[webkit-changes] [192863] trunk/Source/JavaScriptCore
Title: [192863] trunk/Source/_javascript_Core Revision 192863 Author fpi...@apple.com Date 2015-11-30 23:03:55 -0800 (Mon, 30 Nov 2015) Log Message B3::ValueRep::Any should translate into a Arg::ColdUse role in Air https://bugs.webkit.org/show_bug.cgi?id=151174 Reviewed by Geoffrey Garen and Benjamin Poulain. This teaches the register allocator that it should pick spills based on whichever tmp has the highest score: score(tmp) = degree(tmp) / sum(for each use of tmp, block->frequency) In other words, the numerator is the number of edges in the inteference graph and the denominator is an estimate of the dynamic number of uses. This also extends Arg::Role to know that there is such a thing as ColdUse, i.e. a Use that doesn't count as such for the above formula. Because LateUse is always used in contexts where we want it to be Cold, I've defined LateUse to imply ColdUse. This gets rid of all spilling inside the hot loop in Kraken/imaging-gaussian-blur. But more importantly, it makes our register allocator use a well-known heuristic based on reusable building blocks like the new Air::UseCounts. Even if the heuristic is slightly wrong, the right heuristic probably uses the same building blocks. * _javascript_Core.xcodeproj/project.pbxproj: * b3/B3StackmapSpecial.cpp: (JSC::B3::StackmapSpecial::forEachArgImpl): * b3/B3ValueRep.h: * b3/air/AirArg.cpp: (WTF::printInternal): * b3/air/AirArg.h: (JSC::B3::Air::Arg::isAnyUse): (JSC::B3::Air::Arg::isColdUse): (JSC::B3::Air::Arg::isWarmUse): (JSC::B3::Air::Arg::isEarlyUse): (JSC::B3::Air::Arg::isDef): * b3/air/AirIteratedRegisterCoalescing.cpp: (JSC::B3::Air::iteratedRegisterCoalescing): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::IteratedRegisterCoalescingAllocator): Deleted. (JSC::B3::Air::IteratedRegisterCoalescingAllocator::allocatedReg): Deleted. (JSC::B3::Air::IteratedRegisterCoalescingAllocator::tmpArraySize): Deleted. (JSC::B3::Air::IteratedRegisterCoalescingAllocator::initializeDegrees): Deleted. (JSC::B3::Air::IteratedRegisterCoalescingAllocator::build): Deleted. (JSC::B3::Air::IteratedRegisterCoalescingAllocator::selectSpill): Deleted. (JSC::B3::Air::isUselessMoveInst): Deleted. (JSC::B3::Air::assignRegisterToTmpInProgram): Deleted. (JSC::B3::Air::addSpillAndFillToProgram): Deleted. (JSC::B3::Air::iteratedRegisterCoalescingOnType): Deleted. * b3/air/AirLiveness.h: * b3/air/AirSpillEverything.cpp: (JSC::B3::Air::spillEverything): * b3/air/AirUseCounts.h: Added. (JSC::B3::Air::UseCounts::Counts::dump): (JSC::B3::Air::UseCounts::UseCounts): (JSC::B3::Air::UseCounts::operator[]): (JSC::B3::Air::UseCounts::dump): * runtime/Options.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/b3/B3StackmapSpecial.cpp trunk/Source/_javascript_Core/b3/B3ValueRep.h trunk/Source/_javascript_Core/b3/air/AirArg.cpp trunk/Source/_javascript_Core/b3/air/AirArg.h trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp trunk/Source/_javascript_Core/b3/air/AirLiveness.h trunk/Source/_javascript_Core/b3/air/AirSpillEverything.cpp trunk/Source/_javascript_Core/runtime/Options.h Added Paths trunk/Source/_javascript_Core/b3/air/AirUseCounts.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (192862 => 192863) --- trunk/Source/_javascript_Core/ChangeLog 2015-12-01 06:58:44 UTC (rev 192862) +++ trunk/Source/_javascript_Core/ChangeLog 2015-12-01 07:03:55 UTC (rev 192863) @@ -1,3 +1,61 @@ +2015-11-30 Filip Pizlo + +B3::ValueRep::Any should translate into a Arg::ColdUse role in Air +https://bugs.webkit.org/show_bug.cgi?id=151174 + +Reviewed by Geoffrey Garen and Benjamin Poulain. + +This teaches the register allocator that it should pick spills based on whichever tmp has the +highest score: + +score(tmp) = degree(tmp) / sum(for each use of tmp, block->frequency) + +In other words, the numerator is the number of edges in the inteference graph and the denominator +is an estimate of the dynamic number of uses. + +This also extends Arg::Role to know that there is such a thing as ColdUse, i.e. a Use that +doesn't count as such for the above formula. Because LateUse is always used in contexts where we +want it to be Cold, I've defined LateUse to imply ColdUse. + +This gets rid of all spilling inside the hot loop in Kraken/imaging-gaussian-blur. But more +importantly, it makes our register allocator use a well-known heuristic based on reusable +building blocks like the new Air::UseCounts. Even if the heuristic is slightly wrong, the right +heuristic probably uses the same building blocks. + +* _javascript_Core.xcodeproj/project.pbxproj: +* b3/B3StackmapSpecial.cpp: +(JSC::B3::StackmapSpecial::forEachArgImpl): +* b3/B3ValueRep.h: +* b3/air/AirArg.cpp: +(WTF::print
[webkit-changes] [192862] trunk/Source/JavaScriptCore
Title: [192862] trunk/Source/_javascript_Core Revision 192862 Author o...@webkit.org Date 2015-11-30 22:58:44 -0800 (Mon, 30 Nov 2015) Log Message Fix the !ENABLE(DFG_JIT) build after r192699 https://bugs.webkit.org/show_bug.cgi?id=151616 Reviewed by Darin Adler. * assembler/MacroAssembler.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssembler.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (192861 => 192862) --- trunk/Source/_javascript_Core/ChangeLog 2015-12-01 06:46:49 UTC (rev 192861) +++ trunk/Source/_javascript_Core/ChangeLog 2015-12-01 06:58:44 UTC (rev 192862) @@ -1,3 +1,12 @@ +2015-11-30 Csaba Osztrogonác + +Fix the !ENABLE(DFG_JIT) build after r192699 +https://bugs.webkit.org/show_bug.cgi?id=151616 + +Reviewed by Darin Adler. + +* assembler/MacroAssembler.h: + 2015-11-30 Yusuke Suzuki Object::{freeze, seal} perform preventExtensionsTransition twice Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (192861 => 192862) --- trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2015-12-01 06:46:49 UTC (rev 192861) +++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2015-12-01 06:58:44 UTC (rev 192862) @@ -1301,6 +1301,7 @@ #endif // !CPU(X86_64) +#if ENABLE(B3_JIT) template void moveDoubleConditionally32(RelationalCondition cond, LeftType left, RightType right, FPRegisterID src, FPRegisterID dest) { @@ -1355,6 +1356,7 @@ moveDouble(src, dest); falseCase.link(this); } +#endif void lea(Address address, RegisterID dest) { ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192861] trunk/Websites/webkit.org
Title: [192861] trunk/Websites/webkit.org Revision 192861 Author j...@apple.com Date 2015-11-30 22:46:49 -0800 (Mon, 30 Nov 2015) Log Message Set max-height to prevent narrow images from upscaling. * wp-content/themes/webkit/style.css: (article figure > img): (figure.widescreen): (figure.widescreen figcaption): (figure.widescreen img): Deleted. Modified Paths trunk/Websites/webkit.org/ChangeLog trunk/Websites/webkit.org/wp-content/themes/webkit/style.css Diff Modified: trunk/Websites/webkit.org/ChangeLog (192860 => 192861) --- trunk/Websites/webkit.org/ChangeLog 2015-12-01 05:34:07 UTC (rev 192860) +++ trunk/Websites/webkit.org/ChangeLog 2015-12-01 06:46:49 UTC (rev 192861) @@ -1,5 +1,15 @@ 2015-11-30 Jonathan Davis +Set max-height to prevent narrow images from upscaling. + +* wp-content/themes/webkit/style.css: +(article figure > img): +(figure.widescreen): +(figure.widescreen figcaption): +(figure.widescreen img): Deleted. + +2015-11-30 Jonathan Davis + Added a new theme and plugins for a redesigned webkit.org. Reviewed by Timothy Hatcher. Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/style.css (192860 => 192861) --- trunk/Websites/webkit.org/wp-content/themes/webkit/style.css 2015-12-01 05:34:07 UTC (rev 192860) +++ trunk/Websites/webkit.org/wp-content/themes/webkit/style.css 2015-12-01 06:46:49 UTC (rev 192861) @@ -1057,6 +1057,8 @@ article figure > img { display: inline-block; max-width: 100%; +max-height: 540px; +height: auto; } figure.widescreen { @@ -1072,11 +1074,6 @@ margin: 0 auto; } -figure.widescreen img { -max-width: 100%; -height: auto; -} - figure.widescreen figcaption { margin-top: 3rem; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192859] trunk/LayoutTests
Title: [192859] trunk/LayoutTests Revision 192859 Author beid...@apple.com Date 2015-11-30 21:20:15 -0800 (Mon, 30 Nov 2015) Log Message Modern IDB: Unskip "storage/indexeddb/mozilla" instead of each individual test inside of it. https://bugs.webkit.org/show_bug.cgi?id=151693 Reviewed by Geoffrey Garen. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (192858 => 192859) --- trunk/LayoutTests/ChangeLog 2015-12-01 05:15:45 UTC (rev 192858) +++ trunk/LayoutTests/ChangeLog 2015-12-01 05:20:15 UTC (rev 192859) @@ -1,3 +1,12 @@ +2015-11-30 Brady Eidson + +Modern IDB: Unskip "storage/indexeddb/mozilla" instead of each individual test inside of it. +https://bugs.webkit.org/show_bug.cgi?id=151693 + +Reviewed by Geoffrey Garen. + +* platform/mac-wk1/TestExpectations: + 2015-11-30 Jiewen Tan Amazon.com Additional Information links aren't clickable Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192858 => 192859) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-01 05:15:45 UTC (rev 192858) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-01 05:20:15 UTC (rev 192859) @@ -75,42 +75,7 @@ storage/indexeddb/cursor-cast.html [ Pass ] storage/indexeddb/cursor-finished.html [ Pass ] storage/indexeddb/modern [ Pass ] -storage/indexeddb/mozilla/add-twice-failure.html [ Pass ] -storage/indexeddb/mozilla/autoincrement-indexes.html [ Pass ] -storage/indexeddb/mozilla/bad-keypath.html [ Pass ] -storage/indexeddb/mozilla/clear.html [ Pass ] -storage/indexeddb/mozilla/create-index-unique.html [ Pass ] -storage/indexeddb/mozilla/create-index-with-integer-keys.html [ Pass ] -storage/indexeddb/mozilla/create-objectstore-basics.html [ Pass ] -storage/indexeddb/mozilla/create-objectstore-null-name.html [ Pass ] -storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html [ Pass ] -storage/indexeddb/mozilla/cursor-mutation.html [ Pass ] -storage/indexeddb/mozilla/cursor-update-updates-indexes.html [ Pass ] -storage/indexeddb/mozilla/cursors.html [ Pass ] -storage/indexeddb/mozilla/delete-result.html [ Pass ] -storage/indexeddb/mozilla/event-source.html [ Pass ] -storage/indexeddb/mozilla/global-data.html [ Pass ] -storage/indexeddb/mozilla/index-prev-no-duplicate.html [ Pass ] -storage/indexeddb/mozilla/indexes.html [ Pass ] -storage/indexeddb/mozilla/key-requirements-delete-null-key.html [ Pass ] -storage/indexeddb/mozilla/key-requirements-inline-and-passed.html [ Pass ] -storage/indexeddb/mozilla/key-requirements-put-no-key.html [ Pass ] -storage/indexeddb/mozilla/key-requirements-put-null-key.html [ Pass ] -storage/indexeddb/mozilla/key-requirements.html [ Pass ] -storage/indexeddb/mozilla/object-cursors.html [ Pass ] -storage/indexeddb/mozilla/object-identity.html [ Pass ] -storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html [ Pass ] -storage/indexeddb/mozilla/object-store-remove-values.html [ Pass ] -storage/indexeddb/mozilla/objectstorenames.html [ Pass ] -storage/indexeddb/mozilla/odd-result-order.html [ Pass ] -storage/indexeddb/mozilla/open-database-null-name.html [ Pass ] -storage/indexeddb/mozilla/put-get-values.html [ Pass ] -storage/indexeddb/mozilla/readonly-transactions.html [ Pass ] -storage/indexeddb/mozilla/readwrite-transactions.html [ Pass ] -storage/indexeddb/mozilla/readyState.html [ Pass ] -storage/indexeddb/mozilla/remove-index.html [ Pass ] -storage/indexeddb/mozilla/remove-objectstore.html [ Pass ] -storage/indexeddb/mozilla/versionchange-abort.html [ Pass ] +storage/indexeddb/mozilla [ Pass ] # Fails with WebKit1 only. editing/secure-input/reset-state-on-navigation.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192857] trunk/Source/JavaScriptCore
Title: [192857] trunk/Source/_javascript_Core Revision 192857 Author benja...@webkit.org Date 2015-11-30 20:59:02 -0800 (Mon, 30 Nov 2015) Log Message [JSC] Add Sqrt to B3 https://bugs.webkit.org/show_bug.cgi?id=151692 Patch by Benjamin Poulain on 2015-11-30 Reviewed by Geoffrey Garen. * assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::sqrtDouble): * assembler/X86Assembler.h: (JSC::X86Assembler::sqrtsd_mr): * b3/B3LowerToAir.cpp: (JSC::B3::Air::LowerToAir::lower): * b3/B3Opcode.cpp: (WTF::printInternal): * b3/B3Opcode.h: * b3/B3Validate.cpp: * b3/B3Value.cpp: (JSC::B3::Value::effects): (JSC::B3::Value::key): (JSC::B3::Value::typeFor): * b3/air/AirOpcode.opcodes: * b3/testb3.cpp: (JSC::B3::testSqrtArg): (JSC::B3::testSqrtImm): (JSC::B3::testSqrtMem): (JSC::B3::run): * ftl/FTLB3Output.h: (JSC::FTL::Output::doubleSqrt): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h trunk/Source/_javascript_Core/assembler/X86Assembler.h trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp trunk/Source/_javascript_Core/b3/B3Opcode.cpp trunk/Source/_javascript_Core/b3/B3Opcode.h trunk/Source/_javascript_Core/b3/B3Validate.cpp trunk/Source/_javascript_Core/b3/B3Value.cpp trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes trunk/Source/_javascript_Core/b3/testb3.cpp trunk/Source/_javascript_Core/ftl/FTLB3Output.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (192856 => 192857) --- trunk/Source/_javascript_Core/ChangeLog 2015-12-01 04:43:28 UTC (rev 192856) +++ trunk/Source/_javascript_Core/ChangeLog 2015-12-01 04:59:02 UTC (rev 192857) @@ -1,3 +1,33 @@ +2015-11-30 Benjamin Poulain + +[JSC] Add Sqrt to B3 +https://bugs.webkit.org/show_bug.cgi?id=151692 + +Reviewed by Geoffrey Garen. + +* assembler/MacroAssemblerX86Common.h: +(JSC::MacroAssemblerX86Common::sqrtDouble): +* assembler/X86Assembler.h: +(JSC::X86Assembler::sqrtsd_mr): +* b3/B3LowerToAir.cpp: +(JSC::B3::Air::LowerToAir::lower): +* b3/B3Opcode.cpp: +(WTF::printInternal): +* b3/B3Opcode.h: +* b3/B3Validate.cpp: +* b3/B3Value.cpp: +(JSC::B3::Value::effects): +(JSC::B3::Value::key): +(JSC::B3::Value::typeFor): +* b3/air/AirOpcode.opcodes: +* b3/testb3.cpp: +(JSC::B3::testSqrtArg): +(JSC::B3::testSqrtImm): +(JSC::B3::testSqrtMem): +(JSC::B3::run): +* ftl/FTLB3Output.h: +(JSC::FTL::Output::doubleSqrt): + 2015-11-30 Filip Pizlo FTL lazy slow paths should work with B3 Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h (192856 => 192857) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h 2015-12-01 04:43:28 UTC (rev 192856) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h 2015-12-01 04:59:02 UTC (rev 192857) @@ -505,6 +505,11 @@ m_assembler.sqrtsd_rr(src, dst); } +void sqrtDouble(Address src, FPRegisterID dst) +{ +m_assembler.sqrtsd_mr(src.offset, src.base, dst); +} + void absDouble(FPRegisterID src, FPRegisterID dst) { ASSERT(src != dst); Modified: trunk/Source/_javascript_Core/assembler/X86Assembler.h (192856 => 192857) --- trunk/Source/_javascript_Core/assembler/X86Assembler.h 2015-12-01 04:43:28 UTC (rev 192856) +++ trunk/Source/_javascript_Core/assembler/X86Assembler.h 2015-12-01 04:59:02 UTC (rev 192857) @@ -2137,7 +2137,13 @@ m_formatter.prefix(PRE_SSE_F2); m_formatter.twoByteOp(OP2_SQRTSD_VsdWsd, (RegisterID)dst, (RegisterID)src); } - + +void sqrtsd_mr(int offset, RegisterID base, XMMRegisterID dst) +{ +m_formatter.prefix(PRE_SSE_F2); +m_formatter.twoByteOp(OP2_SQRTSD_VsdWsd, (RegisterID)dst, base, offset); +} + // Misc instructions: void int3() Modified: trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp (192856 => 192857) --- trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp 2015-12-01 04:43:28 UTC (rev 192856) +++ trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp 2015-12-01 04:59:02 UTC (rev 192857) @@ -1463,6 +1463,11 @@ return; } +case Sqrt: { +appendUnOp(m_value->child(0)); +return; +} + case BitwiseCast: { appendUnOp(m_value->child(0)); return; Modified: trunk/Source/_javascript_Core/b3/B3Opcode.cpp (192856 => 192857) --- trunk/Source/_javascript_Core/b3/B3Opcode.cpp 2015-12-01 04:43:28 UTC (rev 192856) +++ trunk/Source/_javascript_Core/b3/B3Opcode.cpp 2015-12-01 04:59:02 UTC (rev 192857) @@ -137,6 +137,9 @@ case ZShr: out.print("ZShr"); return; +case Sqrt: +out.print("Sqrt"); +return; case BitwiseCast: out.print("BitwiseCast"); return; Modified: trunk/Source/_javascript_C
[webkit-changes] [192856] trunk/Source/JavaScriptCore
Title: [192856] trunk/Source/_javascript_Core Revision 192856 Author fpi...@apple.com Date 2015-11-30 20:43:28 -0800 (Mon, 30 Nov 2015) Log Message FTL lazy slow paths should work with B3 https://bugs.webkit.org/show_bug.cgi?id=151667 Reviewed by Geoffrey Garen. This adds all of the glue necessary to make FTL::LazySlowPath work with B3. The B3 approach allows us to put all of the code in FTL::LowerDFGToLLVM, instead of having supporting data structures on the side and a bunch of complex code in FTLCompile.cpp. * b3/B3CheckSpecial.cpp: (JSC::B3::CheckSpecial::generate): * b3/B3LowerToAir.cpp: (JSC::B3::Air::LowerToAir::run): * b3/B3PatchpointSpecial.cpp: (JSC::B3::PatchpointSpecial::generate): * b3/B3StackmapValue.h: * ftl/FTLJSTailCall.cpp: (JSC::FTL::DFG::recoveryFor): (JSC::FTL::JSTailCall::emit): * ftl/FTLLazySlowPath.cpp: (JSC::FTL::LazySlowPath::LazySlowPath): (JSC::FTL::LazySlowPath::generate): * ftl/FTLLazySlowPath.h: (JSC::FTL::LazySlowPath::createGenerator): (JSC::FTL::LazySlowPath::patchableJump): (JSC::FTL::LazySlowPath::done): (JSC::FTL::LazySlowPath::patchpoint): (JSC::FTL::LazySlowPath::usedRegisters): (JSC::FTL::LazySlowPath::callSiteIndex): (JSC::FTL::LazySlowPath::stub): * ftl/FTLLocation.cpp: (JSC::FTL::Location::forValueRep): (JSC::FTL::Location::forStackmaps): (JSC::FTL::Location::dump): (JSC::FTL::Location::isGPR): (JSC::FTL::Location::gpr): (JSC::FTL::Location::isFPR): (JSC::FTL::Location::fpr): (JSC::FTL::Location::restoreInto): * ftl/FTLLocation.h: (JSC::FTL::Location::Location): (JSC::FTL::Location::forRegister): (JSC::FTL::Location::forIndirect): (JSC::FTL::Location::forConstant): (JSC::FTL::Location::kind): (JSC::FTL::Location::hasReg): (JSC::FTL::Location::reg): (JSC::FTL::Location::hasOffset): (JSC::FTL::Location::offset): (JSC::FTL::Location::hash): (JSC::FTL::Location::hasDwarfRegNum): Deleted. (JSC::FTL::Location::dwarfRegNum): Deleted. (JSC::FTL::Location::hasDwarfReg): Deleted. (JSC::FTL::Location::dwarfReg): Deleted. * ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::DFG::LowerDFGToLLVM::LowerDFGToLLVM): (JSC::FTL::DFG::LowerDFGToLLVM::lazySlowPath): * jit/RegisterSet.cpp: (JSC::RegisterSet::stubUnavailableRegisters): (JSC::RegisterSet::macroScratchRegisters): (JSC::RegisterSet::calleeSaveRegisters): * jit/RegisterSet.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/b3/B3CheckSpecial.cpp trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp trunk/Source/_javascript_Core/b3/B3PatchpointSpecial.cpp trunk/Source/_javascript_Core/b3/B3StackmapValue.h trunk/Source/_javascript_Core/ftl/FTLJSTailCall.cpp trunk/Source/_javascript_Core/ftl/FTLLazySlowPath.cpp trunk/Source/_javascript_Core/ftl/FTLLazySlowPath.h trunk/Source/_javascript_Core/ftl/FTLLocation.cpp trunk/Source/_javascript_Core/ftl/FTLLocation.h trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp trunk/Source/_javascript_Core/jit/RegisterSet.cpp trunk/Source/_javascript_Core/jit/RegisterSet.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (192855 => 192856) --- trunk/Source/_javascript_Core/ChangeLog 2015-12-01 03:39:59 UTC (rev 192855) +++ trunk/Source/_javascript_Core/ChangeLog 2015-12-01 04:43:28 UTC (rev 192856) @@ -1,3 +1,68 @@ +2015-11-30 Filip Pizlo + +FTL lazy slow paths should work with B3 +https://bugs.webkit.org/show_bug.cgi?id=151667 + +Reviewed by Geoffrey Garen. + +This adds all of the glue necessary to make FTL::LazySlowPath work with B3. The B3 approach +allows us to put all of the code in FTL::LowerDFGToLLVM, instead of having supporting data +structures on the side and a bunch of complex code in FTLCompile.cpp. + +* b3/B3CheckSpecial.cpp: +(JSC::B3::CheckSpecial::generate): +* b3/B3LowerToAir.cpp: +(JSC::B3::Air::LowerToAir::run): +* b3/B3PatchpointSpecial.cpp: +(JSC::B3::PatchpointSpecial::generate): +* b3/B3StackmapValue.h: +* ftl/FTLJSTailCall.cpp: +(JSC::FTL::DFG::recoveryFor): +(JSC::FTL::JSTailCall::emit): +* ftl/FTLLazySlowPath.cpp: +(JSC::FTL::LazySlowPath::LazySlowPath): +(JSC::FTL::LazySlowPath::generate): +* ftl/FTLLazySlowPath.h: +(JSC::FTL::LazySlowPath::createGenerator): +(JSC::FTL::LazySlowPath::patchableJump): +(JSC::FTL::LazySlowPath::done): +(JSC::FTL::LazySlowPath::patchpoint): +(JSC::FTL::LazySlowPath::usedRegisters): +(JSC::FTL::LazySlowPath::callSiteIndex): +(JSC::FTL::LazySlowPath::stub): +* ftl/FTLLocation.cpp: +(JSC::FTL::Location::forValueRep): +(JSC::FTL::Location::forStackmaps): +(JSC::FTL::Location::dump): +(JSC::FTL::Location::isGPR): +(JSC::FTL::Location::gpr): +(JSC::FTL::Location::isFPR): +(JSC::FTL::Location::fpr): +(JSC::FTL::Location::restoreInto): +* ftl/FTLLocation.h: +(JSC::FTL::Location::Location): +
[webkit-changes] [192855] trunk/Source
Title: [192855] trunk/Source Revision 192855 Author gga...@apple.com Date 2015-11-30 19:39:59 -0800 (Mon, 30 Nov 2015) Log Message Use a better RNG for Math.random() https://bugs.webkit.org/show_bug.cgi?id=151641 Reviewed by Anders Carlsson. Source/_javascript_Core: Updated for interface change. * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::setInputCursor): Source/WTF: Use 64 bits in the random number generator instead of 32 bit. (In the end, _javascript_, which uses doubles, will only see 52 bits.) This prevents programs that mulitply a random number by a large constant from seeing non-random "banding" caused by zeroes in the low 20 bits. I also took the opportunity to upgrade from GameRandom to Xorshift+, since Xorshift+ passes more benchmarks for randomness, and is not any slower or more complicated. Now let us all remember the fateful words of Steve Weibe, who would be King of Kong: "The randomness went the opposite way that it usually goes." * wtf/WeakRandom.h: (WTF::WeakRandom::WeakRandom): (WTF::WeakRandom::setSeed): Use standard naming. (WTF::WeakRandom::seed): This function is safe now. "Unsafe" in function names makes me itch. (WTF::WeakRandom::get): (WTF::WeakRandom::getUint32): Update to 64bit. (WTF::WeakRandom::advance): The Xorshift+ algorithm. (WTF::WeakRandom::initializeSeed): Deleted. (WTF::WeakRandom::seedUnsafe): Deleted. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/WeakRandom.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (192854 => 192855) --- trunk/Source/_javascript_Core/ChangeLog 2015-12-01 02:53:25 UTC (rev 192854) +++ trunk/Source/_javascript_Core/ChangeLog 2015-12-01 03:39:59 UTC (rev 192855) @@ -1,3 +1,15 @@ +2015-11-30 Geoffrey Garen + +Use a better RNG for Math.random() +https://bugs.webkit.org/show_bug.cgi?id=151641 + +Reviewed by Anders Carlsson. + +Updated for interface change. + +* runtime/JSGlobalObject.cpp: +(JSC::JSGlobalObject::setInputCursor): + 2015-11-30 Benjamin Poulain [JSC] Speed up Air Liveness Analysis on Tmps Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp (192854 => 192855) --- trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp 2015-12-01 02:53:25 UTC (rev 192854) +++ trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp 2015-12-01 03:39:59 UTC (rev 192855) @@ -1014,10 +1014,10 @@ // Save or set the random seed. This performed here rather than the constructor // to avoid threading the input cursor through all the abstraction layers. if (cursor.isCapturing()) -cursor.appendInput(m_weakRandom.seedUnsafe()); +cursor.appendInput(m_weakRandom.seed()); else if (cursor.isReplaying()) { if (SetRandomSeed* input = cursor.fetchInput()) -m_weakRandom.initializeSeed(static_cast(input->randomSeed())); +m_weakRandom.setSeed(static_cast(input->randomSeed())); } } #endif Modified: trunk/Source/WTF/ChangeLog (192854 => 192855) --- trunk/Source/WTF/ChangeLog 2015-12-01 02:53:25 UTC (rev 192854) +++ trunk/Source/WTF/ChangeLog 2015-12-01 03:39:59 UTC (rev 192855) @@ -1,3 +1,37 @@ +2015-11-30 Geoffrey Garen + +Use a better RNG for Math.random() +https://bugs.webkit.org/show_bug.cgi?id=151641 + +Reviewed by Anders Carlsson. + +Use 64 bits in the random number generator instead of 32 bit. (In +the end, _javascript_, which uses doubles, will only see 52 bits.) This +prevents programs that mulitply a random number by a large constant from +seeing non-random "banding" caused by zeroes in the low 20 bits. + +I also took the opportunity to upgrade from GameRandom to Xorshift+, +since Xorshift+ passes more benchmarks for randomness, and is not any +slower or more complicated. + +Now let us all remember the fateful words of Steve Weibe, who would be +King of Kong: "The randomness went the opposite way that it usually goes." + +* wtf/WeakRandom.h: +(WTF::WeakRandom::WeakRandom): +(WTF::WeakRandom::setSeed): Use standard naming. + +(WTF::WeakRandom::seed): This function is safe now. "Unsafe" in function +names makes me itch. + +(WTF::WeakRandom::get): +(WTF::WeakRandom::getUint32): Update to 64bit. + +(WTF::WeakRandom::advance): The Xorshift+ algorithm. + +(WTF::WeakRandom::initializeSeed): Deleted. +(WTF::WeakRandom::seedUnsafe): Deleted. + 2015-11-30 Benjamin Poulain [JSC] Speed up Air Liveness Analysis on Tmps Modified: trunk/Source/WTF/wtf/WeakRandom.h (192854 => 192855) --- trunk/Source/WTF/wtf/WeakRandom.h 2015-12-01 02:53:25 UTC (rev 192854) +++ trunk/Source/WTF/wtf/WeakRandom.h 2015-12-01 03:39:59 UTC (rev 192855) @@ -22,76 +22,57 @@ * (INCLUDING NEGLIGENC
[webkit-changes] [192854] trunk
Title: [192854] trunk Revision 192854 Author jiewen_...@apple.com Date 2015-11-30 18:53:25 -0800 (Mon, 30 Nov 2015) Log Message Amazon.com Additional Information links aren't clickable https://bugs.webkit.org/show_bug.cgi?id=151401 Reviewed by Darin Adler. Source/WebCore: The cause of this issue is that the painting order is different from the hittest order so we can end up with visible but unreachable content. To fix this, the executation flow of hittest has been reordered. According to the paint system, which renders the webpage from the bottom RenderLayer to the top, contents are rendered before floats. Hence, for the hittest, which determines the hitted location from top RenderLayer to the bottom, should do it reversedly. Now, hittest will first test floats then contents. Test: fast/block/float/hit-test-on-overlapping-floats.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): LayoutTests: * fast/block/float/hit-test-on-overlapping-floats-expected.txt: Added. * fast/block/float/hit-test-on-overlapping-floats.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBlock.cpp Added Paths trunk/LayoutTests/fast/block/float/hit-test-on-overlapping-floats-expected.txt trunk/LayoutTests/fast/block/float/hit-test-on-overlapping-floats.html Diff Modified: trunk/LayoutTests/ChangeLog (192853 => 192854) --- trunk/LayoutTests/ChangeLog 2015-12-01 02:46:09 UTC (rev 192853) +++ trunk/LayoutTests/ChangeLog 2015-12-01 02:53:25 UTC (rev 192854) @@ -1,3 +1,14 @@ +2015-11-30 Jiewen Tan + +Amazon.com Additional Information links aren't clickable +https://bugs.webkit.org/show_bug.cgi?id=151401 + + +Reviewed by Darin Adler. + +* fast/block/float/hit-test-on-overlapping-floats-expected.txt: Added. +* fast/block/float/hit-test-on-overlapping-floats.html: Added. + 2015-11-30 Brady Eidson Modern IDB: Iterating index cursors to a specific key is busted. Added: trunk/LayoutTests/fast/block/float/hit-test-on-overlapping-floats-expected.txt (0 => 192854) --- trunk/LayoutTests/fast/block/float/hit-test-on-overlapping-floats-expected.txt (rev 0) +++ trunk/LayoutTests/fast/block/float/hit-test-on-overlapping-floats-expected.txt 2015-12-01 02:53:25 UTC (rev 192854) @@ -0,0 +1,6 @@ +PASS document.elementFromPoint(450, 10) is document.getElementById('rightc') +PASS successfullyParsed is true + +TEST COMPLETE +foobar + Added: trunk/LayoutTests/fast/block/float/hit-test-on-overlapping-floats.html (0 => 192854) --- trunk/LayoutTests/fast/block/float/hit-test-on-overlapping-floats.html (rev 0) +++ trunk/LayoutTests/fast/block/float/hit-test-on-overlapping-floats.html 2015-12-01 02:53:25 UTC (rev 192854) @@ -0,0 +1,32 @@ + + + + +#leftc { +float: left; +width: 500px; +background-color: silver; +margin-right: -100px; +} + +#rightc { +float: right; +width: 400px; +background-color: rgba(0, 128, 0, 0.75); +padding-bottom: 1px; +} + + + + +foo +bar + + + +shouldBe("document.elementFromPoint(450, 10)", "document.getElementById('rightc')"); + +
[webkit-changes] [192853] trunk/Source/WebCore
Title: [192853] trunk/Source/WebCore Revision 192853 Author simon.fra...@apple.com Date 2015-11-30 18:46:09 -0800 (Mon, 30 Nov 2015) Log Message Fix possible crash with animated layers in reflections https://bugs.webkit.org/show_bug.cgi?id=151689 rdar://problem/23018612 Reviewed by Darin Adler. Reflections create additional PlatformCALayers whose owner is set to the GraphicsLayerCA. Those PlatformCALayers need their owner pointer cleared out when the GraphicsLayerCA is destroyed. Tested by compositing/reflections/nested-reflection-transition.html * platform/graphics/ca/GraphicsLayerCA.cpp: * platform/graphics/ca/GraphicsLayerCA.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h Diff Modified: trunk/Source/WebCore/ChangeLog (192852 => 192853) --- trunk/Source/WebCore/ChangeLog 2015-12-01 02:29:18 UTC (rev 192852) +++ trunk/Source/WebCore/ChangeLog 2015-12-01 02:46:09 UTC (rev 192853) @@ -1,3 +1,20 @@ +2015-11-30 Simon Fraser + +Fix possible crash with animated layers in reflections +https://bugs.webkit.org/show_bug.cgi?id=151689 +rdar://problem/23018612 + +Reviewed by Darin Adler. + +Reflections create additional PlatformCALayers whose owner is set to the GraphicsLayerCA. +Those PlatformCALayers need their owner pointer cleared out when the GraphicsLayerCA +is destroyed. + +Tested by compositing/reflections/nested-reflection-transition.html + +* platform/graphics/ca/GraphicsLayerCA.cpp: +* platform/graphics/ca/GraphicsLayerCA.h: + 2015-11-30 Brady Eidson Modern IDB: Iterating index cursors to a specific key is busted. Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (192852 => 192853) --- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2015-12-01 02:29:18 UTC (rev 192852) +++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2015-12-01 02:46:09 UTC (rev 192853) @@ -3486,14 +3486,25 @@ shapeMaskLayer = findOrMakeClone(cloneID, m_shapeMaskLayer.get(), m_shapeMaskLayerClones.get(), cloneLevel); } +void GraphicsLayerCA::clearClones(std::unique_ptr& layerMap) +{ +if (!layerMap) +return; + +for (auto& layer : layerMap->values()) +layer->setOwner(nullptr); + +layerMap = nullptr; +} + void GraphicsLayerCA::removeCloneLayers() { -m_layerClones = nullptr; -m_structuralLayerClones = nullptr; -m_contentsLayerClones = nullptr; -m_contentsClippingLayerClones = nullptr; -m_contentsShapeMaskLayerClones = nullptr; -m_shapeMaskLayerClones = nullptr; +clearClones(m_layerClones); +clearClones(m_structuralLayerClones); +clearClones(m_contentsLayerClones); +clearClones(m_contentsClippingLayerClones); +clearClones(m_contentsShapeMaskLayerClones); +clearClones(m_shapeMaskLayerClones); } FloatPoint GraphicsLayerCA::positionForCloneRootLayer() const Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h (192852 => 192853) --- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h 2015-12-01 02:29:18 UTC (rev 192852) +++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h 2015-12-01 02:46:09 UTC (rev 192853) @@ -365,6 +365,8 @@ void ensureCloneLayers(CloneID, RefPtr& primaryLayer, RefPtr& structuralLayer, RefPtr& contentsLayer, RefPtr& contentsClippingLayer, RefPtr& contentsShapeMaskLayer, RefPtr& shapeMaskLayer, CloneLevel); +static void clearClones(std::unique_ptr&); + bool hasCloneLayers() const { return !!m_layerClones; } void removeCloneLayers(); FloatPoint positionForCloneRootLayer() const; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192852] trunk
Title: [192852] trunk Revision 192852 Author beid...@apple.com Date 2015-11-30 18:29:18 -0800 (Mon, 30 Nov 2015) Log Message Modern IDB: Iterating index cursors to a specific key is busted. https://bugs.webkit.org/show_bug.cgi?id=151684 Reviewed by Darin Adler. Source/WebCore: No new tests (At least one failing test now passes). * Modules/indexeddb/server/MemoryIndexCursor.cpp: (WebCore::IDBServer::MemoryIndexCursor::iterate): LayoutTests: * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp Diff Modified: trunk/LayoutTests/ChangeLog (192851 => 192852) --- trunk/LayoutTests/ChangeLog 2015-12-01 02:26:57 UTC (rev 192851) +++ trunk/LayoutTests/ChangeLog 2015-12-01 02:29:18 UTC (rev 192852) @@ -1,5 +1,14 @@ 2015-11-30 Brady Eidson +Modern IDB: Iterating index cursors to a specific key is busted. +https://bugs.webkit.org/show_bug.cgi?id=151684 + +Reviewed by Darin Adler. + +* platform/mac-wk1/TestExpectations: + +2015-11-30 Brady Eidson + Modern IDB: ObjectStore cursors should not be able to iterate out of their range. https://bugs.webkit.org/show_bug.cgi?id=151683 Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192851 => 192852) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-01 02:26:57 UTC (rev 192851) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-01 02:29:18 UTC (rev 192852) @@ -91,6 +91,7 @@ storage/indexeddb/mozilla/event-source.html [ Pass ] storage/indexeddb/mozilla/global-data.html [ Pass ] storage/indexeddb/mozilla/index-prev-no-duplicate.html [ Pass ] +storage/indexeddb/mozilla/indexes.html [ Pass ] storage/indexeddb/mozilla/key-requirements-delete-null-key.html [ Pass ] storage/indexeddb/mozilla/key-requirements-inline-and-passed.html [ Pass ] storage/indexeddb/mozilla/key-requirements-put-no-key.html [ Pass ] Modified: trunk/Source/WebCore/ChangeLog (192851 => 192852) --- trunk/Source/WebCore/ChangeLog 2015-12-01 02:26:57 UTC (rev 192851) +++ trunk/Source/WebCore/ChangeLog 2015-12-01 02:29:18 UTC (rev 192852) @@ -1,5 +1,17 @@ 2015-11-30 Brady Eidson +Modern IDB: Iterating index cursors to a specific key is busted. +https://bugs.webkit.org/show_bug.cgi?id=151684 + +Reviewed by Darin Adler. + +No new tests (At least one failing test now passes). + +* Modules/indexeddb/server/MemoryIndexCursor.cpp: +(WebCore::IDBServer::MemoryIndexCursor::iterate): + +2015-11-30 Brady Eidson + Modern IDB: ObjectStore cursors should not be able to iterate out of their range. https://bugs.webkit.org/show_bug.cgi?id=151683 Modified: trunk/Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp (192851 => 192852) --- trunk/Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp 2015-12-01 02:26:57 UTC (rev 192851) +++ trunk/Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp 2015-12-01 02:29:18 UTC (rev 192852) @@ -88,9 +88,9 @@ } if (m_info.isDirectionForward()) -m_currentIterator = valueStore->find(m_currentKey); +m_currentIterator = valueStore->find(key); else -m_currentIterator = valueStore->reverseFind(m_currentKey, m_info.duplicity()); +m_currentIterator = valueStore->reverseFind(key, m_info.duplicity()); if (!m_currentIterator.isValid()) { m_currentKey = { }; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192851] trunk/Source
Title: [192851] trunk/Source Revision 192851 Author benja...@webkit.org Date 2015-11-30 18:26:57 -0800 (Mon, 30 Nov 2015) Log Message [JSC] Speed up Air Liveness Analysis on Tmps https://bugs.webkit.org/show_bug.cgi?id=151556 Patch by Benjamin Poulain on 2015-11-30 Reviewed by Filip Pizlo. Source/_javascript_Core: Liveness Analysis scales poorly on large graphs like the ones generated by testComplex(). This patch introduces a faster of Liveness using the continuous indices of values instead of the values themselves. There are two main areas of improvements: 1) Reduce the cost of doing a LocalCalc over a BasicBlock. 2) Reduce how many LocalCalc are needed to converge to a solution. Most of the costs of LocalCalc are from HashSet manipulations. The HashSet operations are O(1) but the constant is large enough to be a problem. I used a similar trick as the Register Allocator to remove hashing and collision handling: the absolute value of the Tmp is used as an index into a flat array. I used Briggs's Sparse Set implementation for the local live information at each instruction. It has great properties for doing the local calculation: -No memory reallocation. -O(1) add() and remove() with a small constant. -Strict O(n) iteration. -O(1) clear(). The values Live-At-Head are now stored into a Vector. The Sparse Set is used to maintain the Tmp uniqueness. When forwarding new liveness at head to the predecessor, I start by removing everything that was already in live-at-head. We can assume that any value in that list has already been added to the predecessors. This leaves us with a small-ish number of Tmps to add to live-at-head and to the predecessors. The speed up convergence, I used the same trick as DFG's liveness: keep a set of dirty blocks to process. In practice, all the blocks without back-edges converge quickly, and we only propagate liveness as needed. This patch reduces the time taken by "testComplex(64, 384)" by another 5%. The remaining things to do for Liveness are: -Skip the first block for the fix point (it is often large and doing a local calc on it is useless). -Find a better Data Structure for live-at-tail (updating the HashSet takes > 50% of the total convergence time). * _javascript_Core.xcodeproj/project.pbxproj: * b3/air/AirIteratedRegisterCoalescing.cpp: (JSC::B3::Air::IteratedRegisterCoalescingAllocator::build): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::getAlias): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::getAliasWhenSpilling): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::allocatedReg): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::tmpArraySize): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::initializeDegrees): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::addEdges): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::addEdge): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::makeWorkList): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::simplify): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::forEachAdjacent): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::hasBeenSimplified): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::decrementDegree): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::forEachNodeMoves): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::isMoveRelated): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::enableMovesOnValue): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::precoloredCoalescingHeuristic): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::conservativeHeuristic): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::addWorkList): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::combine): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::freezeMoves): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::selectSpill): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::assignColors): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::dumpInterferenceGraphInDot): (JSC::B3::Air::iteratedRegisterCoalescingOnType): (JSC::B3::Air::iteratedRegisterCoalescing): (JSC::B3::Air::AbsoluteTmpHelper::absoluteIndex): Deleted. (JSC::B3::Air::AbsoluteTmpHelper::tmpFromAbsoluteIndex): Deleted. (JSC::B3::Air::AbsoluteTmpHelper::absoluteIndex): Deleted. (JSC::B3::Air::AbsoluteTmpHelper::tmpFromAbsoluteIndex): Deleted. * b3/air/AirReportUsedRegisters.cpp: (JSC::B3::Air::reportUsedRegisters): * b3/air/AirTmpInlines.h: (JSC::B3::Air::AbsoluteTmpMapper::absoluteIndex): (JSC::B3::Air::AbsoluteTmpMapper::tmpFromAbsoluteIndex): (JSC::B3::Air::AbsoluteTmpMapper::absoluteIndex): (JSC::B3::Air::AbsoluteTmpMapper::tmpFromAbsoluteIndex): * b3/air/AirLiveness.h: Added. Source/WTF: * WTF.xcodeproj/project.pbxproj: * wtf/IndexSparseSet.h: Added. (WTF::IndexSparseSet::IndexSparseSet): (WTF::IndexSparseSet::add): (WTF::IndexSparseSet::remove): (WTF::IndexSparseSet::clear): (WTF::IndexSparseSet::size): (WTF::IndexSparseSet::isEmpty): (WTF::IndexSparseSet::contains): Modified Paths trunk/Sou
[webkit-changes] [192850] trunk
Title: [192850] trunk Revision 192850 Author beid...@apple.com Date 2015-11-30 18:15:47 -0800 (Mon, 30 Nov 2015) Log Message Modern IDB: ObjectStore cursors should not be able to iterate out of their range. https://bugs.webkit.org/show_bug.cgi?id=151683 Reviewed by Darin Adler. Source/WebCore: No new tests (Covered by at least one failing test that now passes). * Modules/indexeddb/server/MemoryObjectStoreCursor.cpp: (WebCore::IDBServer::MemoryObjectStoreCursor::incrementForwardIterator): (WebCore::IDBServer::MemoryObjectStoreCursor::incrementReverseIterator): LayoutTests: * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.cpp Diff Modified: trunk/LayoutTests/ChangeLog (192849 => 192850) --- trunk/LayoutTests/ChangeLog 2015-12-01 02:13:55 UTC (rev 192849) +++ trunk/LayoutTests/ChangeLog 2015-12-01 02:15:47 UTC (rev 192850) @@ -1,5 +1,14 @@ 2015-11-30 Brady Eidson +Modern IDB: ObjectStore cursors should not be able to iterate out of their range. +https://bugs.webkit.org/show_bug.cgi?id=151683 + +Reviewed by Darin Adler. + +* platform/mac-wk1/TestExpectations: + +2015-11-30 Brady Eidson + Modern IDB: "prevunique" cursors should point at the lowest primary key that matches, not the highest. https://bugs.webkit.org/show_bug.cgi?id=151675. Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192849 => 192850) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-01 02:13:55 UTC (rev 192849) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-01 02:15:47 UTC (rev 192850) @@ -86,6 +86,7 @@ storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html [ Pass ] storage/indexeddb/mozilla/cursor-mutation.html [ Pass ] storage/indexeddb/mozilla/cursor-update-updates-indexes.html [ Pass ] +storage/indexeddb/mozilla/cursors.html [ Pass ] storage/indexeddb/mozilla/delete-result.html [ Pass ] storage/indexeddb/mozilla/event-source.html [ Pass ] storage/indexeddb/mozilla/global-data.html [ Pass ] Modified: trunk/Source/WebCore/ChangeLog (192849 => 192850) --- trunk/Source/WebCore/ChangeLog 2015-12-01 02:13:55 UTC (rev 192849) +++ trunk/Source/WebCore/ChangeLog 2015-12-01 02:15:47 UTC (rev 192850) @@ -1,3 +1,16 @@ +2015-11-30 Brady Eidson + +Modern IDB: ObjectStore cursors should not be able to iterate out of their range. +https://bugs.webkit.org/show_bug.cgi?id=151683 + +Reviewed by Darin Adler. + +No new tests (Covered by at least one failing test that now passes). + +* Modules/indexeddb/server/MemoryObjectStoreCursor.cpp: +(WebCore::IDBServer::MemoryObjectStoreCursor::incrementForwardIterator): +(WebCore::IDBServer::MemoryObjectStoreCursor::incrementReverseIterator): + 2015-11-30 Anders Carlsson CTTE autogenerated bindings code Modified: trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.cpp (192849 => 192850) --- trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.cpp 2015-12-01 02:13:55 UTC (rev 192849) +++ trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.cpp 2015-12-01 02:15:47 UTC (rev 192850) @@ -237,8 +237,10 @@ if (*m_forwardIterator == set.end()) return; -if (!m_info.range().containsKey(**m_forwardIterator)) +if (!m_info.range().containsKey(**m_forwardIterator)) { +m_forwardIterator = set.end(); return; +} } } @@ -294,8 +296,10 @@ if (*m_reverseIterator == set.rend()) return; -if (!m_info.range().containsKey(**m_reverseIterator)) +if (!m_info.range().containsKey(**m_reverseIterator)) { +m_reverseIterator = set.rend(); return; +} } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192849] trunk/Source/WebCore
Title: [192849] trunk/Source/WebCore Revision 192849 Author ander...@apple.com Date 2015-11-30 18:13:55 -0800 (Mon, 30 Nov 2015) Log Message CTTE autogenerated bindings code https://bugs.webkit.org/show_bug.cgi?id=151682 Reviewed by Darin Adler. Make sure that JS bindings pass a reference to the object when calling static member functions. * Modules/gamepad/NavigatorGamepad.cpp: (WebCore::NavigatorGamepad::getGamepads): * Modules/gamepad/NavigatorGamepad.h: * Modules/geolocation/NavigatorGeolocation.cpp: (WebCore::NavigatorGeolocation::geolocation): * Modules/geolocation/NavigatorGeolocation.h: * Modules/mediasource/AudioTrackMediaSource.h: (WebCore::AudioTrackMediaSource::sourceBuffer): * Modules/mediasource/TextTrackMediaSource.h: (WebCore::TextTrackMediaSource::sourceBuffer): * Modules/mediasource/VideoTrackMediaSource.h: (WebCore::VideoTrackMediaSource::sourceBuffer): * Modules/mediastream/HTMLMediaElementMediaStream.cpp: (WebCore::HTMLMediaElementMediaStream::srcObject): (WebCore::HTMLMediaElementMediaStream::setSrcObject): * Modules/mediastream/HTMLMediaElementMediaStream.h: * Modules/mediastream/NavigatorMediaDevices.cpp: (WebCore::NavigatorMediaDevices::mediaDevices): * Modules/mediastream/NavigatorMediaDevices.h: * Modules/notifications/DOMWindowNotifications.cpp: (WebCore::DOMWindowNotifications::webkitNotifications): * Modules/notifications/DOMWindowNotifications.h: * Modules/notifications/Notification.cpp: (WebCore::Notification::Notification): * Modules/notifications/WorkerGlobalScopeNotifications.cpp: (WebCore::WorkerGlobalScopeNotifications::webkitNotifications): * Modules/notifications/WorkerGlobalScopeNotifications.h: * Modules/speech/DOMWindowSpeechSynthesis.cpp: (WebCore::DOMWindowSpeechSynthesis::speechSynthesis): * Modules/speech/DOMWindowSpeechSynthesis.h: * Modules/webdatabase/DOMWindowWebDatabase.cpp: (WebCore::DOMWindowWebDatabase::openDatabase): * Modules/webdatabase/DOMWindowWebDatabase.h: * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): (GenerateParametersCheck): * testing/Internals.cpp: (WebCore::Internals::enableMockSpeechSynthesizer): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp trunk/Source/WebCore/Modules/gamepad/NavigatorGamepad.h trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.cpp trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.h trunk/Source/WebCore/Modules/mediasource/AudioTrackMediaSource.h trunk/Source/WebCore/Modules/mediasource/TextTrackMediaSource.h trunk/Source/WebCore/Modules/mediasource/VideoTrackMediaSource.h trunk/Source/WebCore/Modules/mediastream/HTMLMediaElementMediaStream.cpp trunk/Source/WebCore/Modules/mediastream/HTMLMediaElementMediaStream.h trunk/Source/WebCore/Modules/mediastream/NavigatorMediaDevices.cpp trunk/Source/WebCore/Modules/mediastream/NavigatorMediaDevices.h trunk/Source/WebCore/Modules/notifications/DOMWindowNotifications.cpp trunk/Source/WebCore/Modules/notifications/DOMWindowNotifications.h trunk/Source/WebCore/Modules/notifications/Notification.cpp trunk/Source/WebCore/Modules/notifications/WorkerGlobalScopeNotifications.cpp trunk/Source/WebCore/Modules/notifications/WorkerGlobalScopeNotifications.h trunk/Source/WebCore/Modules/speech/DOMWindowSpeechSynthesis.cpp trunk/Source/WebCore/Modules/speech/DOMWindowSpeechSynthesis.h trunk/Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp trunk/Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.h trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp trunk/Source/WebCore/testing/Internals.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (192848 => 192849) --- trunk/Source/WebCore/ChangeLog 2015-12-01 01:55:43 UTC (rev 192848) +++ trunk/Source/WebCore/ChangeLog 2015-12-01 02:13:55 UTC (rev 192849) @@ -1,3 +1,51 @@ +2015-11-30 Anders Carlsson + +CTTE autogenerated bindings code +https://bugs.webkit.org/show_bug.cgi?id=151682 + +Reviewed by Darin Adler. + +Make sure that JS bindings pass a reference to the object when calling static member functions. + +* Modules/gamepad/NavigatorGamepad.cpp: +(WebCore::NavigatorGamepad::getGamepads): +* Modules/gamepad/NavigatorGamepad.h: +* Modules/geolocation/NavigatorGeolocation.cpp: +(WebCore::NavigatorGeolocation::geolocation): +* Modules/geolocation/NavigatorGeolocation.h: +* Modules/mediasource/AudioTrackMediaSource.h: +(WebCore::AudioTrackMediaSource::sourceBuffer): +* Modules/mediasource/TextTrackMediaSource.h: +(WebCore::TextTrackMediaSource::sourceBuffer): +* Modules/mediasource/VideoTrackMediaSource.h: +(WebCore::VideoTrackMediaSource::sourceBuffer): +* Modules/mediastream/HTMLMediaElementMediaStream.cpp: +(WebCore::HTMLMediaElementMediaStream::srcObject): +(WebCore::HTMLMediaElementMediaStream:
[webkit-changes] [192848] trunk/Source
Title: [192848] trunk/Source Revision 192848 Author commit-qu...@webkit.org Date 2015-11-30 17:55:43 -0800 (Mon, 30 Nov 2015) Log Message Rename ActiveDOMObject/DOMWindow PageCacheSuspension code to support more reasons for suspension https://bugs.webkit.org/show_bug.cgi?id=151677 Patch by Katlyn Graff on 2015-11-30 Reviewed by Ryosuke Niwa. Source/WebCore: Simply a refactoring patch, so no new tests. * Modules/encryptedmedia/MediaKeySession.cpp: (WebCore::MediaKeySession::canSuspendForDocumentSuspension): (WebCore::MediaKeySession::canSuspendForPageCache): Deleted. * Modules/encryptedmedia/MediaKeySession.h: * Modules/geolocation/Geolocation.cpp: (WebCore::Geolocation::canSuspendForDocumentSuspension): (WebCore::Geolocation::canSuspendForPageCache): Deleted. * Modules/geolocation/Geolocation.h: * Modules/indexeddb/DOMWindowIndexedDatabase.cpp: (WebCore::DOMWindowIndexedDatabase::disconnectFrameForDocumentSuspension): (WebCore::DOMWindowIndexedDatabase::reconnectFrameFromDocumentSuspension): (WebCore::DOMWindowIndexedDatabase::disconnectFrameForPageCache): Deleted. (WebCore::DOMWindowIndexedDatabase::reconnectFrameFromPageCache): Deleted. * Modules/indexeddb/DOMWindowIndexedDatabase.h: * Modules/indexeddb/client/IDBDatabaseImpl.cpp: (WebCore::IDBClient::IDBDatabase::canSuspendForDocumentSuspension): (WebCore::IDBClient::IDBDatabase::canSuspendForPageCache): Deleted. * Modules/indexeddb/client/IDBDatabaseImpl.h: * Modules/indexeddb/client/IDBRequestImpl.cpp: (WebCore::IDBClient::IDBRequest::canSuspendForDocumentSuspension): (WebCore::IDBClient::IDBRequest::canSuspendForPageCache): Deleted. * Modules/indexeddb/client/IDBRequestImpl.h: * Modules/indexeddb/client/IDBTransactionImpl.cpp: (WebCore::IDBClient::IDBTransaction::canSuspendForDocumentSuspension): (WebCore::IDBClient::IDBTransaction::canSuspendForPageCache): Deleted. * Modules/indexeddb/client/IDBTransactionImpl.h: * Modules/indexeddb/legacy/LegacyDatabase.cpp: (WebCore::LegacyDatabase::canSuspendForDocumentSuspension): (WebCore::LegacyDatabase::canSuspendForPageCache): Deleted. * Modules/indexeddb/legacy/LegacyDatabase.h: * Modules/indexeddb/legacy/LegacyRequest.cpp: (WebCore::LegacyRequest::canSuspendForDocumentSuspension): (WebCore::LegacyRequest::canSuspendForPageCache): Deleted. * Modules/indexeddb/legacy/LegacyRequest.h: * Modules/indexeddb/legacy/LegacyTransaction.cpp: (WebCore::LegacyTransaction::canSuspendForDocumentSuspension): (WebCore::LegacyTransaction::canSuspendForPageCache): Deleted. * Modules/indexeddb/legacy/LegacyTransaction.h: * Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::canSuspendForDocumentSuspension): (WebCore::MediaSource::canSuspendForPageCache): Deleted. * Modules/mediasource/MediaSource.h: * Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::canSuspendForDocumentSuspension): (WebCore::SourceBuffer::canSuspendForPageCache): Deleted. * Modules/mediasource/SourceBuffer.h: * Modules/mediastream/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::canSuspendForDocumentSuspension): (WebCore::MediaStreamTrack::canSuspendForPageCache): Deleted. * Modules/mediastream/MediaStreamTrack.h: * Modules/mediastream/RTCDTMFSender.cpp: (WebCore::RTCDTMFSender::canSuspendForDocumentSuspension): (WebCore::RTCDTMFSender::canSuspendForPageCache): Deleted. * Modules/mediastream/RTCDTMFSender.h: * Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::canSuspendForDocumentSuspension): (WebCore::RTCPeerConnection::canSuspendForPageCache): Deleted. * Modules/mediastream/RTCPeerConnection.h: * Modules/notifications/DOMWindowNotifications.cpp: (WebCore::DOMWindowNotifications::disconnectFrameForDocumentSuspension): (WebCore::DOMWindowNotifications::reconnectFrameFromDocumentSuspension): (WebCore::DOMWindowNotifications::disconnectFrameForPageCache): Deleted. (WebCore::DOMWindowNotifications::reconnectFrameFromPageCache): Deleted. * Modules/notifications/DOMWindowNotifications.h: * Modules/notifications/Notification.cpp: (WebCore::Notification::canSuspendForDocumentSuspension): (WebCore::Notification::canSuspendForPageCache): Deleted. * Modules/notifications/Notification.h: * Modules/notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::canSuspendForDocumentSuspension): (WebCore::NotificationCenter::canSuspendForPageCache): Deleted. * Modules/notifications/NotificationCenter.h: * Modules/webaudio/AudioContext.cpp: (WebCore::AudioContext::canSuspendForDocumentSuspension): (WebCore::AudioContext::canSuspendForPageCache): Deleted. * Modules/webaudio/AudioContext.h: * Modules/webdatabase/DatabaseContext.cpp: (WebCore::DatabaseContext::canSuspendForDocumentSuspension): (WebCore::DatabaseContext::canSuspendForPageCache): Deleted. * Modules/webdatabase/DatabaseContext.h: * Modules/websockets/WebSocket.cpp: (WebCore::WebSocket::canSuspendForDocumentSuspension): (WebCore::WebSocket::canSuspendForPageCache): Deleted. * Modules/websockets/WebSocket.h: * css/FontLoader.cpp: (WebCore::FontLoader:
[webkit-changes] [192847] trunk
Title: [192847] trunk Revision 192847 Author beid...@apple.com Date 2015-11-30 17:28:15 -0800 (Mon, 30 Nov 2015) Log Message Modern IDB: "prevunique" cursors should point at the lowest primary key that matches, not the highest. https://bugs.webkit.org/show_bug.cgi?id=151675. Reviewed by Darin Adler. Source/WebCore: No new tests (Covered by at least one failing test that now passes, and updates to previously incorrect tests). * Modules/indexeddb/server/IndexValueEntry.cpp: (WebCore::IDBServer::IndexValueEntry::reverseBegin): If CursorDuplicity is NoDuplicates, start at the lowest entry instead of the highest. (WebCore::IDBServer::IndexValueEntry::reverseFind): * Modules/indexeddb/server/IndexValueEntry.h: * Modules/indexeddb/server/IndexValueStore.cpp: (WebCore::IDBServer::IndexValueStore::reverseFind): (WebCore::IDBServer::IndexValueStore::Iterator::Iterator): (WebCore::IDBServer::IndexValueStore::Iterator::nextIndexEntry): * Modules/indexeddb/server/IndexValueStore.h: * Modules/indexeddb/server/MemoryIndexCursor.cpp: (WebCore::IDBServer::MemoryIndexCursor::MemoryIndexCursor): (WebCore::IDBServer::MemoryIndexCursor::iterate): * Modules/indexeddb/shared/IDBCursorInfo.cpp: (WebCore::IDBCursorInfo::duplicity): (WebCore::IDBCursorInfo::isDirectionNoDuplicate): Deleted. * Modules/indexeddb/shared/IDBCursorInfo.h: LayoutTests: * platform/mac-wk1/TestExpectations: * storage/indexeddb/modern/index-cursor-1-expected.txt: * storage/indexeddb/modern/index-cursor-2-expected.txt: * storage/indexeddb/modern/index-cursor-3-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/LayoutTests/storage/indexeddb/modern/index-cursor-1-expected.txt trunk/LayoutTests/storage/indexeddb/modern/index-cursor-2-expected.txt trunk/LayoutTests/storage/indexeddb/modern/index-cursor-3-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/server/IndexValueEntry.cpp trunk/Source/WebCore/Modules/indexeddb/server/IndexValueEntry.h trunk/Source/WebCore/Modules/indexeddb/server/IndexValueStore.cpp trunk/Source/WebCore/Modules/indexeddb/server/IndexValueStore.h trunk/Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp trunk/Source/WebCore/Modules/indexeddb/shared/IDBCursorInfo.cpp trunk/Source/WebCore/Modules/indexeddb/shared/IDBCursorInfo.h Diff Modified: trunk/LayoutTests/ChangeLog (192846 => 192847) --- trunk/LayoutTests/ChangeLog 2015-12-01 01:05:13 UTC (rev 192846) +++ trunk/LayoutTests/ChangeLog 2015-12-01 01:28:15 UTC (rev 192847) @@ -1,3 +1,15 @@ +2015-11-30 Brady Eidson + +Modern IDB: "prevunique" cursors should point at the lowest primary key that matches, not the highest. +https://bugs.webkit.org/show_bug.cgi?id=151675. + +Reviewed by Darin Adler. + +* platform/mac-wk1/TestExpectations: +* storage/indexeddb/modern/index-cursor-1-expected.txt: +* storage/indexeddb/modern/index-cursor-2-expected.txt: +* storage/indexeddb/modern/index-cursor-3-expected.txt: + 2015-11-30 Jiewen Tan Null dereference loading Blink layout test http/tests/misc/detach-during-notifyDone.html Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192846 => 192847) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-01 01:05:13 UTC (rev 192846) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-01 01:28:15 UTC (rev 192847) @@ -89,6 +89,7 @@ storage/indexeddb/mozilla/delete-result.html [ Pass ] storage/indexeddb/mozilla/event-source.html [ Pass ] storage/indexeddb/mozilla/global-data.html [ Pass ] +storage/indexeddb/mozilla/index-prev-no-duplicate.html [ Pass ] storage/indexeddb/mozilla/key-requirements-delete-null-key.html [ Pass ] storage/indexeddb/mozilla/key-requirements-inline-and-passed.html [ Pass ] storage/indexeddb/mozilla/key-requirements-put-no-key.html [ Pass ] Modified: trunk/LayoutTests/storage/indexeddb/modern/index-cursor-1-expected.txt (192846 => 192847) --- trunk/LayoutTests/storage/indexeddb/modern/index-cursor-1-expected.txt 2015-12-01 01:05:13 UTC (rev 192846) +++ trunk/LayoutTests/storage/indexeddb/modern/index-cursor-1-expected.txt 2015-12-01 01:28:15 UTC (rev 192847) @@ -356,25 +356,25 @@ Cursor direction is: prevunique Cursor source is: TestIndex1 Cursor key is: D -Cursor primary key is: 12 +Cursor primary key is: 10 Cursor value is: [object Object] Success opening or iterating cursor Cursor direction is: prevunique Cursor source is: TestIndex1 Cursor key is: C -Cursor primary key is: 9 +Cursor primary key is: 7 Cursor value is: [object Object] Success opening or iterating cursor Cursor direction is: prevunique Cursor source is: TestIndex1 Cursor key is: B -Cursor primary key is: 6 +Cursor primary key is: 4 Cursor value is: [object Object] Success opening or iterating cursor Cursor direction is: prevunique Cursor source is: TestIndex1 Cursor key is: A -Cursor primary key is: 3 +C
[webkit-changes] [192846] trunk/Source/WebKit2
Title: [192846] trunk/Source/WebKit2 Revision 192846 Author a...@apple.com Date 2015-11-30 17:05:13 -0800 (Mon, 30 Nov 2015) Log Message Build fix for some compiler versions. * UIProcess/ios/forms/WKAirPlayRoutePicker.mm: Disable deprecation warnings while processing SOFT_LINK_CLASS too. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (192845 => 192846) --- trunk/Source/WebKit2/ChangeLog 2015-12-01 00:55:32 UTC (rev 192845) +++ trunk/Source/WebKit2/ChangeLog 2015-12-01 01:05:13 UTC (rev 192846) @@ -1,3 +1,10 @@ +2015-11-30 Alexey Proskuryakov + +Build fix for some compiler versions. + +* UIProcess/ios/forms/WKAirPlayRoutePicker.mm: Disable deprecation warnings while +processing SOFT_LINK_CLASS too. + 2015-11-30 Jiewen Tan Null dereference loading Blink layout test http/tests/misc/detach-during-notifyDone.html Modified: trunk/Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm (192845 => 192846) --- trunk/Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm 2015-12-01 00:55:32 UTC (rev 192845) +++ trunk/Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm 2015-12-01 01:05:13 UTC (rev 192846) @@ -36,6 +36,9 @@ #import #import +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wdeprecated-declarations" + SOFT_LINK_FRAMEWORK(MediaPlayer) SOFT_LINK_CLASS(MediaPlayer, MPAVRoutingController) SOFT_LINK_CLASS(MediaPlayer, MPAudioVideoRoutingPopoverController) @@ -43,9 +46,6 @@ using namespace WebKit; -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Wdeprecated-declarations" - @implementation WKAirPlayRoutePicker { RetainPtr _routingController; RetainPtr _popoverController; // iPad ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192845] trunk/Source/JavaScriptCore
Title: [192845] trunk/Source/_javascript_Core Revision 192845 Author sbar...@apple.com Date 2015-11-30 16:55:32 -0800 (Mon, 30 Nov 2015) Log Message FTL OSR Exits that are exception handlers should not have two different entrances. Instead, we should have two discrete OSR exits that do different things. https://bugs.webkit.org/show_bug.cgi?id=151404 Reviewed by Filip Pizlo. * ftl/FTLCompile.cpp: (JSC::FTL::mmAllocateDataSection): * ftl/FTLExceptionHandlerManager.cpp: (JSC::FTL::ExceptionHandlerManager::addNewExit): (JSC::FTL::ExceptionHandlerManager::addNewCallOperationExit): (JSC::FTL::ExceptionHandlerManager::callOperationExceptionTarget): (JSC::FTL::ExceptionHandlerManager::lazySlowPathExceptionTarget): (JSC::FTL::ExceptionHandlerManager::callOperationOSRExit): (JSC::FTL::ExceptionHandlerManager::getByIdOSRExit): Deleted. (JSC::FTL::ExceptionHandlerManager::subOSRExit): Deleted. * ftl/FTLExceptionHandlerManager.h: * ftl/FTLExitThunkGenerator.cpp: (JSC::FTL::ExitThunkGenerator::emitThunk): * ftl/FTLOSRExit.cpp: (JSC::FTL::OSRExitDescriptor::OSRExitDescriptor): (JSC::FTL::OSRExitDescriptor::isExceptionHandler): (JSC::FTL::OSRExit::OSRExit): (JSC::FTL::OSRExit::spillRegistersToSpillSlot): (JSC::FTL::OSRExit::recoverRegistersFromSpillSlot): (JSC::FTL::OSRExit::willArriveAtExitFromIndirectExceptionCheck): (JSC::FTL::OSRExit::willArriveAtOSRExitFromGenericUnwind): (JSC::FTL::OSRExit::willArriveAtOSRExitFromCallOperation): (JSC::FTL::OSRExit::needsRegisterRecoveryOnGenericUnwindOSRExitPath): (JSC::FTL::OSRExitDescriptor::willArriveAtExitFromIndirectExceptionCheck): Deleted. (JSC::FTL::OSRExitDescriptor::mightArriveAtOSRExitFromGenericUnwind): Deleted. (JSC::FTL::OSRExitDescriptor::mightArriveAtOSRExitFromCallOperation): Deleted. (JSC::FTL::OSRExitDescriptor::needsRegisterRecoveryOnGenericUnwindOSRExitPath): Deleted. * ftl/FTLOSRExit.h: * ftl/FTLOSRExitCompilationInfo.h: (JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo): * ftl/FTLOSRExitCompiler.cpp: (JSC::FTL::compileFTLOSRExit): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/ftl/FTLCompile.cpp trunk/Source/_javascript_Core/ftl/FTLExceptionHandlerManager.cpp trunk/Source/_javascript_Core/ftl/FTLExceptionHandlerManager.h trunk/Source/_javascript_Core/ftl/FTLExitThunkGenerator.cpp trunk/Source/_javascript_Core/ftl/FTLOSRExit.cpp trunk/Source/_javascript_Core/ftl/FTLOSRExit.h trunk/Source/_javascript_Core/ftl/FTLOSRExitCompilationInfo.h trunk/Source/_javascript_Core/ftl/FTLOSRExitCompiler.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (192844 => 192845) --- trunk/Source/_javascript_Core/ChangeLog 2015-12-01 00:33:47 UTC (rev 192844) +++ trunk/Source/_javascript_Core/ChangeLog 2015-12-01 00:55:32 UTC (rev 192845) @@ -1,3 +1,43 @@ +2015-11-30 Saam barati + +FTL OSR Exits that are exception handlers should not have two different entrances. Instead, we should have two discrete OSR exits that do different things. +https://bugs.webkit.org/show_bug.cgi?id=151404 + +Reviewed by Filip Pizlo. + +* ftl/FTLCompile.cpp: +(JSC::FTL::mmAllocateDataSection): +* ftl/FTLExceptionHandlerManager.cpp: +(JSC::FTL::ExceptionHandlerManager::addNewExit): +(JSC::FTL::ExceptionHandlerManager::addNewCallOperationExit): +(JSC::FTL::ExceptionHandlerManager::callOperationExceptionTarget): +(JSC::FTL::ExceptionHandlerManager::lazySlowPathExceptionTarget): +(JSC::FTL::ExceptionHandlerManager::callOperationOSRExit): +(JSC::FTL::ExceptionHandlerManager::getByIdOSRExit): Deleted. +(JSC::FTL::ExceptionHandlerManager::subOSRExit): Deleted. +* ftl/FTLExceptionHandlerManager.h: +* ftl/FTLExitThunkGenerator.cpp: +(JSC::FTL::ExitThunkGenerator::emitThunk): +* ftl/FTLOSRExit.cpp: +(JSC::FTL::OSRExitDescriptor::OSRExitDescriptor): +(JSC::FTL::OSRExitDescriptor::isExceptionHandler): +(JSC::FTL::OSRExit::OSRExit): +(JSC::FTL::OSRExit::spillRegistersToSpillSlot): +(JSC::FTL::OSRExit::recoverRegistersFromSpillSlot): +(JSC::FTL::OSRExit::willArriveAtExitFromIndirectExceptionCheck): +(JSC::FTL::OSRExit::willArriveAtOSRExitFromGenericUnwind): +(JSC::FTL::OSRExit::willArriveAtOSRExitFromCallOperation): +(JSC::FTL::OSRExit::needsRegisterRecoveryOnGenericUnwindOSRExitPath): +(JSC::FTL::OSRExitDescriptor::willArriveAtExitFromIndirectExceptionCheck): Deleted. +(JSC::FTL::OSRExitDescriptor::mightArriveAtOSRExitFromGenericUnwind): Deleted. +(JSC::FTL::OSRExitDescriptor::mightArriveAtOSRExitFromCallOperation): Deleted. +(JSC::FTL::OSRExitDescriptor::needsRegisterRecoveryOnGenericUnwindOSRExitPath): Deleted. +* ftl/FTLOSRExit.h: +* ftl/FTLOSRExitCompilationInfo.h: +(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo): +* ftl/FTLOSRExitCompiler.cpp: +(JSC::FTL::
[webkit-changes] [192844] trunk
Title: [192844] trunk Revision 192844 Author jiewen_...@apple.com Date 2015-11-30 16:33:47 -0800 (Mon, 30 Nov 2015) Log Message Null dereference loading Blink layout test http/tests/misc/detach-during-notifyDone.html https://bugs.webkit.org/show_bug.cgi?id=149309 Reviewed by Brent Fulgham. Source/WebCore: A weird order of event execution introduced by the test case will kill the webpage in a subframe of the page while executing its |frame.loader().checkLoadCompleteForThisFrame()|. Therefore, any frames comes after the failing subframe will have no page. Check it before calling to those frames' |frame.loader().checkLoadCompleteForThisFrame()|, otherwise the assertion in |frame.loader().checkLoadCompleteForThisFrame()| will fail. Test: http/tests/misc/detach-during-notifyDone.html * loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadComplete): Source/WebKit/mac: * WebView/WebDataSource.mm: (WebDataSourcePrivate::~WebDataSourcePrivate): Refine the assertion to treat . Source/WebKit2: Callback of bundle clients could kill the documentloader. Therefore, make a copy of the navigationID before invoking the callback. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage): (WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage): (WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage): (WebKit::WebFrameLoaderClient::dispatchDidFailLoad): (WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebKit::WebFrameLoaderClient::dispatchDidFinishLoad): LayoutTests: The test case is from Blink r175601: https://codereview.chromium.org/317513002 The test case will generate a set of weird ordering events that affects the documentLoader: 1. The subframe finishes loading, and since the frame’s testRunner is not set to wait until done, WebKitTestRunner stops the load (by calling WKBundlePageStopLoading()). 2. This causes the in-progress XHR to be aborted, which causes its readyState to become DONE (this bug doesn’t always reproduce because sometimes the XHR has already finished before the frame finishes loading). 3. The onreadystatechange callback is executed, which sets innerHTML on the parent frame. 4. Setting innerHTML disconnects the subframe, nulling out its DocumentLoader. 5. We return to WebFrameLoaderClient::dispatchDidFinishLoad() from step #1, but now the FrameLoader’s DocumentLoader is null. And WebKit crashes here. Note that steps 2-4 happen synchronously inside WebFrameLoaderClient::dispatchDidFinishLoad(). * http/tests/misc/detach-during-notifyDone-expected.txt: Added. * http/tests/misc/detach-during-notifyDone.html: Added. * http/tests/misc/resources/detached-frame.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/FrameLoader.cpp trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebDataSource.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Added Paths trunk/LayoutTests/http/tests/misc/detach-during-notifyDone-expected.txt trunk/LayoutTests/http/tests/misc/detach-during-notifyDone.html trunk/LayoutTests/http/tests/misc/resources/detached-frame.html Diff Modified: trunk/LayoutTests/ChangeLog (192843 => 192844) --- trunk/LayoutTests/ChangeLog 2015-12-01 00:09:42 UTC (rev 192843) +++ trunk/LayoutTests/ChangeLog 2015-12-01 00:33:47 UTC (rev 192844) @@ -1,3 +1,30 @@ +2015-11-30 Jiewen Tan + +Null dereference loading Blink layout test http/tests/misc/detach-during-notifyDone.html +https://bugs.webkit.org/show_bug.cgi?id=149309 + + +Reviewed by Brent Fulgham. + +The test case is from Blink r175601: +https://codereview.chromium.org/317513002 +The test case will generate a set of weird ordering events that affects the documentLoader: +1. The subframe finishes loading, and since the frame’s testRunner is not set to wait until +done, WebKitTestRunner stops the load (by calling WKBundlePageStopLoading()). +2. This causes the in-progress XHR to be aborted, which causes its readyState to become DONE +(this bug doesn’t always reproduce because sometimes the XHR has already finished before the +frame finishes loading). +3. The onreadystatechange callback is executed, which sets innerHTML on the parent frame. +4. Setting innerHTML disconnects the subframe, nulling out its DocumentLoader. +5. We return to WebFrameLoaderClient::dispatchDidFinishLoad() from step #1, but now the +FrameLoader’s DocumentLoader is null. And WebKit crashes here. + +Note that steps 2-4 happen synchronously inside WebFrameLoaderClient::dispatchDidFinishLoad(). + +* http/tests/misc/detach-during-notifyDone-expected.txt: Added. +* http/tests/misc/detach-during-notifyDone.html: Add
[webkit-changes] [192843] trunk
Title: [192843] trunk Revision 192843 Author commit-qu...@webkit.org Date 2015-11-30 16:09:42 -0800 (Mon, 30 Nov 2015) Log Message Unreviewed, rolling out r192819. https://bugs.webkit.org/show_bug.cgi?id=151681 This change broke existing layout tests on Windows (Requested by ryanhaddad on #webkit). Reverted changeset: "Unify font-variant-* with font-variant shorthand" https://bugs.webkit.org/show_bug.cgi?id=149773 http://trac.webkit.org/changeset/192819 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/font-variant-parsing-expected.txt trunk/LayoutTests/css3/font-variant-parsing.html trunk/LayoutTests/fast/css/font-property-priority-expected.txt trunk/LayoutTests/fast/css/font-shorthand-expected.txt trunk/LayoutTests/fast/css/parsing-font-variant-ligatures-expected.txt trunk/LayoutTests/fast/css/parsing-font-variant-ligatures.html trunk/LayoutTests/fast/inspector-support/style-expected.txt trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac/fast/writing-mode/broken-ideograph-small-caps-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSFontSelector.cpp trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSParser.h trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/FontVariantBuilder.h trunk/Source/WebCore/css/StyleProperties.cpp trunk/Source/WebCore/css/StyleResolver.cpp trunk/Source/WebCore/editing/EditingStyle.cpp trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm trunk/Source/WebCore/editing/ios/EditorIOS.mm trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp trunk/Source/WebCore/platform/graphics/FontCache.h trunk/Source/WebCore/platform/graphics/FontCascade.cpp trunk/Source/WebCore/platform/graphics/FontCascade.h trunk/Source/WebCore/platform/graphics/FontDescription.cpp trunk/Source/WebCore/platform/graphics/FontDescription.h trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp trunk/Source/WebCore/platform/text/TextFlags.h trunk/Source/WebCore/rendering/RenderText.cpp Removed Paths trunk/LayoutTests/fast/text/font-variant-shorthand-expected.txt trunk/LayoutTests/fast/text/font-variant-shorthand.html Diff Modified: trunk/LayoutTests/ChangeLog (192842 => 192843) --- trunk/LayoutTests/ChangeLog 2015-12-01 00:07:39 UTC (rev 192842) +++ trunk/LayoutTests/ChangeLog 2015-12-01 00:09:42 UTC (rev 192843) @@ -1,3 +1,17 @@ +2015-11-30 Commit Queue + +Unreviewed, rolling out r192819. +https://bugs.webkit.org/show_bug.cgi?id=151681 + +This change broke existing layout tests on Windows (Requested +by ryanhaddad on #webkit). + +Reverted changeset: + +"Unify font-variant-* with font-variant shorthand" +https://bugs.webkit.org/show_bug.cgi?id=149773 +http://trac.webkit.org/changeset/192819 + 2015-11-30 Brady Eidson Modern IDB: Set the correct source on the IDBRequest for cursor updates Modified: trunk/LayoutTests/css3/font-variant-parsing-expected.txt (192842 => 192843) --- trunk/LayoutTests/css3/font-variant-parsing-expected.txt 2015-12-01 00:07:39 UTC (rev 192842) +++ trunk/LayoutTests/css3/font-variant-parsing-expected.txt 2015-12-01 00:09:42 UTC (rev 192843) @@ -3,7 +3,7 @@ PASS window.getComputedStyle(document.getElementById('testElement')).getPropertyCSSValue('font-variant-ligatures').cssText is "normal" PASS window.getComputedStyle(document.getElementById('testElement')).getPropertyCSSValue('font-variant-ligatures').cssText is "normal" PASS window.getComputedStyle(document.getElementById('testElement')).getPropertyCSSValue('font-variant-ligatures').cssText is "common-ligatures" -PASS window.getComputedStyle(document.getElementById('testElement')).getPropertyCSSValue('font-variant-ligatures').cssText is "common-ligatures" +PASS window.getComputedStyle(document.getElementById('testElement')).getPropertyCSSValue('font-variant-ligatures').cssText is "normal" PASS window.getComputedStyle(document.getElementById('testElement')).getPropertyCSSValue('font-variant-ligatures').cssText is "no-common-ligatures" PASS window.getComputedStyle(document.getElementById('testElement')).getPropertyCSSValue('font-variant-ligatures').cssText is "discretionary-ligatures" PASS window.getComputedStyle(document.getElementById('testElement')).getPropertyCSSValue('font-variant-ligatures').cssText is "no-discretionary-ligatures" @@ -49,9 +49,9 @@ PASS window.getComputedStyle(document.getElementById('testElement')).getPropertyCSSValue('font-variant-numeric').cssText is "ordinal" PASS window.getComputedStyle(document.getElementById('testElement')).getPropertyCSSValue('font-variant-numeric').cssText is "slashed-zero" PASS window.getComputedStyle(document.getElementById('testElement')).getPropertyCSSValue('font-variant-numeric').cssText is "lining-nums slashed-zero" -PASS window.getComputedStyle(document.getElementById('testElement')).getPropertyCSSVa
[webkit-changes] [192842] trunk/Source/JavaScriptCore
Title: [192842] trunk/Source/_javascript_Core Revision 192842 Author mark@apple.com Date 2015-11-30 16:07:39 -0800 (Mon, 30 Nov 2015) Log Message Refactor the op_add, op_sub, and op_mul snippets to use the SnippetOperand class. https://bugs.webkit.org/show_bug.cgi?id=151678 Reviewed by Geoffrey Garen. * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileValueAdd): (JSC::DFG::SpeculativeJIT::compileArithSub): * ftl/FTLCompile.cpp: * jit/JITAddGenerator.cpp: (JSC::JITAddGenerator::generateFastPath): * jit/JITAddGenerator.h: (JSC::JITAddGenerator::JITAddGenerator): * jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_mul): (JSC::JIT::emit_op_sub): * jit/JITMulGenerator.cpp: (JSC::JITMulGenerator::generateFastPath): * jit/JITMulGenerator.h: (JSC::JITMulGenerator::JITMulGenerator): * jit/JITSubGenerator.cpp: (JSC::JITSubGenerator::generateFastPath): * jit/JITSubGenerator.h: (JSC::JITSubGenerator::JITSubGenerator): * jit/SnippetOperand.h: (JSC::SnippetOperand::isPositiveConstInt32): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/ftl/FTLCompile.cpp trunk/Source/_javascript_Core/jit/JITAddGenerator.cpp trunk/Source/_javascript_Core/jit/JITAddGenerator.h trunk/Source/_javascript_Core/jit/JITArithmetic.cpp trunk/Source/_javascript_Core/jit/JITMulGenerator.cpp trunk/Source/_javascript_Core/jit/JITMulGenerator.h trunk/Source/_javascript_Core/jit/JITSubGenerator.cpp trunk/Source/_javascript_Core/jit/JITSubGenerator.h trunk/Source/_javascript_Core/jit/SnippetOperand.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (192841 => 192842) --- trunk/Source/_javascript_Core/ChangeLog 2015-12-01 00:04:57 UTC (rev 192841) +++ trunk/Source/_javascript_Core/ChangeLog 2015-12-01 00:07:39 UTC (rev 192842) @@ -1,3 +1,33 @@ +2015-11-30 Mark Lam + +Refactor the op_add, op_sub, and op_mul snippets to use the SnippetOperand class. +https://bugs.webkit.org/show_bug.cgi?id=151678 + +Reviewed by Geoffrey Garen. + +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::compileValueAdd): +(JSC::DFG::SpeculativeJIT::compileArithSub): +* ftl/FTLCompile.cpp: +* jit/JITAddGenerator.cpp: +(JSC::JITAddGenerator::generateFastPath): +* jit/JITAddGenerator.h: +(JSC::JITAddGenerator::JITAddGenerator): +* jit/JITArithmetic.cpp: +(JSC::JIT::emit_op_add): +(JSC::JIT::emit_op_mul): +(JSC::JIT::emit_op_sub): +* jit/JITMulGenerator.cpp: +(JSC::JITMulGenerator::generateFastPath): +* jit/JITMulGenerator.h: +(JSC::JITMulGenerator::JITMulGenerator): +* jit/JITSubGenerator.cpp: +(JSC::JITSubGenerator::generateFastPath): +* jit/JITSubGenerator.h: +(JSC::JITSubGenerator::JITSubGenerator): +* jit/SnippetOperand.h: +(JSC::SnippetOperand::isPositiveConstInt32): + 2015-11-30 Filip Pizlo B3 stackmaps should support early clobber Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (192841 => 192842) --- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2015-12-01 00:04:57 UTC (rev 192841) +++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2015-12-01 00:07:39 UTC (rev 192842) @@ -2853,30 +2853,26 @@ FPRReg scratchFPR = fprScratch.fpr(); #endif -ResultType leftType = m_state.forNode(node->child1()).resultType(); -ResultType rightType = m_state.forNode(node->child2()).resultType(); -int32_t leftConstInt32 = 0; -int32_t rightConstInt32 = 0; +SnippetOperand leftOperand(m_state.forNode(node->child1()).resultType()); +SnippetOperand rightOperand(m_state.forNode(node->child2()).resultType()); -ASSERT(!leftIsConstInt32 || !rightIsConstInt32); +if (leftIsConstInt32) +leftOperand.setConstInt32(node->child1()->asInt32()); +if (rightIsConstInt32) +rightOperand.setConstInt32(node->child2()->asInt32()); -if (leftIsConstInt32) { -leftConstInt32 = node->child1()->asInt32(); -right = JSValueOperand(this, node->child2()); -rightRegs = right->jsValueRegs(); -} else if (rightIsConstInt32) { +ASSERT(!leftOperand.isConst() || !rightOperand.isConst()); + +if (!leftOperand.isConst()) { left = JSValueOperand(this, node->child1()); leftRegs = left->jsValueRegs(); -rightConstInt32 = node->child2()->asInt32(); -} else { -left = JSValueOperand(this, node->child1()); -leftRegs = left->jsValueRegs(); +} +if (!rightOperand.isConst()) { right = JSValueOperand(this, node->child2()); rightRegs = right->jsValueRegs(); } -JITAddGenerator gen(resultRegs, leftRegs, rightRegs, leftType, rightType, -leftIsConstInt32, rightIsConstInt32, leftConstInt32, rightConstInt32, +JITAddGenerator gen(leftOperand, rightOperand, result
[webkit-changes] [192841] trunk/Source/JavaScriptCore
Title: [192841] trunk/Source/_javascript_Core Revision 192841 Author fpi...@apple.com Date 2015-11-30 16:04:57 -0800 (Mon, 30 Nov 2015) Log Message B3 stackmaps should support early clobber https://bugs.webkit.org/show_bug.cgi?id=151668 Reviewed by Geoffrey Garen. While starting work on FTL lazy slow paths, I realized that we needed some way to say that r11 is off limits. Not just that it's clobbered, but that it cannot be used for any input values to a stackmap. In LLVM we do this by having the AnyRegCC forbid r11. In B3, we want something more flexible. In this and other cases, what we really want is an early clobber set. B3 already supported a late clobber set for every stackmap value. Late clobber means that the act of performing the operation will cause garbage to be written into those registers. But here we want: assume that garbage magically appears in those registers in the moment before the operation executes. Any registers in that set will be off-limits to the inputs to the stackmap. This should be great for other things, like the way the we handle exceptions. For the simple r11 issue, what we want is to call the StackmapValue::clobber() method, which now means both early and late clobber. It's the weapon of choice whenever you're unsure. This adds the early clobber feature, does some minor Inst refactoring to make this less scary, and adds a test. The test is simple but it's very comprehensive - for example it tests the early-clobber-after-Move special case. * b3/B3StackmapSpecial.cpp: (JSC::B3::StackmapSpecial::extraClobberedRegs): (JSC::B3::StackmapSpecial::extraEarlyClobberedRegs): (JSC::B3::StackmapSpecial::forEachArgImpl): * b3/B3StackmapSpecial.h: * b3/B3StackmapValue.cpp: (JSC::B3::StackmapValue::dumpMeta): (JSC::B3::StackmapValue::StackmapValue): * b3/B3StackmapValue.h: * b3/air/AirCCallSpecial.cpp: (JSC::B3::Air::CCallSpecial::extraClobberedRegs): (JSC::B3::Air::CCallSpecial::extraEarlyClobberedRegs): (JSC::B3::Air::CCallSpecial::dumpImpl): * b3/air/AirCCallSpecial.h: * b3/air/AirInst.h: * b3/air/AirInstInlines.h: (JSC::B3::Air::Inst::extraClobberedRegs): (JSC::B3::Air::Inst::extraEarlyClobberedRegs): (JSC::B3::Air::Inst::forEachTmpWithExtraClobberedRegs): (JSC::B3::Air::Inst::reportUsedRegisters): (JSC::B3::Air::Inst::forEachDefAndExtraClobberedTmp): Deleted. * b3/air/AirIteratedRegisterCoalescing.cpp: (JSC::B3::Air::IteratedRegisterCoalescingAllocator::IteratedRegisterCoalescingAllocator): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::build): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::allocate): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::initializeDegrees): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::addEdges): (JSC::B3::Air::IteratedRegisterCoalescingAllocator::addEdge): (JSC::B3::Air::iteratedRegisterCoalescingOnType): (JSC::B3::Air::iteratedRegisterCoalescing): * b3/air/AirSpecial.h: * b3/air/AirSpillEverything.cpp: (JSC::B3::Air::spillEverything): * b3/testb3.cpp: (JSC::B3::testSimplePatchpointWithoutOuputClobbersGPArgs): (JSC::B3::testSimplePatchpointWithOuputClobbersGPArgs): (JSC::B3::testSimplePatchpointWithoutOuputClobbersFPArgs): (JSC::B3::testSimplePatchpointWithOuputClobbersFPArgs): (JSC::B3::testPatchpointWithEarlyClobber): (JSC::B3::testPatchpointCallArg): (JSC::B3::run): * dfg/DFGCommon.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/b3/B3StackmapSpecial.cpp trunk/Source/_javascript_Core/b3/B3StackmapSpecial.h trunk/Source/_javascript_Core/b3/B3StackmapValue.cpp trunk/Source/_javascript_Core/b3/B3StackmapValue.h trunk/Source/_javascript_Core/b3/air/AirCCallSpecial.cpp trunk/Source/_javascript_Core/b3/air/AirCCallSpecial.h trunk/Source/_javascript_Core/b3/air/AirInst.h trunk/Source/_javascript_Core/b3/air/AirInstInlines.h trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp trunk/Source/_javascript_Core/b3/air/AirSpecial.h trunk/Source/_javascript_Core/b3/air/AirSpillEverything.cpp trunk/Source/_javascript_Core/b3/testb3.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (192840 => 192841) --- trunk/Source/_javascript_Core/ChangeLog 2015-12-01 00:03:51 UTC (rev 192840) +++ trunk/Source/_javascript_Core/ChangeLog 2015-12-01 00:04:57 UTC (rev 192841) @@ -1,3 +1,73 @@ +2015-11-30 Filip Pizlo + +B3 stackmaps should support early clobber +https://bugs.webkit.org/show_bug.cgi?id=151668 + +Reviewed by Geoffrey Garen. + +While starting work on FTL lazy slow paths, I realized that we needed some way to say that r11 is +off limits. Not just that it's clobbered, but that it cannot be used for any input values to a +stackmap. + +In LLVM we do this by having the AnyRegCC forbid r11. + +In B3, we want something more flexible. In this and other cases, what we really want is an early +clobber set. B3 already supported a late clobber set for every stackmap value. Late clobber means +tha
[webkit-changes] [192840] trunk/Source/ThirdParty/ANGLE
Title: [192840] trunk/Source/ThirdParty/ANGLE Revision 192840 Author dburk...@apple.com Date 2015-11-30 16:03:51 -0800 (Mon, 30 Nov 2015) Log Message Remove Mountain Lion support from ANGLE https://bugs.webkit.org/show_bug.cgi?id=151679 Reviewed by Darin Adler. * Configurations/Base.xcconfig: Modified Paths trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig Diff Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (192839 => 192840) --- trunk/Source/ThirdParty/ANGLE/ChangeLog 2015-11-30 23:57:31 UTC (rev 192839) +++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2015-12-01 00:03:51 UTC (rev 192840) @@ -1,3 +1,12 @@ +2015-11-30 Dana Burkart + +Remove Mountain Lion support from ANGLE +https://bugs.webkit.org/show_bug.cgi?id=151679 + +Reviewed by Darin Adler. + +* Configurations/Base.xcconfig: + 2015-11-02 Andy Estes [Cocoa] Add tvOS and watchOS to SUPPORTED_PLATFORMS Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (192839 => 192840) --- trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig 2015-11-30 23:57:31 UTC (rev 192839) +++ trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig 2015-12-01 00:03:51 UTC (rev 192840) @@ -53,14 +53,6 @@ SDKROOT = macosx.internal; -TOOLCHAINS[sdk=macosx*] = $(TOOLCHAINS_macosx); -TOOLCHAINS_macosx = $(TOOLCHAINS_macosx_$(MAC_OS_X_VERSION_MAJOR)); -TOOLCHAINS_macosx_1080 = default; -TOOLCHAINS_macosx_1090 = $(TOOLCHAINS); -TOOLCHAINS_macosx_101000 = $(TOOLCHAINS_macosx_1090); -TOOLCHAINS_macosx_101100 = $(TOOLCHAINS_macosx_101000); -TOOLCHAINS_macosx_101200 = $(TOOLCHAINS_macosx_101100); - OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS); OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS); OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192839] trunk/Source/WebCore
Title: [192839] trunk/Source/WebCore Revision 192839 Author da...@apple.com Date 2015-11-30 15:57:31 -0800 (Mon, 30 Nov 2015) Log Message Use Optional instead of isNull out argument for nullable getters https://bugs.webkit.org/show_bug.cgi?id=151676 Reviewed by Anders Carlsson. No behavior change, just cleaner code. * Modules/geolocation/Coordinates.cpp: (WebCore::Coordinates::altitude): Return an Optional. (WebCore::Coordinates::altitudeAccuracy): Ditto. (WebCore::Coordinates::heading): Ditto. (WebCore::Coordinates::speed): Ditto. * Modules/geolocation/Coordinates.h: Ditto. * Modules/indexeddb/IDBVersionChangeEvent.cpp: (WebCore::IDBVersionChangeEvent::create): Added. The code before was calling through to Event::create, which is clearly not what was wanted. Also removed unneeded explicit destructor. * Modules/indexeddb/IDBVersionChangeEvent.h: Changed return type of newVersion to Optional and updated for above change. * Modules/indexeddb/client/IDBVersionChangeEventImpl.cpp: (WebCore::IDBClient::IDBVersionChangeEvent::newVersion): Changed to return an Optional. * Modules/indexeddb/client/IDBVersionChangeEventImpl.h: Removed unused default argument values; the event type one, at least, was clearly incorrect. Made more things private, got rid of unneeded destructor, marked class final instead of marking all functions final. * Modules/indexeddb/legacy/LegacyVersionChangeEvent.cpp: (WebCore::LegacyVersionChangeEvent::newVersion): Same as above. * Modules/indexeddb/legacy/LegacyVersionChangeEvent.h: Ditto. * Modules/mediastream/MediaTrackConstraints.cpp: (WebCore::MediaTrackConstraints::optional): Removed bogus bool value. If we come back to finish later we will have to implement optional return values for arrays in the _javascript_ bindings generator, which should be straightforward. * Modules/mediastream/MediaTrackConstraints.h: Ditto. * bindings/js/JSDOMBinding.h: (WebCore::toNullableJSNumber): Added. This function template is used for return values that are nullable numbers. * bindings/scripts/CodeGeneratorGObject.pm: (GenerateFunction): Replaced some existing bogus code to handle nullables with new equally-bogus code that should be no worse and will compile. * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Removed old support for nullables. (NativeToJSValue): Added new support for nullable numbers. * bindings/scripts/CodeGeneratorObjC.pm: (GenerateImplementation): Removed support for nullables. We almost certainly won't need it for Objective-C bindings. * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Updated. * bindings/scripts/test/JS/JSTestObj.cpp: Updated. * bindings/scripts/test/ObjC/DOMTestObj.mm: Updated. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/geolocation/Coordinates.cpp trunk/Source/WebCore/Modules/geolocation/Coordinates.h trunk/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.cpp trunk/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h trunk/Source/WebCore/Modules/indexeddb/client/IDBVersionChangeEventImpl.cpp trunk/Source/WebCore/Modules/indexeddb/client/IDBVersionChangeEventImpl.h trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyVersionChangeEvent.cpp trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyVersionChangeEvent.h trunk/Source/WebCore/Modules/mediastream/MediaTrackConstraints.cpp trunk/Source/WebCore/Modules/mediastream/MediaTrackConstraints.h trunk/Source/WebCore/bindings/js/JSDOMBinding.h trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm Diff Modified: trunk/Source/WebCore/ChangeLog (192838 => 192839) --- trunk/Source/WebCore/ChangeLog 2015-11-30 23:48:42 UTC (rev 192838) +++ trunk/Source/WebCore/ChangeLog 2015-11-30 23:57:31 UTC (rev 192839) @@ -1,3 +1,64 @@ +2015-11-30 Darin Adler + +Use Optional instead of isNull out argument for nullable getters +https://bugs.webkit.org/show_bug.cgi?id=151676 + +Reviewed by Anders Carlsson. + +No behavior change, just cleaner code. + +* Modules/geolocation/Coordinates.cpp: +(WebCore::Coordinates::altitude): Return an Optional. +(WebCore::Coordinates::altitudeAccuracy): Ditto. +(WebCore::Coordinates::heading): Ditto. +(WebCore::Coordinates::speed): Ditto. +* Modules/geolocation/Coordinates.h: Ditto. + +* Modules/indexeddb/IDBVersionChangeEvent.cpp: +(WebCore::IDBVersionChangeEvent::create): Added. The code before was calling +through to Event::create, which is clearly not what was wanted. Also removed +unneeded explicit destructor. +* Modules/indexeddb/IDBVersionChangeEvent.h: Changed return type of newVersio
[webkit-changes] [192838] trunk/Source/WebCore
Title: [192838] trunk/Source/WebCore Revision 192838 Author wenson_hs...@apple.com Date 2015-11-30 15:48:42 -0800 (Mon, 30 Nov 2015) Log Message Split platform-independent logic in AVCaptureDeviceManager out into a new class https://bugs.webkit.org/show_bug.cgi?id=151388 Reviewed by Eric Carlson. To prepare for creating a MockCaptureDeviceManager to be able to test MediaDevices.getUserMedia, we create a platform-independent capture device manager which all platforms should extend and add platform-specific logic to. The methods CaptureDeviceManager::createMediaSourceForCaptureDeviceWithConstraints and CaptureDeviceManager::captureDeviceList should be overridden by each platform CaptureDeviceManager to respectively create a RealtimeMediaSource and return a list of capture devices. createMediaSourceForCaptureDeviceWithConstraints attempts to create a media source for a given device with some constraints; if the contraints cannot be satisfied, this returns null. The refactored capture device manager also introduces the notion of a platform- independent capture session which may be extended by platform device managers for determining whether a given constraint name, value and media type is valid. A platform-independent CaptureDeviceInfo now represents either the video or audio component of a capture device, but not both at once. This means a capture device that supports both video and audio will emit two separate capture devices. No new tests, since there should be no behavior change. * Modules/mediastream/CaptureDeviceInfo.h: Added. (WebCore::CaptureSessionInfo::~CaptureSessionInfo): (WebCore::CaptureSessionInfo::supportsVideoSize): (WebCore::CaptureSessionInfo::bestSessionPresetForVideoDimensions): * Modules/mediastream/CaptureDeviceManager.cpp: Added. (CaptureDeviceManager::~CaptureDeviceManager): (CaptureDeviceManager::getSourcesInfo): (CaptureDeviceManager::captureDeviceFromDeviceID): (CaptureDeviceManager::verifyConstraintsForMediaType): (CaptureDeviceManager::bestSourcesForTypeAndConstraints): (CaptureDeviceManager::sourceWithUID): (CaptureDeviceManager::bestDeviceForFacingMode): (facingModeFromString): (CaptureDeviceManager::sessionSupportsConstraint): (CaptureDeviceManager::isSupportedFrameRate): * Modules/mediastream/CaptureDeviceManager.h: Added. (WebCore::CaptureDeviceManager::refreshCaptureDeviceList): (WebCore::CaptureDeviceManager::defaultCaptureSession): * WebCore.xcodeproj/project.pbxproj: * platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp: Added. (WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint): (WebCore::RealtimeMediaSourceSupportedConstraints::constraintFromName): (WebCore::RealtimeMediaSourceSupportedConstraints::supportsConstraint): * platform/mediastream/RealtimeMediaSourceSupportedConstraints.h: * platform/mediastream/mac/AVCaptureDeviceManager.h: * platform/mediastream/mac/AVCaptureDeviceManager.mm: (WebCore::AVCaptureSessionInfo::AVCaptureSessionInfo): (WebCore::AVCaptureSessionInfo::supportsVideoSize): (WebCore::AVCaptureSessionInfo::bestSessionPresetForVideoDimensions): (WebCore::AVCaptureDeviceManager::captureDeviceList): (WebCore::shouldConsiderDeviceInDeviceList): (WebCore::AVCaptureDeviceManager::refreshCaptureDeviceList): (WebCore::AVCaptureDeviceManager::AVCaptureDeviceManager): (WebCore::AVCaptureDeviceManager::bestSourcesForTypeAndConstraints): (WebCore::AVCaptureDeviceManager::sourceWithUID): (WebCore::AVCaptureDeviceManager::getSourcesInfo): (WebCore::AVCaptureDeviceManager::verifyConstraintsForMediaType): (WebCore::AVCaptureDeviceManager::defaultCaptureSession): (WebCore::AVCaptureDeviceManager::sessionSupportsConstraint): (WebCore::AVCaptureDeviceManager::createMediaSourceForCaptureDeviceWithConstraints): (WebCore::AVCaptureDeviceManager::deviceDisconnected): (WebCore::AVCaptureDeviceManager::isSupportedFrameRate): (WebCore::CaptureDevice:::m_enabled): Deleted. (WebCore::captureDeviceList): Deleted. (WebCore::captureDeviceFromDeviceID): Deleted. (WebCore::refreshCaptureDeviceList): Deleted. (WebCore::AVCaptureDeviceManager::bestSessionPresetForVideoSize): Deleted. (WebCore::AVCaptureDeviceManager::deviceSupportsFacingMode): Deleted. (WebCore::AVCaptureDeviceManager::bestDeviceForFacingMode): Deleted. (WebCore::AVCaptureDeviceManager::isValidConstraint): Deleted. (WebCore::AVCaptureDeviceManager::validConstraintNames): Deleted. (WebCore::AVCaptureDeviceManager::validFacingModes): Deleted. * platform/mediastream/mac/AVVideoCaptureSource.mm: (WebCore::AVVideoCaptureSource::applyConstraints): * platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp: (WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints): (WebCore::RealtimeMediaSourceCenterMac::createMediaStream): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.h trunk/Source/WebCore/platform/mediastream/mac/AVCaptureDevic
[webkit-changes] [192837] trunk/Source/WebInspectorUI
Title: [192837] trunk/Source/WebInspectorUI Revision 192837 Author bb...@apple.com Date 2015-11-30 15:27:23 -0800 (Mon, 30 Nov 2015) Log Message Web Inspector: show something useful when the inspector frontend fails to load https://bugs.webkit.org/show_bug.cgi?id=151643 Reviewed by Timothy Hatcher. When a parse error or other early error happens before the inspector is fully loaded, we can't use the second-level inspector to tell what's going on. It would be better to catch any early errors and list them. This patch adds an error page that shows the early errors that happened during loading. It provides a list of errors, a link to reload the inspector, and a link to submit a pre-filled bug report about the error. For now, this page only shows up in engineering builds because it's located in the Debug/ directory. We can move it later when it works better in all cases. Follow-up patches can address smaller issues, such as the transparent title bar and broken text selection. * UserInterface/Debug/CatchEarlyErrors.css: Added. * UserInterface/Debug/CatchEarlyErrors.js: Added. * UserInterface/Main.html: * UserInterface/Main.js: Abort setting up the UI if something happened. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Base/Main.js trunk/Source/WebInspectorUI/UserInterface/Main.html Added Paths trunk/Source/WebInspectorUI/UserInterface/Debug/CatchEarlyErrors.css trunk/Source/WebInspectorUI/UserInterface/Debug/CatchEarlyErrors.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (192836 => 192837) --- trunk/Source/WebInspectorUI/ChangeLog 2015-11-30 23:13:41 UTC (rev 192836) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-11-30 23:27:23 UTC (rev 192837) @@ -1,5 +1,30 @@ 2015-11-30 Brian Burg +Web Inspector: show something useful when the inspector frontend fails to load +https://bugs.webkit.org/show_bug.cgi?id=151643 + +Reviewed by Timothy Hatcher. + +When a parse error or other early error happens before the inspector +is fully loaded, we can't use the second-level inspector to tell what's +going on. It would be better to catch any early errors and list them. + +This patch adds an error page that shows the early errors that happened +during loading. It provides a list of errors, a link to reload the +inspector, and a link to submit a pre-filled bug report about the error. + +For now, this page only shows up in engineering builds because it's +located in the Debug/ directory. We can move it later when it works +better in all cases. Follow-up patches can address smaller issues, +such as the transparent title bar and broken text selection. + + * UserInterface/Debug/CatchEarlyErrors.css: Added. + * UserInterface/Debug/CatchEarlyErrors.js: Added. + * UserInterface/Main.html: + * UserInterface/Main.js: Abort setting up the UI if something happened. + +2015-11-30 Brian Burg + Web Inspector: delete-by-word and similar shortcuts should add text to the WebCore kill ring https://bugs.webkit.org/show_bug.cgi?id=151312 Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (192836 => 192837) --- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-11-30 23:13:41 UTC (rev 192836) +++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-11-30 23:27:23 UTC (rev 192837) @@ -175,6 +175,10 @@ WebInspector.contentLoaded = function() { +// If a loading error page was already shown, then don't set up the Inspector UI. +if (window.__earlyErrors) +return; + // Register for global events. document.addEventListener("beforecopy", this._beforecopy.bind(this)); document.addEventListener("copy", this._copy.bind(this)); Added: trunk/Source/WebInspectorUI/UserInterface/Debug/CatchEarlyErrors.css (0 => 192837) --- trunk/Source/WebInspectorUI/UserInterface/Debug/CatchEarlyErrors.css (rev 0) +++ trunk/Source/WebInspectorUI/UserInterface/Debug/CatchEarlyErrors.css 2015-11-30 23:27:23 UTC (rev 192837) @@ -0,0 +1,78 @@ +/* + * Copyright (C) 2015 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURP
[webkit-changes] [192836] trunk/Source/JavaScriptCore
Title: [192836] trunk/Source/_javascript_Core Revision 192836 Author mark@apple.com Date 2015-11-30 15:13:41 -0800 (Mon, 30 Nov 2015) Log Message Snippefy op_div for the baseline JIT. https://bugs.webkit.org/show_bug.cgi?id=151607 Reviewed by Geoffrey Garen. * CMakeLists.txt: * _javascript_Core.vcxproj/_javascript_Core.vcxproj: * _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters: * _javascript_Core.xcodeproj/project.pbxproj: * jit/JIT.h: * jit/JITArithmetic.cpp: (JSC::JIT::emit_op_div): (JSC::JIT::emitSlow_op_div): (JSC::JIT::compileBinaryArithOpSlowCase): Deleted. * jit/JITArithmetic32_64.cpp: (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div): Deleted. (JSC::JIT::emitSlow_op_div): Deleted. - Removed the 32-bit specific op_div implementation. The 64-bit version with the op_div snippet can now service both 32-bit and 64-bit. * jit/JITDivGenerator.cpp: Added. (JSC::JITDivGenerator::loadOperand): (JSC::JITDivGenerator::generateFastPath): * jit/JITDivGenerator.h: Added. (JSC::JITDivGenerator::JITDivGenerator): (JSC::JITDivGenerator::didEmitFastPath): (JSC::JITDivGenerator::endJumpList): (JSC::JITDivGenerator::slowPathJumpList): * jit/JITInlines.h: (JSC::JIT::getOperandConstantDouble): Added. * jit/SnippetOperand.h: Added. (JSC::SnippetOperand::SnippetOperand): (JSC::SnippetOperand::mightBeNumber): (JSC::SnippetOperand::definitelyIsNumber): (JSC::SnippetOperand::isConst): (JSC::SnippetOperand::isConstInt32): (JSC::SnippetOperand::isConstDouble): (JSC::SnippetOperand::asRawBits): (JSC::SnippetOperand::asConstInt32): (JSC::SnippetOperand::asConstDouble): (JSC::SnippetOperand::setConstInt32): (JSC::SnippetOperand::setConstDouble): - The SnippetOperand encapsulates operand constness, const type, and profiling information. As a result: 1. The argument list to the JITDivGenerator constructor is now more concise. 2. The logic of the JITDivGenerator is now less verbose and easier to express. * parser/ResultType.h: (JSC::ResultType::isInt32): (JSC::ResultType::definitelyIsNumber): (JSC::ResultType::definitelyIsString): (JSC::ResultType::definitelyIsBoolean): (JSC::ResultType::mightBeNumber): (JSC::ResultType::isNotNumber): - Made these functions const because they were always meant to be const. This also allows me to enforce constness in the SnippetOperand. Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/jit/JIT.h trunk/Source/_javascript_Core/jit/JITArithmetic.cpp trunk/Source/_javascript_Core/jit/JITArithmetic32_64.cpp trunk/Source/_javascript_Core/jit/JITInlines.h trunk/Source/_javascript_Core/parser/ResultType.h Added Paths trunk/Source/_javascript_Core/jit/JITDivGenerator.cpp trunk/Source/_javascript_Core/jit/JITDivGenerator.h trunk/Source/_javascript_Core/jit/SnippetOperand.h Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (192835 => 192836) --- trunk/Source/_javascript_Core/CMakeLists.txt 2015-11-30 23:06:27 UTC (rev 192835) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2015-11-30 23:13:41 UTC (rev 192836) @@ -455,6 +455,7 @@ jit/JITCall32_64.cpp jit/JITCode.cpp jit/JITDisassembler.cpp +jit/JITDivGenerator.cpp jit/JITExceptions.cpp jit/JITInlineCacheGenerator.cpp jit/JITMulGenerator.cpp Modified: trunk/Source/_javascript_Core/ChangeLog (192835 => 192836) --- trunk/Source/_javascript_Core/ChangeLog 2015-11-30 23:06:27 UTC (rev 192835) +++ trunk/Source/_javascript_Core/ChangeLog 2015-11-30 23:13:41 UTC (rev 192836) @@ -1,3 +1,67 @@ +2015-11-30 Mark Lam + +Snippefy op_div for the baseline JIT. +https://bugs.webkit.org/show_bug.cgi?id=151607 + +Reviewed by Geoffrey Garen. + +* CMakeLists.txt: +* _javascript_Core.vcxproj/_javascript_Core.vcxproj: +* _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters: +* _javascript_Core.xcodeproj/project.pbxproj: + +* jit/JIT.h: +* jit/JITArithmetic.cpp: +(JSC::JIT::emit_op_div): +(JSC::JIT::emitSlow_op_div): +(JSC::JIT::compileBinaryArithOpSlowCase): Deleted. + +* jit/JITArithmetic32_64.cpp: +(JSC::JIT::emitBinaryDoubleOp): +(JSC::JIT::emit_op_div): Deleted. +(JSC::JIT::emitSlow_op_div): Deleted. +- Removed the 32-bit specific op_div implementation. The 64-bit version with the + op_div snippet can now service both 32-bit and 64-bit. + +* jit/JITDivGenerator.cpp: Added. +(JSC::JITDivGenerator::loadOperand): +(JSC::JITDivGenerator::generateFastPath): +* jit/JITDivGenerator.h: Added. +(JSC::JITDivGenerator::JITDivGenerator): +(JSC::JITDivGenerator::didEmitF
[webkit-changes] [192835] trunk/PerformanceTests
Title: [192835] trunk/PerformanceTests Revision 192835 Author commit-qu...@webkit.org Date 2015-11-30 15:06:27 -0800 (Mon, 30 Nov 2015) Log Message Fix the graphics benchmark complexity bounds adjustment https://bugs.webkit.org/show_bug.cgi?id=151670 Patch by Said Abou-Hallawa on 2015-11-30 Reviewed by Simon Fraser. Make sure the graphics benchmark complexity bounds adjustment is applied to the absolute lower bound. * Animometer/tests/resources/math.js: (PIDController.prototype._saturate): Modified Paths trunk/PerformanceTests/Animometer/tests/resources/math.js trunk/PerformanceTests/ChangeLog Diff Modified: trunk/PerformanceTests/Animometer/tests/resources/math.js (192834 => 192835) --- trunk/PerformanceTests/Animometer/tests/resources/math.js 2015-11-30 23:06:17 UTC (rev 192834) +++ trunk/PerformanceTests/Animometer/tests/resources/math.js 2015-11-30 23:06:27 UTC (rev 192835) @@ -391,9 +391,10 @@ break; case PIDController.stages.SATURATE: +const limitPercentage = 0.90; +var min = this._min > 0 ? Math.min(this._min, this._max * limitPercentage) : this._min; +var max = this._max < 0 ? Math.max(this._max, this._min * limitPercentage) : this._max; var out = this._out + u; -var min = Math.min(this._min, this._max * 0.70); -var max = this._max; // Clip the controller output to the min-max values out = Math.max(Math.min(max, out), min); Modified: trunk/PerformanceTests/ChangeLog (192834 => 192835) --- trunk/PerformanceTests/ChangeLog 2015-11-30 23:06:17 UTC (rev 192834) +++ trunk/PerformanceTests/ChangeLog 2015-11-30 23:06:27 UTC (rev 192835) @@ -1,5 +1,18 @@ 2015-11-30 Said Abou-Hallawa +Fix the graphics benchmark complexity bounds adjustment +https://bugs.webkit.org/show_bug.cgi?id=151670 + +Reviewed by Simon Fraser. + +Make sure the graphics benchmark complexity bounds adjustment is applied +to the absolute lower bound. + +* Animometer/tests/resources/math.js: +(PIDController.prototype._saturate): + +2015-11-30 Said Abou-Hallawa + Add an option to select the results form the graphics benchmark https://bugs.webkit.org/show_bug.cgi?id=151666 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192834] trunk/Source
Title: [192834] trunk/Source Revision 192834 Author timothy_hor...@apple.com Date 2015-11-30 15:06:17 -0800 (Mon, 30 Nov 2015) Log Message Get rid of the !USE(ASYNC_NSTEXTINPUTCLIENT) codepath https://bugs.webkit.org/show_bug.cgi?id=151673 Reviewed by Anders Carlsson. Source/WebKit2: * UIProcess/API/Cocoa/WKWebView.mm: * UIProcess/API/mac/WKView.mm: * UIProcess/Cocoa/WebViewImpl.h: * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::resignFirstResponder): Deleted. (WebKit::WebViewImpl::interpretKeyEvent): Deleted. (WebKit::WebViewImpl::executeSavedKeypressCommands): Deleted. (WebKit::WebViewImpl::doCommandBySelector): Deleted. (WebKit::WebViewImpl::insertText): Deleted. (WebKit::WebViewImpl::inputContext): Deleted. (WebKit::WebViewImpl::selectedRange): Deleted. (WebKit::WebViewImpl::hasMarkedText): Deleted. (WebKit::WebViewImpl::unmarkText): Deleted. (WebKit::WebViewImpl::setMarkedText): Deleted. (WebKit::WebViewImpl::markedRange): Deleted. (WebKit::WebViewImpl::attributedSubstringForProposedRange): Deleted. (WebKit::WebViewImpl::characterIndexForPoint): Deleted. (WebKit::WebViewImpl::firstRectForCharacterRange): Deleted. (WebKit::WebViewImpl::performKeyEquivalent): Deleted. (WebKit::WebViewImpl::keyUp): Deleted. (WebKit::WebViewImpl::keyDown): Deleted. (WebKit::WebViewImpl::flagsChanged): Deleted. * UIProcess/PageClient.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Deleted. (WebKit::WebPageProxy::resetStateAfterProcessExited): Deleted. * UIProcess/WebPageProxy.h: * UIProcess/mac/PageClientImpl.h: * UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::notifyApplicationAboutInputContextChange): Deleted. * UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::setComposition): Deleted. (WebKit::WebPageProxy::confirmComposition): Deleted. (WebKit::WebPageProxy::insertText): Deleted. (WebKit::WebPageProxy::insertDictatedText): Deleted. (WebKit::WebPageProxy::getMarkedRange): Deleted. (WebKit::WebPageProxy::getSelectedRange): Deleted. (WebKit::WebPageProxy::getAttributedSubstringFromRange): Deleted. (WebKit::WebPageProxy::characterIndexForPoint): Deleted. (WebKit::WebPageProxy::firstRectForCharacterRange): Deleted. (WebKit::WebPageProxy::executeKeypressCommands): Deleted. (WebKit::WebPageProxy::cancelComposition): Deleted. (WebKit::WebPageProxy::editorStateChanged): Deleted. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didChangeSelection): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::setComposition): Deleted. (WebKit::WebPage::confirmComposition): Deleted. (WebKit::WebPage::insertText): Deleted. (WebKit::WebPage::insertDictatedText): Deleted. (WebKit::WebPage::getMarkedRange): Deleted. (WebKit::WebPage::getSelectedRange): Deleted. (WebKit::WebPage::getAttributedSubstringFromRange): Deleted. (WebKit::WebPage::characterIndexForPoint): Deleted. (WebKit::WebPage::firstRectForCharacterRange): Deleted. (WebKit::WebPage::executeKeypressCommands): Deleted. (WebKit::WebPage::cancelComposition): Deleted. Source/WTF: * wtf/Platform.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm trunk/Source/WebKit2/UIProcess/PageClient.h trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm Diff Modified: trunk/Source/WTF/ChangeLog (192833 => 192834) --- trunk/Source/WTF/ChangeLog 2015-11-30 23:02:00 UTC (rev 192833) +++ trunk/Source/WTF/ChangeLog 2015-11-30 23:06:17 UTC (rev 192834) @@ -1,3 +1,12 @@ +2015-11-30 Tim Horton + +Get rid of the !USE(ASYNC_NSTEXTINPUTCLIENT) codepath +https://bugs.webkit.org/show_bug.cgi?id=151673 + +Reviewed by Anders Carlsson. + +* wtf/Platform.h: + 2015-11-30 Carlos Garcia Campos [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource Modified: trunk/Source/WTF/wtf/Platform.h (192833 => 192834) --- trunk/Source/WTF/wtf/Platform.h 2015-11-30 23:02:00 UTC (rev 192833) +++ trunk/Source/WTF/wtf/Platform.h 2015-11-30 23:06:17 UTC (rev 192834) @@ -1110,10 +1110,6 @@ #define HAVE_NS_ACTIVITY 1 #endif -#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000 -#define USE_ASYNC_NSTEXTINPUTCLIENT 1 -#endif - #if (OS(DARWIN) && USE(CG)) || USE(FREETYPE) || (PLATFORM(WIN) && (USE(CG) || USE(CAIRO))) #undef ENABLE_OPENTYPE_MATH
[webkit-changes] [192833] trunk
Title: [192833] trunk Revision 192833 Author beid...@apple.com Date 2015-11-30 15:02:00 -0800 (Mon, 30 Nov 2015) Log Message Modern IDB: Set the correct source on the IDBRequest for cursor updates https://bugs.webkit.org/show_bug.cgi?id=151665 Reviewed by Andy Estes. Source/WebCore: No new tests (At least one existing failing test now passes). * Modules/indexeddb/client/IDBCursorImpl.cpp: (WebCore::IDBClient::IDBCursor::update): * Modules/indexeddb/client/IDBObjectStoreImpl.cpp: (WebCore::IDBClient::IDBObjectStore::putForCursorUpdate): (WebCore::IDBClient::IDBObjectStore::putOrAdd): * Modules/indexeddb/client/IDBObjectStoreImpl.h: * Modules/indexeddb/client/IDBRequestImpl.cpp: (WebCore::IDBClient::IDBRequest::IDBRequest): (WebCore::IDBClient::IDBRequest::setSource): * Modules/indexeddb/client/IDBRequestImpl.h: LayoutTests: * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.h trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.h Diff Modified: trunk/LayoutTests/ChangeLog (192832 => 192833) --- trunk/LayoutTests/ChangeLog 2015-11-30 22:21:57 UTC (rev 192832) +++ trunk/LayoutTests/ChangeLog 2015-11-30 23:02:00 UTC (rev 192833) @@ -1,3 +1,12 @@ +2015-11-30 Brady Eidson + +Modern IDB: Set the correct source on the IDBRequest for cursor updates +https://bugs.webkit.org/show_bug.cgi?id=151665 + +Reviewed by Andy Estes. + +* platform/mac-wk1/TestExpectations: + 2015-11-30 Ryan Haddad Marking fast/forms/state-restore-per-form.html as a flaky timeout on mac-wk2 Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192832 => 192833) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-11-30 22:21:57 UTC (rev 192832) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-11-30 23:02:00 UTC (rev 192833) @@ -72,6 +72,7 @@ # But Modern IndexedDB is. storage/indexeddb/aborted-versionchange-closes.html [ Pass ] +storage/indexeddb/cursor-cast.html [ Pass ] storage/indexeddb/cursor-finished.html [ Pass ] storage/indexeddb/modern [ Pass ] storage/indexeddb/mozilla/add-twice-failure.html [ Pass ] Modified: trunk/Source/WebCore/ChangeLog (192832 => 192833) --- trunk/Source/WebCore/ChangeLog 2015-11-30 22:21:57 UTC (rev 192832) +++ trunk/Source/WebCore/ChangeLog 2015-11-30 23:02:00 UTC (rev 192833) @@ -1,3 +1,25 @@ +2015-11-30 Brady Eidson + +Modern IDB: Set the correct source on the IDBRequest for cursor updates +https://bugs.webkit.org/show_bug.cgi?id=151665 + +Reviewed by Andy Estes. + +No new tests (At least one existing failing test now passes). + +* Modules/indexeddb/client/IDBCursorImpl.cpp: +(WebCore::IDBClient::IDBCursor::update): + +* Modules/indexeddb/client/IDBObjectStoreImpl.cpp: +(WebCore::IDBClient::IDBObjectStore::putForCursorUpdate): +(WebCore::IDBClient::IDBObjectStore::putOrAdd): +* Modules/indexeddb/client/IDBObjectStoreImpl.h: + +* Modules/indexeddb/client/IDBRequestImpl.cpp: +(WebCore::IDBClient::IDBRequest::IDBRequest): +(WebCore::IDBClient::IDBRequest::setSource): +* Modules/indexeddb/client/IDBRequestImpl.h: + 2015-11-30 Tim Horton Get rid of the legacy TextIndicatorWindow style Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp (192832 => 192833) --- trunk/Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp 2015-11-30 22:21:57 UTC (rev 192832) +++ trunk/Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp 2015-11-30 23:02:00 UTC (rev 192833) @@ -139,7 +139,9 @@ return nullptr; } -return effectiveObjectStore().putForCursorUpdate(exec, value.jsValue(), m_deprecatedCurrentPrimaryKey.jsValue(), ec); +auto request = effectiveObjectStore().putForCursorUpdate(exec, value.jsValue(), m_deprecatedCurrentPrimaryKey.jsValue(), ec); +request->setSource(*this); +return request; } void IDBCursor::advance(unsigned long count, ExceptionCode& ec) Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp (192832 => 192833) --- trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp 2015-11-30 22:21:57 UTC (rev 192832) +++ trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp 2015-11-30 23:02:00 UTC (rev 192833) @@ -223,12 +223,12 @@ return putOrAdd(state, value, nullptr, IndexedDB::ObjectStoreOverwriteMode::Overwrite, InlineKeyCheck::Perform, ec); } -RefPtr IDBObjectStore::putForCursorUpdate(JSC::ExecState& state, JSC::JSValue value, JSC::JSValue key, ExceptionC
[webkit-changes] [192830] trunk/Source/WebCore
Title: [192830] trunk/Source/WebCore Revision 192830 Author timothy_hor...@apple.com Date 2015-11-30 14:19:09 -0800 (Mon, 30 Nov 2015) Log Message Get rid of the legacy TextIndicatorWindow style https://bugs.webkit.org/show_bug.cgi?id=151674 Reviewed by Anders Carlsson. * page/TextIndicator.h: * page/mac/TextIndicatorWindow.mm: (-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]): Deleted. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/TextIndicator.h trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm Diff Modified: trunk/Source/WebCore/ChangeLog (192829 => 192830) --- trunk/Source/WebCore/ChangeLog 2015-11-30 22:17:58 UTC (rev 192829) +++ trunk/Source/WebCore/ChangeLog 2015-11-30 22:19:09 UTC (rev 192830) @@ -1,3 +1,14 @@ +2015-11-30 Tim Horton + +Get rid of the legacy TextIndicatorWindow style +https://bugs.webkit.org/show_bug.cgi?id=151674 + +Reviewed by Anders Carlsson. + +* page/TextIndicator.h: +* page/mac/TextIndicatorWindow.mm: +(-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]): Deleted. + 2015-11-30 Brady Eidson Modern IDB: Correct handling of cursors finishing iteration. Modified: trunk/Source/WebCore/page/TextIndicator.h (192829 => 192830) --- trunk/Source/WebCore/page/TextIndicator.h 2015-11-30 22:17:58 UTC (rev 192829) +++ trunk/Source/WebCore/page/TextIndicator.h 2015-11-30 22:19:09 UTC (rev 192830) @@ -32,12 +32,6 @@ #include #include -#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101000 -#define ENABLE_LEGACY_TEXT_INDICATOR_STYLE 1 -#else -#define ENABLE_LEGACY_TEXT_INDICATOR_STYLE 0 -#endif - namespace WebCore { class Frame; @@ -107,11 +101,7 @@ // FIXME: These are fairly Mac-specific, and they don't really belong here. // But they're needed at TextIndicator creation time, so they can't go in TextIndicatorWindow. // Maybe they can live in some Theme code somewhere? -#if ENABLE(LEGACY_TEXT_INDICATOR_STYLE) -constexpr static float defaultHorizontalMargin { 3 }; -#else constexpr static float defaultHorizontalMargin { 2 }; -#endif constexpr static float defaultVerticalMargin { 1 }; WEBCORE_EXPORT static Ref create(const TextIndicatorData&); Modified: trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm (192829 => 192830) --- trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm 2015-11-30 22:17:58 UTC (rev 192829) +++ trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm 2015-11-30 22:19:09 UTC (rev 192830) @@ -42,14 +42,6 @@ const CFTimeInterval timeBeforeFadeStarts = bounceAnimationDuration + 0.2; const CFTimeInterval fadeOutAnimationDuration = 0.3; -#if ENABLE(LEGACY_TEXT_INDICATOR_STYLE) -const CGFloat midBounceScale = 1.5; -const CGFloat borderWidth = 1.0; -const CGFloat cornerRadius = 3; -const CGFloat dropShadowOffsetX = 0; -const CGFloat dropShadowOffsetY = 1; -const CGFloat dropShadowBlurRadius = 1.5; -#else const CGFloat midBounceScale = 1.25; const CGFloat borderWidth = 0; const CGFloat cornerRadius = 0; @@ -57,7 +49,6 @@ const CGFloat dropShadowOffsetY = 1; const CGFloat dropShadowBlurRadius = 2; const CGFloat rimShadowBlurRadius = 1; -#endif NSString *textLayerKey = @"TextLayer"; NSString *dropShadowLayerKey = @"DropShadowLayer"; @@ -182,8 +173,6 @@ RetainPtr dropShadowColor = [NSColor colorWithDeviceWhite:0 alpha:0.2].CGColor; RetainPtr borderColor = [NSColor colorWithDeviceRed:.96 green:.90 blue:0 alpha:1].CGColor; -RetainPtr gradientDarkColor = [NSColor colorWithDeviceRed:.929 green:.8 blue:0 alpha:1].CGColor; -RetainPtr gradientLightColor = [NSColor colorWithDeviceRed:.949 green:.937 blue:0 alpha:1].CGColor; Vector textRectsInBoundingRectCoordinates = _textIndicator->textRectsInBoundingRectCoordinates(); @@ -222,7 +211,6 @@ [bounceLayer addSublayer:dropShadowLayer.get()]; [bounceLayer setValue:dropShadowLayer.get() forKey:dropShadowLayerKey]; -#if !ENABLE(LEGACY_TEXT_INDICATOR_STYLE) RetainPtr rimShadowLayer = adoptNS([[CALayer alloc] init]); [rimShadowLayer setDelegate:[WebActionDisablingCALayerDelegate shared]]; [rimShadowLayer setFrame:yellowHighlightRect]; @@ -234,14 +222,8 @@ [rimShadowLayer setFrame:yellowHighlightRect]; [bounceLayer addSublayer:rimShadowLayer.get()]; [bounceLayer setValue:rimShadowLayer.get() forKey:rimShadowLayerKey]; -#endif -#if ENABLE(LEGACY_TEXT_INDICATOR_STYLE) -RetainPtr textLayer = adoptNS([[CAGradientLayer alloc] init]); -[textLayer setColors:@[ (id)gradientLightColor.get(), (id)gradientDarkColor.get() ]]; -#else RetainPtr textLayer = adoptNS([[CALayer alloc] init]); -#endif [textLayer setBackgroundColor:highlightColor.get()]; [textLayer setBorderColor:borderColor.get()]; [textLayer setBorderWidth:borderWidth]; ___ webkit-ch
[webkit-changes] [192829] trunk/Source/WebKit2
Title: [192829] trunk/Source/WebKit2 Revision 192829 Author timothy_hor...@apple.com Date 2015-11-30 14:17:58 -0800 (Mon, 30 Nov 2015) Log Message Remove some unused synchronous drawing SPI https://bugs.webkit.org/show_bug.cgi?id=151672 Reviewed by Anders Carlsson. * UIProcess/API/Cocoa/WKViewPrivate.h: * UIProcess/API/mac/WKView.mm: (-[WKView forceAsyncDrawingAreaSizeUpdate:]): Deleted. (-[WKView waitForAsyncDrawingAreaSizeUpdate]): Deleted. * UIProcess/Cocoa/WebViewImpl.h: * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::forceAsyncDrawingAreaSizeUpdate): Deleted. (WebKit::WebViewImpl::waitForAsyncDrawingAreaSizeUpdate): Deleted. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (192828 => 192829) --- trunk/Source/WebKit2/ChangeLog 2015-11-30 22:15:27 UTC (rev 192828) +++ trunk/Source/WebKit2/ChangeLog 2015-11-30 22:17:58 UTC (rev 192829) @@ -1,5 +1,21 @@ 2015-11-30 Tim Horton +Remove some unused synchronous drawing SPI +https://bugs.webkit.org/show_bug.cgi?id=151672 + +Reviewed by Anders Carlsson. + +* UIProcess/API/Cocoa/WKViewPrivate.h: +* UIProcess/API/mac/WKView.mm: +(-[WKView forceAsyncDrawingAreaSizeUpdate:]): Deleted. +(-[WKView waitForAsyncDrawingAreaSizeUpdate]): Deleted. +* UIProcess/Cocoa/WebViewImpl.h: +* UIProcess/Cocoa/WebViewImpl.mm: +(WebKit::WebViewImpl::forceAsyncDrawingAreaSizeUpdate): Deleted. +(WebKit::WebViewImpl::waitForAsyncDrawingAreaSizeUpdate): Deleted. + +2015-11-30 Tim Horton + Get rid of the legacy swipe shadow style https://bugs.webkit.org/show_bug.cgi?id=151671 Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h (192828 => 192829) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h 2015-11-30 22:15:27 UTC (rev 192828) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h 2015-11-30 22:17:58 UTC (rev 192829) @@ -101,9 +101,6 @@ - (BOOL)windowOcclusionDetectionEnabled; - (void)setWindowOcclusionDetectionEnabled:(BOOL)flag; -- (void)forceAsyncDrawingAreaSizeUpdate:(NSSize)size; -- (void)waitForAsyncDrawingAreaSizeUpdate; - - (void)setMagnification:(double)magnification centeredAtPoint:(NSPoint)point; - (void)setAllowsLinkPreview:(BOOL)allowsLinkPreview; Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (192828 => 192829) --- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-11-30 22:15:27 UTC (rev 192828) +++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-11-30 22:17:58 UTC (rev 192829) @@ -1316,16 +1316,6 @@ return _data->_impl->pageExtendedBackgroundColor(); } -- (void)forceAsyncDrawingAreaSizeUpdate:(NSSize)size -{ -_data->_impl->forceAsyncDrawingAreaSizeUpdate(NSSizeToCGSize(size)); -} - -- (void)waitForAsyncDrawingAreaSizeUpdate -{ -_data->_impl->waitForAsyncDrawingAreaSizeUpdate(); -} - - (BOOL)isUsingUISideCompositing { return _data->_impl->isUsingUISideCompositing(); Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h (192828 => 192829) --- trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h 2015-11-30 22:15:27 UTC (rev 192828) +++ trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h 2015-11-30 22:17:58 UTC (rev 192829) @@ -147,8 +147,6 @@ std::unique_ptr createDrawingAreaProxy(); bool isUsingUISideCompositing() const; void setDrawingAreaSize(CGSize); -void forceAsyncDrawingAreaSizeUpdate(CGSize); -void waitForAsyncDrawingAreaSizeUpdate(); void updateLayer(); static bool wantsUpdateLayer() { return true; } Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm (192828 => 192829) --- trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm 2015-11-30 22:15:27 UTC (rev 192828) +++ trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm 2015-11-30 22:17:58 UTC (rev 192829) @@ -757,47 +757,6 @@ m_resizeScrollOffset = CGSizeZero; } -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Wmissing-noreturn" -// This method forces a drawing area geometry update, even if frame size updates are disabled. -// The updated is performed asynchronously; we don't wait for the geometry update before returning. -// The area drawn need not match the current frame size - if it differs it will be anchored to the -// frame according to the current contentAnchor. -void WebViewImpl::forceAsyncDrawingAreaSizeUpdate(CGSize size) -{ -// This SPI is only used on 10.9 and below, and is incompatible with the fence-based drawing area size synchronization in 10.10+. -#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 1090 -if (m_clipsToVisibleRect) -updateViewExposedRect(); -setDrawingAreaSize(size); - -// If a geometry update is pending the new updat
[webkit-changes] [192828] trunk/PerformanceTests
Title: [192828] trunk/PerformanceTests Revision 192828 Author commit-qu...@webkit.org Date 2015-11-30 14:15:27 -0800 (Mon, 30 Nov 2015) Log Message Add an option to select the results form the graphics benchmark https://bugs.webkit.org/show_bug.cgi?id=151666 Patch by Said Abou-Hallawa on 2015-11-30 Reviewed by Ryosuke Niwa. We need an easy way to select the graphics benchmark results table such that when it is copied to the clipboard, rich text format is set to the clipboard. * Animometer/runner/animometer.html: Add a new button to select the results table or JSON. * Animometer/runner/resources/animometer.js: (window.sectionsManager._sectionDataElement): Selects the container element. (window.sectionsManager._sectionDataDivElement): Replace a literal string with a string table entry. (window.sectionsManager.showTestName): Replace a literal string with a string table entry. (window.sectionsManager.selectData): Selects the container element in a selection. (window.sectionsManager.selectDataContents): Select the contents of container element in a selection. (window.benchmarkController.selectResults): Selects the results table. (window.benchmarkController.showJSON): Function rename. (window.benchmarkController.selectJSON): Selects the contents of the results JSON. (window.benchmarkController.showJson): Deleted. Modified Paths trunk/PerformanceTests/Animometer/runner/animometer.html trunk/PerformanceTests/Animometer/runner/resources/animometer.js trunk/PerformanceTests/ChangeLog Diff Modified: trunk/PerformanceTests/Animometer/runner/animometer.html (192827 => 192828) --- trunk/PerformanceTests/Animometer/runner/animometer.html 2015-11-30 22:15:18 UTC (rev 192827) +++ trunk/PerformanceTests/Animometer/runner/animometer.html 2015-11-30 22:15:27 UTC (rev 192828) @@ -55,7 +55,8 @@ -JSON +Select +JSON Test Again @@ -67,6 +68,7 @@ +Select Results Test Again @@ -79,6 +81,7 @@ +Select Results Test Again Modified: trunk/PerformanceTests/Animometer/runner/resources/animometer.js (192827 => 192828) --- trunk/PerformanceTests/Animometer/runner/resources/animometer.js 2015-11-30 22:15:18 UTC (rev 192827) +++ trunk/PerformanceTests/Animometer/runner/resources/animometer.js 2015-11-30 22:15:27 UTC (rev 192828) @@ -58,6 +58,11 @@ { return document.querySelector("#" + sectionIdentifier + " > header > h1"); }, + +_sectionDataElement: function(sectionIdentifier) +{ +return document.querySelector("#" + sectionIdentifier + " > data"); +}, _sectionDataDivElement: function(sectionIdentifier) { @@ -70,7 +75,7 @@ element.textContent = title + ":"; var score = benchmarkRunnerClient.score.toFixed(2); -element.textContent += " [Score = " + score + "]"; +element.textContent += " [" + Strings.text.score + " = " + score + "]"; }, showTestName: function(sectionIdentifier, title, testName) @@ -81,7 +86,7 @@ if (!testName.length) return; -element.textContent += " [test = " + testName + "]"; +element.textContent += " [" + Strings.text.testName + " = " + testName + "]"; }, showJSON: function(sectionIdentifier, json) @@ -94,6 +99,24 @@ }, 4); }, +selectData: function(sectionIdentifier) +{ +window.getSelection().removeAllRanges(); +var element = this._sectionDataElement(sectionIdentifier); +var range = document.createRange(); +range.selectNode(element); +window.getSelection().addRange(range); +}, + +selectDataContents: function(sectionIdentifier) +{ +window.getSelection().removeAllRanges(); +var element = this._sectionDataDivElement(sectionIdentifier); +var range = document.createRange(); +range.selectNodeContents(element); +window.getSelection().addRange(range); +}, + showSection: function(sectionIdentifier, pushState) { var currentSectionElement = document.querySelector("section.selected"); @@ -414,6 +437,11 @@ this._runBenchmark(suites, options); sectionsManager.showSection("running"); }, + +selectResults: function() +{ +sectionsManager.selectData("results"); +}, showResults: function() { @@ -421,12 +449,12 @@ sectionsManager.showSection("results", true); }, -showJson: function() +showJSON: function() { sectionsManager.showScore("json", Strings.text.results.results); sectionsManager.showSection("json", true); }, - +
[webkit-changes] [192827] trunk/LayoutTests
Title: [192827] trunk/LayoutTests Revision 192827 Author ryanhad...@apple.com Date 2015-11-30 14:15:18 -0800 (Mon, 30 Nov 2015) Log Message Marking fast/forms/state-restore-per-form.html as a flaky timeout on mac-wk2 https://bugs.webkit.org/show_bug.cgi?id=150542 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (192826 => 192827) --- trunk/LayoutTests/ChangeLog 2015-11-30 21:56:56 UTC (rev 192826) +++ trunk/LayoutTests/ChangeLog 2015-11-30 22:15:18 UTC (rev 192827) @@ -1,3 +1,12 @@ +2015-11-30 Ryan Haddad + +Marking fast/forms/state-restore-per-form.html as a flaky timeout on mac-wk2 +https://bugs.webkit.org/show_bug.cgi?id=150542 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2015-11-30 Brady Eidson Modern IDB: Correct handling of cursors finishing iteration. Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (192826 => 192827) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2015-11-30 21:56:56 UTC (rev 192826) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2015-11-30 22:15:18 UTC (rev 192827) @@ -283,6 +283,8 @@ webkit.org/b/151455 [ Yosemite ] http/tests/xmlhttprequest/workers/methods-async.html [ Pass Timeout ] webkit.org/b/151661 [ Yosemite ] http/tests/cache/disk-cache/disk-cache-request-max-stale.html [ Pass Timeout ] + +webkit.org/b/150542 fast/forms/state-restore-per-form.html [ Pass Timeout ] ### END OF (1) Classified failures with bug reports ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192826] trunk/Source/JavaScriptCore
Title: [192826] trunk/Source/_javascript_Core Revision 192826 Author benja...@webkit.org Date 2015-11-30 13:56:56 -0800 (Mon, 30 Nov 2015) Log Message [JSC] Simplify the loop that remove useless Air instructions https://bugs.webkit.org/show_bug.cgi?id=151652 Patch by Benjamin Poulain on 2015-11-30 Reviewed by Andreas Kling. * b3/air/AirEliminateDeadCode.cpp: (JSC::B3::Air::eliminateDeadCode): Use Vector's removeAllMatching() instead of custom code. It is likely faster too since we remove few values and Vector is good at doing that. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/b3/air/AirEliminateDeadCode.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (192825 => 192826) --- trunk/Source/_javascript_Core/ChangeLog 2015-11-30 21:51:06 UTC (rev 192825) +++ trunk/Source/_javascript_Core/ChangeLog 2015-11-30 21:56:56 UTC (rev 192826) @@ -1,3 +1,17 @@ +2015-11-30 Benjamin Poulain + +[JSC] Simplify the loop that remove useless Air instructions +https://bugs.webkit.org/show_bug.cgi?id=151652 + +Reviewed by Andreas Kling. + +* b3/air/AirEliminateDeadCode.cpp: +(JSC::B3::Air::eliminateDeadCode): +Use Vector's removeAllMatching() instead of custom code. + +It is likely faster too since we remove few values and Vector +is good at doing that. + 2015-11-30 Filip Pizlo B3 should be be clever about choosing which child to reuse for result in two-operand commutative operations Modified: trunk/Source/_javascript_Core/b3/air/AirEliminateDeadCode.cpp (192825 => 192826) --- trunk/Source/_javascript_Core/b3/air/AirEliminateDeadCode.cpp 2015-11-30 21:51:06 UTC (rev 192825) +++ trunk/Source/_javascript_Core/b3/air/AirEliminateDeadCode.cpp 2015-11-30 21:56:56 UTC (rev 192826) @@ -134,21 +134,15 @@ break; } -changed = false; +unsigned removedInstCount = 0; for (BasicBlock* block : code) { -unsigned sourceIndex = 0; -unsigned targetIndex = 0; -while (sourceIndex < block->size()) { -Inst inst = WTF::move(block->at(sourceIndex++)); -if (isInstLive(inst)) -block->at(targetIndex++) = WTF::move(inst); -else -changed = true; -} -block->resize(targetIndex); +removedInstCount += block->insts().removeAllMatching( +[&] (Inst& inst) -> bool { +return !isInstLive(inst); +}); } -return changed; +return !!removedInstCount; } } } } // namespace JSC::B3::Air ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192825] trunk
Title: [192825] trunk Revision 192825 Author beid...@apple.com Date 2015-11-30 13:51:06 -0800 (Mon, 30 Nov 2015) Log Message Modern IDB: Correct handling of cursors finishing iteration. https://bugs.webkit.org/show_bug.cgi?id=151664 Reviewed by Andy Estes. Source/WebCore: No new tests (At least one previously failing test now passes). * Modules/indexeddb/client/IDBCursorImpl.cpp: (WebCore::IDBClient::IDBCursor::setGetResult): * Modules/indexeddb/client/IDBObjectStoreImpl.cpp: (WebCore::IDBClient::IDBObjectStore::putOrAdd): LayoutTests: * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp Diff Modified: trunk/LayoutTests/ChangeLog (192824 => 192825) --- trunk/LayoutTests/ChangeLog 2015-11-30 21:50:04 UTC (rev 192824) +++ trunk/LayoutTests/ChangeLog 2015-11-30 21:51:06 UTC (rev 192825) @@ -1,3 +1,12 @@ +2015-11-30 Brady Eidson + +Modern IDB: Correct handling of cursors finishing iteration. +https://bugs.webkit.org/show_bug.cgi?id=151664 + +Reviewed by Andy Estes. + +* platform/mac-wk1/TestExpectations: + 2015-11-30 Myles C. Maxfield Unify font-variant-* with font-variant shorthand Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192824 => 192825) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-11-30 21:50:04 UTC (rev 192824) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-11-30 21:51:06 UTC (rev 192825) @@ -72,6 +72,7 @@ # But Modern IndexedDB is. storage/indexeddb/aborted-versionchange-closes.html [ Pass ] +storage/indexeddb/cursor-finished.html [ Pass ] storage/indexeddb/modern [ Pass ] storage/indexeddb/mozilla/add-twice-failure.html [ Pass ] storage/indexeddb/mozilla/autoincrement-indexes.html [ Pass ] Modified: trunk/Source/WebCore/ChangeLog (192824 => 192825) --- trunk/Source/WebCore/ChangeLog 2015-11-30 21:50:04 UTC (rev 192824) +++ trunk/Source/WebCore/ChangeLog 2015-11-30 21:51:06 UTC (rev 192825) @@ -1,3 +1,18 @@ +2015-11-30 Brady Eidson + +Modern IDB: Correct handling of cursors finishing iteration. +https://bugs.webkit.org/show_bug.cgi?id=151664 + +Reviewed by Andy Estes. + +No new tests (At least one previously failing test now passes). + +* Modules/indexeddb/client/IDBCursorImpl.cpp: +(WebCore::IDBClient::IDBCursor::setGetResult): + +* Modules/indexeddb/client/IDBObjectStoreImpl.cpp: +(WebCore::IDBClient::IDBObjectStore::putOrAdd): + 2015-11-30 Myles C. Maxfield Unify font-variant-* with font-variant shorthand Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp (192824 => 192825) --- trunk/Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp 2015-11-30 21:50:04 UTC (rev 192824) +++ trunk/Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp 2015-11-30 21:51:06 UTC (rev 192825) @@ -288,6 +288,16 @@ if (!context) return; +if (!getResult.isDefined()) { +m_deprecatedCurrentKey = { }; +m_deprecatedCurrentPrimaryKey = { }; +m_currentPrimaryKeyData = { }; +m_deprecatedCurrentValue = { }; + +m_gotValue = false; +return; +} + m_deprecatedCurrentKey = idbKeyDataToScriptValue(context, getResult.keyData()); m_deprecatedCurrentPrimaryKey = idbKeyDataToScriptValue(context, getResult.primaryKeyData()); m_currentPrimaryKeyData = getResult.primaryKeyData(); Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp (192824 => 192825) --- trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp 2015-11-30 21:50:04 UTC (rev 192824) +++ trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp 2015-11-30 21:51:06 UTC (rev 192825) @@ -233,34 +233,34 @@ LOG(IndexedDB, "IDBObjectStore::putOrAdd"); if (m_transaction->isReadOnly()) { -ec = static_cast(IDBExceptionCode::ReadOnlyError); +ec = IDBDatabaseException::ReadOnlyError; return nullptr; } if (!m_transaction->isActive()) { -ec = static_cast(IDBExceptionCode::TransactionInactiveError); +ec = IDBDatabaseException::TransactionInactiveError; return nullptr; } if (m_deleted) { -ec = INVALID_STATE_ERR; +ec = IDBDatabaseException::InvalidStateError; return nullptr; } RefPtr serializedValue = SerializedScriptValue::create(&state, value, nullptr, nullptr); if (state.hadException()) { -ec = DATA_CLONE_ERR; +ec = IDBDatabaseException::DataCloneError; return nullptr; } if (serializedValue->hasBlobURLs()) { // FIXME: Add Blob/File/FileList support -ec = DATA_CLONE_ERR; +ec =
[webkit-changes] [192824] trunk/Source/WebKit2
Title: [192824] trunk/Source/WebKit2 Revision 192824 Author timothy_hor...@apple.com Date 2015-11-30 13:50:04 -0800 (Mon, 30 Nov 2015) Log Message Get rid of the legacy swipe shadow style https://bugs.webkit.org/show_bug.cgi?id=151671 Reviewed by Anders Carlsson. * UIProcess/mac/ViewGestureControllerMac.mm: (WebKit::ViewGestureController::beginSwipeGesture): Deleted. (WebKit::ViewGestureController::handleSwipeGesture): Deleted. (WebKit::ViewGestureController::removeSwipeSnapshot): Deleted. It is no longer needed. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (192823 => 192824) --- trunk/Source/WebKit2/ChangeLog 2015-11-30 21:49:47 UTC (rev 192823) +++ trunk/Source/WebKit2/ChangeLog 2015-11-30 21:50:04 UTC (rev 192824) @@ -1,5 +1,18 @@ 2015-11-30 Tim Horton +Get rid of the legacy swipe shadow style +https://bugs.webkit.org/show_bug.cgi?id=151671 + +Reviewed by Anders Carlsson. + +* UIProcess/mac/ViewGestureControllerMac.mm: +(WebKit::ViewGestureController::beginSwipeGesture): Deleted. +(WebKit::ViewGestureController::handleSwipeGesture): Deleted. +(WebKit::ViewGestureController::removeSwipeSnapshot): Deleted. +It is no longer needed. + +2015-11-30 Tim Horton + [iOS] Option-up and Option-down should scroll a little less than a full page https://bugs.webkit.org/show_bug.cgi?id=151538 Modified: trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm (192823 => 192824) --- trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm 2015-11-30 21:49:47 UTC (rev 192823) +++ trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm 2015-11-30 21:50:04 UTC (rev 192824) @@ -48,12 +48,6 @@ using namespace WebCore; -#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101000 -#define ENABLE_LEGACY_SWIPE_SHADOW_STYLE 1 -#else -#define ENABLE_LEGACY_SWIPE_SHADOW_STYLE 0 -#endif - static const double minMagnification = 1; static const double maxMagnification = 3; @@ -66,14 +60,9 @@ static const float smartMagnificationElementPadding = 0.05; static const float smartMagnificationPanScrollThreshold = 100; -#if ENABLE(LEGACY_SWIPE_SHADOW_STYLE) -static const double swipeOverlayShadowOpacity = 0.66; -static const double swipeOverlayShadowRadius = 3; -#else static const double swipeOverlayShadowOpacity = 0.06; static const double swipeOverlayDimmingOpacity = 0.12; static const CGFloat swipeOverlayShadowWidth = 81; -#endif static const CGFloat minimumHorizontalSwipeDistance = 15; static const float minimumScrollEventRatioForSwipe = 0.5; @@ -611,23 +600,6 @@ // We don't know enough about the custom views' hierarchy to apply a shadow. if (m_swipeTransitionStyle == SwipeTransitionStyle::Overlap && m_customSwipeViews.isEmpty()) { -#if ENABLE(LEGACY_SWIPE_SHADOW_STYLE) -if (direction == SwipeDirection::Back) { -float topContentInset = m_webPageProxy.topContentInset(); -FloatRect shadowRect(FloatPoint(0, topContentInset), m_webPageProxy.viewSize() - FloatSize(0, topContentInset)); -RetainPtr shadowPath = adoptCF(CGPathCreateWithRect(shadowRect, 0)); -[rootContentLayer setShadowColor:CGColorGetConstantColor(kCGColorBlack)]; -[rootContentLayer setShadowOpacity:swipeOverlayShadowOpacity]; -[rootContentLayer setShadowRadius:swipeOverlayShadowRadius]; -[rootContentLayer setShadowPath:shadowPath.get()]; -} else { -RetainPtr shadowPath = adoptCF(CGPathCreateWithRect([m_swipeLayer bounds], 0)); -[m_swipeLayer setShadowColor:CGColorGetConstantColor(kCGColorBlack)]; -[m_swipeLayer setShadowOpacity:swipeOverlayShadowOpacity]; -[m_swipeLayer setShadowRadius:swipeOverlayShadowRadius]; -[m_swipeLayer setShadowPath:shadowPath.get()]; -} -#else FloatRect dimmingRect(FloatPoint(), m_webPageProxy.viewSize()); m_swipeDimmingLayer = adoptNS([[CALayer alloc] init]); [m_swipeDimmingLayer setName:@"Gesture Swipe Dimming Layer"]; @@ -691,7 +663,6 @@ [snapshotLayerParent insertSublayer:m_swipeDimmingLayer.get() below:m_swipeLayer.get()]; [snapshotLayerParent insertSublayer:m_swipeShadowLayer.get() above:m_swipeLayer.get()]; -#endif } } @@ -710,7 +681,6 @@ double swipingLayerOffset = floor(width * progress); -#if !ENABLE(LEGACY_SWIPE_SHADOW_STYLE) double dimmingProgress = (direction == SwipeDirection::Back) ? 1 - progress : -progress; dimmingProgress = std::min(1., std::max(dimmingProgress, 0.)); [m_swipeDimmingLayer setOpacity:dimmingProgress * swipeOverlayDimmingOpacity]; @@ -725,7 +695,6 @@ if (m_swipeTransitionStyle == SwipeTransitionStyle::Overlap) [m_swipeShadowLayer setTransform:CATransform3DMakeTranslation((direction == SwipeDire
[webkit-changes] [192823] tags/Safari-602.1.12.1/Source/WebCore
Title: [192823] tags/Safari-602.1.12.1/Source/WebCore Revision 192823 Author bshaf...@apple.com Date 2015-11-30 13:49:47 -0800 (Mon, 30 Nov 2015) Log Message Merged r192678. rdar://problem/23624934 Modified Paths tags/Safari-602.1.12.1/Source/WebCore/ChangeLog tags/Safari-602.1.12.1/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h Diff Modified: tags/Safari-602.1.12.1/Source/WebCore/ChangeLog (192822 => 192823) --- tags/Safari-602.1.12.1/Source/WebCore/ChangeLog 2015-11-30 21:48:50 UTC (rev 192822) +++ tags/Safari-602.1.12.1/Source/WebCore/ChangeLog 2015-11-30 21:49:47 UTC (rev 192823) @@ -1,5 +1,15 @@ 2015-11-30 Babak Shafiei +Merge r192678. + +2015-11-20 David Kilzer + +REGRESSION (r192460,r192677): Fix all the builds + +* platform/spi/cocoa/QuartzCoreSPI.h: Check different. + +2015-11-30 Babak Shafiei + Merge r192677. 2015-11-19 David Kilzer Modified: tags/Safari-602.1.12.1/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h (192822 => 192823) --- tags/Safari-602.1.12.1/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h 2015-11-30 21:48:50 UTC (rev 192822) +++ tags/Safari-602.1.12.1/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h 2015-11-30 21:49:47 UTC (rev 192823) @@ -196,10 +196,10 @@ EXTERN_C NSString * const kCAContextDisplayId; EXTERN_C NSString * const kCAContextIgnoresHitTest; -#if (PLATFORM(APPLETV) && __TV_OS_VERSION_MAX_ALLOWED < 9) \ -|| (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED < 3) \ -|| (PLATFORM(IOS) && TARGET_OS_IOS && __IPHONE_OS_VERSION_MAX_ALLOWED < 10) \ -|| (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101200) +#if (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED < 10) \ +|| (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED < 3) \ +|| (PLATFORM(IOS) && TARGET_OS_IOS && __IPHONE_OS_VERSION_MIN_REQUIRED < 10) \ +|| (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101200) @protocol CALayerDelegate @end ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192822] tags/Safari-602.1.12.1/Source/WebCore
Title: [192822] tags/Safari-602.1.12.1/Source/WebCore Revision 192822 Author bshaf...@apple.com Date 2015-11-30 13:48:50 -0800 (Mon, 30 Nov 2015) Log Message Merged r192677. rdar://problem/23624934 Modified Paths tags/Safari-602.1.12.1/Source/WebCore/ChangeLog tags/Safari-602.1.12.1/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h Diff Modified: tags/Safari-602.1.12.1/Source/WebCore/ChangeLog (192821 => 192822) --- tags/Safari-602.1.12.1/Source/WebCore/ChangeLog 2015-11-30 21:45:29 UTC (rev 192821) +++ tags/Safari-602.1.12.1/Source/WebCore/ChangeLog 2015-11-30 21:48:50 UTC (rev 192822) @@ -1,3 +1,14 @@ +2015-11-30 Babak Shafiei + +Merge r192677. + +2015-11-19 David Kilzer + +REGRESSION (r192460): Fix tvOS build again + +* platform/spi/cocoa/QuartzCoreSPI.h: Update version check. +This will probably need to be backed out in the future. + 2015-11-17 Carlos Garcia Campos Null dereference loading Blink layout test editing/execCommand/indent-button-crash.html Modified: tags/Safari-602.1.12.1/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h (192821 => 192822) --- tags/Safari-602.1.12.1/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h 2015-11-30 21:45:29 UTC (rev 192821) +++ tags/Safari-602.1.12.1/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h 2015-11-30 21:48:50 UTC (rev 192822) @@ -196,7 +196,7 @@ EXTERN_C NSString * const kCAContextDisplayId; EXTERN_C NSString * const kCAContextIgnoresHitTest; -#if (PLATFORM(APPLETV) && __TV_OS_VERSION_MAX_ALLOWED < 10) \ +#if (PLATFORM(APPLETV) && __TV_OS_VERSION_MAX_ALLOWED < 9) \ || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED < 3) \ || (PLATFORM(IOS) && TARGET_OS_IOS && __IPHONE_OS_VERSION_MAX_ALLOWED < 10) \ || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101200) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192821] tags/Safari-602.1.12.1/Source
Title: [192821] tags/Safari-602.1.12.1/Source Revision 192821 Author bshaf...@apple.com Date 2015-11-30 13:45:29 -0800 (Mon, 30 Nov 2015) Log Message Versioning. Modified Paths tags/Safari-602.1.12.1/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-602.1.12.1/Source/WebCore/Configurations/Version.xcconfig tags/Safari-602.1.12.1/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-602.1.12.1/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-602.1.12.1/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-602.1.12.1/Source/_javascript_Core/Configurations/Version.xcconfig (192820 => 192821) --- tags/Safari-602.1.12.1/Source/_javascript_Core/Configurations/Version.xcconfig 2015-11-30 21:40:46 UTC (rev 192820) +++ tags/Safari-602.1.12.1/Source/_javascript_Core/Configurations/Version.xcconfig 2015-11-30 21:45:29 UTC (rev 192821) @@ -24,9 +24,9 @@ MAJOR_VERSION = 602; MINOR_VERSION = 1; TINY_VERSION = 12; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-602.1.12.1/Source/WebCore/Configurations/Version.xcconfig (192820 => 192821) --- tags/Safari-602.1.12.1/Source/WebCore/Configurations/Version.xcconfig 2015-11-30 21:40:46 UTC (rev 192820) +++ tags/Safari-602.1.12.1/Source/WebCore/Configurations/Version.xcconfig 2015-11-30 21:45:29 UTC (rev 192821) @@ -24,9 +24,9 @@ MAJOR_VERSION = 602; MINOR_VERSION = 1; TINY_VERSION = 12; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-602.1.12.1/Source/WebInspectorUI/Configurations/Version.xcconfig (192820 => 192821) --- tags/Safari-602.1.12.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-11-30 21:40:46 UTC (rev 192820) +++ tags/Safari-602.1.12.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-11-30 21:45:29 UTC (rev 192821) @@ -1,9 +1,9 @@ MAJOR_VERSION = 602; MINOR_VERSION = 1; TINY_VERSION = 12; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Modified: tags/Safari-602.1.12.1/Source/WebKit/mac/Configurations/Version.xcconfig (192820 => 192821) --- tags/Safari-602.1.12.1/Source/WebKit/mac/Configurations/Version.xcconfig 2015-11-30 21:40:46 UTC (rev 192820) +++ tags/Safari-602.1.12.1/Source/WebKit/mac/Configurations/Version.xcconfig 2015-11-30 21:45:29 UTC (rev 192821) @@ -24,9 +24,9 @@ MAJOR_VERSION = 602; MINOR_VERSION = 1; TINY_VERSION = 12; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-602.1.12.1/Source/WebKit2/Configurations/Version.xcconfig (192820 => 192821) --- tags/Safari-602.1.12.1/Source/WebKit2/Configurations/Version.xcconfig 2015-11-30 21:40:46 UTC (rev 192820) +++ tags/Safari-602.1.12.1/Source/WebKit2/Configurations/Version.xcconfig 2015-11-30 21:45:29 UTC (rev 192821) @@ -24,9 +24,9 @@ MAJOR_VERSION = 602; MINOR_VERSION = 1; TINY_VERSION = 12; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192820] tags/Safari-602.1.12.1/
Title: [192820] tags/Safari-602.1.12.1/ Revision 192820 Author bshaf...@apple.com Date 2015-11-30 13:40:46 -0800 (Mon, 30 Nov 2015) Log Message New tag. Added Paths tags/Safari-602.1.12.1/ Diff Property changes: tags/Safari-602.1.12.1 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192819] trunk
Title: [192819] trunk Revision 192819 Author mmaxfi...@apple.com Date 2015-11-30 13:20:32 -0800 (Mon, 30 Nov 2015) Log Message Unify font-variant-* with font-variant shorthand https://bugs.webkit.org/show_bug.cgi?id=149773 Reviewed by Darin Adler. Source/WebCore: This patch makes font-variant a shorthand for the following properties: font-variant-ligatures font-variant-position font-variant-caps font-variant-numeric font-variant-alternates font-variant-east-asian This is consistent with the CSS Fonts Level 3 spec. This patch also migrates the "font" longhand to use the font-variant-caps property. Test: fast/text/font-variant-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::fontVariantEastAsianPropertyValue): Rename FontVariantEastAsian values. (WebCore::fontVariantFromStyle): We must consult with the longhand properties to determine font-variant computed style. (WebCore::ComputedStyleExtractor::propertyValue): Don't put any-old font-variant-caps inside the font shorthand. * css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Guard against incorrect downcasts (due to inherit of the new shorthand property). * css/CSSParser.cpp: Parse font-variant as a shorthand. Also implement its "normal" and "none" values. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseSystemFont): (WebCore::CSSParser::parseFontVariantLigatures): (WebCore::CSSParser::parseFontVariantNumeric): (WebCore::CSSParser::parseFontVariantEastAsian): (WebCore::CSSParser::parseFontVariant): (WebCore::isValidKeywordPropertyAndValue): Deleted. (WebCore::isKeywordPropertyID): Deleted. * css/CSSParser.h: * css/CSSPropertyNames.in: Turn font-variant into a shorthand property. * css/FontVariantBuilder.h: Guard against incorrect downcasts. Also update for renamed FontVariantEastAsian type. (WebCore::applyValueFontVariantLigatures): (WebCore::applyValueFontVariantNumeric): (WebCore::applyValueFontVariantEastAsian): * css/StyleProperties.cpp: Update to use the more specific property. (WebCore::StyleProperties::appendFontLonghandValueIfExplicit): (WebCore::StyleProperties::fontValue): (WebCore::StyleProperties::asText): * css/StyleResolver.cpp: Ditto. (WebCore::StyleResolver::isValidCueStyleProperty): * editing/EditingStyle.cpp: Ditto. * editing/cocoa/HTMLConverter.mm: Ditto. (HTMLConverterCaches::propertyValueForNode): (HTMLConverter::computedAttributesForElement): * editing/ios/EditorIOS.mm: Ditto. (WebCore::Editor::removeUnchangeableStyles): * html/canvas/CanvasRenderingContext2D.cpp: Ditto. (WebCore::CanvasRenderingContext2D::font): (WebCore::CanvasRenderingContext2D::setFont): * platform/graphics/FontCache.h: Removing duplicate cache key value. (WebCore::FontDescriptionKey::makeFlagsKey): * platform/graphics/FontCascade.cpp: Migrate to the new font-variant-caps from the old member variable. (WebCore::FontCascade::glyphDataForCharacter): * platform/graphics/FontCascade.h: Ditto. (WebCore::FontCascade::isSmallCaps): * platform/graphics/FontDescription.cpp: Ditto. (WebCore::FontDescription::FontDescription): * platform/graphics/FontDescription.h: Ditto. (WebCore::FontCascadeDescription::equalForTextAutoSizing): (WebCore::FontDescription::smallCaps): Deleted. (WebCore::FontDescription::setSmallCaps): Deleted. (WebCore::FontDescription::setIsSmallCaps): Deleted. (WebCore::FontDescription::operator==): Deleted. * platform/graphics/cocoa/FontCacheCoreText.cpp: Rename FontVariantEastAsianWidth. (WebCore::computeFeatureSettingsFromVariants): * platform/text/TextFlags.h: Ditto. (WebCore::FontVariantSettings::operator==): * rendering/RenderText.cpp: Migrage to the new font-variant-caps from the old member variable. (WebCore::RenderText::widthFromCache): LayoutTests: Update tests. Also temporarily skip existing font-features tests until https://bugs.webkit.org/show_bug.cgi?id=149774 is fixed. * css3/font-variant-parsing-expected.txt: * css3/font-variant-parsing.html: * fast/css/font-property-priority-expected.txt: * fast/css/font-shorthand-expected.txt: * fast/css/parsing-font-variant-ligatures-expected.txt: * fast/css/parsing-font-variant-ligatures.html: * fast/inspector-support/style-expected.txt: * fast/text/font-variant-shorthand-expected.txt: Added. * fast/text/font-variant-shorthand.html: Added. * platform/mac/TestExpectations: * platform/mac/fast/writing-mode/broken-ideograph-small-caps-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/font-variant-parsing-expected.txt trunk/LayoutTests/css3/font-variant-parsing.html trunk/LayoutTests/fast/css/font-property-priority-expected.txt trunk/LayoutTests/fast/css/font-shorthand-expected.txt trunk/LayoutTests/fast/css/parsing-font-variant-ligatures-expected.txt trunk/LayoutTests/fast/css/parsing-font-variant-ligatures.html trunk/LayoutTests/fast/inspector-support/style-expected.txt trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac/fast/writing-mode/broken-ideogr
[webkit-changes] [192818] trunk/Websites/perf.webkit.org
Title: [192818] trunk/Websites/perf.webkit.org Revision 192818 Author rn...@webkit.org Date 2015-11-30 13:12:43 -0800 (Mon, 30 Nov 2015) Log Message Perf dashboard should extend baseline and target to the future https://bugs.webkit.org/show_bug.cgi?id=151511 Reviewed by Darin Adler. * public/v2/data.js: (RunsData.prototype.timeSeriesByCommitTime): Added extendToFuture as an argument. (RunsData.prototype.timeSeriesByBuildTime): Ditto. (RunsData.prototype._timeSeriesByTimeInternal): Ditto. (TimeSeries): Add a new point to the end if extendToFuture is set and the series is not empty. * public/v2/manifest.js: (App.Manifest._formatFetchedData): Set extendToFuture to true for baselines and targets. Modified Paths trunk/Websites/perf.webkit.org/ChangeLog trunk/Websites/perf.webkit.org/public/v2/data.js trunk/Websites/perf.webkit.org/public/v2/manifest.js Diff Modified: trunk/Websites/perf.webkit.org/ChangeLog (192817 => 192818) --- trunk/Websites/perf.webkit.org/ChangeLog 2015-11-30 21:09:42 UTC (rev 192817) +++ trunk/Websites/perf.webkit.org/ChangeLog 2015-11-30 21:12:43 UTC (rev 192818) @@ -1,5 +1,20 @@ 2015-11-30 Ryosuke Niwa +Perf dashboard should extend baseline and target to the future +https://bugs.webkit.org/show_bug.cgi?id=151511 + +Reviewed by Darin Adler. + +* public/v2/data.js: +(RunsData.prototype.timeSeriesByCommitTime): Added extendToFuture as an argument. +(RunsData.prototype.timeSeriesByBuildTime): Ditto. +(RunsData.prototype._timeSeriesByTimeInternal): Ditto. +(TimeSeries): Add a new point to the end if extendToFuture is set and the series is not empty. +* public/v2/manifest.js: +(App.Manifest._formatFetchedData): Set extendToFuture to true for baselines and targets. + +2015-11-30 Ryosuke Niwa + Perf dashboard should always show comparison to baseline and target even if one is missing https://bugs.webkit.org/show_bug.cgi?id=151510 Modified: trunk/Websites/perf.webkit.org/public/v2/data.js (192817 => 192818) --- trunk/Websites/perf.webkit.org/public/v2/data.js 2015-11-30 21:09:42 UTC (rev 192817) +++ trunk/Websites/perf.webkit.org/public/v2/data.js 2015-11-30 21:12:43 UTC (rev 192818) @@ -323,17 +323,17 @@ return this._measurements.length; } -RunsData.prototype.timeSeriesByCommitTime = function (includeOutliers) +RunsData.prototype.timeSeriesByCommitTime = function (includeOutliers, extendToFuture) { -return this._timeSeriesByTimeInternal(true, includeOutliers); +return this._timeSeriesByTimeInternal(true, includeOutliers, extendToFuture); } -RunsData.prototype.timeSeriesByBuildTime = function (includeOutliers) +RunsData.prototype.timeSeriesByBuildTime = function (includeOutliers, extendToFuture) { -return this._timeSeriesByTimeInternal(false, includeOutliers); +return this._timeSeriesByTimeInternal(false, includeOutliers, extendToFuture); } -RunsData.prototype._timeSeriesByTimeInternal = function (useCommitType, includeOutliers) +RunsData.prototype._timeSeriesByTimeInternal = function (useCommitType, includeOutliers, extendToFuture) { var series = new Array(); var seriesIndex = 0; @@ -349,7 +349,7 @@ markedOutlier: measurement.markedOutlier(), }); } -return new TimeSeries(series); +return new TimeSeries(series, extendToFuture); } // FIXME: We need to devise a way to fetch runs in multiple chunks so that @@ -420,13 +420,26 @@ return unit != 'fps' && unit != '/s' && unit != 'pt'; } -function TimeSeries(series) +// FIXME: Extending the baseline/target to the future should be a server-side configuration. +function TimeSeries(series, extendToFuture) { this._series = series.sort(function (a, b) { var diff = a.time - b.time; return diff ? diff : a.secondaryTime - b.secondaryTime; }); +if (extendToFuture && this._series.length) { +var lastPoint = this._series[this._series.length - 1]; +this._series.push({ +measurement: lastPoint.measurement, +time: Date.now() + 24 * 3600 * 1000, +secondaryTime: Date.now() + 24 * 3600 * 1000, +value: lastPoint.value, +interval: lastPoint.interval, +markedOutlier: lastPoint.markedOutlier, +}); +} + var self = this; var min = undefined; var max = undefined; Modified: trunk/Websites/perf.webkit.org/public/v2/manifest.js (192817 => 192818) --- trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-11-30 21:09:42 UTC (rev 192817) +++ trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-11-30 21:12:43 UTC (rev 192818) @@ -365,12 +365,12 @@ var deltaFormatterWithoutSign = this._makeFormatter(unit, 2, false); var currentTimeSeries = configurations.current.timeSeriesByCommitTime(false); -var baselineTimeSeries = configurations.baseline ? configurations.baseline.timeSeriesByCom
[webkit-changes] [192817] trunk/Websites/perf.webkit.org
Title: [192817] trunk/Websites/perf.webkit.org Revision 192817 Author rn...@webkit.org Date 2015-11-30 13:09:42 -0800 (Mon, 30 Nov 2015) Log Message Perf dashboard should always show comparison to baseline and target even if one is missing https://bugs.webkit.org/show_bug.cgi?id=151510 Reviewed by Darin Adler. Show the comparison status against the baseline when baseline is present but target is missing. To make the code more readable, this patch splits the logic into three cases: 1. Both baseline and target are present 2. Only baseline is present 3. Only target is present Also extracted a helper function to construct the label. * public/v2/app.js: (.labelForDiff): Added. (App.Pane.computeStatus): Modified Paths trunk/Websites/perf.webkit.org/ChangeLog trunk/Websites/perf.webkit.org/public/v2/app.js Diff Modified: trunk/Websites/perf.webkit.org/ChangeLog (192816 => 192817) --- trunk/Websites/perf.webkit.org/ChangeLog 2015-11-30 21:05:25 UTC (rev 192816) +++ trunk/Websites/perf.webkit.org/ChangeLog 2015-11-30 21:09:42 UTC (rev 192817) @@ -1,3 +1,23 @@ +2015-11-30 Ryosuke Niwa + +Perf dashboard should always show comparison to baseline and target even if one is missing +https://bugs.webkit.org/show_bug.cgi?id=151510 + +Reviewed by Darin Adler. + +Show the comparison status against the baseline when baseline is present but target is missing. + +To make the code more readable, this patch splits the logic into three cases: +1. Both baseline and target are present +2. Only baseline is present +3. Only target is present + +Also extracted a helper function to construct the label. + +* public/v2/app.js: +(.labelForDiff): Added. +(App.Pane.computeStatus): + 2015-11-23 Commit Queue Unreviewed, rolling out r192716 and r192717. Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (192816 => 192817) --- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-11-30 21:05:25 UTC (rev 192816) +++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-11-30 21:09:42 UTC (rev 192817) @@ -486,15 +486,27 @@ var className = ''; var formatter = d3.format('.3p'); +function labelForDiff(diff, name) { return formatter(Math.abs(diff)) + ' ' + (diff > 0 ? 'above' : 'below') + ' ' + name; } + var smallerIsBetter = chartData.smallerIsBetter; -if (diffFromBaseline !== undefined && diffFromBaseline > 0 == smallerIsBetter) { -label = formatter(Math.abs(diffFromBaseline)) + ' ' + (smallerIsBetter ? 'above' : 'below') + ' baseline'; -className = 'worse'; -} else if (diffFromTarget !== undefined && diffFromTarget < 0 == smallerIsBetter) { -label = formatter(Math.abs(diffFromTarget)) + ' ' + (smallerIsBetter ? 'below' : 'above') + ' target'; -className = 'better'; -} else if (diffFromTarget !== undefined) -label = formatter(Math.abs(diffFromTarget)) + ' until target'; +if (diffFromBaseline !== undefined && diffFromTarget !== undefined) { +if (diffFromBaseline > 0 == smallerIsBetter) { +label = labelForDiff(diffFromBaseline, 'baseline'); +className = 'worse'; +} else if (diffFromTarget < 0 == smallerIsBetter) { +label = labelForDiff(diffFromBaseline, 'target'); +className = 'better'; +} else +label = formatter(Math.abs(diffFromTarget)) + ' until target'; +} else if (diffFromBaseline !== undefined) { +label = labelForDiff(diffFromBaseline, 'baseline'); +if (diffFromBaseline > 0 == smallerIsBetter) +className = 'worse'; +} else if (diffFromTarget !== undefined) { +label = labelForDiff(diffFromTarget, 'target'); +if (diffFromTarget < 0 == smallerIsBetter) +className = 'better'; +} var valueDelta = null; var relativeDelta = null; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192816] trunk/Source/JavaScriptCore
Title: [192816] trunk/Source/_javascript_Core Revision 192816 Author fpi...@apple.com Date 2015-11-30 13:05:25 -0800 (Mon, 30 Nov 2015) Log Message B3 should be be clever about choosing which child to reuse for result in two-operand commutative operations https://bugs.webkit.org/show_bug.cgi?id=151321 Reviewed by Geoffrey Garen. When lowering a commutative operation to a two-operand instruction, you have a choice of which child value to move into the result tmp. For example we might have: @x = Add(@y, @z) Assuming no three-operand add is available, we could either lower it to this: Move %y, %x Add %z, %x or to this: Move %z, %x Add %y, %x Which is better depends on the likelihood of coalescing with %x. If it's more likely that %y will coalesce with %x, then we want to use the first form. Otherwise, we should use the second form. This implements two heuristics for selecting the right form, and makes those heuristics reusable within the B3->Air lowering by abstracting it as preferRightForResult(). For non-commutative operations we must use the first form, so the first form is the default. The heuristics are: - If the right child has only one user, then use the second form instead. This is profitable because that means that @z dies at the Add, so using the second form means that the Move will be coalesced away. - If one of the children is a Phi that this operation (the Add in this case) flows into via some Upsilon - possibly transitively through other Phis - then use the form that cases a Move on that child. This overrides everything else, and is meant to optimize variables that accumulate in a loop. This required adding a reusable PhiChildren analysis, so I wrote one. It has an API that is mostly based on iterators, and a higher-level API for looking at transitive children that is based on functors. I was originally implementing this for completeness, but when looking at how it interacted with imaging-gaussian-blur, I realized the need for some heuristic for the loop-accumulator case. This helps a lot on that benchmark. This widens the overall lead that B3 has on imaging-gaussian-blur, but steady-state runs that exclude compile latency still show a slight deficit. That will most likely get fixed by https://bugs.webkit.org/show_bug.cgi?id=151174. No new tests because the commutativity appears to be covered by existing tests, and anyway, there are no correctness implications to commuting a commutative operation. * CMakeLists.txt: * _javascript_Core.xcodeproj/project.pbxproj: * b3/B3LowerToAir.cpp: (JSC::B3::Air::LowerToAir::LowerToAir): (JSC::B3::Air::LowerToAir::canBeInternal): (JSC::B3::Air::LowerToAir::appendUnOp): (JSC::B3::Air::LowerToAir::preferRightForResult): (JSC::B3::Air::LowerToAir::appendBinOp): (JSC::B3::Air::LowerToAir::lower): * b3/B3PhiChildren.cpp: Added. (JSC::B3::PhiChildren::PhiChildren): (JSC::B3::PhiChildren::~PhiChildren): * b3/B3PhiChildren.h: Added. (JSC::B3::PhiChildren::ValueCollection::ValueCollection): (JSC::B3::PhiChildren::ValueCollection::size): (JSC::B3::PhiChildren::ValueCollection::at): (JSC::B3::PhiChildren::ValueCollection::operator[]): (JSC::B3::PhiChildren::ValueCollection::contains): (JSC::B3::PhiChildren::ValueCollection::iterator::iterator): (JSC::B3::PhiChildren::ValueCollection::iterator::operator*): (JSC::B3::PhiChildren::ValueCollection::iterator::operator++): (JSC::B3::PhiChildren::ValueCollection::iterator::operator==): (JSC::B3::PhiChildren::ValueCollection::iterator::operator!=): (JSC::B3::PhiChildren::ValueCollection::begin): (JSC::B3::PhiChildren::ValueCollection::end): (JSC::B3::PhiChildren::UpsilonCollection::UpsilonCollection): (JSC::B3::PhiChildren::UpsilonCollection::size): (JSC::B3::PhiChildren::UpsilonCollection::at): (JSC::B3::PhiChildren::UpsilonCollection::operator[]): (JSC::B3::PhiChildren::UpsilonCollection::contains): (JSC::B3::PhiChildren::UpsilonCollection::begin): (JSC::B3::PhiChildren::UpsilonCollection::end): (JSC::B3::PhiChildren::UpsilonCollection::values): (JSC::B3::PhiChildren::UpsilonCollection::forAllTransitiveIncomingValues): (JSC::B3::PhiChildren::UpsilonCollection::transitivelyUses): (JSC::B3::PhiChildren::at): (JSC::B3::PhiChildren::operator[]): * b3/B3Procedure.cpp: (JSC::B3::Procedure::Procedure): * b3/B3Procedure.h: * b3/B3UseCounts.cpp: (JSC::B3::UseCounts::UseCounts): * b3/B3UseCounts.h: (JSC::B3::UseCounts::numUses): (JSC::B3::UseCounts::numUsingInstructions): (JSC::B3::UseCounts::operator[]): Deleted. Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp trunk/Source/_javascript_Core/b3/B3UseCounts.cpp trunk/Source/_javascript_Core/b3/B3UseCounts.h Added Paths trunk/Source/_javascript_Core/b3/B3PhiChildren.cpp trunk/Source/_javascript_Core/b3/B3PhiChildren.h Diff Modified: trunk/Source/_javascri
[webkit-changes] [192815] trunk/Source/JavaScriptCore
Title: [192815] trunk/Source/_javascript_Core Revision 192815 Author fpi...@apple.com Date 2015-11-30 12:45:03 -0800 (Mon, 30 Nov 2015) Log Message REGRESSION(r192812): This change seems to have broken the iOS builds (Requested by ryanhaddad on #webkit). https://bugs.webkit.org/show_bug.cgi?id=151669 Unreviewed, fix build. * dfg/DFGCommon.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGCommon.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (192814 => 192815) --- trunk/Source/_javascript_Core/ChangeLog 2015-11-30 20:36:54 UTC (rev 192814) +++ trunk/Source/_javascript_Core/ChangeLog 2015-11-30 20:45:03 UTC (rev 192815) @@ -1,3 +1,12 @@ +2015-11-30 Filip Pizlo + +REGRESSION(r192812): This change seems to have broken the iOS builds (Requested by ryanhaddad on #webkit). +https://bugs.webkit.org/show_bug.cgi?id=151669 + +Unreviewed, fix build. + +* dfg/DFGCommon.h: + 2015-11-30 Saam barati implement op_get_rest_length so that we can allocate the rest array with the right size from the start Modified: trunk/Source/_javascript_Core/dfg/DFGCommon.h (192814 => 192815) --- trunk/Source/_javascript_Core/dfg/DFGCommon.h 2015-11-30 20:36:54 UTC (rev 192814) +++ trunk/Source/_javascript_Core/dfg/DFGCommon.h 2015-11-30 20:45:03 UTC (rev 192815) @@ -38,7 +38,7 @@ // We are in the middle of an experimental transition from LLVM to B3 as the backend for the FTL. We don't // yet know how it will turn out. For now, this flag will control whether FTL uses B3. Remember to set this // to 0 before committing! -#define FTL_USES_B3 1 +#define FTL_USES_B3 0 struct Node; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192814] trunk/Source/JavaScriptCore
Title: [192814] trunk/Source/_javascript_Core Revision 192814 Author sbar...@apple.com Date 2015-11-30 12:36:54 -0800 (Mon, 30 Nov 2015) Log Message implement op_get_rest_length so that we can allocate the rest array with the right size from the start https://bugs.webkit.org/show_bug.cgi?id=151467 Reviewed by Geoffrey Garen and Mark Lam. This patch implements op_get_rest_length which returns the length that the rest parameter array will be. We're implementing this because it might be a constant value in the presence of inlining in the DFG. We will take advantage of this optimization opportunity in a future patch: https://bugs.webkit.org/show_bug.cgi?id=151454 to emit better code for op_copy_rest. op_get_rest_length has two operands: 1) a destination 2) A constant indicating the number of parameters to skip when copying the rest array. op_get_rest_length lowers to a JSConstant node when we're inlined and not a varargs call (in this case, we statically know the arguments length). When that condition isn't met, we lower op_get_rest_length to GetRestArray. GetRestArray produces its result as an int32. * bytecode/BytecodeList.json: * bytecode/BytecodeUseDef.h: (JSC::computeUsesForBytecodeOffset): (JSC::computeDefsForBytecodeOffset): * bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpBytecode): * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitNewArray): (JSC::BytecodeGenerator::emitNewArrayWithSize): (JSC::BytecodeGenerator::emitNewFunction): (JSC::BytecodeGenerator::emitExpectedFunctionSnippet): (JSC::BytecodeGenerator::emitRestParameter): * bytecompiler/BytecodeGenerator.h: * bytecompiler/NodesCodegen.cpp: (JSC::RestParameterNode::emit): * dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter::executeEffects): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock): * dfg/DFGCapabilities.cpp: (JSC::DFG::capabilityLevel): * dfg/DFGClobberize.h: (JSC::DFG::clobberize): * dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): * dfg/DFGMayExit.cpp: (JSC::DFG::mayExit): * dfg/DFGNode.h: (JSC::DFG::Node::numberOfArgumentsToSkip): * dfg/DFGNodeType.h: * dfg/DFGOperations.cpp: * dfg/DFGOperations.h: * dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate): * dfg/DFGSafeToExecute.h: (JSC::DFG::safeToExecute): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileCopyRest): (JSC::DFG::SpeculativeJIT::compileGetRestLength): (JSC::DFG::SpeculativeJIT::compileNotifyWrite): * dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::callOperation): * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile): * ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::DFG::LowerDFGToLLVM::compileNode): (JSC::FTL::DFG::LowerDFGToLLVM::compileCopyRest): (JSC::FTL::DFG::LowerDFGToLLVM::compileGetRestLength): (JSC::FTL::DFG::LowerDFGToLLVM::compileNewObject): * jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): * jit/JIT.h: * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_copy_rest): (JSC::JIT::emit_op_get_rest_length): * llint/LowLevelInterpreter.asm: * llint/LowLevelInterpreter32_64.asm: * llint/LowLevelInterpreter64.asm: * runtime/CommonSlowPaths.cpp: (JSC::SLOW_PATH_DECL): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/BytecodeList.json trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGCapabilities.cpp trunk/Source/_javascript_Core/dfg/DFGClobberize.h trunk/Source/_javascript_Core/dfg/DFGDoesGC.cpp trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp trunk/Source/_javascript_Core/dfg/DFGMayExit.cpp trunk/Source/_javascript_Core/dfg/DFGNode.h trunk/Source/_javascript_Core/dfg/DFGNodeType.h trunk/Source/_javascript_Core/dfg/DFGOperations.cpp trunk/Source/_javascript_Core/dfg/DFGOperations.h trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp trunk/Source/_javascript_Core/jit/JIT.cpp trunk/Source/_javascript_Core/jit/JIT.h trunk/Source/_javascript_Core/jit/JITOpcodes.cpp trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm trunk/Source/_javasc
[webkit-changes] [192813] trunk
Title: [192813] trunk Revision 192813 Author beid...@apple.com Date 2015-11-30 12:12:07 -0800 (Mon, 30 Nov 2015) Log Message Modern IDB: After versionchange transactions abort, fire onerror on the original IDBOpenDBRequest. https://bugs.webkit.org/show_bug.cgi?id=151648 Reviewed by Andy Estes. Source/WebCore: No new tests. Covered by at least one existing failing test which now passes, and many other tests updated to fix their incorrect behavior. * Modules/indexeddb/client/IDBDatabaseImpl.cpp: (WebCore::IDBClient::IDBDatabase::transaction): (WebCore::IDBClient::IDBDatabase::willAbortTransaction): (WebCore::IDBClient::IDBDatabase::didAbortTransaction): * Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp: (WebCore::IDBClient::IDBOpenDBRequest::fireErrorAfterVersionChangeAbort): * Modules/indexeddb/client/IDBOpenDBRequestImpl.h: * Modules/indexeddb/client/IDBTransactionImpl.cpp: (WebCore::IDBClient::IDBTransaction::notifyDidAbort): (WebCore::IDBClient::IDBTransaction::didAbort): (WebCore::IDBClient::IDBTransaction::didCommit): * Modules/indexeddb/client/IDBTransactionImpl.h: LayoutTests: * platform/mac-wk1/TestExpectations: * storage/indexeddb/modern/abort-requests-cancelled-expected.txt: * storage/indexeddb/modern/abort-requests-cancelled.html: * storage/indexeddb/modern/aborted-put-expected.txt: * storage/indexeddb/modern/aborted-put.html: * storage/indexeddb/modern/createobjectstore-basic-expected.txt: * storage/indexeddb/modern/createobjectstore-basic.html: * storage/indexeddb/modern/deleteindex-2-expected.txt: * storage/indexeddb/modern/deleteindex-2.html: * storage/indexeddb/modern/deleteobjectstore-1-expected.txt: * storage/indexeddb/modern/deleteobjectstore-1.html: * storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt: * storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt: * storage/indexeddb/modern/versionchange-abort-then-reopen.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/LayoutTests/storage/indexeddb/modern/abort-requests-cancelled-expected.txt trunk/LayoutTests/storage/indexeddb/modern/abort-requests-cancelled.html trunk/LayoutTests/storage/indexeddb/modern/aborted-put-expected.txt trunk/LayoutTests/storage/indexeddb/modern/aborted-put.html trunk/LayoutTests/storage/indexeddb/modern/createobjectstore-basic-expected.txt trunk/LayoutTests/storage/indexeddb/modern/createobjectstore-basic.html trunk/LayoutTests/storage/indexeddb/modern/deleteindex-2-expected.txt trunk/LayoutTests/storage/indexeddb/modern/deleteindex-2.html trunk/LayoutTests/storage/indexeddb/modern/deleteobjectstore-1-expected.txt trunk/LayoutTests/storage/indexeddb/modern/deleteobjectstore-1.html trunk/LayoutTests/storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt trunk/LayoutTests/storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt trunk/LayoutTests/storage/indexeddb/modern/versionchange-abort-then-reopen.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.h Diff Modified: trunk/LayoutTests/ChangeLog (192812 => 192813) --- trunk/LayoutTests/ChangeLog 2015-11-30 20:07:18 UTC (rev 192812) +++ trunk/LayoutTests/ChangeLog 2015-11-30 20:12:07 UTC (rev 192813) @@ -1,3 +1,25 @@ +2015-11-30 Brady Eidson + +Modern IDB: After versionchange transactions abort, fire onerror on the original IDBOpenDBRequest. +https://bugs.webkit.org/show_bug.cgi?id=151648 + +Reviewed by Andy Estes. + +* platform/mac-wk1/TestExpectations: +* storage/indexeddb/modern/abort-requests-cancelled-expected.txt: +* storage/indexeddb/modern/abort-requests-cancelled.html: +* storage/indexeddb/modern/aborted-put-expected.txt: +* storage/indexeddb/modern/aborted-put.html: +* storage/indexeddb/modern/createobjectstore-basic-expected.txt: +* storage/indexeddb/modern/createobjectstore-basic.html: +* storage/indexeddb/modern/deleteindex-2-expected.txt: +* storage/indexeddb/modern/deleteindex-2.html: +* storage/indexeddb/modern/deleteobjectstore-1-expected.txt: +* storage/indexeddb/modern/deleteobjectstore-1.html: +* storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt: +* storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt: +* storage/indexeddb/modern/versionchange-abort-then-reopen.html: + 2015-11-30 Chris Dumez location.origin is undefined in a web worker Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192812 => 192813) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-11-30 20:07:18
[webkit-changes] [192812] trunk/Source/JavaScriptCore
Title: [192812] trunk/Source/_javascript_Core Revision 192812 Author fpi...@apple.com Date 2015-11-30 12:07:18 -0800 (Mon, 30 Nov 2015) Log Message MacroAssembler needs an API for disabling scratch registers https://bugs.webkit.org/show_bug.cgi?id=151010 Reviewed by Saam Barati and Michael Saboff. This adds two scope classes, DisallowMacroScratchRegisterUsage and AllowMacroScratchRegisterUsage. The default is that the scratch registers are enabled. Air disables them before generation. Henceforth the pattern inside B3 stackmap generator callbacks will be that you can only use AllowMacroScratchRegisterUsage if you've either supplied the scratch register as a clobbered register and arranged for all of the stackmap values to be late uses, or you're writing a test and you're OK with it being fragile with respect to scratch registers. The latter holds in most of testb3. * _javascript_Core.xcodeproj/project.pbxproj: * assembler/AbstractMacroAssembler.h: (JSC::optimizeForX86): (JSC::AbstractMacroAssembler::setTempRegisterValid): * assembler/AllowMacroScratchRegisterUsage.h: Added. (JSC::AllowMacroScratchRegisterUsage::AllowMacroScratchRegisterUsage): (JSC::AllowMacroScratchRegisterUsage::~AllowMacroScratchRegisterUsage): * assembler/DisallowMacroScratchRegisterUsage.h: Added. (JSC::DisallowMacroScratchRegisterUsage::DisallowMacroScratchRegisterUsage): (JSC::DisallowMacroScratchRegisterUsage::~DisallowMacroScratchRegisterUsage): * assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::scratchRegister): (JSC::MacroAssemblerX86Common::loadDouble): (JSC::MacroAssemblerX86Common::branchConvertDoubleToInt32): * assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::add32): (JSC::MacroAssemblerX86_64::and32): (JSC::MacroAssemblerX86_64::or32): (JSC::MacroAssemblerX86_64::sub32): (JSC::MacroAssemblerX86_64::load8): (JSC::MacroAssemblerX86_64::addDouble): (JSC::MacroAssemblerX86_64::convertInt32ToDouble): (JSC::MacroAssemblerX86_64::store32): (JSC::MacroAssemblerX86_64::store8): (JSC::MacroAssemblerX86_64::callWithSlowPathReturnType): (JSC::MacroAssemblerX86_64::call): (JSC::MacroAssemblerX86_64::jump): (JSC::MacroAssemblerX86_64::tailRecursiveCall): (JSC::MacroAssemblerX86_64::makeTailRecursiveCall): (JSC::MacroAssemblerX86_64::branchAdd32): (JSC::MacroAssemblerX86_64::add64): (JSC::MacroAssemblerX86_64::addPtrNoFlags): (JSC::MacroAssemblerX86_64::and64): (JSC::MacroAssemblerX86_64::lshift64): (JSC::MacroAssemblerX86_64::or64): (JSC::MacroAssemblerX86_64::sub64): (JSC::MacroAssemblerX86_64::store64): (JSC::MacroAssemblerX86_64::store64WithAddressOffsetPatch): (JSC::MacroAssemblerX86_64::branch64): (JSC::MacroAssemblerX86_64::branchPtr): (JSC::MacroAssemblerX86_64::branchTest64): (JSC::MacroAssemblerX86_64::test64): (JSC::MacroAssemblerX86_64::branchPtrWithPatch): (JSC::MacroAssemblerX86_64::branch32WithPatch): (JSC::MacroAssemblerX86_64::storePtrWithPatch): (JSC::MacroAssemblerX86_64::branch8): (JSC::MacroAssemblerX86_64::branchTest8): (JSC::MacroAssemblerX86_64::convertInt64ToDouble): (JSC::MacroAssemblerX86_64::readCallTarget): (JSC::MacroAssemblerX86_64::haveScratchRegisterForBlinding): (JSC::MacroAssemblerX86_64::scratchRegisterForBlinding): (JSC::MacroAssemblerX86_64::canJumpReplacePatchableBranchPtrWithPatch): (JSC::MacroAssemblerX86_64::canJumpReplacePatchableBranch32WithPatch): (JSC::MacroAssemblerX86_64::revertJumpReplacementToPatchableBranchPtrWithPatch): (JSC::MacroAssemblerX86_64::revertJumpReplacementToPatchableBranch32WithPatch): (JSC::MacroAssemblerX86_64::revertJumpReplacementToBranchPtrWithPatch): (JSC::MacroAssemblerX86_64::repatchCall): (JSC::MacroAssemblerX86_64::add64AndSetFlags): * b3/air/AirGenerate.cpp: (JSC::B3::Air::generate): * b3/testb3.cpp: (JSC::B3::testSimplePatchpoint): (JSC::B3::testSimplePatchpointWithoutOuputClobbersGPArgs): (JSC::B3::testSimplePatchpointWithOuputClobbersGPArgs): (JSC::B3::testSimplePatchpointWithoutOuputClobbersFPArgs): (JSC::B3::testSimplePatchpointWithOuputClobbersFPArgs): (JSC::B3::testPatchpointCallArg): (JSC::B3::testPatchpointFixedRegister): (JSC::B3::testPatchpointAny): (JSC::B3::testPatchpointAnyImm): (JSC::B3::testSimpleCheck): (JSC::B3::testCheckLessThan): (JSC::B3::testCheckMegaCombo): (JSC::B3::testCheckAddImm): (JSC::B3::testCheckAddImmCommute): (JSC::B3::testCheckAddImmSomeRegister): (JSC::B3::testCheckAdd): (JSC::B3::testCheckAdd64): (JSC::B3::testCheckAddFoldFail): (JSC::B3::testCheckSubImm): (JSC::B3::testCheckSubBadImm): (JSC::B3::testCheckSub): (JSC::B3::testCheckSub64): (JSC::B3::testCheckSubFoldFail): (JSC::B3::testCheckNeg): (JSC::B3::testCheckNeg64): (JSC::B3::testCheckMul): (JSC::B3::testCheckMulMemory): (JSC::B3::testCheckMul2): (JSC::B3::testCheckMul64): (JSC::B3::testCheckMulFoldFail): (JSC::B3::genericTestCompare): * dfg/DFGCommon.h: * jit/GPRInfo.h: (JSC::GPRInfo::toRegister): (JSC::GPRInfo::reservedRegisters): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript
[webkit-changes] [192811] trunk/Source/WebKit2
Title: [192811] trunk/Source/WebKit2 Revision 192811 Author timothy_hor...@apple.com Date 2015-11-30 11:52:46 -0800 (Mon, 30 Nov 2015) Log Message [iOS] Option-up and Option-down should scroll a little less than a full page https://bugs.webkit.org/show_bug.cgi?id=151538 Reviewed by Simon Fraser. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _scrollOffsetForEvent:]): (-[WKContentView _interpretKeyEvent:isCharEvent:]): Clean up the code a little, and adjust so that we *always* use pageStep instead of just scrolling by the unobscured rect when scrolling by a page. Previously, we did for the spacebar, but not for option-up and option-down. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (192810 => 192811) --- trunk/Source/WebKit2/ChangeLog 2015-11-30 19:27:26 UTC (rev 192810) +++ trunk/Source/WebKit2/ChangeLog 2015-11-30 19:52:46 UTC (rev 192811) @@ -1,3 +1,18 @@ +2015-11-30 Tim Horton + +[iOS] Option-up and Option-down should scroll a little less than a full page +https://bugs.webkit.org/show_bug.cgi?id=151538 + + +Reviewed by Simon Fraser. + +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView _scrollOffsetForEvent:]): +(-[WKContentView _interpretKeyEvent:isCharEvent:]): +Clean up the code a little, and adjust so that we *always* use pageStep +instead of just scrolling by the unobscured rect when scrolling by a page. +Previously, we did for the spacebar, but not for option-up and option-down. + 2015-11-30 Brian Burg Web Inspector: using "Reload Web Inspector" when docked breaks dock-specific styles Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (192810 => 192811) --- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-11-30 19:27:26 UTC (rev 192810) +++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-11-30 19:52:46 UTC (rev 192811) @@ -2865,6 +2865,70 @@ _uiEventBeingResent = nil; } +- (Optional)_scrollOffsetForEvent:(WebIOSEvent *)event +{ +static const unsigned kWebSpaceKey = 0x20; + +if (_page->editorState().isContentEditable) +return Nullopt; + +NSString *charactersIgnoringModifiers = event.charactersIgnoringModifiers; +if (!charactersIgnoringModifiers.length) +return Nullopt; + +enum ScrollingIncrement { Document, Page, Line }; +enum ScrollingDirection { Up, Down, Left, Right }; + +auto computeOffset = ^(ScrollingIncrement increment, ScrollingDirection direction) { +bool isHorizontal = (direction == Left || direction == Right); + +CGFloat scrollDistance = ^ CGFloat { +switch (increment) { +case Document: +ASSERT(!isHorizontal); +return self.bounds.size.height; +case Page: +ASSERT(!isHorizontal); +return Scrollbar::pageStep(_page->unobscuredContentRect().height(), self.bounds.size.height); +case Line: +return Scrollbar::pixelsPerLineStep(); +} +ASSERT_NOT_REACHED(); +return 0; +}(); + +if (direction == Up || direction == Left) +scrollDistance = -scrollDistance; + +return (isHorizontal ? FloatPoint(scrollDistance, 0) : FloatPoint(0, scrollDistance)); +}; + +if ([charactersIgnoringModifiers isEqualToString:UIKeyInputLeftArrow]) +return computeOffset(Line, Left); +if ([charactersIgnoringModifiers isEqualToString:UIKeyInputRightArrow]) +return computeOffset(Line, Right); + +ScrollingIncrement incrementForVerticalArrowKey = Line; +if (event.modifierFlags & WebEventFlagMaskAlternate) +incrementForVerticalArrowKey = Page; +else if (event.modifierFlags & WebEventFlagMaskCommand) +incrementForVerticalArrowKey = Document; +if ([charactersIgnoringModifiers isEqualToString:UIKeyInputUpArrow]) +return computeOffset(incrementForVerticalArrowKey, Up); +if ([charactersIgnoringModifiers isEqualToString:UIKeyInputDownArrow]) +return computeOffset(incrementForVerticalArrowKey, Down); + +if ([charactersIgnoringModifiers isEqualToString:UIKeyInputPageDown]) +return computeOffset(Page, Down); +if ([charactersIgnoringModifiers isEqualToString:UIKeyInputPageUp]) +return computeOffset(Page, Up); + +if ([charactersIgnoringModifiers characterAtIndex:0] == kWebSpaceKey) +return computeOffset(Page, (event.modifierFlags & WebEventFlagMaskShift) ? Up : Down); + +return Nullopt; +} + - (BOOL)_interpretKeyEvent:(WebIOSEvent *)event isCharEvent:(BOOL)isCharEvent { static const unsigned kWebEnterKey = 0x0003; @@ -2875,52 +2939,19 @@ static const unsigned kWebSpaceKey = 0x20; BOOL contentEditable = _page->editorState().i
[webkit-changes] [192810] trunk
Title: [192810] trunk Revision 192810 Author cdu...@apple.com Date 2015-11-30 11:27:26 -0800 (Mon, 30 Nov 2015) Log Message location.origin is undefined in a web worker https://bugs.webkit.org/show_bug.cgi?id=151614 Reviewed by Darin Adler. Source/WebCore: Expose location.origin to web workers, as per: https://html.spec.whatwg.org/multipage/workers.html#workerlocation This behavior is consistent with the behavior of Firefox and Chrome. Test: fast/workers/worker-location.html * workers/WorkerLocation.cpp: (WebCore::WorkerLocation::origin): * workers/WorkerLocation.h: * workers/WorkerLocation.idl: LayoutTests: Update existing layout test to confirm the existence of location.origin when in a WorkerGlobalScope. * fast/workers/resources/worker-location.js: * fast/workers/worker-location-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/workers/resources/worker-location.js trunk/LayoutTests/fast/workers/worker-location-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/WorkerLocation.cpp trunk/Source/WebCore/workers/WorkerLocation.h trunk/Source/WebCore/workers/WorkerLocation.idl Diff Modified: trunk/LayoutTests/ChangeLog (192809 => 192810) --- trunk/LayoutTests/ChangeLog 2015-11-30 19:25:12 UTC (rev 192809) +++ trunk/LayoutTests/ChangeLog 2015-11-30 19:27:26 UTC (rev 192810) @@ -1,3 +1,16 @@ +2015-11-30 Chris Dumez + +location.origin is undefined in a web worker +https://bugs.webkit.org/show_bug.cgi?id=151614 + +Reviewed by Darin Adler. + +Update existing layout test to confirm the existence of location.origin when in a +WorkerGlobalScope. + +* fast/workers/resources/worker-location.js: +* fast/workers/worker-location-expected.txt: + 2015-11-30 Brady Eidson Modern IDB: Support updating cursor values when the object store uses inline keys. Modified: trunk/LayoutTests/fast/workers/resources/worker-location.js (192809 => 192810) --- trunk/LayoutTests/fast/workers/resources/worker-location.js 2015-11-30 19:25:12 UTC (rev 192809) +++ trunk/LayoutTests/fast/workers/resources/worker-location.js 2015-11-30 19:27:26 UTC (rev 192810) @@ -30,6 +30,7 @@ worker.postMessage("eval location.pathname"); worker.postMessage("eval location.search"); worker.postMessage("eval location.hash"); +worker.postMessage("eval location.origin"); worker.postMessage("eval foo//bar"); worker._onmessage_ = function(evt) { Modified: trunk/LayoutTests/fast/workers/worker-location-expected.txt (192809 => 192810) --- trunk/LayoutTests/fast/workers/worker-location-expected.txt 2015-11-30 19:25:12 UTC (rev 192809) +++ trunk/LayoutTests/fast/workers/worker-location-expected.txt 2015-11-30 19:27:26 UTC (rev 192810) @@ -11,5 +11,6 @@ location.pathname: <...>/fast/workers/resources/worker-common.js location.search: location.hash: +location.origin: file:// DONE Modified: trunk/Source/WebCore/ChangeLog (192809 => 192810) --- trunk/Source/WebCore/ChangeLog 2015-11-30 19:25:12 UTC (rev 192809) +++ trunk/Source/WebCore/ChangeLog 2015-11-30 19:27:26 UTC (rev 192810) @@ -1,3 +1,22 @@ +2015-11-30 Chris Dumez + +location.origin is undefined in a web worker +https://bugs.webkit.org/show_bug.cgi?id=151614 + +Reviewed by Darin Adler. + +Expose location.origin to web workers, as per: +https://html.spec.whatwg.org/multipage/workers.html#workerlocation + +This behavior is consistent with the behavior of Firefox and Chrome. + +Test: fast/workers/worker-location.html + +* workers/WorkerLocation.cpp: +(WebCore::WorkerLocation::origin): +* workers/WorkerLocation.h: +* workers/WorkerLocation.idl: + 2015-11-30 Brady Eidson Modern IDB: Support updating cursor values when the object store uses inline keys. Modified: trunk/Source/WebCore/workers/WorkerLocation.cpp (192809 => 192810) --- trunk/Source/WebCore/workers/WorkerLocation.cpp 2015-11-30 19:25:12 UTC (rev 192809) +++ trunk/Source/WebCore/workers/WorkerLocation.cpp 2015-11-30 19:27:26 UTC (rev 192810) @@ -25,9 +25,9 @@ */ #include "config.h" - #include "WorkerLocation.h" +#include "SecurityOrigin.h" #include namespace WebCore { @@ -72,5 +72,9 @@ return m_url.fragmentIdentifier().isEmpty() ? emptyString() : "#" + m_url.fragmentIdentifier(); } +String WorkerLocation::origin() const +{ +return SecurityOrigin::create(m_url)->toString(); +} } // namespace WebCore Modified: trunk/Source/WebCore/workers/WorkerLocation.h (192809 => 192810) --- trunk/Source/WebCore/workers/WorkerLocation.h 2015-11-30 19:25:12 UTC (rev 192809) +++ trunk/Source/WebCore/workers/WorkerLocation.h 2015-11-30 19:27:26 UTC (rev 192810) @@ -54,6 +54,7 @@ String pathname() const; String search() const; String hash() const; +String origin() const; String toString() const { return href(); } Modified:
[webkit-changes] [192809] trunk/Source/WebKit2
Title: [192809] trunk/Source/WebKit2 Revision 192809 Author bb...@apple.com Date 2015-11-30 11:25:12 -0800 (Mon, 30 Nov 2015) Log Message Web Inspector: using "Reload Web Inspector" when docked breaks dock-specific styles https://bugs.webkit.org/show_bug.cgi?id=151642 Reviewed by Timothy Hatcher. After a frontend loads, explicitly tell it about the current dock state. This is necessary for force-reloading the inspector, since the dock state isn't sent from UIProcess in this case. * WebProcess/WebPage/WebInspectorUI.cpp: (WebKit::WebInspectorUI::frontendLoaded): (WebKit::WebInspectorUI::setDockingUnavailable): * WebProcess/WebPage/WebInspectorUI.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h Diff Modified: trunk/Source/WebKit2/ChangeLog (192808 => 192809) --- trunk/Source/WebKit2/ChangeLog 2015-11-30 19:11:09 UTC (rev 192808) +++ trunk/Source/WebKit2/ChangeLog 2015-11-30 19:25:12 UTC (rev 192809) @@ -1,3 +1,19 @@ +2015-11-30 Brian Burg + +Web Inspector: using "Reload Web Inspector" when docked breaks dock-specific styles +https://bugs.webkit.org/show_bug.cgi?id=151642 + +Reviewed by Timothy Hatcher. + +After a frontend loads, explicitly tell it about the current dock +state. This is necessary for force-reloading the inspector, since +the dock state isn't sent from UIProcess in this case. + +* WebProcess/WebPage/WebInspectorUI.cpp: +(WebKit::WebInspectorUI::frontendLoaded): +(WebKit::WebInspectorUI::setDockingUnavailable): +* WebProcess/WebPage/WebInspectorUI.h: + 2015-11-30 Alex Christensen Make ProcessModel always MultipleSecondaryProcesses Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp (192808 => 192809) --- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2015-11-30 19:11:09 UTC (rev 192808) +++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2015-11-30 19:25:12 UTC (rev 192809) @@ -91,6 +91,11 @@ { m_frontendAPIDispatcher.frontendLoaded(); +// Tell the new frontend about the current dock state. If the window object +// cleared due to a reload, the dock state won't be resent from UIProcess. +setDockingUnavailable(m_dockingUnavailable); +setDockSide(m_dockSide); + bringToFront(); } @@ -169,6 +174,7 @@ void WebInspectorUI::setDockingUnavailable(bool unavailable) { m_frontendAPIDispatcher.dispatchCommand(ASCIILiteral("setDockingUnavailable"), unavailable); +m_dockingUnavailable = unavailable; } void WebInspectorUI::changeAttachedWindowHeight(unsigned height) Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h (192808 => 192809) --- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h 2015-11-30 19:11:09 UTC (rev 192808) +++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h 2015-11-30 19:25:12 UTC (rev 192809) @@ -120,6 +120,7 @@ uint64_t m_inspectedPageIdentifier { 0 }; bool m_underTest { false }; +bool m_dockingUnavailable { false }; DockSide m_dockSide { DockSide::Undocked }; unsigned m_inspectionLevel { 1 }; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192808] trunk
Title: [192808] trunk Revision 192808 Author achristen...@apple.com Date 2015-11-30 11:11:09 -0800 (Mon, 30 Nov 2015) Log Message Make ProcessModel always MultipleSecondaryProcesses https://bugs.webkit.org/show_bug.cgi?id=151662 Reviewed by Antti Koivisto. Source/WebKit2: Single WebProcess behavior can still be achieved by setting the maximum number of WebProcesses to 1. * Shared/API/c/WKDeprecatedFunctions.cpp: (WKContextSetUsesNetworkProcess): (WKContextSetProcessModel): (WKContextGetProcessModel): (WKGraphicsContextGetCGContext): * UIProcess/API/APIProcessPoolConfiguration.cpp: (API::ProcessPoolConfiguration::createWithLegacyOptions): (API::ProcessPoolConfiguration::copy): * UIProcess/API/APIProcessPoolConfiguration.h: * UIProcess/API/C/WKAPICast.h: (WebKit::toAPI): (WebKit::toFontSmoothingLevel): (WebKit::toProcessModel): Deleted. * UIProcess/API/C/WKContext.cpp: (WKContextGetCacheModel): (WKContextSetMaximumNumberOfProcesses): (WKContextSetProcessModel): Deleted. (WKContextGetProcessModel): Deleted. * UIProcess/API/C/WKContext.h: * UIProcess/API/Cocoa/WKProcessGroup.mm: (-[WKProcessGroup initWithInjectedBundleURL:]): * UIProcess/API/Cocoa/WKProcessPool.mm: * UIProcess/API/efl/ewk_context.cpp: (EwkContext::cacheModel): (EwkContext::setProcessModel): (EwkContext::processModel): (EwkContext::clearResourceCache): (EwkContext::jsGlobalContext): (ewk_context_message_from_extensions_callback_set): (ewk_context_process_model_set): (ewk_context_process_model_get): (ewk_context_tls_error_policy_get): (toWKProcessModel): Deleted. (toEwkProcessModel): Deleted. * UIProcess/API/gtk/WebKitWebContext.cpp: * UIProcess/ProcessModel.h: Removed. * UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::shouldTerminate): (WebKit::WebCookieManagerProxy::refWebContextSupplement): * UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::inspectorProcessPool): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcess): * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::create): (WebKit::WebProcessPool::setDownloadClient): (WebKit::WebProcessPool::setMaximumNumberOfProcesses): (WebKit::WebProcessPool::processDidCachePage): (WebKit::WebProcessPool::createNewWebProcess): (WebKit::WebProcessPool::disconnectProcess): (WebKit::WebProcessPool::createWebPage): (WebKit::WebProcessPool::postMessageToInjectedBundle): (WebKit::WebProcessPool::requestWebContentStatistics): (WebKit::WebProcessPool::requestNetworkingStatistics): (WebKit::WebProcessPool::setProcessModel): Deleted. (WebKit::WebProcessPool::ensureSharedWebProcess): Deleted. * UIProcess/WebProcessPool.h: (WebKit::WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary): (WebKit::WebProcessPool::sendToOneProcess): * WebKit2.xcodeproj/project.pbxproj: Tools: * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: (TestWebKitAPI::TEST): * WebKitTestRunner/TestController.cpp: (WTR::TestController::generatePageConfiguration): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/API/c/WKDeprecatedFunctions.cpp trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.cpp trunk/Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp trunk/Source/WebKit2/UIProcess/API/C/WKContext.h trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroup.mm trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp trunk/Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp trunk/Source/WebKit2/UIProcess/WebProcessPool.h trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKit2/Geolocation.cpp trunk/Tools/WebKitTestRunner/TestController.cpp Removed Paths trunk/Source/WebKit2/UIProcess/ProcessModel.h Diff Modified: trunk/Source/WebKit2/ChangeLog (192807 => 192808) --- trunk/Source/WebKit2/ChangeLog 2015-11-30 19:06:15 UTC (rev 192807) +++ trunk/Source/WebKit2/ChangeLog 2015-11-30 19:11:09 UTC (rev 192808) @@ -1,3 +1,73 @@ +2015-11-30 Alex Christensen + +Make ProcessModel always MultipleSecondaryProcesses +https://bugs.webkit.org/show_bug.cgi?id=151662 + +Reviewed by Antti Koivisto. + +Single WebProcess behavior can still be achieved by setting the maximum number of WebProcesses to 1. + +* Shared/API/c/WKDeprecatedFunctions.cpp: +(WKContextSetUsesNetworkProcess): +(WKContextSetProcessModel): +(WKContextGetProcessModel): +(WKGraphicsContextGetCGContext): +* UIProcess/API/APIProcessPoolConfiguration.cpp: +(API::ProcessPoolConfiguration::createWithLegacyOptions): +(API::ProcessPoolConfiguration::copy): +* UIProcess/API/APIProcessPoolConfiguration.h: +
[webkit-changes] [192807] trunk/Source/WebKit2
Title: [192807] trunk/Source/WebKit2 Revision 192807 Author cdu...@apple.com Date 2015-11-30 11:06:15 -0800 (Mon, 30 Nov 2015) Log Message [WK2][Cache] We should not speculatively revalidate transient resources https://bugs.webkit.org/show_bug.cgi?id=151402 Reviewed by Antti Koivisto. We should not speculatively revalidate transient resources. This patch adds a simple and conservative algorithm to detect that a subresource is transient and then ignores those when doing the speculative revalidation. The algorithm is question marks as transient all subresources that are not common to the 2 last loads of a main resource. This is not perfect as I see the number of non-speculative revalidations going up to 11-12 from 9 in the context of the warm PLT. However, it is best to be conservative at first and we can improve this later. * NetworkProcess/cache/NetworkCache.cpp: (WebKit::NetworkCache::Cache::retrieve): * NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp: (WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::create): (WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::~PendingFrameLoad): (WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::registerSubresource): (WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::markLoadAsCompleted): (WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::setExistingSubresourcesEntry): (WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::PendingFrameLoad): (WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::saveToDiskIfReady): (WebKit::NetworkCache::SpeculativeLoadManager::registerLoad): (WebKit::NetworkCache::SpeculativeLoadManager::startSpeculativeRevalidation): (WebKit::NetworkCache::SpeculativeLoadManager::retrieveSubresourcesEntry): (WebKit::NetworkCache::SpeculativeLoadManager::retrieve): Deleted. (WebKit::NetworkCache::SpeculativeLoadManager::revalidateEntry): Deleted. * NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h: * NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp: (WebKit::NetworkCache::SubresourcesEntry::encodeAsStorageRecord): (WebKit::NetworkCache::SubresourcesEntry::decodeStorageRecord): (WebKit::NetworkCache::SubresourcesEntry::SubresourcesEntry): (WebKit::NetworkCache::SubresourcesEntry::updateSubresourceKeys): * NetworkProcess/cache/NetworkCacheSubresourcesEntry.h: (WebKit::NetworkCache::SubresourcesEntry::SubresourceInfo::encode): (WebKit::NetworkCache::SubresourcesEntry::SubresourceInfo::decode): (WebKit::NetworkCache::SubresourcesEntry::SubresourceInfo::SubresourceInfo): (WebKit::NetworkCache::SubresourcesEntry::subresources): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSubresourcesEntry.h Diff Modified: trunk/Source/WebKit2/ChangeLog (192806 => 192807) --- trunk/Source/WebKit2/ChangeLog 2015-11-30 19:05:05 UTC (rev 192806) +++ trunk/Source/WebKit2/ChangeLog 2015-11-30 19:06:15 UTC (rev 192807) @@ -1,3 +1,49 @@ +2015-11-30 Chris Dumez + +[WK2][Cache] We should not speculatively revalidate transient resources +https://bugs.webkit.org/show_bug.cgi?id=151402 + + +Reviewed by Antti Koivisto. + +We should not speculatively revalidate transient resources. This patch +adds a simple and conservative algorithm to detect that a subresource is +transient and then ignores those when doing the speculative revalidation. + +The algorithm is question marks as transient all subresources that are +not common to the 2 last loads of a main resource. + +This is not perfect as I see the number of non-speculative revalidations +going up to 11-12 from 9 in the context of the warm PLT. However, it is +best to be conservative at first and we can improve this later. + +* NetworkProcess/cache/NetworkCache.cpp: +(WebKit::NetworkCache::Cache::retrieve): +* NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp: +(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::create): +(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::~PendingFrameLoad): +(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::registerSubresource): +(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::markLoadAsCompleted): +(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::setExistingSubresourcesEntry): +(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::PendingFrameLoad): +(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::saveToDiskIfReady): +(WebKit::Ne
[webkit-changes] [192806] trunk
Title: [192806] trunk Revision 192806 Author beid...@apple.com Date 2015-11-30 11:05:05 -0800 (Mon, 30 Nov 2015) Log Message Modern IDB: Support updating cursor values when the object store uses inline keys. https://bugs.webkit.org/show_bug.cgi?id=151647 Reviewed by Andy Estes. Source/WebCore: No new tests (At least two previously failing tests now pass and are unskipped). * Modules/indexeddb/client/IDBCursorImpl.cpp: (WebCore::IDBClient::IDBCursor::update): Use putForCursorUpdate() instead of put() * Modules/indexeddb/client/IDBObjectStoreImpl.cpp: (WebCore::IDBClient::IDBObjectStore::add): (WebCore::IDBClient::IDBObjectStore::put): (WebCore::IDBClient::IDBObjectStore::putForCursorUpdate): Use the flag to skip the inline-key check. (WebCore::IDBClient::IDBObjectStore::putOrAdd): Add a flag to skip the inline-key check. * Modules/indexeddb/client/IDBObjectStoreImpl.h: LayoutTests: * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.h Diff Modified: trunk/LayoutTests/ChangeLog (192805 => 192806) --- trunk/LayoutTests/ChangeLog 2015-11-30 18:46:13 UTC (rev 192805) +++ trunk/LayoutTests/ChangeLog 2015-11-30 19:05:05 UTC (rev 192806) @@ -1,5 +1,14 @@ 2015-11-30 Brady Eidson +Modern IDB: Support updating cursor values when the object store uses inline keys. +https://bugs.webkit.org/show_bug.cgi?id=151647 + +Reviewed by Andy Estes. + +* platform/mac-wk1/TestExpectations: + +2015-11-30 Brady Eidson + Modern IDB: openCursor() fix resulting in at least 4 more passing tests. https://bugs.webkit.org/show_bug.cgi?id=151630 Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192805 => 192806) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-11-30 18:46:13 UTC (rev 192805) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-11-30 19:05:05 UTC (rev 192806) @@ -82,6 +82,7 @@ storage/indexeddb/mozilla/create-objectstore-null-name.html [ Pass ] storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html [ Pass ] storage/indexeddb/mozilla/cursor-mutation.html [ Pass ] +storage/indexeddb/mozilla/cursor-update-updates-indexes.html [ Pass ] storage/indexeddb/mozilla/delete-result.html [ Pass ] storage/indexeddb/mozilla/event-source.html [ Pass ] storage/indexeddb/mozilla/global-data.html [ Pass ] @@ -92,6 +93,7 @@ storage/indexeddb/mozilla/key-requirements.html [ Pass ] storage/indexeddb/mozilla/object-cursors.html [ Pass ] storage/indexeddb/mozilla/object-identity.html [ Pass ] +storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html [ Pass ] storage/indexeddb/mozilla/object-store-remove-values.html [ Pass ] storage/indexeddb/mozilla/objectstorenames.html [ Pass ] storage/indexeddb/mozilla/odd-result-order.html [ Pass ] Modified: trunk/Source/WebCore/ChangeLog (192805 => 192806) --- trunk/Source/WebCore/ChangeLog 2015-11-30 18:46:13 UTC (rev 192805) +++ trunk/Source/WebCore/ChangeLog 2015-11-30 19:05:05 UTC (rev 192806) @@ -1,5 +1,24 @@ 2015-11-30 Brady Eidson +Modern IDB: Support updating cursor values when the object store uses inline keys. +https://bugs.webkit.org/show_bug.cgi?id=151647 + +Reviewed by Andy Estes. + +No new tests (At least two previously failing tests now pass and are unskipped). + +* Modules/indexeddb/client/IDBCursorImpl.cpp: +(WebCore::IDBClient::IDBCursor::update): Use putForCursorUpdate() instead of put() + +* Modules/indexeddb/client/IDBObjectStoreImpl.cpp: +(WebCore::IDBClient::IDBObjectStore::add): +(WebCore::IDBClient::IDBObjectStore::put): +(WebCore::IDBClient::IDBObjectStore::putForCursorUpdate): Use the flag to skip the inline-key check. +(WebCore::IDBClient::IDBObjectStore::putOrAdd): Add a flag to skip the inline-key check. +* Modules/indexeddb/client/IDBObjectStoreImpl.h: + +2015-11-30 Brady Eidson + Modern IDB: Resolve flaky GC-vs-wrapper issue with IDBOpenDBRequest. https://bugs.webkit.org/show_bug.cgi?id=151645 Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp (192805 => 192806) --- trunk/Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp 2015-11-30 18:46:13 UTC (rev 192805) +++ trunk/Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp 2015-11-30 19:05:05 UTC (rev 192806) @@ -139,7 +139,7 @@ return nullptr; } -return effectiveObjectStore().put(exec, value.jsValue(), m_deprecatedCurrentPrimaryKey.jsValue(), ec); +return effectiveObjectStore().putForCursorUpdate(exec, value.jsValue(), m_deprecatedCurrentPrimaryKey.jsValue(), ec); }
[webkit-changes] [192805] trunk/Source/WebKit2
Title: [192805] trunk/Source/WebKit2 Revision 192805 Author bfulg...@apple.com Date 2015-11-30 10:46:13 -0800 (Mon, 30 Nov 2015) Log Message [Mac] Add font service permission to the sandbox profile https://bugs.webkit.org/show_bug.cgi?id=151509 Reviewed by Anders Carlsson. Update the sandbox profile for Mac WebKit to allow access to the "com.apple.fonts" service. * Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit2/ChangeLog (192804 => 192805) --- trunk/Source/WebKit2/ChangeLog 2015-11-30 18:26:56 UTC (rev 192804) +++ trunk/Source/WebKit2/ChangeLog 2015-11-30 18:46:13 UTC (rev 192805) @@ -1,3 +1,17 @@ +2015-11-30 Brent Fulgham + +[Mac] Add font service permission to the sandbox profile +https://bugs.webkit.org/show_bug.cgi?id=151509 + + +Reviewed by Anders Carlsson. + +Update the sandbox profile for Mac WebKit to allow access to the +"com.apple.fonts" service. + +* Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: +* WebProcess/com.apple.WebProcess.sb.in: + 2015-11-30 Alex Christensen Make usesNetworkProcess always true Modified: trunk/Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb (192804 => 192805) --- trunk/Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb 2015-11-30 18:26:56 UTC (rev 192804) +++ trunk/Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb 2015-11-30 18:46:13 UTC (rev 192805) @@ -231,6 +231,7 @@ (global-name "com.apple.cmio.VDCAssistant") (global-name "com.apple.cookied") ;; FIXME: Limit access to cookies. (global-name "com.apple.coreservices.launchservicesd") +(global-name "com.apple.fonts") (global-name "com.apple.ocspd") (global-name "com.apple.pasteboard.1") (global-name "com.apple.pbs.fetch_services") Modified: trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in (192804 => 192805) --- trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in 2015-11-30 18:26:56 UTC (rev 192804) +++ trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in 2015-11-30 18:46:13 UTC (rev 192805) @@ -183,6 +183,7 @@ (global-name "com.apple.awdd") (global-name "com.apple.cookied") (global-name "com.apple.dock.server") + (global-name "com.apple.fonts") (global-name "com.apple.system.opendirectoryd.api") (global-name "com.apple.tccd") (global-name "com.apple.tccd.system") ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192804] trunk/Source/WebInspectorUI
Title: [192804] trunk/Source/WebInspectorUI Revision 192804 Author bb...@apple.com Date 2015-11-30 10:26:56 -0800 (Mon, 30 Nov 2015) Log Message Web Inspector: delete-by-word and similar shortcuts should add text to the WebCore kill ring https://bugs.webkit.org/show_bug.cgi?id=151312 Reviewed by Darin Adler. Add support for other kill ring-eligible keybindinsg, such as deleting by word, group, or line forwards and backwards. * UserInterface/Controllers/CodeMirrorTextKillController.js: (WebInspector.CodeMirrorTextKillController): (WebInspector.CodeMirrorTextKillController.prototype._handleTextKillCommand): Renamed from _handleKillLine. Parameterize the function so it can handle any keybinding and command. Take a kill ring insertion mode argument, too. (WebInspector.CodeMirrorTextKillController.prototype._handleTextChange): Add some special casing for changes received from Delete Line (Cmd-D) so the right text is added to the kill ring. Thread the kill ring insertion mode to the frontend host call. (WebInspector.CodeMirrorTextKillController.prototype._handleKillLine): Deleted. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (192803 => 192804) --- trunk/Source/WebInspectorUI/ChangeLog 2015-11-30 18:24:25 UTC (rev 192803) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-11-30 18:26:56 UTC (rev 192804) @@ -1,3 +1,28 @@ +2015-11-30 Brian Burg + +Web Inspector: delete-by-word and similar shortcuts should add text to the WebCore kill ring +https://bugs.webkit.org/show_bug.cgi?id=151312 + +Reviewed by Darin Adler. + +Add support for other kill ring-eligible keybindinsg, such as +deleting by word, group, or line forwards and backwards. + +* UserInterface/Controllers/CodeMirrorTextKillController.js: +(WebInspector.CodeMirrorTextKillController): +(WebInspector.CodeMirrorTextKillController.prototype._handleTextKillCommand): Renamed from _handleKillLine. + +Parameterize the function so it can handle any keybinding and +command. Take a kill ring insertion mode argument, too. + +(WebInspector.CodeMirrorTextKillController.prototype._handleTextChange): + +Add some special casing for changes received from Delete Line +(Cmd-D) so the right text is added to the kill ring. Thread the +kill ring insertion mode to the frontend host call. + +(WebInspector.CodeMirrorTextKillController.prototype._handleKillLine): Deleted. + 2015-11-29 Brian Burg Web Inspector: Add context menu item to Reload the Inspector Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js (192803 => 192804) --- trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js 2015-11-30 18:24:25 UTC (rev 192803) +++ trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js 2015-11-30 18:26:56 UTC (rev 192804) @@ -34,30 +34,44 @@ this._codeMirror = codeMirror; this._expectingChangeEventForKill = false; this._nextKillStartsNewSequence = true; +this._shouldPrependToKillRing = false; this._handleTextChangeListener = this._handleTextChange.bind(this); this._handleEditorBlurListener = this._handleEditorBlur.bind(this); this._handleSelectionOrCaretChangeListener = this._handleSelectionOrCaretChange.bind(this); +// FIXME: these keybindings match CodeMirror's default keymap for OS X. +// They should probably be altered for Windows / Linux someday. this._codeMirror.addKeyMap({ -"Ctrl-K": this._handleKillLine.bind(this), +// Overrides for the 'emacsy' keymap. +"Ctrl-K": this._handleTextKillCommand.bind(this, "killLine", false), +"Alt-D": this._handleTextKillCommand.bind(this, "delWordAfter", false), +"Cmd-D": this._handleTextKillCommand.bind(this, "deleteLine", false), +// Overrides for the 'macDefault' keymap. +"Alt-Delete": this._handleTextKillCommand.bind(this, "delGroupAfter", false), +"Cmd-Backspace": this._handleTextKillCommand.bind(this, "delWrappedLineLeft", true), +"Cmd-Delete": this._handleTextKillCommand.bind(this, "delWrappedLineRight", false), +"Alt-Backspace": this._handleTextKillCommand.bind(this, "delGroupBefore", true), +"Ctrl-Alt-Backspace": this._handleTextKillCommand.bind(this, "delGroupAfter", false), }); } -_handleKillLine(codeMirror) +_handleTextKillCommand(command, prependsToKillRing, codeMirror) { // Read-only mode is dynamic in some editors, so check every time // and ignore the shortcut if in read-only mode. if (this._codeMirror.getOption("read
[webkit-changes] [192803] trunk/Source/WebCore
Title: [192803] trunk/Source/WebCore Revision 192803 Author beid...@apple.com Date 2015-11-30 10:24:25 -0800 (Mon, 30 Nov 2015) Log Message Modern IDB: Resolve flaky GC-vs-wrapper issue with IDBOpenDBRequest. https://bugs.webkit.org/show_bug.cgi?id=151645 Reviewed by Andy Estes. No new tests (Resolves flakiness with hundreds of existing IDB tests). Do to improper management of the m_hasPendingActivity flag on IDBRequestImpl, the request wrapper for an IDBOpenDBRequest might be garbage collected in between the onUpgradeNeeded event and onSuccess event. This manifested as flakiness in many tests, some more than others. I tried to write a targeted 100% reproducible case manually forcing GC, but could not get the timing right. * Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp: (WebCore::IDBClient::IDBOpenDBRequest::fireSuccessAfterVersionChangeCommit): * Modules/indexeddb/client/IDBOpenDBRequestImpl.h: * Modules/indexeddb/client/IDBRequestImpl.cpp: (WebCore::IDBClient::IDBRequest::dispatchEvent): (WebCore::IDBClient::IDBRequest::willIterateCursor): * Modules/indexeddb/client/IDBRequestImpl.h: (WebCore::IDBClient::IDBRequest::isOpenDBRequest): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.h Diff Modified: trunk/Source/WebCore/ChangeLog (192802 => 192803) --- trunk/Source/WebCore/ChangeLog 2015-11-30 18:22:31 UTC (rev 192802) +++ trunk/Source/WebCore/ChangeLog 2015-11-30 18:24:25 UTC (rev 192803) @@ -1,3 +1,31 @@ +2015-11-30 Brady Eidson + +Modern IDB: Resolve flaky GC-vs-wrapper issue with IDBOpenDBRequest. +https://bugs.webkit.org/show_bug.cgi?id=151645 + +Reviewed by Andy Estes. + +No new tests (Resolves flakiness with hundreds of existing IDB tests). + +Do to improper management of the m_hasPendingActivity flag on IDBRequestImpl, +the request wrapper for an IDBOpenDBRequest might be garbage collected in between the +onUpgradeNeeded event and onSuccess event. + +This manifested as flakiness in many tests, some more than others. + +I tried to write a targeted 100% reproducible case manually forcing GC, but could not get +the timing right. + +* Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp: +(WebCore::IDBClient::IDBOpenDBRequest::fireSuccessAfterVersionChangeCommit): +* Modules/indexeddb/client/IDBOpenDBRequestImpl.h: + +* Modules/indexeddb/client/IDBRequestImpl.cpp: +(WebCore::IDBClient::IDBRequest::dispatchEvent): +(WebCore::IDBClient::IDBRequest::willIterateCursor): +* Modules/indexeddb/client/IDBRequestImpl.h: +(WebCore::IDBClient::IDBRequest::isOpenDBRequest): + 2015-11-30 Per Arne Vollan [WinCairo][MediaFoundation] Implement seek. Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp (192802 => 192803) --- trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp 2015-11-30 18:22:31 UTC (rev 192802) +++ trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp 2015-11-30 18:24:25 UTC (rev 192803) @@ -71,6 +71,7 @@ { LOG(IndexedDB, "IDBOpenDBRequest::fireSuccessAfterVersionChangeCommit()"); +ASSERT(hasPendingActivity()); ASSERT(m_result); ASSERT(m_result->type() == IDBAny::Type::IDBDatabase); m_transaction->addRequest(*this); Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h (192802 => 192803) --- trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h 2015-11-30 18:22:31 UTC (rev 192802) +++ trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h 2015-11-30 18:24:25 UTC (rev 192803) @@ -61,6 +61,8 @@ void onUpgradeNeeded(const IDBResultData&); void onDeleteDatabaseSuccess(const IDBResultData&); +virtual bool isOpenDBRequest() const override { return true; } + IDBDatabaseIdentifier m_databaseIdentifier; uint64_t m_version { 0 }; }; Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp (192802 => 192803) --- trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp 2015-11-30 18:22:31 UTC (rev 192802) +++ trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp 2015-11-30 18:24:25 UTC (rev 192803) @@ -238,6 +238,8 @@ { LOG(IndexedDB, "IDBRequest::dispatchEvent - %s (%p)", event.type().characters8(), this); +ASSERT(m_hasPendingActivity); + if (event.type() != eventNames().blockedEvent) m_readyState = IDBRequestReadyState::Done; @@ -249,16 +251,22 @@ targets.append(m_transaction->db()); } +m_hasPendingActivity = false; + bool dontPreventDefault; { Transaction
[webkit-changes] [192801] trunk
Title: [192801] trunk Revision 192801 Author aes...@apple.com Date 2015-11-30 10:21:50 -0800 (Mon, 30 Nov 2015) Log Message Reverted r192769. It broke run-minibrowser, and made MiniBrowser.app not usable as a standalone bundle. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/JSMockContentFilterSettingsCustom.cpp trunk/Source/WebCore/testing/MockContentFilter.cpp trunk/Source/WebCore/testing/MockContentFilter.h trunk/Source/WebCore/testing/MockContentFilterSettings.h trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/Configurations/Base.xcconfig trunk/Tools/MiniBrowser/Configurations/MiniBrowser.xcconfig trunk/Tools/MiniBrowser/Configurations/MiniBrowserBundle.xcconfig trunk/Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj trunk/Tools/MiniBrowser/MiniBrowserWebProcessPlugIn.m trunk/Tools/MiniBrowser/mac/AppDelegate.m trunk/Tools/MiniBrowser/mac/BrowserWindowController.h trunk/Tools/MiniBrowser/mac/BrowserWindowController.m trunk/Tools/MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch trunk/Tools/MiniBrowser/mac/MiniBrowser_Prefix.pch trunk/Tools/MiniBrowser/mac/SettingsController.h trunk/Tools/MiniBrowser/mac/SettingsController.m trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.h trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm Removed Paths trunk/Source/WebCore/testing/MockContentFilterEnabler.h trunk/Source/WebCore/testing/MockContentFilterEnabler.mm trunk/Tools/MiniBrowser/blocked-page.html Diff Modified: trunk/Source/WebCore/ChangeLog (192800 => 192801) --- trunk/Source/WebCore/ChangeLog 2015-11-30 18:21:16 UTC (rev 192800) +++ trunk/Source/WebCore/ChangeLog 2015-11-30 18:21:50 UTC (rev 192801) @@ -211,53 +211,6 @@ * Source/WebCore/platform/graphics/WidthIterator.cpp: * Source/WebCore/platform/graphics/FontCascade.cpp: -2015-11-22 Andy Estes - -Teach MiniBrowser how to enable the mock content filter -https://bugs.webkit.org/show_bug.cgi?id=151540 - -Reviewed by Andreas Kling. - -Moved the implementation of MockContentFilterEnabler from TestWebKitAPI to here, renamed it to -WebMockContentFilterEnabler, and made it compatible with the legacy Objective-C runtime. Renamed Decision and -DecisionPoint to WebMockContentFilterDecision and WebMockContentFilterDecisionPoint, and changed them from enum -classes to CF_ENUMs so that they can be used by both C++ and Objective-C source files. - -* WebCore.xcodeproj/project.pbxproj: -* bindings/js/JSMockContentFilterSettingsCustom.cpp: -(WebCore::JSMockContentFilterSettings::decisionPoint): -(WebCore::JSMockContentFilterSettings::setDecisionPoint): -(WebCore::toDecision): -(WebCore::JSMockContentFilterSettings::decision): -(WebCore::JSMockContentFilterSettings::setDecision): -(WebCore::JSMockContentFilterSettings::unblockRequestDecision): -(WebCore::JSMockContentFilterSettings::setUnblockRequestDecision): -(WebCore::toJSValue): Deleted. -* testing/MockContentFilter.cpp: -(WebCore::MockContentFilter::willSendRequest): -(WebCore::MockContentFilter::responseReceived): -(WebCore::MockContentFilter::addData): -(WebCore::MockContentFilter::finishedAddingData): -(WebCore::MockContentFilter::unblockHandler): -(WebCore::MockContentFilter::maybeDetermineStatus): -* testing/MockContentFilter.h: -* testing/MockContentFilterEnabler.h: Added. -* testing/MockContentFilterEnabler.mm: Added. -(-[WebMockContentFilterEnabler initWithDecision:decisionPoint:blockedString:]): -(-[WebMockContentFilterEnabler initWithCoder:]): -(-[WebMockContentFilterEnabler encodeWithCoder:]): -(-[WebMockContentFilterEnabler enable]): -(-[WebMockContentFilterEnabler dealloc]): -(+[WebMockContentFilterEnabler supportsSecureCoding]): -(-[WebMockContentFilterEnabler copyWithZone:]): -* testing/MockContentFilterSettings.h: -(WebCore::MockContentFilterSettings::decisionPoint): -(WebCore::MockContentFilterSettings::setDecisionPoint): -(WebCore::MockContentFilterSettings::decision): -(WebCore::MockContentFilterSettings::setDecision): -(WebCore::MockContentFilterSettings::unblockRequestDecision): -(WebCore::MockContentFilterSettings::setUnblockRequestDecision): - 2015-11-24 Xabier Rodriguez Calvar [Streams API] Implement pipeTo method in readable Stream Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (192800 => 192801) --- trunk/Source/WebCore/WebCore.xcodeproj/p
[webkit-changes] [192800] trunk
Title: [192800] trunk Revision 192800 Author beid...@apple.com Date 2015-11-30 10:21:16 -0800 (Mon, 30 Nov 2015) Log Message Modern IDB: openCursor() fix resulting in at least 4 more passing tests. https://bugs.webkit.org/show_bug.cgi?id=151630 Reviewed by Andy Estes. Source/WebCore: No new tests (At least 4 failing tests now pass, and 9 other incorrect tests updated). * Modules/indexeddb/IDBGetResult.cpp: (WebCore::IDBGetResult::isolatedCopy): * Modules/indexeddb/IDBGetResult.h: (WebCore::IDBGetResult::IDBGetResult): (WebCore::IDBGetResult::isDefined): * Modules/indexeddb/client/IDBRequestImpl.cpp: (WebCore::IDBClient::IDBRequest::didOpenOrIterateCursor): If the IDBGetResult is undefined, do not expose the cursor as the result property of the IDBRequest. LayoutTests: * platform/mac-wk1/TestExpectations: * storage/indexeddb/modern/cursor-2-expected.txt: * storage/indexeddb/modern/cursor-2.html: * storage/indexeddb/modern/cursor-3-expected.txt: * storage/indexeddb/modern/cursor-3.html: * storage/indexeddb/modern/cursor-4-expected.txt: * storage/indexeddb/modern/cursor-4.html: * storage/indexeddb/modern/deleteindex-1-expected.txt: * storage/indexeddb/modern/deleteindex-1.html: * storage/indexeddb/modern/deleteindex-2-expected.txt: * storage/indexeddb/modern/deleteindex-2.html: * storage/indexeddb/modern/index-4-expected.txt: * storage/indexeddb/modern/index-4.html: * storage/indexeddb/modern/index-cursor-1-expected.txt: * storage/indexeddb/modern/index-cursor-1.html: * storage/indexeddb/modern/index-cursor-2-expected.txt: * storage/indexeddb/modern/index-cursor-2.html: * storage/indexeddb/modern/index-cursor-3-expected.txt: * storage/indexeddb/modern/index-cursor-3.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/LayoutTests/storage/indexeddb/modern/cursor-2-expected.txt trunk/LayoutTests/storage/indexeddb/modern/cursor-2.html trunk/LayoutTests/storage/indexeddb/modern/cursor-3-expected.txt trunk/LayoutTests/storage/indexeddb/modern/cursor-3.html trunk/LayoutTests/storage/indexeddb/modern/cursor-4-expected.txt trunk/LayoutTests/storage/indexeddb/modern/cursor-4.html trunk/LayoutTests/storage/indexeddb/modern/deleteindex-1-expected.txt trunk/LayoutTests/storage/indexeddb/modern/deleteindex-1.html trunk/LayoutTests/storage/indexeddb/modern/deleteindex-2-expected.txt trunk/LayoutTests/storage/indexeddb/modern/deleteindex-2.html trunk/LayoutTests/storage/indexeddb/modern/index-4-expected.txt trunk/LayoutTests/storage/indexeddb/modern/index-4.html trunk/LayoutTests/storage/indexeddb/modern/index-cursor-1-expected.txt trunk/LayoutTests/storage/indexeddb/modern/index-cursor-1.html trunk/LayoutTests/storage/indexeddb/modern/index-cursor-2-expected.txt trunk/LayoutTests/storage/indexeddb/modern/index-cursor-2.html trunk/LayoutTests/storage/indexeddb/modern/index-cursor-3-expected.txt trunk/LayoutTests/storage/indexeddb/modern/index-cursor-3.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/IDBGetResult.cpp trunk/Source/WebCore/Modules/indexeddb/IDBGetResult.h trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp Diff Modified: trunk/LayoutTests/ChangeLog (192799 => 192800) --- trunk/LayoutTests/ChangeLog 2015-11-30 18:15:02 UTC (rev 192799) +++ trunk/LayoutTests/ChangeLog 2015-11-30 18:21:16 UTC (rev 192800) @@ -1,3 +1,30 @@ +2015-11-30 Brady Eidson + +Modern IDB: openCursor() fix resulting in at least 4 more passing tests. +https://bugs.webkit.org/show_bug.cgi?id=151630 + +Reviewed by Andy Estes. + +* platform/mac-wk1/TestExpectations: +* storage/indexeddb/modern/cursor-2-expected.txt: +* storage/indexeddb/modern/cursor-2.html: +* storage/indexeddb/modern/cursor-3-expected.txt: +* storage/indexeddb/modern/cursor-3.html: +* storage/indexeddb/modern/cursor-4-expected.txt: +* storage/indexeddb/modern/cursor-4.html: +* storage/indexeddb/modern/deleteindex-1-expected.txt: +* storage/indexeddb/modern/deleteindex-1.html: +* storage/indexeddb/modern/deleteindex-2-expected.txt: +* storage/indexeddb/modern/deleteindex-2.html: +* storage/indexeddb/modern/index-4-expected.txt: +* storage/indexeddb/modern/index-4.html: +* storage/indexeddb/modern/index-cursor-1-expected.txt: +* storage/indexeddb/modern/index-cursor-1.html: +* storage/indexeddb/modern/index-cursor-2-expected.txt: +* storage/indexeddb/modern/index-cursor-2.html: +* storage/indexeddb/modern/index-cursor-3-expected.txt: +* storage/indexeddb/modern/index-cursor-3.html: + 2015-11-30 Ryan Haddad Marking http/tests/cache/disk-cache/disk-cache-request-max-stale.html as flaky on Yosemite WK2 Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192799 => 192800) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-11-30 18:15:02 UTC (rev 19279
[webkit-changes] [192799] trunk/LayoutTests
Title: [192799] trunk/LayoutTests Revision 192799 Author ryanhad...@apple.com Date 2015-11-30 10:15:02 -0800 (Mon, 30 Nov 2015) Log Message 2015-11-30 Ryan Haddad Marking http/tests/cache/disk-cache/disk-cache-request-max-stale.html as flaky on Yosemite WK2 https://bugs.webkit.org/show_bug.cgi?id=143159 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (192798 => 192799) --- trunk/LayoutTests/ChangeLog 2015-11-30 18:11:34 UTC (rev 192798) +++ trunk/LayoutTests/ChangeLog 2015-11-30 18:15:02 UTC (rev 192799) @@ -1,3 +1,12 @@ +2015-11-30 Ryan Haddad + +Marking http/tests/cache/disk-cache/disk-cache-request-max-stale.html as flaky on Yosemite WK2 +https://bugs.webkit.org/show_bug.cgi?id=143159 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2015-11-30 Brady Eidson Modern IDB: Support keyPath injection into object store records. Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (192798 => 192799) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2015-11-30 18:11:34 UTC (rev 192798) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2015-11-30 18:15:02 UTC (rev 192799) @@ -281,6 +281,8 @@ webkit.org/b/151326 [ Yosemite+ ] webarchive/loading/missing-data.html [ Pass Crash ] webkit.org/b/151455 [ Yosemite ] http/tests/xmlhttprequest/workers/methods-async.html [ Pass Timeout ] + +webkit.org/b/151661 [ Yosemite ] http/tests/cache/disk-cache/disk-cache-request-max-stale.html [ Pass Timeout ] ### END OF (1) Classified failures with bug reports ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192798] trunk
Title: [192798] trunk Revision 192798 Author beid...@apple.com Date 2015-11-30 10:11:34 -0800 (Mon, 30 Nov 2015) Log Message Modern IDB: Support keyPath injection into object store records. https://bugs.webkit.org/show_bug.cgi?id=151640 Reviewed by Andy Estes. Source/WebCore: No new tests (At least one existing failure now passes and is unskipped, while many other existing failures are now closer to passing). * Modules/indexeddb/server/MemoryObjectStore.cpp: (WebCore::IDBServer::MemoryObjectStore::updateIndexesForPutRecord): Use the new UniqueIDBDatabase VM/ExecState. (WebCore::IDBServer::MemoryObjectStore::populateIndexWithExistingRecords): Ditto (WebCore::IDBServer::indexVM): Deleted. (WebCore::IDBServer::indexGlobalExec): Deleted. * Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::databaseThreadVM): (WebCore::IDBServer::UniqueIDBDatabase::databaseThreadExecState): (WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd): If appropriate, inject the key that will be used into the value before storing the record. * Modules/indexeddb/server/UniqueIDBDatabase.h: Add modern JSValue/ExecState& version of some binding utilities, for use today and in preparation of getting rid of the DOMRequestState and Deprecated::ScriptValue versions later: * bindings/js/IDBBindingUtilities.cpp: (WebCore::idbKeyToJSValue): (WebCore::injectIDBKeyIntoScriptValue): (WebCore::deserializeIDBValueData): (WebCore::deserializeIDBValueDataToJSValue): * bindings/js/IDBBindingUtilities.h: LayoutTests: * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h trunk/Source/WebCore/bindings/js/IDBBindingUtilities.cpp trunk/Source/WebCore/bindings/js/IDBBindingUtilities.h Diff Modified: trunk/LayoutTests/ChangeLog (192797 => 192798) --- trunk/LayoutTests/ChangeLog 2015-11-30 18:06:23 UTC (rev 192797) +++ trunk/LayoutTests/ChangeLog 2015-11-30 18:11:34 UTC (rev 192798) @@ -1,3 +1,12 @@ +2015-11-30 Brady Eidson + +Modern IDB: Support keyPath injection into object store records. +https://bugs.webkit.org/show_bug.cgi?id=151640 + +Reviewed by Andy Estes. + +* platform/mac-wk1/TestExpectations: + 2015-11-29 Antoine Quint Browser does not fall back to SVG attribute value when CSS style value is invalid or not supported Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192797 => 192798) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-11-30 18:06:23 UTC (rev 192797) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-11-30 18:11:34 UTC (rev 192798) @@ -73,6 +73,7 @@ # But Modern IndexedDB is. storage/indexeddb/modern [ Pass ] storage/indexeddb/mozilla/add-twice-failure.html [ Pass ] +storage/indexeddb/mozilla/autoincrement-indexes.html [ Pass ] storage/indexeddb/mozilla/bad-keypath.html [ Pass ] storage/indexeddb/mozilla/create-index-unique.html [ Pass ] storage/indexeddb/mozilla/create-index-with-integer-keys.html [ Pass ] Modified: trunk/Source/WebCore/ChangeLog (192797 => 192798) --- trunk/Source/WebCore/ChangeLog 2015-11-30 18:06:23 UTC (rev 192797) +++ trunk/Source/WebCore/ChangeLog 2015-11-30 18:11:34 UTC (rev 192798) @@ -1,3 +1,35 @@ +2015-11-30 Brady Eidson + +Modern IDB: Support keyPath injection into object store records. +https://bugs.webkit.org/show_bug.cgi?id=151640 + +Reviewed by Andy Estes. + +No new tests (At least one existing failure now passes and is unskipped, +while many other existing failures are now closer to passing). + +* Modules/indexeddb/server/MemoryObjectStore.cpp: +(WebCore::IDBServer::MemoryObjectStore::updateIndexesForPutRecord): Use the new UniqueIDBDatabase VM/ExecState. +(WebCore::IDBServer::MemoryObjectStore::populateIndexWithExistingRecords): Ditto +(WebCore::IDBServer::indexVM): Deleted. +(WebCore::IDBServer::indexGlobalExec): Deleted. + +* Modules/indexeddb/server/UniqueIDBDatabase.cpp: +(WebCore::IDBServer::UniqueIDBDatabase::databaseThreadVM): +(WebCore::IDBServer::UniqueIDBDatabase::databaseThreadExecState): +(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd): If appropriate, inject the key that will be used into + the value before storing the record. +* Modules/indexeddb/server/UniqueIDBDatabase.h: + +Add modern JSValue/ExecState& version of some binding utilities, for use today and in preparation of getting +rid of the DOMRequestState and Deprecated::ScriptValue versions later: +* bindings/js/IDBBindingUtilities.cpp: +(WebCore::idbKeyToJSValue): +(WebCore::inje
[webkit-changes] [192797] trunk/Source/WebCore
Title: [192797] trunk/Source/WebCore Revision 192797 Author aes...@apple.com Date 2015-11-30 10:06:23 -0800 (Mon, 30 Nov 2015) Log Message [Content Filtering] Avoid creating a ContentFilter when loading the empty document https://bugs.webkit.org/show_bug.cgi?id=151615 Reviewed by Daniel Bates. It's expensive to create the first ContentFilter since two frameworks must be soft-linked. There's no reason to pay this cost if we're just loading the empty document. No new tests. It's not possible to write a test that would fail without this change since ContentFilter is not notified of empty document loads. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::startLoadingMainResource): Don't initialize m_contentFilter until we know we aren't loading the empty document. (WebCore::DocumentLoader::DocumentLoader): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/DocumentLoader.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (192796 => 192797) --- trunk/Source/WebCore/ChangeLog 2015-11-30 17:49:15 UTC (rev 192796) +++ trunk/Source/WebCore/ChangeLog 2015-11-30 18:06:23 UTC (rev 192797) @@ -1,3 +1,21 @@ +2015-11-25 Andy Estes + +[Content Filtering] Avoid creating a ContentFilter when loading the empty document +https://bugs.webkit.org/show_bug.cgi?id=151615 + +Reviewed by Daniel Bates. + +It's expensive to create the first ContentFilter since two frameworks must be soft-linked. There's no reason to +pay this cost if we're just loading the empty document. + +No new tests. It's not possible to write a test that would fail without this change since ContentFilter is not +notified of empty document loads. + +* loader/DocumentLoader.cpp: +(WebCore::DocumentLoader::startLoadingMainResource): Don't initialize m_contentFilter until we know we aren't +loading the empty document. +(WebCore::DocumentLoader::DocumentLoader): + 2015-11-29 Antoine Quint Browser does not fall back to SVG attribute value when CSS style value is invalid or not supported Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (192796 => 192797) --- trunk/Source/WebCore/loader/DocumentLoader.cpp 2015-11-30 17:49:15 UTC (rev 192796) +++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2015-11-30 18:06:23 UTC (rev 192797) @@ -144,9 +144,6 @@ , m_dataLoadTimer(*this, &DocumentLoader::handleSubstituteDataLoadNow) , m_subresourceLoadersArePageCacheAcceptable(false) , m_applicationCacheHost(std::make_unique(*this)) -#if ENABLE(CONTENT_FILTERING) -, m_contentFilter(!substituteData.isValid() ? ContentFilter::createIfEnabled(*this) : nullptr) -#endif { } @@ -1420,6 +1417,10 @@ if (maybeLoadEmpty()) return; +#if ENABLE(CONTENT_FILTERING) +m_contentFilter = !m_originalSubstituteDataWasValid ? ContentFilter::createIfEnabled(*this) : nullptr; +#endif + // FIXME: Is there any way the extra fields could have not been added by now? // If not, it would be great to remove this line of code. // Note that currently, some requests may have incorrect extra fields even if this function has been called, ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192796] trunk
Title: [192796] trunk Revision 192796 Author achristen...@apple.com Date 2015-11-30 09:49:15 -0800 (Mon, 30 Nov 2015) Log Message Make usesNetworkProcess always true https://bugs.webkit.org/show_bug.cgi?id=151580 Reviewed by Darin Adler. Source/WebKit2: * NetworkProcess/mac/RemoteNetworkingContext.mm: (WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession): * Shared/API/c/WKDeprecatedFunctions.cpp: (WKInspectorToggleJavaScriptProfiling): (WKContextSetUsesNetworkProcess): (WKGraphicsContextGetCGContext): * Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm: (WebKit::CustomProtocolManager::initializeConnection): (WebKit::CustomProtocolManager::initialize): * Shared/Network/CustomProtocols/CustomProtocolManager.h: * Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp: (WebKit::CustomProtocolManager::initialize): * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): * Shared/WebProcessCreationParameters.h: * UIProcess/API/APIProcessPoolConfiguration.cpp: (API::ProcessPoolConfiguration::createWithLegacyOptions): (API::ProcessPoolConfiguration::copy): * UIProcess/API/APIProcessPoolConfiguration.h: * UIProcess/API/C/WKContext.cpp: (WKContextSetJavaScriptGarbageCollectorTimerEnabled): (WKContextUseTestingNetworkSession): (WKContextSetUsesNetworkProcess): Deleted. * UIProcess/API/C/WKContextPrivate.h: * UIProcess/API/Cocoa/WKProcessGroup.mm: (-[WKProcessGroup initWithInjectedBundleURL:]): * UIProcess/API/efl/ewk_context.cpp: (EwkContext::setProcessModel): * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::updateProcessSuppressionState): (WebKit::WebProcessPool::platformInitializeWebProcess): * UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::cancel): (WebKit::DownloadProxy::invalidate): * UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy): (WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy): * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::WebProcessPool): (WebKit::m_processSuppressionDisabledForPageCounter): (WebKit::WebProcessPool::networkingProcessConnection): (WebKit::WebProcessPool::languageChanged): (WebKit::WebProcessPool::textCheckerStateChanged): (WebKit::WebProcessPool::ensureNetworkProcess): (WebKit::WebProcessPool::setAnyPageGroupMightHavePrivateBrowsingEnabled): (WebKit::WebProcessPool::createNewWebProcess): (WebKit::WebProcessPool::download): (WebKit::WebProcessPool::resumeDownload): (WebKit::WebProcessPool::setCanHandleHTTPSServerTrustEvaluation): (WebKit::WebProcessPool::setCacheModel): (WebKit::WebProcessPool::createDownloadProxy): (WebKit::WebProcessPool::addMessageReceiver): (WebKit::WebProcessPool::allowSpecificHTTPSCertificateForHost): (WebKit::WebProcessPool::setHTTPPipeliningEnabled): (WebKit::WebProcessPool::requestNetworkingStatistics): (WebKit::WebProcessPool::setUsesNetworkProcess): Deleted. (WebKit::WebProcessPool::usesNetworkProcess): Deleted. * UIProcess/WebProcessPool.h: (WebKit::WebProcessPool::sendToNetworkingProcess): (WebKit::WebProcessPool::sendToNetworkingProcessRelaunchingIfNecessary): * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::shutDown): (WebKit::WebProcessProxy::removeWebPage): (WebKit::WebProcessProxy::canTerminateChildProcess): (WebKit::WebProcessProxy::updateTextCheckerState): (WebKit::WebProcessProxy::didSaveToPageCache): (WebKit::WebProcessProxy::didSetAssertionState): (WebKit::WebProcessProxy::createDownloadProxy): Deleted. * UIProcess/WebProcessProxy.h: * UIProcess/efl/WebProcessPoolEfl.cpp: (WebKit::WebProcessPool::platformInitializeWebProcess): (WebKit::WebProcessPool::setIgnoreTLSErrors): * WebProcess/FileAPI/BlobRegistryProxy.cpp: (WebKit::BlobRegistryProxy::registerFileBlobURL): (WebKit::BlobRegistryProxy::registerBlobURL): (WebKit::BlobRegistryProxy::unregisterBlobURL): (WebKit::BlobRegistryProxy::registerBlobURLForSlice): (WebKit::BlobRegistryProxy::blobSize): * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::cookiesForDOM): (WebKit::WebPlatformStrategies::setCookiesFromDOM): (WebKit::WebPlatformStrategies::cookiesEnabled): (WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue): (WebKit::WebPlatformStrategies::getRawCookies): (WebKit::WebPlatformStrategies::deleteCookie): (WebKit::WebPlatformStrategies::resourceLoadScheduler): (WebKit::WebPlatformStrategies::loadResourceSynchronously): (WebKit::WebPlatformStrategies::createPingHandle): (WebKit::WebPlatformStrategies::createBlobRegistry): * WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::startDownload): (WebKit::WebFrame::convertMainResourceLoadToDownload): (WebKit::WebFrame::source): * WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::m_webSQLiteDatabaseTracker): (WebKit::WebProcess::initializeConnection): (WebKit::WebProcess::initializeW
[webkit-changes] [192795] trunk/Source/JavaScriptCore
Title: [192795] trunk/Source/_javascript_Core Revision 192795 Author mark@apple.com Date 2015-11-30 08:56:27 -0800 (Mon, 30 Nov 2015) Log Message [ARM64] stress/op_div.js is failing on some divide by 0 cases. https://bugs.webkit.org/show_bug.cgi?id=151515 Reviewed by Saam Barati. * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileArithDiv): - Added a check for the divide by zero case. * tests/stress/op_div.js: - Un-skipped the test. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/tests/stress/op_div.js Diff Modified: trunk/Source/_javascript_Core/ChangeLog (192794 => 192795) --- trunk/Source/_javascript_Core/ChangeLog 2015-11-30 14:21:06 UTC (rev 192794) +++ trunk/Source/_javascript_Core/ChangeLog 2015-11-30 16:56:27 UTC (rev 192795) @@ -1,3 +1,16 @@ +2015-11-26 Mark Lam + +[ARM64] stress/op_div.js is failing on some divide by 0 cases. +https://bugs.webkit.org/show_bug.cgi?id=151515 + +Reviewed by Saam Barati. + +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::compileArithDiv): +- Added a check for the divide by zero case. +* tests/stress/op_div.js: +- Un-skipped the test. + 2015-11-27 Csaba Osztrogonác [cmake] Add testb3 to the build system Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (192794 => 192795) --- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2015-11-30 14:21:06 UTC (rev 192794) +++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2015-11-30 16:56:27 UTC (rev 192795) @@ -3556,6 +3556,9 @@ numeratorNonZero.link(&m_jit); } +if (shouldCheckOverflow(node->arithMode())) +speculationCheck(Overflow, JSValueRegs(), nullptr, m_jit.branchTest32(MacroAssembler::Zero, op2GPR)); + m_jit.assembler().sdiv<32>(quotient.gpr(), op1GPR, op2GPR); // Check that there was no remainder. If there had been, then we'd be obligated to Modified: trunk/Source/_javascript_Core/tests/stress/op_div.js (192794 => 192795) --- trunk/Source/_javascript_Core/tests/stress/op_div.js 2015-11-30 14:21:06 UTC (rev 192794) +++ trunk/Source/_javascript_Core/tests/stress/op_div.js 2015-11-30 16:56:27 UTC (rev 192795) @@ -1,5 +1,4 @@ -//@ skip -// FIXME: https://bugs.webkit.org/show_bug.cgi?id=151515 +//@ runFTLNoCJIT // If all goes well, this test module will terminate silently. If not, it will print // errors. See binary-op-test.js for debugging options if needed. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192794] trunk/Tools
Title: [192794] trunk/Tools Revision 192794 Author carlo...@webkit.org Date 2015-11-30 06:21:06 -0800 (Mon, 30 Nov 2015) Log Message Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug. Add a way to skip unit tests only for Debug or Release builds and skipt the test /webkit2/WebKitWebView/editable/editable only for Debug. * Scripts/run-gtk-tests: (SkippedTest): (SkippedTest.__init__): (SkippedTest.__str__): (SkippedTest.skip_entire_suite): (SkippedTest.skip_for_build_type): (TestRunner): (TestRunner.__init__): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-gtk-tests Diff Modified: trunk/Tools/ChangeLog (192793 => 192794) --- trunk/Tools/ChangeLog 2015-11-30 11:26:21 UTC (rev 192793) +++ trunk/Tools/ChangeLog 2015-11-30 14:21:06 UTC (rev 192794) @@ -1,5 +1,21 @@ 2015-11-30 Carlos Garcia Campos +Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug. + +Add a way to skip unit tests only for Debug or Release builds and +skipt the test /webkit2/WebKitWebView/editable/editable only for Debug. + +* Scripts/run-gtk-tests: +(SkippedTest): +(SkippedTest.__init__): +(SkippedTest.__str__): +(SkippedTest.skip_entire_suite): +(SkippedTest.skip_for_build_type): +(TestRunner): +(TestRunner.__init__): + +2015-11-30 Carlos Garcia Campos + Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset. It's an assert hit because we are reloading a view loaded with Modified: trunk/Tools/Scripts/run-gtk-tests (192793 => 192794) --- trunk/Tools/Scripts/run-gtk-tests 2015-11-30 11:26:21 UTC (rev 192793) +++ trunk/Tools/Scripts/run-gtk-tests 2015-11-30 14:21:06 UTC (rev 192794) @@ -34,11 +34,12 @@ class SkippedTest: ENTIRE_SUITE = None -def __init__(self, test, test_case, reason, bug=None): +def __init__(self, test, test_case, reason, bug, build_type=None): self.test = test self.test_case = test_case self.reason = reason self.bug = bug +self.build_type = build_type def __str__(self): skipped_test_str = "%s" % self.test @@ -46,14 +47,18 @@ if not(self.skip_entire_suite()): skipped_test_str += " [%s]" % self.test_case -skipped_test_str += ": %s " % self.reason -if self.bug is not None: -skipped_test_str += "(https://bugs.webkit.org/show_bug.cgi?id=%d)" % self.bug +skipped_test_str += ": %s (https://bugs.webkit.org/show_bug.cgi?id=%d)" % (self.reason, self.bug) return skipped_test_str def skip_entire_suite(self): return self.test_case == SkippedTest.ENTIRE_SUITE +def skip_for_build_type(self, build_type): +if self.build_type is None: +return True; + +return self.build_type == build_type + class TestTimeout(Exception): pass @@ -63,6 +68,7 @@ SKIPPED = [ SkippedTest("WebKit2Gtk/TestUIClient", "/webkit2/WebKitWebView/mouse-target", "Test times out after r150890", 117689), SkippedTest("WebKit2Gtk/TestCookieManager", "/webkit2/WebKitCookieManager/persistent-storage", "Test is flaky", 134580), +SkippedTest("WebKit2Gtk/TestWebViewEditor", "/webkit2/WebKitWebView/editable/editable", "Test hits an assertion in Debug builds", 151654, "Debug"), SkippedTest("WebKit2Gtk/TestWebExtensions", "/webkit2/WebKitWebView/install-missing-plugins-permission-request", "Test times out", 147822), SkippedTest("WebKit2/TestWebKit2", "WebKit2.MouseMoveAfterCrash", "Test is flaky", 85066), SkippedTest("WebKit2/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutForImages", "Test is flaky", 85066), @@ -91,7 +97,7 @@ self._programs_path = common.binary_build_path() self._tests = self._get_tests(tests) -self._skipped_tests = TestRunner.SKIPPED +self._skipped_tests = [skipped for skipped in TestRunner.SKIPPED if skipped.skip_for_build_type(self._build_type)] self._disabled_tests = [] # These SPI daemons need to be active for the accessibility tests to work. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192793] trunk/Tools
Title: [192793] trunk/Tools Revision 192793 Author carlo...@webkit.org Date 2015-11-30 03:26:21 -0800 (Mon, 30 Nov 2015) Log Message Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset. It's an assert hit because we are reloading a view loaded with HTML data which is not supported. Use loadURI instead. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewCustomCharset): Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp Diff Modified: trunk/Tools/ChangeLog (192792 => 192793) --- trunk/Tools/ChangeLog 2015-11-30 09:39:49 UTC (rev 192792) +++ trunk/Tools/ChangeLog 2015-11-30 11:26:21 UTC (rev 192793) @@ -1,5 +1,15 @@ 2015-11-30 Carlos Garcia Campos +Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset. + +It's an assert hit because we are reloading a view loaded with +HTML data which is not supported. Use loadURI instead. + +* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: +(testWebViewCustomCharset): + +2015-11-30 Carlos Garcia Campos + [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource https://bugs.webkit.org/show_bug.cgi?id=151633 Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp (192792 => 192793) --- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp 2015-11-30 09:39:49 UTC (rev 192792) +++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp 2015-11-30 11:26:21 UTC (rev 192793) @@ -96,7 +96,8 @@ static void testWebViewCustomCharset(WebViewTest* test, gconstpointer) { -test->loadHtml("WebKitGTK+ custom encoding test", nullptr); +test->loadURI(gServer->getURIForPath("/").data()); +test->waitUntilLoadFinished(); g_assert(!webkit_web_view_get_custom_charset(test->m_webView)); webkit_web_view_set_custom_charset(test->m_webView, "utf8"); // Changing the charset reloads the page, so wait until reloaded. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192792] trunk/Source/WebKit2
Title: [192792] trunk/Source/WebKit2 Revision 192792 Author carlo...@webkit.org Date 2015-11-30 01:39:49 -0800 (Mon, 30 Nov 2015) Log Message [GTK] UI process crash when the screensaver DBus proxy is being created while the web view is destroyed https://bugs.webkit.org/show_bug.cgi?id=151653 Reviewed by Martin Robinson. We correctly cancel the proxy creation, but when the async ready callback is called, the view could be destroyed already. In that case g_dbus_proxy_new_for_bus_finish() will return nullptr and fail with cancelled error, but we are using the passed web view without checking first if the creation failed or not. * UIProcess/API/gtk/WebKitWebViewBase.cpp: (screenSaverProxyCreatedCallback): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (192791 => 192792) --- trunk/Source/WebKit2/ChangeLog 2015-11-30 08:05:51 UTC (rev 192791) +++ trunk/Source/WebKit2/ChangeLog 2015-11-30 09:39:49 UTC (rev 192792) @@ -1,3 +1,19 @@ +2015-11-30 Carlos Garcia Campos + +[GTK] UI process crash when the screensaver DBus proxy is being created while the web view is destroyed +https://bugs.webkit.org/show_bug.cgi?id=151653 + +Reviewed by Martin Robinson. + +We correctly cancel the proxy creation, but when the async ready +callback is called, the view could be destroyed already. In that +case g_dbus_proxy_new_for_bus_finish() will return nullptr and +fail with cancelled error, but we are using the passed web view +without checking first if the creation failed or not. + +* UIProcess/API/gtk/WebKitWebViewBase.cpp: +(screenSaverProxyCreatedCallback): + 2015-11-28 Tim Horton Stop unnecessarily copying WKWebViewConfiguration in a few places Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (192791 => 192792) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2015-11-30 08:05:51 UTC (rev 192791) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2015-11-30 09:39:49 UTC (rev 192792) @@ -1170,11 +1170,15 @@ static void screenSaverProxyCreatedCallback(GObject*, GAsyncResult* result, WebKitWebViewBase* webViewBase) { -WebKitWebViewBasePrivate* priv = webViewBase->priv; -priv->screenSaverProxy = adoptGRef(g_dbus_proxy_new_for_bus_finish(result, nullptr)); -if (!priv->screenSaverProxy) +// WebKitWebViewBase cancels the proxy creation on dispose, which means this could be called +// after the web view has been destroyed and g_dbus_proxy_new_for_bus_finish will return nullptr. +// So, make sure we don't use the web view unless we have a valid proxy. +// See https://bugs.webkit.org/show_bug.cgi?id=151653. +GRefPtr proxy = adoptGRef(g_dbus_proxy_new_for_bus_finish(result, nullptr)); +if (!proxy) return; +webViewBase->priv->screenSaverProxy = proxy; webkitWebViewBaseSendInhibitMessageToScreenSaver(webViewBase); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [192791] trunk
Title: [192791] trunk Revision 192791 Author carlo...@webkit.org Date 2015-11-30 00:05:51 -0800 (Mon, 30 Nov 2015) Log Message [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource https://bugs.webkit.org/show_bug.cgi?id=151633 Reviewed by Csaba Osztrogonác. Source/WTF: * WTF.vcxproj/WTF.vcxproj: * WTF.vcxproj/WTF.vcxproj.filters: * wtf/PlatformEfl.cmake: * wtf/PlatformGTK.cmake: * wtf/glib/GMainLoopSource.cpp: Removed. * wtf/glib/GMainLoopSource.h: Removed. * wtf/glib/GThreadSafeMainLoopSource.cpp: Removed. * wtf/glib/GThreadSafeMainLoopSource.h: Removed. Tools: * TestWebKitAPI/PlatformGTK.cmake: * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters trunk/Source/WTF/wtf/PlatformEfl.cmake trunk/Source/WTF/wtf/PlatformGTK.cmake trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/PlatformGTK.cmake Removed Paths trunk/Source/WTF/wtf/glib/GMainLoopSource.cpp trunk/Source/WTF/wtf/glib/GMainLoopSource.h trunk/Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp trunk/Source/WTF/wtf/glib/GThreadSafeMainLoopSource.h trunk/Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp Diff Modified: trunk/Source/WTF/ChangeLog (192790 => 192791) --- trunk/Source/WTF/ChangeLog 2015-11-30 00:56:22 UTC (rev 192790) +++ trunk/Source/WTF/ChangeLog 2015-11-30 08:05:51 UTC (rev 192791) @@ -1,3 +1,19 @@ +2015-11-30 Carlos Garcia Campos + +[GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource +https://bugs.webkit.org/show_bug.cgi?id=151633 + +Reviewed by Csaba Osztrogonác. + +* WTF.vcxproj/WTF.vcxproj: +* WTF.vcxproj/WTF.vcxproj.filters: +* wtf/PlatformEfl.cmake: +* wtf/PlatformGTK.cmake: +* wtf/glib/GMainLoopSource.cpp: Removed. +* wtf/glib/GMainLoopSource.h: Removed. +* wtf/glib/GThreadSafeMainLoopSource.cpp: Removed. +* wtf/glib/GThreadSafeMainLoopSource.h: Removed. + 2015-11-27 Csaba Osztrogonác Fix build warning in bignum.cc Modified: trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj (192790 => 192791) --- trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj 2015-11-30 00:56:22 UTC (rev 192790) +++ trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj 2015-11-30 08:05:51 UTC (rev 192791) @@ -83,16 +83,6 @@ true true - - true - true - true - true - true - true - true - true - true true @@ -103,7 +93,6 @@ true true - @@ -209,11 +198,9 @@ - - Modified: trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters (192790 => 192791) --- trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters 2015-11-30 00:56:22 UTC (rev 192790) +++ trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters 2015-11-30 08:05:51 UTC (rev 192791) @@ -240,15 +240,9 @@ wtf\win - - wtf\glib - wtf - - wtf\glib - wtf\win @@ -707,18 +701,12 @@ wtf - - wtf\glib - wtf\glib wtf - - wtf\glib - wtf Modified: trunk/Source/WTF/wtf/PlatformEfl.cmake (192790 => 192791) --- trunk/Source/WTF/wtf/PlatformEfl.cmake 2015-11-30 00:56:22 UTC (rev 192790) +++ trunk/Source/WTF/wtf/PlatformEfl.cmake 2015-11-30 08:05:51 UTC (rev 192791) @@ -4,9 +4,7 @@ efl/RunLoopEfl.cpp efl/WorkQueueEfl.cpp -glib/GMainLoopSource.cpp glib/GRefPtr.cpp -glib/GThreadSafeMainLoopSource.cpp ) list(APPEND WTF_LIBRARIES Modified: trunk/Source/WTF/wtf/PlatformGTK.cmake (192790 => 192791) --- trunk/Source/WTF/wtf/PlatformGTK.cmake 2015-11-30 00:56:22 UTC (rev 192790) +++ trunk/Source/WTF/wtf/PlatformGTK.cmake 2015-11-30 08:05:51 UTC (rev 192791) @@ -3,9 +3,7 @@ list(APPEND WTF_SOURCES glib/GLibUtilities.cpp -glib/GMainLoopSource.cpp glib/GRefPtr.cpp -glib/GThreadSafeMainLoopSource.cpp glib/MainThreadGLib.cpp glib/RunLoopGLib.cpp glib/WorkQueueGLib.cpp Deleted: trunk/Source/WTF/wtf/glib/GMainLoopSource.cpp (192790 => 192791) --- trunk/Source/WTF/wtf/glib/GMainLoopSource.cpp 2015-11-30 00:56:22 UTC (rev 192790) +++ trunk/Source/WTF/wtf/glib/GMainLoopSource.cpp 2015-11-30 08:05:51 UTC (rev 192791) @@ -1,333 +0,0 @@ -/* - * Copyright (C) 2014 Igalia S.L. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * 1. Redistributions of source code must retain the above copyright - *notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - *notice, this list of conditions and the following disclaimer in the - *documentation and/or other materials provided with th