[webkit-changes] [208058] trunk

[simon . fraser]

Title: [208058] trunk








Revision 208058
Author simon.fra...@apple.com
Date 2016-10-28 11:34:17 -0700 (Fri, 28 Oct 2016)


Log Message
Wrong blur radius for filter: drop-shadow()
https://bugs.webkit.org/show_bug.cgi?id=163667

Reviewed by Darin Adler.

Source/WebCore:

The "stdDev" parameter to  and  represents the standard
deviation (σ) of the Gaussian blur function. CSS filters drop-shadow() and blur() follow
this with their radius parameter.

However, CSS box-shadow and text-shadow use 2σ to describe the blur radius, since this
is conveniently close to the number of pixels the effect of the blur extends out.

feDropShadow, which is used by non-accelerated filter: drop-shadow(), was using
the wrong blur radius because it passed its stdDev directly to ShadowBlur. ShadowBlur
was written for CSS box-shadow, so expected its input "blur radius" to be twice the
stdDev.

Tests: css3/filters/drop-shadow-blur-radius.html
   svg/filters/feDropShadow-blur-radius.html

* platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::platformApplySoftware):

LayoutTests:

Mismatch tests to detect that the blurry area extends out from under a masking
element on top.

* css3/filters/drop-shadow-blur-radius-expected-mismatch.html: Added.
* css3/filters/drop-shadow-blur-radius.html: Added.
* svg/filters/feDropShadow-blur-radius-expected-mismatch.html: Added.
* svg/filters/feDropShadow-blur-radius.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.cpp


Added Paths

trunk/LayoutTests/css3/filters/drop-shadow-blur-radius-expected-mismatch.html
trunk/LayoutTests/css3/filters/drop-shadow-blur-radius.html
trunk/LayoutTests/svg/filters/feDropShadow-blur-radius-expected-mismatch.html
trunk/LayoutTests/svg/filters/feDropShadow-blur-radius.html




Diff

Modified: trunk/LayoutTests/ChangeLog (208057 => 208058)

--- trunk/LayoutTests/ChangeLog	2016-10-28 18:09:41 UTC (rev 208057)
+++ trunk/LayoutTests/ChangeLog	2016-10-28 18:34:17 UTC (rev 208058)
@@ -1,3 +1,18 @@
+2016-10-28  Simon Fraser  
+
+Wrong blur radius for filter: drop-shadow()
+https://bugs.webkit.org/show_bug.cgi?id=163667
+
+Reviewed by Darin Adler.
+
+Mismatch tests to detect that the blurry area extends out from under a masking
+element on top.
+
+* css3/filters/drop-shadow-blur-radius-expected-mismatch.html: Added.
+* css3/filters/drop-shadow-blur-radius.html: Added.
+* svg/filters/feDropShadow-blur-radius-expected-mismatch.html: Added.
+* svg/filters/feDropShadow-blur-radius.html: Added.
+
 2016-10-28  Youenn Fablet  
 
 Expose RTCPeerConnection unprefixed


Added: trunk/LayoutTests/css3/filters/drop-shadow-blur-radius-expected-mismatch.html (0 => 208058)

--- trunk/LayoutTests/css3/filters/drop-shadow-blur-radius-expected-mismatch.html	(rev 0)
+++ trunk/LayoutTests/css3/filters/drop-shadow-blur-radius-expected-mismatch.html	2016-10-28 18:34:17 UTC (rev 208058)
@@ -0,0 +1,19 @@
+
+
+
+
+.overlay {
+position: absolute;
+top: 75px;
+left: 75px;
+height: 250px;
+width: 250px;
+border-radius: 50%;
+background-color: green;
+}
+
+
+
+
+
+


Added: trunk/LayoutTests/css3/filters/drop-shadow-blur-radius.html (0 => 208058)

--- trunk/LayoutTests/css3/filters/drop-shadow-blur-radius.html	(rev 0)
+++ trunk/LayoutTests/css3/filters/drop-shadow-blur-radius.html	2016-10-28 18:34:17 UTC (rev 208058)
@@ -0,0 +1,31 @@
+
+
+
+
+.circle {
+position: absolute;
+top: 100px;
+left: 100px;
+height: 200px;
+width: 200px;
+border-radius: 50%;
+background-color: white;
+filter: drop-shadow(0 0 20px black);
+}
+
+.overlay {
+position: absolute;
+top: 75px;
+left: 75px;
+height: 250px;
+width: 250px;
+border-radius: 50%;
+background-color: green;
+}
+
+
+
+
+
+
+


Added: trunk/LayoutTests/svg/filters/feDropShadow-blur-radius-expected-mismatch.html (0 => 208058)

--- trunk/LayoutTests/svg/filters/feDropShadow-blur-radius-expected-mismatch.html	(rev 0)
+++ trunk/LayoutTests/svg/filters/feDropShadow-blur-radius-expected-mismatch.html	2016-10-28 18:34:17 UTC (rev 208058)
@@ -0,0 +1,3 @@
+
+
+


Added: trunk/LayoutTests/svg/filters/feDropShadow-blur-radius.html (0 => 208058)

--- trunk/LayoutTests/svg/filters/feDropShadow-blur-radius.html	(rev 0)
+++ trunk/LayoutTests/svg/filters/feDropShadow-blur-radius.html	2016-10-28 18:34:17 UTC (rev 208058)
@@ -0,0 +1,9 @@
+
+
+
+
+
+
+
+  

[webkit-changes] [208059] trunk/Source/WebCore

[dino]

Title: [208059] trunk/Source/WebCore








Revision 208059
Author d...@apple.com
Date 2016-10-28 11:49:43 -0700 (Fri, 28 Oct 2016)


Log Message
Allow new CSS parser to handle insertRule, etc via parseRule
https://bugs.webkit.org/show_bug.cgi?id=164122


Reviewed by Darin Adler.

Call the new CSS parser from CSSParser::parseRule if enabled. This
allows style added via the CSSOM insertRule to go through
the parser.

I tested this across our layout tests that use insertRule. It
works fine, but does cause some filter tests to fail. This is
because the new parser does not generate WebKitCSSFilterValues,
but I think the CSSFunctionValue is good enough. I'll remove
WebKitCSSFilterValue separately.

* css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseRule): Call CSSParserImpl::parseRule.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208058 => 208059)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 18:34:17 UTC (rev 208058)
+++ trunk/Source/WebCore/ChangeLog	2016-10-28 18:49:43 UTC (rev 208059)
@@ -1,3 +1,24 @@
+2016-10-28  Dean Jackson  
+
+Allow new CSS parser to handle insertRule, etc via parseRule
+https://bugs.webkit.org/show_bug.cgi?id=164122
+
+
+Reviewed by Darin Adler.
+
+Call the new CSS parser from CSSParser::parseRule if enabled. This
+allows style added via the CSSOM insertRule to go through
+the parser.
+
+I tested this across our layout tests that use insertRule. It
+works fine, but does cause some filter tests to fail. This is
+because the new parser does not generate WebKitCSSFilterValues,
+but I think the CSSFunctionValue is good enough. I'll remove
+WebKitCSSFilterValue separately.
+
+* css/parser/CSSParser.cpp:
+(WebCore::CSSParser::parseRule): Call CSSParserImpl::parseRule.
+
 2016-10-28  Simon Fraser  
 
 Wrong blur radius for filter: drop-shadow()


Modified: trunk/Source/WebCore/css/parser/CSSParser.cpp (208058 => 208059)

--- trunk/Source/WebCore/css/parser/CSSParser.cpp	2016-10-28 18:34:17 UTC (rev 208058)
+++ trunk/Source/WebCore/css/parser/CSSParser.cpp	2016-10-28 18:49:43 UTC (rev 208059)
@@ -394,6 +394,8 @@
 
 RefPtr CSSParser::parseRule(StyleSheetContents* sheet, const String& string)
 {
+if (m_context.useNewParser && m_context.mode != UASheetMode)
+return CSSParserImpl::parseRule(string, m_context, sheet, CSSParserImpl::AllowImportRules);
 setStyleSheet(sheet);
 m_allowNamespaceDeclarations = false;
 setupParser("@-webkit-rule{", string, "} ");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208061] trunk/Tools

[commit-queue]

Title: [208061] trunk/Tools








Revision 208061
Author commit-qu...@webkit.org
Date 2016-10-28 11:58:23 -0700 (Fri, 28 Oct 2016)


Log Message
[GTK] Upgrade HarfBuzz to version 1.3.3
https://bugs.webkit.org/show_bug.cgi?id=162719

Patch by Frederic Wang  on 2016-10-28
Reviewed by Michael Catanzaro.

* gtk/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (208060 => 208061)

--- trunk/Tools/ChangeLog	2016-10-28 18:53:49 UTC (rev 208060)
+++ trunk/Tools/ChangeLog	2016-10-28 18:58:23 UTC (rev 208061)
@@ -1,3 +1,12 @@
+2016-10-28  Frederic Wang  
+
+[GTK] Upgrade HarfBuzz to version 1.3.3
+https://bugs.webkit.org/show_bug.cgi?id=162719
+
+Reviewed by Michael Catanzaro.
+
+* gtk/jhbuild.modules:
+
 2016-10-27  Chris Dumez  
 
 Regression(r203601): Caused crashes in iBooks


Modified: trunk/Tools/gtk/jhbuild.modules (208060 => 208061)

--- trunk/Tools/gtk/jhbuild.modules	2016-10-28 18:53:49 UTC (rev 208060)
+++ trunk/Tools/gtk/jhbuild.modules	2016-10-28 18:58:23 UTC (rev 208061)
@@ -131,12 +131,12 @@
 
   
 
-+ repo="freedesktop.org"
-hash="sha256:0aa1a8aba6f502321cf6fef3c9d2c73dde48389c5ed1d3615a7691944c2a06ed"
-md5sum="531ee8650626ecddcd90b2a4637e31d4">
+hash="sha256:2620987115a4122b47321610dccbcc18f7f121115fd7b88dc8a695c8b66cb3c9"
+md5sum="97ae15a72a93f1f27324a2b8d9bd3b1d">
 
   
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208062] trunk/Source/WebCore

[hyatt]

Title: [208062] trunk/Source/WebCore








Revision 208062
Author hy...@apple.com
Date 2016-10-28 12:40:44 -0700 (Fri, 28 Oct 2016)


Log Message
[CSS Parser] Clean up gradient parsing
https://bugs.webkit.org/show_bug.cgi?id=164139

Reviewed by Dean Jackson.

* css/CSSGradientValue.cpp:
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::computeEndPoint):
* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradient):
(WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeLinearGradient):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGradientValue.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208061 => 208062)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 18:58:23 UTC (rev 208061)
+++ trunk/Source/WebCore/ChangeLog	2016-10-28 19:40:44 UTC (rev 208062)
@@ -1,3 +1,20 @@
+2016-10-28  Dave Hyatt  
+
+[CSS Parser] Clean up gradient parsing
+https://bugs.webkit.org/show_bug.cgi?id=164139
+
+Reviewed by Dean Jackson.
+
+* css/CSSGradientValue.cpp:
+(WebCore::positionFromValue):
+(WebCore::CSSGradientValue::computeEndPoint):
+* css/parser/CSSPropertyParserHelpers.cpp:
+(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradient):
+(WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):
+(WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient):
+(WebCore::CSSPropertyParserHelpers::consumeRadialGradient):
+(WebCore::CSSPropertyParserHelpers::consumeLinearGradient):
+
 2016-10-28  Dean Jackson  
 
 New CSS Parser should use Colors not RGBA32s


Modified: trunk/Source/WebCore/css/CSSGradientValue.cpp (208061 => 208062)

--- trunk/Source/WebCore/css/CSSGradientValue.cpp	2016-10-28 18:58:23 UTC (rev 208061)
+++ trunk/Source/WebCore/css/CSSGradientValue.cpp	2016-10-28 19:40:44 UTC (rev 208062)
@@ -35,6 +35,7 @@
 #include "GradientImage.h"
 #include "Image.h"
 #include "NodeRenderStyle.h"
+#include "Pair.h"
 #include "RenderElement.h"
 #include "RenderView.h"
 #include "StyleResolver.h"
@@ -494,21 +495,37 @@
 gradient.setStopsSorted(true);
 }
 
-static float positionFromValue(CSSPrimitiveValue& value, const CSSToLengthConversionData& conversionData, const FloatSize& size, bool isHorizontal)
+static float positionFromValue(const CSSPrimitiveValue* value, const CSSToLengthConversionData& conversionData, const FloatSize& size, bool isHorizontal)
 {
-if (value.isNumber())
-return value.floatValue() * conversionData.zoom();
-
+int origin = 0;
+int sign = 1;
 int edgeDistance = isHorizontal ? size.width() : size.height();
-if (value.isPercentage())
-return value.floatValue() / 100.f * edgeDistance;
+
+// In this case the center of the gradient is given relative to an edge in the
+// form of: [ top | bottom | right | left ] [  |  ].
+if (value->isPair()) {
+CSSValueID originID = value->pairValue()->first()->valueID();
+value = value->pairValue()->second();
+
+if (originID == CSSValueRight || originID == CSSValueBottom) {
+// For right/bottom, the offset is relative to the far edge.
+origin = edgeDistance;
+sign = -1;
+}
+}
+
+if (value->isNumber())
+return origin + sign * value->floatValue() * conversionData.zoom();
+
+if (value->isPercentage())
+return origin + sign * value->floatValue() / 100.f * edgeDistance;
 
-if (value.isCalculatedPercentageWithLength()) {
-Ref calculationValue { value.cssCalcValue()->createCalculationValue(conversionData) };
-return calculationValue->evaluate(edgeDistance);
+if (value->isCalculatedPercentageWithLength()) {
+Ref calculationValue { value->cssCalcValue()->createCalculationValue(conversionData) };
+return origin + sign * calculationValue->evaluate(edgeDistance);
 }
-
-switch (value.valueID()) {
+
+switch (value->valueID()) {
 case CSSValueTop:
 ASSERT(!isHorizontal);
 return 0;
@@ -521,11 +538,13 @@
 case CSSValueRight:
 ASSERT(isHorizontal);
 return size.width();
+case CSSValueCenter:
+return origin + sign * .5f * edgeDistance;
 default:
 break;
 }
 
-return value.computeLength(conversionData);
+return origin + sign * value->computeLength(conversionData);
 }
 
 FloatPoint CSSGradientValue::computeEndPoint(CSSPrimitiveValue* horizontal, CSSPrimitiveValue* vertical, const CSSToLengthConversionData& conversionData, const FloatSize& size)
@@ -533,10 +552,10 @@
 FloatPoint result;
 
 if (horizontal)
-

[webkit-changes] [208060] trunk/Source/WebCore

[dino]

Title: [208060] trunk/Source/WebCore








Revision 208060
Author d...@apple.com
Date 2016-10-28 11:53:49 -0700 (Fri, 28 Oct 2016)


Log Message
New CSS Parser should use Colors not RGBA32s
https://bugs.webkit.org/show_bug.cgi?id=164124


Reviewed by Darin Adler.

The old parser has moved from using RGBA32 values to using
Colors directly. This was so we could support ExtendedColors
via the new color() syntax.

Update the new CSS parser to do the same.

* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
(WebCore::CSSPropertyParserHelpers::parseHexColor):
(WebCore::CSSPropertyParserHelpers::parseColorFunction):
(WebCore::CSSPropertyParserHelpers::consumeColor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208059 => 208060)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 18:49:43 UTC (rev 208059)
+++ trunk/Source/WebCore/ChangeLog	2016-10-28 18:53:49 UTC (rev 208060)
@@ -1,5 +1,26 @@
 2016-10-28  Dean Jackson  
 
+New CSS Parser should use Colors not RGBA32s
+https://bugs.webkit.org/show_bug.cgi?id=164124
+
+
+Reviewed by Darin Adler.
+
+The old parser has moved from using RGBA32 values to using
+Colors directly. This was so we could support ExtendedColors
+via the new color() syntax.
+
+Update the new CSS parser to do the same.
+
+* css/parser/CSSPropertyParserHelpers.cpp:
+(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
+(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
+(WebCore::CSSPropertyParserHelpers::parseHexColor):
+(WebCore::CSSPropertyParserHelpers::parseColorFunction):
+(WebCore::CSSPropertyParserHelpers::consumeColor):
+
+2016-10-28  Dean Jackson  
+
 Allow new CSS parser to handle insertRule, etc via parseRule
 https://bugs.webkit.org/show_bug.cgi?id=164122
 


Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp (208059 => 208060)

--- trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2016-10-28 18:49:43 UTC (rev 208059)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2016-10-28 18:53:49 UTC (rev 208060)
@@ -389,57 +389,62 @@
 return clampTo(result, 0, 255);
 }
 
-static bool parseRGBParameters(CSSParserTokenRange& range, RGBA32& result, bool parseAlpha)
+static Color parseRGBParameters(CSSParserTokenRange& range, bool parseAlpha)
 {
 ASSERT(range.peek().functionId() == CSSValueRgb || range.peek().functionId() == CSSValueRgba);
+Color result;
 CSSParserTokenRange args = consumeFunction(range);
 RefPtr colorParameter = consumeInteger(args);
 if (!colorParameter)
 colorParameter = consumePercent(args, ValueRangeAll);
 if (!colorParameter)
-return false;
+return Color();
 const bool isPercent = colorParameter->isPercentage();
 int colorArray[3];
 colorArray[0] = clampRGBComponent(*colorParameter);
 for (int i = 1; i < 3; i++) {
 if (!consumeCommaIncludingWhitespace(args))
-return false;
+return Color();
 colorParameter = isPercent ? consumePercent(args, ValueRangeAll) : consumeInteger(args);
 if (!colorParameter)
-return false;
+return Color();
 colorArray[i] = clampRGBComponent(*colorParameter);
 }
 if (parseAlpha) {
 if (!consumeCommaIncludingWhitespace(args))
-return false;
+return Color();
 double alpha;
 if (!consumeNumberRaw(args, alpha))
-return false;
+return Color();
 // Convert the floating pointer number of alpha to an integer in the range [0, 256),
 // with an equal distribution across all 256 values.
 int alphaComponent = static_cast(clampTo(alpha, 0.0, 1.0) * nextafter(256.0, 0.0));
-result = makeRGBA(colorArray[0], colorArray[1], colorArray[2], alphaComponent);
+result = Color(makeRGBA(colorArray[0], colorArray[1], colorArray[2], alphaComponent));
 } else {
-result = makeRGB(colorArray[0], colorArray[1], colorArray[2]);
+result = Color(makeRGB(colorArray[0], colorArray[1], colorArray[2]));
 }
-return args.atEnd();
+
+if (!args.atEnd())
+return Color();
+
+return result;
 }
 
-static bool parseHSLParameters(CSSParserTokenRange& range, RGBA32& result, bool parseAlpha)
+static Color parseHSLParameters(CSSParserTokenRange& range, bool parseAlpha)
 {
 ASSERT(range.peek().functionId() == CSSValueHsl || range.peek().functionId() == CSSValueHsla);
 CSSParserTokenRange args = consumeFunction(range);
 RefPtr hslValue = consumeNumber(args, ValueRangeAll);
 if (!hslValue)
-return false;
+return Color();
 

[webkit-changes] [208056] branches/safari-602-branch/Source/JavaScriptCore

[mark . lam]

Title: [208056] branches/safari-602-branch/Source/_javascript_Core








Revision 208056
Author mark@apple.com
Date 2016-10-28 10:52:40 -0700 (Fri, 28 Oct 2016)


Log Message
Merge r208018. rdar://problem/28962887, rdar://problem/28962912

2016-10-27  Mark Lam  

JSFunction::put() should not allow caching of lazily reified properties.
https://bugs.webkit.org/show_bug.cgi?id=164081

Reviewed by Geoffrey Garen.

It is incorrect for JSFunction::put() to return PutPropertySlots that indicates
that its lazily reified properties (e.g. .caller, and .arguments) are cacheable.
The reason for this is:

1. Currently, a cacheable put may only consist of the following types of put
   operations:
   a. putting a new property at an offset in the object storage.
   b. changing the value of an existing property at an offset in the object storage.
   c. invoking the setter for a property at an offset in the object storage.

   Returning a PutPropertySlot that indicates the property is cacheable means that
   the property put must be one of the above operations.

   For lazily reified properties, JSFunction::put() implements complex conditional
   behavior that is different than the set of cacheable put operations above.
   Hence, it should not claim that the property put is cacheable.

2. Cacheable puts are cached on the original structure of the object before the
   put operation.

   Reifying a lazy property will trigger a structure transition.  Even though
   subsequent puts to such a property may be cacheable after the structure
   transition, it is incorrect to indicate that the property put is cacheable
   because the caching is on the original structure, not the new transitioned
   structure.

Also fixed some missing exception checks.

* jit/JITOperations.cpp:
* runtime/JSFunction.cpp:
(JSC::JSFunction::put):
(JSC::JSFunction::reifyLazyPropertyIfNeeded):
(JSC::JSFunction::reifyBoundNameIfNeeded):
* runtime/JSFunction.h:

Modified Paths

branches/safari-602-branch/Source/_javascript_Core/ChangeLog
branches/safari-602-branch/Source/_javascript_Core/jit/JITOperations.cpp
branches/safari-602-branch/Source/_javascript_Core/runtime/JSFunction.cpp
branches/safari-602-branch/Source/_javascript_Core/runtime/JSFunction.h




Diff

Modified: branches/safari-602-branch/Source/_javascript_Core/ChangeLog (208055 => 208056)

--- branches/safari-602-branch/Source/_javascript_Core/ChangeLog	2016-10-28 17:42:47 UTC (rev 208055)
+++ branches/safari-602-branch/Source/_javascript_Core/ChangeLog	2016-10-28 17:52:40 UTC (rev 208056)
@@ -1,3 +1,49 @@
+2016-10-28  Mark Lam  
+
+Merge r208018. rdar://problem/28962887, rdar://problem/28962912
+
+2016-10-27  Mark Lam  
+
+JSFunction::put() should not allow caching of lazily reified properties.
+https://bugs.webkit.org/show_bug.cgi?id=164081
+
+Reviewed by Geoffrey Garen.
+
+It is incorrect for JSFunction::put() to return PutPropertySlots that indicates
+that its lazily reified properties (e.g. .caller, and .arguments) are cacheable.
+The reason for this is:
+
+1. Currently, a cacheable put may only consist of the following types of put
+   operations:
+   a. putting a new property at an offset in the object storage.
+   b. changing the value of an existing property at an offset in the object storage.
+   c. invoking the setter for a property at an offset in the object storage.
+
+   Returning a PutPropertySlot that indicates the property is cacheable means that
+   the property put must be one of the above operations.
+
+   For lazily reified properties, JSFunction::put() implements complex conditional
+   behavior that is different than the set of cacheable put operations above.
+   Hence, it should not claim that the property put is cacheable.
+
+2. Cacheable puts are cached on the original structure of the object before the
+   put operation.
+
+   Reifying a lazy property will trigger a structure transition.  Even though
+   subsequent puts to such a property may be cacheable after the structure
+   transition, it is incorrect to indicate that the property put is cacheable
+   because the caching is on the original structure, not the new transitioned
+   structure.
+
+Also fixed some missing exception checks.
+
+* jit/JITOperations.cpp:
+* runtime/JSFunction.cpp:
+(JSC::JSFunction::put):
+(JSC::JSFunction::reifyLazyPropertyIfNeeded):
+(JSC::JSFunction::reifyBoundNameIfNeeded):
+* runtime/JSFunction.h:
+
 2016-10-27  Mark Lam  

[webkit-changes] [208049] trunk

[antti]

Title: [208049] trunk








Revision 208049
Author an...@apple.com
Date 2016-10-28 08:39:27 -0700 (Fri, 28 Oct 2016)


Log Message
Always use iOS preload behavior
https://bugs.webkit.org/show_bug.cgi?id=164127

Reviewed by Andreas Kling.

Source/WebCore:

On non-iOS platforms we were delaying issuing lower priority preload (images mostly) until document has body.
This should be unnecessary as networking layer prioritization should ensure higher priority resources are
loaded earlier. Testing on iOS has showed that more aggressive behavior is a win.

This patch switches to iOS behavior on all platforms (and simplified the logic).

* html/parser/HTMLResourcePreloader.cpp:
(WebCore::HTMLResourcePreloader::preload):
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::preloadIfNeeded):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::performPostLoadActions):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::isPreloaded):
(WebCore::CachedResourceLoader::checkForPendingPreloads): Deleted.
(WebCore::CachedResourceLoader::requestPreload): Deleted.
(WebCore::CachedResourceLoader::clearPendingPreloads): Deleted.
* loader/cache/CachedResourceLoader.h:

LayoutTests:

* http/tests/webgl/1.0.2/readPixelsBadArgs-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/webgl/1.0.2/readPixelsBadArgs-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLResourcePreloader.cpp
trunk/Source/WebCore/loader/LinkLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h




Diff

Modified: trunk/LayoutTests/ChangeLog (208048 => 208049)

--- trunk/LayoutTests/ChangeLog	2016-10-28 15:11:21 UTC (rev 208048)
+++ trunk/LayoutTests/ChangeLog	2016-10-28 15:39:27 UTC (rev 208049)
@@ -1,3 +1,12 @@
+2016-10-28  Antti Koivisto  
+
+Always use iOS preload behavior
+https://bugs.webkit.org/show_bug.cgi?id=164127
+
+Reviewed by Andreas Kling.
+
+* http/tests/webgl/1.0.2/readPixelsBadArgs-expected.txt:
+
 2016-10-28  Antoine Quint  
 
 [Modern Media Controls] Media Controller: scrubbing support


Modified: trunk/LayoutTests/http/tests/webgl/1.0.2/readPixelsBadArgs-expected.txt (208048 => 208049)

--- trunk/LayoutTests/http/tests/webgl/1.0.2/readPixelsBadArgs-expected.txt	2016-10-28 15:11:21 UTC (rev 208048)
+++ trunk/LayoutTests/http/tests/webgl/1.0.2/readPixelsBadArgs-expected.txt	2016-10-28 15:39:27 UTC (rev 208049)
@@ -1,4 +1,5 @@
 Blocked access to external URL http://www.opengl.org/img/opengl_logo.jpg
+Blocked access to external URL http://www.opengl.org/img/opengl_logo.jpg
 This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
 
 Test: resources/webgl_test_files/conformance/more/functions/readPixelsBadArgs.html


Modified: trunk/Source/WebCore/ChangeLog (208048 => 208049)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 15:11:21 UTC (rev 208048)
+++ trunk/Source/WebCore/ChangeLog	2016-10-28 15:39:27 UTC (rev 208049)
@@ -1,3 +1,29 @@
+2016-10-28  Antti Koivisto  
+
+Always use iOS preload behavior
+https://bugs.webkit.org/show_bug.cgi?id=164127
+
+Reviewed by Andreas Kling.
+
+On non-iOS platforms we were delaying issuing lower priority preload (images mostly) until document has body.
+This should be unnecessary as networking layer prioritization should ensure higher priority resources are
+loaded earlier. Testing on iOS has showed that more aggressive behavior is a win.
+
+This patch switches to iOS behavior on all platforms (and simplified the logic).
+
+* html/parser/HTMLResourcePreloader.cpp:
+(WebCore::HTMLResourcePreloader::preload):
+* loader/LinkLoader.cpp:
+(WebCore::LinkLoader::preloadIfNeeded):
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::performPostLoadActions):
+(WebCore::CachedResourceLoader::preload):
+(WebCore::CachedResourceLoader::isPreloaded):
+(WebCore::CachedResourceLoader::checkForPendingPreloads): Deleted.
+(WebCore::CachedResourceLoader::requestPreload): Deleted.
+(WebCore::CachedResourceLoader::clearPendingPreloads): Deleted.
+* loader/cache/CachedResourceLoader.h:
+
 2016-10-28  Youenn Fablet  
 
 [Fetch] Ensure redirection count is no more than 20 in case of cross origin requests


Modified: trunk/Source/WebCore/html/parser/HTMLResourcePreloader.cpp (208048 => 208049)

--- trunk/Source/WebCore/html/parser/HTMLResourcePreloader.cpp	2016-10-28 15:11:21 UTC (rev 208048)
+++ trunk/Source/WebCore/html/parser/HTMLResourcePreloader.cpp	2016-10-28 15:39:27 UTC (rev 208049)
@@ -68,7 +68,7 @@
 if (!preload->media().isEmpty() && !mediaAttributeMatches(m_document, _document.renderView()->style(), preload->media()))
 return;
 

[webkit-changes] [208048] trunk/Source/WebKit2

[antti]

Title: [208048] trunk/Source/WebKit2








Revision 208048
Author an...@apple.com
Date 2016-10-28 08:11:21 -0700 (Fri, 28 Oct 2016)


Log Message
Enable CFNetwork connection cache fast lane for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=164129

Reviewed by Andreas Kling.

The idea of this feature is keep a connection free for higher priority requests so low-priority
image loads can't take all the available connections.

We have this enabled on WK1 but not on WK2. See what enabling it does for performance in bots.

* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::initializeNetworkSettings):

Based on code inspection setting kHTTPMinimumFastLanePriority is not sufficient to enable this feature,
kHTTPNumFastLanes needs also be set to a non-zero value. Use the same constants as WK1.
Also enable this on Mac to unify behavior.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (208047 => 208048)

--- trunk/Source/WebKit2/ChangeLog	2016-10-28 14:21:04 UTC (rev 208047)
+++ trunk/Source/WebKit2/ChangeLog	2016-10-28 15:11:21 UTC (rev 208048)
@@ -1,3 +1,22 @@
+2016-10-28  Antti Koivisto  
+
+Enable CFNetwork connection cache fast lane for WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=164129
+
+Reviewed by Andreas Kling.
+
+The idea of this feature is keep a connection free for higher priority requests so low-priority
+image loads can't take all the available connections.
+
+We have this enabled on WK1 but not on WK2. See what enabling it does for performance in bots.
+
+* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+(WebKit::initializeNetworkSettings):
+
+Based on code inspection setting kHTTPMinimumFastLanePriority is not sufficient to enable this feature,
+kHTTPNumFastLanes needs also be set to a non-zero value. Use the same constants as WK1.
+Also enable this on Mac to unify behavior.
+
 2016-10-27  Michael Catanzaro  
 
 [GTK] New stable DOM API headers should be included from webkitdom.h


Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm (208047 => 208048)

--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm	2016-10-28 14:21:04 UTC (rev 208047)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm	2016-10-28 15:11:21 UTC (rev 208048)
@@ -60,10 +60,11 @@
 WebCore::ResourceRequest::setHTTPPipeliningEnabled(prefValue);
 
 if (WebCore::ResourceRequest::resourcePrioritiesEnabled()) {
+const unsigned fastLaneConnectionCount = 1;
+
 _CFNetworkHTTPConnectionCacheSetLimit(kHTTPPriorityNumLevels, toPlatformRequestPriority(WebCore::ResourceLoadPriority::Highest));
-#if PLATFORM(IOS)
 _CFNetworkHTTPConnectionCacheSetLimit(kHTTPMinimumFastLanePriority, toPlatformRequestPriority(WebCore::ResourceLoadPriority::Medium));
-#endif
+_CFNetworkHTTPConnectionCacheSetLimit(kHTTPNumFastLanes, fastLaneConnectionCount);
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208050] trunk/Source/WebInspectorUI

[mattbaker]

Title: [208050] trunk/Source/WebInspectorUI








Revision 208050
Author mattba...@apple.com
Date 2016-10-28 09:14:25 -0700 (Fri, 28 Oct 2016)


Log Message
Unreviewed, worker document images added

* UserInterface/Images/WorkerDocument.png: Added.
* UserInterface/Images/workerdocum...@2x.png: Added.
* UserInterface/Images/WorkerDocumentLarge.png: Added.
* UserInterface/Images/workerdocumentla...@2x.png: Added.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog


Added Paths

trunk/Source/WebInspectorUI/UserInterface/Images/WorkerDocument.png
trunk/Source/WebInspectorUI/UserInterface/Images/workerdocum...@2x.png
trunk/Source/WebInspectorUI/UserInterface/Images/WorkerDocumentLarge.png
trunk/Source/WebInspectorUI/UserInterface/Images/workerdocumentla...@2x.png




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (208049 => 208050)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-10-28 15:39:27 UTC (rev 208049)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-10-28 16:14:25 UTC (rev 208050)
@@ -1,3 +1,12 @@
+2016-10-28  Matt Baker  
+
+Unreviewed, worker document images added
+
+* UserInterface/Images/WorkerDocument.png: Added.
+* UserInterface/Images/workerdocum...@2x.png: Added.
+* UserInterface/Images/WorkerDocumentLarge.png: Added.
+* UserInterface/Images/workerdocumentla...@2x.png: Added.
+
 2016-10-27  Devin Rousso  
 
 Web Inspector: Create general model object Collection class


Added: trunk/Source/WebInspectorUI/UserInterface/Images/WorkerDocument.png (0 => 208050)

--- trunk/Source/WebInspectorUI/UserInterface/Images/WorkerDocument.png	(rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/WorkerDocument.png	2016-10-28 16:14:25 UTC (rev 208050)
@@ -0,0 +1,246 @@
+\x89PNG
+
++IHDR\xF3\xFFa	pHYs
\x9A\x9CH\xACiTXtXML:com.adobe.xmp
+
+   
+  
+ Adobe Photoshop CC 2014 (Macintosh)
+ 2011-11-22T18:31:28-08:00
+ 2016-10-24T15:44:14-07:00
+ 2016-10-24T15:44:14-07:00
+ image/png
+ 3
+ 
+
+   
+  
+  
+   
+   
+  css
+  css
+   
+   
+  js
+  js
+   
+   
+  jpg
+  jpg
+   
+   
+  png
+  png
+   
+   
+  pdf
+  pdf
+   
+   
+  gif
+  gif
+   
+
+ 
+ 
+
+   xmp.did:AC1F69DC18206811822ABFE780032E1E
+
+ 
+ xmp.iid:02106927-dba0-495d-8db3-00d38cba3fb7
+ adobe:docid:photoshop:c5fc32e0-dac9-1179-b0a7-af0d0eca52b5
+ xmp.did:008011740720681195FEB766E6513CAB
+ 
+
+   
+  created
+  xmp.iid:008011740720681195FEB766E6513CAB
+  2011-11-22T20:26:36-08:00
+  Adobe Photoshop CS4 Macintosh
+   
+   
+  converted
+  from image/png to application/vnd.adobe.photoshop
+   
+   
+  saved
+  xmp.iid:044149D31420681195FEB766E6513CAB
+  2011-11-22T20:26:36-08:00
+  Adobe Photoshop CS4 Macintosh
+  /
+   
+   
+  saved
+  xmp.iid:999c634d-3dd0-4e03-ab6e-119016768c26
+  2016-10-24T15:44:14-07:00
+  Adobe Photoshop CC 2014 (Macintosh)
+  /
+   
+   
+  converted
+  from application/vnd.adobe.photoshop to image/png
+   
+   
+  derived
+  converted from application/vnd.adobe.photoshop to image/png
+   
+   
+  saved
+  xmp.iid:02106927-dba0-495d-8db3-00d38cba3fb7
+  2016-10-24T15:44:14-07:00
+  Adobe Photoshop CC 2014 (Macintosh)
+  /
+   
+
+ 
+ 
+xmp.iid:999c634d-3dd0-4e03-ab6e-119016768c26
+xmp.did:008011740720681195FEB766E6513CAB
+xmp.did:008011740720681195FEB766E6513CAB
+ 
+ 1
+ 720090/1
+ 720090/1
+ 2
+ 65535
+ 16
+ 16
+  
+   
+
+
+
+ 

[webkit-changes] [208055] trunk/Source/WebCore

[hyatt]

Title: [208055] trunk/Source/WebCore








Revision 208055
Author hy...@apple.com
Date 2016-10-28 10:42:47 -0700 (Fri, 28 Oct 2016)


Log Message
[CSS Parser] Support the marquee properties
https://bugs.webkit.org/show_bug.cgi?id=164132

Reviewed by Zalan Bujtas.

* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeWebkitMarqueeIncrement):
(WebCore::consumeWebkitMarqueeRepetition):
(WebCore::consumeWebkitMarqueeSpeed):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseShorthand):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleBuilderConverter.h
trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208054 => 208055)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 17:41:55 UTC (rev 208054)
+++ trunk/Source/WebCore/ChangeLog	2016-10-28 17:42:47 UTC (rev 208055)
@@ -1,5 +1,21 @@
 2016-10-28  Dave Hyatt  
 
+[CSS Parser] Support the marquee properties
+https://bugs.webkit.org/show_bug.cgi?id=164132
+
+Reviewed by Zalan Bujtas.
+
+* css/parser/CSSParserFastPaths.cpp:
+(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+* css/parser/CSSPropertyParser.cpp:
+(WebCore::consumeWebkitMarqueeIncrement):
+(WebCore::consumeWebkitMarqueeRepetition):
+(WebCore::consumeWebkitMarqueeSpeed):
+(WebCore::CSSPropertyParser::parseSingleValue):
+(WebCore::CSSPropertyParser::parseShorthand):
+
+2016-10-28  Dave Hyatt  
+
 [CSS Parser] Miscellaneous bug fixes
 https://bugs.webkit.org/show_bug.cgi?id=164131
 


Modified: trunk/Source/WebCore/css/StyleBuilderConverter.h (208054 => 208055)

--- trunk/Source/WebCore/css/StyleBuilderConverter.h	2016-10-28 17:41:55 UTC (rev 208054)
+++ trunk/Source/WebCore/css/StyleBuilderConverter.h	2016-10-28 17:42:47 UTC (rev 208055)
@@ -341,14 +341,14 @@
 
 if (value.isValueID()) {
 switch (value.valueID()) {
-case cssValueFor0:
-return Length(0, Percent);
-case cssValueFor100:
-return Length(100, Percent);
-case CSSValueCenter:
-return Length(50, Percent);
-default:
-ASSERT_NOT_REACHED();
+case cssValueFor0:
+return Length(0, Percent);
+case cssValueFor100:
+return Length(100, Percent);
+case CSSValueCenter:
+return Length(50, Percent);
+default:
+ASSERT_NOT_REACHED();
 }
 }
 


Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (208054 => 208055)

--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp	2016-10-28 17:41:55 UTC (rev 208054)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp	2016-10-28 17:42:47 UTC (rev 208055)
@@ -792,6 +792,11 @@
 case CSSPropertyWebkitTouchCallout:
 return valueID == CSSValueDefault || valueID == CSSValueNone;
 #endif
+case CSSPropertyWebkitMarqueeDirection:
+return valueID == CSSValueForwards || valueID == CSSValueBackwards || valueID == CSSValueAhead || valueID == CSSValueReverse || valueID == CSSValueLeft || valueID == CSSValueRight || valueID == CSSValueDown
+|| valueID == CSSValueUp || valueID == CSSValueAuto;
+case CSSPropertyWebkitMarqueeStyle:
+return valueID == CSSValueNone || valueID == CSSValueSlide || valueID == CSSValueScroll || valueID == CSSValueAlternate;
 default:
 ASSERT_NOT_REACHED();
 return false;


Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (208054 => 208055)

--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp	2016-10-28 17:41:55 UTC (rev 208054)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp	2016-10-28 17:42:47 UTC (rev 208055)
@@ -3125,6 +3125,27 @@
 return consumeCustomIdent(range);
 }
 
+static RefPtr consumeWebkitMarqueeIncrement(CSSParserTokenRange& range, CSSParserMode cssParserMode)
+{
+if (range.peek().type() == IdentToken)
+return consumeIdent(range);
+return consumeLengthOrPercent(range, cssParserMode, ValueRangeAll);
+}
+
+static RefPtr consumeWebkitMarqueeRepetition(CSSParserTokenRange& range)
+{
+if (range.peek().type() == IdentToken)
+return consumeIdent(range);
+return consumeNumber(range, ValueRangeNonNegative);
+}
+
+static RefPtr consumeWebkitMarqueeSpeed(CSSParserTokenRange& range, CSSParserMode cssParserMode)
+{
+if (range.peek().type() == IdentToken)
+return consumeIdent(range);
+return consumeTime(range, cssParserMode, ValueRangeNonNegative, UnitlessQuirk::Allow);
+}
+
 RefPtr 

[webkit-changes] [208054] trunk/LayoutTests

[hyatt]

Title: [208054] trunk/LayoutTests








Revision 208054
Author hy...@apple.com
Date 2016-10-28 10:41:55 -0700 (Fri, 28 Oct 2016)


Log Message
Fix busted layout test from previous check-in.

* fast/multicol/column-box-alignment-rtl-expected.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/multicol/column-box-alignment-rtl-expected.html




Diff

Modified: trunk/LayoutTests/ChangeLog (208053 => 208054)

--- trunk/LayoutTests/ChangeLog	2016-10-28 17:15:26 UTC (rev 208053)
+++ trunk/LayoutTests/ChangeLog	2016-10-28 17:41:55 UTC (rev 208054)
@@ -1,3 +1,9 @@
+2016-10-28  Dave Hyatt  
+
+Fix busted layout test from previous check-in.
+
+* fast/multicol/column-box-alignment-rtl-expected.html:
+
 2016-10-28  Antti Koivisto  
 
 Always use iOS preload behavior


Modified: trunk/LayoutTests/fast/multicol/column-box-alignment-rtl-expected.html (208053 => 208054)

--- trunk/LayoutTests/fast/multicol/column-box-alignment-rtl-expected.html	2016-10-28 17:15:26 UTC (rev 208053)
+++ trunk/LayoutTests/fast/multicol/column-box-alignment-rtl-expected.html	2016-10-28 17:41:55 UTC (rev 208054)
@@ -1,3 +1,4 @@
+
 
 
 
@@ -9,7 +10,7 @@
 div {
   column-gap: 0;
   column-width: 20em;
-  column-progression: reverse;
+  -webkit-column-progression: reverse;
   width: 40em;
 }
 /* cosmetics */
@@ -28,4 +29,4 @@
 2nd column
   
 
-
\ No newline at end of file
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208051] trunk/Source/WebCore

[hyatt]

Title: [208051] trunk/Source/WebCore








Revision 208051
Author hy...@apple.com
Date 2016-10-28 09:23:18 -0700 (Fri, 28 Oct 2016)


Log Message
[CSS Parser] Miscellaneous bug fixes
https://bugs.webkit.org/show_bug.cgi?id=164131

Reviewed by Zalan Bujtas.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSPropertyNames.in:
The prefix was incorrectly dropped from -webkit-column-progression.
Put it back.

* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertPositionComponent):
(WebCore::StyleBuilderConverter::convertObjectPosition):
Fix object-position parsing so that the position components can
be ids.

* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueContent):
The new parser doesn't make a list for content:none, since none can't be
a component of a list anyway. Add code to handle this case in the
apply function.

* css/parser/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
Put the prefix back on -webkit-column-progression.

* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
Same.

* css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::parsePageSelector):
Make sure match type is checked, since our code asserts if it isn't.

* css/parser/CSSPropertyParser.cpp:
(WebCore::validWidthOrHeightKeyword):
(WebCore::consumeLineGrid):
(WebCore::CSSPropertyParser::parseSingleValue):
Add support for the line-grid properties and for -webkit-nbsp-mode.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSPropertyNames.in
trunk/Source/WebCore/css/StyleBuilderConverter.h
trunk/Source/WebCore/css/StyleBuilderCustom.h
trunk/Source/WebCore/css/parser/CSSParser.cpp
trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp
trunk/Source/WebCore/css/parser/CSSParserImpl.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208050 => 208051)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 16:14:25 UTC (rev 208050)
+++ trunk/Source/WebCore/ChangeLog	2016-10-28 16:23:18 UTC (rev 208051)
@@ -1,3 +1,47 @@
+2016-10-28  Dave Hyatt  
+
+[CSS Parser] Miscellaneous bug fixes
+https://bugs.webkit.org/show_bug.cgi?id=164131
+
+Reviewed by Zalan Bujtas.
+
+* css/CSSComputedStyleDeclaration.cpp:
+(WebCore::ComputedStyleExtractor::propertyValue):
+* css/CSSPropertyNames.in:
+The prefix was incorrectly dropped from -webkit-column-progression.
+Put it back.
+
+* css/StyleBuilderConverter.h:
+(WebCore::StyleBuilderConverter::convertPositionComponent):
+(WebCore::StyleBuilderConverter::convertObjectPosition):
+Fix object-position parsing so that the position components can
+be ids.
+
+* css/StyleBuilderCustom.h:
+(WebCore::StyleBuilderCustom::applyValueContent):
+The new parser doesn't make a list for content:none, since none can't be
+a component of a list anyway. Add code to handle this case in the
+apply function.
+
+* css/parser/CSSParser.cpp:
+(WebCore::isValidKeywordPropertyAndValue):
+Put the prefix back on -webkit-column-progression.
+
+* css/parser/CSSParserFastPaths.cpp:
+(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+(WebCore::CSSParserFastPaths::isKeywordPropertyID):
+Same.
+
+* css/parser/CSSParserImpl.cpp:
+(WebCore::CSSParserImpl::parsePageSelector):
+Make sure match type is checked, since our code asserts if it isn't.
+
+* css/parser/CSSPropertyParser.cpp:
+(WebCore::validWidthOrHeightKeyword):
+(WebCore::consumeLineGrid):
+(WebCore::CSSPropertyParser::parseSingleValue):
+Add support for the line-grid properties and for -webkit-nbsp-mode.
+
 2016-10-28  Antti Koivisto  
 
 Always use iOS preload behavior


Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (208050 => 208051)

--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp	2016-10-28 16:14:25 UTC (rev 208050)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp	2016-10-28 16:23:18 UTC (rev 208051)
@@ -289,7 +289,7 @@
 CSSPropertyColumnCount,
 CSSPropertyColumnFill,
 CSSPropertyColumnGap,
-CSSPropertyColumnProgression,
+CSSPropertyWebkitColumnProgression,
 CSSPropertyColumnRuleColor,
 CSSPropertyColumnRuleStyle,
 CSSPropertyColumnRuleWidth,
@@ -2800,7 +2800,7 @@
 if (style->hasNormalColumnGap())
 return cssValuePool.createIdentifierValue(CSSValueNormal);
 return zoomAdjustedPixelValue(style->columnGap(), *style);
-case CSSPropertyColumnProgression:
+case CSSPropertyWebkitColumnProgression:
 return 

[webkit-changes] [208053] trunk/JSTests

[ossy]

Title: [208053] trunk/JSTests








Revision 208053
Author o...@webkit.org
Date 2016-10-28 10:15:26 -0700 (Fri, 28 Oct 2016)


Log Message
Skip JSTests/microbenchmarks/dense-set.js on memory limited devices
https://bugs.webkit.org/show_bug.cgi?id=164128

Reviewed by Mark Lam.

* microbenchmarks/dense-set.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/microbenchmarks/dense-set.js




Diff

Modified: trunk/JSTests/ChangeLog (208052 => 208053)

--- trunk/JSTests/ChangeLog	2016-10-28 16:37:38 UTC (rev 208052)
+++ trunk/JSTests/ChangeLog	2016-10-28 17:15:26 UTC (rev 208053)
@@ -1,3 +1,12 @@
+2016-10-28  Csaba Osztrogonác  
+
+Skip JSTests/microbenchmarks/dense-set.js on memory limited devices
+https://bugs.webkit.org/show_bug.cgi?id=164128
+
+Reviewed by Mark Lam.
+
+* microbenchmarks/dense-set.js:
+
 2016-10-20  Caitlin Potter  
 
 [JSC] implement runtime for async functions


Modified: trunk/JSTests/microbenchmarks/dense-set.js (208052 => 208053)

--- trunk/JSTests/microbenchmarks/dense-set.js	2016-10-28 16:37:38 UTC (rev 208052)
+++ trunk/JSTests/microbenchmarks/dense-set.js	2016-10-28 17:15:26 UTC (rev 208053)
@@ -1,3 +1,4 @@
+//@ largeHeap
 (function() {
 
 function bench(name, f, arg) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208067] trunk/Source/JavaScriptCore

[utatane . tea]

Title: [208067] trunk/Source/_javascript_Core








Revision 208067
Author utatane@gmail.com
Date 2016-10-28 13:54:21 -0700 (Fri, 28 Oct 2016)


Log Message
[JSC] Add wasm/js directory to JSC include directories in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=164145

Reviewed by Michael Catanzaro.

Attempt to fix CMake ports. We include a file under wasm/js.
But we didn't add it to JSC include directories.

* CMakeLists.txt:

Modified Paths

trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/CMakeLists.txt (208066 => 208067)

--- trunk/Source/_javascript_Core/CMakeLists.txt	2016-10-28 20:53:03 UTC (rev 208066)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2016-10-28 20:54:21 UTC (rev 208067)
@@ -35,6 +35,7 @@
 "${_javascript_CORE_DIR}/runtime"
 "${_javascript_CORE_DIR}/tools"
 "${_javascript_CORE_DIR}/wasm"
+"${_javascript_CORE_DIR}/wasm/js"
 "${_javascript_CORE_DIR}/yarr"
 "${DERIVED_SOURCES_DIR}"
 "${DERIVED_SOURCES_DIR}/ForwardingHeaders"


Modified: trunk/Source/_javascript_Core/ChangeLog (208066 => 208067)

--- trunk/Source/_javascript_Core/ChangeLog	2016-10-28 20:53:03 UTC (rev 208066)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-10-28 20:54:21 UTC (rev 208067)
@@ -1,3 +1,15 @@
+2016-10-28  Yusuke Suzuki  
+
+[JSC] Add wasm/js directory to JSC include directories in CMakeLists.txt
+https://bugs.webkit.org/show_bug.cgi?id=164145
+
+Reviewed by Michael Catanzaro.
+
+Attempt to fix CMake ports. We include a file under wasm/js.
+But we didn't add it to JSC include directories.
+
+* CMakeLists.txt:
+
 2016-10-27  Geoffrey Garen  
 
 One file per class for Executable.h/.cpp






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208071] trunk/Source/JavaScriptCore

[ryanhaddad]

Title: [208071] trunk/Source/_javascript_Core








Revision 208071
Author ryanhad...@apple.com
Date 2016-10-28 14:35:02 -0700 (Fri, 28 Oct 2016)


Log Message
Update reference files for builtins generator tests after r208063.

Unreviewed test gardening.

* Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result:
* Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result:
* Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result:
* Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result:
* Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result:
* Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result:
* Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result:
* Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result
trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (208070 => 208071)

--- trunk/Source/_javascript_Core/ChangeLog	2016-10-28 21:33:30 UTC (rev 208070)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-10-28 21:35:02 UTC (rev 208071)
@@ -1,3 +1,23 @@
+2016-10-28  Ryan Haddad  
+
+Update reference files for builtins generator tests after r208063.
+
+Unreviewed test gardening.
+
+* Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result:
+* Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result:
+* Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result:
+* Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result:
+* Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result:
+* Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result:
+* Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result:
+* Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
+* Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
+* Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
+* Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
+* Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
+* Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
+
 2016-10-28  Yusuke Suzuki  
 
 [JSC] Add wasm/js directory to JSC include directories in CMakeLists.txt


Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result (208070 => 208071)

--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result	2016-10-28 21:33:30 

[webkit-changes] [208075] trunk/Source/WebCore

[pvollan]

Title: [208075] trunk/Source/WebCore








Revision 208075
Author pvol...@apple.com
Date 2016-10-28 15:10:35 -0700 (Fri, 28 Oct 2016)


Log Message
[Win][Direct2D] Implement ImageBufferData::putData.
https://bugs.webkit.org/show_bug.cgi?id=164151

Reviewed by Brent Fulgham.

* platform/graphics/win/ImageBufferDataDirect2D.cpp:
(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/ImageBufferDataDirect2D.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208074 => 208075)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 21:57:44 UTC (rev 208074)
+++ trunk/Source/WebCore/ChangeLog	2016-10-28 22:10:35 UTC (rev 208075)
@@ -1,3 +1,14 @@
+2016-10-28  Per Arne Vollan  
+
+[Win][Direct2D] Implement ImageBufferData::putData.
+https://bugs.webkit.org/show_bug.cgi?id=164151
+
+Reviewed by Brent Fulgham.
+
+* platform/graphics/win/ImageBufferDataDirect2D.cpp:
+(WebCore::ImageBufferData::getData):
+(WebCore::ImageBufferData::putData):
+
 2016-10-28  Dave Hyatt  
 
 [CSS Parser] Support hanging-punctuation


Modified: trunk/Source/WebCore/platform/graphics/win/ImageBufferDataDirect2D.cpp (208074 => 208075)

--- trunk/Source/WebCore/platform/graphics/win/ImageBufferDataDirect2D.cpp	2016-10-28 21:57:44 UTC (rev 208074)
+++ trunk/Source/WebCore/platform/graphics/win/ImageBufferDataDirect2D.cpp	2016-10-28 22:10:35 UTC (rev 208075)
@@ -79,7 +79,8 @@
 
 ok = ::BitBlt(bitmapDC.get(), 0, 0, rect.width(), rect.height(), hdc, rect.x(), rect.y(), SRCCOPY);
 
-hr = gdiRenderTarget->ReleaseDC(nullptr);
+RECT updateRect = { 0, 0, 0, 0 };
+hr = gdiRenderTarget->ReleaseDC();
 }
 
 if (!ok)
@@ -90,9 +91,79 @@
 return result;
 }
 
-void ImageBufferData::putData(Uint8ClampedArray*& /* source */, const IntSize& /* sourceSize */, const IntRect& /* sourceRect */, const IntPoint& /* destPoint */, const IntSize& /* size */, bool /* accelerateRendering */, bool /* unmultiplied */, float /* resolutionScale */)
+void ImageBufferData::putData(Uint8ClampedArray*& source, const IntSize& sourceSize, const IntRect& sourceRect, const IntPoint& destPoint, const IntSize& size, bool /* accelerateRendering */, bool unmultiplied, float resolutionScale)
 {
-notImplemented();
+auto platformContext = context->platformContext();
+COMPtr renderTarget(Query, platformContext);
+if (!renderTarget)
+return;
+
+COMPtr bitmap;
+HRESULT hr = renderTarget->GetBitmap();
+ASSERT(SUCCEEDED(hr));
+
+ASSERT(sourceRect.width() > 0);
+ASSERT(sourceRect.height() > 0);
+
+Checked originx = sourceRect.x();
+Checked destx = (Checked(destPoint.x()) + sourceRect.x());
+destx *= resolutionScale;
+ASSERT(destx.unsafeGet() >= 0);
+ASSERT(destx.unsafeGet() < size.width());
+ASSERT(originx.unsafeGet() >= 0);
+ASSERT(originx.unsafeGet() <= sourceRect.maxX());
+
+Checked endx = (Checked(destPoint.x()) + sourceRect.maxX());
+endx *= resolutionScale;
+ASSERT(endx.unsafeGet() <= size.width());
+
+Checked width = sourceRect.width();
+Checked destw = endx - destx;
+
+Checked originy = sourceRect.y();
+Checked desty = (Checked(destPoint.y()) + sourceRect.y());
+desty *= resolutionScale;
+ASSERT(desty.unsafeGet() >= 0);
+ASSERT(desty.unsafeGet() < size.height());
+ASSERT(originy.unsafeGet() >= 0);
+ASSERT(originy.unsafeGet() <= sourceRect.maxY());
+
+Checked endy = (Checked(destPoint.y()) + sourceRect.maxY());
+endy *= resolutionScale;
+ASSERT(endy.unsafeGet() <= size.height());
+
+Checked height = sourceRect.height();
+Checked desth = endy - desty;
+
+if (width <= 0 || height <= 0)
+return;
+
+unsigned srcBytesPerRow = 4 * sourceSize.width();
+unsigned char* srcRows = source->data() + (originy * srcBytesPerRow + originx * 4).unsafeGet();
+
+unsigned char* row = new unsigned char[srcBytesPerRow];
+
+for (int y = 0; y < height.unsafeGet(); ++y) {
+for (int x = 0; x < width.unsafeGet(); x++) {
+int basex = x * 4;
+unsigned char alpha = srcRows[basex + 3];
+if (unmultiplied && alpha != 255) {
+row[basex] = (srcRows[basex] * alpha + 254) / 255;
+row[basex + 1] = (srcRows[basex + 1] * alpha + 254) / 255;
+row[basex + 2] = (srcRows[basex + 2] * alpha + 254) / 255;
+row[basex + 3] = alpha;
+} else
+reinterpret_cast(row + basex)[0] = reinterpret_cast(srcRows + basex)[0];
+}
+
+D2D1_RECT_U dstRect = D2D1::RectU(destPoint.x(), destPoint.y() + y, destPoint.x() + size.width(), destPoint.y() + y + 1);
+hr = bitmap->CopyFromMemory(, row, srcBytesPerRow);
+ASSERT(SUCCEEDED(hr));
+
+srcRows += 

[webkit-changes] [208064] trunk/Source/WebCore

[hyatt]

Title: [208064] trunk/Source/WebCore








Revision 208064
Author hy...@apple.com
Date 2016-10-28 13:41:38 -0700 (Fri, 28 Oct 2016)


Log Message
[CSS Parser] Add support for -webkit-canvas images
https://bugs.webkit.org/show_bug.cgi?id=164144

Reviewed by Simon Fraser.

* css/CSSValueKeywords.in:
* css/parser/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeWebkitCanvas):
(WebCore::CSSPropertyParserHelpers::consumeGeneratedImage):
(WebCore::CSSPropertyParserHelpers::isGeneratedImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208063 => 208064)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 20:04:56 UTC (rev 208063)
+++ trunk/Source/WebCore/ChangeLog	2016-10-28 20:41:38 UTC (rev 208064)
@@ -1,3 +1,18 @@
+2016-10-28  Dave Hyatt  
+
+[CSS Parser] Add support for -webkit-canvas images
+https://bugs.webkit.org/show_bug.cgi?id=164144
+
+Reviewed by Simon Fraser.
+
+* css/CSSValueKeywords.in:
+* css/parser/CSSParser.cpp:
+(WebCore::CSSParserContext::CSSParserContext):
+* css/parser/CSSPropertyParserHelpers.cpp:
+(WebCore::CSSPropertyParserHelpers::consumeWebkitCanvas):
+(WebCore::CSSPropertyParserHelpers::consumeGeneratedImage):
+(WebCore::CSSPropertyParserHelpers::isGeneratedImage):
+
 2016-10-27  Geoffrey Garen  
 
 One file per class for Executable.h/.cpp


Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (208063 => 208064)

--- trunk/Source/WebCore/css/CSSValueKeywords.in	2016-10-28 20:04:56 UTC (rev 208063)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in	2016-10-28 20:41:38 UTC (rev 208064)
@@ -1155,6 +1155,7 @@
 repeating-linear-gradient
 repeating-radial-gradient
 paint
+-webkit-canvas
 -webkit-cross-fade
 -webkit-gradient
 -webkit-linear-gradient


Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp (208063 => 208064)

--- trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2016-10-28 20:04:56 UTC (rev 208063)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2016-10-28 20:41:38 UTC (rev 208064)
@@ -31,6 +31,7 @@
 #include "CSSPropertyParserHelpers.h"
 
 #include "CSSCalculationValue.h"
+#include "CSSCanvasValue.h"
 #include "CSSCrossfadeValue.h"
 #include "CSSGradientValue.h"
 #include "CSSImageSetValue.h"
@@ -1020,6 +1021,16 @@
 return CSSCrossfadeValue::create(fromImageValue.releaseNonNull(), toImageValue.releaseNonNull(), percentage.releaseNonNull());
 }
 
+static RefPtr consumeWebkitCanvas(CSSParserTokenRange& args)
+{
+if (args.peek().type() != IdentToken)
+return nullptr;
+auto canvasName = args.consumeIncludingWhitespace().value().toString();
+if (!args.atEnd())
+return nullptr;
+return CSSCanvasValue::create(canvasName);
+}
+
 static RefPtr consumeGeneratedImage(CSSParserTokenRange& range, CSSParserContext context)
 {
 CSSValueID id = range.peek().functionId();
@@ -1046,6 +1057,8 @@
 result = consumeDeprecatedRadialGradient(args, context.mode, Repeating);
 else if (id == CSSValueWebkitCrossFade)
 result = consumeCrossFade(args, context);
+else if (id == CSSValueWebkitCanvas)
+result = consumeWebkitCanvas(args);
 
 if (!result || !args.atEnd())
 return nullptr;
@@ -1089,7 +1102,8 @@
 || id == CSSValueRepeatingLinearGradient || id == CSSValueRepeatingRadialGradient
 || id == CSSValueWebkitLinearGradient || id == CSSValueWebkitRadialGradient
 || id == CSSValueWebkitRepeatingLinearGradient || id == CSSValueWebkitRepeatingRadialGradient
-|| id == CSSValueWebkitGradient || id == CSSValueWebkitCrossFade || id == CSSValuePaint;
+|| id == CSSValueWebkitGradient || id == CSSValueWebkitCrossFade || id == CSSValueWebkitCanvas
+|| id == CSSValuePaint;
 }
 
 RefPtr consumeImage(CSSParserTokenRange& range, CSSParserContext context, ConsumeGeneratedImage generatedImage)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208068] trunk/Source/WebCore

[simon . fraser]

Title: [208068] trunk/Source/WebCore








Revision 208068
Author simon.fra...@apple.com
Date 2016-10-28 14:02:53 -0700 (Fri, 28 Oct 2016)


Log Message
Remove some unused code in RenderLayerCompositor::computeExtent()
https://bugs.webkit.org/show_bug.cgi?id=163934

Reviewed by Zalan Bujtas.

viewportRect was never used.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeExtent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208067 => 208068)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 20:54:21 UTC (rev 208067)
+++ trunk/Source/WebCore/ChangeLog	2016-10-28 21:02:53 UTC (rev 208068)
@@ -1,3 +1,15 @@
+2016-10-28  Simon Fraser  
+
+Remove some unused code in RenderLayerCompositor::computeExtent()
+https://bugs.webkit.org/show_bug.cgi?id=163934
+
+Reviewed by Zalan Bujtas.
+
+viewportRect was never used.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::computeExtent):
+
 2016-10-28  Sam Weinig  
 
 [WebIDL] Update parser and code generators to only access type information through the type property


Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (208067 => 208068)

--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2016-10-28 20:54:21 UTC (rev 208067)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2016-10-28 21:02:53 UTC (rev 208068)
@@ -1196,12 +1196,6 @@
 // Because fixed elements get moved around without re-computing overlap, we have to compute an overlap
 // rect that covers all the locations that the fixed element could move to.
 // FIXME: need to handle sticky too.
-LayoutRect viewportRect;
-if (m_renderView.frameView().useFixedLayout())
-viewportRect = m_renderView.unscaledDocumentRect();
-else
-viewportRect = m_renderView.frameView().viewportConstrainedVisibleContentRect();
-
 extent.bounds = m_renderView.frameView().fixedScrollableAreaBoundsInflatedForScrolling(extent.bounds);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208070] trunk

[utatane . tea]

Title: [208070] trunk








Revision 208070
Author utatane@gmail.com
Date 2016-10-28 14:33:30 -0700 (Fri, 28 Oct 2016)


Log Message
[DOMJIT] Implement Document::documentElement
https://bugs.webkit.org/show_bug.cgi?id=164113

Reviewed by Sam Weinig.

Source/WebCore:

Test: js/dom/domjit-accessor-document-element.html

This patch implements document.documentElement DOMJIT accessor.
Similar to ownerDocument accessor, the way to access to document.documentElement
from JIT code is already prepared for CSSJIT. DOMJIT just utilizes the existing
functionality: using documentElementMemoryOffset().

document.documentElement is frequently called in jQuery. Especially, every time
we call jQuery.attr(), this is called.

To implement Document accessor, we clean up some code in DOMJITHelpers.
We create the cpp file for DOMJITHelpers and move some helpers to it.
And we also implement DOMJIT::checkDOM for convenience.
It returns appropriate CheckDOM patchpoint implementation.

This patch improves Dromaeo jslib-attr-jquery.html 10% (481.64 v.s. 532.54).

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsScopeRoot):
* dom/Document.idl:
* domjit/DOMJITAbstractHeapRepository.h:
* domjit/DOMJITCheckDOM.h: Copied from Source/WebCore/domjit/DOMJITAbstractHeapRepository.h.
(WebCore::DOMJIT::TypeChecker::branchIfFail):
(WebCore::DOMJIT::TypeChecker::branchIfFail):
(WebCore::DOMJIT::TypeChecker::branchIfFail):
(WebCore::DOMJIT::TypeChecker::branchIfFail):
(WebCore::DOMJIT::checkDOM):
* domjit/DOMJITHelpers.cpp: Copied from Source/WebCore/domjit/DOMJITAbstractHeapRepository.h.
(WebCore::DOMJIT::loadDocument):
(WebCore::DOMJIT::loadDocumentElement):
* domjit/DOMJITHelpers.h:
(WebCore::DOMJIT::toWrapperSlow):
(WebCore::DOMJIT::loadDocument): Deleted.
* domjit/JSDocumentDOMJIT.cpp: Added.
(WebCore::DocumentDocumentElementDOMJIT::checkDOM):
(WebCore::DocumentDocumentElementDOMJIT::callDOM):
* domjit/JSNodeDOMJIT.cpp:
(WebCore::createCallDOMForOffsetAccess):
(WebCore::NodeFirstChildDOMJIT::checkDOM):
(WebCore::NodeLastChildDOMJIT::checkDOM):
(WebCore::NodeNextSiblingDOMJIT::checkDOM):
(WebCore::NodePreviousSiblingDOMJIT::checkDOM):
(WebCore::NodeParentNodeDOMJIT::checkDOM):
(WebCore::NodeNodeTypeDOMJIT::checkDOM):
(WebCore::NodeOwnerDocumentDOMJIT::checkDOM):
(WebCore::NodeOwnerDocumentDOMJIT::callDOM):
(WebCore::toWrapperSlow): Deleted.
(WebCore::checkNode): Deleted.

LayoutTests:

* js/dom/domjit-accessor-document-element-changed-expected.txt: Added.
* js/dom/domjit-accessor-document-element-changed.html: Added.
* js/dom/domjit-accessor-document-element-expected.txt: Added.
* js/dom/domjit-accessor-document-element.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/cssjit/SelectorCompiler.cpp
trunk/Source/WebCore/dom/Document.idl
trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.h
trunk/Source/WebCore/domjit/DOMJITHelpers.h
trunk/Source/WebCore/domjit/JSNodeDOMJIT.cpp


Added Paths

trunk/LayoutTests/js/dom/domjit-accessor-document-element-changed-expected.txt
trunk/LayoutTests/js/dom/domjit-accessor-document-element-changed.html
trunk/LayoutTests/js/dom/domjit-accessor-document-element-expected.txt
trunk/LayoutTests/js/dom/domjit-accessor-document-element.html
trunk/Source/WebCore/domjit/DOMJITCheckDOM.h
trunk/Source/WebCore/domjit/DOMJITHelpers.cpp
trunk/Source/WebCore/domjit/JSDocumentDOMJIT.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (208069 => 208070)

--- trunk/LayoutTests/ChangeLog	2016-10-28 21:12:41 UTC (rev 208069)
+++ trunk/LayoutTests/ChangeLog	2016-10-28 21:33:30 UTC (rev 208070)
@@ -1,3 +1,15 @@
+2016-10-28  Yusuke Suzuki  
+
+[DOMJIT] Implement Document::documentElement
+https://bugs.webkit.org/show_bug.cgi?id=164113
+
+Reviewed by Sam Weinig.
+
+* js/dom/domjit-accessor-document-element-changed-expected.txt: Added.
+* js/dom/domjit-accessor-document-element-changed.html: Added.
+* js/dom/domjit-accessor-document-element-expected.txt: Added.
+* js/dom/domjit-accessor-document-element.html: Added.
+
 2016-10-28  Simon Fraser  
 
 Wrong blur radius for filter: drop-shadow()


Added: trunk/LayoutTests/js/dom/domjit-accessor-document-element-changed-expected.txt (0 => 208070)

--- trunk/LayoutTests/js/dom/domjit-accessor-document-element-changed-expected.txt	(rev 0)
+++ trunk/LayoutTests/js/dom/domjit-accessor-document-element-changed-expected.txt	2016-10-28 21:33:30 UTC (rev 208070)
@@ -0,0 +1,11 @@
+Test DOMJIT documentElement accessor works after the documentElement is changed.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS testNull(target, result) is false
+PASS 

[webkit-changes] [208073] trunk/Source/WebCore

[hyatt]

Title: [208073] trunk/Source/WebCore








Revision 208073
Author hy...@apple.com
Date 2016-10-28 14:52:22 -0700 (Fri, 28 Oct 2016)


Log Message
[CSS Parser] Support hanging-punctuation
https://bugs.webkit.org/show_bug.cgi?id=164153

Reviewed by Simon Fraser.

* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeHangingPunctuation):
(WebCore::CSSPropertyParser::parseSingleValue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208072 => 208073)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 21:37:17 UTC (rev 208072)
+++ trunk/Source/WebCore/ChangeLog	2016-10-28 21:52:22 UTC (rev 208073)
@@ -1,3 +1,14 @@
+2016-10-28  Dave Hyatt  
+
+[CSS Parser] Support hanging-punctuation
+https://bugs.webkit.org/show_bug.cgi?id=164153
+
+Reviewed by Simon Fraser.
+
+* css/parser/CSSPropertyParser.cpp:
+(WebCore::consumeHangingPunctuation):
+(WebCore::CSSPropertyParser::parseSingleValue):
+
 2016-10-28  Yusuke Suzuki  
 
 [DOMJIT] Implement Document::documentElement


Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (208072 => 208073)

--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp	2016-10-28 21:37:17 UTC (rev 208072)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp	2016-10-28 21:52:22 UTC (rev 208073)
@@ -70,6 +70,7 @@
 #include "StylePropertyShorthand.h"
 #include "StylePropertyShorthandFunctions.h"
 #include "WebKitCSSTransformValue.h"
+#include 
 #include 
 #include 
 
@@ -3146,6 +3147,51 @@
 return createPrimitiveValuePair(position.releaseNonNull(), WTFMove(height));
 }
 
+static RefPtr consumeHangingPunctuation(CSSParserTokenRange& range)
+{
+if (range.peek().id() == CSSValueNone)
+return consumeIdent(range);
+
+RefPtr list = CSSValueList::createSpaceSeparated();
+std::bitset seenValues;
+
+bool seenForceEnd = false;
+bool seenAllowEnd = false;
+bool seenFirst = false;
+bool seenLast = false;
+
+while (!range.atEnd()) {
+CSSValueID valueID = range.peek().id();
+if ((valueID == CSSValueFirst && seenFirst)
+|| (valueID == CSSValueLast && seenLast)
+|| (valueID == CSSValueAllowEnd && (seenAllowEnd || seenForceEnd))
+|| (valueID == CSSValueForceEnd && (seenAllowEnd || seenForceEnd)))
+return nullptr;
+RefPtr ident = consumeIdent(range);
+if (!ident)
+return nullptr;
+switch (valueID) {
+case CSSValueAllowEnd:
+seenAllowEnd = true;
+break;
+case CSSValueForceEnd:
+seenForceEnd = true;
+break;
+case CSSValueFirst:
+seenFirst = true;
+break;
+case CSSValueLast:
+seenLast = true;
+break;
+default:
+break;
+}
+list->append(ident.releaseNonNull());
+}
+
+return list->length() ? list : nullptr;
+}
+
 static RefPtr consumeWebkitMarqueeIncrement(CSSParserTokenRange& range, CSSParserMode cssParserMode)
 {
 if (range.peek().type() == IdentToken)
@@ -3539,6 +3585,8 @@
 return consumeLineGrid(m_range);
 case CSSPropertyWebkitInitialLetter:
 return consumeInitialLetter(m_range);
+case CSSPropertyHangingPunctuation:
+return consumeHangingPunctuation(m_range);
 case CSSPropertyWebkitMarqueeIncrement:
 return consumeWebkitMarqueeIncrement(m_range, m_context.mode);
 case CSSPropertyWebkitMarqueeRepetition:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208074] trunk/Source/JavaScriptCore

[utatane . tea]

Title: [208074] trunk/Source/_javascript_Core








Revision 208074
Author utatane@gmail.com
Date 2016-10-28 14:57:44 -0700 (Fri, 28 Oct 2016)


Log Message
Unreviewed, build fix in CLoop builds after r208063.

Include required headers.

* parser/Parser.h:
* runtime/Completion.cpp:
* runtime/JSGlobalObjectFunctions.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Parser.h
trunk/Source/_javascript_Core/runtime/Completion.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (208073 => 208074)

--- trunk/Source/_javascript_Core/ChangeLog	2016-10-28 21:52:22 UTC (rev 208073)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-10-28 21:57:44 UTC (rev 208074)
@@ -1,3 +1,13 @@
+2016-10-28  Yusuke Suzuki  
+
+Unreviewed, build fix in CLoop builds after r208063.
+
+Include required headers.
+
+* parser/Parser.h:
+* runtime/Completion.cpp:
+* runtime/JSGlobalObjectFunctions.cpp:
+
 2016-10-28  Ryan Haddad  
 
 Update reference files for builtins generator tests after r208063.


Modified: trunk/Source/_javascript_Core/parser/Parser.h (208073 => 208074)

--- trunk/Source/_javascript_Core/parser/Parser.h	2016-10-28 21:52:22 UTC (rev 208073)
+++ trunk/Source/_javascript_Core/parser/Parser.h	2016-10-28 21:57:44 UTC (rev 208074)
@@ -22,6 +22,7 @@
 
 #pragma once
 
+#include "ExecutableInfo.h"
 #include "ExceptionHelpers.h"
 #include "Lexer.h"
 #include "ModuleScopeData.h"


Modified: trunk/Source/_javascript_Core/runtime/Completion.cpp (208073 => 208074)

--- trunk/Source/_javascript_Core/runtime/Completion.cpp	2016-10-28 21:52:22 UTC (rev 208073)
+++ trunk/Source/_javascript_Core/runtime/Completion.cpp	2016-10-28 21:57:44 UTC (rev 208074)
@@ -38,6 +38,7 @@
 #include "JSWithScope.h"
 #include "ModuleAnalyzer.h"
 #include "Parser.h"
+#include "ProgramExecutable.h"
 #include "ScriptProfilingScope.h"
 #include 
 


Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp (208073 => 208074)

--- trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp	2016-10-28 21:52:22 UTC (rev 208073)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp	2016-10-28 21:57:44 UTC (rev 208074)
@@ -26,6 +26,7 @@
 #include "JSGlobalObjectFunctions.h"
 
 #include "CallFrame.h"
+#include "EvalExecutable.h"
 #include "Interpreter.h"
 #include "JSFunction.h"
 #include "JSGlobalObject.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208072] trunk/Source/WebInspectorUI

[commit-queue]

Title: [208072] trunk/Source/WebInspectorUI








Revision 208072
Author commit-qu...@webkit.org
Date 2016-10-28 14:37:17 -0700 (Fri, 28 Oct 2016)


Log Message
Web Inspector: Include parameter strings for native CustomElementRegistry methods in the console
https://bugs.webkit.org/show_bug.cgi?id=164147

Patch by Joseph Pecoraro  on 2016-10-28
Reviewed by Brian Burg.

* UserInterface/Models/NativeFunctionParameters.js:

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (208071 => 208072)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-10-28 21:35:02 UTC (rev 208071)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-10-28 21:37:17 UTC (rev 208072)
@@ -1,3 +1,12 @@
+2016-10-28  Joseph Pecoraro  
+
+Web Inspector: Include parameter strings for native CustomElementRegistry methods in the console
+https://bugs.webkit.org/show_bug.cgi?id=164147
+
+Reviewed by Brian Burg.
+
+* UserInterface/Models/NativeFunctionParameters.js:
+
 2016-10-28  Matt Baker  
 
 Unreviewed, worker document images added


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js (208071 => 208072)

--- trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js	2016-10-28 21:35:02 UTC (rev 208071)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js	2016-10-28 21:37:17 UTC (rev 208072)
@@ -720,6 +720,13 @@
 __proto__: null,
 },
 
+CustomElementRegistry: {
+define: "name, constructor",
+get: "name",
+whenDefined: "name",
+__proto__: null,
+},
+
 CustomEvent: {
 initCustomEvent: "[typeArg], [canBubbleArg], [cancelableArg], [detailArg]",
 __proto__: null,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208037] trunk/Source/ThirdParty/ANGLE

[achristensen]

Title: [208037] trunk/Source/ThirdParty/ANGLE








Revision 208037
Author achristen...@apple.com
Date 2016-10-27 23:10:33 -0700 (Thu, 27 Oct 2016)


Log Message
Fix Windows WebGL build after r208036
https://bugs.webkit.org/show_bug.cgi?id=164101

* CMakeLists.txt:
Add new files, remove deleted files.

Modified Paths

trunk/Source/ThirdParty/ANGLE/CMakeLists.txt
trunk/Source/ThirdParty/ANGLE/ChangeLog




Diff

Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (208036 => 208037)

--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2016-10-28 06:00:29 UTC (rev 208036)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2016-10-28 06:10:33 UTC (rev 208037)
@@ -54,50 +54,13 @@
 )
 
 add_library(libANGLE STATIC
-src/common/Float16ToFloat32.cpp
-src/common/string_utils.cpp
-src/compiler/translator/AddAndTrueToLoopCondition.cpp
-src/compiler/translator/AddDefaultReturnStatements.cpp
-src/compiler/translator/BreakVariableAliasingInInnerLoops.cpp
-src/compiler/translator/EmulateGLFragColorBroadcast.cpp
-src/compiler/translator/ExpandIntegerPowExpressions.cpp
-src/compiler/translator/RewriteTexelFetchOffset.cpp
-src/compiler/translator/RewriteUnaryMinusOperatorInt.cpp
-src/compiler/translator/SimplifyLoopConditions.cpp
-src/compiler/translator/SplitSequenceOperator.cpp
-src/compiler/translator/TextureFunctionHLSL.cpp
-src/compiler/translator/UseInterfaceBlockFields.cpp
-src/image_util/copyimage.cpp
-src/image_util/imageformats.cpp
-src/image_util/loadimage_etc.cpp
-src/image_util/loadimage.cpp
-src/libANGLE/format_map_autogen.cpp
-src/libANGLE/format_map_autogen.cpp
-src/libANGLE/formatutils.cpp
-src/libANGLE/HandleRangeAllocator.cpp
-src/libANGLE/Path.cpp
-src/libANGLE/queryutils.cpp
-src/libANGLE/renderer/ContextImpl.cpp
-src/libANGLE/renderer/d3d/d3d11/Context11.cpp
-src/libANGLE/renderer/d3d/d3d11/dxgi_format_map_autogen.cpp
-src/libANGLE/renderer/d3d/d3d11/StreamProducerNV12.cpp
-src/libANGLE/renderer/d3d/d3d11/texture_format_table.cpp
-src/libANGLE/renderer/d3d/d3d11/TextureStorage11.cpp
-src/libANGLE/renderer/d3d/d3d11/TransformFeedback11.cpp
-src/libANGLE/renderer/d3d/d3d11/win32/NativeWindow11Win32.cpp
-src/libANGLE/renderer/d3d/d3d9/Context9.cpp
-src/libANGLE/renderer/d3d/d3d9/NativeWindow9.cpp
-src/libANGLE/renderer/d3d/NativeWindowD3D.cpp
-src/libANGLE/renderer/Format_autogen.cpp
-src/libANGLE/renderer/Format.cpp
-src/libANGLE/renderer/load_functions_table_autogen.cpp
-src/libANGLE/signal_utils.cpp
-src/libANGLE/validationES31.cpp
 src/common/angleutils.cpp
 src/common/debug.cpp
 src/common/event_tracer.cpp
+src/common/Float16ToFloat32.cpp
 src/common/mathutil.cpp
 src/common/MemoryBuffer.cpp
+src/common/string_utils.cpp
 src/common/tls.cpp
 src/common/utilities.cpp
 src/compiler/preprocessor/DiagnosticsBase.cpp
@@ -111,10 +74,13 @@
 src/compiler/preprocessor/Preprocessor.cpp
 src/compiler/preprocessor/Token.cpp
 src/compiler/preprocessor/Tokenizer.cpp
+src/compiler/translator/AddAndTrueToLoopCondition.cpp
+src/compiler/translator/AddDefaultReturnStatements.cpp
 src/compiler/translator/ArrayReturnValueToOutParameter.cpp
 src/compiler/translator/ASTMetadataHLSL.cpp
 src/compiler/translator/blocklayout.cpp
 src/compiler/translator/blocklayoutHLSL.cpp
+src/compiler/translator/BreakVariableAliasingInInnerLoops.cpp
 src/compiler/translator/BuiltInFunctionEmulator.cpp
 src/compiler/translator/BuiltInFunctionEmulatorGLSL.cpp
 src/compiler/translator/BuiltInFunctionEmulatorHLSL.cpp
@@ -130,7 +96,9 @@
 src/compiler/translator/depgraph/DependencyGraphTraverse.cpp
 src/compiler/translator/Diagnostics.cpp
 src/compiler/translator/DirectiveHandler.cpp
+src/compiler/translator/EmulateGLFragColorBroadcast.cpp
 src/compiler/translator/EmulatePrecision.cpp
+src/compiler/translator/ExpandIntegerPowExpressions.cpp
 src/compiler/translator/ExtensionGLSL.cpp
 src/compiler/translator/FlagStd140Structs.cpp
 src/compiler/translator/ForLoopUnroll.cpp
@@ -163,6 +131,8 @@
 src/compiler/translator/RemoveSwitchFallThrough.cpp
 src/compiler/translator/RewriteDoWhile.cpp
 src/compiler/translator/RewriteElseBlocks.cpp
+src/compiler/translator/RewriteTexelFetchOffset.cpp
+src/compiler/translator/RewriteUnaryMinusOperatorInt.cpp
 src/compiler/translator/ScalarizeVecAndMatConstructorArgs.cpp
 src/compiler/translator/SearchSymbol.cpp
 src/compiler/translator/SearchSymbol.cpp
@@ -172,8 +142,11 @@
 src/compiler/translator/SeparateExpressionsReturningArrays.cpp
 src/compiler/translator/ShaderLang.cpp
 src/compiler/translator/ShaderVars.cpp
+src/compiler/translator/SimplifyLoopConditions.cpp
+src/compiler/translator/SplitSequenceOperator.cpp
 src/compiler/translator/StructureHLSL.cpp
 

[webkit-changes] [208038] trunk/LayoutTests

[gyuyoung . kim]

Title: [208038] trunk/LayoutTests








Revision 208038
Author gyuyoung@webkit.org
Date 2016-10-27 23:12:10 -0700 (Thu, 27 Oct 2016)


Log Message
[EFL] Skip media test for a while

Unreviewed EFL gardening.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (208037 => 208038)

--- trunk/LayoutTests/ChangeLog	2016-10-28 06:10:33 UTC (rev 208037)
+++ trunk/LayoutTests/ChangeLog	2016-10-28 06:12:10 UTC (rev 208038)
@@ -1,3 +1,11 @@
+2016-10-27  Gyuyoung Kim  
+
+[EFL] Skip media test for a while
+
+Unreviewed EFL gardening.
+
+* platform/efl/TestExpectations:
+
 2016-10-27  Myles C. Maxfield  
 
 Teach WebGL code about new buffer targets in WebGL2


Modified: trunk/LayoutTests/platform/efl/TestExpectations (208037 => 208038)

--- trunk/LayoutTests/platform/efl/TestExpectations	2016-10-28 06:10:33 UTC (rev 208037)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2016-10-28 06:12:10 UTC (rev 208038)
@@ -2821,3 +2821,6 @@
 webkit.org/b/163503 fast/dom/HTMLMeterElement/meter-element-markup.html [ Failure ]
 
 webkit.org/b/164022 media/media-source [ Skip ]
+
+# Skip media test for a while because EFL layout test has been blocked.
+media [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208039] trunk

[commit-queue]

Title: [208039] trunk








Revision 208039
Author commit-qu...@webkit.org
Date 2016-10-27 23:27:29 -0700 (Thu, 27 Oct 2016)


Log Message
[Fetch API] Fetch ReadableStream should only clone the second branch
https://bugs.webkit.org/show_bug.cgi?id=164058

Patch by Youenn Fablet  on 2016-10-27
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* web-platform-tests/fetch/api/response/response-clone-expected.txt:

Source/WebCore:

Covered by rebased tests.

* Modules/streams/ReadableStreamInternals.js:
(readableStreamTeePullFunction):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (208038 => 208039)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-10-28 06:12:10 UTC (rev 208038)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-10-28 06:27:29 UTC (rev 208039)
@@ -1,3 +1,12 @@
+2016-10-27  Youenn Fablet  
+
+[Fetch API] Fetch ReadableStream should only clone the second branch
+https://bugs.webkit.org/show_bug.cgi?id=164058
+
+Reviewed by Darin Adler.
+
+* web-platform-tests/fetch/api/response/response-clone-expected.txt:
+
 2016-10-27  Joseph Pecoraro  
 
 Web Inspector: Include ConsoleAgent in Workers - real console.log support


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt (208038 => 208039)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt	2016-10-28 06:12:10 UTC (rev 208038)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt	2016-10-28 06:27:29 UTC (rev 208039)
@@ -6,15 +6,15 @@
 PASS Cannot clone a disturbed response 
 PASS Cloned responses should provide the same data 
 PASS Cancelling stream should not affect cloned one 
-FAIL Check response clone use structureClone for teed ReadableStreams (Int8Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Int16Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Int32Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (ArrayBufferchunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint8Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint8ClampedArraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint16Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint32Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Float32Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Float64Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (DataViewchunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
+PASS Check response clone use structureClone for teed ReadableStreams (Int8Arraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Int16Arraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Int32Arraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (ArrayBufferchunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Uint8Arraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Uint8ClampedArraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Uint16Arraychunk) 
+PASS Check response clone use structureClone for teed 

[webkit-changes] [208040] trunk/Source

[achristensen]

Title: [208040] trunk/Source








Revision 208040
Author achristen...@apple.com
Date 2016-10-28 00:08:32 -0700 (Fri, 28 Oct 2016)


Log Message

Source/ThirdParty/ANGLE:
Fix Windows WebGL build after r208036
https://bugs.webkit.org/show_bug.cgi?id=164101

* CMakeLists.txt:

Source/WebCore:
Fix Windows WebGL build after r208022
https://bugs.webkit.org/show_bug.cgi?id=164091

* platform/graphics/opengl/Extensions3DOpenGLCommon.h:
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
* platform/graphics/opengl/Extensions3DOpenGLES.h:
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::getExtensions):

Modified Paths

trunk/Source/ThirdParty/ANGLE/CMakeLists.txt
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp




Diff

Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (208039 => 208040)

--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2016-10-28 06:27:29 UTC (rev 208039)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2016-10-28 07:08:32 UTC (rev 208040)
@@ -37,7 +37,6 @@
 src/libGLESv2/entry_points_gles_2_0.cpp
 src/libGLESv2/entry_points_gles_2_0_ext.cpp
 src/libGLESv2/entry_points_gles_3_0.cpp
-src/libGLESv2/entry_points_gles_3_0_ext.cpp
 src/libGLESv2/entry_points_gles_3_1.cpp
 src/libGLESv2/global_state.cpp
 src/libGLESv2/libGLESv2.cpp
@@ -90,10 +89,6 @@
 src/compiler/translator/Compiler.cpp
 src/compiler/translator/ConstantUnion.cpp
 src/compiler/translator/DeferGlobalInitializers.cpp
-src/compiler/translator/depgraph/DependencyGraph.cpp
-src/compiler/translator/depgraph/DependencyGraphBuilder.cpp
-src/compiler/translator/depgraph/DependencyGraphOutput.cpp
-src/compiler/translator/depgraph/DependencyGraphTraverse.cpp
 src/compiler/translator/Diagnostics.cpp
 src/compiler/translator/DirectiveHandler.cpp
 src/compiler/translator/EmulateGLFragColorBroadcast.cpp
@@ -147,8 +142,6 @@
 src/compiler/translator/StructureHLSL.cpp
 src/compiler/translator/SymbolTable.cpp
 src/compiler/translator/TextureFunctionHLSL.cpp
-src/compiler/translator/timing/RestrictFragmentShaderTiming.cpp
-src/compiler/translator/timing/RestrictVertexShaderTiming.cpp
 src/compiler/translator/TranslatorESSL.cpp
 src/compiler/translator/TranslatorGLSL.cpp
 src/compiler/translator/TranslatorHLSL.cpp
@@ -180,17 +173,13 @@
 src/libANGLE/Config.cpp
 src/libANGLE/Context.cpp
 src/libANGLE/ContextState.cpp
-src/libANGLE/Data.cpp
 src/libANGLE/Debug.cpp
 src/libANGLE/Device.cpp
 src/libANGLE/Display.cpp
 src/libANGLE/Error.cpp
 src/libANGLE/Fence.cpp
-src/libANGLE/Float16ToFloat32.cpp
 src/libANGLE/format_map_autogen.cpp
-src/libANGLE/format_map_autogen.cpp
 src/libANGLE/formatutils.cpp
-src/libANGLE/formatutils.cpp
 src/libANGLE/Framebuffer.cpp
 src/libANGLE/FramebufferAttachment.cpp
 src/libANGLE/HandleAllocator.cpp
@@ -208,7 +197,6 @@
 src/libANGLE/renderer/ContextImpl.cpp
 src/libANGLE/renderer/d3d/BufferD3D.cpp
 src/libANGLE/renderer/d3d/CompilerD3D.cpp
-src/libANGLE/renderer/d3d/copyimage.cpp
 src/libANGLE/renderer/d3d/d3d11/Blit11.cpp
 src/libANGLE/renderer/d3d/d3d11/Buffer11.cpp
 src/libANGLE/renderer/d3d/d3d11/Clear11.cpp
@@ -222,7 +210,6 @@
 src/libANGLE/renderer/d3d/d3d11/Image11.cpp
 src/libANGLE/renderer/d3d/d3d11/IndexBuffer11.cpp
 src/libANGLE/renderer/d3d/d3d11/InputLayoutCache.cpp
-src/libANGLE/renderer/d3d/d3d11/load_functions_table_autogen.cpp
 src/libANGLE/renderer/d3d/d3d11/PixelTransfer11.cpp
 src/libANGLE/renderer/d3d/d3d11/Query11.cpp
 src/libANGLE/renderer/d3d/d3d11/renderer11_utils.cpp
@@ -231,18 +218,15 @@
 src/libANGLE/renderer/d3d/d3d11/RenderTarget11.cpp
 src/libANGLE/renderer/d3d/d3d11/ShaderExecutable11.cpp
 src/libANGLE/renderer/d3d/d3d11/StateManager11.cpp
-src/libANGLE/renderer/d3d/d3d11/Stream11.cpp
 src/libANGLE/renderer/d3d/d3d11/StreamProducerNV12.cpp
 src/libANGLE/renderer/d3d/d3d11/SwapChain11.cpp
 src/libANGLE/renderer/d3d/d3d11/texture_format_table_autogen.cpp
 src/libANGLE/renderer/d3d/d3d11/texture_format_table.cpp
 src/libANGLE/renderer/d3d/d3d11/TextureStorage11.cpp
-src/libANGLE/renderer/d3d/d3d11/TextureStorage11.cpp
 src/libANGLE/renderer/d3d/d3d11/TransformFeedback11.cpp
 src/libANGLE/renderer/d3d/d3d11/Trim11.cpp
 src/libANGLE/renderer/d3d/d3d11/VertexArray11.cpp
 src/libANGLE/renderer/d3d/d3d11/VertexBuffer11.cpp
-src/libANGLE/renderer/d3d/d3d11/win32/NativeWindow.cpp
 

[webkit-changes] [208041] trunk/Source/ThirdParty/ANGLE

[achristensen]

Title: [208041] trunk/Source/ThirdParty/ANGLE








Revision 208041
Author achristen...@apple.com
Date 2016-10-28 00:17:35 -0700 (Fri, 28 Oct 2016)


Log Message
Another build fix.

* CMakeLists.txt:

Modified Paths

trunk/Source/ThirdParty/ANGLE/CMakeLists.txt
trunk/Source/ThirdParty/ANGLE/ChangeLog




Diff

Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (208040 => 208041)

--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2016-10-28 07:08:32 UTC (rev 208040)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2016-10-28 07:17:35 UTC (rev 208041)
@@ -233,6 +233,7 @@
 src/libANGLE/renderer/d3d/d3d9/Context9.cpp
 src/libANGLE/renderer/d3d/d3d9/DebugAnnotator9.cpp
 src/libANGLE/renderer/d3d/d3d9/Fence9.cpp
+src/libANGLE/renderer/d3d/d3d9/formatutils9.cpp
 src/libANGLE/renderer/d3d/d3d9/Framebuffer9.cpp
 src/libANGLE/renderer/d3d/d3d9/Image9.cpp
 src/libANGLE/renderer/d3d/d3d9/IndexBuffer9.cpp
@@ -251,7 +252,6 @@
 src/libANGLE/renderer/d3d/DisplayD3D.cpp
 src/libANGLE/renderer/d3d/DynamicHLSL.cpp
 src/libANGLE/renderer/d3d/EGLImageD3D.cpp
-src/libANGLE/renderer/d3d/formatutilsD3D.cpp
 src/libANGLE/renderer/d3d/FramebufferD3D.cpp
 src/libANGLE/renderer/d3d/HLSLCompiler.cpp
 src/libANGLE/renderer/d3d/ImageD3D.cpp


Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (208040 => 208041)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2016-10-28 07:08:32 UTC (rev 208040)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2016-10-28 07:17:35 UTC (rev 208041)
@@ -1,5 +1,11 @@
 2016-10-28  Alex Christensen  
 
+Another build fix.
+
+* CMakeLists.txt:
+
+2016-10-28  Alex Christensen  
+
 Fix Windows WebGL build after r208036
 https://bugs.webkit.org/show_bug.cgi?id=164101
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208042] trunk

[commit-queue]

Title: [208042] trunk








Revision 208042
Author commit-qu...@webkit.org
Date 2016-10-28 02:40:44 -0700 (Fri, 28 Oct 2016)


Log Message
[Modern Media Controls] Media Controller: scrubbing support
https://bugs.webkit.org/show_bug.cgi?id=163726


Patch by Antoine Quint  on 2016-10-28
Reviewed by Dean Jackson.

Source/WebCore:

We introduce the ScrubberSupport class which brings support for scrubbing the media
by interacting with the scrubber in the media controls and correctly reflecting
the media's current time as set via the media API.

Tests: media/modern-media-controls/scrubber-support/scrubber-support-click.html
   media/modern-media-controls/scrubber-support/scrubber-support-drag.html
   media/modern-media-controls/scrubber-support/scrubber-support-media-api.html

* Modules/modern-media-controls/js-files:
* Modules/modern-media-controls/media/media-controller.js:
(MediaController):
* Modules/modern-media-controls/media/scrubbing-support.js: Added.
(ScrubbingSupport.prototype.get control):
(ScrubbingSupport.prototype.get mediaEvents):
(ScrubbingSupport.prototype.controlValueWillStartChanging):
(ScrubbingSupport.prototype.controlValueDidChange):
(ScrubbingSupport.prototype.controlValueDidStopChanging):
(ScrubbingSupport.prototype.syncControl):
(ScrubbingSupport):
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Adding new tests for ScrubberSupport that test clicking in the scrubber,
dragging the scrubber and setting the media currentTime via the media API.
Also adding the new resource to other MediaController tests.

* http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html:
* media/modern-media-controls/elapsed-time-support/elapsed-time-support.html:
* media/modern-media-controls/media-controller/media-controller-constructor.html:
* media/modern-media-controls/media-controller/media-controller-resize.html:
* media/modern-media-controls/mute-support/mute-support-button-click.html:
* media/modern-media-controls/mute-support/mute-support-media-api.html:
* media/modern-media-controls/mute-support/mute-support-muted.html:
* media/modern-media-controls/playback-support/playback-support-autoplay.html:
* media/modern-media-controls/playback-support/playback-support-button-click.html:
* media/modern-media-controls/playback-support/playback-support-media-api.html:
* media/modern-media-controls/remaining-time-support/remaining-time-support.html:
* media/modern-media-controls/scrubber-support/scrubber-support-click-expected.txt: Added.
* media/modern-media-controls/scrubber-support/scrubber-support-click.html: Added.
* media/modern-media-controls/scrubber-support/scrubber-support-drag-expected.txt: Added.
* media/modern-media-controls/scrubber-support/scrubber-support-drag.html: Added.
* media/modern-media-controls/scrubber-support/scrubber-support-media-api-expected.txt: Added.
* media/modern-media-controls/scrubber-support/scrubber-support-media-api.html: Added.
* media/modern-media-controls/start-support/start-support-audio.html:
* media/modern-media-controls/start-support/start-support-autoplay.html:
* media/modern-media-controls/start-support/start-support-click-to-start.html:
* media/modern-media-controls/start-support/start-support-error.html:
* media/modern-media-controls/start-support/start-support-fullscreen.html:
* media/modern-media-controls/start-support/start-support-manual-play.html:
* media/modern-media-controls/start-support/start-support-no-source.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html
trunk/LayoutTests/media/modern-media-controls/elapsed-time-support/elapsed-time-support.html
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-constructor.html
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize.html
trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-button-click.html
trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-media-api.html
trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-muted.html
trunk/LayoutTests/media/modern-media-controls/playback-support/playback-support-autoplay.html
trunk/LayoutTests/media/modern-media-controls/playback-support/playback-support-button-click.html
trunk/LayoutTests/media/modern-media-controls/playback-support/playback-support-media-api.html
trunk/LayoutTests/media/modern-media-controls/remaining-time-support/remaining-time-support.html
trunk/LayoutTests/media/modern-media-controls/start-support/start-support-audio.html
trunk/LayoutTests/media/modern-media-controls/start-support/start-support-autoplay.html
trunk/LayoutTests/media/modern-media-controls/start-support/start-support-click-to-start.html

[webkit-changes] [208046] trunk

[commit-queue]

Title: [208046] trunk








Revision 208046
Author commit-qu...@webkit.org
Date 2016-10-28 06:59:20 -0700 (Fri, 28 Oct 2016)


Log Message
[Fetch] Ensure redirection count is no more than 20 in case of cross origin requests
https://bugs.webkit.org/show_bug.cgi?id=164117

Patch by Youenn Fablet  on 2016-10-28
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Adding new tests.
Split redirect.py in two different scripts.
redirect.py is to be used when simple redirections are needed.
redirect-count.py is to be used when the number of redirections is tested.

redirect.py no longer needs the count parameter.
This explains rebasing of the existing tests.

* web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt:
* web-platform-tests/fetch/api/basic/mode-same-origin-worker-expected.txt:
* web-platform-tests/fetch/api/cors/cors-redirect-credentials-expected.txt:
* web-platform-tests/fetch/api/cors/cors-redirect-credentials-worker-expected.txt:
* web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-expected.txt: Added.
* web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker-expected.txt: Added.
* web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker.html: Added.
* web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.html: Added.
* web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.js: Added.
(redirectCount):
* web-platform-tests/fetch/api/redirect/redirect-count-expected.txt:
* web-platform-tests/fetch/api/redirect/redirect-count-worker-expected.txt:
* web-platform-tests/fetch/api/redirect/redirect-count.js:
(redirectCount):
* web-platform-tests/fetch/api/request/request-cache-only-if-cached-expected.txt:
* web-platform-tests/fetch/api/resources/redirect-count.py: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/redirect.py.
(main):
* web-platform-tests/fetch/api/resources/redirect.py:
(main):

Source/WebCore:

Tests: imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker.html
   imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.html

Introducing a ResourceLoaderOptions that defines the maximum redirection count.
By default, it is set to 20 as per fetch specification.

This option is used by SubresourceLoader to cancel load if its redirection count is above that maximum.
DocumentThreadableLoader stopping redirections to make preflight if needed, it now uses the maxRedirectCount loader option to ensure
that the total number of redirections is 20.

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::redirectReceived):
* loader/ResourceLoaderOptions.h:
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
* loader/SubresourceLoader.h:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin-worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-credentials-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-credentials-worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count.js
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/redirect.py
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp
trunk/Source/WebCore/loader/ResourceLoaderOptions.h
trunk/Source/WebCore/loader/SubresourceLoader.cpp
trunk/Source/WebCore/loader/SubresourceLoader.h


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker.html
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.html
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.js
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/redirect-count.py




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (208045 => 208046)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-10-28 12:36:33 UTC (rev 208045)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-10-28 13:59:20 UTC (rev 208046)
@@ -1,3 +1,38 @@
+2016-10-28  Youenn Fablet  
+
+[Fetch] Ensure 

[webkit-changes] [208043] trunk/Source/WebCore

[commit-queue]

Title: [208043] trunk/Source/WebCore








Revision 208043
Author commit-qu...@webkit.org
Date 2016-10-28 04:14:51 -0700 (Fri, 28 Oct 2016)


Log Message
PeerMediaDescription does not need to be refcounted
https://bugs.webkit.org/show_bug.cgi?id=164059

Patch by Youenn Fablet  on 2016-10-28
Reviewed by Darin Adler.

No change of behavior.

* Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::createOfferTask):
(WebCore::MediaEndpointPeerConnection::createAnswerTask):
(WebCore::createSourceMap):
(WebCore::MediaEndpointPeerConnection::setLocalDescriptionTask):
(WebCore::MediaEndpointPeerConnection::setRemoteDescriptionTask):
(WebCore::MediaEndpointPeerConnection::addIceCandidateTask):
(WebCore::MediaEndpointPeerConnection::gotIceCandidate):
* Modules/mediastream/MediaEndpointPeerConnection.h:
* Modules/mediastream/SDPProcessor.cpp:
(WebCore::configurationFromJSON):
(WebCore::configurationToJSON):
(WebCore::SDPProcessor::generateCandidateLine):
(WebCore::SDPProcessor::parseCandidateLine):
* platform/mediastream/IceCandidate.h:
* platform/mediastream/MediaEndpointSessionConfiguration.h:
(WebCore::MediaEndpointSessionConfiguration::mediaDescriptions):
(WebCore::MediaEndpointSessionConfiguration::addMediaDescription):
(WebCore::MediaEndpointSessionConfiguration::clone):
* platform/mediastream/PeerMediaDescription.h:
(WebCore::PeerMediaDescription::addPayload):
(WebCore::PeerMediaDescription::addSsrc):
(WebCore::PeerMediaDescription::clearSsrcs):
(WebCore::PeerMediaDescription::addIceCandidate):
(WebCore::PeerMediaDescription::create): Deleted.
(WebCore::PeerMediaDescription::~PeerMediaDescription): Deleted.
(WebCore::PeerMediaDescription::type): Deleted.
(WebCore::PeerMediaDescription::setType): Deleted.
(WebCore::PeerMediaDescription::port): Deleted.
(WebCore::PeerMediaDescription::setPort): Deleted.
(WebCore::PeerMediaDescription::address): Deleted.
(WebCore::PeerMediaDescription::setAddress): Deleted.
(WebCore::PeerMediaDescription::mode): Deleted.
(WebCore::PeerMediaDescription::setMode): Deleted.
(WebCore::PeerMediaDescription::mid): Deleted.
(WebCore::PeerMediaDescription::setMid): Deleted.
(WebCore::PeerMediaDescription::payloads): Deleted.
(WebCore::PeerMediaDescription::setPayloads): Deleted.
(WebCore::PeerMediaDescription::rtcpMux): Deleted.
(WebCore::PeerMediaDescription::setRtcpMux): Deleted.
(WebCore::PeerMediaDescription::rtcpAddress): Deleted.
(WebCore::PeerMediaDescription::setRtcpAddress): Deleted.
(WebCore::PeerMediaDescription::rtcpPort): Deleted.
(WebCore::PeerMediaDescription::setRtcpPort): Deleted.
(WebCore::PeerMediaDescription::mediaStreamId): Deleted.
(WebCore::PeerMediaDescription::setMediaStreamId): Deleted.
(WebCore::PeerMediaDescription::mediaStreamTrackId): Deleted.
(WebCore::PeerMediaDescription::setMediaStreamTrackId): Deleted.
(WebCore::PeerMediaDescription::dtlsSetup): Deleted.
(WebCore::PeerMediaDescription::setDtlsSetup): Deleted.
(WebCore::PeerMediaDescription::dtlsFingerprintHashFunction): Deleted.
(WebCore::PeerMediaDescription::setDtlsFingerprintHashFunction): Deleted.
(WebCore::PeerMediaDescription::dtlsFingerprint): Deleted.
(WebCore::PeerMediaDescription::setDtlsFingerprint): Deleted.
(WebCore::PeerMediaDescription::cname): Deleted.
(WebCore::PeerMediaDescription::setCname): Deleted.
(WebCore::PeerMediaDescription::ssrcs): Deleted.
(WebCore::PeerMediaDescription::iceUfrag): Deleted.
(WebCore::PeerMediaDescription::setIceUfrag): Deleted.
(WebCore::PeerMediaDescription::icePassword): Deleted.
(WebCore::PeerMediaDescription::setIcePassword): Deleted.
(WebCore::PeerMediaDescription::iceCandidates): Deleted.
(WebCore::PeerMediaDescription::clone): Deleted.
(WebCore::PeerMediaDescription::PeerMediaDescription): Deleted.
* platform/mediastream/mac/MediaEndpointMac.cpp:
(WebCore::MediaEndpointMac::addRemoteCandidate):
(WebCore::MediaEndpointMac::OnIceCandidate):
* platform/mediastream/mac/MediaEndpointMac.h:
* platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:
(WebCore::MediaEndpointOwr::updateSendConfiguration):
* platform/mediastream/openwebrtc/MediaEndpointOwr.h:
* platform/mock/MockMediaEndpoint.cpp:
(WebCore::MockMediaEndpoint::updateConfigurationMids):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp
trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h
trunk/Source/WebCore/Modules/mediastream/SDPProcessor.cpp
trunk/Source/WebCore/platform/mediastream/MediaEndpointSessionConfiguration.h
trunk/Source/WebCore/platform/mediastream/PeerMediaDescription.h
trunk/Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.cpp
trunk/Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.h
trunk/Source/WebCore/platform/mock/MockMediaEndpoint.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208042 => 208043)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 09:40:44 UTC (rev 208042)
+++ 

[webkit-changes] [208098] trunk/Source/WebCore

[darin]

Title: [208098] trunk/Source/WebCore








Revision 208098
Author da...@apple.com
Date 2016-10-28 22:02:00 -0700 (Fri, 28 Oct 2016)


Log Message
Fix mismerge that broke a CEReactions test.

* html/HTMLOptionsCollection.idl: Add back CEReactions to the remove function.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLOptionsCollection.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (208097 => 208098)

--- trunk/Source/WebCore/ChangeLog	2016-10-29 03:16:10 UTC (rev 208097)
+++ trunk/Source/WebCore/ChangeLog	2016-10-29 05:02:00 UTC (rev 208098)
@@ -1,5 +1,11 @@
 2016-10-28  Darin Adler  
 
+Fix mismerge that broke a CEReactions test.
+
+* html/HTMLOptionsCollection.idl: Add back CEReactions to the remove function.
+
+2016-10-28  Darin Adler  
+
 Move all classes in the HTML directory from ExceptionCode to Exception
 https://bugs.webkit.org/show_bug.cgi?id=163876
 


Modified: trunk/Source/WebCore/html/HTMLOptionsCollection.idl (208097 => 208098)

--- trunk/Source/WebCore/html/HTMLOptionsCollection.idl	2016-10-29 03:16:10 UTC (rev 208097)
+++ trunk/Source/WebCore/html/HTMLOptionsCollection.idl	2016-10-29 05:02:00 UTC (rev 208098)
@@ -32,7 +32,7 @@
 
 [CEReactions, MayThrowException] void add((HTMLOptionElement or HTMLOptGroupElement) element, optional (HTMLElement or long)? before = null);
 
-void remove(long index);
+[CEReactions] void remove(long index);
 
 // FIXME: This overload is not in the specification and has been dropped from Blink.
 [CEReactions] void remove(HTMLOptionElement option);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208076] trunk/Source/WebCore

[hyatt]

Title: [208076] trunk/Source/WebCore








Revision 208076
Author hy...@apple.com
Date 2016-10-28 15:19:11 -0700 (Fri, 28 Oct 2016)


Log Message
[CSS Parser] Fix font-family parsing inside @font-face
https://bugs.webkit.org/show_bug.cgi?id=164155

Reviewed by Simon Fraser.

* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
Use the full font-family parsing that returns a CSSValueList,
since we can handle multiple families.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208075 => 208076)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 22:10:35 UTC (rev 208075)
+++ trunk/Source/WebCore/ChangeLog	2016-10-28 22:19:11 UTC (rev 208076)
@@ -1,3 +1,15 @@
+2016-10-28  Dave Hyatt  
+
+[CSS Parser] Fix font-family parsing inside @font-face
+https://bugs.webkit.org/show_bug.cgi?id=164155
+
+Reviewed by Simon Fraser.
+
+* css/parser/CSSPropertyParser.cpp:
+(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
+Use the full font-family parsing that returns a CSSValueList,
+since we can handle multiple families.
+
 2016-10-28  Per Arne Vollan  
 
 [Win][Direct2D] Implement ImageBufferData::putData.


Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (208075 => 208076)

--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp	2016-10-28 22:10:35 UTC (rev 208075)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp	2016-10-28 22:19:11 UTC (rev 208076)
@@ -3679,9 +3679,7 @@
 RefPtr parsedValue;
 switch (propId) {
 case CSSPropertyFontFamily:
-if (consumeGenericFamily(m_range))
-return false;
-parsedValue = consumeFamilyName(m_range);
+parsedValue = consumeFontFamily(m_range);
 break;
 case CSSPropertySrc: // This is a list of urls or local references.
 parsedValue = consumeFontFaceSrc(m_range, m_context);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208084] tags/Safari-602.3.6/

[matthew_hanson]

Title: [208084] tags/Safari-602.3.6/








Revision 208084
Author matthew_han...@apple.com
Date 2016-10-28 17:05:21 -0700 (Fri, 28 Oct 2016)


Log Message
New tag.

Added Paths

tags/Safari-602.3.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208086] trunk

[achristensen]

Title: [208086] trunk








Revision 208086
Author achristen...@apple.com
Date 2016-10-28 17:17:01 -0700 (Fri, 28 Oct 2016)


Log Message
URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
https://bugs.webkit.org/show_bug.cgi?id=164154

Reviewed by Andy Estes.

Source/WebCore:

This is needed to match behavior of all browsers.
This is being discussed in the spec at https://github.com/whatwg/url/issues/148

Covered by new API tests.

* platform/URLParser.cpp:
(WebCore::URLParser::parseHostAndPort):
Only try to parse and canonicalize the host as an IPv4 address if the scheme is special (http, wss, etc.)

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208085 => 208086)

--- trunk/Source/WebCore/ChangeLog	2016-10-29 00:14:37 UTC (rev 208085)
+++ trunk/Source/WebCore/ChangeLog	2016-10-29 00:17:01 UTC (rev 208086)
@@ -1,3 +1,19 @@
+2016-10-28  Alex Christensen  
+
+URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
+https://bugs.webkit.org/show_bug.cgi?id=164154
+
+Reviewed by Andy Estes.
+
+This is needed to match behavior of all browsers.
+This is being discussed in the spec at https://github.com/whatwg/url/issues/148
+
+Covered by new API tests.
+
+* platform/URLParser.cpp:
+(WebCore::URLParser::parseHostAndPort):
+Only try to parse and canonicalize the host as an IPv4 address if the scheme is special (http, wss, etc.)
+
 2016-10-28  Chris Dumez  
 
 DOMStringMap reports properties as non-enumerable


Modified: trunk/Source/WebCore/platform/URLParser.cpp (208085 => 208086)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-10-29 00:14:37 UTC (rev 208085)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-10-29 00:17:01 UTC (rev 208086)
@@ -2572,25 +2572,28 @@
 if (isInvalidDomainCharacter(*iterator))
 return false;
 }
-if (auto address = parseIPv4Host(CodePointIterator(hostIterator, iterator))) {
-serializeIPv4(address.value());
-m_url.m_hostEnd = currentPosition(iterator);
-if (iterator.atEnd()) {
-m_url.m_portEnd = currentPosition(iterator);
-return true;
+if (m_urlIsSpecial) {
+if (auto address = parseIPv4Host(CodePointIterator(hostIterator, iterator))) {
+serializeIPv4(address.value());
+m_url.m_hostEnd = currentPosition(iterator);
+if (iterator.atEnd()) {
+m_url.m_portEnd = currentPosition(iterator);
+return true;
+}
+return parsePort(iterator);
 }
-return parsePort(iterator);
 }
 for (; hostIterator != iterator; ++hostIterator) {
-if (LIKELY(!isTabOrNewline(*hostIterator))) {
-if (m_urlIsSpecial) {
-if (UNLIKELY(isASCIIUpper(*hostIterator)))
-syntaxViolation(hostIterator);
-appendToASCIIBuffer(toASCIILower(*hostIterator));
-} else
-appendToASCIIBuffer(*hostIterator);
+if (UNLIKELY(isTabOrNewline(*hostIterator))) {
+syntaxViolation(hostIterator);
+continue;
+}
+if (m_urlIsSpecial) {
+if (UNLIKELY(isASCIIUpper(*hostIterator)))
+syntaxViolation(hostIterator);
+appendToASCIIBuffer(toASCIILower(*hostIterator));
 } else
-syntaxViolation(hostIterator);
+appendToASCIIBuffer(*hostIterator);
 }
 m_url.m_hostEnd = currentPosition(iterator);
 if (!hostIterator.atEnd())


Modified: trunk/Tools/ChangeLog (208085 => 208086)

--- trunk/Tools/ChangeLog	2016-10-29 00:14:37 UTC (rev 208085)
+++ trunk/Tools/ChangeLog	2016-10-29 00:17:01 UTC (rev 208086)
@@ -1,3 +1,13 @@
+2016-10-28  Alex Christensen  
+
+URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
+https://bugs.webkit.org/show_bug.cgi?id=164154
+
+Reviewed by Andy Estes.
+
+* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
+(TestWebKitAPI::TEST_F):
+
 2016-10-28  Sam Weinig  
 
 [WebIDL] Update parser and code generators to only access type information through the type property


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp (208085 => 208086)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-10-29 00:14:37 UTC (rev 208085)
+++ 

[webkit-changes] [208078] trunk/Source/JavaScriptCore

[utatane . tea]

Title: [208078] trunk/Source/_javascript_Core








Revision 208078
Author utatane@gmail.com
Date 2016-10-28 16:19:06 -0700 (Fri, 28 Oct 2016)


Log Message
[DOMJIT] Include identifier name in CallDOMGetter to dump it
https://bugs.webkit.org/show_bug.cgi?id=164161

Reviewed by Mark Lam.

This patch adds an identifier number to CallDOMGetterData and use it when dumping the data.
CallDOMGetter did not include identifier. It made CallDOMGetter super hard to debug when dumping DFG graph.

The dump becomes like this.

CallDOMGetter(Cell:@21, JS|MustGen|UseAsOther, Nonboolint32, id0{customGetter}, domJIT = 0x42f8a0, R:World, W:Heap, Exits, ClobbersExit, bc#15)  predicting Nonboolint32

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleDOMJITGetter):
(JSC::DFG::ByteCodeParser::handleGetById):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGNode.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp
trunk/Source/_javascript_Core/dfg/DFGNode.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (208077 => 208078)

--- trunk/Source/_javascript_Core/ChangeLog	2016-10-28 22:57:10 UTC (rev 208077)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-10-28 23:19:06 UTC (rev 208078)
@@ -1,5 +1,26 @@
 2016-10-28  Yusuke Suzuki  
 
+[DOMJIT] Include identifier name in CallDOMGetter to dump it
+https://bugs.webkit.org/show_bug.cgi?id=164161
+
+Reviewed by Mark Lam.
+
+This patch adds an identifier number to CallDOMGetterData and use it when dumping the data.
+CallDOMGetter did not include identifier. It made CallDOMGetter super hard to debug when dumping DFG graph.
+
+The dump becomes like this.
+
+CallDOMGetter(Cell:@21, JS|MustGen|UseAsOther, Nonboolint32, id0{customGetter}, domJIT = 0x42f8a0, R:World, W:Heap, Exits, ClobbersExit, bc#15)  predicting Nonboolint32
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::handleDOMJITGetter):
+(JSC::DFG::ByteCodeParser::handleGetById):
+* dfg/DFGGraph.cpp:
+(JSC::DFG::Graph::dump):
+* dfg/DFGNode.h:
+
+2016-10-28  Yusuke Suzuki  
+
 [DOMJIT] Rename CallDOM to CallDOMGetter
 https://bugs.webkit.org/show_bug.cgi?id=164157
 


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (208077 => 208078)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2016-10-28 22:57:10 UTC (rev 208077)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2016-10-28 23:19:06 UTC (rev 208078)
@@ -219,7 +219,7 @@
 bool handleConstantInternalFunction(Node* callTargetNode, int resultOperand, InternalFunction*, int registerOffset, int argumentCountIncludingThis, CodeSpecializationKind, SpeculatedType, const ChecksFunctor& insertChecks);
 Node* handlePutByOffset(Node* base, unsigned identifier, PropertyOffset, const InferredType::Descriptor&, Node* value);
 Node* handleGetByOffset(SpeculatedType, Node* base, unsigned identifierNumber, PropertyOffset, const InferredType::Descriptor&, NodeType = GetByOffset);
-bool handleDOMJITGetter(int resultOperand, const GetByIdVariant&, Node* thisNode, SpeculatedType prediction);
+bool handleDOMJITGetter(int resultOperand, const GetByIdVariant&, Node* thisNode, unsigned identifierNumber, SpeculatedType prediction);
 
 // Create a presence ObjectPropertyCondition based on some known offset and structure set. Does not
 // check the validity of the condition, but it may return a null one if it encounters a contradiction.
@@ -2680,7 +2680,7 @@
 node->clearFlags(NodeMustGenerate);
 }
 
-bool ByteCodeParser::handleDOMJITGetter(int resultOperand, const GetByIdVariant& variant, Node* thisNode, SpeculatedType prediction)
+bool ByteCodeParser::handleDOMJITGetter(int resultOperand, const GetByIdVariant& variant, Node* thisNode, unsigned identifierNumber, SpeculatedType prediction)
 {
 if (!variant.domJIT())
 return false;
@@ -2704,6 +2704,7 @@
 
 callDOMGetterData->domJIT = domJIT;
 callDOMGetterData->patchpoint = callDOMGetterPatchpoint.ptr();
+callDOMGetterData->identifierNumber = identifierNumber;
 
 Node* callDOMGetterNode = nullptr;
 // GlobalObject of thisNode is always used to create a DOMWrapper.
@@ -3318,7 +3319,7 @@
 ASSERT(!getByIdStatus.makesCalls());
 GetByIdVariant variant = getByIdStatus[0];
 ASSERT(variant.domJIT());
-if (handleDOMJITGetter(destinationOperand, variant, base, prediction)) {
+if (handleDOMJITGetter(destinationOperand, variant, base, identifierNumber, prediction)) {
 if (m_graph.compilation())
 m_graph.compilation()->noticeInlinedGetById();
 return;


Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.cpp (208077 => 208078)

--- 

[webkit-changes] [208080] trunk

[commit-queue]

Title: [208080] trunk








Revision 208080
Author commit-qu...@webkit.org
Date 2016-10-28 16:35:14 -0700 (Fri, 28 Oct 2016)


Log Message
[Modern Media Controls] Media Controller: volume control support
https://bugs.webkit.org/show_bug.cgi?id=163727

Patch by Antoine Quint  on 2016-10-28
Reviewed by Dean Jackson.

Source/WebCore:

We introduce the VolumeSupport class which brings support for modifying the media
volume by interacting with the mute volume slider in the media controls and correctly
reflecting the media's volume should it be changed via the media API.

Tests: media/modern-media-controls/volume-support/volume-support-click.html
   media/modern-media-controls/volume-support/volume-support-drag.html
   media/modern-media-controls/volume-support/volume-support-media-api-mute.html
   media/modern-media-controls/volume-support/volume-support-media-api.html

* Modules/modern-media-controls/js-files:
* Modules/modern-media-controls/media/media-controller.js:
(MediaController):
* Modules/modern-media-controls/media/volume-support.js: Added.
(VolumeSupport.prototype.get control):
(VolumeSupport.prototype.get mediaEvents):
(VolumeSupport.prototype.controlValueWillStartChanging):
(VolumeSupport.prototype.controlValueDidChange):
(VolumeSupport.prototype.syncControl):
(VolumeSupport):
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Adding new tests for VolumeSupport and adding the new resource to other MediaController tests.

* http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html:
* media/modern-media-controls/elapsed-time-support/elapsed-time-support.html:
* media/modern-media-controls/media-controller/media-controller-constructor.html:
* media/modern-media-controls/media-controller/media-controller-resize.html:
* media/modern-media-controls/mute-support/mute-support-button-click.html:
* media/modern-media-controls/mute-support/mute-support-media-api.html:
* media/modern-media-controls/mute-support/mute-support-muted.html:
* media/modern-media-controls/playback-support/playback-support-autoplay.html:
* media/modern-media-controls/playback-support/playback-support-button-click.html:
* media/modern-media-controls/playback-support/playback-support-media-api.html:
* media/modern-media-controls/remaining-time-support/remaining-time-support.html:
* media/modern-media-controls/scrubber-support/scrubber-support-click.html:
* media/modern-media-controls/scrubber-support/scrubber-support-drag.html:
* media/modern-media-controls/scrubber-support/scrubber-support-media-api.html:
* media/modern-media-controls/start-support/start-support-audio.html:
* media/modern-media-controls/start-support/start-support-autoplay.html:
* media/modern-media-controls/start-support/start-support-click-to-start.html:
* media/modern-media-controls/start-support/start-support-error.html:
* media/modern-media-controls/start-support/start-support-fullscreen.html:
* media/modern-media-controls/start-support/start-support-manual-play.html:
* media/modern-media-controls/start-support/start-support-no-source.html:
* media/modern-media-controls/volume-support/volume-support-click-expected.txt: Added.
* media/modern-media-controls/volume-support/volume-support-click.html: Added.
* media/modern-media-controls/volume-support/volume-support-drag-expected.txt: Added.
* media/modern-media-controls/volume-support/volume-support-drag.html: Added.
* media/modern-media-controls/volume-support/volume-support-media-api-expected.txt: Added.
* media/modern-media-controls/volume-support/volume-support-media-api-mute-expected.txt: Added.
* media/modern-media-controls/volume-support/volume-support-media-api-mute.html: Added.
* media/modern-media-controls/volume-support/volume-support-media-api.html: Added.
* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html
trunk/LayoutTests/media/modern-media-controls/elapsed-time-support/elapsed-time-support.html
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-constructor.html
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize.html
trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-button-click.html
trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-media-api.html
trunk/LayoutTests/media/modern-media-controls/mute-support/mute-support-muted.html
trunk/LayoutTests/media/modern-media-controls/playback-support/playback-support-autoplay.html
trunk/LayoutTests/media/modern-media-controls/playback-support/playback-support-button-click.html
trunk/LayoutTests/media/modern-media-controls/playback-support/playback-support-media-api.html
trunk/LayoutTests/media/modern-media-controls/remaining-time-support/remaining-time-support.html

[webkit-changes] [208082] trunk

[rniwa]

Title: [208082] trunk








Revision 208082
Author rn...@webkit.org
Date 2016-10-28 16:49:46 -0700 (Fri, 28 Oct 2016)


Log Message
Add CEReactions to the remaining HTML DOM APIs
https://bugs.webkit.org/show_bug.cgi?id=163969

Reviewed by Chris Dumez.

Source/WebCore:

Added CEReactions to the remaining DOM and HTML APIs as needed.

Tests: fast/custom-elements/reactions-for-indieui.html
   fast/custom-elements/reactions/Document.html
   fast/custom-elements/reactions/HTMLAnchorElement.html
   fast/custom-elements/reactions/HTMLOptionElement.html
   fast/custom-elements/reactions/HTMLOptionsCollection.html
   fast/custom-elements/reactions/HTMLOutputElement.html
   fast/custom-elements/reactions/HTMLSelectElement.html
   fast/custom-elements/reactions/HTMLTableElement.html
   fast/custom-elements/reactions/HTMLTableRowElement.html
   fast/custom-elements/reactions/HTMLTableSectionElement.html
   fast/custom-elements/reactions/HTMLTitleElement.html
   fast/custom-elements/reactions/ShadowRoot.html

* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::setLength):
(WebCore::JSHTMLOptionsCollection::indexSetter):
* bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::JSHTMLSelectElement::indexSetter):
* dom/CharacterData.idl:
* dom/Document.idl:
* dom/Element.idl:
* dom/ShadowRoot.idl:
* html/HTMLAnchorElement.idl:
* html/HTMLDocument.idl:
* html/HTMLOptionElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLOutputElement.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTableRowElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLTitleElement.idl:

LayoutTests:

Added W3C style testharness.js tests for CEReactions to various HTMLElements under fast/custom-elements/reactions.
Also added some WebKit specific tests using the same harness outside that directory.

* fast/custom-elements/reactions-for-indieui-expected.txt: Added.
* fast/custom-elements/reactions-for-indieui.html: Added.
* fast/custom-elements/reactions-for-webkit-extensions-expected.txt:
* fast/custom-elements/reactions-for-webkit-extensions.html:
* fast/custom-elements/reactions/Document-expected.txt: Added.
* fast/custom-elements/reactions/Document.html: Added.
* fast/custom-elements/reactions/HTMLAnchorElement-expected.txt: Added.
* fast/custom-elements/reactions/HTMLAnchorElement.html: Added.
* fast/custom-elements/reactions/HTMLOptionElement-expected.txt: Added.
* fast/custom-elements/reactions/HTMLOptionElement.html: Added.
* fast/custom-elements/reactions/HTMLOptionsCollection-expected.txt: Added.
* fast/custom-elements/reactions/HTMLOptionsCollection.html: Added.
* fast/custom-elements/reactions/HTMLOutputElement-expected.txt: Added.
* fast/custom-elements/reactions/HTMLOutputElement.html: Added.
* fast/custom-elements/reactions/HTMLSelectElement-expected.txt: Added.
* fast/custom-elements/reactions/HTMLSelectElement.html: Added.
* fast/custom-elements/reactions/HTMLTableElement-expected.txt: Added.
* fast/custom-elements/reactions/HTMLTableElement.html: Added.
* fast/custom-elements/reactions/HTMLTableRowElement-expected.txt: Added.
* fast/custom-elements/reactions/HTMLTableRowElement.html: Added.
* fast/custom-elements/reactions/HTMLTableSectionElement-expected.txt: Added.
* fast/custom-elements/reactions/HTMLTableSectionElement.html: Added.
* fast/custom-elements/reactions/HTMLTitleElement-expected.txt: Added.
* fast/custom-elements/reactions/HTMLTitleElement.html: Added.
* fast/custom-elements/reactions/ShadowRoot-expected.txt: Added.
* fast/custom-elements/reactions/ShadowRoot.html: Added.
* fast/custom-elements/resources/additional-helpers.js: Added.
* fast/custom-elements/upgrading-enqueue-reactions-expected.txt:
* fast/custom-elements/upgrading-enqueue-reactions.html:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt
trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html
trunk/LayoutTests/fast/custom-elements/upgrading-enqueue-reactions-expected.txt
trunk/LayoutTests/fast/custom-elements/upgrading-enqueue-reactions.html
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSHTMLOptionsCollectionCustom.cpp
trunk/Source/WebCore/bindings/js/JSHTMLSelectElementCustom.cpp
trunk/Source/WebCore/dom/CharacterData.idl
trunk/Source/WebCore/dom/Document.idl
trunk/Source/WebCore/dom/Element.idl
trunk/Source/WebCore/dom/ShadowRoot.idl
trunk/Source/WebCore/html/HTMLAnchorElement.idl
trunk/Source/WebCore/html/HTMLDocument.idl
trunk/Source/WebCore/html/HTMLOptionElement.idl
trunk/Source/WebCore/html/HTMLOptionsCollection.idl
trunk/Source/WebCore/html/HTMLOutputElement.idl
trunk/Source/WebCore/html/HTMLSelectElement.idl
trunk/Source/WebCore/html/HTMLTableElement.idl

[webkit-changes] [208085] branches/safari-602-branch/Source

[matthew_hanson]

Title: [208085] branches/safari-602-branch/Source








Revision 208085
Author matthew_han...@apple.com
Date 2016-10-28 17:14:37 -0700 (Fri, 28 Oct 2016)


Log Message
Versioning.

Modified Paths

branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig (208084 => 208085)

--- branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-10-29 00:05:21 UTC (rev 208084)
+++ branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-10-29 00:14:37 UTC (rev 208085)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 3;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig (208084 => 208085)

--- branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig	2016-10-29 00:05:21 UTC (rev 208084)
+++ branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig	2016-10-29 00:14:37 UTC (rev 208085)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 3;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (208084 => 208085)

--- branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-10-29 00:05:21 UTC (rev 208084)
+++ branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-10-29 00:14:37 UTC (rev 208085)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 3;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig (208084 => 208085)

--- branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-10-29 00:05:21 UTC (rev 208084)
+++ branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-10-29 00:14:37 UTC (rev 208085)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 3;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig (208084 => 208085)

--- branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-10-29 00:05:21 UTC (rev 208084)
+++ branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-10-29 00:14:37 UTC (rev 208085)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 3;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208088] trunk/Source/WebCore

[hyatt]

Title: [208088] trunk/Source/WebCore








Revision 208088
Author hy...@apple.com
Date 2016-10-28 17:28:15 -0700 (Fri, 28 Oct 2016)


Log Message
[CSS Parser] Allow unknown properties in will-change
https://bugs.webkit.org/show_bug.cgi?id=164165

Reviewed by Simon Fraser.

* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeWillChange):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208087 => 208088)

--- trunk/Source/WebCore/ChangeLog	2016-10-29 00:20:38 UTC (rev 208087)
+++ trunk/Source/WebCore/ChangeLog	2016-10-29 00:28:15 UTC (rev 208088)
@@ -1,3 +1,13 @@
+2016-10-28  Dave Hyatt  
+
+[CSS Parser] Allow unknown properties in will-change
+https://bugs.webkit.org/show_bug.cgi?id=164165
+
+Reviewed by Simon Fraser.
+
+* css/parser/CSSPropertyParser.cpp:
+(WebCore::consumeWillChange):
+
 2016-10-28  Alex Christensen  
 
 Partially revert 207805 after resolution in URL spec issue 87


Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (208087 => 208088)

--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp	2016-10-29 00:20:38 UTC (rev 208087)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp	2016-10-29 00:28:15 UTC (rev 208088)
@@ -393,7 +393,8 @@
 // Need to return nullptr when currentValue is CSSPropertyAll.
 if (propertyID == CSSPropertyWillChange || propertyID == CSSPropertyAll)
 return nullptr;
-values->append(CSSCustomIdentValue::create(propertyID));
+// FIXME-NEWPARSER: Use CSSCustomIdentValue someday.
+values->append(CSSValuePool::singleton().createIdentifierValue(propertyID));
 range.consumeIncludingWhitespace();
 } else {
 switch (range.peek().id()) {
@@ -409,7 +410,8 @@
 values->append(consumeIdent(range).releaseNonNull());
 break;
 default:
-range.consumeIncludingWhitespace();
+// Append properties we don't recognize, but that are legal, as strings.
+values->append(consumeCustomIdent(range).releaseNonNull());
 break;
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208077] trunk/Source

[utatane . tea]

Title: [208077] trunk/Source








Revision 208077
Author utatane@gmail.com
Date 2016-10-28 15:57:10 -0700 (Fri, 28 Oct 2016)


Log Message
[DOMJIT] Rename CallDOM to CallDOMGetter
https://bugs.webkit.org/show_bug.cgi?id=164157

Reviewed by Keith Miller.

Source/_javascript_Core:

Rename CallDOM to CallDOMGetter to represent that
this is used for DOMJIT getter explicitly.
CallDOM will be used for DOM functions (like element.getAttribute()) later.

* _javascript_Core.xcodeproj/project.pbxproj:
* bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::emitDOMJITGetter):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::blessCallDOMGetter):
(JSC::DFG::ByteCodeParser::handleDOMJITGetter):
(JSC::DFG::blessCallDOM): Deleted.
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGGraph.h:
* dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasCallDOMGetterData):
(JSC::DFG::Node::callDOMGetterData):
(JSC::DFG::Node::hasCallDOMData): Deleted.
(JSC::DFG::Node::callDOMData): Deleted.
* dfg/DFGNodeType.h:
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCallDOMGetter):
(JSC::DFG::SpeculativeJIT::compileCallDOM): Deleted.
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* domjit/DOMJITCallDOMGetterPatchpoint.h: Renamed from Source/_javascript_Core/domjit/DOMJITCallDOMPatchpoint.h.
(JSC::DOMJIT::CallDOMGetterPatchpoint::create):
* domjit/DOMJITGetterSetter.h:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOMGetter):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOM): Deleted.
* jsc.cpp:

Source/WebCore:

No behavior change.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bindings/scripts/test/JS/JSTestDOMJIT.h:
* domjit/JSDocumentDOMJIT.cpp:
(WebCore::DocumentDocumentElementDOMJIT::callDOMGetter):
(WebCore::DocumentDocumentElementDOMJIT::callDOM): Deleted.
* domjit/JSNodeDOMJIT.cpp:
(WebCore::createCallDOMGetterForOffsetAccess):
(WebCore::NodeFirstChildDOMJIT::callDOMGetter):
(WebCore::NodeLastChildDOMJIT::callDOMGetter):
(WebCore::NodeNextSiblingDOMJIT::callDOMGetter):
(WebCore::NodePreviousSiblingDOMJIT::callDOMGetter):
(WebCore::NodeParentNodeDOMJIT::callDOMGetter):
(WebCore::NodeNodeTypeDOMJIT::callDOMGetter):
(WebCore::NodeOwnerDocumentDOMJIT::callDOMGetter):
(WebCore::createCallDOMForOffsetAccess): Deleted.
(WebCore::NodeFirstChildDOMJIT::callDOM): Deleted.
(WebCore::NodeLastChildDOMJIT::callDOM): Deleted.
(WebCore::NodeNextSiblingDOMJIT::callDOM): Deleted.
(WebCore::NodePreviousSiblingDOMJIT::callDOM): Deleted.
(WebCore::NodeParentNodeDOMJIT::callDOM): Deleted.
(WebCore::NodeNodeTypeDOMJIT::callDOM): Deleted.
(WebCore::NodeOwnerDocumentDOMJIT::callDOM): Deleted.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/bytecode/PolymorphicAccess.cpp
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/dfg/DFGDoesGC.cpp
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGNodeType.h
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/domjit/DOMJITGetterSetter.h
trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.h
trunk/Source/WebCore/domjit/JSDocumentDOMJIT.cpp
trunk/Source/WebCore/domjit/JSNodeDOMJIT.cpp


Added Paths

trunk/Source/_javascript_Core/domjit/DOMJITCallDOMGetterPatchpoint.h


Removed Paths

trunk/Source/_javascript_Core/domjit/DOMJITCallDOMPatchpoint.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (208076 => 208077)

--- trunk/Source/_javascript_Core/ChangeLog	2016-10-28 22:19:11 UTC (rev 208076)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-10-28 22:57:10 UTC (rev 208077)
@@ -1,5 +1,61 @@
 2016-10-28  Yusuke Suzuki  

[webkit-changes] [208079] branches/safari-602-branch/LayoutTests

[joepeck]

Title: [208079] branches/safari-602-branch/LayoutTests








Revision 208079
Author joep...@webkit.org
Date 2016-10-28 16:28:16 -0700 (Fri, 28 Oct 2016)


Log Message
Fix merge r207229. rdar://problem/29007278

* inspector/console/console-log-proxy.html:

Modified Paths

branches/safari-602-branch/LayoutTests/ChangeLog
branches/safari-602-branch/LayoutTests/inspector/console/console-log-proxy.html




Diff

Modified: branches/safari-602-branch/LayoutTests/ChangeLog (208078 => 208079)

--- branches/safari-602-branch/LayoutTests/ChangeLog	2016-10-28 23:19:06 UTC (rev 208078)
+++ branches/safari-602-branch/LayoutTests/ChangeLog	2016-10-28 23:28:16 UTC (rev 208079)
@@ -1,3 +1,9 @@
+2016-10-28  Joseph Pecoraro  
+
+Fix merge r207229. rdar://problem/29007278
+
+* inspector/console/console-log-proxy.html:
+
 2016-10-27  Mark Lam  
 
 Merge r207518. rdar://problem/28216050, rdar://problem/28216232


Modified: branches/safari-602-branch/LayoutTests/inspector/console/console-log-proxy.html (208078 => 208079)

--- branches/safari-602-branch/LayoutTests/inspector/console/console-log-proxy.html	2016-10-28 23:19:06 UTC (rev 208078)
+++ branches/safari-602-branch/LayoutTests/inspector/console/console-log-proxy.html	2016-10-28 23:28:16 UTC (rev 208079)
@@ -43,7 +43,7 @@
 InspectorTest.evaluateInPage("triggerProxyConsoleLog()", () => {
 InspectorTest.evaluateInPage("window.accessedHandlerGet", (error, result) => {
 let value = WebInspector.RemoteObject.fromPayload(result).value;
-InspectorTest.expectEqual(value, false, "Logging Proxy objects should not have triggered get trap.");
+InspectorTest.expectThat(value === false, "Logging Proxy objects should not have triggered get trap.");
 resolve();
 });
 });
@@ -57,7 +57,7 @@
 InspectorTest.evaluateInPage("triggerProxyAndPrimitiveConsoleLog()", () => {
 InspectorTest.evaluateInPage("window.accessedHandlerGet", (error, result) => {
 let value = WebInspector.RemoteObject.fromPayload(result).value;
-InspectorTest.expectEqual(value, false, "Logging Proxy objects and primitives should not have triggered get trap.");
+InspectorTest.expectThat(value === false, "Logging Proxy objects and primitives should not have triggered get trap.");
 resolve();
 });
 });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208081] trunk/Source/WebKit2

[achristensen]

Title: [208081] trunk/Source/WebKit2








Revision 208081
Author achristen...@apple.com
Date 2016-10-28 16:39:36 -0700 (Fri, 28 Oct 2016)


Log Message
Rename SharedMemoryMac to SharedMemoryCocoa
https://bugs.webkit.org/show_bug.cgi?id=164156

Patch by Megan Gardner  on 2016-10-28
Reviewed by Alex Christensen.

Renamed SharedMemoryMac to SharedMemoryCocoa, as it runs on all cocoa platforms, not exclusively just mac, and
thus should be named to reflect that reality.

* Platform/cocoa: Added.
* Platform/cocoa/SharedMemoryCocoa.cpp: Copied from Source/WebKit2/Platform/mac/SharedMemoryMac.cpp.
* Platform/mac/SharedMemoryMac.cpp: Removed.
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/Platform/cocoa/
trunk/Source/WebKit2/Platform/cocoa/SharedMemoryCocoa.cpp


Removed Paths

trunk/Source/WebKit2/Platform/mac/SharedMemoryMac.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (208080 => 208081)

--- trunk/Source/WebKit2/ChangeLog	2016-10-28 23:35:14 UTC (rev 208080)
+++ trunk/Source/WebKit2/ChangeLog	2016-10-28 23:39:36 UTC (rev 208081)
@@ -1,3 +1,18 @@
+2016-10-28  Megan Gardner  
+
+Rename SharedMemoryMac to SharedMemoryCocoa
+https://bugs.webkit.org/show_bug.cgi?id=164156
+
+Reviewed by Alex Christensen.
+
+Renamed SharedMemoryMac to SharedMemoryCocoa, as it runs on all cocoa platforms, not exclusively just mac, and
+thus should be named to reflect that reality.
+
+* Platform/cocoa: Added.
+* Platform/cocoa/SharedMemoryCocoa.cpp: Copied from Source/WebKit2/Platform/mac/SharedMemoryMac.cpp.
+* Platform/mac/SharedMemoryMac.cpp: Removed.
+* WebKit2.xcodeproj/project.pbxproj:
+
 2016-10-28  Antti Koivisto  
 
 Enable CFNetwork connection cache fast lane for WebKit2


Copied: trunk/Source/WebKit2/Platform/cocoa/SharedMemoryCocoa.cpp (from rev 208080, trunk/Source/WebKit2/Platform/mac/SharedMemoryMac.cpp) (0 => 208081)

--- trunk/Source/WebKit2/Platform/cocoa/SharedMemoryCocoa.cpp	(rev 0)
+++ trunk/Source/WebKit2/Platform/cocoa/SharedMemoryCocoa.cpp	2016-10-28 23:39:36 UTC (rev 208081)
@@ -0,0 +1,264 @@
+/*
+ * Copyright (C) 2010 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "SharedMemory.h"
+
+#include "Decoder.h"
+#include "Encoder.h"
+#include "Logging.h"
+#include "MachPort.h"
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+namespace WebKit {
+
+SharedMemory::Handle::Handle()
+: m_port(MACH_PORT_NULL)
+, m_size(0)
+{
+}
+
+SharedMemory::Handle::~Handle()
+{
+clear();
+}
+
+bool SharedMemory::Handle::isNull() const
+{
+return !m_port;
+}
+
+void SharedMemory::Handle::clear()
+{
+if (m_port)
+mach_port_deallocate(mach_task_self(), m_port);
+
+m_port = MACH_PORT_NULL;
+m_size = 0;
+}
+
+void SharedMemory::Handle::encode(IPC::Encoder& encoder) const
+{
+encoder << static_cast(m_size);
+encoder << IPC::MachPort(m_port, MACH_MSG_TYPE_MOVE_SEND);
+m_port = MACH_PORT_NULL;
+}
+
+bool SharedMemory::Handle::decode(IPC::Decoder& decoder, Handle& handle)
+{
+ASSERT(!handle.m_port);
+ASSERT(!handle.m_size);
+
+uint64_t size;
+if (!decoder.decode(size))
+return false;
+
+IPC::MachPort machPort;
+if (!decoder.decode(machPort))
+return false;
+
+handle.m_size = size;
+handle.m_port = machPort.port();
+return true;
+}
+
+static inline void* toPointer(mach_vm_address_t address)
+{
+return 

[webkit-changes] [208083] trunk

[cdumez]

Title: [208083] trunk








Revision 208083
Author cdu...@apple.com
Date 2016-10-28 16:53:28 -0700 (Fri, 28 Oct 2016)


Log Message
DOMStringMap reports properties as non-enumerable
https://bugs.webkit.org/show_bug.cgi?id=164114

Reviewed by Sam Weinig.

Source/WebCore:

DOMStringMap's named properties should be configurable, enumerable
and writable as per:
- https://heycam.github.io/webidl/#getownproperty-guts (2.7-9)
- https://html.spec.whatwg.org/multipage/dom.html#domstringmap

Firefox and Chrome agree with the specification. However, WebKit
was doing the complete opposite.

No new tests, updated existing test.

* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::getOwnPropertySlotDelegate):

LayoutTests:

Update existing test to reflect behavior change.

* fast/dom/dataset-name-getter-properties-expected.txt:
* fast/dom/dataset-name-getter-properties.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/dataset-name-getter-properties-expected.txt
trunk/LayoutTests/fast/dom/dataset-name-getter-properties.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (208082 => 208083)

--- trunk/LayoutTests/ChangeLog	2016-10-28 23:49:46 UTC (rev 208082)
+++ trunk/LayoutTests/ChangeLog	2016-10-28 23:53:28 UTC (rev 208083)
@@ -1,3 +1,15 @@
+2016-10-28  Chris Dumez  
+
+DOMStringMap reports properties as non-enumerable
+https://bugs.webkit.org/show_bug.cgi?id=164114
+
+Reviewed by Sam Weinig.
+
+Update existing test to reflect behavior change.
+
+* fast/dom/dataset-name-getter-properties-expected.txt:
+* fast/dom/dataset-name-getter-properties.html:
+
 2016-10-28  Ryosuke Niwa  
 
 Add CEReactions to the remaining HTML DOM APIs


Modified: trunk/LayoutTests/fast/dom/dataset-name-getter-properties-expected.txt (208082 => 208083)

--- trunk/LayoutTests/fast/dom/dataset-name-getter-properties-expected.txt	2016-10-28 23:49:46 UTC (rev 208082)
+++ trunk/LayoutTests/fast/dom/dataset-name-getter-properties-expected.txt	2016-10-28 23:53:28 UTC (rev 208083)
@@ -3,9 +3,9 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').configurable is false
-PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').enumerable is false
-PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').writable is false
+PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').configurable is true
+PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').enumerable is true
+PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').writable is true
 PASS Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').value is "yes"
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/fast/dom/dataset-name-getter-properties.html (208082 => 208083)

--- trunk/LayoutTests/fast/dom/dataset-name-getter-properties.html	2016-10-28 23:49:46 UTC (rev 208082)
+++ trunk/LayoutTests/fast/dom/dataset-name-getter-properties.html	2016-10-28 23:53:28 UTC (rev 208083)
@@ -7,9 +7,9 @@
 
 description('Test the _javascript_ property descriptor of the name getter.');
 
-shouldBe("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').configurable", 'false');
-shouldBe("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').enumerable", 'false');
-shouldBe("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').writable", 'false');
+shouldBeTrue("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').configurable");
+shouldBeTrue("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').enumerable");
+shouldBeTrue("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').writable");
 shouldBeEqualToString("Object.getOwnPropertyDescriptor(document.body.dataset, 'webkitRocks').value", 'yes');
 
 


Modified: trunk/Source/WebCore/ChangeLog (208082 => 208083)

--- trunk/Source/WebCore/ChangeLog	2016-10-28 23:49:46 UTC (rev 208082)
+++ trunk/Source/WebCore/ChangeLog	2016-10-28 23:53:28 UTC (rev 208083)
@@ -1,3 +1,23 @@
+2016-10-28  Chris Dumez  
+
+DOMStringMap reports properties as non-enumerable
+https://bugs.webkit.org/show_bug.cgi?id=164114
+
+Reviewed by Sam Weinig.
+
+DOMStringMap's named properties should be configurable, enumerable
+and writable as per:
+- https://heycam.github.io/webidl/#getownproperty-guts (2.7-9)
+- https://html.spec.whatwg.org/multipage/dom.html#domstringmap
+
+Firefox and Chrome agree with the specification. 

[webkit-changes] [208087] trunk

[achristensen]

Title: [208087] trunk








Revision 208087
Author achristen...@apple.com
Date 2016-10-28 17:20:38 -0700 (Fri, 28 Oct 2016)


Log Message
Partially revert 207805 after resolution in URL spec issue 87
https://bugs.webkit.org/show_bug.cgi?id=164142

Reviewed by Andy Estes.

LayoutTests/imported/w3c:

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Covered by updated layout tests and API tests.

* platform/URLParser.cpp:
(WebCore::URLParser::isSingleDotPathSegment):
(WebCore::URLParser::isDoubleDotPathSegment):
(WebCore::URLParser::consumeSingleDotPathSegment):
(WebCore::URLParser::consumeDoubleDotPathSegment):
Treat %2e%2e as .. and %2e as . but only if it is entirety of the path segment.
There are tests for URLs like http://host/abc%2edef which have not changed because
the %2e is not the entirety of the path segment.

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

LayoutTests:

* fast/url/path-expected.txt:
* fetch/fetch-url-serialization-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/url/path-expected.txt
trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (208086 => 208087)

--- trunk/LayoutTests/ChangeLog	2016-10-29 00:17:01 UTC (rev 208086)
+++ trunk/LayoutTests/ChangeLog	2016-10-29 00:20:38 UTC (rev 208087)
@@ -1,3 +1,13 @@
+2016-10-28  Alex Christensen  
+
+Partially revert 207805 after resolution in URL spec issue 87
+https://bugs.webkit.org/show_bug.cgi?id=164142
+
+Reviewed by Andy Estes.
+
+* fast/url/path-expected.txt:
+* fetch/fetch-url-serialization-expected.txt:
+
 2016-10-28  Chris Dumez  
 
 DOMStringMap reports properties as non-enumerable


Modified: trunk/LayoutTests/fast/url/path-expected.txt (208086 => 208087)

--- trunk/LayoutTests/fast/url/path-expected.txt	2016-10-29 00:17:01 UTC (rev 208086)
+++ trunk/LayoutTests/fast/url/path-expected.txt	2016-10-29 00:20:38 UTC (rev 208087)
@@ -14,9 +14,9 @@
 PASS canonicalize('http://example.com/foo/bar/../ton/../../a') is 'http://example.com/a'
 PASS canonicalize('http://example.com/foo/../../..') is 'http://example.com/'
 PASS canonicalize('http://example.com/foo/../../../ton') is 'http://example.com/ton'
-FAIL canonicalize('http://example.com/foo/%2e') should be http://example.com/foo/. Was http://example.com/foo/%2e.
+PASS canonicalize('http://example.com/foo/%2e') is 'http://example.com/foo/'
 FAIL canonicalize('http://example.com/foo/%2e%2') should be http://example.com/foo/.%2. Was http://example.com/foo/%2e%2.
-FAIL canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') should be http://example.com/..bar. Was http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar.
+FAIL canonicalize('http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar') should be http://example.com/..bar. Was http://example.com/%2e.bar.
 PASS canonicalize('http://example.com../..') is 'http://example.com//'
 PASS canonicalize('http://example.com/foo/bar//../..') is 'http://example.com/foo/'
 PASS canonicalize('http://example.com/foo/bar//..') is 'http://example.com/foo/bar/'


Modified: trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt (208086 => 208087)

--- trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt	2016-10-29 00:17:01 UTC (rev 208086)
+++ trunk/LayoutTests/fetch/fetch-url-serialization-expected.txt	2016-10-29 00:20:38 UTC (rev 208087)
@@ -123,9 +123,9 @@
 PASS Testing Request url 'http://example.com/foo/bar/../ton/../../a' with base 'about:blank' 
 PASS Testing Request url 'http://example.com/foo/../../..' with base 'about:blank' 
 PASS Testing Request url 'http://example.com/foo/../../../ton' with base 'about:blank' 
-FAIL Testing Request url 'http://example.com/foo/%2e' with base 'about:blank' assert_equals: expected "http://example.com/foo/" but got "http://example.com/foo/%2e"
+PASS Testing Request url 'http://example.com/foo/%2e' with base 'about:blank' 
 FAIL Testing Request url 'http://example.com/foo/%2e%2' with base 'about:blank' assert_equals: expected "http://example.com/foo/.%2" but got "http://example.com/foo/%2e%2"
-FAIL Testing Request url 'http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar' with base 'about:blank' assert_equals: expected "http://example.com/..bar" but got "http://example.com/foo/%2e./%2e%2e/.%2e/%2e.bar"
+FAIL Testing Request url 

[webkit-changes] [208089] trunk

[achristensen]

Title: [208089] trunk








Revision 208089
Author achristen...@apple.com
Date 2016-10-28 17:31:42 -0700 (Fri, 28 Oct 2016)


Log Message
Unreviewed, rolling out r207700.
https://bugs.webkit.org/show_bug.cgi?id=164168

We are ready after r208086 (Requested by alexchristensen on
#webkit).

Reverted changeset:

"Unreviewed, rolling out r207582."
https://bugs.webkit.org/show_bug.cgi?id=163819
http://trac.webkit.org/changeset/207700

Patch by Commit Queue  on 2016-10-28

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp
trunk/Source/WebCore/testing/js/WebCoreTestSupport.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm
trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208088 => 208089)

--- trunk/Source/WebCore/ChangeLog	2016-10-29 00:28:15 UTC (rev 208088)
+++ trunk/Source/WebCore/ChangeLog	2016-10-29 00:31:42 UTC (rev 208089)
@@ -1,3 +1,17 @@
+2016-10-28  Commit Queue  
+
+Unreviewed, rolling out r207700.
+https://bugs.webkit.org/show_bug.cgi?id=164168
+
+We are ready after r208086 (Requested by alexchristensen on
+#webkit).
+
+Reverted changeset:
+
+"Unreviewed, rolling out r207582."
+https://bugs.webkit.org/show_bug.cgi?id=163819
+http://trac.webkit.org/changeset/207700
+
 2016-10-28  Dave Hyatt  
 
 [CSS Parser] Allow unknown properties in will-change


Modified: trunk/Source/WebCore/platform/URLParser.cpp (208088 => 208089)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-10-29 00:28:15 UTC (rev 208088)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-10-29 00:31:42 UTC (rev 208089)
@@ -2827,31 +2827,16 @@
 // It should be able to be deduced from m_isValid and m_string.length() to save memory.
 }
 
-enum class URLParserEnabled {
-Undetermined,
-Yes,
-No
-};
+static bool urlParserEnabled = true;
 
-static URLParserEnabled urlParserEnabled = URLParserEnabled::Undetermined;
-
 void URLParser::setEnabled(bool enabled)
 {
-urlParserEnabled = enabled ? URLParserEnabled::Yes : URLParserEnabled::No;
+urlParserEnabled = enabled;
 }
 
 bool URLParser::enabled()
 {
-if (urlParserEnabled == URLParserEnabled::Undetermined) {
-#if PLATFORM(MAC)
-urlParserEnabled = MacApplication::isSafari() ? URLParserEnabled::Yes : URLParserEnabled::No;
-#elif PLATFORM(IOS)
-urlParserEnabled = IOSApplication::isMobileSafari() ? URLParserEnabled::Yes : URLParserEnabled::No;
-#else
-urlParserEnabled = URLParserEnabled::Yes;
-#endif
-}
-return urlParserEnabled == URLParserEnabled::Yes;
+return urlParserEnabled;
 }
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp (208088 => 208089)

--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp	2016-10-29 00:28:15 UTC (rev 208088)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp	2016-10-29 00:31:42 UTC (rev 208089)
@@ -121,11 +121,6 @@
 InternalSettings::setAllowsAnySSLCertificate(allowAnySSLCertificate);
 }
 
-void setURLParserEnabled(bool enabled)
-{
-URLParser::setEnabled(enabled);
-}
-
 void installMockGamepadProvider()
 {
 #if ENABLE(GAMEPAD)


Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.h (208088 => 208089)

--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.h	2016-10-29 00:28:15 UTC (rev 208088)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.h	2016-10-29 00:31:42 UTC (rev 208089)
@@ -56,7 +56,6 @@
 void setLogChannelToAccumulate(const WTF::String& name) TEST_SUPPORT_EXPORT;
 void initializeLogChannelsIfNecessary() TEST_SUPPORT_EXPORT;
 void setAllowsAnySSLCertificate(bool) TEST_SUPPORT_EXPORT;
-void setURLParserEnabled(bool) TEST_SUPPORT_EXPORT;
 
 void installMockGamepadProvider() TEST_SUPPORT_EXPORT;
 void connectMockGamepad(unsigned index) TEST_SUPPORT_EXPORT;


Modified: trunk/Tools/ChangeLog (208088 => 208089)

--- trunk/Tools/ChangeLog	2016-10-29 00:28:15 UTC (rev 208088)
+++ trunk/Tools/ChangeLog	2016-10-29 00:31:42 UTC (rev 208089)
@@ -1,3 +1,17 @@
+2016-10-28  Commit Queue  
+
+Unreviewed, rolling out r207700.
+https://bugs.webkit.org/show_bug.cgi?id=164168
+
+We are ready after r208086 (Requested by alexchristensen on
+#webkit).
+
+Reverted changeset:
+
+"Unreviewed, rolling out r207582."
+https://bugs.webkit.org/show_bug.cgi?id=163819
+http://trac.webkit.org/changeset/207700
+
 2016-10-28  Alex Christensen  
 
 Partially revert 207805 after resolution in URL spec issue 87


Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (208088 => 208089)

--- 

[webkit-changes] [208047] trunk/JSTests

[ossy]

Title: [208047] trunk/JSTests








Revision 208047
Author o...@webkit.org
Date 2016-10-28 07:21:04 -0700 (Fri, 28 Oct 2016)


Log Message
Skip 2 JS stress tests on memory limited devices
https://bugs.webkit.org/show_bug.cgi?id=164125

Unreviewed quick fix to unbreak JSCOnly ARM bots as soon as possible.


* stress/joined-strings-should-not-exceed-max-string-length.js:
* stress/string-prototype-replace-should-throw-out-of-memory-error-when-using-too-much-memory.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/joined-strings-should-not-exceed-max-string-length.js
trunk/JSTests/stress/string-prototype-replace-should-throw-out-of-memory-error-when-using-too-much-memory.js




Diff

Modified: trunk/JSTests/ChangeLog (208046 => 208047)

--- trunk/JSTests/ChangeLog	2016-10-28 13:59:20 UTC (rev 208046)
+++ trunk/JSTests/ChangeLog	2016-10-28 14:21:04 UTC (rev 208047)
@@ -1,3 +1,13 @@
+2016-10-28  Csaba Osztrogonác  
+
+Skip 2 JS stress tests on memory limited devices
+https://bugs.webkit.org/show_bug.cgi?id=164125
+
+Unreviewed quick fix to unbreak JSCOnly ARM bots as soon as possible.
+
+* stress/joined-strings-should-not-exceed-max-string-length.js:
+* stress/string-prototype-replace-should-throw-out-of-memory-error-when-using-too-much-memory.js:
+
 2016-10-27  Caitlin Potter  
 
 [JSC] forbid lexical redeclaration of generator formal parameters


Modified: trunk/JSTests/stress/joined-strings-should-not-exceed-max-string-length.js (208046 => 208047)

--- trunk/JSTests/stress/joined-strings-should-not-exceed-max-string-length.js	2016-10-28 13:59:20 UTC (rev 208046)
+++ trunk/JSTests/stress/joined-strings-should-not-exceed-max-string-length.js	2016-10-28 14:21:04 UTC (rev 208047)
@@ -1,5 +1,5 @@
-//@ runFTLNoCJIT
 //@ largeHeap
+//@ runFTLNoCJIT if !$memoryLimited
 // This test should not crash or fail any assertions.
 
 function shouldEqual(stepId, actual, expected) {


Modified: trunk/JSTests/stress/string-prototype-replace-should-throw-out-of-memory-error-when-using-too-much-memory.js (208046 => 208047)

--- trunk/JSTests/stress/string-prototype-replace-should-throw-out-of-memory-error-when-using-too-much-memory.js	2016-10-28 13:59:20 UTC (rev 208046)
+++ trunk/JSTests/stress/string-prototype-replace-should-throw-out-of-memory-error-when-using-too-much-memory.js	2016-10-28 14:21:04 UTC (rev 208047)
@@ -1,6 +1,6 @@
-//@ runFTLNoCJIT
+//@ largeHeap
+//@ runFTLNoCJIT if !$memoryLimited
 //@ slow!
-//@largeHeap
 // This test should not crash or fail any assertions.
 
 function shouldEqual(testId, actual, expected) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208092] trunk

[jer . noble]

Title: [208092] trunk








Revision 208092
Author jer.no...@apple.com
Date 2016-10-28 18:18:45 -0700 (Fri, 28 Oct 2016)


Log Message
WebAudio does not resume when moving from background to foreground tab.
https://bugs.webkit.org/show_bug.cgi?id=164043

Reviewed by Darin Adler.

Source/WebCore:

Test: webaudio/page-canstartmedia.html

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::mediaCanStart):

LayoutTests:

* webaudio/page-canstartmedia-expected.txt: Added.
* webaudio/page-canstartmedia.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp


Added Paths

trunk/LayoutTests/webaudio/page-canstartmedia-expected.txt
trunk/LayoutTests/webaudio/page-canstartmedia.html




Diff

Modified: trunk/LayoutTests/ChangeLog (208091 => 208092)

--- trunk/LayoutTests/ChangeLog	2016-10-29 01:17:43 UTC (rev 208091)
+++ trunk/LayoutTests/ChangeLog	2016-10-29 01:18:45 UTC (rev 208092)
@@ -1,3 +1,13 @@
+2016-10-28  Jer Noble  
+
+WebAudio does not resume when moving from background to foreground tab.
+https://bugs.webkit.org/show_bug.cgi?id=164043
+
+Reviewed by Darin Adler.
+
+* webaudio/page-canstartmedia-expected.txt: Added.
+* webaudio/page-canstartmedia.html: Added.
+
 2016-10-28  Wenson Hsieh  
 
 iOS autocorrection does not trigger an input event of inputType "insertReplacementText"


Added: trunk/LayoutTests/webaudio/page-canstartmedia-expected.txt (0 => 208092)

--- trunk/LayoutTests/webaudio/page-canstartmedia-expected.txt	(rev 0)
+++ trunk/LayoutTests/webaudio/page-canstartmedia-expected.txt	2016-10-29 01:18:45 UTC (rev 208092)
@@ -0,0 +1,9 @@
+Tests that AudioContext resume method resolve promises when notified by Page that it can start media playback.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS context resolve callback called
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/webaudio/page-canstartmedia.html (0 => 208092)

--- trunk/LayoutTests/webaudio/page-canstartmedia.html	(rev 0)
+++ trunk/LayoutTests/webaudio/page-canstartmedia.html	2016-10-29 01:18:45 UTC (rev 208092)
@@ -0,0 +1,55 @@
+
+
+
+
+
+
+
+
+

+

+
+