[webkit-changes] [231841] trunk/WebDriverTests

[carlosgc]

Title: [231841] trunk/WebDriverTests








Revision 231841
Author carlo...@webkit.org
Date 2018-05-16 01:38:10 -0700 (Wed, 16 May 2018)


Log Message
Unreviewed. Remove W3C deleted files after r231727.

In r231727 W3C WebDriver tests were updated, but only new and modified files, not the deleted (or renamed)
ones. Remove the deleted files and update the test expectations to use the new names.

* TestExpectations.json: Update expectations after test renames in r231727.
* imported/w3c/tools/wptrunner/wptrunner/executors/testharness_marionette.js: Removed.
* imported/w3c/tools/wptrunner/wptrunner/executors/testharness_marionette_resume.js: Removed.
* imported/w3c/webdriver/tests/contexts/json_serialize_windowproxy.py: Removed.
* imported/w3c/webdriver/tests/contexts/maximize_window.py: Removed.
* imported/w3c/webdriver/tests/contexts/resizing_and_positioning.py: Removed.
* imported/w3c/webdriver/tests/cookies/add_cookie.py: Removed.
* imported/w3c/webdriver/tests/cookies/delete_cookie.py: Removed.
* imported/w3c/webdriver/tests/cookies/get_named_cookie.py: Removed.
* imported/w3c/webdriver/tests/document_handling/page_source.py: Removed.
* imported/w3c/webdriver/tests/element_retrieval/__init__.py: Removed.
* imported/w3c/webdriver/tests/element_retrieval/find_element.py: Removed.
* imported/w3c/webdriver/tests/element_retrieval/find_element_from_element.py: Removed.
* imported/w3c/webdriver/tests/element_retrieval/find_elements.py: Removed.
* imported/w3c/webdriver/tests/element_retrieval/find_elements_from_element.py: Removed.
* imported/w3c/webdriver/tests/element_retrieval/get_active_element.py: Removed.
* imported/w3c/webdriver/tests/fullscreen_window.py: Removed.
* imported/w3c/webdriver/tests/get_window_rect.py: Removed.
* imported/w3c/webdriver/tests/interaction/element_clear.py: Removed.
* imported/w3c/webdriver/tests/interaction/send_keys_content_editable.py: Removed.
* imported/w3c/webdriver/tests/minimize_window.py: Removed.
* imported/w3c/webdriver/tests/navigation/current_url.py: Removed.
* imported/w3c/webdriver/tests/navigation/get_title.py: Removed.
* imported/w3c/webdriver/tests/sessions/get_timeouts.py: Removed.
* imported/w3c/webdriver/tests/sessions/new_session/conftest.py: Removed.
* imported/w3c/webdriver/tests/sessions/new_session/create_alwaysMatch.py: Removed.
* imported/w3c/webdriver/tests/sessions/new_session/create_firstMatch.py: Removed.
* imported/w3c/webdriver/tests/sessions/new_session/default_values.py: Removed.
* imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py: Removed.
* imported/w3c/webdriver/tests/sessions/new_session/merge.py: Removed.
* imported/w3c/webdriver/tests/sessions/new_session/response.py: Removed.
* imported/w3c/webdriver/tests/sessions/new_session/support/__init__.py: Removed.
* imported/w3c/webdriver/tests/sessions/new_session/support/create.py: Removed.
* imported/w3c/webdriver/tests/sessions/status.py: Removed.
* imported/w3c/webdriver/tests/set_window_rect.py: Removed.
* imported/w3c/webdriver/tests/state/__init__.py: Removed.
* imported/w3c/webdriver/tests/state/get_element_attribute.py: Removed.
* imported/w3c/webdriver/tests/state/get_element_property.py: Removed.
* imported/w3c/webdriver/tests/state/get_element_tag_name.py: Removed.
* imported/w3c/webdriver/tests/state/is_element_selected.py: Removed.
* imported/w3c/webdriver/tests/state/text/__init__.py: Removed.
* imported/w3c/webdriver/tests/state/text/get_text.py: Removed.
* imported/w3c/webdriver/tests/switch_to_parent_frame.py: Removed.
* imported/w3c/webdriver/tests/user_prompts/accept_alert.py: Removed.
* imported/w3c/webdriver/tests/user_prompts/dismiss_alert.py: Removed.
* imported/w3c/webdriver/tests/user_prompts/get_alert_text.py: Removed.
* imported/w3c/webdriver/tests/user_prompts/send_alert_text.py: Removed.

Modified Paths

trunk/WebDriverTests/ChangeLog
trunk/WebDriverTests/TestExpectations.json


Removed Paths

trunk/WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/executors/testharness_marionette.js
trunk/WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/executors/testharness_marionette_resume.js
trunk/WebDriverTests/imported/w3c/webdriver/tests/contexts/
trunk/WebDriverTests/imported/w3c/webdriver/tests/cookies/
trunk/WebDriverTests/imported/w3c/webdriver/tests/document_handling/
trunk/WebDriverTests/imported/w3c/webdriver/tests/element_retrieval/
trunk/WebDriverTests/imported/w3c/webdriver/tests/fullscreen_window.py
trunk/WebDriverTests/imported/w3c/webdriver/tests/get_window_rect.py
trunk/WebDriverTests/imported/w3c/webdriver/tests/interaction/
trunk/WebDriverTests/imported/w3c/webdriver/tests/minimize_window.py
trunk/WebDriverTests/imported/w3c/webdriver/tests/navigation/
trunk/WebDriverTests/imported/w3c/webdriver/tests/sessions/
trunk/WebDriverTests/imported/w3c/webdriver/tests/set_window_rect.py
trunk/WebDriverTests/imported/w3c/webdriver/tests/state/
trunk/WebDriverTests/imported/w3c/webdriver/tests/switch_to_parent_frame.py

[webkit-changes] [231839] trunk/Source

[utatane . tea]

Title: [231839] trunk/Source








Revision 231839
Author utatane@gmail.com
Date 2018-05-16 00:05:27 -0700 (Wed, 16 May 2018)


Log Message
[JSC] Check TypeInfo first before calling getCallData when we would like to check whether given object is a function
https://bugs.webkit.org/show_bug.cgi?id=185601

Reviewed by Saam Barati.

Source/_javascript_Core:

Rename TypeOfShouldCallGetCallData to OverridesGetCallData. And check OverridesGetCallData
before calling getCallData when we would like to check whether a given object is callable
since getCallData is a virtual call. When we call the object anyway, directly calling getCallData
is fine. But if we would like to check whether the object is callable, we can have non
callable objects frequently. In that case, we should not call getCallData if we can avoid it.

To do this cleanly, we refactor JSValue::{isFunction,isCallable}. We add JSCell::{isFunction,isCallable}
and JSValue ones call into these functions. Inside JSCell::{isFunction,isCallable}, we perform
OverridesGetCallData checking before calling getCallData.

We found that this virtual call exists in JSON.stringify's critial path. Checking
OverridesGetCallData improves Kraken/json-stringify-tinderbox by 2-4%.

   baseline  patched

json-stringify-tinderbox38.807+-0.350  ^  37.216+-0.337 ^ definitely 1.0427x faster

In addition to that, we also add OverridesGetCallData flag to JSFunction while we keep JSFunctionType checking fast path
since major cases are covered by this fast JSFunctionType checking.

* API/JSCallbackObject.h:
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIsObjectOrNull):
(JSC::DFG::SpeculativeJIT::compileIsFunction):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::isExoticForTypeof):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitTypeOf):
* runtime/ExceptionHelpers.cpp:
(JSC::createError):
(JSC::createInvalidFunctionApplyParameterError):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/InternalFunction.h:
* runtime/JSCJSValue.h:
* runtime/JSCJSValueInlines.h:
(JSC::JSValue::isFunction const):
(JSC::JSValue::isCallable const):
* runtime/JSCell.h:
* runtime/JSCellInlines.h:
(JSC::JSCell::isFunction):
ALWAYS_INLINE works well for my environment.
(JSC::JSCell::isCallable):
* runtime/JSFunction.h:
* runtime/JSONObject.cpp:
(JSC::Stringifier::toJSON):
(JSC::Stringifier::toJSONImpl):
(JSC::Stringifier::appendStringifiedValue):
* runtime/JSObjectInlines.h:
(JSC::createListFromArrayLike):
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::overridesGetCallData const):
(JSC::TypeInfo::typeOfShouldCallGetCallData const): Deleted.
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectTypeOrNull):
* runtime/ProxyObject.h:
* runtime/RuntimeType.cpp:
(JSC::runtimeTypeForValue):
* runtime/RuntimeType.h:
* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/TypeProfilerLog.cpp:
(JSC::TypeProfilerLog::TypeProfilerLog):
(JSC::TypeProfilerLog::processLogEntries):
* runtime/TypeProfilerLog.h:
* runtime/VM.cpp:
(JSC::VM::enableTypeProfiler):
* tools/JSDollarVM.cpp:
(JSC::functionFindTypeForExpression):
(JSC::functionReturnTypeFor):
(JSC::functionHasBasicBlockExecuted):
(JSC::functionBasicBlockExecutionCount):
* wasm/js/JSWebAssemblyHelpers.h:
(JSC::getWasmBufferFromValue):
* wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::create):
* wasm/js/WebAssemblyFunction.cpp:
(JSC::callWebAssemblyFunction):
* wasm/js/WebAssemblyInstanceConstructor.cpp:
(JSC::constructJSWebAssemblyInstance):
* wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::link):
* wasm/js/WebAssemblyPrototype.cpp:
(JSC::webAssemblyInstantiateFunc):
(JSC::webAssemblyInstantiateStreamingInternal):
* wasm/js/WebAssemblyWrapperFunction.cpp:
(JSC::WebAssemblyWrapperFunction::finishCreation):

Source/WebCore:

No behavior change.

* Modules/plugins/QuickTimePluginReplacement.mm:
(WebCore::QuickTimePluginReplacement::ensureReplacementScriptInjected):
* bindings/js/JSCustomElementRegistryCustom.cpp:
(WebCore::getCustomElementCallback):
* bindings/js/JSDOMConstructorBase.h:
* bindings/js/JSDOMConvertCallbacks.h:
(WebCore::Converter::convert):
* bindings/js/JSDOMPromise.cpp:
(WebCore::DOMPromise::whenSettled):
* bindings/js/ReadableStream.cpp:
(WebCore::ReadableStream::pipeTo):
(WebCore::ReadableStream::tee):
* bindings/js/ReadableStreamDefaultController.cpp:
(WebCore::ReadableStreamDefaultController::invoke):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateOverloadDispatcher):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestPluginInterface.h:
* bridge/objc/objc_runtime.h:
* bridge/runtime_method.h:
* bridge/runtime_object.h:
* html/HTMLMediaElement.cpp:

[webkit-changes] [231847] trunk/Source/WebCore

[zalan]

Title: [231847] trunk/Source/WebCore








Revision 231847
Author za...@apple.com
Date 2018-05-16 07:51:39 -0700 (Wed, 16 May 2018)


Log Message
[LFC] Implement width computation for replaced inflow elements.
https://bugs.webkit.org/show_bug.cgi?id=185672

Reviewed by Antti Koivisto.

Replaced width for block, inline and float elements compute the same way.

* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeWidth const):
(WebCore::Layout::FormattingContext::computeFloatingWidth const):
(WebCore::Layout::FormattingContext::computeInFlowReplacedWidth const):
* layout/FormattingContext.h:
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeInFlowWidth const):
* layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::hasIntrinsicWidth const):
(WebCore::Layout::Box::hasIntrinsicHeight const):
(WebCore::Layout::Box::hasIntrinsicRatio const):
(WebCore::Layout::Box::intrinsicWidth const):
(WebCore::Layout::Box::intrinsicHeight const):
(WebCore::Layout::Box::intrinsicRatio const):
* layout/layouttree/LayoutBox.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/FormattingContext.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp
trunk/Source/WebCore/layout/layouttree/LayoutBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (231846 => 231847)

--- trunk/Source/WebCore/ChangeLog	2018-05-16 14:49:55 UTC (rev 231846)
+++ trunk/Source/WebCore/ChangeLog	2018-05-16 14:51:39 UTC (rev 231847)
@@ -1,5 +1,30 @@
 2018-05-16  Zalan Bujtas  
 
+[LFC] Implement width computation for replaced inflow elements.
+https://bugs.webkit.org/show_bug.cgi?id=185672
+
+Reviewed by Antti Koivisto.
+
+Replaced width for block, inline and float elements compute the same way. 
+
+* layout/FormattingContext.cpp:
+(WebCore::Layout::FormattingContext::computeWidth const):
+(WebCore::Layout::FormattingContext::computeFloatingWidth const):
+(WebCore::Layout::FormattingContext::computeInFlowReplacedWidth const):
+* layout/FormattingContext.h:
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::computeInFlowWidth const):
+* layout/layouttree/LayoutBox.cpp:
+(WebCore::Layout::Box::hasIntrinsicWidth const):
+(WebCore::Layout::Box::hasIntrinsicHeight const):
+(WebCore::Layout::Box::hasIntrinsicRatio const):
+(WebCore::Layout::Box::intrinsicWidth const):
+(WebCore::Layout::Box::intrinsicHeight const):
+(WebCore::Layout::Box::intrinsicRatio const):
+* layout/layouttree/LayoutBox.h:
+
+2018-05-16  Zalan Bujtas  
+
 [LFC] Make Display::Box box sizing aware
 https://bugs.webkit.org/show_bug.cgi?id=185649
 


Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (231846 => 231847)

--- trunk/Source/WebCore/layout/FormattingContext.cpp	2018-05-16 14:49:55 UTC (rev 231846)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp	2018-05-16 14:51:39 UTC (rev 231847)
@@ -65,7 +65,7 @@
 if (layoutBox.isOutOfFlowPositioned())
 return computeOutOfFlowWidth(layoutContext, layoutBox, displayBox);
 if (layoutBox.isFloatingPositioned())
-return computeFloatingWidth(layoutBox, displayBox);
+return computeFloatingWidth(layoutContext, layoutBox, displayBox);
 return computeInFlowWidth(layoutContext, layoutBox, displayBox);
 }
 
@@ -87,8 +87,13 @@
 ASSERT_NOT_REACHED();
 }
 
-void FormattingContext::computeFloatingWidth(const Box&, Display::Box&) const
+void FormattingContext::computeFloatingWidth(LayoutContext& layoutContext, const Box& layoutBox, Display::Box& displayBox) const
 {
+if (!layoutBox.isReplaced()) {
+ASSERT_NOT_REACHED();
+return;
+}
+computeInFlowReplacedWidth(layoutContext, layoutBox, displayBox);
 }
 
 void FormattingContext::computeOutOfFlowHeight(LayoutContext& layoutContext, const Box& layoutBox, Display::Box& displayBox) const
@@ -203,6 +208,55 @@
 displayBox.setHeight(computedHeightValue);
 }
 
+void FormattingContext::computeInFlowReplacedWidth(LayoutContext&, const Box& layoutBox, Display::Box& displayBox) const
+{
+// 10.3.4 Block-level, replaced elements in normal flow: The used value of 'width' is determined as for inline replaced elements
+// 10.3.6 Floating, replaced elements: The used value of 'width' is determined as for inline replaced elements.   
+
+// 10.3.2 Inline, replaced elements
+//
+// 1. If 'height' and 'width' both have computed values of 'auto' and the element also has an intrinsic width, then that intrinsic width is the used value of 'width'.
+//
+// 2. If 'height' and 'width' both have computed values of 'auto' and the element has no intrinsic width, 

[webkit-changes] [231848] trunk/Tools

[commit-queue]

Title: [231848] trunk/Tools








Revision 231848
Author commit-qu...@webkit.org
Date 2018-05-16 09:11:09 -0700 (Wed, 16 May 2018)


Log Message
test262/Runner.pm: save to supplied expectation file if supplied
https://bugs.webkit.org/show_bug.cgi?id=185660

Patch by Valerie R Young  on 2018-05-16
Reviewed by Michael Saboff.

* Scripts/test262/Runner.pm:
(processCLI):
(main):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/test262/Runner.pm




Diff

Modified: trunk/Tools/ChangeLog (231847 => 231848)

--- trunk/Tools/ChangeLog	2018-05-16 14:51:39 UTC (rev 231847)
+++ trunk/Tools/ChangeLog	2018-05-16 16:11:09 UTC (rev 231848)
@@ -1,3 +1,14 @@
+2018-05-16  Valerie R Young  
+
+test262/Runner.pm: save to supplied expectation file if supplied
+https://bugs.webkit.org/show_bug.cgi?id=185660
+
+Reviewed by Michael Saboff.
+
+* Scripts/test262/Runner.pm:
+(processCLI):
+(main):
+
 2018-05-15  Ryan Haddad  
 
 Unreviewed, rolling out r231763.


Modified: trunk/Tools/Scripts/test262/Runner.pm (231847 => 231848)

--- trunk/Tools/Scripts/test262/Runner.pm	2018-05-16 14:51:39 UTC (rev 231847)
+++ trunk/Tools/Scripts/test262/Runner.pm	2018-05-16 16:11:09 UTC (rev 231848)
@@ -208,10 +208,11 @@
 " please specify with --results.";
 }
 
-if (! $ignoreExpectations && $specifiedExpectationsFile) {
+if ($specifiedExpectationsFile) {
 $expectationsFile = abs_path($specifiedExpectationsFile);
-if (! -e $expectationsFile) {
-die "Error: Supplied expectations file $expectationsFile does not exist!";
+if (! -e $expectationsFile && ! $ignoreExpectations) {
+print("Warning: Supplied expectations file $expectationsFile does"
+  . " not exist. Running tests without expectation file.\n");
 }
 }
 
@@ -389,7 +390,7 @@
 if ( !$expect ) {
 print $failcount . " tests failed\n";
 } else {
-print $failcount . " expected tests failed\n";
+print $failcount . " tests failed in total\n";
 print $newfailcount . " tests newly fail\n";
 print $newpasscount . " tests newly pass\n";
 }
@@ -927,7 +928,7 @@
 
 =item B<--expectations, -e>
 
-Specify a expectations file.  If not provided, script will load local JSTests/test262/expectations.yaml
+Specify a expectations file for loading and saving.  If not provided, script will load and save to JSTests/test262/expectations.yaml.
 
 =item B<--ignore-expectations, -x>
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231846] trunk/Source/WebCore

[zalan]

Title: [231846] trunk/Source/WebCore








Revision 231846
Author za...@apple.com
Date 2018-05-16 07:49:55 -0700 (Wed, 16 May 2018)


Log Message
[LFC] Make Display::Box box sizing aware
https://bugs.webkit.org/show_bug.cgi?id=185649

Reviewed by Antti Koivisto.

Display::Box::width() == Display::Box::contentBox().width() <= box-sizing: content-box; (initial and default value)
Display::Box::width() == Display::Box::borderBox().width() <= box-sizing: border-box;

* layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::createDisplayBox):
* layout/displaytree/DisplayBox.cpp:
(WebCore::Display::Box::Box):
(WebCore::Display::Box::marginBox const):
(WebCore::Display::Box::borderBox const):
(WebCore::Display::Box::paddingBox const):
(WebCore::Display::Box::contentBox const):
* layout/displaytree/DisplayBox.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/LayoutContext.cpp
trunk/Source/WebCore/layout/displaytree/DisplayBox.cpp
trunk/Source/WebCore/layout/displaytree/DisplayBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (231845 => 231846)

--- trunk/Source/WebCore/ChangeLog	2018-05-16 14:26:30 UTC (rev 231845)
+++ trunk/Source/WebCore/ChangeLog	2018-05-16 14:49:55 UTC (rev 231846)
@@ -1,3 +1,23 @@
+2018-05-16  Zalan Bujtas  
+
+[LFC] Make Display::Box box sizing aware
+https://bugs.webkit.org/show_bug.cgi?id=185649
+
+Reviewed by Antti Koivisto.
+
+Display::Box::width() == Display::Box::contentBox().width() <= box-sizing: content-box; (initial and default value)
+Display::Box::width() == Display::Box::borderBox().width() <= box-sizing: border-box;
+
+* layout/LayoutContext.cpp:
+(WebCore::Layout::LayoutContext::createDisplayBox):
+* layout/displaytree/DisplayBox.cpp:
+(WebCore::Display::Box::Box):
+(WebCore::Display::Box::marginBox const):
+(WebCore::Display::Box::borderBox const):
+(WebCore::Display::Box::paddingBox const):
+(WebCore::Display::Box::contentBox const):
+* layout/displaytree/DisplayBox.h:
+
 2018-05-16  Antoine Quint  
 
 REGRESSION (r230574): Interrupted hardware transitions don't behave correctly


Modified: trunk/Source/WebCore/layout/LayoutContext.cpp (231845 => 231846)

--- trunk/Source/WebCore/layout/LayoutContext.cpp	2018-05-16 14:26:30 UTC (rev 231845)
+++ trunk/Source/WebCore/layout/LayoutContext.cpp	2018-05-16 14:49:55 UTC (rev 231846)
@@ -64,7 +64,7 @@
 
 Display::Box& LayoutContext::createDisplayBox(const Box& layoutBox)
 {
-std::unique_ptr displayBox(new Display::Box());
+std::unique_ptr displayBox(new Display::Box(layoutBox.style().boxSizing()));
 auto* displayBoxPtr = displayBox.get();
 m_layoutToDisplayBox.add(, WTFMove(displayBox));
 return *displayBoxPtr;


Modified: trunk/Source/WebCore/layout/displaytree/DisplayBox.cpp (231845 => 231846)

--- trunk/Source/WebCore/layout/displaytree/DisplayBox.cpp	2018-05-16 14:26:30 UTC (rev 231845)
+++ trunk/Source/WebCore/layout/displaytree/DisplayBox.cpp	2018-05-16 14:49:55 UTC (rev 231846)
@@ -35,7 +35,8 @@
 
 WTF_MAKE_ISO_ALLOCATED_IMPL(Box);
 
-Box::Box()
+Box::Box(EBoxSizing boxSizing)
+: m_boxSizing(boxSizing)
 {
 }
 
@@ -46,18 +47,27 @@
 LayoutRect Box::marginBox() const
 {
 ASSERT(m_hasValidMargin);
-auto marginBox = rect();
-auto topLeftMargin = LayoutSize(m_marginLeft, m_marginTop);
-marginBox.inflate(topLeftMargin);
+auto marginBox = borderBox();
 
-auto bottomRightMargin = LayoutSize(m_marginRight, m_marginBottom);
-marginBox.expand(bottomRightMargin);
+marginBox.shiftXEdgeTo(marginBox.x() + m_marginLeft);
+marginBox.shiftYEdgeTo(marginBox.y() + m_marginTop);
+marginBox.shiftMaxXEdgeTo(marginBox.maxX() - m_marginRight);
+marginBox.shiftMaxYEdgeTo(marginBox.maxY() - m_marginBottom);
+
 return marginBox;
 }
 
 LayoutRect Box::borderBox() const
 {
-return LayoutRect(LayoutPoint(0, 0), size());
+if (m_boxSizing == BORDER_BOX)
+return LayoutRect( { }, size());
+
+// Width is content box.
+ASSERT(m_hasValidBorder);
+ASSERT(m_hasValidPadding);
+auto borderBoxSize = size();
+borderBoxSize.expand(borderLeft() + paddingLeft() + paddingRight() + borderRight() , borderTop() + paddingTop() + paddingBottom() + borderBottom());
+return LayoutRect( { }, borderBoxSize);
 }
 
 LayoutRect Box::paddingBox() const
@@ -64,23 +74,29 @@
 {
 ASSERT(m_hasValidBorder);
 auto paddingBox = borderBox();
-auto topLeftBorder = LayoutSize(m_borderLeft, m_borderTop);
-paddingBox.inflate(-topLeftBorder);
 
-auto bottomRightBorder = LayoutSize(m_borderRight, m_borderBottom);
-paddingBox.expand(-bottomRightBorder);
+paddingBox.shiftXEdgeTo(paddingBox.x() + m_borderLeft);
+paddingBox.shiftYEdgeTo(paddingBox.y() + m_borderTop);
+paddingBox.shiftMaxXEdgeTo(paddingBox.maxX() - m_borderRight);
+

[webkit-changes] [231844] trunk/LayoutTests

[pvollan]

Title: [231844] trunk/LayoutTests








Revision 231844
Author pvol...@apple.com
Date 2018-05-16 07:11:47 -0700 (Wed, 16 May 2018)


Log Message
Mark animations/keyframes-dynamic.html and related tests as failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=185678

Unreviewed test gardening.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (231843 => 231844)

--- trunk/LayoutTests/ChangeLog	2018-05-16 13:33:50 UTC (rev 231843)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 14:11:47 UTC (rev 231844)
@@ -1,3 +1,12 @@
+2018-05-16  Per Arne Vollan  
+
+Mark animations/keyframes-dynamic.html and related tests as failing on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=185678
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
 2018-05-16  Antoine Quint  
 
 REGRESSION (r230574): Interrupted hardware transitions don't behave correctly


Modified: trunk/LayoutTests/platform/win/TestExpectations (231843 => 231844)

--- trunk/LayoutTests/platform/win/TestExpectations	2018-05-16 13:33:50 UTC (rev 231843)
+++ trunk/LayoutTests/platform/win/TestExpectations	2018-05-16 14:11:47 UTC (rev 231844)
@@ -4082,3 +4082,8 @@
 
 webkit.org/b/185471 http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html [ Skip ]
 webkit.org/b/185471 http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin.html [ Skip ]
+
+webkit.org/b/185678 animations/keyframes-dynamic.html [ Failure ]
+webkit.org/b/185678 animations/missing-from-to-transforms.html [ Failure ]
+webkit.org/b/185678 animations/missing-from-to.html [ Failure ]
+webkit.org/b/185678 fast/css-generated-content/pseudo-animation.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231843] trunk

[berto]

Title: [231843] trunk








Revision 231843
Author be...@igalia.com
Date 2018-05-16 06:33:50 -0700 (Wed, 16 May 2018)


Log Message
[CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations
https://bugs.webkit.org/show_bug.cgi?id=182622

Reviewed by Michael Catanzaro.

.:

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsJSCOnly.cmake:
* Source/cmake/OptionsWPE.cmake:
Enable THREADS_PREFER_PTHREAD_FLAG. This uses -pthread instead of
-lpthread, fixing the 64-bit RISC-V build of the GTK+ port due to
missing atomic primitives.

* Source/cmake/WebKitCompilerFlags.cmake:
Move the test to detect whether we need to link against libatomic
to a common CMake file so it can be used from both _javascript_Core
and WebKit.

Source/_javascript_Core:

We were linking _javascript_Core against libatomic in MIPS because
in that architecture __atomic_fetch_add_8() is not a compiler
intrinsic and is provided by that library instead. However other
architectures (e.g armel) are in the same situation, so we need a
generic test.

That test already exists in WebKit/CMakeLists.txt, so we just have
to move it to a common file (WebKitCompilerFlags.cmake) and use
its result (ATOMIC_INT64_REQUIRES_LIBATOMIC) here.

* CMakeLists.txt:

Source/WebKit:

Move the test to determine whether we need to link against
libatomic to the common file WebKitCompilerFlags.cmake so it can
also be used for _javascript_Core.

* CMakeLists.txt:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsJSCOnly.cmake
trunk/Source/cmake/OptionsWPE.cmake
trunk/Source/cmake/WebKitCompilerFlags.cmake




Diff

Modified: trunk/ChangeLog (231842 => 231843)

--- trunk/ChangeLog	2018-05-16 13:09:37 UTC (rev 231842)
+++ trunk/ChangeLog	2018-05-16 13:33:50 UTC (rev 231843)
@@ -1,3 +1,22 @@
+2018-05-16  Alberto Garcia  
+
+[CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations
+https://bugs.webkit.org/show_bug.cgi?id=182622
+
+Reviewed by Michael Catanzaro.
+
+* Source/cmake/OptionsGTK.cmake:
+* Source/cmake/OptionsJSCOnly.cmake:
+* Source/cmake/OptionsWPE.cmake:
+Enable THREADS_PREFER_PTHREAD_FLAG. This uses -pthread instead of
+-lpthread, fixing the 64-bit RISC-V build of the GTK+ port due to
+missing atomic primitives.
+
+* Source/cmake/WebKitCompilerFlags.cmake:
+Move the test to detect whether we need to link against libatomic
+to a common CMake file so it can be used from both _javascript_Core
+and WebKit.
+
 2018-05-14  Zan Dobersek  
 
 [GTK] REGRESSION(r231170) Build broken with Clang 5.0


Modified: trunk/Source/_javascript_Core/CMakeLists.txt (231842 => 231843)

--- trunk/Source/_javascript_Core/CMakeLists.txt	2018-05-16 13:09:37 UTC (rev 231842)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2018-05-16 13:33:50 UTC (rev 231843)
@@ -124,14 +124,8 @@
 list(APPEND _javascript_Core_LIBRARIES capstone)
 endif ()
 
-# Since r228149, on MIPS we need to link with -latomic, because
-# __atomic_fetch_add_8 is not available as a compiler intrinsic. It is
-# available on other platforms (including 32-bit Arm), so the link with
-# libatomic is only neede on MIPS.
-if (WTF_CPU_MIPS)
-list(APPEND _javascript_Core_LIBRARIES
--latomic
-)
+if (ATOMIC_INT64_REQUIRES_LIBATOMIC)
+list(APPEND _javascript_Core_LIBRARIES atomic)
 endif ()
 
 set(_javascript_Core_SCRIPTS_SOURCES_DIR "${_javascript_CORE_DIR}/Scripts")


Modified: trunk/Source/_javascript_Core/ChangeLog (231842 => 231843)

--- trunk/Source/_javascript_Core/ChangeLog	2018-05-16 13:09:37 UTC (rev 231842)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-05-16 13:33:50 UTC (rev 231843)
@@ -1,3 +1,22 @@
+2018-05-16  Alberto Garcia  
+
+[CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations
+https://bugs.webkit.org/show_bug.cgi?id=182622
+
+Reviewed by Michael Catanzaro.
+
+We were linking _javascript_Core against libatomic in MIPS because
+in that architecture __atomic_fetch_add_8() is not a compiler
+intrinsic and is provided by that library instead. However other
+architectures (e.g armel) are in the same situation, so we need a
+generic test.
+
+That test already exists in WebKit/CMakeLists.txt, so we just have
+to move it to a common file (WebKitCompilerFlags.cmake) and use
+its result (ATOMIC_INT64_REQUIRES_LIBATOMIC) here.
+
+* CMakeLists.txt:
+
 2018-05-15  Yusuke Suzuki  
 
 [JSC] Check TypeInfo first before calling getCallData when we would like to check 

[webkit-changes] [231842] trunk/LayoutTests

[graouts]

Title: [231842] trunk/LayoutTests








Revision 231842
Author grao...@webkit.org
Date 2018-05-16 06:09:37 -0700 (Wed, 16 May 2018)


Log Message
REGRESSION (r230574): Interrupted hardware transitions don't behave correctly
https://bugs.webkit.org/show_bug.cgi?id=185299

Unreviewed. Attempt to make this test more robust.

* transitions/interrupted-transition-hardware.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/transitions/interrupted-transition-hardware.html




Diff

Modified: trunk/LayoutTests/ChangeLog (231841 => 231842)

--- trunk/LayoutTests/ChangeLog	2018-05-16 08:38:10 UTC (rev 231841)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 13:09:37 UTC (rev 231842)
@@ -2,6 +2,15 @@
 
 REGRESSION (r230574): Interrupted hardware transitions don't behave correctly
 https://bugs.webkit.org/show_bug.cgi?id=185299
+
+Unreviewed. Attempt to make this test more robust.
+
+* transitions/interrupted-transition-hardware.html:
+
+2018-05-16  Antoine Quint  
+
+REGRESSION (r230574): Interrupted hardware transitions don't behave correctly
+https://bugs.webkit.org/show_bug.cgi?id=185299
 
 
 Reviewed by Simon Fraser.


Modified: trunk/LayoutTests/transitions/interrupted-transition-hardware.html (231841 => 231842)

--- trunk/LayoutTests/transitions/interrupted-transition-hardware.html	2018-05-16 08:38:10 UTC (rev 231841)
+++ trunk/LayoutTests/transitions/interrupted-transition-hardware.html	2018-05-16 13:09:37 UTC (rev 231842)
@@ -42,16 +42,14 @@
 
 const test = document.getElementById("test");
 
-requestAnimationFrame(() => {
+setTimeout(() => {
 test.classList.add("transitions");
-requestAnimationFrame(() => {
+setTimeout(() => {
 test.classList.remove("transitions");
-requestAnimationFrame(() => {
-requestAnimationFrame(() => {
-if (window.testRunner)
-testRunner.notifyDone();
-});
-});
+setTimeout(() => {
+if (window.testRunner)
+testRunner.notifyDone();
+}, 500);
 });
 });
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231853] trunk/Source/WebKit

[Hironori . Fujii]

Title: [231853] trunk/Source/WebKit








Revision 231853
Author hironori.fu...@sony.com
Date 2018-05-16 10:54:50 -0700 (Wed, 16 May 2018)


Log Message
[Win] Implement WebPage::handleEditingKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=185327

Reviewed by Alexey Proskuryakov.

* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::handleEditingKeyboardEvent): Copied from WebKitLegacy.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (231852 => 231853)

--- trunk/Source/WebKit/ChangeLog	2018-05-16 17:50:38 UTC (rev 231852)
+++ trunk/Source/WebKit/ChangeLog	2018-05-16 17:54:50 UTC (rev 231853)
@@ -1,3 +1,13 @@
+2018-05-16  Fujii Hironori  
+
+[Win] Implement WebPage::handleEditingKeyboardEvent
+https://bugs.webkit.org/show_bug.cgi?id=185327
+
+Reviewed by Alexey Proskuryakov.
+
+* WebProcess/WebPage/win/WebPageWin.cpp:
+(WebKit::WebPage::handleEditingKeyboardEvent): Copied from WebKitLegacy.
+
 2018-05-16  Sihui Liu  
 
 Session cookies aren't reliably set when using default WKWebSiteDataStore


Modified: trunk/Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp (231852 => 231853)

--- trunk/Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp	2018-05-16 17:50:38 UTC (rev 231852)
+++ trunk/Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp	2018-05-16 17:54:50 UTC (rev 231853)
@@ -33,6 +33,7 @@
 #include "WebPageProxyMessages.h"
 #include "WebProcess.h"
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -260,4 +261,36 @@
 int mapKey = modifiers << 16 | evt->charCode();
 return mapKey ? keyPressCommandsMap->get(mapKey) : 0;
 }
+
+bool WebPage::handleEditingKeyboardEvent(WebCore::KeyboardEvent* event)
+{
+auto* frame = downcast(event->target())->document().frame();
+ASSERT(frame);
+
+auto* keyEvent = event->underlyingPlatformEvent();
+if (!keyEvent || keyEvent->isSystemKey()) // Do not treat this as text input if it's a system key event.
+return false;
+
+auto command = frame->editor().command(interpretKeyEvent(event));
+
+if (keyEvent->type() == PlatformEvent::RawKeyDown) {
+// WebKit doesn't have enough information about mode to decide
+// how commands that just insert text if executed via Editor
+// should be treated, so we leave it upon WebCore to either
+// handle them immediately (e.g. Tab that changes focus) or
+// let a keypress event be generated (e.g. Tab that inserts a
+// Tab character, or Enter).
+return !command.isTextInsertion() && command.execute(event);
+}
+
+if (command.execute(event))
+return true;
+
+// Don't insert null or control characters as they can result in unexpected behaviour.
+if (event->charCode() < ' ')
+return false;
+
+return frame->editor().insertText(keyEvent->text(), event);
+}
+
 } // namespace WebKit






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231849] trunk

[commit-queue]

Title: [231849] trunk








Revision 231849
Author commit-qu...@webkit.org
Date 2018-05-16 09:20:26 -0700 (Wed, 16 May 2018)


Log Message
Remove Document#selectedStylesheetSet/preferredStylesheetSet
https://bugs.webkit.org/show_bug.cgi?id=185381

Patch by Chris Nardi  on 2018-05-16
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Refresh historical CSSOM test from upstream to test this change.

* web-platform-tests/cssom/historical-expected.txt:
* web-platform-tests/cssom/historical.html:

Source/WebCore:

Document#selectedStylesheetSet/preferredStylesheetSet are non-standard methods that
are only implemented WebKit. Blink removed these methods in https://crbug.com/690609.
The standard versions of these methods are are no longer in the spec. Remove them
entirely from our implementation.

Updated existing tests and imported/w3c/web-platform-tests/cssom/historical.html.

* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
* dom/Document.h:
* dom/Document.idl:
* style/StyleScope.cpp:
(WebCore::Style::Scope::collectActiveStyleSheets):
* style/StyleScope.h:
(WebCore::Style::Scope::preferredStylesheetSetName const):

Source/WebKit:

Make API methods for Document#selectedStylesheetSet/preferredStylesheetSet do nothing.

* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocument.h:
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:
(webkit_dom_document_set_property):
(webkit_dom_document_get_property):
(webkit_dom_document_get_preferred_stylesheet_set):
(webkit_dom_document_get_selected_stylesheet_set):
(webkit_dom_document_set_selected_stylesheet_set):

Source/WebKitLegacy/mac:

Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
and make them do nothing.

* DOM/DOMDocument.h:
* DOM/DOMDocument.mm:
(-[DOMDocument preferredStylesheetSet]):
(-[DOMDocument selectedStylesheetSet]):
(-[DOMDocument setSelectedStylesheetSet:]):

LayoutTests:

Update tests to remove selectedStylesheetSet/preferredStylesheetSet.

* fast/css/link-disabled-attr-expected.txt:
* fast/css/link-disabled-attr.html:
* fast/dom/assign-to-prototype-accessor-on-prototype-should-throw-expected.txt:
* fast/dom/assign-to-prototype-accessor-on-prototype-should-throw.html:
* fast/dom/document-attribute-js-null-expected.txt:
* fast/dom/document-attribute-js-null.html:
* fast/shadow-dom/link-element-in-shadow-tree-expected.txt:
* fast/shadow-dom/link-element-in-shadow-tree.html:
* fast/shadow-dom/selected-stylesheet-in-shadow-tree-expected.txt: Removed.
* fast/shadow-dom/selected-stylesheet-in-shadow-tree.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/link-disabled-attr-expected.txt
trunk/LayoutTests/fast/css/link-disabled-attr.html
trunk/LayoutTests/fast/dom/assign-to-prototype-accessor-on-prototype-should-throw-expected.txt
trunk/LayoutTests/fast/dom/assign-to-prototype-accessor-on-prototype-should-throw.html
trunk/LayoutTests/fast/dom/document-attribute-js-null-expected.txt
trunk/LayoutTests/fast/dom/document-attribute-js-null.html
trunk/LayoutTests/fast/shadow-dom/link-element-in-shadow-tree-expected.txt
trunk/LayoutTests/fast/shadow-dom/link-element-in-shadow-tree.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/historical-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/historical.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Document.idl
trunk/Source/WebCore/style/StyleScope.cpp
trunk/Source/WebCore/style/StyleScope.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocument.h
trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/DOM/DOMDocument.h
trunk/Source/WebKitLegacy/mac/DOM/DOMDocument.mm


Removed Paths

trunk/LayoutTests/fast/shadow-dom/selected-stylesheet-in-shadow-tree-expected.txt
trunk/LayoutTests/fast/shadow-dom/selected-stylesheet-in-shadow-tree.html




Diff

Modified: trunk/LayoutTests/ChangeLog (231848 => 231849)

--- trunk/LayoutTests/ChangeLog	2018-05-16 16:11:09 UTC (rev 231848)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 16:20:26 UTC (rev 231849)
@@ -1,3 +1,23 @@
+2018-05-16  Chris Nardi  
+
+Remove Document#selectedStylesheetSet/preferredStylesheetSet
+https://bugs.webkit.org/show_bug.cgi?id=185381
+
+Reviewed by Darin Adler.
+
+Update tests to remove selectedStylesheetSet/preferredStylesheetSet.
+
+* fast/css/link-disabled-attr-expected.txt:
+* fast/css/link-disabled-attr.html:
+* fast/dom/assign-to-prototype-accessor-on-prototype-should-throw-expected.txt:
+* fast/dom/assign-to-prototype-accessor-on-prototype-should-throw.html:
+* fast/dom/document-attribute-js-null-expected.txt:
+* 

[webkit-changes] [231850] trunk

[commit-queue]

Title: [231850] trunk








Revision 231850
Author commit-qu...@webkit.org
Date 2018-05-16 10:19:17 -0700 (Wed, 16 May 2018)


Log Message
Session cookies aren't reliably set when using default WKWebSiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=185624


Patch by Sihui Liu  on 2018-05-16
Reviewed by Geoffrey Garen.

Source/WebKit:

Session cookies of default session were set in UI Process when there was no process pool,
but they were not synced (or synced slowly to) Network Process. To make these cookies visible
as soon as they were set through API, we could manually set those cookies in Network Process
during its initilization.

* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
* UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::cookies):
(API::HTTPCookieStore::setCookie):
(API::HTTPCookieStore::deleteCookie):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::pageBeginUsingWebsiteDataStore):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::clearPendingCookies):
* UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.

* TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
(-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm
trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (231849 => 231850)

--- trunk/Source/WebKit/ChangeLog	2018-05-16 16:20:26 UTC (rev 231849)
+++ trunk/Source/WebKit/ChangeLog	2018-05-16 17:19:17 UTC (rev 231850)
@@ -1,3 +1,29 @@
+2018-05-16  Sihui Liu  
+
+Session cookies aren't reliably set when using default WKWebSiteDataStore
+https://bugs.webkit.org/show_bug.cgi?id=185624
+
+
+Reviewed by Geoffrey Garen.
+
+Session cookies of default session were set in UI Process when there was no process pool, 
+but they were not synced (or synced slowly to) Network Process. To make these cookies visible
+as soon as they were set through API, we could manually set those cookies in Network Process
+during its initilization. 
+
+* NetworkProcess/mac/RemoteNetworkingContext.mm:
+(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
+* UIProcess/API/APIHTTPCookieStore.cpp:
+(API::HTTPCookieStore::cookies):
+(API::HTTPCookieStore::setCookie):
+(API::HTTPCookieStore::deleteCookie):
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::ensureNetworkProcess):
+(WebKit::WebProcessPool::pageBeginUsingWebsiteDataStore):
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::clearPendingCookies):
+* UIProcess/WebsiteData/WebsiteDataStore.h:
+
 2018-05-16  Chris Nardi  
 
 Remove Document#selectedStylesheetSet/preferredStylesheetSet


Modified: trunk/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm (231849 => 231850)

--- trunk/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm	2018-05-16 16:20:26 UTC (rev 231849)
+++ trunk/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm	2018-05-16 17:19:17 UTC (rev 231850)
@@ -36,6 +36,7 @@
 #import "WebsiteDataStoreParameters.h"
 #import 
 #import 
+#import 
 #import 
 
 using namespace WebCore;
@@ -45,8 +46,12 @@
 void RemoteNetworkingContext::ensureWebsiteDataStoreSession(WebsiteDataStoreParameters&& parameters)
 {
 auto sessionID = parameters.networkSessionParameters.sessionID;
-if (NetworkStorageSession::storageSession(sessionID))
+if (auto* session = NetworkStorageSession::storageSession(sessionID)) {
+ASSERT(parameters.pendingCookies.isEmpty() || sessionID == PAL::SessionID::defaultSessionID());
+for (const auto& cookie : parameters.pendingCookies)
+session->setCookie(cookie);
 return;
+}
 
 String base;
 if (SessionTracker::getIdentifierBase().isNull())


Modified: trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp (231849 => 231850)

--- trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp	2018-05-16 16:20:26 UTC (rev 231849)
+++ trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp	2018-05-16 17:19:17 UTC (rev 231850)
@@ -52,7 +52,7 @@
 unregisterForNewProcessPoolNotifications();
 }
 
-void HTTPCookieStore::cookies(Function&)>&& completionHandler)
+void 

[webkit-changes] [231852] trunk

[utatane . tea]

Title: [231852] trunk








Revision 231852
Author utatane@gmail.com
Date 2018-05-16 10:50:38 -0700 (Wed, 16 May 2018)


Log Message
[Win] Use C++17 in MSVC
https://bugs.webkit.org/show_bug.cgi?id=185232

Reviewed by Alex Christensen.

.:

Use /std:c++17 option.

* Source/cmake/OptionsMSVC.cmake:

Source/ThirdParty:

Use std::tuple instead of std::tr1::tuple since std::tr1::tuple is removed in C++17 MSVC.
In a subsequent patch, we will upgrade gtest too.

* gtest/include/gtest/internal/gtest-param-util-generated.h:
(testing::internal::CartesianProductHolder2::operator ParamGenerator< ::std::tuple > const):
(testing::internal::CartesianProductHolder3::operator ParamGenerator< ::std::tuple > const):
(testing::internal::CartesianProductHolder4::operator ParamGenerator< ::std::tuple > const):
(testing::internal::CartesianProductHolder5::operator ParamGenerator< ::std::tuple > const):
(testing::internal::CartesianProductHolder6::operator ParamGenerator< ::std::tuple > const):
(testing::internal::CartesianProductHolder7:: const):
(testing::internal::CartesianProductHolder8:: const):
(testing::internal::CartesianProductHolder9:: const):
(testing::internal::CartesianProductHolder10:: const):
(testing::internal::CartesianProductHolder2::operator ParamGenerator< ::std::tr1::tuple > const): Deleted.
(testing::internal::CartesianProductHolder3::operator ParamGenerator< ::std::tr1::tuple > const): Deleted.
(testing::internal::CartesianProductHolder4::operator ParamGenerator< ::std::tr1::tuple > const): Deleted.
(testing::internal::CartesianProductHolder5::operator ParamGenerator< ::std::tr1::tuple > const): Deleted.
(testing::internal::CartesianProductHolder6::operator ParamGenerator< ::std::tr1::tuple > const): Deleted.
* gtest/include/gtest/internal/gtest-tuple.h:

Source/WebCore:

Workaround for MSVC + /std:c++17.

* Modules/geolocation/Coordinates.h:
(WebCore::Coordinates::isolatedCopy const):

Source/WTF:

Disable some WebKit defined C++17 features for MSVC.

* wtf/StdLibExtras.h:

Tools:

Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
conflicts with ::byte defined in Windows' header.

* DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
(WindowedPluginTest::WindowedPluginTest):
* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(logEventProc):
(stringEvent):
(AccessibilityController::winNotificationReceived):
* DumpRenderTree/win/TextInputController.cpp:
(markedRangeCallback):
(firstRectForCharacterRangeCallback):
(selectedRangeCallback):
* DumpRenderTree/win/TextInputController.h:
* DumpRenderTree/win/TextInputControllerWin.cpp:
(TextInputController::markedRange):
(TextInputController::firstRectForCharacterRange):
(TextInputController::selectedRange):

Modified Paths

trunk/ChangeLog
trunk/Source/ThirdParty/ChangeLog
trunk/Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h
trunk/Source/ThirdParty/gtest/include/gtest/internal/gtest-tuple.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/StdLibExtras.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/geolocation/Coordinates.h
trunk/Source/cmake/OptionsMSVC.cmake
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp
trunk/Tools/DumpRenderTree/win/AccessibilityControllerWin.cpp
trunk/Tools/DumpRenderTree/win/TextInputController.cpp
trunk/Tools/DumpRenderTree/win/TextInputController.h
trunk/Tools/DumpRenderTree/win/TextInputControllerWin.cpp




Diff

Modified: trunk/ChangeLog (231851 => 231852)

--- trunk/ChangeLog	2018-05-16 17:25:13 UTC (rev 231851)
+++ trunk/ChangeLog	2018-05-16 17:50:38 UTC (rev 231852)
@@ -1,3 +1,14 @@
+2018-05-14  Yusuke Suzuki  
+
+[Win] Use C++17 in MSVC
+https://bugs.webkit.org/show_bug.cgi?id=185232
+
+Reviewed by Alex Christensen.
+
+Use /std:c++17 option.
+
+* Source/cmake/OptionsMSVC.cmake:
+
 2018-05-16  Alberto Garcia  
 
 [CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations


Modified: trunk/Source/ThirdParty/ChangeLog (231851 => 231852)

--- trunk/Source/ThirdParty/ChangeLog	2018-05-16 17:25:13 UTC (rev 231851)
+++ trunk/Source/ThirdParty/ChangeLog	2018-05-16 17:50:38 UTC (rev 231852)
@@ -1,3 +1,30 @@
+2018-05-14  Yusuke Suzuki  
+
+[Win] Use C++17 in MSVC
+https://bugs.webkit.org/show_bug.cgi?id=185232
+
+Reviewed by Alex Christensen.
+
+Use std::tuple instead of std::tr1::tuple since std::tr1::tuple is removed in C++17 MSVC.
+In a subsequent patch, we will upgrade gtest too.
+
+* gtest/include/gtest/internal/gtest-param-util-generated.h:
+(testing::internal::CartesianProductHolder2::operator ParamGenerator< ::std::tuple > 

[webkit-changes] [231857] branches/safari-606.1.17-branch/Source/WebKit

[bshafiei]

Title: [231857] branches/safari-606.1.17-branch/Source/WebKit








Revision 231857
Author bshaf...@apple.com
Date 2018-05-16 11:47:28 -0700 (Wed, 16 May 2018)


Log Message
Cherry-pick r231824. rdar://problem/40278181

Post-review cleanup for 185459
https://bugs.webkit.org/show_bug.cgi?id=185665


Reviewed by Tim Horton.

Jon made some comments in 185459 that I'm addressing here.

* UIProcess/Cocoa/DownloadClient.h:
* UIProcess/Cocoa/DownloadClient.mm: Guard the activity token for iOS
in a way that means it will still work ok on macOS.
(WebKit::DownloadClient::didStart):
(WebKit::DownloadClient::processDidCrash):
(WebKit::DownloadClient::didFinish):
(WebKit::DownloadClient::didFail):
(WebKit::DownloadClient::didCancel):
(WebKit::DownloadClient::takeActivityToken):
(WebKit::DownloadClient::releaseActivityTokenIfNecessary):
(WebKit::DownloadClient::releaseActivityToken): Deleted.

* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: Add an early return.
(-[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-606.1.17-branch/Source/WebKit/ChangeLog
branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/DownloadClient.h
branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/DownloadClient.mm
branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm




Diff

Modified: branches/safari-606.1.17-branch/Source/WebKit/ChangeLog (231856 => 231857)

--- branches/safari-606.1.17-branch/Source/WebKit/ChangeLog	2018-05-16 18:47:26 UTC (rev 231856)
+++ branches/safari-606.1.17-branch/Source/WebKit/ChangeLog	2018-05-16 18:47:28 UTC (rev 231857)
@@ -1,5 +1,59 @@
 2018-05-16  Babak Shafiei  
 
+Cherry-pick r231824. rdar://problem/40278181
+
+Post-review cleanup for 185459
+https://bugs.webkit.org/show_bug.cgi?id=185665
+
+
+Reviewed by Tim Horton.
+
+Jon made some comments in 185459 that I'm addressing here.
+
+* UIProcess/Cocoa/DownloadClient.h:
+* UIProcess/Cocoa/DownloadClient.mm: Guard the activity token for iOS
+in a way that means it will still work ok on macOS.
+(WebKit::DownloadClient::didStart):
+(WebKit::DownloadClient::processDidCrash):
+(WebKit::DownloadClient::didFinish):
+(WebKit::DownloadClient::didFail):
+(WebKit::DownloadClient::didCancel):
+(WebKit::DownloadClient::takeActivityToken):
+(WebKit::DownloadClient::releaseActivityTokenIfNecessary):
+(WebKit::DownloadClient::releaseActivityToken): Deleted.
+
+* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: Add an early return.
+(-[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-05-15  Dean Jackson  
+
+Post-review cleanup for 185459
+https://bugs.webkit.org/show_bug.cgi?id=185665
+
+
+Reviewed by Tim Horton.
+
+Jon made some comments in 185459 that I'm addressing here.
+
+* UIProcess/Cocoa/DownloadClient.h:
+* UIProcess/Cocoa/DownloadClient.mm: Guard the activity token for iOS
+in a way that means it will still work ok on macOS.
+(WebKit::DownloadClient::didStart):
+(WebKit::DownloadClient::processDidCrash):
+(WebKit::DownloadClient::didFinish):
+(WebKit::DownloadClient::didFail):
+(WebKit::DownloadClient::didCancel):
+(WebKit::DownloadClient::takeActivityToken):
+(WebKit::DownloadClient::releaseActivityTokenIfNecessary):
+(WebKit::DownloadClient::releaseActivityToken): Deleted.
+
+* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: Add an early return.
+(-[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]):
+
+2018-05-16  Babak Shafiei  
+
 Cherry-pick r231814. rdar://problem/40267224
 
 Provide UIView and UIImage for zoom transition


Modified: branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/DownloadClient.h (231856 => 231857)

--- branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/DownloadClient.h	2018-05-16 18:47:26 UTC (rev 231856)
+++ branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/DownloadClient.h	2018-05-16 18:47:28 UTC (rev 231857)
@@ -60,12 +60,17 @@
 void didCreateDestination(WebProcessPool&, DownloadProxy&, const String&) final;
 void processDidCrash(WebProcessPool&, DownloadProxy&) final;
 
-#if PLATFORM(IOS) && USE(SYSTEM_PREVIEW)
-void releaseActivityToken(DownloadProxy&);
+#if USE(SYSTEM_PREVIEW)
+void takeActivityToken(DownloadProxy&);
+void 

[webkit-changes] [231855] branches/safari-606.1.17-branch/Source/WebKit

[bshafiei]

Title: [231855] branches/safari-606.1.17-branch/Source/WebKit








Revision 231855
Author bshaf...@apple.com
Date 2018-05-16 11:47:23 -0700 (Wed, 16 May 2018)


Log Message
Cherry-pick r231783. rdar://problem/40230277

Use the system font by default in extra zoom mode
https://bugs.webkit.org/show_bug.cgi?id=185638


Reviewed by Wenson Hsieh.

* Shared/WebPreferencesDefaultValues.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-606.1.17-branch/Source/WebKit/ChangeLog
branches/safari-606.1.17-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.h




Diff

Modified: branches/safari-606.1.17-branch/Source/WebKit/ChangeLog (231854 => 231855)

--- branches/safari-606.1.17-branch/Source/WebKit/ChangeLog	2018-05-16 18:12:19 UTC (rev 231854)
+++ branches/safari-606.1.17-branch/Source/WebKit/ChangeLog	2018-05-16 18:47:23 UTC (rev 231855)
@@ -1,3 +1,28 @@
+2018-05-16  Babak Shafiei  
+
+Cherry-pick r231783. rdar://problem/40230277
+
+Use the system font by default in extra zoom mode
+https://bugs.webkit.org/show_bug.cgi?id=185638
+
+
+Reviewed by Wenson Hsieh.
+
+* Shared/WebPreferencesDefaultValues.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-05-14  Tim Horton  
+
+Use the system font by default in extra zoom mode
+https://bugs.webkit.org/show_bug.cgi?id=185638
+
+
+Reviewed by Wenson Hsieh.
+
+* Shared/WebPreferencesDefaultValues.h:
+
 2018-05-15  Babak Shafiei  
 
 Cherry-pick r231797. rdar://problem/39652624


Modified: branches/safari-606.1.17-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.h (231854 => 231855)

--- branches/safari-606.1.17-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2018-05-16 18:12:19 UTC (rev 231854)
+++ branches/safari-606.1.17-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2018-05-16 18:47:23 UTC (rev 231855)
@@ -139,7 +139,12 @@
 
 #if PLATFORM(COCOA)
 
+#if ENABLE(EXTRA_ZOOM_MODE)
+#define DEFAULT_STANDARD_FONT_FAMILY "system-ui"
+#else
 #define DEFAULT_STANDARD_FONT_FAMILY "Times"
+#endif
+
 #define DEFAULT_FANTASY_FONT_FAMILY "Papyrus"
 #define DEFAULT_FIXED_FONT_FAMILY "Courier"
 #define DEFAULT_SANS_SERIF_FONT_FAMILY "Helvetica"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231856] branches/safari-606.1.17-branch/Source/WebKit

[bshafiei]

Title: [231856] branches/safari-606.1.17-branch/Source/WebKit








Revision 231856
Author bshaf...@apple.com
Date 2018-05-16 11:47:26 -0700 (Wed, 16 May 2018)


Log Message
Cherry-pick r231814. rdar://problem/40267224

Provide UIView and UIImage for zoom transition
https://bugs.webkit.org/show_bug.cgi?id=185655


Reviewed by Antoine Quint.

Provide a UIView* for the frameForPreviewItem to use as a source view.
Also implement the transitionImageForPreviewItem delegate, even though
we're returning nil.

* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
(-[_WKPreviewControllerDelegate previewController:frameForPreviewItem:inSourceView:]):
(-[_WKPreviewControllerDelegate previewController:transitionImageForPreviewItem:contentRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-606.1.17-branch/Source/WebKit/ChangeLog
branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm




Diff

Modified: branches/safari-606.1.17-branch/Source/WebKit/ChangeLog (231855 => 231856)

--- branches/safari-606.1.17-branch/Source/WebKit/ChangeLog	2018-05-16 18:47:23 UTC (rev 231855)
+++ branches/safari-606.1.17-branch/Source/WebKit/ChangeLog	2018-05-16 18:47:26 UTC (rev 231856)
@@ -1,5 +1,41 @@
 2018-05-16  Babak Shafiei  
 
+Cherry-pick r231814. rdar://problem/40267224
+
+Provide UIView and UIImage for zoom transition
+https://bugs.webkit.org/show_bug.cgi?id=185655
+
+
+Reviewed by Antoine Quint.
+
+Provide a UIView* for the frameForPreviewItem to use as a source view.
+Also implement the transitionImageForPreviewItem delegate, even though
+we're returning nil.
+
+* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
+(-[_WKPreviewControllerDelegate previewController:frameForPreviewItem:inSourceView:]):
+(-[_WKPreviewControllerDelegate previewController:transitionImageForPreviewItem:contentRect:]):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-05-15  Dean Jackson  
+
+Provide UIView and UIImage for zoom transition
+https://bugs.webkit.org/show_bug.cgi?id=185655
+
+
+Reviewed by Antoine Quint.
+
+Provide a UIView* for the frameForPreviewItem to use as a source view.
+Also implement the transitionImageForPreviewItem delegate, even though
+we're returning nil.
+
+* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
+(-[_WKPreviewControllerDelegate previewController:frameForPreviewItem:inSourceView:]):
+(-[_WKPreviewControllerDelegate previewController:transitionImageForPreviewItem:contentRect:]):
+
+2018-05-16  Babak Shafiei  
+
 Cherry-pick r231783. rdar://problem/40230277
 
 Use the system font by default in extra zoom mode


Modified: branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm (231855 => 231856)

--- branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm	2018-05-16 18:47:23 UTC (rev 231855)
+++ branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm	2018-05-16 18:47:26 UTC (rev 231856)
@@ -137,6 +137,7 @@
 if (!presentingViewController)
 return CGRectZero;
 
+*view = presentingViewController.view;
 CGRect frame = presentingViewController.view.frame;
 // Create a smaller rectangle centered in the frame.
 CGFloat halfWidth = frame.size.width / 2;
@@ -145,6 +146,11 @@
 return frame;
 }
 
+- (UIImage *)previewController:(QLPreviewController *)controller transitionImageForPreviewItem:(id )item contentRect:(CGRect *)contentRect
+{
+return nil;
+}
+
 @end
 
 namespace WebKit {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231858] branches/safari-606.1.17-branch/Source/WebKit

[bshafiei]

Title: [231858] branches/safari-606.1.17-branch/Source/WebKit








Revision 231858
Author bshaf...@apple.com
Date 2018-05-16 11:47:31 -0700 (Wed, 16 May 2018)


Log Message
Cherry-pick r231825. rdar://problem/40278181

Launch System Preview as the download starts, rather than waiting for a response
https://bugs.webkit.org/show_bug.cgi?id=185669


Reviewed by Tim Horton.

We were waiting for the RequestResponse to get a MIME-type before
launching the system preview. This causes an annoying delay.

Instead, assume that the system preview is one of the handled
mime types and launch the viewer immediately. If it gets something it
didn't expect, it will show an error.

* UIProcess/Cocoa/DownloadClient.mm:
(WebKit::DownloadClient::didStart):
(WebKit::DownloadClient::didReceiveResponse):
* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
(-[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]):
(WebKit::SystemPreviewController::start): Small cleanup to ensure we
don't try to present twice (this shouldn't happen).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-606.1.17-branch/Source/WebKit/ChangeLog
branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/DownloadClient.mm
branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm




Diff

Modified: branches/safari-606.1.17-branch/Source/WebKit/ChangeLog (231857 => 231858)

--- branches/safari-606.1.17-branch/Source/WebKit/ChangeLog	2018-05-16 18:47:28 UTC (rev 231857)
+++ branches/safari-606.1.17-branch/Source/WebKit/ChangeLog	2018-05-16 18:47:31 UTC (rev 231858)
@@ -1,5 +1,55 @@
 2018-05-16  Babak Shafiei  
 
+Cherry-pick r231825. rdar://problem/40278181
+
+Launch System Preview as the download starts, rather than waiting for a response
+https://bugs.webkit.org/show_bug.cgi?id=185669
+
+
+Reviewed by Tim Horton.
+
+We were waiting for the RequestResponse to get a MIME-type before
+launching the system preview. This causes an annoying delay.
+
+Instead, assume that the system preview is one of the handled
+mime types and launch the viewer immediately. If it gets something it
+didn't expect, it will show an error.
+
+* UIProcess/Cocoa/DownloadClient.mm:
+(WebKit::DownloadClient::didStart):
+(WebKit::DownloadClient::didReceiveResponse):
+* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
+(-[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]):
+(WebKit::SystemPreviewController::start): Small cleanup to ensure we
+don't try to present twice (this shouldn't happen).
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-05-15  Dean Jackson  
+
+Launch System Preview as the download starts, rather than waiting for a response
+https://bugs.webkit.org/show_bug.cgi?id=185669
+
+
+Reviewed by Tim Horton.
+
+We were waiting for the RequestResponse to get a MIME-type before
+launching the system preview. This causes an annoying delay.
+
+Instead, assume that the system preview is one of the handled
+mime types and launch the viewer immediately. If it gets something it
+didn't expect, it will show an error.
+
+* UIProcess/Cocoa/DownloadClient.mm:
+(WebKit::DownloadClient::didStart):
+(WebKit::DownloadClient::didReceiveResponse):
+* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
+(-[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]):
+(WebKit::SystemPreviewController::start): Small cleanup to ensure we
+don't try to present twice (this shouldn't happen).
+
+2018-05-16  Babak Shafiei  
+
 Cherry-pick r231824. rdar://problem/40278181
 
 Post-review cleanup for 185459


Modified: branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/DownloadClient.mm (231857 => 231858)

--- branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/DownloadClient.mm	2018-05-16 18:47:28 UTC (rev 231857)
+++ branches/safari-606.1.17-branch/Source/WebKit/UIProcess/Cocoa/DownloadClient.mm	2018-05-16 18:47:31 UTC (rev 231858)
@@ -76,6 +76,10 @@
 {
 #if USE(SYSTEM_PREVIEW)
 if (downloadProxy.isSystemPreviewDownload()) {
+if (auto* webPage = downloadProxy.originatingPage()) {
+// FIXME: Update the MIME-type once it is known in the ResourceResponse.
+webPage->systemPreviewController()->start(ASCIILiteral { "application/octet-stream" });
+}
 takeActivityToken(downloadProxy);
 return;
 }
@@ -91,10 +95,8 @@
 if (downloadProxy.isSystemPreviewDownload()) {

[webkit-changes] [231854] trunk/Source/WebKitLegacy/mac

[commit-queue]

Title: [231854] trunk/Source/WebKitLegacy/mac








Revision 231854
Author commit-qu...@webkit.org
Date 2018-05-16 11:12:19 -0700 (Wed, 16 May 2018)


Log Message
Fixup after r231849: Do not mark Mac API methods as deprecated
https://bugs.webkit.org/show_bug.cgi?id=185684

Patch by Chris Nardi  on 2018-05-16
Reviewed by Darin Adler.

Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
as the entire class is already marked as deprecated, so it is unnecessary.

* DOM/DOMDocument.h:

Modified Paths

trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/DOM/DOMDocument.h




Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (231853 => 231854)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2018-05-16 17:54:50 UTC (rev 231853)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2018-05-16 18:12:19 UTC (rev 231854)
@@ -1,5 +1,17 @@
 2018-05-16  Chris Nardi  
 
+Fixup after r231849: Do not mark Mac API methods as deprecated
+https://bugs.webkit.org/show_bug.cgi?id=185684
+
+Reviewed by Darin Adler.
+
+Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
+as the entire class is already marked as deprecated, so it is unnecessary.
+
+* DOM/DOMDocument.h:
+
+2018-05-16  Chris Nardi  
+
 Remove Document#selectedStylesheetSet/preferredStylesheetSet
 https://bugs.webkit.org/show_bug.cgi?id=185381
 


Modified: trunk/Source/WebKitLegacy/mac/DOM/DOMDocument.h (231853 => 231854)

--- trunk/Source/WebKitLegacy/mac/DOM/DOMDocument.h	2018-05-16 17:54:50 UTC (rev 231853)
+++ trunk/Source/WebKitLegacy/mac/DOM/DOMDocument.h	2018-05-16 18:12:19 UTC (rev 231854)
@@ -81,8 +81,8 @@
 @property (readonly, copy) NSString *defaultCharset WEBKIT_AVAILABLE_MAC(10_5);
 @property (readonly, copy) NSString *readyState WEBKIT_AVAILABLE_MAC(10_5);
 @property (readonly, copy) NSString *characterSet WEBKIT_AVAILABLE_MAC(10_5);
-@property (readonly, copy) NSString *preferredStylesheetSet WEBKIT_DEPRECATED_MAC(10_5, 10_14);
-@property (copy) NSString *selectedStylesheetSet WEBKIT_DEPRECATED_MAC(10_5, 10_14);
+@property (readonly, copy) NSString *preferredStylesheetSet WEBKIT_AVAILABLE_MAC(10_5);
+@property (copy) NSString *selectedStylesheetSet WEBKIT_AVAILABLE_MAC(10_5);
 @property (readonly, strong) DOMElement *activeElement WEBKIT_AVAILABLE_MAC(10_6);
 
 - (DOMElement *)createElement:(NSString *)tagName;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231859] trunk/Source/WebCore

[dbates]

Title: [231859] trunk/Source/WebCore








Revision 231859
Author dba...@webkit.org
Date 2018-05-16 11:54:39 -0700 (Wed, 16 May 2018)


Log Message
Cleanup platform Cookie
https://bugs.webkit.org/show_bug.cgi?id=185654

Reviewed by Per Arne Vollan.

Remove unnecessary constructor and use =default for default constructor.
Simplify Cookie::decode() by having it decode directly into a stack-allocated
cookie. Remove some unnecessary local variables. Fix style nits.

* platform/Cookie.h:
(WebCore::Cookie::Cookie):
(WebCore::Cookie::isNull const):
(WebCore::Cookie::encode const):
(WebCore::Cookie::decode):
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::getRawCookies):
* platform/network/cocoa/CookieCocoa.mm:
(WebCore::cookieCreated):
(WebCore::Cookie::Cookie):
(WebCore::Cookie::operator== const):
(WebCore::Cookie::hash const):
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Cookie.h
trunk/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp
trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm
trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (231858 => 231859)

--- trunk/Source/WebCore/ChangeLog	2018-05-16 18:47:31 UTC (rev 231858)
+++ trunk/Source/WebCore/ChangeLog	2018-05-16 18:54:39 UTC (rev 231859)
@@ -1,3 +1,29 @@
+2018-05-16  Daniel Bates  
+
+Cleanup platform Cookie
+https://bugs.webkit.org/show_bug.cgi?id=185654
+
+Reviewed by Per Arne Vollan.
+
+Remove unnecessary constructor and use =default for default constructor.
+Simplify Cookie::decode() by having it decode directly into a stack-allocated
+cookie. Remove some unnecessary local variables. Fix style nits.
+
+* platform/Cookie.h:
+(WebCore::Cookie::Cookie):
+(WebCore::Cookie::isNull const):
+(WebCore::Cookie::encode const):
+(WebCore::Cookie::decode):
+* platform/network/cf/CookieJarCFNet.cpp:
+(WebCore::getRawCookies):
+* platform/network/cocoa/CookieCocoa.mm:
+(WebCore::cookieCreated):
+(WebCore::Cookie::Cookie):
+(WebCore::Cookie::operator== const):
+(WebCore::Cookie::hash const):
+* platform/network/soup/CookieJarSoup.cpp:
+(WebCore::getRawCookies):
+
 2018-05-14  Yusuke Suzuki  
 
 [Win] Use C++17 in MSVC


Modified: trunk/Source/WebCore/platform/Cookie.h (231858 => 231859)

--- trunk/Source/WebCore/platform/Cookie.h	2018-05-16 18:47:31 UTC (rev 231858)
+++ trunk/Source/WebCore/platform/Cookie.h	2018-05-16 18:54:39 UTC (rev 231859)
@@ -37,25 +37,9 @@
 namespace WebCore {
 
 struct Cookie {
-Cookie() { }
-
+Cookie() = default;
 Cookie(WTF::HashTableDeletedValueType)
 : name(WTF::HashTableDeletedValue)
-{ }
-
-Cookie(const String& name, const String& value, const String& domain, const String& path, double created, double expires, bool httpOnly, bool secure, bool session, const String& comment, const URL& commentURL, const Vector ports)
-: name(name)
-, value(value)
-, domain(domain)
-, path(path)
-, created(created)
-, expires(expires)
-, httpOnly(httpOnly)
-, secure(secure)
-, session(session)
-, comment(comment)
-, commentURL(commentURL)
-, ports(ports)
 {
 }
 
@@ -76,16 +60,16 @@
 bool isNull() const
 {
 return name.isNull()
-&& value.isNull()
-&& domain.isNull()
-&& path.isNull()
-&& created == 0
-&& expires == 0
-&& !httpOnly
-&& !secure
-&& !session
-&& comment.isNull()
-&& commentURL.isNull();
+&& value.isNull()
+&& domain.isNull()
+&& path.isNull()
+&& !created
+&& !expires
+&& !httpOnly
+&& !secure
+&& !session
+&& comment.isNull()
+&& commentURL.isNull();
 }
 
 String name;
@@ -119,72 +103,49 @@
 template
 void Cookie::encode(Encoder& encoder) const
 {
-encoder << name << value << domain << path << created << expires << httpOnly << secure << session << comment << commentURL << ports;
+encoder << name;
+encoder << value;
+encoder << domain;
+encoder << path;
+encoder << created;
+encoder << expires;
+encoder << httpOnly;
+encoder << secure;
+encoder << session;
+encoder << comment;
+encoder << commentURL;
+encoder << ports;
 }
 
 template
 std::optional Cookie::decode(Decoder& decoder)
 {
-std::optional name;
-decoder >> name;
-if (!name)
+Cookie cookie;
+if (!decoder.decode(cookie.name))
 return std::nullopt;
-
-std::optional value;
-decoder >> value;
-if (!value)
+if (!decoder.decode(cookie.value))
 

[webkit-changes] [231877] trunk/LayoutTests

[ross . kirsling]

Title: [231877] trunk/LayoutTests








Revision 231877
Author ross.kirsl...@sony.com
Date 2018-05-16 16:31:47 -0700 (Wed, 16 May 2018)


Log Message
[WinCairo] Unreviewed gardening before WinCairoRequirements update.

* platform/wincairo/TestExpectations:
* platform/wincairo/fast/dom/adopt-node-crash-2-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wincairo/TestExpectations


Added Paths

trunk/LayoutTests/platform/wincairo/fast/dom/adopt-node-crash-2-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (231876 => 231877)

--- trunk/LayoutTests/ChangeLog	2018-05-16 23:03:02 UTC (rev 231876)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 23:31:47 UTC (rev 231877)
@@ -1,3 +1,10 @@
+2018-05-16  Ross Kirsling  
+
+[WinCairo] Unreviewed gardening before WinCairoRequirements update.
+
+* platform/wincairo/TestExpectations:
+* platform/wincairo/fast/dom/adopt-node-crash-2-expected.txt: Added.
+
 2018-05-16  Ryan Haddad  
 
 Mark imported/mozilla/css-transitions/test_event-dispatch.html as flaky.


Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (231876 => 231877)

--- trunk/LayoutTests/platform/wincairo/TestExpectations	2018-05-16 23:03:02 UTC (rev 231876)
+++ trunk/LayoutTests/platform/wincairo/TestExpectations	2018-05-16 23:31:47 UTC (rev 231877)
@@ -1157,6 +1157,10 @@
 webkit.org/b/176998 fast/animation/css-animation-resuming-when-visible-with-style-change2.html [ Failure ]
 webkit.org/b/176998 legacy-animation-engine/fast/animation/css-animation-resuming-when-visible-with-style-change2.html [ Failure ]
 
+webkit.org/b/185678 animations/keyframes-dynamic.html [ Failure ]
+webkit.org/b/185678 animations/missing-from-to-transforms.html [ Failure ]
+webkit.org/b/185678 animations/missing-from-to.html [ Failure ]
+
 
 ##   End Animation Issues ##
 
@@ -1353,6 +1357,8 @@
 webkit.org/b/116564 fast/dom/Window/window-onFocus.html [ Pass Failure ]
 webkit.org/b/151759 fast/dom/Window/property-access-on-cached-window-after-frame-removed.html [ Skip ]
 
+webkit.org/b/185678 fast/css-generated-content/pseudo-animation.html [ Failure ]
+
 [ Release ] fast/dom/HTMLDocument/hasFocus.html [ Failure ]
 [ Debug ] fast/dom/HTMLDocument/hasFocus.html [ Skip ]
 


Added: trunk/LayoutTests/platform/wincairo/fast/dom/adopt-node-crash-2-expected.txt (0 => 231877)

--- trunk/LayoutTests/platform/wincairo/fast/dom/adopt-node-crash-2-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/wincairo/fast/dom/adopt-node-crash-2-expected.txt	2018-05-16 23:31:47 UTC (rev 231877)
@@ -0,0 +1,2 @@
+Tests for a crash due to adopting a DOM node during DOMFocusOut event. Test passes if it doesn't crash.
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231851] trunk/LayoutTests

[graouts]

Title: [231851] trunk/LayoutTests








Revision 231851
Author grao...@webkit.org
Date 2018-05-16 10:25:13 -0700 (Wed, 16 May 2018)


Log Message
[Web Animations] Turn Web Animations with CSS integration on for test runners
https://bugs.webkit.org/show_bug.cgi?id=184819

Unreviewed. Another attempt to make this test more robust.

* transitions/interrupted-transition-hardware.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/transitions/interrupted-transition-hardware.html




Diff

Modified: trunk/LayoutTests/ChangeLog (231850 => 231851)

--- trunk/LayoutTests/ChangeLog	2018-05-16 17:19:17 UTC (rev 231850)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 17:25:13 UTC (rev 231851)
@@ -1,3 +1,12 @@
+2018-05-16  Antoine Quint  
+
+[Web Animations] Turn Web Animations with CSS integration on for test runners
+https://bugs.webkit.org/show_bug.cgi?id=184819
+
+Unreviewed. Another attempt to make this test more robust.
+
+* transitions/interrupted-transition-hardware.html:
+
 2018-05-16  Chris Nardi  
 
 Remove Document#selectedStylesheetSet/preferredStylesheetSet


Modified: trunk/LayoutTests/transitions/interrupted-transition-hardware.html (231850 => 231851)

--- trunk/LayoutTests/transitions/interrupted-transition-hardware.html	2018-05-16 17:19:17 UTC (rev 231850)
+++ trunk/LayoutTests/transitions/interrupted-transition-hardware.html	2018-05-16 17:25:13 UTC (rev 231851)
@@ -42,14 +42,19 @@
 
 const test = document.getElementById("test");
 
+function waitForCompositedAnimationUpdate(callback)
+{
+setTimeout(callback, 500);
+}
+
 setTimeout(() => {
 test.classList.add("transitions");
-setTimeout(() => {
+waitForCompositedAnimationUpdate(() => {
 test.classList.remove("transitions");
-setTimeout(() => {
+waitForCompositedAnimationUpdate(() => {
 if (window.testRunner)
 testRunner.notifyDone();
-}, 500);
+});
 });
 });
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231876] trunk/Source/WebCore

[mcatanzaro]

Title: [231876] trunk/Source/WebCore








Revision 231876
Author mcatanz...@igalia.com
Date 2018-05-16 16:03:02 -0700 (Wed, 16 May 2018)


Log Message
[GTK] SoupNetworkSession.h:68:62: error: unknown type name 'URL'
https://bugs.webkit.org/show_bug.cgi?id=185378

Unreviewed, just replace unneeded #include with a forward declaration

* platform/network/soup/SoupNetworkSession.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (231875 => 231876)

--- trunk/Source/WebCore/ChangeLog	2018-05-16 22:18:18 UTC (rev 231875)
+++ trunk/Source/WebCore/ChangeLog	2018-05-16 23:03:02 UTC (rev 231876)
@@ -1,3 +1,12 @@
+2018-05-16  Michael Catanzaro  
+
+[GTK] SoupNetworkSession.h:68:62: error: unknown type name 'URL'
+https://bugs.webkit.org/show_bug.cgi?id=185378
+
+Unreviewed, just replace unneeded #include with a forward declaration
+
+* platform/network/soup/SoupNetworkSession.h:
+
 2018-05-16  Jer Noble  
 
 CRASH: Exception thrown from -[AVContentKeySession processContentKeyRequestWithIdentifier:initializationData:options:] after -expire called


Modified: trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h (231875 => 231876)

--- trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h	2018-05-16 22:18:18 UTC (rev 231875)
+++ trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h	2018-05-16 23:03:02 UTC (rev 231876)
@@ -26,7 +26,6 @@
 #ifndef SoupNetworkSession_h
 #define SoupNetworkSession_h
 
-#include "URL.h"
 #include 
 #include 
 #include 
@@ -44,6 +43,7 @@
 
 class CertificateInfo;
 class ResourceError;
+class URL;
 struct SoupNetworkProxySettings;
 
 class SoupNetworkSession {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231878] trunk

[commit-queue]

Title: [231878] trunk








Revision 231878
Author commit-qu...@webkit.org
Date 2018-05-16 16:38:15 -0700 (Wed, 16 May 2018)


Log Message
Unreviewed, rolling out r231845.
https://bugs.webkit.org/show_bug.cgi?id=185702

it is breaking Apple High Sierra 32-bit JSC bot (Requested by
caiolima on #webkit).

Reverted changeset:

"[ESNext][BigInt] Implement support for "/" operation"
https://bugs.webkit.org/show_bug.cgi?id=183996
https://trac.webkit.org/changeset/231845

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/bigIntTests.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/runtime/BigIntPrototype.cpp
trunk/Source/_javascript_Core/runtime/CommonSlowPaths.cpp
trunk/Source/_javascript_Core/runtime/JSBigInt.cpp
trunk/Source/_javascript_Core/runtime/JSBigInt.h
trunk/Source/_javascript_Core/runtime/JSCJSValue.cpp


Removed Paths

trunk/JSTests/stress/big-int-div-jit.js
trunk/JSTests/stress/big-int-div-memory-stress.js
trunk/JSTests/stress/big-int-div-to-primitive.js
trunk/JSTests/stress/big-int-div-type-error.js
trunk/JSTests/stress/big-int-div-wrapped-value.js
trunk/JSTests/stress/big-int-division.js




Diff

Modified: trunk/JSTests/ChangeLog (231877 => 231878)

--- trunk/JSTests/ChangeLog	2018-05-16 23:31:47 UTC (rev 231877)
+++ trunk/JSTests/ChangeLog	2018-05-16 23:38:15 UTC (rev 231878)
@@ -1,3 +1,17 @@
+2018-05-16  Commit Queue  
+
+Unreviewed, rolling out r231845.
+https://bugs.webkit.org/show_bug.cgi?id=185702
+
+it is breaking Apple High Sierra 32-bit JSC bot (Requested by
+caiolima on #webkit).
+
+Reverted changeset:
+
+"[ESNext][BigInt] Implement support for "/" operation"
+https://bugs.webkit.org/show_bug.cgi?id=183996
+https://trac.webkit.org/changeset/231845
+
 2018-05-16  Filip Pizlo  
 
 DFG models InstanceOf incorrectly


Modified: trunk/JSTests/bigIntTests.yaml (231877 => 231878)

--- trunk/JSTests/bigIntTests.yaml	2018-05-16 23:31:47 UTC (rev 231877)
+++ trunk/JSTests/bigIntTests.yaml	2018-05-16 23:38:15 UTC (rev 231878)
@@ -118,20 +118,3 @@
 - path: stress/big-int-multiply-memory-stress.js
   cmd: runBigIntEnabled
 
-- path: stress/big-int-div-jit.js
-  cmd: runBigIntEnabled
-
-- path: stress/big-int-div-memory-stress.js
-  cmd: runBigIntEnabled
-
-- path: stress/big-int-div-to-primitive.js
-  cmd: runBigIntEnabled
-
-- path: stress/big-int-div-type-error.js
-  cmd: runBigIntEnabled
-
-- path: stress/big-int-div-wrapped-value.js
-  cmd: runBigIntEnabled
-
-- path: stress/big-int-division.js
-  cmd: runBigIntEnabled


Deleted: trunk/JSTests/stress/big-int-div-jit.js (231877 => 231878)

--- trunk/JSTests/stress/big-int-div-jit.js	2018-05-16 23:31:47 UTC (rev 231877)
+++ trunk/JSTests/stress/big-int-div-jit.js	2018-05-16 23:38:15 UTC (rev 231878)
@@ -1,19 +0,0 @@
-//@ runBigIntEnabled
-
-let assert = {
-sameValue: function(i, e, m) {
-if (i !== e)
-throw new Error(m);
-}
-}
-
-function bigIntDiv(x, y) {
-return x / y;
-}
-noInline(bigIntDiv);
-
-for (let i = 0; i < 1; i++) {
-let r = bigIntDiv(30n, 10n);
-assert.sameValue(r, 3n, 30n + " / " + 10n + " = " + r);
-}
-


Deleted: trunk/JSTests/stress/big-int-div-memory-stress.js (231877 => 231878)

--- trunk/JSTests/stress/big-int-div-memory-stress.js	2018-05-16 23:31:47 UTC (rev 231877)
+++ trunk/JSTests/stress/big-int-div-memory-stress.js	2018-05-16 23:38:15 UTC (rev 231878)
@@ -1,15 +0,0 @@
-//@ runBigIntEnabled
-
-function assert(a) {
-if (!a)
-throw new Error("Bad assertion");
-}
-
-let a = 0n;
-let b = 30n;
-for (let i = 0; i < 100; i++) {
-a = b / 2n;
-}
-
-assert(a === 15n);
-


Deleted: trunk/JSTests/stress/big-int-div-to-primitive.js (231877 => 231878)

--- trunk/JSTests/stress/big-int-div-to-primitive.js	2018-05-16 23:31:47 UTC (rev 231877)
+++ trunk/JSTests/stress/big-int-div-to-primitive.js	2018-05-16 23:38:15 UTC (rev 231878)
@@ -1,34 +0,0 @@
-//@ runBigIntEnabled
-
-function assert(a) {
-if (!a)
-throw new Error("Bad assertion");
-}
-
-assert.sameValue = function (input, expected, message) {
-if (input !== expected)
-throw new Error(message);
-}
-
-function testDiv(x, y, z) {
-assert.sameValue(x / y, z, x + " / " + y + " = " + z);
-}
-
-let o = {
-[Symbol.toPrimitive]: function () { return 3000n; }
-}
-
-testDiv(5000438n, o, 1666n);
-
-o.valueOf = function () {
-throw new Error("Should never execute it");
-};
-
-testDiv(7000438n, o, 2333n);
-
-o.toString = function () {
-throw new Error("Should never execute it");
-};
-
-testDiv(7000438n, o, 2333n);
-


Deleted: trunk/JSTests/stress/big-int-div-type-error.js (231877 => 231878)

--- trunk/JSTests/stress/big-int-div-type-error.js	2018-05-16 23:31:47 UTC (rev 231877)
+++ trunk/JSTests/stress/big-int-div-type-error.js	2018-05-16 23:38:15 UTC (rev 231878)
@@ 

[webkit-changes] [231840] trunk

[graouts]

Title: [231840] trunk








Revision 231840
Author grao...@webkit.org
Date 2018-05-16 01:27:54 -0700 (Wed, 16 May 2018)


Log Message
REGRESSION (r230574): Interrupted hardware transitions don't behave correctly
https://bugs.webkit.org/show_bug.cgi?id=185299


Reviewed by Simon Fraser.

Source/WebCore:

In r230574, the fix for webkit.org/b/184518, we changed the processing order in GraphicsLayerCA::updateAnimations() to first
process m_uncomittedAnimations and then m_animationsToProcess, so we are guaranteed animations exist before we attempt to pause
or seek them. This broke interrupting and resuming hardware animations (such as an interrupted CSS Transition or an animation
running in a non-visible tab) since a pause operation recorded _before_ an animation was added would be paused anyway since
the animation was now first added, and then paused. The fix is simply to clear any pending AnimationProcessingAction for a
newly-uncommitted animation.

Test: transitions/interrupted-transition-hardware.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
* platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation):

LayoutTests:

Add a new test where we interrupt a transition and check that upon returning to the original value,
an animated value is still used and not the initial value. This test fails prior to this patch.

* transitions/interrupted-transition-hardware-expected.html: Added.
* transitions/interrupted-transition-hardware.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h


Added Paths

trunk/LayoutTests/transitions/interrupted-transition-hardware-expected.html
trunk/LayoutTests/transitions/interrupted-transition-hardware.html




Diff

Modified: trunk/LayoutTests/ChangeLog (231839 => 231840)

--- trunk/LayoutTests/ChangeLog	2018-05-16 07:05:27 UTC (rev 231839)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 08:27:54 UTC (rev 231840)
@@ -1,3 +1,17 @@
+2018-05-16  Antoine Quint  
+
+REGRESSION (r230574): Interrupted hardware transitions don't behave correctly
+https://bugs.webkit.org/show_bug.cgi?id=185299
+
+
+Reviewed by Simon Fraser.
+
+Add a new test where we interrupt a transition and check that upon returning to the original value,
+an animated value is still used and not the initial value. This test fails prior to this patch.
+
+* transitions/interrupted-transition-hardware-expected.html: Added.
+* transitions/interrupted-transition-hardware.html: Added.
+
 2018-05-15  Commit Queue  
 
 Unreviewed, rolling out r231765.


Added: trunk/LayoutTests/transitions/interrupted-transition-hardware-expected.html (0 => 231840)

--- trunk/LayoutTests/transitions/interrupted-transition-hardware-expected.html	(rev 0)
+++ trunk/LayoutTests/transitions/interrupted-transition-hardware-expected.html	2018-05-16 08:27:54 UTC (rev 231840)
@@ -0,0 +1,22 @@
+
+
+
+
+
+
+div {
+position: absolute;
+left: 0;
+top: 0;
+height: 100px;
+width: 100px;
+transform: translateX(25px);
+background-color: green;
+}
+
+
+
+
+
+
+


Added: trunk/LayoutTests/transitions/interrupted-transition-hardware.html (0 => 231840)

--- trunk/LayoutTests/transitions/interrupted-transition-hardware.html	(rev 0)
+++ trunk/LayoutTests/transitions/interrupted-transition-hardware.html	2018-05-16 08:27:54 UTC (rev 231840)
@@ -0,0 +1,61 @@
+
+
+
+
+
+
+div {
+position: absolute;
+left: 0;
+top: 0;
+height: 100px;
+width: 100px;
+}
+
+#test {
+background-color: red;
+transition: transform calc(24 * 60 * 60s) linear;
+transition-delay: calc(-12 * 60 * 60s);
+transform: none;
+}
+
+#test.transitions {
+transform: translateX(100px);
+}
+
+#cover {
+transform: translateX(25px);
+background-color: green;
+}
+
+
+
+
+
+
+
+
+
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+const test = document.getElementById("test");
+
+requestAnimationFrame(() => {
+test.classList.add("transitions");
+requestAnimationFrame(() => {
+test.classList.remove("transitions");
+requestAnimationFrame(() => {
+requestAnimationFrame(() => {
+if 

[webkit-changes] [231879] trunk/Source/WebKit

[bfulgham]

Title: [231879] trunk/Source/WebKit








Revision 231879
Author bfulg...@apple.com
Date 2018-05-16 17:28:29 -0700 (Wed, 16 May 2018)


Log Message
REGRESSION(r229093)[macOS] Allow network-outbound for syslog use
https://bugs.webkit.org/show_bug.cgi?id=185703


Reviewed by Eric Carlson.

In r229093 I removed the 'network-outbound' permission for syslog use.
Further testing has shown that this is still needed for subsystem
logging in our bundle loading code.

This patch re-enabled network-outbound for syslog.

* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (231878 => 231879)

--- trunk/Source/WebKit/ChangeLog	2018-05-16 23:38:15 UTC (rev 231878)
+++ trunk/Source/WebKit/ChangeLog	2018-05-17 00:28:29 UTC (rev 231879)
@@ -1,3 +1,19 @@
+2018-05-16  Brent Fulgham  
+
+REGRESSION(r229093)[macOS] Allow network-outbound for syslog use
+https://bugs.webkit.org/show_bug.cgi?id=185703
+
+
+Reviewed by Eric Carlson.
+
+In r229093 I removed the 'network-outbound' permission for syslog use.
+Further testing has shown that this is still needed for subsystem
+logging in our bundle loading code.
+
+This patch re-enabled network-outbound for syslog.
+
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2018-05-16  Andy VanWagoner  
 
 Add support for Intl NumberFormat formatToParts


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (231878 => 231879)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2018-05-16 23:38:15 UTC (rev 231878)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2018-05-17 00:28:29 UTC (rev 231879)
@@ -645,6 +645,8 @@
;; Note: This is needed for some media playback features. 
;; Remove this permission when  is fixed.
(literal "/private/var/run/mDNSResponder")
+   ;; ObjC map_images needs to send logging data to syslog. 
+   (literal "/private/var/run/syslog")
(remote tcp))
 
 #if !PLATFORM(MAC) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231882] trunk

[sbarati]

Title: [231882] trunk








Revision 231882
Author sbar...@apple.com
Date 2018-05-16 18:49:24 -0700 (Wed, 16 May 2018)


Log Message
Constant fold CheckTypeInfoFlags on ImplementsDefaultHasInstance
https://bugs.webkit.org/show_bug.cgi?id=185670

Reviewed by Yusuke Suzuki.

JSTests:

* microbenchmarks/constant-fold-check-type-info-flags.js: Added.
* stress/dont-constant-fold-check-type-info-on-bound-function.js: Added.

Source/_javascript_Core:

This patch makes it so that we constant fold CheckTypeInfoFlags for
ImplementsDefaultHasInstance inside of AI/constant folding. We constant
fold in three ways:
- When the incoming value is a constant, we just look at its inline type
flags. Since those flags never change after an object is created, this
is sound.
- Based on the incoming value having a finite structure set. We just iterate
all structures and ensure they have the bit set.
- Based on speculated type. To do this, I split up SpecFunction into two
subheaps where one is for functions that have the bit set, and one for
functions that don't have the bit set. The latter is currently only comprised
of JSBoundFunctions. To constant fold, we check that the incoming
value only has the SpecFunction type with ImplementsDefaultHasInstance set.

* bytecode/SpeculatedType.cpp:
(JSC::speculationFromClassInfo):
* bytecode/SpeculatedType.h:
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCheckTypeInfoFlags):
* dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::assertTypeInfoFlagInvariants):
* runtime/JSFunction.h:
(JSC::JSFunction::assertTypeInfoFlagInvariants):
* runtime/JSFunctionInlines.h:
(JSC::JSFunction::JSFunction):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/SpeculatedType.cpp
trunk/Source/_javascript_Core/bytecode/SpeculatedType.h
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp
trunk/Source/_javascript_Core/runtime/JSFunction.cpp
trunk/Source/_javascript_Core/runtime/JSFunction.h
trunk/Source/_javascript_Core/runtime/JSFunctionInlines.h


Added Paths

trunk/JSTests/microbenchmarks/constant-fold-check-type-info-flags.js
trunk/JSTests/stress/dont-constant-fold-check-type-info-on-bound-function.js




Diff

Modified: trunk/JSTests/ChangeLog (231881 => 231882)

--- trunk/JSTests/ChangeLog	2018-05-17 01:37:33 UTC (rev 231881)
+++ trunk/JSTests/ChangeLog	2018-05-17 01:49:24 UTC (rev 231882)
@@ -1,3 +1,13 @@
+2018-05-16  Saam Barati  
+
+Constant fold CheckTypeInfoFlags on ImplementsDefaultHasInstance
+https://bugs.webkit.org/show_bug.cgi?id=185670
+
+Reviewed by Yusuke Suzuki.
+
+* microbenchmarks/constant-fold-check-type-info-flags.js: Added.
+* stress/dont-constant-fold-check-type-info-on-bound-function.js: Added.
+
 2018-05-16  Commit Queue  
 
 Unreviewed, rolling out r231845.


Added: trunk/JSTests/microbenchmarks/constant-fold-check-type-info-flags.js (0 => 231882)

--- trunk/JSTests/microbenchmarks/constant-fold-check-type-info-flags.js	(rev 0)
+++ trunk/JSTests/microbenchmarks/constant-fold-check-type-info-flags.js	2018-05-17 01:49:24 UTC (rev 231882)
@@ -0,0 +1,41 @@
+"use strict";
+
+function clobber() { }
+noInline(clobber);
+
+class C { }
+class D { }
+
+function foo(x, C) {
+clobber();
+return x instanceof C;
+}
+noInline(foo);
+
+function access(o) {
+return o.foo0;
+}
+noInline(access);
+
+function theClass(i) {
+if (i & 1)
+return C;
+return D;
+}
+noInline(theClass);
+
+let x = new C;
+for (let i = 0; i < 1000; ++i) {
+let k = theClass(i);
+if (i < 20)
+k["foo" + i] = i;
+if (i >= 20)
+access(k);
+if (i === 100)
+k["foo" + i] = i;
+let result = foo(x, k);
+if (k === C && result !== true)
+throw new Error("Bad")
+if (k !== C && result !== false)
+throw new Error("Bad")
+}


Added: trunk/JSTests/stress/dont-constant-fold-check-type-info-on-bound-function.js (0 => 231882)

--- trunk/JSTests/stress/dont-constant-fold-check-type-info-on-bound-function.js	(rev 0)
+++ trunk/JSTests/stress/dont-constant-fold-check-type-info-on-bound-function.js	2018-05-17 01:49:24 UTC (rev 231882)
@@ -0,0 +1,17 @@
+"use strict";
+
+class C { }
+let x = new C;
+C = C.bind(this);
+
+function foo(x) {
+x.foo;
+return x instanceof C;
+}
+noInline(foo);
+
+for (let i = 0; i < 1000; ++i) {
+let r = foo(x);
+if (r !== true)

[webkit-changes] [231880] trunk/LayoutTests

[beidson]

Title: [231880] trunk/LayoutTests








Revision 231880
Author beid...@apple.com
Date 2018-05-16 17:33:34 -0700 (Wed, 16 May 2018)


Log Message
LayoutTest storage/indexeddb/dont-wedge-private.html is a flaky failure
 and https://bugs.webkit.org/show_bug.cgi?id=184058

Reviewed by Andy Estes.

Make the asynchronous IDB part of this test take way, way longer to always give the location change a chance to happen.

* TestExpectations:
* storage/indexeddb/dont-wedge-expected.txt:
* storage/indexeddb/dont-wedge-private-expected.txt:
* storage/indexeddb/resources/dont-wedge.js:
(openDatabase1.request.onupgradeneeded.openOnUpgradeNeeded1.putter):
(openDatabase1.request.onupgradeneeded):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/storage/indexeddb/dont-wedge-expected.txt
trunk/LayoutTests/storage/indexeddb/dont-wedge-private-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/dont-wedge.js




Diff

Modified: trunk/LayoutTests/ChangeLog (231879 => 231880)

--- trunk/LayoutTests/ChangeLog	2018-05-17 00:28:29 UTC (rev 231879)
+++ trunk/LayoutTests/ChangeLog	2018-05-17 00:33:34 UTC (rev 231880)
@@ -1,3 +1,19 @@
+2018-05-16  Brady Eidson  
+
+LayoutTest storage/indexeddb/dont-wedge-private.html is a flaky failure
+ and https://bugs.webkit.org/show_bug.cgi?id=184058
+
+Reviewed by Andy Estes.
+
+Make the asynchronous IDB part of this test take way, way longer to always give the location change a chance to happen.
+
+* TestExpectations:
+* storage/indexeddb/dont-wedge-expected.txt:
+* storage/indexeddb/dont-wedge-private-expected.txt:
+* storage/indexeddb/resources/dont-wedge.js:
+(openDatabase1.request.onupgradeneeded.openOnUpgradeNeeded1.putter):
+(openDatabase1.request.onupgradeneeded):
+
 2018-05-16  Ross Kirsling  
 
 [WinCairo] Unreviewed gardening before WinCairoRequirements update.


Modified: trunk/LayoutTests/TestExpectations (231879 => 231880)

--- trunk/LayoutTests/TestExpectations	2018-05-17 00:28:29 UTC (rev 231879)
+++ trunk/LayoutTests/TestExpectations	2018-05-17 00:33:34 UTC (rev 231880)
@@ -1896,8 +1896,6 @@
 
 webkit.org/b/184198 imported/w3c/web-platform-tests/html/browsers/offline/appcache/workers/appcache-worker.html [ Pass Failure ]
 
-webkit.org/b/184058 storage/indexeddb/dont-wedge-private.html [ Pass Failure ]
-
 webkit.org/b/184061 http/tests/appcache/interrupted-update.html [ Pass Failure ]
 
 webkit.org/b/184453 imported/w3c/web-platform-tests/workers/name-property.html [ Pass Failure ]


Modified: trunk/LayoutTests/storage/indexeddb/dont-wedge-expected.txt (231879 => 231880)

--- trunk/LayoutTests/storage/indexeddb/dont-wedge-expected.txt	2018-05-17 00:28:29 UTC (rev 231879)
+++ trunk/LayoutTests/storage/indexeddb/dont-wedge-expected.txt	2018-05-17 00:33:34 UTC (rev 231880)
@@ -19,9 +19,6 @@
 indexedDB.open(dbname1, 1)
 
 openOnUpgradeNeeded1():
-db1 = event.target.result
-store1 = db1.createObjectStore('store')
-store1.put(0, 0)
 
 openOnSuccess1():
 PASS isAfterReload() is true


Modified: trunk/LayoutTests/storage/indexeddb/dont-wedge-private-expected.txt (231879 => 231880)

--- trunk/LayoutTests/storage/indexeddb/dont-wedge-private-expected.txt	2018-05-17 00:28:29 UTC (rev 231879)
+++ trunk/LayoutTests/storage/indexeddb/dont-wedge-private-expected.txt	2018-05-17 00:33:34 UTC (rev 231880)
@@ -19,9 +19,6 @@
 indexedDB.open(dbname1, 1)
 
 openOnUpgradeNeeded1():
-db1 = event.target.result
-store1 = db1.createObjectStore('store')
-store1.put(0, 0)
 
 openOnSuccess1():
 PASS isAfterReload() is true


Modified: trunk/LayoutTests/storage/indexeddb/resources/dont-wedge.js (231879 => 231880)

--- trunk/LayoutTests/storage/indexeddb/resources/dont-wedge.js	2018-05-17 00:28:29 UTC (rev 231879)
+++ trunk/LayoutTests/storage/indexeddb/resources/dont-wedge.js	2018-05-17 00:33:34 UTC (rev 231880)
@@ -54,9 +54,16 @@
 request._onblocked_ = unexpectedBlockedCallback;
 request._onupgradeneeded_ = function openOnUpgradeNeeded1(evt) {
 preamble(evt);
-evalAndLog("db1 = event.target.result");
-evalAndLog("store1 = db1.createObjectStore('store')");
-evalAndLog("store1.put(0, 0)");
+db1 = event.target.result;
+		store1 = db1.createObjectStore('store');
+var count = 0;
+function putter() {
+			++count;
+			if (count == 50)
+return;
+store1.put(0, 0)._onsuccess_ = putter;
+}
+putter();
 };
 request._onsuccess_ = function openOnSuccess1(evt) {
 preamble(evt);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231872] trunk/Source/WebCore

[jer . noble]

Title: [231872] trunk/Source/WebCore








Revision 231872
Author jer.no...@apple.com
Date 2018-05-16 14:23:29 -0700 (Wed, 16 May 2018)


Log Message
CRASH: Exception thrown from -[AVContentKeySession processContentKeyRequestWithIdentifier:initializationData:options:] after -expire called
https://bugs.webkit.org/show_bug.cgi?id=185690


Reviewed by Eric Carlson.

Reject all calls to update() after close() has been called on the session.

* platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::update):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (231871 => 231872)

--- trunk/Source/WebCore/ChangeLog	2018-05-16 21:02:49 UTC (rev 231871)
+++ trunk/Source/WebCore/ChangeLog	2018-05-16 21:23:29 UTC (rev 231872)
@@ -1,3 +1,16 @@
+2018-05-16  Jer Noble  
+
+CRASH: Exception thrown from -[AVContentKeySession processContentKeyRequestWithIdentifier:initializationData:options:] after -expire called
+https://bugs.webkit.org/show_bug.cgi?id=185690
+
+
+Reviewed by Eric Carlson.
+
+Reject all calls to update() after close() has been called on the session.
+
+* platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
+(WebCore::CDMSessionAVContentKeySession::update):
+
 2018-05-16  Andy VanWagoner  
 
 Add support for Intl NumberFormat formatToParts


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm (231871 => 231872)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm	2018-05-16 21:02:49 UTC (rev 231871)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm	2018-05-16 21:23:29 UTC (rev 231872)
@@ -237,6 +237,11 @@
 {
 UNUSED_PARAM(nextMessage);
 
+if (m_stopped) {
+errorCode = MediaPlayer::InvalidPlayerState;
+return false;
+}
+
 bool shouldGenerateKeyRequest = !m_certificate || isEqual(key, "renew");
 if (!m_certificate) {
 LOG(Media, "CDMSessionAVContentKeySession::update(%p) - certificate data", this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231873] trunk/Tools

[commit-queue]

Title: [231873] trunk/Tools








Revision 231873
Author commit-qu...@webkit.org
Date 2018-05-16 14:46:36 -0700 (Wed, 16 May 2018)


Log Message
Test262-Runner: Set timer for each test run
https://bugs.webkit.org/show_bug.cgi?id=185692

Patch by Leo Balter  on 2018-05-16
Reviewed by Michael Saboff.

Sets a high resolution timer for each execution call of JSC, reporting
the time in the results report to allow identifying slow tests.
* Scripts/test262/Runner.pm:
(main):
(processFile):
(runTest):
(processResult):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/test262/Runner.pm




Diff

Modified: trunk/Tools/ChangeLog (231872 => 231873)

--- trunk/Tools/ChangeLog	2018-05-16 21:23:29 UTC (rev 231872)
+++ trunk/Tools/ChangeLog	2018-05-16 21:46:36 UTC (rev 231873)
@@ -1,3 +1,18 @@
+2018-05-16  Leo Balter  
+
+Test262-Runner: Set timer for each test run
+https://bugs.webkit.org/show_bug.cgi?id=185692
+
+Reviewed by Michael Saboff.
+
+Sets a high resolution timer for each execution call of JSC, reporting
+the time in the results report to allow identifying slow tests.
+* Scripts/test262/Runner.pm:
+(main):
+(processFile):
+(runTest):
+(processResult):
+
 2018-05-16  Andy VanWagoner  
 
 Add support for Intl NumberFormat formatToParts


Modified: trunk/Tools/Scripts/test262/Runner.pm (231872 => 231873)

--- trunk/Tools/Scripts/test262/Runner.pm	2018-05-16 21:23:29 UTC (rev 231872)
+++ trunk/Tools/Scripts/test262/Runner.pm	2018-05-16 21:46:36 UTC (rev 231873)
@@ -41,6 +41,7 @@
 use FindBin;
 use Env qw(DYLD_FRAMEWORK_PATH);
 use Config;
+use Time::HiRes qw(time);
 
 my $podIsAvailable;
 if  (eval {require Pod::Usage; 1;}) {
@@ -397,9 +398,7 @@
 
 print $skipfilecount . " test files skipped\n";
 
-my $endTime = time();
-my $totalTime = $endTime - $startTime;
-print "Done in $totalTime seconds!\n";
+printf("Done in %.2f seconds!\n", time() - $startTime);
 
 my $totalfailures = $expect ? $newfailcount : $failcount;
 exit ($totalfailures ? 1 : 0);
@@ -512,9 +511,9 @@
 ($includesfh, $includesfile) = compileTest($includes) if defined $includes;
 
 foreach my $scenario (@scenarios) {
-my $result = runTest($includesfile, $filename, $scenario, $data);
+my ($result, $execTime) = runTest($includesfile, $filename, $scenario, $data);
 
-$resultsdata = processResult($filename, $data, $scenario, $result);
+$resultsdata = processResult($filename, $data, $scenario, $result, $execTime);
 DumpFile($resultsfh, $resultsdata);
 }
 
@@ -623,15 +622,22 @@
 $defaultHarness = $deffile if $scenario ne 'raw';
 
 my $prefix = qq(DYLD_FRAMEWORK_PATH=$DYLD_FRAMEWORK_PATH);
+
+my $execTimeStart = time();
 my $result = qx($prefix $JSC $args $defaultHarness $includesfile '$prefixFile$filename');
+my $execTime = time() - $execTimeStart;
 
 chomp $result;
 
-return $result if ($?);
+if ($?) {
+return ($result, $execTime);
+} else {
+return (0, $execTime);
+}
 }
 
 sub processResult {
-my ($path, $data, $scenario, $result) = @_;
+my ($path, $data, $scenario, $result, $execTime) = @_;
 
 # Report a relative path
 my $file = abs2rel( $path, $test262Dir );
@@ -638,6 +644,7 @@
 my %resultdata;
 $resultdata{path} = $file;
 $resultdata{mode} = $scenario;
+$resultdata{time} = $execTime;
 
 my $currentfailure = parseError($result) if $result;
 my $expectedfailure = $expect






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231875] trunk/LayoutTests

[ryanhaddad]

Title: [231875] trunk/LayoutTests








Revision 231875
Author ryanhad...@apple.com
Date 2018-05-16 15:18:18 -0700 (Wed, 16 May 2018)


Log Message
Mark imported/mozilla/css-transitions/test_event-dispatch.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=183843

Unreviewed test gardening.

* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (231874 => 231875)

--- trunk/LayoutTests/ChangeLog	2018-05-16 22:15:49 UTC (rev 231874)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 22:18:18 UTC (rev 231875)
@@ -1,3 +1,12 @@
+2018-05-16  Ryan Haddad  
+
+Mark imported/mozilla/css-transitions/test_event-dispatch.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=183843
+
+Unreviewed test gardening.
+
+* platform/ios/TestExpectations:
+
 2018-05-16  Andy VanWagoner  
 
 Add support for Intl NumberFormat formatToParts


Modified: trunk/LayoutTests/platform/ios/TestExpectations (231874 => 231875)

--- trunk/LayoutTests/platform/ios/TestExpectations	2018-05-16 22:15:49 UTC (rev 231874)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2018-05-16 22:18:18 UTC (rev 231875)
@@ -3296,3 +3296,5 @@
 webkit.org/b/185028 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html [ Failure ]
 
 webkit.org/b/185332 animations/duplicate-keys.html [ Pass ImageOnlyFailure ]
+
+webkit.org/b/183843 imported/mozilla/css-transitions/test_event-dispatch.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231874] trunk/Tools

[commit-queue]

Title: [231874] trunk/Tools








Revision 231874
Author commit-qu...@webkit.org
Date 2018-05-16 15:15:49 -0700 (Wed, 16 May 2018)


Log Message
Test262-Runner: Adds a --timeout option
https://bugs.webkit.org/show_bug.cgi?id=185696

Patch by Leo Balter  on 2018-05-16
Reviewed by Michael Saboff.

The timeout option is used to set a timeout execution in ms for each test run in JSC.
The passed value - if defined - will be used as the value for the JSC --watchdog arg.
* Scripts/test262/Runner.pm:
(processCLI):
(runTest):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/test262/Runner.pm




Diff

Modified: trunk/Tools/ChangeLog (231873 => 231874)

--- trunk/Tools/ChangeLog	2018-05-16 21:46:36 UTC (rev 231873)
+++ trunk/Tools/ChangeLog	2018-05-16 22:15:49 UTC (rev 231874)
@@ -1,5 +1,18 @@
 2018-05-16  Leo Balter  
 
+Test262-Runner: Adds a --timeout option
+https://bugs.webkit.org/show_bug.cgi?id=185696
+
+Reviewed by Michael Saboff.
+
+The timeout option is used to set a timeout execution in ms for each test run in JSC.
+The passed value - if defined - will be used as the value for the JSC --watchdog arg.
+* Scripts/test262/Runner.pm:
+(processCLI):
+(runTest):
+
+2018-05-16  Leo Balter  
+
 Test262-Runner: Set timer for each test run
 https://bugs.webkit.org/show_bug.cgi?id=185692
 


Modified: trunk/Tools/Scripts/test262/Runner.pm (231873 => 231874)

--- trunk/Tools/Scripts/test262/Runner.pm	2018-05-16 21:46:36 UTC (rev 231873)
+++ trunk/Tools/Scripts/test262/Runner.pm	2018-05-16 22:15:49 UTC (rev 231874)
@@ -83,6 +83,7 @@
 my $failingOnly;
 my $latestImport;
 my $runningAllTests;
+my $timeout;
 
 my $expectationsFile = abs_path("$Bin/../../../JSTests/test262/expectations.yaml");
 my $configFile = abs_path("$Bin/../../../JSTests/test262/config.yaml");
@@ -135,6 +136,7 @@
 'l|latest-import' => \$latestImport,
 'stats' => \$stats,
 'r|results=s' => \$specifiedResultsFile,
+'timeout=i' => \$timeout,
 );
 
 if ($help) {
@@ -234,8 +236,9 @@
 . "DYLD_FRAMEWORK_PATH: $DYLD_FRAMEWORK_PATH\n"
 . "Child Processes: $max_process\n";
 
+print "Test timeout: $timeout\n" if $timeout;
 print "Features to include: " . join(', ', @features) . "\n" if @features;
-print "Paths:  " . join(', ', @cliTestDirs) . "\n" if @cliTestDirs;
+print "Paths: " . join(', ', @cliTestDirs) . "\n" if @cliTestDirs;
 print "Config file: $configFile\n" if $config;
 print "Expectations file: $expectationsFile\n" if $expect;
 print "Results file: $resultsFile\n" if $stats || $failingOnly;
@@ -597,6 +600,10 @@
 
 my $args = '';
 
+if ($timeout) {
+$args .= " --watchdog=$timeout ";
+}
+
 if (exists $data->{negative}) {
 my $type = $data->{negative}->{type};
 $args .=  " --exception=$type ";
@@ -957,6 +964,10 @@
 
 Specifies a results file for the --stats or --failing-files options.
 
+=item B<--timeout>
+
+Specifies a timeout execution in ms for each test. Defers the value to the jsc --watchdog argument. Disabled by default.
+
 =back
 
 =cut






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231863] trunk/Source/WebKit

[aestes]

Title: [231863] trunk/Source/WebKit








Revision 231863
Author aes...@apple.com
Date 2018-05-16 12:39:30 -0700 (Wed, 16 May 2018)


Log Message
[Wi-Fi Assertions] Adopt WiFiAssertionHolderAdditions
https://bugs.webkit.org/show_bug.cgi?id=185685


Reviewed by Sam Weinig.

* NetworkProcess/cocoa/WiFiAssertionHolder.cpp:
(WebKit::WiFiAssertionHolder::WiFiAssertionHolder):
(WebKit::WiFiAssertionHolder::~WiFiAssertionHolder):
(WebKit::ensureWiFiManagerClient): Deleted.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (231862 => 231863)

--- trunk/Source/WebKit/ChangeLog	2018-05-16 19:34:19 UTC (rev 231862)
+++ trunk/Source/WebKit/ChangeLog	2018-05-16 19:39:30 UTC (rev 231863)
@@ -1,3 +1,16 @@
+2018-05-16  Andy Estes  
+
+[Wi-Fi Assertions] Adopt WiFiAssertionHolderAdditions
+https://bugs.webkit.org/show_bug.cgi?id=185685
+
+
+Reviewed by Sam Weinig.
+
+* NetworkProcess/cocoa/WiFiAssertionHolder.cpp:
+(WebKit::WiFiAssertionHolder::WiFiAssertionHolder):
+(WebKit::WiFiAssertionHolder::~WiFiAssertionHolder):
+(WebKit::ensureWiFiManagerClient): Deleted.
+
 2018-05-16  Fujii Hironori  
 
 [Win] Implement WebPage::handleEditingKeyboardEvent


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp (231862 => 231863)

--- trunk/Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp	2018-05-16 19:34:19 UTC (rev 231862)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp	2018-05-16 19:39:30 UTC (rev 231863)
@@ -28,36 +28,28 @@
 
 #if HAVE(MOBILE_WIFI)
 
-#include "Logging.h"
-#include "MobileWiFiSPI.h"
+#if USE(APPLE_INTERNAL_SDK)
+#include 
+#else
+static void holdWiFiAssertion()
+{
+}
 
-namespace WebKit {
-
-static WiFiManagerClientRef ensureWiFiManagerClient()
+static void releaseWiFiAssertion()
 {
-static WiFiManagerClientRef wiFiManagerClient = WiFiManagerClientCreate(kCFAllocatorDefault, kWiFiClientTypeNormal);
-return wiFiManagerClient;
 }
+#endif
 
-static uint64_t wiFiAssertionCount;
+namespace WebKit {
 
 WiFiAssertionHolder::WiFiAssertionHolder()
 {
-if (wiFiAssertionCount++)
-return;
-
-RELEASE_LOG(WiFiAssertions, "Acquiring Wi-Fi assertion.");
-WiFiManagerClientSetType(ensureWiFiManagerClient(), kWiFiClientTypeBackground);
+holdWiFiAssertion();
 }
 
 WiFiAssertionHolder::~WiFiAssertionHolder()
 {
-ASSERT(wiFiAssertionCount);
-if (--wiFiAssertionCount)
-return;
-
-RELEASE_LOG(WiFiAssertions, "Releasing Wi-Fi assertion.");
-WiFiManagerClientSetType(ensureWiFiManagerClient(), kWiFiClientTypeNormal);
+releaseWiFiAssertion();
 }
 
 } // namespace WebKit






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231867] trunk

[commit-queue]

Title: [231867] trunk








Revision 231867
Author commit-qu...@webkit.org
Date 2018-05-16 13:38:32 -0700 (Wed, 16 May 2018)


Log Message
Add support for Intl NumberFormat formatToParts
https://bugs.webkit.org/show_bug.cgi?id=185375

Patch by Andy VanWagoner  on 2018-05-16
Reviewed by Yusuke Suzuki.

.:

Add flag for NumberFormat formatToParts.

* Source/cmake/OptionsJSCOnly.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/_javascript_Core:

Add flag for NumberFormat formatToParts. Implement formatToParts using
unum_formatDoubleForFields. Because the fields are nested and come back
in no guaranteed order, the simple algorithm to convert them to the
desired format is roughly O(n^2). However, even with Number.MAX_VALUE
it appears to perform well enough for the initial implementation. Another
issue has been created to improve this algorithm.

This requires ICU v59+ for unum_formatDoubleForFields, so it is disabled
on macOS, since only v57 is available.

* Configurations/FeatureDefines.xcconfig:
* runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::UFieldPositionIteratorDeleter::operator() const):
(JSC::IntlNumberFormat::partTypeString):
(JSC::IntlNumberFormat::formatToParts):
* runtime/IntlNumberFormat.h:
* runtime/IntlNumberFormatPrototype.cpp:
(JSC::IntlNumberFormatPrototype::create):
(JSC::IntlNumberFormatPrototype::finishCreation):
(JSC::IntlNumberFormatPrototypeFuncFormatToParts):
* runtime/IntlNumberFormatPrototype.h:
* runtime/Options.h:

Source/WebCore:

Test: js/intl-numberformat-format-to-parts.html

Add flag & tests for NumberFormat formatToParts.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Add flag for NumberFormat formatToParts.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Add flag for NumberFormat formatToParts.

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Add flag for NumberFormat formatToParts.

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

Add flag for NumberFormat formatToParts.

* wtf/FeatureDefines.h:

Tools:

Add flag for NumberFormat formatToParts.

* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

Add tests for NumberFormat formatToParts. Tests are expected to fail on
macOS until ICU is updated to v59 or newer.

* js/intl-numberformat-format-to-parts-expected.txt: Added.
* js/intl-numberformat-format-to-parts.html: Added.
* js/script-tests/intl-numberformat-format-to-parts.js: Added.
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/_javascript_Core/runtime/IntlNumberFormat.cpp
trunk/Source/_javascript_Core/runtime/IntlNumberFormat.h
trunk/Source/_javascript_Core/runtime/IntlNumberFormatPrototype.cpp
trunk/Source/_javascript_Core/runtime/IntlNumberFormatPrototype.h
trunk/Source/_javascript_Core/runtime/Options.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/cmake/OptionsJSCOnly.cmake
trunk/Source/cmake/WebKitFeatures.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm
trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig


Added Paths

trunk/LayoutTests/js/intl-numberformat-format-to-parts-expected.txt
trunk/LayoutTests/js/intl-numberformat-format-to-parts.html
trunk/LayoutTests/js/script-tests/intl-numberformat-format-to-parts.js




Diff

Modified: trunk/ChangeLog (231866 => 231867)

--- trunk/ChangeLog	2018-05-16 20:36:26 UTC (rev 231866)
+++ trunk/ChangeLog	2018-05-16 20:38:32 UTC (rev 231867)
@@ -1,3 +1,15 @@
+2018-05-16  Andy VanWagoner  
+
+Add support for Intl NumberFormat formatToParts
+https://bugs.webkit.org/show_bug.cgi?id=185375
+
+Reviewed by Yusuke Suzuki.
+
+Add flag for NumberFormat formatToParts.
+
+* Source/cmake/OptionsJSCOnly.cmake:
+* Source/cmake/WebKitFeatures.cmake:
+
 2018-05-14  Yusuke Suzuki  
 
 [Win] Use C++17 in MSVC


Modified: trunk/LayoutTests/ChangeLog (231866 => 231867)

--- trunk/LayoutTests/ChangeLog	2018-05-16 20:36:26 UTC (rev 231866)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 20:38:32 UTC (rev 231867)
@@ -1,3 +1,20 @@
+2018-05-16  Andy VanWagoner  

[webkit-changes] [231860] trunk/LayoutTests

[commit-queue]

Title: [231860] trunk/LayoutTests








Revision 231860
Author commit-qu...@webkit.org
Date 2018-05-16 12:06:01 -0700 (Wed, 16 May 2018)


Log Message
Mark LayoutTest animations/needs-layout.html as Flaky on macOS debug.
https://bugs.webkit.org/show_bug.cgi?id=185659

Unreviewed test gardening.

Patch by David Fenton  on 2018-05-16

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (231859 => 231860)

--- trunk/LayoutTests/ChangeLog	2018-05-16 18:54:39 UTC (rev 231859)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 19:06:01 UTC (rev 231860)
@@ -1,3 +1,12 @@
+2018-05-16  David Fenton  
+
+Mark LayoutTest animations/needs-layout.html as Flaky on macOS debug.
+https://bugs.webkit.org/show_bug.cgi?id=185659
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2018-05-16  Antoine Quint  
 
 [Web Animations] Turn Web Animations with CSS integration on for test runners


Modified: trunk/LayoutTests/platform/mac/TestExpectations (231859 => 231860)

--- trunk/LayoutTests/platform/mac/TestExpectations	2018-05-16 18:54:39 UTC (rev 231859)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-05-16 19:06:01 UTC (rev 231860)
@@ -1762,4 +1762,6 @@
 
 webkit.org/b/184609 platform/mac/media/audio-session-category-video-track-change.html [ Pass Failure ]
 
-webkit.org/b/170830 inspector/sampling-profiler/named-function-_expression_.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/170830 inspector/sampling-profiler/named-function-_expression_.html [ Pass Failure ]
+
+webkit.org/b/185659 [ Debug ] animations/needs-layout.html [ Pass ImageOnlyFailure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231861] trunk/LayoutTests

[youenn]

Title: [231861] trunk/LayoutTests








Revision 231861
Author you...@apple.com
Date 2018-05-16 12:11:54 -0700 (Wed, 16 May 2018)


Log Message
REGRESSION (r229735): LayoutTest http/wpt/service-workers/third-party-registration.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=183860


Reviewed by Geoffrey Garen.

Make test more robust by introducing a timeout and better failure reporting.
Mark test as Pass/Fail to start gathering results on test stability.

* http/wpt/service-workers/resources/third-party-registration-frame.html:
* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/service-workers/resources/third-party-registration-frame.html
trunk/LayoutTests/http/wpt/service-workers/resources/third-party-worker.js
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (231860 => 231861)

--- trunk/LayoutTests/ChangeLog	2018-05-16 19:06:01 UTC (rev 231860)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 19:11:54 UTC (rev 231861)
@@ -1,3 +1,18 @@
+2018-05-16  Youenn Fablet  
+
+REGRESSION (r229735): LayoutTest http/wpt/service-workers/third-party-registration.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=183860
+
+
+Reviewed by Geoffrey Garen.
+
+Make test more robust by introducing a timeout and better failure reporting.
+Mark test as Pass/Fail to start gathering results on test stability.
+
+* http/wpt/service-workers/resources/third-party-registration-frame.html:
+* platform/ios-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2018-05-16  David Fenton  
 
 Mark LayoutTest animations/needs-layout.html as Flaky on macOS debug.


Modified: trunk/LayoutTests/http/wpt/service-workers/resources/third-party-registration-frame.html (231860 => 231861)

--- trunk/LayoutTests/http/wpt/service-workers/resources/third-party-registration-frame.html	2018-05-16 19:06:01 UTC (rev 231860)
+++ trunk/LayoutTests/http/wpt/service-workers/resources/third-party-registration-frame.html	2018-05-16 19:11:54 UTC (rev 231861)
@@ -15,19 +15,24 @@
 if (activeWorker)
 return;
 activeWorker = registration.installing;
-await new Promise(resolve => {
+await new Promise((resolve, reject) => {
 activeWorker.addEventListener('statechange', () => {
 if (activeWorker.state === "activated")
 resolve();
 });
+setTimeout(reject, 5000);
 });
 }
 window._onmessage_ = async (e) => {
-await doTest();
-navigator.serviceWorker._onmessage_ = (e) => {
-parent.postMessage(e.data, '*');
+try {
+await doTest();
+navigator.serviceWorker._onmessage_ = (e) => {
+parent.postMessage(e.data, '*');
+}
+activeWorker.postMessage(e.data);
+} catch (e) {
+parent.postMessage("FAILED: " + e, '*');
 }
-activeWorker.postMessage(e.data);
 }
 
 


Modified: trunk/LayoutTests/http/wpt/service-workers/resources/third-party-worker.js (231860 => 231861)

--- trunk/LayoutTests/http/wpt/service-workers/resources/third-party-worker.js	2018-05-16 19:06:01 UTC (rev 231860)
+++ trunk/LayoutTests/http/wpt/service-workers/resources/third-party-worker.js	2018-05-16 19:11:54 UTC (rev 231861)
@@ -2,22 +2,26 @@
 await self.clients.claim();
 });
 addEventListener('message', async (e) => {
-if (e.data ="" 'write') {
-await writeDB();
-await self.caches.open(e.data);
-e.source.postMessage('written');
-return;
+try {
+if (e.data ="" 'write') {
+await writeDB();
+await self.caches.open(e.data);
+e.source.postMessage('written');
+return;
+}
+if (e.data ="" 'read') {
+var keys = await self.caches.keys();
+var db = await readDB();
+if (!db)
+db = null;
+var result = { cache : keys, db : db };
+e.source.postMessage(JSON.stringify(result));
+return;
+}
+e.source.postMessage('error');
+} catch (e) {
+e.source.postMessage('Got error:' + e);
 }
-if (e.data ="" 'read') {
-var keys = await self.caches.keys();
-var db = await readDB();
-if (!db)
-db = null;
-var result = { cache : keys, db : db };
-e.source.postMessage(JSON.stringify(result));
-return;
-}
-e.source.postMessage('error');
 });
 
 function readDB() {


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (231860 => 231861)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-05-16 19:06:01 UTC (rev 231860)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-05-16 19:11:54 UTC (rev 231861)
@@ -1348,7 

[webkit-changes] [231865] trunk/LayoutTests

[youenn]

Title: [231865] trunk/LayoutTests








Revision 231865
Author you...@apple.com
Date 2018-05-16 13:24:32 -0700 (Wed, 16 May 2018)


Log Message
Layout Test webrtc/addICECandidate-closed.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=185384


Reviewed by Eric Carlson.

* webrtc/addICECandidate-closed.html:
Handle sometimes rejected promise to remove a line
in the -expected.txt file that is sometimes added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webrtc/addICECandidate-closed.html




Diff

Modified: trunk/LayoutTests/ChangeLog (231864 => 231865)

--- trunk/LayoutTests/ChangeLog	2018-05-16 19:46:22 UTC (rev 231864)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 20:24:32 UTC (rev 231865)
@@ -1,5 +1,17 @@
 2018-05-16  Youenn Fablet  
 
+Layout Test webrtc/addICECandidate-closed.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=185384
+
+
+Reviewed by Eric Carlson.
+
+* webrtc/addICECandidate-closed.html:
+Handle sometimes rejected promise to remove a line
+in the -expected.txt file that is sometimes added.
+
+2018-05-16  Youenn Fablet  
+
 REGRESSION (r229735): LayoutTest http/wpt/service-workers/third-party-registration.html is a flaky timeout
 https://bugs.webkit.org/show_bug.cgi?id=183860
 


Modified: trunk/LayoutTests/webrtc/addICECandidate-closed.html (231864 => 231865)

--- trunk/LayoutTests/webrtc/addICECandidate-closed.html	2018-05-16 19:46:22 UTC (rev 231864)
+++ trunk/LayoutTests/webrtc/addICECandidate-closed.html	2018-05-16 20:24:32 UTC (rev 231865)
@@ -15,10 +15,8 @@
 const localTracks = stream.getTracks();
 [[sender, receiver], [receiver, sender]].forEach(([pc1, pc2]) => {
 pc1._onicecandidate_ = ({ candidate }) => {
-try {
-if (candidate)
-pc2.addIceCandidate(candidate);
-} catch (e) { }
+if (candidate)
+pc2.addIceCandidate(candidate).then(() => { }, () => { });
 pc1.close();
 };
 });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231869] branches/safari-606.1.17-branch/Source

[bshafiei]

Title: [231869] branches/safari-606.1.17-branch/Source








Revision 231869
Author bshaf...@apple.com
Date 2018-05-16 13:53:49 -0700 (Wed, 16 May 2018)


Log Message
Versioning.

Modified Paths

branches/safari-606.1.17-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-606.1.17-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-606.1.17-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-606.1.17-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-606.1.17-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-606.1.17-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-606.1.17-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-606.1.17-branch/Source/_javascript_Core/Configurations/Version.xcconfig (231868 => 231869)

--- branches/safari-606.1.17-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-05-16 20:46:07 UTC (rev 231868)
+++ branches/safari-606.1.17-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-05-16 20:53:49 UTC (rev 231869)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
-MICRO_VERSION = 7;
+MICRO_VERSION = 8;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-606.1.17-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (231868 => 231869)

--- branches/safari-606.1.17-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-05-16 20:46:07 UTC (rev 231868)
+++ branches/safari-606.1.17-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-05-16 20:53:49 UTC (rev 231869)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
-MICRO_VERSION = 7;
+MICRO_VERSION = 8;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-606.1.17-branch/Source/WebCore/Configurations/Version.xcconfig (231868 => 231869)

--- branches/safari-606.1.17-branch/Source/WebCore/Configurations/Version.xcconfig	2018-05-16 20:46:07 UTC (rev 231868)
+++ branches/safari-606.1.17-branch/Source/WebCore/Configurations/Version.xcconfig	2018-05-16 20:53:49 UTC (rev 231869)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
-MICRO_VERSION = 7;
+MICRO_VERSION = 8;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-606.1.17-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (231868 => 231869)

--- branches/safari-606.1.17-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-05-16 20:46:07 UTC (rev 231868)
+++ branches/safari-606.1.17-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-05-16 20:53:49 UTC (rev 231869)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
-MICRO_VERSION = 7;
+MICRO_VERSION = 8;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-606.1.17-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (231868 => 231869)

--- branches/safari-606.1.17-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-05-16 20:46:07 UTC (rev 231868)
+++ branches/safari-606.1.17-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-05-16 20:53:49 UTC (rev 231869)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
-MICRO_VERSION = 7;
+MICRO_VERSION = 8;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-606.1.17-branch/Source/WebKit/Configurations/Version.xcconfig (231868 => 231869)

--- branches/safari-606.1.17-branch/Source/WebKit/Configurations/Version.xcconfig	2018-05-16 20:46:07 UTC (rev 231868)
+++ branches/safari-606.1.17-branch/Source/WebKit/Configurations/Version.xcconfig	2018-05-16 20:53:49 UTC (rev 231869)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
-MICRO_VERSION = 7;
+MICRO_VERSION = 8;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-606.1.17-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (231868 => 231869)

--- branches/safari-606.1.17-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-05-16 20:46:07 UTC (rev 231868)
+++ branches/safari-606.1.17-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-05-16 20:53:49 UTC (rev 231869)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
-MICRO_VERSION = 7;
+MICRO_VERSION = 8;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 

[webkit-changes] [231866] trunk

[eric . carlson]

Title: [231866] trunk








Revision 231866
Author eric.carl...@apple.com
Date 2018-05-16 13:36:26 -0700 (Wed, 16 May 2018)


Log Message
Improve NowPlaying "title"
https://bugs.webkit.org/show_bug.cgi?id=185680


Reviewed by Jer Noble.
Source/WebCore:

We send NowPlaying the element's title attribute if not empty, else the element's current url.
Title should be preferred because it is the most specific, but we should use the document
title if non-empty next, and if falling back to the element's url use just the domain instead
of the full url because it isn't likely to be useful to the user given the small amount of
space control center uses to display the title. Further, don't use any title at all when
in private browsing mode.

Tests: http/tests/media/now-playing-info-private-browsing.html
   http/tests/media/now-playing-info.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Update NowPlaying when the title attribute changes.
(WebCore::HTMLMediaElement::finishSeek): Update NowPlaying when a seek completes.
(WebCore::HTMLMediaElement::mediaSessionTitle const): Update logic.
(WebCore::HTMLMediaElement::mediaSessionUniqueIdentifier const): Use the hash of the current
url as the unique identifier.
* html/HTMLMediaElement.h:

* platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::uniqueIdentifier const): New.
(WebCore::PlatformMediaSessionClient::mediaSessionUniqueIdentifier const): Ditto.
* platform/audio/PlatformMediaSession.h:

* platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::updateNowPlayingInfo): Update m_lastUpdatedNowPlayingInfoUniqueIdentifier.

* platform/audio/mac/MediaSessionManagerMac.mm:
(WebCore::MediaSessionManagerMac::updateNowPlayingInfo): Update.

* testing/Internals.cpp:
(WebCore::Internals::nowPlayingState const): Expose NowPlaying state.
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* http/tests/media/now-playing-info-expected.txt: Added.
* http/tests/media/now-playing-info-private-browsing-expected.txt: Added.
* http/tests/media/now-playing-info-private-browsing.html: Added.
* http/tests/media/now-playing-info.html: Added.
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-test.js
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSession.h
trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm
trunk/Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl


Added Paths

trunk/LayoutTests/http/tests/media/now-playing-info-expected.txt
trunk/LayoutTests/http/tests/media/now-playing-info-private-browsing-expected.txt
trunk/LayoutTests/http/tests/media/now-playing-info-private-browsing.html
trunk/LayoutTests/http/tests/media/now-playing-info.html




Diff

Modified: trunk/LayoutTests/ChangeLog (231865 => 231866)

--- trunk/LayoutTests/ChangeLog	2018-05-16 20:24:32 UTC (rev 231865)
+++ trunk/LayoutTests/ChangeLog	2018-05-16 20:36:26 UTC (rev 231866)
@@ -1,3 +1,17 @@
+2018-05-16  Eric Carlson  
+
+Improve NowPlaying "title"
+https://bugs.webkit.org/show_bug.cgi?id=185680
+
+
+Reviewed by Jer Noble.
+
+* http/tests/media/now-playing-info-expected.txt: Added.
+* http/tests/media/now-playing-info-private-browsing-expected.txt: Added.
+* http/tests/media/now-playing-info-private-browsing.html: Added.
+* http/tests/media/now-playing-info.html: Added.
+* platform/gtk/TestExpectations:
+
 2018-05-16  Youenn Fablet  
 
 Layout Test webrtc/addICECandidate-closed.html is a flaky failure


Added: trunk/LayoutTests/http/tests/media/now-playing-info-expected.txt (0 => 231866)

--- trunk/LayoutTests/http/tests/media/now-playing-info-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/media/now-playing-info-expected.txt	2018-05-16 20:36:26 UTC (rev 231866)
@@ -0,0 +1,45 @@
+ 
+Tests that the NowPlaying information is updated correctly as attributes change.
+
+* NowPlaying should not be active before playback has started.
+RUN(video.src = "" "resources/test"))
+EVENT(canplaythrough)
+RUN(nowPlayingState = internals.nowPlayingState)
+EXPECTED (nowPlayingState.registeredAsNowPlayingApplication == 'false') OK
+
+* Start to play, NowPlaying should become active.
+RUN(video.play())
+EVENT(playing)
+RUN(video.pause())
+
+* Title should be page title because video has no title.
+RUN(nowPlayingState = internals.nowPlayingState)
+EXPECTED (nowPlayingState.registeredAsNowPlayingApplication == 'true') OK
+EXPECTED (nowPlayingState.title == 'Page 

[webkit-changes] [231870] tags/Safari-606.1.17.7/

[bshafiei]

Title: [231870] tags/Safari-606.1.17.7/








Revision 231870
Author bshaf...@apple.com
Date 2018-05-16 13:55:12 -0700 (Wed, 16 May 2018)


Log Message
Tag Safari-606.1.17.7.

Added Paths

tags/Safari-606.1.17.7/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231871] trunk

[fpizlo]

Title: [231871] trunk








Revision 231871
Author fpi...@apple.com
Date 2018-05-16 14:02:49 -0700 (Wed, 16 May 2018)


Log Message
DFG models InstanceOf incorrectly
https://bugs.webkit.org/show_bug.cgi?id=185694

Reviewed by Keith Miller.
JSTests:


* stress/instanceof-proxy-check-structure.js: Added.
(Foo):
(Bar):
(doBadThings):
(getPrototypeOf):
(foo):
(i.new.Bar):
(new.Bar):
* stress/instanceof-proxy-loop.js: Added.
(Foo):
(Bar):
(doBadThings):
(getPrototypeOf):
(foo):
* stress/instanceof-proxy.js: Added.
(Foo):
(Bar):
(doBadThings):
(getPrototypeOf):
(foo):

Source/_javascript_Core:


Proxies mean that InstanceOf can have effects. Exceptions mean that it's illegal to DCE it or
hoist it.

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGHeapLocation.cpp:
(WTF::printInternal):
* dfg/DFGHeapLocation.h:
* dfg/DFGNodeType.h:

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/dfg/DFGHeapLocation.cpp
trunk/Source/_javascript_Core/dfg/DFGHeapLocation.h
trunk/Source/_javascript_Core/dfg/DFGNodeType.h


Added Paths

trunk/JSTests/stress/instanceof-proxy-check-structure.js
trunk/JSTests/stress/instanceof-proxy-loop.js
trunk/JSTests/stress/instanceof-proxy.js




Diff

Modified: trunk/JSTests/ChangeLog (231870 => 231871)

--- trunk/JSTests/ChangeLog	2018-05-16 20:55:12 UTC (rev 231870)
+++ trunk/JSTests/ChangeLog	2018-05-16 21:02:49 UTC (rev 231871)
@@ -1,3 +1,31 @@
+2018-05-16  Filip Pizlo  
+
+DFG models InstanceOf incorrectly
+https://bugs.webkit.org/show_bug.cgi?id=185694
+
+Reviewed by Keith Miller.
+
+* stress/instanceof-proxy-check-structure.js: Added.
+(Foo):
+(Bar):
+(doBadThings):
+(getPrototypeOf):
+(foo):
+(i.new.Bar):
+(new.Bar):
+* stress/instanceof-proxy-loop.js: Added.
+(Foo):
+(Bar):
+(doBadThings):
+(getPrototypeOf):
+(foo):
+* stress/instanceof-proxy.js: Added.
+(Foo):
+(Bar):
+(doBadThings):
+(getPrototypeOf):
+(foo):
+
 2018-05-16  Caio Lima  
 
 [ESNext][BigInt] Implement support for "/" operation


Added: trunk/JSTests/stress/instanceof-proxy-check-structure.js (0 => 231871)

--- trunk/JSTests/stress/instanceof-proxy-check-structure.js	(rev 0)
+++ trunk/JSTests/stress/instanceof-proxy-check-structure.js	2018-05-16 21:02:49 UTC (rev 231871)
@@ -0,0 +1,59 @@
+class Foo { }
+
+function Bar() { }
+
+var numberOfGetPrototypeOfCalls = 0;
+
+var doBadThings = function() { };
+
+Bar.prototype = new Proxy(
+{},
+{
+getPrototypeOf()
+{
+numberOfGetPrototypeOfCalls++;
+doBadThings();
+return Foo.prototype;
+}
+});
+
+// Break some watchpoints.
+var o = {f:42};
+o.g = 43;
+
+function foo(o, p, q)
+{
+var result = o.f;
+var _ = p instanceof Foo;
+q.f = 11;
+return result + o.f;
+}
+
+noInline(foo);
+
+for (var i = 0; i < 1; ++i) {
+var result = foo({f:42}, new Bar(), {f:0});
+if (result != 84)
+throw "Error: bad result in loop: " + result;
+}
+
+if (numberOfGetPrototypeOfCalls != 1)
+throw "Error: did not call getPrototypeOf() the right number of times";
+
+var globalO = {f:42};
+var didCallGetter = false;
+doBadThings = function() {
+delete globalO.f;
+globalO.__defineGetter__("f", function() {
+didCallGetter = true;
+return 43;
+});
+};
+
+var result = foo(globalO, new Bar(), {f:0});
+if (result != 85)
+throw "Error: bad result at end: " + result;
+if (!didCallGetter)
+throw "Error: did not call getter";
+if (numberOfGetPrototypeOfCalls != 10001)
+throw "Error: did not call getPrototypeOf() the right number of times at end";


Added: trunk/JSTests/stress/instanceof-proxy-loop.js (0 => 231871)

--- trunk/JSTests/stress/instanceof-proxy-loop.js	(rev 0)
+++ trunk/JSTests/stress/instanceof-proxy-loop.js	2018-05-16 21:02:49 UTC (rev 231871)
@@ -0,0 +1,59 @@
+class Foo { }
+
+function Bar() { }
+
+var numberOfGetPrototypeOfCalls = 0;
+
+var doBadThings = function() { };
+
+Bar.prototype = new Proxy(
+{},
+{
+getPrototypeOf()
+{
+numberOfGetPrototypeOfCalls++;
+doBadThings();
+return Foo.prototype;
+}
+});
+
+// Break some watchpoints.
+var o = {f:42};
+o.g = 43;
+
+function foo(o, p)
+{
+var result = o.f;
+for (var i = 0; i < 5; ++i)
+var _ = p instanceof Foo;
+return result + o.f;
+}
+
+noInline(foo);
+
+for (var i = 0; i < 1; ++i) {
+var result = foo({f:42}, new Bar());
+if (result != 84)
+

[webkit-changes] [231862] trunk/Source/WebCore

[dbates]

Title: [231862] trunk/Source/WebCore








Revision 231862
Author dba...@webkit.org
Date 2018-05-16 12:34:19 -0700 (Wed, 16 May 2018)


Log Message
Attempt to fix the WinCairo build following r231859
(https://bugs.webkit.org/show_bug.cgi?id=185654)

Instantiate Cookie as a struct and set applicable fields.

* platform/network/curl/CookieJarDB.cpp:
(WebCore::CookieJarDB::searchCookies):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CookieJarDB.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (231861 => 231862)

--- trunk/Source/WebCore/ChangeLog	2018-05-16 19:11:54 UTC (rev 231861)
+++ trunk/Source/WebCore/ChangeLog	2018-05-16 19:34:19 UTC (rev 231862)
@@ -1,5 +1,15 @@
 2018-05-16  Daniel Bates  
 
+Attempt to fix the WinCairo build following r231859
+(https://bugs.webkit.org/show_bug.cgi?id=185654)
+
+Instantiate Cookie as a struct and set applicable fields.
+
+* platform/network/curl/CookieJarDB.cpp:
+(WebCore::CookieJarDB::searchCookies):
+
+2018-05-16  Daniel Bates  
+
 Cleanup platform Cookie
 https://bugs.webkit.org/show_bug.cgi?id=185654
 


Modified: trunk/Source/WebCore/platform/network/curl/CookieJarDB.cpp (231861 => 231862)

--- trunk/Source/WebCore/platform/network/curl/CookieJarDB.cpp	2018-05-16 19:11:54 UTC (rev 231861)
+++ trunk/Source/WebCore/platform/network/curl/CookieJarDB.cpp	2018-05-16 19:34:19 UTC (rev 231862)
@@ -316,20 +316,16 @@
 if (!isPathMatched)
 continue;
 
-Cookie result(cookieName,
-cookieValue,
-cookieDomain,
-cookiePath,
-0,
-cookieExpires,
-cookieHttpOnly,
-cookieSecure,
-cookieSession,
-String(),
-URL(),
-Vector());
-
-results.append(result);
+Cookie cookie;
+cookie.name = cookieName;
+cookie.value = cookieValue;
+cookie.domain = cookieDomain;
+cookie.path = cookiePath;
+cookie.expires = cookieExpires;
+cookie.httpOnly = cookieHttpOnly;
+cookie.secure = cookieSecure;
+cookie.session = cookieSession;
+results.append(WTFMove(cookie));
 }
 pstmt->finalize();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231864] trunk/Source/WTF

[utatane . tea]

Title: [231864] trunk/Source/WTF








Revision 231864
Author utatane@gmail.com
Date 2018-05-16 12:46:22 -0700 (Wed, 16 May 2018)


Log Message
Unreviewed, follow-up after r231762
https://bugs.webkit.org/show_bug.cgi?id=185589

Addresses darin's suggestions to improve timeClip.

* wtf/DateMath.cpp:
(WTF::timeClip):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/DateMath.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (231863 => 231864)

--- trunk/Source/WTF/ChangeLog	2018-05-16 19:39:30 UTC (rev 231863)
+++ trunk/Source/WTF/ChangeLog	2018-05-16 19:46:22 UTC (rev 231864)
@@ -1,3 +1,13 @@
+2018-05-16  Yusuke Suzuki  
+
+Unreviewed, follow-up after r231762
+https://bugs.webkit.org/show_bug.cgi?id=185589
+
+Addresses darin's suggestions to improve timeClip.
+
+* wtf/DateMath.cpp:
+(WTF::timeClip):
+
 2018-05-14  Yusuke Suzuki  
 
 [Win] Use C++17 in MSVC


Modified: trunk/Source/WTF/wtf/DateMath.cpp (231863 => 231864)

--- trunk/Source/WTF/wtf/DateMath.cpp	2018-05-16 19:39:30 UTC (rev 231863)
+++ trunk/Source/WTF/wtf/DateMath.cpp	2018-05-16 19:46:22 UTC (rev 231864)
@@ -1155,11 +1155,9 @@
 
 double timeClip(double t)
 {
-if (!std::isfinite(t))
+if (std::abs(t) > maxECMAScriptTime)
 return std::numeric_limits::quiet_NaN();
-if (fabs(t) > maxECMAScriptTime)
-return std::numeric_limits::quiet_NaN();
-return trunc(t) + 0.0;
+return std::trunc(t) + 0.0;
 }
 
 // See http://tools.ietf.org/html/rfc2822#section-3.3 for more information.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231868] releases/Apple

[mitz]

Title: [231868] releases/Apple








Revision 231868
Author m...@apple.com
Date 2018-05-16 13:46:07 -0700 (Wed, 16 May 2018)


Log Message
Added a tag for Safari Technology Preview release 56.

Added Paths

releases/Apple/Safari Technology Preview 56/
releases/Apple/Safari Technology Preview 56/ANGLE/
releases/Apple/Safari Technology Preview 56/_javascript_Core/
releases/Apple/Safari Technology Preview 56/WTF/
releases/Apple/Safari Technology Preview 56/WebCore/
releases/Apple/Safari Technology Preview 56/WebInspectorUI/
releases/Apple/Safari Technology Preview 56/WebKit/
releases/Apple/Safari Technology Preview 56/WebKitLegacy/
releases/Apple/Safari Technology Preview 56/bmalloc/
releases/Apple/Safari Technology Preview 56/libwebrtc/




Diff
Index: releases/Apple/Safari Technology Preview 56/ANGLE
===
--- tags/Safari-606.1.17.2.2/Source/ThirdParty/ANGLE	2018-05-16 20:38:32 UTC (rev 231867)
+++ releases/Apple/Safari Technology Preview 56/ANGLE	2018-05-16 20:46:07 UTC (rev 231868)

Property changes: releases/Apple/Safari Technology Preview 56/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 56/_javascript_Core
===
--- tags/Safari-606.1.17.2.2/Source/_javascript_Core	2018-05-16 20:38:32 UTC (rev 231867)
+++ releases/Apple/Safari Technology Preview 56/_javascript_Core	2018-05-16 20:46:07 UTC (rev 231868)

Property changes: releases/Apple/Safari Technology Preview 56/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 56/WTF
===
--- tags/Safari-606.1.17.2.2/Source/WTF	2018-05-16 20:38:32 UTC (rev 231867)
+++ releases/Apple/Safari Technology Preview 56/WTF	2018-05-16 20:46:07 UTC (rev 231868)

Property changes: releases/Apple/Safari Technology Preview 56/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 56/WebInspectorUI
===
--- tags/Safari-606.1.17.2.2/Source/WebInspectorUI	2018-05-16 20:38:32 UTC (rev 231867)
+++ releases/Apple/Safari Technology Preview 56/WebInspectorUI	2018-05-16 20:46:07 UTC (rev 231868)

Property changes: releases/Apple/Safari Technology Preview 56/WebInspectorUI



Added: svn:mergeinfo
+/trunk/Source/WebInspectorUI:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 56/bmalloc
===
--- tags/Safari-606.1.17.2.2/Source/bmalloc	2018-05-16 20:38:32 UTC (rev 231867)
+++ releases/Apple/Safari Technology Preview 56/bmalloc	2018-05-16 20:46:07 UTC (rev 231868)

Property changes: releases/Apple/Safari Technology Preview 56/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 56/libwebrtc
===
--- tags/Safari-606.1.17.2.2/Source/ThirdParty/libwebrtc	2018-05-16 20:38:32 UTC (rev 231867)
+++ releases/Apple/Safari Technology Preview 56/libwebrtc	2018-05-16 20:46:07 UTC (rev 231868)

Property changes: releases/Apple/Safari Technology Preview 56/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231885] branches/safari-606.1.17-branch/Source/WebCore

[bshafiei]

Title: [231885] branches/safari-606.1.17-branch/Source/WebCore








Revision 231885
Author bshaf...@apple.com
Date 2018-05-16 20:58:09 -0700 (Wed, 16 May 2018)


Log Message
Cherry-pick r231784. rdar://problem/3778

Unreviewed, fix the iOS build after r231779

Also address a minor in-person review comment by returning "extrazoom" instead of the empty string.

* page/DisabledAdaptations.cpp:
(WebCore::extraZoomModeAdaptationName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-606.1.17-branch/Source/WebCore/ChangeLog
branches/safari-606.1.17-branch/Source/WebCore/page/DisabledAdaptations.cpp




Diff

Modified: branches/safari-606.1.17-branch/Source/WebCore/ChangeLog (231884 => 231885)

--- branches/safari-606.1.17-branch/Source/WebCore/ChangeLog	2018-05-17 03:53:14 UTC (rev 231884)
+++ branches/safari-606.1.17-branch/Source/WebCore/ChangeLog	2018-05-17 03:58:09 UTC (rev 231885)
@@ -1,5 +1,27 @@
 2018-05-16  Babak Shafiei  
 
+Cherry-pick r231784. rdar://problem/3778
+
+Unreviewed, fix the iOS build after r231779
+
+Also address a minor in-person review comment by returning "extrazoom" instead of the empty string.
+
+* page/DisabledAdaptations.cpp:
+(WebCore::extraZoomModeAdaptationName):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-05-14  Wenson Hsieh  
+
+Unreviewed, fix the iOS build after r231779
+
+Also address a minor in-person review comment by returning "extrazoom" instead of the empty string.
+
+* page/DisabledAdaptations.cpp:
+(WebCore::extraZoomModeAdaptationName):
+
+2018-05-16  Babak Shafiei  
+
 Cherry-pick r231779. rdar://problem/3778
 
 [Extra zoom mode] Google search results are excessively zoomed in


Modified: branches/safari-606.1.17-branch/Source/WebCore/page/DisabledAdaptations.cpp (231884 => 231885)

--- branches/safari-606.1.17-branch/Source/WebCore/page/DisabledAdaptations.cpp	2018-05-17 03:53:14 UTC (rev 231884)
+++ branches/safari-606.1.17-branch/Source/WebCore/page/DisabledAdaptations.cpp	2018-05-17 03:58:09 UTC (rev 231885)
@@ -30,7 +30,7 @@
 
 namespace WebCore {
 
-#if USE(APPLE_INTERNAL_SDK)
+#if USE(APPLE_INTERNAL_SDK) && __has_include()
 
 #import 
 
@@ -38,7 +38,7 @@
 
 String extraZoomModeAdaptationName()
 {
-return emptyString();
+return ASCIILiteral("extrazoom");
 }
 
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231887] branches/safari-606.1.17-branch/Source/JavaScriptCore

[bshafiei]

Title: [231887] branches/safari-606.1.17-branch/Source/_javascript_Core








Revision 231887
Author bshaf...@apple.com
Date 2018-05-16 22:11:20 -0700 (Wed, 16 May 2018)


Log Message
Cherry-pick r231719. rdar://problem/40054982

Unreviewed, rolling out r231316 and r231332.
https://bugs.webkit.org/show_bug.cgi?id=185564

Appears to be a Speedometer2/MotionMark regression (Requested
by keith_miller on #webkit).

Reverted changesets:

"Remove the prototype caching for get_by_id in the LLInt"
https://bugs.webkit.org/show_bug.cgi?id=185226
https://trac.webkit.org/changeset/231316

"Unreviewed, fix 32-bit profile offset for change in bytecode"
https://trac.webkit.org/changeset/231332

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-606.1.17-branch/Source/_javascript_Core/CMakeLists.txt
branches/safari-606.1.17-branch/Source/_javascript_Core/ChangeLog
branches/safari-606.1.17-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
branches/safari-606.1.17-branch/Source/_javascript_Core/Sources.txt
branches/safari-606.1.17-branch/Source/_javascript_Core/bytecode/BytecodeDumper.cpp
branches/safari-606.1.17-branch/Source/_javascript_Core/bytecode/BytecodeList.json
branches/safari-606.1.17-branch/Source/_javascript_Core/bytecode/BytecodeUseDef.h
branches/safari-606.1.17-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp
branches/safari-606.1.17-branch/Source/_javascript_Core/bytecode/CodeBlock.h
branches/safari-606.1.17-branch/Source/_javascript_Core/bytecode/GetByIdStatus.cpp
branches/safari-606.1.17-branch/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
branches/safari-606.1.17-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
branches/safari-606.1.17-branch/Source/_javascript_Core/dfg/DFGCapabilities.cpp
branches/safari-606.1.17-branch/Source/_javascript_Core/jit/JIT.cpp
branches/safari-606.1.17-branch/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
branches/safari-606.1.17-branch/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
branches/safari-606.1.17-branch/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
branches/safari-606.1.17-branch/Source/_javascript_Core/runtime/Options.h


Added Paths

branches/safari-606.1.17-branch/Source/_javascript_Core/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp
branches/safari-606.1.17-branch/Source/_javascript_Core/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h




Diff

Modified: branches/safari-606.1.17-branch/Source/_javascript_Core/CMakeLists.txt (231886 => 231887)

--- branches/safari-606.1.17-branch/Source/_javascript_Core/CMakeLists.txt	2018-05-17 04:27:28 UTC (rev 231886)
+++ branches/safari-606.1.17-branch/Source/_javascript_Core/CMakeLists.txt	2018-05-17 05:11:20 UTC (rev 231887)
@@ -455,6 +455,7 @@
 bytecode/InternalFunctionAllocationProfile.h
 bytecode/JumpTable.h
 bytecode/LLIntCallLinkInfo.h
+bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h
 bytecode/LazyOperandValueProfile.h
 bytecode/ObjectAllocationProfile.h
 bytecode/ObjectPropertyCondition.h


Modified: branches/safari-606.1.17-branch/Source/_javascript_Core/ChangeLog (231886 => 231887)

--- branches/safari-606.1.17-branch/Source/_javascript_Core/ChangeLog	2018-05-17 04:27:28 UTC (rev 231886)
+++ branches/safari-606.1.17-branch/Source/_javascript_Core/ChangeLog	2018-05-17 05:11:20 UTC (rev 231887)
@@ -1,3 +1,41 @@
+2018-05-16  Babak Shafiei  
+
+Cherry-pick r231719. rdar://problem/40054982
+
+Unreviewed, rolling out r231316 and r231332.
+https://bugs.webkit.org/show_bug.cgi?id=185564
+
+Appears to be a Speedometer2/MotionMark regression (Requested
+by keith_miller on #webkit).
+
+Reverted changesets:
+
+"Remove the prototype caching for get_by_id in the LLInt"
+https://bugs.webkit.org/show_bug.cgi?id=185226
+https://trac.webkit.org/changeset/231316
+
+"Unreviewed, fix 32-bit profile offset for change in bytecode"
+https://trac.webkit.org/changeset/231332
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-05-11  Commit Queue  
+
+Unreviewed, rolling out r231316 and r231332.
+https://bugs.webkit.org/show_bug.cgi?id=185564
+
+Appears to be a Speedometer2/MotionMark regression (Requested
+by keith_miller on #webkit).
+
+Reverted changesets:
+
+"Remove the prototype caching for get_by_id in the LLInt"
+https://bugs.webkit.org/show_bug.cgi?id=185226
+https://trac.webkit.org/changeset/231316
+
+"Unreviewed, fix 32-bit profile offset for change in bytecode"
+https://trac.webkit.org/changeset/231332
+
 2018-05-09  Kocsen Chung  
 
 

[webkit-changes] [231884] branches/safari-606.1.17-branch

[bshafiei]

Title: [231884] branches/safari-606.1.17-branch








Revision 231884
Author bshaf...@apple.com
Date 2018-05-16 20:53:14 -0700 (Wed, 16 May 2018)


Log Message
Cherry-pick r231779. rdar://problem/3778

[Extra zoom mode] Google search results are excessively zoomed in
https://bugs.webkit.org/show_bug.cgi?id=185347


Reviewed by Tim Horton.

Source/WebCore:

It turns out that basing minimum layout size and shrink-to-fit behaviors off of the `shrink-to-fit` viewport
argument poses compatibility risks with web pages that already specify `shrink-to-fit` to opt out of default
viewport shrinking behaviors in 1/3 multitasking mode on iPad.

One way to resolve this is to introduce a new viewport meta content attribute to disable viewport heuristics in
extra zoom mode. However, combined shrink-to-fit and minimum device width behaviors are difficult to describe
using a single backwards-compatible viewport meta content attribute, and the need to suppress the default
behavior of `shrink-to-fit=no` if such an attribute is not disabled further muddles our viewport story.

After some internal deliberation, we’ve decided to experiment with a new meta tag named "disabled-adaptations".
The content of this meta tag is a comma-separated list of adaptation names; if an adaptation name matches a
known adaptation type (for instance, extra zoom mode), we disable the class of behaviors used to adapt web
content. The first and only known adaptation type is extra zoom mode, which affects `shrink-to-fit` and layout
size adjustments.

See per-method changes below for more details.

Test: fast/viewport/extrazoom/viewport-disable-extra-zoom-adaptations.html

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::processDisabledAdaptations):
* dom/Document.h:
(WebCore::Document::disabledAdaptations const):

Add disabled adaptations to Document. Changes to disabled adaptations are not propagated if the parsed disabled
adaptation types don't change; upon changing adaptation types, notify the client to adjust for the new disabled
adaptations (currently, this only affects the viewport configuration).

* dom/ViewportArguments.h:
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::process):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):

Restore the set of disabled adaptations when restoring a page from the cache.

* page/Chrome.cpp:
(WebCore::Chrome::dispatchDisabledAdaptationsDidChange const):
* page/Chrome.h:
* page/ChromeClient.h:

Add plumbing for changes to the set of disabled adaptations.

* page/DisabledAdaptations.cpp: Added.
(WebCore::extraZoomModeAdaptationName):
* page/DisabledAdaptations.h: Added.

Introduce a header containing a new enum for the extra zoom mode adaptation, as well as a helper function to
return the extra zoom mode adaptation name.

* page/Page.cpp:
(WebCore::Page::disabledAdaptations const):

Returns the mainframe's set of adaptations to disable.

* page/Page.h:
* page/RemoteFrame.h:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setDisabledAdaptationsMetaTagEnabled):
(WebCore::RuntimeEnabledFeatures::disabledAdaptationsMetaTagEnabled const):

Add a new runtime feature to gate handling the "disabled-adaptations" meta tag.

* page/ViewportConfiguration.cpp:
(WebCore::shouldOverrideShrinkToFitArgument):
(WebCore::needsUpdateAfterChangingDisabledAdaptations):
(WebCore::ViewportConfiguration::setDisabledAdaptations):
(WebCore::ViewportConfiguration::shouldOverrideDeviceWidthAndShrinkToFit const):

Consult whether or not extra zoom mode adaptations are disabled, instead of the shrink-to-fit attribute value.

(WebCore::ViewportConfiguration::updateConfiguration):
* page/ViewportConfiguration.h:

Add an OptionSet of disabled adaptation types to ViewportConfiguration. Updates to the adaptation type are
propagated to the ViewportConfiguration from Document, through the ChromeClient and the client layer (refer to
changes in WebKit). Once the OptionSet is changed, we recompute the viewport configuration only if needed by the
platform.

(WebCore::ViewportConfiguration::viewLayoutSize const):
(WebCore::ViewportConfiguration::disabledAdaptations const):
* page/WindowFeatures.cpp:
(WebCore::parseDisabledAdaptations):
* page/WindowFeatures.h:

Add a new helper to parse the meta content of a "disabled-adaptations" tag as an OptionSet of disabled
adaptation types. The string is parsed by first splitting on 

[webkit-changes] [231889] trunk/Source/JavaScriptCore

[sbarati]

Title: [231889] trunk/Source/_javascript_Core








Revision 231889
Author sbar...@apple.com
Date 2018-05-16 22:21:41 -0700 (Wed, 16 May 2018)


Log Message
UnlinkedFunctionExecutable doesn't need a parent source override field since it's only used for default class constructors
https://bugs.webkit.org/show_bug.cgi?id=185637

Reviewed by Keith Miller.

We had this general mechanism for overriding an UnlinkedFunctionExecutable's parent
source code. However, we were only using this for default class constructors. There
are only two types of default class constructors. This patch makes it so that
we just store this information inside of a single bit, and ask for the source
code as needed instead of holding it in a nullable field that is 24 bytes in size.

This brings UnlinkedFunctionExecutable's size down from 184 bytes to 160 bytes.
This has the consequence of making it allocated out of a 160 byte size class
instead of a 224 byte size class. This should bring down its memory footprint
by ~40%.

* builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::defaultConstructorSourceCode):
(JSC::BuiltinExecutables::createDefaultConstructor):
(JSC::BuiltinExecutables::createExecutable):
* builtins/BuiltinExecutables.h:
* bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::UnlinkedFunctionExecutable::link):
* bytecode/UnlinkedFunctionExecutable.h:
* runtime/CodeCache.cpp:
(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/builtins/BuiltinExecutables.cpp
trunk/Source/_javascript_Core/builtins/BuiltinExecutables.h
trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.cpp
trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.h
trunk/Source/_javascript_Core/runtime/CodeCache.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (231888 => 231889)

--- trunk/Source/_javascript_Core/ChangeLog	2018-05-17 05:21:22 UTC (rev 231888)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-05-17 05:21:41 UTC (rev 231889)
@@ -1,5 +1,35 @@
 2018-05-16  Saam Barati  
 
+UnlinkedFunctionExecutable doesn't need a parent source override field since it's only used for default class constructors
+https://bugs.webkit.org/show_bug.cgi?id=185637
+
+Reviewed by Keith Miller.
+
+We had this general mechanism for overriding an UnlinkedFunctionExecutable's parent
+source code. However, we were only using this for default class constructors. There
+are only two types of default class constructors. This patch makes it so that
+we just store this information inside of a single bit, and ask for the source
+code as needed instead of holding it in a nullable field that is 24 bytes in size.
+
+This brings UnlinkedFunctionExecutable's size down from 184 bytes to 160 bytes.
+This has the consequence of making it allocated out of a 160 byte size class
+instead of a 224 byte size class. This should bring down its memory footprint
+by ~40%.
+
+* builtins/BuiltinExecutables.cpp:
+(JSC::BuiltinExecutables::defaultConstructorSourceCode):
+(JSC::BuiltinExecutables::createDefaultConstructor):
+(JSC::BuiltinExecutables::createExecutable):
+* builtins/BuiltinExecutables.h:
+* bytecode/UnlinkedFunctionExecutable.cpp:
+(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
+(JSC::UnlinkedFunctionExecutable::link):
+* bytecode/UnlinkedFunctionExecutable.h:
+* runtime/CodeCache.cpp:
+(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):
+
+2018-05-16  Saam Barati  
+
 VM::shrinkFootprint should call collectNow(Sync) instead of collectSync so it also eagerly sweeps
 https://bugs.webkit.org/show_bug.cgi?id=185707
 


Modified: trunk/Source/_javascript_Core/builtins/BuiltinExecutables.cpp (231888 => 231889)

--- trunk/Source/_javascript_Core/builtins/BuiltinExecutables.cpp	2018-05-17 05:21:22 UTC (rev 231888)
+++ trunk/Source/_javascript_Core/builtins/BuiltinExecutables.cpp	2018-05-17 05:21:41 UTC (rev 231889)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2014-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2014-2018 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -42,18 +42,41 @@
 {
 }
 
+const SourceCode& BuiltinExecutables::defaultConstructorSourceCode(ConstructorKind constructorKind)
+{
+switch (constructorKind) {
+case ConstructorKind::None:
+RELEASE_ASSERT_NOT_REACHED();
+case ConstructorKind::Base: {
+static NeverDestroyed baseConstructorCode(MAKE_STATIC_STRING_IMPL("(function () { })"));
+static LazyNeverDestroyed result;
+static std::once_flag onceFlag;
+  

[webkit-changes] [231888] trunk/Source/JavaScriptCore

[sbarati]

Title: [231888] trunk/Source/_javascript_Core








Revision 231888
Author sbar...@apple.com
Date 2018-05-16 22:21:22 -0700 (Wed, 16 May 2018)


Log Message
VM::shrinkFootprint should call collectNow(Sync) instead of collectSync so it also eagerly sweeps
https://bugs.webkit.org/show_bug.cgi?id=185707

Reviewed by Mark Lam.

* runtime/VM.cpp:
(JSC::VM::shrinkFootprint):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/VM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (231887 => 231888)

--- trunk/Source/_javascript_Core/ChangeLog	2018-05-17 05:11:20 UTC (rev 231887)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-05-17 05:21:22 UTC (rev 231888)
@@ -1,3 +1,13 @@
+2018-05-16  Saam Barati  
+
+VM::shrinkFootprint should call collectNow(Sync) instead of collectSync so it also eagerly sweeps
+https://bugs.webkit.org/show_bug.cgi?id=185707
+
+Reviewed by Mark Lam.
+
+* runtime/VM.cpp:
+(JSC::VM::shrinkFootprint):
+
 2018-05-16  Caio Lima  
 
 [ESNext][BigInt] Implement support for "/" operation


Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (231887 => 231888)

--- trunk/Source/_javascript_Core/runtime/VM.cpp	2018-05-17 05:11:20 UTC (rev 231887)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp	2018-05-17 05:21:22 UTC (rev 231888)
@@ -778,7 +778,7 @@
 {
 sanitizeStackForVM(this);
 deleteAllCode(DeleteAllCodeIfNotCollecting);
-heap.collectSync();
+heap.collectNow(Synchronousness::Sync);
 WTF::releaseFastMallocFreeMemory();
 // FIXME: Consider stopping various automatic threads here.
 // https://bugs.webkit.org/show_bug.cgi?id=185447






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes