[webkit-changes] [236712] trunk/Tools
Title: [236712] trunk/Tools
Revision 236712
Author ross.kirsl...@sony.com
Date 2018-10-01 22:24:44 -0700 (Mon, 01 Oct 2018)
Log Message
[Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
https://bugs.webkit.org/show_bug.cgi?id=190150
Reviewed by Fujii Hironori.
* DumpRenderTree/win/DumpRenderTree.cpp:
(setWebPreferencesForTestOptions):
DRT has been recognizing this field, but not propagating its value to WebPreferences.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp
Diff
Modified: trunk/Tools/ChangeLog (236711 => 236712)
--- trunk/Tools/ChangeLog 2018-10-02 04:58:52 UTC (rev 236711)
+++ trunk/Tools/ChangeLog 2018-10-02 05:24:44 UTC (rev 236712)
@@ -1,3 +1,14 @@
+2018-10-01 Ross Kirsling
+
+[Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
+https://bugs.webkit.org/show_bug.cgi?id=190150
+
+Reviewed by Fujii Hironori.
+
+* DumpRenderTree/win/DumpRenderTree.cpp:
+(setWebPreferencesForTestOptions):
+DRT has been recognizing this field, but not propagating its value to WebPreferences.
+
2018-10-01 Alex Christensen
Unreviewed, rolling out r236551.
Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (236711 => 236712)
--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2018-10-02 04:58:52 UTC (rev 236711)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2018-10-02 05:24:44 UTC (rev 236712)
@@ -895,6 +895,7 @@
{
COMPtr prefsPrivate { Query, preferences };
+prefsPrivate->setWebAnimationsCSSIntegrationEnabled(options.enableWebAnimationsCSSIntegration);
prefsPrivate->setMenuItemElementEnabled(options.enableMenuItemElement);
prefsPrivate->setModernMediaControlsEnabled(options.enableModernMediaControls);
prefsPrivate->setIsSecureContextAttributeEnabled(options.enableIsSecureContextAttribute);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236711] trunk/LayoutTests
Title: [236711] trunk/LayoutTests Revision 236711 Author ross.kirsl...@sony.com Date 2018-10-01 21:58:52 -0700 (Mon, 01 Oct 2018) Log Message [WinCairo] Unreviewed test gardening. * platform/wincairo/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wincairo/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (236710 => 236711) --- trunk/LayoutTests/ChangeLog 2018-10-02 03:29:56 UTC (rev 236710) +++ trunk/LayoutTests/ChangeLog 2018-10-02 04:58:52 UTC (rev 236711) @@ -1,3 +1,9 @@ +2018-10-01 Ross Kirsling + +[WinCairo] Unreviewed test gardening. + +* platform/wincairo/TestExpectations: + 2018-10-01 Ryosuke Niwa Removed a failing test expectation on imported/w3c/web-platform-tests/shadow-dom/slotchange.html Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (236710 => 236711) --- trunk/LayoutTests/platform/wincairo/TestExpectations 2018-10-02 03:29:56 UTC (rev 236710) +++ trunk/LayoutTests/platform/wincairo/TestExpectations 2018-10-02 04:58:52 UTC (rev 236711) @@ -851,11 +851,13 @@ http/tests/contentdispositionattachmentsandbox [ Skip ] http/tests/contentfiltering [ Skip ] -http/tests/cookies/same-site [ Skip ] +http/tests/cookies/cookie-with-multiple-level-path.html [ Pass Failure ] http/tests/cookies/double-quoted-value-with-semi-colon.html [ Failure ] +http/tests/cookies/http-get-cookie-set-in-js.html [ Pass Failure ] http/tests/cookies/multiple-cookies.html [ Pass Failure ] http/tests/cookies/multiple-redirect-and-set-cookie.php [ Pass Failure ] http/tests/cookies/private-cookie-storage.html [ Skip ] +http/tests/cookies/same-site [ Skip ] http/tests/cookies/set-cookie-on-redirect.html [ Pass Failure ] http/tests/cookies/simple-cookies-expired.html [ Pass Failure ] http/tests/cookies/simple-cookies-max-age.html [ Pass Failure ] @@ -876,7 +878,7 @@ http/tests/frame-throttling [ Skip ] http/tests/globalhistory/history-delegate-basic-refresh-redirect.html [ Failure ] -http/tests/globalhistory/history-delegate-basic-visited-links.html [ Failure ] +http/tests/globalhistory/history-delegate-basic-visited-links.html [ Pass Failure ] http/tests/history [ Skip ] http/tests/images [ Skip ] @@ -892,7 +894,6 @@ # need to implement content sniffing http/tests/mime/mime-type-sniff.html [ Skip ] -http/tests/misc/acid3.html [ Failure ] http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html [ Failure ] http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html [ Failure ] http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url.html [ Failure ] @@ -899,14 +900,19 @@ http/tests/misc/favicon-loads-with-icon-loading-override.html [ Failure ] http/tests/misc/link-rel-icon-beforeload.html [ Failure ] http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml [ Failure ] -http/tests/misc/redirect-to-external-url.html [ Failure ] http/tests/misc/slow-loading-animated-image.html [ ImageOnlyFailure ] -http/tests/misc/submit-post-keygen.html [ Timeout ] -http/tests/misc/timer-vs-loading.html [ Timeout ] +http/tests/misc/submit-post-keygen.html [ Skip ] +http/tests/misc/timer-vs-loading.html [ Skip ] http/tests/misc/willCacheResponse-delegate-callback.html [ Failure ] +[ Release ] http/tests/misc/acid3.html [ Failure ] +[ Release ] http/tests/misc/redirect-to-external-url.html [ Failure ] [ Release ] http/tests/multipart/load-last-non-html-frame.php [ Failure ] [ Release ] http/tests/multipart/multipart-replace-non-html-content.php [ Failure ] +[ Debug ] http/tests/misc/acid3.html [ Skip ] +[ Debug ] http/tests/misc/large-js-program.php [ Skip ] +[ Debug ] http/tests/misc/redirect-to-about-blank.html [ Skip ] +[ Debug ] http/tests/misc/redirect-to-external-url.html [ Skip ] [ Debug ] http/tests/multipart [ Skip ] http/tests/navigation [ Skip ] @@ -931,7 +937,10 @@ http/tests/websocket/tests/hybi/contentextensions/block-cookies.php [ Pass Failure ] http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.php [ Pass Failure ] http/tests/websocket/tests/hybi/deflate-frame-parameter.html [ Failure ] +http/tests/websocket/tests/hybi/httponly-cookie.pl [ Pass Failure ] http/tests/websocket/tests/hybi/inspector [ Skip ] +http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl [ Pass Failure ] +http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl [ Pass Failure ] http/tests/websocket/tests/hybi/upgrade-simple-ws.html [ Pass Failure ] http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party.html [ Pass Failure ] http/tests/websocket/tests/hybi/websocket-blocked-from-setting-cookie-as-third-party.html [ Pass Failure ] @@ -956,6 +965,7 @@ http/tests/xmlhttprequest/basic-auth-nopassword.html [ Failure ] http/tests/xmlhttprequest/cache-override.html [ Pass Failure ]
[webkit-changes] [236710] trunk/LayoutTests
Title: [236710] trunk/LayoutTests Revision 236710 Author rn...@webkit.org Date 2018-10-01 20:29:56 -0700 (Mon, 01 Oct 2018) Log Message Removed a failing test expectation on imported/w3c/web-platform-tests/shadow-dom/slotchange.html since we haven't seen a single failure after the fix in r236440. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (236709 => 236710) --- trunk/LayoutTests/ChangeLog 2018-10-02 02:27:11 UTC (rev 236709) +++ trunk/LayoutTests/ChangeLog 2018-10-02 03:29:56 UTC (rev 236710) @@ -1,3 +1,10 @@ +2018-10-01 Ryosuke Niwa + +Removed a failing test expectation on imported/w3c/web-platform-tests/shadow-dom/slotchange.html +since we haven't seen a single failure after the fix in r236440. + +* platform/mac/TestExpectations: + 2018-10-01 Myles C. Maxfield [Cocoa] Update delete-emoji expected results Modified: trunk/LayoutTests/platform/mac/TestExpectations (236709 => 236710) --- trunk/LayoutTests/platform/mac/TestExpectations 2018-10-02 02:27:11 UTC (rev 236709) +++ trunk/LayoutTests/platform/mac/TestExpectations 2018-10-02 03:29:56 UTC (rev 236710) @@ -1326,8 +1326,6 @@ webkit.org/b/162507 http/tests/media/hls/hls-video-resize.html [ Pass Failure ] -webkit.org/b/167642 imported/w3c/web-platform-tests/shadow-dom/slotchange.html [ Pass Failure ] - webkit.org/b/167749 http/tests/media/track-in-band-hls-metadata-crash.html [ Pass Timeout ] webkit.org/b/167186 fast/backgrounds/hidpi-bitmap-background-on-subpixel-position.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236709] trunk/Source
Title: [236709] trunk/Source
Revision 236709
Author drou...@apple.com
Date 2018-10-01 19:27:11 -0700 (Mon, 01 Oct 2018)
Log Message
Web Inspector: remove analyzer manager
https://bugs.webkit.org/show_bug.cgi?id=190162
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
* UserInterface/Main.html:
* UserInterface/Base/Main.js:
(WI.loaded):
* UserInterface/Controllers/AnalyzerManager.js: Removed.
* UserInterface/Models/AnalyzerMessage.js: Removed.
* Scripts/copy-user-interface-resources.pl:
* UserInterface/External/ESLint/LICENSE: Removed.
* UserInterface/External/ESLint/eslint.js: Removed.
Source/WebKit:
* InspectorGResources.cmake:
Remove eslint.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Main.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/InspectorGResources.cmake
Removed Paths
trunk/Source/WebInspectorUI/UserInterface/Controllers/AnalyzerManager.js
trunk/Source/WebInspectorUI/UserInterface/External/ESLint/
trunk/Source/WebInspectorUI/UserInterface/Models/AnalyzerMessage.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236708 => 236709)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-02 02:15:02 UTC (rev 236708)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-02 02:27:11 UTC (rev 236709)
@@ -1,3 +1,21 @@
+2018-10-01 Devin Rousso
+
+Web Inspector: remove analyzer manager
+https://bugs.webkit.org/show_bug.cgi?id=190162
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Main.html:
+* UserInterface/Base/Main.js:
+(WI.loaded):
+
+* UserInterface/Controllers/AnalyzerManager.js: Removed.
+* UserInterface/Models/AnalyzerMessage.js: Removed.
+
+* Scripts/copy-user-interface-resources.pl:
+* UserInterface/External/ESLint/LICENSE: Removed.
+* UserInterface/External/ESLint/eslint.js: Removed.
+
2018-10-01 Nikita Vasilyev
Web Inspector: Styles: add an experimental setting for multi-property selection
Modified: trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl (236708 => 236709)
--- trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl 2018-10-02 02:15:02 UTC (rev 236708)
+++ trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl 2018-10-02 02:27:11 UTC (rev 236709)
@@ -165,7 +165,6 @@
my $workersDir = File::Spec->catdir($targetResourcePath, 'Workers');
my $codeMirrorPath = File::Spec->catdir($uiRoot, 'External', 'CodeMirror');
my $esprimaPath = File::Spec->catdir($uiRoot, 'External', 'Esprima');
-my $eslintPath = File::Spec->catdir($uiRoot, 'External', 'ESLint');
my $threejsPath = File::Spec->catdir($uiRoot, 'External', 'three.js');
$webInspectorUIAdditionsDir = ();
@@ -172,7 +171,6 @@
my $codeMirrorLicense = readLicenseFile(File::Spec->catfile($codeMirrorPath, 'LICENSE'));
my $esprimaLicense = readLicenseFile(File::Spec->catfile($esprimaPath, 'LICENSE'));
-my $eslintLicense = readLicenseFile(File::Spec->catfile($eslintPath, 'LICENSE'));
my $threejsLicense = readLicenseFile(File::Spec->catfile($threejsPath, 'LICENSE'));
make_path($protocolDir, $targetResourcePath);
@@ -318,15 +316,6 @@
'--output-dir', $derivedSourcesDir,
'--output-script-name', 'Esprima.js');
-# Combine the ESLint _javascript_ files in Production builds into a single file (ESLint.js).
-system($perl, $combineResourcesCmd,
- '--input-dir', 'External/ESLint',
- '--input-html', $derivedSourcesMainHTML,
- '--input-html-dir', $uiRoot,
- '--derived-sources-dir', $derivedSourcesDir,
- '--output-dir', $derivedSourcesDir,
- '--output-script-name', 'ESLint.js');
-
# Combine the three.js _javascript_ files in Production builds into a single file (Three.js).
system($perl, $combineResourcesCmd,
'--input-dir', 'External/three.js',
@@ -372,10 +361,6 @@
my $targetEsprimaJS = File::Spec->catfile($targetResourcePath, 'Esprima.js');
seedFile($targetEsprimaJS, $esprimaLicense);
-# Export the license into ESLint.js.
-my $targetESLintJS = File::Spec->catfile($targetResourcePath, 'ESLint.js');
-seedFile($targetESLintJS, $eslintLicense);
-
# Export the license into Three.js.
my $targetThreejsJS = File::Spec->catfile($targetResourcePath, 'Three.js');
seedFile($targetThreejsJS, $threejsLicense);
@@ -396,10 +381,6 @@
my $derivedSourcesEsprimaJS = File::Spec->catfile($derivedSourcesDir, 'Esprima.js');
system(qq("$python" "$jsMinScript" < "$derivedSourcesEsprimaJS" >> "$targetEsprimaJS")) and die "Failed to minify $derivedSourcesEsprimaJS: $!";
-# Minify the ESLint.js file, appending to the license that was exported above.
-my $derivedSourcesESLintJS = File::Spec->catfile($derivedSourcesDir, 'ESLint.js');
-system(qq("$python" "$jsMinScript" <
[webkit-changes] [236708] trunk/LayoutTests
Title: [236708] trunk/LayoutTests Revision 236708 Author mmaxfi...@apple.com Date 2018-10-01 19:15:02 -0700 (Mon, 01 Oct 2018) Log Message [Cocoa] Update delete-emoji expected results https://bugs.webkit.org/show_bug.cgi?id=190182 Unreviewed. Simply update the expected results. * platform/mac-highsierra/editing/deleting/delete-emoji-1-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-emoji-1-expected.txt. * platform/mac-highsierra/editing/deleting/delete-emoji-9-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-emoji-9-expected.txt. * platform/mac-highsierra/editing/deleting/delete-emoji-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-emoji-expected.txt. * platform/mac/TestExpectations: * platform/mac/editing/deleting/delete-emoji-1-expected.txt: * platform/mac/editing/deleting/delete-emoji-9-expected.txt: * platform/mac/editing/deleting/delete-emoji-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac/editing/deleting/delete-emoji-1-expected.txt trunk/LayoutTests/platform/mac/editing/deleting/delete-emoji-9-expected.txt trunk/LayoutTests/platform/mac/editing/deleting/delete-emoji-expected.txt Added Paths trunk/LayoutTests/platform/mac-highsierra/editing/deleting/ trunk/LayoutTests/platform/mac-highsierra/editing/deleting/delete-emoji-1-expected.txt trunk/LayoutTests/platform/mac-highsierra/editing/deleting/delete-emoji-9-expected.txt trunk/LayoutTests/platform/mac-highsierra/editing/deleting/delete-emoji-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (236707 => 236708) --- trunk/LayoutTests/ChangeLog 2018-10-02 01:59:52 UTC (rev 236707) +++ trunk/LayoutTests/ChangeLog 2018-10-02 02:15:02 UTC (rev 236708) @@ -1,3 +1,20 @@ +2018-10-01 Myles C. Maxfield + +[Cocoa] Update delete-emoji expected results +https://bugs.webkit.org/show_bug.cgi?id=190182 + +Unreviewed. + +Simply update the expected results. + +* platform/mac-highsierra/editing/deleting/delete-emoji-1-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-emoji-1-expected.txt. +* platform/mac-highsierra/editing/deleting/delete-emoji-9-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-emoji-9-expected.txt. +* platform/mac-highsierra/editing/deleting/delete-emoji-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-emoji-expected.txt. +* platform/mac/TestExpectations: +* platform/mac/editing/deleting/delete-emoji-1-expected.txt: +* platform/mac/editing/deleting/delete-emoji-9-expected.txt: +* platform/mac/editing/deleting/delete-emoji-expected.txt: + 2018-10-01 Ryosuke Niwa Add a new variant of serializePreservingVisualAppearance which takes VisibleSelection Modified: trunk/LayoutTests/platform/mac/TestExpectations (236707 => 236708) --- trunk/LayoutTests/platform/mac/TestExpectations 2018-10-02 01:59:52 UTC (rev 236707) +++ trunk/LayoutTests/platform/mac/TestExpectations 2018-10-02 02:15:02 UTC (rev 236708) @@ -1774,3 +1774,7 @@ webgl/2.0.0/conformance/rendering/multisample-corruption.html [ Slow ] webgl/2.0.0/conformance2/attribs/gl-vertexattribipointer.html [ Slow ] webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format.html [ Slow ] + +[ Mojave+ ] editing/deleting/delete-emoji-1.html [ Failure ] +[ Mojave+ ] editing/deleting/delete-emoji-9.html [ Failure ] +[ Mojave+ ] editing/deleting/delete-emoji.html [ Failure ] Modified: trunk/LayoutTests/platform/mac/editing/deleting/delete-emoji-1-expected.txt (236707 => 236708) --- trunk/LayoutTests/platform/mac/editing/deleting/delete-emoji-1-expected.txt 2018-10-02 01:59:52 UTC (rev 236707) +++ trunk/LayoutTests/platform/mac/editing/deleting/delete-emoji-1-expected.txt 2018-10-02 02:15:02 UTC (rev 236708) @@ -51,12 +51,8 @@ Dump of markup 13: | " -☝️<#selection-caret>" +<#selection-caret>" Dump of markup 14: -| " -<#selection-caret>" - -Dump of markup 15: | <#selection-caret> | Modified: trunk/LayoutTests/platform/mac/editing/deleting/delete-emoji-9-expected.txt (236707 => 236708) --- trunk/LayoutTests/platform/mac/editing/deleting/delete-emoji-9-expected.txt 2018-10-02 01:59:52 UTC (rev 236707) +++ trunk/LayoutTests/platform/mac/editing/deleting/delete-emoji-9-expected.txt 2018-10-02 02:15:02 UTC (rev 236708) @@ -19,44 +19,32 @@ Dump of markup 5: | " -酪⚕️⚕️⚕⚕️️️<#selection-caret>" +酪⚕️⚕️⚕⚕️️<#selection-caret>" Dump of markup 6: | " -酪⚕️⚕️⚕⚕️️<#selection-caret>" +酪⚕️⚕️⚕⚕️<#selection-caret>" Dump of markup 7: | " -酪⚕️⚕️⚕⚕️️<#selection-caret>" +酪⚕️⚕️⚕⚕<#selection-caret>" Dump of markup 8: | " -酪⚕️⚕️⚕⚕️<#selection-caret>" +酪⚕️⚕️⚕<#selection-caret>" Dump of markup 9: | "
[webkit-changes] [236707] trunk
Title: [236707] trunk Revision 236707 Author rn...@webkit.org Date 2018-10-01 18:59:52 -0700 (Mon, 01 Oct 2018) Log Message Add a new variant of serializePreservingVisualAppearance which takes VisibleSelection https://bugs.webkit.org/show_bug.cgi?id=190108 Reviewed by Wenson Hsieh. Source/WebCore: Added a version of serializePreservingVisualAppearance which takes VisibleSelection so that we can avoid creating a range simply to get the first node and the end node of the selection later. This simple change also fixes a bug demonstrated in editing/pasteboard/paste-table-003.html. Test: editing/pasteboard/paste-table-003.html * editing/cocoa/EditorCocoa.mm: (WebCore::Editor::selectionInHTMLFormat): Adopt the new variant. * editing/gtk/EditorGtk.cpp: (WebCore::Editor::writeSelectionToPasteboard): Ditto. * editing/markup.cpp: (WebCore::serializePreservingVisualAppearance): Added. * editing/markup.h: * editing/wpe/EditorWPE.cpp: (WebCore::Editor::writeSelectionToPasteboard): Ditto. * loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createFromSelection): Ditto. * platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): Ditto. Source/WebKit: Adopt the new variant which directly takes VisibleSelection. * WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp: (WebKit::WebEditorClient::updateGlobalSelection): LayoutTests: Rebaselined the test since the bug that interchange new lines are inserted in the last table cell is fixed. Also updated the description in the test to reflect this change. * editing/pasteboard/paste-table-003-expected.txt: * editing/pasteboard/paste-table-003.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/editing/pasteboard/paste-table-003-expected.txt trunk/LayoutTests/editing/pasteboard/paste-table-003.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/cocoa/EditorCocoa.mm trunk/Source/WebCore/editing/gtk/EditorGtk.cpp trunk/Source/WebCore/editing/markup.cpp trunk/Source/WebCore/editing/markup.h trunk/Source/WebCore/editing/wpe/EditorWPE.cpp trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp trunk/Source/WebCore/platform/win/PasteboardWin.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp Diff Modified: trunk/LayoutTests/ChangeLog (236706 => 236707) --- trunk/LayoutTests/ChangeLog 2018-10-02 01:37:43 UTC (rev 236706) +++ trunk/LayoutTests/ChangeLog 2018-10-02 01:59:52 UTC (rev 236707) @@ -1,3 +1,16 @@ +2018-10-01 Ryosuke Niwa + +Add a new variant of serializePreservingVisualAppearance which takes VisibleSelection +https://bugs.webkit.org/show_bug.cgi?id=190108 + +Reviewed by Wenson Hsieh. + +Rebaselined the test since the bug that interchange new lines are inserted in the last table cell is fixed. +Also updated the description in the test to reflect this change. + +* editing/pasteboard/paste-table-003-expected.txt: +* editing/pasteboard/paste-table-003.html: + 2018-10-01 Ryan Haddad Unreviewed, rebaseline tests after r236632. Modified: trunk/LayoutTests/editing/pasteboard/paste-table-003-expected.txt (236706 => 236707) --- trunk/LayoutTests/editing/pasteboard/paste-table-003-expected.txt 2018-10-02 01:37:43 UTC (rev 236706) +++ trunk/LayoutTests/editing/pasteboard/paste-table-003-expected.txt 2018-10-02 01:59:52 UTC (rev 236707) @@ -5,13 +5,13 @@ EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 0 of #text > DIV > DIV > BODY > HTML > #document to 9 of #text > DIV > DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document toDOMRange:range from 2 of TD > TR > TBODY > TABLE > DIV > DIV > BODY > HTML > #document to 2 of TD > TR > TBODY > TABLE > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE +EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document toDOMRange:range from 3 of #text > TD > TR > TBODY > TABLE > DIV > DIV > BODY > HTML > #document to 3 of #text > TD > TR > TBODY > TABLE > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -This tests pasting a table to replace some text. It demonstrates two bugs: 1) selecting a table without also selecting the line break after programmatically is impossible when its followed by a div because of the way DOM positions are mapped to visible positions, 2)
[webkit-changes] [236706] trunk/Source/WebInspectorUI
Title: [236706] trunk/Source/WebInspectorUI
Revision 236706
Author nvasil...@apple.com
Date 2018-10-01 18:37:43 -0700 (Mon, 01 Oct 2018)
Log Message
Web Inspector: Styles: add an experimental setting for multi-property selection
https://bugs.webkit.org/show_bug.cgi?id=190053
Reviewed by Matt Baker.
This patch only adds a setting. It doesn't change property selection behavior.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Setting.js:
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js
trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236705 => 236706)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-02 01:31:37 UTC (rev 236705)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-02 01:37:43 UTC (rev 236706)
@@ -1,5 +1,20 @@
2018-10-01 Nikita Vasilyev
+Web Inspector: Styles: add an experimental setting for multi-property selection
+https://bugs.webkit.org/show_bug.cgi?id=190053
+
+
+Reviewed by Matt Baker.
+
+This patch only adds a setting. It doesn't change property selection behavior.
+
+* Localizations/en.lproj/localizedStrings.js:
+* UserInterface/Base/Setting.js:
+* UserInterface/Views/SettingsTabContentView.js:
+(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
+2018-10-01 Nikita Vasilyev
+
Web Inspector: Dark Mode: use the same CSS variables for dark and light modes
https://bugs.webkit.org/show_bug.cgi?id=189766
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (236705 => 236706)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2018-10-02 01:31:37 UTC (rev 236705)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2018-10-02 01:37:43 UTC (rev 236706)
@@ -332,6 +332,7 @@
localizedStrings["Enable Layers Tab"] = "Enable Layers Tab";
localizedStrings["Enable New Tab Bar"] = "Enable New Tab Bar";
localizedStrings["Enable Program"] = "Enable Program";
+localizedStrings["Enable Selection of Multiple Properties"] = "Enable Selection of Multiple Properties";
localizedStrings["Enable all breakpoints (%s)"] = "Enable all breakpoints (%s)";
localizedStrings["Enable breakpoints"] = "Enable breakpoints";
localizedStrings["Enable paint flashing"] = "Enable paint flashing";
@@ -823,6 +824,7 @@
localizedStrings["Styles"] = "Styles";
localizedStrings["Styles Invalidated"] = "Styles Invalidated";
localizedStrings["Styles Recalculated"] = "Styles Recalculated";
+localizedStrings["Styles Sidebar:"] = "Styles Sidebar:";
localizedStrings["Styles \u2014 Computed"] = "Styles \u2014 Computed";
localizedStrings["Styles \u2014 Rules"] = "Styles \u2014 Rules";
localizedStrings["Stylesheet"] = "Stylesheet";
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (236705 => 236706)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2018-10-02 01:31:37 UTC (rev 236705)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2018-10-02 01:37:43 UTC (rev 236706)
@@ -121,6 +121,7 @@
showAllRequestsBreakpoint: new WI.Setting("show-all-requests-breakpoint", true),
// Experimental
+experimentalEnableMultiplePropertiesSelection: new WI.Setting("experimental-enable-multiple-properties-selection", false),
experimentalEnableLayersTab: new WI.Setting("experimental-enable-layers-tab", false),
experimentalEnableNewTabBar: new WI.Setting("experimental-enable-new-tab-bar", false),
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (236705 => 236706)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2018-10-02 01:31:37 UTC (rev 236705)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2018-10-02 01:37:43 UTC (rev 236706)
@@ -239,6 +239,11 @@
let experimentalSettingsView = new WI.SettingsView("experimental", WI.UIString("Experimental"));
+if (window.CSSAgent) {
+experimentalSettingsView.addSetting(WI.UIString("Styles Sidebar:"), WI.settings.experimentalEnableMultiplePropertiesSelection, WI.UIString("Enable Selection of Multiple Properties"));
+experimentalSettingsView.addSeparator();
+}
+
if (window.LayerTreeAgent) {
experimentalSettingsView.addSetting(WI.UIString("Layers:"), WI.settings.experimentalEnableLayersTab, WI.UIString("Enable Layers Tab"));
experimentalSettingsView.addSeparator();
@@ -261,6 +266,7 @@
});
}
+listenForChange(WI.settings.experimentalEnableMultiplePropertiesSelection);
[webkit-changes] [236705] trunk/Source/WebInspectorUI
Title: [236705] trunk/Source/WebInspectorUI Revision 236705 Author nvasil...@apple.com Date 2018-10-01 18:31:37 -0700 (Mon, 01 Oct 2018) Log Message Web Inspector: Dark Mode: use the same CSS variables for dark and light modes https://bugs.webkit.org/show_bug.cgi?id=189766 Use --text-color and --background-color CSS variables for both dark and light modes. Reviewed by Matt Baker. * UserInterface/Views/BreakpointPopoverController.css: (.popover .edit-breakpoint-popover-content > label.toggle): Color of the label matches the color of the popover, no need to specify it. (.edit-breakpoint-popover-condition): (@media (prefers-dark-interface)): (.popover .edit-breakpoint-popover-content > table > tr > th): * UserInterface/Views/CompletionSuggestionsView.css: (.completion-suggestions-container > .item): (@media (prefers-dark-interface)): (.completion-suggestions): * UserInterface/Views/ComputedStyleDetailsPanel.css: (.details-section:matches(.computed-style-properties, .computed-style-box-model):not(.collapsed) > :matches(.header, .content)): (.computed-style-properties .property:hover .go-to-arrow): (@media (prefers-dark-interface)): Deleted. (.computed-style-properties.details-section): Deleted. (.details-section.style-box-model:not(.collapsed) > :matches(.header, .content)): Deleted. * UserInterface/Views/DOMTreeOutline.css: (.tree-outline.dom): (@media (prefers-dark-interface)): * UserInterface/Views/DataGrid.css: (.data-grid th): (body:not(.window-inactive, .window-docked-inactive) .data-grid:matches(:focus, .force-focus) tr.editable.selected .cell-content > input): (@media (prefers-dark-interface)): * UserInterface/Views/GeneralStyleDetailsSidebarPanel.css: (.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle): (@media (prefers-dark-interface)): (.sidebar > .panel.details.css-style > .content ~ .options-container > .new-rule): * UserInterface/Views/InlineSwatch.css: (.inline-swatch): (.inline-swatch-variable-popover .CodeMirror pre): (@media (prefers-dark-interface)): Deleted. * UserInterface/Views/NetworkResourceDetailView.css: (.network-resource-detail): (.network .network-resource-detail .navigation-bar .item.radio.button.text-only.selected): (@media (prefers-dark-interface)): (.resource-headers .value): Deleted. Move this rule to ResourceHeadersContentView.css. * UserInterface/Views/ObjectPreviewView.css: (.object-preview): (@media (prefers-dark-interface)): (.object-preview .name): * UserInterface/Views/ObjectTreeView.css: (.object-tree): (.object-tree-property :matches(.formatted-string, .formatted-regexp)): (@media (prefers-dark-interface)): Deleted. (.object-tree,): Deleted. (.object-preview .name): Deleted. (.object-preview > .size): Deleted. Move these rules to ObjectPreviewView.css. * UserInterface/Views/QuickConsole.css: (.quick-console): (@media (prefers-dark-interface)): * UserInterface/Views/ResourceHeadersContentView.css: (.resource-headers .value): (.resource-headers.showing-find-banner .search-highlight): (@media (prefers-dark-interface)): Deleted. * UserInterface/Views/ResourceTimingBreakdownView.css: (.resource-timing-breakdown > table > tr.header:not(.total-row) > td): (@media (prefers-dark-interface)): * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css: (.spreadsheet-style-declaration-editor .property:not(.disabled) .value): (.spreadsheet-style-declaration-editor .property:matches(.invalid-name, .other-vendor, .overridden):not(.disabled) .content > *): (@media (prefers-dark-interface)): (.spreadsheet-style-declaration-editor .property.has-warning .warning): * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css: (.spreadsheet-css-declaration .media-label): (.spreadsheet-css-declaration .selector:focus,): (@media (prefers-dark-interface)): (.spreadsheet-css-declaration .origin .go-to-link,): * UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css: (.sidebar > .panel.details.css-style > .content > .rules .section-header .node-link:hover): (@media (prefers-dark-interface)): (.sidebar > .panel.details.css-style > .content > .rules .section-header): * UserInterface/Views/SyntaxHighlightingDefaultTheme.css: (.cm-s-default,): (@media (prefers-dark-interface)): (.syntax-highlighted,): Deleted. * UserInterface/Views/Table.css: (.table): (.table > .header): * UserInterface/Views/TimelineOverview.css: (.timeline-overview > .navigation-bar.timelines): (@media (prefers-dark-interface)): * UserInterface/Views/TimelineRecordingContentView.css: (.content-view.timeline-recording > .content-browser > .navigation-bar > .item.scope-bar.default-item-selected > .multiple): (.content-view.timeline-recording > .content-browser > .navigation-bar > .item.scope-bar.default-item-selected > .multiple .arrows): (.content-view.timeline-recording > .content-browser .recording-progress > .status > .indeterminate-progress-spinner): (@media (prefers-dark-interface)): Deleted. * UserInterface/Views/Variables.css: (:root): (@media
[webkit-changes] [236704] tags/Safari-606.2.104/
Title: [236704] tags/Safari-606.2.104/ Revision 236704 Author kocsen_ch...@apple.com Date 2018-10-01 18:12:08 -0700 (Mon, 01 Oct 2018) Log Message Tag Safari-606.2.104. Added Paths tags/Safari-606.2.104/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236703] trunk/Source/WebCore
Title: [236703] trunk/Source/WebCore
Revision 236703
Author achristen...@apple.com
Date 2018-10-01 17:21:14 -0700 (Mon, 01 Oct 2018)
Log Message
Don't read from WebCore's bundle for IDNScriptWhiteList
https://bugs.webkit.org/show_bug.cgi?id=190157
Reviewed by Dan Bernstein.
No change in behavior. This increases performance by not reading from the WebCore bundle,
and it makes it so that URL-related functionality can be moved to a place without
a bundle for resources.
* Resources/IDNScriptWhiteList.txt: Removed.
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/WebCoreNSURLExtras.mm:
(WebCore::whiteListIDNScripts):
(WebCore::allCharactersInIDNScriptWhiteList):
(WebCore::readIDNScriptWhiteListFile): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm
Removed Paths
trunk/Source/WebCore/Resources/IDNScriptWhiteList.txt
Diff
Modified: trunk/Source/WebCore/ChangeLog (236702 => 236703)
--- trunk/Source/WebCore/ChangeLog 2018-10-02 00:16:54 UTC (rev 236702)
+++ trunk/Source/WebCore/ChangeLog 2018-10-02 00:21:14 UTC (rev 236703)
@@ -1,5 +1,23 @@
2018-10-01 Alex Christensen
+Don't read from WebCore's bundle for IDNScriptWhiteList
+https://bugs.webkit.org/show_bug.cgi?id=190157
+
+Reviewed by Dan Bernstein.
+
+No change in behavior. This increases performance by not reading from the WebCore bundle,
+and it makes it so that URL-related functionality can be moved to a place without
+a bundle for resources.
+
+* Resources/IDNScriptWhiteList.txt: Removed.
+* WebCore.xcodeproj/project.pbxproj:
+* platform/mac/WebCoreNSURLExtras.mm:
+(WebCore::whiteListIDNScripts):
+(WebCore::allCharactersInIDNScriptWhiteList):
+(WebCore::readIDNScriptWhiteListFile): Deleted.
+
+2018-10-01 Alex Christensen
+
Unreviewed, rolling out r236551.
Fails URL validating too aggressively
Deleted: trunk/Source/WebCore/Resources/IDNScriptWhiteList.txt (236702 => 236703)
--- trunk/Source/WebCore/Resources/IDNScriptWhiteList.txt 2018-10-02 00:16:54 UTC (rev 236702)
+++ trunk/Source/WebCore/Resources/IDNScriptWhiteList.txt 2018-10-02 00:21:14 UTC (rev 236703)
@@ -1,23 +0,0 @@
-# Default Web Kit International Domain Name Script White List.
-
-Common
-Inherited
-
-Arabic
-Armenian
-Bopomofo
-Canadian_Aboriginal
-Devanagari
-Deseret
-Gujarati
-Gurmukhi
-Hangul
-Han
-Hebrew
-Hiragana
-Katakana_Or_Hiragana
-Katakana
-Latin
-Tamil
-Thai
-Yi
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (236702 => 236703)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2018-10-02 00:16:54 UTC (rev 236702)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2018-10-02 00:21:14 UTC (rev 236703)
@@ -2254,7 +2254,6 @@
7CC2DE031ECA04A50027B774 /* NotificationDirection.h in Headers */ = {isa = PBXBuildFile; fileRef = 7CC2DE021ECA04A50027B774 /* NotificationDirection.h */; settings = {ATTRIBUTES = (Private, ); }; };
7CC564B818BABEA6001B9652 /* TelephoneNumberDetector.h in Headers */ = {isa = PBXBuildFile; fileRef = 7CC564B618BABEA6001B9652 /* TelephoneNumberDetector.h */; };
7CC69941191EC5F500AF2270 /* JSWebKitNamespace.h in Headers */ = {isa = PBXBuildFile; fileRef = 7CC6993F191EC5F500AF2270 /* JSWebKitNamespace.h */; };
- 7CC7E3D717208C0F003C5277 /* IDNScriptWhiteList.txt in Resources */ = {isa = PBXBuildFile; fileRef = 7CC7E3D617208C0F003C5277 /* IDNScriptWhiteList.txt */; };
7CC9722E1F93E3360004D4CF /* SettingsBase.h in Headers */ = {isa = PBXBuildFile; fileRef = 7CC660991F93057800D500E9 /* SettingsBase.h */; settings = {ATTRIBUTES = (Private, ); }; };
7CCEBFC01DD8F6AB002C40B8 /* SVGLengthValue.h in Headers */ = {isa = PBXBuildFile; fileRef = 7CE58D531DD7B09300128552 /* SVGLengthValue.h */; settings = {ATTRIBUTES = (Private, ); }; };
7CD0BA051B8F79C9005CEBBE /* ActiveDOMCallbackMicrotask.h in Headers */ = {isa = PBXBuildFile; fileRef = 7CD0BA031B8F79C9005CEBBE /* ActiveDOMCallbackMicrotask.h */; };
@@ -9682,7 +9681,6 @@
7CC6609B1F93057900D500E9 /* SettingsBase.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SettingsBase.cpp; sourceTree = ""; };
7CC6993E191EC5F500AF2270 /* JSWebKitNamespace.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSWebKitNamespace.cpp; sourceTree = ""; };
7CC6993F191EC5F500AF2270 /* JSWebKitNamespace.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSWebKitNamespace.h; sourceTree = ""; };
- 7CC7E3D617208C0F003C5277 /* IDNScriptWhiteList.txt */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = IDNScriptWhiteList.txt; sourceTree = ""; };
7CD0BA021B8F79C9005CEBBE /* ActiveDOMCallbackMicrotask.cpp */ = {isa = PBXFileReference; fileEncoding = 4;
[webkit-changes] [236702] trunk
Title: [236702] trunk
Revision 236702
Author achristen...@apple.com
Date 2018-10-01 17:16:54 -0700 (Mon, 01 Oct 2018)
Log Message
Unreviewed, rolling out r236551.
Fails URL validating too aggressively
Reverted changeset:
"URLWithUserTypedString should return nil for URLs deemed to
be invalid by WebCore::URL"
https://bugs.webkit.org/show_bug.cgi?id=189979
https://trac.webkit.org/changeset/236551
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (236701 => 236702)
--- trunk/Source/WebCore/ChangeLog 2018-10-02 00:07:04 UTC (rev 236701)
+++ trunk/Source/WebCore/ChangeLog 2018-10-02 00:16:54 UTC (rev 236702)
@@ -1,3 +1,16 @@
+2018-10-01 Alex Christensen
+
+Unreviewed, rolling out r236551.
+
+Fails URL validating too aggressively
+
+Reverted changeset:
+
+"URLWithUserTypedString should return nil for URLs deemed to
+be invalid by WebCore::URL"
+https://bugs.webkit.org/show_bug.cgi?id=189979
+https://trac.webkit.org/changeset/236551
+
2018-10-01 Keith Miller
Create a RELEASE_AND_RETURN macro for ExceptionScopes
Modified: trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm (236701 => 236702)
--- trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm 2018-10-02 00:07:04 UTC (rev 236701)
+++ trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm 2018-10-02 00:16:54 UTC (rev 236702)
@@ -895,7 +895,7 @@
// Let's check whether the URL is bogus.
URL url { URL { nsURL }, string };
-if (!url.isValid() || !url.createCFURL())
+if (!url.createCFURL())
return nil;
// FIXME: https://bugs.webkit.org/show_bug.cgi?id=186057
@@ -935,8 +935,6 @@
NSData *dataForURLComponentType(NSURL *URL, CFURLComponentType componentType)
{
-if (!URL)
-return nil;
Vector allBytesBuffer(URL_BYTES_BUFFER_LENGTH);
CFIndex bytesFilled = CFURLGetBytes((__bridge CFURLRef)URL, allBytesBuffer.data(), allBytesBuffer.size());
if (bytesFilled == -1) {
@@ -986,8 +984,6 @@
static NSURL *URLByRemovingComponentAndSubsequentCharacter(NSURL *URL, CFURLComponentType component)
{
-if (!URL)
-return nil;
CFRange range = CFURLGetByteRangeForComponent((__bridge CFURLRef)URL, component, 0);
if (range.location == kCFNotFound)
return URL;
@@ -1025,8 +1021,6 @@
NSURL *URLByCanonicalizingURL(NSURL *URL)
{
-if (!URL)
-return nil;
RetainPtr request = adoptNS([[NSURLRequest alloc] initWithURL:URL]);
Class concreteClass = [NSURLProtocol _protocolClassForRequest:request.get()];
if (!concreteClass) {
@@ -1044,8 +1038,6 @@
NSData *originalURLData(NSURL *URL)
{
-if (!URL)
-return nil;
UInt8 *buffer = (UInt8 *)malloc(URL_BYTES_BUFFER_LENGTH);
CFIndex bytesFilled = CFURLGetBytes((__bridge CFURLRef)URL, buffer, URL_BYTES_BUFFER_LENGTH);
if (bytesFilled == -1) {
@@ -1107,8 +1099,6 @@
NSString *userVisibleString(NSURL *URL)
{
-if (!URL)
-return nil;
NSData *data = ""
const unsigned char *before = static_cast([data bytes]);
int length = [data length];
Modified: trunk/Tools/ChangeLog (236701 => 236702)
--- trunk/Tools/ChangeLog 2018-10-02 00:07:04 UTC (rev 236701)
+++ trunk/Tools/ChangeLog 2018-10-02 00:16:54 UTC (rev 236702)
@@ -1,3 +1,16 @@
+2018-10-01 Alex Christensen
+
+Unreviewed, rolling out r236551.
+
+Fails URL validating too aggressively
+
+Reverted changeset:
+
+"URLWithUserTypedString should return nil for URLs deemed to
+be invalid by WebCore::URL"
+https://bugs.webkit.org/show_bug.cgi?id=189979
+https://trac.webkit.org/changeset/236551
+
2018-10-01 Wenson Hsieh
[iOS] Add SPI to customize the input accessory view when focusing an element
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm (236701 => 236702)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm 2018-10-02 00:07:04 UTC (rev 236701)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm 2018-10-02 00:16:54 UTC (rev 236702)
@@ -50,8 +50,6 @@
static const char* originalDataAsString(NSURL *URL)
{
-if (!URL)
-return "NULL";
return dataAsString(WebCore::originalURLData(URL));
}
@@ -167,8 +165,8 @@
// Selected ideographic space, which looks like the ASCII space, which is not allowed unescaped.
// Code path similar to the one used when typing in a URL.
-EXPECT_STREQ("NULL", originalDataAsString(WebCore::URLWithUserTypedString(@"http://site.com\xE3\x80\x80othersite.org", nil)));
-EXPECT_STREQ(nullptr, userVisibleString(WebCore::URLWithUserTypedString(@"http://site.com\xE3\x80\x80othersite.org", nil)));
+EXPECT_STREQ("http://site.com%20othersite.org",
[webkit-changes] [236701] trunk/Source
Title: [236701] trunk/Source
Revision 236701
Author aes...@apple.com
Date 2018-10-01 17:07:04 -0700 (Mon, 01 Oct 2018)
Log Message
[watchOS] Adopt NSURLSessionCompanionProxyPreference
https://bugs.webkit.org/show_bug.cgi?id=190177
Reviewed by Wenson Hsieh.
Source/WebCore/PAL:
* pal/spi/cf/CFNetworkSPI.h:
Source/WebKit:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
Source/WTF:
* wtf/FeatureDefines.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
Diff
Modified: trunk/Source/WTF/ChangeLog (236700 => 236701)
--- trunk/Source/WTF/ChangeLog 2018-10-01 23:46:52 UTC (rev 236700)
+++ trunk/Source/WTF/ChangeLog 2018-10-02 00:07:04 UTC (rev 236701)
@@ -1,3 +1,13 @@
+2018-10-01 Andy Estes
+
+[watchOS] Adopt NSURLSessionCompanionProxyPreference
+https://bugs.webkit.org/show_bug.cgi?id=190177
+
+
+Reviewed by Wenson Hsieh.
+
+* wtf/FeatureDefines.h:
+
2018-10-01 Koby Boyango
[WTF][JSCONLY] Use MainThreadWin on Windows in the JSCOnly port
Modified: trunk/Source/WTF/wtf/FeatureDefines.h (236700 => 236701)
--- trunk/Source/WTF/wtf/FeatureDefines.h 2018-10-01 23:46:52 UTC (rev 236700)
+++ trunk/Source/WTF/wtf/FeatureDefines.h 2018-10-02 00:07:04 UTC (rev 236701)
@@ -184,7 +184,7 @@
#if PLATFORM(WATCHOS)
#if !defined(ENABLE_PROXIMITY_NETWORKING)
-#if !TARGET_OS_SIMULATOR
+#if !TARGET_OS_SIMULATOR && __WATCH_OS_VERSION_MIN_REQUIRED < 6
#define ENABLE_PROXIMITY_NETWORKING 1
#endif
#endif
Modified: trunk/Source/WebCore/PAL/ChangeLog (236700 => 236701)
--- trunk/Source/WebCore/PAL/ChangeLog 2018-10-01 23:46:52 UTC (rev 236700)
+++ trunk/Source/WebCore/PAL/ChangeLog 2018-10-02 00:07:04 UTC (rev 236701)
@@ -1,3 +1,13 @@
+2018-10-01 Andy Estes
+
+[watchOS] Adopt NSURLSessionCompanionProxyPreference
+https://bugs.webkit.org/show_bug.cgi?id=190177
+
+
+Reviewed by Wenson Hsieh.
+
+* pal/spi/cf/CFNetworkSPI.h:
+
2018-10-01 Daniel Bates
[iOS] Special keys are misidentified in DOM keyboard events
Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (236700 => 236701)
--- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2018-10-01 23:46:52 UTC (rev 236700)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2018-10-02 00:07:04 UTC (rev 236701)
@@ -161,6 +161,14 @@
- (NSDate *)_lastModifiedDate;
@end
+#if PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED >= 6
+typedef NS_ENUM(NSInteger, NSURLSessionCompanionProxyPreference) {
+NSURLSessionCompanionProxyPreferenceDefault = 0,
+NSURLSessionCompanionProxyPreferencePreferCompanion,
+NSURLSessionCompanionProxyPreferencePreferDirectToCloud,
+};
+#endif
+
@interface NSURLSessionConfiguration ()
@property (assign) _TimingDataOptions _timingDataOptions;
@property (copy) NSData *_sourceApplicationAuditTokenData;
@@ -173,6 +181,9 @@
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 11)
@property (nullable, copy) NSSet *_suppressedAutoAddedHTTPHeaders;
#endif
+#if PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED >= 6
+@property NSURLSessionCompanionProxyPreference _companionProxyPreference;
+#endif
@end
@interface NSURLSessionTask ()
Modified: trunk/Source/WebKit/ChangeLog (236700 => 236701)
--- trunk/Source/WebKit/ChangeLog 2018-10-01 23:46:52 UTC (rev 236700)
+++ trunk/Source/WebKit/ChangeLog 2018-10-02 00:07:04 UTC (rev 236701)
@@ -1,3 +1,14 @@
+2018-10-01 Andy Estes
+
+[watchOS] Adopt NSURLSessionCompanionProxyPreference
+https://bugs.webkit.org/show_bug.cgi?id=190177
+
+
+Reviewed by Wenson Hsieh.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+
2018-10-01 Chris Dumez
[Mac] The UIProcess should listen to memory pressure signals
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (236700 => 236701)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2018-10-01 23:46:52 UTC (rev 236700)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2018-10-02 00:07:04 UTC (rev 236701)
@@ -707,6 +707,10 @@
configuration._socketStreamProperties = @{ @"kCFStreamPropertyAutoErrorOnSystemChange" : @(NO) };
#endif
+#if PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 6
+configuration._companionProxyPreference = NSURLSessionCompanionProxyPreferencePreferDirectToCloud;
+#endif
+
auto* storageSession = WebCore::NetworkStorageSession::storageSession(parameters.sessionID);
RELEASE_ASSERT(storageSession);
if (CFHTTPCookieStorageRef storage =
[webkit-changes] [236700] trunk/Source/WebKit
Title: [236700] trunk/Source/WebKit Revision 236700 Author cdu...@apple.com Date 2018-10-01 16:46:52 -0700 (Mon, 01 Oct 2018) Log Message [Mac] The UIProcess should listen to memory pressure signals https://bugs.webkit.org/show_bug.cgi?id=190166 Reviewed by Simon Fraser. The UIProcess should listen to memory pressure signals on Mac in order to free memory, similarly to what we already do on iOS. The memory pressure handler currently discards view snapshots and prewarmed processes. * SourcesCocoa.txt: * UIProcess/Cocoa/WebMemoryPressureHandlerCocoa.h: Renamed from Source/WebKit/UIProcess/ios/WebMemoryPressureHandlerIOS.h. * UIProcess/Cocoa/WebMemoryPressureHandlerCocoa.mm: Renamed from Source/WebKit/UIProcess/ios/WebMemoryPressureHandlerIOS.mm. (WebKit::installMemoryPressureHandler): * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitialize): * WebKit.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/SourcesCocoa.txt trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit/UIProcess/Cocoa/WebMemoryPressureHandlerCocoa.h trunk/Source/WebKit/UIProcess/Cocoa/WebMemoryPressureHandlerCocoa.mm Removed Paths trunk/Source/WebKit/UIProcess/ios/WebMemoryPressureHandlerIOS.h trunk/Source/WebKit/UIProcess/ios/WebMemoryPressureHandlerIOS.mm Diff Modified: trunk/Source/WebKit/ChangeLog (236699 => 236700) --- trunk/Source/WebKit/ChangeLog 2018-10-01 23:45:59 UTC (rev 236699) +++ trunk/Source/WebKit/ChangeLog 2018-10-01 23:46:52 UTC (rev 236700) @@ -1,3 +1,21 @@ +2018-10-01 Chris Dumez + +[Mac] The UIProcess should listen to memory pressure signals +https://bugs.webkit.org/show_bug.cgi?id=190166 + +Reviewed by Simon Fraser. + +The UIProcess should listen to memory pressure signals on Mac in order to free memory, similarly to what we already +do on iOS. The memory pressure handler currently discards view snapshots and prewarmed processes. + +* SourcesCocoa.txt: +* UIProcess/Cocoa/WebMemoryPressureHandlerCocoa.h: Renamed from Source/WebKit/UIProcess/ios/WebMemoryPressureHandlerIOS.h. +* UIProcess/Cocoa/WebMemoryPressureHandlerCocoa.mm: Renamed from Source/WebKit/UIProcess/ios/WebMemoryPressureHandlerIOS.mm. +(WebKit::installMemoryPressureHandler): +* UIProcess/Cocoa/WebProcessPoolCocoa.mm: +(WebKit::WebProcessPool::platformInitialize): +* WebKit.xcodeproj/project.pbxproj: + 2018-10-01 Sihui Liu Fix Internal iOS Build after r236690 Modified: trunk/Source/WebKit/SourcesCocoa.txt (236699 => 236700) --- trunk/Source/WebKit/SourcesCocoa.txt 2018-10-01 23:45:59 UTC (rev 236699) +++ trunk/Source/WebKit/SourcesCocoa.txt 2018-10-01 23:46:52 UTC (rev 236700) @@ -330,6 +330,7 @@ UIProcess/Cocoa/VersionChecks.mm UIProcess/Cocoa/VideoFullscreenManagerProxy.mm UIProcess/Cocoa/ViewGestureController.cpp +UIProcess/Cocoa/WebMemoryPressureHandlerCocoa.mm UIProcess/Cocoa/WebPageProxyCocoa.mm UIProcess/Cocoa/WebPasteboardProxyCocoa.mm UIProcess/Cocoa/WebProcessPoolCocoa.mm @@ -377,7 +378,6 @@ UIProcess/ios/SmartMagnificationController.mm UIProcess/ios/TextCheckerIOS.mm UIProcess/ios/ViewGestureControllerIOS.mm -UIProcess/ios/WebMemoryPressureHandlerIOS.mm UIProcess/ios/WebPageProxyIOS.mm UIProcess/ios/WebProcessProxyIOS.mm UIProcess/ios/WKActionSheet.mm Copied: trunk/Source/WebKit/UIProcess/Cocoa/WebMemoryPressureHandlerCocoa.h (from rev 236699, trunk/Source/WebKit/UIProcess/ios/WebMemoryPressureHandlerIOS.h) (0 => 236700) --- trunk/Source/WebKit/UIProcess/Cocoa/WebMemoryPressureHandlerCocoa.h (rev 0) +++ trunk/Source/WebKit/UIProcess/Cocoa/WebMemoryPressureHandlerCocoa.h 2018-10-01 23:46:52 UTC (rev 236700) @@ -0,0 +1,32 @@ +/* + * Copyright (C) 2014 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
[webkit-changes] [236699] trunk/PerformanceTests
Title: [236699] trunk/PerformanceTests
Revision 236699
Author cdu...@apple.com
Date 2018-10-01 16:45:59 -0700 (Mon, 01 Oct 2018)
Log Message
Regression(r236613): Parser/HTML5-8266-ParseOnly.html performance tests no longer runs
https://bugs.webkit.org/show_bug.cgi?id=190174
Reviewed by Ryosuke Niwa.
Update iframe's sandbox to use 'allow-same-origin' so that the iframe is treated as same-origin and so that
the top frame can call document.open() / document.write() on the subframe. This test was also failing in
Firefox without this change.
* Parser/HTML5-8266-ParseOnly.html:
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Parser/HTML5-8266-ParseOnly.html
Diff
Modified: trunk/PerformanceTests/ChangeLog (236698 => 236699)
--- trunk/PerformanceTests/ChangeLog 2018-10-01 23:28:43 UTC (rev 236698)
+++ trunk/PerformanceTests/ChangeLog 2018-10-01 23:45:59 UTC (rev 236699)
@@ -1,3 +1,16 @@
+2018-10-01 Chris Dumez
+
+Regression(r236613): Parser/HTML5-8266-ParseOnly.html performance tests no longer runs
+https://bugs.webkit.org/show_bug.cgi?id=190174
+
+Reviewed by Ryosuke Niwa.
+
+Update iframe's sandbox to use 'allow-same-origin' so that the iframe is treated as same-origin and so that
+the top frame can call document.open() / document.write() on the subframe. This test was also failing in
+Firefox without this change.
+
+* Parser/HTML5-8266-ParseOnly.html:
+
2018-08-27 Aditya Keerthi
Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
Modified: trunk/PerformanceTests/Parser/HTML5-8266-ParseOnly.html (236698 => 236699)
--- trunk/PerformanceTests/Parser/HTML5-8266-ParseOnly.html 2018-10-01 23:28:43 UTC (rev 236698)
+++ trunk/PerformanceTests/Parser/HTML5-8266-ParseOnly.html 2018-10-01 23:45:59 UTC (rev 236699)
@@ -7,7 +7,7 @@
PerfTestRunner.measureTime({run: function() {
var iframe = document.createElement("iframe");
iframe.style.display = "none"; // Prevent creation of the rendering tree, so we only test HTML parsing.
-iframe.sandbox = ''; // Prevent external script loads which could cause write() to return before completing the parse.
+iframe.sandbox = 'allow-same-origin'; // Prevent external script loads which could cause write() to return before completing the parse.
document.body.appendChild(iframe);
iframe.contentDocument.open();
iframe.contentDocument.write(spec);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236698] trunk/Source/WebKit
Title: [236698] trunk/Source/WebKit Revision 236698 Author sihui_...@apple.com Date 2018-10-01 16:28:43 -0700 (Mon, 01 Oct 2018) Log Message Fix Internal iOS Build after r236690 https://bugs.webkit.org/show_bug.cgi?id=190171 Reviewed by Alex Christensen. * Platform/ExtraPrivateSymbolsForTAPI.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/ExtraPrivateSymbolsForTAPI.h Diff Modified: trunk/Source/WebKit/ChangeLog (236697 => 236698) --- trunk/Source/WebKit/ChangeLog 2018-10-01 23:23:08 UTC (rev 236697) +++ trunk/Source/WebKit/ChangeLog 2018-10-01 23:28:43 UTC (rev 236698) @@ -1,3 +1,12 @@ +2018-10-01 Sihui Liu + +Fix Internal iOS Build after r236690 +https://bugs.webkit.org/show_bug.cgi?id=190171 + +Reviewed by Alex Christensen. + +* Platform/ExtraPrivateSymbolsForTAPI.h: + 2018-10-01 Wenson Hsieh [iOS] Add SPI to customize the input accessory view when focusing an element Modified: trunk/Source/WebKit/Platform/ExtraPrivateSymbolsForTAPI.h (236697 => 236698) --- trunk/Source/WebKit/Platform/ExtraPrivateSymbolsForTAPI.h 2018-10-01 23:23:08 UTC (rev 236697) +++ trunk/Source/WebKit/Platform/ExtraPrivateSymbolsForTAPI.h 2018-10-01 23:28:43 UTC (rev 236698) @@ -30,7 +30,6 @@ #endif // FIXME: Remove these after is fixed. -void DatabaseServiceInitializer(); void NetworkServiceInitializer(); void PluginServiceInitializer(); void WebContentServiceInitializer(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236696] releases/WebKitGTK/webkit-2.22
Title: [236696] releases/WebKitGTK/webkit-2.22 Revision 236696 Author ape...@igalia.com Date 2018-10-01 16:12:55 -0700 (Mon, 01 Oct 2018) Log Message [MSE][GStreamer] Reset running time in PlaybackPipeline::flush() https://bugs.webkit.org/show_bug.cgi?id=190076 Reviewed by Philippe Normand. Source/WebCore: Test: media/media-source/media-source-seek-redundant-append.html PlaybackPipeline::flush() is called when already enqueued frames are appended again. This may be caused by a quality change or just a redundant append. Either way, the pipeline has to be flushed and playback begin again, but without changing the player position by much. There are two kinds of time to consider here: stream time (i.e. the time of a frame as written in the file, e.g. a frame may have stream time 0:01:00), and running time (i.e. how much time since playback started should pass before the frame should be played, e.g. if we started playing at 0:00:59 that same frame would have a running time of just 1 second). Notice how running time depends on where and when playback starts. Running time can also be optionally resetted after a flush. (This is indeed done currently by most demuxers after a seek.) Instead of resetting running time, PlaybackPipeline used to modify the first GstSegment emitted after the flush. A GstSegment declares the mapping between stream time and running time for the following frames. There, PlaybackPipeline used to set `base` (the running time at which the segment starts) to the position reported by a position query (which is stream time). This, of course, only worked when playback (or the last seek) started at stream time 0:00:00, since that's the only case where running time equals stream time. In other cases delays as long as the difference between these timelines would appear. This is demonstrated in the attached test, where seeks and appends are made in such an order that the difference is more than 5 minutes, making the playback stall for >5 minutes before playing 1 second of audio. This patch fixes the problem by resetting running time with the flush and not modifying GstSegment.base anymore (it will be left as zero, which is now correct since the running time has been reset). * platform/graphics/gstreamer/mse/PlaybackPipeline.cpp: (WebCore::PlaybackPipeline::flush): (WebCore::segmentFixerProbe): Deleted. LayoutTests: A test where a seek is followed by a redundant append is added. This test timed out in the GStreamer MSE implementation before the accompanying patch fixed it. The MIME type declared in test-48khz-manifest.json has also been changed, from non-standard `audio/x-m4a` to `audio/mp4; codecs="mp4a.40.2"`, as implied by the MSE specs. This should not affect other tests because no other tests were reading this type string before. * media/media-source/content/test-48khz-manifest.json: * media/media-source/media-source-seek-redundant-append-expected.txt: Added. * media/media-source/media-source-seek-redundant-append.html: Added. * media/video-test.js: Modified Paths releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/content/test-48khz-manifest.json releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp Added Paths releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/media-source-seek-redundant-append-expected.txt releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/media-source-seek-redundant-append.html Diff Modified: releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog (236695 => 236696) --- releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog 2018-10-01 23:12:44 UTC (rev 236695) +++ releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog 2018-10-01 23:12:55 UTC (rev 236696) @@ -1,5 +1,27 @@ 2018-10-01 Alicia Boya García +[MSE][GStreamer] Reset running time in PlaybackPipeline::flush() +https://bugs.webkit.org/show_bug.cgi?id=190076 + +Reviewed by Philippe Normand. + +A test where a seek is followed by a redundant append is added. This +test timed out in the GStreamer MSE implementation before the +accompanying patch fixed it. + +The MIME type declared in test-48khz-manifest.json has also been +changed, from non-standard `audio/x-m4a` to `audio/mp4; +codecs="mp4a.40.2"`, as implied by the MSE specs. This should not +affect other tests because no other tests were reading this type +string before. + +* media/media-source/content/test-48khz-manifest.json: +* media/media-source/media-source-seek-redundant-append-expected.txt: Added. +* media/media-source/media-source-seek-redundant-append.html: Added. +* media/video-test.js: + +2018-10-01 Alicia Boya García + [MSE] Use tolerance when growing the coded frame group
[webkit-changes] [236695] releases/WebKitGTK/webkit-2.22
Title: [236695] releases/WebKitGTK/webkit-2.22
Revision 236695
Author ape...@igalia.com
Date 2018-10-01 16:12:44 -0700 (Mon, 01 Oct 2018)
Log Message
Merged patch for #190085 - [MSE] Use tolerance when growing the coded frame group
https://bugs.webkit.org/show_bug.cgi?id=190085
Patch by Alicia Boya García on 2018-10-01
Reviewed by NOBODY (OOPS!).
build-releng/../LayoutTests:
A test simulating unordered appends with imprecise timestamps,
overlapping <1ms (replicating a typical WebM 30fps video file) is
added.
* media/media-source/media-source-append-acb-tolerance.html: Added.
build-releng/../Source/WebCore:
Test: media/media-source/media-source-append-acb-tolerance.html
This patch introduces a millisecond tolerance in the range of
potential frames that should be erased frame from the track buffer
when the coded frame group is growing.
This is necessary because some files have imprecise overlapping
timestamps (especially WebM files).
This fixes a stall when seeking back and forth in YouTube with WebM
video.
A test case simulating the problem with video/mock using timestamps
similar to those of a typical 30 fps WebM video is also added.
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
Modified Paths
releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/Modules/mediasource/SourceBuffer.cpp
Added Paths
releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/media-source-append-acb-tolerance-expected.txt
releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/media-source-append-acb-tolerance.html
Diff
Modified: releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog (236694 => 236695)
--- releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog 2018-10-01 22:43:05 UTC (rev 236694)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog 2018-10-01 23:12:44 UTC (rev 236695)
@@ -1,3 +1,14 @@
+2018-10-01 Alicia Boya García
+
+[MSE] Use tolerance when growing the coded frame group
+https://bugs.webkit.org/show_bug.cgi?id=190085
+
+A test simulating unordered appends with imprecise timestamps,
+overlapping <1ms (replicating a typical WebM 30fps video file) is
+added.
+
+* media/media-source/media-source-append-acb-tolerance.html: Added.
+
2018-09-27 Alicia Boya García
[MSE] Fix unwanted sample erase from the decode queue
Added: releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/media-source-append-acb-tolerance-expected.txt (0 => 236695)
--- releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/media-source-append-acb-tolerance-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/media-source-append-acb-tolerance-expected.txt 2018-10-01 23:12:44 UTC (rev 236695)
@@ -0,0 +1,466 @@
+
+EXPECTED (source.readyState == 'closed') OK
+EVENT(sourceopen)
+RUN(sourceBuffer = source.addSourceBuffer("video/mock; codecs=mock"))
+RUN(sourceBuffer.appendBuffer(initSegment))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(impreciseSampleRun(0, 5)))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(impreciseSampleRun(10, 15)))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(impreciseSampleRun(5, 10)))
+EVENT(updateend)
+EXPECTED (bufferedSamples.length == '450') OK
+EXPECTED (enqueuedSamples.length == '450') OK
+{PTS({0/100 = 0.00}), DTS({0/100 = 0.00}), duration({3/100 = 0.03}), flags(1), generation(0)}
+{PTS({33000/100 = 0.033000}), DTS({33000/100 = 0.033000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({67000/100 = 0.067000}), DTS({67000/100 = 0.067000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({10/100 = 0.10}), DTS({10/100 = 0.10}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({133000/100 = 0.133000}), DTS({133000/100 = 0.133000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({167000/100 = 0.167000}), DTS({167000/100 = 0.167000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({20/100 = 0.20}), DTS({20/100 = 0.20}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({233000/100 = 0.233000}), DTS({233000/100 = 0.233000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({267000/100 = 0.267000}), DTS({267000/100 = 0.267000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({30/100 = 0.30}), DTS({30/100 = 0.30}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({333000/100 = 0.333000}), DTS({333000/100 = 0.333000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({367000/100 = 0.367000}), DTS({367000/100 = 0.367000}),
[webkit-changes] [236694] trunk/Source/WebCore
Title: [236694] trunk/Source/WebCore
Revision 236694
Author dba...@webkit.org
Date 2018-10-01 15:43:05 -0700 (Mon, 01 Oct 2018)
Log Message
Attempt to fix the watchOS build after
(https://bugs.webkit.org/show_bug.cgi?id=189974)
Explicitly cast index to unsigned to make the operator[] call unambiguous.
* platform/ios/KeyEventIOS.mm:
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/KeyEventIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (236693 => 236694)
--- trunk/Source/WebCore/ChangeLog 2018-10-01 21:53:36 UTC (rev 236693)
+++ trunk/Source/WebCore/ChangeLog 2018-10-01 22:43:05 UTC (rev 236694)
@@ -1,3 +1,13 @@
+2018-10-01 Daniel Bates
+
+Attempt to fix the watchOS build after
+(https://bugs.webkit.org/show_bug.cgi?id=189974)
+
+Explicitly cast index to unsigned to make the operator[] call unambiguous.
+
+* platform/ios/KeyEventIOS.mm:
+(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
+
2018-10-01 Ryosuke Niwa
ASAN failure in ~GCReachableRef()
Modified: trunk/Source/WebCore/platform/ios/KeyEventIOS.mm (236693 => 236694)
--- trunk/Source/WebCore/platform/ios/KeyEventIOS.mm 2018-10-01 21:53:36 UTC (rev 236693)
+++ trunk/Source/WebCore/platform/ios/KeyEventIOS.mm 2018-10-01 22:43:05 UTC (rev 236694)
@@ -305,7 +305,7 @@
} else {
m_keyIdentifier = String();
m_windowsVirtualKeyCode = 0;
-if (m_text.length() == 1 && isFunctionKey(m_text[0])) {
+if (m_text.length() == 1 && isFunctionKey(m_text[0U])) {
m_text = String();
m_unmodifiedText = String();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236693] trunk/Source/WebCore
Title: [236693] trunk/Source/WebCore
Revision 236693
Author rn...@webkit.org
Date 2018-10-01 14:53:36 -0700 (Mon, 01 Oct 2018)
Log Message
ASAN failure in ~GCReachableRef()
https://bugs.webkit.org/show_bug.cgi?id=190113
Reviewed by Darin Adler.
The bug was caused by ~GCReachableRef accessing Ref after it had been poisoned for ASAN
in Ref::leakRef via Ref(Ref&& other). Fixed the bug by using RefPtr instead since that's
the simplest solution here although we could unpoison Ref temporarily as done in ~Ref.
* dom/GCReachableRef.h:
(WebCore::GCReachableRef::GCReachableRef):
(WebCore::GCReachableRef::~GCReachableRef):
(WebCore::GCReachableRef::operator-> const):
(WebCore::GCReachableRef::get const):
(WebCore::GCReachableRef::operator T& const):
(WebCore::GCReachableRef::operator! const):
(WebCore::GCReachableRef::isNull const): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/GCReachableRef.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (236692 => 236693)
--- trunk/Source/WebCore/ChangeLog 2018-10-01 21:25:21 UTC (rev 236692)
+++ trunk/Source/WebCore/ChangeLog 2018-10-01 21:53:36 UTC (rev 236693)
@@ -1,3 +1,23 @@
+2018-10-01 Ryosuke Niwa
+
+ASAN failure in ~GCReachableRef()
+https://bugs.webkit.org/show_bug.cgi?id=190113
+
+Reviewed by Darin Adler.
+
+The bug was caused by ~GCReachableRef accessing Ref after it had been poisoned for ASAN
+in Ref::leakRef via Ref(Ref&& other). Fixed the bug by using RefPtr instead since that's
+the simplest solution here although we could unpoison Ref temporarily as done in ~Ref.
+
+* dom/GCReachableRef.h:
+(WebCore::GCReachableRef::GCReachableRef):
+(WebCore::GCReachableRef::~GCReachableRef):
+(WebCore::GCReachableRef::operator-> const):
+(WebCore::GCReachableRef::get const):
+(WebCore::GCReachableRef::operator T& const):
+(WebCore::GCReachableRef::operator! const):
+(WebCore::GCReachableRef::isNull const): Deleted.
+
2018-10-01 Sihui Liu
Remove StorageProcess
Modified: trunk/Source/WebCore/dom/GCReachableRef.h (236692 => 236693)
--- trunk/Source/WebCore/dom/GCReachableRef.h 2018-10-01 21:25:21 UTC (rev 236692)
+++ trunk/Source/WebCore/dom/GCReachableRef.h 2018-10-01 21:53:36 UTC (rev 236693)
@@ -50,42 +50,31 @@
template::value>>
GCReachableRef(T& object)
-: m_ref(object)
+: m_ptr()
{
-GCReachableRefMap::add(m_ref.get());
+GCReachableRefMap::add(*m_ptr);
}
~GCReachableRef()
{
-if (!isNull())
-GCReachableRefMap::remove(m_ref.get());
+if (m_ptr)
+GCReachableRefMap::remove(*m_ptr);
}
-template::value>>
-GCReachableRef(Ref&& other)
-: m_ref(WTFMove(other.m_ref))
-{
-if (!isNull())
-GCReachableRefMap::add(m_ref.get());
-}
-
GCReachableRef(GCReachableRef&& other)
-: m_ref(WTFMove(other.m_ref))
+: m_ptr(WTFMove(other.m_ptr))
{
}
-template GCReachableRef(const GCReachableRef& other) = delete;
+T* operator->() const { return (); }
+T* ptr() const RETURNS_NONNULL { return (); }
+T& get() const { ASSERT(m_ptr); return *m_ptr; }
+operator T&() const { ASSERT(m_ptr); return *m_ptr; }
+bool operator!() const { return !get(); }
-T* operator->() const { ASSERT(!isNull()); return m_ref.ptr(); }
-T* ptr() const RETURNS_NONNULL { ASSERT(!isNull()); return m_ref.ptr(); }
-T& get() const { ASSERT(!isNull()); return m_ref.get(); }
-operator T&() const { ASSERT(!isNull()); return m_ref.get(); }
-bool operator!() const { ASSERT(!isNull()); return !m_ref.get(); }
-
private:
-bool isNull() const { return m_ref.isHashTableEmptyValue(); }
-Ref m_ref;
+RefPtr m_ptr;
};
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236692] trunk/LayoutTests
Title: [236692] trunk/LayoutTests Revision 236692 Author ryanhad...@apple.com Date 2018-10-01 14:25:21 -0700 (Mon, 01 Oct 2018) Log Message Unreviewed, rebaseline tests after r236632. * platform/ios/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt: * platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt: * platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt trunk/LayoutTests/platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt Added Paths trunk/LayoutTests/platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (236691 => 236692) --- trunk/LayoutTests/ChangeLog 2018-10-01 20:59:19 UTC (rev 236691) +++ trunk/LayoutTests/ChangeLog 2018-10-01 21:25:21 UTC (rev 236692) @@ -1,3 +1,11 @@ +2018-10-01 Ryan Haddad + +Unreviewed, rebaseline tests after r236632. + +* platform/ios/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt: +* platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt: +* platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt: Added. + 2018-10-01 Sihui Liu Remove StorageProcess Modified: trunk/LayoutTests/platform/ios/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt (236691 => 236692) --- trunk/LayoutTests/platform/ios/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt 2018-10-01 20:59:19 UTC (rev 236691) +++ trunk/LayoutTests/platform/ios/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt 2018-10-01 21:25:21 UTC (rev 236692) @@ -20,7 +20,6 @@ (rect 28 296 60 60) (rect 48 296 60 60) (rect 28 296 60 60) - (rect 48 296 60 60) (rect 28 536 60 60) (rect 48 536 60 60) (rect 48 416 60 60) @@ -28,10 +27,11 @@ (rect 48 656 60 60) (rect 68 656 60 60) (rect 48 656 60 60) - (rect 68 656 60 60) (rect 28 296 60 60) (rect 48 656 60 60) + (rect 48 296 60 60) (rect 28 536 60 60) (rect 88 656 20 60) + (rect 68 656 60 60) ) Modified: trunk/LayoutTests/platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt (236691 => 236692) --- trunk/LayoutTests/platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt 2018-10-01 20:59:19 UTC (rev 236691) +++ trunk/LayoutTests/platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt 2018-10-01 21:25:21 UTC (rev 236692) @@ -3,7 +3,8 @@ (repaint rects (rect 8 72 100 100) (rect 58 72 100 100) + (rect 8 72 100 100) + (rect 8 72 100 100) (rect 58 72 100 100) - (rect 8 72 100 100) ) Added: trunk/LayoutTests/platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt (0 => 236692) --- trunk/LayoutTests/platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt (rev 0) +++ trunk/LayoutTests/platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt 2018-10-01 21:25:21 UTC (rev 236692) @@ -0,0 +1,6 @@ +This test checks that removing isolation from an element being stacking context for other reasons will not trigger any repaint. + +(repaint rects + (rect 8 72 100 100) +) + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236691] trunk
Title: [236691] trunk
Revision 236691
Author wenson_hs...@apple.com
Date 2018-10-01 13:59:19 -0700 (Mon, 01 Oct 2018)
Log Message
[iOS] Add SPI to customize the input accessory view when focusing an element
https://bugs.webkit.org/show_bug.cgi?id=190152
Reviewed by Dan Bernstein.
Source/WebKit:
Adds SPI on WKFormInputSession to customize the input accessory view, alongside the input view. See below for
more details.
Test: KeyboardInputTests.CustomInputViewAndInputAccessoryView
* UIProcess/API/Cocoa/_WKFormInputSession.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKFormInputSession customInputAccessoryView]):
(-[WKFormInputSession setCustomInputAccessoryView:]):
Reload input views when the custom input accessory view changes.
(-[WKContentView requiresAccessoryView]):
If a custom input accessory view is specified, return YES.
(-[WKContentView inputAccessoryView]):
Return the custom input accessory view if present, and fall back to the default web form accessory view.
Tools:
Add an API test to verify that setting a custom input accessory view and custom input view on the form input
session when focusing an element overrides the first responder's (i.e. WKContentView's) `-inputView` and
`-inputAccessoryView`.
* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
(webViewWithAutofocusedInput):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/ios/TestInputDelegate.h:
* TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
(-[TestInputDelegate setWillStartInputSessionHandler:]):
(-[TestInputDelegate willStartInputSessionHandler]):
(-[TestInputDelegate _webView:willStartInputSession:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKFormInputSession.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm
trunk/Tools/TestWebKitAPI/Tests/ios/TestInputDelegate.h
trunk/Tools/TestWebKitAPI/Tests/ios/TestInputDelegate.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (236690 => 236691)
--- trunk/Source/WebKit/ChangeLog 2018-10-01 20:44:06 UTC (rev 236690)
+++ trunk/Source/WebKit/ChangeLog 2018-10-01 20:59:19 UTC (rev 236691)
@@ -1,3 +1,31 @@
+2018-10-01 Wenson Hsieh
+
+[iOS] Add SPI to customize the input accessory view when focusing an element
+https://bugs.webkit.org/show_bug.cgi?id=190152
+
+
+Reviewed by Dan Bernstein.
+
+Adds SPI on WKFormInputSession to customize the input accessory view, alongside the input view. See below for
+more details.
+
+Test: KeyboardInputTests.CustomInputViewAndInputAccessoryView
+
+* UIProcess/API/Cocoa/_WKFormInputSession.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKFormInputSession customInputAccessoryView]):
+(-[WKFormInputSession setCustomInputAccessoryView:]):
+
+Reload input views when the custom input accessory view changes.
+
+(-[WKContentView requiresAccessoryView]):
+
+If a custom input accessory view is specified, return YES.
+
+(-[WKContentView inputAccessoryView]):
+
+Return the custom input accessory view if present, and fall back to the default web form accessory view.
+
2018-10-01 Sihui Liu
Remove StorageProcess
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKFormInputSession.h (236690 => 236691)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKFormInputSession.h 2018-10-01 20:44:06 UTC (rev 236690)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKFormInputSession.h 2018-10-01 20:59:19 UTC (rev 236691)
@@ -41,6 +41,7 @@
#if TARGET_OS_IPHONE
@property (nonatomic, copy) NSString *accessoryViewCustomButtonTitle;
@property (nonatomic, strong) UIView *customInputView WK_API_AVAILABLE(ios(10.0));
+@property (nonatomic, strong) UIView *customInputAccessoryView WK_API_AVAILABLE(ios(WK_IOS_TBA));
@property (nonatomic, copy) NSArray *suggestions WK_API_AVAILABLE(ios(10.0));
@property (nonatomic) BOOL accessoryViewShouldNotShow WK_API_AVAILABLE(ios(10.0));
@property (nonatomic) BOOL forceSecureTextEntry WK_API_AVAILABLE(ios(10.0));
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (236690 => 236691)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-10-01 20:44:06 UTC (rev 236690)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-10-01 20:59:19 UTC (rev 236691)
@@ -293,6 +293,7 @@
WeakObjCPtr _contentView;
RetainPtr _focusedElementInfo;
RetainPtr _customInputView;
+RetainPtr _customInputAccessoryView;
RetainPtr> _suggestions;
BOOL _accessoryViewShouldNotShow;
BOOL _forceSecureTextEntry;
@@ -383,6 +384,20 @@
[_contentView reloadInputViews];
}
+- (UIView *)customInputAccessoryView
+{
+return _customInputAccessoryView.get();
+}
+
+- (void)setCustomInputAccessoryView:(UIView *)customInputAccessoryView
+{
+if (_customInputAccessoryView ==
[webkit-changes] [236689] trunk/Source/WebKit
Title: [236689] trunk/Source/WebKit
Revision 236689
Author david_ques...@apple.com
Date 2018-10-01 13:38:47 -0700 (Mon, 01 Oct 2018)
Log Message
Add missing Objective-C versions of downloads SPI
https://bugs.webkit.org/show_bug.cgi?id=190149
rdar://problem/44915592
Reviewed by Alex Christensen.
* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _downloadURLRequest:]):
(-[WKProcessPool _resumeDownloadFromData:path:]):
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* UIProcess/API/Cocoa/_WKDownload.h:
* UIProcess/API/Cocoa/_WKDownload.mm:
(-[_WKDownload resumeData]):
* UIProcess/API/Cocoa/_WKDownloadInternal.h:
* UIProcess/Cocoa/DownloadClient.mm:
Move the DownloadProxy's WrapperTraits out of DownloadClient, and into the internal
header so it can be used from other classes (i.e. WKProcessPool here).
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownloadInternal.h
trunk/Source/WebKit/UIProcess/Cocoa/DownloadClient.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (236688 => 236689)
--- trunk/Source/WebKit/ChangeLog 2018-10-01 20:07:40 UTC (rev 236688)
+++ trunk/Source/WebKit/ChangeLog 2018-10-01 20:38:47 UTC (rev 236689)
@@ -1,3 +1,23 @@
+2018-10-01 David Quesada
+
+Add missing Objective-C versions of downloads SPI
+https://bugs.webkit.org/show_bug.cgi?id=190149
+rdar://problem/44915592
+
+Reviewed by Alex Christensen.
+
+* UIProcess/API/Cocoa/WKProcessPool.mm:
+(-[WKProcessPool _downloadURLRequest:]):
+(-[WKProcessPool _resumeDownloadFromData:path:]):
+* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
+* UIProcess/API/Cocoa/_WKDownload.h:
+* UIProcess/API/Cocoa/_WKDownload.mm:
+(-[_WKDownload resumeData]):
+* UIProcess/API/Cocoa/_WKDownloadInternal.h:
+* UIProcess/Cocoa/DownloadClient.mm:
+Move the DownloadProxy's WrapperTraits out of DownloadClient, and into the internal
+header so it can be used from other classes (i.e. WKProcessPool here).
+
2018-10-01 Alex Christensen
Fix internal build after r236665
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm (236688 => 236689)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm 2018-10-01 20:07:40 UTC (rev 236688)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm 2018-10-01 20:38:47 UTC (rev 236689)
@@ -43,6 +43,7 @@
#import "_WKAutomationDelegate.h"
#import "_WKAutomationSessionInternal.h"
#import "_WKDownloadDelegate.h"
+#import "_WKDownloadInternal.h"
#import "_WKProcessPoolConfigurationInternal.h"
#import
#import
@@ -573,6 +574,16 @@
}
#endif // PLATFORM(IOS)
+- (_WKDownload *)_downloadURLRequest:(NSURLRequest *)request
+{
+return (_WKDownload *)_processPool->download(nullptr, request)->wrapper();
+}
+
+- (_WKDownload *)_resumeDownloadFromData:(NSData *)resumeData path:(NSString *)path
+{
+return wrapper(_processPool->resumeDownload(API::Data::createWithoutCopying(resumeData).ptr(), path));
+}
+
@end
#endif // WK_API_ENABLED
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h (236688 => 236689)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h 2018-10-01 20:07:40 UTC (rev 236688)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h 2018-10-01 20:38:47 UTC (rev 236689)
@@ -29,6 +29,7 @@
#if WK_API_ENABLED
@class _WKAutomationSession;
+@class _WKDownload;
@class _WKProcessPoolConfiguration;
@protocol _WKAutomationDelegate;
@protocol _WKDownloadDelegate;
@@ -79,6 +80,9 @@
- (void)_registerURLSchemeAsCanDisplayOnlyIfCanRequest:(NSString *)scheme WK_API_AVAILABLE(macosx(10.14), ios(12.0));
+- (_WKDownload *)_downloadURLRequest:(NSURLRequest *)request WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
+- (_WKDownload *)_resumeDownloadFromData:(NSData *)resumeData path:(NSString *)path WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
+
// Test only. Should be called only while no web content processes are running.
- (void)_terminateStorageProcess;
- (void)_terminateNetworkProcess;
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.h (236688 => 236689)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.h 2018-10-01 20:07:40 UTC (rev 236688)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.h 2018-10-01 20:38:47 UTC (rev 236689)
@@ -40,6 +40,7 @@
@property (nonatomic, readonly, weak) WKWebView *originatingWebView;
@property (nonatomic, readonly, copy) NSArray *redirectChain WK_API_AVAILABLE(macosx(10.13.4), ios(11.3));
@property (nonatomic, readonly) BOOL wasUserInitiated WK_API_AVAILABLE(macosx(10.13.4), ios(11.3));
+@property (nonatomic, readonly) NSData
[webkit-changes] [236688] releases/WebKitGTK/webkit-2.22/Source/WebCore
Title: [236688] releases/WebKitGTK/webkit-2.22/Source/WebCore
Revision 236688
Author ape...@igalia.com
Date 2018-10-01 13:07:40 -0700 (Mon, 01 Oct 2018)
Log Message
Merge r236679 - [MSE][GStreamer] Set a minimum sample duration
https://bugs.webkit.org/show_bug.cgi?id=190125
Reviewed by Xabier Rodriguez-Calvar.
The last sample of the audio track in the asset used in this test
player has a tiny duration (100 ns):
http://orange-opensource.github.io/hasplayer.js/1.2.0/player.html?url=""
So small, we were truncating it to zero. We're not supposed to have
frames with zero duration. Instead, lets set a minimum frame duration
for those fringe cases.
* platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
Modified Paths
releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog (236687 => 236688)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2018-10-01 19:57:52 UTC (rev 236687)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2018-10-01 20:07:40 UTC (rev 236688)
@@ -1,3 +1,22 @@
+2018-10-01 Alicia Boya García
+
+[MSE][GStreamer] Set a minimum sample duration
+https://bugs.webkit.org/show_bug.cgi?id=190125
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+The last sample of the audio track in the asset used in this test
+player has a tiny duration (100 ns):
+
+http://orange-opensource.github.io/hasplayer.js/1.2.0/player.html?url=""
+
+So small, we were truncating it to zero. We're not supposed to have
+frames with zero duration. Instead, lets set a minimum frame duration
+for those fringe cases.
+
+* platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
+(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
+
2018-10-01 Olivier Blin
[WPE] fix buffer over-read in RenderThemeWPE::mediaControlsStyleSheet()
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp (236687 => 236688)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp 2018-10-01 19:57:52 UTC (rev 236687)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp 2018-10-01 20:07:40 UTC (rev 236688)
@@ -23,6 +23,8 @@
#include "GStreamerCommon.h"
+#include
+
#if ENABLE(VIDEO) && USE(GSTREAMER)
namespace WebCore {
@@ -34,6 +36,7 @@
, m_trackId(trackId)
, m_presentationSize(presentationSize)
{
+const GstClockTime minimumDuration = 1000; // 1 us
ASSERT(sample);
GstBuffer* buffer = gst_sample_get_buffer(sample.get());
RELEASE_ASSERT(buffer);
@@ -47,9 +50,14 @@
m_pts = createMediaTime(GST_BUFFER_PTS(buffer));
if (GST_BUFFER_DTS_IS_VALID(buffer) || GST_BUFFER_PTS_IS_VALID(buffer))
m_dts = createMediaTime(GST_BUFFER_DTS_OR_PTS(buffer));
-if (GST_BUFFER_DURATION_IS_VALID(buffer))
-m_duration = createMediaTime(GST_BUFFER_DURATION(buffer));
-else {
+if (GST_BUFFER_DURATION_IS_VALID(buffer)) {
+// Sometimes (albeit rarely, so far seen only at the end of a track)
+// frames have very small durations, so small that may be under the
+// precision we are working with and be truncated to zero.
+// SourceBuffer algorithms are not expecting frames with zero-duration,
+// so let's use something very small instead in those fringe cases.
+m_duration = createMediaTime(std::max(GST_BUFFER_DURATION(buffer), minimumDuration));
+} else {
// Unfortunately, sometimes samples don't provide a duration. This can never happen in MP4 because of the way
// the format is laid out, but it's pretty common in WebM.
// The good part is that durations don't matter for playback, just for buffered ranges and coded frame deletion.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236687] trunk/Source/WebKit
Title: [236687] trunk/Source/WebKit
Revision 236687
Author achristen...@apple.com
Date 2018-10-01 12:57:52 -0700 (Mon, 01 Oct 2018)
Log Message
Fix internal build after r236665
https://bugs.webkit.org/show_bug.cgi?id=189850
* UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.h:
* WebKit.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebKit/ChangeLog (236686 => 236687)
--- trunk/Source/WebKit/ChangeLog 2018-10-01 19:47:05 UTC (rev 236686)
+++ trunk/Source/WebKit/ChangeLog 2018-10-01 19:57:52 UTC (rev 236687)
@@ -1,3 +1,11 @@
+2018-10-01 Alex Christensen
+
+Fix internal build after r236665
+https://bugs.webkit.org/show_bug.cgi?id=189850
+
+* UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.h:
+* WebKit.xcodeproj/project.pbxproj:
+
2018-10-01 Jiewen Tan
[WebAuthN] Import a JS CBOR coder
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.h (236686 => 236687)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.h 2018-10-01 19:47:05 UTC (rev 236686)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.h 2018-10-01 19:57:52 UTC (rev 236687)
@@ -38,7 +38,6 @@
}
-WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKNavigationDelegate", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA))
@interface WKNSURLAuthenticationChallenge : WKObject
@end
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (236686 => 236687)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-10-01 19:47:05 UTC (rev 236686)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-10-01 19:57:52 UTC (rev 236687)
@@ -841,7 +841,7 @@
37F623B812A57B6200E3FDF6 /* WKFindOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 37F623B712A57B6200E3FDF6 /* WKFindOptions.h */; settings = {ATTRIBUTES = (Private, ); }; };
37F90DE31376560E0051CF68 /* HTTPCookieAcceptPolicy.h in Headers */ = {isa = PBXBuildFile; fileRef = F638954F133BEF38008941D5 /* HTTPCookieAcceptPolicy.h */; };
37FC19471850FBF2008CFA47 /* WKBrowsingContextLoadDelegatePrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 37FC19461850FBF2008CFA47 /* WKBrowsingContextLoadDelegatePrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 37FC194B18510D6A008CFA47 /* WKNSURLAuthenticationChallenge.h in Headers */ = {isa = PBXBuildFile; fileRef = 37FC194918510D6A008CFA47 /* WKNSURLAuthenticationChallenge.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 37FC194B18510D6A008CFA47 /* WKNSURLAuthenticationChallenge.h in Headers */ = {isa = PBXBuildFile; fileRef = 37FC194918510D6A008CFA47 /* WKNSURLAuthenticationChallenge.h */; };
3F418EF91887BD97002795FD /* VideoFullscreenManagerMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3F418EF51887BD97002795FD /* VideoFullscreenManagerMessageReceiver.cpp */; };
3F418EFB1887BD97002795FD /* VideoFullscreenManagerProxyMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3F418EF71887BD97002795FD /* VideoFullscreenManagerProxyMessageReceiver.cpp */; };
3F87B9BE158940190090FF62 /* WebColorChooser.h in Headers */ = {isa = PBXBuildFile; fileRef = 3F87B9BB15893F630090FF62 /* WebColorChooser.h */; };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236686] trunk
Title: [236686] trunk Revision 236686 Author jiewen_...@apple.com Date 2018-10-01 12:47:05 -0700 (Mon, 01 Oct 2018) Log Message [WebAuthN] Import a JS CBOR coder https://bugs.webkit.org/show_bug.cgi?id=189877 Reviewed by Chris Dumez. Source/WebKit: Update MockWebAuthenticationConfiguration to have userCertificateBase64 and intermediateCACertificateBase64 as Local's memeber such that tests can pass those certificates to MockLocalConnection instead of letting it holds some static ones. * UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreSetWebAuthenticationMockConfiguration): * UIProcess/WebAuthentication/Mock/MockLocalConnection.mm: (WebKit::MockLocalConnection::getAttestation const): * UIProcess/WebAuthentication/Mock/MockWebAuthenticationConfiguration.h: Tools: Add logic to only process privateKeyBase64, userCertificateBase64 and intermediateCACertificateBase64 only if acceptAttestation is true. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setWebAuthenticationMockConfiguration): LayoutTests: This patch import a 3rd party JS CBOR coder from https://github.com/paroga/cbor-js. The library is MIT licensed, which should be fine to use within WebKit. As a benefit from the library, tests are updated to check CBOR binaries. * http/wpt/credential-management/credentialscontainer-store-basics.https.html: * http/wpt/webauthn/idl.https.html: * http/wpt/webauthn/public-key-credential-create-failure-local.https.html: * http/wpt/webauthn/public-key-credential-create-success-local.https.html: * http/wpt/webauthn/public-key-credential-get-failure-local.https.html: * http/wpt/webauthn/public-key-credential-get-success-local.https.html: * http/wpt/webauthn/resources/cbor.js: Added. * http/wpt/webauthn/resources/util.js: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/wpt/credential-management/credentialscontainer-store-basics.https.html trunk/LayoutTests/http/wpt/webauthn/idl.https.html trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-local.https.html trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html trunk/LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-local.https.html trunk/LayoutTests/http/wpt/webauthn/public-key-credential-get-success-local.https.html trunk/LayoutTests/http/wpt/webauthn/resources/util.js trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockWebAuthenticationConfiguration.h trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp Added Paths trunk/LayoutTests/http/wpt/webauthn/resources/cbor.js Diff Modified: trunk/LayoutTests/ChangeLog (236685 => 236686) --- trunk/LayoutTests/ChangeLog 2018-10-01 19:45:24 UTC (rev 236685) +++ trunk/LayoutTests/ChangeLog 2018-10-01 19:47:05 UTC (rev 236686) @@ -1,3 +1,25 @@ +2018-10-01 Jiewen Tan + +[WebAuthN] Import a JS CBOR coder +https://bugs.webkit.org/show_bug.cgi?id=189877 + + +Reviewed by Chris Dumez. + +This patch import a 3rd party JS CBOR coder from https://github.com/paroga/cbor-js. +The library is MIT licensed, which should be fine to use within WebKit. + +As a benefit from the library, tests are updated to check CBOR binaries. + +* http/wpt/credential-management/credentialscontainer-store-basics.https.html: +* http/wpt/webauthn/idl.https.html: +* http/wpt/webauthn/public-key-credential-create-failure-local.https.html: +* http/wpt/webauthn/public-key-credential-create-success-local.https.html: +* http/wpt/webauthn/public-key-credential-get-failure-local.https.html: +* http/wpt/webauthn/public-key-credential-get-success-local.https.html: +* http/wpt/webauthn/resources/cbor.js: Added. +* http/wpt/webauthn/resources/util.js: + 2018-10-01 Daniel Bates [iOS] Special keys are misidentified in DOM keyboard events Modified: trunk/LayoutTests/http/wpt/credential-management/credentialscontainer-store-basics.https.html (236685 => 236686) --- trunk/LayoutTests/http/wpt/credential-management/credentialscontainer-store-basics.https.html 2018-10-01 19:45:24 UTC (rev 236685) +++ trunk/LayoutTests/http/wpt/credential-management/credentialscontainer-store-basics.https.html 2018-10-01 19:47:05 UTC (rev 236686) @@ -7,6 +7,31 @@ "BDj/zxSkzKgaBuS3cdWDF558of8AaIpgFpsjF/Qm1749VBJPgqUIwfhWHJ91nb7U" + "PH76c0+WFOzZKslPyyFse4goGIW2R7k9VHLPEZl5nfnBgEVFh5zev+/xpHQIvuq6" + "RQ=="; +const testAttestationCertificateBase64 = +"MIIB6jCCAZCgAwIBAgIGAWHAxcjvMAoGCCqGSM49BAMCMFMxJzAlBgNVBAMMHkJh" + +"c2ljIEF0dGVzdGF0aW9uIFVzZXIgU3ViIENBMTETMBEGA1UECgwKQXBwbGUgSW5j" + +"LjETMBEGA1UECAwKQ2FsaWZvcm5pYTAeFw0xODAyMjMwMzM3MjJaFw0xODAyMjQw" + +
[webkit-changes] [236685] releases/WebKitGTK/webkit-2.22/Source/WebCore
Title: [236685] releases/WebKitGTK/webkit-2.22/Source/WebCore
Revision 236685
Author ape...@igalia.com
Date 2018-10-01 12:45:24 -0700 (Mon, 01 Oct 2018)
Log Message
Merge r23 - [WPE] fix buffer over-read in RenderThemeWPE::mediaControlsStyleSheet()
https://bugs.webkit.org/show_bug.cgi?id=190139
Patch by Olivier Blin on 2018-10-01
Reviewed by Michael Catanzaro.
Like done upstream for EFL in r210213
https://bugs.webkit.org/show_bug.cgi?id=166622
This has been detected by a charactersAreAllASCII() assert failure.
This is because ASCIILiteral() is wrongly used in mediaControlsStyleSheet().
mediaControlsBaseUserAgentStyleSheet is a char array, not a null-terminated string.
It is thus incorrect to use StringImpl::createFromLiteral() that calls
strlen() to get the string length.
The String::ConstructFromLiteral constructor can not be used, since it
skips the last character.
* platform/wpe/RenderThemeWPE.cpp:
(WebCore::RenderThemeWPE::mediaControlsStyleSheet):
Explicitely pass the size to the String constructor.
Modified Paths
releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/wpe/RenderThemeWPE.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog (236684 => 236685)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2018-10-01 19:40:49 UTC (rev 236684)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2018-10-01 19:45:24 UTC (rev 236685)
@@ -1,3 +1,27 @@
+2018-10-01 Olivier Blin
+
+[WPE] fix buffer over-read in RenderThemeWPE::mediaControlsStyleSheet()
+https://bugs.webkit.org/show_bug.cgi?id=190139
+
+Reviewed by Michael Catanzaro.
+
+Like done upstream for EFL in r210213
+https://bugs.webkit.org/show_bug.cgi?id=166622
+
+This has been detected by a charactersAreAllASCII() assert failure.
+
+This is because ASCIILiteral() is wrongly used in mediaControlsStyleSheet().
+mediaControlsBaseUserAgentStyleSheet is a char array, not a null-terminated string.
+It is thus incorrect to use StringImpl::createFromLiteral() that calls
+strlen() to get the string length.
+
+The String::ConstructFromLiteral constructor can not be used, since it
+skips the last character.
+
+* platform/wpe/RenderThemeWPE.cpp:
+(WebCore::RenderThemeWPE::mediaControlsStyleSheet):
+Explicitely pass the size to the String constructor.
+
2018-09-27 Alicia Boya García
[MSE] Fix unwanted sample erase from the decode queue
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/wpe/RenderThemeWPE.cpp (236684 => 236685)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/wpe/RenderThemeWPE.cpp 2018-10-01 19:40:49 UTC (rev 236684)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/wpe/RenderThemeWPE.cpp 2018-10-01 19:45:24 UTC (rev 236685)
@@ -52,7 +52,7 @@
#if ENABLE(VIDEO)
String RenderThemeWPE::mediaControlsStyleSheet()
{
-return ASCIILiteral::fromLiteralUnsafe(mediaControlsBaseUserAgentStyleSheet);
+return String(mediaControlsBaseUserAgentStyleSheet, sizeof(mediaControlsBaseUserAgentStyleSheet));
}
String RenderThemeWPE::mediaControlsScript()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236684] trunk/JSTests
Title: [236684] trunk/JSTests
Revision 236684
Author commit-qu...@webkit.org
Date 2018-10-01 12:40:49 -0700 (Mon, 01 Oct 2018)
Log Message
Split NaN-check into separate test
https://bugs.webkit.org/show_bug.cgi?id=190010
Patch by Dominik Infuehr on 2018-10-01
Reviewed by Saam Barati.
DataView exposes NaN-representation, which is not necessarily the same on each
architecture. Therefore move the check of the NaN-representation into its own
file such that we can disable this test on MIPS where NaN-representation can be
different on older CPUs.
* stress/dataview-jit-set-nan.js: Added.
(assert):
(test.storeLittleEndian):
(test.storeBigEndian):
(test.store):
(test):
* stress/dataview-jit-set.js:
(test5):
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/dataview-jit-set.js
Added Paths
trunk/JSTests/stress/dataview-jit-set-nan.js
Diff
Modified: trunk/JSTests/ChangeLog (236683 => 236684)
--- trunk/JSTests/ChangeLog 2018-10-01 19:17:27 UTC (rev 236683)
+++ trunk/JSTests/ChangeLog 2018-10-01 19:40:49 UTC (rev 236684)
@@ -1,3 +1,24 @@
+2018-10-01 Dominik Infuehr
+
+Split NaN-check into separate test
+https://bugs.webkit.org/show_bug.cgi?id=190010
+
+Reviewed by Saam Barati.
+
+DataView exposes NaN-representation, which is not necessarily the same on each
+architecture. Therefore move the check of the NaN-representation into its own
+file such that we can disable this test on MIPS where NaN-representation can be
+different on older CPUs.
+
+* stress/dataview-jit-set-nan.js: Added.
+(assert):
+(test.storeLittleEndian):
+(test.storeBigEndian):
+(test.store):
+(test):
+* stress/dataview-jit-set.js:
+(test5):
+
2018-10-01 Commit Queue
Unreviewed, rolling out r236647.
Added: trunk/JSTests/stress/dataview-jit-set-nan.js (0 => 236684)
--- trunk/JSTests/stress/dataview-jit-set-nan.js (rev 0)
+++ trunk/JSTests/stress/dataview-jit-set-nan.js 2018-10-01 19:40:49 UTC (rev 236684)
@@ -0,0 +1,52 @@
+//@ skip if $architecture == "mips"
+
+"use strict";
+
+function assert(b) {
+if (!b)
+throw new Error;
+}
+
+function test() {
+function storeLittleEndian(dv, index, value) {
+dv.setFloat32(index, value, true);
+}
+noInline(storeLittleEndian);
+
+function storeBigEndian(dv, index, value) {
+dv.setFloat32(index, value, false);
+}
+noInline(storeBigEndian);
+
+function store(dv, index, value, littleEndian) {
+dv.setFloat32(index, value, littleEndian);
+}
+noInline(store);
+
+let buffer = new ArrayBuffer(4);
+let arr = new Float32Array(buffer);
+let bits = new Uint32Array(buffer);
+let dv = new DataView(buffer);
+
+for (let i = 0; i < 1; ++i) {
+storeLittleEndian(dv, 0, 1.5);
+assert(arr[0] === 1.5);
+
+storeLittleEndian(dv, 0, 12912.124123215122);
+assert(arr[0] === 12912.1240234375);
+assert(bits[0] === 0x4649c07f);
+
+storeLittleEndian(dv, 0, NaN);
+assert(isNaN(arr[0]));
+assert(bits[0] === 0x7FC0);
+
+storeLittleEndian(dv, 0, 2.3879393e-38);
+assert(arr[0] === 2.387939260590663e-38);
+assert(bits[0] === 0x01020304);
+
+storeBigEndian(dv, 0, 2.3879393e-38);
+assert(arr[0] === 1.539989614439558e-36);
+assert(bits[0] === 0x04030201);
+}
+}
+test();
\ No newline at end of file
Modified: trunk/JSTests/stress/dataview-jit-set.js (236683 => 236684)
--- trunk/JSTests/stress/dataview-jit-set.js 2018-10-01 19:17:27 UTC (rev 236683)
+++ trunk/JSTests/stress/dataview-jit-set.js 2018-10-01 19:40:49 UTC (rev 236684)
@@ -314,7 +314,6 @@
storeLittleEndian(dv, 0, NaN);
assert(isNaN(arr[0]));
-assert(bits[0] === 0x7FC0);
storeLittleEndian(dv, 0, 2.3879393e-38);
assert(arr[0] === 2.387939260590663e-38);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236682] releases/WebKitGTK/webkit-2.22/Source/WebCore
Title: [236682] releases/WebKitGTK/webkit-2.22/Source/WebCore
Revision 236682
Author ape...@igalia.com
Date 2018-10-01 12:17:19 -0700 (Mon, 01 Oct 2018)
Log Message
Merge r236409 - [MSE][GStreamer] Pull demuxed samples in batches
https://bugs.webkit.org/show_bug.cgi?id=189871
Reviewed by Xabier Rodriguez-Calvar.
After this patch, only the notifications of "new samples available"
(appsink-new-sample bus messages) travel from the streaming thread to
the main thread through the bus and the main thread is the responsible
of pulling as many samples as it can from appsink. Before, the samples
were pulled from appsink in the non-main thread and traveled to the
main thread through the bus one by one.
This reduces drastically the amount of context switches and waiting
time in the streaming thread, resulting in a noticeable performance
improvement.
This fixes stutter while loading YouTube videos.
* platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::AppendPipeline::clearPlayerPrivate):
(WebCore::AppendPipeline::handleApplicationMessage):
(WebCore::AppendPipeline::appsinkNewSample):
(WebCore::AppendPipeline::consumeAppSinkAvailableSamples):
(WebCore::AppendPipeline::resetPipeline):
(WebCore::AppendPipeline::handleNewAppsinkSample):
* platform/graphics/gstreamer/mse/AppendPipeline.h:
Modified Paths
releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp
releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h
Diff
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog (236681 => 236682)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2018-10-01 19:17:10 UTC (rev 236681)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2018-10-01 19:17:19 UTC (rev 236682)
@@ -1,3 +1,36 @@
+2018-09-24 Alicia Boya García
+
+[MSE][GStreamer] Pull demuxed samples in batches
+https://bugs.webkit.org/show_bug.cgi?id=189871
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+After this patch, only the notifications of "new samples available"
+(appsink-new-sample bus messages) travel from the streaming thread to
+the main thread through the bus and the main thread is the responsible
+of pulling as many samples as it can from appsink. Before, the samples
+were pulled from appsink in the non-main thread and traveled to the
+main thread through the bus one by one.
+
+This reduces drastically the amount of context switches and waiting
+time in the streaming thread, resulting in a noticeable performance
+improvement.
+
+This fixes stutter while loading YouTube videos.
+
+* platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
+(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
+* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
+(WebCore::AppendPipeline::AppendPipeline):
+(WebCore::AppendPipeline::~AppendPipeline):
+(WebCore::AppendPipeline::clearPlayerPrivate):
+(WebCore::AppendPipeline::handleApplicationMessage):
+(WebCore::AppendPipeline::appsinkNewSample):
+(WebCore::AppendPipeline::consumeAppSinkAvailableSamples):
+(WebCore::AppendPipeline::resetPipeline):
+(WebCore::AppendPipeline::handleNewAppsinkSample):
+* platform/graphics/gstreamer/mse/AppendPipeline.h:
+
2018-09-24 Enrique Ocaña González
[MSE][GStreamer] Don't update duration when it was not previously NaN
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp (236681 => 236682)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp 2018-10-01 19:17:10 UTC (rev 236681)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp 2018-10-01 19:17:19 UTC (rev 236682)
@@ -36,8 +36,7 @@
{
ASSERT(sample);
GstBuffer* buffer = gst_sample_get_buffer(sample.get());
-if (!buffer)
-return;
+RELEASE_ASSERT(buffer);
auto createMediaTime =
[](GstClockTime time) -> MediaTime {
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp (236681 => 236682)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp 2018-10-01 19:17:10 UTC (rev 236681)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp 2018-10-01 19:17:19 UTC (rev 236682)
@@ -108,6 +108,7 @@
,
[webkit-changes] [236683] releases/WebKitGTK/webkit-2.22
Title: [236683] releases/WebKitGTK/webkit-2.22
Revision 236683
Author ape...@igalia.com
Date 2018-10-01 12:17:27 -0700 (Mon, 01 Oct 2018)
Log Message
Merge r236566 - [MSE] Fix unwanted sample erase from the decode queue
https://bugs.webkit.org/show_bug.cgi?id=180643
Reviewed by Jer Noble.
Source/WebCore:
Test: media/media-source/media-source-append-acb-no-frame-lost.html
This bug reproduced when unordered appends were made. For instance, if
the application appended [0, 10) and then [20, 30), the frame at 20
would be wrongly discarded from the decode queue.
Later the application could append [10, 20) and the gap at [20, 21)
would persist in the decode queue, even if the frame remained in the
track buffer table.
Thanks to Daniel Zhang for reporting the issue.
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::provideMediaData):
LayoutTests:
Added a test case for the fixed bug.
* media/media-source/media-source-append-acb-no-frame-lost.html: Added.
Modified Paths
releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/Modules/mediasource/SourceBuffer.cpp
Added Paths
releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/media-source-append-acb-no-frame-lost-expected.txt
releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/media-source-append-acb-no-frame-lost.html
Diff
Modified: releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog (236682 => 236683)
--- releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog 2018-10-01 19:17:19 UTC (rev 236682)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/ChangeLog 2018-10-01 19:17:27 UTC (rev 236683)
@@ -1,3 +1,14 @@
+2018-09-27 Alicia Boya García
+
+[MSE] Fix unwanted sample erase from the decode queue
+https://bugs.webkit.org/show_bug.cgi?id=180643
+
+Reviewed by Jer Noble.
+
+Added a test case for the fixed bug.
+
+* media/media-source/media-source-append-acb-no-frame-lost.html: Added.
+
2018-09-15 Rob Buis
XMLHttpRequest::createResponseBlob() should create a Blob with type for empty response
Added: releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/media-source-append-acb-no-frame-lost-expected.txt (0 => 236683)
--- releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/media-source-append-acb-no-frame-lost-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.22/LayoutTests/media/media-source/media-source-append-acb-no-frame-lost-expected.txt 2018-10-01 19:17:27 UTC (rev 236683)
@@ -0,0 +1,46 @@
+
+EXPECTED (source.readyState == 'closed') OK
+EVENT(sourceopen)
+RUN(sourceBuffer = source.addSourceBuffer("video/mock; codecs=mock"))
+RUN(sourceBuffer.appendBuffer(initSegment))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(syncSampleRun(0, 10)))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(syncSampleRun(20, 30)))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(syncSampleRun(10, 20)))
+EVENT(updateend)
+EXPECTED (bufferedSamples.length == '30') OK
+EXPECTED (enqueuedSamples.length == '30') OK
+{PTS({0/1000 = 0.00}), DTS({0/1000 = 0.00}), duration({1000/1000 = 1.00}), flags(1), generation(0)}
+{PTS({1000/1000 = 1.00}), DTS({1000/1000 = 1.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({2000/1000 = 2.00}), DTS({2000/1000 = 2.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({3000/1000 = 3.00}), DTS({3000/1000 = 3.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({4000/1000 = 4.00}), DTS({4000/1000 = 4.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({5000/1000 = 5.00}), DTS({5000/1000 = 5.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({6000/1000 = 6.00}), DTS({6000/1000 = 6.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({7000/1000 = 7.00}), DTS({7000/1000 = 7.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({8000/1000 = 8.00}), DTS({8000/1000 = 8.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({9000/1000 = 9.00}), DTS({9000/1000 = 9.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({1/1000 = 10.00}), DTS({1/1000 = 10.00}), duration({1000/1000 = 1.00}), flags(1), generation(0)}
+{PTS({11000/1000 = 11.00}), DTS({11000/1000 = 11.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({12000/1000 = 12.00}), DTS({12000/1000 = 12.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({13000/1000 = 13.00}), DTS({13000/1000 = 13.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({14000/1000 = 14.00}), DTS({14000/1000 = 14.00}), duration({1000/1000 = 1.00}), flags(0), generation(0)}
+{PTS({15000/1000 = 15.00}), DTS({15000/1000 =
[webkit-changes] [236681] releases/WebKitGTK/webkit-2.22/Source/WebCore
Title: [236681] releases/WebKitGTK/webkit-2.22/Source/WebCore Revision 236681 Author ape...@igalia.com Date 2018-10-01 12:17:10 -0700 (Mon, 01 Oct 2018) Log Message Merge r236395 - [MSE][GStreamer] Don't update duration when it was not previously NaN https://bugs.webkit.org/show_bug.cgi?id=189869 Reviewed by Xabier Rodriguez-Calvar. This is what the spec mandates. The spec doesn't say anything about updating duration when it had been previously set, even if the new init segment says that the duration is growing. This fixes MSE YTTV 2018 69.MediaSourceDurationVP9. * platform/graphics/gstreamer/mse/AppendPipeline.cpp: (WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink): Modified Paths releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp Diff Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog (236680 => 236681) --- releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2018-10-01 18:57:02 UTC (rev 236680) +++ releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2018-10-01 19:17:10 UTC (rev 236681) @@ -1,3 +1,19 @@ +2018-09-24 Enrique Ocaña González + +[MSE][GStreamer] Don't update duration when it was not previously NaN +https://bugs.webkit.org/show_bug.cgi?id=189869 + +Reviewed by Xabier Rodriguez-Calvar. + +This is what the spec mandates. The spec doesn't say anything about +updating duration when it had been previously set, even if the new +init segment says that the duration is growing. + +This fixes MSE YTTV 2018 69.MediaSourceDurationVP9. + +* platform/graphics/gstreamer/mse/AppendPipeline.cpp: +(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink): + 2018-08-30 Ross Kirsling Speculative build fix for WPE after r235531. Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp (236680 => 236681) --- releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp 2018-10-01 18:57:02 UTC (rev 236680) +++ releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp 2018-10-01 19:17:10 UTC (rev 236681) @@ -1005,8 +1005,7 @@ } #endif -if (m_initialDuration > m_mediaSourceClient->duration() -|| (m_mediaSourceClient->duration().isInvalid() && m_initialDuration > MediaTime::zeroTime())) +if (m_mediaSourceClient->duration().isInvalid() && m_initialDuration > MediaTime::zeroTime()) m_mediaSourceClient->durationChanged(m_initialDuration); parseDemuxerSrcPadCaps(gst_caps_ref(caps.get())); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236680] trunk
Title: [236680] trunk
Revision 236680
Author cdu...@apple.com
Date 2018-10-01 11:57:02 -0700 (Mon, 01 Oct 2018)
Log Message
Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=190052
Reviewed by Ryosuke Niwa.
Source/WebKit:
* Platform/IPC/Connection.cpp:
(IPC::Connection::sendMessage):
* Platform/IPC/Connection.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePagePostMessageIgnoringFullySynchronousMode):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::postMessageIgnoringFullySynchronousMode):
* WebProcess/WebPage/WebPage.h:
Tools:
The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
to log those events. It also uses console.log() before sending those events to indicate what the test is about
to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
so that it can log the message.
The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
handler to be transformed into synchronous IPC.
As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
messages may end up being out of order, leading to flakiness.
To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicated
that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::outputText):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/Connection.cpp
trunk/Source/WebKit/Platform/IPC/Connection.h
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (236679 => 236680)
--- trunk/Source/WebKit/ChangeLog 2018-10-01 18:38:49 UTC (rev 236679)
+++ trunk/Source/WebKit/ChangeLog 2018-10-01 18:57:02 UTC (rev 236680)
@@ -1,3 +1,20 @@
+2018-10-01 Chris Dumez
+
+Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=190052
+
+Reviewed by Ryosuke Niwa.
+
+* Platform/IPC/Connection.cpp:
+(IPC::Connection::sendMessage):
+* Platform/IPC/Connection.h:
+* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
+(WKBundlePagePostMessageIgnoringFullySynchronousMode):
+* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::postMessageIgnoringFullySynchronousMode):
+* WebProcess/WebPage/WebPage.h:
+
2018-10-01 Daniel Bates
[iOS] Special keys are misidentified in DOM keyboard events
Modified: trunk/Source/WebKit/Platform/IPC/Connection.cpp (236679 => 236680)
--- trunk/Source/WebKit/Platform/IPC/Connection.cpp 2018-10-01 18:38:49 UTC (rev 236679)
+++ trunk/Source/WebKit/Platform/IPC/Connection.cpp 2018-10-01 18:57:02 UTC (rev 236680)
@@ -400,7 +400,7 @@
if (!isValid())
return false;
-if (isMainThread() && m_inDispatchMessageMarkedToUseFullySynchronousModeForTesting && !encoder->isSyncMessage() && !(encoder->messageReceiverName() == "IPC")) {
+if (isMainThread() && m_inDispatchMessageMarkedToUseFullySynchronousModeForTesting && !encoder->isSyncMessage() && !(encoder->messageReceiverName() == "IPC") && !sendOptions.contains(SendOption::IgnoreFullySynchronousMode)) {
uint64_t syncRequestID;
auto wrappedMessage = createSyncMessageEncoder("IPC", "WrappedAsyncMessageForTesting", encoder->destinationID(), syncRequestID);
wrappedMessage->setFullySynchronousModeForTesting();
Modified: trunk/Source/WebKit/Platform/IPC/Connection.h (236679 => 236680)
--- trunk/Source/WebKit/Platform/IPC/Connection.h 2018-10-01 18:38:49 UTC (rev 236679)
+++ trunk/Source/WebKit/Platform/IPC/Connection.h 2018-10-01 18:57:02 UTC (rev 236680)
@@ -61,6 +61,7 @@
// Whether this message should be dispatched when waiting for a sync reply.
// This is the default for synchronous messages.
DispatchMessageEvenWhenWaitingForSyncReply = 1 << 0,
+IgnoreFullySynchronousMode = 1 << 1,
};
enum class SendSyncOption {
[webkit-changes] [236679] trunk/Source/WebCore
Title: [236679] trunk/Source/WebCore
Revision 236679
Author ab...@igalia.com
Date 2018-10-01 11:38:49 -0700 (Mon, 01 Oct 2018)
Log Message
[MSE][GStreamer] Set a minimum sample duration
https://bugs.webkit.org/show_bug.cgi?id=190125
Reviewed by Xabier Rodriguez-Calvar.
The last sample of the audio track in the asset used in this test
player has a tiny duration (100 ns):
http://orange-opensource.github.io/hasplayer.js/1.2.0/player.html?url=""
So small, we were truncating it to zero. We're not supposed to have
frames with zero duration. Instead, lets set a minimum frame duration
for those fringe cases.
* platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (236678 => 236679)
--- trunk/Source/WebCore/ChangeLog 2018-10-01 18:35:37 UTC (rev 236678)
+++ trunk/Source/WebCore/ChangeLog 2018-10-01 18:38:49 UTC (rev 236679)
@@ -1,3 +1,22 @@
+2018-10-01 Alicia Boya García
+
+[MSE][GStreamer] Set a minimum sample duration
+https://bugs.webkit.org/show_bug.cgi?id=190125
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+The last sample of the audio track in the asset used in this test
+player has a tiny duration (100 ns):
+
+http://orange-opensource.github.io/hasplayer.js/1.2.0/player.html?url=""
+
+So small, we were truncating it to zero. We're not supposed to have
+frames with zero duration. Instead, lets set a minimum frame duration
+for those fringe cases.
+
+* platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
+(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
+
2018-10-01 Daniel Bates
[iOS] Special keys are misidentified in DOM keyboard events
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp (236678 => 236679)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp 2018-10-01 18:35:37 UTC (rev 236678)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp 2018-10-01 18:38:49 UTC (rev 236679)
@@ -23,6 +23,8 @@
#include "GStreamerCommon.h"
+#include
+
#if ENABLE(VIDEO) && USE(GSTREAMER)
namespace WebCore {
@@ -34,6 +36,7 @@
, m_trackId(trackId)
, m_presentationSize(presentationSize)
{
+const GstClockTime minimumDuration = 1000; // 1 us
ASSERT(sample);
GstBuffer* buffer = gst_sample_get_buffer(sample.get());
RELEASE_ASSERT(buffer);
@@ -47,9 +50,14 @@
m_pts = createMediaTime(GST_BUFFER_PTS(buffer));
if (GST_BUFFER_DTS_IS_VALID(buffer) || GST_BUFFER_PTS_IS_VALID(buffer))
m_dts = createMediaTime(GST_BUFFER_DTS_OR_PTS(buffer));
-if (GST_BUFFER_DURATION_IS_VALID(buffer))
-m_duration = createMediaTime(GST_BUFFER_DURATION(buffer));
-else {
+if (GST_BUFFER_DURATION_IS_VALID(buffer)) {
+// Sometimes (albeit rarely, so far seen only at the end of a track)
+// frames have very small durations, so small that may be under the
+// precision we are working with and be truncated to zero.
+// SourceBuffer algorithms are not expecting frames with zero-duration,
+// so let's use something very small instead in those fringe cases.
+m_duration = createMediaTime(std::max(GST_BUFFER_DURATION(buffer), minimumDuration));
+} else {
// Unfortunately, sometimes samples don't provide a duration. This can never happen in MP4 because of the way
// the format is laid out, but it's pretty common in WebM.
// The good part is that durations don't matter for playback, just for buffered ranges and coded frame deletion.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236678] trunk
Title: [236678] trunk Revision 236678 Author dba...@webkit.org Date 2018-10-01 11:35:37 -0700 (Mon, 01 Oct 2018) Log Message [iOS] Special keys are misidentified in DOM keyboard events https://bugs.webkit.org/show_bug.cgi?id=189974 Reviewed by Wenson Hsieh. Source/WebCore: This patch fixes two issues: 1. Special keyboard keys would be misidentified in dispatched DOM keyboard events. 2. DOM keypress events may not be dispatched for some special keys. UIKit uses special input strings to identify the Page Up, Page Down, Escape, Up Arrow, Down Arrow, Left Arrow, and Right Arrow keys. It also uses ASCII control characters to represent some other special keys, including Num Lock / Clear, Home, End, Forward Delete, and F1, ..., F24. We need to explicitly handle these special keyboard keys in order to be able to identify the key that was pressed as well as to correctly disambiguate a key down to know whether to dispatch a DOM keypress event for the key. Unlike UIKit, AppKit reserves Unicode Private Use Area (PUA) code points in 0xF700–0xF8FF to represent special keyboard keys. This makes it straightforward to disambiguate such keys using the input string of the keyboard event alone. To simplify the implementation for iOS we normalize the input string be AppKit compatible. See the explaination for WebCore::windowsKeyCodeForCharCode() below for more details on why this is done. Tests: fast/events/ios/keydown-keyup-arrow-keys-in-non-editable-element.html fast/events/ios/keypress-keys-in-non-editable-element.html * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: Do not use unified source build strategy when building WebEvent.mm as it makes use of SoftLinking macros that are incompatible with this strategy. * platform/ios/KeyEventIOS.mm: (WebCore::windowsKeyCodeForCharCode): Recognize some special AppKit special char codes. These special char codes are generated by WebKit. WebKit uses the same special char codes as AppKit as a convenience instead of defining our own constants for the same purpose. Encoding the special UIKit input strings (e.g. up arrow) as distinct char codes allows us to use integer arithmetic and switch blocks to map characters to Windows virtual key codes as opposed to special cased branches to perform pointer or string comparisions. The latter would be necessary in Modern WebKit in order for key down events to be properly disambiguated to dispatch a DOM keypress event because pointers are not perserved, though what they point to is, when sending the WebEvent from UIProcess to the WebProcess and vice versa. (WebCore::isFunctionKey): Convenience function that determines whether the specified char code corresponds to a function key on the keyboard. The term "function key" is taken from AppKit parlance to describe a special keyboard key. These keys include F1, F2, ..., F24, and cursor keys among other special keyboard keys. (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): Write in terms of isFunctionKey(). * platform/ios/PlatformEventFactoryIOS.h: * platform/ios/PlatformEventFactoryIOS.mm: (WebCore::keyIdentifierForKeyEvent): Remove code to handle UIKit special input strings as we now map such special input strings to char codes and hence can use the default code path. (WebCore::keyForKeyEvent): Ditto. (WebCore::codeForKeyEvent): Remove code to compute the Window virtual key code corresponding to a UIKit special key command now that we map such special input strings to char codes and subsequently map the char codes to the Windows virtual key code (see -[WebEvent initWithKeyEventType:...] constructors). So, we can now use WebEvent.keyCode directly to compute the DOM UIEvents code for the event. (WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder): Remove code to fix up WebEvent.keyCode to account for UIKit special input strings now that we map such special key commands to char codes and subsequently map the char codes to the Windows virtual key code (see -[WebEvent initWithKeyEventType:...] constructors). So, we can now take WebEvent.keyCode verbatim to be the Window virtual key code. (WebCore::convertSpecialKeyToCharCode): Deleted. (WebCore::keyCodeForEvent): Deleted. * platform/ios/WebEvent.mm: (normalizedStringWithAppKitCompatibilityMapping): Added; converts a UIKit character string to the corresponding AppKit-compatible one (if not already compatible). See the explaination for WebCore::windowsKeyCodeForCharCode() above for more details on why this is done. (-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]): (-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:]): Normalize the character strings to be AppKit compatible. Source/WebCore/PAL: Forward declare or define more SPI. * pal/spi/cocoa/IOKitSPI.h: * pal/spi/ios/UIKitSPI.h:
[webkit-changes] [236677] trunk/Source/WebCore
Title: [236677] trunk/Source/WebCore
Revision 236677
Author simon.fra...@apple.com
Date 2018-10-01 11:32:32 -0700 (Mon, 01 Oct 2018)
Log Message
Optimize RenderStyle::diff() and clean up the code
https://bugs.webkit.org/show_bug.cgi?id=190104
Reviewed by Dan Bernstein.
RenderStyle::changeRequiresLayout() and related should only check values on
m_rareNonInheritedData and m_rareInheritedData after checking for pointer equality.
To reduce the chances of future changes regressing this, move code comparing values
on StyleRare[Non]InheritedData into dedication functions.
In addition, the transform comparison double-compared the transformOperations,
because m_rareNonInheritedData->transform != other.m_rareNonInheritedData->transform
is a deep comparison, and it was followed by *m_rareNonInheritedData->transform != *other.m_rareNonInheritedData->transform.
Change the first to be a pointer comparison.
* rendering/style/RenderStyle.cpp:
(WebCore::rareNonInheritedDataChangeRequiresLayout):
(WebCore::rareInheritedDataChangeRequiresLayout):
(WebCore::RenderStyle::changeRequiresLayout const):
(WebCore::rareNonInheritedDataChangeRequiresLayerRepaint):
(WebCore::RenderStyle::changeRequiresLayerRepaint const):
(WebCore::rareNonInheritedDataChangeRequiresRepaint):
(WebCore::rareInheritedDataChangeRequiresRepaint):
(WebCore::RenderStyle::changeRequiresRepaint const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (236676 => 236677)
--- trunk/Source/WebCore/ChangeLog 2018-10-01 18:27:55 UTC (rev 236676)
+++ trunk/Source/WebCore/ChangeLog 2018-10-01 18:32:32 UTC (rev 236677)
@@ -1,3 +1,30 @@
+2018-10-01 Simon Fraser
+
+Optimize RenderStyle::diff() and clean up the code
+https://bugs.webkit.org/show_bug.cgi?id=190104
+
+Reviewed by Dan Bernstein.
+
+RenderStyle::changeRequiresLayout() and related should only check values on
+m_rareNonInheritedData and m_rareInheritedData after checking for pointer equality.
+To reduce the chances of future changes regressing this, move code comparing values
+on StyleRare[Non]InheritedData into dedication functions.
+
+In addition, the transform comparison double-compared the transformOperations,
+because m_rareNonInheritedData->transform != other.m_rareNonInheritedData->transform
+is a deep comparison, and it was followed by *m_rareNonInheritedData->transform != *other.m_rareNonInheritedData->transform.
+Change the first to be a pointer comparison.
+
+* rendering/style/RenderStyle.cpp:
+(WebCore::rareNonInheritedDataChangeRequiresLayout):
+(WebCore::rareInheritedDataChangeRequiresLayout):
+(WebCore::RenderStyle::changeRequiresLayout const):
+(WebCore::rareNonInheritedDataChangeRequiresLayerRepaint):
+(WebCore::RenderStyle::changeRequiresLayerRepaint const):
+(WebCore::rareNonInheritedDataChangeRequiresRepaint):
+(WebCore::rareInheritedDataChangeRequiresRepaint):
+(WebCore::RenderStyle::changeRequiresRepaint const):
+
2018-10-01 Alex Christensen
URL should not use TextEncoding internally
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (236676 => 236677)
--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2018-10-01 18:27:55 UTC (rev 236676)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2018-10-01 18:32:32 UTC (rev 236677)
@@ -550,162 +550,221 @@
return false;
}
-bool RenderStyle::changeRequiresLayout(const RenderStyle& other, OptionSet& changedContextSensitiveProperties) const
+static bool rareNonInheritedDataChangeRequiresLayout(const StyleRareNonInheritedData& first, const StyleRareNonInheritedData& second, OptionSet& changedContextSensitiveProperties)
{
-if (m_boxData->width() != other.m_boxData->width()
-|| m_boxData->minWidth() != other.m_boxData->minWidth()
-|| m_boxData->maxWidth() != other.m_boxData->maxWidth()
-|| m_boxData->height() != other.m_boxData->height()
-|| m_boxData->minHeight() != other.m_boxData->minHeight()
-|| m_boxData->maxHeight() != other.m_boxData->maxHeight())
+ASSERT( != );
+
+if (first.appearance != second.appearance
+|| first.marginBeforeCollapse != second.marginBeforeCollapse
+|| first.marginAfterCollapse != second.marginAfterCollapse
+|| first.lineClamp != second.lineClamp
+|| first.initialLetter != second.initialLetter
+|| first.textOverflow != second.textOverflow)
return true;
-if (m_boxData->verticalAlign() != other.m_boxData->verticalAlign() || m_nonInheritedFlags.verticalAlign != other.m_nonInheritedFlags.verticalAlign)
+if (first.shapeMargin != second.shapeMargin)
return true;
-if (m_boxData->boxSizing() != other.m_boxData->boxSizing())
+if (first.deprecatedFlexibleBox !=
[webkit-changes] [236676] trunk/Source
Title: [236676] trunk/Source Revision 236676 Author kocsen_ch...@apple.com Date 2018-10-01 11:27:55 -0700 (Mon, 01 Oct 2018) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebCore/PAL/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/Configurations/Version.xcconfig trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (236675 => 236676) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2018-10-01 18:27:30 UTC (rev 236675) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2018-10-01 18:27:55 UTC (rev 236676) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 8; +TINY_VERSION = 9; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (236675 => 236676) --- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-10-01 18:27:30 UTC (rev 236675) +++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-10-01 18:27:55 UTC (rev 236676) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 8; +TINY_VERSION = 9; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (236675 => 236676) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2018-10-01 18:27:30 UTC (rev 236675) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2018-10-01 18:27:55 UTC (rev 236676) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 8; +TINY_VERSION = 9; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (236675 => 236676) --- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-10-01 18:27:30 UTC (rev 236675) +++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-10-01 18:27:55 UTC (rev 236676) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 8; +TINY_VERSION = 9; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (236675 => 236676) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-10-01 18:27:30 UTC (rev 236675) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-10-01 18:27:55 UTC (rev 236676) @@ -1,6 +1,6 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 8; +TINY_VERSION = 9; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (236675 => 236676) --- trunk/Source/WebKit/Configurations/Version.xcconfig 2018-10-01 18:27:30 UTC (rev 236675) +++ trunk/Source/WebKit/Configurations/Version.xcconfig 2018-10-01 18:27:55 UTC (rev 236676) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 8; +TINY_VERSION = 9; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (236675 => 236676) --- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-10-01 18:27:30 UTC (rev 236675) +++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-10-01 18:27:55 UTC (rev 236676) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 8; +TINY_VERSION = 9; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236675] trunk/Source/WebKit
Title: [236675] trunk/Source/WebKit
Revision 236675
Author achristen...@apple.com
Date 2018-10-01 11:27:30 -0700 (Mon, 01 Oct 2018)
Log Message
Fix an internal build after r236665
https://bugs.webkit.org/show_bug.cgi?id=189850
* WebKit.xcodeproj/project.pbxproj:
Make WKNSURLAuthenticationChallenge.h a private header.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebKit/ChangeLog (236674 => 236675)
--- trunk/Source/WebKit/ChangeLog 2018-10-01 18:16:33 UTC (rev 236674)
+++ trunk/Source/WebKit/ChangeLog 2018-10-01 18:27:30 UTC (rev 236675)
@@ -1,5 +1,13 @@
2018-10-01 Alex Christensen
+Fix an internal build after r236665
+https://bugs.webkit.org/show_bug.cgi?id=189850
+
+* WebKit.xcodeproj/project.pbxproj:
+Make WKNSURLAuthenticationChallenge.h a private header.
+
+2018-10-01 Alex Christensen
+
URL should not use TextEncoding internally
https://bugs.webkit.org/show_bug.cgi?id=190111
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (236674 => 236675)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-10-01 18:16:33 UTC (rev 236674)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-10-01 18:27:30 UTC (rev 236675)
@@ -841,7 +841,7 @@
37F623B812A57B6200E3FDF6 /* WKFindOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 37F623B712A57B6200E3FDF6 /* WKFindOptions.h */; settings = {ATTRIBUTES = (Private, ); }; };
37F90DE31376560E0051CF68 /* HTTPCookieAcceptPolicy.h in Headers */ = {isa = PBXBuildFile; fileRef = F638954F133BEF38008941D5 /* HTTPCookieAcceptPolicy.h */; };
37FC19471850FBF2008CFA47 /* WKBrowsingContextLoadDelegatePrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 37FC19461850FBF2008CFA47 /* WKBrowsingContextLoadDelegatePrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 37FC194B18510D6A008CFA47 /* WKNSURLAuthenticationChallenge.h in Headers */ = {isa = PBXBuildFile; fileRef = 37FC194918510D6A008CFA47 /* WKNSURLAuthenticationChallenge.h */; };
+ 37FC194B18510D6A008CFA47 /* WKNSURLAuthenticationChallenge.h in Headers */ = {isa = PBXBuildFile; fileRef = 37FC194918510D6A008CFA47 /* WKNSURLAuthenticationChallenge.h */; settings = {ATTRIBUTES = (Private, ); }; };
3F418EF91887BD97002795FD /* VideoFullscreenManagerMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3F418EF51887BD97002795FD /* VideoFullscreenManagerMessageReceiver.cpp */; };
3F418EFB1887BD97002795FD /* VideoFullscreenManagerProxyMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 3F418EF71887BD97002795FD /* VideoFullscreenManagerProxyMessageReceiver.cpp */; };
3F87B9BE158940190090FF62 /* WebColorChooser.h in Headers */ = {isa = PBXBuildFile; fileRef = 3F87B9BB15893F630090FF62 /* WebColorChooser.h */; };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236674] trunk
Title: [236674] trunk
Revision 236674
Author achristen...@apple.com
Date 2018-10-01 11:16:33 -0700 (Mon, 01 Oct 2018)
Log Message
URL should not use TextEncoding internally
https://bugs.webkit.org/show_bug.cgi?id=190111
Reviewed by Andy Estes.
Source/WebCore:
That dependency makes it impossible to move or use elsewhere.
Using TextEncoding was overkill because we know the credentials are UTF-8 percent-encoded in a parsed URL.
No change in behavior as verified by new API tests.
* page/SecurityOrigin.cpp:
* page/csp/ContentSecurityPolicySourceList.cpp:
* platform/URL.cpp:
(WebCore::decodeEscapeSequencesFromParsedURL):
(WebCore::URL::user const):
(WebCore::URL::pass const):
(WebCore::URL::fileSystemPath const):
(WebCore::decodeURLEscapeSequences): Deleted.
* platform/URL.h:
* platform/network/DataURLDecoder.cpp:
* platform/text/TextEncoding.cpp:
(WebCore::decodeURLEscapeSequences):
* platform/text/TextEncoding.h:
Source/WebKit:
* UIProcess/WebInspectorProxy.cpp:
Source/WebKitLegacy/mac:
* Misc/WebNSURLExtras.mm:
Tools:
* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::testUserPass):
(TestWebKitAPI::TEST_F):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/SecurityOrigin.cpp
trunk/Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp
trunk/Source/WebCore/platform/URL.cpp
trunk/Source/WebCore/platform/URL.h
trunk/Source/WebCore/platform/network/DataURLDecoder.cpp
trunk/Source/WebCore/platform/text/TextEncoding.cpp
trunk/Source/WebCore/platform/text/TextEncoding.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
trunk/Source/WebKit/UIProcess/API/glib/WebKitFileChooserRequest.cpp
trunk/Source/WebKit/UIProcess/WebInspectorProxy.cpp
trunk/Source/WebKit/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Misc/WebNSURLExtras.mm
trunk/Source/WebKitLegacy/win/WebDownloadCurl.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (236673 => 236674)
--- trunk/Source/WebCore/ChangeLog 2018-10-01 18:08:35 UTC (rev 236673)
+++ trunk/Source/WebCore/ChangeLog 2018-10-01 18:16:33 UTC (rev 236674)
@@ -1,3 +1,28 @@
+2018-10-01 Alex Christensen
+
+URL should not use TextEncoding internally
+https://bugs.webkit.org/show_bug.cgi?id=190111
+
+Reviewed by Andy Estes.
+
+That dependency makes it impossible to move or use elsewhere.
+Using TextEncoding was overkill because we know the credentials are UTF-8 percent-encoded in a parsed URL.
+No change in behavior as verified by new API tests.
+
+* page/SecurityOrigin.cpp:
+* page/csp/ContentSecurityPolicySourceList.cpp:
+* platform/URL.cpp:
+(WebCore::decodeEscapeSequencesFromParsedURL):
+(WebCore::URL::user const):
+(WebCore::URL::pass const):
+(WebCore::URL::fileSystemPath const):
+(WebCore::decodeURLEscapeSequences): Deleted.
+* platform/URL.h:
+* platform/network/DataURLDecoder.cpp:
+* platform/text/TextEncoding.cpp:
+(WebCore::decodeURLEscapeSequences):
+* platform/text/TextEncoding.h:
+
2018-10-01 Simon Pieters
in quirks mode should have margin-block-end: 1em
Modified: trunk/Source/WebCore/page/SecurityOrigin.cpp (236673 => 236674)
--- trunk/Source/WebCore/page/SecurityOrigin.cpp 2018-10-01 18:08:35 UTC (rev 236673)
+++ trunk/Source/WebCore/page/SecurityOrigin.cpp 2018-10-01 18:16:33 UTC (rev 236674)
@@ -34,6 +34,7 @@
#include "URL.h"
#include "SchemeRegistry.h"
#include "SecurityPolicy.h"
+#include "TextEncoding.h"
#include "ThreadableBlobRegistry.h"
#include
#include
Modified: trunk/Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp (236673 => 236674)
--- trunk/Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp 2018-10-01 18:08:35 UTC (rev 236673)
+++ trunk/Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp 2018-10-01 18:16:33 UTC (rev 236674)
@@ -30,6 +30,7 @@
#include "ContentSecurityPolicy.h"
#include "ContentSecurityPolicyDirectiveNames.h"
#include "ParsingUtilities.h"
+#include "TextEncoding.h"
#include "URL.h"
#include
#include
Modified: trunk/Source/WebCore/platform/URL.cpp (236673 => 236674)
--- trunk/Source/WebCore/platform/URL.cpp 2018-10-01 18:08:35 UTC (rev 236673)
+++ trunk/Source/WebCore/platform/URL.cpp 2018-10-01 18:16:33 UTC (rev 236674)
@@ -27,8 +27,6 @@
#include "config.h"
#include "URL.h"
-#include "DecodeEscapeSequences.h"
-#include "TextEncoding.h"
#include "URLParser.h"
#include
#include
@@ -187,9 +185,30 @@
return result;
}
+static String decodeEscapeSequencesFromParsedURL(StringView input)
+{
+auto inputLength = input.length();
+if (!inputLength)
+return emptyString();
+Vector percentDecoded;
+percentDecoded.reserveInitialCapacity(inputLength);
+for (unsigned i
[webkit-changes] [236673] trunk
Title: [236673] trunk
Revision 236673
Author commit-qu...@webkit.org
Date 2018-10-01 11:08:35 -0700 (Mon, 01 Oct 2018)
Log Message
in quirks mode should have margin-block-end: 1em
https://bugs.webkit.org/show_bug.cgi?id=157788
Patch by Simon Pieters on 2018-10-01
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
* web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html: Added.
* web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt: Added.
Source/WebCore:
Change the default style for forms to take writing-mode into account
in quirks mode. Matches the behavior of Gecko and Edge and the HTML
standard.
Spec: https://html.spec.whatwg.org/multipage/rendering.html#flow-content-3
Test: imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html
* css/quirks.css:
(form):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/quirks.css
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/
trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/
trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/
trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (236672 => 236673)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-10-01 18:06:41 UTC (rev 236672)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-10-01 18:08:35 UTC (rev 236673)
@@ -1,3 +1,13 @@
+2018-10-01 Simon Pieters
+
+ in quirks mode should have margin-block-end: 1em
+https://bugs.webkit.org/show_bug.cgi?id=157788
+
+Reviewed by Simon Fraser.
+
+* web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html: Added.
+* web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt: Added.
+
2018-10-01 Rob Buis
Align XMLHttpRequest's overrideMimeType() with the standard
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt (0 => 236673)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt 2018-10-01 18:08:35 UTC (rev 236673)
@@ -0,0 +1,3 @@
+
+PASS form margin quirk
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html (0 => 236673)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html 2018-10-01 18:08:35 UTC (rev 236673)
@@ -0,0 +1,20 @@
+
+form margin quirk
+
+form { writing-mode: vertical-lr; }
+#ref { margin: 0 1em 0 0; }
+
+
+
+