[webkit-changes] [238950] trunk/Tools

[jbedard]

Title: [238950] trunk/Tools








Revision 238950
Author jbed...@apple.com
Date 2018-12-06 22:18:33 -0800 (Thu, 06 Dec 2018)


Log Message
Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903
https://bugs.webkit.org/show_bug.cgi?id=192486

Unreviewed infrastructure fix.

WinCairo bots define WEBKIT_TEST_CHILD_PROCESSES to run less processes due to RAM restrictions.


* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py




Diff

Modified: trunk/Tools/ChangeLog (238949 => 238950)

--- trunk/Tools/ChangeLog	2018-12-07 05:51:30 UTC (rev 238949)
+++ trunk/Tools/ChangeLog	2018-12-07 06:18:33 UTC (rev 238950)
@@ -1,3 +1,15 @@
+2018-12-06  Jonathan Bedard  
+
+Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903
+https://bugs.webkit.org/show_bug.cgi?id=192486
+
+Unreviewed infrastructure fix.
+
+WinCairo bots define WEBKIT_TEST_CHILD_PROCESSES to run less processes due to RAM restrictions.
+
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+(_set_up_derived_options):
+
 2018-12-06  David Kilzer  
 
 Injected bundle for WebKitTestRunner leaks WKTypeRef objects


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (238949 => 238950)

--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2018-12-07 05:51:30 UTC (rev 238949)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2018-12-07 06:18:33 UTC (rev 238950)
@@ -370,6 +370,9 @@
 
 def _set_up_derived_options(port, options):
 """Sets the options values that depend on other options values."""
+if not options.child_processes:
+options.child_processes = os.environ.get('WEBKIT_TEST_CHILD_PROCESSES')
+
 if not options.configuration:
 options.configuration = port.default_configuration()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238949] trunk/Source

[ap]

Title: [238949] trunk/Source








Revision 238949
Author a...@apple.com
Date 2018-12-06 21:51:30 -0800 (Thu, 06 Dec 2018)


Log Message
Move USE_NEW_THEME out of WebCore's config.h
https://bugs.webkit.org/show_bug.cgi?id=192426

Reviewed by Tim Horton.

Source/WebCore:

* config.h:

Source/WTF:

* wtf/Platform.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/config.h




Diff

Modified: trunk/Source/WTF/ChangeLog (238948 => 238949)

--- trunk/Source/WTF/ChangeLog	2018-12-07 05:34:21 UTC (rev 238948)
+++ trunk/Source/WTF/ChangeLog	2018-12-07 05:51:30 UTC (rev 238949)
@@ -1,3 +1,12 @@
+2018-12-06  Alexey Proskuryakov  
+
+Move USE_NEW_THEME out of WebCore's config.h
+https://bugs.webkit.org/show_bug.cgi?id=192426
+
+Reviewed by Tim Horton.
+
+* wtf/Platform.h:
+
 2018-12-04  Carlos Garcia Campos  
 
 [SOUP] Move URLSoup back to WebCore after r238771


Modified: trunk/Source/WTF/wtf/Platform.h (238948 => 238949)

--- trunk/Source/WTF/wtf/Platform.h	2018-12-07 05:34:21 UTC (rev 238948)
+++ trunk/Source/WTF/wtf/Platform.h	2018-12-07 05:51:30 UTC (rev 238949)
@@ -1418,3 +1418,12 @@
 #define USE_CFNETWORK_AUTO_ADDED_HTTP_HEADER_SUPPRESSION 1
 #endif
 #endif
+
+#ifdef __APPLE__
+#define HAVE_FUNC_USLEEP 1
+#endif
+
+#if PLATFORM(MAC) || PLATFORM(WPE)
+/* FIXME: This really needs a descriptive name, this "new theme" was added in 2008. */
+#define USE_NEW_THEME 1
+#endif


Modified: trunk/Source/WebCore/ChangeLog (238948 => 238949)

--- trunk/Source/WebCore/ChangeLog	2018-12-07 05:34:21 UTC (rev 238948)
+++ trunk/Source/WebCore/ChangeLog	2018-12-07 05:51:30 UTC (rev 238949)
@@ -1,3 +1,12 @@
+2018-12-06  Alexey Proskuryakov  
+
+Move USE_NEW_THEME out of WebCore's config.h
+https://bugs.webkit.org/show_bug.cgi?id=192426
+
+Reviewed by Tim Horton.
+
+* config.h:
+
 2018-12-06  Frederic Wang  
 
 Allow control over child order when adding nodes to the scrolling tree


Modified: trunk/Source/WebCore/config.h (238948 => 238949)

--- trunk/Source/WebCore/config.h	2018-12-07 05:34:21 UTC (rev 238948)
+++ trunk/Source/WebCore/config.h	2018-12-07 05:51:30 UTC (rev 238949)
@@ -33,10 +33,6 @@
 #include <_javascript_Core/JSExportMacros.h>
 #include 
 
-#ifdef __APPLE__
-#define HAVE_FUNC_USLEEP 1
-#endif /* __APPLE__ */
-
 // Using CMake with Unix makefiles does not use prefix headers.
 #if PLATFORM(MAC) && defined(BUILDING_WITH_CMAKE)
 #include "WebCorePrefix.h"
@@ -56,10 +52,6 @@
 
 #include 
 
-#if PLATFORM(MAC) || PLATFORM(WPE)
-#define USE_NEW_THEME 1
-#endif
-
 #if USE(CG)
 #ifndef CGFLOAT_DEFINED
 #if (defined(__LP64__) && __LP64__) || (defined(__x86_64__) && __x86_64__) || defined(_M_X64) || defined(__amd64__)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238948] trunk

[ddkilzer]

Title: [238948] trunk








Revision 238948
Author ddkil...@apple.com
Date 2018-12-06 21:34:21 -0800 (Thu, 06 Dec 2018)


Log Message
Injected bundle for WebKitTestRunner leaks WKTypeRef objects



Reviewed by Simon Fraser.

Source/WebKit:

Change function parameter name from `returnData[Ref]` to
`returnRetainedData[Ref]` to document that the value returned is
a +1 retained WKTypeRef object.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundlePostSynchronousMessage):
* WebProcess/InjectedBundle/API/c/WKBundle.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePagePostSynchronousMessageForTesting):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:

Tools:

This patch:
- Fixes leaks in various injected bundle methods that return +1
  retained WKTypeRef objects via pointer.
- Asserts the returned object is the expected WKTypeRef.
- Replaces 0 with nullptr in many places.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didCreatePage):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::shouldDumpPixels const):
(WTR::TestRunner::whatToDump const):
(WTR::TestRunner::shouldWaitUntilDone const):
(WTR::TestRunner::shouldDumpFrameLoadCallbacks):
(WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
(WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
(WTR::TestRunner::secureEventInputIsEnabled const):
(WTR::TestRunner::isStatisticsPrevalentResource):
(WTR::TestRunner::isStatisticsVeryPrevalentResource):
(WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
(WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
(WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
(WTR::TestRunner::isStatisticsHasHadUserInteraction):
(WTR::TestRunner::isStatisticsGrandfathered):
(WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
(WTR::TestRunner::statisticsUpdateCookieBlocking):
(WTR::TestRunner::statisticsSubmitTelemetry):
(WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
(WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
(WTR::TestRunner::statisticsResetToConsistentState):
(WTR::TestRunner::getAllStorageAccessEntries):
(WTR::TestRunner::hasDOMCache):
(WTR::TestRunner::domCacheSize):
(WTR::TestRunner::injectUserScript):
(WTR::TestRunner::keyExistsInKeychain):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.h
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (238947 => 238948)

--- trunk/Source/WebKit/ChangeLog	2018-12-07 01:47:04 UTC (rev 238947)
+++ trunk/Source/WebKit/ChangeLog	2018-12-07 05:34:21 UTC (rev 238948)
@@ -1,3 +1,22 @@
+2018-12-06  David Kilzer  
+
+Injected bundle for WebKitTestRunner leaks WKTypeRef objects
+
+
+
+Reviewed by Simon Fraser.
+
+Change function parameter name from `returnData[Ref]` to
+`returnRetainedData[Ref]` to document that the value returned is
+a +1 retained WKTypeRef object.
+
+* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
+(WKBundlePostSynchronousMessage):
+* WebProcess/InjectedBundle/API/c/WKBundle.h:
+* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
+(WKBundlePagePostSynchronousMessageForTesting):
+* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
+
 2018-12-06  Frederic Wang  
 
 Allow control over child order when adding nodes to the scrolling tree


Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp (238947 => 238948)

--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp	2018-12-07 01:47:04 UTC (rev 238947)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp	2018-12-07 05:34:21 UTC (rev 238948)
@@ -68,12 +68,12 @@
 WebKit::toImpl(bundleRef)->postMessage(WebKit::toWTFString(messageNameRef), WebKit::toImpl(messageBodyRef));
 }
 
-void WKBundlePostSynchronousMessage(WKBundleRef bundleRef, WKStringRef messageNameRef, WKTypeRef messageBodyRef, WKTypeRef* returnDataRef)
+void WKBundlePostSynchronousMessage(WKBundleRef bundleRef, WKStringRef messageNameRef, WKTypeRef messageBodyRef, WKTypeRef* returnRetainedDataRef)
 {
 RefPtr returnData;
 WebKit::toImpl(bundleRef)->postSynchronousMessage(WebKit::toWTFString(messageNameRef), WebKit::toImpl(messageBodyRef), returnData);
-if (returnDataRef)
-*returnDataRef = WebKit::toAPI(returnData.leakRef());
+if (returnRetainedDataRef)
+*returnRetainedDataRef = WebKit::toAPI(returnData.leakRef());
 }
 
 WKConnectionRef WKBundleGetApplicationConnection(WKBundleRef bundleRef)


Modified: 

[webkit-changes] [238947] trunk/Source

[commit-queue]

Title: [238947] trunk/Source








Revision 238947
Author commit-qu...@webkit.org
Date 2018-12-06 17:47:04 -0800 (Thu, 06 Dec 2018)


Log Message
Allow control over child order when adding nodes to the scrolling tree
https://bugs.webkit.org/show_bug.cgi?id=176914

Patch by Frederic Wang  on 2018-12-06
Reviewed by Simon Fraser.

Based on an earlier patch by Simon Fraser.

Source/WebCore:

Previously ScrollingCoordinator just allowed nodes to be "attached" with a given parent,
but with no control over sibling order. To allow for correct hit-testing overflow and
frame scrolling nodes, we have to build the scrolling tree in z-order.

This patch adds a 'childIndex' parameter to attachNode() which gives control over
sibling order. For now, RenderLayerCompositor always uses the default 'notFound' value
for childIndex so the current behavior (appending new nodes at the end of child list) is
preserved.

No new tests, behavior unchanged and already covered by existing tests.

* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::attachToStateTree):
(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):
* page/scrolling/AsyncScrollingCoordinator.h:
* page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::attachToStateTree):
* page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::insertChild):
(WebCore::ScrollingStateNode::indexOfChild const):
* page/scrolling/ScrollingStateNode.h:
* page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::nodeTypeAndParentMatch const):
(WebCore::ScrollingStateTree::attachNode):
* page/scrolling/ScrollingStateTree.h:

Source/WebKit:

* Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingCoordinatorTransaction::decode): Make explicit that we want to append
the new node at the end of child list.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h
trunk/Source/WebCore/page/scrolling/ScrollingStateNode.cpp
trunk/Source/WebCore/page/scrolling/ScrollingStateNode.h
trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp
trunk/Source/WebCore/page/scrolling/ScrollingStateTree.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238946 => 238947)

--- trunk/Source/WebCore/ChangeLog	2018-12-07 01:35:25 UTC (rev 238946)
+++ trunk/Source/WebCore/ChangeLog	2018-12-07 01:47:04 UTC (rev 238947)
@@ -1,3 +1,38 @@
+2018-12-06  Frederic Wang  
+
+Allow control over child order when adding nodes to the scrolling tree
+https://bugs.webkit.org/show_bug.cgi?id=176914
+
+Reviewed by Simon Fraser.
+
+Based on an earlier patch by Simon Fraser.
+
+Previously ScrollingCoordinator just allowed nodes to be "attached" with a given parent,
+but with no control over sibling order. To allow for correct hit-testing overflow and
+frame scrolling nodes, we have to build the scrolling tree in z-order.
+
+This patch adds a 'childIndex' parameter to attachNode() which gives control over
+sibling order. For now, RenderLayerCompositor always uses the default 'notFound' value
+for childIndex so the current behavior (appending new nodes at the end of child list) is
+preserved.
+
+No new tests, behavior unchanged and already covered by existing tests.
+
+* page/scrolling/AsyncScrollingCoordinator.cpp:
+(WebCore::AsyncScrollingCoordinator::attachToStateTree):
+(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):
+* page/scrolling/AsyncScrollingCoordinator.h:
+* page/scrolling/ScrollingCoordinator.h:
+(WebCore::ScrollingCoordinator::attachToStateTree):
+* page/scrolling/ScrollingStateNode.cpp:
+(WebCore::ScrollingStateNode::insertChild):
+(WebCore::ScrollingStateNode::indexOfChild const):
+* page/scrolling/ScrollingStateNode.h:
+* page/scrolling/ScrollingStateTree.cpp:
+(WebCore::ScrollingStateTree::nodeTypeAndParentMatch const):
+(WebCore::ScrollingStateTree::attachNode):
+* page/scrolling/ScrollingStateTree.h:
+
 2018-12-06  Yongjun Zhang  
 
 We should ignore minimumEffectiveDeviceWidth if the page specifies device-width in viewport meta-tag.


Modified: trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp (238946 => 238947)

--- trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp	2018-12-07 01:35:25 UTC (rev 238946)
+++ trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp	2018-12-07 01:47:04 UTC (rev 238947)
@@ -474,9 +474,9 @@
 scrollableArea.horizontalScrollbarLayerDidChange();
 }
 
-ScrollingNodeID 

[webkit-changes] [238946] trunk

[commit-queue]

Title: [238946] trunk








Revision 238946
Author commit-qu...@webkit.org
Date 2018-12-06 17:35:25 -0800 (Thu, 06 Dec 2018)


Log Message
We should ignore minimumEffectiveDeviceWidth if the page specifies device-width in viewport meta-tag.
https://bugs.webkit.org/show_bug.cgi?id=192377


Patch by Yongjun Zhang  on 2018-12-06
Reviewed by Tim Horton.

Source/WebCore:

If the page specifies width=device-width or initial-scale=1 in the viewport meta tag, we should use the
native device width and ignore the minimum effective device width in ViewportConfiguration. The patch
also introduces scalableNativeWebpageParameters() which uses the device width as default and also allows the page
to shrink-to-fit. If a page doesn't have viewport meta tag, or if the width argument isn't device-width
and the initial scale isn't 1, we will use scalableNativeWebpageParameters() as the default configuration.

Tests: fast/viewport/ios/ignore-minimum-device-width-for-page-with-viewport-device-width.html
   fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta.html

* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::updateDefaultConfiguration): pick the default configuration based on
the page's viewport arguments. Also, we will always fall back to scalableNativeWebpageParameters() if we
can ignore scaling constraints.
(WebCore::ViewportConfiguration::setViewportArguments): When page sends us new ViewportArguments, pick
up the correponsding default configuration before updating the configuration.
(WebCore::ViewportConfiguration::setCanIgnoreScalingConstraints): When m_canIgnoreScalingConstraints is
changed, try to pick up the correponsding default configuration.
(WebCore::ViewportConfiguration::scalableNativeWebpageParameters): Add a new default set of viewport Parameters
this is very close to nativeWebpageParameters() excpet that it allows shrink to fit and its minimum scale
is 0.25. We will use this Parameters for pages that doesn't have viewport meta tag; or the width is
not device-width and initial scale is not 1.
(WebCore::ViewportConfiguration::updateConfiguration): If the page's viewport argument doesn't override
the default width, use the m_minimumLayoutSize.width().
* page/ViewportConfiguration.h:
(WebCore::ViewportConfiguration::shouldIgnoreMinimumEffectiveDeviceWidth const): A helper method to tell
if we should avoid using minimum effective device width.
(WebCore::ViewportConfiguration::canOverrideConfigurationParameters const): If we are using a default
configuration that is neither nativeWebpageParameters() nor scalableNativeWebpageParameters(), don't override
it.
(WebCore::ViewportConfiguration::minimumEffectiveDeviceWidth const): Add a helper method to return minimum
effective device width based on shouldIgnoreMinimumEffectiveDeviceWidth().
(WebCore::ViewportConfiguration::effectiveLayoutSizeScaleFactor const): Use minimumEffectiveDeviceWidth().

Source/WebKit:

Since we are using page's viewport arguments to decide the default viewport parameters and
whether we can use mininum effective device width, we should always call setViewportArguments()
regardless of shouldIgnoreMetaViewport settings.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewportPropertiesDidChange): Always call setViewportArguments().
(WebKit::WebPage::didCommitLoad): Ditto.

LayoutTests:

* fast/viewport/ios/ignore-minimum-device-width-for-page-with-viewport-device-width-expected.txt: Added.
* fast/viewport/ios/ignore-minimum-device-width-for-page-with-viewport-device-width.html: Added.
* fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta-expected.txt: Added.
* fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ViewportConfiguration.cpp
trunk/Source/WebCore/page/ViewportConfiguration.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp


Added Paths

trunk/LayoutTests/fast/viewport/ios/ignore-minimum-device-width-for-page-with-viewport-device-width-expected.txt
trunk/LayoutTests/fast/viewport/ios/ignore-minimum-device-width-for-page-with-viewport-device-width.html
trunk/LayoutTests/fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta-expected.txt
trunk/LayoutTests/fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta.html




Diff

Modified: trunk/LayoutTests/ChangeLog (238945 => 238946)

--- trunk/LayoutTests/ChangeLog	2018-12-06 23:48:36 UTC (rev 238945)
+++ trunk/LayoutTests/ChangeLog	2018-12-07 01:35:25 UTC (rev 238946)
@@ -1,3 +1,16 @@
+2018-12-06  Yongjun Zhang  
+
+We should ignore minimumEffectiveDeviceWidth if the page specifies device-width in viewport meta-tag.
+https://bugs.webkit.org/show_bug.cgi?id=192377
+
+
+Reviewed by Tim Horton.
+
+* 

[webkit-changes] [238945] tags/Safari-606.4.3/

[alancoon]

Title: [238945] tags/Safari-606.4.3/








Revision 238945
Author alanc...@apple.com
Date 2018-12-06 15:48:36 -0800 (Thu, 06 Dec 2018)


Log Message
Tag Safari-606.4.3.

Added Paths

tags/Safari-606.4.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238944] trunk/Tools

[jbedard]

Title: [238944] trunk/Tools








Revision 238944
Author jbed...@apple.com
Date 2018-12-06 15:21:33 -0800 (Thu, 06 Dec 2018)


Log Message
REGRESSION: run-webkit-tests may fail when using booted simulators
https://bugs.webkit.org/show_bug.cgi?id=192470


Reviewed by Lucas Forschler.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Logging uses the number of child processes to print out information about how efficiently tests
were sharded after the fact. This number is the most meaningful if it is the maximum number of child processes used.
* Scripts/webkitpy/port/base.py:
(Port.max_child_processes): By default, Ports do not support running on any specific kind of device.
* Scripts/webkitpy/port/device_port.py:
(DevicePort.default_child_processes): Rather than using the currently initialized devices as a proxy for how many
child processes are being used, check the device manager every time. Regardless of which devices are attached or
available, iOS cannot boot watchOS devices and vice-versa. dedicated_simulators is not a known argument to
device_count_for_type, use use_booted_simulator instead.
(DevicePort.max_child_processes): Simulators can boot more devices than what is specified by device_count_for_type,
but, if no devices are available, then max_child_processes should return 0 even for simulators.
* Scripts/webkitpy/port/ios_device_unittest.py:
(IOSDeviceTest):
(IOSDeviceTest.test_max_child_processes):
* Scripts/webkitpy/port/ios_simulator_unittest.py:
(IOSSimulatorTest):
(IOSSimulatorTest.test_max_child_processes):
* Scripts/webkitpy/port/port_testcase.py:
(PortTestCase):
(PortTestCase.test_max_child_processes):
* Scripts/webkitpy/port/watch_simulator_unittest.py:
(WatchSimulatorTest):
(WatchSimulatorTest.test_max_child_processes):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
trunk/Tools/Scripts/webkitpy/port/base.py
trunk/Tools/Scripts/webkitpy/port/device_port.py
trunk/Tools/Scripts/webkitpy/port/ios_device_unittest.py
trunk/Tools/Scripts/webkitpy/port/ios_simulator_unittest.py
trunk/Tools/Scripts/webkitpy/port/port_testcase.py
trunk/Tools/Scripts/webkitpy/port/watch_simulator_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (238943 => 238944)

--- trunk/Tools/ChangeLog	2018-12-06 23:05:36 UTC (rev 238943)
+++ trunk/Tools/ChangeLog	2018-12-06 23:21:33 UTC (rev 238944)
@@ -1,5 +1,38 @@
 2018-12-06  Jonathan Bedard  
 
+REGRESSION: run-webkit-tests may fail when using booted simulators
+https://bugs.webkit.org/show_bug.cgi?id=192470
+
+
+Reviewed by Lucas Forschler.
+
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(Manager.run): Logging uses the number of child processes to print out information about how efficiently tests
+were sharded after the fact. This number is the most meaningful if it is the maximum number of child processes used.
+* Scripts/webkitpy/port/base.py:
+(Port.max_child_processes): By default, Ports do not support running on any specific kind of device.
+* Scripts/webkitpy/port/device_port.py:
+(DevicePort.default_child_processes): Rather than using the currently initialized devices as a proxy for how many
+child processes are being used, check the device manager every time. Regardless of which devices are attached or
+available, iOS cannot boot watchOS devices and vice-versa. dedicated_simulators is not a known argument to
+device_count_for_type, use use_booted_simulator instead.
+(DevicePort.max_child_processes): Simulators can boot more devices than what is specified by device_count_for_type,
+but, if no devices are available, then max_child_processes should return 0 even for simulators.
+* Scripts/webkitpy/port/ios_device_unittest.py:
+(IOSDeviceTest):
+(IOSDeviceTest.test_max_child_processes):
+* Scripts/webkitpy/port/ios_simulator_unittest.py:
+(IOSSimulatorTest):
+(IOSSimulatorTest.test_max_child_processes):
+* Scripts/webkitpy/port/port_testcase.py:
+(PortTestCase):
+(PortTestCase.test_max_child_processes):
+* Scripts/webkitpy/port/watch_simulator_unittest.py:
+(WatchSimulatorTest):
+(WatchSimulatorTest.test_max_child_processes):
+
+2018-12-06  Jonathan Bedard  
+
 webkitpy: Ignore case when comparing device types (Follow-up fix)
 https://bugs.webkit.org/show_bug.cgi?id=192409
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (238943 => 238944)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2018-12-06 23:05:36 UTC (rev 238943)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2018-12-06 23:21:33 UTC (rev 238944)
@@ -245,6 +245,7 @@
 retry_results = None
 enabled_pixel_tests_in_retry = False
 
+max_child_processes_for_run = 1
 

[webkit-changes] [238943] trunk/Tools

[jbedard]

Title: [238943] trunk/Tools








Revision 238943
Author jbed...@apple.com
Date 2018-12-06 15:05:36 -0800 (Thu, 06 Dec 2018)


Log Message
webkitpy: Ignore case when comparing device types (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=192409


Unreviewed typo fix.


* Scripts/webkitpy/xcode/device_type_unittest.py:
(DeviceTypeTest.test_comparison_lower_case):
(DeviceTypeTest.test_comparsion_lower_case): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (238942 => 238943)

--- trunk/Tools/ChangeLog	2018-12-06 22:34:54 UTC (rev 238942)
+++ trunk/Tools/ChangeLog	2018-12-06 23:05:36 UTC (rev 238943)
@@ -1,5 +1,17 @@
 2018-12-06  Jonathan Bedard  
 
+webkitpy: Ignore case when comparing device types (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=192409
+
+
+Unreviewed typo fix.
+
+* Scripts/webkitpy/xcode/device_type_unittest.py:
+(DeviceTypeTest.test_comparison_lower_case):
+(DeviceTypeTest.test_comparsion_lower_case): Deleted.
+
+2018-12-06  Jonathan Bedard  
+
 webkitpy: Create device given lower-case DeviceType
 
 


Modified: trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py (238942 => 238943)

--- trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py	2018-12-06 22:34:54 UTC (rev 238942)
+++ trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py	2018-12-06 23:05:36 UTC (rev 238943)
@@ -144,7 +144,7 @@
 self.assertTrue(DeviceType.from_string('iPhone', Version(11, 1)) in DeviceType.from_string('iPhone', Version(11)))
 self.assertFalse(DeviceType.from_string('iPhone', Version(11)) in DeviceType.from_string('iPhone', Version(11, 1)))
 
-def test_comparsion_lower_case(self):
+def test_comparison_lower_case(self):
 self.assertEqual(DeviceType.from_string('iphone X'), DeviceType.from_string('iPhone'))
 self.assertEqual(DeviceType.from_string('iphone'), DeviceType.from_string('iPhone X'))
 self.assertEqual(DeviceType.from_string('iPhone X'), DeviceType.from_string('iphone'))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238942] trunk/Source/WebCore

[aperez]

Title: [238942] trunk/Source/WebCore








Revision 238942
Author ape...@igalia.com
Date 2018-12-06 14:34:54 -0800 (Thu, 06 Dec 2018)


Log Message
Content Extensions: Misc fixes to debugging / perf testing code
https://bugs.webkit.org/show_bug.cgi?id=192474

Reviewed by Mark Lam.

This make it possible to build the content extensions support with the
debugging features enabled. In particular, building with
CONTENT_EXTENSIONS_PERFORMANCE_REPORTING enabled was broken.

No new tests needed.

* contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList): Remove usage of removed
variables machinesWihthoutConditionsCount,
totalBytecodeSizeForMachinesWithoutConditions,
machinesWithConditionsCount, and
totalBytecodeSizeForMachinesWithConditions.
* contentextensions/DFA.cpp:
(WebCore::ContentExtensions::DFA::debugPrintDot const):
Use "%" PRIu64 instead of "%llu" to format uint64_t values.
* contentextensions/NFA.cpp:
(WebCore::ContentExtensions::NFA::debugPrintDot const):
Use "%" PRIu64 instead of "%llu" to format uint64_t values.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp
trunk/Source/WebCore/contentextensions/DFA.cpp
trunk/Source/WebCore/contentextensions/NFA.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238941 => 238942)

--- trunk/Source/WebCore/ChangeLog	2018-12-06 22:11:45 UTC (rev 238941)
+++ trunk/Source/WebCore/ChangeLog	2018-12-06 22:34:54 UTC (rev 238942)
@@ -1,3 +1,29 @@
+2018-12-06  Adrian Perez de Castro  
+
+Content Extensions: Misc fixes to debugging / perf testing code
+https://bugs.webkit.org/show_bug.cgi?id=192474
+
+Reviewed by Mark Lam.
+
+This make it possible to build the content extensions support with the
+debugging features enabled. In particular, building with
+CONTENT_EXTENSIONS_PERFORMANCE_REPORTING enabled was broken.
+
+No new tests needed.
+
+* contentextensions/ContentExtensionCompiler.cpp:
+(WebCore::ContentExtensions::compileRuleList): Remove usage of removed
+variables machinesWihthoutConditionsCount,
+totalBytecodeSizeForMachinesWithoutConditions,
+machinesWithConditionsCount, and
+totalBytecodeSizeForMachinesWithConditions.
+* contentextensions/DFA.cpp:
+(WebCore::ContentExtensions::DFA::debugPrintDot const):
+Use "%" PRIu64 instead of "%llu" to format uint64_t values.
+* contentextensions/NFA.cpp:
+(WebCore::ContentExtensions::NFA::debugPrintDot const):
+Use "%" PRIu64 instead of "%llu" to format uint64_t values.
+
 2018-12-06  Alex Christensen  
 
 Remove unused LoaderStrategy::storeDerivedDataToCache and associated dead code


Modified: trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp (238941 => 238942)

--- trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp	2018-12-06 22:11:45 UTC (rev 238941)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp	2018-12-06 22:34:54 UTC (rev 238942)
@@ -427,9 +427,6 @@
 #if CONTENT_EXTENSIONS_PERFORMANCE_REPORTING
 MonotonicTime totalNFAToByteCodeBuildTimeEnd = MonotonicTime::now();
 dataLogF("Time spent building and compiling the DFAs: %f\n", (totalNFAToByteCodeBuildTimeEnd - totalNFAToByteCodeBuildTimeStart).seconds());
-
-dataLogF("Number of machines without condition filters: %d (total bytecode size = %d)\n", machinesWithoutConditionsCount, totalBytecodeSizeForMachinesWithoutConditions);
-dataLogF("Number of machines with condition filters: %d (total bytecode size = %d)\n", machinesWithConditionsCount, totalBytecodeSizeForMachinesWithConditions);
 #endif
 
 client.finalize();


Modified: trunk/Source/WebCore/contentextensions/DFA.cpp (238941 => 238942)

--- trunk/Source/WebCore/contentextensions/DFA.cpp	2018-12-06 22:11:45 UTC (rev 238941)
+++ trunk/Source/WebCore/contentextensions/DFA.cpp	2018-12-06 22:34:54 UTC (rev 238942)
@@ -152,7 +152,7 @@
 for (unsigned actionIndex = 0; actionIndex < actions.size(); ++actionIndex) {
 if (actionIndex)
 dataLogF(", ");
-dataLogF("%llu", actions[actionIndex]);
+dataLogF("%" PRIu64, actions[actionIndex]);
 }
 }
 dataLogF(">]");


Modified: trunk/Source/WebCore/contentextensions/NFA.cpp (238941 => 238942)

--- trunk/Source/WebCore/contentextensions/NFA.cpp	2018-12-06 22:11:45 UTC (rev 238941)
+++ trunk/Source/WebCore/contentextensions/NFA.cpp	2018-12-06 22:34:54 UTC (rev 238942)
@@ -54,7 +54,7 @@
 for (unsigned actionIndex = node.actionStart; actionIndex < node.actionEnd; ++actionIndex) {
 if (!isFirst)
 dataLogF(", ");
-dataLogF("%llu", actions[actionIndex]);
+dataLogF("%" PRIu64, actions[actionIndex]);
 isFirst = false;
 }
 

[webkit-changes] [238941] trunk/Source/WebKit

[timothy_horton]

Title: [238941] trunk/Source/WebKit








Revision 238941
Author timothy_hor...@apple.com
Date 2018-12-06 14:11:45 -0800 (Thu, 06 Dec 2018)


Log Message
Web Share API: share overlay does not stick to the Safari window
https://bugs.webkit.org/show_bug.cgi?id=192469


Reviewed by Wenson Hsieh.

* UIProcess/Cocoa/WKShareSheet.mm:
(-[WKShareSheet sharingServicePicker:didChooseSharingService:]):
(-[WKShareSheet sharingServicePicker:delegateForSharingService:]):
(-[WKShareSheet sharingService:sourceWindowForShareItems:sharingContentScope:]):
(-[WKShareSheet sharingService:didFailToShareItems:error:]):
(-[WKShareSheet sharingService:didShareItems:]):
Implement another NSSharingServicePickerDelegate method to return
an *NSSharingService* delegate when needed.

Implement an NSSharingServiceDelegate method to return the window that
the service's UI should attach to.

Also, instead of notifying the Web Content process when a service is picked
(or not) in the NSSharingServicePicker, wait until the share has completed
(or failed) to send didComplete. This both makes the return completion
value more accurate (matching iOS, if you cancel the share during the
recipient choice step, it will now fail), and avoids explicitly tearing
down the NSSharingServicePicker too early, which breaks the UI attaching mechanism.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (238940 => 238941)

--- trunk/Source/WebKit/ChangeLog	2018-12-06 22:09:19 UTC (rev 238940)
+++ trunk/Source/WebKit/ChangeLog	2018-12-06 22:11:45 UTC (rev 238941)
@@ -1,3 +1,30 @@
+2018-12-06  Tim Horton  
+
+Web Share API: share overlay does not stick to the Safari window
+https://bugs.webkit.org/show_bug.cgi?id=192469
+
+
+Reviewed by Wenson Hsieh.
+
+* UIProcess/Cocoa/WKShareSheet.mm:
+(-[WKShareSheet sharingServicePicker:didChooseSharingService:]):
+(-[WKShareSheet sharingServicePicker:delegateForSharingService:]):
+(-[WKShareSheet sharingService:sourceWindowForShareItems:sharingContentScope:]):
+(-[WKShareSheet sharingService:didFailToShareItems:error:]):
+(-[WKShareSheet sharingService:didShareItems:]):
+Implement another NSSharingServicePickerDelegate method to return
+an *NSSharingService* delegate when needed.
+
+Implement an NSSharingServiceDelegate method to return the window that
+the service's UI should attach to.
+
+Also, instead of notifying the Web Content process when a service is picked
+(or not) in the NSSharingServicePicker, wait until the share has completed
+(or failed) to send didComplete. This both makes the return completion
+value more accurate (matching iOS, if you cancel the share during the
+recipient choice step, it will now fail), and avoids explicitly tearing
+down the NSSharingServicePicker too early, which breaks the UI attaching mechanism.
+
 2018-12-06  Wenson Hsieh  
 
 [iOS] WKWebView should match UITextView behavior when editing text with an RTL keyboard


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm (238940 => 238941)

--- trunk/Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm	2018-12-06 22:09:19 UTC (rev 238940)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm	2018-12-06 22:11:45 UTC (rev 238941)
@@ -42,7 +42,7 @@
 #endif
 
 #if PLATFORM(MAC)
-@interface WKShareSheet () 
+@interface WKShareSheet () 
 @end
 #endif
 
@@ -124,9 +124,35 @@
 #if PLATFORM(MAC)
 - (void)sharingServicePicker:(NSSharingServicePicker *)sharingServicePicker didChooseSharingService:(NSSharingService *)service
 {
-[self _didCompleteWithSuccess:!!service];
+if (service)
+return;
+
+[self _didCompleteWithSuccess:NO];
 [self dispatchDidDismiss];
 }
+
+- (id )sharingServicePicker:(NSSharingServicePicker *)sharingServicePicker delegateForSharingService:(NSSharingService *)sharingService
+{
+return self;
+}
+
+- (NSWindow *)sharingService:(NSSharingService *)sharingService sourceWindowForShareItems:(NSArray *)items sharingContentScope:(NSSharingContentScope *)sharingContentScope
+{
+return [_webView window];
+}
+
+- (void)sharingService:(NSSharingService *)sharingService didFailToShareItems:(NSArray *)items error:(NSError *)error
+{
+[self _didCompleteWithSuccess:NO];
+[self dispatchDidDismiss];
+}
+
+- (void)sharingService:(NSSharingService *)sharingService didShareItems:(NSArray *)items
+{
+[self _didCompleteWithSuccess:YES];
+[self dispatchDidDismiss];
+}
+
 #endif
 
 - (void)_didCompleteWithSuccess:(BOOL)success






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238940] trunk/Tools

[jbedard]

Title: [238940] trunk/Tools








Revision 238940
Author jbed...@apple.com
Date 2018-12-06 14:09:19 -0800 (Thu, 06 Dec 2018)


Log Message
webkitpy: Create device given lower-case DeviceType



Reviewed by Lucas Forschler.

* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager._get_device_identifier_for_type): Comparing simctl device identifiers with DeviceTypes
should be letter-case agnostic.
* Scripts/webkitpy/xcode/simulated_device_unittest.py:
(test_lower_case_device_type):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py
trunk/Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (238939 => 238940)

--- trunk/Tools/ChangeLog	2018-12-06 21:22:19 UTC (rev 238939)
+++ trunk/Tools/ChangeLog	2018-12-06 22:09:19 UTC (rev 238940)
@@ -1,3 +1,17 @@
+2018-12-06  Jonathan Bedard  
+
+webkitpy: Create device given lower-case DeviceType
+
+
+
+Reviewed by Lucas Forschler.
+
+* Scripts/webkitpy/xcode/simulated_device.py:
+(SimulatedDeviceManager._get_device_identifier_for_type): Comparing simctl device identifiers with DeviceTypes
+should be letter-case agnostic.
+* Scripts/webkitpy/xcode/simulated_device_unittest.py:
+(test_lower_case_device_type):
+
 2018-12-06  Wenson Hsieh  
 
 [iOS] WKWebView should match UITextView behavior when editing text with an RTL keyboard


Modified: trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py (238939 => 238940)

--- trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py	2018-12-06 21:22:19 UTC (rev 238939)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py	2018-12-06 22:09:19 UTC (rev 238940)
@@ -229,7 +229,7 @@
 @staticmethod
 def _get_device_identifier_for_type(device_type):
 for type_id, type_name in SimulatedDeviceManager._device_identifier_to_name.iteritems():
-if type_name == '{} {}'.format(device_type.hardware_family, device_type.hardware_type):
+if type_name.lower() == '{} {}'.format(device_type.hardware_family.lower(), device_type.hardware_type.lower()):
 return type_id
 return None
 


Modified: trunk/Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py (238939 => 238940)

--- trunk/Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py	2018-12-06 21:22:19 UTC (rev 238939)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py	2018-12-06 22:09:19 UTC (rev 238940)
@@ -610,6 +610,20 @@
 SimulatedDeviceManager.tear_down(host)
 self.assertIsNone(SimulatedDeviceManager.INITIALIZED_DEVICES)
 
+def test_lower_case_device_type(self):
+SimulatedDeviceTest.reset_simulated_device_manager()
+host = SimulatedDeviceTest.mock_host_for_simctl()
+SimulatedDeviceManager.available_devices(host)
+
+SimulatedDeviceManager.initialize_devices(DeviceRequest(DeviceType.from_string('iphone 5s', Version(11))), host=host)
+
+self.assertEquals(1, len(SimulatedDeviceManager.INITIALIZED_DEVICES))
+self.assertEquals('34FB476C-6FA0-43C8-8945-1BD7A4EBF0DE', SimulatedDeviceManager.INITIALIZED_DEVICES[0].udid)
+self.assertEquals(SimulatedDevice.DeviceState.BOOTED, SimulatedDeviceManager.INITIALIZED_DEVICES[0].platform_device.state())
+
+SimulatedDeviceManager.tear_down(host)
+self.assertIsNone(SimulatedDeviceManager.INITIALIZED_DEVICES)
+
 @staticmethod
 def change_state_to(device, state):
 assert isinstance(state, int)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238939] trunk

[wenson_hsieh]

Title: [238939] trunk








Revision 238939
Author wenson_hs...@apple.com
Date 2018-12-06 13:22:19 -0800 (Thu, 06 Dec 2018)


Log Message
[iOS] WKWebView should match UITextView behavior when editing text with an RTL keyboard
https://bugs.webkit.org/show_bug.cgi?id=187554


Reviewed by Tim Horton.

Source/WebKit:

Add support for automatically switching the base writing direction to the default writing direction with respect
to the current keyboard in an editable WKWebView by implementing `-setBaseWritingDirection:forRange:`. On iOS 12
and earlier, UIKit invokes this protocol method whenever the keyboard is changed to one with a different writing
direction, although in some other versions of iOS, this only happens when first focusing an editable area.

Test: editing/input/ios/rtl-keyboard-input-on-focus.html

* Platform/spi/ios/UIKitSPI.h:

Declare UIKeyboardImpl IPI methods mostly for use in WebKitTestRunner (with the exception of
`-setInitialDirection`, which we may invoke when we receive the first post-layout EditorState update after
focusing an editable element).

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::increaseListLevel):
(WebKit::WebPageProxy::decreaseListLevel):
(WebKit::WebPageProxy::changeListType):
(WebKit::WebPageProxy::setBaseWritingDirection):

Drive-by style fixes: make these bail and return early if `!isValid()`.

(WebKit::WebPageProxy::resetStateAfterProcessExited):

Reset assisted node state in the UI process upon web process termination.

* UIProcess/WebPageProxy.h:

Add plumbing for `setBaseWritingDirection`, from `WebPageProxy` to `WebPage` to `Editor`.

* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didReceiveEditorStateUpdateAfterFocus):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView baseWritingDirectionForPosition:inDirection:]):
(coreWritingDirection):
(-[WKContentView setBaseWritingDirection:forRange:]):

Support `-setBaseWritingDirectionForPosition:forRange:`, but only in the case where the given range is the
selected range. This is all that's currently needed to fulfill the requirements in ,
though we could potentially add full support for this in the future by mapping the given text range to a DOM
range and moving the selection prior to setting the base writing direction.

(-[WKContentView _didReceiveEditorStateUpdateAfterFocus]):

Add a hook to notify WKContentView when the first post-layout EditorState has been received in the UI process.
When this is invoked, if the web view is editable and the selection is not a range, we call into `UIKeyboardImpl`
to change the initial writing direction if necessary.

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::startAssistingNode):
(WebKit::WebPageProxy::stopAssistingNode):
(WebKit::WebPageProxy::editorStateChanged):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setBaseWritingDirection):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Tools:

Add support for simulating the keyboard input mode in layout tests using UIScriptController, as well as a new
`TestOption` to make the web view editable.

* DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::setKeyboardInputModeIdentifier):
* TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setKeyboardInputModeIdentifier):
* TestRunnerShared/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
* WebKitTestRunner/TestController.h:
(WTR::TestController::overriddenKeyboardInputMode const):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::setEditable):
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::setEditable):
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues):
(WTR::swizzleCurrentInputMode):
(WTR::TestController::setKeyboardInputModeIdentifier):

Swizzle out several `UIKeyboardInputModeController` methods in order to convince UIKit that the user has
selected a `UIKeyboardInputMode` corresponding to the given identifier. The call to
`-prepareKeyboardInputModeFromPreferences:` is also necessary on iOS 12 in order to update cached writing
direction state in UIKit.

* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::setKeyboardInputModeIdentifier):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::setEditable):
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::setEditable):
* WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:

[webkit-changes] [238938] trunk/Source/WebInspectorUI

[mattbaker]

Title: [238938] trunk/Source/WebInspectorUI








Revision 238938
Author mattba...@apple.com
Date 2018-12-06 12:37:55 -0800 (Thu, 06 Dec 2018)


Log Message
Web Inspector: REGRESSION(r238602): Elements: collapsing a DOM node with the left arrow doesn't work
https://bugs.webkit.org/show_bug.cgi?id=192353


Reviewed by Devin Rousso.

* UserInterface/Views/TreeElement.js:
(WI.TreeElement.prototype.deselect):
Don't early return when the element is not the selected tree element.
This condition no longer holds now that TreeOutline supports multiple selection.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (238937 => 238938)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-06 20:07:38 UTC (rev 238937)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-06 20:37:55 UTC (rev 238938)
@@ -1,3 +1,16 @@
+2018-12-06  Matt Baker  
+
+Web Inspector: REGRESSION(r238602): Elements: collapsing a DOM node with the left arrow doesn't work
+https://bugs.webkit.org/show_bug.cgi?id=192353
+
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Views/TreeElement.js:
+(WI.TreeElement.prototype.deselect):
+Don't early return when the element is not the selected tree element.
+This condition no longer holds now that TreeOutline supports multiple selection.
+
 2018-12-05  Matt Baker  
 
 Web Inspector: SelectionController should not extend the selection when allowsMultipleSelection is false


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js (238937 => 238938)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js	2018-12-06 20:07:38 UTC (rev 238937)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js	2018-12-06 20:37:55 UTC (rev 238938)
@@ -532,9 +532,11 @@
 
 deselect(suppressNotification)
 {
-if (!this.treeOutline || this.treeOutline.selectedTreeElement !== this || !this.selected)
+if (!this.treeOutline || !this.selected)
 return false;
 
+console.assert(this.treeOutline.selectedTreeElements.includes(this));
+
 this.selected = false;
 this.treeOutline.selectTreeElementInternal(null, suppressNotification);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238937] trunk/Source/WebKit

[david_quesada]

Title: [238937] trunk/Source/WebKit








Revision 238937
Author david_ques...@apple.com
Date 2018-12-06 12:07:38 -0800 (Thu, 06 Dec 2018)


Log Message
-[WKProcessPool _resumeDownloadFromData:path:] should allow specifying the originating web view
https://bugs.webkit.org/show_bug.cgi?id=192411
rdar://problem/46492487

Reviewed by Alex Christensen.

* UIProcess/API/C/WKContext.cpp:
(WKContextResumeDownload):
* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _resumeDownloadFromData:path:originatingWebView:]):
(-[WKProcessPool _resumeDownloadFromData:path:]): Deleted.
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::resumeDownload):
 - Set the originating page of the DownloadProxy.
 - If the originating page is non-null, use its session ID for the download.
 - Remove a FIXME. It's possible to do this now by providing the web view whose session
   should be used for the download.
* UIProcess/WebProcessPool.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKContext.cpp
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (238936 => 238937)

--- trunk/Source/WebKit/ChangeLog	2018-12-06 19:35:35 UTC (rev 238936)
+++ trunk/Source/WebKit/ChangeLog	2018-12-06 20:07:38 UTC (rev 238937)
@@ -1,3 +1,25 @@
+2018-12-06  David Quesada  
+
+-[WKProcessPool _resumeDownloadFromData:path:] should allow specifying the originating web view
+https://bugs.webkit.org/show_bug.cgi?id=192411
+rdar://problem/46492487
+
+Reviewed by Alex Christensen.
+
+* UIProcess/API/C/WKContext.cpp:
+(WKContextResumeDownload):
+* UIProcess/API/Cocoa/WKProcessPool.mm:
+(-[WKProcessPool _resumeDownloadFromData:path:originatingWebView:]):
+(-[WKProcessPool _resumeDownloadFromData:path:]): Deleted.
+* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::resumeDownload):
+ - Set the originating page of the DownloadProxy.
+ - If the originating page is non-null, use its session ID for the download.
+ - Remove a FIXME. It's possible to do this now by providing the web view whose session
+   should be used for the download.
+* UIProcess/WebProcessPool.h:
+
 2018-12-06  Jiewen Tan  
 
 Unreviewed, a quick fix after r238919


Modified: trunk/Source/WebKit/UIProcess/API/C/WKContext.cpp (238936 => 238937)

--- trunk/Source/WebKit/UIProcess/API/C/WKContext.cpp	2018-12-06 19:35:35 UTC (rev 238936)
+++ trunk/Source/WebKit/UIProcess/API/C/WKContext.cpp	2018-12-06 20:07:38 UTC (rev 238937)
@@ -282,7 +282,7 @@
 
 WKDownloadRef WKContextResumeDownload(WKContextRef contextRef, WKDataRef resumeData, WKStringRef path)
 {
-return toAPI(toImpl(contextRef)->resumeDownload(toImpl(resumeData), toWTFString(path)));
+return toAPI(toImpl(contextRef)->resumeDownload(nullptr, toImpl(resumeData), toWTFString(path)));
 }
 
 void WKContextSetInitializationUserDataForInjectedBundle(WKContextRef contextRef,  WKTypeRef userDataRef)


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm (238936 => 238937)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm	2018-12-06 19:35:35 UTC (rev 238936)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm	2018-12-06 20:07:38 UTC (rev 238937)
@@ -576,9 +576,9 @@
 return (_WKDownload *)_processPool->download([webView _page], request)->wrapper();
 }
 
-- (_WKDownload *)_resumeDownloadFromData:(NSData *)resumeData path:(NSString *)path
+- (_WKDownload *)_resumeDownloadFromData:(NSData *)resumeData path:(NSString *)path originatingWebView:(WKWebView *)webView
 {
-return wrapper(_processPool->resumeDownload(API::Data::createWithoutCopying(resumeData).ptr(), path));
+return wrapper(_processPool->resumeDownload([webView _page], API::Data::createWithoutCopying(resumeData).ptr(), path));
 }
 
 - (void)_getActivePagesOriginsInWebProcessForTesting:(pid_t)pid completionHandler:(void(^)(NSArray *))completionHandler


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h (238936 => 238937)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h	2018-12-06 19:35:35 UTC (rev 238936)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h	2018-12-06 20:07:38 UTC (rev 238937)
@@ -82,7 +82,7 @@
 - (void)_registerURLSchemeAsCanDisplayOnlyIfCanRequest:(NSString *)scheme WK_API_AVAILABLE(macosx(10.14), ios(12.0));
 
 - (_WKDownload *)_downloadURLRequest:(NSURLRequest *)request originatingWebView:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
-- (_WKDownload *)_resumeDownloadFromData:(NSData *)resumeData path:(NSString *)path 

[webkit-changes] [238936] trunk/Source/WebKit

[jiewen_tan]

Title: [238936] trunk/Source/WebKit








Revision 238936
Author jiewen_...@apple.com
Date 2018-12-06 11:35:35 -0800 (Thu, 06 Dec 2018)


Log Message
Unreviewed, a quick fix after r238919

Add an early return such that the error message is actually meaningful.

* UIProcess/WebAuthentication/Mock/MockHidService.cpp:
(WebKit::MockHidService::platformStartDiscovery):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (238935 => 238936)

--- trunk/Source/WebKit/ChangeLog	2018-12-06 19:32:38 UTC (rev 238935)
+++ trunk/Source/WebKit/ChangeLog	2018-12-06 19:35:35 UTC (rev 238936)
@@ -1,3 +1,12 @@
+2018-12-06  Jiewen Tan  
+
+Unreviewed, a quick fix after r238919
+
+Add an early return such that the error message is actually meaningful.
+
+* UIProcess/WebAuthentication/Mock/MockHidService.cpp:
+(WebKit::MockHidService::platformStartDiscovery):
+
 2018-12-06  Alex Christensen  
 
 Remove unused LoaderStrategy::storeDerivedDataToCache and associated dead code


Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp (238935 => 238936)

--- trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp	2018-12-06 19:32:38 UTC (rev 238935)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp	2018-12-06 19:35:35 UTC (rev 238936)
@@ -41,8 +41,10 @@
 
 void MockHidService::platformStartDiscovery()
 {
-if (!!m_configuration.hid)
+if (!!m_configuration.hid) {
 deviceAdded(nullptr);
+return;
+}
 LOG_ERROR("No hid authenticators is available.");
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238935] trunk/LayoutTests

[jiewen_tan]

Title: [238935] trunk/LayoutTests








Revision 238935
Author jiewen_...@apple.com
Date 2018-12-06 11:32:38 -0800 (Thu, 06 Dec 2018)


Log Message
Layout Test http/tests/misc/resource-timing-resolution.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=181957

Reviewed by Youenn Fablet.

Since the timing information is a multiplier of a small delta, it is likely that
two timing information are the same as they are so close that fall into the same
bucket. Therefore, this patch releases the check of 't0 !== t1'.

* http/tests/misc/resource-timing-resolution-expected.txt:
* http/tests/misc/resource-timing-resolution.html:
* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/misc/resource-timing-resolution-expected.txt
trunk/LayoutTests/http/tests/misc/resource-timing-resolution.html
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (238934 => 238935)

--- trunk/LayoutTests/ChangeLog	2018-12-06 18:59:44 UTC (rev 238934)
+++ trunk/LayoutTests/ChangeLog	2018-12-06 19:32:38 UTC (rev 238935)
@@ -1,3 +1,19 @@
+2018-12-06  Jiewen Tan  
+
+Layout Test http/tests/misc/resource-timing-resolution.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=181957
+
+Reviewed by Youenn Fablet.
+
+Since the timing information is a multiplier of a small delta, it is likely that
+two timing information are the same as they are so close that fall into the same
+bucket. Therefore, this patch releases the check of 't0 !== t1'.
+
+* http/tests/misc/resource-timing-resolution-expected.txt:
+* http/tests/misc/resource-timing-resolution.html:
+* platform/ios-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2018-12-06  Truitt Savell  
 
 imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html is flaky timeout


Modified: trunk/LayoutTests/http/tests/misc/resource-timing-resolution-expected.txt (238934 => 238935)

--- trunk/LayoutTests/http/tests/misc/resource-timing-resolution-expected.txt	2018-12-06 18:59:44 UTC (rev 238934)
+++ trunk/LayoutTests/http/tests/misc/resource-timing-resolution-expected.txt	2018-12-06 19:32:38 UTC (rev 238935)
@@ -3,7 +3,6 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS t0 !== t1 is true
 PASS shouldBeNearZeroOrOne < 1e-10 || Math.abs(shouldBeNearZeroOrOne - 1) < 1e-10 is true
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/http/tests/misc/resource-timing-resolution.html (238934 => 238935)

--- trunk/LayoutTests/http/tests/misc/resource-timing-resolution.html	2018-12-06 18:59:44 UTC (rev 238934)
+++ trunk/LayoutTests/http/tests/misc/resource-timing-resolution.html	2018-12-06 19:32:38 UTC (rev 238935)
@@ -18,7 +18,6 @@
 var entries = performance.getEntries();
 t0 = entries[0].fetchStart;
 t1 = entries[1].fetchStart;
-shouldBe("t0 !== t1", "true");
 
 var expectedResolutionMilliseconds = 0.005;
 var integerMultipleOfResolution = (t1 - t0) / expectedResolutionMilliseconds;


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (238934 => 238935)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-12-06 18:59:44 UTC (rev 238934)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-12-06 19:32:38 UTC (rev 238935)
@@ -1260,8 +1260,6 @@
 
 webkit.org/b/181392 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html [ Pass Failure ]
 
-webkit.org/b/181957 [ Release ] http/tests/misc/resource-timing-resolution.html [ Pass Failure ]
-
 webkit.org/b/181821 fast/visual-viewport/ios/caret-after-focus-in-fixed.html [ Pass Failure ]
 
 webkit.org/b/182144 [ Debug ] webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Skip ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (238934 => 238935)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-12-06 18:59:44 UTC (rev 238934)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-12-06 19:32:38 UTC (rev 238935)
@@ -820,8 +820,6 @@
 
 webkit.org/b/181839 [ Debug ] inspector/debugger/breakpoint-action-log.html [ Pass Timeout ]
 
-webkit.org/b/181957 [ Release ] http/tests/misc/resource-timing-resolution.html [ Pass Failure ]
-
 webkit.org/b/181835 webrtc/captureCanvas-webrtc.html [ Pass Timeout ]
 
 webkit.org/b/177663 media/W3C/video/events/event_progress_manual.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238934] trunk/JSTests

[keith_miller]

Title: [238934] trunk/JSTests








Revision 238934
Author keith_mil...@apple.com
Date 2018-12-06 10:59:44 -0800 (Thu, 06 Dec 2018)


Log Message
stress/big-wasm-memory tests failing on 32-bit JSC bot
https://bugs.webkit.org/show_bug.cgi?id=192020

Reviewed by Saam Barati.

Not every platform has WebAssembly, e.g. 32-bit, so we should exit
the wasm stress tests if the WebAssembly object does not exist.

* stress/big-wasm-memory-grow-no-max.js:
(test.foo):
(test):
(foo): Deleted.
(catch): Deleted.
* stress/big-wasm-memory-grow.js:
(test.foo):
(test):
(foo): Deleted.
(catch): Deleted.
* stress/big-wasm-memory.js:
(test.foo):
(test):
(foo): Deleted.
(catch): Deleted.

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/big-wasm-memory-grow-no-max.js
trunk/JSTests/stress/big-wasm-memory-grow.js
trunk/JSTests/stress/big-wasm-memory.js




Diff

Modified: trunk/JSTests/ChangeLog (238933 => 238934)

--- trunk/JSTests/ChangeLog	2018-12-06 16:55:45 UTC (rev 238933)
+++ trunk/JSTests/ChangeLog	2018-12-06 18:59:44 UTC (rev 238934)
@@ -1,3 +1,29 @@
+2018-12-06  Keith Miller  
+
+stress/big-wasm-memory tests failing on 32-bit JSC bot
+https://bugs.webkit.org/show_bug.cgi?id=192020
+
+Reviewed by Saam Barati.
+
+Not every platform has WebAssembly, e.g. 32-bit, so we should exit
+the wasm stress tests if the WebAssembly object does not exist.
+
+* stress/big-wasm-memory-grow-no-max.js:
+(test.foo):
+(test):
+(foo): Deleted.
+(catch): Deleted.
+* stress/big-wasm-memory-grow.js:
+(test.foo):
+(test):
+(foo): Deleted.
+(catch): Deleted.
+* stress/big-wasm-memory.js:
+(test.foo):
+(test):
+(foo): Deleted.
+(catch): Deleted.
+
 2018-12-05  Mark Lam  
 
 speculationFromCell() should speculate non-Identifier strings as SpecString instead of SpecStringVar.


Modified: trunk/JSTests/stress/big-wasm-memory-grow-no-max.js (238933 => 238934)

--- trunk/JSTests/stress/big-wasm-memory-grow-no-max.js	2018-12-06 16:55:45 UTC (rev 238933)
+++ trunk/JSTests/stress/big-wasm-memory-grow-no-max.js	2018-12-06 18:59:44 UTC (rev 238934)
@@ -1,34 +1,45 @@
 //@ skip if $memoryLimited
-let bigArray = new Array(0x700);
-bigArray[0] = 1.1;
-bigArray[1] = 1.2;
 
-function foo(array) {
-var index = array.length;
-if (index >= bigArray.length || (index - 0x1ffdc01) < 0)
+function test() {
+
+// We don't support WebAssembly everywhere, so check for its existance before doing anything else.
+if (!this.WebAssembly)
 return;
-return bigArray[index - 0x1ffdc01];
-}
 
-noInline(foo);
+let bigArray = new Array(0x700);
+bigArray[0] = 1.1;
+bigArray[1] = 1.2;
 
-var okArray = new Uint8Array(0x1ffdc02);
+function foo(array) {
+var index = array.length;
+if (index >= bigArray.length || (index - 0x1ffdc01) < 0)
+return;
+return bigArray[index - 0x1ffdc01];
+}
 
-for (var i = 0; i < 1; ++i)
-foo(okArray);
+noInline(foo);
 
-var ok = false;
-try {
-var memory = new WebAssembly.Memory({ initial: 0x1000 });
-memory.grow(0x7000);
-var result = foo(new Uint8Array(memory.buffer));
-if (result !== void 0)
-throw "Error: bad result at end: " + result;
-ok = true;
-} catch (e) {
-if (e.toString() != "Error: Out of memory")
-throw e;
+var okArray = new Uint8Array(0x1ffdc02);
+
+for (var i = 0; i < 1; ++i)
+foo(okArray);
+
+var ok = false;
+try {
+var memory = new WebAssembly.Memory({ initial: 0x1000 });
+memory.grow(0x7000);
+var result = foo(new Uint8Array(memory.buffer));
+if (result !== void 0)
+throw "Error: bad result at end: " + result;
+ok = true;
+} catch (e) {
+if (e.toString() != "Error: Out of memory")
+throw e;
+}
+
+if (ok)
+throw "Error: did not throw error";
+
 }
 
-if (ok)
-throw "Error: did not throw error";
+test();


Modified: trunk/JSTests/stress/big-wasm-memory-grow.js (238933 => 238934)

--- trunk/JSTests/stress/big-wasm-memory-grow.js	2018-12-06 16:55:45 UTC (rev 238933)
+++ trunk/JSTests/stress/big-wasm-memory-grow.js	2018-12-06 18:59:44 UTC (rev 238934)
@@ -1,34 +1,45 @@
 //@ skip if $memoryLimited
-let bigArray = new Array(0x700);
-bigArray[0] = 1.1;
-bigArray[1] = 1.2;
 
-function foo(array) {
-var index = array.length;
-if (index >= bigArray.length || (index - 0x1ffdc01) < 0)
+function test() {
+
+// We don't support WebAssembly everywhere, so check for its existance before doing anything else.
+if (!this.WebAssembly)
 return;
-return bigArray[index - 0x1ffdc01];
-}
 
-noInline(foo);
+let bigArray = new Array(0x700);
+bigArray[0] = 1.1;
+bigArray[1] = 1.2;
 
-var okArray = new Uint8Array(0x1ffdc02);
+function foo(array) {
+var index = array.length;

[webkit-changes] [238933] trunk/Source

[achristensen]

Title: [238933] trunk/Source








Revision 238933
Author achristen...@apple.com
Date 2018-12-06 08:55:45 -0800 (Thu, 06 Dec 2018)


Log Message
Remove unused LoaderStrategy::storeDerivedDataToCache and associated dead code
https://bugs.webkit.org/show_bug.cgi?id=192452

Reviewed by Anders Carlsson.

Source/WebCore:

* loader/LoaderStrategy.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didRetrieveDerivedDataFromCache): Deleted.
* loader/ResourceLoader.h:
* loader/ResourceLoaderOptions.h:
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didRetrieveDerivedDataFromCache): Deleted.
* loader/SubresourceLoader.h:
* loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoaderOptions::isolatedCopy const):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::didRetrieveDerivedDataFromCache): Deleted.

Source/WebKit:

This was introduced in r210835 but never used.
It's preventing me from making the disk cache associated with a SessionID/NetworkSession.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::storeDerivedDataToCache): Deleted.
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueDidReceiveResponse):
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
(WebKit::NetworkResourceLoader::continueProcessingCachedEntryAfterDidReceiveResponse): Deleted.
* NetworkProcess/NetworkResourceLoader.h:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::storeDerivedDataToCache): Deleted.
* WebProcess/Network/WebLoaderStrategy.h:
* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didRetrieveDerivedData): Deleted.
* WebProcess/Network/WebResourceLoader.messages.in:

Source/WebKitLegacy:

* WebCoreSupport/WebResourceLoadScheduler.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/LoaderStrategy.h
trunk/Source/WebCore/loader/ResourceLoader.cpp
trunk/Source/WebCore/loader/ResourceLoader.h
trunk/Source/WebCore/loader/ResourceLoaderOptions.h
trunk/Source/WebCore/loader/SubresourceLoader.cpp
trunk/Source/WebCore/loader/SubresourceLoader.h
trunk/Source/WebCore/loader/ThreadableLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.h
trunk/Source/WebKit/WebProcess/Network/WebResourceLoader.cpp
trunk/Source/WebKit/WebProcess/Network/WebResourceLoader.messages.in
trunk/Source/WebKitLegacy/ChangeLog
trunk/Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (238932 => 238933)

--- trunk/Source/WebCore/ChangeLog	2018-12-06 16:48:56 UTC (rev 238932)
+++ trunk/Source/WebCore/ChangeLog	2018-12-06 16:55:45 UTC (rev 238933)
@@ -1,3 +1,23 @@
+2018-12-06  Alex Christensen  
+
+Remove unused LoaderStrategy::storeDerivedDataToCache and associated dead code
+https://bugs.webkit.org/show_bug.cgi?id=192452
+
+Reviewed by Anders Carlsson.
+
+* loader/LoaderStrategy.h:
+* loader/ResourceLoader.cpp:
+(WebCore::ResourceLoader::didRetrieveDerivedDataFromCache): Deleted.
+* loader/ResourceLoader.h:
+* loader/ResourceLoaderOptions.h:
+* loader/SubresourceLoader.cpp:
+(WebCore::SubresourceLoader::didRetrieveDerivedDataFromCache): Deleted.
+* loader/SubresourceLoader.h:
+* loader/ThreadableLoader.cpp:
+(WebCore::ThreadableLoaderOptions::isolatedCopy const):
+* loader/cache/CachedResource.h:
+(WebCore::CachedResource::didRetrieveDerivedDataFromCache): Deleted.
+
 2018-12-06  Zalan Bujtas  
 
 [LFC][BFC][MarginCollapsing] HeightAndMargin::margin is always the non-collapsed margin value.


Modified: trunk/Source/WebCore/loader/LoaderStrategy.h (238932 => 238933)

--- trunk/Source/WebCore/loader/LoaderStrategy.h	2018-12-06 16:48:56 UTC (rev 238932)
+++ trunk/Source/WebCore/loader/LoaderStrategy.h	2018-12-06 16:55:45 UTC (rev 238933)
@@ -31,7 +31,6 @@
 #include "StoredCredentialsPolicy.h"
 #include 
 #include 
-#include 
 
 

[webkit-changes] [238932] trunk/LayoutTests

[tsavell]

Title: [238932] trunk/LayoutTests








Revision 238932
Author tsav...@apple.com
Date 2018-12-06 08:48:56 -0800 (Thu, 06 Dec 2018)


Log Message
imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html is flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=191565

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (238931 => 238932)

--- trunk/LayoutTests/ChangeLog	2018-12-06 15:24:56 UTC (rev 238931)
+++ trunk/LayoutTests/ChangeLog	2018-12-06 16:48:56 UTC (rev 238932)
@@ -1,3 +1,12 @@
+2018-12-06  Truitt Savell  
+
+imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html is flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=191565
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2018-12-05  Alicia Boya García  
 
 [GTK] Unreviewed test gardening


Modified: trunk/LayoutTests/platform/mac/TestExpectations (238931 => 238932)

--- trunk/LayoutTests/platform/mac/TestExpectations	2018-12-06 15:24:56 UTC (rev 238931)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-12-06 16:48:56 UTC (rev 238932)
@@ -1792,3 +1792,5 @@
 webkit.org/b/190883 legacy-animation-engine/animations/suspend-resume-animation.html [ Pass Failure ]
 
 webkit.org/b/190724 [ Debug ] http/tests/misc/large-js-program.php [ Pass Timeout ]
+
+webkit.org/b/191565 imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html [ Pass Slow ] 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238931] trunk/Source/WebCore

[zalan]

Title: [238931] trunk/Source/WebCore








Revision 238931
Author za...@apple.com
Date 2018-12-06 07:24:56 -0800 (Thu, 06 Dec 2018)


Log Message
[LFC][BFC][MarginCollapsing] HeightAndMargin::margin is always the non-collapsed margin value.
https://bugs.webkit.org/show_bug.cgi?id=192345

Reviewed by Antti Koivisto.

Rename HeightAndMargin::margin to HeightAndMargin::nonCollapsedMargin.

* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
* layout/LayoutUnits.h:
(WebCore::Layout::HeightAndMargin::usedMarginValues const):
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
* layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedHeight):
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/LayoutUnits.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextQuirks.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238930 => 238931)

--- trunk/Source/WebCore/ChangeLog	2018-12-06 15:21:48 UTC (rev 238930)
+++ trunk/Source/WebCore/ChangeLog	2018-12-06 15:24:56 UTC (rev 238931)
@@ -1,5 +1,28 @@
 2018-12-06  Zalan Bujtas  
 
+[LFC][BFC][MarginCollapsing] HeightAndMargin::margin is always the non-collapsed margin value.
+https://bugs.webkit.org/show_bug.cgi?id=192345
+
+Reviewed by Antti Koivisto.
+
+Rename HeightAndMargin::margin to HeightAndMargin::nonCollapsedMargin.
+
+* layout/FormattingContext.cpp:
+(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
+* layout/LayoutUnits.h:
+(WebCore::Layout::HeightAndMargin::usedMarginValues const):
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
+* layout/blockformatting/BlockFormattingContextGeometry.cpp:
+(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
+(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
+* layout/blockformatting/BlockFormattingContextQuirks.cpp:
+(WebCore::Layout::BlockFormattingContext::Quirks::stretchedHeight):
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin const):
+
+2018-12-06  Zalan Bujtas  
+
 [LFC][BFC][MarginCollapsing] Add MarginCollapse::establishesBlockFormattingContext
 https://bugs.webkit.org/show_bug.cgi?id=192297
 


Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (238930 => 238931)

--- trunk/Source/WebCore/layout/FormattingContext.cpp	2018-12-06 15:21:48 UTC (rev 238930)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp	2018-12-06 15:24:56 UTC (rev 238931)
@@ -115,11 +115,13 @@
 }
 
 auto& displayBox = layoutState.displayBoxForLayoutBox(layoutBox);
-displayBox.setTop(verticalGeometry.top + verticalGeometry.heightAndMargin.margin.top);
+// Margins of absolutely positioned boxes do not collapse
+ASSERT(!verticalGeometry.heightAndMargin.collapsedMargin);
+auto nonCollapsedVerticalMargins = verticalGeometry.heightAndMargin.usedMarginValues();
+displayBox.setTop(verticalGeometry.top + nonCollapsedVerticalMargins.top);
 displayBox.setContentBoxHeight(verticalGeometry.heightAndMargin.height);
-ASSERT(!verticalGeometry.heightAndMargin.collapsedMargin);
-displayBox.setVerticalMargin(verticalGeometry.heightAndMargin.margin);
-displayBox.setVerticalNonCollapsedMargin(verticalGeometry.heightAndMargin.margin);
+displayBox.setVerticalMargin(nonCollapsedVerticalMargins);
+displayBox.setVerticalNonCollapsedMargin(nonCollapsedVerticalMargins);
 }
 
 void FormattingContext::computeBorderAndPadding(const Box& layoutBox) const


Modified: trunk/Source/WebCore/layout/LayoutUnits.h (238930 => 238931)

--- trunk/Source/WebCore/layout/LayoutUnits.h	2018-12-06 15:21:48 UTC (rev 238930)
+++ trunk/Source/WebCore/layout/LayoutUnits.h	2018-12-06 15:24:56 UTC (rev 238931)
@@ -107,10 +107,10 @@
 };
 
 struct HeightAndMargin {
-VerticalEdges usedMarginValues() const { return collapsedMargin.value_or(margin); }
+VerticalEdges usedMarginValues() const { return 

[webkit-changes] [238930] trunk/Source/WebCore

[zalan]

Title: [238930] trunk/Source/WebCore








Revision 238930
Author za...@apple.com
Date 2018-12-06 07:21:48 -0800 (Thu, 06 Dec 2018)


Log Message
[LFC][BFC][MarginCollapsing] Add MarginCollapse::establishesBlockFormattingContext
https://bugs.webkit.org/show_bug.cgi?id=192297

Reviewed by Antti Koivisto.

WebKit treats the document element renderer as a block formatting context root.

* layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::establishesBlockFormattingContext):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginTopCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginBottomCollapsedWithParent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238929 => 238930)

--- trunk/Source/WebCore/ChangeLog	2018-12-06 13:07:46 UTC (rev 238929)
+++ trunk/Source/WebCore/ChangeLog	2018-12-06 15:21:48 UTC (rev 238930)
@@ -1,3 +1,17 @@
+2018-12-06  Zalan Bujtas  
+
+[LFC][BFC][MarginCollapsing] Add MarginCollapse::establishesBlockFormattingContext
+https://bugs.webkit.org/show_bug.cgi?id=192297
+
+Reviewed by Antti Koivisto.
+
+WebKit treats the document element renderer as a block formatting context root.
+
+* layout/blockformatting/BlockMarginCollapse.cpp:
+(WebCore::Layout::establishesBlockFormattingContext):
+(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginTopCollapsedWithParent):
+(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginBottomCollapsedWithParent):
+
 2018-12-06  Carlos Eduardo Ramalho  
 
 [GStreamer] -DENABLE_VIDEO=ON -DENABLE_OPENGL=OFF still tries to build GstreamerGL


Modified: trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp (238929 => 238930)

--- trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp	2018-12-06 13:07:46 UTC (rev 238929)
+++ trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp	2018-12-06 15:21:48 UTC (rev 238930)
@@ -69,6 +69,15 @@
 return hasPadding(layoutBox.style().paddingAfter());
 }
 
+static bool establishesBlockFormattingContext(const Box& layoutBox)
+{
+// WebKit treats the document element renderer as a block formatting context root. It probably only impacts margin collapsing, so let's not do
+// a layout wide quirk on this for now.
+if (layoutBox.isDocumentBox())
+return true;
+return layoutBox.establishesBlockFormattingContext();
+}
+
 static LayoutUnit marginValue(LayoutUnit currentMarginValue, LayoutUnit candidateMarginValue)
 {
 if (!candidateMarginValue)
@@ -131,16 +140,11 @@
 if (layoutBox.previousInFlowSibling())
 return false;
 
-// We never margin collapse the initial containing block.
-ASSERT(layoutBox.parent());
 auto& parent = *layoutBox.parent();
-if (parent.establishesBlockFormattingContext())
+// Margins of elements that establish new block formatting contexts do not collapse with their in-flow children
+if (establishesBlockFormattingContext(parent))
 return false;
 
-// Margins of the root element's box do not collapse.
-if (parent.isDocumentBox() || parent.isInitialContainingBlock())
-return false;
-
 if (hasBorderBefore(parent))
 return false;
 
@@ -308,20 +312,15 @@
 if (isMarginBottomCollapsedThrough(layoutBox))
 return false;
 
-// We never margin collapse the initial containing block.
-ASSERT(layoutBox.parent());
-auto& parent = *layoutBox.parent();
 // Only the last inlflow child collapses with parent.
 if (layoutBox.nextInFlowSibling())
 return false;
 
-if (parent.establishesBlockFormattingContext())
+auto& parent = *layoutBox.parent();
+// Margins of elements that establish new block formatting contexts do not collapse with their in-flow children
+if (establishesBlockFormattingContext(parent))
 return false;
 
-// Margins of the root element's box do not collapse.
-if (parent.isDocumentBox() || parent.isInitialContainingBlock())
-return false;
-
 if (hasBorderBefore(parent))
 return false;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238929] trunk

[commit-queue]

Title: [238929] trunk








Revision 238929
Author commit-qu...@webkit.org
Date 2018-12-06 05:07:46 -0800 (Thu, 06 Dec 2018)


Log Message
[GStreamer] -DENABLE_VIDEO=ON -DENABLE_OPENGL=OFF still tries to build GstreamerGL
https://bugs.webkit.org/show_bug.cgi?id=191998

Patch by Carlos Eduardo Ramalho  on 2018-12-06
Reviewed by Philippe Normand.

Fix compilation with -DENABLE_VIDEO=ON and -DENABLE_OPENGL=OFF due to GStreamerGL.

.:

* Source/cmake/GStreamerDependencies.cmake: "DEFINED ENABLE_OPENGL" is always false because ENABLE_OPENGL
is not a CMake variable (WEBKIT_OPTION_DEFINE macro does not define ENABLE_OPENGL variable per se, but other
variables and appends it to a list).
* Source/cmake/OptionsGTK.cmake: GStreamerDefinitions.cmake was included twice by mistake. Second should be GStreamerDependencies.cmake.

Source/WebCore:

No new tests required. Only fixing the build with certain flags.

* Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged): add required #if ENABLE(WEBGL).

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp
trunk/Source/cmake/GStreamerDependencies.cmake
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (238928 => 238929)

--- trunk/ChangeLog	2018-12-06 12:40:47 UTC (rev 238928)
+++ trunk/ChangeLog	2018-12-06 13:07:46 UTC (rev 238929)
@@ -1,5 +1,19 @@
 2018-12-06  Carlos Eduardo Ramalho  
 
+[GStreamer] -DENABLE_VIDEO=ON -DENABLE_OPENGL=OFF still tries to build GstreamerGL
+https://bugs.webkit.org/show_bug.cgi?id=191998
+
+Reviewed by Philippe Normand.
+
+Fix compilation with -DENABLE_VIDEO=ON and -DENABLE_OPENGL=OFF due to GStreamerGL.
+
+* Source/cmake/GStreamerDependencies.cmake: "DEFINED ENABLE_OPENGL" is always false because ENABLE_OPENGL
+is not a CMake variable (WEBKIT_OPTION_DEFINE macro does not define ENABLE_OPENGL variable per se, but other
+variables and appends it to a list).
+* Source/cmake/OptionsGTK.cmake: GStreamerDefinitions.cmake was included twice by mistake. Second should be GStreamerDependencies.cmake.
+
+2018-12-06  Carlos Eduardo Ramalho  
+
 REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds
 https://bugs.webkit.org/show_bug.cgi?id=191997
 


Modified: trunk/Source/WebCore/ChangeLog (238928 => 238929)

--- trunk/Source/WebCore/ChangeLog	2018-12-06 12:40:47 UTC (rev 238928)
+++ trunk/Source/WebCore/ChangeLog	2018-12-06 13:07:46 UTC (rev 238929)
@@ -1,5 +1,19 @@
 2018-12-06  Carlos Eduardo Ramalho  
 
+[GStreamer] -DENABLE_VIDEO=ON -DENABLE_OPENGL=OFF still tries to build GstreamerGL
+https://bugs.webkit.org/show_bug.cgi?id=191998
+
+Reviewed by Philippe Normand.
+
+Fix compilation with -DENABLE_VIDEO=ON and -DENABLE_OPENGL=OFF due to GStreamerGL.
+
+No new tests required. Only fixing the build with certain flags.
+
+* Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
+(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged): add required #if ENABLE(WEBGL).
+
+2018-12-06  Carlos Eduardo Ramalho  
+
 REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds
 https://bugs.webkit.org/show_bug.cgi?id=191997
 


Modified: trunk/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp (238928 => 238929)

--- trunk/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp	2018-12-06 12:40:47 UTC (rev 238928)
+++ trunk/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp	2018-12-06 13:07:46 UTC (rev 238929)
@@ -143,6 +143,7 @@
 {
 ASSERT_UNUSED(canvas, m_canvas == );
 
+#if ENABLE(WEBGL)
 // FIXME: We need to preserve drawing buffer as we are currently grabbing frames asynchronously.
 // We should instead add an anchor point for both 2d and 3d contexts where canvas will actually paint.
 // And call canvas observers from that point.
@@ -153,6 +154,7 @@
 context.setPreserveDrawingBuffer(true);
 }
 }
+#endif
 
 // FIXME: We should try to generate the frame at the time the screen is being updated.
 if (m_canvasChangedTimer.isActive())


Modified: trunk/Source/cmake/GStreamerDependencies.cmake (238928 => 238929)

--- trunk/Source/cmake/GStreamerDependencies.cmake	2018-12-06 12:40:47 UTC (rev 238928)
+++ trunk/Source/cmake/GStreamerDependencies.cmake	2018-12-06 13:07:46 UTC (rev 238929)
@@ -1,4 +1,4 @@
-if (DEFINED ENABLE_OPENGL)
+if (PORT STREQUAL "GTK")
   WEBKIT_OPTION_DEPEND(USE_GSTREAMER_GL ENABLE_OPENGL)
 endif ()
 WEBKIT_OPTION_DEPEND(USE_GSTREAMER_GL ENABLE_VIDEO)


Modified: trunk/Source/cmake/OptionsGTK.cmake (238928 => 238929)

--- trunk/Source/cmake/OptionsGTK.cmake	2018-12-06 12:40:47 UTC (rev 238928)
+++ 

[webkit-changes] [238928] trunk

[commit-queue]

Title: [238928] trunk








Revision 238928
Author commit-qu...@webkit.org
Date 2018-12-06 04:40:47 -0800 (Thu, 06 Dec 2018)


Log Message
REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds
https://bugs.webkit.org/show_bug.cgi?id=191997

Patch by Carlos Eduardo Ramalho  on 2018-12-06
Reviewed by Philippe Normand.

.:

Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF

* Source/cmake/OptionsGTK.cmake: make ENABLE_ASYNC_SCROLLING depend on ENABLE_OPENGL

Source/WebCore:

Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF.

No new tests required. Only fixing build.

* platform/gtk/PlatformWheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): add required #if ENABLE(ASYNC_SCROLLING)

Source/WebKit:

Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF.

* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent): add required #if ENABLE(ASYNC_SCROLLING)

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebEventConversion.cpp
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (238927 => 238928)

--- trunk/ChangeLog	2018-12-06 06:12:28 UTC (rev 238927)
+++ trunk/ChangeLog	2018-12-06 12:40:47 UTC (rev 238928)
@@ -1,3 +1,14 @@
+2018-12-06  Carlos Eduardo Ramalho  
+
+REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds
+https://bugs.webkit.org/show_bug.cgi?id=191997
+
+Reviewed by Philippe Normand.
+
+Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF
+
+* Source/cmake/OptionsGTK.cmake: make ENABLE_ASYNC_SCROLLING depend on ENABLE_OPENGL
+
 2018-12-05  Don Olmstead  
 
 [PlayStation] Enable WebCore


Modified: trunk/Source/WebCore/ChangeLog (238927 => 238928)

--- trunk/Source/WebCore/ChangeLog	2018-12-06 06:12:28 UTC (rev 238927)
+++ trunk/Source/WebCore/ChangeLog	2018-12-06 12:40:47 UTC (rev 238928)
@@ -1,3 +1,17 @@
+2018-12-06  Carlos Eduardo Ramalho  
+
+REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds
+https://bugs.webkit.org/show_bug.cgi?id=191997
+
+Reviewed by Philippe Normand.
+
+Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF.
+
+No new tests required. Only fixing build.
+
+* platform/gtk/PlatformWheelEventGtk.cpp:
+(WebCore::PlatformWheelEvent::PlatformWheelEvent): add required #if ENABLE(ASYNC_SCROLLING)
+
 2018-12-05  Don Olmstead  
 
 [PlayStation] Enable WebCore


Modified: trunk/Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp (238927 => 238928)

--- trunk/Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp	2018-12-06 06:12:28 UTC (rev 238927)
+++ trunk/Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp	2018-12-06 12:40:47 UTC (rev 238928)
@@ -87,6 +87,7 @@
 m_wheelTicksX = m_deltaX;
 m_wheelTicksY = m_deltaY;
 
+#if ENABLE(ASYNC_SCROLLING)
 #ifndef GTK_API_VERSION_2
 #if GTK_CHECK_VERSION(3, 20, 0)
 m_phase = event->is_stop ?
@@ -100,6 +101,7 @@
 #else
 m_phase = PlatformWheelEventPhaseChanged;
 #endif // GTK_API_VERSION_2
+#endif // ENABLE(ASYNC_SCROLLING)
 
 m_position = IntPoint(static_cast(event->x), static_cast(event->y));
 m_globalPosition = IntPoint(static_cast(event->x_root), static_cast(event->y_root));


Modified: trunk/Source/WebKit/ChangeLog (238927 => 238928)

--- trunk/Source/WebKit/ChangeLog	2018-12-06 06:12:28 UTC (rev 238927)
+++ trunk/Source/WebKit/ChangeLog	2018-12-06 12:40:47 UTC (rev 238928)
@@ -1,3 +1,15 @@
+2018-12-06  Carlos Eduardo Ramalho  
+
+REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds
+https://bugs.webkit.org/show_bug.cgi?id=191997
+
+Reviewed by Philippe Normand.
+
+Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF.
+
+* Shared/WebEventConversion.cpp:
+(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent): add required #if ENABLE(ASYNC_SCROLLING)
+
 2018-12-05  Ryosuke Niwa  
 
 REGRESSION(PSON): Process swapping code doesn't set DisplayID in WebContent process


Modified: trunk/Source/WebKit/Shared/WebEventConversion.cpp (238927 => 238928)

--- trunk/Source/WebKit/Shared/WebEventConversion.cpp	2018-12-06 06:12:28 UTC (rev 238927)
+++ trunk/Source/WebKit/Shared/WebEventConversion.cpp	2018-12-06 12:40:47 UTC (rev 238928)
@@ -157,7 +157,7 @@
 m_wheelTicksY = webEvent.wheelTicks().height();
 m_granularity = (webEvent.granularity() == WebWheelEvent::ScrollByPageWheelEvent) ? WebCore::ScrollByPageWheelEvent : WebCore::ScrollByPixelWheelEvent;
 m_directionInvertedFromDevice = webEvent.directionInvertedFromDevice();
-#if PLATFORM(COCOA) ||