[webkit-changes] [240329] trunk
Title: [240329] trunk
Revision 240329
Author ysuz...@apple.com
Date 2019-01-22 22:21:41 -0800 (Tue, 22 Jan 2019)
Log Message
Unreviewed, fix initial global lexical binding epoch
https://bugs.webkit.org/show_bug.cgi?id=193603
JSTests:
* stress/global-lexical-binding-epoch-should-be-correct-one.js: Added.
(f1.f2.f3.f4):
(f1.f2.f3):
(f1.f2):
(f1):
Source/_javascript_Core:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
Added Paths
trunk/JSTests/stress/global-lexical-binding-epoch-should-be-correct-one.js
Diff
Modified: trunk/JSTests/ChangeLog (240328 => 240329)
--- trunk/JSTests/ChangeLog 2019-01-23 06:10:45 UTC (rev 240328)
+++ trunk/JSTests/ChangeLog 2019-01-23 06:21:41 UTC (rev 240329)
@@ -1,5 +1,17 @@
2019-01-22 Yusuke Suzuki
+Unreviewed, fix initial global lexical binding epoch
+https://bugs.webkit.org/show_bug.cgi?id=193603
+
+
+* stress/global-lexical-binding-epoch-should-be-correct-one.js: Added.
+(f1.f2.f3.f4):
+(f1.f2.f3):
+(f1.f2):
+(f1):
+
+2019-01-22 Yusuke Suzuki
+
REGRESSION(r239612) Crash at runtime due to broken DFG assumption
https://bugs.webkit.org/show_bug.cgi?id=193709
Added: trunk/JSTests/stress/global-lexical-binding-epoch-should-be-correct-one.js (0 => 240329)
--- trunk/JSTests/stress/global-lexical-binding-epoch-should-be-correct-one.js (rev 0)
+++ trunk/JSTests/stress/global-lexical-binding-epoch-should-be-correct-one.js 2019-01-23 06:21:41 UTC (rev 240329)
@@ -0,0 +1,31 @@
+globalThis.a = 0;
+function f1(v)
+{
+let x = 40;
+function f2() {
+x;
+let y = 41;
+function f3() {
+let z = 44;
+function f4() {
+z;
+if (v)
+return a;
+return 1;
+}
+return f4();
+}
+return f3();
+}
+return f2();
+}
+var N = 2;
+for (var i = 0; i < N; ++i) {
+$.evalScript(`let i${i} = 42`);
+}
+if (f1(false) !== 1) {
+throw new Error('first');
+}
+$.evalScript(`let a = 42`);
+if (f1(true) !== 42)
+throw new Error('second');
Modified: trunk/Source/_javascript_Core/ChangeLog (240328 => 240329)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-23 06:10:45 UTC (rev 240328)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-23 06:21:41 UTC (rev 240329)
@@ -1,5 +1,14 @@
2019-01-22 Yusuke Suzuki
+Unreviewed, fix initial global lexical binding epoch
+https://bugs.webkit.org/show_bug.cgi?id=193603
+
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::finishCreation):
+
+2019-01-22 Yusuke Suzuki
+
REGRESSION(r239612) Crash at runtime due to broken DFG assumption
https://bugs.webkit.org/show_bug.cgi?id=193709
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (240328 => 240329)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2019-01-23 06:10:45 UTC (rev 240328)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2019-01-23 06:21:41 UTC (rev 240329)
@@ -625,7 +625,7 @@
metadata.m_symbolTable.set(vm, this, op.lexicalEnvironment->symbolTable());
} else if (JSScope* constantScope = JSScope::constantScopeForCodeBlock(op.type, this)) {
metadata.m_constantScope.set(vm, this, constantScope);
-if (op.type == GlobalLexicalVar || op.type == GlobalLexicalVarWithVarInjectionChecks)
+if (op.type == GlobalProperty || op.type == GlobalPropertyWithVarInjectionChecks)
metadata.m_globalLexicalBindingEpoch = m_globalObject->globalLexicalBindingEpoch();
} else
metadata.m_globalObject = nullptr;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240328] trunk/Source/WebCore
Title: [240328] trunk/Source/WebCore
Revision 240328
Author wenson_hs...@apple.com
Date 2019-01-22 22:10:45 -0800 (Tue, 22 Jan 2019)
Log Message
Introduce CustomUndoStep.h and CustomUndoStep.cpp
https://bugs.webkit.org/show_bug.cgi?id=193704
Reviewed by Ryosuke Niwa.
This patch is more work in progress towards supporting `UndoManager.addItem()`. Here, we introduce a helper
class, CustomUndoStep, that holds a weak reference to a script-defined UndoItem. See below for more details.
No change in behavior.
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* editing/CustomUndoStep.cpp:
(WebCore::CustomUndoStep::CustomUndoStep):
Subclass UndoStep.
(WebCore::CustomUndoStep::unapply):
(WebCore::CustomUndoStep::reapply):
If possible, invoke the UndoItem's undo and redo handlers.
(WebCore::CustomUndoStep::isValid const):
* editing/CustomUndoStep.h:
* editing/EditingStyle.cpp:
* editing/InsertEditableImageCommand.cpp:
(WebCore::InsertEditableImageCommand::doApply):
Unified build fixes.
* page/UndoItem.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/editing/EditingStyle.cpp
trunk/Source/WebCore/editing/InsertEditableImageCommand.cpp
trunk/Source/WebCore/page/UndoItem.h
Added Paths
trunk/Source/WebCore/editing/CustomUndoStep.cpp
trunk/Source/WebCore/editing/CustomUndoStep.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (240327 => 240328)
--- trunk/Source/WebCore/ChangeLog 2019-01-23 05:55:08 UTC (rev 240327)
+++ trunk/Source/WebCore/ChangeLog 2019-01-23 06:10:45 UTC (rev 240328)
@@ -1,3 +1,38 @@
+2019-01-22 Wenson Hsieh
+
+Introduce CustomUndoStep.h and CustomUndoStep.cpp
+https://bugs.webkit.org/show_bug.cgi?id=193704
+
+
+Reviewed by Ryosuke Niwa.
+
+This patch is more work in progress towards supporting `UndoManager.addItem()`. Here, we introduce a helper
+class, CustomUndoStep, that holds a weak reference to a script-defined UndoItem. See below for more details.
+
+No change in behavior.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* editing/CustomUndoStep.cpp:
+(WebCore::CustomUndoStep::CustomUndoStep):
+
+Subclass UndoStep.
+
+(WebCore::CustomUndoStep::unapply):
+(WebCore::CustomUndoStep::reapply):
+
+If possible, invoke the UndoItem's undo and redo handlers.
+
+(WebCore::CustomUndoStep::isValid const):
+* editing/CustomUndoStep.h:
+* editing/EditingStyle.cpp:
+* editing/InsertEditableImageCommand.cpp:
+(WebCore::InsertEditableImageCommand::doApply):
+
+Unified build fixes.
+
+* page/UndoItem.h:
+
2019-01-22 Simon Fraser
Adding a child to a ScrollingStateNode needs to trigger a tree state commit
Modified: trunk/Source/WebCore/Sources.txt (240327 => 240328)
--- trunk/Source/WebCore/Sources.txt 2019-01-23 05:55:08 UTC (rev 240327)
+++ trunk/Source/WebCore/Sources.txt 2019-01-23 06:10:45 UTC (rev 240328)
@@ -952,6 +952,7 @@
editing/ChangeListTypeCommand.cpp
editing/CompositeEditCommand.cpp
editing/CreateLinkCommand.cpp
+editing/CustomUndoStep.cpp
editing/DeleteFromTextNodeCommand.cpp
editing/DeleteSelectionCommand.cpp
editing/DictationAlternative.cpp
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (240327 => 240328)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2019-01-23 05:55:08 UTC (rev 240327)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2019-01-23 06:10:45 UTC (rev 240328)
@@ -15131,6 +15131,8 @@
F4D9817E2195FBF6008230FC /* ChangeListTypeCommand.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = ChangeListTypeCommand.cpp; sourceTree = ""; };
F4E1965A21F2395000285078 /* JSUndoItemCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSUndoItemCustom.cpp; sourceTree = ""; };
F4E1965F21F26E4E00285078 /* UndoItem.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = UndoItem.cpp; sourceTree = ""; };
+ F4E1966121F27D3C00285078 /* CustomUndoStep.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CustomUndoStep.h; sourceTree = ""; };
+ F4E1966221F27D3D00285078 /* CustomUndoStep.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CustomUndoStep.cpp; sourceTree = ""; };
F4E57EDA213F3F5F004EA98E /* FontAttributeChanges.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = FontAttributeChanges.h; sourceTree = ""; };
F4E57EDF213F434A004EA98E /* WebCoreNSFontManagerExtras.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WebCoreNSFontManagerExtras.h; sourceTree = ""; };
F4E57EE0213F434A004EA98E /* WebCoreNSFontManagerExtras.mm */ = {isa = PBXFileReference;
[webkit-changes] [240327] trunk
Title: [240327] trunk
Revision 240327
Author ysuz...@apple.com
Date 2019-01-22 21:55:08 -0800 (Tue, 22 Jan 2019)
Log Message
REGRESSION(r239612) Crash at runtime due to broken DFG assumption
https://bugs.webkit.org/show_bug.cgi?id=193709
Unreviewed, rollout to watch the tests.
JSTests:
* stress/object-tostring-changed-proto.js: Removed.
* stress/object-tostring-changed.js: Removed.
* stress/object-tostring-misc.js: Removed.
* stress/object-tostring-other.js: Removed.
* stress/object-tostring-untyped.js: Removed.
Source/_javascript_Core:
* _javascript_Core.xcodeproj/project.pbxproj:
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupObjectToString): Deleted.
* dfg/DFGNodeType.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectToString): Deleted.
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLAbstractHeapRepository.h:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructorOrStringValueOf):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectToString): Deleted.
* runtime/Intrinsic.cpp:
(JSC::intrinsicName):
* runtime/Intrinsic.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::finishCreation):
(JSC::objectProtoFuncToString):
* runtime/ObjectPrototype.h:
* runtime/ObjectPrototypeInlines.h: Removed.
* runtime/StructureRareData.h:
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/dfg/DFGDoesGC.cpp
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGNodeType.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h
trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/runtime/Intrinsic.cpp
trunk/Source/_javascript_Core/runtime/Intrinsic.h
trunk/Source/_javascript_Core/runtime/ObjectPrototype.cpp
trunk/Source/_javascript_Core/runtime/ObjectPrototype.h
trunk/Source/_javascript_Core/runtime/StructureRareData.h
Removed Paths
trunk/JSTests/stress/object-tostring-changed-proto.js
trunk/JSTests/stress/object-tostring-changed.js
trunk/JSTests/stress/object-tostring-misc.js
trunk/JSTests/stress/object-tostring-other.js
trunk/JSTests/stress/object-tostring-untyped.js
trunk/Source/_javascript_Core/runtime/ObjectPrototypeInlines.h
Diff
Modified: trunk/JSTests/ChangeLog (240326 => 240327)
--- trunk/JSTests/ChangeLog 2019-01-23 05:42:06 UTC (rev 240326)
+++ trunk/JSTests/ChangeLog 2019-01-23 05:55:08 UTC (rev 240327)
@@ -1,3 +1,17 @@
+2019-01-22 Yusuke Suzuki
+
+REGRESSION(r239612) Crash at runtime due to broken DFG assumption
+https://bugs.webkit.org/show_bug.cgi?id=193709
+
+
+Unreviewed, rollout to watch the tests.
+
+* stress/object-tostring-changed-proto.js: Removed.
+* stress/object-tostring-changed.js: Removed.
+* stress/object-tostring-misc.js: Removed.
+* stress/object-tostring-other.js: Removed.
+* stress/object-tostring-untyped.js: Removed.
+
2019-01-22 Saam Barati
Unreviewed. Rollout r240223. It regressed JetStream2 by 1%.
Deleted: trunk/JSTests/stress/object-tostring-changed-proto.js (240326 => 240327)
--- trunk/JSTests/stress/object-tostring-changed-proto.js 2019-01-23 05:42:06 UTC (rev 240326)
+++ trunk/JSTests/stress/object-tostring-changed-proto.js 2019-01-23 05:55:08 UTC (rev 240327)
@@ -1,18 +0,0 @@
-function shouldBe(actual, expected)
-{
-if (actual !== expected)
-throw new Error('bad value: ' + actual);
-}
-noInline(shouldBe);
-
-function test(value)
-{
-return Object.prototype.toString.call(value);
-}
[webkit-changes] [240326] trunk
Title: [240326] trunk Revision 240326 Author simon.fra...@apple.com Date 2019-01-22 21:42:06 -0800 (Tue, 22 Jan 2019) Log Message Adding a child to a ScrollingStateNode needs to trigger a tree state commit https://bugs.webkit.org/show_bug.cgi?id=193682 Reviewed by Zalan Bujtas. Source/WebCore: Scrolling tree mutations that re-arrange nodes (e.g. node reordering when z-index changes) need to trigger scrolling tree updates, and currently do not. Fix by adding a "ChildNodes" dirty bit to ScrollingStateNode. There isn't any code that consults this flag when committing the scrolling tree because we always eagerly traverse children, but we could use it to optimize later. The important part is that we use it to trigger a tree update. Can't test via z-reordering until webkit.org/b/192529 is fixed. Tests: scrollingcoordinator/gain-scrolling-node-parent.html scrollingcoordinator/lose-scrolling-node-parent.html * page/scrolling/ScrollingStateNode.cpp: (WebCore::ScrollingStateNode::appendChild): (WebCore::ScrollingStateNode::insertChild): (WebCore::ScrollingStateNode::removeChildAtIndex): * page/scrolling/ScrollingStateNode.h: * page/scrolling/ScrollingStateTree.cpp: (WebCore::ScrollingStateTree::attachNode): LayoutTests: * platform/ios/scrollingcoordinator/gain-scrolling-node-parent-expected.txt: Added. * platform/ios/scrollingcoordinator/lose-scrolling-node-parent-expected.txt: Added. * scrollingcoordinator/gain-scrolling-node-parent-expected.txt: Added. * scrollingcoordinator/gain-scrolling-node-parent.html: Added. * scrollingcoordinator/lose-scrolling-node-parent-expected.txt: Added. * scrollingcoordinator/lose-scrolling-node-parent.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/scrolling/ScrollingStateNode.cpp trunk/Source/WebCore/page/scrolling/ScrollingStateNode.h trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp Added Paths trunk/LayoutTests/platform/ios/scrollingcoordinator/ trunk/LayoutTests/platform/ios/scrollingcoordinator/gain-scrolling-node-parent-expected.txt trunk/LayoutTests/platform/ios/scrollingcoordinator/lose-scrolling-node-parent-expected.txt trunk/LayoutTests/scrollingcoordinator/gain-scrolling-node-parent-expected.txt trunk/LayoutTests/scrollingcoordinator/gain-scrolling-node-parent.html trunk/LayoutTests/scrollingcoordinator/lose-scrolling-node-parent-expected.txt trunk/LayoutTests/scrollingcoordinator/lose-scrolling-node-parent.html Diff Modified: trunk/LayoutTests/ChangeLog (240325 => 240326) --- trunk/LayoutTests/ChangeLog 2019-01-23 05:30:09 UTC (rev 240325) +++ trunk/LayoutTests/ChangeLog 2019-01-23 05:42:06 UTC (rev 240326) @@ -1,5 +1,19 @@ 2019-01-22 Simon Fraser +Adding a child to a ScrollingStateNode needs to trigger a tree state commit +https://bugs.webkit.org/show_bug.cgi?id=193682 + +Reviewed by Zalan Bujtas. + +* platform/ios/scrollingcoordinator/gain-scrolling-node-parent-expected.txt: Added. +* platform/ios/scrollingcoordinator/lose-scrolling-node-parent-expected.txt: Added. +* scrollingcoordinator/gain-scrolling-node-parent-expected.txt: Added. +* scrollingcoordinator/gain-scrolling-node-parent.html: Added. +* scrollingcoordinator/lose-scrolling-node-parent-expected.txt: Added. +* scrollingcoordinator/lose-scrolling-node-parent.html: Added. + +2019-01-22 Simon Fraser + Make scrollingcoordinator tests only run on iOS/macOS WK2 https://bugs.webkit.org/show_bug.cgi?id=193690 Added: trunk/LayoutTests/platform/ios/scrollingcoordinator/gain-scrolling-node-parent-expected.txt (0 => 240326) --- trunk/LayoutTests/platform/ios/scrollingcoordinator/gain-scrolling-node-parent-expected.txt (rev 0) +++ trunk/LayoutTests/platform/ios/scrollingcoordinator/gain-scrolling-node-parent-expected.txt 2019-01-23 05:42:06 UTC (rev 240326) @@ -0,0 +1,42 @@ +Scrolling content +Middle scrolling content +Inner scrolling content + +(Frame scrolling node + (scrollable area size 800 600) + (contents size 800 600) + (scrollable area parameters +(horizontal scroll elasticity 1) +(vertical scroll elasticity 1) +(horizontal scrollbar mode 0) +(vertical scrollbar mode 0)) + (visual viewport enabled 1) + (layout viewport at (0,0) size 800x600) + (min layout viewport origin (0,0)) + (max layout viewport origin (0,0)) + (behavior for fixed 0) + (children 1 +(Overflow scrolling node + (scrollable area size 420 320) + (contents size 443 1041) + (scrollable area parameters +(horizontal scroll elasticity 1) +(vertical scroll elasticity 1) +(horizontal scrollbar mode 0) +(vertical scrollbar mode 0)) + (children 1 +(Overflow scrolling node + (scrollable area size 420 320) + (contents size 420 1020) + (scrollable area parameters +(horizontal scroll
[webkit-changes] [240325] trunk/Source/WebKit
Title: [240325] trunk/Source/WebKit
Revision 240325
Author cdu...@apple.com
Date 2019-01-22 21:30:09 -0800 (Tue, 22 Jan 2019)
Log Message
Regression(r240178) Some API tests are crashing
https://bugs.webkit.org/show_bug.cgi?id=193680
Reviewed by Alex Christensen.
r240178 made sure that userScripts / scriptMessageHandlers / contentExtensions are always
properly populated in the WebPageCreationParameters. This was needed in case we need to
reconstruct the WebUserContentController on the WebProcess side. However, this caused a
regression in the case we reuse a process where the WebUserContentController still exists
(because it was kept alive, e.g. by the WebPageGroup). In that case, we would add duplicate
entries to the existing WebUserContentController instance because its "add" methods did not
have duplicate checks. To address the issue, this patch adds duplicate checks to the
WebUserContentController "add" methods.
* WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::addUserScriptMessageHandlerInternal):
(WebKit::WebUserContentController::removeUserScriptMessageHandlerInternal):
(WebKit::WebUserContentController::addUserScriptInternal):
(WebKit::WebUserContentController::removeUserScriptInternal):
(WebKit::WebUserContentController::addUserStyleSheetInternal):
(WebKit::WebUserContentController::removeUserStyleSheetInternal):
(WebKit::WebUserContentController::forEachUserMessageHandler const):
* WebProcess/UserContent/WebUserContentController.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp
trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (240324 => 240325)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 05:20:36 UTC (rev 240324)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 05:30:09 UTC (rev 240325)
@@ -1,3 +1,29 @@
+2019-01-22 Chris Dumez
+
+Regression(r240178) Some API tests are crashing
+https://bugs.webkit.org/show_bug.cgi?id=193680
+
+Reviewed by Alex Christensen.
+
+r240178 made sure that userScripts / scriptMessageHandlers / contentExtensions are always
+properly populated in the WebPageCreationParameters. This was needed in case we need to
+reconstruct the WebUserContentController on the WebProcess side. However, this caused a
+regression in the case we reuse a process where the WebUserContentController still exists
+(because it was kept alive, e.g. by the WebPageGroup). In that case, we would add duplicate
+entries to the existing WebUserContentController instance because its "add" methods did not
+have duplicate checks. To address the issue, this patch adds duplicate checks to the
+WebUserContentController "add" methods.
+
+* WebProcess/UserContent/WebUserContentController.cpp:
+(WebKit::WebUserContentController::addUserScriptMessageHandlerInternal):
+(WebKit::WebUserContentController::removeUserScriptMessageHandlerInternal):
+(WebKit::WebUserContentController::addUserScriptInternal):
+(WebKit::WebUserContentController::removeUserScriptInternal):
+(WebKit::WebUserContentController::addUserStyleSheetInternal):
+(WebKit::WebUserContentController::removeUserStyleSheetInternal):
+(WebKit::WebUserContentController::forEachUserMessageHandler const):
+* WebProcess/UserContent/WebUserContentController.h:
+
2019-01-22 Michael Catanzaro
Unreviewed attempt to fix GTK/WPE bots
Modified: trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp (240324 => 240325)
--- trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp 2019-01-23 05:20:36 UTC (rev 240324)
+++ trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp 2019-01-23 05:30:09 UTC (rev 240325)
@@ -318,8 +318,10 @@
#if ENABLE(USER_MESSAGE_HANDLERS)
void WebUserContentController::addUserScriptMessageHandlerInternal(InjectedBundleScriptWorld& world, uint64_t userScriptMessageHandlerIdentifier, const String& name)
{
-auto& messageHandlersInWorld = m_userMessageHandlers.ensure(, [] { return Vector>(); }).iterator->value;
-messageHandlersInWorld.append(WebUserMessageHandlerDescriptorProxy::create(this, name, world, userScriptMessageHandlerIdentifier));
+auto& messageHandlersInWorld = m_userMessageHandlers.ensure(, [] { return Vector>> { }; }).iterator->value;
+if (messageHandlersInWorld.findMatching([&](auto& pair) { return pair.first == userScriptMessageHandlerIdentifier; }) != notFound)
+return;
+messageHandlersInWorld.append(std::make_pair(userScriptMessageHandlerIdentifier, WebUserMessageHandlerDescriptorProxy::create(this, name, world, userScriptMessageHandlerIdentifier)));
}
void WebUserContentController::removeUserScriptMessageHandlerInternal(InjectedBundleScriptWorld& world, uint64_t
[webkit-changes] [240324] trunk/LayoutTests
Title: [240324] trunk/LayoutTests Revision 240324 Author simon.fra...@apple.com Date 2019-01-22 21:20:36 -0800 (Tue, 22 Jan 2019) Log Message Make scrollingcoordinator tests only run on iOS/macOS WK2 https://bugs.webkit.org/show_bug.cgi?id=193690 Reviewed by Zalan Bujtas. scrollingcoordinator is only active in WK2, and both WPE and WinCairo skip this directory already, so skip it at the top level, and re-enable for mac-wk2 and ios-wk2. Also do some cleanup after tiled-drawing/ios was removed on 1/18. * TestExpectations: * platform/ios-device/TestExpectations: * platform/ios-wk2/TestExpectations: * platform/ios/TestExpectations: * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/ios-device/TestExpectations trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (240323 => 240324) --- trunk/LayoutTests/ChangeLog 2019-01-23 04:51:45 UTC (rev 240323) +++ trunk/LayoutTests/ChangeLog 2019-01-23 05:20:36 UTC (rev 240324) @@ -1,3 +1,21 @@ +2019-01-22 Simon Fraser + +Make scrollingcoordinator tests only run on iOS/macOS WK2 +https://bugs.webkit.org/show_bug.cgi?id=193690 + +Reviewed by Zalan Bujtas. + +scrollingcoordinator is only active in WK2, and both WPE and WinCairo skip this directory +already, so skip it at the top level, and re-enable for mac-wk2 and ios-wk2. + +Also do some cleanup after tiled-drawing/ios was removed on 1/18. + +* TestExpectations: +* platform/ios-device/TestExpectations: +* platform/ios-wk2/TestExpectations: +* platform/ios/TestExpectations: +* platform/mac-wk2/TestExpectations: + 2019-01-22 Devin Rousso Web Inspector: InspectorInstrumentation::willEvaluateScript should include column number Modified: trunk/LayoutTests/TestExpectations (240323 => 240324) --- trunk/LayoutTests/TestExpectations 2019-01-23 04:51:45 UTC (rev 240323) +++ trunk/LayoutTests/TestExpectations 2019-01-23 05:20:36 UTC (rev 240324) @@ -39,7 +39,7 @@ fast/history/ios [ Skip ] fast/scrolling/ios [ Skip ] fast/text/mac [ Skip ] -scrollingcoordinator/ios [ Skip ] +scrollingcoordinator [ Skip ] fast/content-observation [ Skip ] media/mac [ Skip ] media/ios [ Skip ] Modified: trunk/LayoutTests/platform/ios/TestExpectations (240323 => 240324) --- trunk/LayoutTests/platform/ios/TestExpectations 2019-01-23 04:51:45 UTC (rev 240323) +++ trunk/LayoutTests/platform/ios/TestExpectations 2019-01-23 05:20:36 UTC (rev 240324) @@ -1531,10 +1531,6 @@ transforms/3d/point-mapping/3d-point-mapping-3.html [ Failure ] transforms/3d/point-mapping/3d-point-mapping-overlapping.html [ Failure ] -# Scrolling coordinator tests that fail: -scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ Failure ] -scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ Failure ] - # Userscript tests that fail: userscripts/user-script-plugin-document.html [ Failure ] Modified: trunk/LayoutTests/platform/ios-device/TestExpectations (240323 => 240324) --- trunk/LayoutTests/platform/ios-device/TestExpectations 2019-01-23 04:51:45 UTC (rev 240323) +++ trunk/LayoutTests/platform/ios-device/TestExpectations 2019-01-23 05:20:36 UTC (rev 240324) @@ -120,8 +120,6 @@ svg/custom/pattern-reference.svg [ Crash ] -tiled-drawing/ios/iphone7/compositing-layers-deep-color.html [ Failure ] - quicklook/numbers.html [ ImageOnlyFailure ] scrollbars/overflow-scrollbar-combinations.html [ Timeout ] @@ -131,7 +129,6 @@ security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html [ ImageOnlyFailure ] # Manage tests which require different device types better -tiled-drawing/ios/iphone7 fast/forms/ios/ipad fast/events/touch/ios/iphone7 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (240323 => 240324) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-01-23 04:51:45 UTC (rev 240323) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-01-23 05:20:36 UTC (rev 240324) @@ -11,8 +11,7 @@ fast/scrolling/ios [ Pass ] fast/viewport/ios [ Pass ] fast/visual-viewport/ios/ [ Pass ] -scrollingcoordinator/ios [ Pass ] -tiled-drawing/ios [ Pass ] +scrollingcoordinator [ Pass ] fast/web-share [ Pass ] editing/find [ Pass ] editing/input/ios [ Pass ] @@ -57,6 +56,10 @@ # Skipped because of . http/tests/webAPIStatistics [ Skip ] +# Non-fast scrollable region doesn't apply to iOS. +scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ Skip ] +scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ Skip ] + #// # End platform-specific directories.
[webkit-changes] [240323] trunk
Title: [240323] trunk
Revision 240323
Author drou...@apple.com
Date 2019-01-22 20:51:45 -0800 (Tue, 22 Jan 2019)
Log Message
Web Inspector: InspectorInstrumentation::willEvaluateScript should include column number
https://bugs.webkit.org/show_bug.cgi?id=116191
Reviewed by Joseph Pecoraro.
Source/WebCore:
Test inspector/timeline/line-column.html
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::evaluateModule):
* bindings/js/JSExecStateInstrumentation.h:
(WebCore::JSExecState::instrumentFunctionInternal):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::willEvaluateScript):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willCallFunctionImpl):
(WebCore::InspectorInstrumentation::willEvaluateScriptImpl):
* inspector/agents/InspectorTimelineAgent.h:
* inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
* inspector/TimelineRecordFactory.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createFunctionCallData):
(WebCore::TimelineRecordFactory::createEvaluateScriptData):
* bindings/js/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::startColumn const): Added.
Source/WebInspectorUI:
* UserInterface/Controllers/TimelineManager.js:
(WI.TimelineManager.prototype._processRecord):
LayoutTests:
* inspector/timeline/line-column.html: Added.
* inspector/timeline/line-column-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSExecStateInstrumentation.h
trunk/Source/WebCore/bindings/js/ScriptController.cpp
trunk/Source/WebCore/bindings/js/ScriptSourceCode.h
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp
trunk/Source/WebCore/inspector/TimelineRecordFactory.h
trunk/Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/agents/InspectorTimelineAgent.h
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
Added Paths
trunk/LayoutTests/inspector/timeline/line-column-expected.txt
trunk/LayoutTests/inspector/timeline/line-column.html
Diff
Modified: trunk/LayoutTests/ChangeLog (240322 => 240323)
--- trunk/LayoutTests/ChangeLog 2019-01-23 04:49:56 UTC (rev 240322)
+++ trunk/LayoutTests/ChangeLog 2019-01-23 04:51:45 UTC (rev 240323)
@@ -1,5 +1,16 @@
2019-01-22 Devin Rousso
+Web Inspector: InspectorInstrumentation::willEvaluateScript should include column number
+https://bugs.webkit.org/show_bug.cgi?id=116191
+
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/timeline/line-column.html: Added.
+* inspector/timeline/line-column-expected.txt: Added.
+
+2019-01-22 Devin Rousso
+
Web Inspector: expose Audit and Recording versions to the frontend
https://bugs.webkit.org/show_bug.cgi?id=193262
Added: trunk/LayoutTests/inspector/timeline/line-column-expected.txt (0 => 240323)
--- trunk/LayoutTests/inspector/timeline/line-column-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/timeline/line-column-expected.txt 2019-01-23 04:51:45 UTC (rev 240323)
@@ -0,0 +1,238 @@
+Test that script Timeline records have column numbers.
+
+
+
+== Running test suite: Timeline.LineColumn
+-- Running test case: Timeline.LineColumn.willCallFunction
+Evaluating in page...
+PASS: Capturing started.
+{
+ "startTime": "",
+ "data": {},
+ "children": [
+{
+ "startTime": "",
+ "stackTrace": [
+{
+ "functionName": "click",
+ "url": "[native code]",
+ "scriptId": "",
+ "lineNumber": 0,
+ "columnNumber": 0
+},
+{
+ "functionName": "willCallFunctionTest",
+ "url": "timeline/line-column.html",
+ "scriptId": "",
+ "lineNumber": 26,
+ "columnNumber": 44
+},
+{
+ "functionName": "global code",
+ "url": "",
+ "scriptId": "",
+ "lineNumber": 1,
+ "columnNumber": 21
+},
+{
+ "functionName": "evaluateWithScopeExtension",
+ "url": "[native code]",
+ "scriptId": "",
+ "lineNumber": 0,
+ "columnNumber": 0
+},
+{
+ "functionName": "",
+ "url": "",
+ "scriptId": "",
+ "lineNumber": 134,
+ "columnNumber": 97
+}
+ ],
+ "data": {},
+ "frameId": "",
+ "type": "ScheduleStyleRecalculation"
+},
+{
+ "startTime": "",
+ "frameId": "",
+ "data": {
+"type": "click"
+ },
+ "children": [],
+
[webkit-changes] [240322] releases/Apple
Title: [240322] releases/Apple Revision 240322 Author m...@apple.com Date 2019-01-22 20:49:56 -0800 (Tue, 22 Jan 2019) Log Message Added a tag for Safari 12.0.3. Added Paths releases/Apple/Safari 12.0.3/ releases/Apple/Safari 12.0.3/ANGLE/ releases/Apple/Safari 12.0.3/_javascript_Core/ releases/Apple/Safari 12.0.3/WTF/ releases/Apple/Safari 12.0.3/WebCore/ releases/Apple/Safari 12.0.3/WebInspectorUI/ releases/Apple/Safari 12.0.3/WebKit/ releases/Apple/Safari 12.0.3/WebKitLegacy/ releases/Apple/Safari 12.0.3/bmalloc/ releases/Apple/Safari 12.0.3/libwebrtc/ Diff Index: releases/Apple/Safari 12.0.3/ANGLE === --- tags/Safari-606.4.5.3.1/Source/ThirdParty/ANGLE 2019-01-23 04:48:31 UTC (rev 240321) +++ releases/Apple/Safari 12.0.3/ANGLE 2019-01-23 04:49:56 UTC (rev 240322) Property changes: releases/Apple/Safari 12.0.3/ANGLE Added: allow-tabs +true \ No newline at end of property Added: svn:mergeinfo +/trunk/Source/ThirdParty/ANGLE:53455,235254,235419,235666,236554,236576,236587,238267,238270,239062 \ No newline at end of property Index: releases/Apple/Safari 12.0.3/_javascript_Core === --- tags/Safari-606.4.5.3.1/Source/_javascript_Core 2019-01-23 04:48:31 UTC (rev 240321) +++ releases/Apple/Safari 12.0.3/_javascript_Core 2019-01-23 04:49:56 UTC (rev 240322) Property changes: releases/Apple/Safari 12.0.3/_javascript_Core Added: svn:mergeinfo +/trunk/Source/_javascript_Core:53455,235254,235419,235666,236554,236576,236587,238267,238270,239062 \ No newline at end of property Index: releases/Apple/Safari 12.0.3/WTF === --- tags/Safari-606.4.5.3.1/Source/WTF 2019-01-23 04:48:31 UTC (rev 240321) +++ releases/Apple/Safari 12.0.3/WTF 2019-01-23 04:49:56 UTC (rev 240322) Property changes: releases/Apple/Safari 12.0.3/WTF Added: svn:mergeinfo +/trunk/Source/WTF:53455,235254,235419,235666,236554,236576,236587,238267,238270,239062 \ No newline at end of property Index: releases/Apple/Safari 12.0.3/WebInspectorUI === --- tags/Safari-606.4.5.3.1/Source/WebInspectorUI 2019-01-23 04:48:31 UTC (rev 240321) +++ releases/Apple/Safari 12.0.3/WebInspectorUI 2019-01-23 04:49:56 UTC (rev 240322) Property changes: releases/Apple/Safari 12.0.3/WebInspectorUI Added: svn:mergeinfo +/trunk/Source/WebInspectorUI:53455,235254,235419,235666,236554,236576,236587,238267,238270,239062 \ No newline at end of property Index: releases/Apple/Safari 12.0.3/bmalloc === --- tags/Safari-606.4.5.3.1/Source/bmalloc 2019-01-23 04:48:31 UTC (rev 240321) +++ releases/Apple/Safari 12.0.3/bmalloc 2019-01-23 04:49:56 UTC (rev 240322) Property changes: releases/Apple/Safari 12.0.3/bmalloc Added: svn:mergeinfo +/trunk/Source/bmalloc:53455,235254,235419,235666,236554,236576,236587,238267,238270,239062 \ No newline at end of property Index: releases/Apple/Safari 12.0.3/libwebrtc === --- tags/Safari-606.4.5.3.1/Source/ThirdParty/libwebrtc 2019-01-23 04:48:31 UTC (rev 240321) +++ releases/Apple/Safari 12.0.3/libwebrtc 2019-01-23 04:49:56 UTC (rev 240322) Property changes: releases/Apple/Safari 12.0.3/libwebrtc Added: svn:mergeinfo +/trunk/Source/ThirdParty/libwebrtc:53455,235254,235419,235666,236554,236576,236587,238267,238270,239062 \ No newline at end of property ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240321] releases/Apple
Title: [240321] releases/Apple Revision 240321 Author m...@apple.com Date 2019-01-22 20:48:31 -0800 (Tue, 22 Jan 2019) Log Message Added a tag iOS 12.1.3. Added Paths releases/Apple/iOS 12.1.3/ releases/Apple/iOS 12.1.3/ANGLE/ releases/Apple/iOS 12.1.3/_javascript_Core/ releases/Apple/iOS 12.1.3/WTF/ releases/Apple/iOS 12.1.3/WebCore/ releases/Apple/iOS 12.1.3/WebKit/ releases/Apple/iOS 12.1.3/WebKitLegacy/ releases/Apple/iOS 12.1.3/bmalloc/ releases/Apple/iOS 12.1.3/libwebrtc/ Diff Index: releases/Apple/iOS 12.1.3/ANGLE === --- tags/Safari-606.4.5/Source/ThirdParty/ANGLE 2019-01-23 04:42:54 UTC (rev 240320) +++ releases/Apple/iOS 12.1.3/ANGLE 2019-01-23 04:48:31 UTC (rev 240321) Property changes: releases/Apple/iOS 12.1.3/ANGLE Added: allow-tabs +true \ No newline at end of property Added: svn:mergeinfo +/trunk/Source/ThirdParty/ANGLE:53455,235254,235419,235666,236554,236576,236587,238267,238270,239062 \ No newline at end of property Index: releases/Apple/iOS 12.1.3/_javascript_Core === --- tags/Safari-606.4.5/Source/_javascript_Core 2019-01-23 04:42:54 UTC (rev 240320) +++ releases/Apple/iOS 12.1.3/_javascript_Core 2019-01-23 04:48:31 UTC (rev 240321) Property changes: releases/Apple/iOS 12.1.3/_javascript_Core Added: svn:mergeinfo +/trunk/Source/_javascript_Core:53455,235254,235419,235666,236554,236576,236587,238267,238270,239062 \ No newline at end of property Index: releases/Apple/iOS 12.1.3/WTF === --- tags/Safari-606.4.5/Source/WTF 2019-01-23 04:42:54 UTC (rev 240320) +++ releases/Apple/iOS 12.1.3/WTF 2019-01-23 04:48:31 UTC (rev 240321) Property changes: releases/Apple/iOS 12.1.3/WTF Added: svn:mergeinfo +/trunk/Source/WTF:53455,235254,235419,235666,236554,236576,236587,238267,238270,239062 \ No newline at end of property Index: releases/Apple/iOS 12.1.3/bmalloc === --- tags/Safari-606.4.5/Source/bmalloc 2019-01-23 04:42:54 UTC (rev 240320) +++ releases/Apple/iOS 12.1.3/bmalloc 2019-01-23 04:48:31 UTC (rev 240321) Property changes: releases/Apple/iOS 12.1.3/bmalloc Added: svn:mergeinfo +/trunk/Source/bmalloc:53455,235254,235419,235666,236554,236576,236587,238267,238270,239062 \ No newline at end of property Index: releases/Apple/iOS 12.1.3/libwebrtc === --- tags/Safari-606.4.5/Source/ThirdParty/libwebrtc 2019-01-23 04:42:54 UTC (rev 240320) +++ releases/Apple/iOS 12.1.3/libwebrtc 2019-01-23 04:48:31 UTC (rev 240321) Property changes: releases/Apple/iOS 12.1.3/libwebrtc Added: svn:mergeinfo +/trunk/Source/ThirdParty/libwebrtc:53455,235254,235419,235666,236554,236576,236587,238267,238270,239062 \ No newline at end of property ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240320] trunk
Title: [240320] trunk Revision 240320 Author you...@apple.com Date 2019-01-22 20:42:54 -0800 (Tue, 22 Jan 2019) Log Message Resync libwebrtc with latest M72 branch https://bugs.webkit.org/show_bug.cgi?id=193693 LayoutTests/imported/w3c: Reviewed by Eric Carlson. * web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt: Source/ThirdParty/libwebrtc: Reviewed by Eric Carlson. Update libwebrtc up to latest M72 branch to fix some identified issues: - Bad bandwidth estimation in case of multiple transceivers - mid handling for legacy endpoints - msid handling for updating mediastreams accordingly. * Source/webrtc/modules/congestion_controller/goog_cc/delay_based_bwe.cc: * Source/webrtc/modules/congestion_controller/goog_cc/delay_based_bwe.h: * Source/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc: * Source/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control_unittest.cc: * Source/webrtc/modules/congestion_controller/send_side_congestion_controller_unittest.cc: * Source/webrtc/pc/jsepsessiondescription_unittest.cc: * Source/webrtc/pc/mediasession.cc: * Source/webrtc/pc/mediasession_unittest.cc: * Source/webrtc/pc/peerconnection.cc: * Source/webrtc/pc/peerconnection.h: * Source/webrtc/pc/peerconnection_jsep_unittest.cc: * Source/webrtc/pc/peerconnection_media_unittest.cc: * Source/webrtc/pc/peerconnection_rtp_unittest.cc: * Source/webrtc/pc/sessiondescription.cc: * Source/webrtc/pc/sessiondescription.h: * Source/webrtc/pc/webrtcsdp.cc: * Source/webrtc/pc/webrtcsdp_unittest.cc: * Source/webrtc/system_wrappers/include/metrics.h: * Source/webrtc/video/BUILD.gn: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt trunk/Source/ThirdParty/libwebrtc/ChangeLog trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/goog_cc/delay_based_bwe.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/goog_cc/delay_based_bwe.h trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control_unittest.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/send_side_congestion_controller_unittest.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/jsepsessiondescription_unittest.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/mediasession.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/mediasession_unittest.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/peerconnection.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/peerconnection.h trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/peerconnection_jsep_unittest.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/peerconnection_media_unittest.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/peerconnection_rtp_unittest.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/sessiondescription.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/sessiondescription.h trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/webrtcsdp.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/pc/webrtcsdp_unittest.cc trunk/Source/ThirdParty/libwebrtc/Source/webrtc/system_wrappers/include/metrics.h trunk/Source/ThirdParty/libwebrtc/Source/webrtc/video/BUILD.gn Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (240319 => 240320) --- trunk/LayoutTests/imported/w3c/ChangeLog 2019-01-23 04:28:57 UTC (rev 240319) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-01-23 04:42:54 UTC (rev 240320) @@ -1,3 +1,13 @@ +2019-01-22 Youenn Fablet + +Resync libwebrtc with latest M72 branch +https://bugs.webkit.org/show_bug.cgi?id=193693 + + +Reviewed by Eric Carlson. + +* web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt: + 2019-01-22 Oriol Brufau [css-logical] Implement flow-relative margin, padding and border shorthands Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt (240319 => 240320) --- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt 2019-01-23 04:28:57 UTC (rev 240319) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt 2019-01-23 04:42:54 UTC (rev 240320) @@ -8,7 +8,7 @@ PASS checkAddTransceiverWithSetRemoteOfferSending PASS checkAddTransceiverWithSetRemoteOfferNoSend PASS checkAddTransceiverBadKind -FAIL checkNoMidOffer promise_test: Unhandled rejection with value: object "InvalidAccessError: Failed to set remote offer sdp: The BUNDLE group contains MID:0 matching no m= section." +PASS checkNoMidOffer PASS checkSetDirection PASS checkCurrentDirection PASS checkSendrecvWithNoSendTrack Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (240319
[webkit-changes] [240319] trunk/Websites/perf.webkit.org
Title: [240319] trunk/Websites/perf.webkit.org
Revision 240319
Author dewei_...@apple.com
Date 2019-01-22 20:28:57 -0800 (Tue, 22 Jan 2019)
Log Message
Analyzing a chart that does not exist should not halt whole run-analysis script.
https://bugs.webkit.org/show_bug.cgi?id=193563
Reviewed by Ryosuke Niwa.
Halting whole run-analysis script while there is any invalid chart specified in Manifest makes the script fragile.
Run-analysis is also responsible for adding retry and sending notification which should not be block by this error.
Skipping analyzing the corresponding configuration seems reasonable.
* public/v3/models/measurement-set.js:
(MeasurementSet.prototype._ensureClusterPromise): Only add callback when callback is specified.
This will help to fix 'UnhandledPromiseRejectionWarning' while running the test.
* tools/js/measurement-set-analyzer.js:
(MeasurementSetAnalyzer.prototype.async._analyzeMeasurementSet): Catch the exception while failing to fetch a measurement set and skip the analysis for this config.
* unit-tests/measurement-set-analyzer-tests.js: Added unit tests for this.
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v3/models/measurement-set.js
trunk/Websites/perf.webkit.org/tools/js/measurement-set-analyzer.js
trunk/Websites/perf.webkit.org/unit-tests/measurement-set-analyzer-tests.js
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (240318 => 240319)
--- trunk/Websites/perf.webkit.org/ChangeLog 2019-01-23 04:17:06 UTC (rev 240318)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2019-01-23 04:28:57 UTC (rev 240319)
@@ -1,5 +1,23 @@
2019-01-17 Dewei Zhu
+Analyzing a chart that does not exist should not halt whole run-analysis script.
+https://bugs.webkit.org/show_bug.cgi?id=193563
+
+Reviewed by Ryosuke Niwa.
+
+Halting whole run-analysis script while there is any invalid chart specified in Manifest makes the script fragile.
+Run-analysis is also responsible for adding retry and sending notification which should not be block by this error.
+Skipping analyzing the corresponding configuration seems reasonable.
+
+* public/v3/models/measurement-set.js:
+(MeasurementSet.prototype._ensureClusterPromise): Only add callback when callback is specified.
+This will help to fix 'UnhandledPromiseRejectionWarning' while running the test.
+* tools/js/measurement-set-analyzer.js:
+(MeasurementSetAnalyzer.prototype.async._analyzeMeasurementSet): Catch the exception while failing to fetch a measurement set and skip the analysis for this config.
+* unit-tests/measurement-set-analyzer-tests.js: Added unit tests for this.
+
+2019-01-17 Dewei Zhu
+
Updating commit in OSBuildFetcher should respect revision range in config.
https://bugs.webkit.org/show_bug.cgi?id=193558
Modified: trunk/Websites/perf.webkit.org/public/v3/models/measurement-set.js (240318 => 240319)
--- trunk/Websites/perf.webkit.org/public/v3/models/measurement-set.js 2019-01-23 04:17:06 UTC (rev 240318)
+++ trunk/Websites/perf.webkit.org/public/v3/models/measurement-set.js 2019-01-23 04:28:57 UTC (rev 240319)
@@ -62,7 +62,8 @@
if (!this._primaryClusterPromise)
this._primaryClusterPromise = this._fetchPrimaryCluster(noCache);
var self = this;
-this._primaryClusterPromise.catch(callback);
+if (callback)
+this._primaryClusterPromise.catch(callback);
return this._primaryClusterPromise.then(function () {
self._allFetches[self._primaryClusterEndTime] = self._primaryClusterPromise;
return Promise.all(self.findClusters(startTime, endTime).map(function (clusterEndTime) {
@@ -76,12 +77,14 @@
if (!this._callbackMap.has(clusterEndTime))
this._callbackMap.set(clusterEndTime, new Set);
var callbackSet = this._callbackMap.get(clusterEndTime);
-callbackSet.add(callback);
+if (callback)
+callbackSet.add(callback);
var promise = this._allFetches[clusterEndTime];
-if (promise)
-promise.then(callback, callback);
-else {
+if (promise) {
+if (callback)
+promise.then(callback, callback);
+} else {
promise = this._fetchSecondaryCluster(clusterEndTime);
for (var existingCallback of callbackSet)
promise.then(existingCallback, existingCallback);
Modified: trunk/Websites/perf.webkit.org/tools/js/measurement-set-analyzer.js (240318 => 240319)
--- trunk/Websites/perf.webkit.org/tools/js/measurement-set-analyzer.js 2019-01-23 04:17:06 UTC (rev 240318)
+++ trunk/Websites/perf.webkit.org/tools/js/measurement-set-analyzer.js 2019-01-23 04:28:57 UTC (rev 240319)
@@ -49,7 +49,14 @@
const metric = Metric.findById(measurementSet.metricId());
const platform =
[webkit-changes] [240318] trunk
Title: [240318] trunk Revision 240318 Author drou...@apple.com Date 2019-01-22 20:17:06 -0800 (Tue, 22 Jan 2019) Log Message Web Inspector: expose Audit and Recording versions to the frontend https://bugs.webkit.org/show_bug.cgi?id=193262 Reviewed by Joseph Pecoraro. Source/_javascript_Core: * inspector/protocol/Audit.json: * inspector/protocol/Recording.json: Add `version` values. * inspector/scripts/codegen/models.py: (Protocol.parse_domain): (Domain.__init__): (Domain.version): Added. (Domains): * inspector/scripts/codegen/generator.py: (Generator.version_for_domain): Added. * inspector/scripts/codegen/generate_cpp_protocol_types_header.py: (CppProtocolTypesHeaderGenerator.generate_output): (CppProtocolTypesHeaderGenerator._generate_versions): Added. * inspector/scripts/codegen/generate_js_backend_commands.py: (JSBackendCommandsGenerator.should_generate_domain): (JSBackendCommandsGenerator.generate_domain): * inspector/scripts/tests/generic/version.json: Added. * inspector/scripts/tests/generic/expected/version.json-result: Added. * inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result: * inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result: * inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result: * inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result: * inspector/scripts/tests/generic/expected/domain-availability.json-result: * inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result: * inspector/scripts/tests/generic/expected/enum-values.json-result: * inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result: * inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result: * inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result: * inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result: * inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result: * inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result: * inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result: * inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result: * inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result: * inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result: * inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result: * inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result: Source/WebCore: Tests: inspector/audit/version.html inspector/recording/version.html * inspector/agents/InspectorCanvasAgent.cpp: (WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame): Source/WebInspectorUI: * UserInterface/Protocol/InspectorBackend.js: (InspectorBackendClass.prototype.registerVersion): Added. * UserInterface/Models/AuditTestCase.js: * UserInterface/Models/Recording.js: (WI.Recording.fromPayload): Add Interface version values. LayoutTests: * inspector/audit/version.html: Added. * inspector/audit/version-expected.txt: Added. * inspector/recording/version.html: Added. * inspector/recording/version-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/inspector/protocol/Audit.json trunk/Source/_javascript_Core/inspector/protocol/Recording.json trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_cpp_protocol_types_header.py trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_js_backend_commands.py trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py trunk/Source/_javascript_Core/inspector/scripts/codegen/models.py trunk/Source/_javascript_Core/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/domain-availability.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/enum-values.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result
[webkit-changes] [240317] trunk/Source/WebKit
Title: [240317] trunk/Source/WebKit
Revision 240317
Author mcatanz...@igalia.com
Date 2019-01-22 20:06:56 -0800 (Tue, 22 Jan 2019)
Log Message
Unreviewed attempt to fix GTK/WPE bots
https://bugs.webkit.org/show_bug.cgi?id=193580
Doesn't make sense to clear the storage session right after creating it. This should fix
network process crash on startup under G_DEBUG=fatal-criticals due to the storage session
not having a cookie jar.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (240316 => 240317)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 02:12:08 UTC (rev 240316)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 04:06:56 UTC (rev 240317)
@@ -1,3 +1,16 @@
+2019-01-22 Michael Catanzaro
+
+Unreviewed attempt to fix GTK/WPE bots
+https://bugs.webkit.org/show_bug.cgi?id=193580
+
+
+Doesn't make sense to clear the storage session right after creating it. This should fix
+network process crash on startup under G_DEBUG=fatal-criticals due to the storage session
+not having a cookie jar.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::NetworkProcess):
+
2019-01-22 Megan Gardner
Cancel Web Touches Properly so that long presses on YouTube links do not incorrectly trigger a load
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (240316 => 240317)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2019-01-23 02:12:08 UTC (rev 240316)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2019-01-23 04:06:56 UTC (rev 240317)
@@ -163,7 +163,6 @@
DNSResolveQueueSoup::setGlobalDefaultNetworkStorageSessionAccessor([this]() -> NetworkStorageSession& {
return defaultStorageSession();
});
-defaultStorageSession().clearSoupNetworkSessionAndCookieStorage();
#endif
NetworkStateNotifier::singleton().addListener([this](bool isOnLine) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240316] trunk/Source/WebKit
Title: [240316] trunk/Source/WebKit
Revision 240316
Author megan_gard...@apple.com
Date 2019-01-22 18:12:08 -0800 (Tue, 22 Jan 2019)
Log Message
Cancel Web Touches Properly so that long presses on YouTube links do not incorrectly trigger a load
https://bugs.webkit.org/show_bug.cgi?id=193687
Reviewed by Tim Horton.
Cancel web gestures when a long press is recognized.
* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _cancelWebGestureRecognizer]):
(-[WKContentView _longPressRecognized:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (240315 => 240316)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 02:06:53 UTC (rev 240315)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 02:12:08 UTC (rev 240316)
@@ -1,3 +1,18 @@
+2019-01-22 Megan Gardner
+
+Cancel Web Touches Properly so that long presses on YouTube links do not incorrectly trigger a load
+https://bugs.webkit.org/show_bug.cgi?id=193687
+
+
+Reviewed by Tim Horton.
+
+Cancel web gestures when a long press is recognized.
+
+* Platform/spi/ios/UIKitSPI.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _cancelWebGestureRecognizer]):
+(-[WKContentView _longPressRecognized:]):
+
2019-01-22 Alex Christensen
Fix an internal build failure after r240292
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (240315 => 240316)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2019-01-23 02:06:53 UTC (rev 240315)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2019-01-23 02:12:08 UTC (rev 240316)
@@ -758,6 +758,7 @@
@interface UIWebTouchEventsGestureRecognizer ()
- (id)initWithTarget:(id)target action:(SEL)action touchDelegate:(id )delegate;
+- (void)cancel;
@property (nonatomic, getter=isDefaultPrevented) BOOL defaultPrevented;
@property (nonatomic, readonly) BOOL inJavaScriptGesture;
@property (nonatomic, readonly) CGPoint locationInWindow;
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (240315 => 240316)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-01-23 02:06:53 UTC (rev 240315)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-01-23 02:12:08 UTC (rev 240316)
@@ -1348,6 +1348,13 @@
[_highlightLongPressGestureRecognizer cancel];
}
+- (void)_cancelTouchEventGestureRecognizer
+{
+#if HAVE(CANCEL_WEB_TOUCH_EVENTS_GESTURE)
+[_touchEventGestureRecognizer cancel];
+#endif
+}
+
- (void)_didScroll
{
[self _cancelLongPressGestureRecognizer];
@@ -1979,6 +1986,7 @@
{
ASSERT(gestureRecognizer == _longPressGestureRecognizer);
[self _resetIsDoubleTapPending];
+[self _cancelTouchEventGestureRecognizer];
_lastInteractionLocation = gestureRecognizer.startPoint;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240315] trunk/Source/WebCore
Title: [240315] trunk/Source/WebCore
Revision 240315
Author wenson_hs...@apple.com
Date 2019-01-22 18:06:53 -0800 (Tue, 22 Jan 2019)
Log Message
Add some bindings-related bookkeeping to UndoManager and UndoItem
https://bugs.webkit.org/show_bug.cgi?id=193111
Reviewed by Ryosuke Niwa.
This patch is work in progress towards supporting `UndoManager.addItem()`. Here, we add helper methods to
UndoItem and UndoManager which later patches will exercise, as well as introduce some custom bindings to
properly handle the case where UndoItems are given anonymous _javascript_ functions (see below for more details).
No new tests, because there is no script-observable change in behavior yet. When `addItems()` is hooked up, I
will write a test to verify that the undo and redo _javascript_ functions survive garbage collection.
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSUndoItemCustom.cpp:
(WebCore::JSUndoItem::visitAdditionalChildren):
Have each JSUndoItem visit its undo and redo callback functions to ensure that the _javascript_ wrapper objects
for these functions are not garbage collected underneath the item.
(WebCore::JSUndoItemOwner::isReachableFromOpaqueRoots):
Consider the undo item wrapper reachable from opaque roots if it is associated with its UndoManager's Document.
This ensures that if script isn't holding on to a reference to the wrapper (for instance, by calling
`UndoManager.addItem(new UndoItem({ ... }))`), we still protect the corresponding JSUndoItem as long as the
UndoManager's Document is alive. In the case where the undo item is not associated with a document, either (1)
script is keeping a reference to it, in which case it will be trivially reachable, or (2) script won't be able
to observe the destruction of the wrapper anyways (e.g. calling `new UndoItem({ ... })` by itself).
* dom/Document.cpp:
(WebCore::Document::prepareForDestruction):
Invalidate all undo items when the document is about to go away.
* page/UndoItem.cpp:
(WebCore::UndoItem::setUndoManager):
(WebCore::UndoItem::invalidate):
(WebCore::UndoItem::isValid const):
Add a few helpers, to be used in a future patch. We consider an UndoItem valid if it has been added to an
UndoManager, and is thus associated with a document.
(WebCore::UndoItem::document const):
* page/UndoItem.h:
* page/UndoItem.idl:
* page/UndoManager.cpp:
(WebCore::UndoManager::UndoManager):
(WebCore::UndoManager::addItem):
Have an UndoManager keep its UndoItems alive. These UndoItems remain in this set until either the document will
be destroyed, or the corresponding undo action is no longer needed because the platform undo stack has changed
(this latter behavior is yet to be implemented).
(WebCore::UndoManager::removeItem):
(WebCore::UndoManager::removeAllItems):
* page/UndoManager.h:
(WebCore::UndoManager::UndoManager): Deleted.
* page/scrolling/ScrollingTreeScrollingNode.cpp:
Unified build fix.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/UndoItem.h
trunk/Source/WebCore/page/UndoItem.idl
trunk/Source/WebCore/page/UndoManager.cpp
trunk/Source/WebCore/page/UndoManager.h
Added Paths
trunk/Source/WebCore/bindings/js/JSUndoItemCustom.cpp
trunk/Source/WebCore/page/UndoItem.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (240314 => 240315)
--- trunk/Source/WebCore/ChangeLog 2019-01-23 01:46:01 UTC (rev 240314)
+++ trunk/Source/WebCore/ChangeLog 2019-01-23 02:06:53 UTC (rev 240315)
@@ -1,3 +1,67 @@
+2019-01-22 Wenson Hsieh
+
+Add some bindings-related bookkeeping to UndoManager and UndoItem
+https://bugs.webkit.org/show_bug.cgi?id=193111
+
+
+Reviewed by Ryosuke Niwa.
+
+This patch is work in progress towards supporting `UndoManager.addItem()`. Here, we add helper methods to
+UndoItem and UndoManager which later patches will exercise, as well as introduce some custom bindings to
+properly handle the case where UndoItems are given anonymous _javascript_ functions (see below for more details).
+
+No new tests, because there is no script-observable change in behavior yet. When `addItems()` is hooked up, I
+will write a test to verify that the undo and redo _javascript_ functions survive garbage collection.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* bindings/js/JSUndoItemCustom.cpp:
+(WebCore::JSUndoItem::visitAdditionalChildren):
+
+Have each JSUndoItem visit its undo and redo callback functions to ensure that the _javascript_ wrapper objects
+for these functions are not garbage collected underneath the item.
+
+(WebCore::JSUndoItemOwner::isReachableFromOpaqueRoots):
+
+Consider the undo item wrapper reachable from opaque roots if it is associated with its UndoManager's Document.
+This ensures that if script
[webkit-changes] [240314] trunk
Title: [240314] trunk Revision 240314 Author nvasil...@apple.com Date 2019-01-22 17:46:01 -0800 (Tue, 22 Jan 2019) Log Message Web Inspector: Styles: refactor properties/allProperties/visibleProperties/allVisibleProperties https://bugs.webkit.org/show_bug.cgi?id=193615 Reviewed by Devin Rousso. Source/WebInspectorUI: Remove unused visibleProperties. Rename: - properties to enabledProperties; - allProperties to properties; - allVisibleProperties to visibleProperties. * UserInterface/Models/CSSProperty.js: (WI.CSSProperty.prototype._prependSemicolonIfNeeded): (WI.CSSProperty): * UserInterface/Models/CSSStyleDeclaration.js: (WI.CSSStyleDeclaration): (WI.CSSStyleDeclaration.prototype.get enabledProperties): (WI.CSSStyleDeclaration.prototype.get properties): (WI.CSSStyleDeclaration.prototype.propertyForName): (WI.CSSStyleDeclaration.prototype.newBlankProperty): (WI.CSSStyleDeclaration.prototype.shiftPropertiesAfter): (WI.CSSStyleDeclaration.prototype._rangeAfterPropertyAtIndex): * UserInterface/Models/DOMNodeStyles.js: (WI.DOMNodeStyles.prototype._parseStylePropertyPayload): (WI.DOMNodeStyles.prototype._markOverriddenProperties): (WI.DOMNodeStyles.prototype._associateRelatedProperties): (WI.DOMNodeStyles.prototype._isPropertyFoundInMatchingRules): (WI.DOMNodeStyles): * UserInterface/Views/BoxModelDetailsSectionRow.js: (WI.BoxModelDetailsSectionRow.prototype._updateMetrics): * UserInterface/Views/ComputedStyleDetailsPanel.js: (WI.ComputedStyleDetailsPanel.prototype._computePropertyTraces): * UserInterface/Views/ComputedStyleSection.js: (WI.ComputedStyleSection.prototype.get propertiesToRender): * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js: (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get propertiesToRender): * UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js: (WI.SpreadsheetRulesStyleDetailsPanel.prototype.layout): * UserInterface/Views/SpreadsheetStyleProperty.js: (WI.SpreadsheetStyleProperty.prototype.updateStatus): LayoutTests: Rename: - properties to enabledProperties; - allProperties to properties. * inspector/css/css-property-expected.txt: * inspector/css/css-property.html: * inspector/css/force-page-appearance.html: * inspector/css/matched-style-properties.html: * inspector/css/modify-css-property.html: * inspector/css/shadow-scoped-style.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/css/css-property-expected.txt trunk/LayoutTests/inspector/css/css-property.html trunk/LayoutTests/inspector/css/force-page-appearance.html trunk/LayoutTests/inspector/css/matched-style-properties.html trunk/LayoutTests/inspector/css/modify-css-property.html trunk/LayoutTests/inspector/css/shadow-scoped-style.html trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js Diff Modified: trunk/LayoutTests/ChangeLog (240313 => 240314) --- trunk/LayoutTests/ChangeLog 2019-01-23 01:13:44 UTC (rev 240313) +++ trunk/LayoutTests/ChangeLog 2019-01-23 01:46:01 UTC (rev 240314) @@ -1,3 +1,21 @@ +2019-01-22 Nikita Vasilyev + +Web Inspector: Styles: refactor properties/allProperties/visibleProperties/allVisibleProperties +https://bugs.webkit.org/show_bug.cgi?id=193615 + +Reviewed by Devin Rousso. + +Rename: +- properties to enabledProperties; +- allProperties to properties. + +* inspector/css/css-property-expected.txt: +* inspector/css/css-property.html: +* inspector/css/force-page-appearance.html: +* inspector/css/matched-style-properties.html: +* inspector/css/modify-css-property.html: +* inspector/css/shadow-scoped-style.html: + 2019-01-22 Sihui Liu Layout test storage/indexeddb/open-during-transaction-private.html is failing Modified: trunk/LayoutTests/inspector/css/css-property-expected.txt (240313 => 240314) --- trunk/LayoutTests/inspector/css/css-property-expected.txt 2019-01-23 01:13:44 UTC (rev 240313) +++ trunk/LayoutTests/inspector/css/css-property-expected.txt 2019-01-23 01:46:01 UTC (rev 240314) @@ -51,6 +51,6 @@ PASS: "background-repeat-y" has the _text (private) "". -- Running test case: CSSProperty.prototype.remove -PASS: The removed property should no longer be in allProperties array. +PASS: The removed property should no longer be in properties array. PASS: The second
[webkit-changes] [240313] trunk/Source/WebCore
Title: [240313] trunk/Source/WebCore
Revision 240313
Author hironori.fu...@sony.com
Date 2019-01-22 17:13:44 -0800 (Tue, 22 Jan 2019)
Log Message
[WinCairo][WebKitTestRunner] Null dereference of GraphicsContext::m_data in GraphicsContext::releaseWindowsContext
https://bugs.webkit.org/show_bug.cgi?id=193664
Reviewed by Brent Fulgham.
WinCairo WebKitTestRunner always crash on openning test cases of
HTMLMeterElement.
If GraphicsContext::getWindowsContext retruned null HDC,
LocalWindowsContext shouldn't release the null HDC.
Covered by existing tests.
* platform/graphics/win/LocalWindowsContext.h:
(WebCore::LocalWindowsContext::~LocalWindowsContext):
Release m_hdc only if it isn't null.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/LocalWindowsContext.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (240312 => 240313)
--- trunk/Source/WebCore/ChangeLog 2019-01-23 01:11:29 UTC (rev 240312)
+++ trunk/Source/WebCore/ChangeLog 2019-01-23 01:13:44 UTC (rev 240313)
@@ -1,3 +1,22 @@
+2019-01-22 Fujii Hironori
+
+[WinCairo][WebKitTestRunner] Null dereference of GraphicsContext::m_data in GraphicsContext::releaseWindowsContext
+https://bugs.webkit.org/show_bug.cgi?id=193664
+
+Reviewed by Brent Fulgham.
+
+WinCairo WebKitTestRunner always crash on openning test cases of
+HTMLMeterElement.
+
+If GraphicsContext::getWindowsContext retruned null HDC,
+LocalWindowsContext shouldn't release the null HDC.
+
+Covered by existing tests.
+
+* platform/graphics/win/LocalWindowsContext.h:
+(WebCore::LocalWindowsContext::~LocalWindowsContext):
+Release m_hdc only if it isn't null.
+
2019-01-22 Michael Catanzaro
Unreviewed, fix -Wsign-compare warning
Modified: trunk/Source/WebCore/platform/graphics/win/LocalWindowsContext.h (240312 => 240313)
--- trunk/Source/WebCore/platform/graphics/win/LocalWindowsContext.h 2019-01-23 01:11:29 UTC (rev 240312)
+++ trunk/Source/WebCore/platform/graphics/win/LocalWindowsContext.h 2019-01-23 01:13:44 UTC (rev 240313)
@@ -43,7 +43,8 @@
~LocalWindowsContext()
{
-m_graphicsContext.releaseWindowsContext(m_hdc, m_rect, m_supportAlphaBlend);
+if (m_hdc)
+m_graphicsContext.releaseWindowsContext(m_hdc, m_rect, m_supportAlphaBlend);
}
HDC hdc() const { return m_hdc; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240312] trunk/LayoutTests
Title: [240312] trunk/LayoutTests
Revision 240312
Author sihui_...@apple.com
Date 2019-01-22 17:11:29 -0800 (Tue, 22 Jan 2019)
Log Message
Layout test storage/indexeddb/open-during-transaction-private.html is failing
https://bugs.webkit.org/show_bug.cgi?id=193600
Reviewed by Brady Eidson.
Make sure the second request is finished before the third one so that test ends properly.
* storage/indexeddb/open-during-transaction-expected.txt:
* storage/indexeddb/open-during-transaction-private-expected.txt:
* storage/indexeddb/resources/open-during-transaction.js:
(tryOpens.openreq3.onsuccess):
(tryOpens.openreq2.onsuccess):
(tryOpens):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/open-during-transaction-expected.txt
trunk/LayoutTests/storage/indexeddb/open-during-transaction-private-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/open-during-transaction.js
Diff
Modified: trunk/LayoutTests/ChangeLog (240311 => 240312)
--- trunk/LayoutTests/ChangeLog 2019-01-23 00:43:18 UTC (rev 240311)
+++ trunk/LayoutTests/ChangeLog 2019-01-23 01:11:29 UTC (rev 240312)
@@ -1,3 +1,19 @@
+2019-01-22 Sihui Liu
+
+Layout test storage/indexeddb/open-during-transaction-private.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=193600
+
+Reviewed by Brady Eidson.
+
+Make sure the second request is finished before the third one so that test ends properly.
+
+* storage/indexeddb/open-during-transaction-expected.txt:
+* storage/indexeddb/open-during-transaction-private-expected.txt:
+* storage/indexeddb/resources/open-during-transaction.js:
+(tryOpens.openreq3.onsuccess):
+(tryOpens.openreq2.onsuccess):
+(tryOpens):
+
2019-01-22 Devin Rousso
Web Inspector: Audit: provide a way to get related Accessibility properties for a given node
Modified: trunk/LayoutTests/storage/indexeddb/open-during-transaction-expected.txt (240311 => 240312)
--- trunk/LayoutTests/storage/indexeddb/open-during-transaction-expected.txt 2019-01-23 00:43:18 UTC (rev 240311)
+++ trunk/LayoutTests/storage/indexeddb/open-during-transaction-expected.txt 2019-01-23 01:11:29 UTC (rev 240312)
@@ -17,14 +17,12 @@
trying to open the same database
openreq2 = indexedDB.open(dbname)
-
-trying to open a different database
-openreq3 = indexedDB.open(dbname + '2')
-
openreq2.onsuccess
PASS state is "starting"
state = 'open2complete'
+trying to open a different database
+openreq3 = indexedDB.open(dbname + '2')
openreq3.onsuccess
PASS state is "open2complete"
state = 'open3complete'
Modified: trunk/LayoutTests/storage/indexeddb/open-during-transaction-private-expected.txt (240311 => 240312)
--- trunk/LayoutTests/storage/indexeddb/open-during-transaction-private-expected.txt 2019-01-23 00:43:18 UTC (rev 240311)
+++ trunk/LayoutTests/storage/indexeddb/open-during-transaction-private-expected.txt 2019-01-23 01:11:29 UTC (rev 240312)
@@ -17,14 +17,12 @@
trying to open the same database
openreq2 = indexedDB.open(dbname)
-
-trying to open a different database
-openreq3 = indexedDB.open(dbname + '2')
-
openreq2.onsuccess
PASS state is "starting"
state = 'open2complete'
+trying to open a different database
+openreq3 = indexedDB.open(dbname + '2')
openreq3.onsuccess
PASS state is "open2complete"
state = 'open3complete'
Modified: trunk/LayoutTests/storage/indexeddb/resources/open-during-transaction.js (240311 => 240312)
--- trunk/LayoutTests/storage/indexeddb/resources/open-during-transaction.js 2019-01-23 00:43:18 UTC (rev 240311)
+++ trunk/LayoutTests/storage/indexeddb/resources/open-during-transaction.js 2019-01-23 01:11:29 UTC (rev 240312)
@@ -55,17 +55,15 @@
shouldBeEqualToString("state", "starting");
evalAndLog("state = 'open2complete'");
debug("");
-};
-debug("");
-debug("trying to open a different database");
-evalAndLog("openreq3 = indexedDB.open(dbname + '2')");
-openreq3._onerror_ = unexpectedErrorCallback;
-openreq3._onsuccess_ = function (e) {
-debug("openreq3.onsuccess");
-shouldBeEqualToString("state", "open2complete");
-evalAndLog("state = 'open3complete'");
-debug("");
+debug("trying to open a different database");
+evalAndLog("openreq3 = indexedDB.open(dbname + '2')");
+openreq3._onerror_ = unexpectedErrorCallback;
+openreq3._onsuccess_ = function (e) {
+debug("openreq3.onsuccess");
+shouldBeEqualToString("state", "open2complete");
+evalAndLog("state = 'open3complete'");
+debug("");
+};
};
-debug("");
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240311] trunk/Source/WebKit
Title: [240311] trunk/Source/WebKit
Revision 240311
Author achristen...@apple.com
Date 2019-01-22 16:43:18 -0800 (Tue, 22 Jan 2019)
Log Message
Fix an internal build failure after r240292
https://bugs.webkit.org/show_bug.cgi?id=193580
Rubber-stamped by Wenson Hsieh.
* SourcesCocoa.txt:
* UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKMenuTarget forwardContextMenuAction:]):
* WebKit.xcodeproj/project.pbxproj:
It was apparently unclear to the compiler sometimes which "state" selector to use, and this apparently mattered.
Tell the compiler to use the NSMenuItem selector, but at runtime it doesn't matter.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebKit/ChangeLog (240310 => 240311)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 00:37:30 UTC (rev 240310)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 00:43:18 UTC (rev 240311)
@@ -1,3 +1,17 @@
+2019-01-22 Alex Christensen
+
+Fix an internal build failure after r240292
+https://bugs.webkit.org/show_bug.cgi?id=193580
+
+Rubber-stamped by Wenson Hsieh.
+
+* SourcesCocoa.txt:
+* UIProcess/mac/WebContextMenuProxyMac.mm:
+(-[WKMenuTarget forwardContextMenuAction:]):
+* WebKit.xcodeproj/project.pbxproj:
+It was apparently unclear to the compiler sometimes which "state" selector to use, and this apparently mattered.
+Tell the compiler to use the NSMenuItem selector, but at runtime it doesn't matter.
+
2019-01-22 Michael Catanzaro
Unreviewed, fix -Wunused-but-set-variable warning
Modified: trunk/Source/WebKit/SourcesCocoa.txt (240310 => 240311)
--- trunk/Source/WebKit/SourcesCocoa.txt 2019-01-23 00:37:30 UTC (rev 240310)
+++ trunk/Source/WebKit/SourcesCocoa.txt 2019-01-23 00:43:18 UTC (rev 240311)
@@ -255,6 +255,7 @@
UIProcess/API/Cocoa/_WKWebsitePolicies.mm
UIProcess/API/Cocoa/APIAttachmentCocoa.mm
UIProcess/API/Cocoa/APIContentRuleListStoreCocoa.mm
+UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm
UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm
UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm
UIProcess/API/Cocoa/LegacyBundleForClass.mm
Modified: trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm (240310 => 240311)
--- trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm 2019-01-23 00:37:30 UTC (rev 240310)
+++ trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm 2019-01-23 00:43:18 UTC (rev 240311)
@@ -138,7 +138,8 @@
return;
}
-WebKit::WebContextMenuItemData item(WebCore::ActionType, static_cast([sender tag]), [sender title], [sender isEnabled], [sender state] == NSControlStateValueOn);
+ASSERT(!sender || [sender isKindOfClass:NSMenuItem.class]);
+WebKit::WebContextMenuItemData item(WebCore::ActionType, static_cast([sender tag]), [sender title], [sender isEnabled], [(NSMenuItem *)sender state] == NSControlStateValueOn);
if (representedObject) {
ASSERT([representedObject isKindOfClass:[WKUserDataWrapper class]]);
item.setUserData([static_cast(representedObject) userData]);
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (240310 => 240311)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2019-01-23 00:37:30 UTC (rev 240310)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2019-01-23 00:43:18 UTC (rev 240311)
@@ -1070,7 +1070,6 @@
5CD286551E7235B80094FDC8 /* WKContentRuleListInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CD2864C1E722F440094FDC8 /* WKContentRuleListInternal.h */; };
5CD286571E7235C90094FDC8 /* WKContentRuleListStoreInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CD2864F1E722F440094FDC8 /* WKContentRuleListStoreInternal.h */; };
5CD286581E7235D10094FDC8 /* WKContentRuleListStorePrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CD286501E722F440094FDC8 /* WKContentRuleListStorePrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 5CE43B7221F7CC020093BCC5 /* APIHTTPCookieStoreCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CA46E7A21F1A23900CE86B4 /* APIHTTPCookieStoreCocoa.mm */; };
5CE85B201C88E64B0070BFCE /* PingLoad.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CE85B1F1C88E6430070BFCE /* PingLoad.h */; };
617A52D81F43A9DA00DCDC0A /* ServiceWorkerClientFetchMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 617A52D71F43A9B600DCDC0A /* ServiceWorkerClientFetchMessageReceiver.cpp */; };
63108F961F96719C00A0DB84 /* _WKApplicationManifest.h in Headers */ = {isa = PBXBuildFile; fileRef = 63108F941F96719C00A0DB84 /* _WKApplicationManifest.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -10787,7 +10786,6 @@
2D92A787212B6AB100F493FD /* ShareableBitmap.cpp in Sources */,
2DE6943D18BD2A68005C15E5 /* SmartMagnificationControllerMessageReceiver.cpp in Sources */,
[webkit-changes] [240310] trunk/Source/WebCore
Title: [240310] trunk/Source/WebCore
Revision 240310
Author mcatanz...@igalia.com
Date 2019-01-22 16:37:30 -0800 (Tue, 22 Jan 2019)
Log Message
Unreviewed, fix -Wsign-compare warning
https://bugs.webkit.org/show_bug.cgi?id=188697
* css/StyleProperties.cpp:
(WebCore::StyleProperties::asText const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleProperties.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (240309 => 240310)
--- trunk/Source/WebCore/ChangeLog 2019-01-23 00:32:59 UTC (rev 240309)
+++ trunk/Source/WebCore/ChangeLog 2019-01-23 00:37:30 UTC (rev 240310)
@@ -1,3 +1,12 @@
+2019-01-22 Michael Catanzaro
+
+Unreviewed, fix -Wsign-compare warning
+https://bugs.webkit.org/show_bug.cgi?id=188697
+
+
+* css/StyleProperties.cpp:
+(WebCore::StyleProperties::asText const):
+
2019-01-22 Devin Rousso
Web Inspector: Audit: provide a way to get related Accessibility properties for a given node
Modified: trunk/Source/WebCore/css/StyleProperties.cpp (240309 => 240310)
--- trunk/Source/WebCore/css/StyleProperties.cpp 2019-01-23 00:32:59 UTC (rev 240309)
+++ trunk/Source/WebCore/css/StyleProperties.cpp 2019-01-23 00:37:30 UTC (rev 240310)
@@ -979,7 +979,7 @@
String value;
auto serializeBorderShorthand = [&] (const CSSPropertyID borderProperty, const CSSPropertyID fallbackProperty) {
// FIXME: Deal with cases where only some of border sides are specified.
-ASSERT(borderProperty - firstCSSProperty < shorthandPropertyAppeared.size());
+ASSERT(borderProperty - firstCSSProperty < static_cast(shorthandPropertyAppeared.size()));
if (!shorthandPropertyAppeared[borderProperty - firstCSSProperty] && isEnabledCSSProperty(borderProperty)) {
value = getPropertyValue(borderProperty);
if (value.isNull())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240309] trunk
Title: [240309] trunk
Revision 240309
Author drou...@apple.com
Date 2019-01-22 16:32:59 -0800 (Tue, 22 Jan 2019)
Log Message
Web Inspector: Audit: provide a way to get related Accessibility properties for a given node
https://bugs.webkit.org/show_bug.cgi?id=193227
Reviewed by Joseph Pecoraro.
Source/WebCore:
Test: inspector/audit/run-accessibility.html
* inspector/InspectorAuditAccessibilityObject.idl:
* inspector/InspectorAuditAccessibilityObject.h:
* inspector/InspectorAuditAccessibilityObject.cpp:
(WebCore::InspectorAuditAccessibilityObject::getComputedProperties): Added.
LayoutTests:
* inspector/audit/run-accessibility.html:
* inspector/audit/run-accessibility-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/audit/run-accessibility-expected.txt
trunk/LayoutTests/inspector/audit/run-accessibility.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp
trunk/Source/WebCore/inspector/InspectorAuditAccessibilityObject.h
trunk/Source/WebCore/inspector/InspectorAuditAccessibilityObject.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (240308 => 240309)
--- trunk/LayoutTests/ChangeLog 2019-01-23 00:32:24 UTC (rev 240308)
+++ trunk/LayoutTests/ChangeLog 2019-01-23 00:32:59 UTC (rev 240309)
@@ -1,3 +1,14 @@
+2019-01-22 Devin Rousso
+
+Web Inspector: Audit: provide a way to get related Accessibility properties for a given node
+https://bugs.webkit.org/show_bug.cgi?id=193227
+
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/audit/run-accessibility.html:
+* inspector/audit/run-accessibility-expected.txt:
+
2019-01-22 Simon Fraser
Remove an iOS quirk where iframe renderers are identified as "RenderPartObject" in layout test results
Modified: trunk/LayoutTests/inspector/audit/run-accessibility-expected.txt (240308 => 240309)
--- trunk/LayoutTests/inspector/audit/run-accessibility-expected.txt 2019-01-23 00:32:24 UTC (rev 240308)
+++ trunk/LayoutTests/inspector/audit/run-accessibility-expected.txt 2019-01-23 00:32:59 UTC (rev 240309)
@@ -63,6 +63,46 @@
Result: []
Audit teardown...
+-- Running test case: Audit.run.Accessibility.getComputedProperties.parent
+Audit setup...
+Audit run `WebInspectorAudit.Accessibility.getComputedProperties(document.querySelector("#parent"))`...
+Result: {
+"busy": false,
+"currentState": "false",
+"disabled": false,
+"headingLevel": 0,
+"hidden": false,
+"hierarchicalLevel": 0,
+"ignored": false,
+"ignoredByDefault": false,
+"invalidStatus": "false",
+"isPopUpButton": false,
+"pressed": false,
+"role": "tree",
+"selected": false
+}
+Audit teardown...
+
+-- Running test case: Audit.run.Accessibility.getComputedProperties.child
+Audit setup...
+Audit run `WebInspectorAudit.Accessibility.getComputedProperties(document.querySelector("#child"))`...
+Result: {
+"busy": false,
+"currentState": "false",
+"disabled": false,
+"headingLevel": 0,
+"hidden": false,
+"hierarchicalLevel": 1,
+"ignored": false,
+"ignoredByDefault": false,
+"invalidStatus": "false",
+"isPopUpButton": false,
+"pressed": false,
+"role": "treeitem",
+"selected": true
+}
+Audit teardown...
+
-- Running test case: Audit.run.Accessibility.getControlledNodes.parent
Audit setup...
Audit run `WebInspectorAudit.Accessibility.getControlledNodes(document.querySelector("#parent"))`...
@@ -114,7 +154,7 @@
-- Running test case: Audit.run.Accessibility.getParentNode.parent
Audit setup...
Audit run `WebInspectorAudit.Accessibility.getParentNode(document.querySelector("#parent"))`...
-Result: undefined
+Result:
Audit teardown...
-- Running test case: Audit.run.Accessibility.getParentNode.child
@@ -148,6 +188,9 @@
Testing copied getChildNodes...
PASS: Should produce an exception.
Error: NotAllowedError: Cannot be called outside of a Web Inspector Audit
+Testing copied getComputedProperties...
+PASS: Should produce an exception.
+Error: NotAllowedError: Cannot be called outside of a Web Inspector Audit
Testing copied getControlledNodes...
PASS: Should produce an exception.
Error: NotAllowedError: Cannot be called outside of a Web Inspector Audit
Modified: trunk/LayoutTests/inspector/audit/run-accessibility.html (240308 => 240309)
--- trunk/LayoutTests/inspector/audit/run-accessibility.html 2019-01-23 00:32:24 UTC (rev 240308)
+++ trunk/LayoutTests/inspector/audit/run-accessibility.html 2019-01-23 00:32:59 UTC (rev 240309)
@@ -6,12 +6,20 @@
[webkit-changes] [240308] trunk/Source/WebKit
Title: [240308] trunk/Source/WebKit
Revision 240308
Author mcatanz...@igalia.com
Date 2019-01-22 16:32:24 -0800 (Tue, 22 Jan 2019)
Log Message
Unreviewed, fix -Wunused-but-set-variable warning
https://bugs.webkit.org/show_bug.cgi?id=193660
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::removeData):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (240307 => 240308)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 00:24:04 UTC (rev 240307)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 00:32:24 UTC (rev 240308)
@@ -1,5 +1,14 @@
2019-01-22 Michael Catanzaro
+Unreviewed, fix -Wunused-but-set-variable warning
+https://bugs.webkit.org/show_bug.cgi?id=193660
+
+
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::removeData):
+
+2019-01-22 Michael Catanzaro
+
Unreviewed, further build fixes after r240292
https://bugs.webkit.org/show_bug.cgi?id=193580
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (240307 => 240308)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2019-01-23 00:24:04 UTC (rev 240307)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2019-01-23 00:32:24 UTC (rev 240308)
@@ -757,7 +757,9 @@
}
#endif
+#if ENABLE(RESOURCE_LOAD_STATISTICS)
bool didNotifyNetworkProcessToDeleteWebsiteData = false;
+#endif
auto networkProcessAccessType = computeNetworkProcessAccessTypeForDataRemoval(dataTypes, !isPersistent());
if (networkProcessAccessType != ProcessAccessType::None) {
for (auto& processPool : processPools()) {
@@ -779,7 +781,9 @@
processPool->networkProcess()->deleteWebsiteData(m_sessionID, dataTypes, modifiedSince, [callbackAggregator, processPool] {
callbackAggregator->removePendingCallback();
});
+#if ENABLE(RESOURCE_LOAD_STATISTICS)
didNotifyNetworkProcessToDeleteWebsiteData = true;
+#endif
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240306] trunk/Source/WebKit
Title: [240306] trunk/Source/WebKit Revision 240306 Author mcatanz...@igalia.com Date 2019-01-22 16:19:13 -0800 (Tue, 22 Jan 2019) Log Message Unreviewed, further build fixes after r240292 https://bugs.webkit.org/show_bug.cgi?id=193580 Oops. * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::defaultStorageSession const): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (240305 => 240306) --- trunk/Source/WebKit/ChangeLog 2019-01-23 00:13:41 UTC (rev 240305) +++ trunk/Source/WebKit/ChangeLog 2019-01-23 00:19:13 UTC (rev 240306) @@ -4,6 +4,17 @@ https://bugs.webkit.org/show_bug.cgi?id=193580 +Oops. + +* NetworkProcess/NetworkProcess.cpp: +(WebKit::NetworkProcess::defaultStorageSession const): + +2019-01-22 Michael Catanzaro + +Unreviewed, further build fixes after r240292 +https://bugs.webkit.org/show_bug.cgi?id=193580 + + This builds for libsoup. Doesn't work, but at least builds. Also, speculative fixes for curl. Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (240305 => 240306) --- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2019-01-23 00:13:41 UTC (rev 240305) +++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2019-01-23 00:19:13 UTC (rev 240306) @@ -538,9 +538,9 @@ #if PLATFORM(COCOA) m_defaultNetworkStorageSession = std::make_unique(PAL::SessionID::defaultSessionID()); -#elif PLATFORM(SOUP) +#elif USE(SOUP) m_defaultNetworkStorageSession = std::make_unique(PAL::SessionID::defaultSessionID(), std::make_unique(PAL::SessionID::defaultSessionID())); -#elif PLATFORM(CURL) +#elif USE(CURL) m_defaultNetworkStorageSession = std::make_unique(PAL::SessionID::defaultSessionID(), CurlContext::singleton()); #else #error Implement me ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240305] trunk
Title: [240305] trunk
Revision 240305
Author commit-qu...@webkit.org
Date 2019-01-22 16:13:41 -0800 (Tue, 22 Jan 2019)
Log Message
Dynamic changes in the style attributes of an SVGElement do no affect the instances
https://bugs.webkit.org/show_bug.cgi?id=193647
Patch by Said Abou-Hallawa on 2019-01-22
Reviewed by Simon Fraser.
Source/WebCore:
Changing a style attribute of an SVGELement needs to call invalidateInstances().
Tests: svg/custom/svg-use-style-dynamic-change-invalidate.svg
* svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged):
LayoutTests:
* svg/custom/svg-use-style-dynamic-change-invalidate-expected.svg: Added.
* svg/custom/svg-use-style-dynamic-change-invalidate.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGElement.cpp
Added Paths
trunk/LayoutTests/svg/custom/svg-use-style-dynamic-change-invalidate-expected.svg
trunk/LayoutTests/svg/custom/svg-use-style-dynamic-change-invalidate.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (240304 => 240305)
--- trunk/LayoutTests/ChangeLog 2019-01-23 00:10:19 UTC (rev 240304)
+++ trunk/LayoutTests/ChangeLog 2019-01-23 00:13:41 UTC (rev 240305)
@@ -1,3 +1,13 @@
+2019-01-22 Said Abou-Hallawa
+
+Dynamic changes in the style attributes of an SVGElement do no affect the instances
+https://bugs.webkit.org/show_bug.cgi?id=193647
+
+Reviewed by Simon Fraser.
+
+* svg/custom/svg-use-style-dynamic-change-invalidate-expected.svg: Added.
+* svg/custom/svg-use-style-dynamic-change-invalidate.svg: Added.
+
2019-01-22 Michael Catanzaro
Unreviewed, skip all resource load statistics tests on GTK
Added: trunk/LayoutTests/svg/custom/svg-use-style-dynamic-change-invalidate-expected.svg (0 => 240305)
--- trunk/LayoutTests/svg/custom/svg-use-style-dynamic-change-invalidate-expected.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/svg-use-style-dynamic-change-invalidate-expected.svg 2019-01-23 00:13:41 UTC (rev 240305)
@@ -0,0 +1,6 @@
+
+
+
+
+
+
Added: trunk/LayoutTests/svg/custom/svg-use-style-dynamic-change-invalidate.svg (0 => 240305)
--- trunk/LayoutTests/svg/custom/svg-use-style-dynamic-change-invalidate.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/svg-use-style-dynamic-change-invalidate.svg 2019-01-23 00:13:41 UTC (rev 240305)
@@ -0,0 +1,25 @@
+
+
+
+
+
+
+
+
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+setTimeout(function(){
+document.getElementById("symbol-rect").setAttribute("style", "fill: green");
+document.getElementById("defs-rect").setAttribute("style", "fill: green");
+document.getElementById("rect").setAttribute("style", "fill: green");
+
+if (window.testRunner)
+testRunner.notifyDone();
+ }, 0);
+
+
Modified: trunk/Source/WebCore/ChangeLog (240304 => 240305)
--- trunk/Source/WebCore/ChangeLog 2019-01-23 00:10:19 UTC (rev 240304)
+++ trunk/Source/WebCore/ChangeLog 2019-01-23 00:13:41 UTC (rev 240305)
@@ -1,3 +1,17 @@
+2019-01-22 Said Abou-Hallawa
+
+Dynamic changes in the style attributes of an SVGElement do no affect the instances
+https://bugs.webkit.org/show_bug.cgi?id=193647
+
+Reviewed by Simon Fraser.
+
+Changing a style attribute of an SVGELement needs to call invalidateInstances().
+
+Tests: svg/custom/svg-use-style-dynamic-change-invalidate.svg
+
+* svg/SVGElement.cpp:
+(WebCore::SVGElement::attributeChanged):
+
2019-01-22 Alex Christensen
Fix more builds.
Modified: trunk/Source/WebCore/svg/SVGElement.cpp (240304 => 240305)
--- trunk/Source/WebCore/svg/SVGElement.cpp 2019-01-23 00:10:19 UTC (rev 240304)
+++ trunk/Source/WebCore/svg/SVGElement.cpp 2019-01-23 00:13:41 UTC (rev 240305)
@@ -686,8 +686,10 @@
document().accessSVGExtensions().rebuildAllElementReferencesForTarget(*this);
// Changes to the style attribute are processed lazily (see Element::getAttribute() and related methods),
-// so we don't want changes to the style attribute to result in extra work here.
-if (name != HTMLNames::styleAttr)
+// so we don't want changes to the style attribute to result in extra work here except invalidateInstances().
+if (name == HTMLNames::styleAttr)
+invalidateInstances();
+else
svgAttributeChanged(name);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240304] trunk/Source/WebKit
Title: [240304] trunk/Source/WebKit
Revision 240304
Author mcatanz...@igalia.com
Date 2019-01-22 16:10:19 -0800 (Tue, 22 Jan 2019)
Log Message
Unreviewed, further build fixes after r240292
https://bugs.webkit.org/show_bug.cgi?id=193580
This builds for libsoup. Doesn't work, but at least builds.
Also, speculative fixes for curl.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::defaultStorageSession const):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (240303 => 240304)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 00:04:23 UTC (rev 240303)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 00:10:19 UTC (rev 240304)
@@ -4,6 +4,19 @@
https://bugs.webkit.org/show_bug.cgi?id=193580
+This builds for libsoup. Doesn't work, but at least builds.
+
+Also, speculative fixes for curl.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::defaultStorageSession const):
+
+2019-01-22 Michael Catanzaro
+
+Unreviewed, further build fixes after r240292
+https://bugs.webkit.org/show_bug.cgi?id=193580
+
+
Still not working yet.
* NetworkProcess/NetworkProcess.cpp:
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (240303 => 240304)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2019-01-23 00:04:23 UTC (rev 240303)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2019-01-23 00:10:19 UTC (rev 240304)
@@ -96,6 +96,10 @@
#include
#endif
+#if USE(CURL)
+#include
+#endif
+
#if ENABLE(SERVICE_WORKER)
#include "WebSWServerToContextConnectionMessages.h"
#endif
@@ -529,8 +533,19 @@
WebCore::NetworkStorageSession& NetworkProcess::defaultStorageSession() const
{
-if (!m_defaultNetworkStorageSession)
-m_defaultNetworkStorageSession = std::make_unique(PAL::SessionID::defaultSessionID());
+if (m_defaultNetworkStorageSession)
+ return *m_defaultNetworkStorageSession;
+
+#if PLATFORM(COCOA)
+m_defaultNetworkStorageSession = std::make_unique(PAL::SessionID::defaultSessionID());
+#elif PLATFORM(SOUP)
+m_defaultNetworkStorageSession = std::make_unique(PAL::SessionID::defaultSessionID(), std::make_unique(PAL::SessionID::defaultSessionID()));
+#elif PLATFORM(CURL)
+m_defaultNetworkStorageSession = std::make_unique(PAL::SessionID::defaultSessionID(), CurlContext::singleton());
+#else
+#error Implement me
+#endif
+
return *m_defaultNetworkStorageSession;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240303] trunk/Tools
Title: [240303] trunk/Tools
Revision 240303
Author aakash_j...@apple.com
Date 2019-01-22 16:04:23 -0800 (Tue, 22 Jan 2019)
Log Message
[ews-app] fetch loop should not stop on network issues
https://bugs.webkit.org/show_bug.cgi?id=193666
Reviewed by Lucas Forschler.
* BuildSlaveSupport/ews-app/ews/fetcher.py:
(FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py (240302 => 240303)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py 2019-01-22 23:50:39 UTC (rev 240302)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py 2019-01-23 00:04:23 UTC (rev 240303)
@@ -40,7 +40,10 @@
def run(self):
while True:
-BugzillaPatchFetcher().fetch()
+try:
+BugzillaPatchFetcher().fetch()
+except Exception as e:
+_log.error('Exception in BugzillaPatchFetcher: {}'.format(e))
time.sleep(self.interval)
Modified: trunk/Tools/ChangeLog (240302 => 240303)
--- trunk/Tools/ChangeLog 2019-01-22 23:50:39 UTC (rev 240302)
+++ trunk/Tools/ChangeLog 2019-01-23 00:04:23 UTC (rev 240303)
@@ -1,3 +1,13 @@
+2019-01-22 Aakash Jain
+
+[ews-app] fetch loop should not stop on network issues
+https://bugs.webkit.org/show_bug.cgi?id=193666
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/ews-app/ews/fetcher.py:
+(FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
+
2019-01-22 Wenson Hsieh
[iOS] Multiple WKWebViewAutofillTests are flaky failures
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240302] trunk/Source/WebKit
Title: [240302] trunk/Source/WebKit
Revision 240302
Author mcatanz...@igalia.com
Date 2019-01-22 15:50:39 -0800 (Tue, 22 Jan 2019)
Log Message
Unreviewed, further build fixes after r240292
https://bugs.webkit.org/show_bug.cgi?id=193580
Still not working yet.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
* UIProcess/API/APIHTTPCookieStore.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (240301 => 240302)
--- trunk/Source/WebKit/ChangeLog 2019-01-22 23:21:45 UTC (rev 240301)
+++ trunk/Source/WebKit/ChangeLog 2019-01-22 23:50:39 UTC (rev 240302)
@@ -1,3 +1,15 @@
+2019-01-22 Michael Catanzaro
+
+Unreviewed, further build fixes after r240292
+https://bugs.webkit.org/show_bug.cgi?id=193580
+
+
+Still not working yet.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::NetworkProcess):
+* UIProcess/API/APIHTTPCookieStore.h:
+
2019-01-22 Antti Koivisto
[iOS] Flash when swiping back to Google search result page
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (240301 => 240302)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2019-01-22 23:21:45 UTC (rev 240301)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2019-01-22 23:50:39 UTC (rev 240302)
@@ -93,6 +93,7 @@
#if USE(SOUP)
#include
+#include
#endif
#if ENABLE(SERVICE_WORKER)
@@ -155,7 +156,7 @@
#endif
#if USE(SOUP)
-DNSResolveQueueSoup::setGlobalDefaultNetworkStorageSessionAccessor([this] {
+DNSResolveQueueSoup::setGlobalDefaultNetworkStorageSessionAccessor([this]() -> NetworkStorageSession& {
return defaultStorageSession();
});
defaultStorageSession().clearSoupNetworkSessionAndCookieStorage();
Modified: trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h (240301 => 240302)
--- trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h 2019-01-22 23:21:45 UTC (rev 240301)
+++ trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h 2019-01-22 23:50:39 UTC (rev 240302)
@@ -32,12 +32,12 @@
#include
#include
-#if PLATFORM(COCOA)
namespace WebCore {
struct Cookie;
+#if PLATFORM(COCOA)
class CookieStorageObserver;
+#endif
}
-#endif
namespace WebKit {
class WebCookieManagerProxy;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240301] trunk/Tools
Title: [240301] trunk/Tools Revision 240301 Author wenson_hs...@apple.com Date 2019-01-22 15:21:45 -0800 (Tue, 22 Jan 2019) Log Message [iOS] Multiple WKWebViewAutofillTests are flaky failures https://bugs.webkit.org/show_bug.cgi?id=189165 Reviewed by Tim Horton. These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular, the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI process in sufficient to ensure that any previous action that blurred the focused element in the web process would make its way to the UI process by the time the layer tree commit is finished. However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread. This means that if a layer tree flush was already scheduled in the web process before the element was blurred, the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test will fail because it asks for -_autofillContext too early. To fix this, we tweak these tests to actually wait until the intended input session change triggered by script is handled in the UI process. * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm: Tweak some of these tests to wait for input session changes before checking for the presence of an autofill context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new input session. (-[AutofillTestView textInputHasAutofillContext]): Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date. * TestWebKitAPI/cocoa/TestWKWebView.h: * TestWebKitAPI/cocoa/TestWKWebView.mm: (nextInputSessionChangeCount): Monotonically increasing identifier that's incremented whenever an input session is started in the UI process. This includes changing the focused element from one to another. (-[TestWKWebView initWithFrame:configuration:addToWindow:]): (-[TestWKWebView didStartFormControlInteraction]): (-[TestWKWebView didEndFormControlInteraction]): (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]): Add a helper to evaluate _javascript_ and wait for this script to cause some change in the input session. This handles three cases: (1) changing focus from an element that doesn't require an input session to one that does, (2) changing focus between elements that require input sessions, and (3) changing focus from an input session that doesn't require an input session to one that doesn't. Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm Diff Modified: trunk/Tools/ChangeLog (240300 => 240301) --- trunk/Tools/ChangeLog 2019-01-22 23:08:36 UTC (rev 240300) +++ trunk/Tools/ChangeLog 2019-01-22 23:21:45 UTC (rev 240301) @@ -1,3 +1,53 @@ +2019-01-22 Wenson Hsieh + +[iOS] Multiple WKWebViewAutofillTests are flaky failures +https://bugs.webkit.org/show_bug.cgi?id=189165 + + +Reviewed by Tim Horton. + +These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to +immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular, +the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI +process in sufficient to ensure that any previous action that blurred the focused element in the web process +would make its way to the UI process by the time the layer tree commit is finished. + +However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread. +This means that if a layer tree flush was already scheduled in the web process before the element was blurred, +the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test +will fail because it asks for -_autofillContext too early. + +To fix this, we tweak these tests to actually wait until the intended input session change triggered by script +is handled in the UI process. + +* TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm: + +Tweak some of these tests to wait for input session changes before checking for the presence of an autofill +context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions +by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new +input
[webkit-changes] [240300] branches/safari-607-branch/Source/WebKit/UIProcess
Title: [240300] branches/safari-607-branch/Source/WebKit/UIProcess
Revision 240300
Author alanc...@apple.com
Date 2019-01-22 15:08:36 -0800 (Tue, 22 Jan 2019)
Log Message
Apply patch. rdar://problem/47458213
Unreviewed, fix build after r240046.
Modified Paths
branches/safari-607-branch/Source/WebKit/UIProcess/API/C/WKAuthenticationDecisionListener.cpp
branches/safari-607-branch/Source/WebKit/UIProcess/API/C/WKPage.cpp
branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h
branches/safari-607-branch/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
Diff
Modified: branches/safari-607-branch/Source/WebKit/UIProcess/API/C/WKAuthenticationDecisionListener.cpp (240299 => 240300)
--- branches/safari-607-branch/Source/WebKit/UIProcess/API/C/WKAuthenticationDecisionListener.cpp 2019-01-22 22:51:19 UTC (rev 240299)
+++ branches/safari-607-branch/Source/WebKit/UIProcess/API/C/WKAuthenticationDecisionListener.cpp 2019-01-22 23:08:36 UTC (rev 240300)
@@ -33,20 +33,20 @@
WKTypeID WKAuthenticationDecisionListenerGetTypeID()
{
-return WebKit::toAPI(AuthenticationDecisionListener::APIType);
+return WebKit::toAPI(WebKit::AuthenticationDecisionListener::APIType);
}
void WKAuthenticationDecisionListenerUseCredential(WKAuthenticationDecisionListenerRef authenticationListener, WKCredentialRef credential)
{
-WebKit::toImpl(authenticationListener)->completeChallenge(AuthenticationChallengeDisposition::UseCredential, credential ? WebKit::toImpl(credential)->credential() : WebCore::Credential());
+WebKit::toImpl(authenticationListener)->completeChallenge(WebKit::AuthenticationChallengeDisposition::UseCredential, credential ? WebKit::toImpl(credential)->credential() : WebCore::Credential());
}
void WKAuthenticationDecisionListenerCancel(WKAuthenticationDecisionListenerRef authenticationListener)
{
-WebKit::toImpl(authenticationListener)->completeChallenge(AuthenticationChallengeDisposition::Cancel);
+WebKit::toImpl(authenticationListener)->completeChallenge(WebKit::AuthenticationChallengeDisposition::Cancel);
}
void WKAuthenticationDecisionListenerRejectProtectionSpaceAndContinue(WKAuthenticationDecisionListenerRef authenticationListener)
{
-WebKit::toImpl(authenticationListener)->completeChallenge(AuthenticationChallengeDisposition::RejectProtectionSpaceAndContinue);
+WebKit::toImpl(authenticationListener)->completeChallenge(WebKit::AuthenticationChallengeDisposition::RejectProtectionSpaceAndContinue);
}
Modified: branches/safari-607-branch/Source/WebKit/UIProcess/API/C/WKPage.cpp (240299 => 240300)
--- branches/safari-607-branch/Source/WebKit/UIProcess/API/C/WKPage.cpp 2019-01-22 22:51:19 UTC (rev 240299)
+++ branches/safari-607-branch/Source/WebKit/UIProcess/API/C/WKPage.cpp 2019-01-22 23:08:36 UTC (rev 240300)
@@ -97,9 +97,10 @@
#include "VersionChecks.h"
#endif
-namespace API {
using namespace WebCore;
using namespace WebKit;
+
+namespace API {
template<> struct ClientTraits {
typedef std::tuple Versions;
Modified: branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h (240299 => 240300)
--- branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h 2019-01-22 22:51:19 UTC (rev 240299)
+++ branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h 2019-01-22 23:08:36 UTC (rev 240300)
@@ -32,10 +32,16 @@
class ResourceRequest;
}
+namespace IPC {
+class FormDataReference;
+}
+
namespace WebKit {
class DrawingAreaProxy;
class SuspendedPageProxy;
+struct URLSchemeTaskParameters;
+class UserData;
class WebFrameProxy;
struct WebNavigationDataStore;
class WebPageProxy;
Modified: branches/safari-607-branch/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp (240299 => 240300)
--- branches/safari-607-branch/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2019-01-22 22:51:19 UTC (rev 240299)
+++ branches/safari-607-branch/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2019-01-22 23:08:36 UTC (rev 240300)
@@ -29,7 +29,9 @@
#include "WebPageMessages.h"
#include "WebPageProxy.h"
#include "WebProcess.h"
+#include "WebProcessPool.h"
#include "WebProcessProxy.h"
+#include "WebsiteDataStore.h"
#include
#include
#include
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240299] trunk/Tools
Title: [240299] trunk/Tools
Revision 240299
Author ddkil...@apple.com
Date 2019-01-22 14:51:19 -0800 (Tue, 22 Jan 2019)
Log Message
check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_member_initialization_list):
- Don't report missing whitespace around colon if the colon at
the start of the line is formatted correctly.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_member_initialization_list):
- Add a test for a missing permutation of existing tests.
- Add a test this false-positive.
- Add blank lines between subtests to make them easier to read.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (240298 => 240299)
--- trunk/Tools/ChangeLog 2019-01-22 22:31:36 UTC (rev 240298)
+++ trunk/Tools/ChangeLog 2019-01-22 22:51:19 UTC (rev 240299)
@@ -1,3 +1,20 @@
+2019-01-22 David Kilzer
+
+check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
+
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(check_member_initialization_list):
+- Don't report missing whitespace around colon if the colon at
+ the start of the line is formatted correctly.
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+(WebKitStyleTest.test_member_initialization_list):
+- Add a test for a missing permutation of existing tests.
+- Add a test this false-positive.
+- Add blank lines between subtests to make them easier to read.
+
2019-01-22 Aakash Jain
[build.webkit.org] Unit-test failure after r237113
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (240298 => 240299)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2019-01-22 22:31:36 UTC (rev 240298)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2019-01-22 22:51:19 UTC (rev 240299)
@@ -2104,7 +2104,7 @@
begin_line = line
# match the start of initialization list
if search(r'^(?P\s*)((explicit\s+)?[^(\s|\?)]+\([^\?]*\)\s?\:|^(\s|\?)*\:)([^\:]|\Z)[^;]*$', line):
-if search(r'[^:]\:[^\:\s]+', line):
+if search(r'[^:]\:[^\:\s]+', line) and not search(r'^\s*:\s\S+', line):
error(line_number, 'whitespace/init', 4,
'Missing spaces around :')
if (not line.lstrip().startswith(':')) and search(r'[^\s]\(.*\)\s?\:.*[^;]*$', line):
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (240298 => 240299)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2019-01-22 22:31:36 UTC (rev 240298)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2019-01-22 22:51:19 UTC (rev 240299)
@@ -5503,9 +5503,11 @@
self.assert_lint('explicit MyClass(Document* doc) : MySuperClass() { }',
'Should be indented on a separate line, with the colon or comma first on that line.'
' [whitespace/indent] [4]')
+
self.assert_lint('MyClass::MyClass(Document* doc) : MySuperClass() { }',
'Should be indented on a separate line, with the colon or comma first on that line.'
' [whitespace/indent] [4]')
+
self.assert_multi_line_lint((
'MyClass::MyClass(Document* doc)\n'
': m_myMember(b ? bar() : baz())\n'
@@ -5512,11 +5514,13 @@
', MySuperClass()\n'
', m_doc(0)\n'
'{ }'), '')
+
self.assert_multi_line_lint('''\
MyClass::MyClass(Document* doc) : MySuperClass()
{ }''',
'Should be indented on a separate line, with the colon or comma first on that line.'
' [whitespace/indent] [4]')
+
self.assert_multi_line_lint('''\
MyClass::MyClass(Document* doc)
: MySuperClass()
@@ -5523,6 +5527,7 @@
{ }''',
'Wrong number of spaces before statement. (expected: 12)'
' [whitespace/indent] [4]')
+
self.assert_multi_line_lint('''\
MyClass::MyClass(Document* doc) :
MySuperClass(),
@@ -5532,12 +5537,20 @@
' [whitespace/indent] [4]',
'Comma should be at the beginning of the line in a member initialization list.'
' [whitespace/init] [4]'])
+
self.assert_multi_line_lint('''\
+MyClass::MyClass(Document* doc): MySuperClass()
+{ }''',
+'Should be indented on a separate line, with the colon or comma first on that line.'
+' [whitespace/indent] [4]')
+
+self.assert_multi_line_lint('''\
MyClass::MyClass(Document* doc) :MySuperClass()
{ }''',
['Missing spaces around : [whitespace/init] [4]',
'Should be indented on a separate line, with the
[webkit-changes] [240298] trunk/Source/WebKit
Title: [240298] trunk/Source/WebKit
Revision 240298
Author an...@apple.com
Date 2019-01-22 14:31:36 -0800 (Tue, 22 Jan 2019)
Log Message
[iOS] Flash when swiping back to Google search result page
https://bugs.webkit.org/show_bug.cgi?id=193668
Reviewed by Simon Fraser.
If the google page is scrolled, there is sometimes a short flash.
When restoring the page state we also restore exposedContentRect which is used to determine
which part of the page to create layers for. Scroll position is restored by the UI process
later so we rely on this to get the right layers for the initial view update.
A viewport configuration update may sometimes trample over the restored exposedContentRect,
moving it to top left. In this case the initial layer tree unfreeze commit may not have
layers to cover the actual visible view position.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::restorePageState):
Set a bit to indicate we have already restored the exposedContentRect.
(WebKit::WebPage::viewportConfigurationChanged):
Only reset exposedContentRect if wasn't already set by restorePageState.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (240297 => 240298)
--- trunk/Source/WebKit/ChangeLog 2019-01-22 22:10:51 UTC (rev 240297)
+++ trunk/Source/WebKit/ChangeLog 2019-01-22 22:31:36 UTC (rev 240298)
@@ -1,3 +1,33 @@
+2019-01-22 Antti Koivisto
+
+[iOS] Flash when swiping back to Google search result page
+https://bugs.webkit.org/show_bug.cgi?id=193668
+
+
+Reviewed by Simon Fraser.
+
+If the google page is scrolled, there is sometimes a short flash.
+
+When restoring the page state we also restore exposedContentRect which is used to determine
+which part of the page to create layers for. Scroll position is restored by the UI process
+later so we rely on this to get the right layers for the initial view update.
+
+A viewport configuration update may sometimes trample over the restored exposedContentRect,
+moving it to top left. In this case the initial layer tree unfreeze commit may not have
+layers to cover the actual visible view position.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::didCommitLoad):
+* WebProcess/WebPage/WebPage.h:
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::restorePageState):
+
+Set a bit to indicate we have already restored the exposedContentRect.
+
+(WebKit::WebPage::viewportConfigurationChanged):
+
+Only reset exposedContentRect if wasn't already set by restorePageState.
+
2019-01-22 Alex Christensen
Fix more builds.
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (240297 => 240298)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-01-22 22:10:51 UTC (rev 240297)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-01-22 22:31:36 UTC (rev 240298)
@@ -5604,6 +5604,7 @@
}
#if PLATFORM(IOS_FAMILY)
m_hasReceivedVisibleContentRectsAfterDidCommitLoad = false;
+m_hasRestoredExposedContentRectAfterDidCommitLoad = false;
m_scaleWasSetByUIProcess = false;
m_userHasChangedPageScaleFactor = false;
m_estimatedLatency = Seconds(1.0 / 60);
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.h (240297 => 240298)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2019-01-22 22:10:51 UTC (rev 240297)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2019-01-22 22:31:36 UTC (rev 240298)
@@ -1710,7 +1710,9 @@
RefPtr m_potentialTapSecurityOrigin;
WebCore::ViewportConfiguration m_viewportConfiguration;
+
bool m_hasReceivedVisibleContentRectsAfterDidCommitLoad { false };
+bool m_hasRestoredExposedContentRectAfterDidCommitLoad { false };
bool m_scaleWasSetByUIProcess { false };
bool m_userHasChangedPageScaleFactor { false };
bool m_hasStablePageScaleFactor { true };
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (240297 => 240298)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-01-22 22:10:51 UTC (rev 240297)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-01-22 22:31:36 UTC (rev 240298)
@@ -346,6 +346,7 @@
Optional scrollPosition;
if (historyItem.shouldRestoreScrollPosition()) {
m_drawingArea->setExposedContentRect(historyItem.exposedContentRect());
+m_hasRestoredExposedContentRectAfterDidCommitLoad = true;
scrollPosition = FloatPoint(historyItem.scrollPosition());
}
send(Messages::WebPageProxy::RestorePageState(scrollPosition, frameView.scrollOrigin(),
[webkit-changes] [240297] trunk/Source
Title: [240297] trunk/Source
Revision 240297
Author achristen...@apple.com
Date 2019-01-22 14:10:51 -0800 (Tue, 22 Jan 2019)
Log Message
Fix more builds.
Source/WebCore:
* platform/network/curl/CurlResourceHandleDelegate.cpp:
(WebCore::handleCookieHeaders):
(WebCore::CurlResourceHandleDelegate::curlDidReceiveResponse):
Source/WebKit:
* SourcesCocoa.txt:
* WebKit.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (240296 => 240297)
--- trunk/Source/WebCore/ChangeLog 2019-01-22 22:04:56 UTC (rev 240296)
+++ trunk/Source/WebCore/ChangeLog 2019-01-22 22:10:51 UTC (rev 240297)
@@ -1,5 +1,13 @@
2019-01-22 Alex Christensen
+Fix more builds.
+
+* platform/network/curl/CurlResourceHandleDelegate.cpp:
+(WebCore::handleCookieHeaders):
+(WebCore::CurlResourceHandleDelegate::curlDidReceiveResponse):
+
+2019-01-22 Alex Christensen
+
Fix some builds after r240292
https://bugs.webkit.org/show_bug.cgi?id=193580
Modified: trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.cpp (240296 => 240297)
--- trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.cpp 2019-01-22 22:04:56 UTC (rev 240296)
+++ trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.cpp 2019-01-22 22:10:51 UTC (rev 240297)
@@ -85,11 +85,11 @@
client()->didSendData(_handle, bytesSent, totalBytesToBeSent);
}
-static void handleCookieHeaders(const CurlResponse& response)
+static void handleCookieHeaders(ResourceHandleInternal* d, const CurlResponse& response)
{
static const auto setCookieHeader = "set-cookie: ";
-const auto& storageSession = *d()->m_context->storageSession(PAL::SessionID::defaultSessionID());
+const auto& storageSession = *d->m_context->storageSession(PAL::SessionID::defaultSessionID());
const auto& cookieJar = storageSession.cookieStorage();
for (const auto& header : response.headers) {
if (header.startsWithIgnoringASCIICase(setCookieHeader)) {
@@ -112,7 +112,7 @@
m_response.setCertificateInfo(request.certificateInfo().isolatedCopy());
m_response.setDeprecatedNetworkLoadMetrics(request.networkLoadMetrics().isolatedCopy());
-handleCookieHeaders(receivedResponse);
+handleCookieHeaders(d(), receivedResponse);
if (m_response.shouldRedirect()) {
m_handle.willSendRequest();
Modified: trunk/Source/WebKit/ChangeLog (240296 => 240297)
--- trunk/Source/WebKit/ChangeLog 2019-01-22 22:04:56 UTC (rev 240296)
+++ trunk/Source/WebKit/ChangeLog 2019-01-22 22:10:51 UTC (rev 240297)
@@ -1,3 +1,10 @@
+2019-01-22 Alex Christensen
+
+Fix more builds.
+
+* SourcesCocoa.txt:
+* WebKit.xcodeproj/project.pbxproj:
+
2019-01-22 Michael Catanzaro
Another build fix after r240292
Modified: trunk/Source/WebKit/SourcesCocoa.txt (240296 => 240297)
--- trunk/Source/WebKit/SourcesCocoa.txt 2019-01-22 22:04:56 UTC (rev 240296)
+++ trunk/Source/WebKit/SourcesCocoa.txt 2019-01-22 22:10:51 UTC (rev 240297)
@@ -255,7 +255,6 @@
UIProcess/API/Cocoa/_WKWebsitePolicies.mm
UIProcess/API/Cocoa/APIAttachmentCocoa.mm
UIProcess/API/Cocoa/APIContentRuleListStoreCocoa.mm
-UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm
UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm
UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm
UIProcess/API/Cocoa/LegacyBundleForClass.mm
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (240296 => 240297)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2019-01-22 22:04:56 UTC (rev 240296)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2019-01-22 22:10:51 UTC (rev 240297)
@@ -1070,6 +1070,7 @@
5CD286551E7235B80094FDC8 /* WKContentRuleListInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CD2864C1E722F440094FDC8 /* WKContentRuleListInternal.h */; };
5CD286571E7235C90094FDC8 /* WKContentRuleListStoreInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CD2864F1E722F440094FDC8 /* WKContentRuleListStoreInternal.h */; };
5CD286581E7235D10094FDC8 /* WKContentRuleListStorePrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CD286501E722F440094FDC8 /* WKContentRuleListStorePrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 5CE43B7221F7CC020093BCC5 /* APIHTTPCookieStoreCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CA46E7A21F1A23900CE86B4 /* APIHTTPCookieStoreCocoa.mm */; };
5CE85B201C88E64B0070BFCE /* PingLoad.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CE85B1F1C88E6430070BFCE /* PingLoad.h */; };
617A52D81F43A9DA00DCDC0A /* ServiceWorkerClientFetchMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 617A52D71F43A9B600DCDC0A /*
[webkit-changes] [240296] trunk/Source/WebKit
Title: [240296] trunk/Source/WebKit
Revision 240296
Author mcatanz...@igalia.com
Date 2019-01-22 14:04:56 -0800 (Tue, 22 Jan 2019)
Log Message
Another build fix after r240292
https://bugs.webkit.org/show_bug.cgi?id=193580
Unreviewed, still not enough to fix soup builds, but closer.
* UIProcess/API/APIHTTPCookieStore.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (240295 => 240296)
--- trunk/Source/WebKit/ChangeLog 2019-01-22 21:52:10 UTC (rev 240295)
+++ trunk/Source/WebKit/ChangeLog 2019-01-22 22:04:56 UTC (rev 240296)
@@ -1,3 +1,13 @@
+2019-01-22 Michael Catanzaro
+
+Another build fix after r240292
+https://bugs.webkit.org/show_bug.cgi?id=193580
+
+
+Unreviewed, still not enough to fix soup builds, but closer.
+
+* UIProcess/API/APIHTTPCookieStore.h:
+
2019-01-22 Alex Christensen
Fix some builds after r240292
Modified: trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h (240295 => 240296)
--- trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h 2019-01-22 21:52:10 UTC (rev 240295)
+++ trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h 2019-01-22 22:04:56 UTC (rev 240296)
@@ -32,10 +32,12 @@
#include
#include
+#if PLATFORM(COCOA)
namespace WebCore {
struct Cookie;
class CookieStorageObserver;
}
+#endif
namespace WebKit {
class WebCookieManagerProxy;
@@ -93,7 +95,10 @@
bool m_observingUIProcessCookies { false };
uint64_t m_processPoolCreationListenerIdentifier { 0 };
+
+#if PLATFORM(COCOA)
RefPtr m_defaultUIProcessObserver;
+#endif
};
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240295] trunk/Source
Title: [240295] trunk/Source
Revision 240295
Author achristen...@apple.com
Date 2019-01-22 13:52:10 -0800 (Tue, 22 Jan 2019)
Log Message
Fix some builds after r240292
https://bugs.webkit.org/show_bug.cgi?id=193580
Source/WebCore:
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::createCurlRequest):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::getCredential):
Source/WebKit:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::switchToNewTestingSession):
* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
Source/WebKitLegacy:
* WebCoreSupport/NetworkStorageSessionMap.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
trunk/Source/WebKitLegacy/ChangeLog
trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (240294 => 240295)
--- trunk/Source/WebCore/ChangeLog 2019-01-22 21:45:07 UTC (rev 240294)
+++ trunk/Source/WebCore/ChangeLog 2019-01-22 21:52:10 UTC (rev 240295)
@@ -1,5 +1,16 @@
2019-01-22 Alex Christensen
+Fix some builds after r240292
+https://bugs.webkit.org/show_bug.cgi?id=193580
+
+* platform/network/curl/ResourceHandleCurl.cpp:
+(WebCore::ResourceHandle::createCurlRequest):
+(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
+(WebCore::ResourceHandle::receivedCredential):
+(WebCore::ResourceHandle::getCredential):
+
+2019-01-22 Alex Christensen
+
Move NetworkStorageSession ownership to NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=193580
Modified: trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp (240294 => 240295)
--- trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp 2019-01-22 21:45:07 UTC (rev 240294)
+++ trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp 2019-01-22 21:52:10 UTC (rev 240295)
@@ -145,7 +145,7 @@
if (status == RequestStatus::NewRequest) {
addCacheValidationHeaders(request);
-auto& storageSession = *d->m_context->storageSession(PAL::SessionID::defaultSessionID());
+auto& storageSession = *d->m_context->storageSession();
auto& cookieJar = storageSession.cookieStorage();
auto includeSecureCookies = request.url().protocolIs("https") ? IncludeSecureCookies::Yes : IncludeSecureCookies::No;
String cookieHeaderField = cookieJar.cookieRequestHeaderFieldValue(storageSession, request.firstPartyForCookies(), SameSiteInfo::create(request), request.url(), WTF::nullopt, WTF::nullopt, includeSecureCookies).first;
@@ -231,7 +231,7 @@
URL urlToStore;
if (challenge.failureResponse().httpStatusCode() == 401)
urlToStore = challenge.failureResponse().url();
-d->m_context->storageSession(PAL::SessionID::defaultSessionID())->credentialStorage().set(partition, credential, challenge.protectionSpace(), urlToStore);
+d->m_context->storageSession()->credentialStorage().set(partition, credential, challenge.protectionSpace(), urlToStore);
restartRequestWithCredential(challenge.protectionSpace(), credential);
@@ -246,16 +246,16 @@
// The stored credential wasn't accepted, stop using it.
// There is a race condition here, since a different credential might have already been stored by another ResourceHandle,
// but the observable effect should be very minor, if any.
-d->m_context->storageSession(PAL::SessionID::defaultSessionID())->credentialStorage().remove(partition, challenge.protectionSpace());
+d->m_context->storageSession()->credentialStorage().remove(partition, challenge.protectionSpace());
}
if (!challenge.previousFailureCount()) {
-Credential credential = d->m_context->storageSession(PAL::SessionID::defaultSessionID())->credentialStorage().get(partition, challenge.protectionSpace());
+Credential credential = d->m_context->storageSession()->credentialStorage().get(partition, challenge.protectionSpace());
if (!credential.isEmpty() && credential != d->m_initialCredential) {
ASSERT(credential.persistence() == CredentialPersistenceNone);
if (challenge.failureResponse().httpStatusCode() == 401) {
// Store the credential back, possibly adding it as a default for this directory.
-d->m_context->storageSession(PAL::SessionID::defaultSessionID())->credentialStorage().set(partition, credential, challenge.protectionSpace(), challenge.failureResponse().url());
+
[webkit-changes] [240294] trunk/Source/WebKit
Title: [240294] trunk/Source/WebKit
Revision 240294
Author bb...@apple.com
Date 2019-01-22 13:45:07 -0800 (Tue, 22 Jan 2019)
Log Message
Automation.computeElementLayout should return visual viewport-aware coordinates
https://bugs.webkit.org/show_bug.cgi?id=193598
Unreviewed, restore a mistakenly-deleted line whose absence causes hangs.
* Shared/CoordinateSystem.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/CoordinateSystem.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (240293 => 240294)
--- trunk/Source/WebKit/ChangeLog 2019-01-22 21:34:34 UTC (rev 240293)
+++ trunk/Source/WebKit/ChangeLog 2019-01-22 21:45:07 UTC (rev 240294)
@@ -1,3 +1,13 @@
+2019-01-22 Brian Burg
+
+Automation.computeElementLayout should return visual viewport-aware coordinates
+https://bugs.webkit.org/show_bug.cgi?id=193598
+
+
+Unreviewed, restore a mistakenly-deleted line whose absence causes hangs.
+
+* Shared/CoordinateSystem.h:
+
2019-01-22 Alex Christensen
Move NetworkStorageSession ownership to NetworkProcess
Modified: trunk/Source/WebKit/Shared/CoordinateSystem.h (240293 => 240294)
--- trunk/Source/WebKit/Shared/CoordinateSystem.h 2019-01-22 21:34:34 UTC (rev 240293)
+++ trunk/Source/WebKit/Shared/CoordinateSystem.h 2019-01-22 21:45:07 UTC (rev 240294)
@@ -41,7 +41,8 @@
template<> struct EnumTraits {
using values = EnumValues<
WebKit::CoordinateSystem,
-WebKit::CoordinateSystem::Page
+WebKit::CoordinateSystem::Page,
+WebKit::CoordinateSystem::LayoutViewport
>;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240293] trunk/LayoutTests
Title: [240293] trunk/LayoutTests Revision 240293 Author mcatanz...@igalia.com Date 2019-01-22 13:34:34 -0800 (Tue, 22 Jan 2019) Log Message Unreviewed, skip all resource load statistics tests on GTK We don't have this feature enabled yet, so shouldn't be running the tests. Yet. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (240292 => 240293) --- trunk/LayoutTests/ChangeLog 2019-01-22 21:28:28 UTC (rev 240292) +++ trunk/LayoutTests/ChangeLog 2019-01-22 21:34:34 UTC (rev 240293) @@ -1,3 +1,11 @@ +2019-01-22 Michael Catanzaro + +Unreviewed, skip all resource load statistics tests on GTK + +We don't have this feature enabled yet, so shouldn't be running the tests. Yet. + +* platform/gtk/TestExpectations: + 2019-01-22 Devin Rousso Web Inspector: Audit: provide a way to get related Accessibility nodes for a given node Modified: trunk/LayoutTests/platform/gtk/TestExpectations (240292 => 240293) --- trunk/LayoutTests/platform/gtk/TestExpectations 2019-01-22 21:28:28 UTC (rev 240292) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2019-01-22 21:34:34 UTC (rev 240293) @@ -1243,6 +1243,9 @@ # No support for WebGPU yet webkit.org/b/191005 webgpu/ [ Skip ] +# No support for resource load statistics yet +http/tests/resourceLoadStatistics/ [ Skip ] + # # End of Expected failures. # @@ -1928,8 +1931,6 @@ webkit.org/b/183036 fast/events/message-port.html [ Timeout Pass ] -webkit.org/b/183037 http/tests/resourceLoadStatistics/prevalent-resource-handled-keydown.html [ Timeout Pass ] - webkit.org/b/183188 imported/blink/svg/as-image/image-change-with-equal-sizes.html [ ImageOnlyFailure Pass ] webkit.org/b/183608 imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey.https.html [ Failure Pass ] @@ -2440,8 +2441,6 @@ webkit.org/b/182108 http/tests/media/hls/hls-webvtt-tracks.html [ Timeout ] -webkit.org/b/182317 http/tests/resourceLoadStatistics/grandfathering.html [ Pass Failure ] - webkit.org/b/183181 inspector/heap/getPreview.html [ Pass Timeout ] webkit.org/b/183186 imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-001.html [ Pass Timeout ] @@ -3531,8 +3530,6 @@ webkit.org/b/188436 svg/custom/href-svg-namespace-static.svg [ ImageOnlyFailure ] -webkit.org/b/188844 http/tests/resourceLoadStatistics/blocking-in-web-worker-script-import.html [ Failure ] - webkit.org/b/189343 imported/w3c/web-platform-tests/xhr/sync-no-timeout.any.html [ Failure ] webkit.org/b/189343 imported/w3c/web-platform-tests/xhr/sync-no-timeout.any.worker.html [ Failure ] @@ -3587,8 +3584,6 @@ webkit.org/b/190991 media/encrypted-media/encrypted-media-v2-events.html [ Timeout ] webkit.org/b/190991 media/encrypted-media/encrypted-media-v2-syntax.html [ Timeout ] -webkit.org/b/190992 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js.html [ Failure ] - webkit.org/b/191000 imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/hidden.html [ Failure ] webkit.org/b/191000 imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/text.html [ Failure ] webkit.org/b/191000 imported/w3c/web-platform-tests/shadow-dom/input-element-list.html [ Failure ] @@ -3660,21 +3655,6 @@ imported/w3c/web-platform-tests/css/css-lists/content-property/marker-text-matches-georgian.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-lists/content-property/marker-text-matches-armenian.html [ ImageOnlyFailure ] -webkit.org/b/193320 http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-redirect-collusion.html [ Failure ] -webkit.org/b/193320 http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html [ Failure ] -webkit.org/b/193320 http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html [ Failure ] -webkit.org/b/193320 http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html [ Failure ] -webkit.org/b/193320 http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html [ Failure ] -webkit.org/b/193320 http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html [ Failure ] -webkit.org/b/193320 http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html [ Failure ] -webkit.org/b/193320 http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html [ Failure ] -webkit.org/b/193320
[webkit-changes] [240291] trunk/Tools
Title: [240291] trunk/Tools Revision 240291 Author aakash_j...@apple.com Date 2019-01-22 13:25:06 -0800 (Tue, 22 Jan 2019) Log Message [build.webkit.org] Unit-test failure after r237113 https://bugs.webkit.org/show_bug.cgi?id=193669 Reviewed by Michael Catanzaro. * BuildSlaveSupport/build.webkit.org-config/factories.py: (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has multiple or zero flags. Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py (240290 => 240291) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py 2019-01-22 21:23:31 UTC (rev 240290) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py 2019-01-22 21:25:06 UTC (rev 240291) @@ -39,7 +39,7 @@ self.addStep(DeleteStaleBuildFiles()) if platform == "win": self.addStep(InstallWin32Dependencies()) -if platform == "gtk" and additionalArguments != ["--no-experimental-features"]: +if platform == "gtk" and "--no-experimental-features" not in (additionalArguments or []): self.addStep(InstallGtkDependencies()) if platform == "wpe": self.addStep(InstallWpeDependencies()) Modified: trunk/Tools/ChangeLog (240290 => 240291) --- trunk/Tools/ChangeLog 2019-01-22 21:23:31 UTC (rev 240290) +++ trunk/Tools/ChangeLog 2019-01-22 21:25:06 UTC (rev 240291) @@ -1,3 +1,14 @@ +2019-01-22 Aakash Jain + +[build.webkit.org] Unit-test failure after r237113 +https://bugs.webkit.org/show_bug.cgi?id=193669 + +Reviewed by Michael Catanzaro. + +* BuildSlaveSupport/build.webkit.org-config/factories.py: +(Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has +multiple or zero flags. + 2019-01-22 Tadeu Zagallo Cache bytecode to disk ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240290] trunk/Source/WebInspectorUI
Title: [240290] trunk/Source/WebInspectorUI
Revision 240290
Author commit-qu...@webkit.org
Date 2019-01-22 13:23:31 -0800 (Tue, 22 Jan 2019)
Log Message
Web Inspector: Network Table appears broken after filter - rows look collapsed
https://bugs.webkit.org/show_bug.cgi?id=192730
Patch by Joseph Pecoraro on 2019-01-22
Reviewed by Devin Rousso.
* UserInterface/Views/Table.js:
(WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
Affect the filler row like the other applyColumnWidths calls since this
now may be the initial call to size visible columns.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/Table.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240289 => 240290)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-22 21:22:34 UTC (rev 240289)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-22 21:23:31 UTC (rev 240290)
@@ -1,3 +1,16 @@
+2019-01-22 Joseph Pecoraro
+
+Web Inspector: Network Table appears broken after filter - rows look collapsed
+https://bugs.webkit.org/show_bug.cgi?id=192730
+
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Views/Table.js:
+(WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
+Affect the filler row like the other applyColumnWidths calls since this
+now may be the initial call to size visible columns.
+
2019-01-22 Devin Rousso
Web Inspector: Audit: use plural strings for Passed, Failed, and Unsupported
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Table.js (240289 => 240290)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2019-01-22 21:22:34 UTC (rev 240289)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2019-01-22 21:23:31 UTC (rev 240290)
@@ -1153,11 +1153,13 @@
{
// Apply and create missing cells only if row needs a width update.
for (let row of this._listElement.children) {
-if (row.__widthGeneration !== this._widthGeneration && row !== this._fillerRow) {
+if (row.__widthGeneration !== this._widthGeneration) {
for (let i = 0; i < row.children.length; ++i)
row.children[i].style.width = this._columnWidths[i] + "px";
-if (row.children.length !== this._visibleColumns.length)
-this._populateRow(row);
+if (row !== this._fillerRow) {
+if (row.children.length !== this._visibleColumns.length)
+this._populateRow(row);
+}
row.__widthGeneration = this._widthGeneration;
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240289] trunk/Source/WebKit
Title: [240289] trunk/Source/WebKit Revision 240289 Author pvol...@apple.com Date 2019-01-22 13:22:34 -0800 (Tue, 22 Jan 2019) Log Message [macOS] Adjust logging policy in WebKit's sandbox https://bugs.webkit.org/show_bug.cgi?id=193454 Reviewed by Brent Fulgham. Add a rule to initially deny all calls, since the default is to allow every call. Later rules allow syscalls that we determined are needed for proper WebKit function. This reduces the API surface available to attackers. * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (240288 => 240289) --- trunk/Source/WebKit/ChangeLog 2019-01-22 21:15:35 UTC (rev 240288) +++ trunk/Source/WebKit/ChangeLog 2019-01-22 21:22:34 UTC (rev 240289) @@ -1,3 +1,16 @@ +2019-01-22 Per Arne Vollan + +[macOS] Adjust logging policy in WebKit's sandbox +https://bugs.webkit.org/show_bug.cgi?id=193454 + +Reviewed by Brent Fulgham. + +Add a rule to initially deny all calls, since the default is to allow every call. +Later rules allow syscalls that we determined are needed for proper WebKit function. +This reduces the API surface available to attackers. + +* WebProcess/com.apple.WebProcess.sb.in: + 2019-01-22 Daniel Bates [iOS] WebKit should handle shift state changes when using the software keyboard Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (240288 => 240289) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2019-01-22 21:15:35 UTC (rev 240288) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2019-01-22 21:22:34 UTC (rev 240289) @@ -825,6 +825,7 @@ #endif // PLATFORM(MAC) (when (defined? 'syscall-unix) +(deny syscall-unix (with termination)) (allow syscall-unix (syscall-number SYS_exit) (syscall-number SYS_read) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240288] trunk/Source/WebKit
Title: [240288] trunk/Source/WebKit Revision 240288 Author dba...@webkit.org Date 2019-01-22 13:15:35 -0800 (Tue, 22 Jan 2019) Log Message [iOS] WebKit should handle shift state changes when using the software keyboard https://bugs.webkit.org/show_bug.cgi?id=191475 Reviewed by Brent Fulgham. Implement UIKit SPI to be notified of shift state changes to the software keyboard and dispatch a synthetic keydown or keyup event for either the Shift key or Caps Lock key. A side benefit of this change is that we now show and hide the caps lock indicator in a focused password field when caps lock is enabled or disabled using the software keyboard, respectively. * Platform/spi/ios/UIKitSPI.h: Expose more SPI. * SourcesCocoa.txt: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView modifierFlagsDidChangeFrom:to:]): Create a synthetic flags changed web event based on the state change and dispatch it. (-[WKContentView _didHandleKeyEvent:eventWasHandled:]): Early return if the event was a synethic flags change event so that we do not notify UIKit about this event as it does not know anything about such synthetic events. * UIProcess/ios/WKSyntheticFlagsChangedWebEvent.h: Added. * UIProcess/ios/WKSyntheticFlagsChangedWebEvent.mm: Added. (-[WKSyntheticFlagsChangedWebEvent initWithKeyCode:modifiers:keyDown:]): (-[WKSyntheticFlagsChangedWebEvent initWithCapsLockState:]): (-[WKSyntheticFlagsChangedWebEvent initWithShiftState:]): * WebKit.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h trunk/Source/WebKit/SourcesCocoa.txt trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit/UIProcess/ios/WKSyntheticFlagsChangedWebEvent.h trunk/Source/WebKit/UIProcess/ios/WKSyntheticFlagsChangedWebEvent.mm Diff Modified: trunk/Source/WebKit/ChangeLog (240287 => 240288) --- trunk/Source/WebKit/ChangeLog 2019-01-22 21:02:30 UTC (rev 240287) +++ trunk/Source/WebKit/ChangeLog 2019-01-22 21:15:35 UTC (rev 240288) @@ -1,5 +1,36 @@ 2019-01-22 Daniel Bates +[iOS] WebKit should handle shift state changes when using the software keyboard +https://bugs.webkit.org/show_bug.cgi?id=191475 + + +Reviewed by Brent Fulgham. + +Implement UIKit SPI to be notified of shift state changes to the software keyboard +and dispatch a synthetic keydown or keyup event for either the Shift key or Caps Lock +key. + +A side benefit of this change is that we now show and hide the caps lock indicator +in a focused password field when caps lock is enabled or disabled using the software +keyboard, respectively. + +* Platform/spi/ios/UIKitSPI.h: Expose more SPI. +* SourcesCocoa.txt: +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView modifierFlagsDidChangeFrom:to:]): Create a synthetic flags changed +web event based on the state change and dispatch it. +(-[WKContentView _didHandleKeyEvent:eventWasHandled:]): Early return if the event +was a synethic flags change event so that we do not notify UIKit about this event +as it does not know anything about such synthetic events. +* UIProcess/ios/WKSyntheticFlagsChangedWebEvent.h: Added. +* UIProcess/ios/WKSyntheticFlagsChangedWebEvent.mm: Added. +(-[WKSyntheticFlagsChangedWebEvent initWithKeyCode:modifiers:keyDown:]): +(-[WKSyntheticFlagsChangedWebEvent initWithCapsLockState:]): +(-[WKSyntheticFlagsChangedWebEvent initWithShiftState:]): +* WebKit.xcodeproj/project.pbxproj: + +2019-01-22 Daniel Bates + [iOS] Interpret text key commands on keydown and app key commands on keypress https://bugs.webkit.org/show_bug.cgi?id=192897 Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (240287 => 240288) --- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2019-01-22 21:02:30 UTC (rev 240287) +++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2019-01-22 21:15:35 UTC (rev 240288) @@ -393,6 +393,9 @@ - (void)insertDictationResult:(NSArray *)dictationResult withCorrectionIdentifier:(id)correctionIdentifier; - (void)replaceRangeWithTextWithoutClosingTyping:(UITextRange *)range replacementText:(NSString *)text; - (void)setBottomBufferHeight:(CGFloat)bottomBuffer; +#if USE(UIKIT_KEYBOARD_ADDITIONS) +- (void)modifierFlagsDidChangeFrom:(UIKeyModifierFlags)oldFlags to:(UIKeyModifierFlags)newFlags; +#endif @property (nonatomic) UITextGranularity selectionGranularity; @required - (BOOL)hasContent; Modified: trunk/Source/WebKit/SourcesCocoa.txt (240287 => 240288) --- trunk/Source/WebKit/SourcesCocoa.txt 2019-01-22 21:02:30 UTC (rev 240287) +++ trunk/Source/WebKit/SourcesCocoa.txt 2019-01-22 21:15:35 UTC (rev 240288) @@ -405,6 +405,7 @@ UIProcess/ios/WKPDFView.mm UIProcess/ios/WKScrollView.mm
[webkit-changes] [240287] branches/safari-607-branch/Source/WebKit
Title: [240287] branches/safari-607-branch/Source/WebKit Revision 240287 Author alanc...@apple.com Date 2019-01-22 13:02:30 -0800 (Tue, 22 Jan 2019) Log Message Cherry-pick r240055. rdar://problem/47099573 Regression(r240046) Several API tests are crashing https://bugs.webkit.org/show_bug.cgi?id=193509 Reviewed by Geoffrey Garen. The crashes would happen because loadRequestShared() would take a WebProcessProxy& in parameter but then call reattachToWebProcess() if the page is not valid, which would replace m_process and invalidate our process reference. To address the issue, move the reattachToWebProcess() call to loadRequest(), before calling loadRequestShared(). Also, update *Shared() methods to take a Ref&& instead of a WebProcessProxy& in parameter. Since we call client delegates, we need to make sure our process stays alive. * UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::loadData): (WebKit::ProvisionalPageProxy::loadRequest): (WebKit::ProvisionalPageProxy::didCreateMainFrame): (WebKit::ProvisionalPageProxy::didPerformClientRedirect): (WebKit::ProvisionalPageProxy::didStartProvisionalLoadForFrame): (WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame): (WebKit::ProvisionalPageProxy::didNavigateWithNavigationData): (WebKit::ProvisionalPageProxy::didChangeProvisionalURLForFrame): (WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync): (WebKit::ProvisionalPageProxy::decidePolicyForResponse): (WebKit::ProvisionalPageProxy::startURLSchemeTask): (WebKit::ProvisionalPageProxy::backForwardGoToItem): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadRequest): (WebKit::WebPageProxy::loadRequestWithNavigationShared): (WebKit::WebPageProxy::loadData): (WebKit::WebPageProxy::loadDataWithNavigationShared): (WebKit::WebPageProxy::didPerformDragControllerAction): (WebKit::WebPageProxy::findPlugin): (WebKit::WebPageProxy::didCreateMainFrame): (WebKit::WebPageProxy::didCreateSubframe): (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared): (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame): (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrameShared): (WebKit::WebPageProxy::willPerformClientRedirectForFrame): (WebKit::WebPageProxy::didCancelClientRedirectForFrame): (WebKit::WebPageProxy::didChangeProvisionalURLForFrame): (WebKit::WebPageProxy::didChangeProvisionalURLForFrameShared): (WebKit::WebPageProxy::didFailProvisionalLoadForFrame): (WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared): (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::didFinishDocumentLoadForFrame): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::didSameDocumentNavigationForFrame): (WebKit::WebPageProxy::didReceiveTitleForFrame): (WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame): (WebKit::WebPageProxy::didDisplayInsecureContentForFrame): (WebKit::WebPageProxy::didRunInsecureContentForFrame): (WebKit::WebPageProxy::frameDidBecomeFrameSet): (WebKit::WebPageProxy::decidePolicyForNavigationActionAsync): (WebKit::WebPageProxy::decidePolicyForNavigationActionAsyncShared): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNavigationActionSync): (WebKit::WebPageProxy::decidePolicyForNewWindowAction): (WebKit::WebPageProxy::decidePolicyForResponse): (WebKit::WebPageProxy::decidePolicyForResponseShared): (WebKit::WebPageProxy::unableToImplementPolicy): (WebKit::WebPageProxy::willSubmitForm): (WebKit::WebPageProxy::didNavigateWithNavigationData): (WebKit::WebPageProxy::didNavigateWithNavigationDataShared): (WebKit::WebPageProxy::didPerformClientRedirect): (WebKit::WebPageProxy::didPerformClientRedirectShared): (WebKit::WebPageProxy::didPerformServerRedirect): (WebKit::WebPageProxy::didUpdateHistoryTitle): (WebKit::WebPageProxy::createNewPage): (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt): (WebKit::WebPageProxy::unavailablePluginButtonClicked): (WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): (WebKit::WebPageProxy::runOpenPanel): (WebKit::WebPageProxy::printFrame): (WebKit::WebPageProxy::backForwardGoToItem): (WebKit::WebPageProxy::backForwardGoToItemShared): (WebKit::WebPageProxy::learnWord): (WebKit::WebPageProxy::ignoreWord): (WebKit::WebPageProxy::didReceiveEvent): (WebKit::WebPageProxy::editingRangeCallback): (WebKit::WebPageProxy::rectForCharacterRangeCallback): (WebKit::WebPageProxy::focusedFrameChanged):
[webkit-changes] [240285] trunk/Source
Title: [240285] trunk/Source
Revision 240285
Author dba...@webkit.org
Date 2019-01-22 12:59:48 -0800 (Tue, 22 Jan 2019)
Log Message
[iOS] Interpret text key commands on keydown and app key commands on keypress
https://bugs.webkit.org/show_bug.cgi?id=192897
Reviewed by Brent Fulgham.
Source/WebKit:
Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
is false) and keypress (isCharEvent is true), respectively.
* Platform/spi/ios/UIKitSPI.h: Add more SPI.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
Source/WebKitLegacy/ios:
Add stubs for SPI.
* DefaultDelegates/WebDefaultUIKitDelegate.m:
(-[WebDefaultUIKitDelegate handleKeyTextCommandForCurrentEvent]): Added.
(-[WebDefaultUIKitDelegate handleKeyAppCommandForCurrentEvent]): Added.
(-[WebDefaultUIKitDelegate handleKeyCommandForCurrentEvent]): Deleted.
* WebView/WebUIKitDelegate.h:
Source/WebKitLegacy/mac:
Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
is false) and keypress (isCharEvent is true), respectively.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _handleEditingKeyEvent:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKitLegacy/ios/ChangeLog
trunk/Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultUIKitDelegate.m
trunk/Source/WebKitLegacy/ios/WebView/WebUIKitDelegate.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (240284 => 240285)
--- trunk/Source/WebKit/ChangeLog 2019-01-22 20:58:33 UTC (rev 240284)
+++ trunk/Source/WebKit/ChangeLog 2019-01-22 20:59:48 UTC (rev 240285)
@@ -1,3 +1,18 @@
+2019-01-22 Daniel Bates
+
+[iOS] Interpret text key commands on keydown and app key commands on keypress
+https://bugs.webkit.org/show_bug.cgi?id=192897
+
+
+Reviewed by Brent Fulgham.
+
+Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
+is false) and keypress (isCharEvent is true), respectively.
+
+* Platform/spi/ios/UIKitSPI.h: Add more SPI.
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _interpretKeyEvent:isCharEvent:]):
+
2019-01-22 David Kilzer
C strings in ClientCertificateAuthenticationXPCConstants.h are duplicated
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (240284 => 240285)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2019-01-22 20:58:33 UTC (rev 240284)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2019-01-22 20:59:48 UTC (rev 240285)
@@ -1072,6 +1072,8 @@
@interface UIKeyboardImpl (IPI)
- (void)setInitialDirection;
- (void)prepareKeyboardInputModeFromPreferences:(UIKeyboardInputMode *)lastUsedMode;
+- (BOOL)handleKeyTextCommandForCurrentEvent;
+- (BOOL)handleKeyAppCommandForCurrentEvent;
@property (nonatomic, readonly) UIKeyboardInputMode *currentInputModeInPreference;
@end
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (240284 => 240285)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-01-22 20:58:33 UTC (rev 240284)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-01-22 20:59:48 UTC (rev 240285)
@@ -135,14 +135,6 @@
#endif
-#if PLATFORM(IOS_FAMILY)
-
-@interface UIKeyboardImpl (Staging)
-- (BOOL)handleKeyCommandForCurrentEvent;
-@end
-
-#endif
-
namespace WebKit {
using namespace WebCore;
using namespace WebKit;
@@ -4023,8 +4015,10 @@
UIKeyboardImpl *keyboard = [UIKeyboardImpl sharedInstance];
#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 13
-if (event.type == WebEventKeyDown && [keyboard respondsToSelector:@selector(handleKeyCommandForCurrentEvent)] && [keyboard handleKeyCommandForCurrentEvent])
+if (!isCharEvent && [keyboard respondsToSelector:@selector(handleKeyTextCommandForCurrentEvent)] && [keyboard handleKeyTextCommandForCurrentEvent])
return YES;
+if (isCharEvent && [keyboard respondsToSelector:@selector(handleKeyAppCommandForCurrentEvent)] && [keyboard handleKeyAppCommandForCurrentEvent])
+return YES;
#endif
NSString *characters = event.characters;
Modified: trunk/Source/WebKitLegacy/ios/ChangeLog (240284 => 240285)
--- trunk/Source/WebKitLegacy/ios/ChangeLog 2019-01-22 20:58:33 UTC (rev 240284)
+++ trunk/Source/WebKitLegacy/ios/ChangeLog 2019-01-22 20:59:48 UTC (rev 240285)
@@ -1,3 +1,19 @@
+2019-01-22 Daniel Bates
+
+[iOS] Interpret text key commands on keydown and app key commands on keypress
+https://bugs.webkit.org/show_bug.cgi?id=192897
+
+
+Reviewed by Brent Fulgham.
+
+Add stubs for SPI.
+
+* DefaultDelegates/WebDefaultUIKitDelegate.m:
+(-[WebDefaultUIKitDelegate
[webkit-changes] [240284] branches/safari-607-branch
Title: [240284] branches/safari-607-branch Revision 240284 Author alanc...@apple.com Date 2019-01-22 12:58:33 -0800 (Tue, 22 Jan 2019) Log Message Revert r240258. rdar://problem/47099573 Modified Paths branches/safari-607-branch/LayoutTests/ChangeLog branches/safari-607-branch/LayoutTests/platform/wk2/TestExpectations branches/safari-607-branch/Source/WebCore/ChangeLog branches/safari-607-branch/Source/WebCore/loader/FrameLoader.cpp branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/Shared/WebPageCreationParameters.cpp branches/safari-607-branch/Source/WebKit/Shared/WebPageCreationParameters.h branches/safari-607-branch/Source/WebKit/Shared/WebPolicyAction.h branches/safari-607-branch/Source/WebKit/Sources.txt branches/safari-607-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm branches/safari-607-branch/Source/WebKit/UIProcess/PageClient.h branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebFrameProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebPageProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebPageProxy.h branches/safari-607-branch/Source/WebKit/UIProcess/WebProcessProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebProcessProxy.h branches/safari-607-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebPage.h branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm branches/safari-607-branch/Tools/ChangeLog branches/safari-607-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Removed Paths branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h Diff Modified: branches/safari-607-branch/LayoutTests/ChangeLog (240283 => 240284) --- branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-22 20:58:25 UTC (rev 240283) +++ branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-22 20:58:33 UTC (rev 240284) @@ -1,5 +1,9 @@ 2019-01-22 Alan Coon +Revert r240258. rdar://problem/47099573 + +2019-01-22 Alan Coon + Revert r240262. rdar://problem/47099573 2019-01-22 Alan Coon Modified: branches/safari-607-branch/LayoutTests/platform/wk2/TestExpectations (240283 => 240284) --- branches/safari-607-branch/LayoutTests/platform/wk2/TestExpectations 2019-01-22 20:58:25 UTC (rev 240283) +++ branches/safari-607-branch/LayoutTests/platform/wk2/TestExpectations 2019-01-22 20:58:33 UTC (rev 240284) @@ -733,8 +733,8 @@ http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context.html [ Skip ] http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.html [ Skip ] -# This feature is currently disabled by default and unfinished . -http/tests/navigation/process-swap-window-open.html [ Skip ] +# Process swapping is only implemented on WebKit2. +http/tests/navigation/process-swap-window-open.html [ Pass ] # Cross-Origin-Resource-Policy response header is only implemented in WebKit2. http/wpt/cross-origin-resource-policy/ [ Pass ] Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240283 => 240284) --- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-22 20:58:25 UTC (rev 240283) +++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-22 20:58:33 UTC (rev 240284) @@ -1,5 +1,9 @@ 2019-01-22 Alan Coon +Revert r240258. rdar://problem/47099573 + +2019-01-22 Alan Coon + Revert r240262. rdar://problem/47099573 2019-01-22 Alan Coon Modified: branches/safari-607-branch/Source/WebCore/loader/FrameLoader.cpp (240283 => 240284) --- branches/safari-607-branch/Source/WebCore/loader/FrameLoader.cpp 2019-01-22 20:58:25 UTC (rev 240283) +++ branches/safari-607-branch/Source/WebCore/loader/FrameLoader.cpp 2019-01-22 20:58:33 UTC (rev 240284) @@ -2032,11 +2032,11 @@ Optional hasInsecureContent = cachedPage->cachedMainFrame()->hasInsecureContent(); -dispatchDidCommitLoad(hasInsecureContent); - // FIXME: This API should be turned around so that we ground CachedPage into the Page. cachedPage->restore(*m_frame.page()); +dispatchDidCommitLoad(hasInsecureContent); + #if PLATFORM(IOS_FAMILY) m_frame.page()->chrome().setDispatchViewportDataDidChangeSuppressed(false); m_frame.page()->chrome().dispatchViewportPropertiesDidChange(m_frame.page()->viewportArguments()); Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240283 => 240284) --- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-22 20:58:25 UTC (rev 240283) +++
[webkit-changes] [240282] branches/safari-607-branch/Source
Title: [240282] branches/safari-607-branch/Source
Revision 240282
Author alanc...@apple.com
Date 2019-01-22 12:58:23 -0800 (Tue, 22 Jan 2019)
Log Message
Revert r240260. rdar://problem/47099573
Modified Paths
branches/safari-607-branch/Source/WTF/ChangeLog
branches/safari-607-branch/Source/WTF/wtf/RefCounter.h
branches/safari-607-branch/Source/WebKit/ChangeLog
branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h
branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h
Diff
Modified: branches/safari-607-branch/Source/WTF/ChangeLog (240281 => 240282)
--- branches/safari-607-branch/Source/WTF/ChangeLog 2019-01-22 20:58:20 UTC (rev 240281)
+++ branches/safari-607-branch/Source/WTF/ChangeLog 2019-01-22 20:58:23 UTC (rev 240282)
@@ -1,5 +1,9 @@
2019-01-22 Alan Coon
+Revert r240260. rdar://problem/47099573
+
+2019-01-22 Alan Coon
+
Revert r240261. rdar://problem/47099573
2019-01-22 Alan Coon
Modified: branches/safari-607-branch/Source/WTF/wtf/RefCounter.h (240281 => 240282)
--- branches/safari-607-branch/Source/WTF/wtf/RefCounter.h 2019-01-22 20:58:20 UTC (rev 240281)
+++ branches/safari-607-branch/Source/WTF/wtf/RefCounter.h 2019-01-22 20:58:23 UTC (rev 240282)
@@ -65,7 +65,6 @@
using ValueChangeFunction = WTF::Function;
RefCounter(ValueChangeFunction&& = nullptr);
-RefCounter(RefCounter&&) = default;
~RefCounter();
Token count() const
Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240281 => 240282)
--- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-22 20:58:20 UTC (rev 240281)
+++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-22 20:58:23 UTC (rev 240282)
@@ -1,5 +1,9 @@
2019-01-22 Alan Coon
+Revert r240260. rdar://problem/47099573
+
+2019-01-22 Alan Coon
+
Revert r240262. rdar://problem/47099573
2019-01-22 Alan Coon
Modified: branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h (240281 => 240282)
--- branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h 2019-01-22 20:58:20 UTC (rev 240281)
+++ branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h 2019-01-22 20:58:23 UTC (rev 240282)
@@ -88,7 +88,7 @@
URL m_provisionalLoadURL;
#if PLATFORM(IOS_FAMILY)
-ProcessThrottler::ForegroundActivityToken m_suspensionToken;
+ProcessThrottler::BackgroundActivityToken m_suspensionToken;
#endif
};
Modified: branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h (240281 => 240282)
--- branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h 2019-01-22 20:58:20 UTC (rev 240281)
+++ branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h 2019-01-22 20:58:23 UTC (rev 240282)
@@ -72,7 +72,7 @@
SuspensionState m_suspensionState { SuspensionState::Suspending };
CompletionHandler m_readyToUnsuspendHandler;
#if PLATFORM(IOS_FAMILY)
-ProcessThrottler::BackgroundActivityToken m_suspensionToken;
+ProcessThrottler::ForegroundActivityToken m_suspensionToken;
#endif
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240283] branches/safari-607-branch/Source/WebKit
Title: [240283] branches/safari-607-branch/Source/WebKit
Revision 240283
Author alanc...@apple.com
Date 2019-01-22 12:58:25 -0800 (Tue, 22 Jan 2019)
Log Message
Revert r240259. rdar://problem/47099573
Modified Paths
branches/safari-607-branch/Source/WebKit/ChangeLog
branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h
Diff
Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240282 => 240283)
--- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-22 20:58:23 UTC (rev 240282)
+++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-22 20:58:25 UTC (rev 240283)
@@ -1,5 +1,9 @@
2019-01-22 Alan Coon
+Revert r240259. rdar://problem/47099573
+
+2019-01-22 Alan Coon
+
Revert r240260. rdar://problem/47099573
2019-01-22 Alan Coon
Modified: branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h (240282 => 240283)
--- branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h 2019-01-22 20:58:23 UTC (rev 240282)
+++ branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h 2019-01-22 20:58:25 UTC (rev 240283)
@@ -72,7 +72,7 @@
SuspensionState m_suspensionState { SuspensionState::Suspending };
CompletionHandler m_readyToUnsuspendHandler;
#if PLATFORM(IOS_FAMILY)
-ProcessThrottler::ForegroundActivityToken m_suspensionToken;
+ProcessThrottler::BackgroundActivityToken m_suspensionToken;
#endif
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240281] branches/safari-607-branch/Source/WTF
Title: [240281] branches/safari-607-branch/Source/WTF Revision 240281 Author alanc...@apple.com Date 2019-01-22 12:58:20 -0800 (Tue, 22 Jan 2019) Log Message Revert r240261. rdar://problem/47099573 Modified Paths branches/safari-607-branch/Source/WTF/ChangeLog branches/safari-607-branch/Source/WTF/wtf/RefCounter.h Diff Modified: branches/safari-607-branch/Source/WTF/ChangeLog (240280 => 240281) --- branches/safari-607-branch/Source/WTF/ChangeLog 2019-01-22 20:58:17 UTC (rev 240280) +++ branches/safari-607-branch/Source/WTF/ChangeLog 2019-01-22 20:58:20 UTC (rev 240281) @@ -1,5 +1,9 @@ 2019-01-22 Alan Coon +Revert r240261. rdar://problem/47099573 + +2019-01-22 Alan Coon + Cherry-pick r23. rdar://problem/47099573 Unreviewed, revert part of r239997 as it is not needed to fix the build. Modified: branches/safari-607-branch/Source/WTF/wtf/RefCounter.h (240280 => 240281) --- branches/safari-607-branch/Source/WTF/wtf/RefCounter.h 2019-01-22 20:58:17 UTC (rev 240280) +++ branches/safari-607-branch/Source/WTF/wtf/RefCounter.h 2019-01-22 20:58:20 UTC (rev 240281) @@ -65,6 +65,7 @@ using ValueChangeFunction = WTF::Function; RefCounter(ValueChangeFunction&& = nullptr); +RefCounter(RefCounter&&) = default; ~RefCounter(); Token count() const ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240280] branches/safari-607-branch
Title: [240280] branches/safari-607-branch Revision 240280 Author alanc...@apple.com Date 2019-01-22 12:58:17 -0800 (Tue, 22 Jan 2019) Log Message Revert r240262. rdar://problem/47099573 Modified Paths branches/safari-607-branch/LayoutTests/ChangeLog branches/safari-607-branch/LayoutTests/platform/wk2/TestExpectations branches/safari-607-branch/Source/WebCore/ChangeLog branches/safari-607-branch/Source/WebCore/loader/FrameLoader.cpp branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/Shared/WebPageCreationParameters.cpp branches/safari-607-branch/Source/WebKit/Shared/WebPageCreationParameters.h branches/safari-607-branch/Source/WebKit/Shared/WebPolicyAction.h branches/safari-607-branch/Source/WebKit/Sources.txt branches/safari-607-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm branches/safari-607-branch/Source/WebKit/UIProcess/PageClient.h branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebFrameProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebPageProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebPageProxy.h branches/safari-607-branch/Source/WebKit/UIProcess/WebProcessProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebProcessProxy.h branches/safari-607-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebPage.h branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm branches/safari-607-branch/Tools/ChangeLog branches/safari-607-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Added Paths branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h Diff Modified: branches/safari-607-branch/LayoutTests/ChangeLog (240279 => 240280) --- branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-22 20:58:07 UTC (rev 240279) +++ branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-22 20:58:17 UTC (rev 240280) @@ -1,5 +1,9 @@ 2019-01-22 Alan Coon +Revert r240262. rdar://problem/47099573 + +2019-01-22 Alan Coon + Revert r240263. rdar://problem/47099573 2019-01-22 Alan Coon Modified: branches/safari-607-branch/LayoutTests/platform/wk2/TestExpectations (240279 => 240280) --- branches/safari-607-branch/LayoutTests/platform/wk2/TestExpectations 2019-01-22 20:58:07 UTC (rev 240279) +++ branches/safari-607-branch/LayoutTests/platform/wk2/TestExpectations 2019-01-22 20:58:17 UTC (rev 240280) @@ -733,8 +733,8 @@ http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context.html [ Skip ] http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.html [ Skip ] -# Process swapping is only implemented on WebKit2. -http/tests/navigation/process-swap-window-open.html [ Pass ] +# This feature is currently disabled by default and unfinished . +http/tests/navigation/process-swap-window-open.html [ Skip ] # Cross-Origin-Resource-Policy response header is only implemented in WebKit2. http/wpt/cross-origin-resource-policy/ [ Pass ] Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (240279 => 240280) --- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-22 20:58:07 UTC (rev 240279) +++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-01-22 20:58:17 UTC (rev 240280) @@ -1,5 +1,9 @@ 2019-01-22 Alan Coon +Revert r240262. rdar://problem/47099573 + +2019-01-22 Alan Coon + Revert r240263. rdar://problem/47099573 2019-01-22 Alan Coon Modified: branches/safari-607-branch/Source/WebCore/loader/FrameLoader.cpp (240279 => 240280) --- branches/safari-607-branch/Source/WebCore/loader/FrameLoader.cpp 2019-01-22 20:58:07 UTC (rev 240279) +++ branches/safari-607-branch/Source/WebCore/loader/FrameLoader.cpp 2019-01-22 20:58:17 UTC (rev 240280) @@ -2032,11 +2032,11 @@ Optional hasInsecureContent = cachedPage->cachedMainFrame()->hasInsecureContent(); +dispatchDidCommitLoad(hasInsecureContent); + // FIXME: This API should be turned around so that we ground CachedPage into the Page. cachedPage->restore(*m_frame.page()); -dispatchDidCommitLoad(hasInsecureContent); - #if PLATFORM(IOS_FAMILY) m_frame.page()->chrome().setDispatchViewportDataDidChangeSuppressed(false); m_frame.page()->chrome().dispatchViewportPropertiesDidChange(m_frame.page()->viewportArguments()); Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240279 => 240280) --- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-22 20:58:07 UTC (rev 240279) +++
[webkit-changes] [240278] branches/safari-607-branch/Source/WebKit
Title: [240278] branches/safari-607-branch/Source/WebKit
Revision 240278
Author alanc...@apple.com
Date 2019-01-22 12:57:52 -0800 (Tue, 22 Jan 2019)
Log Message
Revert r240264. rdar://problem/47099573
Modified Paths
branches/safari-607-branch/Source/WebKit/ChangeLog
branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
branches/safari-607-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-607-branch/Source/WebKit/UIProcess/WebPageProxy.h
Diff
Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240277 => 240278)
--- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-22 20:52:53 UTC (rev 240277)
+++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-22 20:57:52 UTC (rev 240278)
@@ -1,5 +1,9 @@
2019-01-22 Alan Coon
+Revert r240264. rdar://problem/47099573
+
+2019-01-22 Alan Coon
+
Cherry-pick r240055. rdar://problem/47099573
Regression(r240046) Several API tests are crashing
Modified: branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp (240277 => 240278)
--- branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp 2019-01-22 20:52:53 UTC (rev 240277)
+++ branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp 2019-01-22 20:57:52 UTC (rev 240278)
@@ -147,7 +147,7 @@
{
RELEASE_LOG_IF_ALLOWED(ProcessSwapping, "loadData: pageID = %" PRIu64, m_page.pageID());
-m_page.loadDataWithNavigationShared(m_process.copyRef(), navigation, data, MIMEType, encoding, baseURL, userData, WebCore::ShouldTreatAsContinuingLoad::Yes, WTFMove(websitePolicies));
+m_page.loadDataWithNavigationShared(m_process, navigation, data, MIMEType, encoding, baseURL, userData, WebCore::ShouldTreatAsContinuingLoad::Yes, WTFMove(websitePolicies));
}
void ProvisionalPageProxy::loadRequest(API::Navigation& navigation, WebCore::ResourceRequest&& request, WebCore::ShouldOpenExternalURLsPolicy shouldOpenExternalURLsPolicy, API::Object* userData, Optional&& websitePolicies)
@@ -154,7 +154,7 @@
{
RELEASE_LOG_IF_ALLOWED(ProcessSwapping, "loadRequest: pageID = %" PRIu64, m_page.pageID());
-m_page.loadRequestWithNavigationShared(m_process.copyRef(), navigation, WTFMove(request), shouldOpenExternalURLsPolicy, userData, WebCore::ShouldTreatAsContinuingLoad::Yes, WTFMove(websitePolicies));
+m_page.loadRequestWithNavigationShared(m_process, navigation, WTFMove(request), shouldOpenExternalURLsPolicy, userData, WebCore::ShouldTreatAsContinuingLoad::Yes, WTFMove(websitePolicies));
}
void ProvisionalPageProxy::goToBackForwardItem(API::Navigation& navigation, WebBackForwardListItem& item, Optional&& websitePolicies)
@@ -196,13 +196,13 @@
// In this case we have the UIProcess synthesize the redirect notification at the appropriate time.
if (m_isServerRedirect) {
m_mainFrame->frameLoadState().didStartProvisionalLoad(m_request.url());
-m_page.didReceiveServerRedirectForProvisionalLoadForFrameShared(m_process.copyRef(), m_mainFrame->frameID(), m_navigationID, WTFMove(m_request), { });
+m_page.didReceiveServerRedirectForProvisionalLoadForFrameShared(m_process, m_mainFrame->frameID(), m_navigationID, WTFMove(m_request), { });
}
}
void ProvisionalPageProxy::didPerformClientRedirect(const String& sourceURLString, const String& destinationURLString, uint64_t frameID)
{
-m_page.didPerformClientRedirectShared(m_process.copyRef(), sourceURLString, destinationURLString, frameID);
+m_page.didPerformClientRedirectShared(m_process, sourceURLString, destinationURLString, frameID);
}
void ProvisionalPageProxy::didStartProvisionalLoadForFrame(uint64_t frameID, uint64_t navigationID, URL&& url, URL&& unreachableURL, const UserData& userData)
@@ -223,7 +223,7 @@
if (auto* pageMainFrame = m_page.mainFrame())
pageMainFrame->didStartProvisionalLoad(url);
-m_page.didStartProvisionalLoadForFrameShared(m_process.copyRef(), frameID, navigationID, WTFMove(url), WTFMove(unreachableURL), userData);
+m_page.didStartProvisionalLoadForFrameShared(m_process, frameID, navigationID, WTFMove(url), WTFMove(unreachableURL), userData);
}
void ProvisionalPageProxy::didFailProvisionalLoadForFrame(uint64_t frameID, const WebCore::SecurityOriginData& frameSecurityOrigin, uint64_t navigationID, const String& provisionalURL, const WebCore::ResourceError& error, const UserData& userData)
@@ -235,7 +235,7 @@
if (auto* pageMainFrame = m_page.mainFrame())
pageMainFrame->didFailProvisionalLoad();
-m_page.didFailProvisionalLoadForFrameShared(m_process.copyRef(), frameID, frameSecurityOrigin, navigationID, provisionalURL, error, userData); // Will delete |this|.
+m_page.didFailProvisionalLoadForFrameShared(m_process, frameID, frameSecurityOrigin, navigationID, provisionalURL, error, userData); // Will delete |this|.
}
void ProvisionalPageProxy::didCommitLoadForFrame(uint64_t frameID, uint64_t
[webkit-changes] [240277] trunk
Title: [240277] trunk
Revision 240277
Author drou...@apple.com
Date 2019-01-22 12:52:53 -0800 (Tue, 22 Jan 2019)
Log Message
Web Inspector: Audit: provide a way to get related Accessibility nodes for a given node
https://bugs.webkit.org/show_bug.cgi?id=193225
Reviewed by Joseph Pecoraro.
Source/WebCore:
Test: inspector/audit/run-accessibility.html
* inspector/InspectorAuditAccessibilityObject.idl:
* inspector/InspectorAuditAccessibilityObject.h:
* inspector/InspectorAuditAccessibilityObject.cpp:
(WebCore::InspectorAuditAccessibilityObject::getActiveDescendant): Added.
(WebCore::addChildren): Added.
(WebCore::InspectorAuditAccessibilityObject::getChildNodes): Added.
(WebCore::InspectorAuditAccessibilityObject::getControlledNodes): Added.
(WebCore::InspectorAuditAccessibilityObject::getFlowedNodes): Added.
(WebCore::InspectorAuditAccessibilityObject::getMouseEventNode): Added.
(WebCore::InspectorAuditAccessibilityObject::getOwnedNodes): Added.
(WebCore::InspectorAuditAccessibilityObject::getParentNode): Added.
(WebCore::InspectorAuditAccessibilityObject::getSelectedChildNodes): Added.
LayoutTests:
* inspector/audit/run-accessibility.html:
* inspector/audit/run-accessibility-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/audit/run-accessibility-expected.txt
trunk/LayoutTests/inspector/audit/run-accessibility.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp
trunk/Source/WebCore/inspector/InspectorAuditAccessibilityObject.h
trunk/Source/WebCore/inspector/InspectorAuditAccessibilityObject.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (240276 => 240277)
--- trunk/LayoutTests/ChangeLog 2019-01-22 20:51:27 UTC (rev 240276)
+++ trunk/LayoutTests/ChangeLog 2019-01-22 20:52:53 UTC (rev 240277)
@@ -1,3 +1,14 @@
+2019-01-22 Devin Rousso
+
+Web Inspector: Audit: provide a way to get related Accessibility nodes for a given node
+https://bugs.webkit.org/show_bug.cgi?id=193225
+
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/audit/run-accessibility.html:
+* inspector/audit/run-accessibility-expected.txt:
+
2019-01-22 Simon Fraser
Fix the position of layers nested inside of composited overflow-scroll
Modified: trunk/LayoutTests/inspector/audit/run-accessibility-expected.txt (240276 => 240277)
--- trunk/LayoutTests/inspector/audit/run-accessibility-expected.txt 2019-01-22 20:51:27 UTC (rev 240276)
+++ trunk/LayoutTests/inspector/audit/run-accessibility-expected.txt 2019-01-22 20:52:53 UTC (rev 240277)
@@ -39,6 +39,102 @@
Result: []
Audit teardown...
+-- Running test case: Audit.run.Accessibility.getActiveDescendant.parent
+Audit setup...
+Audit run `WebInspectorAudit.Accessibility.getActiveDescendant(document.querySelector("#parent"))`...
+Result: #child
+Audit teardown...
+
+-- Running test case: Audit.run.Accessibility.getActiveDescendant.child
+Audit setup...
+Audit run `WebInspectorAudit.Accessibility.getActiveDescendant(document.querySelector("#child"))`...
+Result: null
+Audit teardown...
+
+-- Running test case: Audit.run.Accessibility.getChildNodes.parent
+Audit setup...
+Audit run `WebInspectorAudit.Accessibility.getChildNodes(document.querySelector("#parent"))`...
+Result: ["#child"]
+Audit teardown...
+
+-- Running test case: Audit.run.Accessibility.getChildNodes.child
+Audit setup...
+Audit run `WebInspectorAudit.Accessibility.getChildNodes(document.querySelector("#child"))`...
+Result: []
+Audit teardown...
+
+-- Running test case: Audit.run.Accessibility.getControlledNodes.parent
+Audit setup...
+Audit run `WebInspectorAudit.Accessibility.getControlledNodes(document.querySelector("#parent"))`...
+Result: ["#child"]
+Audit teardown...
+
+-- Running test case: Audit.run.Accessibility.getControlledNodes.child
+Audit setup...
+Audit run `WebInspectorAudit.Accessibility.getControlledNodes(document.querySelector("#child"))`...
+Result: []
+Audit teardown...
+
+-- Running test case: Audit.run.Accessibility.getFlowedNodes.parent
+Audit setup...
+Audit run `WebInspectorAudit.Accessibility.getFlowedNodes(document.querySelector("#parent"))`...
+Result: ["#child"]
+Audit teardown...
+
+-- Running test case: Audit.run.Accessibility.getFlowedNodes.child
+Audit setup...
+Audit run `WebInspectorAudit.Accessibility.getFlowedNodes(document.querySelector("#child"))`...
+Result: []
+Audit teardown...
+
+-- Running test case: Audit.run.Accessibility.getMouseEventNode.parent
+Audit setup...
+Audit run `WebInspectorAudit.Accessibility.getMouseEventNode(document.querySelector("#parent"))`...
+Result: #parent
+Audit teardown...
+
+-- Running test case: Audit.run.Accessibility.getMouseEventNode.child
+Audit setup...
+Audit run `WebInspectorAudit.Accessibility.getMouseEventNode(document.querySelector("#child"))`...
+Result: #parent
+Audit teardown...
+
+-- Running test case: Audit.run.Accessibility.getOwnedNodes.parent
+Audit setup...
+Audit run
[webkit-changes] [240276] tags/Safari-607.1.22.1/Source
Title: [240276] tags/Safari-607.1.22.1/Source Revision 240276 Author kocsen_ch...@apple.com Date 2019-01-22 12:51:27 -0800 (Tue, 22 Jan 2019) Log Message Versioning. Modified Paths tags/Safari-607.1.22.1/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-607.1.22.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig tags/Safari-607.1.22.1/Source/WebCore/Configurations/Version.xcconfig tags/Safari-607.1.22.1/Source/WebCore/PAL/Configurations/Version.xcconfig tags/Safari-607.1.22.1/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-607.1.22.1/Source/WebKit/Configurations/Version.xcconfig tags/Safari-607.1.22.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: tags/Safari-607.1.22.1/Source/_javascript_Core/Configurations/Version.xcconfig (240275 => 240276) --- tags/Safari-607.1.22.1/Source/_javascript_Core/Configurations/Version.xcconfig 2019-01-22 20:49:55 UTC (rev 240275) +++ tags/Safari-607.1.22.1/Source/_javascript_Core/Configurations/Version.xcconfig 2019-01-22 20:51:27 UTC (rev 240276) @@ -24,9 +24,9 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; TINY_VERSION = 22; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-607.1.22.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (240275 => 240276) --- tags/Safari-607.1.22.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-01-22 20:49:55 UTC (rev 240275) +++ tags/Safari-607.1.22.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-01-22 20:51:27 UTC (rev 240276) @@ -24,9 +24,9 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; TINY_VERSION = 22; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-607.1.22.1/Source/WebCore/Configurations/Version.xcconfig (240275 => 240276) --- tags/Safari-607.1.22.1/Source/WebCore/Configurations/Version.xcconfig 2019-01-22 20:49:55 UTC (rev 240275) +++ tags/Safari-607.1.22.1/Source/WebCore/Configurations/Version.xcconfig 2019-01-22 20:51:27 UTC (rev 240276) @@ -24,9 +24,9 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; TINY_VERSION = 22; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-607.1.22.1/Source/WebCore/PAL/Configurations/Version.xcconfig (240275 => 240276) --- tags/Safari-607.1.22.1/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-01-22 20:49:55 UTC (rev 240275) +++ tags/Safari-607.1.22.1/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-01-22 20:51:27 UTC (rev 240276) @@ -24,9 +24,9 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; TINY_VERSION = 22; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-607.1.22.1/Source/WebInspectorUI/Configurations/Version.xcconfig (240275 => 240276) --- tags/Safari-607.1.22.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-01-22 20:49:55 UTC (rev 240275) +++ tags/Safari-607.1.22.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-01-22 20:51:27 UTC (rev 240276) @@ -1,9 +1,9 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; TINY_VERSION = 22; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Modified: tags/Safari-607.1.22.1/Source/WebKit/Configurations/Version.xcconfig (240275 => 240276) --- tags/Safari-607.1.22.1/Source/WebKit/Configurations/Version.xcconfig 2019-01-22 20:49:55 UTC (rev 240275) +++ tags/Safari-607.1.22.1/Source/WebKit/Configurations/Version.xcconfig 2019-01-22 20:51:27 UTC (rev 240276) @@
[webkit-changes] [240275] trunk/Source/WebKit
Title: [240275] trunk/Source/WebKit
Revision 240275
Author ddkil...@apple.com
Date 2019-01-22 12:49:55 -0800 (Tue, 22 Jan 2019)
Log Message
C strings in ClientCertificateAuthenticationXPCConstants.h are duplicated
Reviewed by Alex Christensen.
* Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:
(WebKit::AuthenticationManager::initializeConnection):
* UIProcess/Authentication/cocoa/AuthenticationChallengeProxyCocoa.mm:
(WebKit::AuthenticationChallengeProxy::sendClientCertificateCredentialOverXpc):
- Update name of constants.
* Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.cpp: Copied from Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.h.
* Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.h:
- Put constant values in a namespace, and move values to
ClientCertificateAuthenticationXPCConstants.cpp.
* SourcesCocoa.txt:
* UnifiedSources-input.xcfilelist:
* WebKit.xcodeproj/project.pbxproj:
- Add ClientCertificateAuthenticationXPCConstants.cpp.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm
trunk/Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.h
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/UIProcess/Authentication/cocoa/AuthenticationChallengeProxyCocoa.mm
trunk/Source/WebKit/UnifiedSources-input.xcfilelist
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (240274 => 240275)
--- trunk/Source/WebKit/ChangeLog 2019-01-22 20:41:44 UTC (rev 240274)
+++ trunk/Source/WebKit/ChangeLog 2019-01-22 20:49:55 UTC (rev 240275)
@@ -1,5 +1,29 @@
2019-01-22 David Kilzer
+C strings in ClientCertificateAuthenticationXPCConstants.h are duplicated
+
+
+
+Reviewed by Alex Christensen.
+
+* Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:
+(WebKit::AuthenticationManager::initializeConnection):
+* UIProcess/Authentication/cocoa/AuthenticationChallengeProxyCocoa.mm:
+(WebKit::AuthenticationChallengeProxy::sendClientCertificateCredentialOverXpc):
+- Update name of constants.
+
+* Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.cpp: Copied from Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.h.
+* Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.h:
+- Put constant values in a namespace, and move values to
+ ClientCertificateAuthenticationXPCConstants.cpp.
+
+* SourcesCocoa.txt:
+* UnifiedSources-input.xcfilelist:
+* WebKit.xcodeproj/project.pbxproj:
+- Add ClientCertificateAuthenticationXPCConstants.cpp.
+
+2019-01-22 David Kilzer
+
Switch remaining QuickLook soft-linking in WebCore, WebKit over to QuickLookSoftLink.{cpp,h}
Modified: trunk/Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm (240274 => 240275)
--- trunk/Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm 2019-01-22 20:41:44 UTC (rev 240274)
+++ trunk/Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm 2019-01-22 20:49:55 UTC (rev 240275)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2018 Apple Inc. All rights reserved.
+ * Copyright (C) 2018-2019 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -56,16 +56,16 @@
if (type == XPC_TYPE_ERROR || !weakThis)
return;
-if (type != XPC_TYPE_DICTIONARY || strcmp(xpc_dictionary_get_string(event, clientCertificateAuthenticationXPCMessageNameKey), clientCertificateAuthenticationXPCMessageNameValue)) {
+if (type != XPC_TYPE_DICTIONARY || strcmp(xpc_dictionary_get_string(event, ClientCertificateAuthentication::XPCMessageNameKey), ClientCertificateAuthentication::XPCMessageNameValue)) {
ASSERT_NOT_REACHED();
return;
}
-auto challengeID = xpc_dictionary_get_uint64(event, clientCertificateAuthenticationXPCChallengeIDKey);
+auto challengeID = xpc_dictionary_get_uint64(event, ClientCertificateAuthentication::XPCChallengeIDKey);
if (!challengeID)
return;
-auto xpcEndPoint = xpc_dictionary_get_value(event, clientCertificateAuthenticationXPCSecKeyProxyEndpointKey);
+auto xpcEndPoint = xpc_dictionary_get_value(event, ClientCertificateAuthentication::XPCSecKeyProxyEndpointKey);
if (!xpcEndPoint || xpc_get_type(xpcEndPoint) != XPC_TYPE_ENDPOINT)
return;
auto endPoint = adoptNS([[NSXPCListenerEndpoint alloc] init]);
@@ -77,7 +77,7 @@
[webkit-changes] [240274] tags/Safari-607.1.22.1/
Title: [240274] tags/Safari-607.1.22.1/ Revision 240274 Author kocsen_ch...@apple.com Date 2019-01-22 12:41:44 -0800 (Tue, 22 Jan 2019) Log Message New tag. Added Paths tags/Safari-607.1.22.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240273] trunk/Source/JavaScriptCore
Title: [240273] trunk/Source/_javascript_Core Revision 240273 Author ysuz...@apple.com Date 2019-01-22 12:33:37 -0800 (Tue, 22 Jan 2019) Log Message [JSC] Intl constructors should fit in sizeof(InternalFunction) https://bugs.webkit.org/show_bug.cgi?id=193661 Reviewed by Mark Lam. Previously all the Intl constructors have their own subspace. This is because these constructors have different size from InternalFunction. But it is too costly approach in terms of the memory usage since these constructors are only one per JSGlobalObject. This patch attempts to reduce the memory size consumed by these Intl objects by holding instance structures in IntlObject instead of in each Intl constructors. So that we can make sizeof(Intl constructors) == sizeof(InternalFunction) and drop costly subspaces. Since this patch drops subspaces in VM, it also significantly reduces the sizeof(VM), from 76696 to 74680. This patch also includes the preparation for making Intl properties lazy. But currently it is not possible since @Collator reference exists in builtin code. * CMakeLists.txt: * DerivedSources.make: * runtime/IntlCollatorConstructor.cpp: (JSC::IntlCollatorConstructor::create): (JSC::IntlCollatorConstructor::finishCreation): (JSC::constructIntlCollator): (JSC::callIntlCollator): (JSC::IntlCollatorConstructor::visitChildren): Deleted. * runtime/IntlCollatorConstructor.h: * runtime/IntlDateTimeFormatConstructor.cpp: (JSC::IntlDateTimeFormatConstructor::create): (JSC::IntlDateTimeFormatConstructor::finishCreation): (JSC::constructIntlDateTimeFormat): (JSC::callIntlDateTimeFormat): (JSC::IntlDateTimeFormatConstructor::visitChildren): Deleted. * runtime/IntlDateTimeFormatConstructor.h: * runtime/IntlNumberFormatConstructor.cpp: (JSC::IntlNumberFormatConstructor::create): (JSC::IntlNumberFormatConstructor::finishCreation): (JSC::constructIntlNumberFormat): (JSC::callIntlNumberFormat): (JSC::IntlNumberFormatConstructor::visitChildren): Deleted. * runtime/IntlNumberFormatConstructor.h: * runtime/IntlObject.cpp: (JSC::createCollatorConstructor): (JSC::createNumberFormatConstructor): (JSC::createDateTimeFormatConstructor): (JSC::createPluralRulesConstructor): (JSC::IntlObject::create): (JSC::IntlObject::finishCreation): (JSC::IntlObject::visitChildren): * runtime/IntlObject.h: * runtime/IntlPluralRulesConstructor.cpp: (JSC::IntlPluralRulesConstructor::create): (JSC::IntlPluralRulesConstructor::finishCreation): (JSC::constructIntlPluralRules): (JSC::IntlPluralRulesConstructor::visitChildren): Deleted. * runtime/IntlPluralRulesConstructor.h: * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::visitChildren): * runtime/JSGlobalObject.h: (JSC::JSGlobalObject::intlObject const): * runtime/VM.cpp: (JSC::VM::VM): * runtime/VM.h: Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/DerivedSources.make trunk/Source/_javascript_Core/runtime/IntlCollatorConstructor.cpp trunk/Source/_javascript_Core/runtime/IntlCollatorConstructor.h trunk/Source/_javascript_Core/runtime/IntlDateTimeFormatConstructor.cpp trunk/Source/_javascript_Core/runtime/IntlDateTimeFormatConstructor.h trunk/Source/_javascript_Core/runtime/IntlNumberFormatConstructor.cpp trunk/Source/_javascript_Core/runtime/IntlNumberFormatConstructor.h trunk/Source/_javascript_Core/runtime/IntlObject.cpp trunk/Source/_javascript_Core/runtime/IntlObject.h trunk/Source/_javascript_Core/runtime/IntlPluralRulesConstructor.cpp trunk/Source/_javascript_Core/runtime/IntlPluralRulesConstructor.h trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp trunk/Source/_javascript_Core/runtime/JSGlobalObject.h trunk/Source/_javascript_Core/runtime/VM.cpp trunk/Source/_javascript_Core/runtime/VM.h Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (240272 => 240273) --- trunk/Source/_javascript_Core/CMakeLists.txt 2019-01-22 20:12:37 UTC (rev 240272) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2019-01-22 20:33:37 UTC (rev 240273) @@ -75,6 +75,7 @@ runtime/IntlDateTimeFormatPrototype.cpp runtime/IntlNumberFormatConstructor.cpp runtime/IntlNumberFormatPrototype.cpp +runtime/IntlObject.cpp runtime/IntlPluralRulesConstructor.cpp runtime/IntlPluralRulesPrototype.cpp runtime/JSDataViewPrototype.cpp Modified: trunk/Source/_javascript_Core/ChangeLog (240272 => 240273) --- trunk/Source/_javascript_Core/ChangeLog 2019-01-22 20:12:37 UTC (rev 240272) +++ trunk/Source/_javascript_Core/ChangeLog 2019-01-22 20:33:37 UTC (rev 240273) @@ -1,3 +1,66 @@ +2019-01-22 Yusuke Suzuki + +[JSC] Intl constructors should fit in sizeof(InternalFunction) +https://bugs.webkit.org/show_bug.cgi?id=193661 + +Reviewed by Mark Lam. + +Previously all the Intl constructors have their own subspace. This is because these constructors have different size from InternalFunction. +But it is too costly approach in terms of
[webkit-changes] [240272] trunk/Source
Title: [240272] trunk/Source
Revision 240272
Author ddkil...@apple.com
Date 2019-01-22 12:12:37 -0800 (Tue, 22 Jan 2019)
Log Message
Switch remaining QuickLook soft-linking in WebCore, WebKit over to QuickLookSoftLink.{cpp,h}
Reviewed by Alex Christensen.
- Moves QuickLookSoftLink.{h,mm} to PAL.
- Adds soft-link to 3 classes to consolidate QuickLook.framework
soft-linking.
- Updates existing source to work with above changes.
Source/WebCore:
* SourcesCocoa.txt:
* UnifiedSources-input.xcfilelist:
* WebCore.xcodeproj/project.pbxproj:
- Remove QuickLookSoftLink.{h,mm} due to move to PAL.
* platform/ios/QuickLook.mm:
(WebCore::QLPreviewGetSupportedMIMETypesSet):
(WebCore::registerQLPreviewConverterIfNeeded):
- Update for QuickLookSoftLink.{h,mm} move to PAL.
* platform/network/ios/PreviewConverter.mm:
(WebCore::optionsWithPassword):
(WebCore::PreviewConverter::PreviewConverter):
- Switch to using QuickLookSoftLink.{h,mm} in PAL.
* platform/network/ios/WebCoreURLResponseIOS.mm:
(WebCore::adjustMIMETypeIfNecessary):
- Update for QuickLookSoftLink.{h,mm} move to PAL.
Source/WebCore/PAL:
* PAL.xcodeproj/project.pbxproj:
- Add QuickLookSoftLink.{h,mm} due to move from WebCore.
* pal/ios/QuickLookSoftLink.h: Renamed from Source/WebCore/platform/ios/QuickLookSoftLink.h.
* pal/ios/QuickLookSoftLink.mm: Renamed from Source/WebCore/platform/ios/QuickLookSoftLink.mm.
- Add 3 classes for soft-linking.
- Change namespace from WebCore to PAL.
Source/WebKit:
* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
(-[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]):
(WebKit::SystemPreviewController::start):
* UIProcess/ios/WKSystemPreviewView.mm:
(-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]):
- Switch to using QuickLookSoftLink.{h,mm} in PAL.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/UnifiedSources-input.xcfilelist
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/ios/QuickLook.mm
trunk/Source/WebCore/platform/network/ios/PreviewConverter.mm
trunk/Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
trunk/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm
Added Paths
trunk/Source/WebCore/PAL/pal/ios/QuickLookSoftLink.h
trunk/Source/WebCore/PAL/pal/ios/QuickLookSoftLink.mm
Removed Paths
trunk/Source/WebCore/platform/ios/QuickLookSoftLink.h
trunk/Source/WebCore/platform/ios/QuickLookSoftLink.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (240271 => 240272)
--- trunk/Source/WebCore/ChangeLog 2019-01-22 19:55:00 UTC (rev 240271)
+++ trunk/Source/WebCore/ChangeLog 2019-01-22 20:12:37 UTC (rev 240272)
@@ -1,3 +1,35 @@
+2019-01-22 David Kilzer
+
+Switch remaining QuickLook soft-linking in WebCore, WebKit over to QuickLookSoftLink.{cpp,h}
+
+
+
+Reviewed by Alex Christensen.
+
+- Moves QuickLookSoftLink.{h,mm} to PAL.
+- Adds soft-link to 3 classes to consolidate QuickLook.framework
+ soft-linking.
+- Updates existing source to work with above changes.
+
+* SourcesCocoa.txt:
+* UnifiedSources-input.xcfilelist:
+* WebCore.xcodeproj/project.pbxproj:
+- Remove QuickLookSoftLink.{h,mm} due to move to PAL.
+
+* platform/ios/QuickLook.mm:
+(WebCore::QLPreviewGetSupportedMIMETypesSet):
+(WebCore::registerQLPreviewConverterIfNeeded):
+- Update for QuickLookSoftLink.{h,mm} move to PAL.
+
+* platform/network/ios/PreviewConverter.mm:
+(WebCore::optionsWithPassword):
+(WebCore::PreviewConverter::PreviewConverter):
+- Switch to using QuickLookSoftLink.{h,mm} in PAL.
+
+* platform/network/ios/WebCoreURLResponseIOS.mm:
+(WebCore::adjustMIMETypeIfNecessary):
+- Update for QuickLookSoftLink.{h,mm} move to PAL.
+
2019-01-22 Simon Fraser
Fix the position of layers nested inside of composited overflow-scroll
Modified: trunk/Source/WebCore/PAL/ChangeLog (240271 => 240272)
--- trunk/Source/WebCore/PAL/ChangeLog 2019-01-22 19:55:00 UTC (rev 240271)
+++ trunk/Source/WebCore/PAL/ChangeLog 2019-01-22 20:12:37 UTC (rev 240272)
@@ -1,3 +1,24 @@
+2019-01-22 David Kilzer
+
+Switch remaining QuickLook soft-linking in WebCore, WebKit over to QuickLookSoftLink.{cpp,h}
+
+
+
+Reviewed by Alex Christensen.
+
+- Moves QuickLookSoftLink.{h,mm} to PAL.
+- Adds soft-link to 3 classes to consolidate QuickLook.framework
+ soft-linking.
+- Updates existing source to work with above changes.
+
+* PAL.xcodeproj/project.pbxproj:
+- Add QuickLookSoftLink.{h,mm} due to move from WebCore.
+
+*
[webkit-changes] [240271] trunk
Title: [240271] trunk
Revision 240271
Author simon.fra...@apple.com
Date 2019-01-22 11:55:00 -0800 (Tue, 22 Jan 2019)
Log Message
Fix the position of layers nested inside of composited overflow-scroll
https://bugs.webkit.org/show_bug.cgi?id=193642
Reviewed by Antti Koivisto and Sam Weinig.
Source/WebCore:
Remove an iOS #ifdef so that layers inside composited overflow gets the correct
positions on macOS too.
Test: compositing/geometry/fixed-inside-overflow-scroll.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::computeParentGraphicsLayerRect const):
LayoutTests:
Ref test. Black bar obscures the area that's different because of overlay/non-overlay
scrollbar differences between macOS and iOS.
* compositing/geometry/fixed-inside-overflow-scroll-expected.html: Added.
* compositing/geometry/fixed-inside-overflow-scroll.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Added Paths
trunk/LayoutTests/compositing/geometry/fixed-inside-overflow-scroll-expected.html
trunk/LayoutTests/compositing/geometry/fixed-inside-overflow-scroll.html
Diff
Modified: trunk/LayoutTests/ChangeLog (240270 => 240271)
--- trunk/LayoutTests/ChangeLog 2019-01-22 19:54:05 UTC (rev 240270)
+++ trunk/LayoutTests/ChangeLog 2019-01-22 19:55:00 UTC (rev 240271)
@@ -1,3 +1,16 @@
+2019-01-22 Simon Fraser
+
+Fix the position of layers nested inside of composited overflow-scroll
+https://bugs.webkit.org/show_bug.cgi?id=193642
+
+Reviewed by Antti Koivisto and Sam Weinig.
+
+Ref test. Black bar obscures the area that's different because of overlay/non-overlay
+scrollbar differences between macOS and iOS.
+
+* compositing/geometry/fixed-inside-overflow-scroll-expected.html: Added.
+* compositing/geometry/fixed-inside-overflow-scroll.html: Added.
+
2019-01-22 Oriol Brufau
[css-logical] Implement flow-relative margin, padding and border shorthands
Added: trunk/LayoutTests/compositing/geometry/fixed-inside-overflow-scroll-expected.html (0 => 240271)
--- trunk/LayoutTests/compositing/geometry/fixed-inside-overflow-scroll-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/geometry/fixed-inside-overflow-scroll-expected.html 2019-01-22 19:55:00 UTC (rev 240271)
@@ -0,0 +1,70 @@
+
+
+
+
+
+body {
+margin: 0;
+}
+.container {
+position: relative;
+z-index: 0;
+margin: 50px;
+width: 400px;
+height: 320px;
+overflow-y: scroll;
+border: 30px solid gray;
+box-shadow: 0 0 10px transparent;
+padding: 20px;
+}
+
+.inner {
+position: relative;
+height: 1000px;
+width: 100%;
+background-color: silver;
+}
+
+.inner-fixed {
+position: absolute;
+top: 50px;
+left: 100px;
+width: 200px;
+height: 150px;
+background-color: green;
+box-shadow: 0 0 10px transparent;
+will-change: transform;
+}
+
+.placeholder {
+position: absolute;
+background-color: red;
+top: 50px;
+left: 100px;
+width: 200px;
+height: 148px;
+}
+
+.scrollbar-hider {
+position: absolute;
+height: 380px;
+width: 37px;
+top: 70px;
+left: 484px;
+background-color: black;
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Added: trunk/LayoutTests/compositing/geometry/fixed-inside-overflow-scroll.html (0 => 240271)
--- trunk/LayoutTests/compositing/geometry/fixed-inside-overflow-scroll.html (rev 0)
+++ trunk/LayoutTests/compositing/geometry/fixed-inside-overflow-scroll.html 2019-01-22 19:55:00 UTC (rev 240271)
@@ -0,0 +1,70 @@
+
+
+
+
+
+body {
+margin: 0;
+}
+.container {
+position: relative;
+z-index: 0;
+margin: 50px;
+width: 400px;
+height: 320px;
+overflow-y: scroll;
+border: 30px solid gray;
+box-shadow: 0 0 10px transparent;
+padding: 20px;
+}
+
+.inner {
+height: 1000px;
+width: 100%;
+background-color: silver;
+}
+
+.inner-fixed {
+position: fixed;
+top: 150px;
+left: 200px;
+width: 200px;
+height: 150px;
+background-color: green;
+box-shadow: 0 0 10px transparent;
+}
+
+.placeholder {
+background-color: red;
+width: 200px;
+height:
[webkit-changes] [240270] trunk/Source/WebInspectorUI
Title: [240270] trunk/Source/WebInspectorUI
Revision 240270
Author drou...@apple.com
Date 2019-01-22 11:54:05 -0800 (Tue, 22 Jan 2019)
Log Message
Web Inspector: Audit: use plural strings for Passed, Failed, and Unsupported
https://bugs.webkit.org/show_bug.cgi?id=193675
Reviewed by Joseph Pecoraro.
* UserInterface/Views/AuditTestGroupContentView.js:
(WI.AuditTestGroupContentView.prototype.layout):
* Localizations/en.lproj/localizedStrings.js:
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240269 => 240270)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-22 19:41:10 UTC (rev 240269)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-22 19:54:05 UTC (rev 240270)
@@ -1,3 +1,16 @@
+2019-01-22 Devin Rousso
+
+Web Inspector: Audit: use plural strings for Passed, Failed, and Unsupported
+https://bugs.webkit.org/show_bug.cgi?id=193675
+
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/AuditTestGroupContentView.js:
+(WI.AuditTestGroupContentView.prototype.layout):
+
+* Localizations/en.lproj/localizedStrings.js:
+
2019-01-18 Jer Noble
SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (240269 => 240270)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-01-22 19:41:10 UTC (rev 240269)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-01-22 19:54:05 UTC (rev 240270)
@@ -25,13 +25,16 @@
localizedStrings["%d Error"] = "%d Error";
localizedStrings["%d Errors"] = "%d Errors";
localizedStrings["%d Errors, %d Warnings"] = "%d Errors, %d Warnings";
-localizedStrings["%d Failed"] = "%d Failed";
+localizedStrings["%d Failed (plural)"] = "%d Failed";
+localizedStrings["%d Failed (singular)"] = "%d Failed";
localizedStrings["%d Frame"] = "%d Frame";
localizedStrings["%d Frames"] = "%d Frames";
localizedStrings["%d More\u2026"] = "%d More\u2026";
-localizedStrings["%d Passed"] = "%d Passed";
+localizedStrings["%d Passed (plural)"] = "%d Passed";
+localizedStrings["%d Passed (singular)"] = "%d Passed";
localizedStrings["%d Threads"] = "%d Threads";
-localizedStrings["%d Unsupported"] = "%d Unsupported";
+localizedStrings["%d Unsupported (plural)"] = "%d Unsupported";
+localizedStrings["%d Unsupported (singular)"] = "%d Unsupported";
localizedStrings["%d Warning"] = "%d Warning";
localizedStrings["%d Warnings"] = "%d Warnings";
localizedStrings["%d \xd7 %d pixels"] = "%d \xd7 %d pixels";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js (240269 => 240270)
--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js 2019-01-22 19:41:10 UTC (rev 240269)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js 2019-01-22 19:54:05 UTC (rev 240270)
@@ -122,11 +122,11 @@
scopeBarItems.push(scopeBarItem);
};
-addScopeBarItem(WI.AuditTestCaseResult.Level.Pass, WI.UIString("%d Passed"));
+addScopeBarItem(WI.AuditTestCaseResult.Level.Pass, WI.UIString("%d Passed", "%d Passed (singular)"), WI.UIString("%d Passed", "%d Passed (plural)"));
addScopeBarItem(WI.AuditTestCaseResult.Level.Warn, WI.UIString("%d Warning"), WI.UIString("%d Warnings"));
-addScopeBarItem(WI.AuditTestCaseResult.Level.Fail, WI.UIString("%d Failed"));
+addScopeBarItem(WI.AuditTestCaseResult.Level.Fail, WI.UIString("%d Failed", "%d Failed (singular)"), WI.UIString("%d Failed", "%d Failed (plural)"));
addScopeBarItem(WI.AuditTestCaseResult.Level.Error, WI.UIString("%d Error"), WI.UIString("%d Errors"));
-addScopeBarItem(WI.AuditTestCaseResult.Level.Unsupported, WI.UIString("%d Unsupported"));
+addScopeBarItem(WI.AuditTestCaseResult.Level.Unsupported, WI.UIString("%d Unsupported", "%d Unsupported (singular)"), WI.UIString("%d Unsupported", "%d Unsupported (plural)"));
this._levelScopeBar = new WI.ScopeBar(null, scopeBarItems);
this._levelScopeBar.addEventListener(WI.ScopeBar.Event.SelectionChanged, this._handleLevelScopeBarSelectionChanged, this);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240269] trunk
Title: [240269] trunk
Revision 240269
Author sbar...@apple.com
Date 2019-01-22 11:41:10 -0800 (Tue, 22 Jan 2019)
Log Message
Unreviewed. Rollout r240223. It regressed JetStream2 by 1%.
JSTests:
* stress/arith-abs-to-arith-negate-range-optimizaton.js:
(testUncheckedBetweenIntMinInclusiveAndZeroExclusive):
(testUncheckedLessThanZero):
(testUncheckedLessThanOrEqualZero):
* stress/movhint-backwards-propagation-must-merge-use-as-value-add.js: Removed.
* stress/movhint-backwards-propagation-must-merge-use-as-value.js: Removed.
Source/_javascript_Core:
* dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/arith-abs-to-arith-negate-range-optimizaton.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGBackwardsPropagationPhase.cpp
Removed Paths
trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value-add.js
trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value.js
Diff
Modified: trunk/JSTests/ChangeLog (240268 => 240269)
--- trunk/JSTests/ChangeLog 2019-01-22 19:06:42 UTC (rev 240268)
+++ trunk/JSTests/ChangeLog 2019-01-22 19:41:10 UTC (rev 240269)
@@ -1,3 +1,14 @@
+2019-01-22 Saam Barati
+
+Unreviewed. Rollout r240223. It regressed JetStream2 by 1%.
+
+* stress/arith-abs-to-arith-negate-range-optimizaton.js:
+(testUncheckedBetweenIntMinInclusiveAndZeroExclusive):
+(testUncheckedLessThanZero):
+(testUncheckedLessThanOrEqualZero):
+* stress/movhint-backwards-propagation-must-merge-use-as-value-add.js: Removed.
+* stress/movhint-backwards-propagation-must-merge-use-as-value.js: Removed.
+
2019-01-22 Yusuke Suzuki
[JSC] Invalidate old scope operations using global lexical binding epoch
Modified: trunk/JSTests/stress/arith-abs-to-arith-negate-range-optimizaton.js (240268 => 240269)
--- trunk/JSTests/stress/arith-abs-to-arith-negate-range-optimizaton.js 2019-01-22 19:06:42 UTC (rev 240268)
+++ trunk/JSTests/stress/arith-abs-to-arith-negate-range-optimizaton.js 2019-01-22 19:41:10 UTC (rev 240269)
@@ -233,7 +233,7 @@
throw "Failed testUncheckedBetweenIntMinInclusiveAndZeroExclusive() on -2147483648";
}
}
-if (numberOfDFGCompiles(opaqueUncheckedBetweenIntMinInclusiveAndZeroExclusive) > 2) {
+if (numberOfDFGCompiles(opaqueUncheckedBetweenIntMinInclusiveAndZeroExclusive) > 1) {
throw "Failed optimizing testUncheckedBetweenIntMinInclusiveAndZeroExclusive(). None of the tested case need to OSR Exit.";
}
}
@@ -376,7 +376,7 @@
throw "Failed testUncheckedLessThanOrEqualZero() on -2147483648";
}
}
-if (numberOfDFGCompiles(opaqueUncheckedLessThanZero) > 2) {
+if (numberOfDFGCompiles(opaqueUncheckedLessThanZero) > 1) {
throw "Failed optimizing testUncheckedLessThanZero(). None of the tested case need to OSR Exit.";
}
@@ -420,7 +420,7 @@
throw "Failed testUncheckedLessThanOrEqualZero() on -2147483648";
}
}
-if (numberOfDFGCompiles(opaqueUncheckedLessThanOrEqualZero) > 2) {
+if (numberOfDFGCompiles(opaqueUncheckedLessThanOrEqualZero) > 1) {
throw "Failed optimizing testUncheckedLessThanOrEqualZero(). None of the tested case need to OSR Exit.";
}
}
Deleted: trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value-add.js (240268 => 240269)
--- trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value-add.js 2019-01-22 19:06:42 UTC (rev 240268)
+++ trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value-add.js 2019-01-22 19:41:10 UTC (rev 240269)
@@ -1,16 +0,0 @@
-function foo(v, a, b) {
-if (v) {
-let r = a + b;
-OSRExit();
-return r;
-}
-}
-noInline(foo);
-
-for (let i = 0; i < 1; ++i) {
-let r = foo(true, 4, 4);
-if (r !== 8)
-throw new Error("Bad!");
-}
-if (foo(true, 2**31 - 1, 1) !== 2**31)
-throw new Error("Bad!");
Deleted: trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value.js (240268 => 240269)
--- trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value.js 2019-01-22 19:06:42 UTC (rev 240268)
+++ trunk/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value.js 2019-01-22 19:41:10 UTC (rev 240269)
@@ -1,16 +0,0 @@
-function foo(v, a, b) {
-if (v) {
-let r = a / b;
-OSRExit();
-return r;
-}
-}
-noInline(foo);
-
-for (let i = 0; i < 1; ++i) {
-let r = foo(true, 4, 4);
-if (r !== 1)
-throw new Error("Bad!");
-}
-if (foo(true, 1, 4) !== 0.25)
-throw new Error("Bad!");
Modified: trunk/Source/_javascript_Core/ChangeLog (240268 => 240269)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-22 19:06:42 UTC (rev 240268)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-22 19:41:10 UTC (rev 240269)
@@
[webkit-changes] [240268] trunk/Source/WebCore
Title: [240268] trunk/Source/WebCore
Revision 240268
Author csaave...@igalia.com
Date 2019-01-22 11:06:42 -0800 (Tue, 22 Jan 2019)
Log Message
[GTK] Build fix for Ubuntu LTS 16.04
https://bugs.webkit.org/show_bug.cgi?id=193672
Unreviewed build fix.
* html/canvas/CanvasStyle.h: Add default copy constructor for
CMYKAColor struct.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasStyle.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (240267 => 240268)
--- trunk/Source/WebCore/ChangeLog 2019-01-22 19:03:53 UTC (rev 240267)
+++ trunk/Source/WebCore/ChangeLog 2019-01-22 19:06:42 UTC (rev 240268)
@@ -1,3 +1,13 @@
+2019-01-22 Claudio Saavedra
+
+[GTK] Build fix for Ubuntu LTS 16.04
+https://bugs.webkit.org/show_bug.cgi?id=193672
+
+Unreviewed build fix.
+
+* html/canvas/CanvasStyle.h: Add default copy constructor for
+CMYKAColor struct.
+
2019-01-22 David Kilzer
Leak of NSMutableArray (128 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
Modified: trunk/Source/WebCore/html/canvas/CanvasStyle.h (240267 => 240268)
--- trunk/Source/WebCore/html/canvas/CanvasStyle.h 2019-01-22 19:03:53 UTC (rev 240267)
+++ trunk/Source/WebCore/html/canvas/CanvasStyle.h 2019-01-22 19:06:42 UTC (rev 240268)
@@ -76,6 +76,8 @@
float y { 0 };
float k { 0 };
float a { 0 };
+
+CMYKAColor(const CMYKAColor&) = default;
};
struct CurrentColor {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240267] tags/Safari-608.1.1.1/Source
Title: [240267] tags/Safari-608.1.1.1/Source Revision 240267 Author alanc...@apple.com Date 2019-01-22 11:03:53 -0800 (Tue, 22 Jan 2019) Log Message Versioning. Modified Paths tags/Safari-608.1.1.1/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-608.1.1.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig tags/Safari-608.1.1.1/Source/WebCore/Configurations/Version.xcconfig tags/Safari-608.1.1.1/Source/WebCore/PAL/Configurations/Version.xcconfig tags/Safari-608.1.1.1/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-608.1.1.1/Source/WebKit/Configurations/Version.xcconfig tags/Safari-608.1.1.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: tags/Safari-608.1.1.1/Source/_javascript_Core/Configurations/Version.xcconfig (240266 => 240267) --- tags/Safari-608.1.1.1/Source/_javascript_Core/Configurations/Version.xcconfig 2019-01-22 18:54:01 UTC (rev 240266) +++ tags/Safari-608.1.1.1/Source/_javascript_Core/Configurations/Version.xcconfig 2019-01-22 19:03:53 UTC (rev 240267) @@ -24,9 +24,9 @@ MAJOR_VERSION = 608; MINOR_VERSION = 1; TINY_VERSION = 1; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-608.1.1.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (240266 => 240267) --- tags/Safari-608.1.1.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-01-22 18:54:01 UTC (rev 240266) +++ tags/Safari-608.1.1.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-01-22 19:03:53 UTC (rev 240267) @@ -24,9 +24,9 @@ MAJOR_VERSION = 608; MINOR_VERSION = 1; TINY_VERSION = 1; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-608.1.1.1/Source/WebCore/Configurations/Version.xcconfig (240266 => 240267) --- tags/Safari-608.1.1.1/Source/WebCore/Configurations/Version.xcconfig 2019-01-22 18:54:01 UTC (rev 240266) +++ tags/Safari-608.1.1.1/Source/WebCore/Configurations/Version.xcconfig 2019-01-22 19:03:53 UTC (rev 240267) @@ -24,9 +24,9 @@ MAJOR_VERSION = 608; MINOR_VERSION = 1; TINY_VERSION = 1; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-608.1.1.1/Source/WebCore/PAL/Configurations/Version.xcconfig (240266 => 240267) --- tags/Safari-608.1.1.1/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-01-22 18:54:01 UTC (rev 240266) +++ tags/Safari-608.1.1.1/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-01-22 19:03:53 UTC (rev 240267) @@ -24,9 +24,9 @@ MAJOR_VERSION = 608; MINOR_VERSION = 1; TINY_VERSION = 1; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-608.1.1.1/Source/WebInspectorUI/Configurations/Version.xcconfig (240266 => 240267) --- tags/Safari-608.1.1.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-01-22 18:54:01 UTC (rev 240266) +++ tags/Safari-608.1.1.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-01-22 19:03:53 UTC (rev 240267) @@ -1,9 +1,9 @@ MAJOR_VERSION = 608; MINOR_VERSION = 1; TINY_VERSION = 1; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Modified: tags/Safari-608.1.1.1/Source/WebKit/Configurations/Version.xcconfig (240266 => 240267) --- tags/Safari-608.1.1.1/Source/WebKit/Configurations/Version.xcconfig 2019-01-22 18:54:01 UTC (rev 240266) +++ tags/Safari-608.1.1.1/Source/WebKit/Configurations/Version.xcconfig 2019-01-22 19:03:53 UTC (rev 240267) @@ -24,9 +24,9 @@ MAJOR_VERSION = 608;
[webkit-changes] [240266] tags/Safari-608.1.1.1/
Title: [240266] tags/Safari-608.1.1.1/ Revision 240266 Author alanc...@apple.com Date 2019-01-22 10:54:01 -0800 (Tue, 22 Jan 2019) Log Message New tag. Added Paths tags/Safari-608.1.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240265] branches/safari-607-branch/Source
Title: [240265] branches/safari-607-branch/Source Revision 240265 Author alanc...@apple.com Date 2019-01-22 10:42:37 -0800 (Tue, 22 Jan 2019) Log Message Versioning. Modified Paths branches/safari-607-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-607-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-607-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-607-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-607-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-607-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-607-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-607-branch/Source/_javascript_Core/Configurations/Version.xcconfig (240264 => 240265) --- branches/safari-607-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2019-01-22 18:34:54 UTC (rev 240264) +++ branches/safari-607-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2019-01-22 18:42:37 UTC (rev 240265) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 25; +TINY_VERSION = 26; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-607-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (240264 => 240265) --- branches/safari-607-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-01-22 18:34:54 UTC (rev 240264) +++ branches/safari-607-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-01-22 18:42:37 UTC (rev 240265) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 25; +TINY_VERSION = 26; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-607-branch/Source/WebCore/Configurations/Version.xcconfig (240264 => 240265) --- branches/safari-607-branch/Source/WebCore/Configurations/Version.xcconfig 2019-01-22 18:34:54 UTC (rev 240264) +++ branches/safari-607-branch/Source/WebCore/Configurations/Version.xcconfig 2019-01-22 18:42:37 UTC (rev 240265) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 25; +TINY_VERSION = 26; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-607-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (240264 => 240265) --- branches/safari-607-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-01-22 18:34:54 UTC (rev 240264) +++ branches/safari-607-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-01-22 18:42:37 UTC (rev 240265) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 25; +TINY_VERSION = 26; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-607-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (240264 => 240265) --- branches/safari-607-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-01-22 18:34:54 UTC (rev 240264) +++ branches/safari-607-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-01-22 18:42:37 UTC (rev 240265) @@ -1,6 +1,6 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 25; +TINY_VERSION = 26; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-607-branch/Source/WebKit/Configurations/Version.xcconfig (240264 => 240265) --- branches/safari-607-branch/Source/WebKit/Configurations/Version.xcconfig 2019-01-22 18:34:54 UTC (rev 240264) +++ branches/safari-607-branch/Source/WebKit/Configurations/Version.xcconfig 2019-01-22 18:42:37 UTC (rev 240265) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 25; +TINY_VERSION = 26; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-607-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (240264 => 240265) --- branches/safari-607-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2019-01-22 18:34:54 UTC (rev 240264) +++ branches/safari-607-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2019-01-22 18:42:37 UTC (rev 240265) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 25; +TINY_VERSION = 26; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240260] branches/safari-607-branch/Source
Title: [240260] branches/safari-607-branch/Source
Revision 240260
Author alanc...@apple.com
Date 2019-01-22 10:34:24 -0800 (Tue, 22 Jan 2019)
Log Message
Cherry-pick r239997. rdar://problem/47099573
Fix iOS build after r239993
https://bugs.webkit.org/show_bug.cgi?id=193361
Source/WebKit:
* UIProcess/ProvisionalPageProxy.h:
* UIProcess/SuspendedPageProxy.h:
Source/WTF:
* wtf/RefCounter.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/WTF/ChangeLog
branches/safari-607-branch/Source/WTF/wtf/RefCounter.h
branches/safari-607-branch/Source/WebKit/ChangeLog
branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h
branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h
Diff
Modified: branches/safari-607-branch/Source/WTF/ChangeLog (240259 => 240260)
--- branches/safari-607-branch/Source/WTF/ChangeLog 2019-01-22 18:34:21 UTC (rev 240259)
+++ branches/safari-607-branch/Source/WTF/ChangeLog 2019-01-22 18:34:24 UTC (rev 240260)
@@ -1,3 +1,30 @@
+2019-01-22 Alan Coon
+
+Cherry-pick r239997. rdar://problem/47099573
+
+Fix iOS build after r239993
+https://bugs.webkit.org/show_bug.cgi?id=193361
+
+Source/WebKit:
+
+* UIProcess/ProvisionalPageProxy.h:
+* UIProcess/SuspendedPageProxy.h:
+
+Source/WTF:
+
+* wtf/RefCounter.h:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-15 Alex Christensen
+
+Fix iOS build after r239993
+https://bugs.webkit.org/show_bug.cgi?id=193361
+
+* wtf/RefCounter.h:
+
2019-01-15 Alan Coon
Cherry-pick r239904. rdar://problem/4726030
Modified: branches/safari-607-branch/Source/WTF/wtf/RefCounter.h (240259 => 240260)
--- branches/safari-607-branch/Source/WTF/wtf/RefCounter.h 2019-01-22 18:34:21 UTC (rev 240259)
+++ branches/safari-607-branch/Source/WTF/wtf/RefCounter.h 2019-01-22 18:34:24 UTC (rev 240260)
@@ -65,6 +65,7 @@
using ValueChangeFunction = WTF::Function;
RefCounter(ValueChangeFunction&& = nullptr);
+RefCounter(RefCounter&&) = default;
~RefCounter();
Token count() const
Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240259 => 240260)
--- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-22 18:34:21 UTC (rev 240259)
+++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-22 18:34:24 UTC (rev 240260)
@@ -1,5 +1,33 @@
2019-01-22 Alan Coon
+Cherry-pick r239997. rdar://problem/47099573
+
+Fix iOS build after r239993
+https://bugs.webkit.org/show_bug.cgi?id=193361
+
+Source/WebKit:
+
+* UIProcess/ProvisionalPageProxy.h:
+* UIProcess/SuspendedPageProxy.h:
+
+Source/WTF:
+
+* wtf/RefCounter.h:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-15 Alex Christensen
+
+Fix iOS build after r239993
+https://bugs.webkit.org/show_bug.cgi?id=193361
+
+* UIProcess/ProvisionalPageProxy.h:
+* UIProcess/SuspendedPageProxy.h:
+
+2019-01-22 Alan Coon
+
Cherry-pick r239995. rdar://problem/47099573
Unreviewed iOS build fix after r239993.
Modified: branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h (240259 => 240260)
--- branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h 2019-01-22 18:34:21 UTC (rev 240259)
+++ branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h 2019-01-22 18:34:24 UTC (rev 240260)
@@ -88,7 +88,7 @@
URL m_provisionalLoadURL;
#if PLATFORM(IOS_FAMILY)
-ProcessThrottler::BackgroundActivityToken m_suspensionToken;
+ProcessThrottler::ForegroundActivityToken m_suspensionToken;
#endif
};
Modified: branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h (240259 => 240260)
--- branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h 2019-01-22 18:34:21 UTC (rev 240259)
+++ branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h 2019-01-22 18:34:24 UTC (rev 240260)
@@ -72,7 +72,7 @@
SuspensionState m_suspensionState { SuspensionState::Suspending };
CompletionHandler m_readyToUnsuspendHandler;
#if PLATFORM(IOS_FAMILY)
-ProcessThrottler::ForegroundActivityToken m_suspensionToken;
+ProcessThrottler::BackgroundActivityToken m_suspensionToken;
#endif
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240262] branches/safari-607-branch
Title: [240262] branches/safari-607-branch Revision 240262 Author alanc...@apple.com Date 2019-01-22 10:34:34 -0800 (Tue, 22 Jan 2019) Log Message Cherry-pick r240015. rdar://problem/47099573 Unreviewed, rolling out r239993, r239995, r239997, and r23. Caused assertions under ViewGestureController::disconnectFromProcess() Reverted changesets: "Regression(PSON) View becomes blank after click a cross-site download link" https://bugs.webkit.org/show_bug.cgi?id=193361 https://trac.webkit.org/changeset/239993 "Unreviewed iOS build fix after r239993." https://trac.webkit.org/changeset/239995 "Fix iOS build after r239993" https://bugs.webkit.org/show_bug.cgi?id=193361 https://trac.webkit.org/changeset/239997 "Unreviewed, revert part of r239997 as it is not needed to fix the build." https://trac.webkit.org/changeset/23 git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240015 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/LayoutTests/ChangeLog branches/safari-607-branch/LayoutTests/platform/wk2/TestExpectations branches/safari-607-branch/Source/WebCore/ChangeLog branches/safari-607-branch/Source/WebCore/loader/FrameLoader.cpp branches/safari-607-branch/Source/WebKit/ChangeLog branches/safari-607-branch/Source/WebKit/Shared/WebPageCreationParameters.cpp branches/safari-607-branch/Source/WebKit/Shared/WebPageCreationParameters.h branches/safari-607-branch/Source/WebKit/Shared/WebPolicyAction.h branches/safari-607-branch/Source/WebKit/Sources.txt branches/safari-607-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm branches/safari-607-branch/Source/WebKit/UIProcess/PageClient.h branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebFrameProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebPageProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebPageProxy.h branches/safari-607-branch/Source/WebKit/UIProcess/WebProcessProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/WebProcessProxy.h branches/safari-607-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebPage.h branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm branches/safari-607-branch/Tools/ChangeLog branches/safari-607-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Removed Paths branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp branches/safari-607-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.h Diff Modified: branches/safari-607-branch/LayoutTests/ChangeLog (240261 => 240262) --- branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-22 18:34:26 UTC (rev 240261) +++ branches/safari-607-branch/LayoutTests/ChangeLog 2019-01-22 18:34:34 UTC (rev 240262) @@ -1,5 +1,61 @@ 2019-01-22 Alan Coon +Cherry-pick r240015. rdar://problem/47099573 + +Unreviewed, rolling out r239993, r239995, r239997, and +r23. + +Caused assertions under +ViewGestureController::disconnectFromProcess() + +Reverted changesets: + +"Regression(PSON) View becomes blank after click a cross-site +download link" +https://bugs.webkit.org/show_bug.cgi?id=193361 +https://trac.webkit.org/changeset/239993 + +"Unreviewed iOS build fix after r239993." +https://trac.webkit.org/changeset/239995 + +"Fix iOS build after r239993" +https://bugs.webkit.org/show_bug.cgi?id=193361 +https://trac.webkit.org/changeset/239997 + +"Unreviewed, revert part of r239997 as it is not needed to fix +the build." +https://trac.webkit.org/changeset/23 + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240015 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-15 Chris Dumez + +Unreviewed, rolling out r239993, r239995, r239997, and +r23. + +Caused assertions under +ViewGestureController::disconnectFromProcess() + +Reverted changesets: + +"Regression(PSON) View becomes blank after click a cross-site +download link" +https://bugs.webkit.org/show_bug.cgi?id=193361 +https://trac.webkit.org/changeset/239993 + +"Unreviewed iOS build fix after r239993." +https://trac.webkit.org/changeset/239995 + +"Fix iOS build after r239993" +https://bugs.webkit.org/show_bug.cgi?id=193361 +https://trac.webkit.org/changeset/239997 + +"Unreviewed, revert part of r239997 as it is not needed to fix +the build." +https://trac.webkit.org/changeset/23 +
[webkit-changes] [240264] branches/safari-607-branch/Source/WebKit
Title: [240264] branches/safari-607-branch/Source/WebKit Revision 240264 Author alanc...@apple.com Date 2019-01-22 10:34:54 -0800 (Tue, 22 Jan 2019) Log Message Cherry-pick r240055. rdar://problem/47099573 Regression(r240046) Several API tests are crashing https://bugs.webkit.org/show_bug.cgi?id=193509 Reviewed by Geoffrey Garen. The crashes would happen because loadRequestShared() would take a WebProcessProxy& in parameter but then call reattachToWebProcess() if the page is not valid, which would replace m_process and invalidate our process reference. To address the issue, move the reattachToWebProcess() call to loadRequest(), before calling loadRequestShared(). Also, update *Shared() methods to take a Ref&& instead of a WebProcessProxy& in parameter. Since we call client delegates, we need to make sure our process stays alive. * UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::loadData): (WebKit::ProvisionalPageProxy::loadRequest): (WebKit::ProvisionalPageProxy::didCreateMainFrame): (WebKit::ProvisionalPageProxy::didPerformClientRedirect): (WebKit::ProvisionalPageProxy::didStartProvisionalLoadForFrame): (WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame): (WebKit::ProvisionalPageProxy::didNavigateWithNavigationData): (WebKit::ProvisionalPageProxy::didChangeProvisionalURLForFrame): (WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync): (WebKit::ProvisionalPageProxy::decidePolicyForResponse): (WebKit::ProvisionalPageProxy::startURLSchemeTask): (WebKit::ProvisionalPageProxy::backForwardGoToItem): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadRequest): (WebKit::WebPageProxy::loadRequestWithNavigationShared): (WebKit::WebPageProxy::loadData): (WebKit::WebPageProxy::loadDataWithNavigationShared): (WebKit::WebPageProxy::didPerformDragControllerAction): (WebKit::WebPageProxy::findPlugin): (WebKit::WebPageProxy::didCreateMainFrame): (WebKit::WebPageProxy::didCreateSubframe): (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared): (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame): (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrameShared): (WebKit::WebPageProxy::willPerformClientRedirectForFrame): (WebKit::WebPageProxy::didCancelClientRedirectForFrame): (WebKit::WebPageProxy::didChangeProvisionalURLForFrame): (WebKit::WebPageProxy::didChangeProvisionalURLForFrameShared): (WebKit::WebPageProxy::didFailProvisionalLoadForFrame): (WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared): (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::didFinishDocumentLoadForFrame): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::didSameDocumentNavigationForFrame): (WebKit::WebPageProxy::didReceiveTitleForFrame): (WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame): (WebKit::WebPageProxy::didDisplayInsecureContentForFrame): (WebKit::WebPageProxy::didRunInsecureContentForFrame): (WebKit::WebPageProxy::frameDidBecomeFrameSet): (WebKit::WebPageProxy::decidePolicyForNavigationActionAsync): (WebKit::WebPageProxy::decidePolicyForNavigationActionAsyncShared): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNavigationActionSync): (WebKit::WebPageProxy::decidePolicyForNewWindowAction): (WebKit::WebPageProxy::decidePolicyForResponse): (WebKit::WebPageProxy::decidePolicyForResponseShared): (WebKit::WebPageProxy::unableToImplementPolicy): (WebKit::WebPageProxy::willSubmitForm): (WebKit::WebPageProxy::didNavigateWithNavigationData): (WebKit::WebPageProxy::didNavigateWithNavigationDataShared): (WebKit::WebPageProxy::didPerformClientRedirect): (WebKit::WebPageProxy::didPerformClientRedirectShared): (WebKit::WebPageProxy::didPerformServerRedirect): (WebKit::WebPageProxy::didUpdateHistoryTitle): (WebKit::WebPageProxy::createNewPage): (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt): (WebKit::WebPageProxy::unavailablePluginButtonClicked): (WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): (WebKit::WebPageProxy::runOpenPanel): (WebKit::WebPageProxy::printFrame): (WebKit::WebPageProxy::backForwardGoToItem): (WebKit::WebPageProxy::backForwardGoToItemShared): (WebKit::WebPageProxy::learnWord): (WebKit::WebPageProxy::ignoreWord): (WebKit::WebPageProxy::didReceiveEvent): (WebKit::WebPageProxy::editingRangeCallback): (WebKit::WebPageProxy::rectForCharacterRangeCallback): (WebKit::WebPageProxy::focusedFrameChanged):
[webkit-changes] [240259] branches/safari-607-branch/Source/WebKit
Title: [240259] branches/safari-607-branch/Source/WebKit
Revision 240259
Author alanc...@apple.com
Date 2019-01-22 10:34:21 -0800 (Tue, 22 Jan 2019)
Log Message
Cherry-pick r239995. rdar://problem/47099573
Unreviewed iOS build fix after r239993.
* UIProcess/SuspendedPageProxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-607-branch/Source/WebKit/ChangeLog
branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h
Diff
Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (240258 => 240259)
--- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-22 18:34:17 UTC (rev 240258)
+++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-01-22 18:34:21 UTC (rev 240259)
@@ -1,5 +1,21 @@
2019-01-22 Alan Coon
+Cherry-pick r239995. rdar://problem/47099573
+
+Unreviewed iOS build fix after r239993.
+
+* UIProcess/SuspendedPageProxy.h:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-01-15 Chris Dumez
+
+Unreviewed iOS build fix after r239993.
+
+* UIProcess/SuspendedPageProxy.h:
+
+2019-01-22 Alan Coon
+
Cherry-pick r239993. rdar://problem/47099573
Regression(PSON) View becomes blank after click a cross-site download link
Modified: branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h (240258 => 240259)
--- branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h 2019-01-22 18:34:17 UTC (rev 240258)
+++ branches/safari-607-branch/Source/WebKit/UIProcess/SuspendedPageProxy.h 2019-01-22 18:34:21 UTC (rev 240259)
@@ -72,7 +72,7 @@
SuspensionState m_suspensionState { SuspensionState::Suspending };
CompletionHandler m_readyToUnsuspendHandler;
#if PLATFORM(IOS_FAMILY)
-ProcessThrottler::BackgroundActivityToken m_suspensionToken;
+ProcessThrottler::ForegroundActivityToken m_suspensionToken;
#endif
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240261] branches/safari-607-branch/Source/WTF
Title: [240261] branches/safari-607-branch/Source/WTF Revision 240261 Author alanc...@apple.com Date 2019-01-22 10:34:26 -0800 (Tue, 22 Jan 2019) Log Message Cherry-pick r23. rdar://problem/47099573 Unreviewed, revert part of r239997 as it is not needed to fix the build. * wtf/RefCounter.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-607-branch/Source/WTF/ChangeLog branches/safari-607-branch/Source/WTF/wtf/RefCounter.h Diff Modified: branches/safari-607-branch/Source/WTF/ChangeLog (240260 => 240261) --- branches/safari-607-branch/Source/WTF/ChangeLog 2019-01-22 18:34:24 UTC (rev 240260) +++ branches/safari-607-branch/Source/WTF/ChangeLog 2019-01-22 18:34:26 UTC (rev 240261) @@ -1,5 +1,21 @@ 2019-01-22 Alan Coon +Cherry-pick r23. rdar://problem/47099573 + +Unreviewed, revert part of r239997 as it is not needed to fix the build. + +* wtf/RefCounter.h: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-01-15 Chris Dumez + +Unreviewed, revert part of r239997 as it is not needed to fix the build. + +* wtf/RefCounter.h: + +2019-01-22 Alan Coon + Cherry-pick r239997. rdar://problem/47099573 Fix iOS build after r239993 Modified: branches/safari-607-branch/Source/WTF/wtf/RefCounter.h (240260 => 240261) --- branches/safari-607-branch/Source/WTF/wtf/RefCounter.h 2019-01-22 18:34:24 UTC (rev 240260) +++ branches/safari-607-branch/Source/WTF/wtf/RefCounter.h 2019-01-22 18:34:26 UTC (rev 240261) @@ -65,7 +65,6 @@ using ValueChangeFunction = WTF::Function; RefCounter(ValueChangeFunction&& = nullptr); -RefCounter(RefCounter&&) = default; ~RefCounter(); Token count() const ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240257] trunk/Source/JavaScriptCore
Title: [240257] trunk/Source/_javascript_Core
Revision 240257
Author tzaga...@apple.com
Date 2019-01-22 10:33:18 -0800 (Tue, 22 Jan 2019)
Log Message
Unreviewed, restore bytecode cache-related JSC options deleted in r240254
https://bugs.webkit.org/show_bug.cgi?id=192782
The JSC options were committed as part of r240210, which got rolled out in
r240224. However, the options got re-landed in r240248 and then deleted
again in 240254 (immediately before the caching code code landed in 240255)
* runtime/Options.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Options.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (240256 => 240257)
--- trunk/Source/_javascript_Core/ChangeLog 2019-01-22 18:15:00 UTC (rev 240256)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-01-22 18:33:18 UTC (rev 240257)
@@ -1,5 +1,16 @@
2019-01-22 Tadeu Zagallo
+Unreviewed, restore bytecode cache-related JSC options deleted in r240254
+https://bugs.webkit.org/show_bug.cgi?id=192782
+
+The JSC options were committed as part of r240210, which got rolled out in
+r240224. However, the options got re-landed in r240248 and then deleted
+again in 240254 (immediately before the caching code code landed in 240255)
+
+* runtime/Options.h:
+
+2019-01-22 Tadeu Zagallo
+
Cache bytecode to disk
https://bugs.webkit.org/show_bug.cgi?id=192782
Modified: trunk/Source/_javascript_Core/runtime/Options.h (240256 => 240257)
--- trunk/Source/_javascript_Core/runtime/Options.h 2019-01-22 18:15:00 UTC (rev 240256)
+++ trunk/Source/_javascript_Core/runtime/Options.h 2019-01-22 18:33:18 UTC (rev 240257)
@@ -509,6 +509,8 @@
v(bool, traceLLIntSlowPath, false, Configurable, nullptr) \
v(bool, traceBaselineJITExecution, false, Normal, nullptr) \
v(unsigned, thresholdForGlobalLexicalBindingEpoch, UINT_MAX, Normal, "Threshold for global lexical binding epoch. If the epoch reaches to this value, CodeBlock metadata for scope operations will be revised globally. It needs to be greater than 1.") \
+v(optionString, diskCachePath, nullptr, Restricted, nullptr) \
+v(bool, forceDiskCache, false, Restricted, nullptr) \
enum OptionEquivalence {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240256] trunk/Source/WebCore
Title: [240256] trunk/Source/WebCore
Revision 240256
Author ddkil...@apple.com
Date 2019-01-22 10:15:00 -0800 (Tue, 22 Jan 2019)
Log Message
Leak of NSMutableArray (128 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
Reviewed by Dean Jackson.
* platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:
(WebCore::appendArgumentToArray): Use adoptNS() to fix the leak.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (240255 => 240256)
--- trunk/Source/WebCore/ChangeLog 2019-01-22 18:00:14 UTC (rev 240255)
+++ trunk/Source/WebCore/ChangeLog 2019-01-22 18:15:00 UTC (rev 240256)
@@ -1,3 +1,14 @@
+2019-01-22 David Kilzer
+
+Leak of NSMutableArray (128 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
+
+
+
+Reviewed by Dean Jackson.
+
+* platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:
+(WebCore::appendArgumentToArray): Use adoptNS() to fix the leak.
+
2019-01-22 Zalan Bujtas
[LFC][Floats] Decouple clearance computation and margin collapsing reset.
Modified: trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm (240255 => 240256)
--- trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm 2019-01-22 18:00:14 UTC (rev 240255)
+++ trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm 2019-01-22 18:15:00 UTC (rev 240256)
@@ -55,7 +55,7 @@
{
BEGIN_BLOCK_OBJC_EXCEPTIONS;
if (!array)
-array = [[NSMutableArray alloc] initWithObjects:argument.get(), nil];
+array = adoptNS([[NSMutableArray alloc] initWithObjects:argument.get(), nil]);
else
[array addObject:argument.get()];
END_BLOCK_OBJC_EXCEPTIONS;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [240254] trunk
Title: [240254] trunk
Revision 240254
Author commit-qu...@webkit.org
Date 2019-01-22 09:48:08 -0800 (Tue, 22 Jan 2019)
Log Message
[JSC] Invalidate old scope operations using global lexical binding epoch
https://bugs.webkit.org/show_bug.cgi?id=193603
Patch by Yusuke Suzuki on 2019-01-22
Reviewed by Saam Barati.
JSTests:
* stress/let-lexical-binding-shadow-existing-global-property-ftl.js:
* stress/scope-operation-cache-global-property-before-deleting.js: Added.
(shouldThrow):
(bar):
* stress/scope-operation-cache-global-property-bump-counter.js: Added.
(shouldBe):
(get1):
(get2):
(get1If):
(get2If):
* stress/scope-operation-cache-global-property-even-if-it-fails.js: Added.
(shouldThrow):
(foo):
Source/_javascript_Core:
Even if the global lexical binding does not shadow the global property at that time, we need to clear the cached information in
scope related operations since we may have a global property previously. Consider the following example,
foo = 0;
function get() { return foo; }
print(get()); // 0
print(get()); // 0
delete globalThis.foo;
$.evalScript(`const foo = 42;`);
print(get()); // Should be 42, but it returns 0 if the cached information in get() is not cleared.
To invalidate the cache easily, we introduce global lexical binding epoch. It is bumped every time we introduce a new lexical binding
into JSGlobalLexicalEnvironment, since that name could shadow the global property name previously. In op_resolve_scope, we first check
the epoch stored in the metadata, and go to slow path if it is not equal to the current epoch. Our slow path code convert the scope
operation to the appropriate one even if the resolve type is not UnresolvedProperty type. After updating the resolve type of the bytecode,
we update the cached epoch to the current one, so that we can use the cached information as long as we stay in the same epoch.
In op_get_from_scope and op_put_to_scope, we do not use this epoch since Structure check can do the same thing instead. If op_resolve_type
is updated by the epoch, and if it starts returning JSGlobalLexicalEnvironment instead JSGlobalObject, obviously the structure check fails.
And in the slow path, we update op_get_from_scope and op_put_to_scope appropriately.
So, the metadata for scope related bytecodes are eventually updated to the appropriate one. In DFG and FTL, we use the watchpoint based approach.
In DFG and FTL, we concurrently attempt to get the watchpoint for the lexical binding and look into it by using `isStillValid()` to avoid
infinite compile-and-fail loop.
When the global lexical binding epoch overflows we iterate all the live CodeBlock and update the op_resolve_scope's epoch. Even if the shadowing
happens, it is OK if we bump the epoch, since op_resolve_scope will return JSGlobalLexicalEnvironment instead of JSGlobalObject, and following
structure check in op_put_to_scope and op_get_from_scope fail. We do not need to update op_get_from_scope and op_put_to_scope because of the same
reason.
* bytecode/BytecodeList.rb:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::notifyLexicalBindingUpdate):
(JSC::CodeBlock::notifyLexicalBindingShadowing): Deleted.
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGDesiredGlobalProperties.cpp:
(JSC::DFG::DesiredGlobalProperties::isStillValidOnMainThread):
* dfg/DFGDesiredGlobalProperties.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::watchGlobalProperty):
* dfg/DFGGraph.h:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::isStillValidOnMainThread):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_resolve_scope):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_resolve_scope):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::bumpGlobalLexicalBindingEpoch):
(JSC::JSGlobalObject::getReferencedPropertyWatchpointSet):
(JSC::JSGlobalObject::ensureReferencedPropertyWatchpointSet):
(JSC::JSGlobalObject::notifyLexicalBindingShadowing): Deleted.
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::globalLexicalBindingEpoch const):
(JSC::JSGlobalObject::globalLexicalBindingEpochOffset):
(JSC::JSGlobalObject::addressOfGlobalLexicalBindingEpoch):
* runtime/Options.cpp:
(JSC::correctOptions):
(JSC::Options::initialize):
(JSC::Options::setOptions):
(JSC::Options::setOptionWithoutAlias):
* runtime/Options.h:
* runtime/ProgramExecutable.cpp:
(JSC::ProgramExecutable::initializeGlobalProperties):
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/let-lexical-binding-shadow-existing-global-property-ftl.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/BytecodeList.rb
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
[webkit-changes] [240253] trunk/Source/WebCore
Title: [240253] trunk/Source/WebCore
Revision 240253
Author za...@apple.com
Date 2019-01-22 09:25:59 -0800 (Tue, 22 Jan 2019)
Log Message
[LFC][Floats] Decouple clearance computation and margin collapsing reset.
https://bugs.webkit.org/show_bug.cgi?id=193670
Reviewed by Antti Koivisto.
Move margin collapsing reset logic from FloatingContext to BlockFormattingContext. It's the BlockFormattingContext's job to do.
This is also in preparation for adding clear to static position.
* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::mapTopToAncestor):
(WebCore::Layout::FormattingContext::mapTopLeftToAncestor): Deleted.
* layout/FormattingContext.h:
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
* layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
* layout/floats/FloatingContext.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/FormattingContext.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/floats/FloatingContext.cpp
trunk/Source/WebCore/layout/floats/FloatingContext.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (240252 => 240253)
--- trunk/Source/WebCore/ChangeLog 2019-01-22 16:59:15 UTC (rev 240252)
+++ trunk/Source/WebCore/ChangeLog 2019-01-22 17:25:59 UTC (rev 240253)
@@ -1,3 +1,23 @@
+2019-01-22 Zalan Bujtas
+
+[LFC][Floats] Decouple clearance computation and margin collapsing reset.
+https://bugs.webkit.org/show_bug.cgi?id=193670
+
+Reviewed by Antti Koivisto.
+
+Move margin collapsing reset logic from FloatingContext to BlockFormattingContext. It's the BlockFormattingContext's job to do.
+This is also in preparation for adding clear to static position.
+
+* layout/FormattingContext.cpp:
+(WebCore::Layout::FormattingContext::mapTopToAncestor):
+(WebCore::Layout::FormattingContext::mapTopLeftToAncestor): Deleted.
+* layout/FormattingContext.h:
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
+* layout/floats/FloatingContext.cpp:
+(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
+* layout/floats/FloatingContext.h:
+
2019-01-22 Frederic Wang
Minor refactoring of the scrolling code
Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (240252 => 240253)
--- trunk/Source/WebCore/layout/FormattingContext.cpp 2019-01-22 16:59:15 UTC (rev 240252)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp 2019-01-22 17:25:59 UTC (rev 240253)
@@ -184,10 +184,14 @@
return mappedDisplayBox;
}
-Point FormattingContext::mapTopLeftToAncestor(const LayoutState& layoutState, const Box& layoutBox, const Container& ancestor)
+LayoutUnit FormattingContext::mapTopToAncestor(const LayoutState& layoutState, const Box& layoutBox, const Container& ancestor)
{
ASSERT(layoutBox.isDescendantOf(ancestor));
-return mapCoordinateToAncestor(layoutState, layoutState.displayBoxForLayoutBox(layoutBox).topLeft(), *layoutBox.containingBlock(), ancestor);
+auto top = layoutState.displayBoxForLayoutBox(layoutBox).top();
+auto* container = layoutBox.containingBlock();
+for (; container && container != container = container->containingBlock())
+top += layoutState.displayBoxForLayoutBox(*container).top();
+return top;
}
Point FormattingContext::mapCoordinateToAncestor(const LayoutState& layoutState, Point position, const Container& containingBlock, const Container& ancestor)
Modified: trunk/Source/WebCore/layout/FormattingContext.h (240252 => 240253)
--- trunk/Source/WebCore/layout/FormattingContext.h 2019-01-22 16:59:15 UTC (rev 240252)
+++ trunk/Source/WebCore/layout/FormattingContext.h 2019-01-22 17:25:59 UTC (rev 240253)
@@ -59,7 +59,7 @@
virtual InstrinsicWidthConstraints instrinsicWidthConstraints() const = 0;
static Display::Box mapBoxToAncestor(const LayoutState&, const Box&, const Container& ancestor);
-static Point mapTopLeftToAncestor(const LayoutState&, const Box&, const Container& ancestor);
+static LayoutUnit mapTopToAncestor(const LayoutState&, const Box&, const Container& ancestor);
static Point mapCoordinateToAncestor(const LayoutState&, Point, const Container& containingBlock, const Container& ancestor);
protected:
Modified: trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp (240252 => 240253)
--- trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp 2019-01-22 16:59:15 UTC (rev 240252)
+++ trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp 2019-01-22 17:25:59 UTC (rev 240253)
@@ -291,14 +291,46 @@
if
[webkit-changes] [240250] trunk/Source/WebKit
Title: [240250] trunk/Source/WebKit Revision 240250 Author commit-qu...@webkit.org Date 2019-01-22 01:07:00 -0800 (Tue, 22 Jan 2019) Log Message Enable CSSOMViewScrollingAPI https://bugs.webkit.org/show_bug.cgi?id=189472 Patch by Frederic Wang on 2019-01-22 Reviewed by Simon Fraser. This patch enables the CSSOMViewScrollingAPI option by default. This feature has already been enabled in tests since r235855. Basically, this change fixes an old compatibility issue regarding which scrolling element correspond to the viewport in standard mode (WebKit uses document.body while Gecko/Edge/Chromium use document.documentElement as described in the CSSOM View specification). WebKit developers writing tests can use document.scrollingElement for that purpose, so that they work independently of whether the option is enabled. [1] https://lists.webkit.org/pipermail/webkit-dev/2018-January/029857.html * Shared/WebPreferences.yaml: Enable by default and remove "experimental" category in accordance with the new policy. Instead, keep an internal flag only for developers. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebPreferences.yaml Diff Modified: trunk/Source/WebKit/ChangeLog (240249 => 240250) --- trunk/Source/WebKit/ChangeLog 2019-01-22 06:50:49 UTC (rev 240249) +++ trunk/Source/WebKit/ChangeLog 2019-01-22 09:07:00 UTC (rev 240250) @@ -1,3 +1,22 @@ +2019-01-22 Frederic Wang + +Enable CSSOMViewScrollingAPI +https://bugs.webkit.org/show_bug.cgi?id=189472 + +Reviewed by Simon Fraser. + +This patch enables the CSSOMViewScrollingAPI option by default. This feature has already been +enabled in tests since r235855. Basically, this change fixes an old compatibility issue +regarding which scrolling element correspond to the viewport in standard mode (WebKit uses +document.body while Gecko/Edge/Chromium use document.documentElement as described in the +CSSOM View specification). WebKit developers writing tests can use document.scrollingElement +for that purpose, so that they work independently of whether the option is enabled. + +[1] https://lists.webkit.org/pipermail/webkit-dev/2018-January/029857.html + +* Shared/WebPreferences.yaml: Enable by default and remove "experimental" category in +accordance with the new policy. Instead, keep an internal flag only for developers. + 2019-01-21 Antti Koivisto [iOS] Handle hit testing for subframes Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (240249 => 240250) --- trunk/Source/WebKit/Shared/WebPreferences.yaml 2019-01-22 06:50:49 UTC (rev 240249) +++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2019-01-22 09:07:00 UTC (rev 240250) @@ -1255,10 +1255,10 @@ CSSOMViewScrollingAPIEnabled: type: bool - defaultValue: false + defaultValue: true humanReadableName: "CSSOM View Scrolling API" humanReadableDescription: "Implement standard behavior for scrollLeft, scrollTop, scrollWidth, scrollHeight, scrollTo, scrollBy and scrollingElement." - category: experimental + category: internal WebAnimationsEnabled: type: bool ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
