[webkit-changes] [294290] trunk/Source
Title: [294290] trunk/Source
Revision 294290
Author z...@falconsigh.net
Date 2022-05-16 22:52:04 -0700 (Mon, 16 May 2022)
Log Message
[GTK][WPE] Current-context enforcement in ANGLE is expensive
https://bugs.webkit.org/show_bug.cgi?id=240392
Reviewed by Adrian Perez de Castro.
Source/WebCore:
ANGLE's current-context operations are relatively heavy and introduce
detectable overhead when executed for each of many WebGL operation. More
specifically, loads of the current-thread data from thread-local
storage are done under both EGL_GetCurrentContext() and
EGL_MakeCurrent() through the general TLS access model, relying on the
__tls_get_addr function.
Instead, a static thread-local pointer variable is introduced, with the
initial-exec method, containing the address of the current
GraphicsContextGLANGLE object for a given thread. Instead of dipping
into ANGLE to retrieve the current context, the GraphicsContextGLANGLE
object's address is compared to the value of the thread-local variable
and an early return is done if they match.
This model is applied through the TLS_MODEL_INITIAL_EXEC macro that's
defined appropriately if the compiler is detected to support the
required tls_model attribute. This should be the case when targetting
platforms that use ELF, i.e. Unix-like systems but primarily Linux.
The initial-exec TLS model relies on early understanding from the
dynamic linker about what TLS data is required, which enables more
efficient allocation of and access into the required underlying memory.
Caching the current-context data into a static thread-specific variable
with the initial-exec TLS model is the same approach that's taken in the
Mesa library. More on this and other TLS models can be gathered from the
'ELF Handling For Thread-Local Storage' paper by Ulrich Drepper.
* platform/graphics/gbm/GraphicsContextGLGBM.cpp:
(WebCore::GraphicsContextGLANGLE::makeContextCurrent):
Source/WTF:
* wtf/Compiler.h: Define the TLS_MODEL_INITIAL_EXEC macro as the
tls_model attribute with the initial-exec value, to be used on variables
whose TLS model should be adjusted.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Compiler.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (294289 => 294290)
--- trunk/Source/WTF/ChangeLog 2022-05-17 05:23:02 UTC (rev 294289)
+++ trunk/Source/WTF/ChangeLog 2022-05-17 05:52:04 UTC (rev 294290)
@@ -1,3 +1,14 @@
+2022-05-16 Zan Dobersek
+
+[GTK][WPE] Current-context enforcement in ANGLE is expensive
+https://bugs.webkit.org/show_bug.cgi?id=240392
+
+Reviewed by Adrian Perez de Castro.
+
+* wtf/Compiler.h: Define the TLS_MODEL_INITIAL_EXEC macro as the
+tls_model attribute with the initial-exec value, to be used on variables
+whose TLS model should be adjusted.
+
2022-05-16 Mark Lam
Add ARM64 disassembler support for symbolic dumping of some well known constants.
Modified: trunk/Source/WTF/wtf/Compiler.h (294289 => 294290)
--- trunk/Source/WTF/wtf/Compiler.h 2022-05-17 05:23:02 UTC (rev 294289)
+++ trunk/Source/WTF/wtf/Compiler.h 2022-05-17 05:52:04 UTC (rev 294290)
@@ -532,3 +532,15 @@
#if !defined(NO_UNIQUE_ADDRESS)
#define NO_UNIQUE_ADDRESS
#endif
+
+/* TLS_MODEL_INITIAL_EXEC */
+
+#if !defined(TLS_MODEL_INITIAL_EXEC) && defined(__has_attribute)
+#if __has_attribute(tls_model)
+#define TLS_MODEL_INITIAL_EXEC __attribute__((tls_model("initial-exec")))
+#endif
+#endif
+
+#if !defined(TLS_MODEL_INITIAL_EXEC)
+#define TLS_MODEL_INITIAL_EXEC
+#endif
Modified: trunk/Source/WebCore/ChangeLog (294289 => 294290)
--- trunk/Source/WebCore/ChangeLog 2022-05-17 05:23:02 UTC (rev 294289)
+++ trunk/Source/WebCore/ChangeLog 2022-05-17 05:52:04 UTC (rev 294290)
@@ -1,3 +1,41 @@
+2022-05-16 Zan Dobersek
+
+[GTK][WPE] Current-context enforcement in ANGLE is expensive
+https://bugs.webkit.org/show_bug.cgi?id=240392
+
+Reviewed by Adrian Perez de Castro.
+
+ANGLE's current-context operations are relatively heavy and introduce
+detectable overhead when executed for each of many WebGL operation. More
+specifically, loads of the current-thread data from thread-local
+storage are done under both EGL_GetCurrentContext() and
+EGL_MakeCurrent() through the general TLS access model, relying on the
+__tls_get_addr function.
+
+Instead, a static thread-local pointer variable is introduced, with the
+initial-exec method, containing the address of the current
+GraphicsContextGLANGLE object for a given thread. Instead of dipping
+into ANGLE to retrieve the current context, the GraphicsContextGLANGLE
+object's address is compared to the value of the thread-local variable
+and an early return is done if they match.
+
+This model is applied through the TLS_MODEL_INITIAL_EXEC macro that's
[webkit-changes] [294288] branches/safari-7614.1.14.100-branch/Source/WebCore
Title: [294288] branches/safari-7614.1.14.100-branch/Source/WebCore Revision 294288 Author alanc...@apple.com Date 2022-05-16 22:22:51 -0700 (Mon, 16 May 2022) Log Message Cherry-pick r293993. rdar://problem/92993954 Const-ify Node::willRespondTo*Events() https://bugs.webkit.org/show_bug.cgi?id=240246 Reviewed by Wenson Hsieh. Constify these four methods, because there's no reason for them not to be, and because it makes them usable in a const context in a future patch. * dom/EventNames.h: (WebCore::EventNames::isTouchRelatedEventType const): * dom/EventTarget.cpp: (WebCore::EventTarget::eventTypes const): * dom/EventTarget.h: * dom/Node.cpp: (WebCore::Node::willRespondToMouseMoveEvents const): (WebCore::Node::willRespondToTouchEvents const): (WebCore::Node::willRespondToMouseClickEvents const): (WebCore::Node::willRespondToMouseWheelEvents const): * dom/Node.h: * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::willRespondToMouseClickEvents const): * html/HTMLAnchorElement.h: * html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::willRespondToMouseClickEvents const): * html/HTMLButtonElement.h: * html/HTMLElement.cpp: (WebCore::HTMLElement::willRespondToMouseMoveEvents const): (WebCore::HTMLElement::willRespondToMouseWheelEvents const): (WebCore::HTMLElement::willRespondToMouseClickEvents const): * html/HTMLElement.h: * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::willRespondToMouseClickEvents const): * html/HTMLImageElement.h: * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willRespondToMouseClickEvents const): * html/HTMLInputElement.h: * html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::willRespondToMouseClickEvents const): * html/HTMLLabelElement.h: * html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::willRespondToMouseClickEvents const): * html/HTMLPlugInElement.h: * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::willRespondToMouseClickEvents const): * html/HTMLSelectElement.h: * html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::willRespondToMouseClickEvents const): * html/HTMLSummaryElement.h: * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::willRespondToMouseClickEvents const): * html/HTMLTextAreaElement.h: * html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::shouldSpinButtonRespondToMouseEvents const): (WebCore::TextFieldInputType::shouldSpinButtonRespondToWheelEvents const): * html/TextFieldInputType.h: * html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::willRespondToMouseMoveEvents const): (WebCore::SliderThumbElement::willRespondToMouseClickEvents const): * html/shadow/SliderThumbElement.h: * html/shadow/SpinButtonElement.cpp: (WebCore::SpinButtonElement::willRespondToMouseMoveEvents const): (WebCore::SpinButtonElement::willRespondToMouseClickEvents const): (WebCore::SpinButtonElement::shouldRespondToMouseEvents const): * html/shadow/SpinButtonElement.h: * html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldResultsButtonElement::willRespondToMouseClickEvents const): (WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents const): * html/shadow/TextControlInnerElements.h: * mathml/MathMLElement.cpp: (WebCore::MathMLElement::willRespondToMouseClickEvents const): * mathml/MathMLElement.h: * mathml/MathMLSelectElement.cpp: (WebCore::MathMLSelectElement::willRespondToMouseClickEvents const): * mathml/MathMLSelectElement.h: * svg/SVGAElement.cpp: (WebCore::SVGAElement::willRespondToMouseClickEvents const): * svg/SVGAElement.h: Canonical link: https://commits.webkit.org/250430@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293993 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-7614.1.14.100-branch/Source/WebCore/ChangeLog branches/safari-7614.1.14.100-branch/Source/WebCore/dom/EventNames.h branches/safari-7614.1.14.100-branch/Source/WebCore/dom/EventTarget.cpp branches/safari-7614.1.14.100-branch/Source/WebCore/dom/EventTarget.h branches/safari-7614.1.14.100-branch/Source/WebCore/dom/Node.cpp branches/safari-7614.1.14.100-branch/Source/WebCore/dom/Node.h branches/safari-7614.1.14.100-branch/Source/WebCore/html/HTMLAnchorElement.cpp branches/safari-7614.1.14.100-branch/Source/WebCore/html/HTMLAnchorElement.h branches/safari-7614.1.14.100-branch/Source/WebCore/html/HTMLButtonElement.cpp branches/safari-7614.1.14.100-branch/Source/WebCore/html/HTMLButtonElement.h branches/safari-7614.1.14.100-branch/Source/WebCore/html/HTMLElement.cpp branches/safari-7614.1.14.100-branch/Source/WebCore/html/HTMLElement.h branches/safari-7614.1.14.100-branch/Source/WebCore/html/HTMLImageElement.cpp
[webkit-changes] [294289] branches/safari-7614.1.14.100-branch/Source
Title: [294289] branches/safari-7614.1.14.100-branch/Source Revision 294289 Author alanc...@apple.com Date 2022-05-16 22:23:02 -0700 (Mon, 16 May 2022) Log Message Cherry-pick r294160. rdar://problem/87170289 Add UI-side layers for optionally indicating interaction regions https://bugs.webkit.org/show_bug.cgi?id=240372 Reviewed by Dean Jackson. Source/WebCore: * page/DebugPageOverlays.cpp: (WebCore::pathsForRegion): Move inline rect inflation into InteractionRegion so that all clients get it. * page/Page.cpp: (WebCore::Page::shouldBuildInteractionRegions const): * page/Page.h: * page/Frame.cpp: (WebCore::Frame::invalidateContentEventRegionsIfNeeded): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const): (WebCore::RenderLayerBacking::updateEventRegion): If the ENABLE() and setting are both enabled, update event regions due to possible interaction region changes. We could make this more conservative later, but chances are high that most layers include interaction regions. For now, compute interaction regions only for the root layer. In a future patch, we will adopt the normal fake paint mechanism and maintain them on the layer that owns them. * page/InteractionRegion.cpp: (WebCore::regionForElement): Move inline rect inflation into InteractionRegion so that all clients get it. Limit interaction rects to half of the viewport. Ignore regions that are larger. * page/InteractionRegion.h: (WebCore::operator==): Added. (WebCore::InteractionRegion::encode const): (WebCore::InteractionRegion::decode): Remove the isInline bit, since we only used it for rect inflation. * rendering/EventRegion.cpp: (WebCore::EventRegion::operator== const): (WebCore::EventRegion::translate): (WebCore::EventRegion::uniteInteractionRegions): (WebCore::EventRegion::computeInteractionRegions): * rendering/EventRegion.h: (WebCore::EventRegion::interactionRegions const): (WebCore::EventRegion::encode const): (WebCore::EventRegion::decode): Store interaction regions on EventRegion. Source/WebKit: * Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer): (WebKit::RemoteLayerTreePropertyApplier::applyHierarchyUpdates): Allow RemoteLayerTreeInteractionRegionLayers to add and maintain layers for interaction regions. * SourcesCocoa.txt: * UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.h: Added. * UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm: Added. (configureLayerForInteractionRegion): (WebKit::interactionRegionForLayer): (WebKit::isInteractionRegionLayer): (WebKit::setInteractionRegion): Box WebCore::InteractionRegion in a Objective-C object and store it on the layer. Use this as a key to indicate that a given layer is an interaction region. (WebKit::appendInteractionRegionLayersForLayer): Make sure that interaction region layers are always at the end of the layer's sublayers array. (WebKit::updateLayersForInteractionRegions): Add new layers for interaction regions. Maintain the same layer for regions that cover the same area. Add a green wash if the default `WKInteractionRegionDebugFill` is set. * WebKit.xcodeproj/project.pbxproj: Source/WTF: * Scripts/Preferences/WebPreferencesInternal.yaml: Add a preference to toggle interaction region layers. Canonical link: https://commits.webkit.org/250529@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294160 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-7614.1.14.100-branch/Source/WTF/ChangeLog branches/safari-7614.1.14.100-branch/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml branches/safari-7614.1.14.100-branch/Source/WebCore/ChangeLog branches/safari-7614.1.14.100-branch/Source/WebCore/page/DebugPageOverlays.cpp branches/safari-7614.1.14.100-branch/Source/WebCore/page/Frame.cpp branches/safari-7614.1.14.100-branch/Source/WebCore/page/InteractionRegion.cpp branches/safari-7614.1.14.100-branch/Source/WebCore/page/InteractionRegion.h branches/safari-7614.1.14.100-branch/Source/WebCore/page/Page.cpp branches/safari-7614.1.14.100-branch/Source/WebCore/page/Page.h branches/safari-7614.1.14.100-branch/Source/WebCore/rendering/EventRegion.cpp branches/safari-7614.1.14.100-branch/Source/WebCore/rendering/EventRegion.h branches/safari-7614.1.14.100-branch/Source/WebCore/rendering/RenderBlock.cpp branches/safari-7614.1.14.100-branch/Source/WebCore/rendering/RenderLayerBacking.cpp branches/safari-7614.1.14.100-branch/Source/WebKit/ChangeLog branches/safari-7614.1.14.100-branch/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm
[webkit-changes] [294287] trunk/Source
Title: [294287] trunk/Source Revision 294287 Author mark@apple.com Date 2022-05-16 22:21:53 -0700 (Mon, 16 May 2022) Log Message Add ARM64 disassembler support for symbolic dumping of some well known constants. https://bugs.webkit.org/show_bug.cgi?id=240443 Reviewed by Yusuke Suzuki. Source/_javascript_Core: 1. Added a Options::needDisassemblySupport() option. This option is true if any of the JSC disassembly options are enabled. This allows us to trivially check if we need to enable additional infrastructure (like those added in this patch) to support disassembly. 2. Refactor the Disassembler's thunkLabelMap into a more generic labelMap. It can now map a pointer to a CString or a const char* label. 3. Enable JITOperationList infrastructure when ENABLE(JIT_OPERATION_DISASSEMBLY) is true. This adds a name to the JITOperationAnnotation record. Since this is guarded by ENABLE(JIT_OPERATION_DISASSEMBLY), we can trivially turn this part off later if adding this name adds too much size burden (or if any unexpected issues arise). Turning this off will only disable disassembly of JIT operation names. Disassembly of other constants (see below) will still be supported. If Options::needDisassemblySupport() is true, the JITOperationList will register all JIT operations (and the LLInt ones as well) with the Disassembler labelMap. 4. Removed the < > brackets around branch target labels except for internal pc index labels (e.g. <716>) and (when we don't know what the branch target is). The < > notation takes up space and doesn't add any info. The branch targets now look like this: <32> 0x1180102c0:b.ne 0x1180101c0 -> thunk: native Tail With Saved Tags Call trampoline <92> 0x11801c87c:b0x118008980 -> thunk: LLInt function for call jump to prologue thunk <3508> 0x1198e16b4:b0x1198bc1a0 -> JIT PC Internal pc index labels will still use the < > brackets: <3476> 0x1198e1694:b.eq 0x1198e16a0 -> <3488> 5. Added ARM64 disassembler support to compute the value of a constant being loaded into a register using "MoveWide" instructions e.g. movz and movk. When the disassembler sees a movz or movn or mov (of the MoveWide variety), the disassembler initializes a m_builtConstant value. With each subsequent movk instruction with the same destination register, the disassembler splices in the corresponding 16-bit immediate. After disassembling a MoveWide instruction, it will check if the next instruction is also a MoveWide instruction targeting the same destination register. If so, the constant is still being build: hence, it does nothing and continues. If the next instruction is (a) a MoveWide instruction targeting a different register, (b) not a MoveWide instruction, or (c) we've reached the end of the LinkBuffer (i.e. there's no next instruction), then the constant building for the current target register is complete. 6. Added ARM64 disassembler support for looking up constants (built in (5) above) and printing symbolic info / names of those constants. With ENABLE(JIT_OPERATION_DISASSEMBLY), we now have JIT operation names e.g. <176> 0x118010270:movk x3, #0x9f6e, lsl #48 -> 0x102dc8950 operationVMHandleException <164> 0x1180180a4:movk x8, #0xe5c, lsl #48 -> 0x102db9420 operationVirtualCall Apart from looking up the constant in the Disassembler labelMap, it also looks up some commonly used constants e.g. a. VM pointers: <156> 0x11801105c:movk x0, #0x1, lsl #32 -> 0x139435000 vm b. Some VM internal pointers (more can be added later as needed): <24> 0x118014d18:movk x17, #0x1, lsl #32 -> 0x13943ee78 vm +40568: vm.topCallFrame <76> 0x118014d4c:movk x17, #0x1, lsl #32 -> 0x139441a10 vm +51728: vm.m_exception <196> 0x118011244:movk x17, #0x1, lsl #32 -> 0x1394417d0 vm +51152: vm.targetMachinePCForThrow <208> 0x1198e09d0:movk x17, #0x1, lsl #32 -> 0x104432cc0 vm +52416: vm.m_doesGC c. VM related pointers (only 1 for now; not VM fields, but hangs off of VM): <12> 0x11801938c:movk x1, #0x1, lsl #32 -> 0x1052cd3c8 vm scratchBuffer.m_buffer d. Well known PtrTags: <204> 0x11801124c:movz x16, #0x6f9b -> 0x6f9b ExceptionHandlerPtrTag ? <212> 0x1180150d4:movz x16, #0x593 -> 0x593 JSEntryPtrTag ? <168> 0x1180183a8:movz lr, #0xb389 -> 0xb389 OperationPtrTag ? * the ? is because we cannot be certain that the 16-bit constant is a PtrTag. It may just be a coincidence that the value is the same. However, the user can trivially look at the surrounding disassembled code, and be able to tell if the value is used as a PtrTag. For constants that are not found in the known sets: e. Small 16-bit constant (prints decimal value for convenience): <200>
[webkit-changes] [294285] trunk
Title: [294285] trunk
Revision 294285
Author wenson_hs...@apple.com
Date 2022-05-16 20:29:53 -0700 (Mon, 16 May 2022)
Log Message
Demote -[WKWebView retrieveAccessibilityTreeData:] to SPI
https://bugs.webkit.org/show_bug.cgi?id=240494
rdar://93385094
Reviewed by Tim Horton.
This method was only intended for use in MiniBrowser, and should ship as public API on WKWebView. Move the
declaration and implementation of this over to WKWebViewPrivateForTestingMac.h and WKWebViewTestingMac.mm
(respectively), and additionally prefix this testing-only SPI with an underscore.
* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView retrieveAccessibilityTreeData:]): Deleted.
* UIProcess/API/mac/WKWebViewPrivateForTestingMac.h:
* UIProcess/API/mac/WKWebViewTestingMac.mm:
(-[WKWebView _retrieveAccessibilityTreeData:]):
Demote -[WKWebView retrieveAccessibilityTreeData:] to SPI
https://bugs.webkit.org/show_bug.cgi?id=240494
rdar://93385094
Reviewed by Tim Horton.
See WebKit/ChangeLog for more details.
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController logAccessibilityTrees:]):
Canonical link: https://commits.webkit.org/250629@main
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h
trunk/Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m
Diff
Modified: trunk/Source/WebKit/ChangeLog (294284 => 294285)
--- trunk/Source/WebKit/ChangeLog 2022-05-17 01:34:39 UTC (rev 294284)
+++ trunk/Source/WebKit/ChangeLog 2022-05-17 03:29:53 UTC (rev 294285)
@@ -1,3 +1,22 @@
+2022-05-16 Wenson Hsieh
+
+Demote -[WKWebView retrieveAccessibilityTreeData:] to SPI
+https://bugs.webkit.org/show_bug.cgi?id=240494
+rdar://93385094
+
+Reviewed by Tim Horton.
+
+This method was only intended for use in MiniBrowser, and should not ship as public API on WKWebView. Move the
+declaration and implementation of this over to WKWebViewPrivateForTestingMac.h and WKWebViewTestingMac.mm
+(respectively), and additionally prefix this testing-only SPI with an underscore.
+
+* UIProcess/API/Cocoa/WKWebView.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView retrieveAccessibilityTreeData:]): Deleted.
+* UIProcess/API/mac/WKWebViewPrivateForTestingMac.h:
+* UIProcess/API/mac/WKWebViewTestingMac.mm:
+(-[WKWebView _retrieveAccessibilityTreeData:]):
+
2022-05-16 Said Abou-Hallawa
REGRESSION(r249162): CanvasRenderingContext2DBase::drawImage() crashes if the image is animated and the first frame cannot be decoded
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h (294284 => 294285)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h 2022-05-17 01:34:39 UTC (rev 294284)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h 2022-05-17 03:29:53 UTC (rev 294285)
@@ -449,8 +449,6 @@
*/
- (void)createWebArchiveDataWithCompletionHandler:(void (^)(NSData *, NSError *))completionHandler NS_REFINED_FOR_SWIFT WK_API_AVAILABLE(macos(11.0), ios(14.0));
-- (void)retrieveAccessibilityTreeData:(void (^)(NSData *, NSError *))completionHandler;
-
/*! @abstract A Boolean value indicating whether horizontal swipe gestures
will trigger back-forward list navigations.
@discussion The default value is NO.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (294284 => 294285)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2022-05-17 01:34:39 UTC (rev 294284)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2022-05-17 03:29:53 UTC (rev 294285)
@@ -1750,14 +1750,6 @@
});
}
-- (void)retrieveAccessibilityTreeData:(void (^)(NSData *, NSError *))completionHandler
-{
-THROW_IF_SUSPENDED;
-_page->getAccessibilityTreeData([completionHandler = makeBlockPtr(completionHandler)] (API::Data* data) {
-completionHandler(wrapper(data), nil);
-});
-}
-
static NSDictionary *dictionaryRepresentationForEditorState(const WebKit::EditorState& state)
{
if (state.isMissingPostLayoutData)
Modified: trunk/Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h (294284 => 294285)
--- trunk/Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h 2022-05-17 01:34:39 UTC (rev 294284)
+++ trunk/Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h 2022-05-17 03:29:53 UTC (rev 294285)
@@ -53,6 +53,7 @@
- (NSSet *)_pdfHUDs;
- (void)_simulateMouseMove:(NSEvent *)event;
+- (void)_retrieveAccessibilityTreeData:(void (^)(NSData *, NSError *))completionHandler;
@end
Modified: trunk/Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm (294284 => 294285)
--- trunk/Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm 2022-05-17 01:34:39 UTC (rev 294284)
[webkit-changes] [294284] trunk/Source/JavaScriptCore
Title: [294284] trunk/Source/_javascript_Core
Revision 294284
Author sbar...@apple.com
Date 2022-05-16 18:34:39 -0700 (Mon, 16 May 2022)
Log Message
Move around some NaN handling code
https://bugs.webkit.org/show_bug.cgi?id=240493
Reviewed by Yusuke Suzuki.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueRep):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::purifyNaN):
(JSC::FTL::DFG::LowerDFGToB3::compileValueRep):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
Canonical link: https://commits.webkit.org/250628@main
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (294283 => 294284)
--- trunk/Source/_javascript_Core/ChangeLog 2022-05-17 01:32:50 UTC (rev 294283)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-05-17 01:34:39 UTC (rev 294284)
@@ -1,3 +1,18 @@
+2022-05-16 Saam Barati
+
+Move around some NaN handling code
+https://bugs.webkit.org/show_bug.cgi?id=240493
+
+
+Reviewed by Yusuke Suzuki.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileValueRep):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::purifyNaN):
+(JSC::FTL::DFG::LowerDFGToB3::compileValueRep):
+(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
+
2022-05-16 Patrick Angle
Web Inspector: Regression(r266885) Crash sometimes when rehydrating imported audit results
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (294283 => 294284)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2022-05-17 01:32:50 UTC (rev 294283)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2022-05-17 01:34:39 UTC (rev 294284)
@@ -3484,7 +3484,7 @@
// anymore. Unfortunately, this would be unsound. If it's a GetLocal or if the value was
// subject to a prior SetLocal, filtering the value would imply that the corresponding
// local was purified.
-if (needsTypeCheck(node->child1(), ~SpecDoubleImpureNaN))
+if (m_state.forNode(node->child1()).couldBeType(SpecDoubleImpureNaN))
m_jit.purifyNaN(valueFPR);
boxDouble(valueFPR, resultRegs);
@@ -4007,6 +4007,7 @@
}
if (format == DataFormatJS) {
+m_jit.purifyNaN(resultReg);
m_jit.boxDouble(resultReg, resultRegs);
jsValueResult(resultRegs, node);
} else {
Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (294283 => 294284)
--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2022-05-17 01:32:50 UTC (rev 294283)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2022-05-17 01:34:39 UTC (rev 294284)
@@ -1964,6 +1964,11 @@
setInt32(integerValue);
}
+LValue purifyNaN(LValue value)
+{
+return m_out.select(m_out.doubleEqual(value, value), value, m_out.constDouble(PNaN));
+}
+
void compileValueRep()
{
switch (m_node->child1().useKind()) {
@@ -1970,10 +1975,8 @@
case DoubleRepUse: {
LValue value = lowDouble(m_node->child1());
-if (m_interpreter.needsTypeCheck(m_node->child1(), ~SpecDoubleImpureNaN)) {
-value = m_out.select(
-m_out.doubleEqual(value, value), value, m_out.constDouble(PNaN));
-}
+if (abstractValue(m_node->child1()).couldBeType(SpecDoubleImpureNaN))
+value = purifyNaN(value);
setJSValue(boxDouble(value));
return;
@@ -13780,7 +13783,7 @@
else
genericResult = strictInt52ToJSValue(m_out.zeroExt(genericResult, Int64));
} else if (genericResult->type() == Double)
-genericResult = boxDouble(genericResult);
+genericResult = boxDouble(purifyNaN(genericResult));
results.append(m_out.anchor(genericResult));
m_out.jump(continuation);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294283] trunk/LayoutTests
Title: [294283] trunk/LayoutTests Revision 294283 Author rack...@apple.com Date 2022-05-16 18:32:50 -0700 (Mon, 16 May 2022) Log Message REGRESSION (r294215): [ iOS ] Nine fast tests are a consistent image failure https://bugs.webkit.org/show_bug.cgi?id=240495 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/250627@main Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (294282 => 294283) --- trunk/LayoutTests/ChangeLog 2022-05-17 01:00:05 UTC (rev 294282) +++ trunk/LayoutTests/ChangeLog 2022-05-17 01:32:50 UTC (rev 294283) @@ -1,5 +1,14 @@ 2022-05-16 Karl Rackler +REGRESSION (r294215): [ iOS ] Nine fast tests are a consistent image failure +https://bugs.webkit.org/show_bug.cgi?id=240495 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: + +2022-05-16 Karl Rackler + [ iOS ] imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=240489 Modified: trunk/LayoutTests/platform/ios/TestExpectations (294282 => 294283) --- trunk/LayoutTests/platform/ios/TestExpectations 2022-05-17 01:00:05 UTC (rev 294282) +++ trunk/LayoutTests/platform/ios/TestExpectations 2022-05-17 01:32:50 UTC (rev 294283) @@ -3617,3 +3617,13 @@ webkit.org/b/240463 imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html [ Failure ] webkit.org/b/240489 imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html [ Slow ] + +webkit.org/b/240495 fast/css/paint-order-shadow.html [ ImageOnlyFailure ] +webkit.org/b/240495 fast/forms/ios/focus-ring-size.html [ ImageOnlyFailure ] +webkit.org/b/240495 fast/inline/hidpi-outline-auto-negative-offset-with-border-radius.html [ ImageOnlyFailure ] +webkit.org/b/240495 fast/inline/hidpi-outline-auto-with-border-radius-horizontal-ltr.html [ ImageOnlyFailure ] +webkit.org/b/240495 fast/inline/hidpi-outline-auto-with-border-radius-horizontal-rtl.html [ ImageOnlyFailure ] +webkit.org/b/240495 fast/inline/hidpi-outline-auto-with-border-radius-vertical-ltr.html [ ImageOnlyFailure ] +webkit.org/b/240495 fast/inline/hidpi-outline-auto-with-border-radius-vertical-rtl.html [ ImageOnlyFailure ] +webkit.org/b/240495 fast/inline/hidpi-outline-auto-with-fractional-radius.html [ ImageOnlyFailure ] +webkit.org/b/240495 fast/inline/hidpi-outline-auto-with-one-focusring-rect.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294282] trunk/Source/WebKit/NetworkProcess/mac/ com.apple.WebKit.NetworkProcess.sb.in
Title: [294282] trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in Revision 294282 Author pvol...@apple.com Date 2022-05-16 18:00:05 -0700 (Mon, 16 May 2022) Log Message [macOS] Fix mach syscall sandbox violation in the Network process https://bugs.webkit.org/show_bug.cgi?id=240466 Reviewed by Chris Dumez. Fix mach syscall sandbox violation in the Network process on macOS. * Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: Canonical link: https://commits.webkit.org/250626@main Modified Paths trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in Diff Modified: trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (294281 => 294282) --- trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2022-05-16 23:58:42 UTC (rev 294281) +++ trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2022-05-17 01:00:05 UTC (rev 294282) @@ -670,7 +670,11 @@ MSC_syscall_thread_switch MSC_task_dyld_process_info_notify_get MSC_task_self_trap -MSC_thread_get_special_reply_port)) +MSC_thread_get_special_reply_port +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 12 +MSC_thread_self_trap +#endif +)) (when (defined? 'MSC_mach_msg2_trap) (allow syscall-mach ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294281] trunk/Source/WebCore
Title: [294281] trunk/Source/WebCore
Revision 294281
Author gnavamar...@apple.com
Date 2022-05-16 16:58:42 -0700 (Mon, 16 May 2022)
Log Message
Crash in WebCore::InsertTextCommand::positionInsideTextNode
https://bugs.webkit.org/show_bug.cgi?id=240480
Reviewed by Ryosuke Niwa.
Calling pushAnchorElementDown in CompositeEditCommand::positionAvoidingSpecialElementBoundary can
end up removing the startPosition's container node which leaves an invalid endingSelection.
InsertTextCommand::doApply requires a real endingSelection, so we should check if this occurred and bail out.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::doApply):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/InsertTextCommand.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (294280 => 294281)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 23:44:54 UTC (rev 294280)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 23:58:42 UTC (rev 294281)
@@ -1,3 +1,18 @@
+2022-05-16 Gabriel Nava Marino
+
+Crash in WebCore::InsertTextCommand::positionInsideTextNode
+https://bugs.webkit.org/show_bug.cgi?id=240480
+
+Reviewed by Ryosuke Niwa.
+
+Calling pushAnchorElementDown in CompositeEditCommand::positionAvoidingSpecialElementBoundary can
+end up removing the startPosition's container node which leaves an invalid endingSelection.
+
+InsertTextCommand::doApply requires a real endingSelection, so we should check if this occurred and bail out.
+
+* editing/InsertTextCommand.cpp:
+(WebCore::InsertTextCommand::doApply):
+
2022-05-16 Said Abou-Hallawa
REGRESSION(r249162): CanvasRenderingContext2DBase::drawImage() crashes if the image is animated and the first frame cannot be decoded
Modified: trunk/Source/WebCore/editing/InsertTextCommand.cpp (294280 => 294281)
--- trunk/Source/WebCore/editing/InsertTextCommand.cpp 2022-05-16 23:44:54 UTC (rev 294280)
+++ trunk/Source/WebCore/editing/InsertTextCommand.cpp 2022-05-16 23:58:42 UTC (rev 294281)
@@ -182,7 +182,9 @@
startPosition = startPosition.downstream();
startPosition = positionAvoidingSpecialElementBoundary(startPosition);
-
+if (endingSelection().isNoneOrOrphaned())
+return;
+
Position endPosition;
if (m_text == "\t") {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294280] trunk/Source
Title: [294280] trunk/Source Revision 294280 Author s...@apple.com Date 2022-05-16 16:44:54 -0700 (Mon, 16 May 2022) Log Message REGRESSION(r249162): CanvasRenderingContext2DBase::drawImage() crashes if the image is animated and the first frame cannot be decoded https://bugs.webkit.org/show_bug.cgi?id=239113 rdar://87980543 Reviewed by Simon Fraser. Source/WebCore: CanvasRenderingContext2DBase::drawImage() needs to ensure the first frame of the animated image can be decoded correctly before creating the temporary static image. If the first frame can't be decoded, this function should return immediately. This matches the behavior of this function before r249162. The animated image decodes its frames asynchronously in a work queue. But the first frame has to be decoded synchronously in the main run loop. So to avoid running the image decoder in two different threads we are going to keep the first and the current frame cached when we receive a memory pressure warning. This should not increase the memory allocation of the animated image because the numbers of cached frames increases quickly and we keep all of them till a memory warning is received. But the memory pressure warning will be received a little bit more often. This depends on the memory size of the first frame. To make the code more robust, make ImageSource take a Ref instead of taking a RefPtr. * html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::drawImage): * platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::destroyDecodedData): * platform/graphics/BitmapImage.h: * platform/graphics/ImageSource.cpp: (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::destroyDecodedData): (WebCore::ImageSource::setNativeImage): * platform/graphics/ImageSource.h: (WebCore::ImageSource::create): (WebCore::ImageSource::isDecoderAvailable const): (WebCore::ImageSource::destroyAllDecodedData): Deleted. (WebCore::ImageSource::destroyAllDecodedDataExcludeFrame): Deleted. (WebCore::ImageSource::destroyDecodedDataBeforeFrame): Deleted. Source/WebKit: * GPUProcess/graphics/RemoteDisplayListRecorder.cpp: (WebKit::RemoteDisplayListRecorder::drawSystemImage): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp trunk/Source/WebCore/platform/graphics/BitmapImage.cpp trunk/Source/WebCore/platform/graphics/BitmapImage.h trunk/Source/WebCore/platform/graphics/ImageSource.cpp trunk/Source/WebCore/platform/graphics/ImageSource.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (294279 => 294280) --- trunk/Source/WebCore/ChangeLog 2022-05-16 23:40:16 UTC (rev 294279) +++ trunk/Source/WebCore/ChangeLog 2022-05-16 23:44:54 UTC (rev 294280) @@ -1,3 +1,46 @@ +2022-05-16 Said Abou-Hallawa + +REGRESSION(r249162): CanvasRenderingContext2DBase::drawImage() crashes if the image is animated and the first frame cannot be decoded +https://bugs.webkit.org/show_bug.cgi?id=239113 +rdar://87980543 + +Reviewed by Simon Fraser. + +CanvasRenderingContext2DBase::drawImage() needs to ensure the first frame +of the animated image can be decoded correctly before creating the temporary +static image. If the first frame can't be decoded, this function should return +immediately. This matches the behavior of this function before r249162. + +The animated image decodes its frames asynchronously in a work queue. But +the first frame has to be decoded synchronously in the main run loop. So +to avoid running the image decoder in two different threads we are going +to keep the first and the current frame cached when we receive a memory +pressure warning. This should not increase the memory allocation of the +animated image because the numbers of cached frames increases quickly and +we keep all of them till a memory warning is received. But the memory +pressure warning will be received a little bit more often. This depends +on the memory size of the first frame. + +To make the code more robust, make ImageSource take a Ref +instead of taking a RefPtr. + +* html/canvas/CanvasRenderingContext2DBase.cpp: +(WebCore::CanvasRenderingContext2DBase::drawImage): +* platform/graphics/BitmapImage.cpp: +(WebCore::BitmapImage::BitmapImage): +(WebCore::BitmapImage::destroyDecodedData): +* platform/graphics/BitmapImage.h: +* platform/graphics/ImageSource.cpp: +(WebCore::ImageSource::ImageSource): +(WebCore::ImageSource::destroyDecodedData): +(WebCore::ImageSource::setNativeImage): +* platform/graphics/ImageSource.h: +(WebCore::ImageSource::create): +(WebCore::ImageSource::isDecoderAvailable const): +
[webkit-changes] [294279] trunk/Source/WebCore
Title: [294279] trunk/Source/WebCore Revision 294279 Author simon.fra...@apple.com Date 2022-05-16 16:40:16 -0700 (Mon, 16 May 2022) Log Message rdar://93377867 (WebKit r294204: weird text rendering artifacts while pages are loading) Revert r294204 and r294262 * layout/integration/inline/InlineIteratorBox.cpp: (WebCore::InlineIterator::Box::visualRect const): Deleted. * layout/integration/inline/InlineIteratorBox.h: (WebCore::InlineIterator::Box::visualRect const): (WebCore::InlineIterator::Box::containingBlock const): Deleted. * layout/integration/inline/InlineIteratorBoxLegacyPath.h: (WebCore::InlineIterator::BoxLegacyPath::containingBlock const): Deleted. (WebCore::InlineIterator::BoxLegacyPath::direction const): Deleted. (WebCore::InlineIterator::BoxLegacyPath::isFirstLine const): Deleted. * layout/integration/inline/InlineIteratorBoxModernPath.h: (WebCore::InlineIterator::BoxModernPath::direction const): (WebCore::InlineIterator::BoxModernPath::containingBlock const): Deleted. (WebCore::InlineIterator::BoxModernPath::isFirstLine const): Deleted. * layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::paint): * rendering/InlineBoxPainter.cpp: (WebCore::InlineBoxPainter::paintMask): (WebCore::InlineBoxPainter::paintDecorations): * rendering/LegacyInlineFlowBox.cpp: (WebCore::LegacyInlineFlowBox::addTextBoxVisualOverflow): * rendering/LegacyInlineTextBox.cpp: (WebCore::LegacyInlineTextBox::paint): * rendering/LegacyInlineTextBox.h: * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintMaskForTextFillBox): * rendering/TextBoxPainter.cpp: (WebCore::TextBoxPainter::TextBoxPainter): (WebCore::TextBoxPainter::~TextBoxPainter): (WebCore::TextBoxPainter::paint): (WebCore::TextBoxPainter::createMarkedTextFromSelectionInBox): (WebCore::TextBoxPainter::paintBackground): (WebCore::TextBoxPainter::paintForegroundAndDecorations): (WebCore::TextBoxPainter::paintCompositionBackground): (WebCore::TextBoxPainter::paintForeground): (WebCore::TextBoxPainter::createDecorationPainter): (WebCore::TextBoxPainter::paintBackgroundDecorations): (WebCore::TextBoxPainter::paintForegroundDecorations): (WebCore::TextBoxPainter::paintCompositionUnderlines): (WebCore::textPosition): (WebCore::TextBoxPainter::paintCompositionUnderline): (WebCore::TextBoxPainter::paintPlatformDocumentMarkers): (WebCore::TextBoxPainter::calculateUnionOfAllDocumentMarkerBounds): (WebCore::TextBoxPainter::paintPlatformDocumentMarker): (WebCore::TextBoxPainter::computePaintRect): (WebCore::TextBoxPainter::calculateDocumentMarkerBounds): (WebCore::TextBoxPainter::computeHaveSelection const): (WebCore::TextBoxPainter::fontCascade const): (WebCore::TextBoxPainter::textOriginFromPaintRect const): (WebCore::TextBoxPainter::debugTextShadow const): (WebCore::LegacyTextBoxPainter::LegacyTextBoxPainter): Deleted. (): Deleted. (WebCore::ModernTextBoxPainter::ModernTextBoxPainter): Deleted. (WebCore::TextBoxPainter::TextBoxPainter): Deleted. (WebCore::TextBoxPainter::~TextBoxPainter): Deleted. (WebCore::TextBoxPainter::makeIterator const): Deleted. (WebCore::TextBoxPainter::paint): Deleted. (WebCore::TextBoxPainter::createMarkedTextFromSelectionInBox): Deleted. (WebCore::TextBoxPainter::paintBackground): Deleted. (WebCore::TextBoxPainter::paintForegroundAndDecorations): Deleted. (WebCore::TextBoxPainter::paintCompositionBackground): Deleted. (WebCore::TextBoxPainter::paintForeground): Deleted. (WebCore::TextBoxPainter::createDecorationPainter): Deleted. (WebCore::TextBoxPainter::paintBackgroundDecorations): Deleted. (WebCore::TextBoxPainter::paintForegroundDecorations): Deleted. (WebCore::TextBoxPainter::paintCompositionUnderlines): Deleted. (WebCore::TextBoxPainter::textPosition): Deleted. (WebCore::TextBoxPainter::paintCompositionUnderline): Deleted. (WebCore::TextBoxPainter::paintPlatformDocumentMarkers): Deleted. (WebCore::LegacyTextBoxPainter::calculateUnionOfAllDocumentMarkerBounds): Deleted. (WebCore::TextBoxPainter::paintPlatformDocumentMarker): Deleted. (WebCore::TextBoxPainter::computePaintRect): Deleted. (WebCore::calculateDocumentMarkerBounds): Deleted. (WebCore::TextBoxPainter::computeHaveSelection const): Deleted. (WebCore::TextBoxPainter::fontCascade const): Deleted. (WebCore::TextBoxPainter::textOriginFromPaintRect const): Deleted. (WebCore::TextBoxPainter::debugTextShadow const): Deleted. * rendering/TextBoxPainter.h: (WebCore::TextBoxPainter::textBox const): Modified Paths trunk/Source/WebCore/layout/integration/inline/InlineIteratorBox.cpp trunk/Source/WebCore/layout/integration/inline/InlineIteratorBox.h trunk/Source/WebCore/layout/integration/inline/InlineIteratorBoxLegacyPath.h trunk/Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h trunk/Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp trunk/Source/WebCore/rendering/InlineBoxPainter.cpp trunk/Source/WebCore/rendering/LegacyInlineFlowBox.cpp
[webkit-changes] [294278] trunk/LayoutTests
Title: [294278] trunk/LayoutTests Revision 294278 Author rack...@apple.com Date 2022-05-16 16:40:12 -0700 (Mon, 16 May 2022) Log Message [ iOS ] imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=240489 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/250622@main Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (294277 => 294278) --- trunk/LayoutTests/ChangeLog 2022-05-16 23:13:37 UTC (rev 294277) +++ trunk/LayoutTests/ChangeLog 2022-05-16 23:40:12 UTC (rev 294278) @@ -1,3 +1,12 @@ +2022-05-16 Karl Rackler + +[ iOS ] imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html is a flaky timeout +https://bugs.webkit.org/show_bug.cgi?id=240489 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: + 2022-05-16 Ziran Sun [css-ui] alias appearance keywords to 'auto' for textfield Modified: trunk/LayoutTests/platform/ios/TestExpectations (294277 => 294278) --- trunk/LayoutTests/platform/ios/TestExpectations 2022-05-16 23:13:37 UTC (rev 294277) +++ trunk/LayoutTests/platform/ios/TestExpectations 2022-05-16 23:40:12 UTC (rev 294278) @@ -3615,3 +3615,5 @@ webkit.org/b/240348 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-videoDetectorTest.html [ Failure ] webkit.org/b/240463 imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html [ Failure ] + +webkit.org/b/240489 imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html [ Slow ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294277] branches/safari-613-branch
Title: [294277] branches/safari-613-branch
Revision 294277
Author alanc...@apple.com
Date 2022-05-16 16:13:37 -0700 (Mon, 16 May 2022)
Log Message
Apply patch. rdar://problem/88672183
Modified Paths
branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-613-branch/Source/WebCore/rendering/RenderLayerBacking.cpp
branches/safari-613-branch/Source/WebCore/rendering/style/KeyframeList.cpp
branches/safari-613-branch/Source/WebCore/rendering/style/KeyframeList.h
Added Paths
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-multiple-from-to-keyframes-with-only-timing-function-expected.txt
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-multiple-from-to-keyframes-with-only-timing-function.html
Diff
Modified: branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog (294276 => 294277)
--- branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog 2022-05-16 23:13:31 UTC (rev 294276)
+++ branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog 2022-05-16 23:13:37 UTC (rev 294277)
@@ -1,3 +1,24 @@
+2022-05-16 Alan Coon
+
+Apply patch. rdar://problem/88672183
+
+2022-02-19 Antoine Quint
+
+REGRESSION (r287524): hihello.me does not show sliding sheet at the bottom of the page
+https://bugs.webkit.org/show_bug.cgi?id=236838
+rdar://88672183
+
+Reviewed by Dean Jackson.
+
+Add new WPT tests to check we correctly compute implicit keyframes when a 0% and/or 100% keyframe
+is defined but only specifies a timing function. One test checks the output of getKeyframes() and
+the other that we correctly account for the implicit vaues when computing styles.
+
+* web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt:
+* web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html:
+* web-platform-tests/css/css-animations/animation-multiple-from-to-keyframes-with-only-timing-function-expected.txt: Added.
+* web-platform-tests/css/css-animations/animation-multiple-from-to-keyframes-with-only-timing-function.html: Added.
+
2022-04-22 Alan Coon
Cherry-pick r291589. rdar://problem/90511155
Modified: branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt (294276 => 294277)
--- branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt 2022-05-16 23:13:31 UTC (rev 294276)
+++ branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt 2022-05-16 23:13:37 UTC (rev 294277)
@@ -24,4 +24,5 @@
PASS KeyframeEffect.getKeyframes() returns expected values for animations with a CSS variable which is overriden by the value in keyframe
PASS KeyframeEffect.getKeyframes() returns expected values for animations with only custom property in a keyframe
PASS KeyframeEffect.getKeyframes() reflects changes to @keyframes rules
+PASS KeyframeEffect.getKeyframes() returns expected values for animations with implicit values and a non-default timingfunction specified for 0% and 100%
Modified: branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html (294276 => 294277)
--- branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html 2022-05-16 23:13:31 UTC (rev 294276)
+++ branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html 2022-05-16 23:13:37 UTC (rev 294277)
@@ -156,6 +156,12 @@
from { transform: translate(100px, 0) }
to { --not-used: 200px }
}
+
+@keyframes anim-only-timing-function-for-from-and-to {
+from, to { animation-timing-function: linear }
+50% { left: 10px }
+}
+
@@ -696,5 +702,23 @@
);
}, 'KeyframeEffect.getKeyframes() reflects changes to @keyframes rules');
+test(t => {
+ const div = addDiv(t);
+ div.style.animation = 'anim-only-timing-function-for-from-and-to 100s';
+
+ const frames = getKeyframes(div);
+
+ const expected = [
+{ offset: 0, computedOffset: 0, easing: "ease", composite: "auto", left: "auto" },
+{ offset: 0, computedOffset: 0, easing: "linear",
[webkit-changes] [294276] branches/safari-613-branch/Source/WebCore
Title: [294276] branches/safari-613-branch/Source/WebCore
Revision 294276
Author alanc...@apple.com
Date 2022-05-16 16:13:31 -0700 (Mon, 16 May 2022)
Log Message
Apply patch. rdar://problem/88408231
Modified Paths
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-613-branch/Source/WebCore/rendering/style/KeyframeList.cpp
branches/safari-613-branch/Source/WebCore/rendering/style/KeyframeList.h
branches/safari-613-branch/Source/WebCore/style/StyleResolver.cpp
branches/safari-613-branch/Source/WebCore/style/StyleResolver.h
Diff
Modified: branches/safari-613-branch/Source/WebCore/ChangeLog (294275 => 294276)
--- branches/safari-613-branch/Source/WebCore/ChangeLog 2022-05-16 23:03:23 UTC (rev 294275)
+++ branches/safari-613-branch/Source/WebCore/ChangeLog 2022-05-16 23:13:31 UTC (rev 294276)
@@ -1,3 +1,32 @@
+2022-05-16 Alan Coon
+
+Apply patch. rdar://problem/88408231
+
+2022-02-02 Antoine Quint
+
+Keyframe resolution methods should use reference instead of pointer parameters
+https://bugs.webkit.org/show_bug.cgi?id=236020
+
+Reviewed by Dean Jackson.
+
+The Style::Resolver::styleForKeyframe() method would take in a `const RenderStyle*`
+and a `const StyleRuleKeyframe*` but these parameters were used without null checks.
+This patch changes this method signature to take in references instead, which involves
+also changing the signature for Style::Resolver::keyframeStylesForAnimation().
+
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::getKeyframes):
+(WebCore::KeyframeEffect::updateBlendingKeyframes):
+(WebCore::KeyframeEffect::computeCSSAnimationBlendingKeyframes):
+(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
+* rendering/style/KeyframeList.cpp:
+(WebCore::KeyframeList::fillImplicitKeyframes):
+* rendering/style/KeyframeList.h:
+* style/StyleResolver.cpp:
+(WebCore::Style::Resolver::styleForKeyframe):
+(WebCore::Style::Resolver::keyframeStylesForAnimation):
+* style/StyleResolver.h:
+
2022-05-03 Sihui Liu
StorageMap::removeItem may fail to remove item from map
Modified: branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp (294275 => 294276)
--- branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp 2022-05-16 23:03:23 UTC (rev 294275)
+++ branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp 2022-05-16 23:13:31 UTC (rev 294276)
@@ -637,12 +637,13 @@
auto* target = m_target.get();
auto* renderer = this->renderer();
auto* lastStyleChangeEventStyle = targetStyleable()->lastStyleChangeEventStyle();
+auto& elementStyle = lastStyleChangeEventStyle ? *lastStyleChangeEventStyle : currentStyle();
auto computedStyleExtractor = ComputedStyleExtractor(target, false, m_pseudoId);
KeyframeList computedKeyframes(m_blendingKeyframes.animationName());
computedKeyframes.copyKeyframes(m_blendingKeyframes);
-computedKeyframes.fillImplicitKeyframes(*m_target, m_target->styleResolver(), lastStyleChangeEventStyle, nullptr);
+computedKeyframes.fillImplicitKeyframes(*m_target, m_target->styleResolver(), elementStyle, nullptr);
auto keyframeRules = [&]() -> const Vector> {
if (!is(animation()))
@@ -947,7 +948,7 @@
keyframeList.addProperty(styleProperties->propertyAt(i).id());
auto keyframeRule = StyleRuleKeyframe::create(WTFMove(styleProperties));
-keyframeValue.setStyle(styleResolver.styleForKeyframe(*m_target, , resolutionContext, keyframeRule.ptr(), keyframeValue));
+keyframeValue.setStyle(styleResolver.styleForKeyframe(*m_target, elementStyle, resolutionContext, keyframeRule.get(), keyframeValue));
keyframeList.insert(WTFMove(keyframeValue));
}
@@ -1143,7 +1144,7 @@
KeyframeList keyframeList(backingAnimation.name().string);
if (auto* styleScope = Style::Scope::forOrdinal(*m_target, backingAnimation.nameStyleScopeOrdinal()))
-styleScope->resolver().keyframeStylesForAnimation(*m_target, , resolutionContext, keyframeList);
+styleScope->resolver().keyframeStylesForAnimation(*m_target, unanimatedStyle, resolutionContext, keyframeList);
// Ensure resource loads for all the frames.
for (auto& keyframe : keyframeList.keyframes()) {
@@ -1899,7 +1900,7 @@
KeyframeList explicitKeyframes(m_blendingKeyframes.animationName());
explicitKeyframes.copyKeyframes(m_blendingKeyframes);
-explicitKeyframes.fillImplicitKeyframes(*m_target, m_target->styleResolver(), underlyingStyle.get(), nullptr);
+explicitKeyframes.fillImplicitKeyframes(*m_target, m_target->styleResolver(),
[webkit-changes] [294275] trunk
Title: [294275] trunk
Revision 294275
Author obru...@igalia.com
Date 2022-05-16 16:03:23 -0700 (Mon, 16 May 2022)
Log Message
Take intrinsicBorderForFieldset() into account in intrinsically sized fieldset
https://bugs.webkit.org/show_bug.cgi?id=240388
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Add test.
* web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size-expected.txt: Added.
* web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size.html: Added.
Source/WebCore:
With 'box-sizing: content-box', computeIntrinsicLogicalContentHeightUsing
was not taking intrinsicBorderForFieldset() into account. So a fieldset
with 'height: min-content' would ignore the extra space required by the
legend, and the contents would overflow.
This patch adds a RenderBox::adjustIntrinsicLogicalHeightForBoxSizing
method with the logic, and overrides it in RenderBlock to take
intrinsicBorderForFieldset() into account.
Test: imported/w3c/web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustIntrinsicLogicalHeightForBoxSizing const):
Take intrinsicBorderForFieldset() into account.
* rendering/RenderBlock.h:
Override adjustIntrinsicLogicalHeightForBoxSizing.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::adjustIntrinsicLogicalHeightForBoxSizing const):
(WebCore::RenderBox::computeIntrinsicLogicalContentHeightUsing const):
Move logic into a new method so that RenderBlock can override it.
* rendering/RenderBox.h:
Declare adjustIntrinsicLogicalHeightForBoxSizing as virtual.
No need for computeIntrinsicLogicalContentHeightUsing to be virtual.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (294274 => 294275)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-16 22:59:07 UTC (rev 294274)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-16 23:03:23 UTC (rev 294275)
@@ -1,3 +1,15 @@
+2022-05-16 Oriol Brufau
+
+Take intrinsicBorderForFieldset() into account in intrinsically sized fieldset
+https://bugs.webkit.org/show_bug.cgi?id=240388
+
+Reviewed by Darin Adler.
+
+Add test.
+
+* web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size-expected.txt: Added.
+* web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size.html: Added.
+
2022-05-16 Tim Nguyen
[css-ui] Unexpose attachment and borderless-attachment appearance values
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size-expected.txt (0 => 294275)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size-expected.txt 2022-05-16 23:03:23 UTC (rev 294275)
@@ -0,0 +1,19 @@
+
+PASS auto content-box
+PASS auto border-box
+PASS min-content content-box
+PASS min-content border-box
+PASS max-content content-box
+PASS max-content border-box
+Legend
+Contents
+Legend
+Contents
+Legend
+Contents
+Legend
+Contents
+Legend
+Contents
+Legend
+Contents
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size.html (0 => 294275)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size.html 2022-05-16 23:03:23 UTC (rev 294275)
@@ -0,0 +1,74 @@
+
+
+Fieldset with intrinsic size
+
+
+fieldset {
+ height: min-content;
+ padding: 7px;
+ border: 3px solid cyan;
+}
+fieldset > div {
+ border: 3px solid orange;
+}
+.auto {
+ height: auto;
+}
+.min-content {
+ height: min-content;
+}
+.max-content {
+ height: max-content;
+}
+.content-box {
+ box-sizing: content-box;
+}
+.border-box {
+ box-sizing: border-box;
+}
+
+
+
+
+
+ Legend
+ Contents
+
+
+ Legend
+ Contents
+
+
+ Legend
+ Contents
+
+
+ Legend
+ Contents
+
+
+ Legend
+ Contents
+
+
+ Legend
+ Contents
+
+
+
+for (let fieldset of document.querySelectorAll("fieldset")) {
+ test(function() {
+const fieldsetRect
[webkit-changes] [294274] trunk/Source/WebKit
Title: [294274] trunk/Source/WebKit Revision 294274 Author timothy_hor...@apple.com Date 2022-05-16 15:59:07 -0700 (Mon, 16 May 2022) Log Message Fix the build after 250556@main * Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer): Maintain the status quo here, for now, by adopting unsafeBuffer(). Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm Diff Modified: trunk/Source/WebKit/ChangeLog (294273 => 294274) --- trunk/Source/WebKit/ChangeLog 2022-05-16 22:56:32 UTC (rev 294273) +++ trunk/Source/WebKit/ChangeLog 2022-05-16 22:59:07 UTC (rev 294274) @@ -1,3 +1,11 @@ +2022-05-16 Tim Horton + +Fix the build after 250556@main + +* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: +(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer): +Maintain the status quo here, for now, by adopting unsafeBuffer(). + 2022-05-16 Yury Semikhatsky [SOUP2] Compute number of header bytes whe using soup 2 Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm (294273 => 294274) --- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2022-05-16 22:56:32 UTC (rev 294273) +++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2022-05-16 22:59:07 UTC (rev 294274) @@ -606,7 +606,7 @@ [layer setValue:@1 forKeyPath:WKCGDisplayListBifurcationEnabledKey]; } else layer.opaque = m_isOpaque; -auto data = "" +auto data = "" [(WKCompositingLayer *)layer _setWKContents:contents.get() withDisplayList:data.get() replayForTesting:replayCGDisplayListsIntoBackingStore]; return; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294273] trunk/Source/WebCore
Title: [294273] trunk/Source/WebCore
Revision 294273
Author hironori.fu...@sony.com
Date 2022-05-16 15:56:32 -0700 (Mon, 16 May 2022)
Log Message
[CMake][VS] PrivateHeaders/WebCore/WebCoreJSBuiltinInternals.h is not updated in incremental build
https://bugs.webkit.org/show_bug.cgi?id=240297
Reviewed by Don Olmstead.
In CMake Visual Studio generator builds,
WebCoreJSBuiltinInternals.h was not copied to the private headers
directory as expected in incremental builds.
${WebCore_DERIVED_SOURCES_DIR}/WebCoreJSBuiltinInternals.h was
added to both WebCore_SOURCES and WebCore_PRIVATE_FRAMEWORK_HEADERS.
This caused the incremental build problem. Don't add the headers
to WebCore_SOURCES.
There was another minor problem. ${WebCore_BUILTINS_SOURCES} was
passed to the MAIN_DEPENDENCY argument of add_custom_command.
However, MAIN_DEPENDENCY argument should take a single file. It
should be passed to DEPENDS argument.
* CMakeLists.txt:
Modified Paths
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (294272 => 294273)
--- trunk/Source/WebCore/CMakeLists.txt 2022-05-16 22:43:21 UTC (rev 294272)
+++ trunk/Source/WebCore/CMakeLists.txt 2022-05-16 22:56:32 UTC (rev 294273)
@@ -2377,15 +2377,12 @@
${WebCore_DERIVED_SOURCES_DIR}/WebCoreJSBuiltinInternals.cpp
${WebCore_DERIVED_SOURCES_DIR}/WebCoreJSBuiltins.h
${WebCore_DERIVED_SOURCES_DIR}/WebCoreJSBuiltinInternals.h
-MAIN_DEPENDENCY ${WebCore_BUILTINS_SOURCES}
-DEPENDS ${BUILTINS_GENERATOR_SCRIPTS} ${WebCore_DERIVED_BUILTIN_HEADERS}
+DEPENDS ${BUILTINS_GENERATOR_SCRIPTS} ${WebCore_DERIVED_BUILTIN_HEADERS} ${WebCore_BUILTINS_SOURCES}
COMMAND ${PYTHON_EXECUTABLE} ${_javascript_Core_SCRIPTS_DIR}/generate-js-builtins.py --wrappers-only --framework WebCore --output-directory ${WebCore_DERIVED_SOURCES_DIR} ${WebCore_BUILTINS_SOURCES}
VERBATIM)
list(APPEND WebCore_SOURCES
${WebCore_DERIVED_SOURCES_DIR}/WebCoreJSBuiltins.cpp
-${WebCore_DERIVED_SOURCES_DIR}/WebCoreJSBuiltinInternals.cpp
-${WebCore_DERIVED_SOURCES_DIR}/WebCoreJSBuiltins.h
-${WebCore_DERIVED_SOURCES_DIR}/WebCoreJSBuiltinInternals.h)
+${WebCore_DERIVED_SOURCES_DIR}/WebCoreJSBuiltinInternals.cpp)
ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES(${WEBCORE_DIR}/html/HTMLTreeBuilder.cpp MathMLNames.cpp)
Modified: trunk/Source/WebCore/ChangeLog (294272 => 294273)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 22:43:21 UTC (rev 294272)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 22:56:32 UTC (rev 294273)
@@ -1,3 +1,26 @@
+2022-05-16 Fujii Hironori
+
+[CMake][VS] PrivateHeaders/WebCore/WebCoreJSBuiltinInternals.h is not updated in incremental build
+https://bugs.webkit.org/show_bug.cgi?id=240297
+
+Reviewed by Don Olmstead.
+
+In CMake Visual Studio generator builds,
+WebCoreJSBuiltinInternals.h was not copied to the private headers
+directory as expected in incremental builds.
+
+${WebCore_DERIVED_SOURCES_DIR}/WebCoreJSBuiltinInternals.h was
+added to both WebCore_SOURCES and WebCore_PRIVATE_FRAMEWORK_HEADERS.
+This caused the incremental build problem. Don't add the headers
+to WebCore_SOURCES.
+
+There was another minor problem. ${WebCore_BUILTINS_SOURCES} was
+passed to the MAIN_DEPENDENCY argument of add_custom_command.
+However, MAIN_DEPENDENCY argument should take a single file. It
+should be passed to DEPENDS argument.
+
+* CMakeLists.txt:
+
2022-05-16 Tim Nguyen
[css-ui] Unexpose attachment and borderless-attachment appearance values
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294272] trunk/Source/WTF
Title: [294272] trunk/Source/WTF Revision 294272 Author bfulg...@apple.com Date 2022-05-16 15:43:21 -0700 (Mon, 16 May 2022) Log Message Correct erroneous guard in Platform file https://bugs.webkit.org/show_bug.cgi?id=240469 Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformEnableCocoa.h Diff Modified: trunk/Source/WTF/ChangeLog (294271 => 294272) --- trunk/Source/WTF/ChangeLog 2022-05-16 22:35:27 UTC (rev 294271) +++ trunk/Source/WTF/ChangeLog 2022-05-16 22:43:21 UTC (rev 294272) @@ -1,5 +1,17 @@ 2022-05-16 Brent Fulgham +Correct erroneous guard in Platform file +https://bugs.webkit.org/show_bug.cgi?id=240469 + + +Reviewed by Geoff Garen. + +SSIA. + +* wtf/PlatformEnableCocoa.h: + +2022-05-16 Brent Fulgham + Remove abandoned WebKitAdditionsFeature1 flag (240462) https://bugs.webkit.org/show_bug.cgi?id=240462 Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (294271 => 294272) --- trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2022-05-16 22:35:27 UTC (rev 294271) +++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2022-05-16 22:43:21 UTC (rev 294272) @@ -441,7 +441,7 @@ #define ENABLE_NON_VISIBLE_WEBPROCESS_MEMORY_CLEANUP_TIMER 1 #endif -#if !defined(ENABLE_NOTIFICATIONS) && (PLATFORM(MAC) || PLATFORM(IOS)) +#if !defined(ENABLE_NOTIFICATIONS) && PLATFORM(MAC) #define ENABLE_NOTIFICATIONS 1 #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294271] trunk/Source/ThirdParty/ANGLE
Title: [294271] trunk/Source/ThirdParty/ANGLE
Revision 294271
Author commit-qu...@webkit.org
Date 2022-05-16 15:35:27 -0700 (Mon, 16 May 2022)
Log Message
-Wdangling-pointer warning when building ANGLE with GCC 12
https://bugs.webkit.org/show_bug.cgi?id=239339
Patch by Michael Catanzaro on 2022-05-16
Reviewed by Yusuke Suzuki and Kenneth Russell.
* Source/ThirdParty/ANGLE/CMakeLists.txt:
Canonical link: https://commits.webkit.org/250617@main
Modified Paths
trunk/Source/ThirdParty/ANGLE/CMakeLists.txt
trunk/Source/ThirdParty/ANGLE/ChangeLog
Diff
Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (294270 => 294271)
--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt 2022-05-16 22:26:41 UTC (rev 294270)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt 2022-05-16 22:35:27 UTC (rev 294271)
@@ -244,6 +244,7 @@
if (TARGET ${angle_target})
WEBKIT_ADD_TARGET_CXX_FLAGS(${angle_target}
-Wno-cast-align
+-Wno-dangling-pointer
-Wno-extra
-Wno-suggest-attribute=format
-Wno-undef
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (294270 => 294271)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2022-05-16 22:26:41 UTC (rev 294270)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2022-05-16 22:35:27 UTC (rev 294271)
@@ -1,3 +1,16 @@
+2022-05-09 Michael Catanzaro
+
+-Wdangling-pointer warning when building ANGLE with GCC 12
+https://bugs.webkit.org/show_bug.cgi?id=239339
+
+
+Reviewed by Yusuke Suzuki and Kenneth Russell.
+
+Add -Wdangling-pointer to the list of warnings that we suppress. This looks more likely to
+be a false positive than a security issue.
+
+* CMakeLists.txt:
+
2022-04-27 Kimmo Kinnunen
Update ANGLE to 2022-04-26 (7ca11287a056d4150cba96c9c9b964153ad539cb)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294269] branches/safari-613-branch/Source
Title: [294269] branches/safari-613-branch/Source Revision 294269 Author alanc...@apple.com Date 2022-05-16 15:26:37 -0700 (Mon, 16 May 2022) Log Message Revert "Versioning." This reverts r294068. Modified Paths branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294268 => 294269) --- branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-16 22:25:50 UTC (rev 294268) +++ branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-16 22:26:37 UTC (rev 294269) @@ -25,8 +25,8 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 0; -NANO_VERSION = 1; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); +NANO_VERSION = 0; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294268 => 294269) --- branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-16 22:25:50 UTC (rev 294268) +++ branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-16 22:26:37 UTC (rev 294269) @@ -25,8 +25,8 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 0; -NANO_VERSION = 1; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); +NANO_VERSION = 0; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294268 => 294269) --- branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-16 22:25:50 UTC (rev 294268) +++ branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-16 22:26:37 UTC (rev 294269) @@ -25,8 +25,8 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 0; -NANO_VERSION = 1; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); +NANO_VERSION = 0; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig (294268 => 294269) --- branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-16 22:25:50 UTC (rev 294268) +++ branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-16 22:26:37 UTC (rev 294269) @@ -25,8 +25,8 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 0; -NANO_VERSION = 1; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); +NANO_VERSION = 0; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294268 => 294269) --- branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-16 22:25:50 UTC (rev 294268) +++ branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-16 22:26:37 UTC (rev 294269) @@ -25,8 +25,8 @@ MINOR_VERSION = 3; TINY_VERSION = 1; MICRO_VERSION = 0; -NANO_VERSION = 1; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); +NANO_VERSION = 0; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified:
[webkit-changes] [294270] branches/safari-613-branch/Source
Title: [294270] branches/safari-613-branch/Source Revision 294270 Author alanc...@apple.com Date 2022-05-16 15:26:41 -0700 (Mon, 16 May 2022) Log Message Versioning. WebKit-7613.3.2 Modified Paths branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294269 => 294270) --- branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-16 22:26:37 UTC (rev 294269) +++ branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-16 22:26:41 UTC (rev 294270) @@ -23,7 +23,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294269 => 294270) --- branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-16 22:26:37 UTC (rev 294269) +++ branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-16 22:26:41 UTC (rev 294270) @@ -23,7 +23,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294269 => 294270) --- branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-16 22:26:37 UTC (rev 294269) +++ branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-16 22:26:41 UTC (rev 294270) @@ -23,7 +23,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig (294269 => 294270) --- branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-16 22:26:37 UTC (rev 294269) +++ branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-16 22:26:41 UTC (rev 294270) @@ -23,7 +23,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294269 => 294270) --- branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-16 22:26:37 UTC (rev 294269) +++ branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-16 22:26:41 UTC (rev 294270) @@ -23,7 +23,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig (294269 => 294270) --- branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-16 22:26:37 UTC (rev 294269) +++ branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-16 22:26:41 UTC (rev 294270) @@ -23,7 +23,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (294269 => 294270) --- branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-05-16 22:26:37 UTC (rev 294269) +++ branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-05-16 22:26:41 UTC (rev 294270) @@ -1,6 +1,6 @@ MAJOR_VERSION = 613; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/WebKit/Configurations/Version.xcconfig (294269 => 294270) ---
[webkit-changes] [294268] trunk/Source/WebKit
Title: [294268] trunk/Source/WebKit
Revision 294268
Author yu...@chromium.org
Date 2022-05-16 15:25:50 -0700 (Mon, 16 May 2022)
Log Message
[SOUP2] Compute number of header bytes whe using soup 2
https://bugs.webkit.org/show_bug.cgi?id=240200
Reviewed by Michael Catanzaro.
SOUP 2 lacks methods that allow to get computed head sizes (only present in v3),
calculate the sizes manually when libsoup 2 is used.
No new tests, covered by LayoutTests/http/tests/inspector/network/resource-sizes-network.html
when compiled with SOUP 2.
* NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::addHeaderSizes):
(WebKit::NetworkDataTaskSoup::didGetHeaders):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (294267 => 294268)
--- trunk/Source/WebKit/ChangeLog 2022-05-16 22:25:02 UTC (rev 294267)
+++ trunk/Source/WebKit/ChangeLog 2022-05-16 22:25:50 UTC (rev 294268)
@@ -1,3 +1,20 @@
+2022-05-16 Yury Semikhatsky
+
+[SOUP2] Compute number of header bytes whe using soup 2
+https://bugs.webkit.org/show_bug.cgi?id=240200
+
+Reviewed by Michael Catanzaro.
+
+SOUP 2 lacks methods that allow to get computed head sizes (only present in v3),
+calculate the sizes manually when libsoup 2 is used.
+
+No new tests, covered by LayoutTests/http/tests/inspector/network/resource-sizes-network.html
+when compiled with SOUP 2.
+
+* NetworkProcess/soup/NetworkDataTaskSoup.cpp:
+(WebKit::addHeaderSizes):
+(WebKit::NetworkDataTaskSoup::didGetHeaders):
+
2022-05-16 Brent Fulgham
Remove abandoned UseScreenCaptureKit preference
Modified: trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp (294267 => 294268)
--- trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp 2022-05-16 22:25:02 UTC (rev 294267)
+++ trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp 2022-05-16 22:25:50 UTC (rev 294268)
@@ -1218,6 +1218,15 @@
return *m_networkLoadMetrics.additionalNetworkLoadMetricsForWebInspector;
}
+#if USE(SOUP2)
+static void addHeaderSizes(const char *name, const char *value, gpointer pointer)
+{
+uint64_t* size = static_cast(pointer);
+// Each header is formatted as ": \r\n"
+*size += strlen(name) + strlen(value) + 4;
+}
+#endif
+
void NetworkDataTaskSoup::didGetHeaders()
{
// We are a bit more conservative with the persistent credential storage than the session store,
@@ -1263,6 +1272,20 @@
additionalMetrics.tlsProtocol = tlsProtocolVersionToString(soup_message_get_tls_protocol_version(m_soupMessage.get()));
additionalMetrics.tlsCipher = String::fromUTF8(soup_message_get_tls_ciphersuite_name(m_soupMessage.get()));
additionalMetrics.responseHeaderBytesReceived = soup_message_metrics_get_response_header_bytes_received(metrics);
+#else
+{
+auto* requestHeaders = soup_message_get_request_headers(m_soupMessage.get());
+uint64_t requestHeadersSize = 0;
+soup_message_headers_foreach(requestHeaders, addHeaderSizes, );
+additionalMetrics.requestHeaderBytesSent = requestHeadersSize;
+}
+
+{
+auto* responseHeaders = soup_message_get_response_headers(m_soupMessage.get());
+uint64_t responseHeadersSize = 0;
+soup_message_headers_foreach(responseHeaders, addHeaderSizes, );
+additionalMetrics.responseHeaderBytesReceived = responseHeadersSize;
+}
#endif
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294267] trunk
Title: [294267] trunk Revision 294267 Author n...@apple.com Date 2022-05-16 15:25:02 -0700 (Mon, 16 May 2022) Log Message [css-ui] Unexpose attachment and borderless-attachment appearance values https://bugs.webkit.org/show_bug.cgi?id=240447 Reviewed by Tim Horton. Hide them behind the attachmentElementEnabled setting. Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html LayoutTests: * imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Source/WebCore: * css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): Canonical link: https://commits.webkit.org/250615@main Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (294266 => 294267) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-16 22:18:15 UTC (rev 294266) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-16 22:25:02 UTC (rev 294267) @@ -1,5 +1,18 @@ 2022-05-16 Tim Nguyen +[css-ui] Unexpose attachment and borderless-attachment appearance values +https://bugs.webkit.org/show_bug.cgi?id=240447 + +Reviewed by Tim Horton. + +Hide them behind the attachmentElementEnabled setting. + +Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html + +* web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: + +2022-05-16 Tim Nguyen + [css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal https://bugs.webkit.org/show_bug.cgi?id=240448 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (294266 => 294267) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-16 22:18:15 UTC (rev 294266) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-16 22:25:02 UTC (rev 294267) @@ -17,9 +17,9 @@ PASS -webkit-appearance: textarea PASS -webkit-appearance: textfield PASS -webkit-appearance: bogus-button (invalid) -FAIL -webkit-appearance: attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "attachment" +PASS -webkit-appearance: attachment (invalid) PASS -webkit-appearance: button-bevel (invalid) -FAIL -webkit-appearance: borderless-attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "borderless-attachment" +PASS -webkit-appearance: borderless-attachment (invalid) PASS -webkit-appearance: button-arrow-down (invalid) PASS -webkit-appearance: button-arrow-next (invalid) PASS -webkit-appearance: button-arrow-previous (invalid) @@ -180,9 +180,9 @@ PASS appearance: textarea PASS appearance: textfield PASS appearance: bogus-button (invalid) -FAIL appearance: attachment (invalid) assert_equals: style.appearance expected "" but got "attachment" +PASS appearance: attachment (invalid) PASS appearance: button-bevel (invalid) -FAIL appearance: borderless-attachment (invalid) assert_equals: style.appearance expected "" but got "borderless-attachment" +PASS appearance: borderless-attachment (invalid) PASS appearance: button-arrow-down (invalid) PASS appearance: button-arrow-next (invalid) PASS appearance: button-arrow-previous (invalid) Modified: trunk/Source/WebCore/ChangeLog (294266 => 294267) --- trunk/Source/WebCore/ChangeLog 2022-05-16 22:18:15 UTC (rev 294266) +++ trunk/Source/WebCore/ChangeLog 2022-05-16 22:25:02 UTC (rev 294267) @@ -1,5 +1,19 @@ 2022-05-16 Tim Nguyen +[css-ui] Unexpose attachment and borderless-attachment appearance values +https://bugs.webkit.org/show_bug.cgi?id=240447 + +Reviewed by Tim Horton. + +Hide them behind the attachmentElementEnabled setting. + +Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html + +* css/parser/CSSParserFastPaths.cpp: +(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): + +2022-05-16 Tim Nguyen + [css-ui] Update documentation for appearance CSS property https://bugs.webkit.org/show_bug.cgi?id=240481 Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (294266 => 294267) --- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-05-16 22:18:15 UTC (rev 294266) +++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-05-16 22:25:02 UTC (rev 294267) @@ -750,8 +750,13 @@ return valueID == CSSValueNone || valueID == CSSValueNonScalingStroke; case CSSPropertyVisibility: // visible | hidden | collapse return valueID == CSSValueVisible || valueID == CSSValueHidden || valueID == CSSValueCollapse; -case
[webkit-changes] [294266] trunk/Source
Title: [294266] trunk/Source
Revision 294266
Author n...@apple.com
Date 2022-05-16 15:18:15 -0700 (Mon, 16 May 2022)
Log Message
[css-ui] Update documentation for appearance CSS property
https://bugs.webkit.org/show_bug.cgi?id=240481
Reviewed by Devin Rousso.
Account for r294226, r294187 and r294170.
Source/WebCore:
* css/CSSProperties.json:
Source/WebInspectorUI:
* UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
* UserInterface/External/CSSDocumentation/CSSDocumentation.js:
Canonical link: https://commits.webkit.org/250614@main
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json
trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (294265 => 294266)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 21:53:34 UTC (rev 294265)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 22:18:15 UTC (rev 294266)
@@ -1,3 +1,14 @@
+2022-05-16 Tim Nguyen
+
+[css-ui] Update documentation for appearance CSS property
+https://bugs.webkit.org/show_bug.cgi?id=240481
+
+Reviewed by Devin Rousso.
+
+Account for r294226, r294187 and r294170.
+
+* css/CSSProperties.json:
+
2022-05-16 Brent Fulgham
Remove abandoned UseScreenCaptureKit preference
Modified: trunk/Source/WebCore/css/CSSProperties.json (294265 => 294266)
--- trunk/Source/WebCore/css/CSSProperties.json 2022-05-16 21:53:34 UTC (rev 294265)
+++ trunk/Source/WebCore/css/CSSProperties.json 2022-05-16 22:18:15 UTC (rev 294266)
@@ -5164,9 +5164,7 @@
"square-button",
"button",
"default-button",
-"inner-spin-button",
"listbox",
-"listitem",
"media-controls-dark-bar-background",
"media-controls-light-bar-background",
"media-fullscreen-volume-slider",
@@ -5181,18 +5179,9 @@
"menulist-button",
"meter",
"progress-bar",
-"progress-bar-value",
"slider-horizontal",
"slider-vertical",
-"sliderthumb-horizontal",
-"sliderthumb-vertical",
-"caret",
"searchfield",
-"searchfield-decoration",
-"searchfield-results-decoration",
-"searchfield-results-button",
-"searchfield-cancel-button",
-"snapshotted-plugin-overlay",
"textfield",
"relevancy-level-indicator",
"continuous-capacity-level-indicator",
@@ -5200,10 +5189,6 @@
"rating-level-indicator",
"-apple-pay-button",
"textarea",
-"attachment",
-"caps-lock-indicator",
-"color-well",
-"list-button",
"auto",
"none"
],
Modified: trunk/Source/WebInspectorUI/ChangeLog (294265 => 294266)
--- trunk/Source/WebInspectorUI/ChangeLog 2022-05-16 21:53:34 UTC (rev 294265)
+++ trunk/Source/WebInspectorUI/ChangeLog 2022-05-16 22:18:15 UTC (rev 294266)
@@ -1,3 +1,15 @@
+2022-05-16 Tim Nguyen
+
+[css-ui] Update documentation for appearance CSS property
+https://bugs.webkit.org/show_bug.cgi?id=240481
+
+Reviewed by Devin Rousso.
+
+Account for r294226, r294187 and r294170.
+
+* UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
+* UserInterface/External/CSSDocumentation/CSSDocumentation.js:
+
2022-05-13 Anjali Kumar
Web Inspector: [Meta] Implement Timelines Film Strip
Modified: trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json (294265 => 294266)
--- trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json 2022-05-16 21:53:34 UTC (rev 294265)
+++ trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json 2022-05-16 22:18:15 UTC (rev 294266)
@@ -4,6 +4,6 @@
},
"-webkit-appearance": {
"description": "Changes the appearance of buttons and other controls to resemble native controls.",
-"syntax": "none | button | caret | checkbox | default-button | inner-spin-button | listbox | listitem | media-play-button | media-slider | media-sliderthumb | media-volume-slider | media-volume-sliderthumb | menulist | menulist-button | meter | progress-bar | progress-bar-value | push-button | radio | searchfield | searchfield-cancel-button | searchfield-decoration | searchfield-results-button | searchfield-results-decoration | slider-horizontal | slider-vertical |
[webkit-changes] [294265] trunk/Source/WTF
Title: [294265] trunk/Source/WTF Revision 294265 Author bfulg...@apple.com Date 2022-05-16 14:53:34 -0700 (Mon, 16 May 2022) Log Message Remove abandoned WebKitAdditionsFeature1 flag (240462) https://bugs.webkit.org/show_bug.cgi?id=240462 Reviewed by Alex Christensen. Remove the abandoned WebKitAdditionsFeature1 preference, since it ended up not being needed and now just complicates the build and generated preferences. * Scripts/Preferences/WebPreferencesExperimental.yaml: * wtf/ExperimentalFeatureNames.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml trunk/Source/WTF/wtf/ExperimentalFeatureNames.h Diff Modified: trunk/Source/WTF/ChangeLog (294264 => 294265) --- trunk/Source/WTF/ChangeLog 2022-05-16 21:44:55 UTC (rev 294264) +++ trunk/Source/WTF/ChangeLog 2022-05-16 21:53:34 UTC (rev 294265) @@ -1,5 +1,20 @@ 2022-05-16 Brent Fulgham +Remove abandoned WebKitAdditionsFeature1 flag (240462) +https://bugs.webkit.org/show_bug.cgi?id=240462 + + +Reviewed by Alex Christensen. + +Remove the abandoned WebKitAdditionsFeature1 preference, since +it ended up not being needed and now just complicates the build +and generated preferences. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: +* wtf/ExperimentalFeatureNames.h: + +2022-05-16 Brent Fulgham + Remove abandoned UseScreenCaptureKit preference https://bugs.webkit.org/show_bug.cgi?id=240460 Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (294264 => 294265) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-05-16 21:44:55 UTC (rev 294264) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-05-16 21:53:34 UTC (rev 294265) @@ -1660,18 +1660,6 @@ "HAVE(WEBGL_COMPATIBLE_METAL)": true default: false -WebKitAdditionsFeature1Enabled: - type: bool - humanReadableName: WebKitAdditionsFeature1HumanReadableName - humanReadableDescription: WebKitAdditionsFeature1HumanReadableDescription - defaultValue: -WebKitLegacy: - default: false -WebKit: - default: false -WebCore: - default: false - WebLocksAPIEnabled: type: bool humanReadableName: "Web Locks API" Modified: trunk/Source/WTF/wtf/ExperimentalFeatureNames.h (294264 => 294265) --- trunk/Source/WTF/wtf/ExperimentalFeatureNames.h 2022-05-16 21:44:55 UTC (rev 294264) +++ trunk/Source/WTF/wtf/ExperimentalFeatureNames.h 2022-05-16 21:53:34 UTC (rev 294265) @@ -31,11 +31,6 @@ #include -#else - -#define WebKitAdditionsFeature1HumanReadableName "WebKitAdditions Feature" -#define WebKitAdditionsFeature1HumanReadableDescription "WebKitAdditions Feature" - #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294264] trunk
Title: [294264] trunk Revision 294264 Author bfulg...@apple.com Date 2022-05-16 14:44:55 -0700 (Mon, 16 May 2022) Log Message Remove abandoned UseScreenCaptureKit preference https://bugs.webkit.org/show_bug.cgi?id=240460 Reviewed by Youenn Fablet. We no longer need this switch to activate ScreenCaptureKit, and this code is no longer used. We should remove it to simplify the build and reduce complexity. Source/WebCore: * platform/mediastream/RealtimeMediaSourceCenter.h: (WebCore::RealtimeMediaSourceCenter::useScreenCaptureKit const): Deleted. (WebCore::RealtimeMediaSourceCenter::setUseScreenCaptureKit): Deleted. Source/WebKit: * GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::setUseScreenCaptureKit): Deleted. * GPUProcess/GPUProcess.h: * GPUProcess/GPUProcess.messages.in: * Shared/WebPreferencesDefaultValues.cpp: (WebKit::defaultScreenCaptureKitEnabled): Deleted. * Shared/WebPreferencesDefaultValues.h: * UIProcess/API/Cocoa/WKPreferences.mm: (-[WKPreferences _useScreenCaptureKit]): Deleted. (-[WKPreferences _setUseScreenCaptureKit:]): Deleted. * UIProcess/API/Cocoa/WKPreferencesPrivate.h: * UIProcess/GPU/GPUProcessProxy.cpp: (WebKit::GPUProcessProxy::updatePreferences): * UIProcess/UserMediaPermissionRequestManagerProxy.cpp: (WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs const): Source/WTF: * Scripts/Preferences/WebPreferencesExperimental.yaml: Tools: * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm: (TestWebKitAPI::TEST): Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h trunk/Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h trunk/Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/GPUProcess/GPUProcess.cpp trunk/Source/WebKit/GPUProcess/GPUProcess.h trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm Diff Modified: trunk/Source/WTF/ChangeLog (294263 => 294264) --- trunk/Source/WTF/ChangeLog 2022-05-16 21:43:21 UTC (rev 294263) +++ trunk/Source/WTF/ChangeLog 2022-05-16 21:44:55 UTC (rev 294264) @@ -1,3 +1,16 @@ +2022-05-16 Brent Fulgham + +Remove abandoned UseScreenCaptureKit preference +https://bugs.webkit.org/show_bug.cgi?id=240460 + + +Reviewed by Youenn Fablet. + +We no longer need this switch to activate ScreenCaptureKit, and this code is no +longer used. We should remove it to simplify the build and reduce complexity. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + 2022-05-15 Wenson Hsieh Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (294263 => 294264) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-05-16 21:43:21 UTC (rev 294263) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-05-16 21:44:55 UTC (rev 294264) @@ -1494,19 +1494,6 @@ "PLATFORM(WIN)": true default: false -UseScreenCaptureKit: - type: bool - condition: HAVE(SCREEN_CAPTURE_KIT) - humanReadableName: "Use ScreenCaptureKit" - humanReadableDescription: "Use ScreenCaptureKit when available" - defaultValue: -WebKitLegacy: - default: false -WebKit: - default: WebKit::defaultScreenCaptureKitEnabled() -WebCore: - default: false - UserGesturePromisePropagationEnabled: type: bool humanReadableName: "UserGesture Promise Propagation" Modified: trunk/Source/WebCore/ChangeLog (294263 => 294264) --- trunk/Source/WebCore/ChangeLog 2022-05-16 21:43:21 UTC (rev 294263) +++ trunk/Source/WebCore/ChangeLog 2022-05-16 21:44:55 UTC (rev 294264) @@ -1,3 +1,18 @@ +2022-05-16 Brent Fulgham + +Remove abandoned UseScreenCaptureKit preference +https://bugs.webkit.org/show_bug.cgi?id=240460 + + +Reviewed by Youenn Fablet. + +We no longer need this switch to activate ScreenCaptureKit, and this code is no +longer used. We should remove it to simplify the build and reduce complexity. + +* platform/mediastream/RealtimeMediaSourceCenter.h: +(WebCore::RealtimeMediaSourceCenter::useScreenCaptureKit const): Deleted. +(WebCore::RealtimeMediaSourceCenter::setUseScreenCaptureKit): Deleted. +
[webkit-changes] [294263] trunk/Tools/buildstream
Title: [294263] trunk/Tools/buildstream Revision 294263 Author ape...@igalia.com Date 2022-05-16 14:43:21 -0700 (Mon, 16 May 2022) Log Message [Flatpak SDK] Update libwpe to version 1.13.2 https://bugs.webkit.org/show_bug.cgi?id=240470 Reviewed by Philippe Normand. * elements/sdk/libwpe.bst: Update to version 1.13.2, switch download URL to the canonical release site while at it. Canonical link: https://commits.webkit.org/250611@main Modified Paths trunk/Tools/buildstream/ChangeLog trunk/Tools/buildstream/elements/sdk/libwpe.bst Diff Modified: trunk/Tools/buildstream/ChangeLog (294262 => 294263) --- trunk/Tools/buildstream/ChangeLog 2022-05-16 21:41:43 UTC (rev 294262) +++ trunk/Tools/buildstream/ChangeLog 2022-05-16 21:43:21 UTC (rev 294263) @@ -1,3 +1,13 @@ +2022-05-16 Adrian Perez de Castro + +[Flatpak SDK] Bump libwpe to version 1.13.2 +https://bugs.webkit.org/show_bug.cgi?id=240470 + +Reviewed by Philippe Normand. + +* elements/sdk/libwpe.bst: Update to version 1.13.2, switch download URL to the +canonical release site while at it. + 2022-05-15 Philippe Normand [Flatpak SDK] Update to pipewire master Modified: trunk/Tools/buildstream/elements/sdk/libwpe.bst (294262 => 294263) --- trunk/Tools/buildstream/elements/sdk/libwpe.bst 2022-05-16 21:41:43 UTC (rev 294262) +++ trunk/Tools/buildstream/elements/sdk/libwpe.bst 2022-05-16 21:43:21 UTC (rev 294263) @@ -1,8 +1,8 @@ kind: meson sources: - kind: tar - url: github_com:WebPlatformForEmbedded/libwpe/releases/download/1.12.0/libwpe-1.12.0.tar.xz - ref: e8eeca228a6b4c36294cfb63f7d3ba9ada47a430904a5a973b3c99c96a44c18c + url: https://wpewebkit.org/releases//libwpe-1.13.2.tar.xz + ref: efcd97dc0f95ff7a506483ba3df944669cdc602b3fc45c9fd676dee0f8f92cac build-depends: - freedesktop-sdk.bst:public-stacks/buildsystem-meson.bst depends: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294262] trunk/Source/WebCore
Title: [294262] trunk/Source/WebCore
Revision 294262
Author commit-qu...@webkit.org
Date 2022-05-16 14:41:43 -0700 (Mon, 16 May 2022)
Log Message
Unreviewed, fix build after 250565@main
https://bugs.webkit.org/show_bug.cgi?id=240416
Patch by Michael Catanzaro on 2022-05-16
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::debugTextShadow const):
Canonical link: https://commits.webkit.org/250610@main
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/TextBoxPainter.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (294261 => 294262)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 21:37:00 UTC (rev 294261)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 21:41:43 UTC (rev 294262)
@@ -1,3 +1,14 @@
+2022-05-16 Michael Catanzaro
+
+Unreviewed, fix build after 250565@main
+https://bugs.webkit.org/show_bug.cgi?id=240416
+
+
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
+* rendering/TextBoxPainter.cpp:
+(WebCore::TextBoxPainter::debugTextShadow const):
+
2022-05-16 Ziran Sun
[css-ui] alias appearance keywords to 'auto' for textfield
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (294261 => 294262)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2022-05-16 21:37:00 UTC (rev 294261)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2022-05-16 21:41:43 UTC (rev 294262)
@@ -732,8 +732,10 @@
textBoxPainter.paint();
continue;
}
+#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
ModernTextBoxPainter textBoxPainter(box->modernPath().inlineContent(), box->modernPath().box(), maskInfo, paintOffset);
textBoxPainter.paint();
+#endif
}
return;
}
Modified: trunk/Source/WebCore/rendering/TextBoxPainter.cpp (294261 => 294262)
--- trunk/Source/WebCore/rendering/TextBoxPainter.cpp 2022-05-16 21:37:00 UTC (rev 294261)
+++ trunk/Source/WebCore/rendering/TextBoxPainter.cpp 2022-05-16 21:41:43 UTC (rev 294262)
@@ -702,14 +702,18 @@
{
if (!m_renderer.settings().legacyLineLayoutVisualCoverageEnabled())
return nullptr;
+#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
if constexpr (std::is_same_v)
return nullptr;
+#endif
static NeverDestroyed debugTextShadow(LengthPoint(Length(LengthType::Fixed), Length(LengthType::Fixed)), Length(10, LengthType::Fixed), Length(20, LengthType::Fixed), ShadowStyle::Normal, true, SRGBA { 150, 0, 0, 190 });
return ();
}
+#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
template class TextBoxPainter;
+#endif
template class TextBoxPainter;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294261] trunk
Title: [294261] trunk
Revision 294261
Author ryanhad...@apple.com
Date 2022-05-16 14:37:00 -0700 (Mon, 16 May 2022)
Log Message
Unreviewed, reverting r294238.
Breaks internal builds
Reverted changeset:
"Use _adoptEffectiveConfiguration instead of a separate
NSURLSession without credentials"
https://bugs.webkit.org/show_bug.cgi?id=240362
https://commits.webkit.org/r294238
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm
trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.mm
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (294260 => 294261)
--- trunk/Source/WebCore/PAL/ChangeLog 2022-05-16 21:21:17 UTC (rev 294260)
+++ trunk/Source/WebCore/PAL/ChangeLog 2022-05-16 21:37:00 UTC (rev 294261)
@@ -1,3 +1,16 @@
+2022-05-16 Ryan Haddad
+
+Unreviewed, reverting r294238.
+
+Breaks internal builds
+
+Reverted changeset:
+
+"Use _adoptEffectiveConfiguration instead of a separate
+NSURLSession without credentials"
+https://bugs.webkit.org/show_bug.cgi?id=240362
+https://commits.webkit.org/r294238
+
2022-05-16 Alex Christensen
Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (294260 => 294261)
--- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2022-05-16 21:21:17 UTC (rev 294260)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2022-05-16 21:37:00 UTC (rev 294261)
@@ -280,7 +280,6 @@
@end
@interface NSURLSessionTask ()
-- (void) _adoptEffectiveConfiguration:(NSURLSessionConfiguration*) newConfiguration;
- (NSDictionary *)_timingData;
@property (readwrite, copy) NSString *_pathToDownloadTaskFile;
@property (copy) NSString *_storagePartitionIdentifier;
Modified: trunk/Source/WebKit/ChangeLog (294260 => 294261)
--- trunk/Source/WebKit/ChangeLog 2022-05-16 21:21:17 UTC (rev 294260)
+++ trunk/Source/WebKit/ChangeLog 2022-05-16 21:37:00 UTC (rev 294261)
@@ -1,3 +1,16 @@
+2022-05-16 Ryan Haddad
+
+Unreviewed, reverting r294238.
+
+Breaks internal builds
+
+Reverted changeset:
+
+"Use _adoptEffectiveConfiguration instead of a separate
+NSURLSession without credentials"
+https://bugs.webkit.org/show_bug.cgi?id=240362
+https://commits.webkit.org/r294238
+
2022-05-16 J Pascoe
REGRESSION (250501@main): [ Mac ] 2 TestWebKitAPI.WebAuthenticationPanel.GetAssertionLA tests failing
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (294260 => 294261)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-05-16 21:21:17 UTC (rev 294260)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-05-16 21:37:00 UTC (rev 294261)
@@ -356,20 +356,6 @@
m_task = [m_sessionWrapper->session dataTaskWithRequest:nsRequest.get()];
-switch (parameters.storedCredentialsPolicy) {
-case WebCore::StoredCredentialsPolicy::Use:
-ASSERT(m_sessionWrapper->session.get().configuration.URLCredentialStorage);
-break;
-case WebCore::StoredCredentialsPolicy::EphemeralStateless:
-ASSERT(!m_sessionWrapper->session.get().configuration.URLCredentialStorage);
-break;
-case WebCore::StoredCredentialsPolicy::DoNotUse:
-NSURLSessionConfiguration *effectiveConfiguration = m_sessionWrapper->session.get().configuration;
-effectiveConfiguration.URLCredentialStorage = nil;
-[m_task _adoptEffectiveConfiguration:effectiveConfiguration];
-break;
-};
-
WTFBeginSignpost(m_task.get(), "DataTask", "%{public}s pri: %.2f preconnect: %d", url.string().ascii().data(), toNSURLSessionTaskPriority(request.priority()), parameters.shouldPreconnectOnly == PreconnectOnly::Yes);
RELEASE_ASSERT(!m_sessionWrapper->dataTaskMap.contains([m_task taskIdentifier]));
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h (294260 => 294261)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h 2022-05-16 21:21:17 UTC (rev 294260)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h 2022-05-16 21:37:00 UTC (rev 294261)
@@ -68,6 +68,7 @@
WTF_MAKE_FAST_ALLOCATED;
public:
SessionWrapper sessionWithCredentialStorage;
+SessionWrapper sessionWithoutCredentialStorage;
WallTime lastUsed;
};
@@ -86,6 +87,7 @@
std::unique_ptr appBoundSession;
SessionWrapper sessionWithCredentialStorage;
+SessionWrapper sessionWithoutCredentialStorage;
SessionWrapper ephemeralStatelessSession;
private:
Modified:
[webkit-changes] [294260] branches/safari-7614.1.14.1-branch
Title: [294260] branches/safari-7614.1.14.1-branch Revision 294260 Author alanc...@apple.com Date 2022-05-16 14:21:17 -0700 (Mon, 16 May 2022) Log Message Cherry-pick r294225. rdar://problem/92978482 Make sure calling showNotification will extend the service worker lifetime https://bugs.webkit.org/show_bug.cgi?id=240273 Reviewed by Chris Dumez. Source/WebCore: Update NotificationClient API so that show is taking a completion handler. Make use of this completion handler to resolve the promise when the show notification steps are done, as per spec. Register push event to ServiceWorkerGlobalScope when the event handlers are called. When ServiceWorkerRegistration::show is called during one of the push event handlers, extend the push event lifetime by adding the show notification promise to the push event. Covered by API test. * Modules/notifications/Notification.cpp: * Modules/notifications/Notification.h: * Modules/notifications/NotificationClient.h: * dom/ScriptExecutionContext.cpp: * dom/ScriptExecutionContext.h: * workers/service/ServiceWorkerGlobalScope.cpp: * workers/service/ServiceWorkerGlobalScope.h: * workers/service/ServiceWorkerRegistration.cpp: * workers/service/ServiceWorkerRegistration.h: * workers/service/context/ServiceWorkerThread.cpp: Source/WebKit: On WebProcess side, implement the new NoficationClient::show API that takes a callback. Delay calling this callback until UIProcess tells us so through async IPC. On UIProcess side, take a callback and call it when the show notification steps are done. * NetworkProcess/Notifications/NetworkNotificationManager.cpp: * NetworkProcess/Notifications/NetworkNotificationManager.h: * Shared/Notifications/NotificationManagerMessageHandler.h: * Shared/Notifications/NotificationManagerMessageHandler.messages.in: * UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp: * UIProcess/Notifications/ServiceWorkerNotificationHandler.h: * UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp: * UIProcess/Notifications/WebNotificationManagerMessageHandler.h: * WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp: * WebProcess/Notifications/WebNotificationManager.cpp: * WebProcess/Notifications/WebNotificationManager.h: * WebProcess/WebCoreSupport/WebNotificationClient.cpp: * WebProcess/WebCoreSupport/WebNotificationClient.h: Source/WebKitLegacy/mac: * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: Tools: * TestWebKitAPI/TestNotificationProvider.cpp: * TestWebKitAPI/TestNotificationProvider.h: * TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294225 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-7614.1.14.1-branch/Source/WebCore/ChangeLog branches/safari-7614.1.14.1-branch/Source/WebCore/Modules/notifications/Notification.cpp branches/safari-7614.1.14.1-branch/Source/WebCore/Modules/notifications/Notification.h branches/safari-7614.1.14.1-branch/Source/WebCore/Modules/notifications/NotificationClient.h branches/safari-7614.1.14.1-branch/Source/WebCore/dom/ScriptExecutionContext.cpp branches/safari-7614.1.14.1-branch/Source/WebCore/dom/ScriptExecutionContext.h branches/safari-7614.1.14.1-branch/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp branches/safari-7614.1.14.1-branch/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h branches/safari-7614.1.14.1-branch/Source/WebCore/workers/service/ServiceWorkerRegistration.cpp branches/safari-7614.1.14.1-branch/Source/WebCore/workers/service/ServiceWorkerRegistration.h branches/safari-7614.1.14.1-branch/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp branches/safari-7614.1.14.1-branch/Source/WebKit/ChangeLog branches/safari-7614.1.14.1-branch/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp branches/safari-7614.1.14.1-branch/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h branches/safari-7614.1.14.1-branch/Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.h branches/safari-7614.1.14.1-branch/Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.messages.in branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.h branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.h branches/safari-7614.1.14.1-branch/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp
[webkit-changes] [294259] trunk/Source/WebCore/css/CSSProperties.json
Title: [294259] trunk/Source/WebCore/css/CSSProperties.json
Revision 294259
Author mmaxfi...@apple.com
Date 2022-05-16 14:21:12 -0700 (Mon, 16 May 2022)
Log Message
Fix URL to offset-rotate property in CSSProperties.json
https://bugs.webkit.org/show_bug.cgi?id=240474
Reviewed by Myles C. Maxfield.
No new tests, not a functional change.
* Source/WebCore/css/CSSProperties.json:
Canonical link: https://commits.webkit.org/250608@main
Modified Paths
trunk/Source/WebCore/css/CSSProperties.json
Diff
Modified: trunk/Source/WebCore/css/CSSProperties.json (294258 => 294259)
--- trunk/Source/WebCore/css/CSSProperties.json 2022-05-16 21:21:07 UTC (rev 294258)
+++ trunk/Source/WebCore/css/CSSProperties.json 2022-05-16 21:21:12 UTC (rev 294259)
@@ -3715,7 +3715,7 @@
},
"specification": {
"category": "css-motion-path",
-"url": "https://drafts.fxtf.org/motion-1/#offset-anchor-property"
+"url": "https://drafts.fxtf.org/motion-1/#offset-rotate-property"
}
},
"offset": {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294258] branches/safari-7614.1.14.1-branch
Title: [294258] branches/safari-7614.1.14.1-branch Revision 294258 Author alanc...@apple.com Date 2022-05-16 14:21:07 -0700 (Mon, 16 May 2022) Log Message Cherry-pick r294218. rdar://problem/90400867 Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated https://bugs.webkit.org/show_bug.cgi?id=240427 rdar://90400867 Reviewed by Tim Horton. Add a new linked-on-or-after check to guard this new behavior for apps built against newer SDK versions. * wtf/cocoa/RuntimeApplicationChecksCocoa.h: Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated https://bugs.webkit.org/show_bug.cgi?id=240427 rdar://90400867 Reviewed by Tim Horton. Make a couple of minor adjustments to `ContextMenuController` to ensure that right clicking a link and choosing "Open Link" or "Open Link in New Window" surfaces a navigation action with `WKNavigationTypeLinkActivated`, rather than `WKNavigationTypeOther`. Test: ContextMenuTests.NavigationTypeWhenOpeningLink * page/ContextMenuContext.cpp: (WebCore::ContextMenuContext::ContextMenuContext): * page/ContextMenuContext.h: (WebCore::ContextMenuContext::event const): Save a reference to the `Event` of type "contextmenu" that's triggering context menu presentation in the `ContextMenuContext`. * page/ContextMenuController.cpp: (WebCore::ContextMenuController::maybeCreateContextMenu): (WebCore::openNewWindow): Plumb the `"contextmenu"` event through to `FrameLoader::loadFrameRequest` when opening links via context menu. (WebCore::ContextMenuController::contextMenuItemSelected): Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated https://bugs.webkit.org/show_bug.cgi?id=240427 rdar://90400867 Reviewed by Tim Horton. Add an API test to verify that right clicking a link and selecting "Open Link" triggers a navigation action with the type `WKNavigationTypeLinkActivated`. * TestWebKitAPI/Tests/mac/ContextMenuTests.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/250576@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294218 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog branches/safari-7614.1.14.1-branch/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h branches/safari-7614.1.14.1-branch/Source/WebCore/ChangeLog branches/safari-7614.1.14.1-branch/Source/WebCore/page/ContextMenuContext.cpp branches/safari-7614.1.14.1-branch/Source/WebCore/page/ContextMenuContext.h branches/safari-7614.1.14.1-branch/Source/WebCore/page/ContextMenuController.cpp branches/safari-7614.1.14.1-branch/Tools/ChangeLog branches/safari-7614.1.14.1-branch/Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm Diff Modified: branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog (294257 => 294258) --- branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog 2022-05-16 21:19:45 UTC (rev 294257) +++ branches/safari-7614.1.14.1-branch/Source/WTF/ChangeLog 2022-05-16 21:21:07 UTC (rev 294258) @@ -1,3 +1,72 @@ +2022-05-16 Alan Coon + +Cherry-pick r294218. rdar://problem/90400867 + +Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated +https://bugs.webkit.org/show_bug.cgi?id=240427 +rdar://90400867 + +Reviewed by Tim Horton. + +Add a new linked-on-or-after check to guard this new behavior for apps built against newer SDK versions. + +* wtf/cocoa/RuntimeApplicationChecksCocoa.h: +Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated +https://bugs.webkit.org/show_bug.cgi?id=240427 +rdar://90400867 + +Reviewed by Tim Horton. + +Make a couple of minor adjustments to `ContextMenuController` to ensure that right clicking a link and choosing +"Open Link" or "Open Link in New Window" surfaces a navigation action with `WKNavigationTypeLinkActivated`, +rather than `WKNavigationTypeOther`. + +Test: ContextMenuTests.NavigationTypeWhenOpeningLink + +* page/ContextMenuContext.cpp: +(WebCore::ContextMenuContext::ContextMenuContext): +* page/ContextMenuContext.h: +(WebCore::ContextMenuContext::event const): + +Save a reference to the `Event` of type "contextmenu" that's triggering context menu presentation in the +`ContextMenuContext`. + +* page/ContextMenuController.cpp: +(WebCore::ContextMenuController::maybeCreateContextMenu): +(WebCore::openNewWindow): + +Plumb the `"contextmenu"` event through to `FrameLoader::loadFrameRequest` when opening links via context menu. + +(WebCore::ContextMenuController::contextMenuItemSelected): +Right click > "Open Link" should trigger a navigation action with
[webkit-changes] [294257] releases/WebKitGTK/webkit-2.36/Source
Title: [294257] releases/WebKitGTK/webkit-2.36/Source
Revision 294257
Author ape...@igalia.com
Date 2022-05-16 14:19:45 -0700 (Mon, 16 May 2022)
Log Message
Merge r294177 - Non-unified build broken in debug mode
https://bugs.webkit.org/show_bug.cgi?id=240378
Unreviewed non-unified build fixes.
* heap/StructureAlignedMemoryAllocator.cpp: Include if needed.
Non-unified build broken in debug mode
https://bugs.webkit.org/show_bug.cgi?id=240378
Unreviewed non-unified build fixes.
* contentextensions/ContentExtensionCompiler.cpp: Add missing wtf/CrossThreadCopier.h header.
* workers/service/ServiceWorkerClients.cpp: Add missing Logging.h header.
Canonical link: https://commits.webkit.org/250544@main
Modified Paths
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/heap/StructureAlignedMemoryAllocator.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/workers/service/ServiceWorkerClients.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog (294256 => 294257)
--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog 2022-05-16 21:19:36 UTC (rev 294256)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog 2022-05-16 21:19:45 UTC (rev 294257)
@@ -1,3 +1,12 @@
+2022-05-13 Adrian Perez de Castro
+
+Non-unified build broken in debug mode
+https://bugs.webkit.org/show_bug.cgi?id=240378
+
+Unreviewed non-unified build fixes.
+
+* heap/StructureAlignedMemoryAllocator.cpp: Include if needed.
+
2022-05-13 Lauro Moura
Unreviewed, non-unified build fixes
Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/heap/StructureAlignedMemoryAllocator.cpp (294256 => 294257)
--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/heap/StructureAlignedMemoryAllocator.cpp 2022-05-16 21:19:36 UTC (rev 294256)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/heap/StructureAlignedMemoryAllocator.cpp 2022-05-16 21:19:45 UTC (rev 294257)
@@ -32,6 +32,10 @@
#include
+#if OS(UNIX) && ASSERT_ENABLED
+#include
+#endif
+
namespace JSC {
StructureAlignedMemoryAllocator::StructureAlignedMemoryAllocator(CString name)
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (294256 => 294257)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog 2022-05-16 21:19:36 UTC (rev 294256)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog 2022-05-16 21:19:45 UTC (rev 294257)
@@ -1,3 +1,13 @@
+2022-05-13 Adrian Perez de Castro
+
+Non-unified build broken in debug mode
+https://bugs.webkit.org/show_bug.cgi?id=240378
+
+Unreviewed non-unified build fixes.
+
+* contentextensions/ContentExtensionCompiler.cpp: Add missing wtf/CrossThreadCopier.h header.
+* workers/service/ServiceWorkerClients.cpp: Add missing Logging.h header.
+
2022-05-13 Lauro Moura
Unreviewed, non-unified build fixes
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp (294256 => 294257)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp 2022-05-16 21:19:36 UTC (rev 294256)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp 2022-05-16 21:19:45 UTC (rev 294257)
@@ -40,6 +40,7 @@
#include "NFA.h"
#include "NFAToDFA.h"
#include "URLFilterParser.h"
+#include
#include
#include
#include
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/workers/service/ServiceWorkerClients.cpp (294256 => 294257)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/workers/service/ServiceWorkerClients.cpp 2022-05-16 21:19:36 UTC (rev 294256)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/workers/service/ServiceWorkerClients.cpp 2022-05-16 21:19:45 UTC (rev 294257)
@@ -30,6 +30,7 @@
#include "JSDOMPromiseDeferred.h"
#include "JSServiceWorkerWindowClient.h"
+#include "Logging.h"
#include "SWContextManager.h"
#include "ServiceWorker.h"
#include "ServiceWorkerGlobalScope.h"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294256] releases/WebKitGTK/webkit-2.36/Source
Title: [294256] releases/WebKitGTK/webkit-2.36/Source
Revision 294256
Author ape...@igalia.com
Date 2022-05-16 14:19:36 -0700 (Mon, 16 May 2022)
Log Message
Merge r294154 - Unreviewed, non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=240369
Source/_javascript_Core:
* runtime/DateConversion.cpp:
Source/WebCore:
* Modules/highlight/HighlightRegister.h:
* rendering/TextPainter.h:
Modified Paths
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/runtime/DateConversion.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/Modules/highlight/HighlightRegister.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/TextPainter.h
Diff
Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog (294255 => 294256)
--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog 2022-05-16 21:15:10 UTC (rev 294255)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog 2022-05-16 21:19:36 UTC (rev 294256)
@@ -1,3 +1,10 @@
+2022-05-13 Lauro Moura
+
+Unreviewed, non-unified build fixes
+https://bugs.webkit.org/show_bug.cgi?id=240369
+
+* runtime/DateConversion.cpp:
+
2022-03-24 Yusuke Suzuki
[JSC] JSRemoteFunction thunk should materialize code-pointer
Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/runtime/DateConversion.cpp (294255 => 294256)
--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/runtime/DateConversion.cpp 2022-05-16 21:15:10 UTC (rev 294255)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/runtime/DateConversion.cpp 2022-05-16 21:19:36 UTC (rev 294256)
@@ -25,6 +25,7 @@
#include "config.h"
#include "DateConversion.h"
+#include "JSDateMath.h"
#include
#include
#include
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (294255 => 294256)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog 2022-05-16 21:15:10 UTC (rev 294255)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog 2022-05-16 21:19:36 UTC (rev 294256)
@@ -1,3 +1,11 @@
+2022-05-13 Lauro Moura
+
+Unreviewed, non-unified build fixes
+https://bugs.webkit.org/show_bug.cgi?id=240369
+
+* Modules/highlight/HighlightRegister.h:
+* rendering/TextPainter.h:
+
2022-05-09 Miguel Gomez
[Nicosia] Canvas animations don't work with threaded rendering
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/Modules/highlight/HighlightRegister.h (294255 => 294256)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/Modules/highlight/HighlightRegister.h 2022-05-16 21:15:10 UTC (rev 294255)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/Modules/highlight/HighlightRegister.h 2022-05-16 21:19:36 UTC (rev 294256)
@@ -29,6 +29,7 @@
#include "HighlightVisibility.h"
#include
#include
+#include
namespace WebCore {
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/TextPainter.h (294255 => 294256)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/TextPainter.h 2022-05-16 21:15:10 UTC (rev 294255)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/TextPainter.h 2022-05-16 21:19:36 UTC (rev 294256)
@@ -36,6 +36,7 @@
class RenderCombineText;
class ShadowData;
class TextRun;
+class Text;
struct TextPaintStyle;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294255] branches/safari-7614.1.14.1-branch/Source
Title: [294255] branches/safari-7614.1.14.1-branch/Source Revision 294255 Author alanc...@apple.com Date 2022-05-16 14:15:10 -0700 (Mon, 16 May 2022) Log Message Versioning. WebKit-7614.1.14.1.2 Modified Paths branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294254 => 294255) --- branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-16 21:01:40 UTC (rev 294254) +++ branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-16 21:15:10 UTC (rev 294255) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294254 => 294255) --- branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-16 21:01:40 UTC (rev 294254) +++ branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-16 21:15:10 UTC (rev 294255) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294254 => 294255) --- branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-16 21:01:40 UTC (rev 294254) +++ branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-16 21:15:10 UTC (rev 294255) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig (294254 => 294255) --- branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-16 21:01:40 UTC (rev 294254) +++ branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-16 21:15:10 UTC (rev 294255) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294254 => 294255) --- branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-16 21:01:40 UTC (rev 294254) +++ branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-16 21:15:10 UTC (rev 294255) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig (294254 => 294255) --- branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-16 21:01:40 UTC (rev 294254) +++ branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-16 21:15:10 UTC (rev 294255) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 1;
[webkit-changes] [294254] trunk/metadata/contributors.json
Title: [294254] trunk/metadata/contributors.json
Revision 294254
Author n...@apple.com
Date 2022-05-16 14:01:40 -0700 (Mon, 16 May 2022)
Log Message
Add myself to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240475
Reviewed by Myles C. Maxfield.
* metadata/contributors.json:
Canonical link: https://commits.webkit.org/250607@main
Modified Paths
trunk/metadata/contributors.json
Diff
Modified: trunk/metadata/contributors.json (294253 => 294254)
--- trunk/metadata/contributors.json 2022-05-16 20:45:49 UTC (rev 294253)
+++ trunk/metadata/contributors.json 2022-05-16 21:01:40 UTC (rev 294254)
@@ -4144,6 +4144,17 @@
},
{
"emails" : [
+ "th...@apple.com",
+ "tuankie...@gmail.com"
+ ],
+ "github" : "tuankiet65",
+ "name" : "Kiet Ho",
+ "nicks" : [
+ "tuankiet65"
+ ]
+ },
+ {
+ "emails" : [
"kihong.k...@samsung.com"
],
"expertise" : "Device APIs(Battery Status, Vibration...), The EFLWebKit Port",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294252] branches/safari-7614.1.14.0-branch/Source/WebKit
Title: [294252] branches/safari-7614.1.14.0-branch/Source/WebKit
Revision 294252
Author alanc...@apple.com
Date 2022-05-16 13:43:35 -0700 (Mon, 16 May 2022)
Log Message
Cherry-pick r294175. rdar://problem/91441895
[iOS] Multiple visible find highlights when searching for text after beginning a "find from selection"
https://bugs.webkit.org/show_bug.cgi?id=240393
rdar://91441895
Reviewed by Wenson Hsieh.
Some WebKit clients use SPI on WKWebView to support "find from selection"
functionality (the Cmd+E shortcut). However, to support general
find functionality, they use new find API that uses a different codepath
to draw highlights. Mixing use of the API and SPI can currently result
in two highlights showing up.
To fix, ensure SPI highlights are removed once the API is being used.
The long term solution is for clients to adopt API for the
"find from selection" functionality, but in the short term the SPI
should remain supported.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::clearAllDecoratedFoundText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-7614.1.14.0-branch/Source/WebKit/ChangeLog
branches/safari-7614.1.14.0-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp
Diff
Modified: branches/safari-7614.1.14.0-branch/Source/WebKit/ChangeLog (294251 => 294252)
--- branches/safari-7614.1.14.0-branch/Source/WebKit/ChangeLog 2022-05-16 20:38:41 UTC (rev 294251)
+++ branches/safari-7614.1.14.0-branch/Source/WebKit/ChangeLog 2022-05-16 20:43:35 UTC (rev 294252)
@@ -1,3 +1,52 @@
+2022-05-16 Alan Coon
+
+Cherry-pick r294175. rdar://problem/91441895
+
+[iOS] Multiple visible find highlights when searching for text after beginning a "find from selection"
+https://bugs.webkit.org/show_bug.cgi?id=240393
+rdar://91441895
+
+Reviewed by Wenson Hsieh.
+
+Some WebKit clients use SPI on WKWebView to support "find from selection"
+functionality (the Cmd+E shortcut). However, to support general
+find functionality, they use new find API that uses a different codepath
+to draw highlights. Mixing use of the API and SPI can currently result
+in two highlights showing up.
+
+To fix, ensure SPI highlights are removed once the API is being used.
+The long term solution is for clients to adopt API for the
+"find from selection" functionality, but in the short term the SPI
+should remain supported.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::clearAllDecoratedFoundText):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-05-13 Aditya Keerthi
+
+[iOS] Multiple visible find highlights when searching for text after beginning a "find from selection"
+https://bugs.webkit.org/show_bug.cgi?id=240393
+rdar://91441895
+
+Reviewed by Wenson Hsieh.
+
+Some WebKit clients use SPI on WKWebView to support "find from selection"
+functionality (the Cmd+E shortcut). However, to support general
+find functionality, they use new find API that uses a different codepath
+to draw highlights. Mixing use of the API and SPI can currently result
+in two highlights showing up.
+
+To fix, ensure SPI highlights are removed once the API is being used.
+The long term solution is for clients to adopt API for the
+"find from selection" functionality, but in the short term the SPI
+should remain supported.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::clearAllDecoratedFoundText):
+
2022-05-12 Alan Coon
Cherry-pick r293994. rdar://problem/87157773
Modified: branches/safari-7614.1.14.0-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp (294251 => 294252)
--- branches/safari-7614.1.14.0-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2022-05-16 20:38:41 UTC (rev 294251)
+++ branches/safari-7614.1.14.0-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2022-05-16 20:43:35 UTC (rev 294252)
@@ -4875,6 +4875,7 @@
void WebPage::clearAllDecoratedFoundText()
{
+hideFindUI();
foundTextRangeController().clearAllDecoratedFoundText();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294251] branches/safari-7614.1.14.0-branch/Source
Title: [294251] branches/safari-7614.1.14.0-branch/Source Revision 294251 Author alanc...@apple.com Date 2022-05-16 13:38:41 -0700 (Mon, 16 May 2022) Log Message Versioning. WebKit-7614.1.14.0.2 Modified Paths branches/safari-7614.1.14.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.14.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294250 => 294251) --- branches/safari-7614.1.14.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-16 20:32:13 UTC (rev 294250) +++ branches/safari-7614.1.14.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-16 20:38:41 UTC (rev 294251) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294250 => 294251) --- branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-16 20:32:13 UTC (rev 294250) +++ branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-16 20:38:41 UTC (rev 294251) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294250 => 294251) --- branches/safari-7614.1.14.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-16 20:32:13 UTC (rev 294250) +++ branches/safari-7614.1.14.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-16 20:38:41 UTC (rev 294251) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.0-branch/Source/WebCore/Configurations/Version.xcconfig (294250 => 294251) --- branches/safari-7614.1.14.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-16 20:32:13 UTC (rev 294250) +++ branches/safari-7614.1.14.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-16 20:38:41 UTC (rev 294251) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294250 => 294251) --- branches/safari-7614.1.14.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-16 20:32:13 UTC (rev 294250) +++ branches/safari-7614.1.14.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-16 20:38:41 UTC (rev 294251) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.0-branch/Source/WebGPU/Configurations/Version.xcconfig (294250 => 294251) --- branches/safari-7614.1.14.0-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-16 20:32:13 UTC (rev 294250) +++ branches/safari-7614.1.14.0-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-16 20:38:41 UTC (rev 294251) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 0;
[webkit-changes] [294250] trunk/Websites/bugs.webkit.org
Title: [294250] trunk/Websites/bugs.webkit.org Revision 294250 Author jbed...@apple.com Date 2022-05-16 13:32:13 -0700 (Mon, 16 May 2022) Log Message [PrettyPatch] Support commit messages (Follow-up fix) https://bugs.webkit.org/show_bug.cgi?id=240386 Unreviewed follow-up fix. * Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb: Handle diffs without a header. Canonical link: https://commits.webkit.org/250606@main Modified Paths trunk/Websites/bugs.webkit.org/ChangeLog trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb Diff Modified: trunk/Websites/bugs.webkit.org/ChangeLog (294249 => 294250) --- trunk/Websites/bugs.webkit.org/ChangeLog 2022-05-16 19:00:08 UTC (rev 294249) +++ trunk/Websites/bugs.webkit.org/ChangeLog 2022-05-16 20:32:13 UTC (rev 294250) @@ -1,3 +1,13 @@ +2022-05-16 Jonathan Bedard + +[PrettyPatch] Support commit messages (Follow-up fix) +https://bugs.webkit.org/show_bug.cgi?id=240386 + + +Unreviewed follow-up fix. + +* PrettyPatch/PrettyPatch.rb: Handle diffs without a header. + 2022-05-13 Jonathan Bedard [PrettyPatch] Support commit messages Modified: trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb (294249 => 294250) --- trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb 2022-05-16 19:00:08 UTC (rev 294249) +++ trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb 2022-05-16 20:32:13 UTC (rev 294250) @@ -797,6 +797,7 @@ def self.parse(string) commitMessageLength = 0 haveSeenDiffHeader = false +haveCommitMessage = false subject = '' linesForDiffs = [] line_array = string.lines.to_a @@ -809,7 +810,7 @@ haveSeenDiffHeader = false elsif (PrettyPatch.message_header?(line)) haveSeenDiffHeader = false -parsingSubject = true +haveCommitMessage = true commitMessageLength = 1 linesForDiffs << [] linesForDiffs.last << '+++ COMMIT_MESSAGE' @@ -836,7 +837,7 @@ if (subject.empty? && commitMessageLength != 0) commitMessageLength += 1 linesForDiffs.last << '+' + line unless linesForDiffs.last.nil? -elsif (subject.empty? && haveSeenDiffHeader) +elsif (subject.empty? && (!haveCommitMessage || haveSeenDiffHeader)) linesForDiffs.last << line unless linesForDiffs.last.nil? end end ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294249] trunk
Title: [294249] trunk
Revision 294249
Author z...@igalia.com
Date 2022-05-16 12:00:08 -0700 (Mon, 16 May 2022)
Log Message
[css-ui] alias appearance keywords to 'auto' for textfield
https://bugs.webkit.org/show_bug.cgi?id=238551
Reviewed by Tim Nguyen.
Source/WebCore:
This is to add support of aliasing appearance to 'auto' for textfield.
It has improved the following wpt tests
imported/w3c/web-platform-tests/css/css-ui/appearance-textfield-001.html
and
imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-textfield-001.html.
The test failures though, are not fully fixed. The issue left is that the search cancel button
for input type="search" still present while it is expected to disappear (Bug 238751).
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustAppearanceForElement const):
LayoutTests:
Rename test name as the test result now matches the expected.
* fast/forms/color/color-input-uses-color-well-appearance-expected.html: Renamed from LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTheme.cpp
Added Paths
trunk/LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected.html
Removed Paths
trunk/LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html
Diff
Modified: trunk/LayoutTests/ChangeLog (294248 => 294249)
--- trunk/LayoutTests/ChangeLog 2022-05-16 18:54:01 UTC (rev 294248)
+++ trunk/LayoutTests/ChangeLog 2022-05-16 19:00:08 UTC (rev 294249)
@@ -1,3 +1,13 @@
+2022-05-16 Ziran Sun
+
+[css-ui] alias appearance keywords to 'auto' for textfield
+https://bugs.webkit.org/show_bug.cgi?id=238551
+
+Reviewed by Tim Nguyen.
+
+Rename test name as the test result now matches the expected.
+* fast/forms/color/color-input-uses-color-well-appearance-expected.html: Renamed from LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html.
+
2022-05-16 Karl Rackler
[Gardening]: REGRESSION (r264117): [ Mac iOS ] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https.html
Deleted: trunk/LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html (294248 => 294249)
--- trunk/LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html 2022-05-16 18:54:01 UTC (rev 294248)
+++ trunk/LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html 2022-05-16 19:00:08 UTC (rev 294249)
@@ -1 +0,0 @@
-
Copied: trunk/LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected.html (from rev 294248, trunk/LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html) (0 => 294249)
--- trunk/LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected.html (rev 0)
+++ trunk/LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected.html 2022-05-16 19:00:08 UTC (rev 294249)
@@ -0,0 +1 @@
+
Modified: trunk/Source/WebCore/ChangeLog (294248 => 294249)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 18:54:01 UTC (rev 294248)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 19:00:08 UTC (rev 294249)
@@ -1,3 +1,22 @@
+2022-05-16 Ziran Sun
+
+[css-ui] alias appearance keywords to 'auto' for textfield
+https://bugs.webkit.org/show_bug.cgi?id=238551
+
+Reviewed by Tim Nguyen.
+
+This is to add support of aliasing appearance to 'auto' for textfield.
+It has improved the following wpt tests
+imported/w3c/web-platform-tests/css/css-ui/appearance-textfield-001.html
+and
+imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-textfield-001.html.
+
+The test failures though, are not fully fixed. The issue left is that the search cancel button
+for input type="search" still present while it is expected to disappear (Bug 238751).
+
+* rendering/RenderTheme.cpp:
+(WebCore::RenderTheme::adjustAppearanceForElement const):
+
2022-05-16 Loïc Le Page
REGRESSION(r294104): [GStreamer][VideoCapture] Webcam raw streams may hang up the video capture pipeline
Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (294248 => 294249)
--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2022-05-16 18:54:01 UTC (rev 294248)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2022-05-16 19:00:08 UTC (rev 294249)
@@ -117,6 +117,13 @@
return autoAppearance;
}
+if (part == TextFieldPart) {
+if (is(*element) && downcast(*element).isSearchField())
+return part;
+style.setEffectiveAppearance(autoAppearance);
+return autoAppearance;
+}
+
return part;
}
___
webkit-changes mailing list
[webkit-changes] [294248] trunk/Tools/buildstream
Title: [294248] trunk/Tools/buildstream
Revision 294248
Author commit-qu...@webkit.org
Date 2022-05-16 11:54:01 -0700 (Mon, 16 May 2022)
Log Message
[Flatpak SDK] Update to pipewire master
https://bugs.webkit.org/show_bug.cgi?id=240428
Patch by Philippe Normand on 2022-05-16
Reviewed by Adrian Perez de Castro.
The GStreamer pipewiresrc element from 0.3.36 has bugs that were fixed in the master branch.
* elements/freedesktop-sdk.bst:
* patches/fdo-0001-pipewire-base-Track-master-branch.patch: Added.
Canonical link: https://commits.webkit.org/250604@main
Modified Paths
trunk/Tools/buildstream/ChangeLog
trunk/Tools/buildstream/elements/freedesktop-sdk.bst
Added Paths
trunk/Tools/buildstream/patches/fdo-0001-pipewire-base-Track-master-branch.patch
Diff
Modified: trunk/Tools/buildstream/ChangeLog (294247 => 294248)
--- trunk/Tools/buildstream/ChangeLog 2022-05-16 18:35:53 UTC (rev 294247)
+++ trunk/Tools/buildstream/ChangeLog 2022-05-16 18:54:01 UTC (rev 294248)
@@ -1,3 +1,15 @@
+2022-05-15 Philippe Normand
+
+[Flatpak SDK] Update to pipewire master
+https://bugs.webkit.org/show_bug.cgi?id=240428
+
+Reviewed by Adrian Perez de Castro.
+
+The GStreamer pipewiresrc element from 0.3.36 has bugs that were fixed in the master branch.
+
+* elements/freedesktop-sdk.bst:
+* patches/fdo-0001-pipewire-base-Track-master-branch.patch: Added.
+
2022-05-13 Lauro Moura
[Flatpak SDK] Add Breakpad to SDK
Modified: trunk/Tools/buildstream/elements/freedesktop-sdk.bst (294247 => 294248)
--- trunk/Tools/buildstream/elements/freedesktop-sdk.bst 2022-05-16 18:35:53 UTC (rev 294247)
+++ trunk/Tools/buildstream/elements/freedesktop-sdk.bst 2022-05-16 18:54:01 UTC (rev 294248)
@@ -3,7 +3,7 @@
- kind: git_tag
url: gitlab_com:freedesktop-sdk/freedesktop-sdk.git
track: 'release/21.08'
- ref: freedesktop-sdk-21.08.12-73-g6f02787ff2f4506731cf6aac153728e3251bdda1
+ ref: freedesktop-sdk-21.08.13-31-g21fed0ebe165b748f4bbf1edd0f275dbabc26086
- kind: patch
path: patches/fdo-0001-Bump-libnice-to-current-git-master-HEAD.patch
- kind: patch
@@ -16,6 +16,8 @@
path: patches/fdo-0001-gobject-introspection-Bump-to-1.72.patch
- kind: patch
path: patches/fdo-0002-meson-Bump-to-1.62.patch
+- kind: patch
+ path: patches/fdo-0001-pipewire-base-Track-master-branch.patch
config:
options:
target_arch: '%{arch}'
Added: trunk/Tools/buildstream/patches/fdo-0001-pipewire-base-Track-master-branch.patch (0 => 294248)
--- trunk/Tools/buildstream/patches/fdo-0001-pipewire-base-Track-master-branch.patch (rev 0)
+++ trunk/Tools/buildstream/patches/fdo-0001-pipewire-base-Track-master-branch.patch 2022-05-16 18:54:01 UTC (rev 294248)
@@ -0,0 +1,38 @@
+From 58a792ac322995205758a34f716865387b76fa1c Mon Sep 17 00:00:00 2001
+From: Philippe Normand
+Date: Sun, 15 May 2022 17:59:50 +0100
+Subject: [PATCH] pipewire-base: Track master branch
+
+---
+ elements/components/pipewire-base.bst | 9 +
+ 1 file changed, 5 insertions(+), 4 deletions(-)
+
+diff --git a/elements/components/pipewire-base.bst b/elements/components/pipewire-base.bst
+index 2c5686a89..01ffe8a01 100644
+--- a/elements/components/pipewire-base.bst
b/elements/components/pipewire-base.bst
+@@ -38,6 +38,9 @@ variables:
+ -Dbluez5-codec-ldac=disabled
+ -Dbluez5-codec-aptx=disabled
+ -Dlibcamera=disabled
++-Dlibcanberra=disabled
++-Dlv2=disabled
++-Dsession-managers=
+ -Dlibjack-path=%{libdir}
+ -Dudevrulesdir=$(pkg-config --variable=udevdir udev)/rules.d
+
+@@ -107,9 +110,7 @@ public:
+ sources:
+ - kind: git_tag
+ url: freedesktop:PipeWire/pipewire.git
+- # track: master : Frozen due to forward break
++ track: master
+ exclude:
+ - '*.*.9*'
+- ref: 0.3.36-0-g4997d47f63ed2c91d74bc8e5b229e57200354ee5
+-- kind: patch
+- path: patches/pipewire/remove-useless-rpaths.patch
++ ref: 0.3.51-0-gebc775674a0cf254cebd6d4694944006405807e3
+--
+2.35.1
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294247] branches/safari-7614.1.14.100-branch/Source
Title: [294247] branches/safari-7614.1.14.100-branch/Source Revision 294247 Author alanc...@apple.com Date 2022-05-16 11:35:53 -0700 (Mon, 16 May 2022) Log Message Versioning. WebKit-7614.1.14.100.1 Modified Paths branches/safari-7614.1.14.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.14.100-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.14.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.14.100-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.14.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.14.100-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.14.100-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.14.100-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.14.100-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.14.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294246 => 294247) --- branches/safari-7614.1.14.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-16 18:11:18 UTC (rev 294246) +++ branches/safari-7614.1.14.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-16 18:35:53 UTC (rev 294247) @@ -24,9 +24,9 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 14; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 100; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-7614.1.14.100-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294246 => 294247) --- branches/safari-7614.1.14.100-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-16 18:11:18 UTC (rev 294246) +++ branches/safari-7614.1.14.100-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-16 18:35:53 UTC (rev 294247) @@ -24,9 +24,9 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 14; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 100; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-7614.1.14.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294246 => 294247) --- branches/safari-7614.1.14.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-16 18:11:18 UTC (rev 294246) +++ branches/safari-7614.1.14.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-16 18:35:53 UTC (rev 294247) @@ -24,9 +24,9 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 14; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 100; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-7614.1.14.100-branch/Source/WebCore/Configurations/Version.xcconfig (294246 => 294247) --- branches/safari-7614.1.14.100-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-16 18:11:18 UTC (rev 294246) +++ branches/safari-7614.1.14.100-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-16 18:35:53 UTC (rev 294247) @@ -24,9 +24,9 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 14; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 100; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-7614.1.14.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294246 => 294247) --- branches/safari-7614.1.14.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-16 18:11:18 UTC (rev 294246) +++ branches/safari-7614.1.14.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-16 18:35:53 UTC (rev 294247) @@ -24,9 +24,9 @@ MAJOR_VERSION = 614; MINOR_VERSION
[webkit-changes] [294246] branches/safari-7614.1.14.100-branch/
Title: [294246] branches/safari-7614.1.14.100-branch/ Revision 294246 Author alanc...@apple.com Date 2022-05-16 11:11:18 -0700 (Mon, 16 May 2022) Log Message New branch. Added Paths branches/safari-7614.1.14.100-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294245] trunk/Tools
Title: [294245] trunk/Tools Revision 294245 Author commit-qu...@webkit.org Date 2022-05-16 10:58:38 -0700 (Mon, 16 May 2022) Log Message [GTK][WPE] Make ANGLE backend EGL context initialization work https://bugs.webkit.org/show_bug.cgi?id=240313 The platform is not selected correctly by default and the config can not be chosen in some cases in the current conditions. Maybe at some point we want something more general in the code for the platform detection but for testing we have solved it adding the environment variable (EGL_PLATORM) to make sure the platform inside mesa is correctly selected when running the tests. If we don't do it the small environment in the testing driver process causes to chose the X11 because it is the building default option. We used wayland because the headless driver we use is a wayland backed implemented using shared memory. Patch by Alejandro G. Castro on 2022-05-16 Reviewed by Žan Doberšek. No new tests, it fixes the tests for the ANGLE implementation. * Scripts/webkitpy/port/headlessdriver.py: (HeadlessDriver._setup_environ_for_test): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/port/headlessdriver.py Diff Modified: trunk/Tools/ChangeLog (294244 => 294245) --- trunk/Tools/ChangeLog 2022-05-16 17:57:23 UTC (rev 294244) +++ trunk/Tools/ChangeLog 2022-05-16 17:58:38 UTC (rev 294245) @@ -1,3 +1,26 @@ +2022-05-16 Alejandro G. Castro + +[GTK][WPE] Make ANGLE backend EGL context initialization work +https://bugs.webkit.org/show_bug.cgi?id=240313 + +The platform is not selected correctly by default and the config +can not be chosen in some cases in the current conditions. Maybe +at some point we want something more general in the code for the +platform detection but for testing we have solved it adding the +environment variable (EGL_PLATORM) to make sure the platform +inside mesa is correctly selected when running the tests. If we +don't do it the small environment in the testing driver process +causes to chose the X11 because it is the building default +option. We used wayland because the headless driver we use is a +wayland backed implemented using shared memory. + +Reviewed by Žan Doberšek. + +No new tests, it fixes the tests for the ANGLE implementation. + +* Scripts/webkitpy/port/headlessdriver.py: +(HeadlessDriver._setup_environ_for_test): + 2022-05-16 J Pascoe (REGRESSION(r287957)[ Mac ] TestWebKitAPI.WebAuthenticationPanel.LAGetAssertionNoMockNoUserGesture is a constant timeout) Modified: trunk/Tools/Scripts/webkitpy/port/headlessdriver.py (294244 => 294245) --- trunk/Tools/Scripts/webkitpy/port/headlessdriver.py 2022-05-16 17:57:23 UTC (rev 294244) +++ trunk/Tools/Scripts/webkitpy/port/headlessdriver.py 2022-05-16 17:58:38 UTC (rev 294245) @@ -40,4 +40,5 @@ def _setup_environ_for_test(self): driver_environment = super(HeadlessDriver, self)._setup_environ_for_test() driver_environment['WPE_USE_HEADLESS_VIEW_BACKEND'] = "1" +driver_environment['EGL_PLATFORM'] = "wayland" return driver_environment ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294244] trunk/LayoutTests
Title: [294244] trunk/LayoutTests Revision 294244 Author rack...@apple.com Date 2022-05-16 10:57:23 -0700 (Mon, 16 May 2022) Log Message [Gardening]: REGRESSION (r264117): [ Mac iOS ] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https.html https://bugs.webkit.org/show_bug.cgi?id=214155 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/250602@main Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (294243 => 294244) --- trunk/LayoutTests/ChangeLog 2022-05-16 17:53:21 UTC (rev 294243) +++ trunk/LayoutTests/ChangeLog 2022-05-16 17:57:23 UTC (rev 294244) @@ -1,5 +1,14 @@ 2022-05-16 Karl Rackler +[Gardening]: REGRESSION (r264117): [ Mac iOS ] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https.html +https://bugs.webkit.org/show_bug.cgi?id=214155 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: + +2022-05-16 Karl Rackler + [ iOS ] imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=240463 Modified: trunk/LayoutTests/platform/ios/TestExpectations (294243 => 294244) --- trunk/LayoutTests/platform/ios/TestExpectations 2022-05-16 17:53:21 UTC (rev 294243) +++ trunk/LayoutTests/platform/ios/TestExpectations 2022-05-16 17:57:23 UTC (rev 294244) @@ -3171,7 +3171,7 @@ fast/text/text-styles/-apple-system [ Pass ] -webkit.org/b/214155 imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https.html [ Pass Failure ] +webkit.org/b/214155 imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https.html [ Pass Timeout Failure ] webkit.org/b/214291 imported/w3c/web-platform-tests/css/css-writing-modes/normal-flow-overconstrained-vlr-005.xht [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294243] trunk/Source/WebCore
Title: [294243] trunk/Source/WebCore
Revision 294243
Author commit-qu...@webkit.org
Date 2022-05-16 10:53:21 -0700 (Mon, 16 May 2022)
Log Message
REGRESSION(r294104): [GStreamer][VideoCapture] Webcam raw streams may hang up the video capture pipeline
https://bugs.webkit.org/show_bug.cgi?id=240456
Patch by Loïc Le Page on 2022-05-16
Reviewed by Philippe Normand.
When capturing a raw stream from a webcam, the pipeline may hang up because the decodebin3 cannot fix the upstream caps.
The webcam capsfilter should not only specify the captured mime-type (video/x-raw) but also the capture image dimensions.
Manually tested.
* platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (294242 => 294243)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 17:48:17 UTC (rev 294242)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 17:53:21 UTC (rev 294243)
@@ -1,3 +1,17 @@
+2022-05-16 Loïc Le Page
+
+REGRESSION(r294104): [GStreamer][VideoCapture] Webcam raw streams may hang up the video capture pipeline
+https://bugs.webkit.org/show_bug.cgi?id=240456
+
+Reviewed by Philippe Normand.
+
+When capturing a raw stream from a webcam, the pipeline may hang up because the decodebin3 cannot fix the upstream caps.
+The webcam capsfilter should not only specify the captured mime-type (video/x-raw) but also the capture image dimensions.
+
+Manually tested.
+
+* platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
+
2022-05-16 Alan Bujtas
[LFC][FFC] Add support for logical ordering
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp (294242 => 294243)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp 2022-05-16 17:48:17 UTC (rev 294242)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp 2022-05-16 17:53:21 UTC (rev 294243)
@@ -317,6 +317,9 @@
if (*width >= selector->stopCondition.width && *height >= selector->stopCondition.height
&& *frameRate >= selector->stopCondition.frameRate) {
+selector->maxWidth = *width;
+selector->maxHeight = *height;
+selector->maxFrameRate = *frameRate;
selector->mimeType = gst_structure_get_name(structure);
selector->format = gst_structure_get_string(structure, "format");
return FALSE;
@@ -333,7 +336,8 @@
return TRUE;
}), );
-auto caps = adoptGRef(gst_caps_new_empty_simple(selector.mimeType));
+auto caps = adoptGRef(gst_caps_new_simple(selector.mimeType, "width", G_TYPE_INT, selector.maxWidth,
+"height", G_TYPE_INT, selector.maxHeight, nullptr));
// Workaround for https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1793.
if (selector.format)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294242] trunk/Tools
Title: [294242] trunk/Tools Revision 294242 Author j_pas...@apple.com Date 2022-05-16 10:48:17 -0700 (Mon, 16 May 2022) Log Message (REGRESSION(r287957)[ Mac ] TestWebKitAPI.WebAuthenticationPanel.LAGetAssertionNoMockNoUserGesture is a constant timeout) https://bugs.webkit.org/show_bug.cgi?id=240403 rdar://93271671 Reviewed by Brent Fulgham. Whenever HAVE(UNIFIED_ASC_AUTH_UI), unmocked calls are passed to ASA, which does not support calls from TWAPI. * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm: (TestWebKitAPI::TEST): Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm Diff Modified: trunk/Tools/ChangeLog (294241 => 294242) --- trunk/Tools/ChangeLog 2022-05-16 17:43:08 UTC (rev 294241) +++ trunk/Tools/ChangeLog 2022-05-16 17:48:17 UTC (rev 294242) @@ -1,3 +1,17 @@ +2022-05-16 J Pascoe + +(REGRESSION(r287957)[ Mac ] TestWebKitAPI.WebAuthenticationPanel.LAGetAssertionNoMockNoUserGesture is a constant timeout) +https://bugs.webkit.org/show_bug.cgi?id=240403 +rdar://93271671 + +Reviewed by Brent Fulgham. + +Whenever HAVE(UNIFIED_ASC_AUTH_UI), unmocked calls are passed to ASA, which does not +support calls from TWAPI. + +* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm: +(TestWebKitAPI::TEST): + 2022-05-16 Youenn Fablet Make sure calling showNotification will extend the service worker lifetime Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm (294241 => 294242) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm 2022-05-16 17:43:08 UTC (rev 294241) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm 2022-05-16 17:48:17 UTC (rev 294242) @@ -1538,7 +1538,11 @@ [webView focus]; [webView loadRequest:[NSURLRequest requestWithURL:testURL.get()]]; +#if HAVE(UNIFIED_ASC_AUTH_UI) +[webView waitForMessage:@"Operation failed."]; +#else [webView waitForMessage:@"This request has been cancelled by the user."]; +#endif } TEST(WebAuthenticationPanel, LAGetAssertionMultipleOrder) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294241] trunk/Source/WebKit
Title: [294241] trunk/Source/WebKit Revision 294241 Author j_pas...@apple.com Date 2022-05-16 10:43:08 -0700 (Mon, 16 May 2022) Log Message REGRESSION (250501@main): [ Mac ] 2 TestWebKitAPI.WebAuthenticationPanel.GetAssertionLA tests failing https://bugs.webkit.org/show_bug.cgi?id=240406 rdar://93267082 Reviewed by Brent Fulgham. Using the the truthiness of BOOL from attributes doesn't work here, instead compare it to @YES. * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticatorInternal::getExistingCredentials): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm Diff Modified: trunk/Source/WebKit/ChangeLog (294240 => 294241) --- trunk/Source/WebKit/ChangeLog 2022-05-16 17:35:40 UTC (rev 294240) +++ trunk/Source/WebKit/ChangeLog 2022-05-16 17:43:08 UTC (rev 294241) @@ -1,3 +1,16 @@ +2022-05-16 J Pascoe + +REGRESSION (250501@main): [ Mac ] 2 TestWebKitAPI.WebAuthenticationPanel.GetAssertionLA tests failing +https://bugs.webkit.org/show_bug.cgi?id=240406 +rdar://93267082 + +Reviewed by Brent Fulgham. + +Using the the truthiness of BOOL from attributes doesn't work here, instead compare it to @YES. + +* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: +(WebKit::LocalAuthenticatorInternal::getExistingCredentials): + 2022-05-16 Alex Christensen Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm (294240 => 294241) --- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2022-05-16 17:35:40 UTC (rev 294240) +++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2022-05-16 17:43:08 UTC (rev 294241) @@ -186,7 +186,7 @@ if (!group.isNull()) response->setGroup(group); if ([[attributes allKeys] containsObject:bridge_cast(kSecAttrSynchronizable)]) -response->setSynchronizable(attributes[(id)kSecAttrSynchronizable]); +response->setSynchronizable([attributes[(id)kSecAttrSynchronizable] isEqual:@YES]); result.uncheckedAppend(WTFMove(response)); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294240] trunk/Source/WebCore
Title: [294240] trunk/Source/WebCore
Revision 294240
Author za...@apple.com
Date 2022-05-16 10:35:40 -0700 (Mon, 16 May 2022)
Log Message
[LFC][FFC] Add support for logical ordering
https://bugs.webkit.org/show_bug.cgi?id=240442
Reviewed by Antti Koivisto.
Let's reorder the logicalFlexItemList when the 'order' property has a non-initial value.
* layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (294239 => 294240)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 17:30:34 UTC (rev 294239)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 17:35:40 UTC (rev 294240)
@@ -1,5 +1,17 @@
2022-05-16 Alan Bujtas
+[LFC][FFC] Add support for logical ordering
+https://bugs.webkit.org/show_bug.cgi?id=240442
+
+Reviewed by Antti Koivisto.
+
+Let's reorder the logicalFlexItemList when the 'order' property has a non-initial value.
+
+* layout/formattingContexts/flex/FlexFormattingContext.cpp:
+(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
+
+2022-05-16 Alan Bujtas
+
[LFC][FFC] Add "flex-direction: column-reverse" basic visual/logical conversion
https://bugs.webkit.org/show_bug.cgi?id=240434
Modified: trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp (294239 => 294240)
--- trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp 2022-05-16 17:30:34 UTC (rev 294239)
+++ trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp 2022-05-16 17:35:40 UTC (rev 294240)
@@ -121,7 +121,8 @@
struct FlexItemLogicalBox {
FlexRect rect;
-const ContainerBox& flexItem;
+int logicalOrder { 0 };
+CheckedPtr flexItem;
};
void FlexFormattingContext::layoutInFlowContentForIntegration(const ConstraintsForInFlowContent& constraints)
@@ -128,11 +129,12 @@
{
auto& formattingState = this->formattingState();
Vector logicalFlexItemList;
+auto flexItemsNeedReordering = false;
-
auto convertVisualToLogical = [&] {
// FIXME: Convert visual (row/column) direction to logical.
auto direction = root().style().flexDirection();
+auto previousLogicalOrder = std::optional { };
for (auto& flexItem : childrenOfType(root())) {
auto& flexItemGeometry = formattingState.boxGeometry(flexItem);
@@ -151,11 +153,26 @@
ASSERT_NOT_REACHED();
break;
}
-logicalFlexItemList.append({ { logicalSize }, flexItem });
+auto flexItemOrder = flexItem.style().order();
+flexItemsNeedReordering = flexItemsNeedReordering || flexItemOrder != previousLogicalOrder.value_or(0);
+previousLogicalOrder = flexItemOrder;
+
+logicalFlexItemList.append({ { logicalSize }, flexItemOrder, });
+
}
};
convertVisualToLogical();
+auto reorderFlexItemsIfApplicable = [&] {
+if (!flexItemsNeedReordering)
+return;
+
+std::stable_sort(logicalFlexItemList.begin(), logicalFlexItemList.end(), [&] (auto& a, auto& b) {
+return a.logicalOrder < b.logicalOrder;
+});
+};
+reorderFlexItemsIfApplicable();
+
auto logicalLeft = LayoutUnit { };
auto logicalTop = LayoutUnit { };
@@ -169,7 +186,7 @@
auto logicalWidth = logicalFlexItemList.last().rect.right() - logicalFlexItemList.first().rect.left();
auto direction = root().style().flexDirection();
for (auto& logicalFlexItem : logicalFlexItemList) {
-auto& flexItemGeometry = formattingState.boxGeometry(logicalFlexItem.flexItem);
+auto& flexItemGeometry = formattingState.boxGeometry(*logicalFlexItem.flexItem);
auto topLeft = LayoutPoint { };
switch (direction) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294239] trunk/LayoutTests
Title: [294239] trunk/LayoutTests Revision 294239 Author rack...@apple.com Date 2022-05-16 10:30:34 -0700 (Mon, 16 May 2022) Log Message [ iOS ] imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=240463 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/250597@main Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (294238 => 294239) --- trunk/LayoutTests/ChangeLog 2022-05-16 16:49:23 UTC (rev 294238) +++ trunk/LayoutTests/ChangeLog 2022-05-16 17:30:34 UTC (rev 294239) @@ -1,5 +1,14 @@ 2022-05-16 Karl Rackler +[ iOS ] imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html is a consistent failure +https://bugs.webkit.org/show_bug.cgi?id=240463 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: + +2022-05-16 Karl Rackler + [Gardening]:[ iOS ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-videoDetectorTest.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=240348 Modified: trunk/LayoutTests/platform/ios/TestExpectations (294238 => 294239) --- trunk/LayoutTests/platform/ios/TestExpectations 2022-05-16 16:49:23 UTC (rev 294238) +++ trunk/LayoutTests/platform/ios/TestExpectations 2022-05-16 17:30:34 UTC (rev 294239) @@ -3614,3 +3614,4 @@ webkit.org/b/240348 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-videoDetectorTest.html [ Failure ] +webkit.org/b/240463 imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294238] trunk
Title: [294238] trunk
Revision 294238
Author commit-qu...@webkit.org
Date 2022-05-16 09:49:23 -0700 (Mon, 16 May 2022)
Log Message
Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
https://bugs.webkit.org/show_bug.cgi?id=240362
Patch by Alex Christensen on 2022-05-16
Reviewed by Chris Dumez.
Source/WebCore/PAL:
* pal/spi/cf/CFNetworkSPI.h:
Source/WebKit:
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* NetworkProcess/cocoa/NetworkSessionCocoa.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::initializeNSURLSessionsInSet):
(WebKit::SessionSet::initializeEphemeralStatelessSessionIfNeeded):
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
(WebKit::NetworkSessionCocoa::appBoundSession):
(WebKit::SessionSet::isolatedSession):
(WebKit::NetworkSessionCocoa::invalidateAndCancelSessionSet):
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm
trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.mm
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (294237 => 294238)
--- trunk/Source/WebCore/PAL/ChangeLog 2022-05-16 16:33:38 UTC (rev 294237)
+++ trunk/Source/WebCore/PAL/ChangeLog 2022-05-16 16:49:23 UTC (rev 294238)
@@ -1,3 +1,12 @@
+2022-05-16 Alex Christensen
+
+Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
+https://bugs.webkit.org/show_bug.cgi?id=240362
+
+Reviewed by Chris Dumez.
+
+* pal/spi/cf/CFNetworkSPI.h:
+
2022-05-08 Yusuke Suzuki
Put ThreadGlobalData in Thread
Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (294237 => 294238)
--- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2022-05-16 16:33:38 UTC (rev 294237)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2022-05-16 16:49:23 UTC (rev 294238)
@@ -280,6 +280,7 @@
@end
@interface NSURLSessionTask ()
+- (void) _adoptEffectiveConfiguration:(NSURLSessionConfiguration*) newConfiguration;
- (NSDictionary *)_timingData;
@property (readwrite, copy) NSString *_pathToDownloadTaskFile;
@property (copy) NSString *_storagePartitionIdentifier;
Modified: trunk/Source/WebKit/ChangeLog (294237 => 294238)
--- trunk/Source/WebKit/ChangeLog 2022-05-16 16:33:38 UTC (rev 294237)
+++ trunk/Source/WebKit/ChangeLog 2022-05-16 16:49:23 UTC (rev 294238)
@@ -1,3 +1,21 @@
+2022-05-16 Alex Christensen
+
+Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
+https://bugs.webkit.org/show_bug.cgi?id=240362
+
+Reviewed by Chris Dumez.
+
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+* NetworkProcess/cocoa/NetworkSessionCocoa.h:
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::initializeNSURLSessionsInSet):
+(WebKit::SessionSet::initializeEphemeralStatelessSessionIfNeeded):
+(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
+(WebKit::NetworkSessionCocoa::appBoundSession):
+(WebKit::SessionSet::isolatedSession):
+(WebKit::NetworkSessionCocoa::invalidateAndCancelSessionSet):
+
2022-05-13 Michael Catanzaro
[GTK] Warning in WebKitDOMDocumentGtk.cpp with GCC 12
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (294237 => 294238)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-05-16 16:33:38 UTC (rev 294237)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-05-16 16:49:23 UTC (rev 294238)
@@ -356,6 +356,20 @@
m_task = [m_sessionWrapper->session dataTaskWithRequest:nsRequest.get()];
+switch (parameters.storedCredentialsPolicy) {
+case WebCore::StoredCredentialsPolicy::Use:
+ASSERT(m_sessionWrapper->session.get().configuration.URLCredentialStorage);
+break;
+case WebCore::StoredCredentialsPolicy::EphemeralStateless:
+ASSERT(!m_sessionWrapper->session.get().configuration.URLCredentialStorage);
+break;
+case WebCore::StoredCredentialsPolicy::DoNotUse:
+NSURLSessionConfiguration *effectiveConfiguration = m_sessionWrapper->session.get().configuration;
+effectiveConfiguration.URLCredentialStorage = nil;
+[m_task _adoptEffectiveConfiguration:effectiveConfiguration];
+break;
+};
+
WTFBeginSignpost(m_task.get(), "DataTask", "%{public}s pri: %.2f preconnect: %d", url.string().ascii().data(), toNSURLSessionTaskPriority(request.priority()), parameters.shouldPreconnectOnly == PreconnectOnly::Yes);
[webkit-changes] [294237] trunk/Source/WebCore
Title: [294237] trunk/Source/WebCore
Revision 294237
Author za...@apple.com
Date 2022-05-16 09:33:38 -0700 (Mon, 16 May 2022)
Log Message
[LFC][FFC] Add "flex-direction: column-reverse" basic visual/logical conversion
https://bugs.webkit.org/show_bug.cgi?id=240434
Reviewed by Antti Koivisto.
With "flex-direction: column-reverse" the main axis progression is from visual bottom to top (with default writing mode and all that).
* layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (294236 => 294237)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 16:18:10 UTC (rev 294236)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 16:33:38 UTC (rev 294237)
@@ -1,3 +1,15 @@
+2022-05-16 Alan Bujtas
+
+[LFC][FFC] Add "flex-direction: column-reverse" basic visual/logical conversion
+https://bugs.webkit.org/show_bug.cgi?id=240434
+
+Reviewed by Antti Koivisto.
+
+With "flex-direction: column-reverse" the main axis progression is from visual bottom to top (with default writing mode and all that).
+
+* layout/formattingContexts/flex/FlexFormattingContext.cpp:
+(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
+
2022-05-16 Patrick Angle
Web Inspector: Regression(r266885) Crash sometimes when rehydrating imported audit results
Modified: trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp (294236 => 294237)
--- trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp 2022-05-16 16:18:10 UTC (rev 294236)
+++ trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp 2022-05-16 16:33:38 UTC (rev 294237)
@@ -144,11 +144,9 @@
logicalSize = { flexItemGeometry.marginBoxWidth(), flexItemGeometry.marginBoxHeight() };
break;
case FlexDirection::Column:
+case FlexDirection::ColumnReverse:
logicalSize = { flexItemGeometry.marginBoxHeight(), flexItemGeometry.marginBoxWidth() };
break;
-case FlexDirection::ColumnReverse:
-ASSERT_NOT_IMPLEMENTED_YET();
-break;
default:
ASSERT_NOT_REACHED();
break;
@@ -168,6 +166,7 @@
auto convertLogicalToVisual = [&] {
// FIXME: Convert logical coordinates to visual.
+auto logicalWidth = logicalFlexItemList.last().rect.right() - logicalFlexItemList.first().rect.left();
auto direction = root().style().flexDirection();
for (auto& logicalFlexItem : logicalFlexItemList) {
auto& flexItemGeometry = formattingState.boxGeometry(logicalFlexItem.flexItem);
@@ -186,7 +185,7 @@
break;
}
case FlexDirection::ColumnReverse:
-ASSERT_NOT_IMPLEMENTED_YET();
+topLeft = { constraints.horizontal().logicalLeft + logicalFlexItem.rect.top(), constraints.logicalTop() + logicalWidth - logicalFlexItem.rect.right() };
break;
default:
ASSERT_NOT_REACHED();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294236] trunk/LayoutTests
Title: [294236] trunk/LayoutTests Revision 294236 Author rack...@apple.com Date 2022-05-16 09:18:10 -0700 (Mon, 16 May 2022) Log Message [Gardening]:[ iOS ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-videoDetectorTest.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=240348 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/250594@main Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (294235 => 294236) --- trunk/LayoutTests/ChangeLog 2022-05-16 16:12:23 UTC (rev 294235) +++ trunk/LayoutTests/ChangeLog 2022-05-16 16:18:10 UTC (rev 294236) @@ -1,3 +1,12 @@ +2022-05-16 Karl Rackler + +[Gardening]:[ iOS ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-videoDetectorTest.html is a consistent failure +https://bugs.webkit.org/show_bug.cgi?id=240348 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: + 2022-05-16 Patrick Angle Web Inspector: Regression(r266885) Crash sometimes when rehydrating imported audit results Modified: trunk/LayoutTests/platform/ios/TestExpectations (294235 => 294236) --- trunk/LayoutTests/platform/ios/TestExpectations 2022-05-16 16:12:23 UTC (rev 294235) +++ trunk/LayoutTests/platform/ios/TestExpectations 2022-05-16 16:18:10 UTC (rev 294236) @@ -3612,5 +3612,5 @@ webkit.org/b/240167 [ Release ] fast/css-custom-paint/animate-repaint.html [ Pass Failure ] -webkit.org/b/240348 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-videoDetectorTest.html [ Slow ] +webkit.org/b/240348 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-videoDetectorTest.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294235] trunk/Source/WebCore/platform/graphics/avfoundation/objc/ LocalSampleBufferDisplayLayer.mm
Title: [294235] trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm
Revision 294235
Author commit-qu...@webkit.org
Date 2022-05-16 09:12:23 -0700 (Mon, 16 May 2022)
Log Message
Canvas generated transparent pixels are not well handled by LocalSampleBufferDisplayLayer
https://bugs.webkit.org/show_bug.cgi?id=230621
rdar://problem/83668394
Patch by Youenn Fablet on 2022-05-16
Reviewed by Eric Carlson.
Remove black color for root and display layer.
When display layer is hidden but root layer is visible, set root layer background color to black to keep existing behavior.
This allows to render transparent video frames without a black background.
Covered by https://jsfiddle.net/nfu7oL60/ (make sure to switch between tabs after clicking start).
Also covered by https://webrtc.github.io/samples/src/content/peerconnection/pc1/ and muting/unmuting the camera.
* Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
(WebCore::LocalSampleBufferDisplayLayer::initialize):
(WebCore::LocalSampleBufferDisplayLayer::updateDisplayMode):
Canonical link: https://commits.webkit.org/250593@main
Modified Paths
trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm
Diff
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm (294234 => 294235)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm 2022-05-16 15:52:10 UTC (rev 294234)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm 2022-05-16 16:12:23 UTC (rev 294235)
@@ -164,7 +164,6 @@
void LocalSampleBufferDisplayLayer::initialize(bool hideRootLayer, IntSize size, CompletionHandler&& callback)
{
-m_sampleBufferDisplayLayer.get().backgroundColor = cachedCGColor(Color::black).get();
m_sampleBufferDisplayLayer.get().anchorPoint = { .5, .5 };
m_sampleBufferDisplayLayer.get().needsDisplayOnBoundsChange = YES;
m_sampleBufferDisplayLayer.get().videoGravity = AVLayerVideoGravityResizeAspectFill;
@@ -172,7 +171,6 @@
m_rootLayer = adoptNS([[CALayer alloc] init]);
m_rootLayer.get().hidden = hideRootLayer;
-m_rootLayer.get().backgroundColor = cachedCGColor(Color::black).get();
m_rootLayer.get().needsDisplayOnBoundsChange = YES;
m_rootLayer.get().bounds = CGRectMake(0, 0, size.width(), size.height());
@@ -241,6 +239,10 @@
return;
runWithoutAnimations([&] {
+if (hideDisplayLayer && !hideRootLayer)
+m_rootLayer.get().backgroundColor = cachedCGColor(Color::black).get();
+else
+m_rootLayer.get().backgroundColor = nil;
m_sampleBufferDisplayLayer.get().hidden = hideDisplayLayer;
m_rootLayer.get().hidden = hideRootLayer;
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294234] trunk
Title: [294234] trunk
Revision 294234
Author pan...@apple.com
Date 2022-05-16 08:52:10 -0700 (Mon, 16 May 2022)
Log Message
Web Inspector: Regression(r266885) Crash sometimes when rehydrating imported audit results
https://bugs.webkit.org/show_bug.cgi?id=240366
Reviewed by Devin Rousso.
Source/_javascript_Core:
* inspector/protocol/DOM.json:
Source/WebCore:
Added test cases to inspector/model/dom-node.html
After r266885, there is no path to handle the possibility that there may not be a resulting node for calls to
`DOM.querySelector`. To correct this, mark the return value as optional (Web Inspector frontend already treats
it as optional) and return early if there was no Element matching the selector.
* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::querySelector):
* inspector/agents/InspectorDOMAgent.h:
LayoutTests:
* inspector/model/dom-node.html:
* inspector/model/dom-node-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/model/dom-node-expected.txt
trunk/LayoutTests/inspector/model/dom-node.html
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/protocol/DOM.json
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.h
Diff
Modified: trunk/LayoutTests/ChangeLog (294233 => 294234)
--- trunk/LayoutTests/ChangeLog 2022-05-16 15:08:11 UTC (rev 294233)
+++ trunk/LayoutTests/ChangeLog 2022-05-16 15:52:10 UTC (rev 294234)
@@ -1,3 +1,13 @@
+2022-05-16 Patrick Angle
+
+Web Inspector: Regression(r266885) Crash sometimes when rehydrating imported audit results
+https://bugs.webkit.org/show_bug.cgi?id=240366
+
+Reviewed by Devin Rousso.
+
+* inspector/model/dom-node.html:
+* inspector/model/dom-node-expected.txt:
+
2022-05-16 Rob Buis
Remove some custom-element tests
Modified: trunk/LayoutTests/inspector/model/dom-node-expected.txt (294233 => 294234)
--- trunk/LayoutTests/inspector/model/dom-node-expected.txt 2022-05-16 15:08:11 UTC (rev 294233)
+++ trunk/LayoutTests/inspector/model/dom-node-expected.txt 2022-05-16 15:52:10 UTC (rev 294234)
@@ -7,3 +7,11 @@
class="test-class"
data-item="test-data"
+-- Running test case: WI.DOMNode.querySelector
+Calling querySelector("#test-id") on document node.
+PASS: `querySelector("#test-id")` should return a WI.DOMNode
+Calling querySelector("#non-existent-id") on document node.
+PASS: `querySelector("#non-existent-id")` should return null.
+Calling querySelector("^\_(invalid selector)_/^") on document node.
+PASS: `querySelector` with an invalid selector should throw a SyntaxError.
+
Modified: trunk/LayoutTests/inspector/model/dom-node.html (294233 => 294234)
--- trunk/LayoutTests/inspector/model/dom-node.html 2022-05-16 15:08:11 UTC (rev 294233)
+++ trunk/LayoutTests/inspector/model/dom-node.html 2022-05-16 15:52:10 UTC (rev 294234)
@@ -25,6 +25,34 @@
}
});
+suite.addTestCase({
+name: "WI.DOMNode.querySelector",
+description: "Test getting a child node via querySelector.",
+async test() {
+let documentNode = await WI.domManager.requestDocument();
+
+function querySelector(selector) {
+InspectorTest.log(`Calling querySelector("${selector}") on document node.`);
+return documentNode.querySelector(selector).then((nodeId) => {
+if (!nodeId)
+return null;
+return WI.domManager.nodeForId(nodeId);
+});
+}
+
+let nodeFromQueryingExistingId = await querySelector("#test-id");
+InspectorTest.expectThat(nodeFromQueryingExistingId instanceof WI.DOMNode, "`querySelector(\"#test-id\")` should return a WI.DOMNode");
+
+let nodeFromQueryingNonExistantId = await querySelector("#non-existent-id");
+InspectorTest.expectNull(nodeFromQueryingNonExistantId, "`querySelector(\"#non-existent-id\")` should return null.");
+
+await querySelector("^\\_(invalid selector)_/^").catch((error) => {
+InspectorTest.expectEqual(error.message, "SyntaxError", "`querySelector` with an invalid selector should throw a SyntaxError.");
+});
+
+}
+});
+
suite.runTestCasesAndFinish();
}
Modified: trunk/Source/_javascript_Core/ChangeLog (294233 => 294234)
--- trunk/Source/_javascript_Core/ChangeLog 2022-05-16 15:08:11 UTC (rev 294233)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-05-16 15:52:10 UTC (rev 294234)
@@ -1,3 +1,12 @@
+2022-05-16 Patrick Angle
+
+Web Inspector: Regression(r266885) Crash sometimes when rehydrating imported audit results
+https://bugs.webkit.org/show_bug.cgi?id=240366
+
+Reviewed by Devin Rousso.
+
+* inspector/protocol/DOM.json:
+
2022-05-13 Mark Lam
Enhance the
[webkit-changes] [294233] trunk/Source/WebCore
Title: [294233] trunk/Source/WebCore
Revision 294233
Author za...@apple.com
Date 2022-05-16 08:08:11 -0700 (Mon, 16 May 2022)
Log Message
[LFC][FFC] Add "flex-direction: row-reverse" basic visual/logical conversion
https://bugs.webkit.org/show_bug.cgi?id=240432
Reviewed by Antti Koivisto.
With "flex-direction: row-reverse" the main axis progression is from visual right to left (with default writing mode and all that).
* layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (294232 => 294233)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 13:55:35 UTC (rev 294232)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 15:08:11 UTC (rev 294233)
@@ -1,5 +1,17 @@
2022-05-16 Alan Bujtas
+[LFC][FFC] Add "flex-direction: row-reverse" basic visual/logical conversion
+https://bugs.webkit.org/show_bug.cgi?id=240432
+
+Reviewed by Antti Koivisto.
+
+With "flex-direction: row-reverse" the main axis progression is from visual right to left (with default writing mode and all that).
+
+* layout/formattingContexts/flex/FlexFormattingContext.cpp:
+(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
+
+2022-05-16 Alan Bujtas
+
[LFC][FFC] Add "flex-direction: column" basic visual/logical conversion
https://bugs.webkit.org/show_bug.cgi?id=240430
Modified: trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp (294232 => 294233)
--- trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp 2022-05-16 13:55:35 UTC (rev 294232)
+++ trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp 2022-05-16 15:08:11 UTC (rev 294233)
@@ -129,16 +129,11 @@
auto& formattingState = this->formattingState();
Vector logicalFlexItemList;
-auto logicalLeft = LayoutUnit { };
-auto logicalTop = LayoutUnit { };
auto convertVisualToLogical = [&] {
// FIXME: Convert visual (row/column) direction to logical.
auto direction = root().style().flexDirection();
-logicalLeft = constraints.horizontal().logicalLeft;
-logicalTop = constraints.logicalTop();
-
for (auto& flexItem : childrenOfType(root())) {
auto& flexItemGeometry = formattingState.boxGeometry(flexItem);
auto logicalSize = LayoutSize { };
@@ -145,12 +140,12 @@
switch (direction) {
case FlexDirection::Row:
+case FlexDirection::RowReverse:
logicalSize = { flexItemGeometry.marginBoxWidth(), flexItemGeometry.marginBoxHeight() };
break;
case FlexDirection::Column:
logicalSize = { flexItemGeometry.marginBoxHeight(), flexItemGeometry.marginBoxWidth() };
break;
-case FlexDirection::RowReverse:
case FlexDirection::ColumnReverse:
ASSERT_NOT_IMPLEMENTED_YET();
break;
@@ -163,6 +158,9 @@
};
convertVisualToLogical();
+auto logicalLeft = LayoutUnit { };
+auto logicalTop = LayoutUnit { };
+
for (auto& logicalFlexItem : logicalFlexItemList) {
logicalFlexItem.rect.setTopLeft({ logicalLeft, logicalTop });
logicalLeft = logicalFlexItem.rect.right();
@@ -177,12 +175,16 @@
switch (direction) {
case FlexDirection::Row:
-topLeft = logicalFlexItem.rect.topLeft();
+topLeft = { constraints.horizontal().logicalLeft + logicalFlexItem.rect.left(), constraints.logicalTop() + logicalFlexItem.rect.top() };
break;
-case FlexDirection::Column:
-topLeft = logicalFlexItem.rect.topLeft().transposedPoint();
+case FlexDirection::RowReverse:
+topLeft = { constraints.horizontal().logicalRight() - logicalFlexItem.rect.right(), constraints.logicalTop() + logicalFlexItem.rect.top() };
break;
-case FlexDirection::RowReverse:
+case FlexDirection::Column: {
+auto flippedTopLeft = logicalFlexItem.rect.topLeft().transposedPoint();
+topLeft = { constraints.horizontal().logicalLeft + flippedTopLeft.x(), constraints.logicalTop() + flippedTopLeft.y() };
+break;
+}
case FlexDirection::ColumnReverse:
ASSERT_NOT_IMPLEMENTED_YET();
break;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294232] trunk/Source/WebKit
Title: [294232] trunk/Source/WebKit
Revision 294232
Author commit-qu...@webkit.org
Date 2022-05-16 06:55:35 -0700 (Mon, 16 May 2022)
Log Message
[GTK] Warning in WebKitDOMDocumentGtk.cpp with GCC 12
https://bugs.webkit.org/show_bug.cgi?id=239353
Patch by Michael Catanzaro on 2022-05-16
Reviewed by Yusuke Suzuki.
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:
(webkit_dom_document_create_node_iterator):
(webkit_dom_document_create_tree_walker):
Canonical link: https://commits.webkit.org/250590@main
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (294231 => 294232)
--- trunk/Source/WebKit/ChangeLog 2022-05-16 13:16:41 UTC (rev 294231)
+++ trunk/Source/WebKit/ChangeLog 2022-05-16 13:55:35 UTC (rev 294232)
@@ -1,3 +1,14 @@
+2022-05-13 Michael Catanzaro
+
+[GTK] Warning in WebKitDOMDocumentGtk.cpp with GCC 12
+https://bugs.webkit.org/show_bug.cgi?id=239353
+
+Reviewed by Yusuke Suzuki.
+
+* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:
+(webkit_dom_document_create_node_iterator):
+(webkit_dom_document_create_tree_walker):
+
2022-05-16 Youenn Fablet
Make sure calling showNotification will extend the service worker lifetime
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp (294231 => 294232)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp 2022-05-16 13:16:41 UTC (rev 294231)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp 2022-05-16 13:55:35 UTC (rev 294232)
@@ -1098,7 +1098,9 @@
WebCore::Node* convertedRoot = WebKit::core(root);
RefPtr convertedFilter = WebKit::core(item, filter);
RefPtr gobjectResult = WTF::getPtr(item->createNodeIterator(*convertedRoot, whatToShow, WTF::getPtr(convertedFilter), expandEntityReferences));
+IGNORE_GCC_WARNINGS_BEGIN("use-after-free")
return WebKit::kit(gobjectResult.get());
+IGNORE_GCC_WARNINGS_END
}
WebKitDOMTreeWalker* webkit_dom_document_create_tree_walker(WebKitDOMDocument* self, WebKitDOMNode* root, gulong whatToShow, WebKitDOMNodeFilter* filter, gboolean expandEntityReferences, GError** error)
@@ -1112,7 +1114,9 @@
WebCore::Node* convertedRoot = WebKit::core(root);
RefPtr convertedFilter = WebKit::core(item, filter);
RefPtr gobjectResult = WTF::getPtr(item->createTreeWalker(*convertedRoot, whatToShow, WTF::getPtr(convertedFilter), expandEntityReferences));
+IGNORE_GCC_WARNINGS_BEGIN("use-after-free")
return WebKit::kit(gobjectResult.get());
+IGNORE_GCC_WARNINGS_END
}
WebKitDOMCSSStyleDeclaration* webkit_dom_document_get_override_style(WebKitDOMDocument*, WebKitDOMElement*, const gchar*)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294231] trunk/Source/WebCore
Title: [294231] trunk/Source/WebCore
Revision 294231
Author za...@apple.com
Date 2022-05-16 06:16:41 -0700 (Mon, 16 May 2022)
Log Message
[LFC][FFC] Add "flex-direction: column" basic visual/logical conversion
https://bugs.webkit.org/show_bug.cgi?id=240430
Reviewed by Antti Koivisto.
With "flex-direction: column" the main axis progression is based on the margin box height.
* layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (294230 => 294231)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 12:54:14 UTC (rev 294230)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 13:16:41 UTC (rev 294231)
@@ -1,3 +1,15 @@
+2022-05-16 Alan Bujtas
+
+[LFC][FFC] Add "flex-direction: column" basic visual/logical conversion
+https://bugs.webkit.org/show_bug.cgi?id=240430
+
+Reviewed by Antti Koivisto.
+
+With "flex-direction: column" the main axis progression is based on the margin box height.
+
+* layout/formattingContexts/flex/FlexFormattingContext.cpp:
+(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
+
2022-05-15 Philippe Normand
REGRESSION(r294104): [GStreamer] getUserMedia broken
Modified: trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp (294230 => 294231)
--- trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp 2022-05-16 12:54:14 UTC (rev 294230)
+++ trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp 2022-05-16 13:16:41 UTC (rev 294231)
@@ -134,12 +134,31 @@
auto convertVisualToLogical = [&] {
// FIXME: Convert visual (row/column) direction to logical.
+auto direction = root().style().flexDirection();
+
logicalLeft = constraints.horizontal().logicalLeft;
logicalTop = constraints.logicalTop();
-
+
for (auto& flexItem : childrenOfType(root())) {
auto& flexItemGeometry = formattingState.boxGeometry(flexItem);
-logicalFlexItemList.append({ { LayoutSize { flexItemGeometry.marginBoxWidth(), flexItemGeometry.marginBoxHeight() } }, flexItem });
+auto logicalSize = LayoutSize { };
+
+switch (direction) {
+case FlexDirection::Row:
+logicalSize = { flexItemGeometry.marginBoxWidth(), flexItemGeometry.marginBoxHeight() };
+break;
+case FlexDirection::Column:
+logicalSize = { flexItemGeometry.marginBoxHeight(), flexItemGeometry.marginBoxWidth() };
+break;
+case FlexDirection::RowReverse:
+case FlexDirection::ColumnReverse:
+ASSERT_NOT_IMPLEMENTED_YET();
+break;
+default:
+ASSERT_NOT_REACHED();
+break;
+}
+logicalFlexItemList.append({ { logicalSize }, flexItem });
}
};
convertVisualToLogical();
@@ -151,9 +170,27 @@
auto convertLogicalToVisual = [&] {
// FIXME: Convert logical coordinates to visual.
+auto direction = root().style().flexDirection();
for (auto& logicalFlexItem : logicalFlexItemList) {
auto& flexItemGeometry = formattingState.boxGeometry(logicalFlexItem.flexItem);
-flexItemGeometry.setLogicalTopLeft(logicalFlexItem.rect.topLeft());
+auto topLeft = LayoutPoint { };
+
+switch (direction) {
+case FlexDirection::Row:
+topLeft = logicalFlexItem.rect.topLeft();
+break;
+case FlexDirection::Column:
+topLeft = logicalFlexItem.rect.topLeft().transposedPoint();
+break;
+case FlexDirection::RowReverse:
+case FlexDirection::ColumnReverse:
+ASSERT_NOT_IMPLEMENTED_YET();
+break;
+default:
+ASSERT_NOT_REACHED();
+break;
+}
+flexItemGeometry.setLogicalTopLeft(topLeft);
}
};
convertLogicalToVisual();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294230] trunk/Source/WebCore/platform/mediastream/mac/ MockAudioSharedUnit.mm
Title: [294230] trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm
Revision 294230
Author commit-qu...@webkit.org
Date 2022-05-16 05:54:14 -0700 (Mon, 16 May 2022)
Log Message
Rename MockAudioSharedInternalUnit::m_isProducingState to MockAudioSharedInternalUnit::m_internalState
https://bugs.webkit.org/show_bug.cgi?id=240450
Patch by Youenn Fablet on 2022-05-16
Reviewed by Eric Carlson.
Follow-up to https://bugs.webkit.org/show_bug.cgi?id=240421 review.
No change of behavior.
* Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:
(WebCore::MockAudioSharedInternalUnit::MockAudioSharedInternalUnit):
(WebCore::MockAudioSharedInternalUnit::~MockAudioSharedInternalUnit):
(WebCore::MockAudioSharedInternalUnit::start):
(WebCore::MockAudioSharedInternalUnit::stop):
(WebCore::MockAudioSharedInternalUnit::uninitialize):
(WebCore::MockAudioSharedInternalUnit::generateSampleBuffers):
Canonical link: https://commits.webkit.org/250588@main
Modified Paths
trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm
Diff
Modified: trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm (294229 => 294230)
--- trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm 2022-05-16 12:48:52 UTC (rev 294229)
+++ trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm 2022-05-16 12:54:14 UTC (rev 294230)
@@ -147,7 +147,7 @@
Vector m_bipBopBuffer;
bool m_hasAudioUnit { false };
-Ref m_isProducingState;
+Ref m_internalState;
bool m_enableEchoCancellation { true };
RunLoop::Timer m_timer;
MonotonicTime m_lastRenderTime { MonotonicTime::nan() };
@@ -188,7 +188,7 @@
}
MockAudioSharedInternalUnit::MockAudioSharedInternalUnit()
-: m_isProducingState(MockAudioSharedInternalUnitState::create())
+: m_internalState(MockAudioSharedInternalUnitState::create())
, m_timer(RunLoop::current(), [this] { this->start(); })
, m_workQueue(WorkQueue::create("MockAudioSharedInternalUnit Capture Queue", WorkQueue::QOS::UserInteractive))
{
@@ -197,7 +197,7 @@
MockAudioSharedInternalUnit::~MockAudioSharedInternalUnit()
{
-ASSERT(!m_isProducingState->isProducingData());
+ASSERT(!m_internalState->isProducingData());
}
OSStatus MockAudioSharedInternalUnit::initialize()
@@ -216,7 +216,7 @@
m_lastRenderTime = MonotonicTime::now();
-m_isProducingState->setIsProducingData(true);
+m_internalState->setIsProducingData(true);
m_workQueue->dispatch([this, renderTime = m_lastRenderTime] {
generateSampleBuffers(renderTime);
});
@@ -225,7 +225,7 @@
OSStatus MockAudioSharedInternalUnit::stop()
{
-m_isProducingState->setIsProducingData(false);
+m_internalState->setIsProducingData(false);
if (m_hasAudioUnit)
m_lastRenderTime = MonotonicTime::nan();
@@ -236,7 +236,7 @@
OSStatus MockAudioSharedInternalUnit::uninitialize()
{
-ASSERT(!m_isProducingState->isProducingData());
+ASSERT(!m_internalState->isProducingData());
return 0;
}
@@ -311,7 +311,7 @@
nextRenderDelay = 0_s;
}
-m_workQueue->dispatchAfter(nextRenderDelay, [this, nextRenderTime, state = m_isProducingState] {
+m_workQueue->dispatchAfter(nextRenderDelay, [this, nextRenderTime, state = m_internalState] {
if (state->isProducingData())
generateSampleBuffers(nextRenderTime);
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294229] trunk/Source/WebCore
Title: [294229] trunk/Source/WebCore
Revision 294229
Author commit-qu...@webkit.org
Date 2022-05-16 05:48:52 -0700 (Mon, 16 May 2022)
Log Message
REGRESSION(r294104): [GStreamer] getUserMedia broken
https://bugs.webkit.org/show_bug.cgi?id=240420
Patch by Philippe Normand on 2022-05-16
Reviewed by Xabier Rodriguez-Calvar.
The converter handling logic was modified in order to fix getUserMedia negotiated with raw
video and also getDisplayMedia which is always raw video and thus doesn't require decoding.
This patch also introduces a small optimization, reconfiguration is now done once only,
after setting size and framerate. Before this patch it was done twice, so the pipeline was a
taking more time to produce the first frame.
* platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
(WebCore::GStreamerVideoCaptureSource::~GStreamerVideoCaptureSource):
(WebCore::GStreamerVideoCaptureSource::settingsDidChange): Trigger capturer reconfiguration after setting both size and framerate.
(WebCore::GStreamerVideoCaptureSource::startProducingData): Ditto.
* platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::createConverter): Do not decode display capture streams, these are always raw anyway.
(WebCore::GStreamerVideoCapturer::setSize): Delay reconfiguration.
(WebCore::GStreamerVideoCapturer::setFrameRate): Ditto.
(WebCore::GStreamerVideoCapturer::reconfigure): Keep track of compatible video format. This
is needed to workaround an issue in pipewiresrc caps negotiation.
(WebCore::GStreamerVideoCapturer::adjustVideoSrcMIMEType): Renamed to reconfigure().
* platform/mediastream/gstreamer/GStreamerVideoCapturer.h:
Canonical link: https://commits.webkit.org/250587@main
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp
trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp
trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (294228 => 294229)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 12:23:09 UTC (rev 294228)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 12:48:52 UTC (rev 294229)
@@ -1,5 +1,32 @@
2022-05-15 Philippe Normand
+REGRESSION(r294104): [GStreamer] getUserMedia broken
+https://bugs.webkit.org/show_bug.cgi?id=240420
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+The converter handling logic was modified in order to fix getUserMedia negotiated with raw
+video and also getDisplayMedia which is always raw video and thus doesn't require decoding.
+
+This patch also introduces a small optimization, reconfiguration is now done once only,
+after setting size and framerate. Before this patch it was done twice, so the pipeline was a
+taking more time to produce the first frame.
+
+* platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
+(WebCore::GStreamerVideoCaptureSource::~GStreamerVideoCaptureSource):
+(WebCore::GStreamerVideoCaptureSource::settingsDidChange): Trigger capturer reconfiguration after setting both size and framerate.
+(WebCore::GStreamerVideoCaptureSource::startProducingData): Ditto.
+* platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
+(WebCore::GStreamerVideoCapturer::createConverter): Do not decode display capture streams, these are always raw anyway.
+(WebCore::GStreamerVideoCapturer::setSize): Delay reconfiguration.
+(WebCore::GStreamerVideoCapturer::setFrameRate): Ditto.
+(WebCore::GStreamerVideoCapturer::reconfigure): Keep track of compatible video format. This
+is needed to workaround an issue in pipewiresrc caps negotiation.
+(WebCore::GStreamerVideoCapturer::adjustVideoSrcMIMEType): Renamed to reconfigure().
+* platform/mediastream/gstreamer/GStreamerVideoCapturer.h:
+
+2022-05-15 Philippe Normand
+
[GStreamer] Add basic video meta handling in sinks
https://bugs.webkit.org/show_bug.cgi?id=240429
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp (294228 => 294229)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp 2022-05-16 12:23:09 UTC (rev 294228)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp 2022-05-16 12:48:52 UTC (rev 294229)
@@ -145,7 +145,7 @@
g_signal_handlers_disconnect_by_func(m_capturer->sink(), reinterpret_cast(newSampleCallback), this);
m_capturer->stop();
-if (m_capturer->feedingFromPipewire()) {
+if (m_capturer->isCapturingDisplay()) {
auto& manager = GStreamerDisplayCaptureDeviceManager::singleton();
manager.stopSource(persistentID());
}
@@ -162,6 +162,8 @@
if (settings.contains(RealtimeMediaSourceSettings::Flag::FrameRate))
[webkit-changes] [294228] trunk/Source/WebCore
Title: [294228] trunk/Source/WebCore
Revision 294228
Author commit-qu...@webkit.org
Date 2022-05-16 05:23:09 -0700 (Mon, 16 May 2022)
Log Message
[GStreamer] Add basic video meta handling in sinks
https://bugs.webkit.org/show_bug.cgi?id=240429
Patch by Philippe Normand on 2022-05-16
Reviewed by Xabier Rodriguez-Calvar.
By handling allocation queries and advertising video meta handling to upstream elements, our
video sinks are now more efficient, especially on Raspberry Pi 4 with the v4l2 stateless
H.264 decoder.
* platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
(webKitVideoSinkSetMediaPlayerPrivate):
Canonical link: https://commits.webkit.org/250586@main
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (294227 => 294228)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 11:43:54 UTC (rev 294227)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 12:23:09 UTC (rev 294228)
@@ -1,3 +1,17 @@
+2022-05-15 Philippe Normand
+
+[GStreamer] Add basic video meta handling in sinks
+https://bugs.webkit.org/show_bug.cgi?id=240429
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+By handling allocation queries and advertising video meta handling to upstream elements, our
+video sinks are now more efficient, especially on Raspberry Pi 4 with the v4l2 stateless
+H.264 decoder.
+
+* platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
+(webKitVideoSinkSetMediaPlayerPrivate):
+
2022-05-16 Tim Nguyen
[css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp (294227 => 294228)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp 2022-05-16 11:43:54 UTC (rev 294227)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp 2022-05-16 12:23:09 UTC (rev 294228)
@@ -64,14 +64,20 @@
return GST_PAD_PROBE_OK;
}
-// In some platforms (e.g. OpenMAX on the Raspberry Pi) when a resolution change occurs the
-// pipeline has to be drained before a frame with the new resolution can be decoded.
-// In this context, it's important that we don't hold references to any previous frame
-// (e.g. m_sample) so that decoding can continue.
-// We are also not supposed to keep the original frame after a flush.
if (info->type & GST_PAD_PROBE_TYPE_QUERY_DOWNSTREAM) {
-if (GST_QUERY_TYPE(GST_PAD_PROBE_INFO_QUERY(info)) != GST_QUERY_DRAIN)
+auto* query = GST_PAD_PROBE_INFO_QUERY(info);
+if (GST_QUERY_TYPE(query) == GST_QUERY_ALLOCATION) {
+gst_query_add_allocation_meta(query, GST_VIDEO_META_API_TYPE, nullptr);
return GST_PAD_PROBE_OK;
+}
+
+// In some platforms (e.g. OpenMAX on the Raspberry Pi) when a resolution change occurs the
+// pipeline has to be drained before a frame with the new resolution can be decoded.
+// In this context, it's important that we don't hold references to any previous frame
+// (e.g. m_sample) so that decoding can continue.
+// We are also not supposed to keep the original frame after a flush.
+if (GST_QUERY_TYPE(query) != GST_QUERY_DRAIN)
+return GST_PAD_PROBE_OK;
GST_DEBUG("Acting upon DRAIN query");
}
if (info->type & GST_PAD_PROBE_TYPE_EVENT_FLUSH) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294227] trunk/LayoutTests
Title: [294227] trunk/LayoutTests Revision 294227 Author commit-qu...@webkit.org Date 2022-05-16 04:43:54 -0700 (Mon, 16 May 2022) Log Message Remove some custom-element tests https://bugs.webkit.org/show_bug.cgi?id=240449 Patch by Rob Buis on 2022-05-16 Reviewed by Tim Nguyen. Remove some custom-element tests since they are now available in WPT. * fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt: Removed. * fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html: Removed. * fast/custom-elements/perform-microtask-checkpoint-before-construction-expected.txt: Removed. * fast/custom-elements/perform-microtask-checkpoint-before-construction.html: Removed. * fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct-expected.txt: Removed. * fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html: Removed. * fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions-expected.txt: Removed. * fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt trunk/LayoutTests/fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html trunk/LayoutTests/fast/custom-elements/perform-microtask-checkpoint-before-construction-expected.txt trunk/LayoutTests/fast/custom-elements/perform-microtask-checkpoint-before-construction.html trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct-expected.txt trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions-expected.txt trunk/LayoutTests/fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html Diff Modified: trunk/LayoutTests/ChangeLog (294226 => 294227) --- trunk/LayoutTests/ChangeLog 2022-05-16 10:27:00 UTC (rev 294226) +++ trunk/LayoutTests/ChangeLog 2022-05-16 11:43:54 UTC (rev 294227) @@ -1,3 +1,21 @@ +2022-05-16 Rob Buis + +Remove some custom-element tests +https://bugs.webkit.org/show_bug.cgi?id=240449 + +Reviewed by Tim Nguyen. + +Remove some custom-element tests since they are now available in WPT. + +* fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt: Removed. +* fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html: Removed. +* fast/custom-elements/perform-microtask-checkpoint-before-construction-expected.txt: Removed. +* fast/custom-elements/perform-microtask-checkpoint-before-construction.html: Removed. +* fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct-expected.txt: Removed. +* fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html: Removed. +* fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions-expected.txt: Removed. +* fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html: Removed. + 2022-05-16 Tim Nguyen [css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal Deleted: trunk/LayoutTests/fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt (294226 => 294227) --- trunk/LayoutTests/fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt 2022-05-16 10:27:00 UTC (rev 294226) +++ trunk/LayoutTests/fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt 2022-05-16 11:43:54 UTC (rev 294227) @@ -1,10 +0,0 @@ - -PASS Disconnecting an element with disconnectedCallback while it has a connectedCallback in its custom element reaction queue must result in connectedCallback getting invoked before the removal completes -PASS Disconnecting an element without disconnectedCallback while it has a connectedCallback in its custom element reaction queue must not result in connectedCallback getting invoked before the removal completes -PASS Connecting a element with connectedCallback while it has a disconnectedCallback in its custom element reaction queue must result in disconnectedCallback getting invoked before the insertion completes -PASS Connecting an element without connectedCallback while it has a disconnectedCallback in its custom element reaction queue must not result in disconnectedCallback getting invoked before the insertion completes -PASS Adopting an element with adoptingCallback while it has a connectedCallback in its custom element reaction queue must result in connectedCallback getting invoked before the adoption completes
[webkit-changes] [294226] trunk
Title: [294226] trunk Revision 294226 Author n...@apple.com Date 2022-05-16 03:27:00 -0700 (Mon, 16 May 2022) Log Message [css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal https://bugs.webkit.org/show_bug.cgi?id=240448 Reviewed by Antti Koivisto. Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html iOS baseline for appearance-cssom-001-expected.txt is identical to the main one, so remove it. LayoutTests: * fast/forms/range/thumbslider-crash-expected.txt: Removed. * fast/forms/range/thumbslider-crash.html: Removed. * fast/forms/range/thumbslider-no-parent-slider.html: Removed. * platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed. * platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. * platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed. * platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. * platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed. * platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. * platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. * platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. * imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Source/WebCore: * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * css/CSSValueKeywords.in: * platform/ThemeTypes.h: Canonical link: https://commits.webkit.org/250584@main Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/css/CSSValueKeywords.in trunk/Source/WebCore/platform/ThemeTypes.h Removed Paths trunk/LayoutTests/fast/forms/range/thumbslider-crash-expected.txt trunk/LayoutTests/fast/forms/range/thumbslider-crash.html trunk/LayoutTests/fast/forms/range/thumbslider-no-parent-slider.html trunk/LayoutTests/platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png trunk/LayoutTests/platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt trunk/LayoutTests/platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/LayoutTests/platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png trunk/LayoutTests/platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt trunk/LayoutTests/platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt trunk/LayoutTests/platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (294225 => 294226) --- trunk/LayoutTests/ChangeLog 2022-05-16 08:18:23 UTC (rev 294225) +++ trunk/LayoutTests/ChangeLog 2022-05-16 10:27:00 UTC (rev 294226) @@ -1,3 +1,25 @@ +2022-05-16 Tim Nguyen + +[css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal +https://bugs.webkit.org/show_bug.cgi?id=240448 + +Reviewed by Antti Koivisto. + +iOS baseline for appearance-cssom-001-expected.txt is identical to the main one, so remove it. + +* fast/forms/range/thumbslider-crash-expected.txt: Removed. +* fast/forms/range/thumbslider-crash.html: Removed. +* fast/forms/range/thumbslider-no-parent-slider.html: Removed. +* platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed. +* platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. +* platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: +* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed. +* platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. +* platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed. +* platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. +* platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. +* platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. + 2022-05-16 Martin Robinson Do not allow unitless values for CSS unprefixed perspective property Deleted:
[webkit-changes] [294225] trunk
Title: [294225] trunk Revision 294225 Author you...@apple.com Date 2022-05-16 01:18:23 -0700 (Mon, 16 May 2022) Log Message Make sure calling showNotification will extend the service worker lifetime https://bugs.webkit.org/show_bug.cgi?id=240273 Reviewed by Chris Dumez. Source/WebCore: Update NotificationClient API so that show is taking a completion handler. Make use of this completion handler to resolve the promise when the show notification steps are done, as per spec. Register push event to ServiceWorkerGlobalScope when the event handlers are called. When ServiceWorkerRegistration::show is called during one of the push event handlers, extend the push event lifetime by adding the show notification promise to the push event. Covered by API test. * Modules/notifications/Notification.cpp: * Modules/notifications/Notification.h: * Modules/notifications/NotificationClient.h: * dom/ScriptExecutionContext.cpp: * dom/ScriptExecutionContext.h: * workers/service/ServiceWorkerGlobalScope.cpp: * workers/service/ServiceWorkerGlobalScope.h: * workers/service/ServiceWorkerRegistration.cpp: * workers/service/ServiceWorkerRegistration.h: * workers/service/context/ServiceWorkerThread.cpp: Source/WebKit: On WebProcess side, implement the new NoficationClient::show API that takes a callback. Delay calling this callback until UIProcess tells us so through async IPC. On UIProcess side, take a callback and call it when the show notification steps are done. * NetworkProcess/Notifications/NetworkNotificationManager.cpp: * NetworkProcess/Notifications/NetworkNotificationManager.h: * Shared/Notifications/NotificationManagerMessageHandler.h: * Shared/Notifications/NotificationManagerMessageHandler.messages.in: * UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp: * UIProcess/Notifications/ServiceWorkerNotificationHandler.h: * UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp: * UIProcess/Notifications/WebNotificationManagerMessageHandler.h: * WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp: * WebProcess/Notifications/WebNotificationManager.cpp: * WebProcess/Notifications/WebNotificationManager.h: * WebProcess/WebCoreSupport/WebNotificationClient.cpp: * WebProcess/WebCoreSupport/WebNotificationClient.h: Source/WebKitLegacy/mac: * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: Tools: * TestWebKitAPI/TestNotificationProvider.cpp: * TestWebKitAPI/TestNotificationProvider.h: * TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/notifications/Notification.cpp trunk/Source/WebCore/Modules/notifications/Notification.h trunk/Source/WebCore/Modules/notifications/NotificationClient.h trunk/Source/WebCore/dom/ScriptExecutionContext.cpp trunk/Source/WebCore/dom/ScriptExecutionContext.h trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h trunk/Source/WebCore/workers/service/ServiceWorkerRegistration.cpp trunk/Source/WebCore/workers/service/ServiceWorkerRegistration.h trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp trunk/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h trunk/Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.h trunk/Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.messages.in trunk/Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp trunk/Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.h trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.h trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.h trunk/Source/WebKit/WebProcess/WebCoreSupport/WebNotificationClient.cpp trunk/Source/WebKit/WebProcess/WebCoreSupport/WebNotificationClient.h trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.h trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestNotificationProvider.cpp trunk/Tools/TestWebKitAPI/TestNotificationProvider.h trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm Diff Modified: trunk/Source/WebCore/ChangeLog (294224 => 294225) --- trunk/Source/WebCore/ChangeLog 2022-05-16 08:14:46 UTC (rev 294224) +++ trunk/Source/WebCore/ChangeLog 2022-05-16 08:18:23 UTC (rev 294225) @@ -1,3 +1,30 @@ +2022-05-16 Youenn Fablet + +Make sure calling showNotification will extend the service worker lifetime +https://bugs.webkit.org/show_bug.cgi?id=240273 + + +Reviewed by Chris Dumez. + +Update
[webkit-changes] [294224] trunk
Title: [294224] trunk Revision 294224 Author mrobin...@webkit.org Date 2022-05-16 01:14:46 -0700 (Mon, 16 May 2022) Log Message Do not allow unitless values for CSS unprefixed perspective property https://bugs.webkit.org/show_bug.cgi?id=104805 Reviewed by Tim Nguyen. LayoutTests/imported/w3c: * web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt: Source/WebCore: No new tests. This is tested by an existing WPT test: web-platform-tests/quirks/unitless-length/excluded-properties-001.html * animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/CSSProperties.json: * css/parser/CSSPropertyParser.cpp: (WebCore::consumePerspective): (WebCore::CSSPropertyParser::consumePrefixedPerspective): (WebCore::CSSPropertyParser::parseShorthand): * css/parser/CSSPropertyParser.h: * rendering/style/WillChangeData.cpp: (WebCore::WillChangeData::propertyCreatesStackingContext): LayoutTests: * platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSProperties.json trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp trunk/Source/WebCore/css/parser/CSSPropertyParser.h trunk/Source/WebCore/rendering/style/WillChangeData.cpp Diff Modified: trunk/LayoutTests/ChangeLog (294223 => 294224) --- trunk/LayoutTests/ChangeLog 2022-05-16 07:26:25 UTC (rev 294223) +++ trunk/LayoutTests/ChangeLog 2022-05-16 08:14:46 UTC (rev 294224) @@ -1,3 +1,17 @@ +2022-05-16 Martin Robinson + +Do not allow unitless values for CSS unprefixed perspective property +https://bugs.webkit.org/show_bug.cgi?id=104805 + + +Reviewed by Tim Nguyen. + +* platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: +* platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: +* platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: +* platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: + 2022-05-15 Fujii Hironori [WinCairo] Unreviewed test gardening Modified: trunk/LayoutTests/imported/w3c/ChangeLog (294223 => 294224) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-16 07:26:25 UTC (rev 294223) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-16 08:14:46 UTC (rev 294224) @@ -1,3 +1,14 @@ +2022-05-16 Martin Robinson + +Do not allow unitless values for CSS unprefixed perspective property +https://bugs.webkit.org/show_bug.cgi?id=104805 + + +Reviewed by Tim Nguyen. + +* web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: +* web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt: + 2022-05-13 Tim Nguyen [css-ui] Unexpose appearance property values already handled by appearance: auto Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (294223 => 294224) ---
[webkit-changes] [294223] trunk/Source/WebCore
Title: [294223] trunk/Source/WebCore
Revision 294223
Author you...@apple.com
Date 2022-05-16 00:26:25 -0700 (Mon, 16 May 2022)
Log Message
MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers
https://bugs.webkit.org/show_bug.cgi?id=240421
Reviewed by Eric Carlson.
We used to always call generateSampleBuffers from main thread.
We are now calling it from background thread with dispatchAfter to mimick a realtime clock.
This broke the dispatchSync call we were calling when stopping the mock unit as the dispatchAfter task would be called
after the dispatchSync and |this| could potentially no longer be valid.
To prevent this, we introduce MockAudioSharedInternalUnitState which allows to safely know whether the unit is stopped or not
at any point in time. If the unit is stopped, dispatchAfter will not call generateSampleBuffers.
Covered by existing tests.
* platform/mediastream/mac/MockAudioSharedUnit.mm:
(WebCore::MockAudioSharedInternalUnitState::create):
(WebCore::MockAudioSharedInternalUnitState::isProducingData const):
(WebCore::MockAudioSharedInternalUnitState::setIsProducingData):
(WebCore::MockAudioSharedInternalUnit::MockAudioSharedInternalUnit):
(WebCore::MockAudioSharedInternalUnit::~MockAudioSharedInternalUnit):
(WebCore::MockAudioSharedInternalUnit::start):
(WebCore::MockAudioSharedInternalUnit::stop):
(WebCore::MockAudioSharedInternalUnit::uninitialize):
(WebCore::MockAudioSharedInternalUnit::generateSampleBuffers):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (294222 => 294223)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 07:14:59 UTC (rev 294222)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 07:26:25 UTC (rev 294223)
@@ -1,3 +1,31 @@
+2022-05-16 Youenn Fablet
+
+MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers
+https://bugs.webkit.org/show_bug.cgi?id=240421
+
+
+Reviewed by Eric Carlson.
+
+We used to always call generateSampleBuffers from main thread.
+We are now calling it from background thread with dispatchAfter to mimick a realtime clock.
+This broke the dispatchSync call we were calling when stopping the mock unit as the dispatchAfter task would be called
+after the dispatchSync and |this| could potentially no longer be valid.
+To prevent this, we introduce MockAudioSharedInternalUnitState which allows to safely know whether the unit is stopped or not
+at any point in time. If the unit is stopped, dispatchAfter will not call generateSampleBuffers.
+
+Covered by existing tests.
+
+* platform/mediastream/mac/MockAudioSharedUnit.mm:
+(WebCore::MockAudioSharedInternalUnitState::create):
+(WebCore::MockAudioSharedInternalUnitState::isProducingData const):
+(WebCore::MockAudioSharedInternalUnitState::setIsProducingData):
+(WebCore::MockAudioSharedInternalUnit::MockAudioSharedInternalUnit):
+(WebCore::MockAudioSharedInternalUnit::~MockAudioSharedInternalUnit):
+(WebCore::MockAudioSharedInternalUnit::start):
+(WebCore::MockAudioSharedInternalUnit::stop):
+(WebCore::MockAudioSharedInternalUnit::uninitialize):
+(WebCore::MockAudioSharedInternalUnit::generateSampleBuffers):
+
2022-05-15 Youenn Fablet
Audio playback rate sped up for few seconds when using createMediaElementSource
Modified: trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm (294222 => 294223)
--- trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm 2022-05-16 07:14:59 UTC (rev 294222)
+++ trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm 2022-05-16 07:26:25 UTC (rev 294223)
@@ -97,6 +97,17 @@
return CoreAudioCaptureSource::createForTesting(WTFMove(deviceID), WTFMove(name), WTFMove(hashSalt), constraints, MockAudioSharedUnit::singleton(), pageIdentifier);
}
+class MockAudioSharedInternalUnitState : public ThreadSafeRefCounted {
+public:
+static Ref create() { return adoptRef(*new MockAudioSharedInternalUnitState()); }
+
+bool isProducingData() const { return m_isProducingData; }
+void setIsProducingData(bool value) { m_isProducingData = value; }
+
+private:
+bool m_isProducingData { false };
+};
+
class MockAudioSharedInternalUnit : public CoreAudioSharedUnit::InternalUnit {
WTF_MAKE_FAST_ALLOCATED;
public:
@@ -105,7 +116,7 @@
private:
OSStatus initialize() final;
-OSStatus uninitialize() final { return 0; }
+OSStatus uninitialize() final;
OSStatus start() final;
OSStatus stop() final;
OSStatus set(AudioUnitPropertyID, AudioUnitScope, AudioUnitElement, const void*, UInt32) final;
@@ -136,7 +147,7 @@
Vector m_bipBopBuffer;
bool m_hasAudioUnit { false };
-bool m_isProducingData { false };
+Ref
[webkit-changes] [294222] trunk/Source/WebKit
Title: [294222] trunk/Source/WebKit
Revision 294222
Author you...@apple.com
Date 2022-05-16 00:14:59 -0700 (Mon, 16 May 2022)
Log Message
Add logging when taking a process assertion synchronously
https://bugs.webkit.org/show_bug.cgi?id=240334
Reviewed by Chris Dumez.
No observable change of behavior.
* UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::ProcessAssertion::acquireSync):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (294221 => 294222)
--- trunk/Source/WebKit/ChangeLog 2022-05-16 06:37:21 UTC (rev 294221)
+++ trunk/Source/WebKit/ChangeLog 2022-05-16 07:14:59 UTC (rev 294222)
@@ -1,3 +1,15 @@
+2022-05-16 Youenn Fablet
+
+Add logging when taking a process assertion synchronously
+https://bugs.webkit.org/show_bug.cgi?id=240334
+
+Reviewed by Chris Dumez.
+
+No observable change of behavior.
+
+* UIProcess/ios/ProcessAssertionIOS.mm:
+(WebKit::ProcessAssertion::acquireSync):
+
2022-05-10 Yusuke Suzuki
Rename EventTrackingRegions::Event to EventTrackingRegions::EventType
Modified: trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm (294221 => 294222)
--- trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm 2022-05-16 06:37:21 UTC (rev 294221)
+++ trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm 2022-05-16 07:14:59 UTC (rev 294222)
@@ -367,15 +367,17 @@
void ProcessAssertion::acquireSync()
{
+RELEASE_LOG(ProcessSuspension, "%p - ProcessAssertion::acquireSync Trying to take RBS assertion '%{public}s' for process with PID=%d", this, m_reason.utf8().data(), m_pid);
+
NSError *acquisitionError = nil;
if (![m_rbsAssertion acquireWithError:]) {
-RELEASE_LOG_ERROR(ProcessSuspension, "%p - ProcessAssertion: Failed to acquire RBS assertion '%{public}s' for process with PID=%d, error: %{public}@", this, m_reason.utf8().data(), m_pid, acquisitionError);
+RELEASE_LOG_ERROR(ProcessSuspension, "%p - ProcessAssertion::acquireSync Failed to acquire RBS assertion '%{public}s' for process with PID=%d, error: %{public}@", this, m_reason.utf8().data(), m_pid, acquisitionError);
RunLoop::main().dispatch([weakThis = WeakPtr { *this }] {
if (weakThis)
weakThis->processAssertionWasInvalidated();
});
} else
-RELEASE_LOG(ProcessSuspension, "%p - ProcessAssertion: Successfully took RBS assertion '%{public}s' for process with PID=%d", this, m_reason.utf8().data(), m_pid);
+RELEASE_LOG(ProcessSuspension, "%p - ProcessAssertion::acquireSync Successfully took RBS assertion '%{public}s' for process with PID=%d", this, m_reason.utf8().data(), m_pid);
}
ProcessAssertion::~ProcessAssertion()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294221] trunk/Source/WebCore
Title: [294221] trunk/Source/WebCore
Revision 294221
Author you...@apple.com
Date 2022-05-15 23:37:21 -0700 (Sun, 15 May 2022)
Log Message
Audio playback rate sped up for few seconds when using createMediaElementSource
https://bugs.webkit.org/show_bug.cgi?id=239696
Reviewed by Eric Carlson.
We added a way for AudioSampleDataSource to reduce latency due to its audio buffer by reading the audio buffer faster
until the audio buffer size decreases to a reasonnable value.
The reasonnable buffer size was computed in terms of multiple of 10ms as RTC sources are pushing 10 or 20 millisecond chunks.
Other sources may push much bigger chunks (100 milliseconds for instance), in which case it does not make real sense to try to reduce the delay below it.
To prevent this, we will decrease the buffer size if it is above 100 milliseconds (as previously) AND the buffer size is 4 times the size of the pushed audio chunk.
4 times the size of the pushed audio chunk is 40 ms for RTC sources which is a reasonnable buffer size.
Manually tested with https://webaudioapi.com/samples/audio-tag/.
* platform/audio/cocoa/AudioSampleDataConverter.h:
* platform/audio/cocoa/AudioSampleDataConverter.mm:
(WebCore::AudioSampleDataConverter::updateBufferedAmount):
* platform/audio/cocoa/AudioSampleDataSource.mm:
(WebCore::AudioSampleDataSource::pushSamplesInternal):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.h
trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm
trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (294220 => 294221)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 02:32:13 UTC (rev 294220)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 06:37:21 UTC (rev 294221)
@@ -1,3 +1,26 @@
+2022-05-15 Youenn Fablet
+
+Audio playback rate sped up for few seconds when using createMediaElementSource
+https://bugs.webkit.org/show_bug.cgi?id=239696
+
+
+Reviewed by Eric Carlson.
+
+We added a way for AudioSampleDataSource to reduce latency due to its audio buffer by reading the audio buffer faster
+until the audio buffer size decreases to a reasonnable value.
+The reasonnable buffer size was computed in terms of multiple of 10ms as RTC sources are pushing 10 or 20 millisecond chunks.
+Other sources may push much bigger chunks (100 milliseconds for instance), in which case it does not make real sense to try to reduce the delay below it.
+To prevent this, we will decrease the buffer size if it is above 100 milliseconds (as previously) AND the buffer size is 4 times the size of the pushed audio chunk.
+4 times the size of the pushed audio chunk is 40 ms for RTC sources which is a reasonnable buffer size.
+
+Manually tested with https://webaudioapi.com/samples/audio-tag/.
+
+* platform/audio/cocoa/AudioSampleDataConverter.h:
+* platform/audio/cocoa/AudioSampleDataConverter.mm:
+(WebCore::AudioSampleDataConverter::updateBufferedAmount):
+* platform/audio/cocoa/AudioSampleDataSource.mm:
+(WebCore::AudioSampleDataSource::pushSamplesInternal):
+
2022-05-15 Wenson Hsieh
Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated
Modified: trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.h (294220 => 294221)
--- trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.h 2022-05-16 02:32:13 UTC (rev 294220)
+++ trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.h 2022-05-16 06:37:21 UTC (rev 294221)
@@ -42,7 +42,7 @@
~AudioSampleDataConverter();
OSStatus setFormats(const CAAudioStreamDescription& inputDescription, const CAAudioStreamDescription& outputDescription);
-bool updateBufferedAmount(size_t currentBufferedAmount);
+bool updateBufferedAmount(size_t currentBufferedAmount, size_t pushedSampleSize);
OSStatus convert(const AudioBufferList&, AudioSampleBufferList&, size_t sampleCount);
size_t regularBufferSize() const { return m_regularBufferSize; }
bool isRegular() const { return m_selectedConverter == m_regularConverter; }
Modified: trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm (294220 => 294221)
--- trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm 2022-05-16 02:32:13 UTC (rev 294220)
+++ trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm 2022-05-16 06:37:21 UTC (rev 294221)
@@ -72,13 +72,13 @@
return noErr;
}
-bool AudioSampleDataConverter::updateBufferedAmount(size_t currentBufferedAmount)
+bool AudioSampleDataConverter::updateBufferedAmount(size_t currentBufferedAmount, size_t pushedSampleSize)
{
if (currentBufferedAmount) {
if (m_selectedConverter == m_regularConverter) {
if (currentBufferedAmount <= m_lowBufferSize)
