[webkit-changes] [WebKit/WebKit] 6b9b66: Sync and remove [NotEnumerable] from `toString` as...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b9b667d2d27aa82c075e0a8e8b04e3353d05531
  
https://github.com/WebKit/WebKit/commit/6b9b667d2d27aa82c075e0a8e8b04e3353d05531
  Author: Ahmad Saleem 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M LayoutTests/js/dom/toString-dontEnum-expected.txt
M LayoutTests/js/dom/toString-dontEnum.html
M Source/WebCore/page/DOMSelection.idl

  Log Message:
  ---
  Sync and remove [NotEnumerable] from `toString` as per Selection API IDL 
Specification

https://bugs.webkit.org/show_bug.cgi?id=264991

Reviewed by Ryosuke Niwa.

This change is to align WebKit with Gecko / Firefox, Blink / Chromium and 
Web-Specification [1] by removing
[NoEnumerable] from 'toString' (stringifier).

[1] https://w3c.github.io/selection-api/#selection-interface

* Source/WebCore/page/DOMSelection.idl:
* LayoutTests/js/dom/toString-dontEnum.html: Rebaselined
* LayoutTests/js/dom/toString-dontEnum-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/270933@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c96f1c: Fix !ENABLE(ACCESSIBILITY) build following 270916@...

[Ross Kirsling]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c96f1c58a0d8f11be92c51b509d3858cfb73d366
  
https://github.com/WebKit/WebKit/commit/c96f1c58a0d8f11be92c51b509d3858cfb73d366
  Author: Ross Kirsling 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/accessibility/AXObjectCache.h

  Log Message:
  ---
  Fix !ENABLE(ACCESSIBILITY) build following 270916@main
https://bugs.webkit.org/show_bug.cgi?id=265080

Unreviewed build fix.

* Source/WebCore/accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::objectsForIDs): Delete duplicate definition.
(WebCore::AXObjectCache::relatedObjectIDsFor): Update function signature.

Canonical link: https://commits.webkit.org/270932@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1021b9: [WebM] video.buffered attribute will always be empty

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1021b9500accef619ee22b690c8b7ce7a8582baf
  
https://github.com/WebKit/WebKit/commit/1021b9500accef619ee22b690c8b7ce7a8582baf
  Author: Jean-Yves Avenard 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
A LayoutTests/media/content/short.webm
A LayoutTests/media/media-webm-opus-buffered-expected.txt
A LayoutTests/media/media-webm-opus-buffered.html
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm

  Log Message:
  ---
  [WebM] video.buffered attribute will always be empty
https://bugs.webkit.org/show_bug.cgi?id=265010
rdar://118550061

Reviewed by Jer Noble.

The MediaPlayerPrivate wasnt' notified when the buffered range was set.
Fly-by fix: networkState would never go back to idle if the media element only 
had an audio track.

We can also remote the method resetParserState, it serves no purpose for CRABS.

* LayoutTests/media/content/short.webm: Added.
* LayoutTests/media/media-webm-opus-buffered-expected.txt: Added.
* LayoutTests/media/media-webm-opus-buffered.html: Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::~MediaPlayerPrivateWebM):
(WebCore::MediaPlayerPrivateWebM::loadFinished):
(WebCore::MediaPlayerPrivateWebM::setBufferedRanges):
(WebCore::MediaPlayerPrivateWebM::updateDurationFromTrackBuffers):
(WebCore::MediaPlayerPrivateWebM::setNaturalSize):
(WebCore::MediaPlayerPrivateWebM::setNetworkState):
(WebCore::MediaPlayerPrivateWebM::appendCompleted):
(WebCore::MediaPlayerPrivateWebM::didParseInitializationData):
(WebCore::MediaPlayerPrivateWebM::resetParserState): Deleted.

Canonical link: https://commits.webkit.org/270931@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cab7e2: [git-webkit revert] Commit message should present ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cab7e2d834d95d64c75955f7d66e154f262b52ad
  
https://github.com/WebKit/WebKit/commit/cab7e2d834d95d64c75955f7d66e154f262b52ad
  Author: Brianna Fan 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Tools/Scripts/hooks/prepare-commit-msg
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py

  Log Message:
  ---
  [git-webkit revert] Commit message should present more useful information
https://bugs.webkit.org/show_bug.cgi?id=263456
rdar://117270674

Reviewed by Jonathan Bedard.

Commit message is formatted after webkit patch workflow.
Changed git-webkit revert logic to support these changes and future work.

* Tools/Scripts/hooks/prepare-commit-msg:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py:
(Revert.parser):
(Revert.get_issue_info):
(Revert):
(Revert.create_revert_commit_msg):
(Revert.revert_commit):
(Revert.main):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py:

Canonical link: https://commits.webkit.org/270930@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c54dbe: Crash while running WebCore::SourceBufferPrivate::...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c54dbe8ebd21d9268a73bb4e611bf9424d8172e7
  
https://github.com/WebKit/WebKit/commit/c54dbe8ebd21d9268a73bb4e611bf9424d8172e7
  Author: Jean-Yves Avenard 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp
M Source/WebCore/platform/graphics/SourceBufferPrivate.h

  Log Message:
  ---
  Crash while running WebCore::SourceBufferPrivate::processMediaSamplesOperation
https://bugs.webkit.org/show_bug.cgi?id=265008
rdar://116953621

Reviewed by Youenn Fablet.

It was possible for either memoryPressure or removeCodedFrame to be run in the 
middle of a pending appendBuffer operation.
The move to NativePromise already eliminated most of the possibilities by 
removeCodedFrame operation wasn't queued to the pending
list of operation.
We now only process removeCodedFrame once we have fully completed any pending 
appendBuffer.
Also, we allow for the appendBuffer operation to be aborted in more places.

* Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::removeCodedFrames):
(WebCore::SourceBufferPrivate::didReceiveInitializationSegment):
(WebCore::SourceBufferPrivate::append):
(WebCore::SourceBufferPrivate::processPendingMediaSamples):

Canonical link: https://commits.webkit.org/270929@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3616c5: Update .editorconfig to include python and perl sc...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3616c587918df72ec972a4ab62746d9a5516d96d
  
https://github.com/WebKit/WebKit/commit/3616c587918df72ec972a4ab62746d9a5516d96d
  Author: Yusuke Suzuki 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M .editorconfig

  Log Message:
  ---
  Update .editorconfig to include python and perl scripts
https://bugs.webkit.org/show_bug.cgi?id=264974
rdar://118523696

Reviewed by Justin Michaud.

This patch updates .editorconfig to include python and perl scripts so that we 
can use consistent rule supported by editors.

* .editorconfig:

Canonical link: https://commits.webkit.org/270928@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ec77ef: Unreviewed, GTK build fix

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec77ef00f5dabc2971dcf2e8c32190fdca2396dc
  
https://github.com/WebKit/WebKit/commit/ec77ef00f5dabc2971dcf2e8c32190fdca2396dc
  Author: Yusuke Suzuki 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/JavaScriptCore/heap/EdenGCActivityCallback.cpp
M Source/JavaScriptCore/heap/EdenGCActivityCallback.h
M Source/JavaScriptCore/heap/FullGCActivityCallback.cpp
M Source/JavaScriptCore/heap/FullGCActivityCallback.h

  Log Message:
  ---
  Unreviewed, GTK build fix
https://bugs.webkit.org/show_bug.cgi?id=265072
rdar://118585847

* Source/JavaScriptCore/heap/EdenGCActivityCallback.cpp:
* Source/JavaScriptCore/heap/EdenGCActivityCallback.h:
* Source/JavaScriptCore/heap/FullGCActivityCallback.cpp:
* Source/JavaScriptCore/heap/FullGCActivityCallback.h:

Canonical link: https://commits.webkit.org/270927@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4fbab9: Add tests for _WKWebExtensionDeclarativeNetRequest...

[Brian Weinstein]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4fbab99095d1b31f272aab6d5e74d7788c9fb60a
  
https://github.com/WebKit/WebKit/commit/4fbab99095d1b31f272aab6d5e74d7788c9fb60a
  Author: Brian Weinstein 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/Modules/OSX_Private.modulemap
M Source/WebKit/Modules/iOS_Private.modulemap
M 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestRule.h
M 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestRule.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestTranslator.h
M 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestTranslator.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/SourcesCocoa.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIExtension.mm

  Log Message:
  ---
  Add tests for _WKWebExtensionDeclarativeNetRequestRule and 
_WKWebExtensionDeclarativeNetRequestTranslator and make them SPI to use in 
TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=265049
rdar://118570291

Reviewed by Timothy Hatcher.

To add tests for these classes in TestWebKitAPI, the headers need to become 
private headers in the WebKit project. To do this, I needed to
get rid of all ENABLE flags and implement a version of the classes when 
WK_WEB_EXTENSIONS is off.

Doing this lets us add a lot of tests of the rule translator code into 
TestWebKitAPI.

Adding this new file showed a latent compilation error in 
WKWebExtensionAPIExtension, so fix that while we are here.

* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestRule.h:
* 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestRule.mm:
(WebKit::if):
(-[_WKWebExtensionDeclarativeNetRequestRule initWithDictionary:errorString:]):
(-[_WKWebExtensionDeclarativeNetRequestRule compare:]):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestTranslator.h:
* 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestTranslator.mm:
(+[_WKWebExtensionDeclarativeNetRequestTranslator 
jsonObjectsFromData:errorStrings:]):
(+[_WKWebExtensionDeclarativeNetRequestTranslator 
translateRules:errorStrings:]):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm:
 Added.
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIExtension.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/270926@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 00e440: [Cocoa] Create a platform abstraction for process ...

[aestes]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00e440a2f6c6fcd6c2729baa70d57a81977ecf28
  
https://github.com/WebKit/WebKit/commit/00e440a2f6c6fcd6c2729baa70d57a81977ecf28
  Author: Andy Estes 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WTF/wtf/PlatformEnable.h
M Source/WTF/wtf/PlatformUse.h
A Source/WebKit/Platform/cocoa/AssertionCapability.h
A Source/WebKit/Platform/cocoa/AssertionCapability.mm
A Source/WebKit/Platform/cocoa/ProcessCapability.cpp
A Source/WebKit/Platform/cocoa/ProcessCapability.h
M Source/WebKit/Platform/spi/Cocoa/ExtensionKitSPI.h
A Source/WebKit/Shared/Cocoa/ExtensionKitSoftLink.h
A Source/WebKit/Shared/Cocoa/ExtensionKitSoftLink.mm
M 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  [Cocoa] Create a platform abstraction for process capabilities
https://bugs.webkit.org/show_bug.cgi?id=264986
rdar://118533701

Reviewed by Per Arne Vollan.

In 269791@main we adopted _SECapabilities to take process assertions on iOS. In 
a follow-on change
we will adopt a new kind of process capability, so in preparation this change 
creates a platform
abstraction around the concept of process capabilities. This will allow us to 
more easily create new
types of capabilities and write tests.

For now, this change creates an abstract ProcessCapability class that can 
return a platform
capability (_SECapabilities on iOS), creates an AssertionCapability subclass 
that vends the type of
platform capability adopted in 269791@main, and uses it in 
ProcessAssertionCocoa.

* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformUse.h:
* Source/WebKit/Platform/cocoa/AssertionCapability.h: Added.
* Source/WebKit/Platform/cocoa/AssertionCapability.mm: Added.
(WebKit::AssertionCapability::AssertionCapability):
(WebKit::AssertionCapability::platformCapability const):
* Source/WebKit/Platform/cocoa/ProcessCapability.cpp: Added.
(WebKit::ProcessCapability::ProcessCapability):
* Source/WebKit/Platform/cocoa/ProcessCapability.h: Added.
(WebKit::ProcessCapability::environmentIdentifier const):
* Source/WebKit/Platform/spi/Cocoa/ExtensionKitSPI.h:
* Source/WebKit/Shared/Cocoa/ExtensionKitSoftLink.h: Added.
* Source/WebKit/Shared/Cocoa/ExtensionKitSoftLink.mm: Added.
* 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm:
(WebKit::runningBoardNameForAssertionType):
(WebKit::runningBoardDomainForAssertionType):
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::init):
(WebKit::ProcessAssertion::acquireSync):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/270925@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8d8e58: [ iOS ] imported/w3c/web-platform-tests/html/seman...

[sideshowbarker]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8d8e58ab0f77802d04b5552a38612ea8a63c1422
  
https://github.com/WebKit/WebKit/commit/8d8e58ab0f77802d04b5552a38612ea8a63c1422
  Author: Michael[tm] Smith 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [ iOS ] 
imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content.html
 is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=264285

Reviewed by Tim Nguyen.

For iOS testing, this change causes the WPT test
html/semantics/interactive-elements/the-summary-element/interactive-content.html
to be skipped — because that test relies on test_driver.click(), which
isn’t supported for iOS testing.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/270924@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 59ee70: [JSC] Add Fuzzilli support to jsc

[junghoon4a]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59ee7065d4c9870d8ad953a0b2d34a68f2c25e4e
  
https://github.com/WebKit/WebKit/commit/59ee7065d4c9870d8ad953a0b2d34a68f2c25e4e
  Author: Junghoon Lee 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Configurations/CommonBase.xcconfig
M Configurations/Sanitizers.xcconfig
M Source/JavaScriptCore/CMakeLists.txt
M Source/JavaScriptCore/Configurations/JSC.xcconfig
M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
A Source/JavaScriptCore/fuzzilli/Fuzzilli.cpp
A Source/JavaScriptCore/fuzzilli/Fuzzilli.h
M Source/JavaScriptCore/jsc.cpp
M Tools/Scripts/set-webkit-configuration
M Tools/Scripts/webkitdirs.pm

  Log Message:
  ---
  [JSC] Add Fuzzilli support to jsc
https://bugs.webkit.org/show_bug.cgi?id=264983


Reviewed by Yusuke Suzuki.

Based on a patch by Samuel Groß and Carl Smith:


* Configurations/CommonBase.xcconfig:
- Move support for adding -DENABLE_LIBFUZZER=1 to OTHER_CFLAGS from here
  to Sanitizers.xcconfig since LIBFUZZER support is there now.
* Configurations/Sanitizers.xcconfig:
- Add -DENABLE_LIBFUZZER=1 to OTHER_CFLAGS when ENABLE_LIBFUZZER=YES.
- Add -fsanitize-coverage=trace-pc-guard -DENABLE_FUZZILLI=1 to
  OTHER_CFLAGS when ENABLE_FUZZILLI=YES.
- Add -fsanitize-coverage=trace-pc-guard to OTHER_LDFLAGS when when
  ENABLE_FUZZILLI=YES.

* Source/JavaScriptCore/CMakeLists.txt:
- Add fuzzilli to the header search path for CMake builds.
* Source/JavaScriptCore/Configurations/JSC.xcconfig:
(JSC_USE_STATIC_LINKING):
- Set to YES only when ENABLE_FUZZILLI=YES as this is the only
  configuration where it is currently required.
* Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
- Disable static initializer check at link time when
  ENABLE_FUZZILLI=YES or when WK_ANY_SANITIZER_ENABLED=YES.
* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
- Add fuzzilli/Fuzzilli.{cpp,h} to the jsc target in the Xcode project.

* Source/JavaScriptCore/jsc.cpp:
(GlobalObject::promiseRejectionTracker):
(JSC_DEFINE_HOST_FUNCTION):
(runWithOptions):
(printUsageStatement):
(CommandLine::parseArguments):
(runJSC):
- Make changes to support Fuzzilli.  CommandLine::m_repl is always
  defined, but only set to true when Fuzzilli support is enabled.
  This simplifies some logic that would otherwise need to use the
  ENABLE(FUZZILLI) macro.

* Source/JavaScriptCore/fuzzilli/Fuzzilli.cpp: Add.
(Fuzzilli::resetCoverageEdges):
(Fuzzilli::logFile):
(Fuzzilli::waitForCommand):
(Fuzzilli::initializeCoverage):
(Fuzzilli::readInput):
(Fuzzilli::flushReprl):
(Fuzzilli::initializeReprl):
(__sanitizer_cov_trace_pc_guard_init):
(__sanitizer_cov_trace_pc_guard):
* Source/JavaScriptCore/fuzzilli/Fuzzilli.h: Add.
- Move core Fuzzilli code to its own header and source files.

* Tools/Scripts/set-webkit-configuration:
(printCurrentSettings):
- Add support for --[no-]fuzzilli command-line switches.
- Enabling Fuzzilli support also disables libFuzzer support.
* Tools/Scripts/webkitdirs.pm:
(determineFuzzilliIsEnabled):
(fuzzilliIsEnabled):
(XcodeOptions):
- Add support for the --[no-]fuzzilli command-line switches in
  set-webkit-configuration.

Canonical link: https://commits.webkit.org/270923@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7812e1: [webkitbugspy] Gracefully handle null duplicate

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7812e1fae6d3d9d08f5dfbdb50c9cc4868b9c98e
  
https://github.com/WebKit/WebKit/commit/7812e1fae6d3d9d08f5dfbdb50c9cc4868b9c98e
  Author: Jonathan Bedard 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitbugspy/setup.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py

  Log Message:
  ---
  [webkitbugspy] Gracefully handle null duplicate
https://bugs.webkit.org/show_bug.cgi?id=263694
rdar://117502065

Reviewed by Elliott Williams.

* Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py:
(Tracker.populate): If the provided relationship object doesn't define a
related radar, skip that relationship.

Canonical link: https://commits.webkit.org/270922@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 88a259: [git-webkit] Handle multiple bugs associated with ...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 88a259f2f225e68684db60360a653993ae1e8628
  
https://github.com/WebKit/WebKit/commit/88a259f2f225e68684db60360a653993ae1e8628
  Author: Jonathan Bedard 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Tools/Scripts/hooks/prepare-commit-msg

  Log Message:
  ---
  [git-webkit] Handle multiple bugs associated with a single branch
https://bugs.webkit.org/show_bug.cgi?id=264450
rdar://118144919

Reviewed by Elliott Williams.

Parse `git config` output backwards to prefer newer config values.
Except for bugs, only allow a single line to be passed to the template
via 'git config'. For bugs, we should only allow a single bug from each
tracker to be associated with the issue.

* Tools/Scripts/hooks/prepare-commit-msg:

Canonical link: https://commits.webkit.org/270921@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ed1571: Build fix when SERVICE_WORKER is disabled

[tKnmori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed1571ff480ce80acff17a25d0d0588d916f0580
  
https://github.com/WebKit/WebKit/commit/ed1571ff480ce80acff17a25d0d0588d916f0580
  Author: Takashi Komori 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  Build fix when SERVICE_WORKER is disabled
https://bugs.webkit.org/show_bug.cgi?id=264902

Reviewed by Don Olmstead.

When SERVICE_WORKER is dsabled, building webkit fails.
Functions below in GeneratedSerializers.cpp should be disabled when 
SERVICE_WORKER is off.

isValidEnum
isValidEnum

* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/270920@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5c9eac: Adjust GC Timer a bit with heuristics to avoid run...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c9eac47597dd0447d181e32ef2436cfce67791c
  
https://github.com/WebKit/WebKit/commit/5c9eac47597dd0447d181e32ef2436cfce67791c
  Author: Yusuke Suzuki 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/JavaScriptCore/CMakeLists.txt
M Source/JavaScriptCore/heap/EdenGCActivityCallback.cpp
M Source/JavaScriptCore/heap/EdenGCActivityCallback.h
M Source/JavaScriptCore/heap/FullGCActivityCallback.cpp
M Source/JavaScriptCore/heap/FullGCActivityCallback.h
M Source/JavaScriptCore/heap/GCActivityCallback.cpp
M Source/JavaScriptCore/heap/GCActivityCallback.h
M Source/JavaScriptCore/heap/Heap.cpp
M Source/JavaScriptCore/heap/Heap.h
M Source/JavaScriptCore/heap/MarkedSpace.cpp
M Source/JavaScriptCore/heap/MarkedSpace.h
M Source/JavaScriptCore/runtime/DeferredWorkTimer.h
M Source/JavaScriptCore/runtime/JSRunLoopTimer.h
M Source/JavaScriptCore/runtime/VM.cpp
M Source/WebCore/bindings/js/CommonVM.cpp
M Source/WebCore/page/OpportunisticTaskScheduler.cpp
M Source/WebCore/page/OpportunisticTaskScheduler.h

  Log Message:
  ---
  Adjust GC Timer a bit with heuristics to avoid running it while critical 
tasks are waiting
https://bugs.webkit.org/show_bug.cgi?id=265055
rdar://118574205

Reviewed by Wenson Hsieh and Justin Michaud.

We found that GC timer fires randomly and it runs GC at random timing. We 
should avoid
running it when there is critical tasks are waiting. This patch starts with a 
naive simple
approach which just defers this GC invocation with some threshold when there is 
a waiting task.
We are not directly using OpportunisticTaskScheduler since it is active only 
when a page is visible
and active, but we would like to run this GC for background page too. 
Eventually we would like
to unify both into one global mechanism but we put it as a future work.

* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/heap/EdenGCActivityCallback.cpp:
(JSC::EdenGCActivityCallback::EdenGCActivityCallback):
(JSC::EdenGCActivityCallback::doCollection):
* Source/JavaScriptCore/heap/EdenGCActivityCallback.h:
(JSC::EdenGCActivityCallback::tryCreate):
(): Deleted.
(JSC::GCActivityCallback::tryCreateEdenTimer): Deleted.
* Source/JavaScriptCore/heap/FullGCActivityCallback.cpp:
(JSC::FullGCActivityCallback::FullGCActivityCallback):
(JSC::FullGCActivityCallback::doCollection):
* Source/JavaScriptCore/heap/FullGCActivityCallback.h:
(JSC::FullGCActivityCallback::tryCreate):
(): Deleted.
(JSC::GCActivityCallback::tryCreateFullTimer): Deleted.
* Source/JavaScriptCore/heap/GCActivityCallback.cpp:
(JSC::GCActivityCallback::GCActivityCallback):
(JSC::GCActivityCallback::scheduleTimer):
* Source/JavaScriptCore/heap/GCActivityCallback.h:
(JSC::GCActivityCallback::didGCRecently const):
(JSC::GCActivityCallback::setDidGCRecently):
(JSC::GCActivityCallback::GCActivityCallback):
* Source/JavaScriptCore/heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::collect):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::collectNowFullIfNotDoneRecently):
(JSC::Heap::setFullActivityCallback):
(JSC::Heap::setEdenActivityCallback):
* Source/JavaScriptCore/heap/Heap.h:
* Source/JavaScriptCore/heap/MarkedSpace.cpp:
(JSC::MarkedSpace::beginMarking):
* Source/JavaScriptCore/heap/MarkedSpace.h:
(JSC::MarkedSpace::edenVersion const):
* Source/JavaScriptCore/runtime/DeferredWorkTimer.h:
* Source/JavaScriptCore/runtime/JSRunLoopTimer.h:
* Source/JavaScriptCore/runtime/VM.cpp:
(JSC::VM::performOpportunisticallyScheduledTasks):
* Source/WebCore/bindings/js/CommonVM.cpp:
(WebCore::commonVMSlow):
* Source/WebCore/page/OpportunisticTaskScheduler.cpp:
(WebCore::OpportunisticTaskScheduler::runLoopObserverFired):
(WebCore::isBusyForTimerBasedGC):
(WebCore::OpportunisticTaskScheduler::FullGCActivityCallback::doCollection):
(WebCore::OpportunisticTaskScheduler::EdenGCActivityCallback::doCollection):
* Source/WebCore/page/OpportunisticTaskScheduler.h:
(WebCore::OpportunisticTaskScheduler::create): Deleted.
(WebCore::OpportunisticTaskScheduler::willQueueIdleCallback): Deleted.
(WebCore::OpportunisticTaskScheduler::hasImminentlyScheduledWork const): 
Deleted.

Canonical link: https://commits.webkit.org/270919@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0b4f1f: Replace `-layoutHasChanged` and `-updateForChanged...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b4f1f99201e4820a2b8727d68a6ba57b3785457
  
https://github.com/WebKit/WebKit/commit/0b4f1f99201e4820a2b8727d68a6ba57b3785457
  Author: Wenson Hsieh 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/Platform/spi/ios/UIKitSPI.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  Replace `-layoutHasChanged` and `-updateForChangedSelection` with 
`-[UIAsyncTextInputDelegate invalidateTextEntryContext]`
https://bugs.webkit.org/show_bug.cgi?id=265054
rdar://118467892

Reviewed by Megan Gardner.

Adopt `-[UIAsyncTextInputDelegate invalidateTextEntryContext]`, which is a 
direct replacement for
`-[UIKeyboardImpl updateForChangedSelection]`. Since the latter also updates 
marked text UI if
needed, we can also replace the `-layoutHasChanged` call with this new method 
as well.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKRelativeTextRange isEmpty]):

Some drive-by fixes after the introduction of `WKRelativeTextRange` in 
270847@main:

1.  Enforce type safety in `-selectionRectsForRange:` and 
`-caretRectForPosition:`, in case any
system client calls these methods using a relative range.

2.  Fix `-[WKRelativeTextRange isEmpty]` so that it returns `YES` only in the 
case where the offsets
are equal, *and* the anchors are the same.

3.  Return `nil` in `-positionFromPosition:offset:` and 
`-textRangeFromPosition:toPosition:` instead
of `WKRelativeText{Range|Position}`, if the given positions are either not 
already relative to
the selection, or the given positions are not identical to the selection 
start/end. This is
possible if UIKit asks for `-markedTextRange`, and then asks for positions 
offset from the start
or end of the marked text.

(-[WKContentView replaceForWebView:]):

Another drive-by fix: the plan for handling `-replace:` has pivoted slightly, 
such that we're going
to instead call a new protocol method on the sytem input delegate, instead of 
calling into the
superclass. Adjust for that here.

(-[WKContentView caretRectForPosition:]):
(-[WKContentView selectionRectsForRange:]):
(-[WKContentView _isAnchoredToCurrentSelection:]):
(-[WKContentView textRangeFromPosition:toPosition:]):
(-[WKContentView positionFromPosition:offset:]):
(-[WKContentView _updateInputContextAfterBlurringAndRefocusingElement]):
(-[WKContentView _selectionChanged]):
(-[WKContentView setAsyncSystemInputDelegate:]):

Canonical link: https://commits.webkit.org/270918@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 34b37b: [UnifiedPDF] Use the scrolling tree for UnifiedPDF...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 34b37bd8fc5607f6eb809a7fc0ee4a5edd83a688
  
https://github.com/WebKit/WebKit/commit/34b37bd8fc5607f6eb809a7fc0ee4a5edd83a688
  Author: Tim Horton 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
A 
LayoutTests/compositing/plugins/pdf/pdf-scrolling-tree-dynamic-expected.txt
A LayoutTests/compositing/plugins/pdf/pdf-scrolling-tree-dynamic.html
A LayoutTests/compositing/plugins/pdf/pdf-scrolling-tree-expected.txt
A LayoutTests/compositing/plugins/pdf/pdf-scrolling-tree.html
M Source/WebCore/Sources.txt
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/LocalFrameView.h
M Source/WebCore/page/scrolling/ScrollingCoordinator.h
M Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.cpp
M Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h
M Source/WebCore/page/scrolling/ScrollingStateNode.h
A Source/WebCore/page/scrolling/ScrollingStatePluginHostingNode.cpp
A Source/WebCore/page/scrolling/ScrollingStatePluginHostingNode.h
A Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.cpp
A Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.h
M Source/WebCore/page/scrolling/ScrollingStateTree.cpp
M Source/WebCore/page/scrolling/ScrollingTreeNode.h
A Source/WebCore/page/scrolling/ScrollingTreePluginHostingNode.cpp
A Source/WebCore/page/scrolling/ScrollingTreePluginHostingNode.h
A Source/WebCore/page/scrolling/ScrollingTreePluginScrollingNode.cpp
A Source/WebCore/page/scrolling/ScrollingTreePluginScrollingNode.h
M Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm
A Source/WebCore/page/scrolling/mac/ScrollingTreePluginScrollingNodeMac.h
A Source/WebCore/page/scrolling/mac/ScrollingTreePluginScrollingNodeMac.mm
M Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp
M Source/WebCore/plugins/PluginViewBase.h
M Source/WebCore/rendering/EventRegion.h
M Source/WebCore/rendering/RenderEmbeddedObject.cpp
M Source/WebCore/rendering/RenderEmbeddedObject.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayer.h
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerBacking.h
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderLayerCompositor.h
M 
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp
M 
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm
M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingTreeIOS.cpp
A 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreePluginScrollingNodeIOS.h
A 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreePluginScrollingNodeIOS.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm
M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm
A 
Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreePluginScrollingNodeRemoteMac.cpp
A 
Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreePluginScrollingNodeRemoteMac.h
M Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PluginView.cpp
M Source/WebKit/WebProcess/Plugins/PluginView.h

  Log Message:
  ---
  [UnifiedPDF] Use the scrolling tree for UnifiedPDFPlugin
https://bugs.webkit.org/show_bug.cgi?id=265007
rdar://118154855

Reviewed by Simon Fraser.

Adopt async scrolling for Unified PDF plugin, improving scrolling performance,
getting scrolling working for the first time on iOS, and paving the way towards
UI-side scrollbars on macOS.

* Source/WebCore/Sources.txt:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::scrollableAreaForScrollingNodeID const):
* Source/WebCore/page/LocalFrameView.h:
Make it possible to install a non-RenderLayer-owned ScrollableArea as associated
with a ScrollingNodeID.

* Source/WebCore/plugins/PluginViewBase.h:
(WebCore::PluginViewBase::usesAsyncScrolling):

[webkit-changes] [WebKit/WebKit] 227e9b: AX: Duplicated relationships in AXObjectCache::m_r...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 227e9bce988182fcbc160b49a01ccdd7b4edbd35
  
https://github.com/WebKit/WebKit/commit/227e9bce988182fcbc160b49a01ccdd7b4edbd35
  Author: Andres Gonzalez 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  ---
  AX: Duplicated relationships in AXObjectCache::m_relations.
https://bugs.webkit.org/show_bug.cgi?id=265044


Reviewed by Tyler Wilcock.

Under certain conditions it is possible to add more than one entry to the 
AXObjectCache::m_relations data structure for the same pair of objects and the 
same relation type. To avoid this, this patch replaces the Vector in AXRelation 
with a ListHashSet. This also has some performance gain, since find and remove 
opeartions are o(1) in ListHashSets.

In addition, changed the enum AddingSymmetricRelation to AddSymmetricRelation 
which makes the code more readable.

* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::addRelation):
(WebCore::AXObjectCache::removeRelationByID):
(WebCore::AXObjectCache::relatedObjectIDsFor):
(WebCore::AXObjectCache::objectsForIDs const): Deleted.
* Source/WebCore/accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::objectsForIDs const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::objectsForIDs):
(WebCore::AXIsolatedTree::relatedObjectIDsFor):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/270916@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 023fc9: Add Mateusz Krzywicki as a contributor

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 023fc91cc1b047968acef3633b8758a2c8e3958e
  
https://github.com/WebKit/WebKit/commit/023fc91cc1b047968acef3633b8758a2c8e3958e
  Author: Jonathan Bedard 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add Mateusz Krzywicki as a contributor

Unreviewed contributor addition.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/270915@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 373b5f: style.display setter should be fast

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 373b5f1310c1d92cb0aef4b501a3bef651d07bf1
  
https://github.com/WebKit/WebKit/commit/373b5f1310c1d92cb0aef4b501a3bef651d07bf1
  Author: Yusuke Suzuki 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
M 
Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
M Source/WebCore/css/parser/CSSParserContext.h
M Source/WebCore/css/parser/CSSParserFastPaths.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/process-css-properties.py

  Log Message:
  ---
  style.display setter should be fast
https://bugs.webkit.org/show_bug.cgi?id=265009
rdar://118548941

Reviewed by Chris Dumez.

While `style.display` setter can be called frequently, this isn't optimized 
well.
This patch optimizes it in three ways.

1. We should have CSSParserFastPaths for display with simple one keyword, like, 
`style.display = "none"`.
2. We found that JSCSSStyleDeclaration::put is completely disabling IC and 
using the slowest path.
   Since JSCSSStyleDeclaration does not have any named getters / setters, we 
should use JSObject::put when
   we access to named property. We add a path which uses JSObject::put when 
propertyName is not index.
3. CSSParserContext is frequently created. We should use bitfields to make it 
much smaller (from 110 => 64).

* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GeneratePut):
(InstanceOverridesIndexedDefineOwnProperty):
(InstanceOverridesNamedDefineOwnProperty):
(InstanceOverridesDefineOwnProperty):
* Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::parseDisplay):
(WebCore::CSSParserFastPaths::maybeParseValue):

Canonical link: https://commits.webkit.org/270914@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 020f29: Port RemoteVideoFrameProxy::Properties to the new ...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 020f297aadfe1e55b3d238dfc7922cfa193ceae3
  
https://github.com/WebKit/WebKit/commit/020f297aadfe1e55b3d238dfc7922cfa193ceae3
  Author: Chris Dumez 
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.h
A Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxyProperties.h
A 
Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxyProperties.serialization.in

  Log Message:
  ---
  Port RemoteVideoFrameProxy::Properties to the new IPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=264620

Reviewed by Alex Christensen.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.h:
(WebKit::RemoteVideoFrameProxy::Properties::encode const): Deleted.
(WebKit::RemoteVideoFrameProxy::Properties::decode): Deleted.
* Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxyProperties.h: Added.
* 
Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxyProperties.serialization.in:
 Added.

Canonical link: https://commits.webkit.org/270575@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e98de6: [LBSE] Fix RenderSVGResourceClipper (re)painting p...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e98de6f4b331de2ca6ea78c00b6b6d6243c78621
  
https://github.com/WebKit/WebKit/commit/e98de6f4b331de2ca6ea78c00b6b6d6243c78621
  Author: Rob Buis 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
A LayoutTests/svg/repaint/clip-path-object-bounding-box-expected.txt
A LayoutTests/svg/repaint/clip-path-object-bounding-box-shrink-expected.txt
A LayoutTests/svg/repaint/clip-path-object-bounding-box-shrink.html
A 
LayoutTests/svg/repaint/clip-path-object-bounding-box-transformed-expected.txt
A LayoutTests/svg/repaint/clip-path-object-bounding-box-transformed.html
A LayoutTests/svg/repaint/clip-path-object-bounding-box.html
A LayoutTests/svg/repaint/clip-path-user-space-on-use-expected.txt
A LayoutTests/svg/repaint/clip-path-user-space-on-use-shrink-expected.txt
A LayoutTests/svg/repaint/clip-path-user-space-on-use-shrink.html
A 
LayoutTests/svg/repaint/clip-path-user-space-on-use-transformed-expected.txt
A LayoutTests/svg/repaint/clip-path-user-space-on-use-transformed.html
A LayoutTests/svg/repaint/clip-path-user-space-on-use.html
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderLayer.h
M Source/WebCore/rendering/RenderLayerInlines.h
M Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp
M Source/WebCore/svg/SVGClipPathElement.cpp
M Source/WebCore/svg/SVGClipPathElement.h

  Log Message:
  ---
  [LBSE] Fix RenderSVGResourceClipper (re)painting problems
https://bugs.webkit.org/show_bug.cgi?id=264946

Reviewed by Nikolas Zimmermann.

The logic in RenderSVGResourceClipper::resourceBoundingBox does not take
the actual clip content rectangle into account, use the legacy solution which 
does.

Also stop repainting SVG resources by adjusting 
RenderElement::isInsideEntirelyHiddenLayer.

This PR also adds repaint tests that verify repaint rectangles after changing 
clipping content.

* LayoutTests/svg/repaint/clip-path-object-bounding-box-expected.txt: Added.
* LayoutTests/svg/repaint/clip-path-object-bounding-box-shrink-expected.txt: 
Added.
* LayoutTests/svg/repaint/clip-path-object-bounding-box-shrink.html: Added.
* 
LayoutTests/svg/repaint/clip-path-object-bounding-box-transformed-expected.txt: 
Added.
* LayoutTests/svg/repaint/clip-path-object-bounding-box-transformed.html: Added.
* LayoutTests/svg/repaint/clip-path-object-bounding-box.html: Added.
* LayoutTests/svg/repaint/clip-path-user-space-on-use-expected.txt: Added.
* LayoutTests/svg/repaint/clip-path-user-space-on-use-shrink-expected.txt: 
Added.
* LayoutTests/svg/repaint/clip-path-user-space-on-use-shrink.html: Added.
* LayoutTests/svg/repaint/clip-path-user-space-on-use-transformed-expected.txt: 
Added.
* LayoutTests/svg/repaint/clip-path-user-space-on-use-transformed.html: Added.
* LayoutTests/svg/repaint/clip-path-user-space-on-use.html: Added.
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::isInsideEntirelyHiddenLayer const):
* Source/WebCore/rendering/RenderLayer.h:
* Source/WebCore/rendering/RenderLayerInlines.h:
(WebCore::RenderLayer::enclosingSVGHiddenOrResourceContainer const):
* Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::resourceBoundingBox):
* Source/WebCore/svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::calculateClipContentRepaintRect):
* Source/WebCore/svg/SVGClipPathElement.h:

Canonical link: https://commits.webkit.org/270913@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 839bf8: Make 270849@main have no effect when site isolatio...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 839bf830c8c625acdabd89736bb541543e98c7a2
  
https://github.com/WebKit/WebKit/commit/839bf830c8c625acdabd89736bb541543e98c7a2
  Author: Alex Christensen 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  ---
  Make 270849@main have no effect when site isolation is off
https://bugs.webkit.org/show_bug.cgi?id=265063
rdar://118574473

Unreviewed.

It was supposed to only change behavior when site isolation was on.
It broke the tests 
http/tests/inspector/target/provisional-load-cancels-previous-load.html
and TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON.
This fixes those two tests and restores existing behavior with site isolation 
off.
There is still work to do when site isolation is on.  A lot of work.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

Canonical link: https://commits.webkit.org/270912@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 027711: Remove an unnecessary call to -[UIKeyboardImpl cle...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 027711e3d3c063ba9b8e9c835a194fceafa878d3
  
https://github.com/WebKit/WebKit/commit/027711e3d3c063ba9b8e9c835a194fceafa878d3
  Author: Wenson Hsieh 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/Platform/spi/ios/UIKitSPI.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  Remove an unnecessary call to -[UIKeyboardImpl clearShiftState] after 
rdar://118307508
https://bugs.webkit.org/show_bug.cgi?id=265002
rdar://118543047

Reviewed by Richard Robinson and Megan Gardner.

Remove this call to `-[UIKeyboardImpl clearShiftState]`, which is no longer 
needed after the changes
in rdar://118307508.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _selectionChanged]):

Canonical link: https://commits.webkit.org/270911@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d08dfb: Fix assertion related UI process crash

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d08dfb4672fecde69e9b9c5f06ea323f5b2fb54d
  
https://github.com/WebKit/WebKit/commit/d08dfb4672fecde69e9b9c5f06ea323f5b2fb54d
  Author: Per Arne Vollan 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm

  Log Message:
  ---
  Fix assertion related UI process crash
https://bugs.webkit.org/show_bug.cgi?id=265045
rdar://118569476

Reviewed by Chris Dumez.

Fix assertion related UI process crash by checking if selector is present.

* Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm:
(WebKit::ProcessAssertion::ProcessAssertion):

Canonical link: https://commits.webkit.org/270910@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4e1e58: [build.webkit.org] Add visionOS images

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e1e5834d8ea95e2f121805484d7dca439569b51
  
https://github.com/WebKit/WebKit/commit/4e1e5834d8ea95e2f121805484d7dca439569b51
  Author: Jonathan Bedard 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
A Tools/CISupport/build-webkit-org/public_html/dashboard/Images/visionOS.png
A 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/visionOSSimulator.png

  Log Message:
  ---
  [build.webkit.org] Add visionOS images
rdar://118574982
https://bugs.webkit.org/show_bug.cgi?id=265059

Reviewed by Ryan Haddad.

* Tools/CISupport/build-webkit-org/public_html/dashboard/Images/visionOS.png: 
Added.
* 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/visionOSSimulator.png:
 Added.

Canonical link: https://commits.webkit.org/270909@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 54f2b1: Group forward declarations by namespace in Generat...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 54f2b1ca9dfd07f31b22583ad78f266cc763fd39
  
https://github.com/WebKit/WebKit/commit/54f2b1ca9dfd07f31b22583ad78f266cc763fd39
  Author: Chris Dumez 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/Scripts/generate-serializers.py
M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h

  Log Message:
  ---
  Group forward declarations by namespace in GeneratedSerializers.h
https://bugs.webkit.org/show_bug.cgi?id=265046

Reviewed by Alex Christensen.

* Source/WebKit/Scripts/generate-serializers.py:
(Template.forward_declaration):
(generate_header):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h:

Canonical link: https://commits.webkit.org/270908@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dd7600: Stop using Vector::unsafeAppendWithoutCapacityChec...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd7600e37d7414091d0207425b7d5990479d6487
  
https://github.com/WebKit/WebKit/commit/dd7600e37d7414091d0207425b7d5990479d6487
  Author: Chris Dumez 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp

  Log Message:
  ---
  Stop using Vector::unsafeAppendWithoutCapacityCheck() in 
AirAllocateRegistersByGraphColoring.cpp
https://bugs.webkit.org/show_bug.cgi?id=265005

Reviewed by Darin Adler.

* Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:

Canonical link: https://commits.webkit.org/270907@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 73ee3b: [Gardening]: NEW TEST[267491@main]: [ iOS17 ] impo...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73ee3b023f6727962cc340706521352d8f41772d
  
https://github.com/WebKit/WebKit/commit/73ee3b023f6727962cc340706521352d8f41772d
  Author: Marta Darbinyan 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [Gardening]: NEW TEST[267491@main]: [ iOS17 ] 
imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content.html
 is constant failure
https://bugs.webkit.org/show_bug.cgi?id=264992
rdar://118535739

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/270906@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6078e2: REGRESSION (270453@main?): [iOS] imported/w3c/web-...

[Ryan Haddad]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6078e234978a2ea250c2ea0a7347739dfbf08cf4
  
https://github.com/WebKit/WebKit/commit/6078e234978a2ea250c2ea0a7347739dfbf08cf4
  Author: Ryan Haddad 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  REGRESSION (270453@main?): [iOS] 
imported/w3c/web-platform-tests/css/css-sizing/button-min-width.html is 
consistently failing
https://bugs.webkit.org/show_bug.cgi?id=265053
rdar://118572212

Unreviewed test gardening.

* LayoutTests/platform/ios/TestExpectations: Mark the test as failing.

Canonical link: https://commits.webkit.org/270905@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c31e0d: Generate serialization of SandboxExtensionHandle

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c31e0dd75e709ee3ffec35dc0ece60754149fdc8
  
https://github.com/WebKit/WebKit/commit/c31e0dd75e709ee3ffec35dc0ece60754149fdc8
  Author: Alex Christensen 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm
M Source/WebKit/Shared/SandboxExtension.h
A Source/WebKit/Shared/SandboxExtension.serialization.in
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Generate serialization of SandboxExtensionHandle
https://bugs.webkit.org/show_bug.cgi?id=264994
rdar://118539219

Reviewed by Chris Dumez.

All the transformations to get this to work are pretty straightforward,
except the if (dataReference.empty()) check to deserialize a valid, null
SandboxExtensionHandle if sandboxExtensionForType somehow returns an empty
string is replaced by a fast strlen-is-greater-than-0 check in
SandboxExtensionImpl::create to return an empty handle in the creation
process rather than failing to decode and killing the creation process.
This matches existing behavior as close as possible.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtensionImpl::create):
(WebKit::SandboxExtensionImpl::SandboxExtensionImpl):
(WebKit::SandboxExtensionImpl::~SandboxExtensionImpl):
(WebKit::SandboxExtensionImpl::consume):
(WebKit::SandboxExtensionImpl::invalidate):
(WebKit::SandboxExtensionImpl::getSerializedFormat):
(WebKit::SandboxExtensionImpl::sandboxExtensionForType):
(): Deleted.
(WebKit::SandboxExtensionHandle::encode): Deleted.
(WebKit::SandboxExtensionHandle::decode): Deleted.
* Source/WebKit/Shared/SandboxExtension.h:
(WebKit::SandboxExtensionImpl::SandboxExtensionImpl):
(WebKit::SandboxExtensionHandle::SandboxExtensionHandle):
(WebKit::SandboxExtensionHandle::takeImpl):
(WebKit::SandboxExtensionHandle::~SandboxExtensionHandle):
(WebKit::SandboxExtensionHandle::encode): Deleted.
(WebKit::SandboxExtensionHandle::decode): Deleted.
* Source/WebKit/Shared/SandboxExtension.serialization.in: Added.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/270904@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e59e03: Adopt ASCIILiteral in TextEncoding code

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e59e03e1df5b9d3dce970b9590767ceaabb9da47
  
https://github.com/WebKit/WebKit/commit/e59e03e1df5b9d3dce970b9590767ceaabb9da47
  Author: Chris Dumez 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WTF/wtf/HashTraits.h
M Source/WTF/wtf/text/ASCIILiteral.h
M Source/WebCore/PAL/pal/text/TextCodec.h
M Source/WebCore/PAL/pal/text/TextCodecCJK.cpp
M Source/WebCore/PAL/pal/text/TextCodecICU.cpp
M Source/WebCore/PAL/pal/text/TextCodecICU.h
M Source/WebCore/PAL/pal/text/TextCodecLatin1.cpp
M Source/WebCore/PAL/pal/text/TextCodecReplacement.cpp
M Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp
M Source/WebCore/PAL/pal/text/TextCodecUTF16.cpp
M Source/WebCore/PAL/pal/text/TextCodecUTF8.cpp
M Source/WebCore/PAL/pal/text/TextCodecUserDefined.cpp
M Source/WebCore/PAL/pal/text/TextEncoding.cpp
M Source/WebCore/PAL/pal/text/TextEncoding.h
M Source/WebCore/PAL/pal/text/TextEncodingRegistry.cpp
M Source/WebCore/PAL/pal/text/TextEncodingRegistry.h
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/DocumentInlines.h

  Log Message:
  ---
  Adopt ASCIILiteral in TextEncoding code
https://bugs.webkit.org/show_bug.cgi?id=264988

Reviewed by Darin Adler.

Adopt ASCIILiteral in TextEncoding code instead of `const char*` to
clarify the lifetime of these strings.

* Source/WTF/wtf/HashTraits.h:
(WTF::HashTraits::emptyValue):
(WTF::HashTraits::constructDeletedValue):
(WTF::HashTraits::isDeletedValue):
* Source/WTF/wtf/text/ASCIILiteral.h:
(WTF::ASCIILiteral::hash const):
(WTF::ASCIILiteralHash::hash):
(WTF::ASCIILiteralHash::equal):
* Source/WebCore/PAL/pal/text/TextCodec.h:
* Source/WebCore/PAL/pal/text/TextCodecCJK.cpp:
(PAL::TextCodecCJK::registerEncodingNames):
(PAL::TextCodecCJK::registerCodecs):
* Source/WebCore/PAL/pal/text/TextCodecICU.cpp:
(PAL::TextCodecICU::registerCodecs):
(PAL::TextCodecICU::TextCodecICU):
* Source/WebCore/PAL/pal/text/TextCodecICU.h:
* Source/WebCore/PAL/pal/text/TextCodecLatin1.cpp:
(PAL::TextCodecLatin1::registerEncodingNames):
(PAL::TextCodecLatin1::registerCodecs):
* Source/WebCore/PAL/pal/text/TextCodecReplacement.cpp:
(PAL::TextCodecReplacement::registerEncodingNames):
(PAL::TextCodecReplacement::registerCodecs):
* Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp:
(PAL::TextCodecSingleByte::registerEncodingNames):
(PAL::TextCodecSingleByte::registerCodecs):
* Source/WebCore/PAL/pal/text/TextCodecUTF16.cpp:
(PAL::TextCodecUTF16::registerEncodingNames):
(PAL::TextCodecUTF16::registerCodecs):
* Source/WebCore/PAL/pal/text/TextCodecUTF8.cpp:
(PAL::TextCodecUTF8::registerEncodingNames):
(PAL::TextCodecUTF8::registerCodecs):
* Source/WebCore/PAL/pal/text/TextCodecUserDefined.cpp:
(PAL::TextCodecUserDefined::registerEncodingNames):
(PAL::TextCodecUserDefined::registerCodecs):
* Source/WebCore/PAL/pal/text/TextEncoding.cpp:
(PAL::TextEncoding::decode const):
(PAL::TextEncoding::encode const):
(PAL::TextEncoding::domName const):
(PAL::TextEncoding::usesVisualOrdering const):
* Source/WebCore/PAL/pal/text/TextEncoding.h:
(PAL::TextEncoding::isValid const):
(PAL::TextEncoding::name const):
* Source/WebCore/PAL/pal/text/TextEncodingRegistry.cpp:
(PAL::TextEncodingNameHash::hash):
(PAL::HashTranslatorTextEncodingName::hash):
(PAL::HashTranslatorTextEncodingName::equal):
(PAL::isUndesiredAlias):
(PAL::WTF_REQUIRES_LOCK):
(PAL::isJapaneseEncoding):
(PAL::shouldShowBackslashAsCurrencySymbolIn):
(PAL::newTextCodec):
(PAL::atomCanonicalTextEncodingName):
* Source/WebCore/PAL/pal/text/TextEncodingRegistry.h:
* Source/WebCore/dom/DocumentInlines.h:
(WebCore::Document::encoding const):

Canonical link: https://commits.webkit.org/270903@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 28a5e6: [iOS] Remove sandbox extension of Frontboard XPC s...

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28a5e6a0092f62c0fd51c34a28a552bf0dea5dbd
  
https://github.com/WebKit/WebKit/commit/28a5e6a0092f62c0fd51c34a28a552bf0dea5dbd
  Author: Per Arne Vollan 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M 
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
M Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessPool.h
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  ---
  [iOS] Remove sandbox extension of Frontboard XPC service
https://bugs.webkit.org/show_bug.cgi?id=264969
rdar://118521486

Reviewed by Brent Fulgham.

We currently create a sandbox extension for this service when uploading files 
and enabling
Accessibility. Local testing has found no regressions when blocking this 
service.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):
* Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded): Deleted.
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didFinishLaunching):
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/270902@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eb12f0: [WPE][GTK] Fix VideoFrameGStreamer include for bui...

[Olivier Blin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb12f06944357d1a68c029ff621f140637494197
  
https://github.com/WebKit/WebKit/commit/eb12f06944357d1a68c029ff621f140637494197
  Author: Olivier Blin 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp
M 
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp

  Log Message:
  ---
  [WPE][GTK] Fix VideoFrameGStreamer include for build with WebCodecs and 
without MediaStream
https://bugs.webkit.org/show_bug.cgi?id=265034

Reviewed by Michael Catanzaro.

VideoFrameGStreamer.h was not included if WebCodecs was enabled but not 
MediaStream.

* Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp:
* 
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:

Canonical link: https://commits.webkit.org/270901@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f939a7: Rebaseline imported/w3c/web-platform-tests/html/se...

[Ryan Haddad]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f939a7ad15b6ca4a048c70f9605be95759998517
  
https://github.com/WebKit/WebKit/commit/f939a7ad15b6ca4a048c70f9605be95759998517
  Author: Ryan Haddad 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
A 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative-expected.txt

  Log Message:
  ---
  Rebaseline 
imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative.html
 for iOS
https://bugs.webkit.org/show_bug.cgi?id=265047
rdar://118569628

Unreviewed test gardening.

* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative-expected.txt:
 Added.

Canonical link: https://commits.webkit.org/270900@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 69c47f: [import-w3c-tests] check all baselines when deleti...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 69c47f823b0e278ba4a79e9661133153e6b334e5
  
https://github.com/WebKit/WebKit/commit/69c47f823b0e278ba4a79e9661133153e6b334e5
  Author: Sam Sneddon 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Tools/Scripts/webkitpy/w3c/test_importer.py
M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

  Log Message:
  ---
  [import-w3c-tests] check all baselines when deleting dangling baselines
https://bugs.webkit.org/show_bug.cgi?id=264735

Reviewed by Jonathan Bedard.

Previously, we found the first baseline for the current port, and
preserved that baseline. This is, of course, wrong: we need to preserve
baselines for all platforms, including (and especially) the generic
baseline.

* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.remove_dangling_expectations):
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.import_downloaded_tests):

Canonical link: https://commits.webkit.org/270899@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 579a9e: Fix AudioSourceProviderGStreamer build with !ENABL...

[Olivier Blin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 579a9e5c3ee474e180bd956077dda2ae229c1cce
  
https://github.com/WebKit/WebKit/commit/579a9e5c3ee474e180bd956077dda2ae229c1cce
  Author: Olivier Blin 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h

  Log Message:
  ---
  Fix AudioSourceProviderGStreamer build with !ENABLE(MEDIA_STREAM)
https://bugs.webkit.org/show_bug.cgi?id=265039

Reviewed by Philippe Normand.

* Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h:
WebAudioSourceProvider.h always needs to be included since
AudioSourceProviderGStreamer inherits from WebAudioSourceProvider.

Canonical link: https://commits.webkit.org/270898@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e0b7ea: Reduce logging in CoreIPCError

[Simon Lewis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e0b7ea8037ddccad1549de4aefa439635f2f8a5b
  
https://github.com/WebKit/WebKit/commit/e0b7ea8037ddccad1549de4aefa439635f2f8a5b
  Author: Simon Lewis 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/Shared/Cocoa/CoreIPCError.mm

  Log Message:
  ---
  Reduce logging in CoreIPCError
https://bugs.webkit.org/show_bug.cgi?id=264919
rdar://118490413

Reviewed by Brady Eidson.

Remove unneeded logging from the TestIPC output.

* Source/WebKit/Shared/Cocoa/CoreIPCError.mm:
(WebKit::CoreIPCError::CoreIPCError):

Canonical link: https://commits.webkit.org/270897@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 11c211: Minor PlatformHave cleanup

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11c211c312825f0bb0c7c65ba94daa362c018dd2
  
https://github.com/WebKit/WebKit/commit/11c211c312825f0bb0c7c65ba94daa362c018dd2
  Author: Anne van Kesteren 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WebCore/PAL/pal/avfoundation/OutputDevice.mm
M Source/WebCore/xml/XSLTProcessorLibxslt.cpp
M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  ---
  Minor PlatformHave cleanup
https://bugs.webkit.org/show_bug.cgi?id=265022

Reviewed by Wenson Hsieh.

Removes

- HAVE_FIG_PHOTO_DECOMPRESSION_SET_HARDWARE_CUTOFF
- HAVE_NSSHARINGSERVICEPICKER_ASYNC_MENUS
- HAVE_AVOUTPUTDEVICE_SPATIALAUDIO
- HAVE_LIBXSLT_FIX_FOR_RADAR_71864140

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/PAL/pal/avfoundation/OutputDevice.mm:
(PAL::OutputDevice::supportsSpatialAudio const):
* Source/WebCore/xml/XSLTProcessorLibxslt.cpp:
(WebCore::xsltParamArrayFromParameterMap):
* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::getStandardShareMenuItem):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/270896@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c15c26: Unified build fixes on macOS

[Yury Semikhatsky]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c15c2658c2629382644f9ca7fdf4bccc7d4ee725
  
https://github.com/WebKit/WebKit/commit/c15c2658c2629382644f9ca7fdf4bccc7d4ee725
  Author: Yury Semikhatsky 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/_WKFrameTreeNode.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferencesInternal.h
M Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm

  Log Message:
  ---
  Unified build fixes on macOS
https://bugs.webkit.org/show_bug.cgi?id=264981

Unreviewed, adding some missing includes to fix unified build errors
mentioned in the bug.

* Source/WebKit/UIProcess/API/Cocoa/_WKFrameTreeNode.mm:
* Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferencesInternal.h:
* Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:

Canonical link: https://commits.webkit.org/270895@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6226d4: [GTK] Get rid of EnumTraits for DMABufRendererBuff...

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6226d4c168b66ce1788461b8255a261e65f0d47b
  
https://github.com/WebKit/WebKit/commit/6226d4c168b66ce1788461b8255a261e65f0d47b
  Author: Claudio Saavedra 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/PlatformGTK.cmake
M Source/WebKit/Shared/glib/DMABufRendererBufferFormat.h
M Source/WebKit/Shared/glib/DMABufRendererBufferFormat.serialization.in
M Source/WebKit/Shared/glib/DMABufRendererBufferMode.h
A Source/WebKit/Shared/glib/DMABufRendererBufferMode.serialization.in

  Log Message:
  ---
  [GTK] Get rid of EnumTraits for DMABufRendererBuffer enums
https://bugs.webkit.org/show_bug.cgi?id=264958

Reviewed by Chris Dumez.

Port the DMABufRendererBuffer enums to the new IPC serialization
format, and get rid of the EnumTraits bits.

* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/Shared/glib/DMABufRendererBufferFormat.h:
* Source/WebKit/Shared/glib/DMABufRendererBufferFormat.serialization.in:
* Source/WebKit/Shared/glib/DMABufRendererBufferMode.h:
* Source/WebKit/Shared/glib/DMABufRendererBufferMode.serialization.in: added

Canonical link: https://commits.webkit.org/270894@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e3633f: Port IPC::SharedBufferReference to the new IPC ser...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3633fb4dca3f877787ad9a6518db345e11215a5
  
https://github.com/WebKit/WebKit/commit/e3633fb4dca3f877787ad9a6518db345e11215a5
  Author: Chris Dumez 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Platform/IPC/SharedBufferReference.cpp
M Source/WebKit/Platform/IPC/SharedBufferReference.h
A Source/WebKit/Platform/IPC/SharedBufferReference.serialization.in
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Port IPC::SharedBufferReference to the new IPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=264957

Reviewed by Alex Christensen.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Platform/IPC/SharedBufferReference.cpp:
(IPC::SharedBufferReference::SharedBufferReference):
(IPC::SharedBufferReference::bufferHandle const):
(IPC::SharedBufferReference::encode const): Deleted.
(IPC::SharedBufferReference::decode): Deleted.
* Source/WebKit/Platform/IPC/SharedBufferReference.h:
(IPC::SharedBufferReference::buffer const):
* Source/WebKit/Platform/IPC/SharedBufferReference.serialization.in: Added.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/270893@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 56b0d9: Add the ability for the IPCTestingAPI to report wh...

[Gavin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 56b0d92bb3fe7fbbdd946601c98e2e5b5b68fb75
  
https://github.com/WebKit/WebKit/commit/56b0d92bb3fe7fbbdd946601c98e2e5b5b68fb75
  Author: Gavin Phillips 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
A 
LayoutTests/ipc/send-invalid-sync-stream-message-empty-reply-check-exception-expected.txt
A 
LayoutTests/ipc/send-invalid-sync-stream-message-empty-reply-check-exception.html
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
M Source/WebKit/Platform/IPC/HandleMessage.h
M Source/WebKit/Platform/IPC/StreamServerConnection.cpp
M Source/WebKit/Platform/IPC/StreamServerConnection.h
M Source/WebKit/Shared/IPCStreamTester.cpp
M Source/WebKit/Shared/IPCStreamTester.h
M Source/WebKit/Shared/IPCStreamTester.messages.in
M Source/WebKit/Shared/IPCTester.cpp
M Source/WebKit/Shared/IPCTester.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp

  Log Message:
  ---
  Add the ability for the IPCTestingAPI to report when a sync stream message 
fails to be deserialized correctly
https://bugs.webkit.org/show_bug.cgi?id=264810
rdar://118391408

Reviewed by Alex Christensen.

Add the ability for the IPCTestingAPI to report when a sync stream connection
message fails to be received correctly. The existing behaviour is that no reply
is returned for failed messages. This change records the decoder validity
on failure into a MessageSyncReply so that the IPCTestingAPI can raise
an exception.

* 
LayoutTests/ipc/ignoreinvalidmessagesfortesting-stream-connection-expected.txt: 
Added.
* LayoutTests/ipc/ignoreinvalidmessagesfortesting-stream-connection.html: Added.
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::createRenderingBackend):
(WebKit::GPUConnectionToWebProcess::createGraphicsContextGL):
(WebKit::GPUConnectionToWebProcess::createRemoteGPU):
* Source/WebKit/Platform/IPC/HandleMessage.h:
(IPC::handleMessageSynchronous):
* Source/WebKit/Platform/IPC/StreamServerConnection.cpp:
(IPC::StreamServerConnection::tryCreate):
(IPC::StreamServerConnection::dispatchStreamMessage):
(IPC::StreamServerConnection::dispatchOutOfStreamMessage):
(IPC::StreamServerConnection::sendDeserializationErrorSyncReply):
* Source/WebKit/Platform/IPC/StreamServerConnection.h:
* Source/WebKit/Shared/IPCStreamTester.cpp:
(WebKit::IPCStreamTester::IPCStreamTester):
(WebKit::IPCStreamTester::syncMessageEmptyReply):
* Source/WebKit/Shared/IPCStreamTester.h:
* Source/WebKit/Shared/IPCStreamTester.messages.in:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp:
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/270892@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4dacd4: Regression(267645@main) ~3MB increase in binary size

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4dacd4adab9471bc6dfb8ce2c0a090a03cce1d52
  
https://github.com/WebKit/WebKit/commit/4dacd4adab9471bc6dfb8ce2c0a090a03cce1d52
  Author: Chris Dumez 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/JavaScriptCore/assembler/AbstractMacroAssembler.h
M Source/JavaScriptCore/b3/B3Origin.h
M Source/JavaScriptCore/b3/B3Type.h
M Source/JavaScriptCore/b3/air/AirTmp.h
M Source/JavaScriptCore/bytecode/ArithProfile.h
M Source/JavaScriptCore/bytecode/CallVariant.h
M Source/JavaScriptCore/bytecode/CodeBlockHash.h
M Source/JavaScriptCore/bytecode/VirtualRegister.h
M Source/JavaScriptCore/debugger/DebuggerScope.h
M Source/JavaScriptCore/dfg/DFGAbstractHeap.h
M Source/JavaScriptCore/dfg/DFGAbstractValueClobberEpoch.h
M Source/JavaScriptCore/dfg/DFGEdge.h
M Source/JavaScriptCore/dfg/DFGEpoch.h
M Source/JavaScriptCore/dfg/DFGNodeFlowProjection.h
M Source/JavaScriptCore/dfg/DFGRegisteredStructure.h
M Source/JavaScriptCore/heap/Allocator.h
M Source/JavaScriptCore/interpreter/CallFrame.h
M Source/JavaScriptCore/jit/GPRInfo.h
M Source/JavaScriptCore/jit/Reg.h
M Source/JavaScriptCore/parser/SourceCodeKey.h
M Source/JavaScriptCore/parser/VariableEnvironment.h
M Source/JavaScriptCore/profiler/ProfilerUID.h
M Source/JavaScriptCore/runtime/GenericOffset.h
M Source/JavaScriptCore/runtime/ISO8601.h
M Source/JavaScriptCore/runtime/JSScope.h
M Source/JavaScriptCore/runtime/PageCount.h
M Source/JavaScriptCore/runtime/StructureID.h
M Source/JavaScriptCore/runtime/StructureTransitionTable.h

  Log Message:
  ---
  Regression(267645@main) ~3MB increase in binary size
https://bugs.webkit.org/show_bug.cgi?id=264896
rdar://118490755

Reviewed by Brent Fulgham.

Pass comparison operands by const reference instead of by value, as
recommended by the clang team. This should generate code more similar
to the one before 267645@main.

* Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:
* Source/JavaScriptCore/b3/B3Origin.h:
* Source/JavaScriptCore/b3/B3Type.h:
* Source/JavaScriptCore/b3/air/AirTmp.h:
* Source/JavaScriptCore/bytecode/ArithProfile.h:
* Source/JavaScriptCore/bytecode/CallVariant.h:
* Source/JavaScriptCore/bytecode/CodeBlockHash.h:
* Source/JavaScriptCore/bytecode/VirtualRegister.h:
* Source/JavaScriptCore/debugger/DebuggerScope.h:
* Source/JavaScriptCore/dfg/DFGAbstractHeap.h:
* Source/JavaScriptCore/dfg/DFGAbstractValueClobberEpoch.h:
* Source/JavaScriptCore/dfg/DFGEdge.h:
* Source/JavaScriptCore/dfg/DFGEpoch.h:
* Source/JavaScriptCore/dfg/DFGNodeFlowProjection.h:
* Source/JavaScriptCore/dfg/DFGRegisteredStructure.h:
* Source/JavaScriptCore/heap/Allocator.h:
* Source/JavaScriptCore/interpreter/CallFrame.h:
* Source/JavaScriptCore/jit/GPRInfo.h:
* Source/JavaScriptCore/jit/Reg.h:
* Source/JavaScriptCore/parser/SourceCodeKey.h:
* Source/JavaScriptCore/parser/VariableEnvironment.h:
* Source/JavaScriptCore/profiler/ProfilerUID.h:
* Source/JavaScriptCore/runtime/GenericOffset.h:
* Source/JavaScriptCore/runtime/ISO8601.h:
* Source/JavaScriptCore/runtime/JSScope.h:
* Source/JavaScriptCore/runtime/PageCount.h:
* Source/JavaScriptCore/runtime/StructureID.h:
* Source/JavaScriptCore/runtime/StructureTransitionTable.h:

Canonical link: https://commits.webkit.org/270891@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c5a71d: Add style invalidity state for animations

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c5a71dadf89f5816fedaab3d7efaaec4e247fdc6
  
https://github.com/WebKit/WebKit/commit/c5a71dadf89f5816fedaab3d7efaaec4e247fdc6
  Author: Antti Koivisto 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/animation/ElementAnimationRareData.h
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/Element.h
M Source/WebCore/dom/Node.h
M Source/WebCore/style/StyleInvalidator.cpp
M Source/WebCore/style/StyleTreeResolver.cpp
M Source/WebCore/style/StyleTreeResolver.h
M Source/WebCore/style/StyleValidity.h
M Source/WebCore/style/Styleable.h
M Source/WebCore/testing/Internals.cpp

  Log Message:
  ---
  Add style invalidity state for animations
https://bugs.webkit.org/show_bug.cgi?id=264932
rdar://118500247

Reviewed by Antoine Quint.

We may be able to apply animation effects only without reapplying normal style 
rules.

* Source/WebCore/animation/ElementAnimationRareData.h:
(WebCore::ElementAnimationRareData::hasPropertiesOverridenAfterAnimation const):
(WebCore::ElementAnimationRareData::setHasPropertiesOverridenAfterAnimation):

If we have rules the override animation effects we can not use this 
optimization.

* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::invalidateElement):

Set the animation invalidity state instead of invaliding the element fully.

(WebCore::KeyframeEffect::animationDidChangeTimingProperties):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::invalidateStyleForAnimation):
(WebCore::Element::hasPropertiesOverridenAfterAnimation const):
(WebCore::Element::setHasPropertiesOverridenAfterAnimation):
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/Node.h:
* Source/WebCore/style/StyleInvalidator.cpp:
(WebCore::Style::Invalidator::invalidateIfNeeded):
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::styleForStyleable):

Use the base style from the previous frame instead of computing it again if only
the animation is invalid.

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::TreeResolver::determineResolutionType):
(WebCore::Style::shouldResolvePseudoElement): Deleted.
* Source/WebCore/style/StyleTreeResolver.h:
* Source/WebCore/style/StyleValidity.h:
* Source/WebCore/style/Styleable.h:
(WebCore::Styleable::hasPropertiesOverridenAfterAnimation const):
(WebCore::Styleable::setHasPropertiesOverridenAfterAnimation const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::styleValidityToToString):

Canonical link: https://commits.webkit.org/270890@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 295b9c: Register assertion invalidation callbacks

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 295b9ce46fcb73b97aee8dd1229f3089647d6a8e
  
https://github.com/WebKit/WebKit/commit/295b9ce46fcb73b97aee8dd1229f3089647d6a8e
  Author: Per Arne Vollan 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/Platform/spi/Cocoa/ExtensionKitSPI.h
M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm
M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm

  Log Message:
  ---
  Register assertion invalidation callbacks
https://bugs.webkit.org/show_bug.cgi?id=264760
rdar://118347404

Reviewed by Brent Fulgham.

Add environment identifier and register assertion invalidation callbacks for 
capabilities.

* Source/WebKit/Platform/spi/Cocoa/ExtensionKitSPI.h:
* Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm:
(WebKit::ProcessAssertion::ProcessAssertion):

Canonical link: https://commits.webkit.org/270889@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eea0af: [content-visibility] Property should not apply to ...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eea0af365e1cca71d12a328eee4398d5f2db9745
  
https://github.com/WebKit/WebKit/commit/eea0af365e1cca71d12a328eee4398d5f2db9745
  Author: Rob Buis 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-094-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-094.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-095-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-095.html
M Source/WebCore/rendering/RenderElementInlines.h
M Source/WebCore/rendering/style/RenderStyleInlines.h

  Log Message:
  ---
  [content-visibility] Property should not apply to tables
https://bugs.webkit.org/show_bug.cgi?id=264163

Reviewed by Tim Nguyen.

The content-visibility property applied to elements for which size containment 
can apply [1].
However, size containment does not apply to tables [2], so change the code to 
make content-visibility
not have a direct effect on tables.

[1] https://drafts.csswg.org/css-contain/#content-visibility
[2] https://drafts.csswg.org/css-contain/#containment-size

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-094-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-094.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-095-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-095.html:
 Added.
* Source/WebCore/rendering/RenderElementInlines.h:
(WebCore::RenderElement::shouldApplyLayoutOrPaintContainment const):
(WebCore::RenderElement::shouldApplyPaintContainment const):
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::isSkippedContentRoot):

Canonical link: https://commits.webkit.org/270888@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f2c812: RenderSearchField has a spurious stopSearchEventTi...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f2c812fd03f6c24f7d81131cdc7b367645cacf50
  
https://github.com/WebKit/WebKit/commit/f2c812fd03f6c24f7d81131cdc7b367645cacf50
  Author: Anne van Kesteren 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/rendering/RenderSearchField.h

  Log Message:
  ---
  RenderSearchField has a spurious stopSearchEventTimer() method
https://bugs.webkit.org/show_bug.cgi?id=264951

Reviewed by Alan Baradlay.

* Source/WebCore/rendering/RenderSearchField.h:

Canonical link: https://commits.webkit.org/270887@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 05bd97: WebXROpaqueFramebuffer queries state from GPUP

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05bd97a27164d3373bd61101c2f995d292bc36f0
  
https://github.com/WebKit/WebKit/commit/05bd97a27164d3373bd61101c2f995d292bc36f0
  Author: Kimmo Kinnunen 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/CMakeLists.txt
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
M Source/WebCore/html/canvas/WebGL2RenderingContext.h
M Source/WebCore/html/canvas/WebGLDrawInstancedBaseVertexBaseInstance.cpp
M Source/WebCore/html/canvas/WebGLMultiDraw.cpp
M 
Source/WebCore/html/canvas/WebGLMultiDrawInstancedBaseVertexBaseInstance.cpp
M Source/WebCore/html/canvas/WebGLRenderingContext.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
A Source/WebCore/html/canvas/WebGLUtilities.cpp
A Source/WebCore/html/canvas/WebGLUtilities.h

  Log Message:
  ---
  WebXROpaqueFramebuffer queries state from GPUP
https://bugs.webkit.org/show_bug.cgi?id=264248
rdar://117992444

Reviewed by Dan Glastonbury.

The context state is available in WebGLRenderingContextBase, and thus
it should not be queried from the underlying OpenGL context.

Add Scoped*Restore classes to encapsulate restoring the state from
the WebGL context. These will also be used when default framebuffer
implementation is moved from the underlying context to the webgl context
level.

Move all the scoped helpers to WebGLUtilities.h so they're available
to all the WebGL implementation files.

This is work towards supporting premultipliedAlpha=false compositing.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::endFrame):
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::drawRangeElements):
* Source/WebCore/html/canvas/WebGL2RenderingContext.h:
* Source/WebCore/html/canvas/WebGLDrawInstancedBaseVertexBaseInstance.cpp:
(WebCore::WebGLDrawInstancedBaseVertexBaseInstance::drawArraysInstancedBaseInstanceWEBGL):
(WebCore::WebGLDrawInstancedBaseVertexBaseInstance::drawElementsInstancedBaseVertexBaseInstanceWEBGL):
* Source/WebCore/html/canvas/WebGLMultiDraw.cpp:
(WebCore::WebGLMultiDraw::multiDrawArraysWEBGL):
(WebCore::WebGLMultiDraw::multiDrawArraysInstancedWEBGL):
(WebCore::WebGLMultiDraw::multiDrawElementsWEBGL):
(WebCore::WebGLMultiDraw::multiDrawElementsInstancedWEBGL):
* Source/WebCore/html/canvas/WebGLMultiDrawInstancedBaseVertexBaseInstance.cpp:
(WebCore::WebGLMultiDrawInstancedBaseVertexBaseInstance::multiDrawArraysInstancedBaseInstanceWEBGL):
(WebCore::WebGLMultiDrawInstancedBaseVertexBaseInstance::multiDrawElementsInstancedBaseVertexBaseInstanceWEBGL):
* Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::drawArrays):
(WebCore::WebGLRenderingContextBase::drawElements):
(WebCore::WebGLRenderingContextBase::drawArraysInstanced):
(WebCore::WebGLRenderingContextBase::drawElementsInstanced):
(WebCore::ScopedTightUnpackParameters::ScopedTightUnpackParameters): Deleted.
(WebCore::ScopedTightUnpackParameters::~ScopedTightUnpackParameters): Deleted.
(WebCore::ScopedTightUnpackParameters::set): Deleted.
(WebCore::ScopedDisableRasterizerDiscard::ScopedDisableRasterizerDiscard): 
Deleted.
(WebCore::ScopedDisableRasterizerDiscard::~ScopedDisableRasterizerDiscard): 
Deleted.
(WebCore::ScopedEnableBackbuffer::ScopedEnableBackbuffer): Deleted.
(WebCore::ScopedEnableBackbuffer::~ScopedEnableBackbuffer): Deleted.
(WebCore::ScopedDisableScissorTest::ScopedDisableScissorTest): Deleted.
(WebCore::ScopedDisableScissorTest::~ScopedDisableScissorTest): Deleted.
(WebCore::InspectorScopedShaderProgramHighlight::InspectorScopedShaderProgramHighlight):
 Deleted.
(WebCore::InspectorScopedShaderProgramHighlight::~InspectorScopedShaderProgramHighlight):
 Deleted.
(WebCore::InspectorScopedShaderProgramHighlight::showHighlight): Deleted.
(WebCore::InspectorScopedShaderProgramHighlight::hideHighlight): Deleted.
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:

Canonical link: https://commits.webkit.org/270886@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5223cb: Stream IPC calls into kernel while sending destina...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5223cb2bb65ae9f81a09d96d3833192cdebdac56
  
https://github.com/WebKit/WebKit/commit/5223cb2bb65ae9f81a09d96d3833192cdebdac56
  Author: Kimmo Kinnunen 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/Platform/IPC/StreamClientConnection.h

  Log Message:
  ---
  Stream IPC calls into kernel while sending destination ID
https://bugs.webkit.org/show_bug.cgi?id=264947
rdar://118509053

Reviewed by Matt Woodrow.

Make SetStreamDestinationID work like a batched message in order
to skip most of the wakeups after the message.
This avoids the kernel trap during sends where the message target
switches frequently.

* Source/WebKit/Platform/IPC/StreamClientConnection.h:
(IPC::StreamClientConnection::trySendDestinationIDIfNeeded):

Canonical link: https://commits.webkit.org/270885@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4c7dcf: [WebGPU] WGPUTextureFormat_RGB10A2Uint should supp...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c7dcf47194b0c256001df8e9b975b506d58d711
  
https://github.com/WebKit/WebKit/commit/4c7dcf47194b0c256001df8e9b975b506d58d711
  Author: Mike Wyrzykowski 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebGPU/WebGPU/Texture.mm

  Log Message:
  ---
  [WebGPU] WGPUTextureFormat_RGB10A2Uint should support multisampling
https://bugs.webkit.org/show_bug.cgi?id=265001
rdar://118542788

Reviewed by Tadeu Zagallo.

WGPUTextureFormat_RGB10A2Uint supports multisampling but it was
in the wrong part of the switch statement.

* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::supportsMultisampling):

Canonical link: https://commits.webkit.org/270884@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0bb4da: [GStreamer][WebCodecs][Debug] ASSERTs in video enc...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0bb4da6c65e2519ef6c902d2355a99ff88543392
  
https://github.com/WebKit/WebKit/commit/0bb4da6c65e2519ef6c902d2355a99ff88543392
  Author: Philippe Normand 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp

  Log Message:
  ---
  [GStreamer][WebCodecs][Debug] ASSERTs in video encoder
https://bugs.webkit.org/show_bug.cgi?id=264935

Reviewed by Xabier Rodriguez-Calvar.

Pass owned strings to WorkQueue callbacks and make a copy of the codecName 
string in the internal
encoders, as attempts to fix flaky crashes that I am unable to reproduce here.

* Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp:
(WebCore::GStreamerAudioEncoder::create):
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:
(WebCore::GStreamerVideoEncoder::create):

Canonical link: https://commits.webkit.org/270883@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 98da47: [WebGPU] webgpu:api, operation, buffers, * is not pas...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 98da47e2740e302d72a02213c42ad421a9c871a7
  
https://github.com/WebKit/WebKit/commit/98da47e2740e302d72a02213c42ad421a9c871a7
  Author: Mike Wyrzykowski 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/buffers/map-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/buffers/map_ArrayBuffer-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/buffers/map_detach-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/buffers/map_oom-expected.txt
M Source/JavaScriptCore/runtime/ArrayBuffer.cpp
M Source/JavaScriptCore/runtime/ArrayBuffer.h
M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp
M Source/WebCore/bindings/js/SerializedScriptValue.cpp

  Log Message:
  ---
  [WebGPU] webgpu:api,operation,buffers,* is not passing
https://bugs.webkit.org/show_bug.cgi?id=264825
rdar://118406537

Reviewed by Dan Glastonbury and Yusuke Suzuki.

The WebGPU specification prevents ArrayBuffers returned from getMappedRange from
being transferred via postMessage calls.

* LayoutTests/http/tests/webgpu/webgpu/api/operation/buffers/map-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/api/operation/buffers/map_ArrayBuffer-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/api/operation/buffers/map_detach-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/api/operation/buffers/map_oom-expected.txt:
Add passing expectations.

* Source/JavaScriptCore/runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::transferTo):
Use helper.

* Source/JavaScriptCore/runtime/ArrayBuffer.h:
(JSC::ArrayBuffer::isDetachable const):
Add helper member function to determine if an ArrayBuffer can be detached.

* Source/WebCore/Modules/WebGPU/GPUBuffer.cpp:
(WebCore::makeArrayBuffer):
(WebCore::GPUBuffer::internalUnmap):
Pin and unpin the buffer to prevent transferring.

* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
Throw a type error if we try to transfer an ArrayBuffer which can not
be detached.

Canonical link: https://commits.webkit.org/270882@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] edb411: [WebGPU] copy compressed textures fails when textu...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: edb411c919576af5b884c4edc7c44080bd78d7ca
  
https://github.com/WebKit/WebKit/commit/edb411c919576af5b884c4edc7c44080bd78d7ca
  Author: Mike Wyrzykowski 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/copyTextureToTexture-expected.txt
M Source/WebGPU/WebGPU/Queue.mm

  Log Message:
  ---
  [WebGPU] copy compressed textures fails when texture width is not divisible 
by the block size
https://bugs.webkit.org/show_bug.cgi?id=264923
radar://118491364

Reviewed by Tadeu Zagallo.

To correctly write to compressed textures, the width of the data must be 
divisible
by the compressed texture's block size and we were not previously ensuring that.

Also clean up newBytesPerRow and levelInfoBytesPerRow duplication which were 
being
assigned the same value and never modified.

* 
LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/copyTextureToTexture-expected.txt:
Add test expectation as this passes locally.

* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::writeTexture):

Canonical link: https://commits.webkit.org/270881@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cb302c: [webkitpy] Move WebKitFinder.{layout, perf}_tests_d...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cb302cd1f44f09c8b330f4c25efb99347b3b8878
  
https://github.com/WebKit/WebKit/commit/cb302cd1f44f09c8b330f4c25efb99347b3b8878
  Author: Sam Sneddon 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py
M 
Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py
M Tools/Scripts/webkitpy/common/webkit_finder.py
M Tools/Scripts/webkitpy/port/base.py
M Tools/Scripts/webkitpy/w3c/test_downloader.py
M Tools/Scripts/webkitpy/w3c/test_importer.py
M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

  Log Message:
  ---
  [webkitpy] Move WebKitFinder.{layout,perf}_tests_dir to Port
https://bugs.webkit.org/show_bug.cgi?id=264750

Reviewed by Jonathan Bedard.

We currently have two copies of these methods: one on the WebKitFinder
and one on the Port. The version on the Port allow the layout test
directory to be overriden by --layout-tests-dir (which is used for
certain non-public tests, for example).

We don't want to ever end up calling a code path that doesn't obey that
option if it has been passed, so it makes sense to unify all calls onto
the variants on Port.

To achieve this, we have to adjust a number of call sites to actually
have a Port, but this is a surprisingly small number.

* Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py:
(TestExpectationUpdater.__init__):
(main):
* 
Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py:
(TestExpectationUpdaterTest.test_update_test_expectations):
* Tools/Scripts/webkitpy/common/webkit_finder.py:
(WebKitFinder.path_from_webkit_base):
(WebKitFinder.path_to_script):
(WebKitFinder.layout_tests_dir): Deleted.
(WebKitFinder.perf_tests_dir): Deleted.
* Tools/Scripts/webkitpy/port/base.py:
(Port.path_from_webkit_base):
(Port.layout_tests_dir):
(Port.perf_tests_dir):
* Tools/Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader.__init__):
* Tools/Scripts/webkitpy/w3c/test_importer.py:
(main):
(TestImporter.__init__):
(TestImporter.test_downloader):
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
(TestImporterTest.test_import_dir_with_no_tests):
(TestImporterTest.test_import_dir_with_empty_init_py):
(TestImporterTest.import_directory):
(TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
(TestImporterTest.import_downloaded_tests):

Canonical link: https://commits.webkit.org/270880@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5aa9fe: [WGSL] Add parsing for directives

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5aa9fe80938ed403d06efbba763ddf77d24913ab
  
https://github.com/WebKit/WebKit/commit/5aa9fe80938ed403d06efbba763ddf77d24913ab
  Author: Tadeu Zagallo 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebGPU/WGSL/AST/AST.h
A Source/WebGPU/WGSL/AST/ASTDiagnostic.h
M Source/WebGPU/WGSL/AST/ASTDiagnosticAttribute.h
A Source/WebGPU/WGSL/AST/ASTDiagnosticDirective.h
M Source/WebGPU/WGSL/AST/ASTDirective.h
M Source/WebGPU/WGSL/AST/ASTForward.h
M Source/WebGPU/WGSL/AST/ASTNode.h
M Source/WebGPU/WGSL/AST/ASTStringDumper.cpp
M Source/WebGPU/WGSL/AST/ASTStringDumper.h
M Source/WebGPU/WGSL/AST/ASTVisitor.cpp
M Source/WebGPU/WGSL/AST/ASTVisitor.h
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/ParserPrivate.h
M Source/WebGPU/WGSL/WGSLEnums.cpp
M Source/WebGPU/WGSL/WGSLEnums.h
M Source/WebGPU/WGSL/WGSLShaderModule.h
M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj

  Log Message:
  ---
  [WGSL] Add parsing for directives
https://bugs.webkit.org/show_bug.cgi?id=264973
rdar://118522832

Reviewed by Mike Wyrzykowski.

Add support for parsing enable, requires and diagnostic directives.

* Source/WebGPU/WGSL/AST/AST.h:
* Source/WebGPU/WGSL/AST/ASTDiagnostic.h: Copied from 
Source/WebGPU/WGSL/AST/ASTDirective.h.
* Source/WebGPU/WGSL/AST/ASTDiagnosticAttribute.h:
* Source/WebGPU/WGSL/AST/ASTDiagnosticDirective.h: Copied from 
Source/WebGPU/WGSL/AST/ASTDirective.h.
* Source/WebGPU/WGSL/AST/ASTDirective.h:
(WGSL::AST::Directive::Directive):
(WGSL::AST::Directive::name const): Deleted.
* Source/WebGPU/WGSL/AST/ASTForward.h:
* Source/WebGPU/WGSL/AST/ASTNode.h:
* Source/WebGPU/WGSL/AST/ASTStringDumper.cpp:
(WGSL::AST::StringDumper::visit):
* Source/WebGPU/WGSL/AST/ASTStringDumper.h:
* Source/WebGPU/WGSL/AST/ASTVisitor.cpp:
(WGSL::AST::Visitor::visit):
* Source/WebGPU/WGSL/AST/ASTVisitor.h:
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser::parseShader):
(WGSL::Parser::parseEnableDirective):
(WGSL::Parser::parseRequireDirective):
(WGSL::Parser::parseAttribute):
(WGSL::Parser::parseDiagnostic):
* Source/WebGPU/WGSL/ParserPrivate.h:
* Source/WebGPU/WGSL/WGSLEnums.cpp:
* Source/WebGPU/WGSL/WGSLEnums.h:
* Source/WebGPU/WGSL/WGSLShaderModule.h:
(WGSL::ShaderModule::enabledExtensions):
(WGSL::ShaderModule::requiredFeatures):
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/270879@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 71c0ce: [import-w3c-tests] don't find fuzzy metadata as pa...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71c0ce6cf2ce1343ca845d2ab33a92540aef5b97
  
https://github.com/WebKit/WebKit/commit/71c0ce6cf2ce1343ca845d2ab33a92540aef5b97
  Author: Sam Sneddon 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Tools/Scripts/webkitpy/w3c/test_parser.py
M Tools/Scripts/webkitpy/w3c/test_parser_unittest.py

  Log Message:
  ---
  [import-w3c-tests] don't find fuzzy metadata as part of analyze_test
https://bugs.webkit.org/show_bug.cgi?id=263673

Reviewed by Jonathan Bedard.

We don't actually do anything with the fuzzy field, as we only pay
attention to the metadata in the test runner. Therefore, we can fix this
throwing on data it cannot parse by just not including the field at all.

* Tools/Scripts/webkitpy/w3c/test_parser.py:
(TestParser.analyze_test):
* Tools/Scripts/webkitpy/w3c/test_parser_unittest.py:
(_fuzzy_metadata_from_test_with_contents):
(_test_info_from_test_with_contents): Deleted.

Canonical link: https://commits.webkit.org/270878@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 734a5a: [GStreamer] Avoid using decoding limits for all co...

[Olivier Blin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 734a5ac349dfdd416b16df21782c4cbc6c3c133c
  
https://github.com/WebKit/WebKit/commit/734a5ac349dfdd416b16df21782c4cbc6c3c133c
  Author: Olivier Blin 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp

  Log Message:
  ---
  [GStreamer] Avoid using decoding limits for all configurations
https://bugs.webkit.org/show_bug.cgi?id=264941

Reviewed by Philippe Normand.

When VIDEO_DECODING_LIMIT support is enabled, after a first call of
isContentTypeSupported() with Configuration::Decoding, the video
limits are remembered in a static variable.

They were then used for all subsequent isContentTypeSupported() calls,
regardless of the configuration.

This should be limited to Configuration::Decoding.

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::isContentTypeSupported const):

Canonical link: https://commits.webkit.org/270877@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a8b3f7: MediaPlayerPrivateMediaSourceAVFObjC is not handli...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a8b3f78d322baecab6e30c5e454410a25f542740
  
https://github.com/WebKit/WebKit/commit/a8b3f78d322baecab6e30c5e454410a25f542740
  Author: Youenn Fablet 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
A 
LayoutTests/http/tests/media/media-source/media-source-video-fit-fill-expected.txt
A LayoutTests/http/tests/media/media-source/media-source-video-fit-fill.html
M LayoutTests/platform/mac-wk2/TestExpectations
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm

  Log Message:
  ---
  MediaPlayerPrivateMediaSourceAVFObjC is not handling aspect ratio 
preservation signal from HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=264944
rdar://118508061

Reviewed by Eric Carlson and Jer Noble.

MediaPlayer is calling setShouldMaintainAspectRatio but 
MediaPlayerPrivateMediaSourceAVFObjC was not implementing it.
Implement it by setting the gravity to AVLayerVideoGravityResizeAspect when we 
should maintain aspectRatio and AVLayerVideoGravityResizeAspect otherwise.
This fixes the bug for UI side compositing.
We should do a follow-up to fix it for non UI side compositing.

* 
LayoutTests/http/tests/media/media-source/media-source-video-fit-fill-expected.txt:
 Added.
* LayoutTests/http/tests/media/media-source/media-source-video-fit-fill.html: 
Added.
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setShouldMaintainAspectRatio):

Canonical link: https://commits.webkit.org/270876@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 477727: New test: imported/w3c/web-platform-tests/webrtc/R...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4777271bc3152771c7bb4e7a25d700863de12bd4
  
https://github.com/WebKit/WebKit/commit/4777271bc3152771c7bb4e7a25d700863de12bd4
  Author: Youenn Fablet 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-GC.https.html
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  New test: 
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-GC.https.html is a 
consistent/flaky text failure.
https://bugs.webkit.org/show_bug.cgi?id=260225
rdar://113932040

Reviewed by Jean-Yves Avenard.

The test was assuming that after the resize event, it would be possible to draw 
the video element in the canvas.
This is not guaranteed since the resize event may fire in HAVE_METADATA.

We replace the first call of onVideoChange by calling HTMLMediaElement.play().
To make it work, we trigger a canvas frame every 50 ms, instead of triggering 
frames when checking for the resize event.
We mute the media element to make the HTMLMediaElement.play() call work in all 
browsers.

* 
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-GC.https.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/270875@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a8751d: MediaPlayerPrivateMediaStreamAVFObjC is not handli...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a8751d3459816b5fba4ffc992a5cb8c3aa4048b5
  
https://github.com/WebKit/WebKit/commit/a8751d3459816b5fba4ffc992a5cb8c3aa4048b5
  Author: Youenn Fablet 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h
M 
Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in
M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp
M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h

  Log Message:
  ---
  MediaPlayerPrivateMediaStreamAVFObjC is not handling aspect ratio 
preservation signal from HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=264945
rdar://118508190

Reviewed by Eric Carlson and Jer Noble.

Add support for setShouldMaintainAspectRatio like for other media players.
Set the display layer video gravity accordingly.
Covered by LayoutTests/fast/mediastream/video-srcObject-fit-fill.html.

* Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
(WebCore::LocalSampleBufferDisplayLayer::initialize):
(WebCore::LocalSampleBufferDisplayLayer::setShouldMaintainAspectRatio):
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setShouldMaintainAspectRatio):
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::initialize):
(WebKit::RemoteSampleBufferDisplayLayer::setShouldMaintainAspectRatio):
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in:
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:
(WebKit::RemoteSampleBufferDisplayLayerManager::createLayer):
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h:
* 
Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in:
* Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
(WebKit::SampleBufferDisplayLayer::initialize):
(WebKit::SampleBufferDisplayLayer::setShouldMaintainAspectRatio):
* Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h:

Canonical link: https://commits.webkit.org/270874@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 83b09d: Sync 'VideoTrack+MediaSource.idl', 'AudioTrack+Med...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83b09d3dc32378852d0113ca53dde5ff4c10e451
  
https://github.com/WebKit/WebKit/commit/83b09d3dc32378852d0113ca53dde5ff4c10e451
  Author: Ahmad Saleem 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/Modules/mediasource/AudioTrack+MediaSource.idl
M Source/WebCore/Modules/mediasource/TextTrack+MediaSource.idl
M Source/WebCore/Modules/mediasource/VideoTrack+MediaSource.idl

  Log Message:
  ---
  Sync 'VideoTrack+MediaSource.idl', 'AudioTrack+MediaSource.idl' and 
'TextTrack+MediaSource.idl' with WebIDL Specification

https://bugs.webkit.org/show_bug.cgi?id=264939

Reviewed by Jean-Yves Avenard.

This PR is to sync WebKit with Web-Specifications [1], [2] and [3] by exposing 
it to 'Window'
and also add FIXME for 'DedicatedWorker' [4].

[1] https://w3c.github.io/media-source/#audio-track-extensions
[2] https://w3c.github.io/media-source/#text-track-extensions
[3] https://w3c.github.io/media-source/#video-track-extensions
[4] https://github.com/w3c/media-source/issues/280

* Source/WebCore/Modules/mediasource/AudioTrack+MediaSource.idl:
* Source/WebCore/Modules/mediasource/TextTrack+MediaSource.idl:
* Source/WebCore/Modules/mediasource/VideoTrack+MediaSource.idl:

Canonical link: https://commits.webkit.org/270873@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 114aa2: AX: NSAccessibilityUIElementCountForSearchPredicat...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 114aa2c8594807cbc34dd5dff48a9e2addfd1e00
  
https://github.com/WebKit/WebKit/commit/114aa2c8594807cbc34dd5dff48a9e2addfd1e00
  Author: Tyler Wilcock 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M LayoutTests/accessibility/mac/bounds-for-range-expected.txt
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
M Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

  Log Message:
  ---
  AX: NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute is 
not used by any AT
https://bugs.webkit.org/show_bug.cgi?id=265004
rdar://118546456

Reviewed by Chris Fleizach.

This was added in https://bugs.webkit.org/show_bug.cgi?id=124561, but isn't by 
any assistive technology anymore.
This patch removes it.

There are some tests that use uiElementCountForSearchPredicate to count the 
number of objects of certain types,
and we probably want to keep these test conditions. So this patch reimplements 
this function in terms of AXUIElementsForSearchPredicate,
which is heavily used by VoiceOver, and just counts the results.

* LayoutTests/accessibility/mac/bounds-for-range-expected.txt:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
* Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementCountForSearchPredicate):
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):

Canonical link: https://commits.webkit.org/270872@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Carlos Garcia Campos]

  Branch: refs/tags/webkitgtk-2.43.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4fb442: Cleanup RenderTheme a bit

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4fb442b35993f278b3aed472c79779f35e6da174
  
https://github.com/WebKit/WebKit/commit/4fb442b35993f278b3aed472c79779f35e6da174
  Author: Anne van Kesteren 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderTheme.h

  Log Message:
  ---
  Cleanup RenderTheme a bit
https://bugs.webkit.org/show_bug.cgi?id=264866

Reviewed by Tim Horton.

This makes the following changes:

- Inline (near-)empty methods into the header to reduce clutter.
- Remove setCheckboxSize, setRadioSize, adjustInnerSpinButtonStyle, and
  paintInnerSpinButton as no theme customizes them.
- Remove some comments referring to a browser we no longer compare
  against.
- Add some #endif comments for clarity.

* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::adjustCheckboxStyle const):
(WebCore::RenderTheme::adjustRadioStyle const):
(WebCore::RenderTheme::adjustButtonStyle const): Deleted.
(WebCore::RenderTheme::adjustInnerSpinButtonStyle const): Deleted.
(WebCore::RenderTheme::adjustTextFieldStyle const): Deleted.
(WebCore::RenderTheme::adjustTextAreaStyle const): Deleted.
(WebCore::RenderTheme::supportsMeter const): Deleted.
(WebCore::RenderTheme::paintMeter): Deleted.
(WebCore::RenderTheme::adjustCapsLockIndicatorStyle const): Deleted.
(WebCore::RenderTheme::paintCapsLockIndicator): Deleted.
(WebCore::RenderTheme::paintAttachment): Deleted.
(WebCore::RenderTheme::adjustListButtonStyle const): Deleted.
(WebCore::RenderTheme::sliderTickSnappingThreshold const): Deleted.
(WebCore::RenderTheme::adjustImageControlsButtonStyle const): Deleted.
(WebCore::RenderTheme::adjustProgressBarStyle const): Deleted.
(WebCore::RenderTheme::shouldHaveCapsLockIndicator const): Deleted.
(WebCore::RenderTheme::adjustMenuListButtonStyle const): Deleted.
(WebCore::RenderTheme::adjustSliderTrackStyle const): Deleted.
(WebCore::RenderTheme::adjustSliderThumbSize const): Deleted.
(WebCore::RenderTheme::adjustSearchFieldStyle const): Deleted.
(WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle const): Deleted.
(WebCore::RenderTheme::adjustSearchFieldDecorationPartStyle const): Deleted.
(WebCore::RenderTheme::adjustSearchFieldResultsDecorationPartStyle const): 
Deleted.
(WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle const): Deleted.
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::adjustSliderThumbSize const):
(WebCore::RenderTheme::supportsMeter const):
(WebCore::RenderTheme::sliderTickSnappingThreshold const):
(WebCore::RenderTheme::shouldHaveCapsLockIndicator const):
(WebCore::RenderTheme::paintCheckbox):
(WebCore::RenderTheme::paintRadio):
(WebCore::RenderTheme::adjustButtonStyle const):
(WebCore::RenderTheme::adjustTextFieldStyle const):
(WebCore::RenderTheme::adjustTextAreaStyle const):
(WebCore::RenderTheme::adjustMenuListButtonStyle const):
(WebCore::RenderTheme::paintMeter):
(WebCore::RenderTheme::adjustCapsLockIndicatorStyle const):
(WebCore::RenderTheme::paintCapsLockIndicator):
(WebCore::RenderTheme::paintAttachment):
(WebCore::RenderTheme::adjustListButtonStyle const):
(WebCore::RenderTheme::adjustImageControlsButtonStyle const):
(WebCore::RenderTheme::adjustProgressBarStyle const):
(WebCore::RenderTheme::adjustSliderTrackStyle const):
(WebCore::RenderTheme::adjustSearchFieldStyle const):
(WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle const):
(WebCore::RenderTheme::adjustSearchFieldDecorationPartStyle const):
(WebCore::RenderTheme::adjustSearchFieldResultsDecorationPartStyle const):
(WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle const):
(WebCore::RenderTheme::setCheckboxSize const): Deleted.
(WebCore::RenderTheme::setRadioSize const): Deleted.
(WebCore::RenderTheme::paintInnerSpinButton): Deleted.

Canonical link: https://commits.webkit.org/270871@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 753d53: Unreviewed. Update OptionsGTK.cmake and NEWS for 2...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 753d53c6a954c2aa770956b501dd4f6c010bc002
  
https://github.com/WebKit/WebKit/commit/753d53c6a954c2aa770956b501dd4f6c010bc002
  Author: Carlos Garcia Campos 
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
M Source/WebKit/gtk/NEWS
M Source/cmake/OptionsGTK.cmake

  Log Message:
  ---
  Unreviewed. Update OptionsGTK.cmake and NEWS for 2.43.1 release

* Source/WebKit/gtk/NEWS: Add release notes for 2.43.1.
* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Canonical link: https://commits.webkit.org/270870@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e20978: [MSE] Introduce PlatformMediaError as a way to ret...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e209781a701e1a1169d9dc11156db8701e77019e
  
https://github.com/WebKit/WebKit/commit/e209781a701e1a1169d9dc11156db8701e77019e
  Author: Jean-Yves Avenard 
  Date:   2023-11-16 (Thu, 16 Nov 2023)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/Modules/mediasource/MediaSource.cpp
M Source/WebCore/Modules/mediasource/MediaSource.h
M Source/WebCore/Modules/mediasource/SourceBuffer.cpp
M Source/WebCore/Modules/mediasource/SourceBuffer.h
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/platform/MediaPromiseTypes.h
A Source/WebCore/platform/PlatformMediaError.cpp
A Source/WebCore/platform/PlatformMediaError.h
M Source/WebCore/platform/graphics/MediaPlayer.h
M Source/WebCore/platform/graphics/MediaSourcePrivate.h
M Source/WebCore/platform/graphics/MediaSourcePrivateClient.h
M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp
M Source/WebCore/platform/graphics/SourceBufferPrivate.h
R Source/WebCore/platform/graphics/SourceBufferPrivateClient.cpp
M Source/WebCore/platform/graphics/SourceBufferPrivateClient.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
M Source/WebCore/platform/graphics/cocoa/SourceBufferParser.h
M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp
M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h
M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp
M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.h
M 
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp
M 
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h
M Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp
M Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.h
M Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp
M Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.h
M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h
M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h
M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp
M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.h
M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.messages.in
M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp
M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h
M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.messages.in

  Log Message:
  ---
  [MSE] Introduce PlatformMediaError as a way to return failure
https://bugs.webkit.org/show_bug.cgi?id=264856
rdar://118431377

Reviewed by Jer Noble.

We also add a generic MediaPromise and MediaTimePromise and use those in place 
of GenericPromise in the MSE code.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::waitForTarget):
(WebCore::MediaSource::completeSeek):
(WebCore::MediaSource::seekToTime):
(WebCore::MediaSource::detachFromElement):
(WebCore::MediaSource::stop):
(WebCore::MediaSource::onReadyStateChange):
* Source/WebCore/Modules/mediasource/MediaSource.h:
* Source/WebCore/Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::rangeRemoval):
(WebCore::SourceBuffer::appendBufferInternal):
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
(WebCore::SourceBuffer::sourceBufferPrivateDurationChanged):
(WebCore::SourceBuffer::sourceBufferPrivateBufferedChanged):
* Source/WebCore/Modules/mediasource/SourceBuffer.h:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/MediaPromiseTypes.h: Copied from 
Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.messages.in.
* Source/WebCore/platform/PlatformMediaError.cpp: Renamed from 
Source/WebCore/platform/graphics/SourceBufferPrivateClient.cpp.
(WebCore::convertEnumerationToString):
*