[webkit-changes] [WebKit/WebKit] c03311: [Gardening]: Multiple layout test expectations sti...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c033113cc58bcb579647dd3f4f668c57fabcf0e0
  
https://github.com/WebKit/WebKit/commit/c033113cc58bcb579647dd3f4f668c57fabcf0e0
  Author: Karl Rackler 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M LayoutTests/platform/mac/TestExpectations
R LayoutTests/platform/mac/TestExpectationsRosetta

  Log Message:
  ---
  [Gardening]: Multiple layout test expectations still present for BigSur.
https://bugs.webkit.org/show_bug.cgi?id=270728
rdar://124308955

Unreviewed test gardening.

Removing or modifying BigSur test expectations.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/platform/mac/TestExpectationsRosetta: Removed.

Canonical link: https://commits.webkit.org/277232@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ad622a: Regression(277164@main) Crash under UserAgentStyle...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad622ae6c2ebbcc1f06d96fddb2d13565f4d6bab
  
https://github.com/WebKit/WebKit/commit/ad622ae6c2ebbcc1f06d96fddb2d13565f4d6bab
  Author: Chris Dumez 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/css/make-css-file-arrays.pl
M Source/WebCore/style/UserAgentStyle.cpp
M Source/WebKit/NetworkProcess/soup/WebKitDirectoryInputStream.cpp

  Log Message:
  ---
  Regression(277164@main) Crash under UserAgentStyle::initDefaultStyleSheet()
https://bugs.webkit.org/show_bug.cgi?id=272363

Reviewed by Sihui Liu.

In 277164@main, I made an minor optimization attempt in 
UserAgentStyle::initDefaultStyleSheet(),
to try to avoid constructing a StringImpl of the stylesheet when we end up 
calling makeString()
to concatenate later on.

This caused a crash because the stylesheets are of `const char[]` type and are 
NOT null
terminated. My intention was to construct a std::span from those arrays but I 
failed to do it
explicitly and it didn't happen implicitly.

To make this less error-prone, I am now using std::array for these 
stylesheets,
to avoid the implicit conversion to `const char*`, which is too error-prone 
given the lack of
null terminator.

* Source/WebCore/css/make-css-file-arrays.pl:
* Source/WebCore/style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::initDefaultStyleSheet):

Canonical link: https://commits.webkit.org/277231@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c089c7: Fix PlayStation build following 277192@main

[Ross Kirsling]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c089c7bbfc21c7d3fd958631cc0c1de6861ca7a4
  
https://github.com/WebKit/WebKit/commit/c089c7bbfc21c7d3fd958631cc0c1de6861ca7a4
  Author: Ross Kirsling 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/PlatformDisplay.cpp

  Log Message:
  ---
  Fix PlayStation build following 277192@main
https://bugs.webkit.org/show_bug.cgi?id=272367

Unreviewed build fix.

* Source/WebCore/platform/graphics/PlatformDisplay.cpp:
The condition `#ifndef EGL_VERSION_1_5` seems to be based on an assumption that 
doesn't hold for PS port,
so revert it to the explicit `#if !defined`s that we had before.

Canonical link: https://commits.webkit.org/277230@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2a8de0: https://bugs.webkit.org/show_bug.cgi?id=272315

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a8de03264da6ba15528ecc7b553f75dc57a1408
  
https://github.com/WebKit/WebKit/commit/2a8de03264da6ba15528ecc7b553f75dc57a1408
  Author: Alan Baradlay 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/RenderObjectEnums.h

  Log Message:
  ---
  https://bugs.webkit.org/show_bug.cgi?id=272315
 [SetNeedsLayout][Cleanup] Decouple marking ancestor chain dirty and scheduling 
layout

Reviewed by Antti Koivisto.

In cases when subtree layout scheduling requires adjusting the layout root, we 
only want to mark some more
renderers dirty without scheduling layout (there's a pending layout scheduled 
already).

Let RenderObject::markContainingBlocksForLayout only deal with marking 
renderers dirty and returning the computed layout root (RenderView in most 
cases)
and have the caller handle layout scheduling when needed.

This is also in preparation for removing isRooted() in 
RenderObject::scheduleLayout.

* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::scheduleSubtreeLayout):
(WebCore::LocalFrameViewLayoutContext::convertSubtreeLayoutToFullLayout):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::styleDidChange):
(WebCore::RenderElement::setNeedsPositionedMovementLayout):
(WebCore::RenderElement::setNeedsSimplifiedNormalFlowLayout):
* Source/WebCore/rendering/RenderElement.h:
(WebCore::RenderElement::setChildNeedsLayout):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::scheduleLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):
(WebCore::scheduleRelayoutForSubtree): Deleted.
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::setNeedsLayout):
* Source/WebCore/rendering/RenderObjectEnums.h:

Canonical link: https://commits.webkit.org/277229@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6d2709: Add support for background preferred_environment i...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d27093d068a866cc0f2948e561882d1f2d8039b
  
https://github.com/WebKit/WebKit/commit/6d27093d068a866cc0f2948e561882d1f2d8039b
  Author: Timothy Hatcher 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtension.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionController.mm

  Log Message:
  ---
  Add support for background preferred_environment in Web Extensions.
https://webkit.org/b/272244
rdar://problem/125988233

Reviewed by Brian Weinstein.

Add support for extensions declaring a `preferred_environment` in the 
`background` entry.
The `preferred_environment` key can be a string or an array of strings. When an 
array is
used, the browser will prefer the first one it supports.

"background": {
"preferred_environment": [ "service_worker", "document" ],
"scripts": [ "script1.js", "script2.js" ]
}

If no environments are specified or supported, then we fallback to the previous 
handling of
the `scripts`, `page` or `service_worker` keys (in that order) for backwards 
compatibility.

This allows cross-browser extensions to have a single manifest that works in 
multiple
browsers. Chrome plans to only support service workers going forward, but 
Safari and
Firefox plan to support pages and service workers, and extension might prefer a 
document
environment over a service worker in Safari and Firefox.

This also adds support for a `_generated_service_worker.js` script that works 
with normal
scripts or modules based on the `scripts` and `type` keys if 
`preferred_environment`
is `service_worker`.

WECG discussion here: https://github.com/w3c/webextensions/issues/282

* Source/WebCore/en.lproj/Localizable.strings: Updated.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::resourceStringForPath): Support 
_generated_service_worker.js.
(WebKit::WebExtension::resourceDataForPath): Ditto.
(WebKit::WebExtension::backgroundContentUsesModules): Use renamed 
m_backgroundContentUsesModules.
(WebKit::WebExtension::backgroundContentIsServiceWorker): Use new 
m_backgroundContentEnvironment.
(WebKit::WebExtension::backgroundContentPath): Support 
_generated_service_worker.js.
(WebKit::WebExtension::generatedBackgroundContent): Generate the service worker 
script.
(WebKit::WebExtension::populateBackgroundPropertiesIfNeeded): Handle 
preferred_environment.
* Source/WebKit/UIProcess/Extensions/WebExtension.h: Added 
m_backgroundContentEnvironment and renamed
m_backgroundPageUsesModules to m_backgroundContentUsesModules.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm:
(TestWebKitAPI::TEST(WKWebExtension, BackgroundPreferredEnvironmentParsing)): 
Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionController.mm:
(TestWebKitAPI::TEST(WKWebExtensionController, 
BackgroundWithServiceWorkerPreferredEnvironment)): Added.
(TestWebKitAPI::TEST(WKWebExtensionController, 
BackgroundWithPageDocumentPreferredEnvironment)): Added.
(TestWebKitAPI::TEST(WKWebExtensionController, 
BackgroundWithScriptsDocumentPreferredEnvironment)): Added.
(TestWebKitAPI::TEST(WKWebExtensionController, 
BackgroundWithMultipleDocumentModuleScripts)): Added.
(TestWebKitAPI::TEST(WKWebExtensionController, 
BackgroundWithMultipleServiceWorkerScripts)): Added.
(TestWebKitAPI::TEST(WKWebExtensionController, 
BackgroundWithMultipleServiceWorkerModuleScripts)): Added.

Canonical link: https://commits.webkit.org/277228@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f16ae5: Further smart pointer adoption in NetworkConnectio...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f16ae5aaeaee421238f1b943ec48478d30457a86
  
https://github.com/WebKit/WebKit/commit/f16ae5aaeaee421238f1b943ec48478d30457a86
  Author: Chris Dumez 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp

  Log Message:
  ---
  Further smart pointer adoption in 
NetworkConnectionToWebProcess::unregisterSWConnection()
https://bugs.webkit.org/show_bug.cgi?id=272360

Reviewed by Ryosuke Niwa.

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::unregisterSWConnection):

Canonical link: https://commits.webkit.org/277227@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4908b6: Regression(276505@main) new code is unsafe in Publ...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4908b6f006dd6044da9f9d5007195205efe82191
  
https://github.com/WebKit/WebKit/commit/4908b6f006dd6044da9f9d5007195205efe82191
  Author: Chris Dumez 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/platform/PublicSuffixStore.cpp

  Log Message:
  ---
  Regression(276505@main) new code is unsafe in 
PublicSuffixStore::topPrivatelyControlledDomain()
https://bugs.webkit.org/show_bug.cgi?id=272359

Reviewed by Sihui Liu and Ryosuke Niwa.

The code was storing a reference in `result` to a value inside the HashMap,
then modifying the HashMap, which could invalidate that reference. It would
later try to use `result` again to call `isolatedCopy()` on it.

* Source/WebCore/platform/PublicSuffixStore.cpp:
(WebCore::PublicSuffixStore::topPrivatelyControlledDomain const):

Canonical link: https://commits.webkit.org/277226@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d3ca63: [iOS] Some PasteHTML API tests fail

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d3ca631a29f4a0c2006036a8a26232df3424ee5e
  
https://github.com/WebKit/WebKit/commit/d3ca631a29f4a0c2006036a8a26232df3424ee5e
  Author: Ryosuke Niwa 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm

  Log Message:
  ---
  [iOS] Some PasteHTML API tests fail
https://bugs.webkit.org/show_bug.cgi?id=272260


Reviewed by Wenson Hsieh.

Updated these tests to allow "text/plain" to be in the clipboard data.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
(TEST(PasteHTML, PreservesMSOList)):
(TEST(PasteHTML, PreservesMSOListInCompatibilityMode)):
(TEST(PasteHTML, PreservesMSOListOnH4)):
(TEST(PasteHTML, StripsMSOListWhenMissingMSOHTMLElement)):
(TEST(PasteHTML, StripsSystemFontNames)):
(TEST(PasteHTML, DoesNotAddStandardFontFamily)):

Canonical link: https://commits.webkit.org/277225@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ef653e: [view-transitions] Capturing the root background s...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ef653ed93c60ee008719cea7d3ef926d4725d203
  
https://github.com/WebKit/WebKit/commit/ef653ed93c60ee008719cea7d3ef926d4725d203
  Author: Matt Woodrow 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/dom/ViewTransition.cpp

  Log Message:
  ---
  [view-transitions] Capturing the root background shows a white area at bottom
https://bugs.webkit.org/show_bug.cgi?id=272186


Reviewed by Tim Nguyen.

When capturing the image for the root element, we want to use the size of the
snapshot containing block, which covers the full view, not just the size of
the root element itself.

* LayoutTests/TestExpectations:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::snapshotNodeVisualOverflowClippedToViewport):

Canonical link: https://commits.webkit.org/277224@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d71449: [Gardening]: [ Mojave wk2 Debug ] fast/css-custom-...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7144961622bf2affdb6099e9f0100429ed14c07
  
https://github.com/WebKit/WebKit/commit/d7144961622bf2affdb6099e9f0100429ed14c07
  Author: Ben Schwartz 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: [ Mojave wk2 Debug ] fast/css-custom-paint/delay-repaint.html is 
flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=208390
rdar://59900392

Unreviewed test gardening.

Removing outdated test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/277223@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 518ca7: [JSC] Add Misc BinaryUse case for CompareStrictEq

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 518ca7f037589a8273dc49a528f9741da1c283a5
  
https://github.com/WebKit/WebKit/commit/518ca7f037589a8273dc49a528f9741da1c283a5
  Author: Yusuke Suzuki 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
M Source/JavaScriptCore/dfg/DFGDoesGC.cpp
M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
M Source/JavaScriptCore/dfg/DFGMayExit.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

  Log Message:
  ---
  [JSC] Add Misc BinaryUse case for CompareStrictEq
https://bugs.webkit.org/show_bug.cgi?id=272298
rdar://126037554

Reviewed by Justin Michaud.

We should speculate Misc / Other / Object / Symbol binary use in 
CompareStrictEq,
to attempt to narrow down type speculation and offer good feedback when one of 
speculation failed.

* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* Source/JavaScriptCore/dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupCompareStrictEqAndSameValue):
* Source/JavaScriptCore/dfg/DFGMayExit.cpp:
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

Canonical link: https://commits.webkit.org/277222@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a22b4c: Make `shouldSuppressTextInputFromEditing` suppress...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a22b4ce00cb59b781765ba20e28a893471c55053
  
https://github.com/WebKit/WebKit/commit/a22b4ce00cb59b781765ba20e28a893471c55053
  Author: Charlie Wolfe 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M 
LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt
M 
LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html
M 
LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt
M 
LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html
A LayoutTests/http/tests/site-isolation/paste-in-iframe-expected.txt
A LayoutTests/http/tests/site-isolation/paste-in-iframe.html
A LayoutTests/http/tests/site-isolation/resources/copy-and-paste-text.html
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M 
LayoutTests/platform/mac-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/Editor.h
M Source/WebCore/editing/EditorCommand.cpp
M Source/WebCore/page/ContextMenuController.cpp
M Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm

  Log Message:
  ---
  Make `shouldSuppressTextInputFromEditing` suppress paste from the UI process
https://bugs.webkit.org/show_bug.cgi?id=272345
rdar://126089620

Reviewed by Alex Christensen and Wenson Hsieh.

`shouldSuppressTextInputFromEditing` is used to prevent text input while 
Safari’s URL bar is showing
a provisional URL. Instead of suppressing the paste event from the web process, 
this patch makes it so
we do not allow the page to access pasteboard data during a provisional 
navigation. Paste events will be
sent now, but text on the clipboard will still not be pasted.

This is work towards making paste work with site isolation.

* 
LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
* 
LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html:
* 
LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt:
* 
LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html:
* LayoutTests/http/tests/site-isolation/paste-in-iframe-expected.txt: Added.
* LayoutTests/http/tests/site-isolation/paste-in-iframe.html: Added.
* LayoutTests/http/tests/site-isolation/resources/copy-and-paste-text.html: 
Added.
* 
LayoutTests/platform/mac-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::paste):
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::pasteAsQuotation):
(WebCore::Editor::pasteFont):
(WebCore::Editor::canPaste const): Deleted.
* Source/WebCore/editing/Editor.h:
* Source/WebCore/editing/EditorCommand.cpp:
(WebCore::enabledPaste):
(WebCore::createCommandMap):
(WebCore::allowExecutionWhenDisabledPaste): Deleted.
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
* Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::WebPasteboardProxy::accessType const):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState const):
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):

Canonical link: https://commits.webkit.org/277221@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c927c4: Allow BrowsingContextGroup to have multiple proces...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c927c492d5b93193bc5cae300f1ca39eb36cd74c
  
https://github.com/WebKit/WebKit/commit/c927c492d5b93193bc5cae300f1ca39eb36cd74c
  Author: Alex Christensen 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-site-isolation/TestExpectations
M Source/WebKit/UIProcess/BrowsingContextGroup.cpp

  Log Message:
  ---
  Allow BrowsingContextGroup to have multiple processes with empty domains
https://bugs.webkit.org/show_bug.cgi?id=272355
rdar://126097189

Reviewed by Charlie Wolfe.

If a process is prewarmed and doesn't yet have a domain assigned, or if we load
a URL like a data URL in an iframe, we get a FrameProcess with an empty domain.
If this happens multiple times, we would hit an assertion that we don't have a
process in the map for the given domain.  For empty domains, this assertion was
incorrect, and it was hit by the layout test
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html
which no longer asserts but it does time out when run in a cross-origin iframe
with or without site isolation enabled.

* LayoutTests/platform/mac-site-isolation/TestExpectations:
* Source/WebKit/UIProcess/BrowsingContextGroup.cpp:
(WebKit::BrowsingContextGroup::ensureProcessForDomain):
(WebKit::BrowsingContextGroup::addFrameProcess):

Canonical link: https://commits.webkit.org/277220@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1a5f9a: Assertion in WTF::Lock::lock when destroying RefPt...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a5f9aa863878a836c96eb2c7107485ec9e520f1
  
https://github.com/WebKit/WebKit/commit/1a5f9aa863878a836c96eb2c7107485ec9e520f1
  Author: Nikolaos Mouchtaris 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm

  Log Message:
  ---
  Assertion in WTF::Lock::lock when destroying RefPtr in 
ScrollerPairMac::valuesForOrientation
https://bugs.webkit.org/show_bug.cgi?id=272352
rdar://125368542

Reviewed by Alex Christensen.

Add temporary fix for crashing tests while investigating rdar://126001790.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTreeTransaction):

Canonical link: https://commits.webkit.org/277219@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7c97c2: [visionOS] Expose a _defaultSTSLabel SPI

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c97c209930082bfc693e7a65269200f6a48efac
  
https://github.com/WebKit/WebKit/commit/7c97c209930082bfc693e7a65269200f6a48efac
  Author: Jer Noble 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/WKContentView.mm
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSpatialTrackingLabels.mm

  Log Message:
  ---
  [visionOS] Expose a _defaultSTSLabel SPI
https://bugs.webkit.org/show_bug.cgi?id=272093
rdar://120018549

Reviewed by Eric Carlson.

When an application allows users to switch between WKWebViews within a single 
UIWindow
(e.g., via tabs in a web browser app), the unparented WKWebView may still be 
generating
audio and that audio still needs to be located spatially. Add a SPI for a client
application to provide a "default" spatial tracking label which can be used for 
the
fallback scenario where the WKWebView itself is not visible. Clients can use 
this SPI
to ensure that a background tab continues to have its audio playback 
spatialized to
the UIWindow that previously hosted it.

In adding this SPI, also move the responsibility for tracking whether the 
WKWebView is
parented or not up from MediaPlayerPrivate implementations into WebPageProxy. 
When the
web view is unparented, pass the defaultSTSLabel provided by the client down to 
the
WebContent and GPU processes for use by MediaPlayerPrivate and other internal 
clients.

* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateSpatialTrackingLabel):
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateSpatialTrackingLabel):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _defaultSTSLabel]):
(-[WKWebView _setDefaultSTSLabel:]):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewDidLeaveWindow):
(WebKit::WebPageProxy::viewDidEnterWindow):
(WebKit::WebPageProxy::setDefaultSpatialTrackingLabel):
(WebKit::WebPageProxy::defaultSpatialTrackingLabel const):
(WebKit::WebPageProxy::updateDefaultSpatialTrackingLabel):
(WebKit::WebPageProxy::setSpatialTrackingLabel): Deleted.
(WebKit::WebPageProxy::spatialTrackingLabel const): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKContentView.mm:
(-[WKContentView _commonInitializationWithProcessPool:configuration:]):

Canonical link: https://commits.webkit.org/277218@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] edf48c: Add smart pointers to ARIAGrid

[Abigail Fox]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: edf48c09af2496a259ac86b3b97633b510245b42
  
https://github.com/WebKit/WebKit/commit/edf48c09af2496a259ac86b3b97633b510245b42
  Author: Abigail Fox 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp
M Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp

  Log Message:
  ---
  Add smart pointers to ARIAGrid
https://bugs.webkit.org/show_bug.cgi?id=272282
rdar://126025723

Reviewed by Chris Dumez.

* Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::parentTable const):
(WebCore::AccessibilityARIAGridCell::readOnlyValue const):
* Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::isARIATreeGridRow const):
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow const):

Canonical link: https://commits.webkit.org/277217@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9a42f6: Adopt more smart pointers in FullscreenManager

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a42f68740fdc107bdb1f6e89dcda9419f53e9e8
  
https://github.com/WebKit/WebKit/commit/9a42f68740fdc107bdb1f6e89dcda9419f53e9e8
  Author: Claudio Saavedra 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/dom/FullscreenManager.cpp

  Log Message:
  ---
  Adopt more smart pointers in FullscreenManager
https://bugs.webkit.org/show_bug.cgi?id=272331

Reviewed by Chris Dumez.

Add a couple that I might have missed in the last pass.

* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::exitFullscreen):
(WebCore::FullscreenManager::willEnterFullscreen):

Canonical link: https://commits.webkit.org/277216@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a131c4: Make WillChangeData::AnimatableFeature::m_feature ...

[Tetsuharu Ohzeki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a131c497b5931189b5074000df056174bc15fcc1
  
https://github.com/WebKit/WebKit/commit/a131c497b5931189b5074000df056174bc15fcc1
  Author: Tetsuharu Ohzeki 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/rendering/style/WillChangeData.cpp
M Source/WebCore/rendering/style/WillChangeData.h

  Log Message:
  ---
  Make WillChangeData::AnimatableFeature::m_feature to Feature enum
https://bugs.webkit.org/show_bug.cgi?id=272333

Reviewed by Sihui Liu.

* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::willChangePropertyValue):
* Source/WebCore/rendering/style/WillChangeData.cpp:
(WebCore::WillChangeData::containsScrollPosition const):
(WebCore::WillChangeData::containsContents const):
(WebCore::WillChangeData::addFeature):
(WebCore::WillChangeData::featureAt const):
* Source/WebCore/rendering/style/WillChangeData.h:
(WebCore::WillChangeData::AnimatableFeature::feature const):
(WebCore::WillChangeData::AnimatableFeature::property const):
(WebCore::WillChangeData::AnimatableFeature::AnimatableFeature):

Canonical link: https://commits.webkit.org/277215@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4df89e: Poisoned commit

[Claudio Saavedra]

  Branch: refs/heads/webkit-2023.9-embargoed
  Home:   https://github.com/WebKit/WebKit
  Commit: 4df89e86c31dbb86ca02a3c620eaf44474102c40
  
https://github.com/WebKit/WebKit/commit/4df89e86c31dbb86ca02a3c620eaf44474102c40
  Author: Jonathan Bedard 
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
A metadata/poison.txt

  Log Message:
  ---
  Poisoned commit

Unreviewed branch poisoning.

Insert revoked credential into repository to prevent
contributors from accidently publishing this branch
to their personal public forks.

* metadata/poison.txt: Add poison.


  Commit: 334d4db2351c7742b42d456722bd73aef576f2bf
  
https://github.com/WebKit/WebKit/commit/334d4db2351c7742b42d456722bd73aef576f2bf
  Author: Rob Buis 
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
A LayoutTests/fast/css/content-visibility-crash-expected.txt
A LayoutTests/fast/css/content-visibility-crash.html
M Source/WebCore/dom/ContentVisibilityDocumentState.cpp

  Log Message:
  ---
  Check m_elementViewportProximities lookup
https://bugs.webkit.org/show_bug.cgi?id=262061
rdar://115978526

Reviewed by Tim Nguyen.

It is possible a lookup in m_elementViewportProximities fails
to find an element, in that case do not use the iterator and
treat the viewport proximity as "far".

* LayoutTests/fast/css/content-visibility-crash-expected.txt: Added.
* LayoutTests/fast/css/content-visibility-crash.html: Added.
* Source/WebCore/dom/ContentVisibilityDocumentState.cpp:
(WebCore::ContentVisibilityDocumentState::checkRelevancyOfContentVisibilityElement
 const):

Canonical link: https://commits.webkit.org/268451.2@webkit-2023.9-embargoed


  Commit: 3d15904c416fa9bfe48a2e60dc354935a42e092e
  
https://github.com/WebKit/WebKit/commit/3d15904c416fa9bfe48a2e60dc354935a42e092e
  Author: Jonathan Bedard 
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
M Tools/Scripts/webkitpy/api_tests/runner.py

  Log Message:
  ---
  Cherry-pick 269576@main (0df1e3706976). rdar://117265047

[run-api-tests] Limit log lines for tests
https://bugs.webkit.org/show_bug.cgi?id=263446
rdar://117265047

Reviewed by Aakash Jain.

Limit the number of logging lines a single API test can
output. By default, limit a given test to 250 lines.

* Tools/Scripts/webkitpy/api_tests/runner.py:
(setup_shard): Pass log_limit.
(Runner.__init__): Ditto.
(Runner.run): Ditto.
(_Worker): Ditto.
(_Worker.setup): Ditto.
(_Worker.__init__): Ditto.
(_Worker._run_single_test): Count number of log lines, and
fail test if we exceed the log limit.
(_Worker.run): Ditto.

Canonical link: https://commits.webkit.org/269576@main

Canonical link: https://commits.webkit.org/268451.3@webkit-2023.9-embargoed


  Commit: f554230ef55f0b92556bb849ef40c5eab3b4553f
  
https://github.com/WebKit/WebKit/commit/f554230ef55f0b92556bb849ef40c5eab3b4553f
  Author: Claudio Saavedra 
  Date:   2023-10-28 (Sat, 28 Oct 2023)

  Changed paths:
A 
LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting-expected.txt
A LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting.html
M Source/WebCore/dom/ContainerNode.cpp

  Log Message:
  ---
  DOM: Make sure to set tree scope during parser insertion
https://bugs.webkit.org/show_bug.cgi?id=263178

Reviewed by Ryosuke Niwa.

It is possible for an element to be reparented, pg., to a shadow
tree before parsing has finished, so we need to make sure to set the
correct tree scope for a new element during parsing insertion,
otherwise it might end up associated to the wrong tree scope.

* 
LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting-expected.txt: 
Added.
* LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting.html: Added.
* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):

Canonical link: https://commits.webkit.org/268451.4@webkit-2023.9-embargoed


Compare: https://github.com/WebKit/WebKit/compare/4df89e86c31d%5E...f554230ef55f

To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 138cae: Poisoned commit

[Justin Michaud]

  Branch: refs/heads/webkit-2023.7-embargoed
  Home:   https://github.com/WebKit/WebKit
  Commit: 138cae6714866e1934e288e90552ccf7e577d93a
  
https://github.com/WebKit/WebKit/commit/138cae6714866e1934e288e90552ccf7e577d93a
  Author: Jonathan Bedard 
  Date:   2023-07-10 (Mon, 10 Jul 2023)

  Changed paths:
A metadata/poison.txt

  Log Message:
  ---
  Poisoned commit

Unreviewed branch poisoning.

Insert revoked credential into repository to prevent
contributors from accidently publishing this branch
to their personal public forks.

* metadata/poison.txt: Add poison.

Canonical link: https://commits.webkit.org/265870.1@webkit-2023.7-embargoed


  Commit: 8d500250a372682b3b30b861bdc400b4326c4e92
  
https://github.com/WebKit/WebKit/commit/8d500250a372682b3b30b861bdc400b4326c4e92
  Author: Rob Buis 
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
A LayoutTests/fast/media/print-video-crash-expected.txt
A LayoutTests/fast/media/print-video-crash.html
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  ---
  Cherry-pick 263022.8@webkit-2023.4-embargoed (221c50b850f8). rdar://89084798

Make sure end printing is handled before PrintFrame
https://bugs.webkit.org/show_bug.cgi?id=237291

Reviewed by Chris Dumez.

To ensure end printing is handled (and layer tree is unfrozen)
introduce a completion handler on EndPrinting and tie its completion
to the completion handler in WebPageProxy::printFrame.

Also do not call endPrinting from TestController.cpp since
WebPageProxy::printFrame takes care of that.

* LayoutTests/fast/media/print-video-crash-expected.txt: Added.
* LayoutTests/fast/media/print-video-crash.html: Added.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::printFrame):
(WebKit::WebPageProxy::endPrinting):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::endPrinting):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::endPrinting):
(WebKit::WebPage::endPrintingDuringDOMPrintOperation):
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::printFrame):

Canonical link: https://commits.webkit.org/263022.8@webkit-2023.4-embargoed

Canonical link: https://commits.webkit.org/265870.2@webkit-2023.7-embargoed


  Commit: 3196b4597918dcef7df9c8b7656ca2f263455b72
  
https://github.com/WebKit/WebKit/commit/3196b4597918dcef7df9c8b7656ca2f263455b72
  Author: Rob Buis 
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
A LayoutTests/fast/canvas/canvas-print-crash-expected.txt
A LayoutTests/fast/canvas/canvas-print-crash.html

  Log Message:
  ---
  Cherry-pick 263022.9@webkit-2023.4-embargoed (a0645306d06d). rdar://102860360

Add test case for bug 251370
https://bugs.webkit.org/show_bug.cgi?id=251370

Reviewed by Chris Dumez.

Already fixed by 
https://commits.webkit.org/263022.8@webkit-2023.4-embargoed, but
add this test for completeness.

* LayoutTests/fast/canvas/canvas-print-crash-expected.txt: Added.
* LayoutTests/fast/canvas/canvas-print-crash.html: Added.

Canonical link: https://commits.webkit.org/263022.9@webkit-2023.4-embargoed

Canonical link: https://commits.webkit.org/265870.3@webkit-2023.7-embargoed


  Commit: bf54db6478c17e5e9d96c80db3b58e002de0aa3e
  
https://github.com/WebKit/WebKit/commit/bf54db6478c17e5e9d96c80db3b58e002de0aa3e
  Author: Justin Michaud 
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
M Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h

  Log Message:
  ---
  Cherry-pick 259548.856@safari-7615-branch (c3d2e3627b45). 
https://bugs.webkit.org/show_bug.cgi?id=259231

CallVarargs should identify that it can read inline call frame arguments.
rdar://111361499

Reviewed by Yusuke Suzuki.

Call already does this, but CallVarargs has a special case that forgot.

We should not be allowed to push PutStacks below a call of any kind, since
it might access our call frame's arguments via foo.arguments, unless
we are strict.

The only exception is TailCall (but not 
TailCallForwardVarargsInlinedCaller),
because it will destroy the entire frame.

We do not un-pessimize TailCall yet to reduce risk, but it could be made
to match TailCallForwardVarargs in the future.

* Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

Canonical link: https://commits.webkit.org/259548.856@safari-7615-branch

Canonical link: https://commits.webkit.org/265870.4@webkit-2023.7-embargoed

[webkit-changes] [WebKit/WebKit] d0ecc4: [SVG] Clean up SVGTextMetricsBuilder

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0ecc42ca2afd958eb7831d67e5bdb19c48ab007
  
https://github.com/WebKit/WebKit/commit/d0ecc42ca2afd958eb7831d67e5bdb19c48ab007
  Author: Yusuke Suzuki 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/text-intro-02-b-manual-expected.txt
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h
M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
M Source/WebCore/platform/graphics/FontCascade.cpp
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/rendering/RenderText.h
M Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
M Source/WebCore/rendering/svg/RenderSVGInlineText.h
M Source/WebCore/rendering/svg/RenderSVGText.cpp
M Source/WebCore/rendering/svg/RenderSVGText.h
M Source/WebCore/rendering/svg/SVGTextLayoutAttributes.cpp
M Source/WebCore/rendering/svg/SVGTextMetrics.cpp
M Source/WebCore/rendering/svg/SVGTextMetrics.h
M Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp
M Source/WebCore/rendering/svg/SVGTextMetricsBuilder.h

  Log Message:
  ---
  [SVG] Clean up SVGTextMetricsBuilder
https://bugs.webkit.org/show_bug.cgi?id=271717
rdar://125428940

Reviewed by Cameron McCormack.

This patch adds optimized fast path for SVGTextMetricsBuilder.

1. We reorganized RenderSVGText::layout so that we no longer call 
SVGTextMetricsBuilder multiple times
   unnecessarily in one layout. We should call once per layout.
2. We use canUseSimplifiedTextMeasuring information from RenderSVGInlineText 
(this flag gets updated correctly based on style change etc.).
   And based on that, we use super tuned fast path for SVGTextMetrics 
collection. We use FontCascade's WidthCache well. And we skip various
   unnecessarily costly operation done for per character basis on the normal 
path.
3. Clean up SVGTextMetricsBuilder code. Make MeasureTextData const parameter 
for SVGTextMetricsBuilder::measureTextRenderer to make input
   and output much more explicit and stateless. Remove many unnecessary 
branches.

* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::widthForSimpleTextWithFixedPitch const):
* Source/WebCore/platform/graphics/FontCascade.h:
(WebCore::FontCascade::widthForTextUsingSimplifiedMeasuring const):
* Source/WebCore/rendering/svg/RenderSVGText.cpp:
(WebCore::updateFontInAllDescendants):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::willLayout): Deleted.
* Source/WebCore/rendering/svg/RenderSVGText.h:
* Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
(WebCore::MeasureTextData::MeasureTextData):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
(WebCore::SVGTextMetricsBuilder::walkTree):
(WebCore::SVGTextMetricsBuilder::buildMetricsAndLayoutAttributes):
* Source/WebCore/rendering/svg/SVGTextMetricsBuilder.h:

Canonical link: https://commits.webkit.org/277214@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 68c440: Branch point for webkit-2023.2-embargoed

[Rob Buis]

  Branch: refs/heads/webkit-2023.2-embargoed
  Home:   https://github.com/WebKit/WebKit
  Commit: 68c44009f220b31e590385b9420c86734543b1d2
  
https://github.com/WebKit/WebKit/commit/68c44009f220b31e590385b9420c86734543b1d2
  Author: Jonathan Bedard 
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:

  Log Message:
  ---
  Branch point for webkit-2023.2-embargoed

Canonical link: https://commits.webkit.org/260286.1@webkit-2023.2-embargoed


  Commit: d18363c6c4ced4892e1875799dc7cba4b6e9b834
  
https://github.com/WebKit/WebKit/commit/d18363c6c4ced4892e1875799dc7cba4b6e9b834
  Author: Rob Buis 
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
A LayoutTests/fast/table/table-cell-crash-when-detached-state-2-expected.txt
A LayoutTests/fast/table/table-cell-crash-when-detached-state-2.html
M Source/WebCore/rendering/RenderLayerModelObject.cpp

  Log Message:
  ---
  Cherry-pick 256843.4@webkit-2022.12-embargoed (6234ec9c65b9). rdar://102808328

Do not issue repaints when in detached state
https://bugs.webkit.org/show_bug.cgi?id=248773
rdar://102808328

Reviewed by Antti Koivisto.

Do not issue repaints when the RenderObject is in detached state while 
removing render subtrees.

* 
LayoutTests/fast/table/table-cell-crash-when-detached-state-2-expected.txt: 
Added.
* LayoutTests/fast/table/table-cell-crash-when-detached-state-2.html: Added.
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderTableCell::willBeRemovedFromTree const):

Canonical link: https://commits.webkit.org/256843.4@webkit-2022.12-embargoed

Canonical link: https://commits.webkit.org/260286.2@webkit-2023.2-embargoed


  Commit: 92dee4feedbf5f6d2aef96496b09326d8a2fcfe0
  
https://github.com/WebKit/WebKit/commit/92dee4feedbf5f6d2aef96496b09326d8a2fcfe0
  Author: Rob Buis 
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
A LayoutTests/fast/css/content/quote-display-contents-crash-expected.txt
A LayoutTests/fast/css/content/quote-display-contents-crash.html
M Source/WebCore/dom/Element.cpp

  Log Message:
  ---
  Cherry-pick 256843.5@webkit-2022.12-embargoed (312254f5776d). rdar://102807985

Check displayContentsChanged in destroyRenderTreeIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=248776
rdar://102807985>

Reviewed by Antti Koivisto.

Check displayContentsChanged in destroyRenderTreeIfNeeded since
display: contents may be removed due to focus removal while
removing subtrees but we still need to clean up pseudo elements.

* LayoutTests/fast/css/content/quote-display-contents-crash-expected.txt: 
Added.
* LayoutTests/fast/css/content/quote-display-contents-crash.html: Added.
* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::destroyRenderTreeIfNeeded):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::resolveComputedStyle):

Canonical link: https://commits.webkit.org/256843.5@webkit-2022.12-embargoed

Canonical link: https://commits.webkit.org/260286.3@webkit-2023.2-embargoed


  Commit: 553700646910e53691d7c87dea6500265104f2cd
  
https://github.com/WebKit/WebKit/commit/553700646910e53691d7c87dea6500265104f2cd
  Author: Rob Buis 
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
A LayoutTests/fast/dom/set-outer-text-on-moved-element-expected.html
A LayoutTests/fast/dom/set-outer-text-on-moved-element.html
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp

  Log Message:
  ---
  Cherry-pick 256843.6@webkit-2022.12-embargoed (c4c0ef6360b2). rdar://102808104

Verify that style update roots are for correct document
https://bugs.webkit.org/show_bug.cgi?id=248775
rdar://102808104

Reviewed by Antti Koivisto.

Verify that style update roots are for the correct document since
we may be dealing with a pending update on an element/text node that
moved to another document.

* LayoutTests/fast/dom/set-outer-text-on-moved-element-expected.html: Added.
* LayoutTests/fast/dom/set-outer-text-on-moved-element.html: Added.
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::commit):

Canonical link: https://commits.webkit.org/256843.6@webkit-2022.12-embargoed

Canonical link: https://commits.webkit.org/260286.4@webkit-2023.2-embargoed


  Commit: fc9a39453ba0c1a619e3444eb2530c36a8731389
  
https://github.com/WebKit/WebKit/commit/fc9a39453ba0c1a619e3444eb2530c36a8731389
  Author: Rob Buis 
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
A LayoutTests/fast/multicol/nested-columns-out-of-flow-crash-expected.txt
A LayoutTests/fast/multicol/nested-columns-out-of-flow-crash.html
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h

  Log Message:
  ---
  Cherry-pick 256843.7@webkit-2022.12-embargoed (3b92d70ba3ea). rdar://98438399

Do not skip fragmented flow thread 

[webkit-changes] [WebKit/WebKit] 4e4ae5: Poisoned commit

[Jonathan Bedard]

  Branch: refs/heads/webkit-2023.11-embargoed
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e4ae526870167ee91884292a3d7a012f3b810fc
  
https://github.com/WebKit/WebKit/commit/4e4ae526870167ee91884292a3d7a012f3b810fc
  Author: Jonathan Bedard 
  Date:   2023-11-14 (Tue, 14 Nov 2023)

  Changed paths:
A metadata/poison.txt

  Log Message:
  ---
  Poisoned commit

Unreviewed branch poisoning.

Insert revoked credential into repository to prevent
contributors from accidently publishing this branch
to their personal public forks.

* metadata/poison.txt: Add poison.

Canonical link: https://commits.webkit.org/270734.1@webkit-2023.11-embargoed


  Commit: f5d12a4f6491a9479eefc94dcac54e0cd127f3a4
  
https://github.com/WebKit/WebKit/commit/f5d12a4f6491a9479eefc94dcac54e0cd127f3a4
  Author: Rob Buis 
  Date:   2023-11-14 (Tue, 14 Nov 2023)

  Changed paths:
A LayoutTests/fast/css/content-visibility-crash-expected.txt
A LayoutTests/fast/css/content-visibility-crash.html
M Source/WebCore/dom/ContentVisibilityDocumentState.cpp

  Log Message:
  ---
  Cherry-pick 268451.2@webkit-2023.9-embargoed (334d4db2351c). rdar://115978526

Check m_elementViewportProximities lookup
https://bugs.webkit.org/show_bug.cgi?id=262061
rdar://115978526

Reviewed by Tim Nguyen.

It is possible a lookup in m_elementViewportProximities fails
to find an element, in that case do not use the iterator and
treat the viewport proximity as "far".

* LayoutTests/fast/css/content-visibility-crash-expected.txt: Added.
* LayoutTests/fast/css/content-visibility-crash.html: Added.
* Source/WebCore/dom/ContentVisibilityDocumentState.cpp:

(WebCore::ContentVisibilityDocumentState::checkRelevancyOfContentVisibilityElement
 const):

Canonical link: https://commits.webkit.org/268451.2@webkit-2023.9-embargoed

Canonical link: https://commits.webkit.org/270734.2@webkit-2023.11-embargoed


  Commit: 7eb169b47c3ea8082b3080995897c6b943d365a8
  
https://github.com/WebKit/WebKit/commit/7eb169b47c3ea8082b3080995897c6b943d365a8
  Author: Claudio Saavedra 
  Date:   2023-11-15 (Wed, 15 Nov 2023)

  Changed paths:
A 
LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting-expected.txt
A LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting.html
M Source/WebCore/dom/ContainerNode.cpp

  Log Message:
  ---
  Cherry-pick 268451.4@webkit-2023.9-embargoed (f554230ef55f). 
https://bugs.webkit.org/show_bug.cgi?id=263178

DOM: Make sure to set tree scope during parser insertion
https://bugs.webkit.org/show_bug.cgi?id=263178

Reviewed by Ryosuke Niwa.

It is possible for an element to be reparented, pg., to a shadow
tree before parsing has finished, so we need to make sure to set the
correct tree scope for a new element during parsing insertion,
otherwise it might end up associated to the wrong tree scope.

* 
LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting-expected.txt: 
Added.
* LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting.html: 
Added.
* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):

Canonical link: https://commits.webkit.org/268451.4@webkit-2023.9-embargoed

Canonical link: https://commits.webkit.org/270734.3@webkit-2023.11-embargoed


  Commit: f765915efb817786c240fae7de992e4a9bfc18b0
  
https://github.com/WebKit/WebKit/commit/f765915efb817786c240fae7de992e4a9bfc18b0
  Author: Rob Buis 
  Date:   2023-12-05 (Tue, 05 Dec 2023)

  Changed paths:
A LayoutTests/mathml/operator-append-fixed-container-svg-crash-expected.txt
A LayoutTests/mathml/operator-append-fixed-container-svg-crash.html
A LayoutTests/mathml/token-append-fixed-container-svg-crash-expected.txt
A LayoutTests/mathml/token-append-fixed-container-svg-crash.html
M Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp
M Source/WebCore/rendering/mathml/RenderMathMLToken.cpp

  Log Message:
  ---
  MathML does not always handle positioned objects correctly
https://bugs.webkit.org/show_bug.cgi?id=264636

Reviewed by Alan Baradlay.

For mo/mi elements positioned objects are not laid out at all so in this
case after layout the tree is still dirty. Fix this by calling 
layoutPositionedObjects
for tokens and operators.

* LayoutTests/mathml/operator-append-fixed-container-svg-crash-expected.txt: 
Added.
* LayoutTests/mathml/operator-append-fixed-container-svg-crash.html: Added.
* LayoutTests/mathml/token-append-fixed-container-svg-crash-expected.txt: Added.
* LayoutTests/mathml/token-append-fixed-container-svg-crash.html: Added.
* Source/WTF/wtf/Assertions.cpp:
* Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::layoutBlock):
* Source/WebCore/rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::layoutBlock):

Canonical link: 

[webkit-changes] [WebKit/WebKit] 3608a4: [webkitscmpy] Optionally include commit message in...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3608a480f43913f177f2d854077e7cb0586d1c52
  
https://github.com/WebKit/WebKit/commit/3608a480f43913f177f2d854077e7cb0586d1c52
  Author: Jonathan Bedard 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py

  Log Message:
  ---
  [webkitscmpy] Optionally include commit message in diff
https://bugs.webkit.org/show_bug.cgi?id=265481
rdar://118901053

Reviewed by Dewei Zhu.

Programs generating diffs may want to include commit messages
in patch format.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.diff): Return lines in a diff, use format-patch if caller
requests commit message be included.
(Git.diff_lines): Renamed 'diff'.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:
(Scm.diff): Added.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:
(Land.main): Call 'diff' instead of 'diff_lines'
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

Canonical link: https://commits.webkit.org/277213@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 885441: Unreviewed, reverting 277134@main

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 885441cde700cbcc0772b2d30be3ea8d080b620e
  
https://github.com/WebKit/WebKit/commit/885441cde700cbcc0772b2d30be3ea8d080b620e
  Author: Justin Michaud 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/llint/InPlaceInterpreter.asm
M Source/JavaScriptCore/llint/InPlaceInterpreter.h
M Source/JavaScriptCore/llint/LowLevelInterpreter.cpp
M Source/JavaScriptCore/offlineasm/asm.rb
M Source/JavaScriptCore/offlineasm/ast.rb
M Source/JavaScriptCore/offlineasm/backends.rb
M Source/JavaScriptCore/offlineasm/parser.rb
M Source/JavaScriptCore/offlineasm/transform.rb

  Log Message:
  ---
  Unreviewed, reverting 277134@main
https://bugs.webkit.org/show_bug.cgi?id=270699
rdar://126085546

Breaks iOS builds

Reverted change:

[JSC] (Re-land) Add aligned label annotation to offlineasm
https://bugs.webkit.org/show_bug.cgi?id=270699
rdar://113594783
https://commits.webkit.org/277134@main

Canonical link: https://commits.webkit.org/277212@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3b7835: REGRESSION(277164@main): builtins generator tests ...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b78352e805853219dba140e70f561002d4cba38
  
https://github.com/WebKit/WebKit/commit/3b78352e805853219dba140e70f561002d4cba38
  Author: Fujii Hironori 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M 
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result
M 
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result
M 
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result
M 
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result
M 
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result
M 
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result

  Log Message:
  ---
  REGRESSION(277164@main): builtins generator tests are failing
https://bugs.webkit.org/show_bug.cgi?id=272269

Unreviewed reset results by run-builtins-generator-tests --reset-results.

* 
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
* 
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
* 
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
* 
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
* 
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
* 
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:

Canonical link: https://commits.webkit.org/277211@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eb9db9: Unreviewed, Revert 277136@main "Clean up Signals a...

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb9db9d4c5a2c74ead9656d6abe429b26cecb4f7
  
https://github.com/WebKit/WebKit/commit/eb9db9d4c5a2c74ead9656d6abe429b26cecb4f7
  Author: Justin Michaud 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/jsc.cpp
M Source/JavaScriptCore/runtime/InitializeThreading.cpp
M Source/JavaScriptCore/runtime/JSCConfig.cpp
M Source/JavaScriptCore/runtime/JSCConfig.h
M Source/JavaScriptCore/runtime/VM.cpp
M Source/JavaScriptCore/runtime/VMEntryScope.cpp
M Source/JavaScriptCore/runtime/VMTraps.cpp
M Source/JavaScriptCore/tools/JSDollarVM.cpp
M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp
M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h
M Source/WTF/wtf/PlatformRegisters.cpp
M Source/WTF/wtf/Threading.cpp
M Source/WTF/wtf/WTFConfig.cpp
M Source/WTF/wtf/WTFConfig.h
M Source/WTF/wtf/threads/Signals.cpp
M Source/WTF/wtf/threads/Signals.h
M Source/WTF/wtf/win/SignalsWin.cpp
M 
Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUServiceEntryPoint.mm
M 
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
M Tools/TestWebKitAPI/Tests/WTF/Signals.cpp

  Log Message:
  ---
  Unreviewed, Revert 277136@main "Clean up Signals and remove hardened fallback"
https://bugs.webkit.org/show_bug.cgi?id=272335
rdar://126077721

Breaks OBJC API

Reverted change:

Clean up Signals and remove hardened fallback
https://bugs.webkit.org/show_bug.cgi?id=271766
rdar://125256111
https://commits.webkit.org/277136@main

Canonical link: https://commits.webkit.org/277210@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a6d91e: REGRESSION(275262@main) AudioContext.start() takes...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6d91e7d8f97f21ba3878cb1e722ae2bc75180cc
  
https://github.com/WebKit/WebKit/commit/a6d91e7d8f97f21ba3878cb1e722ae2bc75180cc
  Author: Jer Noble 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
A PerformanceTests/AudioContext/audio-context-creation.html
M Source/WebCore/platform/audio/SharedAudioDestination.cpp

  Log Message:
  ---
  REGRESSION(275262@main) AudioContext.start() takes longer than it used to.
https://bugs.webkit.org/show_bug.cgi?id=272240
rdar://124071843

Reviewed by Eric Carlson.

In 275262@main, SharedAudioDestination was added to reduce the runtime overhead 
of having
multiple AudioDestinations with the same configuration running simultaneously. 
The
SharedAudioDestination passes its start() and stop() completion handlers to
SharedAudioDestinationAdapter, which calls the completion handler when the 
underlying
AudioDestination starts and stops. But if the destination is already running, 
it waits
until that destination is fully "configured" to call the completion handler, 
and this
configuration happens on the audio render thread. The audio render thread spins 
every 3ms,
so this delay should average out to 1.5ms. However, the underlying 
RemoteAudioDestinationProxy
will run its completion handler without waitaing for the audio device to start, 
so the delay
for that class is much smaller: effecitvely the duration of the XPC call.

In the case that the AudioDestination starts and stops, continue to pass the 
completion
handler to that method. But in the case where the AudioDestination is already 
running and
the list of renderers just needs to be updated, assume that will succeed and 
just run the
completion handler in the next run loop.

* PerformanceTests/AudioContext/audio-context-creation.html: Added.
* Source/WebCore/platform/audio/SharedAudioDestination.cpp:
(WebCore::SharedAudioDestinationAdapter::~SharedAudioDestinationAdapter):
(WebCore::SharedAudioDestinationAdapter::configureRenderThread):
(WebCore::SharedAudioDestinationAdapter::render):
(WebCore::SharedAudioDestinationAdapter::callAllConfigurationHandlers): Deleted.

Canonical link: https://commits.webkit.org/277209@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 28733f: [Navigation] Implement userInitiated in NavigateEvent

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28733f4c1575c6350918cc83e645f6a5f8e79c0e
  
https://github.com/WebKit/WebKit/commit/28733f4c1575c6350918cc83e645f6a5f8e79c0e
  Author: Rob Buis 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-userInitiated-expected.txt
M Source/WebCore/page/Navigation.cpp

  Log Message:
  ---
  [Navigation] Implement userInitiated in NavigateEvent
https://bugs.webkit.org/show_bug.cgi?id=272146

Reviewed by Alex Christensen.

Implement userInitiated in NavigateEvent.

Also correct isSameDocument determination when sending the push/replace/reload 
navigate event on fragment navigation since it is hardcoded to true:
https://html.spec.whatwg.org/multipage/browsing-the-web.html#scroll-to-fragid:fire-a-push/replace/reload-navigate-event

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-userInitiated-expected.txt:
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::innerDispatchNavigateEvent):

Canonical link: https://commits.webkit.org/277208@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4c1792: Update RELEASE_ASSERT in FormState::willDetachPage

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c17927610b9ae436eb76bd1dea3354921331c35
  
https://github.com/WebKit/WebKit/commit/4c17927610b9ae436eb76bd1dea3354921331c35
  Author: Rob Buis 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
A LayoutTests/fast/forms/form-submission-crash-4-expected.txt
A LayoutTests/fast/forms/form-submission-crash-4.html
M Source/WebCore/loader/FormState.cpp

  Log Message:
  ---
  Update RELEASE_ASSERT in FormState::willDetachPage
https://bugs.webkit.org/show_bug.cgi?id=270479
rdar://123991819

Reviewed by Chris Dumez.

During the call to continueLoadAfterNavigationPolicy(), it's possible for the 
frame to be detached. The
FrameDestructionObserver willDetachPage() implementation in FormState has the 
expectation that there
is only one reference at this stage, so having an extra one during the scope of
continueLoadAfterNavigationPolicy() might break this assumption.

To respect the new smart pointer adoption guidelines, but also keep the trap 
introduced in
https://trac.webkit.org/changeset/229683/webkit, use refCount() instead.

* LayoutTests/fast/forms/form-submission-crash-4-expected.txt: Added.
* LayoutTests/fast/forms/form-submission-crash-4.html: Added.
* Source/WebCore/loader/FormState.cpp:
(WebCore::FormState::willDetachPage):

Canonical link: https://commits.webkit.org/277207@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 636108: Begin unskipping web platform tests when running W...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 636108ec76f2fbee335e40b38fb67875c88dae5f
  
https://github.com/WebKit/WebKit/commit/636108ec76f2fbee335e40b38fb67875c88dae5f
  Author: Alex Christensen 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-site-isolation/TestExpectations

  Log Message:
  ---
  Begin unskipping web platform tests when running WebKitTestRunner with 
--site-isolation
https://bugs.webkit.org/show_bug.cgi?id=272341
rdar://126085327

Unreviewed.

* LayoutTests/platform/mac-site-isolation/TestExpectations:

Canonical link: https://commits.webkit.org/277206@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ccf339: [test-webkitpy] Disable commit signing in test rep...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ccf339bcd967718e3eb778f0ca0df1a520447c3c
  
https://github.com/WebKit/WebKit/commit/ccf339bcd967718e3eb778f0ca0df1a520447c3c
  Author: Jonathan Bedard 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py

  Log Message:
  ---
  [test-webkitpy] Disable commit signing in test repositories
https://bugs.webkit.org/show_bug.cgi?id=272258
rdar://125996992

Reviewed by Dewei Zhu.

* Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(GitTest.setUp): Disable commit signing in temporary repository.

Canonical link: https://commits.webkit.org/277205@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1a7bea: Avoid IPC to OpenDirectory XPC service on main thread

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a7bea21fb470e352743786b98cac1b5b5e6ca5a
  
https://github.com/WebKit/WebKit/commit/1a7bea21fb470e352743786b98cac1b5b5e6ca5a
  Author: Per Arne Vollan 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebKit/GPUProcess/mac/GPUProcessMac.mm
M Source/WebKit/Shared/AuxiliaryProcess.h
M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  ---
  Avoid IPC to OpenDirectory XPC service on main thread
https://bugs.webkit.org/show_bug.cgi?id=272192
rdar://123778399

Reviewed by Sihui Liu.

Avoid IPC to OpenDirectory XPC service on main thread, since it can potentially 
block the main thread for a long time.
This IPC is called in response to a notification from the UI process when the 
Open Directory cache has been invalidated.
There is a window of time where calling getpwuid_r and related functions in the 
WebContent process can return stale
values after the cache has been invalidated. This is still an issue after this 
patch and should be addressed, but it
may be outside the scope of this patch. WebKit is only calling this function 
before entering the sandbox, where we will
never get stale values. It is however possible that other frameworks are 
calling this function, but I am not aware of
that being the case, currently.

* Source/WebKit/GPUProcess/mac/GPUProcessMac.mm:
(WebKit::GPUProcess::openDirectoryCacheInvalidated):
* Source/WebKit/Shared/AuxiliaryProcess.h:
* Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::AuxiliaryProcess::openDirectoryCacheInvalidated):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::openDirectoryCacheInvalidated):

Canonical link: https://commits.webkit.org/277204@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bd1249: Workaround restrict error in GCC 12

[Patrick]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd1249cc9c4fe70efb4dae7cb463a790d684ce48
  
https://github.com/WebKit/WebKit/commit/bd1249cc9c4fe70efb4dae7cb463a790d684ce48
  Author: Patrick Griffis 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WTF/wtf/Int128.cpp

  Log Message:
  ---
  Workaround restrict error in GCC 12
https://bugs.webkit.org/show_bug.cgi?id=272309

Reviewed by Darin Adler.

In GCC 12.3.0:

In static member function ‘static constexpr std::char_traits::char_type* 
std::char_traits::copy(char_type*, const char_type*, std::size_t)’,
inlined from ‘static constexpr void std::__cxx11::basic_string<_CharT, 
_Traits, _Alloc>::_S_copy(_CharT*, const _CharT*, size_type) [with _CharT = 
char; _Traits = std::char_traits; _Alloc = std::allocator]’ at 
/usr/include/c++/12/bits/basic_string.h:431:21,
inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, 
_Allocator>& std::__cxx11::basic_string<_CharT, _Traits, 
_Alloc>::_M_replace(size_type, size_type, const _CharT*, size_type) [with 
_CharT = char; _Traits = std::char_traits; _Alloc = 
std::allocator]’ at /usr/include/c++/12/bits/basic_string.tcc:532:22,
inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, 
_Alloc>& std::__cxx11::basic_string<_CharT, _Traits, 
_Alloc>::replace(size_type, size_type, const _CharT*, size_type) [with _CharT = 
char; _Traits = std::char_traits; _Alloc = std::allocator]’ at 
/usr/include/c++/12/bits/basic_string.h:2179:19,
inlined from ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, 
_Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::insert(size_type, 
const _CharT*) [with _CharT = char; _Traits = std::char_traits; _Alloc = 
std::allocator]’ at /usr/include/c++/12/bits/basic_string.h:1936:22,
inlined from ‘std::ostream& WTF::operator<<(std::ostream&, Int128Impl)’ at 
/host/home/tingping/Projects/WebKit/Source/WTF/wtf/Int128.cpp:268:17:
/usr/include/c++/12/bits/char_traits.h:435:56: error: ‘void* 
__builtin_memcpy(void*, const void*, long unsigned int)’ accessing 
9223372036854775810 or more bytes at offsets [2, 9223372036854775807] and 1 may 
overlap up to 9223372036854775813 bytes at offset -3 [-Werror=restrict]
  435 | return static_cast(__builtin_memcpy(__s1, __s2, 
__n));
  |^

* Source/WTF/wtf/Int128.cpp:
(WTF::operator<<):

Canonical link: https://commits.webkit.org/277203@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d52c23: [WPE][WebXR] Assertion fails `gl.checkFramebufferS...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d52c23512973325366891d4fdbd0ca2ab5bd0c7c
  
https://github.com/WebKit/WebKit/commit/d52c23512973325366891d4fdbd0ca2ab5bd0c7c
  Author: Vitaly Dyachkov 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/testing/WebFakeXRDevice.cpp

  Log Message:
  ---
  [WPE][WebXR] Assertion fails `gl.checkFramebufferStatus(GL::FRAMEBUFFER) == 
GL::FRAMEBUFFER_COMPLETE` in `WebXROpaqueFramebuffer::blitShared()`
https://bugs.webkit.org/show_bug.cgi?id=272329

Reviewed by Mike Wyrzykowski.

`glTexStorage2D` and sized color formats are unavialable in `WebGL`
context which is using OpenGL ES 2 under the hood.

* Source/WebCore/testing/WebFakeXRDevice.cpp:
(WebCore::SimulatedXRDevice::createLayerProjection):

Canonical link: https://commits.webkit.org/277202@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 18692f: Remove trusted types enforcement from object and e...

[Luke Warlow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18692f5a98be6dcc54fca171bd358e136660ec4b
  
https://github.com/WebKit/WebKit/commit/18692f5a98be6dcc54fca171bd358e136660ec4b
  Author: Luke Warlow 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute.html
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic.html
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedType-AttributeNodes-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedType-AttributeNodes.html
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.html
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute.html
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS.html
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic.html
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node.html
M 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt
M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt
M 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt
M Source/WebCore/dom/TrustedTypePolicyFactory.cpp
M Source/WebCore/html/HTMLEmbedElement.idl
M Source/WebCore/html/HTMLObjectElement.idl

  Log Message:
  ---
  Remove trusted types enforcement from object and embed elements
https://bugs.webkit.org/show_bug.cgi?id=271824

Reviewed by Anne van Kesteren.

This removes TT coverage of object and embed elements.
These no longer need protecting as they're not XSS sinks anymore.

Also updates the test suite to remove coverage of them.

* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute.html:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic.html:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedType-AttributeNodes-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedType-AttributeNodes.html:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.html:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute.html:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS.html:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic.html:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node.html:
* 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt:
* 

[webkit-changes] [WebKit/WebKit] cdadd1: Unreviewed, reverting 277143@main

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cdadd16e6fa8270afc0f9b13979aaa3cd4828298
  
https://github.com/WebKit/WebKit/commit/cdadd16e6fa8270afc0f9b13979aaa3cd4828298
  Author: Justin Michaud 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WTF/wtf/threads/Signals.cpp

  Log Message:
  ---
  Unreviewed, reverting 277143@main
https://bugs.webkit.org/show_bug.cgi?id=272335
rdar://126077721

Breaks OBJC API

Reverted change:

Don't initialize mach exceptions if we didn't register any.
https://bugs.webkit.org/show_bug.cgi?id=272261
rdar://126000755
https://commits.webkit.org/277143@main

Canonical link: https://commits.webkit.org/277200@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dd34ad: [visionOS] Re-baseline layer based tests

[Etienne Segonzac]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd34add77143b39d511f18371770d1df44bf9cf7
  
https://github.com/WebKit/WebKit/commit/dd34add77143b39d511f18371770d1df44bf9cf7
  Author: Etienne Segonzac 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M LayoutTests/interaction-region/interaction-layers-culling-expected.txt
M 
LayoutTests/interaction-region/interaction-layers-culling-layer-type-change-expected.txt
M LayoutTests/interaction-region/layer-tree-expected.txt
M LayoutTests/interaction-region/layer-tree-shape-reset-expected.txt
M LayoutTests/overlay-region/fixed-node-updates-expected.txt
M LayoutTests/overlay-region/full-page-dynamic-expected.txt
M LayoutTests/overlay-region/full-page-expected.txt
M LayoutTests/overlay-region/full-page-horizontal-expected.txt
M LayoutTests/overlay-region/full-page-overflow-expected.txt
M LayoutTests/overlay-region/full-page-overflow-scrolling-expected.txt
M LayoutTests/overlay-region/full-page-overflow-snapping-expected.txt
M LayoutTests/overlay-region/full-page-scrolling-expected.txt
M LayoutTests/overlay-region/many-candidates-expected.txt
M LayoutTests/overlay-region/map-expected.txt
M LayoutTests/overlay-region/map-small-expected.txt
M LayoutTests/overlay-region/overlay-element-expected.txt
M LayoutTests/overlay-region/overlay-element-overflow-expected.txt
M LayoutTests/overlay-region/snapping-expected.txt
M LayoutTests/overlay-region/split-scrollers-expected.txt

  Log Message:
  ---
  [visionOS] Re-baseline layer based tests
https://bugs.webkit.org/show_bug.cgi?id=272323
rdar://126070971

Reviewed by Mike Wyrzykowski.

No code change.
An extra layer was added elsewhere so some tests need new expectations.

* LayoutTests/interaction-region/interaction-layers-culling-expected.txt:
* 
LayoutTests/interaction-region/interaction-layers-culling-layer-type-change-expected.txt:
* LayoutTests/interaction-region/layer-tree-expected.txt:
* LayoutTests/interaction-region/layer-tree-shape-reset-expected.txt:
* LayoutTests/overlay-region/fixed-node-updates-expected.txt:
* LayoutTests/overlay-region/full-page-dynamic-expected.txt:
* LayoutTests/overlay-region/full-page-expected.txt:
* LayoutTests/overlay-region/full-page-horizontal-expected.txt:
* LayoutTests/overlay-region/full-page-overflow-expected.txt:
* LayoutTests/overlay-region/full-page-overflow-scrolling-expected.txt:
* LayoutTests/overlay-region/full-page-overflow-snapping-expected.txt:
* LayoutTests/overlay-region/full-page-scrolling-expected.txt:
* LayoutTests/overlay-region/many-candidates-expected.txt:
* LayoutTests/overlay-region/map-expected.txt:
* LayoutTests/overlay-region/map-small-expected.txt:
* LayoutTests/overlay-region/overlay-element-expected.txt:
* LayoutTests/overlay-region/overlay-element-overflow-expected.txt:
* LayoutTests/overlay-region/snapping-expected.txt:
* LayoutTests/overlay-region/split-scrollers-expected.txt:

Canonical link: https://commits.webkit.org/277199@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 20ff0f: Deploy std::span more broadly

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20ff0f714457fc4549f05f522014652f38b7f37d
  
https://github.com/WebKit/WebKit/commit/20ff0f714457fc4549f05f522014652f38b7f37d
  Author: Chris Dumez 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/PAL/pal/text/TextEncodingRegistry.cpp
M Source/WebCore/css/CSSMarkup.cpp
M Source/WebCore/css/CSSVariableData.cpp
M Source/WebCore/css/parser/CSSParserToken.cpp
M Source/WebCore/css/parser/CSSParserToken.h
M Source/WebCore/css/parser/CSSPropertyParser.cpp
M Source/WebCore/html/HTMLFontElement.cpp
M Source/WebCore/html/parser/CSSPreloadScanner.cpp
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/platform/graphics/FontCascade.cpp
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/platform/graphics/WidthCache.h
M Source/WebCore/rendering/RenderText.cpp

  Log Message:
  ---
  Deploy std::span more broadly
https://bugs.webkit.org/show_bug.cgi?id=272314

Reviewed by Darin Adler.

* Source/WebCore/PAL/pal/text/TextEncodingRegistry.cpp:
(PAL::atomCanonicalTextEncodingName):
* Source/WebCore/css/CSSMarkup.cpp:
(WebCore::isCSSTokenizerIdentifier):
* Source/WebCore/css/CSSVariableData.cpp:
(WebCore::CSSVariableData::updateBackingStringsInTokens):
* Source/WebCore/css/parser/CSSParserToken.cpp:
(WebCore::cssPrimitiveValueUnitFromTrie):
(WebCore::CSSParserToken::stringToUnitType):
(WebCore::CSSParserToken::tryUseStringLiteralBacking):
* Source/WebCore/css/parser/CSSParserToken.h:
(WebCore::CSSParserToken::updateCharacters):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::cssPropertyID):
(WebCore::cssValueKeywordID):
* Source/WebCore/html/HTMLFontElement.cpp:
(WebCore::parseFontSize):
* Source/WebCore/html/parser/CSSPreloadScanner.cpp:
(WebCore::parseCSSStringOrURL):
(WebCore::CSSPreloadScanner::emitRule):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::nonWhitespaceLength):
(WebCore::LocalFrameView::incrementVisuallyNonEmptyCharacterCountSlowCase):
* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::normalizeSpacesInternal):
(WebCore::FontCascade::normalizeSpaces):
* Source/WebCore/platform/graphics/FontCascade.h:
* Source/WebCore/platform/graphics/WidthCache.h:
(WebCore::WidthCache::SmallStringKey::SmallStringKey):
(WebCore::WidthCache::SmallStringKey::copySmallCharacters):
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::containsOnlyCollapsibleWhitespace):
(WebCore::RenderText::containsOnlyCollapsibleWhitespace const):
(WebCore::containsOnlyPossiblyCollapsibleWhitespace):
(WebCore::RenderText::containsOnlyCSSWhitespace const):

Canonical link: https://commits.webkit.org/277198@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2a4191: Clarify generate-compile-commands is only needed f...

[Alicia Boya García]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a4191b4fda114f2781cb0ae27eb7571d2ecffa0
  
https://github.com/WebKit/WebKit/commit/2a4191b4fda114f2781cb0ae27eb7571d2ecffa0
  Author: Alicia Boya Garcia 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Tools/Scripts/build-webkit
M Tools/Scripts/generate-compile-commands

  Log Message:
  ---
  Clarify generate-compile-commands is only needed for XCode builds
https://bugs.webkit.org/show_bug.cgi?id=271053

Reviewed by Darin Adler.

This patch adds clarifications that generate-compile-commands is only
needed for XCode based builds (i.e. current Mac builds).

An additional hint is added to the script such that if it detects the
build is CMake based it instructs the user on how to generate
compile_commands.json with CMake.

* Tools/Scripts/build-webkit:
* Tools/Scripts/generate-compile-commands:

Canonical link: https://commits.webkit.org/277197@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 80dd62: [Modern Media Controls] HTMLMediaElement is never ...

[Enrique Ocaña González]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 80dd62a7e3323e4c039cac722ec4c563c92a17ff
  
https://github.com/WebKit/WebKit/commit/80dd62a7e3323e4c039cac722ec4c563c92a17ff
  Author: Enrique Ocaña González 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/Modules/modern-media-controls/controls/icon-service.js
M Source/WebCore/Modules/modern-media-controls/media/media-controller.js
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLMediaElement.h

  Log Message:
  ---
  [Modern Media Controls] HTMLMediaElement is never destroyed when showing 
media controls
https://bugs.webkit.org/show_bug.cgi?id=270571

Reviewed by Xabier Rodriguez-Calvar.

At least in GStreamer-based ports (WPE and WebKitGTK, I haven't checked
on Mac ports because I don't have the proper environment easily
available), the media element is leaked after explicit deinitialization
and detaching from the HTML document, even after manually triggering
garbage collection (GC) using the web inspector.

See: https://github.com/WebPlatformForEmbedded/WPEWebKit/issues/1285

After some debugging, we've detected that 2 extra references to
HTMLMediaElement appear when using the controls (3 refs in total), while
in a scenario where the controls are hidden on purpose only 1 reference
remains, which is released as soon as the GC kicks in.

Those references are held (or transitively held) by the MediaController,
the shadowRoot referenced by the MediaController and by the IconService,
and the  element that MediaController adds to the shadowRoot as a
container for the controls.

This commit adds code to use WeakRefs to the ShadowRoot and to the
MediaJSWrapper (media) on MediaController, and to the ShadowRoot on
the iconService, instead of the original objects. This allows the
garbage collector to kick in when needed and have those objects freed
automatically. The WeakRefs are transparently exposed as regular objects
by using properties (get/set), to avoid the need to change a lot of code
that expects regular objects.

There's still the  element added to the ShadowRoot, which
transitively holds a reference that prevents GC. There's no good place
to remove that element, so I removed it in the "less bad place", which
is HTMLMediaElement::pauseAfterDetachedTask(). A new deinitialize() JS
function takes care of that. Unfortunately, the element can still be
used after deinitialization, so there's also a method to reinitialize()
it if needed and an extra ControlsState to mark the element as
PartiallyDeinitialized in order to know when to recover from that state.

* Source/WebCore/Modules/modern-media-controls/controls/icon-service.js: Store 
shadowRoot as a WeakRef.
(const.iconService.new.IconService.prototype.get shadowRoot): Expose the 
shadowRootWeakRef as a regular shadowRoot object by binding it to the 
shadowRoot property.
(const.iconService.new.IconService.prototype.set shadowRoot): Ditto, but for 
the setter.
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController): Store shadowRoot and media as WeakRefs.
(MediaController.prototype.get media): Expose the mediaWeakRef as a regular 
media object by binding it to the media property.
(MediaController.prototype.get shadowRoot): Expose the shadowRootWeakRef as a 
regular shadowRoot object by binding it to the shadowRoot property.
(MediaController.prototype.get isFullscreen): Take into account the case where 
media can be null.
(MediaController.prototype.deinitialize): Function called from HTMLMediaElement 
to deinitialize the MediaController. Just removes the shadowRoot child.
(MediaController.prototype.reinitialize): Function called from HTMLMediaElement 
to reinitialize the MediaController. Readds the shadowRoot child and sets again 
the WeakRefs that might have become by lack of use of the main objects.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::convertEnumerationToString): Utility function to get a printable 
version of ControlsState. Useful for debugging.
(WebCore::HTMLMediaElement::pauseAfterDetachedTask): Deinitialize the 
MediaController by calling its deinitialize() JS method.
(WebCore::HTMLMediaElement::ensureMediaControls): Support the case of 
reinitialization. Call the reinitialize() JS method in MediaController in that 
case.
* Source/WebCore/html/HTMLMediaElement.h: Added new PartiallyDeinitialized 
state to ControlsState. Give friend access to convertEnumerationToString() so 
it can do its job.

Canonical link: https://commits.webkit.org/277196@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9b6dc3: WebCore::RenderElement::StylePropagationType shoul...

[Tetsuharu Ohzeki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b6dc36441c0d9a7f13168cce493bcb9839f637c
  
https://github.com/WebKit/WebKit/commit/9b6dc36441c0d9a7f13168cce493bcb9839f637c
  Author: Tetsuharu Ohzeki 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTableRow.cpp
M Source/WebCore/rendering/RenderTableSection.cpp

  Log Message:
  ---
  WebCore::RenderElement::StylePropagationType should be an enum class
https://bugs.webkit.org/show_bug.cgi?id=272302

Reviewed by Tim Nguyen.

* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::propagateStyleToAnonymousChildren):
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::styleDidChange):
* Source/WebCore/rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::styleDidChange):

Canonical link: https://commits.webkit.org/277195@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c5b0e4: [WGSL] Fix broken wgslc tests

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c5b0e434b552f9ea9b45b699ba435b1bd048
  
https://github.com/WebKit/WebKit/commit/c5b0e434b552f9ea9b45b699ba435b1bd048
  Author: Tadeu Zagallo 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebGPU/WGSL/AttributeValidator.cpp
A 
Source/WebGPU/WGSL/tests/invalid/attribute-validation-during-type-checking.wgsl
M Source/WebGPU/WGSL/tests/invalid/attribute-validation.wgsl
M Source/WebGPU/WGSL/tests/valid/concretization.wgsl
M Source/WebGPU/WGSL/tests/valid/constants-utf16.wgsl
M Source/WebGPU/WGSL/tests/valid/constants.wgsl
M Source/WebGPU/WGSL/tests/valid/global-constant-vector.wgsl
M Source/WebGPU/WGSL/tests/valid/overload.wgsl
M Source/WebGPU/WGSL/tests/valid/packing.wgsl

  Log Message:
  ---
  [WGSL] Fix broken wgslc tests
https://bugs.webkit.org/show_bug.cgi?id=272227
rdar://125966589

Reviewed by Mike Wyrzykowski and Dan Glastonbury.

The tests just needed to be updated because they contained invalid code that
is now being rejected after we added more validation.

* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::visit):
* 
Source/WebGPU/WGSL/tests/invalid/attribute-validation-during-type-checking.wgsl:
 Added.
* Source/WebGPU/WGSL/tests/invalid/attribute-validation.wgsl:
* Source/WebGPU/WGSL/tests/valid/concretization.wgsl:
* Source/WebGPU/WGSL/tests/valid/constants-utf16.wgsl:
* Source/WebGPU/WGSL/tests/valid/constants.wgsl:
* Source/WebGPU/WGSL/tests/valid/global-constant-vector.wgsl:
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:
* Source/WebGPU/WGSL/tests/valid/packing.wgsl:

Canonical link: https://commits.webkit.org/277194@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 15c31e: [WebGPU] https://gpuweb.github.io/cts/standalone/?...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 15c31e21d87705f509b1206beee9eee170e6cda3
  
https://github.com/WebKit/WebKit/commit/15c31e21d87705f509b1206beee9eee170e6cda3
  Author: Tadeu Zagallo 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
A 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/shader_io/workgroup_size-expected.txt
M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  ---
  [WebGPU] 
https://gpuweb.github.io/cts/standalone/?q=webgpu:api,operation,compute_pipeline,overrides:workgroup_size:isAsync=true;type=%22u32%22;size=3;v=%22y%22
 is failing
https://bugs.webkit.org/show_bug.cgi?id=272204
rdar://125945949

Reviewed by Mike Wyrzykowski and Dan Glastonbury.

In 275374@main I changed some of the attribute type checking to use a new 
`check` helper,
which checks if a type satisfies a constraint and then concretizes it if 
necessary. That
helper was being used when checking the `@workgroup_size`, which is not 
correct, since we
cannot concretize the type of each argument individually.

* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/shader_io/workgroup_size-expected.txt:
 Added.
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):

Canonical link: https://commits.webkit.org/277193@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 91f787: Fix incorrect EGL function type definitions in Pla...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91f787886ac542eb4148d991b629c028f389f0cf
  
https://github.com/WebKit/WebKit/commit/91f787886ac542eb4148d991b629c028f389f0cf
  Author: Adrian Perez de Castro 
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/PlatformDisplay.cpp

  Log Message:
  ---
  Fix incorrect EGL function type definitions in PlatformDisplay
https://bugs.webkit.org/show_bug.cgi?id=27

Reviewed by Carlos Garcia Campos.

* Source/WebCore/platform/graphics/PlatformDisplay.cpp: Use EGLAPIENTRYP
  to mark EGL function type definitions and use the extension name and
  EGL version macros to guard their definition.

Canonical link: https://commits.webkit.org/277192@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes