[webkit-changes] [185774] trunk/Source

[mcatanzaro]

Title: [185774] trunk/Source








Revision 185774
Author mcatanz...@igalia.com
Date 2015-06-19 16:25:51 -0700 (Fri, 19 Jun 2015)


Log Message
[SOUP] Fix return-type-c-linkage warning after r185553
https://bugs.webkit.org/show_bug.cgi?id=146014

Reviewed by Martin Robinson.

Source/WebCore:

* platform/network/soup/WebKitSoupRequestGeneric.cpp:
(webkitSoupRequestGenericGetRequest): Return a pointer rather than a reference.
* platform/network/soup/WebKitSoupRequestGeneric.h: webkitSoupRequestGenericGetRequest now
returns a pointer rather than a reference.

Source/WebKit2:

* Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:
(WebKit::CustomProtocolManagerImpl::start): webkitSoupRequestGenericGetRequest now returns
a pointer rather than a reference.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.cpp
trunk/Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (185773 => 185774)

--- trunk/Source/WebCore/ChangeLog	2015-06-19 22:40:25 UTC (rev 185773)
+++ trunk/Source/WebCore/ChangeLog	2015-06-19 23:25:51 UTC (rev 185774)
@@ -1,3 +1,15 @@
+2015-06-19  Michael Catanzaro  mcatanz...@igalia.com
+
+[SOUP] Fix return-type-c-linkage warning after r185553
+https://bugs.webkit.org/show_bug.cgi?id=146014
+
+Reviewed by Martin Robinson.
+
+* platform/network/soup/WebKitSoupRequestGeneric.cpp:
+(webkitSoupRequestGenericGetRequest): Return a pointer rather than a reference.
+* platform/network/soup/WebKitSoupRequestGeneric.h: webkitSoupRequestGenericGetRequest now
+returns a pointer rather than a reference.
+
 2015-06-19  Dean Jackson  d...@apple.com
 
 Played audio looks invisible against the gray background


Modified: trunk/Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.cpp (185773 => 185774)

--- trunk/Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.cpp	2015-06-19 22:40:25 UTC (rev 185773)
+++ trunk/Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.cpp	2015-06-19 23:25:51 UTC (rev 185774)
@@ -100,7 +100,7 @@
 request-priv-resourceRequest = resourceRequest;
 }
 
-const ResourceRequest webkitSoupRequestGenericGetRequest(WebKitSoupRequestGeneric* request)
+const ResourceRequest* webkitSoupRequestGenericGetRequest(WebKitSoupRequestGeneric* request)
 {
-return request-priv-resourceRequest;
+return request-priv-resourceRequest;
 }


Modified: trunk/Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.h (185773 => 185774)

--- trunk/Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.h	2015-06-19 22:40:25 UTC (rev 185773)
+++ trunk/Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.h	2015-06-19 23:25:51 UTC (rev 185774)
@@ -58,7 +58,7 @@
 void webkitSoupRequestGenericSetContentLength(WebKitSoupRequestGeneric*, goffset contentLength);
 void webkitSoupRequestGenericSetContentType(WebKitSoupRequestGeneric*, const char* mimeType);
 void webkitSoupRequestGenericSetRequest(WebKitSoupRequestGeneric*, const WebCore::ResourceRequest);
-const WebCore::ResourceRequest webkitSoupRequestGenericGetRequest(WebKitSoupRequestGeneric*);
+const WebCore::ResourceRequest* webkitSoupRequestGenericGetRequest(WebKitSoupRequestGeneric*);
 
 G_END_DECLS
 


Modified: trunk/Source/WebKit2/ChangeLog (185773 => 185774)

--- trunk/Source/WebKit2/ChangeLog	2015-06-19 22:40:25 UTC (rev 185773)
+++ trunk/Source/WebKit2/ChangeLog	2015-06-19 23:25:51 UTC (rev 185774)
@@ -1,3 +1,14 @@
+2015-06-19  Michael Catanzaro  mcatanz...@igalia.com
+
+[SOUP] Fix return-type-c-linkage warning after r185553
+https://bugs.webkit.org/show_bug.cgi?id=146014
+
+Reviewed by Martin Robinson.
+
+* Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:
+(WebKit::CustomProtocolManagerImpl::start): webkitSoupRequestGenericGetRequest now returns
+a pointer rather than a reference.
+
 2015-06-19  Brady Eidson  beid...@apple.com
 
 Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.


Modified: trunk/Source/WebKit2/Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp (185773 => 185774)

--- trunk/Source/WebKit2/Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp	2015-06-19 22:40:25 UTC (rev 185773)
+++ trunk/Source/WebKit2/Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp	2015-06-19 23:25:51 UTC (rev 185774)
@@ -190,7 +190,7 @@
 WebKitSoupRequestGeneric* request = WEBKIT_SOUP_REQUEST_GENERIC(g_task_get_source_object(task));
 m_customProtocolMap.set(customProtocolID, std::make_uniqueWebSoupRequestAsyncData(task, request));
 
-m_childProcess-send(Messages::CustomProtocolManagerProxy::StartLoading(customProtocolID, 

[webkit-changes] [185783] trunk/Source/WTF

[mcatanzaro]

Title: [185783] trunk/Source/WTF








Revision 185783
Author mcatanz...@igalia.com
Date 2015-06-19 17:14:20 -0700 (Fri, 19 Jun 2015)


Log Message
[SOUP] Define SOUP_VERSION_MIN_REQUIRED
https://bugs.webkit.org/show_bug.cgi?id=146165

Reviewed by Martin Robinson.

Define SOUP_VERSION_MIN_REQUIRED to avoid deprecation warnings.

* wtf/Platform.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h




Diff

Modified: trunk/Source/WTF/ChangeLog (185782 => 185783)

--- trunk/Source/WTF/ChangeLog	2015-06-19 23:55:25 UTC (rev 185782)
+++ trunk/Source/WTF/ChangeLog	2015-06-20 00:14:20 UTC (rev 185783)
@@ -1,3 +1,14 @@
+2015-06-19  Michael Catanzaro  mcatanz...@igalia.com
+
+[SOUP] Define SOUP_VERSION_MIN_REQUIRED
+https://bugs.webkit.org/show_bug.cgi?id=146165
+
+Reviewed by Martin Robinson.
+
+Define SOUP_VERSION_MIN_REQUIRED to avoid deprecation warnings.
+
+* wtf/Platform.h:
+
 2015-06-19  Mark Lam  mark@apple.com
 
 Gardening: build fixes for GTK and EFL for CheckedArithmetic change.


Modified: trunk/Source/WTF/wtf/Platform.h (185782 => 185783)

--- trunk/Source/WTF/wtf/Platform.h	2015-06-19 23:55:25 UTC (rev 185782)
+++ trunk/Source/WTF/wtf/Platform.h	2015-06-20 00:14:20 UTC (rev 185783)
@@ -492,6 +492,10 @@
 #define GDK_VERSION_MIN_REQUIRED GDK_VERSION_3_6
 #endif
 
+#if USE(SOUP)
+#define SOUP_VERSION_MIN_REQUIRED SOUP_VERSION_2_42
+#endif
+
 /* On Windows, use QueryPerformanceCounter by default */
 #if OS(WINDOWS)
 #define USE_QUERY_PERFORMANCE_COUNTER  1






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185806] trunk/Tools

[mcatanzaro]

Title: [185806] trunk/Tools








Revision 185806
Author mcatanz...@igalia.com
Date 2015-06-21 06:15:54 -0700 (Sun, 21 Jun 2015)


Log Message
[CMake] Ignore warnings from system headers when compiling Tools
https://bugs.webkit.org/show_bug.cgi?id=146185

Reviewed by Martin Robinson.

Use the SYSTEM argument to the include_directories() command to silence compiler warnings
from system headers that we don't control.

* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
* ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
* ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
* ImageDiff/PlatformGTK.cmake:
* MiniBrowser/efl/CMakeLists.txt:
* MiniBrowser/gtk/CMakeLists.txt:
* TestWebKitAPI/PlatformEfl.cmake:
* TestWebKitAPI/PlatformGTK.cmake:
* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
* WebKitTestRunner/CMakeLists.txt:
* WebKitTestRunner/PlatformEfl.cmake:
* WebKitTestRunner/PlatformGTK.cmake:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt
trunk/Tools/ImageDiff/CMakeLists.txt
trunk/Tools/ImageDiff/PlatformEfl.cmake
trunk/Tools/ImageDiff/PlatformGTK.cmake
trunk/Tools/MiniBrowser/efl/CMakeLists.txt
trunk/Tools/MiniBrowser/gtk/CMakeLists.txt
trunk/Tools/TestWebKitAPI/PlatformEfl.cmake
trunk/Tools/TestWebKitAPI/PlatformGTK.cmake
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt
trunk/Tools/WebKitTestRunner/CMakeLists.txt
trunk/Tools/WebKitTestRunner/PlatformEfl.cmake
trunk/Tools/WebKitTestRunner/PlatformGTK.cmake




Diff

Modified: trunk/Tools/ChangeLog (185805 => 185806)

--- trunk/Tools/ChangeLog	2015-06-21 10:06:14 UTC (rev 185805)
+++ trunk/Tools/ChangeLog	2015-06-21 13:15:54 UTC (rev 185806)
@@ -1,3 +1,26 @@
+2015-06-21  Michael Catanzaro  mcatanz...@igalia.com
+
+[CMake] Ignore warnings from system headers when compiling Tools
+https://bugs.webkit.org/show_bug.cgi?id=146185
+
+Reviewed by Martin Robinson.
+
+Use the SYSTEM argument to the include_directories() command to silence compiler warnings
+from system headers that we don't control.
+
+* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
+* ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
+* ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
+* ImageDiff/PlatformGTK.cmake:
+* MiniBrowser/efl/CMakeLists.txt:
+* MiniBrowser/gtk/CMakeLists.txt:
+* TestWebKitAPI/PlatformEfl.cmake:
+* TestWebKitAPI/PlatformGTK.cmake:
+* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
+* WebKitTestRunner/CMakeLists.txt:
+* WebKitTestRunner/PlatformEfl.cmake:
+* WebKitTestRunner/PlatformGTK.cmake:
+
 2015-06-20  Michael Catanzaro  mcatanz...@igalia.com
 
 [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser


Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt (185805 => 185806)

--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt	2015-06-21 10:06:14 UTC (rev 185805)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt	2015-06-21 13:15:54 UTC (rev 185806)
@@ -33,10 +33,14 @@
 ${WEBKIT_TESTNETSCAPEPLUGIN_DIR}
 ${WEBKIT_TESTNETSCAPEPLUGIN_DIR}/unix/ForwardingHeaders
 ${WEBCORE_DIR}
+)
+
+set(WebKitTestNetscapePlugin_SYSTEM_INCLUDE_DIRECTORIES
 ${X11_INCLUDE_DIR}
 )
 
 include_directories(${WebKitTestNetscapePlugin_INCLUDE_DIRECTORIES})
+include_directories(SYSTEM ${WebKitTestNetscapePlugin_SYSTEM_INCLUDE_DIRECTORIES})
 
 set(WebKitTestNetscapePlugin_LIBRARIES
 ${X11_LIBRARIES}


Modified: trunk/Tools/ImageDiff/CMakeLists.txt (185805 => 185806)

--- trunk/Tools/ImageDiff/CMakeLists.txt	2015-06-21 10:06:14 UTC (rev 185805)
+++ trunk/Tools/ImageDiff/CMakeLists.txt	2015-06-21 13:15:54 UTC (rev 185806)
@@ -2,10 +2,11 @@
 
 set(IMAGE_DIFF_INCLUDE_DIRECTORIES
 ${CMAKE_BINARY_DIR}
-${ECORE_IMF_INCLUDE_DIRS}
 ${WTF_DIR}
 )
 
+set(IMAGE_DIFF_SYSTEM_INCLUDE_DIRECTORIES )
+
 set(IMAGE_DIFF_LIBRARIES
 WTF
 )
@@ -13,6 +14,7 @@
 WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
 
 include_directories(${IMAGE_DIFF_INCLUDE_DIRECTORIES})
+include_directories(SYSTEM ${IMAGE_DIFF_SYSTEM_INCLUDE_DIRECTORIES})
 add_executable(ImageDiff ${IMAGE_DIFF_SOURCES})
 target_link_libraries(ImageDiff ${IMAGE_DIFF_LIBRARIES})
 set_target_properties(ImageDiff PROPERTIES FOLDER Tools)


Modified: trunk/Tools/ImageDiff/PlatformEfl.cmake (185805 => 185806)

--- trunk/Tools/ImageDiff/PlatformEfl.cmake	2015-06-21 10:06:14 UTC (rev 185805)
+++ trunk/Tools/ImageDiff/PlatformEfl.cmake	2015-06-21 13:15:54 UTC (rev 185806)
@@ -2,8 +2,9 @@
 ${IMAGE_DIFF_DIR}/efl/ImageDiff.cpp
 )
 
-list(APPEND IMAGE_DIFF_INCLUDE_DIRECTORIES
+list(APPEND IMAGE_DIFF_SYSTEM_INCLUDE_DIRECTORIES
 ${ECORE_EVAS_INCLUDE_DIRS}
+${ECORE_IMF_INCLUDE_DIRS}
 )
 
 list(APPEND IMAGE_DIFF_LIBRARIES


Modified: trunk/Tools/ImageDiff/PlatformGTK.cmake (185805 => 185806)

[webkit-changes] [185786] trunk/Source/WebCore

[mcatanzaro]

Title: [185786] trunk/Source/WebCore








Revision 185786
Author mcatanz...@igalia.com
Date 2015-06-19 18:24:55 -0700 (Fri, 19 Jun 2015)


Log Message
Fix absolute value warning in LocalizedStringsGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=145919

Reviewed by Martin Robinson.

Use abs(static_castint(time)) rather than static_castint(abs(time)) to avoid clang's
warnings about passing a float to abs() instead of std::abs(). Also, because casting an int
to an int is silly.

* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaTimeDescription):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (185785 => 185786)

--- trunk/Source/WebCore/ChangeLog	2015-06-20 00:51:52 UTC (rev 185785)
+++ trunk/Source/WebCore/ChangeLog	2015-06-20 01:24:55 UTC (rev 185786)
@@ -1,3 +1,17 @@
+2015-06-19  Michael Catanzaro  mcatanz...@igalia.com
+
+Fix absolute value warning in LocalizedStringsGtk.cpp
+https://bugs.webkit.org/show_bug.cgi?id=145919
+
+Reviewed by Martin Robinson.
+
+Use abs(static_castint(time)) rather than static_castint(abs(time)) to avoid clang's
+warnings about passing a float to abs() instead of std::abs(). Also, because casting an int
+to an int is silly.
+
+* platform/gtk/LocalizedStringsGtk.cpp:
+(WebCore::localizedMediaTimeDescription):
+
 2015-06-19  Devin Rousso  drou...@apple.com
 
 Web Inspector: Highlight currently edited CSS selector


Modified: trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp (185785 => 185786)

--- trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp	2015-06-20 00:51:52 UTC (rev 185785)
+++ trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp	2015-06-20 01:24:55 UTC (rev 185786)
@@ -664,7 +664,7 @@
 if (!std::isfinite(time))
 return String::fromUTF8(_(indefinite time));
 
-int seconds = static_castint(abs(time));
+int seconds = abs(static_castint(time));
 int days = seconds / (60 * 60 * 24);
 int hours = seconds / (60 * 60);
 int minutes = (seconds / 60) % 60;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185788] trunk

[mcatanzaro]

Title: [185788] trunk








Revision 185788
Author mcatanz...@igalia.com
Date 2015-06-19 19:41:09 -0700 (Fri, 19 Jun 2015)


Log Message
[CMake] FindGTK3.cmake should not modify the values of build options
https://bugs.webkit.org/show_bug.cgi?id=144613

Reviewed by Martin Robinson.

* Source/cmake/FindGTK3.cmake: Do not check or set the value of ENABLE_X11_TARGET and
ENABLE_WAYLAND_TARGET. Instead, simply define the variables GTK3_SUPPORTS_X11 and
GTK3_SUPPORTS_WAYLAND as appropriate. Also, rename GTK_SUPPORTS_GESTURES to
GTK3_SUPPORTS_GESTURES for consistency.
* Source/cmake/OptionsGTK.cmake: Fail the build if the appropriate GTK+ backend is not
available. It's not possible to automatically select a backend correctly anymore, since all
options are set at the same time.

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/FindGTK3.cmake
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (185787 => 185788)

--- trunk/ChangeLog	2015-06-20 01:46:17 UTC (rev 185787)
+++ trunk/ChangeLog	2015-06-20 02:41:09 UTC (rev 185788)
@@ -1,3 +1,18 @@
+2015-06-19  Michael Catanzaro  mcatanz...@igalia.com
+
+[CMake] FindGTK3.cmake should not modify the values of build options
+https://bugs.webkit.org/show_bug.cgi?id=144613
+
+Reviewed by Martin Robinson.
+
+* Source/cmake/FindGTK3.cmake: Do not check or set the value of ENABLE_X11_TARGET and
+ENABLE_WAYLAND_TARGET. Instead, simply define the variables GTK3_SUPPORTS_X11 and
+GTK3_SUPPORTS_WAYLAND as appropriate. Also, rename GTK_SUPPORTS_GESTURES to
+GTK3_SUPPORTS_GESTURES for consistency.
+* Source/cmake/OptionsGTK.cmake: Fail the build if the appropriate GTK+ backend is not
+available. It's not possible to automatically select a backend correctly anymore, since all
+options are set at the same time.
+
 2015-06-19  Csaba Osztrogonác  o...@webkit.org
 
 Remove unnecessary svn:executable flags


Modified: trunk/Source/cmake/FindGTK3.cmake (185787 => 185788)

--- trunk/Source/cmake/FindGTK3.cmake	2015-06-20 01:46:17 UTC (rev 185787)
+++ trunk/Source/cmake/FindGTK3.cmake	2015-06-20 02:41:09 UTC (rev 185788)
@@ -4,9 +4,12 @@
 #  GTK3_FOUND - system has GTK+ 3.
 #  GTK3_INCLUDE_DIRS - the GTK+ 3. include directories
 #  GTK3_LIBRARIES - link these to use GTK+ 3.
+#  GTK3_SUPPORTS_GESTURES - GTK+ supports gestures (GTK+ = 3.14)
+#  GTK3_SUPPORTS_X11 - GTK+ supports X11 backend
+#  GTK3_SUPPORTS_WAYLAND - GTK+ supports Wayland backend
 #
 # Copyright (C) 2012 Raphael Kubo da Costa rak...@webkit.org
-# Copyright (C) 2013 Igalia S.L.
+# Copyright (C) 2013, 2015 Igalia S.L.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -45,30 +48,23 @@
 endif ()
 endif ()
 
-if (GTK3_VERSION AND VERSION_OK AND ENABLE_X11_TARGET)
+if (GTK3_VERSION AND VERSION_OK)
 pkg_check_modules(GTK3_X11 gtk+-x11-3.0)
-if (NOT(${GTK3_X11_VERSION} VERSION_EQUAL ${GTK3_VERSION}))
-set(ENABLE_X11_TARGET OFF)
+if (${GTK3_X11_VERSION} VERSION_EQUAL ${GTK3_VERSION})
+set(GTK3_SUPPORTS_X11 TRUE)
 endif ()
-endif ()
 
-if (GTK3_VERSION AND VERSION_OK AND ENABLE_WAYLAND_TARGET)
 pkg_check_modules(GTK3_WAYLAND gtk+-wayland-3.0)
-if (NOT(${GTK3_WAYLAND_VERSION} VERSION_EQUAL ${GTK3_VERSION}))
-set(ENABLE_WAYLAND_TARGET OFF)
+if (${GTK3_WAYLAND_VERSION} VERSION_EQUAL ${GTK3_VERSION})
+set(GTK3_SUPPORTS_WAYLAND TRUE)
 endif ()
-endif ()
 
-if (NOT(ENABLE_X11_TARGET OR ENABLE_WAYLAND_TARGET))
-message(FATAL_ERROR At least one of the following windowing targets must 
-be enabled and also supported by the GTK+ dependency: X11, Wayland)
+if (NOT(${GTK3_VERSION} VERSION_LESS 3.14.0))
+set(GTK3_SUPPORTS_GESTURES ON)
+else ()
+set(GTK3_SUPPORTS_GESTURES OFF)
+endif ()
 endif ()
 
-if (GTK3_VERSION AND VERSION_OK AND NOT(${GTK3_VERSION} VERSION_LESS 3.14.0))
-set(GTK_SUPPORTS_GESTURES ON)
-else ()
-set(GTK_SUPPORTS_GESTURES OFF)
-endif ()
-
 include(FindPackageHandleStandardArgs)
 FIND_PACKAGE_HANDLE_STANDARD_ARGS(GTK3 DEFAULT_MSG GTK3_INCLUDE_DIRS GTK3_LIBRARIES VERSION_OK)


Modified: trunk/Source/cmake/OptionsGTK.cmake (185787 => 185788)

--- trunk/Source/cmake/OptionsGTK.cmake	2015-06-20 01:46:17 UTC (rev 185787)
+++ trunk/Source/cmake/OptionsGTK.cmake	2015-06-20 02:41:09 UTC (rev 185788)
@@ -237,8 +237,8 @@
 set(GDK_LIBRARIES ${GDK3_LIBRARIES})
 set(GDK_INCLUDE_DIRS ${GDK3_INCLUDE_DIRS})
 
+SET_AND_EXPOSE_TO_BUILD(HAVE_GTK_GESTURES ${GTK3_SUPPORTS_GESTURES})
 SET_AND_EXPOSE_TO_BUILD(HAVE_GTK_UNIX_PRINTING ${GTK_UNIX_PRINT_FOUND})
-SET_AND_EXPOSE_TO_BUILD(HAVE_GTK_GESTURES ${GTK_SUPPORTS_GESTURES})
 
 set(glib_components gio gobject gthread gmodule)
 if (ENABLE_GAMEPAD_DEPRECATED OR ENABLE_GEOLOCATION)
@@ -378,6 +378,10 @@
 endif ()
 
 if (ENABLE_X11_TARGET)
+if (NOT GTK3_SUPPORTS_X11)
+

[webkit-changes] [185795] trunk/Source/WebKit2

[mcatanzaro]

Title: [185795] trunk/Source/WebKit2








Revision 185795
Author mcatanz...@igalia.com
Date 2015-06-20 09:06:23 -0700 (Sat, 20 Jun 2015)


Log Message
Check for SHA1 certificates ignores subresources
https://bugs.webkit.org/show_bug.cgi?id=146159

Reviewed by Dan Bernstein.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame): Call
PageLoadState::didDisplayOrRunInsecureContent if a certificate chain contains a non-root
SHA1 certificate when the frame is not the main frame.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (185794 => 185795)

--- trunk/Source/WebKit2/ChangeLog	2015-06-20 15:57:03 UTC (rev 185794)
+++ trunk/Source/WebKit2/ChangeLog	2015-06-20 16:06:23 UTC (rev 185795)
@@ -1,3 +1,15 @@
+2015-06-20  Michael Catanzaro  mcatanz...@igalia.com
+
+Check for SHA1 certificates ignores subresources
+https://bugs.webkit.org/show_bug.cgi?id=146159
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didCommitLoadForFrame): Call
+PageLoadState::didDisplayOrRunInsecureContent if a certificate chain contains a non-root
+SHA1 certificate when the frame is not the main frame.
+
 2015-06-20  Dan Bernstein  m...@apple.com
 
 Added availability information to a recently-added delegate method.


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (185794 => 185795)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2015-06-20 15:57:03 UTC (rev 185794)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2015-06-20 16:06:23 UTC (rev 185795)
@@ -2941,12 +2941,12 @@
 #endif
 
 auto transaction = m_pageLoadState.transaction();
+bool markPageInsecure = m_treatsSHA1CertificatesAsInsecure  certificateInfo.containsNonRootSHA1SignedCertificate();
+if (frame-isMainFrame())
+m_pageLoadState.didCommitLoad(transaction, markPageInsecure);
+else if (markPageInsecure)
+m_pageLoadState.didDisplayOrRunInsecureContent(transaction);
 
-if (frame-isMainFrame()) {
-bool hasInsecureCertificateChain = m_treatsSHA1CertificatesAsInsecure  certificateInfo.containsNonRootSHA1SignedCertificate();
-m_pageLoadState.didCommitLoad(transaction, hasInsecureCertificateChain);
-}
-
 #if USE(APPKIT)
 // FIXME (bug 59111): didCommitLoadForFrame comes too late when restoring a page from b/f cache, making us disable secure event mode in password fields.
 // FIXME: A load going on in one frame shouldn't affect text editing in other frames on the page.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185801] trunk/Tools

[mcatanzaro]

Title: [185801] trunk/Tools








Revision 185801
Author mcatanz...@igalia.com
Date 2015-06-20 15:50:58 -0700 (Sat, 20 Jun 2015)


Log Message
[GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=146186

Reviewed by Martin Robinson.

Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)

* MiniBrowser/gtk/CMakeLists.txt:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/CMakeLists.txt




Diff

Modified: trunk/Tools/ChangeLog (185800 => 185801)

--- trunk/Tools/ChangeLog	2015-06-20 22:47:39 UTC (rev 185800)
+++ trunk/Tools/ChangeLog	2015-06-20 22:50:58 UTC (rev 185801)
@@ -1,3 +1,15 @@
+2015-06-20  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=146186
+
+Reviewed by Martin Robinson.
+
+Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
+deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
+
+* MiniBrowser/gtk/CMakeLists.txt:
+
 2015-06-19  Ryosuke Niwa  rn...@webkit.org
 
 Build fix after r146125.


Modified: trunk/Tools/MiniBrowser/gtk/CMakeLists.txt (185800 => 185801)

--- trunk/Tools/MiniBrowser/gtk/CMakeLists.txt	2015-06-20 22:47:39 UTC (rev 185800)
+++ trunk/Tools/MiniBrowser/gtk/CMakeLists.txt	2015-06-20 22:50:58 UTC (rev 185801)
@@ -49,9 +49,11 @@
 add_definitions(-DWEBKIT_INJECTED_BUNDLE_PATH=${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
 endif ()
 
+add_definitions(-DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6)
+
 include_directories(${MiniBrowser_INCLUDE_DIRECTORIES})
 add_executable(MiniBrowser ${MiniBrowser_SOURCES})
 target_link_libraries(MiniBrowser ${MiniBrowser_LIBRARIES})
 set_target_properties(MiniBrowser PROPERTIES FOLDER Tools)
 
-install(TARGETS MiniBrowser DESTINATION ${EXEC_INSTALL_DIR})
\ No newline at end of file
+install(TARGETS MiniBrowser DESTINATION ${EXEC_INSTALL_DIR})






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [185896] trunk/Source/WebKit2

[mcatanzaro]

Title: [185896] trunk/Source/WebKit2








Revision 185896
Author mcatanz...@igalia.com
Date 2015-06-23 19:04:38 -0700 (Tue, 23 Jun 2015)


Log Message
[GTK] Crash performing drag-and-drop
https://bugs.webkit.org/show_bug.cgi?id=146267

Reviewed by Darin Adler.

Return early if gtk_get_current_event() returns null to avoid a crash. Note that this does
not fix drag-and-drop. Note also this prevents the web process from forcing the UI process
to crash by sending fake startDrag messages.

* UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::startDrag):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/gtk/DragAndDropHandler.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (185895 => 185896)

--- trunk/Source/WebKit2/ChangeLog	2015-06-24 02:00:52 UTC (rev 185895)
+++ trunk/Source/WebKit2/ChangeLog	2015-06-24 02:04:38 UTC (rev 185896)
@@ -1,3 +1,17 @@
+2015-06-23  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] Crash performing drag-and-drop
+https://bugs.webkit.org/show_bug.cgi?id=146267
+
+Reviewed by Darin Adler.
+
+Return early if gtk_get_current_event() returns null to avoid a crash. Note that this does
+not fix drag-and-drop. Note also this prevents the web process from forcing the UI process
+to crash by sending fake startDrag messages.
+
+* UIProcess/gtk/DragAndDropHandler.cpp:
+(WebKit::DragAndDropHandler::startDrag):
+
 2015-06-23  Anders Carlsson  ander...@apple.com
 
 Add a class that tracks whether we're a background or foreground application


Modified: trunk/Source/WebKit2/UIProcess/gtk/DragAndDropHandler.cpp (185895 => 185896)

--- trunk/Source/WebKit2/UIProcess/gtk/DragAndDropHandler.cpp	2015-06-24 02:00:52 UTC (rev 185895)
+++ trunk/Source/WebKit2/UIProcess/gtk/DragAndDropHandler.cpp	2015-06-24 02:04:38 UTC (rev 185896)
@@ -114,6 +114,9 @@
 GRefPtrGtkTargetList targetList = adoptGRef(PasteboardHelper::defaultPasteboardHelper()-targetListForDataObject(dataObject.get()));
 GUniquePtrGdkEvent currentEvent(gtk_get_current_event());
 
+if (!currentEvent)
+return;
+
 GdkDragContext* context = gtk_drag_begin(m_page.viewWidget(), targetList.get(), dragOperationToGdkDragActions(dragData.draggingSourceOperationMask()),
 GDK_BUTTON_PRIMARY, currentEvent.get());
 m_draggingDataObjects.set(context, dataObject.get());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186176] trunk/Source/WebKit2

[mcatanzaro]

Title: [186176] trunk/Source/WebKit2








Revision 186176
Author mcatanz...@igalia.com
Date 2015-07-01 08:44:39 -0700 (Wed, 01 Jul 2015)


Log Message
[GTK] [Wayland] Build broken with ENABLE_WAYLAND_TARGET=ON
https://bugs.webkit.org/show_bug.cgi?id=146512

Unreviewed, fix build with ENABLE_WAYLAND_TARGET=ON after r185949.


* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreateWebPage):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (186175 => 186176)

--- trunk/Source/WebKit2/ChangeLog	2015-07-01 14:51:28 UTC (rev 186175)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-01 15:44:39 UTC (rev 186176)
@@ -1,3 +1,13 @@
+2015-07-01  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] [Wayland] Build broken with ENABLE_WAYLAND_TARGET=ON
+https://bugs.webkit.org/show_bug.cgi?id=146512
+
+Unreviewed, fix build with ENABLE_WAYLAND_TARGET=ON after r185949.
+
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseCreateWebPage):
+
 2015-06-30  Martin Robinson  mrobin...@igalia.com
 
 [GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (186175 => 186176)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp	2015-07-01 14:51:28 UTC (rev 186175)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp	2015-07-01 15:44:39 UTC (rev 186176)
@@ -1100,7 +1100,7 @@
 // FIXME: Accelerated compositing under Wayland is not yet supported.
 // https://bugs.webkit.org/show_bug.cgi?id=115803
 if (PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland)
-preferences-setAcceleratedCompositingEnabled(false);
+configuration.preferences-setAcceleratedCompositingEnabled(false);
 #endif
 
 priv-pageProxy = context-createWebPage(*priv-pageClient, WTF::move(configuration));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188826] trunk

[mcatanzaro]

Title: [188826] trunk








Revision 188826
Author mcatanz...@igalia.com
Date 2015-08-22 11:38:29 -0700 (Sat, 22 Aug 2015)


Log Message
Unreviewed, attempt to fix GTK build after r188718

Source/WebKit2:

* CMakeLists.txt: Build WKPageConfigurationRef.cpp
* PlatformEfl.cmake: Don't build WKPageConfigurationRef.cpp

Tools:

* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::PlatformWebView):

Modified Paths

trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp




Diff

Modified: trunk/Source/WebKit2/CMakeLists.txt (188825 => 188826)

--- trunk/Source/WebKit2/CMakeLists.txt	2015-08-22 18:35:47 UTC (rev 188825)
+++ trunk/Source/WebKit2/CMakeLists.txt	2015-08-22 18:38:29 UTC (rev 188826)
@@ -440,6 +440,7 @@
 UIProcess/API/C/WKOpenPanelResultListener.cpp
 UIProcess/API/C/WKOriginDataManager.cpp
 UIProcess/API/C/WKPage.cpp
+UIProcess/API/C/WKPageConfigurationRef.cpp
 UIProcess/API/C/WKPageGroup.cpp
 UIProcess/API/C/WKPluginSiteDataManager.cpp
 UIProcess/API/C/WKPreferences.cpp


Modified: trunk/Source/WebKit2/ChangeLog (188825 => 188826)

--- trunk/Source/WebKit2/ChangeLog	2015-08-22 18:35:47 UTC (rev 188825)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-22 18:38:29 UTC (rev 188826)
@@ -1,3 +1,10 @@
+2015-08-22  Michael Catanzaro  mcatanz...@igalia.com
+
+Unreviewed, attempt to fix GTK build after r188718
+
+* CMakeLists.txt: Build WKPageConfigurationRef.cpp
+* PlatformEfl.cmake: Don't build WKPageConfigurationRef.cpp
+
 2015-08-22  Antti Koivisto  an...@apple.com
 
 Decode data URLs in web process


Modified: trunk/Source/WebKit2/PlatformEfl.cmake (188825 => 188826)

--- trunk/Source/WebKit2/PlatformEfl.cmake	2015-08-22 18:35:47 UTC (rev 188825)
+++ trunk/Source/WebKit2/PlatformEfl.cmake	2015-08-22 18:38:29 UTC (rev 188826)
@@ -65,8 +65,6 @@
 UIProcess/BackingStore.cpp
 UIProcess/DefaultUndoController.cpp
 
-UIProcess/API/C/WKPageConfigurationRef.cpp
-
 UIProcess/API/C/CoordinatedGraphics/WKView.cpp
 
 UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp


Modified: trunk/Tools/ChangeLog (188825 => 188826)

--- trunk/Tools/ChangeLog	2015-08-22 18:35:47 UTC (rev 188825)
+++ trunk/Tools/ChangeLog	2015-08-22 18:38:29 UTC (rev 188826)
@@ -1,3 +1,10 @@
+2015-08-22  Michael Catanzaro  mcatanz...@igalia.com
+
+Unreviewed, attempt to fix GTK build after r188718
+
+* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
+(WTR::PlatformWebView::PlatformWebView):
+
 2015-08-21  Commit Queue  commit-qu...@webkit.org
 
 Unreviewed, rolling out r188807, r188813, and r188815.


Modified: trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp (188825 => 188826)

--- trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp	2015-08-22 18:35:47 UTC (rev 188825)
+++ trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp	2015-08-22 18:38:29 UTC (rev 188826)
@@ -29,14 +29,15 @@
 #include PlatformWebView.h
 
 #include WebKit/WKImageCairo.h
+#include WebKit/WKPageConfigurationRef.h
 #include WebKit/WKViewPrivate.h
 #include gtk/gtk.h
 #include wtf/Assertions.h
 
 namespace WTR {
 
-PlatformWebView::PlatformWebView(WKContextRef context, WKPageGroupRef pageGroup, WKPageRef relatedPage, const ViewOptions options)
-: m_view(WKViewCreate(context, pageGroup, relatedPage))
+PlatformWebView::PlatformWebView(WKPageConfigurationRef configuration, const ViewOptions options)
+: m_view(WKViewCreate(WKPageConfigurationGetContext(configuration), WKPageConfigurationGetPageGroup(configuration), WKPageConfigurationGetRelatedPage(configuration)))
 , m_window(gtk_window_new(GTK_WINDOW_POPUP))
 , m_windowIsKey(true)
 , m_options(options)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188859] trunk/Source/WebCore

[mcatanzaro]

Title: [188859] trunk/Source/WebCore








Revision 188859
Author mcatanz...@igalia.com
Date 2015-08-24 06:39:11 -0700 (Mon, 24 Aug 2015)


Log Message
Unreviewed, fix typo in a comment (unsused - unused)

* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (188858 => 188859)

--- trunk/Source/WebCore/ChangeLog	2015-08-24 13:23:45 UTC (rev 188858)
+++ trunk/Source/WebCore/ChangeLog	2015-08-24 13:39:11 UTC (rev 188859)
@@ -1,3 +1,10 @@
+2015-08-24  Michael Catanzaro  mcatanz...@igalia.com
+
+Unreviewed, fix typo in a comment (unsused - unused)
+
+* bindings/scripts/CodeGeneratorGObject.pm:
+(GenerateFunction):
+
 2015-08-24  Carlos Garcia Campos  cgar...@igalia.com
 
 Unreviewed. Fix cairo performance regression introduced in r188379.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (188858 => 188859)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm	2015-08-24 13:23:45 UTC (rev 188858)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm	2015-08-24 13:39:11 UTC (rev 188859)
@@ -1036,7 +1036,7 @@
 
 # If a method used to raise an exception, but was changed to not raise it anymore, the
 # API changes because we use a explicit GError parameter to handle the exceptions.
-# In this case, it's better to keep the GError parameter even if it's unsused to keep
+# In this case, it's better to keep the GError parameter even if it's unused to keep
 # the API compatibility.
 my $usedToRaiseException = FunctionUsedToRaiseException($functionName);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188823] trunk/Source/WebCore

[mcatanzaro]

Title: [188823] trunk/Source/WebCore








Revision 188823
Author mcatanz...@igalia.com
Date 2015-08-22 10:42:46 -0700 (Sat, 22 Aug 2015)


Log Message
Unreviewed, fix build without ENABLE_CSS_GRID_LAYOUT after r188582

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (188822 => 188823)

--- trunk/Source/WebCore/ChangeLog	2015-08-22 17:14:22 UTC (rev 188822)
+++ trunk/Source/WebCore/ChangeLog	2015-08-22 17:42:46 UTC (rev 188823)
@@ -1,3 +1,10 @@
+2015-08-22  Michael Catanzaro  mcatanz...@igalia.com
+
+Unreviewed, fix build without ENABLE_CSS_GRID_LAYOUT after r188582
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::computeLogicalWidthInRegion):
+
 2015-08-22  Zalan Bujtas  za...@apple.com
 
 Page::renderTreeSize() does not include anonymous renderers.


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (188822 => 188823)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2015-08-22 17:14:22 UTC (rev 188822)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2015-08-22 17:42:46 UTC (rev 188823)
@@ -2338,7 +2338,11 @@
 // width.  Use the width from the style context.
 // FIXME: Account for block-flow in flexible boxes.
 // https://bugs.webkit.org/show_bug.cgi?id=46418
-if (hasOverrideLogicalContentWidth()  (isRubyRun() || style().borderFit() == BorderFitLines || (parent()-isFlexibleBoxIncludingDeprecated() || parent()-isRenderGrid( {
+if (hasOverrideLogicalContentWidth()  (isRubyRun() || style().borderFit() == BorderFitLines || (parent()-isFlexibleBoxIncludingDeprecated()
+#if ENABLE(CSS_GRID_LAYOUT)
+|| parent()-isRenderGrid()
+#endif
+))) {
 computedValues.m_extent = overrideLogicalContentWidth() + borderAndPaddingLogicalWidth();
 return;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [187547] trunk/Source/WebKit2

[mcatanzaro]

Title: [187547] trunk/Source/WebKit2








Revision 187547
Author mcatanz...@igalia.com
Date 2015-07-29 08:52:27 -0700 (Wed, 29 Jul 2015)


Log Message
[Seccomp] Further improvements to default web process policy
https://bugs.webkit.org/show_bug.cgi?id=142987

Provide various helper functions to allow more flexible construction of
filesystem access policies.

Reviewed by Žan Doberšek.

Improve the policy. Also, remove ifdefs to reduce potential for breakage in non-default
configurations.

* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (187546 => 187547)

--- trunk/Source/WebKit2/ChangeLog	2015-07-29 14:30:50 UTC (rev 187546)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-29 15:52:27 UTC (rev 187547)
@@ -1,3 +1,19 @@
+2015-07-29  Michael Catanzaro  mcatanz...@igalia.com
+
+[Seccomp] Further improvements to default web process policy
+https://bugs.webkit.org/show_bug.cgi?id=142987
+
+Provide various helper functions to allow more flexible construction of
+filesystem access policies.
+
+Reviewed by Žan Doberšek.
+
+Improve the policy. Also, remove ifdefs to reduce potential for breakage in non-default
+configurations.
+
+* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
+(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):
+
 2015-07-29  Chris Dumez  cdu...@apple.com
 
 Avoid unnecessarily constructing PlatformMediaSessionManager on Document destruction


Modified: trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp (187546 => 187547)

--- trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp	2015-07-29 14:30:50 UTC (rev 187546)
+++ trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp	2015-07-29 15:52:27 UTC (rev 187547)
@@ -30,6 +30,7 @@
 
 #include PluginSearchPath.h
 #include WebProcessCreationParameters.h
+#include XDGBaseDirectory.h
 #include libgen.h
 #include string.h
 #include sys/stat.h
@@ -151,30 +152,30 @@
 // file unless white listed bellow or by platform.
 addDirectoryPermission(ASCIILiteral(/), NotAllowed);
 
-// Shared libraries, plugins and fonts.
+// System library directories
 addDirectoryPermission(ASCIILiteral(/lib), Read);
 addDirectoryPermission(ASCIILiteral(/lib32), Read);
 addDirectoryPermission(ASCIILiteral(/lib64), Read);
 addDirectoryPermission(ASCIILiteral(/usr/lib), Read);
 addDirectoryPermission(ASCIILiteral(/usr/lib32), Read);
 addDirectoryPermission(ASCIILiteral(/usr/lib64), Read);
+addDirectoryPermission(ASCIILiteral(/usr/local/lib), Read);
+addDirectoryPermission(ASCIILiteral(/usr/local/lib32), Read);
+addDirectoryPermission(ASCIILiteral(/usr/local/lib64), Read);
+addDirectoryPermission(ASCIILiteral(LIBDIR), Read);
+
+// System data directories
 addDirectoryPermission(ASCIILiteral(/usr/share), Read);
-
-// Support for alternative install prefixes, e.g. /usr/local.
+addDirectoryPermission(ASCIILiteral(/usr/local/share), Read);
 addDirectoryPermission(ASCIILiteral(DATADIR), Read);
-addDirectoryPermission(ASCIILiteral(LIBDIR), Read);
 
-// Plugin search path
+// NPAPI plugins
 for (String path : pluginsDirectories())
 addDirectoryPermission(path, Read);
 
 // SSL Certificates.
 addDirectoryPermission(ASCIILiteral(/etc/ssl/certs), Read);
 
-// Fontconfig cache.
-addDirectoryPermission(ASCIILiteral(/etc/fonts), Read);
-addDirectoryPermission(ASCIILiteral(/var/cache/fontconfig), Read);
-
 // Audio devices, random number generators, etc.
 addDirectoryPermission(ASCIILiteral(/dev), ReadAndWrite);
 
@@ -220,56 +221,61 @@
 // FIXME This is too permissive: https://bugs.webkit.org/show_bug.cgi?id=143004
 addDirectoryPermission(/run/user/ + String::number(getuid()), ReadAndWrite);
 
-// Needed by WebKit's memory pressure handler
+// Needed by WebKit's memory pressure handler.
 addFilePermission(ASCIILiteral(/sys/fs/cgroup/memory/memory.pressure_level), Read);
 addFilePermission(ASCIILiteral(/sys/fs/cgroup/memory/cgroup.event_control), Read);
 
-char* homeDir = getenv(HOME);
-if (homeDir) {
-// X11 connection token.
-addFilePermission(String::fromUTF8(homeDir) + /.Xauthority, Read);
-}
+// X11 connection token.
+addFilePermission(userHomeDirectory() + /.Xauthority, Read);
 
 // MIME type resolution.
-char* dataHomeDir = getenv(XDG_DATA_HOME);
-if (dataHomeDir)
-addDirectoryPermission(String::fromUTF8(dataHomeDir) + /mime, Read);
-else if (homeDir)
-addDirectoryPermission(String::fromUTF8(homeDir) + /.local/share/mime, Read);
+addDirectoryPermission(userDataDirectory() + /mime, Read);
 
-#if ENABLE(WEBGL) || 

[webkit-changes] [187532] trunk/Source/WebCore

[mcatanzaro]

Title: [187532] trunk/Source/WebCore








Revision 187532
Author mcatanz...@igalia.com
Date 2015-07-28 17:57:00 -0700 (Tue, 28 Jul 2015)


Log Message
Minor cleanups in FontCacheFreeType.cpp
https://bugs.webkit.org/show_bug.cgi?id=147392

Reviewed by Martin Robinson.

Mark several functions as static (file-scope), use more nullptr, and use more smart
pointers. No behavior changes.

* platform/graphics/freetype/FcUniquePtr.h:
(WebCore::FcPtrDeleterFcCharSet::operator()):
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::createFontConfigPatternForCharacters):
(WebCore::findBestFontGivenFallbacks):
(WebCore::FontCache::systemFallbackForCharacters):
(WebCore::fontWeightToFontconfigWeight):
(WebCore::FontCache::createFontPlatformData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/freetype/FcUniquePtr.h
trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (187531 => 187532)

--- trunk/Source/WebCore/ChangeLog	2015-07-29 00:55:17 UTC (rev 187531)
+++ trunk/Source/WebCore/ChangeLog	2015-07-29 00:57:00 UTC (rev 187532)
@@ -1,3 +1,22 @@
+2015-07-28  Michael Catanzaro  mcatanz...@igalia.com
+
+Minor cleanups in FontCacheFreeType.cpp
+https://bugs.webkit.org/show_bug.cgi?id=147392
+
+Reviewed by Martin Robinson.
+
+Mark several functions as static (file-scope), use more nullptr, and use more smart
+pointers. No behavior changes.
+
+* platform/graphics/freetype/FcUniquePtr.h:
+(WebCore::FcPtrDeleterFcCharSet::operator()):
+* platform/graphics/freetype/FontCacheFreeType.cpp:
+(WebCore::createFontConfigPatternForCharacters):
+(WebCore::findBestFontGivenFallbacks):
+(WebCore::FontCache::systemFallbackForCharacters):
+(WebCore::fontWeightToFontconfigWeight):
+(WebCore::FontCache::createFontPlatformData):
+
 2015-07-28  Yusuke Suzuki  utatane@gmail.com
 
 [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value false


Modified: trunk/Source/WebCore/platform/graphics/freetype/FcUniquePtr.h (187531 => 187532)

--- trunk/Source/WebCore/platform/graphics/freetype/FcUniquePtr.h	2015-07-29 00:55:17 UTC (rev 187531)
+++ trunk/Source/WebCore/platform/graphics/freetype/FcUniquePtr.h	2015-07-29 00:57:00 UTC (rev 187532)
@@ -41,6 +41,13 @@
 templatetypename T
 using FcUniquePtr = std::unique_ptrT, FcPtrDeleterT;
 
+template struct FcPtrDeleterFcCharSet {
+void operator()(FcCharSet* ptr) const
+{
+FcCharSetDestroy(ptr);
+}
+};
+
 template struct FcPtrDeleterFcFontSet {
 void operator()(FcFontSet* ptr) const
 {


Modified: trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp (187531 => 187532)

--- trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp	2015-07-29 00:55:17 UTC (rev 187531)
+++ trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp	2015-07-29 00:57:00 UTC (rev 187532)
@@ -41,60 +41,59 @@
 ASSERT_NOT_REACHED();
 }
 
-FcPattern* createFontConfigPatternForCharacters(const UChar* characters, int bufferLength)
+static RefPtrFcPattern createFontConfigPatternForCharacters(const UChar* characters, int bufferLength)
 {
-FcPattern* pattern = FcPatternCreate();
-FcCharSet* fontConfigCharSet = FcCharSetCreate();
+RefPtrFcPattern pattern = adoptRef(FcPatternCreate());
+FcUniquePtrFcCharSet fontConfigCharSet(FcCharSetCreate());
 
 UTF16UChar32Iterator iterator(characters, bufferLength);
 UChar32 character = iterator.next();
 while (character != iterator.end()) {
-FcCharSetAddChar(fontConfigCharSet, character);
+FcCharSetAddChar(fontConfigCharSet.get(), character);
 character = iterator.next();
 }
 
-FcPatternAddCharSet(pattern, FC_CHARSET, fontConfigCharSet);
-FcCharSetDestroy(fontConfigCharSet);
+FcPatternAddCharSet(pattern.get(), FC_CHARSET, fontConfigCharSet.get());
 
-FcPatternAddBool(pattern, FC_SCALABLE, FcTrue);
-FcConfigSubstitute(0, pattern, FcMatchPattern);
-FcDefaultSubstitute(pattern);
+FcPatternAddBool(pattern.get(), FC_SCALABLE, FcTrue);
+FcConfigSubstitute(nullptr, pattern.get(), FcMatchPattern);
+FcDefaultSubstitute(pattern.get());
 return pattern;
 }
 
-FcPattern* findBestFontGivenFallbacks(const FontPlatformData fontData, FcPattern* pattern)
+static RefPtrFcPattern findBestFontGivenFallbacks(const FontPlatformData fontData, FcPattern* pattern)
 {
 if (!fontData.m_pattern)
-return 0;
+return nullptr;
 
 if (!fontData.m_fallbacks) {
 FcResult fontConfigResult;
-fontData.m_fallbacks = FcFontSort(0, fontData.m_pattern.get(), FcTrue, 0, fontConfigResult);
+fontData.m_fallbacks = FcFontSort(nullptr, fontData.m_pattern.get(), FcTrue, nullptr, fontConfigResult);
 }
 
 if (!fontData.m_fallbacks)
-return 0;
+return nullptr;
 
 

[webkit-changes] [187527] trunk

[mcatanzaro]

Title: [187527] trunk








Revision 187527
Author mcatanz...@igalia.com
Date 2015-07-28 16:37:10 -0700 (Tue, 28 Jul 2015)


Log Message
[Freetype] Always allow font matching for strong aliases
https://bugs.webkit.org/show_bug.cgi?id=147057

Reviewed by Martin Robinson.

Source/WebCore:

Tests: platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html
   platform/gtk/fonts/font-family-fallback-respects-strong-aliases.html

Treat fonts that are strongly-aliased to each other as if they were identical for the
purposes of CSS font fallback. This improves the layout of many web pages by allowing
fontconfig to replace fonts with metric-compatible equivalents (e.g. Arial - Liberation
Sans) instead of rejecting the metric-compatible font as unsuitable.

* platform/graphics/cairo/RefPtrCairo.cpp:
(WTF::refIfNotNull):
(WTF::derefIfNotNull):
* platform/graphics/cairo/RefPtrCairo.h:
* platform/graphics/freetype/FcUniquePtr.h: Added.
(WebCore::FcPtrDeleterFcFontSet::operator()):
(WebCore::FcPtrDeleterFcLangSet::operator()):
(WebCore::FcPtrDeleterFcObjectSet::operator()):
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::strengthOfFirstAlias):
(WebCore::strongAliasesForFamily):
(WebCore::areStronglyAliased):
(WebCore::FontCache::createFontPlatformData):

Tools:

Create family aliases needed for the new layout tests.

* WebKitTestRunner/gtk/fonts/fonts.conf:

LayoutTests:

* platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html: Added.
* platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html: Added.
* platform/gtk/fonts/font-family-fallback-respects-strong-aliases-expected.html: Added.
* platform/gtk/fonts/font-family-fallback-respects-strong-aliases.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/RefPtrCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/RefPtrCairo.h
trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/gtk/fonts/fonts.conf


Added Paths

trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html
trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html
trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-respects-strong-aliases-expected.html
trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-respects-strong-aliases.html
trunk/Source/WebCore/platform/graphics/freetype/FcUniquePtr.h




Diff

Modified: trunk/LayoutTests/ChangeLog (187526 => 187527)

--- trunk/LayoutTests/ChangeLog	2015-07-28 23:21:15 UTC (rev 187526)
+++ trunk/LayoutTests/ChangeLog	2015-07-28 23:37:10 UTC (rev 187527)
@@ -1,3 +1,15 @@
+2015-07-28  Michael Catanzaro  mcatanz...@igalia.com
+
+[Freetype] Always allow font matching for strong aliases
+https://bugs.webkit.org/show_bug.cgi?id=147057
+
+Reviewed by Martin Robinson.
+
+* platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html: Added.
+* platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html: Added.
+* platform/gtk/fonts/font-family-fallback-respects-strong-aliases-expected.html: Added.
+* platform/gtk/fonts/font-family-fallback-respects-strong-aliases.html: Added.
+
 2015-07-28  Myles C. Maxfield  mmaxfi...@apple.com
 
 [iOS] Crash when encountering characters whose natural font is one we can't look up


Added: trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html (0 => 187527)

--- trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html	2015-07-28 23:37:10 UTC (rev 187527)
@@ -0,0 +1,5 @@
+body style=font-family:serif;
+This test ensures that if a font is weakly aliased to another, the alias is
+ignored for the purposes of CSS font fallback. This test passes if it is
+displayed in a serif font and fails if it is displayed in FreeMono.
+/body


Added: trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html (0 => 187527)

--- trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html	2015-07-28 23:37:10 UTC (rev 187527)
@@ -0,0 +1,5 @@
+body style=font-family:FamilyWeakAliasedToFreeMono,serif;
+This test ensures that if a font is weakly aliased to another, the alias is
+ignored for the purposes of CSS font fallback. This test passes if it is
+displayed in a serif font and fails if it is displayed in FreeMono.
+/body


Added: trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-respects-strong-aliases-expected.html (0 => 187527)

--- trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-respects-strong-aliases-expected.html	   

[webkit-changes] [187583] trunk

[mcatanzaro]

Title: [187583] trunk








Revision 187583
Author mcatanz...@igalia.com
Date 2015-07-30 07:51:09 -0700 (Thu, 30 Jul 2015)


Log Message
Web Inspector: [Freetype] Allow inspector to retrieve a list of system fonts
https://bugs.webkit.org/show_bug.cgi?id=147018

Reviewed by Carlos Garcia Campos.

Source/WebCore:

No new tests; unskipped inspector/css/get-system-fonts.html

* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::patternToFamilies): Added.
(WebCore::FontCache::systemFontFamilies): Implemented.
(WebCore::strongAliasesForFamily): Split some code off to patternToFamilies.

LayoutTests:

* inspector/css/get-system-fonts-expected.txt: Expect some free fonts to be missing
* inspector/css/get-system-fonts.html: Check for some free fonts.
* platform/gtk/TestExpectations: Unskip the test.
* platform/gtk/inspector/css/get-system-fonts-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/css/get-system-fonts-expected.txt
trunk/LayoutTests/inspector/css/get-system-fonts.html
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp


Added Paths

trunk/LayoutTests/platform/gtk/inspector/css/
trunk/LayoutTests/platform/gtk/inspector/css/get-system-fonts-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (187582 => 187583)

--- trunk/LayoutTests/ChangeLog	2015-07-30 11:10:38 UTC (rev 187582)
+++ trunk/LayoutTests/ChangeLog	2015-07-30 14:51:09 UTC (rev 187583)
@@ -1,3 +1,15 @@
+2015-07-30  Michael Catanzaro  mcatanz...@igalia.com
+
+Web Inspector: [Freetype] Allow inspector to retrieve a list of system fonts
+https://bugs.webkit.org/show_bug.cgi?id=147018
+
+Reviewed by Carlos Garcia Campos.
+
+* inspector/css/get-system-fonts-expected.txt: Expect some free fonts to be missing
+* inspector/css/get-system-fonts.html: Check for some free fonts.
+* platform/gtk/TestExpectations: Unskip the test.
+* platform/gtk/inspector/css/get-system-fonts-expected.txt: Added.
+
 2015-07-30  Nan Wang  n_w...@apple.com
 
 AX: VoiceOver unable to access content in malformed trees


Modified: trunk/LayoutTests/inspector/css/get-system-fonts-expected.txt (187582 => 187583)

--- trunk/LayoutTests/inspector/css/get-system-fonts-expected.txt	2015-07-30 11:10:38 UTC (rev 187582)
+++ trunk/LayoutTests/inspector/css/get-system-fonts-expected.txt	2015-07-30 14:51:09 UTC (rev 187583)
@@ -1,4 +1,7 @@
-Has at least 5 fonts: true
-PASS: Includes Arial
-PASS: Includes Times
+This test ensures that the inspector can enumerate system font families, and checks for the existance of common fonts.
 
+Includes Arial
+Includes Times
+Missing DejaVu Sans
+Missing Liberation Serif
+


Modified: trunk/LayoutTests/inspector/css/get-system-fonts.html (187582 => 187583)

--- trunk/LayoutTests/inspector/css/get-system-fonts.html	2015-07-30 11:10:38 UTC (rev 187582)
+++ trunk/LayoutTests/inspector/css/get-system-fonts.html	2015-07-30 14:51:09 UTC (rev 187583)
@@ -3,19 +3,22 @@
 head
 script type=text/_javascript_ src=""
 script
-// Testing that we can get the fonts on the system and that the fonts contain some universal fonts (arial, times, etc).
 function test() {
 function hasFontFamily(fontFamilies, fontFamily) {
-return (fontFamilies.includes(fontFamily) ? PASS: Includes  : FAIL: Missing ) + fontFamily;
+return (fontFamilies.includes(fontFamily) ? Includes  : Missing ) + fontFamily;
 }
 
 function fontFamilyNamesCallback(error, fontFamilyNames) {
 InspectorTest.assert(!error, Error in getting font family names.);
 
 if (!error) {
-InspectorTest.log(Has at least 5 fonts:  + (fontFamilyNames.length = 5));
+InspectorTest.assert(fontFamilyNames.length = 5, Has at least 5 fonts);
+// We can't count on any font existing on every platform, so we list enough fonts here
+// such that at least one will exist. Update your port's test expectations as needed.
 InspectorTest.log(hasFontFamily(fontFamilyNames, Arial));
 InspectorTest.log(hasFontFamily(fontFamilyNames, Times));
+InspectorTest.log(hasFontFamily(fontFamilyNames, DejaVu Sans));
+InspectorTest.log(hasFontFamily(fontFamilyNames, Liberation Serif));
 }
 
 InspectorTest.completeTest();
@@ -24,5 +27,8 @@
 }
 /script
 /head
-body _onload_=runTest()/body
+body _onload_=runTest()
+  pThis test ensures that the inspector can enumerate system font families, and checks for the
+ existance of common fonts./p
+/body
 /html


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (187582 => 187583)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-07-30 11:10:38 UTC (rev 187582)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-07-30 14:51:09 UTC (rev 187583)
@@ -1319,7 +1319,6 @@
 
 webkit.org/b/139362 

[webkit-changes] [187541] trunk/Tools

[mcatanzaro]

Title: [187541] trunk/Tools








Revision 187541
Author mcatanz...@igalia.com
Date 2015-07-28 23:47:12 -0700 (Tue, 28 Jul 2015)


Log Message
[GTK] Missing casts in BrowserWindow.c
https://bugs.webkit.org/show_bug.cgi?id=147395

Reviewed by Carlos Garcia Campos.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowSetupEditorToolbar):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c




Diff

Modified: trunk/Tools/ChangeLog (187540 => 187541)

--- trunk/Tools/ChangeLog	2015-07-29 06:41:02 UTC (rev 187540)
+++ trunk/Tools/ChangeLog	2015-07-29 06:47:12 UTC (rev 187541)
@@ -1,3 +1,13 @@
+2015-07-28  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] Missing casts in BrowserWindow.c
+https://bugs.webkit.org/show_bug.cgi?id=147395
+
+Reviewed by Carlos Garcia Campos.
+
+* MiniBrowser/gtk/BrowserWindow.c:
+(browserWindowSetupEditorToolbar):
+
 2015-07-28  Yusuke Suzuki  utatane@gmail.com
 
 [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value false


Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (187540 => 187541)

--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2015-07-29 06:41:02 UTC (rev 187540)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2015-07-29 06:47:12 UTC (rev 187541)
@@ -814,21 +814,21 @@
 gtk_toolbar_set_style(GTK_TOOLBAR(toolbar), GTK_TOOLBAR_BOTH_HORIZ);
 
 GtkToolItem *item = gtk_toggle_tool_button_new_from_stock(GTK_STOCK_BOLD);
-window-boldItem = item;
+window-boldItem = GTK_WIDGET(item);
 gtk_widget_set_name(GTK_WIDGET(item), Bold);
 g_signal_connect(G_OBJECT(item), toggled, G_CALLBACK(editingCommandCallback), window);
 gtk_toolbar_insert(GTK_TOOLBAR(toolbar), item, -1);
 gtk_widget_show(GTK_WIDGET(item));
 
 item = gtk_toggle_tool_button_new_from_stock(GTK_STOCK_ITALIC);
-window-italicItem = item;
+window-italicItem = GTK_WIDGET(item);
 gtk_widget_set_name(GTK_WIDGET(item), Italic);
 g_signal_connect(G_OBJECT(item), toggled, G_CALLBACK(editingCommandCallback), window);
 gtk_toolbar_insert(GTK_TOOLBAR(toolbar), item, -1);
 gtk_widget_show(GTK_WIDGET(item));
 
 item = gtk_toggle_tool_button_new_from_stock(GTK_STOCK_UNDERLINE);
-window-underlineItem = item;
+window-underlineItem = GTK_WIDGET(item);
 gtk_widget_set_name(GTK_WIDGET(item), Underline);
 g_signal_connect(G_OBJECT(item), toggled, G_CALLBACK(editingCommandCallback), window);
 gtk_toolbar_insert(GTK_TOOLBAR(toolbar), item, -1);
@@ -836,7 +836,7 @@
 
 item = gtk_toggle_tool_button_new_from_stock(GTK_STOCK_STRIKETHROUGH);
 gtk_widget_set_name(GTK_WIDGET(item), Strikethrough);
-window-strikethroughItem = item;
+window-strikethroughItem = GTK_WIDGET(item);
 g_signal_connect(G_OBJECT(item), toggled, G_CALLBACK(editingCommandCallback), window);
 gtk_toolbar_insert(GTK_TOOLBAR(toolbar), item, -1);
 gtk_widget_show(GTK_WIDGET(item));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [187586] trunk/Source/WebCore

[mcatanzaro]

Title: [187586] trunk/Source/WebCore








Revision 187586
Author mcatanz...@igalia.com
Date 2015-07-30 09:21:45 -0700 (Thu, 30 Jul 2015)


Log Message
[GTK] Crashes when SoupSession is destroyed in exit handler
https://bugs.webkit.org/show_bug.cgi?id=145347

Reviewed by Carlos Garcia Campos.

Leak the default SoupSession with NeverDestroyed to avoid races at program exit.

* platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::defaultSession):
* platform/network/soup/SoupNetworkSession.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp
trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (187585 => 187586)

--- trunk/Source/WebCore/ChangeLog	2015-07-30 16:16:23 UTC (rev 187585)
+++ trunk/Source/WebCore/ChangeLog	2015-07-30 16:21:45 UTC (rev 187586)
@@ -1,3 +1,16 @@
+2015-07-30  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] Crashes when SoupSession is destroyed in exit handler
+https://bugs.webkit.org/show_bug.cgi?id=145347
+
+Reviewed by Carlos Garcia Campos.
+
+Leak the default SoupSession with NeverDestroyed to avoid races at program exit.
+
+* platform/network/soup/SoupNetworkSession.cpp:
+(WebCore::SoupNetworkSession::defaultSession):
+* platform/network/soup/SoupNetworkSession.h:
+
 2015-07-30  Alex Christensen  achristen...@webkit.org
 
 Build AppleWin port with CMake


Modified: trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp (187585 => 187586)

--- trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp	2015-07-30 16:16:23 UTC (rev 187585)
+++ trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp	2015-07-30 16:21:45 UTC (rev 187586)
@@ -37,6 +37,7 @@
 #include ResourceHandle.h
 #include glib/gstdio.h
 #include libsoup/soup.h
+#include wtf/NeverDestroyed.h
 #include wtf/text/CString.h
 #include wtf/text/StringBuilder.h
 
@@ -51,7 +52,7 @@
 
 SoupNetworkSession SoupNetworkSession::defaultSession()
 {
-static SoupNetworkSession networkSession(soupCookieJar());
+static NeverDestroyedSoupNetworkSession networkSession(soupCookieJar());
 return networkSession;
 }
 


Modified: trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h (187585 => 187586)

--- trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h	2015-07-30 16:16:23 UTC (rev 187585)
+++ trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h	2015-07-30 16:21:45 UTC (rev 187586)
@@ -70,6 +70,8 @@
 void setAcceptLanguages(const VectorString);
 
 private:
+friend class NeverDestroyedSoupNetworkSession;
+
 SoupNetworkSession(SoupCookieJar*);
 SoupNetworkSession(SoupSession*);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [187546] trunk/Source/WebCore

[mcatanzaro]

Title: [187546] trunk/Source/WebCore








Revision 187546
Author mcatanz...@igalia.com
Date 2015-07-29 07:30:50 -0700 (Wed, 29 Jul 2015)


Log Message
Clean up RefPtrCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=147384

Reviewed by Martin Robinson.

Tests for null/non-null should all be done without equality comparisons.

* platform/graphics/cairo/RefPtrCairo.cpp:
(WTF::refIfNotNull):
(WTF::derefIfNotNull):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/RefPtrCairo.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (187545 => 187546)

--- trunk/Source/WebCore/ChangeLog	2015-07-29 12:35:31 UTC (rev 187545)
+++ trunk/Source/WebCore/ChangeLog	2015-07-29 14:30:50 UTC (rev 187546)
@@ -1,3 +1,16 @@
+2015-07-29  Michael Catanzaro  mcatanz...@igalia.com
+
+Clean up RefPtrCairo.cpp
+https://bugs.webkit.org/show_bug.cgi?id=147384
+
+Reviewed by Martin Robinson.
+
+Tests for null/non-null should all be done without equality comparisons.
+
+* platform/graphics/cairo/RefPtrCairo.cpp:
+(WTF::refIfNotNull):
+(WTF::derefIfNotNull):
+
 2015-07-29  Dean Jackson  d...@apple.com
 
 Remove dispatch_apply_f and instead use vImage more directly


Modified: trunk/Source/WebCore/platform/graphics/cairo/RefPtrCairo.cpp (187545 => 187546)

--- trunk/Source/WebCore/platform/graphics/cairo/RefPtrCairo.cpp	2015-07-29 12:35:31 UTC (rev 187545)
+++ trunk/Source/WebCore/platform/graphics/cairo/RefPtrCairo.cpp	2015-07-29 14:30:50 UTC (rev 187546)
@@ -32,98 +32,98 @@
 
 template void refIfNotNull(cairo_t* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 cairo_reference(ptr);
 }
 
 template void derefIfNotNull(cairo_t* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 cairo_destroy(ptr);
 }
 
 template void refIfNotNull(cairo_surface_t* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 cairo_surface_reference(ptr);
 }
 
 template void derefIfNotNull(cairo_surface_t* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 cairo_surface_destroy(ptr);
 }
 
 template void refIfNotNull(cairo_font_face_t* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 cairo_font_face_reference(ptr);
 }
 
 template void derefIfNotNull(cairo_font_face_t* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 cairo_font_face_destroy(ptr);
 }
 
 template void refIfNotNull(cairo_scaled_font_t* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 cairo_scaled_font_reference(ptr);
 }
 
 template void derefIfNotNull(cairo_scaled_font_t* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 cairo_scaled_font_destroy(ptr);
 }
 
 template void refIfNotNull(cairo_pattern_t* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 cairo_pattern_reference(ptr);
 }
 
 template void derefIfNotNull(cairo_pattern_t* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 cairo_pattern_destroy(ptr);
 }
 
 template void refIfNotNull(cairo_region_t* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 cairo_region_reference(ptr);
 }
 
 template void derefIfNotNull(cairo_region_t* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 cairo_region_destroy(ptr);
 }
 
 #if USE(FREETYPE)
 template void refIfNotNull(FcPattern* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 FcPatternReference(ptr);
 }
 
 template void derefIfNotNull(FcPattern* ptr)
 {
-if (LIKELY(ptr != 0))
+if (LIKELY(ptr))
 FcPatternDestroy(ptr);
 }
 
 template void refIfNotNull(FcConfig* ptr)
 {
-if (LIKELY(ptr != nullptr))
+if (LIKELY(ptr))
 FcConfigReference(ptr);
 }
 
 template void derefIfNotNull(FcConfig* ptr)
 {
-if (LIKELY(ptr != nullptr))
+if (LIKELY(ptr))
 FcConfigDestroy(ptr);
 }
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [187159] trunk/Source/WebKit2

[mcatanzaro]

Title: [187159] trunk/Source/WebKit2








Revision 187159
Author mcatanz...@igalia.com
Date 2015-07-22 08:56:50 -0700 (Wed, 22 Jul 2015)


Log Message
[Seccomp Filters] Add helpers to get XDG base directory locations
https://bugs.webkit.org/show_bug.cgi?id=142982

Reviewed by Zan Dobersek.

* PlatformEfl.cmake:
* PlatformGTK.cmake:
* Shared/linux/SeccompFilters/XDGBaseDirectory.h: Added.
* Shared/linux/SeccompFilters/XDGBaseDirectoryGLib.cpp: Added.
(WebKit::userHomeDirectory):
(WebKit::userCacheDirectory):
(WebKit::userConfigDirectory):
(WebKit::userDataDirectory):
(WebKit::userRuntimeDirectory):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/PlatformGTK.cmake


Added Paths

trunk/Source/WebKit2/Shared/linux/SeccompFilters/XDGBaseDirectory.h
trunk/Source/WebKit2/Shared/linux/SeccompFilters/XDGBaseDirectoryGLib.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (187158 => 187159)

--- trunk/Source/WebKit2/ChangeLog	2015-07-22 15:44:04 UTC (rev 187158)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-22 15:56:50 UTC (rev 187159)
@@ -1,3 +1,20 @@
+2015-07-22  Michael Catanzaro  mcatanz...@igalia.com
+
+[Seccomp Filters] Add helpers to get XDG base directory locations
+https://bugs.webkit.org/show_bug.cgi?id=142982
+
+Reviewed by Zan Dobersek.
+
+* PlatformEfl.cmake:
+* PlatformGTK.cmake:
+* Shared/linux/SeccompFilters/XDGBaseDirectory.h: Added.
+* Shared/linux/SeccompFilters/XDGBaseDirectoryGLib.cpp: Added.
+(WebKit::userHomeDirectory):
+(WebKit::userCacheDirectory):
+(WebKit::userConfigDirectory):
+(WebKit::userDataDirectory):
+(WebKit::userRuntimeDirectory):
+
 2015-07-22  Gyuyoung Kim  gyuyoung@webkit.org
 
 [EFL][WK2] EWK2ContextTestMultipleProcesses.ewk_context_network_process_model fails to pass


Modified: trunk/Source/WebKit2/PlatformEfl.cmake (187158 => 187159)

--- trunk/Source/WebKit2/PlatformEfl.cmake	2015-07-22 15:44:04 UTC (rev 187158)
+++ trunk/Source/WebKit2/PlatformEfl.cmake	2015-07-22 15:56:50 UTC (rev 187159)
@@ -54,6 +54,7 @@
 Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp
 Shared/linux/SeccompFilters/Syscall.cpp
 Shared/linux/SeccompFilters/SyscallPolicy.cpp
+Shared/linux/SeccompFilters/XDGBaseDirectoryGLib.cpp
 
 Shared/soup/WebCoreArgumentCodersSoup.cpp
 


Modified: trunk/Source/WebKit2/PlatformGTK.cmake (187158 => 187159)

--- trunk/Source/WebKit2/PlatformGTK.cmake	2015-07-22 15:44:04 UTC (rev 187158)
+++ trunk/Source/WebKit2/PlatformGTK.cmake	2015-07-22 15:56:50 UTC (rev 187159)
@@ -83,6 +83,7 @@
 Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp
 Shared/linux/SeccompFilters/Syscall.cpp
 Shared/linux/SeccompFilters/SyscallPolicy.cpp
+Shared/linux/SeccompFilters/XDGBaseDirectoryGLib.cpp
 
 Shared/soup/WebCoreArgumentCodersSoup.cpp
 


Added: trunk/Source/WebKit2/Shared/linux/SeccompFilters/XDGBaseDirectory.h (0 => 187159)

--- trunk/Source/WebKit2/Shared/linux/SeccompFilters/XDGBaseDirectory.h	(rev 0)
+++ trunk/Source/WebKit2/Shared/linux/SeccompFilters/XDGBaseDirectory.h	2015-07-22 15:56:50 UTC (rev 187159)
@@ -0,0 +1,46 @@
+/*
+ * Copyright (C) 2015 Igalia S.L.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef XDGBaseDirectory_h
+#define XDGBaseDirectory_h
+
+#if ENABLE(SECCOMP_FILTERS)
+
+#include wtf/text/WTFString.h
+
+namespace WebKit {
+
+String userCacheDirectory();
+String userConfigDirectory();
+String userDataDirectory();
+String userHomeDirectory();
+String userRuntimeDirectory();
+
+} // namespace WebKit
+
+#endif // ENABLE(SECCOMP_FILTERS)
+
+#endif // XDGBaseDirectory_h

[webkit-changes] [187455] trunk/Source/WebKit2

[mcatanzaro]

Title: [187455] trunk/Source/WebKit2








Revision 187455
Author mcatanz...@igalia.com
Date 2015-07-27 15:18:58 -0700 (Mon, 27 Jul 2015)


Log Message
[Seccomp] Set appropriate filters when trapping syscalls by default
https://bugs.webkit.org/show_bug.cgi?id=142983

If we trap syscalls by default, we must not set separate filters to trap
anything here, since it will fail causing us to crash.

But also, there are some things we must allow unconditionally even when
trapping by default. sigreturn, obviously. Also, let's whitelist brk
here instead of in platform-specific code.

Reviewed by Žan Doberšek.

* Shared/linux/SeccompFilters/SeccompBroker.cpp:
(WebKit::SeccompBroker::launchProcess): Don't trap sigprocmask or sigaction unless allow is
the default action. Also, allow sigreturn and brk is allow is not the default.
* Shared/linux/SeccompFilters/SeccompFilters.cpp: Added
(WebKit::SeccompFilters::defaultAction):
* Shared/linux/SeccompFilters/SeccompFilters.h: Added defaultAction

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (187454 => 187455)

--- trunk/Source/WebKit2/ChangeLog	2015-07-27 22:10:55 UTC (rev 187454)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-27 22:18:58 UTC (rev 187455)
@@ -1,3 +1,24 @@
+2015-07-27  Michael Catanzaro  mcatanz...@igalia.com
+
+[Seccomp] Set appropriate filters when trapping syscalls by default
+https://bugs.webkit.org/show_bug.cgi?id=142983
+
+If we trap syscalls by default, we must not set separate filters to trap
+anything here, since it will fail causing us to crash.
+
+But also, there are some things we must allow unconditionally even when
+trapping by default. sigreturn, obviously. Also, let's whitelist brk
+here instead of in platform-specific code.
+
+Reviewed by Žan Doberšek.
+
+* Shared/linux/SeccompFilters/SeccompBroker.cpp:
+(WebKit::SeccompBroker::launchProcess): Don't trap sigprocmask or sigaction unless allow is
+the default action. Also, allow sigreturn and brk is allow is not the default.
+* Shared/linux/SeccompFilters/SeccompFilters.cpp: Added
+(WebKit::SeccompFilters::defaultAction):
+* Shared/linux/SeccompFilters/SeccompFilters.h: Added defaultAction
+
 2015-07-27  Matthew Daiter  mdai...@apple.com
 
 Renamed duplicate vectors inside UserMediaPermissionRequestProxy


Modified: trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp (187454 => 187455)

--- trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp	2015-07-27 22:10:55 UTC (rev 187454)
+++ trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp	2015-07-27 22:18:58 UTC (rev 187455)
@@ -268,28 +268,40 @@
 if (initialized)
 return;
 
-// The sigprocmask filters bellow are needed to trap sigprocmask()
-// so we can prevent the running processes from blocking SIGSYS.
-filters-addRule(sigprocmask, SeccompFilters::Trap,
-0, SeccompFilters::Equal, SIG_BLOCK,
-1, SeccompFilters::NotEqual, 0);
-filters-addRule(sigprocmask, SeccompFilters::Trap,
-0, SeccompFilters::Equal, SIG_SETMASK,
-1, SeccompFilters::NotEqual, 0);
-filters-addRule(rt_sigprocmask, SeccompFilters::Trap,
-0, SeccompFilters::Equal, SIG_BLOCK,
-1, SeccompFilters::NotEqual, 0);
-filters-addRule(rt_sigprocmask, SeccompFilters::Trap,
-0, SeccompFilters::Equal, SIG_SETMASK,
-1, SeccompFilters::NotEqual, 0);
+if (filters-defaultAction() == SeccompFilters::Allow) {
+// The sigprocmask filters bellow are needed to trap sigprocmask()
+// so we can prevent the running processes from blocking SIGSYS.
+filters-addRule(sigprocmask, SeccompFilters::Trap,
+0, SeccompFilters::Equal, SIG_BLOCK,
+1, SeccompFilters::NotEqual, 0);
+filters-addRule(sigprocmask, SeccompFilters::Trap,
+0, SeccompFilters::Equal, SIG_SETMASK,
+1, SeccompFilters::NotEqual, 0);
+filters-addRule(rt_sigprocmask, SeccompFilters::Trap,
+0, SeccompFilters::Equal, SIG_BLOCK,
+1, SeccompFilters::NotEqual, 0);
+filters-addRule(rt_sigprocmask, SeccompFilters::Trap,
+0, SeccompFilters::Equal, SIG_SETMASK,
+1, SeccompFilters::NotEqual, 0);
 
-// The sigaction filters bellow are needed to trap sigaction()
-// so we can prevent the running processes from handling SIGSYS.
-filters-addRule(sigaction, SeccompFilters::Trap,
-0, SeccompFilters::Equal, SIGSYS);
-filters-addRule(rt_sigaction, SeccompFilters::Trap,
-0, SeccompFilters::Equal, SIGSYS);
+// The sigaction filters bellow are needed to trap sigaction()
+  

[webkit-changes] [187190] trunk/Source/WebKit2

[mcatanzaro]

Title: [187190] trunk/Source/WebKit2








Revision 187190
Author mcatanz...@igalia.com
Date 2015-07-22 15:09:35 -0700 (Wed, 22 Jul 2015)


Log Message
[Seccomp] Canonicalize filesystem path when whitelisting it
https://bugs.webkit.org/show_bug.cgi?id=142986

Reviewed by Žan Doberšek.

* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
(WebKit::canonicalizeFileName):
(WebKit::SyscallPolicy::addFilePermission):
(WebKit::SyscallPolicy::addDirectoryPermission):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (187189 => 187190)

--- trunk/Source/WebKit2/ChangeLog	2015-07-22 21:55:48 UTC (rev 187189)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-22 22:09:35 UTC (rev 187190)
@@ -1,3 +1,15 @@
+2015-07-22  Michael Catanzaro  mcatanz...@igalia.com
+
+[Seccomp] Canonicalize filesystem path when whitelisting it
+https://bugs.webkit.org/show_bug.cgi?id=142986
+
+Reviewed by Žan Doberšek.
+
+* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
+(WebKit::canonicalizeFileName):
+(WebKit::SyscallPolicy::addFilePermission):
+(WebKit::SyscallPolicy::addDirectoryPermission):
+
 2015-07-21  Simon Fraser  simon.fra...@apple.com
 
 Add logging for TiledCoreAnimationDrawingArea resizing


Modified: trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp (187189 => 187190)

--- trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp	2015-07-22 21:55:48 UTC (rev 187189)
+++ trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp	2015-07-22 22:09:35 UTC (rev 187190)
@@ -106,18 +106,29 @@
 return false;
 }
 
+static String canonicalizeFileName(const String path)
+{
+char* canonicalizedPath = canonicalize_file_name(path.utf8().data());
+if (canonicalizedPath) {
+String result = String::fromUTF8(canonicalizedPath);
+free(canonicalizedPath);
+return result;
+}
+return path;
+}
+
 void SyscallPolicy::addFilePermission(const String path, Permission permission)
 {
 ASSERT(!path.isEmpty()  path.startsWith('/')   !path.endsWith('/')  !path.contains(//));
 
-m_filePermission.set(path, permission);
+m_filePermission.set(canonicalizeFileName(path), permission);
 }
 
 void SyscallPolicy::addDirectoryPermission(const String path, Permission permission)
 {
 ASSERT(path.startsWith('/')  !path.contains(//)  (path.length() == 1 || !path.endsWith('/')));
 
-m_directoryPermission.set(path, permission);
+m_directoryPermission.set(canonicalizeFileName(path), permission);
 }
 
 void SyscallPolicy::addDefaultWebProcessPolicy(const WebProcessCreationParameters parameters)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [187157] trunk/Source/WebCore/platform/gtk/po

[mcatanzaro]

Title: [187157] trunk/Source/WebCore/platform/gtk/po








Revision 187157
Author mcatanz...@igalia.com
Date 2015-07-22 07:57:53 -0700 (Wed, 22 Jul 2015)


Log Message
[l10n] Updated Swedish translation
https://bugs.webkit.org/show_bug.cgi?id=147190

Patch by Josef Andersson josef.anders...@fripost.org on 2015-07-22

* sv.po:

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog
trunk/Source/WebCore/platform/gtk/po/sv.po




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (187156 => 187157)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-07-22 14:53:31 UTC (rev 187156)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-07-22 14:57:53 UTC (rev 187157)
@@ -1,3 +1,10 @@
+2015-07-22  Josef Andersson  josef.anders...@fripost.org
+
+[l10n] Updated Swedish translation
+https://bugs.webkit.org/show_bug.cgi?id=147190
+
+* sv.po:
+
 2015-07-10  Josef Andersson  josef.anders...@fripost.org
 
 Updated Swedish translation for WebKitGTK+


Modified: trunk/Source/WebCore/platform/gtk/po/sv.po (187156 => 187157)

--- trunk/Source/WebCore/platform/gtk/po/sv.po	2015-07-22 14:53:31 UTC (rev 187156)
+++ trunk/Source/WebCore/platform/gtk/po/sv.po	2015-07-22 14:57:53 UTC (rev 187157)
@@ -6,8 +6,8 @@
 msgstr 
 Project-Id-Version: webkitgtk+\n
 Report-Msgid-Bugs-To: https://bugs.webkit.org\n
-POT-Creation-Date: 2015-07-03 00:13+\n
-PO-Revision-Date: 2015-06-07 10:21+0100\n
+POT-Creation-Date: 2015-07-21 12:08+\n
+PO-Revision-Date: 2015-07-21 11:11+0100\n
 Last-Translator: Josef Andersson josef.anders...@fripost.org\n
 Language-Team: Swedish tp...@listor.tp-sv.se\n
 Language: sv\n
@@ -35,7 +35,7 @@
 
 #: ../ErrorsGtk.cpp:57
 msgid Content with the specified MIME type cannot be shown
-msgstr Innehåll med den specifierade MIME-typen kan inte visas
+msgstr Innehåll med den angivna MIME-typen kan inte visas
 
 #: ../ErrorsGtk.cpp:63
 msgid File does not exist
@@ -558,11 +558,11 @@
 
 #: ../LocalizedStringsGtk.cpp:759
 msgid range underflow
-msgstr intervallunderskridning
+msgstr intervallunderspill
 
 #: ../LocalizedStringsGtk.cpp:764
 msgid range overflow
-msgstr intervallöverskridning
+msgstr intervallöverspill
 
 #: ../LocalizedStringsGtk.cpp:769
 msgid step mismatch
@@ -575,7 +575,7 @@
 #: ../LocalizedStringsGtk.cpp:791
 msgctxt Closed Captions
 msgid Menu section heading for closed captions
-msgstr Menuavsnittsrubrik för undertexter
+msgstr Menyavsnittsrubrik för undertexter
 
 #: ../LocalizedStringsGtk.cpp:796
 msgctxt Menu section heading for subtitles
@@ -780,7 +780,7 @@
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitHitTestResult.cpp:153
 msgid Flags with the context of the WebKitHitTestResult
-msgstr Flaggor med kontextet för WebKitHitTestResult
+msgstr Flaggor med kontexten för WebKitHitTestResult
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitHitTestResult.cpp:166
 msgid Link URI
@@ -804,7 +804,7 @@
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitHitTestResult.cpp:193
 msgid The link label
-msgstr Länktetiketten
+msgstr Länketiketten
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitHitTestResult.cpp:205
 msgid Image URI
@@ -880,7 +880,7 @@
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:159
 msgid Print Settings
-msgstr Utskriftsinställnngar
+msgstr Utskriftsinställningar
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:160
 msgid The initial print settings for the print operation
@@ -1027,8 +1027,8 @@
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:693
 msgid The font family used as the default for content using monospace font.
 msgstr 
-Standardfamiljen för teckensnitt som används för innehåll med teckensnittet 
-monospace.
+Standardfamiljen för teckensnitt som används för innehåll med monospace-
+teckensnitt.
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:705
 msgid Serif font family
@@ -1067,7 +1067,7 @@
 msgid The font family used as the default for content using fantasy font.
 msgstr 
 Teckensnittsfamilj att använda som standard för innehåll som använder 
-teckensnittet fantasy.
+fantasy-teckensnitt.
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:757
 msgid Pictograph font family
@@ -1077,7 +1077,7 @@
 msgid The font family used as the default for content using pictograph font.
 msgstr 
 Teckensnittsfamilj att använda som standard för innehåll som använder 
-teckensnittet pictograph.
+pictograph-teckensnitt.
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:771
 msgid Default font size
@@ -1240,19 +1240,19 @@
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1055
 msgid Draw compositing indicators
-msgstr Visa indikatorer för composting-indikatorer
+msgstr Rita ut kompositionsindikatorer
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1056
 msgid Whether to draw compositing borders and repaint counters
-msgstr Huruvida utritning av composting-ramar och rita om räknare
+msgstr Huruvida utritning av 

[webkit-changes] [186802] trunk/Source/WebKit2

[mcatanzaro]

Title: [186802] trunk/Source/WebKit2








Revision 186802
Author mcatanz...@igalia.com
Date 2015-07-14 08:35:48 -0700 (Tue, 14 Jul 2015)


Log Message
[Linux] SeccompFilters: whitelist source directory on all ports
https://bugs.webkit.org/show_bug.cgi?id=140066

Reviewed by Žan Doberšek.

Move this from EFL to port-independent code.

* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):
* WebProcess/efl/SeccompFiltersWebProcessEfl.cpp:
(WebKit::SeccompFiltersWebProcessEfl::platformInitialize):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp
trunk/Source/WebKit2/WebProcess/efl/SeccompFiltersWebProcessEfl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (186801 => 186802)

--- trunk/Source/WebKit2/ChangeLog	2015-07-14 08:53:30 UTC (rev 186801)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-14 15:35:48 UTC (rev 186802)
@@ -1,3 +1,17 @@
+2015-07-14  Michael Catanzaro  mcatanz...@igalia.com
+
+[Linux] SeccompFilters: whitelist source directory on all ports
+https://bugs.webkit.org/show_bug.cgi?id=140066
+
+Reviewed by Žan Doberšek.
+
+Move this from EFL to port-independent code.
+
+* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
+(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):
+* WebProcess/efl/SeccompFiltersWebProcessEfl.cpp:
+(WebKit::SeccompFiltersWebProcessEfl::platformInitialize):
+
 2015-07-14  Zan Dobersek  zdober...@igalia.com
 
 [GTK] Add a runtime check for X11 display in webkitWebViewBaseExitAcceleratedCompositingMode()


Modified: trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp (186801 => 186802)

--- trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp	2015-07-14 08:53:30 UTC (rev 186801)
+++ trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp	2015-07-14 15:35:48 UTC (rev 186802)
@@ -238,6 +238,17 @@
 // Needed by NVIDIA proprietary graphics driver
 if (homeDir)
 addDirectoryPermission(String::fromUTF8(homeDir) + /.nv, ReadAndWrite);
+
+#if ENABLE(DEVELOPER_MODE)  defined(SOURCE_DIR)
+// Developers using build-webkit expect some libraries to be loaded
+// from the build root directory and they also need access to layout test
+// files.
+char* sourceDir = canonicalize_file_name(SOURCE_DIR);
+if (sourceDir) {
+addDirectoryPermission(String::fromUTF8(sourceDir), SyscallPolicy::ReadAndWrite);
+free(sourceDir);
+}
+#endif
 }
 
 } // namespace WebKit


Modified: trunk/Source/WebKit2/WebProcess/efl/SeccompFiltersWebProcessEfl.cpp (186801 => 186802)

--- trunk/Source/WebKit2/WebProcess/efl/SeccompFiltersWebProcessEfl.cpp	2015-07-14 08:53:30 UTC (rev 186801)
+++ trunk/Source/WebKit2/WebProcess/efl/SeccompFiltersWebProcessEfl.cpp	2015-07-14 15:35:48 UTC (rev 186802)
@@ -55,18 +55,6 @@
 m_policy.addDirectoryPermission(ASCIILiteral(/sys/devices), SyscallPolicy::Read);
 m_policy.addFilePermission(ASCIILiteral(/etc/udev/udev.conf), SyscallPolicy::Read);
 
-#ifdef SOURCE_DIR
-// Developers using build-webkit --efl expect some libraries to be loaded
-// from the build root directory and they also need access to layout test
-// files. The constant is defined only when jhbuild is detected, which is
-// an indication of a development build.
-char* sourceDir = canonicalize_file_name(SOURCE_DIR);
-if (sourceDir) {
-m_policy.addDirectoryPermission(String::fromUTF8(sourceDir), SyscallPolicy::ReadAndWrite);
-free(sourceDir);
-}
-#endif
-
 // Place where the theme and icons are installed.
 char* dataDir = canonicalize_file_name(DATA_DIR);
 if (dataDir) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186810] trunk/Source/WebKit2

[mcatanzaro]

Title: [186810] trunk/Source/WebKit2








Revision 186810
Author mcatanz...@igalia.com
Date 2015-07-14 13:06:10 -0700 (Tue, 14 Jul 2015)


Log Message
[Linux] SeccompFilters: whitelist all NPAPI plugin directories
https://bugs.webkit.org/show_bug.cgi?id=140067

Reviewed by Žan Doberšek.

* PlatformEfl.cmake: Build PluginSearchPath.cpp
* PlatformGTK.cmake: Build PluginSearchPath.cpp
* Shared/Plugins/unix/PluginSearchPath.cpp: Added.
(WebKit::pluginsDirectories): Moved from PluginInfoStoreUnix.cpp.
* Shared/Plugins/unix/PluginSearchPath.h: Added.
* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy): Add the entire
plugin search path to the whitelist.
* UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::pluginsDirectories): Now gets plugins
directories from PluginSearchPath.cpp

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp
trunk/Source/WebKit2/UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp


Added Paths

trunk/Source/WebKit2/Shared/Plugins/unix/
trunk/Source/WebKit2/Shared/Plugins/unix/PluginSearchPath.cpp
trunk/Source/WebKit2/Shared/Plugins/unix/PluginSearchPath.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (186809 => 186810)

--- trunk/Source/WebKit2/ChangeLog	2015-07-14 19:50:37 UTC (rev 186809)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-14 20:06:10 UTC (rev 186810)
@@ -1,3 +1,22 @@
+2015-07-14  Michael Catanzaro  mcatanz...@igalia.com
+
+[Linux] SeccompFilters: whitelist all NPAPI plugin directories
+https://bugs.webkit.org/show_bug.cgi?id=140067
+
+Reviewed by Žan Doberšek.
+
+* PlatformEfl.cmake: Build PluginSearchPath.cpp
+* PlatformGTK.cmake: Build PluginSearchPath.cpp
+* Shared/Plugins/unix/PluginSearchPath.cpp: Added.
+(WebKit::pluginsDirectories): Moved from PluginInfoStoreUnix.cpp.
+* Shared/Plugins/unix/PluginSearchPath.h: Added.
+* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
+(WebKit::SyscallPolicy::addDefaultWebProcessPolicy): Add the entire
+plugin search path to the whitelist.
+* UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
+(WebKit::PluginInfoStore::pluginsDirectories): Now gets plugins
+directories from PluginSearchPath.cpp
+
 2015-07-14  Yongjun Zhang  yongjun_zh...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=146917


Modified: trunk/Source/WebKit2/PlatformEfl.cmake (186809 => 186810)

--- trunk/Source/WebKit2/PlatformEfl.cmake	2015-07-14 19:50:37 UTC (rev 186809)
+++ trunk/Source/WebKit2/PlatformEfl.cmake	2015-07-14 20:06:10 UTC (rev 186810)
@@ -34,6 +34,8 @@
 
 Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp
 
+Shared/Plugins/unix/PluginSearchPath.cpp
+
 Shared/cairo/ShareableBitmapCairo.cpp
 
 Shared/efl/NativeContextMenuItemEfl.cpp
@@ -235,6 +237,7 @@
 ${WEBKIT2_DIR}/Shared/CoordinatedGraphics
 ${WEBKIT2_DIR}/Shared/Downloads/soup
 ${WEBKIT2_DIR}/Shared/Network/CustomProtocols/soup
+${WEBKIT2_DIR}/Shared/Plugins/unix
 ${WEBKIT2_DIR}/Shared/efl
 ${WEBKIT2_DIR}/Shared/soup
 ${WEBKIT2_DIR}/Shared/unix


Modified: trunk/Source/WebKit2/PlatformGTK.cmake (186809 => 186810)

--- trunk/Source/WebKit2/PlatformGTK.cmake	2015-07-14 19:50:37 UTC (rev 186809)
+++ trunk/Source/WebKit2/PlatformGTK.cmake	2015-07-14 20:06:10 UTC (rev 186810)
@@ -55,6 +55,8 @@
 
 Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp
 
+Shared/Plugins/unix/PluginSearchPath.cpp
+
 Shared/cairo/ShareableBitmapCairo.cpp
 
 Shared/gtk/ArgumentCodersGtk.cpp
@@ -470,6 +472,7 @@
 ${WEBKIT2_DIR}/Shared/API/c/gtk
 ${WEBKIT2_DIR}/Shared/Network/CustomProtocols/soup
 ${WEBKIT2_DIR}/Shared/Downloads/soup
+${WEBKIT2_DIR}/Shared/Plugins/unix
 ${WEBKIT2_DIR}/Shared/gtk
 ${WEBKIT2_DIR}/Shared/soup
 ${WEBKIT2_DIR}/Shared/unix


Copied: trunk/Source/WebKit2/Shared/Plugins/unix/PluginSearchPath.cpp (from rev 186809, trunk/Source/WebKit2/UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp) (0 => 186810)

--- trunk/Source/WebKit2/Shared/Plugins/unix/PluginSearchPath.cpp	(rev 0)
+++ trunk/Source/WebKit2/Shared/Plugins/unix/PluginSearchPath.cpp	2015-07-14 20:06:10 UTC (rev 186810)
@@ -0,0 +1,76 @@
+/*
+ * Copyright (C) 2015 Igalia S.L.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS 

[webkit-changes] [186886] trunk/Tools

[mcatanzaro]

Title: [186886] trunk/Tools








Revision 186886
Author mcatanz...@igalia.com
Date 2015-07-15 19:42:51 -0700 (Wed, 15 Jul 2015)


Log Message
[EFL] Bump libseccomp version to 2.2.3
https://bugs.webkit.org/show_bug.cgi?id=146980

Reviewed by Gyuyoung Kim.

* efl/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/efl/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (186885 => 186886)

--- trunk/Tools/ChangeLog	2015-07-16 02:08:00 UTC (rev 186885)
+++ trunk/Tools/ChangeLog	2015-07-16 02:42:51 UTC (rev 186886)
@@ -1,3 +1,12 @@
+2015-07-15  Michael Catanzaro  mcatanz...@igalia.com
+
+[EFL] Bump libseccomp version to 2.2.3
+https://bugs.webkit.org/show_bug.cgi?id=146980
+
+Reviewed by Gyuyoung Kim.
+
+* efl/jhbuild.modules:
+
 2015-07-15  Brent Fulgham  bfulg...@apple.com
 
 [Win] Maintain consistent COM Interfaces


Modified: trunk/Tools/efl/jhbuild.modules (186885 => 186886)

--- trunk/Tools/efl/jhbuild.modules	2015-07-16 02:08:00 UTC (rev 186885)
+++ trunk/Tools/efl/jhbuild.modules	2015-07-16 02:42:51 UTC (rev 186886)
@@ -302,9 +302,9 @@
   /autotools
 
   autotools id=libseccomp autogen-sh=configure
-  branch module=seccomp/libseccomp/releases/download/v2.2.1/libseccomp-2.2.1.tar.gz version=2.2.1
+  branch module=seccomp/libseccomp/releases/download/v2.2.3/libseccomp-2.2.3.tar.gz version=2.2.3
   repo=github.com
-  hash=sha256:0ba1789f54786c644af54cdffc9fd0dd0a8bb2b2ee153933f658855d2851a740
+  hash=sha256:d9b400b703cab7bb04b84b9b6e52076a630b673819d7541757bcc16467b6d49e
   /branch
   /autotools
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186893] trunk/Source/WebKit2

[mcatanzaro]

Title: [186893] trunk/Source/WebKit2








Revision 186893
Author mcatanz...@igalia.com
Date 2015-07-16 08:34:03 -0700 (Thu, 16 Jul 2015)


Log Message
[Linux] Seccomp: fix -Wmismatched-tags
https://bugs.webkit.org/show_bug.cgi?id=146990

Reviewed by Žan Doberšek.

WebProcessCreationParameters is a struct nowadays, not a class, so declare it appropriately.

* Shared/linux/SeccompFilters/SyscallPolicy.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (186892 => 186893)

--- trunk/Source/WebKit2/ChangeLog	2015-07-16 10:29:51 UTC (rev 186892)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-16 15:34:03 UTC (rev 186893)
@@ -1,3 +1,14 @@
+2015-07-16  Michael Catanzaro  mcatanz...@igalia.com
+
+[Linux] Seccomp: fix -Wmismatched-tags
+https://bugs.webkit.org/show_bug.cgi?id=146990
+
+Reviewed by Žan Doberšek.
+
+WebProcessCreationParameters is a struct nowadays, not a class, so declare it appropriately.
+
+* Shared/linux/SeccompFilters/SyscallPolicy.h:
+
 2015-07-16  Carlos Garcia Campos  cgar...@igalia.com
 
 REGRESSION(r185415): [GTK] Browsers crash when an input method is enabled


Modified: trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.h (186892 => 186893)

--- trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.h	2015-07-16 10:29:51 UTC (rev 186892)
+++ trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.h	2015-07-16 15:34:03 UTC (rev 186893)
@@ -34,7 +34,7 @@
 
 namespace WebKit {
 
-class WebProcessCreationParameters;
+struct WebProcessCreationParameters;
 
 class SyscallPolicy {
 public:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186852] trunk/Source/WebKit2

[mcatanzaro]

Title: [186852] trunk/Source/WebKit2








Revision 186852
Author mcatanz...@igalia.com
Date 2015-07-15 13:34:17 -0700 (Wed, 15 Jul 2015)


Log Message
[GTK] Rename LIBEXECDIR to PKGLIBEXECDIR
https://bugs.webkit.org/show_bug.cgi?id=140070

Reviewed by Martin Robinson.

The path that's currently stored in LIBEXECDIR is one level lower than
the real LIBEXECDIR, which we are going to need. Introduce PKGLIBEXECDIR
so that we can use LIBEXECDIR for the real LIBEXECDIR in the future.

* PlatformGTK.cmake:
* Shared/gtk/ProcessExecutablePathGtk.cpp:
(WebKit::findWebKitProcess):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/WebKit2/Shared/gtk/ProcessExecutablePathGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (186851 => 186852)

--- trunk/Source/WebKit2/ChangeLog	2015-07-15 18:32:29 UTC (rev 186851)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-15 20:34:17 UTC (rev 186852)
@@ -1,3 +1,18 @@
+2015-07-15  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] Rename LIBEXECDIR to PKGLIBEXECDIR
+https://bugs.webkit.org/show_bug.cgi?id=140070
+
+Reviewed by Martin Robinson.
+
+The path that's currently stored in LIBEXECDIR is one level lower than
+the real LIBEXECDIR, which we are going to need. Introduce PKGLIBEXECDIR
+so that we can use LIBEXECDIR for the real LIBEXECDIR in the future.
+
+* PlatformGTK.cmake:
+* Shared/gtk/ProcessExecutablePathGtk.cpp:
+(WebKit::findWebKitProcess):
+
 2015-07-15  Daniel Bates  daba...@apple.com
 
 [Mac][WK2] Videos should only have access to cookies when -[NSURLRequest HTTPShouldHandleCookies] is YES


Modified: trunk/Source/WebKit2/PlatformGTK.cmake (186851 => 186852)

--- trunk/Source/WebKit2/PlatformGTK.cmake	2015-07-15 18:32:29 UTC (rev 186851)
+++ trunk/Source/WebKit2/PlatformGTK.cmake	2015-07-15 20:34:17 UTC (rev 186852)
@@ -15,7 +15,7 @@
 
 add_definitions(-DBUILDING_WEBKIT)
 add_definitions(-DWEBKIT2_COMPILATION)
-add_definitions(-DLIBEXECDIR=${LIBEXEC_INSTALL_DIR})
+add_definitions(-DPKGLIBEXECDIR=${LIBEXEC_INSTALL_DIR})
 add_definitions(-DPACKAGE_LOCALE_DIR=${CMAKE_INSTALL_FULL_LOCALEDIR})
 add_definitions(-DLIBDIR=${LIB_INSTALL_DIR})
 


Modified: trunk/Source/WebKit2/Shared/gtk/ProcessExecutablePathGtk.cpp (186851 => 186852)

--- trunk/Source/WebKit2/Shared/gtk/ProcessExecutablePathGtk.cpp	2015-07-15 18:32:29 UTC (rev 186851)
+++ trunk/Source/WebKit2/Shared/gtk/ProcessExecutablePathGtk.cpp	2015-07-15 20:34:17 UTC (rev 186852)
@@ -66,7 +66,7 @@
 }
 #endif
 
-return pathByAppendingComponent(filenameToString(LIBEXECDIR), processName);
+return pathByAppendingComponent(filenameToString(PKGLIBEXECDIR), processName);
 }
 
 String executablePathOfWebProcess()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186861] trunk/Source/WebKit2

[mcatanzaro]

Title: [186861] trunk/Source/WebKit2








Revision 186861
Author mcatanz...@igalia.com
Date 2015-07-15 14:46:07 -0700 (Wed, 15 Jul 2015)


Log Message
[GTK] Rename PACKAGE_LOCALE_DIR to LOCALEDIR
https://bugs.webkit.org/show_bug.cgi?id=146975

Reviewed by Martin Robinson.

* PlatformGTK.cmake:
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_class_init):
* WebProcess/gtk/WebProcessMainGtk.cpp:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (186860 => 186861)

--- trunk/Source/WebKit2/ChangeLog	2015-07-15 21:41:08 UTC (rev 186860)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-15 21:46:07 UTC (rev 186861)
@@ -1,5 +1,17 @@
 2015-07-15  Michael Catanzaro  mcatanz...@igalia.com
 
+[GTK] Rename PACKAGE_LOCALE_DIR to LOCALEDIR
+https://bugs.webkit.org/show_bug.cgi?id=146975
+
+Reviewed by Martin Robinson.
+
+* PlatformGTK.cmake:
+* UIProcess/API/gtk/WebKitWebContext.cpp:
+(webkit_web_context_class_init):
+* WebProcess/gtk/WebProcessMainGtk.cpp:
+
+2015-07-15  Michael Catanzaro  mcatanz...@igalia.com
+
 [GTK] Rename LIBEXECDIR to PKGLIBEXECDIR
 https://bugs.webkit.org/show_bug.cgi?id=140070
 


Modified: trunk/Source/WebKit2/PlatformGTK.cmake (186860 => 186861)

--- trunk/Source/WebKit2/PlatformGTK.cmake	2015-07-15 21:41:08 UTC (rev 186860)
+++ trunk/Source/WebKit2/PlatformGTK.cmake	2015-07-15 21:46:07 UTC (rev 186861)
@@ -16,7 +16,7 @@
 add_definitions(-DBUILDING_WEBKIT)
 add_definitions(-DWEBKIT2_COMPILATION)
 add_definitions(-DPKGLIBEXECDIR=${LIBEXEC_INSTALL_DIR})
-add_definitions(-DPACKAGE_LOCALE_DIR=${CMAKE_INSTALL_FULL_LOCALEDIR})
+add_definitions(-DLOCALEDIR=${CMAKE_INSTALL_FULL_LOCALEDIR})
 add_definitions(-DLIBDIR=${LIB_INSTALL_DIR})
 
 set(WebKit2_USE_PREFIX_HEADER ON)


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp (186860 => 186861)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp	2015-07-15 21:41:08 UTC (rev 186860)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp	2015-07-15 21:46:07 UTC (rev 186861)
@@ -339,7 +339,7 @@
 {
 GObjectClass* gObjectClass = G_OBJECT_CLASS(webContextClass);
 
-bindtextdomain(GETTEXT_PACKAGE, PACKAGE_LOCALE_DIR);
+bindtextdomain(GETTEXT_PACKAGE, LOCALEDIR);
 bind_textdomain_codeset(GETTEXT_PACKAGE, UTF-8);
 
 gObjectClass-get_property = webkitWebContextGetProperty;


Modified: trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp (186860 => 186861)

--- trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp	2015-07-15 21:41:08 UTC (rev 186860)
+++ trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp	2015-07-15 21:46:07 UTC (rev 186861)
@@ -56,7 +56,7 @@
 #endif
 gtk_init(nullptr, nullptr);
 
-bindtextdomain(GETTEXT_PACKAGE, PACKAGE_LOCALE_DIR);
+bindtextdomain(GETTEXT_PACKAGE, LOCALEDIR);
 bind_textdomain_codeset(GETTEXT_PACKAGE, UTF-8);
 
 SoupNetworkSession::defaultSession().setSSLPolicy(SoupNetworkSession::SSLUseSystemCAFile);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186904] trunk/Source/WebKit2

[mcatanzaro]

Title: [186904] trunk/Source/WebKit2








Revision 186904
Author mcatanz...@igalia.com
Date 2015-07-16 13:06:43 -0700 (Thu, 16 Jul 2015)


Log Message
REGRESSION(r186464): [SOUP] ASSERTION FAILED: !m_messageReceiverMapCount when closing any tab
https://bugs.webkit.org/show_bug.cgi?id=147006

Reviewed by Anders Carlsson.

Remove the message receiver before it is deallocated.

* UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp:
(WebKit::CustomProtocolManagerProxy::~CustomProtocolManagerProxy):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (186903 => 186904)

--- trunk/Source/WebKit2/ChangeLog	2015-07-16 19:30:46 UTC (rev 186903)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-16 20:06:43 UTC (rev 186904)
@@ -1,3 +1,15 @@
+2015-07-16  Michael Catanzaro  mcatanz...@igalia.com
+
+REGRESSION(r186464): [SOUP] ASSERTION FAILED: !m_messageReceiverMapCount when closing any tab
+https://bugs.webkit.org/show_bug.cgi?id=147006
+
+Reviewed by Anders Carlsson.
+
+Remove the message receiver before it is deallocated.
+
+* UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp:
+(WebKit::CustomProtocolManagerProxy::~CustomProtocolManagerProxy):
+
 2015-07-16  Brady Eidson  beid...@apple.com
 
 Review feedback followup for:


Modified: trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp (186903 => 186904)

--- trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp	2015-07-16 19:30:46 UTC (rev 186903)
+++ trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp	2015-07-16 20:06:43 UTC (rev 186904)
@@ -39,6 +39,7 @@
 
 CustomProtocolManagerProxy::~CustomProtocolManagerProxy()
 {
+m_childProcessProxy-removeMessageReceiver(Messages::CustomProtocolManagerProxy::messageReceiverName());
 }
 
 void CustomProtocolManagerProxy::startLoading(uint64_t customProtocolID, const WebCore::ResourceRequest request)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [187011] trunk

[mcatanzaro]

Title: [187011] trunk








Revision 187011
Author mcatanz...@igalia.com
Date 2015-07-19 09:32:58 -0700 (Sun, 19 Jul 2015)


Log Message
[GTK] Add seccomp filters support
https://bugs.webkit.org/show_bug.cgi?id=110014

Reviewed by Žan Doberšek.

.:

Find needed compiler and linker flags for libseccomp.

* Source/cmake/OptionsGTK.cmake:

Source/WebKit2:

Allow building with ENABLE_SECCOMP_FILTERS=ON. Based on work by Thiago Marcos P. Santos.

* PlatformGTK.cmake: Support ENABLE_SECCOMP_FILTERS build option.
* WebProcess/gtk/SeccompFiltersWebProcessGtk.cpp: Added.
(WebKit::SeccompFiltersWebProcessGtk::SeccompFiltersWebProcessGtk):
(WebKit::SeccompFiltersWebProcessGtk::platformInitialize):
* WebProcess/gtk/SeccompFiltersWebProcessGtk.h: Added.
* WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Initialize default
GTK+ web process seccomp filters.

Tools:

Add libseccomp to jhbuild modulesets.

* gtk/jhbuild.modules:

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp
trunk/Source/cmake/OptionsGTK.cmake
trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules


Added Paths

trunk/Source/WebKit2/WebProcess/gtk/SeccompFiltersWebProcessGtk.cpp
trunk/Source/WebKit2/WebProcess/gtk/SeccompFiltersWebProcessGtk.h




Diff

Modified: trunk/ChangeLog (187010 => 187011)

--- trunk/ChangeLog	2015-07-19 13:16:54 UTC (rev 187010)
+++ trunk/ChangeLog	2015-07-19 16:32:58 UTC (rev 187011)
@@ -1,3 +1,14 @@
+2015-07-19  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] Add seccomp filters support
+https://bugs.webkit.org/show_bug.cgi?id=110014
+
+Reviewed by Žan Doberšek.
+
+Find needed compiler and linker flags for libseccomp.
+
+* Source/cmake/OptionsGTK.cmake:
+
 2015-07-17  Ting-Wei Lan  lant...@gmail.com
 
 Bring back the GNU ar check to create thin archives on non-Linux systems


Modified: trunk/Source/WebKit2/ChangeLog (187010 => 187011)

--- trunk/Source/WebKit2/ChangeLog	2015-07-19 13:16:54 UTC (rev 187010)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-19 16:32:58 UTC (rev 187011)
@@ -1,3 +1,21 @@
+2015-07-19  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] Add seccomp filters support
+https://bugs.webkit.org/show_bug.cgi?id=110014
+
+Reviewed by Žan Doberšek.
+
+Allow building with ENABLE_SECCOMP_FILTERS=ON. Based on work by Thiago Marcos P. Santos.
+
+* PlatformGTK.cmake: Support ENABLE_SECCOMP_FILTERS build option.
+* WebProcess/gtk/SeccompFiltersWebProcessGtk.cpp: Added.
+(WebKit::SeccompFiltersWebProcessGtk::SeccompFiltersWebProcessGtk):
+(WebKit::SeccompFiltersWebProcessGtk::platformInitialize):
+* WebProcess/gtk/SeccompFiltersWebProcessGtk.h: Added.
+* WebProcess/soup/WebProcessSoup.cpp:
+(WebKit::WebProcess::platformInitializeWebProcess): Initialize default
+GTK+ web process seccomp filters.
+
 2015-07-18  Gyuyoung Kim  gyuyoung@webkit.org
 
 Reduce PassRefPtr in WebKit2 - 3


Modified: trunk/Source/WebKit2/PlatformGTK.cmake (187010 => 187011)

--- trunk/Source/WebKit2/PlatformGTK.cmake	2015-07-19 13:16:54 UTC (rev 187010)
+++ trunk/Source/WebKit2/PlatformGTK.cmake	2015-07-19 16:32:58 UTC (rev 187011)
@@ -15,9 +15,12 @@
 
 add_definitions(-DBUILDING_WEBKIT)
 add_definitions(-DWEBKIT2_COMPILATION)
+
+add_definitions(-DLIBEXECDIR=${CMAKE_INSTALL_FULL_LIBEXECDIR})
 add_definitions(-DPKGLIBEXECDIR=${LIBEXEC_INSTALL_DIR})
 add_definitions(-DLOCALEDIR=${CMAKE_INSTALL_FULL_LOCALEDIR})
 add_definitions(-DLIBDIR=${LIB_INSTALL_DIR})
+add_definitions(-DDATADIR=${CMAKE_INSTALL_FULL_DATADIR})
 
 set(WebKit2_USE_PREFIX_HEADER ON)
 
@@ -340,6 +343,8 @@
 WebProcess/WebPage/gtk/WebPageGtk.cpp
 WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp
 
+WebProcess/gtk/SeccompFiltersWebProcessGtk.cpp
+WebProcess/gtk/SeccompFiltersWebProcessGtk.h
 WebProcess/gtk/WebGtkExtensionManager.cpp
 WebProcess/gtk/WebGtkInjectedBundleMain.cpp
 WebProcess/gtk/WebProcessMainGtk.cpp
@@ -474,6 +479,8 @@
 ${WEBKIT2_DIR}/Shared/Downloads/soup
 ${WEBKIT2_DIR}/Shared/Plugins/unix
 ${WEBKIT2_DIR}/Shared/gtk
+${WEBKIT2_DIR}/Shared/linux
+${WEBKIT2_DIR}/Shared/linux/SeccompFilters
 ${WEBKIT2_DIR}/Shared/soup
 ${WEBKIT2_DIR}/Shared/unix
 ${WEBKIT2_DIR}/UIProcess/API/C/cairo
@@ -558,6 +565,21 @@
 )
 endif ()
 
+if (ENABLE_SECCOMP_FILTERS)
+list(APPEND WebKit2_LIBRARIES
+${LIBSECCOMP_LIBRARIES}
+)
+list(APPEND WebKit2_INCLUDE_DIRECTORIES
+${LIBSECCOMP_INCLUDE_DIRS}
+)
+
+# If building with WebKit jhbuild (not GNOME jhbuild), add the root build
+# directory to the filesystem access policy.
+if (DEVELOPER_MODE AND IS_DIRECTORY ${CMAKE_SOURCE_DIR}/WebKitBuild/DependenciesGTK)
+add_definitions(-DSOURCE_DIR=\${CMAKE_SOURCE_DIR}\)
+endif ()
+endif ()
+
 

[webkit-changes] [187015] trunk/Tools

[mcatanzaro]

Title: [187015] trunk/Tools








Revision 187015
Author mcatanz...@igalia.com
Date 2015-07-19 15:27:00 -0700 (Sun, 19 Jul 2015)


Log Message
[GTK] Enable seccomp filter API tests
https://bugs.webkit.org/show_bug.cgi?id=140071

Reviewed by Žan Doberšek.

These tests will now be run by the run-gtk-tests script.

* TestWebKitAPI/PlatformGTK.cmake:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/PlatformGTK.cmake




Diff

Modified: trunk/Tools/ChangeLog (187014 => 187015)

--- trunk/Tools/ChangeLog	2015-07-19 19:31:36 UTC (rev 187014)
+++ trunk/Tools/ChangeLog	2015-07-19 22:27:00 UTC (rev 187015)
@@ -1,5 +1,16 @@
 2015-07-19  Michael Catanzaro  mcatanz...@igalia.com
 
+[GTK] Enable seccomp filter API tests
+https://bugs.webkit.org/show_bug.cgi?id=140071
+
+Reviewed by Žan Doberšek.
+
+These tests will now be run by the run-gtk-tests script.
+
+* TestWebKitAPI/PlatformGTK.cmake:
+
+2015-07-19  Michael Catanzaro  mcatanz...@igalia.com
+
 [GTK] Add seccomp filters support
 https://bugs.webkit.org/show_bug.cgi?id=110014
 


Modified: trunk/Tools/TestWebKitAPI/PlatformGTK.cmake (187014 => 187015)

--- trunk/Tools/TestWebKitAPI/PlatformGTK.cmake	2015-07-19 19:31:36 UTC (rev 187014)
+++ trunk/Tools/TestWebKitAPI/PlatformGTK.cmake	2015-07-19 22:27:00 UTC (rev 187015)
@@ -118,6 +118,20 @@
 set_tests_properties(TestWebKit2 PROPERTIES TIMEOUT 60)
 set_target_properties(TestWebKit2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2)
 
+if (ENABLE_SECCOMP_FILTERS)
+# This test needs to be in its own executable. It's a general test of the
+# seccomp filter mechanism, and the filters it sets are incompatible with
+# the correct operation of WebKit and the other tests.
+add_executable(TestSeccompFilters
+${TESTWEBKITAPI_DIR}/Tests/WebKit2/SeccompFilters.cpp
+)
+
+target_link_libraries(TestSeccompFilters ${test_webkit2_api_LIBRARIES})
+add_test(TestSeccompFilters ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2/TestWebKit2)
+set_tests_properties(TestSeccompFilters PROPERTIES TIMEOUT 5)
+set_target_properties(TestSeccompFilters PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2)
+endif ()
+
 set(TestWebCoreGtk_SOURCES
 ${TESTWEBKITAPI_DIR}/Tests/WebCore/gtk/UserAgentQuirks.cpp
 )






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [187013] trunk/Source/WebKit2

[mcatanzaro]

Title: [187013] trunk/Source/WebKit2








Revision 187013
Author mcatanz...@igalia.com
Date 2015-07-19 12:14:44 -0700 (Sun, 19 Jul 2015)


Log Message
Unreviewed, placate -Wmismatched-tags after r187011

It's basically bug #146990 again. Oops.

* WebProcess/gtk/SeccompFiltersWebProcessGtk.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/gtk/SeccompFiltersWebProcessGtk.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (187012 => 187013)

--- trunk/Source/WebKit2/ChangeLog	2015-07-19 16:57:44 UTC (rev 187012)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-19 19:14:44 UTC (rev 187013)
@@ -1,5 +1,13 @@
 2015-07-19  Michael Catanzaro  mcatanz...@igalia.com
 
+Unreviewed, placate -Wmismatched-tags after r187011
+
+It's basically bug #146990 again. Oops.
+
+* WebProcess/gtk/SeccompFiltersWebProcessGtk.h:
+
+2015-07-19  Michael Catanzaro  mcatanz...@igalia.com
+
 [GTK] Add seccomp filters support
 https://bugs.webkit.org/show_bug.cgi?id=110014
 


Modified: trunk/Source/WebKit2/WebProcess/gtk/SeccompFiltersWebProcessGtk.h (187012 => 187013)

--- trunk/Source/WebKit2/WebProcess/gtk/SeccompFiltersWebProcessGtk.h	2015-07-19 16:57:44 UTC (rev 187012)
+++ trunk/Source/WebKit2/WebProcess/gtk/SeccompFiltersWebProcessGtk.h	2015-07-19 19:14:44 UTC (rev 187013)
@@ -33,7 +33,7 @@
 
 namespace WebKit {
 
-class WebProcessCreationParameters;
+struct WebProcessCreationParameters;
 
 class SeccompFiltersWebProcessGtk : public SeccompFilters {
 public:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186762] trunk/Source/WebKit2

[mcatanzaro]

Title: [186762] trunk/Source/WebKit2








Revision 186762
Author mcatanz...@igalia.com
Date 2015-07-13 08:42:11 -0700 (Mon, 13 Jul 2015)


Log Message
[Linux] SeccompFilters: handle alternate install prefixes
https://bugs.webkit.org/show_bug.cgi?id=140065

Reviewed by Žan Doberšek.

If the install prefix is something other than /usr, e.g. /usr/local or
~/jhbuild/install, then we want to make sure to allow libraries and data
from that prefix.

* PlatformEfl.cmake:
* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (186761 => 186762)

--- trunk/Source/WebKit2/ChangeLog	2015-07-13 07:44:18 UTC (rev 186761)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-13 15:42:11 UTC (rev 186762)
@@ -1,3 +1,18 @@
+2015-07-13  Michael Catanzaro  mcatanz...@igalia.com
+
+[Linux] SeccompFilters: handle alternate install prefixes
+https://bugs.webkit.org/show_bug.cgi?id=140065
+
+Reviewed by Žan Doberšek.
+
+If the install prefix is something other than /usr, e.g. /usr/local or
+~/jhbuild/install, then we want to make sure to allow libraries and data
+from that prefix.
+
+* PlatformEfl.cmake:
+* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
+(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):
+
 2015-07-13  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Contents not correctly laid out when the web view is not realized


Modified: trunk/Source/WebKit2/PlatformEfl.cmake (186761 => 186762)

--- trunk/Source/WebKit2/PlatformEfl.cmake	2015-07-13 07:44:18 UTC (rev 186761)
+++ trunk/Source/WebKit2/PlatformEfl.cmake	2015-07-13 15:42:11 UTC (rev 186762)
@@ -476,7 +476,9 @@
 add_definitions(-DTEST_RESOURCES_DIR=\${TEST_RESOURCES_DIR}\
 -DTEST_LIB_DIR=\${CMAKE_LIBRARY_OUTPUT_DIRECTORY}\
 -DGTEST_LINKED_AS_SHARED_LIBRARY=1
+-DLIBDIR=\${LIB_INSTALL_DIR}\
 -DLIBEXECDIR=\${EXEC_INSTALL_DIR}\
+-DDATADIR=\${CMAKE_INSTALL_PREFIX}/share\
 -DEXTENSIONMANAGERDIR=\${CMAKE_INSTALL_PREFIX}/${EWEBKIT_EXTENSION_MANAGER_INSTALL_DIR}\
 -DWEBPROCESSNAME=\WebProcess\
 -DPLUGINPROCESSNAME=\PluginProcess\


Modified: trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp (186761 => 186762)

--- trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp	2015-07-13 07:44:18 UTC (rev 186761)
+++ trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp	2015-07-13 15:42:11 UTC (rev 186762)
@@ -142,6 +142,10 @@
 addDirectoryPermission(ASCIILiteral(/usr/lib64), Read);
 addDirectoryPermission(ASCIILiteral(/usr/share), Read);
 
+// Support for alternative install prefixes, e.g. /usr/local.
+addDirectoryPermission(ASCIILiteral(DATADIR), Read);
+addDirectoryPermission(ASCIILiteral(LIBDIR), Read);
+
 // SSL Certificates.
 addDirectoryPermission(ASCIILiteral(/etc/ssl/certs), Read);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [187030] trunk/Source/WebKit2

[mcatanzaro]

Title: [187030] trunk/Source/WebKit2








Revision 187030
Author mcatanz...@igalia.com
Date 2015-07-20 13:06:27 -0700 (Mon, 20 Jul 2015)


Log Message
[Seccomp] Should be easier to debug blocked syscalls
https://bugs.webkit.org/show_bug.cgi?id=142980

These should be printed even when not running in debug mode. There is no
value in hiding errors from release build users.

Reviewed by Žan Doberšek.

* Shared/linux/SeccompFilters/SeccompBroker.cpp:
(WebKit::SeccompBroker::runLoop): Don't close stderr et. al. in release builds.
* Shared/linux/SeccompFilters/Syscall.cpp:
(WebKit::write_uint): Added.
(WebKit::reportUnexpectedSyscall): Added.
(WebKit::Syscall::createFromContext): Call reportUnexpectedSyscall. Also, no need to crash
here in release builds.
* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
(WebKit::SyscallPolicy::hasPermissionForPath): Print a warning when access is denied.
(WebKit::SyscallPolicy::permissionToString): Added.
* Shared/linux/SeccompFilters/SyscallPolicy.h: Add permissionToString.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp
trunk/Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.cpp
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SyscallPolicy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (187029 => 187030)

--- trunk/Source/WebKit2/ChangeLog	2015-07-20 19:50:54 UTC (rev 187029)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-20 20:06:27 UTC (rev 187030)
@@ -1,3 +1,25 @@
+2015-07-20  Michael Catanzaro  mcatanz...@igalia.com
+
+[Seccomp] Should be easier to debug blocked syscalls
+https://bugs.webkit.org/show_bug.cgi?id=142980
+
+These should be printed even when not running in debug mode. There is no
+value in hiding errors from release build users.
+
+Reviewed by Žan Doberšek.
+
+* Shared/linux/SeccompFilters/SeccompBroker.cpp:
+(WebKit::SeccompBroker::runLoop): Don't close stderr et. al. in release builds.
+* Shared/linux/SeccompFilters/Syscall.cpp:
+(WebKit::write_uint): Added.
+(WebKit::reportUnexpectedSyscall): Added.
+(WebKit::Syscall::createFromContext): Call reportUnexpectedSyscall. Also, no need to crash
+here in release builds.
+* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
+(WebKit::SyscallPolicy::hasPermissionForPath): Print a warning when access is denied.
+(WebKit::SyscallPolicy::permissionToString): Added.
+* Shared/linux/SeccompFilters/SyscallPolicy.h: Add permissionToString.
+
 2015-07-20  Csaba Osztrogonác  o...@webkit.org
 
 Fix the !ENABLE(VIDEO) build after r186396


Modified: trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp (187029 => 187030)

--- trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp	2015-07-20 19:50:54 UTC (rev 187029)
+++ trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp	2015-07-20 20:06:27 UTC (rev 187030)
@@ -320,16 +320,11 @@
 
 NO_RETURN void SeccompBroker::runLoop(int socket)
 {
-#ifndef NDEBUG
-int i = STDERR_FILENO + 1;
-#else
-int i = 0;
-#endif
-// Close all inherited file descriptors other
-// than the socket to the sandboxed process.
-for (; i  FD_SETSIZE; ++i)
+// Close unnecessary inherited file descriptors.
+for (int i = STDERR_FILENO + 1; i  FD_SETSIZE; ++i) {
 if (i != socket)
 close(i);
+}
 
 while (true) {
 char buffer[messageMaxSize];


Modified: trunk/Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp (187029 => 187030)

--- trunk/Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp	2015-07-20 19:50:54 UTC (rev 187029)
+++ trunk/Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp	2015-07-20 20:06:27 UTC (rev 187030)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2013 Intel Corporation. All rights reserved.
+ * Copyright (C) 2015 Igalia S.L.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -32,10 +33,47 @@
 #include OpenSyscall.h
 #include SigactionSyscall.h
 #include SigprocmaskSyscall.h
+#include limits
 #include seccomp.h
+#include string.h
+#include unistd.h
 
 namespace WebKit {
 
+// The redundant constexpr const is to placate Clang's -Wwritable-strings.
+static constexpr const char* const message = Blocked unexpected syscall: ;
+
+// Since sprintf is not signal-safe, reimplement %d here. Based on code from
+// http://outflux.net/teach-seccomp by Will Drewry and Kees Cook, released under
+// the Chromium BSD license.
+static void writeUnsignedInt(char* buf, unsigned val)
+{
+int width = 0;
+unsigned tens;
+
+if (!val) {
+strcpy(buf, 0);
+return;
+}
+for (tens = val; tens; tens /= 10)
+++width;
+buf[width] = '\0';
+for (tens = val; tens; tens /= 10)
+buf[--width] = '0' + 

[webkit-changes] [187101] trunk/Source/WebCore

[mcatanzaro]

Title: [187101] trunk/Source/WebCore








Revision 187101
Author mcatanz...@igalia.com
Date 2015-07-20 23:18:24 -0700 (Mon, 20 Jul 2015)


Log Message
REGRESSION(r184376): [SOUP] Multiple assertions when downloading files
https://bugs.webkit.org/show_bug.cgi?id=147039

Reviewed by Darin Adler.

No new tests; this will be covered once we enable the network process for API tests.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::releaseForDownload): Call RefPtrBase::relaxAdoptionRequirement so
that we don't assert when storing the non-adopted ResourceHandle in a RefPtr. The ref will
be dropped in ResourceHandle::cleanupSoupOperation, which as the comment says should always
run. HOPEFULLY.
(WebCore::ResourceHandle::continueWillSendRequest): Don't assert that client() is nonnull,
because the code clearly expects and handles the case where it is null.
(WebCore::ResourceHandle::continueDidReceiveResponse): Ditto; note that here client() will
always be null for a download.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (187100 => 187101)

--- trunk/Source/WebCore/ChangeLog	2015-07-21 06:06:18 UTC (rev 187100)
+++ trunk/Source/WebCore/ChangeLog	2015-07-21 06:18:24 UTC (rev 187101)
@@ -1,3 +1,22 @@
+2015-07-20  Michael Catanzaro  mcatanz...@igalia.com
+
+REGRESSION(r184376): [SOUP] Multiple assertions when downloading files
+https://bugs.webkit.org/show_bug.cgi?id=147039
+
+Reviewed by Darin Adler.
+
+No new tests; this will be covered once we enable the network process for API tests.
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::ResourceHandle::releaseForDownload): Call RefPtrBase::relaxAdoptionRequirement so
+that we don't assert when storing the non-adopted ResourceHandle in a RefPtr. The ref will
+be dropped in ResourceHandle::cleanupSoupOperation, which as the comment says should always
+run. HOPEFULLY.
+(WebCore::ResourceHandle::continueWillSendRequest): Don't assert that client() is nonnull,
+because the code clearly expects and handles the case where it is null.
+(WebCore::ResourceHandle::continueDidReceiveResponse): Ditto; note that here client() will
+always be null for a download.
+
 2015-07-20  Ada Chan  adac...@apple.com
 
 Follow-up to my earlier fix for r147085


Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (187100 => 187101)

--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2015-07-21 06:06:18 UTC (rev 187100)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2015-07-21 06:18:24 UTC (rev 187101)
@@ -1036,14 +1036,15 @@
 RefPtrResourceHandle ResourceHandle::releaseForDownload(ResourceHandleClient* downloadClient)
 {
 // We don't adopt the ref, as it will be released by cleanupSoupRequestOperation, which should always run.
-RefPtrResourceHandle newHandle = new ResourceHandle(d-m_context.get(), firstRequest(), nullptr, d-m_defersLoading, d-m_shouldContentSniff);
+ResourceHandle* newHandle = new ResourceHandle(d-m_context.get(), firstRequest(), nullptr, d-m_defersLoading, d-m_shouldContentSniff);
+newHandle-relaxAdoptionRequirement();
 std::swap(d, newHandle-d);
 
 g_signal_handlers_disconnect_matched(newHandle-d-m_soupMessage.get(), G_SIGNAL_MATCH_DATA, 0, 0, nullptr, nullptr, this);
-g_object_set_data(G_OBJECT(newHandle-d-m_soupMessage.get()), handle, newHandle.get());
+g_object_set_data(G_OBJECT(newHandle-d-m_soupMessage.get()), handle, newHandle);
 
 newHandle-d-m_client = downloadClient;
-continueAfterDidReceiveResponse(newHandle.get());
+continueAfterDidReceiveResponse(newHandle);
 
 return newHandle;
 }
@@ -1366,15 +1367,13 @@
 
 void ResourceHandle::continueWillSendRequest(const ResourceRequest request)
 {
-ASSERT(client());
-ASSERT(client()-usesAsyncCallbacks());
+ASSERT(!client() || client()-usesAsyncCallbacks());
 continueAfterWillSendRequest(this, request);
 }
 
 void ResourceHandle::continueDidReceiveResponse()
 {
-ASSERT(client());
-ASSERT(client()-usesAsyncCallbacks());
+ASSERT(!client() || client()-usesAsyncCallbacks());
 continueAfterDidReceiveResponse(this);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186839] trunk/Source/WebKit2

[mcatanzaro]

Title: [186839] trunk/Source/WebKit2








Revision 186839
Author mcatanz...@igalia.com
Date 2015-07-15 09:01:32 -0700 (Wed, 15 Jul 2015)


Log Message
[Linux] SeccompBrokerClient should cache arbitrary file descriptors
https://bugs.webkit.org/show_bug.cgi?id=140068

Reviewed by Žan Doberšek.

If malloc() attempts to open /proc/sys/vm/overcommit_memory in a SIGSYS
signal handler, the SeccompBroker will attempt to recursively broker the
open() syscall. Generalize the existing code that already handles the
similar case where malloc() opens /sys/devices/system/cpu/online to
handle this situation as well.

* Shared/linux/SeccompFilters/SeccompBroker.cpp:
(WebKit::SIGSYSHandler):
(WebKit::SeccompBrokerClient::SeccompBrokerClient):
(WebKit::SeccompBrokerClient::~SeccompBrokerClient):
(WebKit::SeccompBrokerClient::handleIfOpeningCachedFile):
(WebKit::SeccompBrokerClient::cacheFile):
(WebKit::SeccompBrokerClient::handleIfOpeningOnlineCPUCount): Deleted.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (186838 => 186839)

--- trunk/Source/WebKit2/ChangeLog	2015-07-15 14:47:47 UTC (rev 186838)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-15 16:01:32 UTC (rev 186839)
@@ -1,3 +1,24 @@
+2015-07-15  Michael Catanzaro  mcatanz...@igalia.com
+
+[Linux] SeccompBrokerClient should cache arbitrary file descriptors
+https://bugs.webkit.org/show_bug.cgi?id=140068
+
+Reviewed by Žan Doberšek.
+
+If malloc() attempts to open /proc/sys/vm/overcommit_memory in a SIGSYS
+signal handler, the SeccompBroker will attempt to recursively broker the
+open() syscall. Generalize the existing code that already handles the
+similar case where malloc() opens /sys/devices/system/cpu/online to
+handle this situation as well.
+
+* Shared/linux/SeccompFilters/SeccompBroker.cpp:
+(WebKit::SIGSYSHandler):
+(WebKit::SeccompBrokerClient::SeccompBrokerClient):
+(WebKit::SeccompBrokerClient::~SeccompBrokerClient):
+(WebKit::SeccompBrokerClient::handleIfOpeningCachedFile):
+(WebKit::SeccompBrokerClient::cacheFile):
+(WebKit::SeccompBrokerClient::handleIfOpeningOnlineCPUCount): Deleted.
+
 2015-07-15  ChangSeok Oh  changseok...@collabora.com
 
 [GTK] Accelerated compositing is enabled by MiniBrowser in Wayland


Modified: trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp (186838 => 186839)

--- trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp	2015-07-15 14:47:47 UTC (rev 186838)
+++ trunk/Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp	2015-07-15 16:01:32 UTC (rev 186839)
@@ -46,7 +46,6 @@
 #endif
 
 static const size_t messageMaxSize = 4096;
-static const char onlineCPUCountPath[] = /sys/devices/system/cpu/online;
 
 namespace WebKit {
 
@@ -57,15 +56,19 @@
 
 void dispatch(Syscall*) const;
 
-bool handleIfOpeningOnlineCPUCount(mcontext_t*) const;
+bool handleIfOpeningCachedFile(mcontext_t*) const;
 
 private:
 SeccompBrokerClient(int socket);
 
+void cacheFile(const char* path);
+
 int m_socket;
-int m_onlineCPUCountFd;
 
 mutable Mutex m_socketLock;
+
+// Maps files that may be read by malloc() to open file descriptors.
+HashMapString, int m_fileDescriptorCache;
 };
 
 static ssize_t sendMessage(int socket, void* data, size_t size, int fd = -1)
@@ -142,7 +145,7 @@
 
 SeccompBrokerClient* client = SeccompBrokerClient::singleton();
 
-if (client-handleIfOpeningOnlineCPUCount(ucontext-uc_mcontext))
+if (client-handleIfOpeningCachedFile(ucontext-uc_mcontext))
 return;
 
 // createFromContext might return a nullptr if it is able to resolve the
@@ -183,15 +186,18 @@
 
 SeccompBrokerClient::SeccompBrokerClient(int socket)
 : m_socket(socket)
-, m_onlineCPUCountFd(open(onlineCPUCountPath, O_RDONLY))
 {
-ASSERT(m_socket = 0  m_onlineCPUCountFd = 0);
+ASSERT(m_socket = 0);
+
+cacheFile(/proc/sys/vm/overcommit_memory);
+cacheFile(/sys/devices/system/cpu/online);
 }
 
 SeccompBrokerClient::~SeccompBrokerClient()
 {
+for (int fd : m_fileDescriptorCache.values())
+close(fd);
 close(m_socket);
-close(m_onlineCPUCountFd);
 }
 
 void SeccompBrokerClient::dispatch(Syscall* syscall) const
@@ -227,25 +233,35 @@
 syscall-setResult(result.get());
 }
 
-bool SeccompBrokerClient::handleIfOpeningOnlineCPUCount(mcontext_t* context) const
+bool SeccompBrokerClient::handleIfOpeningCachedFile(mcontext_t* context) const
 {
 if (context-gregs[REG_SYSCALL] != __NR_open)
 return false;
 
 const char *path = reinterpret_castchar*(context-gregs[REG_ARG0]);
-if (strcmp(onlineCPUCountPath, path))
+
+auto iter = m_fileDescriptorCache.find(path);
+if (iter == m_fileDescriptorCache.end())
 return false;
 
 // Malloc will eventually check the number of 

[webkit-changes] [192129] trunk/Source/WebCore

[mcatanzaro]

Title: [192129] trunk/Source/WebCore








Revision 192129
Author mcatanz...@igalia.com
Date 2015-11-07 07:22:30 -0800 (Sat, 07 Nov 2015)


Log Message
Unreviewed, fix GTK build after r191981

* html/HTMLFormControlElement.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFormControlElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (192128 => 192129)

--- trunk/Source/WebCore/ChangeLog	2015-11-07 05:23:55 UTC (rev 192128)
+++ trunk/Source/WebCore/ChangeLog	2015-11-07 15:22:30 UTC (rev 192129)
@@ -1,3 +1,9 @@
+2015-11-07  Michael Catanzaro  
+
+Unreviewed, fix GTK build after r191981
+
+* html/HTMLFormControlElement.cpp:
+
 2015-11-06  Scott Valentine  
 
 Allow an optional hash algorithm to be passed to generateKey for RSA keys.


Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (192128 => 192129)

--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp	2015-11-07 05:23:55 UTC (rev 192128)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp	2015-11-07 15:22:30 UTC (rev 192129)
@@ -39,6 +39,7 @@
 #include "RenderBox.h"
 #include "RenderTheme.h"
 #include "ValidationMessage.h"
+#include 
 #include 
 #include 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192130] trunk/Source/WebCore

[mcatanzaro]

Title: [192130] trunk/Source/WebCore








Revision 192130
Author mcatanz...@igalia.com
Date 2015-11-07 09:17:47 -0800 (Sat, 07 Nov 2015)


Log Message
Node.h:392:12: warning: 'this' pointer cannot be null in well-defined C++ code
https://bugs.webkit.org/show_bug.cgi?id=150996

Reviewed by Andreas Kling.

Remove ASSERT(this) statement that is triggering hundreds of warnings from Clang.

* dom/Node.h:
(WebCore::Node::document):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (192129 => 192130)

--- trunk/Source/WebCore/ChangeLog	2015-11-07 15:22:30 UTC (rev 192129)
+++ trunk/Source/WebCore/ChangeLog	2015-11-07 17:17:47 UTC (rev 192130)
@@ -1,5 +1,17 @@
 2015-11-07  Michael Catanzaro  
 
+Node.h:392:12: warning: 'this' pointer cannot be null in well-defined C++ code
+https://bugs.webkit.org/show_bug.cgi?id=150996
+
+Reviewed by Andreas Kling.
+
+Remove ASSERT(this) statement that is triggering hundreds of warnings from Clang.
+
+* dom/Node.h:
+(WebCore::Node::document):
+
+2015-11-07  Michael Catanzaro  
+
 Unreviewed, fix GTK build after r191981
 
 * html/HTMLFormControlElement.cpp:


Modified: trunk/Source/WebCore/dom/Node.h (192129 => 192130)

--- trunk/Source/WebCore/dom/Node.h	2015-11-07 15:22:30 UTC (rev 192129)
+++ trunk/Source/WebCore/dom/Node.h	2015-11-07 17:17:47 UTC (rev 192130)
@@ -389,7 +389,6 @@
 // A Document node returns itself.
 Document& document() const
 {
-ASSERT(this);
 return treeScope().documentScope();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192095] trunk

[mcatanzaro]

Title: [192095] trunk








Revision 192095
Author mcatanz...@igalia.com
Date 2015-11-06 01:39:30 -0800 (Fri, 06 Nov 2015)


Log Message
[GTK] Re-enable Quartz backend on cmake build system
https://bugs.webkit.org/show_bug.cgi?id=144561

Reviewed by Philippe Normand.

* Source/cmake/FindGTK3.cmake: Set GTK3_SUPPORTS_QUARTZ based on
the presence of of gtk+-quartz-3.0 module.
* Source/cmake/OptionsGTK.cmake: Reintroduce the
ENABLE_QUARTZ_TARGET option to the CMake build, for building the
GTK+ Quartz backend on OS X.

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/FindGTK3.cmake
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (192094 => 192095)

--- trunk/ChangeLog	2015-11-06 07:28:00 UTC (rev 192094)
+++ trunk/ChangeLog	2015-11-06 09:39:30 UTC (rev 192095)
@@ -1,3 +1,16 @@
+2015-11-06  Philip Chimento   and Michael Catanzaro 
+
+[GTK] Re-enable Quartz backend on cmake build system
+https://bugs.webkit.org/show_bug.cgi?id=144561
+
+Reviewed by Philippe Normand.
+
+* Source/cmake/FindGTK3.cmake: Set GTK3_SUPPORTS_QUARTZ based on
+the presence of of gtk+-quartz-3.0 module.
+* Source/cmake/OptionsGTK.cmake: Reintroduce the
+ENABLE_QUARTZ_TARGET option to the CMake build, for building the
+GTK+ Quartz backend on OS X.
+
 2015-11-05  Nikos Andronikos  
 
 Add runtime and compile time flags for enabling Web Animations API and model.


Modified: trunk/Source/cmake/FindGTK3.cmake (192094 => 192095)

--- trunk/Source/cmake/FindGTK3.cmake	2015-11-06 07:28:00 UTC (rev 192094)
+++ trunk/Source/cmake/FindGTK3.cmake	2015-11-06 09:39:30 UTC (rev 192095)
@@ -5,6 +5,7 @@
 #  GTK3_INCLUDE_DIRS - the GTK+ 3. include directories
 #  GTK3_LIBRARIES - link these to use GTK+ 3.
 #  GTK3_SUPPORTS_GESTURES - GTK+ supports gestures (GTK+ >= 3.14)
+#  GTK3_SUPPORTS_QUARTZ - GTK+ supports Quartz backend
 #  GTK3_SUPPORTS_X11 - GTK+ supports X11 backend
 #  GTK3_SUPPORTS_WAYLAND - GTK+ supports Wayland backend
 #
@@ -49,6 +50,11 @@
 endif ()
 
 if (GTK3_VERSION AND VERSION_OK)
+pkg_check_modules(GTK3_QUARTZ gtk+-quartz-3.0)
+if ("${GTK3_QUARTZ_VERSION}" VERSION_EQUAL "${GTK3_VERSION}")
+set(GTK3_SUPPORTS_QUARTZ TRUE)
+endif ()
+
 pkg_check_modules(GTK3_X11 gtk+-x11-3.0)
 if ("${GTK3_X11_VERSION}" VERSION_EQUAL "${GTK3_VERSION}")
 set(GTK3_SUPPORTS_X11 TRUE)


Modified: trunk/Source/cmake/OptionsGTK.cmake (192094 => 192095)

--- trunk/Source/cmake/OptionsGTK.cmake	2015-11-06 07:28:00 UTC (rev 192094)
+++ trunk/Source/cmake/OptionsGTK.cmake	2015-11-06 09:39:30 UTC (rev 192095)
@@ -71,6 +71,7 @@
 WEBKIT_OPTION_DEFINE(ENABLE_INTROSPECTION "Whether to enable GObject introspection." PUBLIC ON)
 WEBKIT_OPTION_DEFINE(ENABLE_OPENGL "Whether to use OpenGL." PUBLIC ON)
 WEBKIT_OPTION_DEFINE(ENABLE_PLUGIN_PROCESS_GTK2 "Whether to build WebKitPluginProcess2 to load GTK2 based plugins." PUBLIC ON)
+WEBKIT_OPTION_DEFINE(ENABLE_QUARTZ_TARGET "Whether to enable support for the Quartz windowing target." PUBLIC ${GTK3_SUPPORTS_QUARTZ})
 WEBKIT_OPTION_DEFINE(ENABLE_X11_TARGET "Whether to enable support for the X11 windowing target." PUBLIC ${GTK3_SUPPORTS_X11})
 WEBKIT_OPTION_DEFINE(ENABLE_WAYLAND_TARGET "Whether to enable support for the Wayland windowing target." PUBLIC ${GTK3_SUPPORTS_WAYLAND})
 WEBKIT_OPTION_DEFINE(USE_LIBNOTIFY "Whether to enable the default web notification implementation." PUBLIC ON)
@@ -186,6 +187,7 @@
 # this point, and do not attempt to change any option after this point.
 WEBKIT_OPTION_END()
 
+SET_AND_EXPOSE_TO_BUILD(WTF_PLATFORM_QUARTZ ${ENABLE_QUARTZ_TARGET})
 SET_AND_EXPOSE_TO_BUILD(WTF_PLATFORM_X11 ${ENABLE_X11_TARGET})
 SET_AND_EXPOSE_TO_BUILD(WTF_PLATFORM_WAYLAND ${ENABLE_WAYLAND_TARGET})
 
@@ -392,6 +394,12 @@
 SET_AND_EXPOSE_TO_BUILD(USE_GSTREAMER TRUE)
 endif ()
 
+if (ENABLE_QUARTZ_TARGET)
+if (NOT GTK3_SUPPORTS_QUARTZ)
+message(FATAL_ERROR "Recompile GTK+ with Quartz backend to use ENABLE_QUARTZ_TARGET")
+endif ()
+endif ()
+
 if (ENABLE_X11_TARGET)
 if (NOT GTK3_SUPPORTS_X11)
 message(FATAL_ERROR "Recompile GTK+ with X11 backend to use ENABLE_X11_TARGET")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190726] trunk/Source/WebKit2

[mcatanzaro]

Title: [190726] trunk/Source/WebKit2








Revision 190726
Author mcatanz...@igalia.com
Date 2015-10-08 08:29:47 -0700 (Thu, 08 Oct 2015)


Log Message
Format string issues in NetworkCache.cpp
https://bugs.webkit.org/show_bug.cgi?id=149867

Reviewed by Csaba Osztrogonác.

Cast enums to ints before printing them to placate GCC's -Wformat.

* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::store):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (190725 => 190726)

--- trunk/Source/WebKit2/ChangeLog	2015-10-08 15:27:36 UTC (rev 190725)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-08 15:29:47 UTC (rev 190726)
@@ -1,5 +1,18 @@
 2015-10-08  Michael Catanzaro  
 
+Format string issues in NetworkCache.cpp
+https://bugs.webkit.org/show_bug.cgi?id=149867
+
+Reviewed by Csaba Osztrogonác.
+
+Cast enums to ints before printing them to placate GCC's -Wformat.
+
+* NetworkProcess/cache/NetworkCache.cpp:
+(WebKit::NetworkCache::Cache::retrieve):
+(WebKit::NetworkCache::Cache::store):
+
+2015-10-08  Michael Catanzaro  
+
 Format string issue in WebResourceLoadScheduler.cpp
 https://bugs.webkit.org/show_bug.cgi?id=149868
 


Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp (190725 => 190726)

--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp	2015-10-08 15:27:36 UTC (rev 190725)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp	2015-10-08 15:29:47 UTC (rev 190726)
@@ -334,7 +334,7 @@
 ASSERT(isEnabled());
 ASSERT(originalRequest.url().protocolIsInHTTPFamily());
 
-LOG(NetworkCache, "(NetworkProcess) retrieving %s priority %u", originalRequest.url().string().ascii().data(), originalRequest.priority());
+LOG(NetworkCache, "(NetworkProcess) retrieving %s priority %d", originalRequest.url().string().ascii().data(), static_cast(originalRequest.priority()));
 
 if (m_statistics)
 m_statistics->recordRetrievalRequest(webPageID);
@@ -380,7 +380,7 @@
 
 #if !LOG_DISABLED
 auto elapsedMS = static_cast(std::chrono::duration_cast(std::chrono::system_clock::now() - startTime).count());
-LOG(NetworkCache, "(NetworkProcess) retrieve complete useDecision=%d priority=%u time=%" PRIi64 "ms", useDecision, originalRequest.priority(), elapsedMS);
+LOG(NetworkCache, "(NetworkProcess) retrieve complete useDecision=%d priority=%d time=%" PRIi64 "ms", static_cast(useDecision), static_cast(originalRequest.priority()), elapsedMS);
 #endif
 completionHandler(WTF::move(entry));
 
@@ -406,7 +406,7 @@
 
 StoreDecision storeDecision = makeStoreDecision(originalRequest, response);
 if (storeDecision != StoreDecision::Yes) {
-LOG(NetworkCache, "(NetworkProcess) didn't store, storeDecision=%d", storeDecision);
+LOG(NetworkCache, "(NetworkProcess) didn't store, storeDecision=%d", static_cast(storeDecision));
 auto key = makeCacheKey(originalRequest);
 
 auto isSuccessfulRevalidation = response.httpStatusCode() == 304;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190724] trunk/Source/WebKit2

[mcatanzaro]

Title: [190724] trunk/Source/WebKit2








Revision 190724
Author mcatanz...@igalia.com
Date 2015-10-08 08:27:06 -0700 (Thu, 08 Oct 2015)


Log Message
Format string issue in WebResourceLoadScheduler.cpp
https://bugs.webkit.org/show_bug.cgi?id=149868

Reviewed by Csaba Osztrogonác.

Cast enums to ints before printing them to placate GCC's -Wformat.

* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (190723 => 190724)

--- trunk/Source/WebKit2/ChangeLog	2015-10-08 15:23:24 UTC (rev 190723)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-08 15:27:06 UTC (rev 190724)
@@ -1,3 +1,15 @@
+2015-10-08  Michael Catanzaro  
+
+Format string issue in WebResourceLoadScheduler.cpp
+https://bugs.webkit.org/show_bug.cgi?id=149868
+
+Reviewed by Csaba Osztrogonác.
+
+Cast enums to ints before printing them to placate GCC's -Wformat.
+
+* WebProcess/Network/WebResourceLoadScheduler.cpp:
+(WebKit::WebResourceLoadScheduler::scheduleLoad):
+
 2015-10-08  Carlos Garcia Campos  
 
 [GTK] Stop using a nested main loop for popup menus


Modified: trunk/Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp (190723 => 190724)

--- trunk/Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp	2015-10-08 15:23:24 UTC (rev 190723)
+++ trunk/Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp	2015-10-08 15:27:06 UTC (rev 190724)
@@ -155,7 +155,7 @@
 }
 #endif
 
-LOG(NetworkScheduling, "(WebProcess) WebResourceLoadScheduler::scheduleLoad, url '%s' will be scheduled with the NetworkProcess with priority %u", resourceLoader->url().string().utf8().data(), resourceLoader->request().priority());
+LOG(NetworkScheduling, "(WebProcess) WebResourceLoadScheduler::scheduleLoad, url '%s' will be scheduled with the NetworkProcess with priority %d", resourceLoader->url().string().utf8().data(), static_cast(resourceLoader->request().priority()));
 
 ContentSniffingPolicy contentSniffingPolicy = resourceLoader->shouldSniffContent() ? SniffContent : DoNotSniffContent;
 StoredCredentials allowStoredCredentials = resourceLoader->shouldUseCredentialStorage() ? AllowStoredCredentials : DoNotAllowStoredCredentials;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190725] trunk/Source/WebCore

[mcatanzaro]

Title: [190725] trunk/Source/WebCore








Revision 190725
Author mcatanz...@igalia.com
Date 2015-10-08 08:27:36 -0700 (Thu, 08 Oct 2015)


Log Message
Format string issues in LegacyRequest.cpp
https://bugs.webkit.org/show_bug.cgi?id=149866

Reviewed by Csaba Osztrogonác.

Cast enums to ints before printing them to placate GCC's -Wformat.

* Modules/indexeddb/legacy/LegacyRequest.cpp:
(WebCore::LegacyRequest::dispatchEvent):
(WebCore::LegacyRequest::enqueueEvent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyRequest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (190724 => 190725)

--- trunk/Source/WebCore/ChangeLog	2015-10-08 15:27:06 UTC (rev 190724)
+++ trunk/Source/WebCore/ChangeLog	2015-10-08 15:27:36 UTC (rev 190725)
@@ -1,3 +1,16 @@
+2015-10-08  Michael Catanzaro  
+
+Format string issues in LegacyRequest.cpp
+https://bugs.webkit.org/show_bug.cgi?id=149866
+
+Reviewed by Csaba Osztrogonác.
+
+Cast enums to ints before printing them to placate GCC's -Wformat.
+
+* Modules/indexeddb/legacy/LegacyRequest.cpp:
+(WebCore::LegacyRequest::dispatchEvent):
+(WebCore::LegacyRequest::enqueueEvent):
+
 2015-10-08  Commit Queue  
 
 Unreviewed, rolling out r190716.


Modified: trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyRequest.cpp (190724 => 190725)

--- trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyRequest.cpp	2015-10-08 15:27:06 UTC (rev 190724)
+++ trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyRequest.cpp	2015-10-08 15:27:36 UTC (rev 190725)
@@ -475,7 +475,7 @@
 ASSERT(m_enqueuedEvents.size());
 ASSERT(scriptExecutionContext());
 ASSERT(event->target() == this);
-ASSERT_WITH_MESSAGE(m_readyState < IDBRequestReadyState::Done, "When dispatching event %s, m_readyState < DONE(%d), was %d", event->type().string().utf8().data(), IDBRequestReadyState::Done, m_readyState);
+ASSERT_WITH_MESSAGE(m_readyState < IDBRequestReadyState::Done, "When dispatching event %s, m_readyState < DONE(%d), was %d", event->type().string().utf8().data(), static_cast(IDBRequestReadyState::Done), static_cast(m_readyState));
 
 DOMRequestState::Scope scope(m_requestState);
 
@@ -572,7 +572,7 @@
 if (m_contextStopped || !scriptExecutionContext())
 return;
 
-ASSERT_WITH_MESSAGE(m_readyState == IDBRequestReadyState::Pending || m_didFireUpgradeNeededEvent, "When queueing event %s, m_readyState was %d", event->type().string().utf8().data(), m_readyState);
+ASSERT_WITH_MESSAGE(m_readyState == IDBRequestReadyState::Pending || m_didFireUpgradeNeededEvent, "When queueing event %s, m_readyState was %d", event->type().string().utf8().data(), static_cast(m_readyState));
 
 event->setTarget(this);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190862] trunk/Source/JavaScriptCore

[mcatanzaro]

Title: [190862] trunk/Source/_javascript_Core








Revision 190862
Author mcatanz...@igalia.com
Date 2015-10-12 10:59:45 -0700 (Mon, 12 Oct 2015)


Log Message
webkit-gtk 2.3.3 fails to build on OS X - Conflicting type "Fixed"
https://bugs.webkit.org/show_bug.cgi?id=126433

Patch by Philip Chimento  on 2015-10-12
Reviewed by Philippe Normand

Don't include CoreFoundation.h when building the GTK port.

* Source/_javascript_Core/API/WebKitAvailability.h: Add !defined(BUILDING_GTK__) to defined(__APPLE__).

Modified Paths

trunk/Source/_javascript_Core/API/WebKitAvailability.h
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/WebKitAvailability.h (190861 => 190862)

--- trunk/Source/_javascript_Core/API/WebKitAvailability.h	2015-10-12 17:59:05 UTC (rev 190861)
+++ trunk/Source/_javascript_Core/API/WebKitAvailability.h	2015-10-12 17:59:45 UTC (rev 190862)
@@ -26,7 +26,7 @@
 #ifndef __WebKitAvailability__
 #define __WebKitAvailability__
 
-#ifdef __APPLE__
+#if defined(__APPLE__) && !defined(BUILDING_GTK__)
 
 #include 
 #include 


Modified: trunk/Source/_javascript_Core/ChangeLog (190861 => 190862)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 17:59:05 UTC (rev 190861)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 17:59:45 UTC (rev 190862)
@@ -1,3 +1,14 @@
+2015-10-12  Philip Chimento  
+
+webkit-gtk 2.3.3 fails to build on OS X - Conflicting type "Fixed"
+https://bugs.webkit.org/show_bug.cgi?id=126433
+
+Reviewed by Philippe Normand
+
+Don't include CoreFoundation.h when building the GTK port.
+
+* Source/_javascript_Core/API/WebKitAvailability.h: Add !defined(BUILDING_GTK__) to defined(__APPLE__).
+
 2015-10-10  Filip Pizlo  
 
 FTL should generate code to call slow paths lazily






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190660] trunk

[mcatanzaro]

Title: [190660] trunk








Revision 190660
Author mcatanz...@igalia.com
Date 2015-10-06 21:08:25 -0700 (Tue, 06 Oct 2015)


Log Message
[GTK] Add autocleanups
https://bugs.webkit.org/show_bug.cgi?id=149588

Reviewed by Darin Adler.

Source/WebCore:

* PlatformGTK.cmake:
* bindings/scripts/gobject-generate-headers.pl:

Source/WebKit2:

* PlatformGTK.cmake:
* UIProcess/API/gtk/WebKitAutocleanups.h: Added.
* UIProcess/API/gtk/webkit2.h:
* WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionAutocleanups.h: Added.
* WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:

Tools:

* TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
(AutocleanupsTest::create):
(AutocleanupsTest::testWebProcessAutocleanups):
(registerTests):
* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
* TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
(testUIProcessAutocleanups):
(testWebProcessAutocleanups):
(beforeAll):
(afterAll):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/bindings/scripts/gobject-generate-headers.pl
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/WebKit2/UIProcess/API/gtk/webkit2.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt


Added Paths

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitAutocleanups.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionAutocleanups.h
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (190659 => 190660)

--- trunk/Source/WebCore/ChangeLog	2015-10-07 03:35:26 UTC (rev 190659)
+++ trunk/Source/WebCore/ChangeLog	2015-10-07 04:08:25 UTC (rev 190660)
@@ -1,3 +1,13 @@
+2015-10-06  Michael Catanzaro  
+
+[GTK] Add autocleanups
+https://bugs.webkit.org/show_bug.cgi?id=149588
+
+Reviewed by Darin Adler.
+
+* PlatformGTK.cmake:
+* bindings/scripts/gobject-generate-headers.pl:
+
 2015-10-06  Zalan Bujtas  
 
 Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/


Modified: trunk/Source/WebCore/PlatformGTK.cmake (190659 => 190660)

--- trunk/Source/WebCore/PlatformGTK.cmake	2015-10-07 03:35:26 UTC (rev 190659)
+++ trunk/Source/WebCore/PlatformGTK.cmake	2015-10-07 04:08:25 UTC (rev 190660)
@@ -559,6 +559,8 @@
 bindings/gobject/WebKitDOMObject.cpp
 bindings/gobject/WebKitDOMPrivate.cpp
 bindings/gobject/WebKitDOMXPathNSResolver.cpp
+${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups.h
+${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups-unstable.h
 ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomdefines.h
 ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomdefines-unstable.h
 ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdom.h
@@ -774,6 +776,7 @@
 
 set(GObjectDOMBindingsStable_CLASS_LIST ${GObjectDOMBindings_STATIC_CLASS_LIST})
 set(GObjectDOMBindingsStable_INSTALLED_HEADERS
+ ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups.h
  ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomdefines.h
  ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdom.h
  ${WEBCORE_DIR}/bindings/gobject/WebKitDOMCustom.h
@@ -785,6 +788,7 @@
 )
 
 set(GObjectDOMBindingsUnstable_INSTALLED_HEADERS
+ ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups-unstable.h
  ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomdefines-unstable.h
  ${WEBCORE_DIR}/bindings/gobject/WebKitDOMCustomUnstable.h
 )
@@ -826,6 +830,18 @@
 COMMAND echo ${GObjectDOMBindingsStable_CLASS_LIST} | ${PERL_EXECUTABLE} ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl gdom > ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdom.h
 )
 
+add_custom_command(
+OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups.h
+DEPENDS ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl
+COMMAND echo ${GObjectDOMBindingsStable_CLASS_LIST} | ${PERL_EXECUTABLE} ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl autocleanups > ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups.h
+)
+
+add_custom_command(
+OUTPUT ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups-unstable.h
+DEPENDS ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl
+COMMAND echo ${GObjectDOMBindingsUnstable_CLASS_LIST} | ${PERL_EXECUTABLE} ${WEBCORE_DIR}/bindings/scripts/gobject-generate-headers.pl autocleanups > ${DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR}/webkitdomautocleanups-unstable.h
+)
+
 # Some of the static headers are included by generated public headers with include .
 # We need those headers in the derived sources to be in webkitdom directory.
 

[webkit-changes] [186670] trunk

[mcatanzaro]

Title: [186670] trunk








Revision 186670
Author mcatanz...@igalia.com
Date 2015-07-10 05:33:18 -0700 (Fri, 10 Jul 2015)


Log Message
[GTK] ar warning when linking static libraries
https://bugs.webkit.org/show_bug.cgi?id=144988

Reviewed by Carlos Garcia Campos.

Do not use 'u' when calling ar. This argument conflicts with 'D' and is ignored if 'D' is
used, and 'D' is used by default if binutils is built with --enable-deterministic-archives.
Using 'u' with 'D' causes a warning to be printed when linking static libraries. At least
Fedora and Debian have recently both chosen to use --enable-deterministic-archives, so we
should either stop using 'u' or else add 'U' as well in order to disable deterministic
archives. Using 'U' should result in a somewhat faster build (at least when using the
Makefile generator), but it's unlikely that the difference is significant, so let's simply
remove 'u' until someone determines otherwise. This seems like a better option than adding
'U' so as not to foil distributions' attempts to perform deterministic builds. This also
aligns us with the behavior of upstream CMake (which has never used 'u'). This is a minor
behavior change on distributions that do not use --enable-deterministic-archives, notably
Arch and openSUSE.

* Source/cmake/OptionsCommon.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsCommon.cmake




Diff

Modified: trunk/ChangeLog (186669 => 186670)

--- trunk/ChangeLog	2015-07-10 12:30:00 UTC (rev 186669)
+++ trunk/ChangeLog	2015-07-10 12:33:18 UTC (rev 186670)
@@ -1,3 +1,25 @@
+2015-07-10  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] ar warning when linking static libraries
+https://bugs.webkit.org/show_bug.cgi?id=144988
+
+Reviewed by Carlos Garcia Campos.
+
+Do not use 'u' when calling ar. This argument conflicts with 'D' and is ignored if 'D' is
+used, and 'D' is used by default if binutils is built with --enable-deterministic-archives.
+Using 'u' with 'D' causes a warning to be printed when linking static libraries. At least
+Fedora and Debian have recently both chosen to use --enable-deterministic-archives, so we
+should either stop using 'u' or else add 'U' as well in order to disable deterministic
+archives. Using 'U' should result in a somewhat faster build (at least when using the
+Makefile generator), but it's unlikely that the difference is significant, so let's simply
+remove 'u' until someone determines otherwise. This seems like a better option than adding
+'U' so as not to foil distributions' attempts to perform deterministic builds. This also
+aligns us with the behavior of upstream CMake (which has never used 'u'). This is a minor
+behavior change on distributions that do not use --enable-deterministic-archives, notably
+Arch and openSUSE.
+
+* Source/cmake/OptionsCommon.cmake:
+
 2015-07-03  Emanuele Aina  emanuele.a...@collabora.com
 
 [GTK] Forcefully disable gtk-doc and gobject-introspection when crossbuilding


Modified: trunk/Source/cmake/OptionsCommon.cmake (186669 => 186670)

--- trunk/Source/cmake/OptionsCommon.cmake	2015-07-10 12:30:00 UTC (rev 186669)
+++ trunk/Source/cmake/OptionsCommon.cmake	2015-07-10 12:33:18 UTC (rev 186670)
@@ -16,10 +16,10 @@
 endif ()
 
 if (${CMAKE_SYSTEM_NAME} STREQUAL Linux)
-set(CMAKE_CXX_ARCHIVE_CREATE CMAKE_AR cruT TARGET LINK_FLAGS OBJECTS)
-set(CMAKE_C_ARCHIVE_CREATE CMAKE_AR cruT TARGET LINK_FLAGS OBJECTS)
-set(CMAKE_CXX_ARCHIVE_APPEND CMAKE_AR ruT TARGET LINK_FLAGS OBJECTS)
-set(CMAKE_C_ARCHIVE_APPEND CMAKE_AR ruT TARGET LINK_FLAGS OBJECTS)
+set(CMAKE_CXX_ARCHIVE_CREATE CMAKE_AR crT TARGET LINK_FLAGS OBJECTS)
+set(CMAKE_C_ARCHIVE_CREATE CMAKE_AR crT TARGET LINK_FLAGS OBJECTS)
+set(CMAKE_CXX_ARCHIVE_APPEND CMAKE_AR rT TARGET LINK_FLAGS OBJECTS)
+set(CMAKE_C_ARCHIVE_APPEND CMAKE_AR rT TARGET LINK_FLAGS OBJECTS)
 endif ()
 
 set_property(GLOBAL PROPERTY USE_FOLDERS ON)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186653] trunk/Source/WebKit2

[mcatanzaro]

Title: [186653] trunk/Source/WebKit2








Revision 186653
Author mcatanz...@igalia.com
Date 2015-07-09 17:09:11 -0700 (Thu, 09 Jul 2015)


Log Message
[GTK] Crash when spell checker returns no guesses
https://bugs.webkit.org/show_bug.cgi?id=146805

Reviewed by Martin Robinson.

Properly handle ContextMenuItemTagNoGuessesFound in the switch statement.

* UIProcess/API/gtk/WebKitContextMenuActions.cpp:
(webkitContextMenuActionGetForContextMenuItem):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (186652 => 186653)

--- trunk/Source/WebKit2/ChangeLog	2015-07-10 00:02:50 UTC (rev 186652)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-10 00:09:11 UTC (rev 186653)
@@ -1,3 +1,15 @@
+2015-07-09  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] Crash when spell checker returns no guesses
+https://bugs.webkit.org/show_bug.cgi?id=146805
+
+Reviewed by Martin Robinson.
+
+Properly handle ContextMenuItemTagNoGuessesFound in the switch statement.
+
+* UIProcess/API/gtk/WebKitContextMenuActions.cpp:
+(webkitContextMenuActionGetForContextMenuItem):
+
 2015-07-09  Alex Christensen  achristen...@webkit.org
 
 [Content Extensions] Add 3 byte jump size.


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.cpp (186652 => 186653)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.cpp	2015-07-10 00:02:50 UTC (rev 186652)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.cpp	2015-07-10 00:09:11 UTC (rev 186653)
@@ -182,6 +182,8 @@
 return WEBKIT_CONTEXT_MENU_ACTION_UNICODE;
 case ContextMenuItemTagSpellingGuess:
 return WEBKIT_CONTEXT_MENU_ACTION_SPELLING_GUESS;
+case ContextMenuItemTagNoGuessesFound:
+return WEBKIT_CONTEXT_MENU_ACTION_NO_GUESSES_FOUND;
 case ContextMenuItemTagIgnoreSpelling:
 return WEBKIT_CONTEXT_MENU_ACTION_IGNORE_SPELLING;
 case ContextMenuItemTagLearnSpelling:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186655] trunk/Tools

[mcatanzaro]

Title: [186655] trunk/Tools








Revision 186655
Author mcatanz...@igalia.com
Date 2015-07-09 17:20:31 -0700 (Thu, 09 Jul 2015)


Log Message
[GTK] pango should be included in the default jhbuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=146683

Reviewed by Martin Robinson.

Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when
compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and
fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild
moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have
the same problem again the next time pango wants to use a new fontconfig feature), or remove
fontconfig (which would make it hard to keep tests working). On the balance, adding pango is
best.

* gtk/jhbuild-optional.modules: Remove pango
* gtk/jhbuild.modules: Add pango and update to latest 1.36.8

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild-optional.modules
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (186654 => 186655)

--- trunk/Tools/ChangeLog	2015-07-10 00:11:09 UTC (rev 186654)
+++ trunk/Tools/ChangeLog	2015-07-10 00:20:31 UTC (rev 186655)
@@ -1,3 +1,21 @@
+2015-07-09  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] pango should be included in the default jhbuild moduleset
+https://bugs.webkit.org/show_bug.cgi?id=146683
+
+Reviewed by Martin Robinson.
+
+Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when
+compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and
+fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild
+moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have
+the same problem again the next time pango wants to use a new fontconfig feature), or remove
+fontconfig (which would make it hard to keep tests working). On the balance, adding pango is
+best.
+
+* gtk/jhbuild-optional.modules: Remove pango
+* gtk/jhbuild.modules: Add pango and update to latest 1.36.8
+
 2015-07-09  Devin Rousso  drou...@apple.com
 
 Unreviewed.  Added myself as a committer.


Modified: trunk/Tools/gtk/jhbuild-optional.modules (186654 => 186655)

--- trunk/Tools/gtk/jhbuild-optional.modules	2015-07-10 00:11:09 UTC (rev 186654)
+++ trunk/Tools/gtk/jhbuild-optional.modules	2015-07-10 00:20:31 UTC (rev 186655)
@@ -56,16 +56,4 @@
 /branch
   /autotools
 
-  autotools id=pango autogen-sh=configure
- autogenargs=--enable-cairo
-dependencies
-  dep package=cairo/
-  dep package=fontconfig/
-/dependencies
-branch module=/pub/GNOME/sources/pango/1.34/pango-1.34.0.tar.xz version=1.34.0
-repo=ftp.gnome.org
-hash=sha256:105da1efe019018a9de81681d88c9ace83d2111509ab625c4be9d124a1fdce27
-/branch
-  /autotools
-
 /moduleset


Modified: trunk/Tools/gtk/jhbuild.modules (186654 => 186655)

--- trunk/Tools/gtk/jhbuild.modules	2015-07-10 00:11:09 UTC (rev 186654)
+++ trunk/Tools/gtk/jhbuild.modules	2015-07-10 00:20:31 UTC (rev 186655)
@@ -151,6 +151,7 @@
   dep package=cairo/
   dep package=at-spi2-atk/
   dep package=gdk-pixbuf/
+  dep package=pango/
 /dependencies
 branch module=/pub/GNOME/sources/gtk+/3.16/gtk+-3.16.4.tar.xz version=3.16.4
 repo=ftp.gnome.org
@@ -390,4 +391,19 @@
 branch repo=github.com module=EricssonResearch/openwebrtc.git checkoutdir=openwebrtc tag=13516c7f79a0c48bb411464f7613d4b426c70f5b/
   /autotools
 
+  !-- Dependencies listed below this point are not thought to affect test results, and are only
+   included because they themselves depend on other dependencies built by jhbuild. --
+
+  autotools id=pango autogen-sh=configure
+ autogenargs=--enable-cairo
+dependencies
+  dep package=cairo/
+  dep package=fontconfig/
+/dependencies
+branch module=/pub/GNOME/sources/pango/1.36/pango-1.36.8.tar.xz version=1.36.8
+repo=ftp.gnome.org
+hash=sha256:18dbb51b8ae12bae0ab7a958e7cf3317c9acfc8a1e1103ec2f147164a0fc2d07
+/branch
+  /autotools
+
 /moduleset






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188973] trunk

[mcatanzaro]

Title: [188973] trunk








Revision 188973
Author mcatanz...@igalia.com
Date 2015-08-26 11:46:04 -0700 (Wed, 26 Aug 2015)


Log Message
[GTK] Disable ACCELERATED_2D_CANVAS by default
https://bugs.webkit.org/show_bug.cgi?id=148473

Reviewed by Martin Robinson.

Currently ACCELERATED_2D_CANVAS is enabled by default on most systems (which have CairoGL)
but not on Debian (which does not). We've known this was problematic for a while, since it
means we have two different sets of distro-dependent bugs, but never decided whether that
outweighed the benefits of CarioGL or not. I'm making the call now: it's more important to
have the same bugs everywhere. We can turn this on again for other distros when we're ready
to turn it on for Debian.

Also, properly fail the build if ENABLE_ACCELERATED_2D_CANVAS is enabled but CairoGL is not
available.

* Source/cmake/OptionsGTK.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (188972 => 188973)

--- trunk/ChangeLog	2015-08-26 18:34:38 UTC (rev 188972)
+++ trunk/ChangeLog	2015-08-26 18:46:04 UTC (rev 188973)
@@ -1,3 +1,22 @@
+2015-08-26  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] Disable ACCELERATED_2D_CANVAS by default
+https://bugs.webkit.org/show_bug.cgi?id=148473
+
+Reviewed by Martin Robinson.
+
+Currently ACCELERATED_2D_CANVAS is enabled by default on most systems (which have CairoGL)
+but not on Debian (which does not). We've known this was problematic for a while, since it
+means we have two different sets of distro-dependent bugs, but never decided whether that
+outweighed the benefits of CarioGL or not. I'm making the call now: it's more important to
+have the same bugs everywhere. We can turn this on again for other distros when we're ready
+to turn it on for Debian.
+
+Also, properly fail the build if ENABLE_ACCELERATED_2D_CANVAS is enabled but CairoGL is not
+available.
+
+* Source/cmake/OptionsGTK.cmake:
+
 2015-08-25  Commit Queue  commit-qu...@webkit.org
 
 Unreviewed, rolling out r188919.


Modified: trunk/Source/cmake/OptionsGTK.cmake (188972 => 188973)

--- trunk/Source/cmake/OptionsGTK.cmake	2015-08-26 18:34:38 UTC (rev 188972)
+++ trunk/Source/cmake/OptionsGTK.cmake	2015-08-26 18:46:04 UTC (rev 188973)
@@ -112,27 +112,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PUBLIC OFF)
 endif ()
 
-if (OPENGL_FOUND)
-if (GLX_FOUND)
-list(APPEND CAIROGL_COMPONENTS cairo-glx)
-endif ()
-if (EGL_FOUND)
-list(APPEND CAIROGL_COMPONENTS cairo-egl)
-endif ()
-endif ()
-find_package(CairoGL 1.10.2 COMPONENTS ${CAIROGL_COMPONENTS})
-
-# Normally we do not set the value of options automatically. However, CairoGL is special. Currently
-# most major distros compile Cario with --enable-gl, but Debian and derivitives are a major
-# exception. You very probably want accelerated 2D canvas if Cario has been compiled with CarioGL,
-# and very probably do not want to recompile Cario otherwise. So we expect some major distros will
-# enable this feature, and others will not, and that is just fine for the time being. Once Debian
-# enables CairoGL, then it will be time to force this ON by default. Note that if GLX is installed,
-# EGL is not, and ENABLE_X11_TARGET is OFF, this guess is wrong and the user must override it. We
-# can't check ENABLE_X11_TARGET at this point because we don't know whether it's enabled until
-# WEBKIT_OPTION_END has been called, and at that point it's too late to change default values.
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS PUBLIC CAIROGL_FOUND)
-
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CREDENTIAL_STORAGE PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GEOLOCATION PUBLIC ON)
@@ -241,6 +221,20 @@
 endif ()
 find_package(GLIB 2.36 REQUIRED COMPONENTS ${glib_components})
 
+if (ENABLE_ACCELERATED_2D_CANVAS)
+if (GLX_FOUND)
+list(APPEND CAIROGL_COMPONENTS cairo-glx)
+endif ()
+if (EGL_FOUND)
+list(APPEND CAIROGL_COMPONENTS cairo-egl)
+endif ()
+
+find_package(CairoGL 1.10.2 COMPONENTS ${CAIROGL_COMPONENTS})
+if (NOT CAIROGL_FOUND)
+message(FATAL_ERROR CairoGL is needed for ENABLE_ACCELERATED_2D_CANVAS)
+endif ()
+endif ()
+
 if (ENABLE_CREDENTIAL_STORAGE)
 find_package(Libsecret)
 if (NOT LIBSECRET_FOUND)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189025] trunk/Tools

[mcatanzaro]

Title: [189025] trunk/Tools








Revision 189025
Author mcatanz...@igalia.com
Date 2015-08-27 08:35:12 -0700 (Thu, 27 Aug 2015)


Log Message
[GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora

geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.

* gtk/install-dependencies:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/install-dependencies




Diff

Modified: trunk/Tools/ChangeLog (189024 => 189025)

--- trunk/Tools/ChangeLog	2015-08-27 15:15:40 UTC (rev 189024)
+++ trunk/Tools/ChangeLog	2015-08-27 15:35:12 UTC (rev 189025)
@@ -1,3 +1,11 @@
+2015-08-27  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
+
+geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
+
+* gtk/install-dependencies:
+
 2015-08-27  Carlos Garcia Campos  cgar...@igalia.com
 
 Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.


Modified: trunk/Tools/gtk/install-dependencies (189024 => 189025)

--- trunk/Tools/gtk/install-dependencies	2015-08-27 15:15:40 UTC (rev 189024)
+++ trunk/Tools/gtk/install-dependencies	2015-08-27 15:35:12 UTC (rev 189025)
@@ -309,7 +309,7 @@
 fontconfig-devel \
 freetype-devel \
 gcc-c++ \
-geoclue-devel \
+geoclue2-devel \
 gettext-devel \
 gobject-introspection-devel \
 gperf \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189097] trunk/Source/WebKit2

[mcatanzaro]

Title: [189097] trunk/Source/WebKit2








Revision 189097
Author mcatanz...@igalia.com
Date 2015-08-28 07:22:57 -0700 (Fri, 28 Aug 2015)


Log Message
Minor fixes in reportUnexpectedSyscall
https://bugs.webkit.org/show_bug.cgi?id=148551

Reviewed by Žan Doberšek.

There is an off-by-one in the static assert.

Also, an unsigned long long is passed in, but the parameter is an int. Then it's passed to
writeUnsignedInt, which takes an unsigned int. Let's use unsigned int instead. (The value
is a syscall number, so it's safe to truncate regardless -- it never be anywhere near as
large as an int, unless the input is malicious, in which case truncating it is the right
thing to do anyway -- so this is just a matter of style.)

* Shared/linux/SeccompFilters/Syscall.cpp:
(WebKit::reportUnexpectedSyscall):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (189096 => 189097)

--- trunk/Source/WebKit2/ChangeLog	2015-08-28 12:58:14 UTC (rev 189096)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-28 14:22:57 UTC (rev 189097)
@@ -1,3 +1,21 @@
+2015-08-28  Michael Catanzaro  mcatanz...@igalia.com
+
+Minor fixes in reportUnexpectedSyscall
+https://bugs.webkit.org/show_bug.cgi?id=148551
+
+Reviewed by Žan Doberšek.
+
+There is an off-by-one in the static assert.
+
+Also, an unsigned long long is passed in, but the parameter is an int. Then it's passed to
+writeUnsignedInt, which takes an unsigned int. Let's use unsigned int instead. (The value
+is a syscall number, so it's safe to truncate regardless -- it never be anywhere near as
+large as an int, unless the input is malicious, in which case truncating it is the right
+thing to do anyway -- so this is just a matter of style.)
+
+* Shared/linux/SeccompFilters/Syscall.cpp:
+(WebKit::reportUnexpectedSyscall):
+
 2015-08-28  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Simplify the internal API to create a WebView


Modified: trunk/Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp (189096 => 189097)

--- trunk/Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp	2015-08-28 12:58:14 UTC (rev 189096)
+++ trunk/Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp	2015-08-28 14:22:57 UTC (rev 189097)
@@ -62,11 +62,13 @@
 buf[--width] = '0' + (tens % 10);
 }
 
-static void reportUnexpectedSyscall(int syscall)
+static void reportUnexpectedSyscall(unsigned syscall)
 {
 char buf[128];
 #if defined(__has_builtin)  __has_builtin(__builtin_strlen)
-static_assert(__builtin_strlen(message) + std::numeric_limitsint::digits10 + 1  sizeof(buf), Buffer too small);
+// Buffer must be big enough for the literal, plus the number of digits in the largest possible
+// unsigned int, plus one for the newline, plus one more for the trailing null.
+static_assert(__builtin_strlen(message) + std::numeric_limitsunsigned::digits10 + 2  sizeof(buf), Buffer too small);
 #endif
 strcpy(buf, message);
 writeUnsignedInt(buf + strlen(buf), syscall);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189098] trunk/Source/WebKit2

[mcatanzaro]

Title: [189098] trunk/Source/WebKit2








Revision 189098
Author mcatanz...@igalia.com
Date 2015-08-28 07:24:10 -0700 (Fri, 28 Aug 2015)


Log Message
[CMake] LIBSECCOMP_INCLUDE_DIRS should be added to WebKit2_SYSTEM_INCLUDE_DIRECTORIES
https://bugs.webkit.org/show_bug.cgi?id=148552

Reviewed by Žan Doberšek.

LIBSECCOMP_INCLUDE_DIRS should be added to WebKit2_SYSTEM_INCLUDE_DIRECTORIES, not
WebKit2_INCLUDE_DIRECTORIES. (So that warnings from libseccomp headers are suppressed. Not
that there are any right now.)

* PlatformGTK.cmake:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformGTK.cmake




Diff

Modified: trunk/Source/WebKit2/ChangeLog (189097 => 189098)

--- trunk/Source/WebKit2/ChangeLog	2015-08-28 14:22:57 UTC (rev 189097)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-28 14:24:10 UTC (rev 189098)
@@ -1,5 +1,18 @@
 2015-08-28  Michael Catanzaro  mcatanz...@igalia.com
 
+[CMake] LIBSECCOMP_INCLUDE_DIRS should be added to WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+https://bugs.webkit.org/show_bug.cgi?id=148552
+
+Reviewed by Žan Doberšek.
+
+LIBSECCOMP_INCLUDE_DIRS should be added to WebKit2_SYSTEM_INCLUDE_DIRECTORIES, not
+WebKit2_INCLUDE_DIRECTORIES. (So that warnings from libseccomp headers are suppressed. Not
+that there are any right now.)
+
+* PlatformGTK.cmake:
+
+2015-08-28  Michael Catanzaro  mcatanz...@igalia.com
+
 Minor fixes in reportUnexpectedSyscall
 https://bugs.webkit.org/show_bug.cgi?id=148551
 


Modified: trunk/Source/WebKit2/PlatformGTK.cmake (189097 => 189098)

--- trunk/Source/WebKit2/PlatformGTK.cmake	2015-08-28 14:22:57 UTC (rev 189097)
+++ trunk/Source/WebKit2/PlatformGTK.cmake	2015-08-28 14:24:10 UTC (rev 189098)
@@ -584,7 +584,7 @@
 list(APPEND WebKit2_LIBRARIES
 ${LIBSECCOMP_LIBRARIES}
 )
-list(APPEND WebKit2_INCLUDE_DIRECTORIES
+list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
 ${LIBSECCOMP_INCLUDE_DIRS}
 )
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [188929] trunk

[mcatanzaro]

Title: [188929] trunk








Revision 188929
Author mcatanz...@igalia.com
Date 2015-08-25 12:13:39 -0700 (Tue, 25 Aug 2015)


Log Message
[GTK] r186800 broke the build on Ubuntu 14.04
https://bugs.webkit.org/show_bug.cgi?id=147559

Reviewed by Martin Robinson.

* Source/cmake/FindGTK3.cmake: Always define GTK3_SUPPORTS_X11 and GTK3_SUPPORTS_WAYLAND.
* Source/cmake/OptionsGTK.cmake: Autodetect support for X11 and Wayland backends.

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/FindGTK3.cmake
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (188928 => 188929)

--- trunk/ChangeLog	2015-08-25 19:10:29 UTC (rev 188928)
+++ trunk/ChangeLog	2015-08-25 19:13:39 UTC (rev 188929)
@@ -1,3 +1,13 @@
+2015-08-25  Michael Catanzaro  mcatanz...@igalia.com
+
+[GTK] r186800 broke the build on Ubuntu 14.04
+https://bugs.webkit.org/show_bug.cgi?id=147559
+
+Reviewed by Martin Robinson.
+
+* Source/cmake/FindGTK3.cmake: Always define GTK3_SUPPORTS_X11 and GTK3_SUPPORTS_WAYLAND.
+* Source/cmake/OptionsGTK.cmake: Autodetect support for X11 and Wayland backends.
+
 2015-08-25  Per Arne Vollan  pe...@outlook.com
 
 [Win] Build does not generate debug info.


Modified: trunk/Source/cmake/FindGTK3.cmake (188928 => 188929)

--- trunk/Source/cmake/FindGTK3.cmake	2015-08-25 19:10:29 UTC (rev 188928)
+++ trunk/Source/cmake/FindGTK3.cmake	2015-08-25 19:13:39 UTC (rev 188929)
@@ -52,11 +52,15 @@
 pkg_check_modules(GTK3_X11 gtk+-x11-3.0)
 if (${GTK3_X11_VERSION} VERSION_EQUAL ${GTK3_VERSION})
 set(GTK3_SUPPORTS_X11 TRUE)
+else ()
+set(GTK3_SUPPORTS_X11 FALSE)
 endif ()
 
 pkg_check_modules(GTK3_WAYLAND gtk+-wayland-3.0)
 if (${GTK3_WAYLAND_VERSION} VERSION_EQUAL ${GTK3_VERSION})
 set(GTK3_SUPPORTS_WAYLAND TRUE)
+else ()
+set(GTK3_SUPPORTS_WAYLAND FALSE)
 endif ()
 
 if (NOT(${GTK3_VERSION} VERSION_LESS 3.14.0))


Modified: trunk/Source/cmake/OptionsGTK.cmake (188928 => 188929)

--- trunk/Source/cmake/OptionsGTK.cmake	2015-08-25 19:10:29 UTC (rev 188928)
+++ trunk/Source/cmake/OptionsGTK.cmake	2015-08-25 19:13:39 UTC (rev 188929)
@@ -33,6 +33,8 @@
 find_package(Cairo 1.10.2 REQUIRED)
 find_package(Fontconfig 2.8.0 REQUIRED)
 find_package(Freetype2 2.4.2 REQUIRED)
+find_package(GTK3 3.6.0 REQUIRED)
+find_package(GDK3 3.6.0 REQUIRED)
 find_package(HarfBuzz 0.9.2 REQUIRED)
 find_package(ICU REQUIRED)
 find_package(JPEG REQUIRED)
@@ -47,6 +49,7 @@
 find_package(WebP REQUIRED)
 find_package(ATSPI 2.5.3)
 find_package(EGL)
+find_package(GTKUnixPrint)
 find_package(OpenGL)
 find_package(OpenGLES2)
 
@@ -68,8 +71,8 @@
 WEBKIT_OPTION_DEFINE(ENABLE_INTROSPECTION Whether to enable GObject introspection. PUBLIC ON)
 WEBKIT_OPTION_DEFINE(ENABLE_OPENGL Whether to use OpenGL. PUBLIC ON)
 WEBKIT_OPTION_DEFINE(ENABLE_PLUGIN_PROCESS_GTK2 Whether to build WebKitPluginProcess2 to load GTK2 based plugins. PUBLIC ON)
-WEBKIT_OPTION_DEFINE(ENABLE_X11_TARGET Whether to enable support for the X11 windowing target. PUBLIC ON)
-WEBKIT_OPTION_DEFINE(ENABLE_WAYLAND_TARGET Whether to enable support for the Wayland windowing target. PUBLIC ON)
+WEBKIT_OPTION_DEFINE(ENABLE_X11_TARGET Whether to enable support for the X11 windowing target. PUBLIC ${GTK3_SUPPORTS_X11})
+WEBKIT_OPTION_DEFINE(ENABLE_WAYLAND_TARGET Whether to enable support for the Wayland windowing target. PUBLIC ${GTK3_SUPPORTS_WAYLAND})
 WEBKIT_OPTION_DEFINE(USE_LIBNOTIFY Whether to enable the default web notification implementation. PUBLIC ON)
 WEBKIT_OPTION_DEFINE(USE_LIBHYPHEN Whether to enable the default automatic hyphenation implementation. PUBLIC ON)
 
@@ -224,16 +227,6 @@
 add_definitions(-DUSER_AGENT_GTK_MINOR_VERSION=1)
 add_definitions(-DWEBKITGTK_API_VERSION_STRING=${WEBKITGTK_API_VERSION})
 
-if (ENABLE_WAYLAND_TARGET)
-set(GTK3_REQUIRED_VERSION 3.12.0)
-else ()
-set(GTK3_REQUIRED_VERSION 3.6.0)
-endif ()
-
-find_package(GTK3 ${GTK3_REQUIRED_VERSION} REQUIRED)
-find_package(GDK3 ${GTK3_REQUIRED_VERSION} REQUIRED)
-find_package(GTKUnixPrint)
-
 set(GTK_LIBRARIES ${GTK3_LIBRARIES})
 set(GTK_INCLUDE_DIRS ${GTK3_INCLUDE_DIRS})
 set(GDK_LIBRARIES ${GDK3_LIBRARIES})
@@ -424,6 +417,10 @@
 message(FATAL_ERROR Recompile GTK+ with Wayland backend to use ENABLE_WAYLAND_TARGET)
 endif ()
 
+if (ENABLE_WAYLAND_TARGET AND GTK3_VERSION VERSION_LESS 3.12)
+message(FATAL_ERROR GTK+ 3.12 is required to use ENABLE_WAYLAND_TARGET)
+endif ()
+
 find_package(Wayland REQUIRED)
 endif ()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189170] trunk/Source/WebCore

[mcatanzaro]

Title: [189170] trunk/Source/WebCore








Revision 189170
Author mcatanz...@igalia.com
Date 2015-08-31 09:32:59 -0700 (Mon, 31 Aug 2015)


Log Message
[Freetype] FontCache::strengthOfFirstAlias leaks an FcPattern
https://bugs.webkit.org/show_bug.cgi?id=148624

Reviewed by Martin Robinson.

Using the normal RefPtr constructor causes the FcPattern to be reffed one extra time. Even
though the FcPattern is intentionally leaked to FcFontSetAdd down below, the FcPattern has
its own refcount and now it's screwed up. Just completely stop using RefPtr for these
FcPatterns, since the potential for confusion regarding leakRef combined with Fontconfig
refcounting far outweighs the benefit of using a smart pointer.

* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::strengthOfFirstAlias):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (189169 => 189170)

--- trunk/Source/WebCore/ChangeLog	2015-08-31 16:30:03 UTC (rev 189169)
+++ trunk/Source/WebCore/ChangeLog	2015-08-31 16:32:59 UTC (rev 189170)
@@ -1,3 +1,19 @@
+2015-08-31  Michael Catanzaro  
+
+[Freetype] FontCache::strengthOfFirstAlias leaks an FcPattern
+https://bugs.webkit.org/show_bug.cgi?id=148624
+
+Reviewed by Martin Robinson.
+
+Using the normal RefPtr constructor causes the FcPattern to be reffed one extra time. Even
+though the FcPattern is intentionally leaked to FcFontSetAdd down below, the FcPattern has
+its own refcount and now it's screwed up. Just completely stop using RefPtr for these
+FcPatterns, since the potential for confusion regarding leakRef combined with Fontconfig
+refcounting far outweighs the benefit of using a smart pointer.
+
+* platform/graphics/freetype/FontCacheFreeType.cpp:
+(WebCore::strengthOfFirstAlias):
+
 2015-08-31  Javier Fernandez  
 
 [CSS Grid Layout] auto-margins alignment does not work for heights


Modified: trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp (189169 => 189170)

--- trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp	2015-08-31 16:30:03 UTC (rev 189169)
+++ trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp	2015-08-31 16:32:59 UTC (rev 189170)
@@ -225,17 +225,19 @@
 
 FcUniquePtr strongLangSet(FcLangSetCreate());
 FcLangSetAdd(strongLangSet.get(), reinterpret_cast("nomatchlang"));
-RefPtr strong = adoptRef(FcPatternDuplicate(pattern.get()));
-FcPatternAddLangSet(strong.get(), FC_LANG, strongLangSet.get());
+// Ownership of this FcPattern will be transferred with FcFontSetAdd.
+FcPattern* strong = FcPatternDuplicate(pattern.get());
+FcPatternAddLangSet(strong, FC_LANG, strongLangSet.get());
 
 FcUniquePtr weakLangSet(FcLangSetCreate());
 FcLangSetAdd(weakLangSet.get(), reinterpret_cast("matchlang"));
-RefPtr weak(FcPatternCreate());
-FcPatternAddString(weak.get(), FC_FAMILY, reinterpret_cast("nomatchstring"));
-FcPatternAddLangSet(weak.get(), FC_LANG, weakLangSet.get());
+// Ownership of this FcPattern will be transferred via FcFontSetAdd.
+FcPattern* weak = FcPatternCreate();
+FcPatternAddString(weak, FC_FAMILY, reinterpret_cast("nomatchstring"));
+FcPatternAddLangSet(weak, FC_LANG, weakLangSet.get());
 
-FcFontSetAdd(fontSet.get(), strong.leakRef());
-FcFontSetAdd(fontSet.get(), weak.leakRef());
+FcFontSetAdd(fontSet.get(), strong);
+FcFontSetAdd(fontSet.get(), weak);
 
 // Add 'matchlang' to the copy of the pattern.
 FcPatternAddLangSet(pattern.get(), FC_LANG, weakLangSet.get());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189181] trunk/Source/bmalloc

[mcatanzaro]

Title: [189181] trunk/Source/bmalloc








Revision 189181
Author mcatanz...@igalia.com
Date 2015-08-31 13:41:19 -0700 (Mon, 31 Aug 2015)


Log Message
Implement bmalloc::isASanEnabled for generic Unix
https://bugs.webkit.org/show_bug.cgi?id=148623

Reviewed by Geoffrey Garen.

* bmalloc/BPlatform.h: Add BOS_UNIX to detect whether the OS is a Unix.
* bmalloc/Environment.cpp:
(bmalloc::isASanEnabled): Implement a runtime check that should work on any Unix.

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/BPlatform.h
trunk/Source/bmalloc/bmalloc/Environment.cpp




Diff

Modified: trunk/Source/bmalloc/ChangeLog (189180 => 189181)

--- trunk/Source/bmalloc/ChangeLog	2015-08-31 20:32:29 UTC (rev 189180)
+++ trunk/Source/bmalloc/ChangeLog	2015-08-31 20:41:19 UTC (rev 189181)
@@ -1,3 +1,14 @@
+2015-08-31  Michael Catanzaro  
+
+Implement bmalloc::isASanEnabled for generic Unix
+https://bugs.webkit.org/show_bug.cgi?id=148623
+
+Reviewed by Geoffrey Garen.
+
+* bmalloc/BPlatform.h: Add BOS_UNIX to detect whether the OS is a Unix.
+* bmalloc/Environment.cpp:
+(bmalloc::isASanEnabled): Implement a runtime check that should work on any Unix.
+
 2015-08-19  Geoffrey Garen  
 
 Crash @ bmalloc::Environment::computeIsBmallocEnabled


Modified: trunk/Source/bmalloc/bmalloc/BPlatform.h (189180 => 189181)

--- trunk/Source/bmalloc/bmalloc/BPlatform.h	2015-08-31 20:32:29 UTC (rev 189180)
+++ trunk/Source/bmalloc/bmalloc/BPlatform.h	2015-08-31 20:41:19 UTC (rev 189181)
@@ -43,4 +43,8 @@
 #define BOS_DARWIN 1
 #endif
 
+#ifdef __unix
+#define BOS_UNIX 1
+#endif
+
 #endif // BPlatform_h


Modified: trunk/Source/bmalloc/bmalloc/Environment.cpp (189180 => 189181)

--- trunk/Source/bmalloc/bmalloc/Environment.cpp	2015-08-31 20:32:29 UTC (rev 189180)
+++ trunk/Source/bmalloc/bmalloc/Environment.cpp	2015-08-31 20:41:19 UTC (rev 189181)
@@ -29,6 +29,8 @@
 #include 
 #if BOS(DARWIN)
 #include 
+#elif BOS(UNIX)
+#include 
 #endif
 
 namespace bmalloc {
@@ -85,6 +87,13 @@
 return true;
 }
 return false;
+#elif BOS(UNIX)
+void* handle = dlopen(nullptr, RTLD_NOW);
+if (!handle)
+return false;
+bool result = !!dlsym(handle, "__asan_poison_memory_region");
+dlclose(handle);
+return result;
 #else
 return false;
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189442] trunk/Source/WebKit2

[mcatanzaro]

Title: [189442] trunk/Source/WebKit2








Revision 189442
Author mcatanz...@igalia.com
Date 2015-09-05 19:33:35 -0700 (Sat, 05 Sep 2015)


Log Message
Leak in WebContextInjectedBundleClient::getInjectedBundleInitializationUserData
https://bugs.webkit.org/show_bug.cgi?id=148769

Fix suggested by Zan Dobersek.

Reviewed by Darin Adler.

* UIProcess/WebContextInjectedBundleClient.cpp:
(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebContextInjectedBundleClient.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (189441 => 189442)

--- trunk/Source/WebKit2/ChangeLog	2015-09-06 01:50:13 UTC (rev 189441)
+++ trunk/Source/WebKit2/ChangeLog	2015-09-06 02:33:35 UTC (rev 189442)
@@ -1,3 +1,15 @@
+2015-09-05  Michael Catanzaro  
+
+Leak in WebContextInjectedBundleClient::getInjectedBundleInitializationUserData
+https://bugs.webkit.org/show_bug.cgi?id=148769
+
+Fix suggested by Zan Dobersek.
+
+Reviewed by Darin Adler.
+
+* UIProcess/WebContextInjectedBundleClient.cpp:
+(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):
+
 2015-09-04  Brian Burg  
 
 Web Inspector: agents should send messages through FrontendRouter instead of FrontendChannel


Modified: trunk/Source/WebKit2/UIProcess/WebContextInjectedBundleClient.cpp (189441 => 189442)

--- trunk/Source/WebKit2/UIProcess/WebContextInjectedBundleClient.cpp	2015-09-06 01:50:13 UTC (rev 189441)
+++ trunk/Source/WebKit2/UIProcess/WebContextInjectedBundleClient.cpp	2015-09-06 02:33:35 UTC (rev 189442)
@@ -57,7 +57,7 @@
 if (!m_client.getInjectedBundleInitializationUserData)
 return 0;
 
-return toImpl(m_client.getInjectedBundleInitializationUserData(toAPI(processPool), m_client.base.clientInfo));
+return adoptRef(toImpl(m_client.getInjectedBundleInitializationUserData(toAPI(processPool), m_client.base.clientInfo)));
 }
 
 } // namespace WebKit






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189526] trunk/Source/WebCore

[mcatanzaro]

Title: [189526] trunk/Source/WebCore








Revision 189526
Author mcatanz...@igalia.com
Date 2015-09-08 18:38:32 -0700 (Tue, 08 Sep 2015)


Log Message
Crash when WebCore::SQLiteFileSystem::openDatabase is called from multiple threads
https://bugs.webkit.org/show_bug.cgi?id=143245

Reviewed by Darin Adler.

sqlite3_initialize is documented to be thread-safe, and to be called automatically by the
library when needed, so applications should never need to call it directly. The problem is,
it's not thread-safe: we have documented instances of GNOME Builder, Devhelp, Epiphany, and
cinnamon-screensaver crashing when sqlite3_initialize is called simultaneously in separate
threads (usually inside sqlite3_open). So call it manually, guarded using std::call_once, to
make sure that the library is fully initialized before the first call to sqlite3_open. It's
a good idea to do this regardless, because the documentation says it could be required in
a future release of SQLite. (Though the use of std::call_once should not be needed, and is
only used to attempt to work around the crashes.)

This is a workaround for an SQLite bug that might have been fixed upstream, but the SQLite
developers are not really confident in the thread-safety of this function, and have advised
that we carry the workaround. Seems like a good idea.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::SQLiteDatabase):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (189525 => 189526)

--- trunk/Source/WebCore/ChangeLog	2015-09-09 01:32:51 UTC (rev 189525)
+++ trunk/Source/WebCore/ChangeLog	2015-09-09 01:38:32 UTC (rev 189526)
@@ -1,3 +1,27 @@
+2015-09-08  Michael Catanzaro  
+
+Crash when WebCore::SQLiteFileSystem::openDatabase is called from multiple threads
+https://bugs.webkit.org/show_bug.cgi?id=143245
+
+Reviewed by Darin Adler.
+
+sqlite3_initialize is documented to be thread-safe, and to be called automatically by the
+library when needed, so applications should never need to call it directly. The problem is,
+it's not thread-safe: we have documented instances of GNOME Builder, Devhelp, Epiphany, and
+cinnamon-screensaver crashing when sqlite3_initialize is called simultaneously in separate
+threads (usually inside sqlite3_open). So call it manually, guarded using std::call_once, to
+make sure that the library is fully initialized before the first call to sqlite3_open. It's
+a good idea to do this regardless, because the documentation says it could be required in
+a future release of SQLite. (Though the use of std::call_once should not be needed, and is
+only used to attempt to work around the crashes.)
+
+This is a workaround for an SQLite bug that might have been fixed upstream, but the SQLite
+developers are not really confident in the thread-safety of this function, and have advised
+that we carry the workaround. Seems like a good idea.
+
+* platform/sql/SQLiteDatabase.cpp:
+(WebCore::SQLiteDatabase::SQLiteDatabase):
+
 2015-09-08  Yusuke Suzuki  
 
 Unify symbolTablePut in JSLexicalEnvironment and JSSymbolTableObject


Modified: trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp (189525 => 189526)

--- trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2015-09-09 01:32:51 UTC (rev 189525)
+++ trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2015-09-09 01:38:32 UTC (rev 189526)
@@ -31,6 +31,8 @@
 #include "Logging.h"
 #include "SQLiteFileSystem.h"
 #include "SQLiteStatement.h"
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -57,6 +59,22 @@
 , m_openErrorMessage()
 , m_lastChangesCount(0)
 {
+static std::once_flag flag;
+std::call_once(flag, [] {
+// It should be safe to call this outside of std::call_once, since it is documented to be
+// completely threadsafe. But in the past it was not safe, and the SQLite developers still
+// aren't confident that it really is, and we still support ancient versions of SQLite. So
+// std::call_once is used to stay on the safe side. See bug #143245.
+int ret = sqlite3_initialize();
+if (ret != SQLITE_OK) {
+#if SQLITE_VERSION_NUMBER >= 3007015
+WTFLogAlways("Failed to initialize SQLite: %s", sqlite3_errstr(ret));
+#else
+WTFLogAlways("Failed to initialize SQLite");
+#endif
+CRASH();
+}
+});
 }
 
 SQLiteDatabase::~SQLiteDatabase()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189661] trunk/Source/WebCore/platform/gtk/po

[mcatanzaro]

Title: [189661] trunk/Source/WebCore/platform/gtk/po








Revision 189661
Author mcatanz...@igalia.com
Date 2015-09-12 16:20:54 -0700 (Sat, 12 Sep 2015)


Log Message
[GTK] [l10n] Updated Turkish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=148362

Unreviewed.

* tr.po: Added.

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog


Added Paths

trunk/Source/WebCore/platform/gtk/po/tr.po




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (189660 => 189661)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-12 21:52:25 UTC (rev 189660)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-12 23:20:54 UTC (rev 189661)
@@ -1,3 +1,12 @@
+2015-09-12  Michael Catanzaro  
+
+[GTK] [l10n] Updated Turkish translation of WebKitGTK+
+https://bugs.webkit.org/show_bug.cgi?id=148362
+
+Unreviewed.
+
+* tr.po: Added.
+
 2015-07-22  Josef Andersson  
 
 [l10n] Updated Swedish translation


Added: trunk/Source/WebCore/platform/gtk/po/tr.po (0 => 189661)

--- trunk/Source/WebCore/platform/gtk/po/tr.po	(rev 0)
+++ trunk/Source/WebCore/platform/gtk/po/tr.po	2015-09-12 23:20:54 UTC (rev 189661)
@@ -0,0 +1,1611 @@
+# Turkish translation for webkit.
+# Copyright (C) 2014 webkit's COPYRIGHT HOLDER
+# This file is distributed under the same license as the webkit package.
+#
+# Elif Aydurmuş , 2014.
+# Sabri Ünal , 2014.
+# Furkan Usta , 2015.
+# Gökhan Gurbetoğlu , 2014, 2015.
+# Muhammet Kara , 2014, 2015.
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: webkit HEAD\n"
+"Report-Msgid-Bugs-To: https://bugs.webkit.org\n"
+"POT-Creation-Date: 2015-08-23 00:17+\n"
+"PO-Revision-Date: 2015-08-23 03:32+0300\n"
+"Last-Translator: Muhammet Kara \n"
+"Language-Team: Türkçe \n"
+"Language: tr\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=1; plural=0;\n"
+"X-Generator: Gtranslator 2.91.7\n"
+
+#: ../ErrorsGtk.cpp:33
+msgid "Load request cancelled"
+msgstr "Yükleme isteği iptal edildi"
+
+#: ../ErrorsGtk.cpp:39
+msgid "Not allowed to use restricted network port"
+msgstr "Sınırlı ağ bağlantı noktası kullanmaya izin verilmiyor"
+
+#: ../ErrorsGtk.cpp:45
+msgid "URL cannot be shown"
+msgstr "URL gösterilemiyor"
+
+#: ../ErrorsGtk.cpp:51
+msgid "Frame load was interrupted"
+msgstr "Çerçeve yükleme kesintiye uğradı"
+
+#: ../ErrorsGtk.cpp:57
+msgid "Content with the specified MIME type cannot be shown"
+msgstr "Belirtilen MIME türündeki içerik gösterilemiyor"
+
+#: ../ErrorsGtk.cpp:63
+msgid "File does not exist"
+msgstr "Dosya mevcut değil"
+
+#: ../ErrorsGtk.cpp:69
+msgid "Plugin will handle load"
+msgstr "Yükleme işini eklenti halledecek"
+
+#: ../ErrorsGtk.cpp:81
+msgid "User cancelled the download"
+msgstr "Kullanıcı indirmeyi iptal etti"
+
+#: ../ErrorsGtk.cpp:97
+msgid "Printer not found"
+msgstr "Yazıcı bulunamadı"
+
+#: ../ErrorsGtk.cpp:102
+msgid "Invalid page range"
+msgstr "Geçersiz sayfa aralığı"
+
+#: ../LocalizedStringsGtk.cpp:55 ../LocalizedStringsGtk.cpp:60
+msgid "Submit"
+msgstr "Gönder"
+
+#: ../LocalizedStringsGtk.cpp:65
+msgid "Reset"
+msgstr "Sıfırla"
+
+#: ../LocalizedStringsGtk.cpp:70
+msgid "Details"
+msgstr "Ayrıntılar"
+
+#: ../LocalizedStringsGtk.cpp:75
+msgid "This is a searchable index. Enter search keywords: "
+msgstr "Bu aranabilir bir dizindir. Arama için anahtar sözcükleri girin:"
+
+#: ../LocalizedStringsGtk.cpp:80
+msgid "Choose File"
+msgstr "Dosya Seç"
+
+#: ../LocalizedStringsGtk.cpp:85
+msgid "Choose Files"
+msgstr "Dosyaları Seç"
+
+#: ../LocalizedStringsGtk.cpp:90 ../LocalizedStringsGtk.cpp:95
+msgid "(None)"
+msgstr "(Yok)"
+
+#: ../LocalizedStringsGtk.cpp:100
+msgid "Open Link in New _Window"
+msgstr "Bağlantıyı Yeni _Pencerede Aç"
+
+#: ../LocalizedStringsGtk.cpp:105
+msgid "_Download Linked File"
+msgstr "Bağlı Dosyayı _İndir"
+
+#: ../LocalizedStringsGtk.cpp:110
+msgid "Copy Link Loc_ation"
+msgstr "B_ağlantı Konumunu Kopyala"
+
+#: ../LocalizedStringsGtk.cpp:115
+msgid "Open _Image in New Window"
+msgstr "Resm_i Yeni Pencerede Aç"
+
+#: ../LocalizedStringsGtk.cpp:120
+msgid "Sa_ve Image As"
+msgstr "Resmi Farkl_ı Kaydet"
+
+#: ../LocalizedStringsGtk.cpp:125
+msgid "Cop_y Image"
+msgstr "Resmi Kop_yala"
+
+#: ../LocalizedStringsGtk.cpp:130
+msgid "Copy Image _Address"
+msgstr "Resim _Adresini Kopyala"
+
+#: ../LocalizedStringsGtk.cpp:135
+msgid "Open _Video in New Window"
+msgstr "_Videoyu Yeni Pencerede Aç"
+
+#: ../LocalizedStringsGtk.cpp:140
+msgid "Open _Audio in New Window"
+msgstr "Sesi Yeni Pencerede _Aç"
+
+#: ../LocalizedStringsGtk.cpp:145
+msgid "Download _Video"
+msgstr "_Videoyu İndir"
+
+#: ../LocalizedStringsGtk.cpp:150
+msgid "Download _Audio"
+msgstr "_Sesi İndir"

[webkit-changes] [189662] trunk/Source/WebCore/platform/gtk/po/ChangeLog

[mcatanzaro]

Title: [189662] trunk/Source/WebCore/platform/gtk/po/ChangeLog








Revision 189662
Author mcatanz...@igalia.com
Date 2015-09-12 16:27:19 -0700 (Sat, 12 Sep 2015)


Log Message
[GTK] [l10n] Updated Turkish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=148362

Unreviewed.

Patch by Muhammet Kara  on 2015-09-12

* tr.po: Added.

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (189661 => 189662)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-12 23:20:54 UTC (rev 189661)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-12 23:27:19 UTC (rev 189662)
@@ -1,4 +1,4 @@
-2015-09-12  Michael Catanzaro  
+2015-09-12  Muhammet Kara  
 
 [GTK] [l10n] Updated Turkish translation of WebKitGTK+
 https://bugs.webkit.org/show_bug.cgi?id=148362






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189663] trunk/Source/WebCore/platform/gtk/po

[mcatanzaro]

Title: [189663] trunk/Source/WebCore/platform/gtk/po








Revision 189663
Author mcatanz...@igalia.com
Date 2015-09-12 16:54:17 -0700 (Sat, 12 Sep 2015)


Log Message
[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=148475

Unreviewed.

Patch by Piotr Drąg  on 2015-09-12

* pl.po:

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog
trunk/Source/WebCore/platform/gtk/po/pl.po




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (189662 => 189663)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-12 23:27:19 UTC (rev 189662)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-12 23:54:17 UTC (rev 189663)
@@ -1,3 +1,12 @@
+2015-09-12  Piotr Drąg  
+
+[l10n] Updated Polish translation of WebKitGTK+
+https://bugs.webkit.org/show_bug.cgi?id=148475
+
+Unreviewed.
+
+* pl.po:
+
 2015-09-12  Muhammet Kara  
 
 [GTK] [l10n] Updated Turkish translation of WebKitGTK+


Modified: trunk/Source/WebCore/platform/gtk/po/pl.po (189662 => 189663)

--- trunk/Source/WebCore/platform/gtk/po/pl.po	2015-09-12 23:27:19 UTC (rev 189662)
+++ trunk/Source/WebCore/platform/gtk/po/pl.po	2015-09-12 23:54:17 UTC (rev 189663)
@@ -9,9 +9,9 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: webkitgtk\n"
-"Report-Msgid-Bugs-To: http://bugs.webkit.org\n"
-"POT-Creation-Date: 2015-01-20 12:06+\n"
-"PO-Revision-Date: 2015-03-04 22:32+0100\n"
+"Report-Msgid-Bugs-To: https://bugs.webkit.org\n"
+"POT-Creation-Date: 2015-08-26 14:45+\n"
+"PO-Revision-Date: 2015-08-26 17:00+0200\n"
 "Last-Translator: Piotr Drąg \n"
 "Language-Team: Polish \n"
 "Language: pl\n"
@@ -258,43 +258,43 @@
 
 #: ../LocalizedStringsGtk.cpp:366
 msgid "LRM _Left-to-right mark"
-msgstr "LRM znacznik od l_ewej do prawej"
+msgstr "LRM — znacznik od l_ewej do prawej"
 
 #: ../LocalizedStringsGtk.cpp:371
 msgid "RLM _Right-to-left mark"
-msgstr "RLM znacznik od p_rawej do lewej"
+msgstr "RLM — znacznik od p_rawej do lewej"
 
 #: ../LocalizedStringsGtk.cpp:376
 msgid "LRE Left-to-right _embedding"
-msgstr "LRE _osadzanie od lewej do prawej"
+msgstr "LRE — _osadzanie od lewej do prawej"
 
 #: ../LocalizedStringsGtk.cpp:381
 msgid "RLE Right-to-left e_mbedding"
-msgstr "RLE o_sadzanie od prawej do lewej"
+msgstr "RLE — o_sadzanie od prawej do lewej"
 
 #: ../LocalizedStringsGtk.cpp:386
 msgid "LRO Left-to-right _override"
-msgstr "LRO _zastąpienie od lewej do prawej"
+msgstr "LRO — _zastąpienie od lewej do prawej"
 
 #: ../LocalizedStringsGtk.cpp:391
 msgid "RLO Right-to-left o_verride"
-msgstr "RLO z_astąpienie od prawej do lewej"
+msgstr "RLO — z_astąpienie od prawej do lewej"
 
 #: ../LocalizedStringsGtk.cpp:396
 msgid "PDF _Pop directional formatting"
-msgstr "PDF formatowanie kierunkowe _Pop"
+msgstr "PDF — formatowanie kierunkowe _Pop"
 
 #: ../LocalizedStringsGtk.cpp:401
 msgid "ZWS _Zero width space"
-msgstr "ZWS spacja o _zerowej szerokości"
+msgstr "ZWS — spacja o _zerowej szerokości"
 
 #: ../LocalizedStringsGtk.cpp:406
 msgid "ZWJ Zero width _joiner"
-msgstr "ZWJ łą_cznik o zerowej szerokości"
+msgstr "ZWJ — łą_cznik o zerowej szerokości"
 
 #: ../LocalizedStringsGtk.cpp:411
 msgid "ZWNJ Zero width _non-joiner"
-msgstr "ZWNJ _bezłącznik o zerowej szerokości"
+msgstr "ZWNJ — _bezłącznik o zerowej szerokości"
 
 #: ../LocalizedStringsGtk.cpp:416
 msgid "No recent searches"
@@ -365,257 +365,252 @@
 msgstr "Niepowodzenie wtyczki"
 
 #. FIXME: If this file gets localized, this should really be localized as one string with a wildcard for the number.
-#: ../LocalizedStringsGtk.cpp:536
+#: ../LocalizedStringsGtk.cpp:530
 msgid " files"
 msgstr " plików"
 
-#: ../LocalizedStringsGtk.cpp:541
+#: ../LocalizedStringsGtk.cpp:535
 msgid "Unknown"
 msgstr "Nieznane"
 
-#: ../LocalizedStringsGtk.cpp:546
+#: ../LocalizedStringsGtk.cpp:540
 #, c-format
 msgctxt "Title string for images"
 msgid "%s  (%dx%d pixels)"
-msgstr "%s  (%dx%d pikseli)"
+msgstr "%s  (%d×%d pikseli)"
 
-#: ../LocalizedStringsGtk.cpp:557
+#: ../LocalizedStringsGtk.cpp:551
 msgid "Loading..."
-msgstr "Wczytywanie..."
+msgstr "Wczytywanie…"
 
-#: ../LocalizedStringsGtk.cpp:562
+#: ../LocalizedStringsGtk.cpp:556
 msgid "Live Broadcast"
 msgstr "Nadawanie na żywo"
 
-#: ../LocalizedStringsGtk.cpp:568
+#: ../LocalizedStringsGtk.cpp:562
 msgid "audio playback"
 msgstr "odtwarzanie dźwięku"
 
-#: ../LocalizedStringsGtk.cpp:570
+#: ../LocalizedStringsGtk.cpp:564
 msgid "video playback"
 msgstr "odtwarzanie wideo"
 
-#: ../LocalizedStringsGtk.cpp:572
+#: ../LocalizedStringsGtk.cpp:566
 msgid "mute"
 msgstr "wyciszenie"
 
-#: ../LocalizedStringsGtk.cpp:574
+#: ../LocalizedStringsGtk.cpp:568
 msgid "unmute"
 msgstr "wyłączenie wyciszenia"
 
-#: ../LocalizedStringsGtk.cpp:576
+#: ../LocalizedStringsGtk.cpp:570
 msgid "play"
 msgstr "odtworzenie"
 
-#: ../LocalizedStringsGtk.cpp:578
+#: 

[webkit-changes] [189666] trunk/Source/WebCore/platform/gtk/po

[mcatanzaro]

Title: [189666] trunk/Source/WebCore/platform/gtk/po








Revision 189666
Author mcatanz...@igalia.com
Date 2015-09-12 18:11:46 -0700 (Sat, 12 Sep 2015)


Log Message
Updated Slovenian translation
https://bugs.webkit.org/show_bug.cgi?id=123080

Unreviewed.

Patch by Matej Urbančič  on 2015-09-12

* sl.po:

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog
trunk/Source/WebCore/platform/gtk/po/sl.po




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (189665 => 189666)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-13 01:08:22 UTC (rev 189665)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-13 01:11:46 UTC (rev 189666)
@@ -1,3 +1,12 @@
+2015-09-12  Matej Urbančič  
+
+Updated Slovenian translation
+https://bugs.webkit.org/show_bug.cgi?id=123080
+
+Unreviewed.
+
+* sl.po:
+
 2015-09-12  Shantha kumar  
 
 Webkit Tamil translations updated


Modified: trunk/Source/WebCore/platform/gtk/po/sl.po (189665 => 189666)

--- trunk/Source/WebCore/platform/gtk/po/sl.po	2015-09-13 01:08:22 UTC (rev 189665)
+++ trunk/Source/WebCore/platform/gtk/po/sl.po	2015-09-13 01:11:46 UTC (rev 189666)
@@ -9,8 +9,8 @@
 msgstr ""
 "Project-Id-Version: webkit HEAD\n"
 "Report-Msgid-Bugs-To: http://bugs.webkit.org\n"
-"POT-Creation-Date: 2013-03-19 18:04+\n"
-"PO-Revision-Date: 2013-03-24 13:29+0100\n"
+"POT-Creation-Date: 2013-09-16 15:07+\n"
+"PO-Revision-Date: 2013-10-20 08:09+0100\n"
 "Last-Translator: Matej Urbančič \n"
 "Language-Team: Slovenian GNOME Translation Team \n"
 "Language: sl_SI\n"
@@ -62,27 +62,6 @@
 msgid "Invalid page range"
 msgstr "Neveljaven obseg strani"
 
-#: ../GtkAuthenticationDialog.cpp:171
-#, c-format
-msgid "The site %s:%i requests a username and password"
-msgstr "Spletišče %s:%i zahteva uporabniško ime in geslo"
-
-#: ../GtkAuthenticationDialog.cpp:175
-msgid "_Remember password"
-msgstr "Za_pomni si geslo"
-
-#: ../GtkAuthenticationDialog.cpp:201
-msgid "Server message:"
-msgstr "Sporočilo strežnika:"
-
-#: ../GtkAuthenticationDialog.cpp:202 ../GtkAuthenticationDialog.cpp:210
-msgid "Username:"
-msgstr "Uporabniško ime:"
-
-#: ../GtkAuthenticationDialog.cpp:203 ../GtkAuthenticationDialog.cpp:211
-msgid "Password:"
-msgstr "Geslo:"
-
 #: ../LocalizedStringsGtk.cpp:56 ../LocalizedStringsGtk.cpp:61
 msgid "Submit"
 msgstr "Pošlji"
@@ -148,465 +127,522 @@
 msgstr "Odpri _zvok v novem oknu"
 
 #: ../LocalizedStringsGtk.cpp:146
+#| msgid "_Download Linked File"
+msgid "Download _Video"
+msgstr "Prejmi _sliko"
+
+#: ../LocalizedStringsGtk.cpp:151
+#| msgid "_Download Linked File"
+msgid "Download _Audio"
+msgstr "Prejmi _zvok"
+
+#: ../LocalizedStringsGtk.cpp:156
 msgid "Cop_y Video Link Location"
 msgstr "Kopiraj mesto slikovne _povezave"
 
-#: ../LocalizedStringsGtk.cpp:151
+#: ../LocalizedStringsGtk.cpp:161
 msgid "Cop_y Audio Link Location"
 msgstr "Kopiraj mesto zvočne _povezave"
 
-#: ../LocalizedStringsGtk.cpp:156
+#: ../LocalizedStringsGtk.cpp:166
 msgid "_Toggle Media Controls"
 msgstr "_Preklopi predstavne tipke"
 
-#: ../LocalizedStringsGtk.cpp:161
+#: ../LocalizedStringsGtk.cpp:171
+#| msgid "_Toggle Media Controls"
+msgid "_Show Media Controls"
+msgstr "_Pokaži predstavne tipke"
+
+#: ../LocalizedStringsGtk.cpp:176
+#| msgid "_Toggle Media Controls"
+msgid "_Hide Media Controls"
+msgstr "_Skrij predstavne tipke"
+
+#: ../LocalizedStringsGtk.cpp:181
 msgid "Toggle Media _Loop Playback"
 msgstr "Preklopi predvajanje v _zanki"
 
-#: ../LocalizedStringsGtk.cpp:166
+#: ../LocalizedStringsGtk.cpp:186
 msgid "Switch Video to _Fullscreen"
 msgstr "Preklopi sliko na _cel zaslon"
 
-#: ../LocalizedStringsGtk.cpp:171
+#: ../LocalizedStringsGtk.cpp:191
 msgid "_Play"
 msgstr "_Predvajaj"
 
-#: ../LocalizedStringsGtk.cpp:176
+#: ../LocalizedStringsGtk.cpp:196
 msgid "_Pause"
 msgstr "_Premor"
 
-#: ../LocalizedStringsGtk.cpp:181
+#: ../LocalizedStringsGtk.cpp:201
 msgid "_Mute"
 msgstr "_Nemo"
 
-#: ../LocalizedStringsGtk.cpp:186
+#: ../LocalizedStringsGtk.cpp:206
 msgid "Open _Frame in New Window"
 msgstr "Odpri okvir v _novem oknu"
 
-#: ../LocalizedStringsGtk.cpp:209
+#: ../LocalizedStringsGtk.cpp:229
 msgid "_Insert Unicode Control Character"
 msgstr "_Vstavi nadzorni znak Unicode"
 
-#: ../LocalizedStringsGtk.cpp:214
+#: ../LocalizedStringsGtk.cpp:234
 msgid "Input _Methods"
 msgstr "_Načini vnosa"
 
-#: ../LocalizedStringsGtk.cpp:237
+#: ../LocalizedStringsGtk.cpp:257
 msgid "_Reload"
 msgstr "_Ponovno naloži"
 
-#: ../LocalizedStringsGtk.cpp:254
+#: ../LocalizedStringsGtk.cpp:274
 msgid "No Guesses Found"
 msgstr "Ni najdenih ugibanj"
 
-#: ../LocalizedStringsGtk.cpp:259
+#: ../LocalizedStringsGtk.cpp:279
 msgid "_Ignore Spelling"
 msgstr "_Prezri črkovanje"
 
-#: ../LocalizedStringsGtk.cpp:264
+#: ../LocalizedStringsGtk.cpp:284
 msgid "_Learn Spelling"
 msgstr "_Zapomni si črkovanje"
 
-#: 

[webkit-changes] [189665] trunk/Source/WebCore/platform/gtk/po

[mcatanzaro]

Title: [189665] trunk/Source/WebCore/platform/gtk/po








Revision 189665
Author mcatanz...@igalia.com
Date 2015-09-12 18:08:22 -0700 (Sat, 12 Sep 2015)


Log Message
Webkit Tamil translations updated
https://bugs.webkit.org/show_bug.cgi?id=139478

Unreviewed.

Patch by Shantha kumar  on 2015-09-12

* ta.po:

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog
trunk/Source/WebCore/platform/gtk/po/ta.po




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (189664 => 189665)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-12 23:56:21 UTC (rev 189664)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-13 01:08:22 UTC (rev 189665)
@@ -1,3 +1,12 @@
+2015-09-12  Shantha kumar  
+
+Webkit Tamil translations updated
+https://bugs.webkit.org/show_bug.cgi?id=139478
+
+Unreviewed.
+
+* ta.po:
+
 2015-09-12  Zahari Yurukov  
 
 [l10n] Updated Bulgarian translation


Modified: trunk/Source/WebCore/platform/gtk/po/ta.po (189664 => 189665)

--- trunk/Source/WebCore/platform/gtk/po/ta.po	2015-09-12 23:56:21 UTC (rev 189664)
+++ trunk/Source/WebCore/platform/gtk/po/ta.po	2015-09-13 01:08:22 UTC (rev 189665)
@@ -6,8 +6,8 @@
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: http://bugs.webkit.org\n"
-"POT-Creation-Date: 2014-09-10 10:57+\n"
-"PO-Revision-Date: 2014-09-15 15:44+0630\n"
+"POT-Creation-Date: 2014-10-25 10:53+\n"
+"PO-Revision-Date: 2014-12-10 18:57+0530\n"
 "Last-Translator: Shantha kumar \n"
 "Language-Team: Tamil \n"
 "Language: ta\n"
@@ -599,49 +599,60 @@
 msgid "No label"
 msgstr "லேபிள் இல்லை"
 
-#: ../LocalizedStringsGtk.cpp:817
+#: ../LocalizedStringsGtk.cpp:816
+#| msgctxt "Menu item label for a closed captions track that has no other name"
+#| msgid "No label"
+msgctxt "Menu item label for an audio track that has no other name"
+msgid "No label"
+msgstr "லேபிள் இல்லை"
+
+#: ../LocalizedStringsGtk.cpp:822
 msgctxt "Snapshotted Plug-In"
 msgid "Title of the label to show on a snapshotted plug-in"
 msgstr ""
 "ஸ்னாப்ஷாட் செய்யப்பட்ட செருகுநிரலில் காண்பிக்கப்பட வேண்டிய லேபிளின் தலைப்பு"
 
-#: ../LocalizedStringsGtk.cpp:822
+#: ../LocalizedStringsGtk.cpp:827
 msgctxt "Click to restart"
 msgid "Subtitle of the label to show on a snapshotted plug-in"
 msgstr ""
 "ஸ்னாப்ஷாட் செய்யப்பட்ட செருகுநிரலில் காண்பிக்கப்பட வேண்டிய லேபிளின் "
 "துணைத்தலைப்பு"
 
-#: ../WebKitAuthenticationWidget.cpp:155
+#: ../../../../WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:99
 #, c-format
+msgid ""
+"Cannot determine destination URI for download with suggested filename %s"
+msgstr ""
+"பரிந்துரைக்கப்பட்ட கோப்புப் பெயரான %s ஐக் கொண்டுள்ள பதிவறக்குத்துக்கான இலக்கு "
+"URI ஐத் "
+"தீர்மானிக்க முடியவில்லை"
+
+#. Prompt on the HTTP authentication dialog.
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:114
+#, c-format
 msgid "The site %s:%i requests a username and password"
 msgstr "தளம் %s:%i பயனர் பெயரையும் கடவுச்சொலையும் கோருகிறது"
 
-#: ../WebKitAuthenticationWidget.cpp:159
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:122
+msgid "Server message:"
+msgstr "சேவையக செய்தி:"
+
+#. Check button on the HTTP authentication dialog.
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:129
 msgid "_Remember password"
 msgstr "கடவுச்சொல்லை நினைவில் கொள் (_R)"
 
-#: ../WebKitAuthenticationWidget.cpp:167
-msgid "Server message:"
-msgstr "சேவையக செய்தி:"
-
-#: ../WebKitAuthenticationWidget.cpp:168 ../WebKitAuthenticationWidget.cpp:177
+#. Entry on the HTTP authentication dialog.
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:133
 msgid "Username:"
 msgstr "பயனர்பெயர்:"
 
-#: ../WebKitAuthenticationWidget.cpp:169 ../WebKitAuthenticationWidget.cpp:178
+#. Entry on the HTTP authentication dialog.
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:144
 msgid "Password:"
 msgstr "கடவுச்சொல்:"
 
-#: ../../../../WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:99
-#, c-format
-msgid ""
-"Cannot determine destination URI for download with suggested filename %s"
-msgstr ""
-"பரிந்துரைக்கப்பட்ட கோப்புப் பெயரான %s ஐக் கொண்டுள்ள பதிவறக்குத்துக்கான இலக்கு "
-"URI ஐத் "
-"தீர்மானிக்க முடியவில்லை"
-
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitDownload.cpp:164
 msgid "Destination"
 msgstr "இலக்கு"
@@ -672,7 +683,6 @@
 msgstr "மேலெழுத அனுமதிக்கவும்"
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitDownload.cpp:215
-#| msgid "Whether the window can be resized."
 msgid "Whether the destination may be overwritten"
 msgstr "இலக்கு மேலெழுதப்படலாமா"
 
@@ -807,12 +817,10 @@
 msgstr "மீடியா URI"
 
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:113
-#| msgid "Navigation type"
 msgid "Navigation action"
 msgstr "வழிசெலுத்தல் செயல்"
 
 #: 

[webkit-changes] [189673] trunk/Source/WebCore/platform/gtk/po

[mcatanzaro]

Title: [189673] trunk/Source/WebCore/platform/gtk/po








Revision 189673
Author mcatanz...@igalia.com
Date 2015-09-13 07:01:49 -0700 (Sun, 13 Sep 2015)


Log Message
Webkit Gujarati Translations
https://bugs.webkit.org/show_bug.cgi?id=139530

Unreviewed.

Patch by Ankit Patel  on 2015-09-13

* gu.po:

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog
trunk/Source/WebCore/platform/gtk/po/gu.po




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (189672 => 189673)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-13 06:46:30 UTC (rev 189672)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-13 14:01:49 UTC (rev 189673)
@@ -1,3 +1,12 @@
+2015-09-13  Ankit Patel  
+
+Webkit Gujarati Translations
+https://bugs.webkit.org/show_bug.cgi?id=139530
+
+Unreviewed.
+
+* gu.po:
+
 2015-09-12  Francisco Serrador  
 
 Updated Spanish translation


Modified: trunk/Source/WebCore/platform/gtk/po/gu.po (189672 => 189673)

--- trunk/Source/WebCore/platform/gtk/po/gu.po	2015-09-13 06:46:30 UTC (rev 189672)
+++ trunk/Source/WebCore/platform/gtk/po/gu.po	2015-09-13 14:01:49 UTC (rev 189673)
@@ -8,8 +8,8 @@
 msgstr ""
 "Project-Id-Version: webkit.gu\n"
 "Report-Msgid-Bugs-To: http://bugs.webkit.org\n"
-"POT-Creation-Date: 2014-08-28 22:55+\n"
-"PO-Revision-Date: 2014-09-04 15:13+0530\n"
+"POT-Creation-Date: 2014-10-25 10:53+\n"
+"PO-Revision-Date: 2014-12-11 10:49+0530\n"
 "Last-Translator: \n"
 "Language-Team: American English \n"
 "Language: \n"
@@ -125,12 +125,10 @@
 msgstr "નવી વિન્ડોમાં ઓડિયો ખોલો (_A)"
 
 #: ../LocalizedStringsGtk.cpp:145
-#| msgid "_Download Linked File"
 msgid "Download _Video"
 msgstr "વિડિઓને ડાઉનલોડ કરો (_V)"
 
 #: ../LocalizedStringsGtk.cpp:150
-#| msgid "_Download Linked File"
 msgid "Download _Audio"
 msgstr "ઓડિયોને ડાઉનલોડ કરો (_A)"
 
@@ -147,12 +145,10 @@
 msgstr "ટૉગલ મીડિયા નિયંત્રણ (_T)"
 
 #: ../LocalizedStringsGtk.cpp:170
-#| msgid "_Toggle Media Controls"
 msgid "_Show Media Controls"
 msgstr "મીડિયા નિયંત્રણને બતાવો (_S)"
 
 #: ../LocalizedStringsGtk.cpp:175
-#| msgid "_Toggle Media Controls"
 msgid "_Hide Media Controls"
 msgstr "મીડિયા નિયંત્રણને છુપાડો (_H)"
 
@@ -321,7 +317,6 @@
 msgstr "પદ"
 
 #: ../LocalizedStringsGtk.cpp:446
-#| msgid "definition"
 msgid "description"
 msgstr "વર્ણન"
 
@@ -389,12 +384,10 @@
 msgstr "જીવંત પ્રસારણ"
 
 #: ../LocalizedStringsGtk.cpp:568
-#| msgid "pause playback"
 msgid "audio playback"
 msgstr "ઓડિયો વગાડો"
 
 #: ../LocalizedStringsGtk.cpp:570
-#| msgid "begin playback"
 msgid "video playback"
 msgstr "વિડિયો વગાડો"
 
@@ -583,7 +576,6 @@
 msgstr "અસ્વીકારી TLS પ્રમાણપત્ર"
 
 #: ../LocalizedStringsGtk.cpp:791
-#| msgid "stop displaying closed captions"
 msgctxt "Closed Captions"
 msgid "Menu section heading for closed captions"
 msgstr "મેનુ વિભાગ બંધ કૅપ્શન માટે મથાળું"
@@ -594,8 +586,7 @@
 msgstr "ઉપશીર્ષકો"
 
 #: ../LocalizedStringsGtk.cpp:801
-msgctxt ""
-"Menu item label for the track that represents disabling closed captions"
+msgctxt "Menu item label for the track that represents disabling closed captions"
 msgid "Off"
 msgstr "બંધ"
 
@@ -609,73 +600,87 @@
 msgid "No label"
 msgstr "લેબલ નથી"
 
-#: ../LocalizedStringsGtk.cpp:817
+#: ../LocalizedStringsGtk.cpp:816
+#| msgctxt "Menu item label for a closed captions track that has no other name"
+#| msgid "No label"
+msgctxt "Menu item label for an audio track that has no other name"
+msgid "No label"
+msgstr "લેબલ નથી"
+
+#: ../LocalizedStringsGtk.cpp:822
 msgctxt "Snapshotted Plug-In"
 msgid "Title of the label to show on a snapshotted plug-in"
 msgstr "સ્નેપશોટ થયેલ પ્લગ-ઇન પર બતાવવા માટે લેબલનું શીર્ષક"
 
-#: ../LocalizedStringsGtk.cpp:822
+#: ../LocalizedStringsGtk.cpp:827
 msgctxt "Click to restart"
 msgid "Subtitle of the label to show on a snapshotted plug-in"
 msgstr "સ્નેપશોટ થયેલ પ્લગઇન પર બતાવવા માટે લેબલનું ઉપશીર્ષક"
 
-#: ../WebKitAuthenticationWidget.cpp:155
+#: ../../../../WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:99
 #, c-format
+msgid "Cannot determine destination URI for download with suggested filename %s"
+msgstr "સૂચિત ફાઇલનામ %s સાથે ડાઉનલોડ માટે લક્ષ્ય URI ને નક્કી કરી શકાતુ નથી"
+
+#. Prompt on the HTTP authentication dialog.
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:114
+#, c-format
 msgid "The site %s:%i requests a username and password"
 msgstr "સાઇટ %s:%i એ વપરાશકર્તાનામ અને પાસવર્ડની માંગણી કરે છે"
 
-#: ../WebKitAuthenticationWidget.cpp:159
-msgid "_Remember password"
-msgstr "પાસવર્ડ યાદ રાખો (_R)"
-
-#: ../WebKitAuthenticationWidget.cpp:167
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:122
 msgid "Server message:"
 msgstr "સર્વર સંદેશો:"
 
-#: ../WebKitAuthenticationWidget.cpp:168 ../WebKitAuthenticationWidget.cpp:177
+#. Check button on the HTTP authentication dialog.
+#: 

[webkit-changes] [189812] trunk/Source/WebCore/platform/gtk/po

[mcatanzaro]

Title: [189812] trunk/Source/WebCore/platform/gtk/po








Revision 189812
Author mcatanz...@igalia.com
Date 2015-09-15 10:48:58 -0700 (Tue, 15 Sep 2015)


Log Message
[GTK] Remove outdated README under po directory
https://bugs.webkit.org/show_bug.cgi?id=149166

Reviewed by Martin Robinson.

* README: Removed.

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog


Removed Paths

trunk/Source/WebCore/platform/gtk/po/README




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (189811 => 189812)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 17:43:27 UTC (rev 189811)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-15 17:48:58 UTC (rev 189812)
@@ -1,3 +1,12 @@
+2015-09-15  Michael Catanzaro  
+
+[GTK] Remove outdated README under po directory
+https://bugs.webkit.org/show_bug.cgi?id=149166
+
+Reviewed by Martin Robinson.
+
+* README: Removed.
+
 2015-09-13  Ankit Patel  
 
 Webkit Gujarati Translations


Deleted: trunk/Source/WebCore/platform/gtk/po/README (189811 => 189812)

--- trunk/Source/WebCore/platform/gtk/po/README	2015-09-15 17:43:27 UTC (rev 189811)
+++ trunk/Source/WebCore/platform/gtk/po/README	2015-09-15 17:48:58 UTC (rev 189812)
@@ -1,11 +0,0 @@
-===
-WebKitGTK+ Localization
-===
-
-WebKitGTK+'s build system is very unorthodox. This means that you will
-not get to run the usual make commands in the po directory.
-
-To refresh the .pot file, go to the root of the build directory, and
-run `make webkit.pot-update'. To update the .po files using the new
-.pot file run `make update-po'. This will also build the .mo files.
-






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189912] trunk/Source/WebKit2

[mcatanzaro]

Title: [189912] trunk/Source/WebKit2








Revision 189912
Author mcatanz...@igalia.com
Date 2015-09-17 06:00:48 -0700 (Thu, 17 Sep 2015)


Log Message
[GTK] Crash in WebKit::BackingStore::createBackend running under Wayland
https://bugs.webkit.org/show_bug.cgi?id=147453

Reviewed by Carlos Garcia Campos.

Except when running on X11, this function always crashes if called before the web view is
realized, as gdk_window_create_similar_surface will return null in that case. Avoid this by
simply realizing the widget before calling that.

Thanks to Carlos Garnacho for some debugging help.

* UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::createBackend):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/cairo/BackingStoreCairo.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (189911 => 189912)

--- trunk/Source/WebKit2/ChangeLog	2015-09-17 12:13:30 UTC (rev 189911)
+++ trunk/Source/WebKit2/ChangeLog	2015-09-17 13:00:48 UTC (rev 189912)
@@ -1,3 +1,19 @@
+2015-09-17  Michael Catanzaro  
+
+[GTK] Crash in WebKit::BackingStore::createBackend running under Wayland
+https://bugs.webkit.org/show_bug.cgi?id=147453
+
+Reviewed by Carlos Garcia Campos.
+
+Except when running on X11, this function always crashes if called before the web view is
+realized, as gdk_window_create_similar_surface will return null in that case. Avoid this by
+simply realizing the widget before calling that.
+
+Thanks to Carlos Garnacho for some debugging help.
+
+* UIProcess/cairo/BackingStoreCairo.cpp:
+(WebKit::BackingStore::createBackend):
+
 2015-09-16  Carlos Garcia Campos  
 
 printing does not use minimum page zoom factor


Modified: trunk/Source/WebKit2/UIProcess/cairo/BackingStoreCairo.cpp (189911 => 189912)

--- trunk/Source/WebKit2/UIProcess/cairo/BackingStoreCairo.cpp	2015-09-17 12:13:30 UTC (rev 189911)
+++ trunk/Source/WebKit2/UIProcess/cairo/BackingStoreCairo.cpp	2015-09-17 13:00:48 UTC (rev 189912)
@@ -63,7 +63,9 @@
 scaledSize.scale(m_deviceScaleFactor);
 
 #if PLATFORM(GTK)
-RefPtr surface = adoptRef(gdk_window_create_similar_surface(gtk_widget_get_window(m_webPageProxy.viewWidget()),
+GtkWidget* viewWidget = m_webPageProxy.viewWidget();
+gtk_widget_realize(viewWidget);
+RefPtr surface = adoptRef(gdk_window_create_similar_surface(gtk_widget_get_window(viewWidget),
 CAIRO_CONTENT_COLOR_ALPHA, scaledSize.width(), scaledSize.height()));
 #else
 RefPtr surface = adoptRef(cairo_image_surface_create(CAIRO_FORMAT_ARGB32, scaledSize.width(), scaledSize.height()));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190321] trunk

[mcatanzaro]

Title: [190321] trunk








Revision 190321
Author mcatanz...@igalia.com
Date 2015-09-29 12:18:26 -0700 (Tue, 29 Sep 2015)


Log Message
[GTK][CMake] Warning about CMP0058
https://bugs.webkit.org/show_bug.cgi?id=149627

Reviewed by Martin Robinson.

Opt-in to the new behavior for CMP0058.

* CMakeLists.txt:

Modified Paths

trunk/CMakeLists.txt
trunk/ChangeLog




Diff

Modified: trunk/CMakeLists.txt (190320 => 190321)

--- trunk/CMakeLists.txt	2015-09-29 19:04:18 UTC (rev 190320)
+++ trunk/CMakeLists.txt	2015-09-29 19:18:26 UTC (rev 190321)
@@ -1,6 +1,11 @@
 cmake_minimum_required(VERSION 2.8.12)
 project(WebKit)
 
+# This should be removed once we require CMake 3.3.
+if (POLICY CMP0058)
+cmake_policy(SET CMP0058 NEW)
+endif ()
+
 set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/Source/cmake")
 
 if (NOT DEFINED ENABLE_WEBKIT)


Modified: trunk/ChangeLog (190320 => 190321)

--- trunk/ChangeLog	2015-09-29 19:04:18 UTC (rev 190320)
+++ trunk/ChangeLog	2015-09-29 19:18:26 UTC (rev 190321)
@@ -1,3 +1,14 @@
+2015-09-29  Michael Catanzaro  
+
+[GTK][CMake] Warning about CMP0058
+https://bugs.webkit.org/show_bug.cgi?id=149627
+
+Reviewed by Martin Robinson.
+
+Opt-in to the new behavior for CMP0058.
+
+* CMakeLists.txt:
+
 2015-09-28  Brent Fulgham  
 
 [Win] Unreviewed build fix for internal systems.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190045] trunk/Source/WebCore

[mcatanzaro]

Title: [190045] trunk/Source/WebCore








Revision 190045
Author mcatanz...@igalia.com
Date 2015-09-21 00:22:37 -0700 (Mon, 21 Sep 2015)


Log Message
[GTK] REGRESSION(188031): ASSERTION FAILED: menu
https://bugs.webkit.org/show_bug.cgi?id=149379

Reviewed by Carlos Garcia Campos.

Remove assert that no longer makes sense.

* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::setPlatformDescription): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/ContextMenuGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (190044 => 190045)

--- trunk/Source/WebCore/ChangeLog	2015-09-21 07:12:43 UTC (rev 190044)
+++ trunk/Source/WebCore/ChangeLog	2015-09-21 07:22:37 UTC (rev 190045)
@@ -1,3 +1,15 @@
+2015-09-21  Michael Catanzaro  
+
+[GTK] REGRESSION(188031): ASSERTION FAILED: menu
+https://bugs.webkit.org/show_bug.cgi?id=149379
+
+Reviewed by Carlos Garcia Campos.
+
+Remove assert that no longer makes sense.
+
+* platform/gtk/ContextMenuGtk.cpp:
+(WebCore::ContextMenu::setPlatformDescription): Deleted.
+
 2015-09-20  Chris Dumez  
 
 Unreviewed attempt to fix GTK build after r190030.


Modified: trunk/Source/WebCore/platform/gtk/ContextMenuGtk.cpp (190044 => 190045)

--- trunk/Source/WebCore/platform/gtk/ContextMenuGtk.cpp	2015-09-21 07:12:43 UTC (rev 190044)
+++ trunk/Source/WebCore/platform/gtk/ContextMenuGtk.cpp	2015-09-21 07:22:37 UTC (rev 190045)
@@ -61,7 +61,6 @@
 
 void ContextMenu::setPlatformDescription(PlatformMenuDescription menu)
 {
-ASSERT(menu);
 if (m_platformDescription == menu)
 return;
 if (m_platformDescription)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190019] trunk/Source/WebKit2

[mcatanzaro]

Title: [190019] trunk/Source/WebKit2








Revision 190019
Author mcatanz...@igalia.com
Date 2015-09-19 17:17:27 -0700 (Sat, 19 Sep 2015)


Log Message
[GTK] WebEditorClient::supportsGlobalSelection returns true under Wayland
https://bugs.webkit.org/show_bug.cgi?id=149375

Reviewed by Darin Adler.

WebEditorClient::supportsGlobalSelection should return false when running under Wayland,
since Wayland does not have any equivalent for PRIMARY or the concept of a global selection.

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::supportsGlobalSelection):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (190018 => 190019)

--- trunk/Source/WebKit2/ChangeLog	2015-09-19 22:07:58 UTC (rev 190018)
+++ trunk/Source/WebKit2/ChangeLog	2015-09-20 00:17:27 UTC (rev 190019)
@@ -1,3 +1,16 @@
+2015-09-19  Michael Catanzaro  
+
+[GTK] WebEditorClient::supportsGlobalSelection returns true under Wayland
+https://bugs.webkit.org/show_bug.cgi?id=149375
+
+Reviewed by Darin Adler.
+
+WebEditorClient::supportsGlobalSelection should return false when running under Wayland,
+since Wayland does not have any equivalent for PRIMARY or the concept of a global selection.
+
+* WebProcess/WebCoreSupport/WebEditorClient.cpp:
+(WebKit::WebEditorClient::supportsGlobalSelection):
+
 2015-09-19  Dan Bernstein  
 
 Attempted build fix.


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp (190018 => 190019)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp	2015-09-19 22:07:58 UTC (rev 190018)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp	2015-09-20 00:17:27 UTC (rev 190019)
@@ -53,6 +53,10 @@
 #include 
 #include 
 
+#if PLATFORM(X11)
+#include 
+#endif
+
 using namespace WebCore;
 using namespace HTMLNames;
 
@@ -535,7 +539,7 @@
 bool WebEditorClient::supportsGlobalSelection()
 {
 #if PLATFORM(GTK) && PLATFORM(X11)
-return true;
+return PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::X11;
 #else
 // FIXME: Return true on other X11 platforms when they support global selection.
 return false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [193618] trunk/Tools

[mcatanzaro]

Title: [193618] trunk/Tools








Revision 193618
Author mcatanz...@igalia.com
Date 2015-12-07 03:01:10 -0800 (Mon, 07 Dec 2015)


Log Message
[GTK] update-webkitgtk-libs cannot build mesa
https://bugs.webkit.org/show_bug.cgi?id=151535

Reviewed by Martin Robinson.

Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
does not have a stable API and we cannot expect mesa to be buildable unless we control the
LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
--enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.

* gtk/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (193617 => 193618)

--- trunk/Tools/ChangeLog	2015-12-07 09:11:30 UTC (rev 193617)
+++ trunk/Tools/ChangeLog	2015-12-07 11:01:10 UTC (rev 193618)
@@ -1,3 +1,19 @@
+2015-12-07  Michael Catanzaro  
+
+[GTK] update-webkitgtk-libs cannot build mesa
+https://bugs.webkit.org/show_bug.cgi?id=151535
+
+Reviewed by Martin Robinson.
+
+Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
+dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
+on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
+does not have a stable API and we cannot expect mesa to be buildable unless we control the
+LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
+--enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
+
+* gtk/jhbuild.modules:
+
 2015-12-07  Philippe Normand  
 
 [GTK][Mac] libWebExtensionTest link error


Modified: trunk/Tools/gtk/jhbuild.modules (193617 => 193618)

--- trunk/Tools/gtk/jhbuild.modules	2015-12-07 09:11:30 UTC (rev 193617)
+++ trunk/Tools/gtk/jhbuild.modules	2015-12-07 11:01:10 UTC (rev 193618)
@@ -33,9 +33,7 @@
   
   
   
-  
-
-  
+  
 
   
 
@@ -368,14 +366,17 @@
 hash="sha256:3e6ecf134dbf92a74c24d79848fea3a48e59ab95408a38c6405905d95a293011"/>
   
 
-  
+  
 
-+ checkoutdir="Mesa"
 repo="people.freedesktop.org"
-hash="sha256:b51e723f3a20d842c88a92d809435b229fc4744ca0dbec0317d9d4a3ac4c6803">
+hash="sha256:8340e64cdc91999840404c211496f3de38e7b4cb38db34e2f72f1642c5134760">
 
+
+  
+
   
 
   






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [193639] trunk/Tools

[mcatanzaro]

Title: [193639] trunk/Tools








Revision 193639
Author mcatanz...@igalia.com
Date 2015-12-07 10:54:33 -0800 (Mon, 07 Dec 2015)


Log Message
'jhbuild build' should fail immediately when building any module fails
https://bugs.webkit.org/show_bug.cgi?id=145697

Reviewed by Carlos Garcia Campos.

* efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
* gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
Everything is placed under lib instead of lib64 now.
* jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
--exit-on-error when running 'jhbuild build'.
* jhbuild/jhbuildrc_common.py:
(init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
jhbuild should be able to handle these for us without breaking things

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/efl/jhbuildrc
trunk/Tools/gtk/jhbuildrc
trunk/Tools/jhbuild/jhbuild-wrapper
trunk/Tools/jhbuild/jhbuildrc_common.py




Diff

Modified: trunk/Tools/ChangeLog (193638 => 193639)

--- trunk/Tools/ChangeLog	2015-12-07 18:49:59 UTC (rev 193638)
+++ trunk/Tools/ChangeLog	2015-12-07 18:54:33 UTC (rev 193639)
@@ -1,3 +1,19 @@
+2015-12-07  Michael Catanzaro  
+
+'jhbuild build' should fail immediately when building any module fails
+https://bugs.webkit.org/show_bug.cgi?id=145697
+
+Reviewed by Carlos Garcia Campos.
+
+* efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
+* gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
+Everything is placed under lib instead of lib64 now.
+* jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
+--exit-on-error when running 'jhbuild build'.
+* jhbuild/jhbuildrc_common.py:
+(init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
+jhbuild should be able to handle these for us without breaking things
+
 2015-12-07  Xabier Rodriguez Calvar  
 
 Add support to import w3c tests from a repository with a different root that the main repo dir


Modified: trunk/Tools/efl/jhbuildrc (193638 => 193639)

--- trunk/Tools/efl/jhbuildrc	2015-12-07 18:49:59 UTC (rev 193638)
+++ trunk/Tools/efl/jhbuildrc	2015-12-07 18:54:33 UTC (rev 193639)
@@ -22,10 +22,6 @@
 sys.path.insert(0, os.path.join(os.path.dirname(__file__), "../jhbuild") )
 import jhbuildrc_common
 
-# Setting use_lib64 to False is necessary, otherwise CMake will not find
-# the lib64/cmake/ folder that contains the Config.cmake files.
-use_lib64 = False
-
 jhbuildrc_common.init(globals(), "efl") 
 
 addpath('XDG_DATA_DIRS', '/usr/share')


Modified: trunk/Tools/gtk/jhbuildrc (193638 => 193639)

--- trunk/Tools/gtk/jhbuildrc	2015-12-07 18:49:59 UTC (rev 193638)
+++ trunk/Tools/gtk/jhbuildrc	2015-12-07 18:54:33 UTC (rev 193639)
@@ -37,7 +37,4 @@
 # for a module, so we do it here globally since it's a good idea for all other modules as well.
 buildroot = os.path.join(os.path.dirname(checkoutroot), "Build")
 
-if use_lib64:
-os.environ['LLVMPIPE_LIBGL_PATH'] = os.path.abspath(os.path.join(buildroot, 'Mesa', 'lib64', 'gallium'))
-else:
-os.environ['LLVMPIPE_LIBGL_PATH'] = os.path.abspath(os.path.join(buildroot, 'Mesa', 'lib', 'gallium'))
+os.environ['LLVMPIPE_LIBGL_PATH'] = os.path.abspath(os.path.join(buildroot, 'Mesa', 'lib', 'gallium'))


Modified: trunk/Tools/jhbuild/jhbuild-wrapper (193638 => 193639)

--- trunk/Tools/jhbuild/jhbuild-wrapper	2015-12-07 18:49:59 UTC (rev 193638)
+++ trunk/Tools/jhbuild/jhbuild-wrapper	2015-12-07 18:54:33 UTC (rev 193639)
@@ -24,8 +24,8 @@
 import subprocess
 import sys
 
-# 3.12.0
-jhbuild_revision = '5f42e91b05f55bcf1346899fa39fee4e3becca6f'
+# First release to support --exit-on-error option
+jhbuild_revision = 'f524fbe120ebb4b7d209ce0d035cd3d2e4a66bd4'
 
 def determine_platform():
 if '--efl' in sys.argv:
@@ -123,4 +123,4 @@
 
 ensure_jhbuild(platform)
 
-os.execve(jhbuild_path, [jhbuild_path, '--no-interact', '-f', jhbuildutils.get_config_file_for_platform(platform)] + sys.argv[2:], os.environ)
+os.execve(jhbuild_path, [jhbuild_path, '--exit-on-error', '--no-interact', '-f', jhbuildutils.get_config_file_for_platform(platform)] + sys.argv[2:], os.environ)


Modified: trunk/Tools/jhbuild/jhbuildrc_common.py (193638 => 193639)

--- trunk/Tools/jhbuild/jhbuildrc_common.py	2015-12-07 18:49:59 UTC (rev 193638)
+++ trunk/Tools/jhbuild/jhbuildrc_common.py	2015-12-07 18:54:33 UTC (rev 193639)
@@ -72,17 +72,15 @@
 os.environ['GST_PLUGIN_SYSTEM_PATH'] = ''
 
 # Use system libraries while building.
-if jhbuildrc_globals['use_lib64']:
-_library_dir = 'lib64'
-else:
-_library_dir = 'lib'
 addpath = jhbuildrc_globals['addpath']
-addpath('PKG_CONFIG_PATH', os.path.join(os.sep, 'usr', _library_dir, 'pkgconfig'))
+

[webkit-changes] [193896] trunk/Source/WebCore

[mcatanzaro]

Title: [193896] trunk/Source/WebCore








Revision 193896
Author mcatanz...@igalia.com
Date 2015-12-10 02:15:36 -0800 (Thu, 10 Dec 2015)


Log Message
[GTK] RenderThemeGtk::platformActiveSelectionBackgroundColor, et. al. should not clobber state of cached GtkStyleContexts
https://bugs.webkit.org/show_bug.cgi?id=151533

Reviewed by Carlos Garcia Campos.

Remove the style context cache to simplify the code, drastically reduce the number of
expensive save/restore operations performed on style contexts, and avoid unwanted
side-effects in RenderThemeGtk::styleColor. This is also a speculative fix for improper
button rendering with certain custom themes, and a simplification that will make it easier
to fix bug #150550.

This change does have performance implications, which I intend to check on the perf bot
after landing to ensure that removing the cache does not have a significant negative impact
on performance; I have no clue whether this will be a net performance win or loss. However,
this is a bit tricky, because the bot is running GTK+ 3.16, whereas I expect save/restore
might be much more expensive in GTK+ 3.20, and I do not want to make performance decisions
except based on the latest GTK+ due to large changes in the implementation of
GtkStyleContext.

* rendering/RenderThemeGtk.cpp:
(WebCore::createStyleContext):
(WebCore::getStockIconForWidgetType):
(WebCore::getStockSymbolicIconForWidgetType):
(WebCore::RenderThemeGtk::initMediaColors):
(WebCore::RenderThemeGtk::adjustRepaintRect):
(WebCore::setToggleSize):
(WebCore::paintToggle):
(WebCore::RenderThemeGtk::setCheckboxSize):
(WebCore::RenderThemeGtk::setRadioSize):
(WebCore::RenderThemeGtk::paintButton):
(WebCore::getComboBoxMetrics):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeGtk::paintInnerSpinButton):
(WebCore::styleColor):
(WebCore::gtkStyleChangedCallback): Deleted.
(WebCore::styleContextMap): Deleted.
(WebCore::getStyleContext): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (193895 => 193896)

--- trunk/Source/WebCore/ChangeLog	2015-12-10 09:20:01 UTC (rev 193895)
+++ trunk/Source/WebCore/ChangeLog	2015-12-10 10:15:36 UTC (rev 193896)
@@ -1,3 +1,49 @@
+2015-12-10  Michael Catanzaro  
+
+[GTK] RenderThemeGtk::platformActiveSelectionBackgroundColor, et. al. should not clobber state of cached GtkStyleContexts
+https://bugs.webkit.org/show_bug.cgi?id=151533
+
+Reviewed by Carlos Garcia Campos.
+
+Remove the style context cache to simplify the code, drastically reduce the number of
+expensive save/restore operations performed on style contexts, and avoid unwanted
+side-effects in RenderThemeGtk::styleColor. This is also a speculative fix for improper
+button rendering with certain custom themes, and a simplification that will make it easier
+to fix bug #150550.
+
+This change does have performance implications, which I intend to check on the perf bot
+after landing to ensure that removing the cache does not have a significant negative impact
+on performance; I have no clue whether this will be a net performance win or loss. However,
+this is a bit tricky, because the bot is running GTK+ 3.16, whereas I expect save/restore
+might be much more expensive in GTK+ 3.20, and I do not want to make performance decisions
+except based on the latest GTK+ due to large changes in the implementation of
+GtkStyleContext.
+
+* rendering/RenderThemeGtk.cpp:
+(WebCore::createStyleContext):
+(WebCore::getStockIconForWidgetType):
+(WebCore::getStockSymbolicIconForWidgetType):
+(WebCore::RenderThemeGtk::initMediaColors):
+(WebCore::RenderThemeGtk::adjustRepaintRect):
+(WebCore::setToggleSize):
+(WebCore::paintToggle):
+(WebCore::RenderThemeGtk::setCheckboxSize):
+(WebCore::RenderThemeGtk::setRadioSize):
+(WebCore::RenderThemeGtk::paintButton):
+(WebCore::getComboBoxMetrics):
+(WebCore::RenderThemeGtk::paintMenuList):
+(WebCore::RenderThemeGtk::paintTextField):
+(WebCore::RenderThemeGtk::paintSliderTrack):
+(WebCore::RenderThemeGtk::paintSliderThumb):
+(WebCore::RenderThemeGtk::adjustSliderThumbSize):
+(WebCore::RenderThemeGtk::paintProgressBar):
+(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
+(WebCore::RenderThemeGtk::paintInnerSpinButton):
+(WebCore::styleColor):
+(WebCore::gtkStyleChangedCallback): Deleted.
+

[webkit-changes] [194525] trunk/Source/WebCore

[mcatanzaro]

Title: [194525] trunk/Source/WebCore








Revision 194525
Author mcatanz...@igalia.com
Date 2016-01-03 19:35:53 -0800 (Sun, 03 Jan 2016)


Log Message
Unreviewed, turn off temporary scrolling logging on GTK
https://bugs.webkit.org/show_bug.cgi?id=152649

* platform/Logging.cpp:
(WebCore::initializeLoggingChannelsIfNecessary): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Logging.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (194524 => 194525)

--- trunk/Source/WebCore/ChangeLog	2016-01-04 02:58:14 UTC (rev 194524)
+++ trunk/Source/WebCore/ChangeLog	2016-01-04 03:35:53 UTC (rev 194525)
@@ -1,3 +1,11 @@
+2016-01-03  Michael Catanzaro  
+
+Unreviewed, turn off temporary scrolling logging on GTK
+https://bugs.webkit.org/show_bug.cgi?id=152649
+
+* platform/Logging.cpp:
+(WebCore::initializeLoggingChannelsIfNecessary): Deleted.
+
 2016-01-03  Simon Fraser  
 
 Fix Windows build after r194515.


Modified: trunk/Source/WebCore/platform/Logging.cpp (194524 => 194525)

--- trunk/Source/WebCore/platform/Logging.cpp	2016-01-04 02:58:14 UTC (rev 194524)
+++ trunk/Source/WebCore/platform/Logging.cpp	2016-01-04 03:35:53 UTC (rev 194525)
@@ -65,11 +65,6 @@
 haveInitializedLoggingChannels = true;
 
 WTFInitializeLogChannelStatesFromString(logChannels, logChannelCount, logLevelString().utf8().data());
-
-#if PLATFORM(GTK)
-// Temporarily get Scrolling channel data for https://bugs.webkit.org/show_bug.cgi?id=152649.
-LogScrolling.state = WTFLogChannelOn;
-#endif
 }
 
 #ifndef NDEBUG






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194527] trunk/Source/WebCore

[mcatanzaro]

Title: [194527] trunk/Source/WebCore








Revision 194527
Author mcatanz...@igalia.com
Date 2016-01-03 21:20:20 -0800 (Sun, 03 Jan 2016)


Log Message
[GTK] Fix -Wpessimizing-move warnings after switch to WTFMove
https://bugs.webkit.org/show_bug.cgi?id=152677

Reviewed by Andy Estes.

* platform/glib/KeyedDecoderGlib.cpp:
(WebCore::KeyedDecoderGlib::dictionaryFromGVariant):
* platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::createContext):
* platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::createContext):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/glib/KeyedDecoderGlib.cpp
trunk/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp
trunk/Source/WebCore/platform/graphics/glx/GLContextGLX.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (194526 => 194527)

--- trunk/Source/WebCore/ChangeLog	2016-01-04 03:48:49 UTC (rev 194526)
+++ trunk/Source/WebCore/ChangeLog	2016-01-04 05:20:20 UTC (rev 194527)
@@ -1,3 +1,17 @@
+2016-01-03  Michael Catanzaro  
+
+[GTK] Fix -Wpessimizing-move warnings after switch to WTFMove
+https://bugs.webkit.org/show_bug.cgi?id=152677
+
+Reviewed by Andy Estes.
+
+* platform/glib/KeyedDecoderGlib.cpp:
+(WebCore::KeyedDecoderGlib::dictionaryFromGVariant):
+* platform/graphics/egl/GLContextEGL.cpp:
+(WebCore::GLContextEGL::createContext):
+* platform/graphics/glx/GLContextGLX.cpp:
+(WebCore::GLContextGLX::createContext):
+
 2016-01-03  David Kilzer  
 
 -[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:] is missing an m_handle->client() NULL check


Modified: trunk/Source/WebCore/platform/glib/KeyedDecoderGlib.cpp (194526 => 194527)

--- trunk/Source/WebCore/platform/glib/KeyedDecoderGlib.cpp	2016-01-04 03:48:49 UTC (rev 194526)
+++ trunk/Source/WebCore/platform/glib/KeyedDecoderGlib.cpp	2016-01-04 05:20:20 UTC (rev 194527)
@@ -58,7 +58,7 @@
 GVariant* value;
 while (g_variant_iter_loop(, "{}", , ))
 dictionary.set(String::fromUTF8(key), value);
-return WTFMove(dictionary);
+return dictionary;
 }
 
 bool KeyedDecoderGlib::decodeBytes(const String& key, const uint8_t*& bytes, size_t& size)


Modified: trunk/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp (194526 => 194527)

--- trunk/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp	2016-01-04 03:48:49 UTC (rev 194526)
+++ trunk/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp	2016-01-04 05:20:20 UTC (rev 194527)
@@ -209,7 +209,7 @@
 if (!context)
 context = createPbufferContext(eglSharingContext);
 
-return WTFMove(context);
+return context;
 }
 
 GLContextEGL::GLContextEGL(EGLContext context, EGLSurface surface, EGLSurfaceType type)


Modified: trunk/Source/WebCore/platform/graphics/glx/GLContextGLX.cpp (194526 => 194527)

--- trunk/Source/WebCore/platform/graphics/glx/GLContextGLX.cpp	2016-01-04 03:48:49 UTC (rev 194526)
+++ trunk/Source/WebCore/platform/graphics/glx/GLContextGLX.cpp	2016-01-04 05:20:20 UTC (rev 194527)
@@ -136,7 +136,7 @@
 if (!context)
 return nullptr;
 
-return WTFMove(context);
+return context;
 }
 
 GLContextGLX::GLContextGLX(XUniqueGLXContext&& context, XID window)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194480] trunk

[mcatanzaro]

Title: [194480] trunk








Revision 194480
Author mcatanz...@igalia.com
Date 2016-01-01 13:22:22 -0800 (Fri, 01 Jan 2016)


Log Message
[SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
https://bugs.webkit.org/show_bug.cgi?id=152634

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Load GResource URIs locally, not in the network process. Applications expect calling
g_resource_load in a web extension to make it possible to load resource URIs, but that
doesn't work now that the network process is in use. Loading them locally solves this.

* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):

Tools:

* TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
(testLoadFromGResource): Added test.
(beforeAll):
* TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
(registerGResource): Added.
(webkit_web_extension_initialize_with_user_data): Load the test gresource.
* TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
* TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html




Diff

Modified: trunk/Source/WebKit2/ChangeLog (194479 => 194480)

--- trunk/Source/WebKit2/ChangeLog	2016-01-01 16:30:12 UTC (rev 194479)
+++ trunk/Source/WebKit2/ChangeLog	2016-01-01 21:22:22 UTC (rev 194480)
@@ -1,3 +1,17 @@
+2016-01-01  Michael Catanzaro  
+
+[SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
+https://bugs.webkit.org/show_bug.cgi?id=152634
+
+Reviewed by Carlos Garcia Campos.
+
+Load GResource URIs locally, not in the network process. Applications expect calling
+g_resource_load in a web extension to make it possible to load resource URIs, but that
+doesn't work now that the network process is in use. Loading them locally solves this.
+
+* WebProcess/Network/WebLoaderStrategy.cpp:
+(WebKit::WebLoaderStrategy::scheduleLoad):
+
 2016-01-01  Jeff Miller  
 
 Update user-visible copyright strings to include 2016


Modified: trunk/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp (194479 => 194480)

--- trunk/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp	2016-01-01 16:30:12 UTC (rev 194479)
+++ trunk/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp	2016-01-01 21:22:22 UTC (rev 194480)
@@ -160,6 +160,16 @@
 }
 #endif
 
+#if USE(SOUP)
+// For apps that call g_resource_load in a web extension.
+// https://blogs.gnome.org/alexl/2012/01/26/resources-in-glib/
+if (resourceLoader->request().url().protocolIs("resource")) {
+LOG(NetworkScheduling, "(WebProcess) WebLoaderStrategy::scheduleLoad, url '%s' will be handled as a GResource.", resourceLoader->url().string().utf8().data());
+startLocalLoad(*resourceLoader);
+return;
+}
+#endif
+
 LOG(NetworkScheduling, "(WebProcess) WebLoaderStrategy::scheduleLoad, url '%s' will be scheduled with the NetworkProcess with priority %d", resourceLoader->url().string().utf8().data(), static_cast(resourceLoader->request().priority()));
 
 ContentSniffingPolicy contentSniffingPolicy = resourceLoader->shouldSniffContent() ? SniffContent : DoNotSniffContent;


Modified: trunk/Tools/ChangeLog (194479 => 194480)

--- trunk/Tools/ChangeLog	2016-01-01 16:30:12 UTC (rev 194479)
+++ trunk/Tools/ChangeLog	2016-01-01 21:22:22 UTC (rev 194480)
@@ -1,3 +1,19 @@
+2016-01-01  Michael Catanzaro  
+
+[SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
+https://bugs.webkit.org/show_bug.cgi?id=152634
+
+Reviewed by Carlos Garcia Campos.
+
+* TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
+(testLoadFromGResource): Added test.
+(beforeAll):
+* TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
+(registerGResource): Added.
+(webkit_web_extension_initialize_with_user_data): Load the test gresource.
+* TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
+* TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
+
 2015-12-31  David Kilzer  
 
 REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp (194479 => 194480)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp	

[webkit-changes] [194484] trunk/LayoutTests

[mcatanzaro]

Title: [194484] trunk/LayoutTests








Revision 194484
Author mcatanz...@igalia.com
Date 2016-01-01 16:21:06 -0800 (Fri, 01 Jan 2016)


Log Message
[GTK] Several IndexedDB tests failing

Unreviewed gardening.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (194483 => 194484)

--- trunk/LayoutTests/ChangeLog	2016-01-02 00:03:48 UTC (rev 194483)
+++ trunk/LayoutTests/ChangeLog	2016-01-02 00:21:06 UTC (rev 194484)
@@ -1,5 +1,13 @@
 2016-01-01  Michael Catanzaro  
 
+[GTK] Several IndexedDB tests failing
+
+Unreviewed gardening.
+
+* platform/gtk/TestExpectations:
+
+2016-01-01  Michael Catanzaro  
+
 [GTK] http/tests/misc/detached-frame-console.html is crashing
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (194483 => 194484)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2016-01-02 00:03:48 UTC (rev 194483)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2016-01-02 00:21:06 UTC (rev 194484)
@@ -2660,6 +2660,12 @@
 
 webkit.org/b/152057 accessibility/textarea-selected-text-range.html [ Failure Timeout ]
 
+webkit.org/b/152643 imported/w3c/indexeddb/idbcursor-advance.htm [ Failure ]
+webkit.org/b/152643 imported/w3c/indexeddb/idbcursor-continue.htm [ Failure ]
+webkit.org/b/152643 imported/w3c/indexeddb/idbcursor-direction-index.htm [ Failure ]
+webkit.org/b/152643 imported/w3c/indexeddb/idbindex_get2.htm [ Failure ]
+webkit.org/b/152643 imported/w3c/indexeddb/idbindex_getKey2.htm [ Failure ]
+
 #
 # End of Tests failing
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194483] trunk/LayoutTests

[mcatanzaro]

Title: [194483] trunk/LayoutTests








Revision 194483
Author mcatanz...@igalia.com
Date 2016-01-01 16:03:48 -0800 (Fri, 01 Jan 2016)


Log Message
[GTK] http/tests/misc/detached-frame-console.html is crashing

Unreviewed gardening.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (194482 => 194483)

--- trunk/LayoutTests/ChangeLog	2016-01-01 23:51:33 UTC (rev 194482)
+++ trunk/LayoutTests/ChangeLog	2016-01-02 00:03:48 UTC (rev 194483)
@@ -1,5 +1,13 @@
 2016-01-01  Michael Catanzaro  
 
+[GTK] http/tests/misc/detached-frame-console.html is crashing
+
+Unreviewed gardening.
+
+* platform/gtk/TestExpectations:
+
+2016-01-01  Michael Catanzaro  
+
 [GTK] http/tests/media/clearkey/clear-key-hls-aes128.html is crashing
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (194482 => 194483)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2016-01-01 23:51:33 UTC (rev 194482)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2016-01-02 00:03:48 UTC (rev 194483)
@@ -794,6 +794,8 @@
 webkit.org/b/152043 [ Debug ] http/tests/media/hls/video-controls-live-stream.html [ Crash ]
 webkit.org/b/152043 [ Debug ] http/tests/media/hls/video-cookie.html [ Crash ]
 
+webkit.org/b/152642 http/tests/misc/detached-frame-console.html [ Crash Pass Timeout Failure ]
+
 #
 # End of Crashing tests
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194481] trunk/LayoutTests

[mcatanzaro]

Title: [194481] trunk/LayoutTests








Revision 194481
Author mcatanz...@igalia.com
Date 2016-01-01 15:43:33 -0800 (Fri, 01 Jan 2016)


Log Message
[GTK] Expect missing results for CSS table anonymous objects tests

Unreviewed gardening.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (194480 => 194481)

--- trunk/LayoutTests/ChangeLog	2016-01-01 21:22:22 UTC (rev 194480)
+++ trunk/LayoutTests/ChangeLog	2016-01-01 23:43:33 UTC (rev 194481)
@@ -1,3 +1,11 @@
+2016-01-01  Michael Catanzaro  
+
+[GTK] Expect missing results for CSS table anonymous objects tests
+
+Unreviewed gardening.
+
+* platform/gtk/TestExpectations:
+
 2015-12-31  Simon Fraser  
 
 [iOS WK2] Fix incorrect scrollPosition handling


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (194480 => 194481)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2016-01-01 21:22:22 UTC (rev 194480)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2016-01-01 23:43:33 UTC (rev 194481)
@@ -52,8 +52,78 @@
 # Tests that require new results.
 #
 
+# These XHTML files are being processed as HTML files.
+# Need to fix this before we can add expectations.
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-015.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-016.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-023.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-024.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-035.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-036.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-037.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-038.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-045.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-046.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-047.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-048.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-049.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-050.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-055.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-056.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-091.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-092.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-099.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-100.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-103.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-104.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-105.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-106.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-107.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-108.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-109.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-110.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-111.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-112.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-113.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-114.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-115.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-116.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-117.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-118.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-119.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-120.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-121.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-122.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-123.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-124.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-139.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-140.xht [ Missing ]
+webkit.org/b/152455 css2.1/tables/table-anonymous-objects-149.xht [ Missing ]

[webkit-changes] [194482] trunk/LayoutTests

[mcatanzaro]

Title: [194482] trunk/LayoutTests








Revision 194482
Author mcatanz...@igalia.com
Date 2016-01-01 15:51:33 -0800 (Fri, 01 Jan 2016)


Log Message
[GTK] http/tests/media/clearkey/clear-key-hls-aes128.html is crashing

Unreviewed gardening.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (194481 => 194482)

--- trunk/LayoutTests/ChangeLog	2016-01-01 23:43:33 UTC (rev 194481)
+++ trunk/LayoutTests/ChangeLog	2016-01-01 23:51:33 UTC (rev 194482)
@@ -1,5 +1,13 @@
 2016-01-01  Michael Catanzaro  
 
+[GTK] http/tests/media/clearkey/clear-key-hls-aes128.html is crashing
+
+Unreviewed gardening.
+
+* platform/gtk/TestExpectations:
+
+2016-01-01  Michael Catanzaro  
+
 [GTK] Expect missing results for CSS table anonymous objects tests
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (194481 => 194482)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2016-01-01 23:43:33 UTC (rev 194481)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2016-01-01 23:51:33 UTC (rev 194482)
@@ -1428,7 +1428,7 @@
 webkit.org/b/142292 fast/images/animated-gif-zooming.html [ Timeout Pass ]
 
 webkit.org/b/142488 http/tests/appcache/404-resource-with-slow-main-resource.php [ Timeout ]
-webkit.org/b/141959 [ Release ] http/tests/media/clearkey/clear-key-hls-aes128.html [ Timeout ]
+webkit.org/b/141959 [ Release ] http/tests/media/clearkey/clear-key-hls-aes128.html [ Crash Timeout ]
 webkit.org/b/142489 http/tests/media/video-play-waiting.html [ Timeout ]
 webkit.org/b/142490 inspector/css/selector-dynamic-specificity.html [ Timeout ]
 webkit.org/b/142491 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194511] trunk/Tools

[mcatanzaro]

Title: [194511] trunk/Tools








Revision 194511
Author mcatanz...@igalia.com
Date 2016-01-03 08:16:18 -0800 (Sun, 03 Jan 2016)


Log Message
Unreviewed, move Sebastian Dröge to committers list harder

He accidentally added himself to the reviewers list because the file is confusing. Then I
accidentially moved him to the contributors list because the file is confusing, even though
I knew the contributors list existed in this file and was attempting to add him to the
committers list. Really move him to the committers list now.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (194510 => 194511)

--- trunk/Tools/ChangeLog	2016-01-03 16:12:22 UTC (rev 194510)
+++ trunk/Tools/ChangeLog	2016-01-03 16:16:18 UTC (rev 194511)
@@ -1,3 +1,14 @@
+2016-01-03  Michael Catanzaro  
+
+Unreviewed, move Sebastian Dröge to committers list harder
+
+He accidentally added himself to the reviewers list because the file is confusing. Then I
+accidentially moved him to the contributors list because the file is confusing, even though
+I knew the contributors list existed in this file and was attempting to add him to the
+committers list. Really move him to the committers list now.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2016-01-02  Youenn Fablet  
 
 Python SCM should be able to retrieve untracked files - Add SVN support


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (194510 => 194511)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2016-01-03 16:12:22 UTC (rev 194510)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2016-01-03 16:16:18 UTC (rev 194511)
@@ -2627,6 +2627,18 @@
 "sky"
  ]
   },
+  "Sebastian Dr\u00f6ge" : {
+ "emails" : [
+"sl...@coaxion.net",
+"sebast...@centricular.com",
+"sebastian.dro...@collabora.co.uk",
+"sebastian.dro...@collabora.com"
+ ],
+ "expertise" : "WebKitGTK+, Media support (focused on the GStreamer implementation)",
+ "nicks" : [
+"slomo"
+ ]
+  },
   "Seokju Kwon" : {
  "emails" : [
 "seo...@webkit.org",
@@ -3536,18 +3548,6 @@
 "rmondello"
  ]
   },
-  "Sebastian Dr\u00f6ge" : {
- "emails" : [
-"sl...@coaxion.net",
-"sebast...@centricular.com",
-"sebastian.dro...@collabora.co.uk",
-"sebastian.dro...@collabora.com"
- ],
- "expertise" : "WebKitGTK+, Media support (focused on the GStreamer implementation)",
- "nicks" : [
-"slomo"
- ]
-  },
   "Sungmann Cho" : {
  "emails" : [
 "sungmann@navercorp.com",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194682] trunk/LayoutTests

[mcatanzaro]

Title: [194682] trunk/LayoutTests








Revision 194682
Author mcatanz...@igalia.com
Date 2016-01-06 17:39:49 -0800 (Wed, 06 Jan 2016)


Log Message
[GTK] css-multicol-1 tests are failing

Unreviewed gardening.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (194681 => 194682)

--- trunk/LayoutTests/ChangeLog	2016-01-07 01:33:09 UTC (rev 194681)
+++ trunk/LayoutTests/ChangeLog	2016-01-07 01:39:49 UTC (rev 194682)
@@ -1,3 +1,11 @@
+2016-01-06  Michael Catanzaro  
+
+[GTK] css-multicol-1 tests are failing
+
+Unreviewed gardening.
+
+* platform/gtk/TestExpectations:
+
 2016-01-06  Ryan Haddad  
 
 Rebaselining media/airplay-target-availability.html


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (194681 => 194682)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2016-01-07 01:33:09 UTC (rev 194681)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2016-01-07 01:39:49 UTC (rev 194682)
@@ -2677,6 +2677,20 @@
 webkit.org/b/152788 svg/filters/feComposite-background-rect-control-operators.svg [ ImageOnlyFailure ]
 webkit.org/b/152788 svg/filters/feDisplacementMap-filterUnits.svg [ ImageOnlyFailure ]
 
+webkit.org/b/152821 imported/w3c/css/css-multicol-1/multicol-basic-001.html [ ImageOnlyFailure ]
+webkit.org/b/152821 imported/w3c/css/css-multicol-1/multicol-basic-002.html [ ImageOnlyFailure ]
+webkit.org/b/152821 imported/w3c/css/css-multicol-1/multicol-basic-003.html [ ImageOnlyFailure ]
+webkit.org/b/152821 imported/w3c/css/css-multicol-1/multicol-basic-004.html [ ImageOnlyFailure ]
+webkit.org/b/152821 imported/w3c/css/css-multicol-1/multicol-rule-002.xht [ ImageOnlyFailure ]
+webkit.org/b/152821 imported/w3c/css/css-multicol-1/multicol-rule-px-001.xht [ ImageOnlyFailure ]
+webkit.org/b/152821 imported/w3c/css/css-multicol-1/multicol-rule-stacking-001.xht [ ImageOnlyFailure ]
+webkit.org/b/152821 imported/w3c/css/css-multicol-1/multicol-shorthand-001.xht [ ImageOnlyFailure ]
+webkit.org/b/152821 imported/w3c/css/css-multicol-1/multicol-span-all-block-sibling-003.xht [ ImageOnlyFailure ]
+webkit.org/b/152821 imported/w3c/css/css-multicol-1/multicol-span-all-margin-nested-firstchild-001.xht [ ImageOnlyFailure ]
+
+webkit.org/b/152823 imported/w3c/css/css-multicol-1/multicol-rule-inset-000.xht [ ImageOnlyFailure ]
+webkit.org/b/152823 imported/w3c/css/css-multicol-1/multicol-rule-outset-000.xht [ ImageOnlyFailure ]
+
 #
 # End of Tests failing
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194697] trunk/Source/WebCore

[mcatanzaro]

Title: [194697] trunk/Source/WebCore








Revision 194697
Author mcatanz...@igalia.com
Date 2016-01-07 07:00:18 -0800 (Thu, 07 Jan 2016)


Log Message
[SOUP] Consider reducing max simultaneous connections
https://bugs.webkit.org/show_bug.cgi?id=137282

Reviewed by Carlos Garcia Campos.

Reduce max simultaneous connections from 35 to 17, because (a) all major browsers except
Chrome use 17, and (b) Chrome uses 10. The only reason we previously used 35 was that other
browsers were using 35 at the time.

* platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::SoupNetworkSession):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (194696 => 194697)

--- trunk/Source/WebCore/ChangeLog	2016-01-07 14:00:00 UTC (rev 194696)
+++ trunk/Source/WebCore/ChangeLog	2016-01-07 15:00:18 UTC (rev 194697)
@@ -1,3 +1,17 @@
+2016-01-07  Michael Catanzaro  
+
+[SOUP] Consider reducing max simultaneous connections
+https://bugs.webkit.org/show_bug.cgi?id=137282
+
+Reviewed by Carlos Garcia Campos.
+
+Reduce max simultaneous connections from 35 to 17, because (a) all major browsers except
+Chrome use 17, and (b) Chrome uses 10. The only reason we previously used 35 was that other
+browsers were using 35 at the time.
+
+* platform/network/soup/SoupNetworkSession.cpp:
+(WebCore::SoupNetworkSession::SoupNetworkSession):
+
 2016-01-06  Antti Koivisto  
 
 Factor free standing tree style resolve functions into a class


Modified: trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp (194696 => 194697)

--- trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp	2016-01-07 14:00:00 UTC (rev 194696)
+++ trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp	2016-01-07 15:00:18 UTC (rev 194697)
@@ -97,7 +97,7 @@
 // the rule "Do What Every Other Modern Browser Is Doing". They seem
 // to significantly improve page loading time compared to soup's
 // default values.
-static const int maxConnections = 35;
+static const int maxConnections = 17;
 static const int maxConnectionsPerHost = 6;
 
 g_object_set(m_soupSession.get(),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194456] trunk

[mcatanzaro]

Title: [194456] trunk








Revision 194456
Author mcatanz...@igalia.com
Date 2015-12-31 10:50:09 -0800 (Thu, 31 Dec 2015)


Log Message
[CMake] Add error checking to WEBKIT_OPTION_DEFAULT_PORT_VALUE et. al.
https://bugs.webkit.org/show_bug.cgi?id=144069

Reviewed by Martin Robinson.

* Source/cmake/OptionsWin.cmake:
Do not set options that no longer exist.
* Source/cmake/WebKitFeatures.cmake:
Add error checking to ensure that option names passed to WEBKIT_OPTION_DEFAULT_PORT_VALUE,
WEBKIT_OPTION_CONFLICT, and WEBKIT_OPTION_DEPEND are actually valid options that have been
previously-defined. Also, add ENABLE_SVG_OTF_CONVERTER build option, defaulted to off since
no CMake port was using it.

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsWin.cmake
trunk/Source/cmake/WebKitFeatures.cmake




Diff

Modified: trunk/ChangeLog (194455 => 194456)

--- trunk/ChangeLog	2015-12-31 17:54:21 UTC (rev 194455)
+++ trunk/ChangeLog	2015-12-31 18:50:09 UTC (rev 194456)
@@ -1,5 +1,20 @@
 2015-12-31  Michael Catanzaro  
 
+[CMake] Add error checking to WEBKIT_OPTION_DEFAULT_PORT_VALUE et. al.
+https://bugs.webkit.org/show_bug.cgi?id=144069
+
+Reviewed by Martin Robinson.
+
+* Source/cmake/OptionsWin.cmake:
+Do not set options that no longer exist.
+* Source/cmake/WebKitFeatures.cmake:
+Add error checking to ensure that option names passed to WEBKIT_OPTION_DEFAULT_PORT_VALUE,
+WEBKIT_OPTION_CONFLICT, and WEBKIT_OPTION_DEPEND are actually valid options that have been
+previously-defined. Also, add ENABLE_SVG_OTF_CONVERTER build option, defaulted to off since
+no CMake port was using it.
+
+2015-12-31  Michael Catanzaro  
+
 [CMake] Add error checking to catch option manipulation after WEBKIT_OPTION_END
 https://bugs.webkit.org/show_bug.cgi?id=152611
 


Modified: trunk/Source/cmake/OptionsWin.cmake (194455 => 194456)

--- trunk/Source/cmake/OptionsWin.cmake	2015-12-31 17:54:21 UTC (rev 194455)
+++ trunk/Source/cmake/OptionsWin.cmake	2015-12-31 18:50:09 UTC (rev 194456)
@@ -11,7 +11,6 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PROXY PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CHANNEL_MESSAGING PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSP_NEXT PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_CONDITIONAL_RULES PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_TEXT PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_BOX_DECORATION_BREAK PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_COMPOSITING PUBLIC OFF)
@@ -19,35 +18,27 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SHADERS PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SHAPES PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SHAPE_INSIDE PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CURRENTSRC PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CURSOR_VISIBILITY PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CUSTOM_SCHEME_HANDLER PUBLIC OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATAGRID PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATALIST_ELEMENT PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATA_TRANSFER_ITEMS PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DETAILS_ELEMENT PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DEVICE_ORIENTATION PUBLIC OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DIRECTORY_UPLOAD PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DOM4_EVENTS_CONSTRUCTOR PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ES6_GENERATORS PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ES6_MODULES PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FETCH_API PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FILE_SYSTEM PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GEOLOCATION PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING PUBLIC OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_HIGH_DPI_CANVAS PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ICONDATABASE PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTL PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE PUBLIC OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_SPEECH PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_COLOR PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_DATE 

[webkit-changes] [194458] trunk

[mcatanzaro]

Title: [194458] trunk








Revision 194458
Author mcatanz...@igalia.com
Date 2015-12-31 10:50:42 -0800 (Thu, 31 Dec 2015)


Log Message
[GTK][CMake] Do not override default values of build options with the default value
https://bugs.webkit.org/show_bug.cgi?id=152615

Reviewed by Martin Robinson.

Override the default value of build options only when the default value for the GTK+ port
is actually different than the default value in WebKitFeatures.cmake. This way we don't
accidentally override changes to default values in WebKitFeatures.cmake. We should use the
values in WebKitFeatures.cmake except when we make an active choice to do otherwise.

* Source/cmake/OptionsGTK.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (194457 => 194458)

--- trunk/ChangeLog	2015-12-31 18:50:10 UTC (rev 194457)
+++ trunk/ChangeLog	2015-12-31 18:50:42 UTC (rev 194458)
@@ -1,5 +1,19 @@
 2015-12-31  Michael Catanzaro  
 
+[GTK][CMake] Do not override default values of build options with the default value
+https://bugs.webkit.org/show_bug.cgi?id=152615
+
+Reviewed by Martin Robinson.
+
+Override the default value of build options only when the default value for the GTK+ port
+is actually different than the default value in WebKitFeatures.cmake. This way we don't
+accidentally override changes to default values in WebKitFeatures.cmake. We should use the
+values in WebKitFeatures.cmake except when we make an active choice to do otherwise.
+
+* Source/cmake/OptionsGTK.cmake:
+
+2015-12-31  Michael Catanzaro  
+
 [CMake] Add error checking to WEBKIT_OPTION_DEFAULT_PORT_VALUE et. al.
 https://bugs.webkit.org/show_bug.cgi?id=144069
 


Modified: trunk/Source/cmake/OptionsGTK.cmake (194457 => 194458)

--- trunk/Source/cmake/OptionsGTK.cmake	2015-12-31 18:50:10 UTC (rev 194457)
+++ trunk/Source/cmake/OptionsGTK.cmake	2015-12-31 18:50:42 UTC (rev 194458)
@@ -137,57 +137,29 @@
 
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_3D_TRANSFORMS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ALLINONE_BUILD PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ATTACHMENT_ELEMENT PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BATTERY_STATUS PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_TEXT PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_DEVICE_ADAPTATION PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_GRID_LAYOUT PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CURRENTSRC PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CUSTOM_SCHEME_HANDLER PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATABASE_PROCESS PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATALIST_ELEMENT PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DOWNLOAD_ATTRIBUTE PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA_V2 PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FILTERS_LEVEL_2 PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD_DEPRECATED PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE_IN_WORKERS PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_COLOR PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LEGACY_WEB_AUDIO PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LINK_PREFETCH PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_CAPTURE PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_CONTROLS_SCRIPT PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MHTML PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NAVIGATOR_CONTENT_UTILS PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NAVIGATOR_HWCONCURRENCY PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NOTIFICATIONS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PUBLIC_SUFFIX_LIST PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_QUOTA PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOLUTION_MEDIA_QUERY PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REQUEST_ANIMATION_FRAME PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SECCOMP_FILTERS PRIVATE OFF)
 

[webkit-changes] [194454] trunk

[mcatanzaro]

Title: [194454] trunk








Revision 194454
Author mcatanz...@igalia.com
Date 2015-12-31 09:12:05 -0800 (Thu, 31 Dec 2015)


Log Message
[CMake] Add error checking to catch option manipulation after WEBKIT_OPTION_END
https://bugs.webkit.org/show_bug.cgi?id=152611

Reviewed by Martin Robinson.

If WEBKIT_OPTION_DEFINE is called after WEBKIT_OPTION_END, the option never makes its way
into FEATURE_DEFINES and so will be inconsistently set (available to most of the build, but
not to the DOM bindings generator, for example).

If WEBKIT_OPTION_DEFAULT_PORT_VALUE, WEBKIT_OPTION_CONFLICT, or WEBKIT_OPTION_DEPEND are
called after WEBKIT_OPTION_END, they don't do anything.

Add error checking to catch these bugs.

* Source/cmake/WebKitFeatures.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/WebKitFeatures.cmake




Diff

Modified: trunk/ChangeLog (194453 => 194454)

--- trunk/ChangeLog	2015-12-31 16:47:49 UTC (rev 194453)
+++ trunk/ChangeLog	2015-12-31 17:12:05 UTC (rev 194454)
@@ -1,3 +1,21 @@
+2015-12-31  Michael Catanzaro  
+
+[CMake] Add error checking to catch option manipulation after WEBKIT_OPTION_END
+https://bugs.webkit.org/show_bug.cgi?id=152611
+
+Reviewed by Martin Robinson.
+
+If WEBKIT_OPTION_DEFINE is called after WEBKIT_OPTION_END, the option never makes its way
+into FEATURE_DEFINES and so will be inconsistently set (available to most of the build, but
+not to the DOM bindings generator, for example).
+
+If WEBKIT_OPTION_DEFAULT_PORT_VALUE, WEBKIT_OPTION_CONFLICT, or WEBKIT_OPTION_DEPEND are
+called after WEBKIT_OPTION_END, they don't do anything.
+
+Add error checking to catch these bugs.
+
+* Source/cmake/WebKitFeatures.cmake:
+
 2015-12-30  Philippe Normand  
 
 [GTK][Mac] Disable gtk-doc


Modified: trunk/Source/cmake/WebKitFeatures.cmake (194453 => 194454)

--- trunk/Source/cmake/WebKitFeatures.cmake	2015-12-31 16:47:49 UTC (rev 194453)
+++ trunk/Source/cmake/WebKitFeatures.cmake	2015-12-31 17:12:05 UTC (rev 194454)
@@ -3,7 +3,14 @@
 set(PUBLIC YES)
 set(PRIVATE NO)
 
+macro(_ENSURE_OPTION_MODIFICATION_IS_ALLOWED)
+if (NOT _SETTING_WEBKIT_OPTIONS)
+message(FATAL_ERROR "Options must be set between WEBKIT_OPTION_BEGIN and WEBKIT_OPTION_END")
+endif ()
+endmacro()
+
 macro(WEBKIT_OPTION_DEFINE _name _description _public _initial_value)
+_ENSURE_OPTION_MODIFICATION_IS_ALLOWED()
 set(_WEBKIT_AVAILABLE_OPTIONS_DESCRIPTION_${_name} ${_description})
 set(_WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name} ${_public})
 set(_WEBKIT_AVAILABLE_OPTIONS_INITIAL_VALUE_${_name} ${_initial_value})
@@ -14,19 +21,24 @@
 endmacro()
 
 macro(WEBKIT_OPTION_DEFAULT_PORT_VALUE _name _public _value)
+_ENSURE_OPTION_MODIFICATION_IS_ALLOWED()
 set(_WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name} ${_public})
 set(_WEBKIT_AVAILABLE_OPTIONS_INITIAL_VALUE_${_name} ${_value})
 endmacro()
 
 macro(WEBKIT_OPTION_CONFLICT _name _conflict)
+_ENSURE_OPTION_MODIFICATION_IS_ALLOWED()
 list(APPEND _WEBKIT_AVAILABLE_OPTIONS_${_name}_CONFLICTS ${_conflict})
 endmacro()
 
 macro(WEBKIT_OPTION_DEPEND _name _depend)
+_ENSURE_OPTION_MODIFICATION_IS_ALLOWED()
 list(APPEND _WEBKIT_AVAILABLE_OPTIONS_${_name}_DEPENDENCIES ${_depend})
 endmacro()
 
 macro(WEBKIT_OPTION_BEGIN)
+set(_SETTING_WEBKIT_OPTIONS TRUE)
+
 WEBKIT_OPTION_DEFINE(ENABLE_3D_TRANSFORMS "Toggle 3D transforms support" PRIVATE OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_ACCELERATED_2D_CANVAS "Toggle accelerated 2D canvas support" PRIVATE OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_ACCELERATED_OVERFLOW_SCROLLING "Toggle accelerated scrolling support" PRIVATE OFF)
@@ -224,6 +236,8 @@
 endmacro()
 
 macro(WEBKIT_OPTION_END)
+set(_SETTING_WEBKIT_OPTIONS FALSE)
+
 list(SORT _WEBKIT_AVAILABLE_OPTIONS)
 set(_MAX_FEATURE_LENGTH 0)
 foreach (_name ${_WEBKIT_AVAILABLE_OPTIONS})






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194474] trunk/Source/WebKit2

[mcatanzaro]

Title: [194474] trunk/Source/WebKit2








Revision 194474
Author mcatanz...@igalia.com
Date 2015-12-31 16:42:09 -0800 (Thu, 31 Dec 2015)


Log Message
Unreviewed, fix a log message

* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponse):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (194473 => 194474)

--- trunk/Source/WebKit2/ChangeLog	2016-01-01 00:19:20 UTC (rev 194473)
+++ trunk/Source/WebKit2/ChangeLog	2016-01-01 00:42:09 UTC (rev 194474)
@@ -1,3 +1,10 @@
+2015-12-31  Michael Catanzaro  
+
+Unreviewed, fix a log message
+
+* WebProcess/Network/WebResourceLoader.cpp:
+(WebKit::WebResourceLoader::didReceiveResponse):
+
 2015-12-31  David Kilzer  
 
 Stop using USE(CFNETWORK) path on iOS


Modified: trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp (194473 => 194474)

--- trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp	2016-01-01 00:19:20 UTC (rev 194473)
+++ trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp	2016-01-01 00:42:09 UTC (rev 194474)
@@ -98,7 +98,7 @@
 
 void WebResourceLoader::didReceiveResponse(const ResourceResponse& response, bool needsContinueDidReceiveResponseMessage)
 {
-LOG(Network, "(WebProcess) WebResourceLoader::didReceiveResponseWithCertificateInfo for '%s'. Status %d.", m_coreLoader->url().string().utf8().data(), response.httpStatusCode());
+LOG(Network, "(WebProcess) WebResourceLoader::didReceiveResponse for '%s'. Status %d.", m_coreLoader->url().string().utf8().data(), response.httpStatusCode());
 
 Ref protect(*this);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194779] trunk/LayoutTests

[mcatanzaro]

Title: [194779] trunk/LayoutTests








Revision 194779
Author mcatanz...@igalia.com
Date 2016-01-08 13:01:01 -0800 (Fri, 08 Jan 2016)


Log Message
[GTK] Several animation tests fail with accelerated compositing enabled

Unreviewed gardening.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (194778 => 194779)

--- trunk/LayoutTests/ChangeLog	2016-01-08 20:47:11 UTC (rev 194778)
+++ trunk/LayoutTests/ChangeLog	2016-01-08 21:01:01 UTC (rev 194779)
@@ -1,3 +1,11 @@
+2016-01-08  Michael Catanzaro  
+
+[GTK] Several animation tests fail with accelerated compositing enabled
+
+Unreviewed gardening.
+
+* platform/gtk/TestExpectations:
+
 2016-01-08  Lorenzo Tilve  
 
 [GTK] pageoverlay tests are failing


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (194778 => 194779)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2016-01-08 20:47:11 UTC (rev 194778)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2016-01-08 21:01:01 UTC (rev 194779)
@@ -2283,6 +2283,12 @@
 webkit.org/b/132126 media/track/track-cues-enter-exit.html [ Timeout Pass ]
 webkit.org/b/132126 media/video-poster-background.html [ ImageOnlyFailure ]
 
+# These tests fail when accelerated compositing is enabled or when XVFB_SCREEN_DEPTH=8 is not set.
+webkit.org/b/132126 animations/play-state-paused.html [ Failure ]
+webkit.org/b/132126 animations/play-state-suspend.html [ Failure ]
+webkit.org/b/132126 animations/suspend-resume-animation.html [ Failure ]
+webkit.org/b/132126 animations/transform-non-accelerated.html [ Failure ]
+
 webkit.org/b/132233 fast/regions/clip-to-padding-box-vertical-lr.html [ ImageOnlyFailure ]
 
 webkit.org/b/132234 fast/regions/scrolling/wheel-scrollable-single-region.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194822] trunk/Source/WebCore/platform/gtk/po

[mcatanzaro]

Title: [194822] trunk/Source/WebCore/platform/gtk/po








Revision 194822
Author mcatanz...@igalia.com
Date 2016-01-09 15:29:23 -0800 (Sat, 09 Jan 2016)


Log Message
[l10n] Updated Turkish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=152948

"Reviewed" by Michael Catanzaro.

Patch by Muhammet Kara  on 2016-01-09

* tr.po:

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog
trunk/Source/WebCore/platform/gtk/po/tr.po




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (194821 => 194822)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2016-01-09 20:13:57 UTC (rev 194821)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2016-01-09 23:29:23 UTC (rev 194822)
@@ -1,3 +1,12 @@
+2016-01-09  Muhammet Kara  
+
+[l10n] Updated Turkish translation of WebKitGTK+
+https://bugs.webkit.org/show_bug.cgi?id=152948
+
+"Reviewed" by Michael Catanzaro.
+
+* tr.po:
+
 2015-12-20  Bernd Homuth  
 
 German translation update


Modified: trunk/Source/WebCore/platform/gtk/po/tr.po (194821 => 194822)

--- trunk/Source/WebCore/platform/gtk/po/tr.po	2016-01-09 20:13:57 UTC (rev 194821)
+++ trunk/Source/WebCore/platform/gtk/po/tr.po	2016-01-09 23:29:23 UTC (rev 194822)
@@ -6,14 +6,14 @@
 # Sabri Ünal , 2014.
 # Furkan Usta , 2015.
 # Gökhan Gurbetoğlu , 2014, 2015.
-# Muhammet Kara , 2014, 2015.
+# Muhammet Kara , 2014, 2015, 2016.
 #
 msgid ""
 msgstr ""
 "Project-Id-Version: webkit HEAD\n"
 "Report-Msgid-Bugs-To: https://bugs.webkit.org\n"
-"POT-Creation-Date: 2015-08-23 00:17+\n"
-"PO-Revision-Date: 2015-08-23 03:32+0300\n"
+"POT-Creation-Date: 2015-12-09 15:06+\n"
+"PO-Revision-Date: 2016-01-09 22:26+0200\n"
 "Last-Translator: Muhammet Kara \n"
 "Language-Team: Türkçe \n"
 "Language: tr\n"
@@ -31,35 +31,39 @@
 msgid "Not allowed to use restricted network port"
 msgstr "Sınırlı ağ bağlantı noktası kullanmaya izin verilmiyor"
 
-#: ../ErrorsGtk.cpp:45
+#: ../ErrorsGtk.cpp:44
+msgid "Blocked by content blocker"
+msgstr "İçerik engelleyici tarafından engellendi"
+
+#: ../ErrorsGtk.cpp:50
 msgid "URL cannot be shown"
 msgstr "URL gösterilemiyor"
 
-#: ../ErrorsGtk.cpp:51
+#: ../ErrorsGtk.cpp:56
 msgid "Frame load was interrupted"
 msgstr "Çerçeve yükleme kesintiye uğradı"
 
-#: ../ErrorsGtk.cpp:57
+#: ../ErrorsGtk.cpp:62
 msgid "Content with the specified MIME type cannot be shown"
 msgstr "Belirtilen MIME türündeki içerik gösterilemiyor"
 
-#: ../ErrorsGtk.cpp:63
+#: ../ErrorsGtk.cpp:68
 msgid "File does not exist"
 msgstr "Dosya mevcut değil"
 
-#: ../ErrorsGtk.cpp:69
+#: ../ErrorsGtk.cpp:74
 msgid "Plugin will handle load"
 msgstr "Yükleme işini eklenti halledecek"
 
-#: ../ErrorsGtk.cpp:81
+#: ../ErrorsGtk.cpp:86
 msgid "User cancelled the download"
 msgstr "Kullanıcı indirmeyi iptal etti"
 
-#: ../ErrorsGtk.cpp:97
+#: ../ErrorsGtk.cpp:102
 msgid "Printer not found"
 msgstr "Yazıcı bulunamadı"
 
-#: ../ErrorsGtk.cpp:102
+#: ../ErrorsGtk.cpp:107
 msgid "Invalid page range"
 msgstr "Geçersiz sayfa aralığı"
 
@@ -363,8 +367,7 @@
 msgid "Plug-in Failure"
 msgstr "Eklenti Hatası"
 
-#. FIXME: If this file gets localized, this should really be localized as one
-#. string with a wildcard for the number.
+#. FIXME: If this file gets localized, this should really be localized as one string with a wildcard for the number.
 #: ../LocalizedStringsGtk.cpp:530
 msgid " files"
 msgstr "dosya"
@@ -615,7 +618,7 @@
 msgid "Subtitle of the label to show on a snapshotted plug-in"
 msgstr "Görüntüsü alınan bir eklenti üzerinde gösterilecek etiket alt başlığı"
 
-#: ../../../../WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:99
+#: ../../../../WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:100
 #, c-format
 msgid ""
 "Cannot determine destination URI for download with suggested filename %s"
@@ -640,8 +643,7 @@
 msgid "Authentication required by %s:%i"
 msgstr "%s:%i tarafından kaynak doğrulama isteniyor"
 
-#. Label on the HTTP authentication dialog. %s is a (probably English) message
-#. from the website.
+#. Label on the HTTP authentication dialog. %s is a (probably English) message from the website.
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:131
 #, c-format
 msgid "The site says: “%s”"
@@ -1337,14 +1339,14 @@
 msgid "Whether file access is allowed from file URLs."
 msgstr "Dosya adreslerinden (URL) dosya erişimine izin verilip verilmeyeceği."
 
-#: ../../../../WebKit2/UIProcess/API/gtk/WebKitURIRequest.cpp:95
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitURIRequest.cpp:96
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:105
 #: ../../../../WebKit2/UIProcess/API/gtk/WebKitWebResource.cpp:110
-#: ../../../../WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:913
+#: 

[webkit-changes] [194512] trunk/Tools

[mcatanzaro]

Title: [194512] trunk/Tools








Revision 194512
Author mcatanz...@igalia.com
Date 2016-01-03 08:39:54 -0800 (Sun, 03 Jan 2016)


Log Message
Unreviewed, move Frédéric Wang to committers list

He seems to be on the contributors list by accident. He has been landing his own commits for
about two years now.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (194511 => 194512)

--- trunk/Tools/ChangeLog	2016-01-03 16:16:18 UTC (rev 194511)
+++ trunk/Tools/ChangeLog	2016-01-03 16:39:54 UTC (rev 194512)
@@ -1,5 +1,14 @@
 2016-01-03  Michael Catanzaro  
 
+Unreviewed, move Frédéric Wang to committers list
+
+He seems to be on the contributors list by accident. He has been landing his own commits for
+about two years now.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
+2016-01-03  Michael Catanzaro  
+
 Unreviewed, move Sebastian Dröge to committers list harder
 
 He accidentally added himself to the reviewers list because the file is confusing. Then I


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (194511 => 194512)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2016-01-03 16:16:18 UTC (rev 194511)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2016-01-03 16:39:54 UTC (rev 194512)
@@ -979,6 +979,14 @@
 "fmalita"
  ]
   },
+  "Frédéric Wang" : {
+ "emails" : [
+"fred.w...@free.fr"
+ ],
+ "nicks" : [
+"fredw"
+ ]
+  },
   "Fumitoshi Ukai" : {
  "emails" : [
 "u...@chromium.org"
@@ -3278,14 +3286,6 @@
 "epenner"
  ]
   },
-  "Frédéric Wang" : {
- "emails" : [
-"fred.w...@free.fr"
- ],
- "nicks" : [
-"fredw"
- ]
-  },
   "Finnur Thorarinsson" : {
  "emails" : [
 "finnur.web...@gmail.com",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194532] trunk/Source/WebKit2

[mcatanzaro]

Title: [194532] trunk/Source/WebKit2








Revision 194532
Author mcatanz...@igalia.com
Date 2016-01-04 08:13:38 -0800 (Mon, 04 Jan 2016)


Log Message
[GTK] Rename _WebKitWebContextPrivate.context to _WebKitWebContextPrivate.processPool
https://bugs.webkit.org/show_bug.cgi?id=152672

Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitDownloadClient.cpp:
(attachDownloadClientToContext):
* UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
(attachInjectedBundleClientToContext):
* UIProcess/API/gtk/WebKitSecurityManager.cpp:
(registerSecurityPolicyForURIScheme):
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed):
(webkitWebContextDispose):
(webkit_web_context_set_cache_model):
(webkit_web_context_get_cache_model):
(webkit_web_context_clear_cache):
(webkit_web_context_get_cookie_manager):
(ensureFaviconDatabase):
(webkit_web_context_set_favicon_database_directory):
(webkit_web_context_set_additional_plugins_directory):
(webkitWebContextGetPluginThread):
(webkit_web_context_set_tls_errors_policy):
(webkit_web_context_set_disk_cache_directory):
(webkit_web_context_prefetch_dns):
(webkit_web_context_allow_tls_certificate_for_host):
(webkit_web_context_set_process_model):
(webkit_web_context_set_web_process_count_limit):
(webkitWebContextStartDownload):
(webkitWebContextGetProcessPool):
(webkitWebContextCreatePageForWebView):
(webkitWebContextGetContext): Deleted.
* UIProcess/API/gtk/WebKitWebContextPrivate.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitDownloadClient.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInjectedBundleClient.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSecurityManager.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContextPrivate.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (194531 => 194532)

--- trunk/Source/WebKit2/ChangeLog	2016-01-04 16:09:15 UTC (rev 194531)
+++ trunk/Source/WebKit2/ChangeLog	2016-01-04 16:13:38 UTC (rev 194532)
@@ -1,3 +1,39 @@
+2016-01-04  Michael Catanzaro  
+
+[GTK] Rename _WebKitWebContextPrivate.context to _WebKitWebContextPrivate.processPool
+https://bugs.webkit.org/show_bug.cgi?id=152672
+
+Reviewed by Carlos Garcia Campos.
+
+* UIProcess/API/gtk/WebKitDownloadClient.cpp:
+(attachDownloadClientToContext):
+* UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
+(attachInjectedBundleClientToContext):
+* UIProcess/API/gtk/WebKitSecurityManager.cpp:
+(registerSecurityPolicyForURIScheme):
+* UIProcess/API/gtk/WebKitWebContext.cpp:
+(webkitWebContextConstructed):
+(webkitWebContextDispose):
+(webkit_web_context_set_cache_model):
+(webkit_web_context_get_cache_model):
+(webkit_web_context_clear_cache):
+(webkit_web_context_get_cookie_manager):
+(ensureFaviconDatabase):
+(webkit_web_context_set_favicon_database_directory):
+(webkit_web_context_set_additional_plugins_directory):
+(webkitWebContextGetPluginThread):
+(webkit_web_context_set_tls_errors_policy):
+(webkit_web_context_set_disk_cache_directory):
+(webkit_web_context_prefetch_dns):
+(webkit_web_context_allow_tls_certificate_for_host):
+(webkit_web_context_set_process_model):
+(webkit_web_context_set_web_process_count_limit):
+(webkitWebContextStartDownload):
+(webkitWebContextGetProcessPool):
+(webkitWebContextCreatePageForWebView):
+(webkitWebContextGetContext): Deleted.
+* UIProcess/API/gtk/WebKitWebContextPrivate.h:
+
 2016-01-03  Simon Fraser  
 
 Rename scrollPosition(Scrollbar*) to scrollOffset(ScrollbarOrientation)


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitDownloadClient.cpp (194531 => 194532)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitDownloadClient.cpp	2016-01-04 16:09:15 UTC (rev 194531)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitDownloadClient.cpp	2016-01-04 16:13:38 UTC (rev 194532)
@@ -111,6 +111,6 @@
 didCancel,
 0, // processDidCrash
 };
-WKContextSetDownloadClient(toAPI(webkitWebContextGetContext(webContext)), );
+WKContextSetDownloadClient(toAPI(webkitWebContextGetProcessPool(webContext)), );
 }
 


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInjectedBundleClient.cpp (194531 => 194532)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInjectedBundleClient.cpp	2016-01-04 16:09:15 UTC (rev 194531)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInjectedBundleClient.cpp	2016-01-04 16:13:38 UTC (rev 194532)
@@ -140,5 +140,5 @@
 0, // didReceiveSynchronousMessageFromInjectedBundle
 getInjectedBundleInitializationUserData
 };
-WKContextSetInjectedBundleClient(toAPI(webkitWebContextGetContext(webContext)), );
+

[webkit-changes] [194659] trunk/Source/JavaScriptCore

[mcatanzaro]

Title: [194659] trunk/Source/_javascript_Core








Revision 194659
Author mcatanz...@igalia.com
Date 2016-01-06 13:13:32 -0800 (Wed, 06 Jan 2016)


Log Message
Silence -Wtautological-compare
https://bugs.webkit.org/show_bug.cgi?id=152768

Reviewed by Saam Barati.

* runtime/Options.cpp:
(JSC::Options::setAliasedOption):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Options.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (194658 => 194659)

--- trunk/Source/_javascript_Core/ChangeLog	2016-01-06 21:06:42 UTC (rev 194658)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-01-06 21:13:32 UTC (rev 194659)
@@ -1,3 +1,13 @@
+2016-01-06  Michael Catanzaro  
+
+Silence -Wtautological-compare
+https://bugs.webkit.org/show_bug.cgi?id=152768
+
+Reviewed by Saam Barati.
+
+* runtime/Options.cpp:
+(JSC::Options::setAliasedOption):
+
 2016-01-06  Filip Pizlo  
 
 Make sure that the basic throw-from-operation mode of throwing makes sense in FTL B3


Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (194658 => 194659)

--- trunk/Source/_javascript_Core/runtime/Options.cpp	2016-01-06 21:06:42 UTC (rev 194658)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp	2016-01-06 21:13:32 UTC (rev 194659)
@@ -33,6 +33,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -597,6 +598,13 @@
 if (!equalStr)
 return false;
 
+#if COMPILER(CLANG)
+#if __has_warning("-Wtautological-compare")
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wtautological-compare"
+#endif
+#endif
+
 // For each option, check if the specify arg is a match. If so, set the arg
 // if the value makes sense. Otherwise, move on to checking the next option.
 #define FOR_EACH_OPTION(aliasedName_, unaliasedName_, equivalence) \
@@ -618,6 +626,12 @@
 JSC_ALIASED_OPTIONS(FOR_EACH_OPTION)
 #undef FOR_EACH_OPTION
 
+#if COMPILER(CLANG)
+#if __has_warning("-Wtautological-compare")
+#pragma clang diagnostic pop
+#endif
+#endif
+
 return false; // No option matched.
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194323] trunk/Source

[mcatanzaro]

Title: [194323] trunk/Source








Revision 194323
Author mcatanz...@igalia.com
Date 2015-12-20 17:19:41 -0800 (Sun, 20 Dec 2015)


Log Message
[SOUP] Performs DNS prefetch when a proxy is configured (information leak)
https://bugs.webkit.org/show_bug.cgi?id=145542

Reviewed by Darin Adler.

Source/WebCore:

Perform DNS prefetch only when no proxy is configured.

No new tests. Test this manually with Wireshark. Run the simple-proxy example program found
in libsoup's examples directory, set that as your system HTTP proxy, and see if DNS queries
show up in Wireshark when refreshing a page sent over HTTP. They should appear only when the
proxy is not configured.

* platform/network/DNSResolveQueue.cpp:
(WebCore::DNSResolveQueue::DNSResolveQueue):
(WebCore::DNSResolveQueue::isUsingProxy):
* platform/network/DNSResolveQueue.h:
* platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::updateIsUsingProxy):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences): Deleted.
* platform/network/soup/DNSSoup.cpp:
(WebCore::didResolveProxy):
(WebCore::proxyResolvedForHttpUriCallback):
(WebCore::proxyResolvedForHttpsUriCallback):
(WebCore::DNSResolveQueue::updateIsUsingProxy):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences): Deleted.

Source/WTF:

Specialize GUniquePtr, using g_strfreev.

* wtf/glib/GUniquePtr.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/glib/GUniquePtr.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/DNSResolveQueue.cpp
trunk/Source/WebCore/platform/network/DNSResolveQueue.h
trunk/Source/WebCore/platform/network/cf/DNSCFNet.cpp
trunk/Source/WebCore/platform/network/soup/DNSSoup.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (194322 => 194323)

--- trunk/Source/WTF/ChangeLog	2015-12-20 21:57:01 UTC (rev 194322)
+++ trunk/Source/WTF/ChangeLog	2015-12-21 01:19:41 UTC (rev 194323)
@@ -1,3 +1,14 @@
+2015-12-20  Michael Catanzaro  
+
+[SOUP] Performs DNS prefetch when a proxy is configured (information leak)
+https://bugs.webkit.org/show_bug.cgi?id=145542
+
+Reviewed by Darin Adler.
+
+Specialize GUniquePtr, using g_strfreev.
+
+* wtf/glib/GUniquePtr.h:
+
 2015-12-19  Dan Bernstein  
 
 [Mac] WebKit contains dead source code for OS X Mavericks and earlier


Modified: trunk/Source/WTF/wtf/glib/GUniquePtr.h (194322 => 194323)

--- trunk/Source/WTF/wtf/glib/GUniquePtr.h	2015-12-20 21:57:01 UTC (rev 194322)
+++ trunk/Source/WTF/wtf/glib/GUniquePtr.h	2015-12-21 01:19:41 UTC (rev 194323)
@@ -43,7 +43,8 @@
 macro(GPatternSpec, g_pattern_spec_free) \
 macro(GDir, g_dir_close) \
 macro(GTimer, g_timer_destroy) \
-macro(GKeyFile, g_key_file_free)
+macro(GKeyFile, g_key_file_free) \
+macro(char*, g_strfreev)
 
 #define WTF_DEFINE_GPTR_DELETER(typeName, deleterFunc) \
 template<> struct GPtrDeleter \


Modified: trunk/Source/WebCore/ChangeLog (194322 => 194323)

--- trunk/Source/WebCore/ChangeLog	2015-12-20 21:57:01 UTC (rev 194322)
+++ trunk/Source/WebCore/ChangeLog	2015-12-21 01:19:41 UTC (rev 194323)
@@ -1,3 +1,31 @@
+2015-12-20  Michael Catanzaro  
+
+[SOUP] Performs DNS prefetch when a proxy is configured (information leak)
+https://bugs.webkit.org/show_bug.cgi?id=145542
+
+Reviewed by Darin Adler.
+
+Perform DNS prefetch only when no proxy is configured.
+
+No new tests. Test this manually with Wireshark. Run the simple-proxy example program found
+in libsoup's examples directory, set that as your system HTTP proxy, and see if DNS queries
+show up in Wireshark when refreshing a page sent over HTTP. They should appear only when the
+proxy is not configured.
+
+* platform/network/DNSResolveQueue.cpp:
+(WebCore::DNSResolveQueue::DNSResolveQueue):
+(WebCore::DNSResolveQueue::isUsingProxy):
+* platform/network/DNSResolveQueue.h:
+* platform/network/cf/DNSCFNet.cpp:
+(WebCore::DNSResolveQueue::updateIsUsingProxy):
+(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences): Deleted.
+* platform/network/soup/DNSSoup.cpp:
+(WebCore::didResolveProxy):
+(WebCore::proxyResolvedForHttpUriCallback):
+(WebCore::proxyResolvedForHttpsUriCallback):
+(WebCore::DNSResolveQueue::updateIsUsingProxy):
+(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences): Deleted.
+
 2015-12-20  Dan Bernstein  
 
 Remove unused setToolbarHeight


Modified: trunk/Source/WebCore/platform/network/DNSResolveQueue.cpp (194322 => 194323)

--- trunk/Source/WebCore/platform/network/DNSResolveQueue.cpp	2015-12-20 21:57:01 UTC (rev 194322)
+++ trunk/Source/WebCore/platform/network/DNSResolveQueue.cpp	2015-12-21 01:19:41 UTC (rev 194323)
@@ -60,20 +60,27 @@
 DNSResolveQueue::DNSResolveQueue()
 : 

[webkit-changes] [194327] trunk/Tools

[mcatanzaro]

Title: [194327] trunk/Tools








Revision 194327
Author mcatanz...@igalia.com
Date 2015-12-21 01:04:40 -0800 (Mon, 21 Dec 2015)


Log Message
[GTK] jquery.min.js violates DFSG
https://bugs.webkit.org/show_bug.cgi?id=152428

Reviewed by Joseph Pecoraro.

Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.

* gtk/manifest.txt.in:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/manifest.txt.in




Diff

Modified: trunk/Tools/ChangeLog (194326 => 194327)

--- trunk/Tools/ChangeLog	2015-12-21 04:23:09 UTC (rev 194326)
+++ trunk/Tools/ChangeLog	2015-12-21 09:04:40 UTC (rev 194327)
@@ -1,3 +1,15 @@
+2015-12-21  Michael Catanzaro  
+
+[GTK] jquery.min.js violates DFSG
+https://bugs.webkit.org/show_bug.cgi?id=152428
+
+Reviewed by Joseph Pecoraro.
+
+Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
+into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
+
+* gtk/manifest.txt.in:
+
 2015-12-19  Dan Bernstein  
 
 [Mac] WebKit contains dead source code for OS X Mavericks and earlier


Modified: trunk/Tools/gtk/manifest.txt.in (194326 => 194327)

--- trunk/Tools/gtk/manifest.txt.in	2015-12-21 04:23:09 UTC (rev 194326)
+++ trunk/Tools/gtk/manifest.txt.in	2015-12-21 09:04:40 UTC (rev 194327)
@@ -55,6 +55,7 @@
 exclude Source/cmake/OptionsAppleWin.cmake$
 exclude Source/cmake/OptionsEfl.cmake$
 exclude Source/cmake/eflsymbols.filter$
+exclude Source/WebInspectorUI/Tools
 exclude Source/WebInspectorUI/UserInterface/Images
 
 directory Source/WebInspectorUI/UserInterface/Images/gtk






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194377] trunk/Source/WebCore

[mcatanzaro]

Title: [194377] trunk/Source/WebCore








Revision 194377
Author mcatanz...@igalia.com
Date 2015-12-22 15:15:25 -0800 (Tue, 22 Dec 2015)


Log Message
[GTK] Everything broken in GTK+ 3.19
https://bugs.webkit.org/show_bug.cgi?id=150550

Reviewed by Carlos Garcia Campos.

Port RenderThemeGtk and ScrollbarThemeGtk to use CSS nodes. This makes it possible to render
stuff with modern GTK+.

No new tests. We already have tons of tests for this functionality, but we're running them
with GTK+ 3.16, so they cannot have detected this breakage. These fixes require unreleased
GTK+, and GTK+ rendering is currently in a state of flux; once things settle down, we can
consider upgrading the GTK+ used for our layout tests.

* platform/gtk/GRefPtrGtk.cpp:
(WTF::refGPtr):
(WTF::derefGPtr):
* platform/gtk/GRefPtrGtk.h:
* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::themeChanged):
(WebCore::ScrollbarThemeGtk::updateThemeProperties):
(WebCore::orientationStyleClass):
(WebCore::applyScrollbarStyleContextClasses):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
* rendering/RenderThemeGtk.cpp:
(WebCore::createStyleContext):
(WebCore::setToggleSize):
(WebCore::paintToggle):
(WebCore::RenderThemeGtk::paintButton):
(WebCore::getComboBoxMetrics):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::applySliderStyleContextClasses):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::paintSpinArrowButton):
(WebCore::styleColor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp
trunk/Source/WebCore/platform/gtk/GRefPtrGtk.h
trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (194376 => 194377)

--- trunk/Source/WebCore/ChangeLog	2015-12-22 23:12:43 UTC (rev 194376)
+++ trunk/Source/WebCore/ChangeLog	2015-12-22 23:15:25 UTC (rev 194377)
@@ -1,3 +1,46 @@
+2015-12-22  Michael Catanzaro  
+
+[GTK] Everything broken in GTK+ 3.19
+https://bugs.webkit.org/show_bug.cgi?id=150550
+
+Reviewed by Carlos Garcia Campos.
+
+Port RenderThemeGtk and ScrollbarThemeGtk to use CSS nodes. This makes it possible to render
+stuff with modern GTK+.
+
+No new tests. We already have tons of tests for this functionality, but we're running them
+with GTK+ 3.16, so they cannot have detected this breakage. These fixes require unreleased
+GTK+, and GTK+ rendering is currently in a state of flux; once things settle down, we can
+consider upgrading the GTK+ used for our layout tests.
+
+* platform/gtk/GRefPtrGtk.cpp:
+(WTF::refGPtr):
+(WTF::derefGPtr):
+* platform/gtk/GRefPtrGtk.h:
+* platform/gtk/ScrollbarThemeGtk.cpp:
+(WebCore::ScrollbarThemeGtk::themeChanged):
+(WebCore::ScrollbarThemeGtk::updateThemeProperties):
+(WebCore::orientationStyleClass):
+(WebCore::applyScrollbarStyleContextClasses):
+(WebCore::ScrollbarThemeGtk::paintTrackBackground):
+(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
+(WebCore::ScrollbarThemeGtk::paintThumb):
+(WebCore::ScrollbarThemeGtk::paintButton):
+* rendering/RenderThemeGtk.cpp:
+(WebCore::createStyleContext):
+(WebCore::setToggleSize):
+(WebCore::paintToggle):
+(WebCore::RenderThemeGtk::paintButton):
+(WebCore::getComboBoxMetrics):
+(WebCore::RenderThemeGtk::paintMenuList):
+(WebCore::RenderThemeGtk::paintTextField):
+(WebCore::applySliderStyleContextClasses):
+(WebCore::RenderThemeGtk::paintSliderTrack):
+(WebCore::RenderThemeGtk::paintSliderThumb):
+(WebCore::RenderThemeGtk::paintProgressBar):
+(WebCore::paintSpinArrowButton):
+(WebCore::styleColor):
+
 2015-12-22  Eric Carlson  
 
 [MediaStream] MediaStreamTrackPrivate.source should be a reference


Modified: trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp (194376 => 194377)

--- trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp	2015-12-22 23:12:43 UTC (rev 194376)
+++ trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp	2015-12-22 23:15:25 UTC (rev 194377)
@@ -72,6 +72,22 @@
 if (ptr)
 gdk_cursor_unref(ptr);
 }
+
+#else
+
+template <> GtkWidgetPath* refGPtr(GtkWidgetPath* ptr)
+{
+if (ptr)
+gtk_widget_path_ref(ptr);
+return ptr;
+}
+
+template <> void derefGPtr(GtkWidgetPath* ptr)
+{
+if (ptr)
+gtk_widget_path_unref(ptr);
+}
+
 #endif
 
 }


Modified: trunk/Source/WebCore/platform/gtk/GRefPtrGtk.h (194376 => 194377)

--- 

[webkit-changes] [194268] trunk/Source/WebKit2

[mcatanzaro]

Title: [194268] trunk/Source/WebKit2








Revision 194268
Author mcatanz...@igalia.com
Date 2015-12-18 07:57:49 -0800 (Fri, 18 Dec 2015)


Log Message
LayerTreeHostGtk triggers -Wunused-private-field
https://bugs.webkit.org/show_bug.cgi?id=152410

Reviewed by Carlos Garcia Campos.

Remove the unused member variable.

* WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (194267 => 194268)

--- trunk/Source/WebKit2/ChangeLog	2015-12-18 11:10:44 UTC (rev 194267)
+++ trunk/Source/WebKit2/ChangeLog	2015-12-18 15:57:49 UTC (rev 194268)
@@ -1,3 +1,14 @@
+2015-12-18  Michael Catanzaro  
+
+LayerTreeHostGtk triggers -Wunused-private-field
+https://bugs.webkit.org/show_bug.cgi?id=152410
+
+Reviewed by Carlos Garcia Campos.
+
+Remove the unused member variable.
+
+* WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
+
 2015-12-18  Alex Christensen  
 
 Add types for DownloadID and TaskIdentifier


Modified: trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.h (194267 => 194268)

--- trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.h	2015-12-18 11:10:44 UTC (rev 194267)
+++ trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.h	2015-12-18 15:57:49 UTC (rev 194268)
@@ -117,7 +117,6 @@
 std::unique_ptr m_nonCompositedContentLayer;
 std::unique_ptr m_textureMapper;
 std::unique_ptr m_context;
-double m_lastImmediateFlushTime;
 bool m_layerFlushSchedulingEnabled;
 WebCore::GraphicsLayer* m_viewOverlayRootLayer;
 WebCore::TransformationMatrix m_scaleMatrix;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194271] trunk/LayoutTests

[mcatanzaro]

Title: [194271] trunk/LayoutTests








Revision 194271
Author mcatanz...@igalia.com
Date 2015-12-18 08:34:03 -0800 (Fri, 18 Dec 2015)


Log Message
[GTK] Unreviewed gardening

css3/flexbox/multiline-reverse-wrap-baseline.html consistently passes for GTK since
r191623, but fails on Apple ports, so add a GTK-specific Pass expectation.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (194270 => 194271)

--- trunk/LayoutTests/ChangeLog	2015-12-18 16:25:34 UTC (rev 194270)
+++ trunk/LayoutTests/ChangeLog	2015-12-18 16:34:03 UTC (rev 194271)
@@ -1,6 +1,15 @@
 2015-12-18  Michael Catanzaro  
 
 [GTK] Unreviewed gardening
+
+css3/flexbox/multiline-reverse-wrap-baseline.html consistently passes for GTK since
+r191623, but fails on Apple ports, so add a GTK-specific Pass expectation.
+
+* platform/gtk/TestExpectations:
+
+2015-12-18  Michael Catanzaro  
+
+[GTK] Unreviewed gardening
 https://bugs.webkit.org/show_bug.cgi?id=142292
 
 fast/images/animated-gif-body-outside-viewport.html and


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (194270 => 194271)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-12-18 16:25:34 UTC (rev 194270)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-12-18 16:34:03 UTC (rev 194271)
@@ -2577,6 +2577,7 @@
 #
 
 # This tests are passing on GTK+ but they do not in the Apple ports
+css3/flexbox/multiline-reverse-wrap-baseline.html [ Pass ]
 imported/mozilla/svg/image/image-filter-01.svg [ Pass ]
 imported/w3c/canvas/2d.line.cap.round.html [ Pass ]
 mathml/presentation/style-changed.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194269] trunk/LayoutTests

[mcatanzaro]

Title: [194269] trunk/LayoutTests








Revision 194269
Author mcatanz...@igalia.com
Date 2015-12-18 08:20:57 -0800 (Fri, 18 Dec 2015)


Log Message
[GTK] Unreviewed gardening

Remove failure expectation for fast/events/drag-and-drop-autoscroll-inner-frame.html which
has been consistently passing since r192511.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (194268 => 194269)

--- trunk/LayoutTests/ChangeLog	2015-12-18 15:57:49 UTC (rev 194268)
+++ trunk/LayoutTests/ChangeLog	2015-12-18 16:20:57 UTC (rev 194269)
@@ -1,3 +1,12 @@
+2015-12-18  Michael Catanzaro  
+
+[GTK] Unreviewed gardening
+
+Remove failure expectation for fast/events/drag-and-drop-autoscroll-inner-frame.html which
+has been consistently passing since r192511.
+
+* platform/gtk/TestExpectations:
+
 2015-12-17  Commit Queue  
 
 Unreviewed, rolling out r194241 and r194252.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (194268 => 194269)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-12-18 15:57:49 UTC (rev 194268)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-12-18 16:20:57 UTC (rev 194269)
@@ -1492,7 +1492,6 @@
 webkit.org/b/63706 editing/pasteboard/cleanup-on-move.html [ Failure ]
 webkit.org/b/63706 editing/pasteboard/drag-list-item.html [ Failure ]
 webkit.org/b/63706 fast/events/ondragenter.html [ Failure ]
-webkit.org/b/63706 fast/events/drag-and-drop-autoscroll-inner-frame.html [ Timeout ]
 webkit.org/b/63706 fast/events/drag-customData.html  [ Timeout ]
 
 # Need support for internals.settings.setDeviceSupportsMouse






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194270] trunk/LayoutTests

[mcatanzaro]

Title: [194270] trunk/LayoutTests








Revision 194270
Author mcatanz...@igalia.com
Date 2015-12-18 08:25:34 -0800 (Fri, 18 Dec 2015)


Log Message
[GTK] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=142292

fast/images/animated-gif-body-outside-viewport.html and
fast/images/animated-gif-window-resizing.html are flaky; mark them
accordingly.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (194269 => 194270)

--- trunk/LayoutTests/ChangeLog	2015-12-18 16:20:57 UTC (rev 194269)
+++ trunk/LayoutTests/ChangeLog	2015-12-18 16:25:34 UTC (rev 194270)
@@ -1,7 +1,18 @@
 2015-12-18  Michael Catanzaro  
 
 [GTK] Unreviewed gardening
+https://bugs.webkit.org/show_bug.cgi?id=142292
 
+fast/images/animated-gif-body-outside-viewport.html and
+fast/images/animated-gif-window-resizing.html are flaky; mark them
+accordingly.
+
+* platform/gtk/TestExpectations:
+
+2015-12-18  Michael Catanzaro  
+
+[GTK] Unreviewed gardening
+
 Remove failure expectation for fast/events/drag-and-drop-autoscroll-inner-frame.html which
 has been consistently passing since r192511.
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (194269 => 194270)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-12-18 16:20:57 UTC (rev 194269)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-12-18 16:25:34 UTC (rev 194270)
@@ -1336,8 +1336,8 @@
 webkit.org/b/139362 inspector/css/selector-specificity.html [ Timeout Pass ]
 webkit.org/b/147229 inspector/css/modify-rule-selector.html [ Skip ] # Timeout
 
-webkit.org/b/142292 fast/images/animated-gif-window-resizing.html [ Timeout ]
-webkit.org/b/142292 fast/images/animated-gif-zooming.html [ Timeout ]
+webkit.org/b/142292 fast/images/animated-gif-window-resizing.html [ Timeout Pass ]
+webkit.org/b/142292 fast/images/animated-gif-zooming.html [ Timeout Pass ]
 
 webkit.org/b/142488 http/tests/appcache/404-resource-with-slow-main-resource.php [ Timeout ]
 webkit.org/b/141959 [ Release ] http/tests/media/clearkey/clear-key-hls-aes128.html [ Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194280] trunk/Source/WebKit2

[mcatanzaro]

Title: [194280] trunk/Source/WebKit2








Revision 194280
Author mcatanz...@igalia.com
Date 2015-12-18 11:46:21 -0800 (Fri, 18 Dec 2015)


Log Message
[GTK] Unreviewed, fix GtkDoc after r193620

* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml




Diff

Modified: trunk/Source/WebKit2/ChangeLog (194279 => 194280)

--- trunk/Source/WebKit2/ChangeLog	2015-12-18 19:42:30 UTC (rev 194279)
+++ trunk/Source/WebKit2/ChangeLog	2015-12-18 19:46:21 UTC (rev 194280)
@@ -1,3 +1,9 @@
+2015-12-18  Michael Catanzaro  
+
+[GTK] Unreviewed, fix GtkDoc after r193620
+
+* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
+
 2015-12-18  Dan Bernstein  
 
 WebPage::didCompleteUserMediaPermissionCheck and WebPage::didReceiveUserMediaPermissionDecision are exported


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml (194279 => 194280)

--- trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml	2015-12-18 19:42:30 UTC (rev 194279)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml	2015-12-18 19:46:21 UTC (rev 194280)
@@ -62,7 +62,7 @@
   -+   
 
   






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194276] trunk/Tools

[mcatanzaro]

Title: [194276] trunk/Tools








Revision 194276
Author mcatanz...@igalia.com
Date 2015-12-18 10:41:04 -0800 (Fri, 18 Dec 2015)


Log Message
Unreviewed, add WebKitGTK+ Bugzilla email to committers list

This is to make it easy to CC it on Bugzilla.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (194275 => 194276)

--- trunk/Tools/ChangeLog	2015-12-18 18:31:34 UTC (rev 194275)
+++ trunk/Tools/ChangeLog	2015-12-18 18:41:04 UTC (rev 194276)
@@ -1,3 +1,11 @@
+2015-12-18  Michael Catanzaro  
+
+Unreviewed, add WebKitGTK+ Bugzilla email to committers list
+
+This is to make it easy to CC it on Bugzilla.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2015-12-18  Aakash Jain  
 
 Pasteboard get messed up after running kill-old-processes


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (194275 => 194276)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-12-18 18:31:34 UTC (rev 194275)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-12-18 18:41:04 UTC (rev 194276)
@@ -3595,6 +3595,11 @@
 "webcomponents-bugzi...@chromium.org"
  ]
   },
+  "WebKitGTK+ Bugs" : {
+ "emails" : [
+"bugs-nore...@webkitgtk.org"
+ ]
+  },
   "WebKit Review Bot" : {
  "emails" : [
 "webkit.review@gmail.com"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194284] trunk/Source/WebCore/platform/gtk/po

[mcatanzaro]

Title: [194284] trunk/Source/WebCore/platform/gtk/po








Revision 194284
Author mcatanz...@igalia.com
Date 2015-12-18 11:56:35 -0800 (Fri, 18 Dec 2015)


Log Message
[GTK] Unreviewed, update POTFILES.in after r194272

* POTFILES.in:

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog
trunk/Source/WebCore/platform/gtk/po/POTFILES.in




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (194283 => 194284)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-12-18 19:49:58 UTC (rev 194283)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-12-18 19:56:35 UTC (rev 194284)
@@ -1,3 +1,9 @@
+2015-12-18  Michael Catanzaro  
+
+[GTK] Unreviewed, update POTFILES.in after r194272
+
+* POTFILES.in:
+
 2015-11-22  Milo Casagrande  
 
 [GTK] [l10n] Updated Italian translation of WebKitGTK+


Modified: trunk/Source/WebCore/platform/gtk/po/POTFILES.in (194283 => 194284)

--- trunk/Source/WebCore/platform/gtk/po/POTFILES.in	2015-12-18 19:49:58 UTC (rev 194283)
+++ trunk/Source/WebCore/platform/gtk/po/POTFILES.in	2015-12-18 19:56:35 UTC (rev 194284)
@@ -1,7 +1,7 @@
 # List of source files which contain translatable strings.
 ErrorsGtk.cpp
 LocalizedStringsGtk.cpp
-../../../WebKit2/Shared/Downloads/soup/DownloadSoup.cpp
+../../../WebKit2/NetworkProcess/Downloads/soup/DownloadSoup.cpp
 ../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp
 ../../../WebKit2/UIProcess/API/gtk/WebKitDownload.cpp
 ../../../WebKit2/UIProcess/API/gtk/WebKitFaviconDatabase.cpp






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes