Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Darin Fisher
On Wed, Sep 16, 2009 at 10:57 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 10:33 PM, Darin Fisher wrote: On Wed, Sep 16, 2009 at 9:59 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 4:49 PM, Darin Fisher wrote: Counting work instead of time is much

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 16, 2009, at 10:57 PM, Maciej Stachowiak wrote: On Sep 16, 2009, at 10:33 PM, Darin Fisher wrote: You can find links to example sites in the Chromium bug report: http://code.google.com/p/chromium/issues/detail?id=7823 The bug contains some distilled data. I found a couple of URLs

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 16, 2009, at 10:47 PM, Darin Fisher wrote: By the way, to be clear these ads aren't on the critical path for link clicks. A navigation occurs, and the ad just observes unload. During unload it presumably tries to send home some data (ad impression time, perhaps?). I'm not

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Darin Fisher
On Wed, Sep 16, 2009 at 11:46 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 10:47 PM, Darin Fisher wrote: By the way, to be clear these ads aren't on the critical path for link clicks. A navigation occurs, and the ad just observes unload. During unload it presumably

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 12:35 AM, Darin Fisher wrote: For a ping to be used as I suggested, you would need to set the href to a javascript URL such as javascript:void(), so that it would not interfere with an existing navigation. Navigating to a javascript: URL will still cancel with an

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Adam Barth
On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: A third possibility: limit unload persistence to Image and XMLHttpRequest, to limit the complexity. That's assuming sites are not using scripts, stylesheets or frames to do the exit ping - I don't know if that's a good

Re: [webkit-dev] [webkit-changes] [48407] trunk/LayoutTests

2009-09-17 Thread Tor Arne Vestbø
Chris Fleizach wrote: It's possible that Windows, for example, supports an accessibility value attribute for sliders, but it's also possible that it does not. Likewise, it's possible Linux could support that attribute, or not. All I am sure of right now is that it's not implemented now. So

[webkit-dev] Commissioning an enhancement to QtWebkit

2009-09-17 Thread Garth Dahlstrom
Hi Everyone, I'm interested in commissioning an enhancement to QtWebkit port, the work would be donated to the webkit project under the LGPL in the hopes it would make it into the main git tree. The enhancement would be to implement support for the Java Applet tag. I won't bore the list

Re: [webkit-dev] Commissioning an enhancement to QtWebkit

2009-09-17 Thread Maciej Stachowiak
The proper place for work proposals like this would be the webkit-j...@lists.webkit.org list. - Maciej On Sep 17, 2009, at 9:24 AM, Garth Dahlstrom wrote: Hi Everyone, I'm interested in commissioning an enhancement to QtWebkit port, the work would be donated to the webkit project

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Darin Fisher
On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:35 AM, Darin Fisher wrote: For a ping to be used as I suggested, you would need to set the href to a javascript URL such as javascript:void(), so that it would not interfere with an existing

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Brady Eidson
On Sep 17, 2009, at 2:28 AM, Maciej Stachowiak wrote: Here's what would need to happen to let loads from unload run to completion: 1) Implement a way to track all entities that start loads during unload (all owners of ResourceHandles, say). 2) Add a way (perhaps via an abstract base

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Peter Kasting
On Thu, Sep 17, 2009 at 12:14 PM, Darin Fisher da...@chromium.org wrote: At any rate, I think I'm persuaded by your arguments. Adam made a similar argument the other day too. It seems reasonable to make Image behave this way when created in certain contexts. We should probably include

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 12:14 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:35 AM, Darin Fisher wrote: For a ping to be used as I suggested, you would need to set the href to a javascript URL such as

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 12:23 PM, Brady Eidson wrote: On Sep 17, 2009, at 2:28 AM, Maciej Stachowiak wrote: Here's what would need to happen to let loads from unload run to completion: 1) Implement a way to track all entities that start loads during unload (all owners of ResourceHandles,

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Brady Eidson
On Sep 17, 2009, at 12:54 PM, Maciej Stachowiak wrote: On Sep 17, 2009, at 12:23 PM, Brady Eidson wrote: On Sep 17, 2009, at 2:28 AM, Maciej Stachowiak wrote: Here's what would need to happen to let loads from unload run to completion: 1) Implement a way to track all entities that

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 1:14 PM, Brady Eidson wrote: On Sep 17, 2009, at 12:54 PM, Maciej Stachowiak wrote: On Sep 17, 2009, at 12:23 PM, Brady Eidson wrote: On Sep 17, 2009, at 2:28 AM, Maciej Stachowiak wrote: Here's what would need to happen to let loads from unload run to completion:

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread John Abd-El-Malek
On Wed, Sep 16, 2009 at 11:03 PM, Darin Fisher da...@chromium.org wrote: On Wed, Sep 16, 2009 at 10:57 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009, at 10:33 PM, Darin Fisher wrote: On Wed, Sep 16, 2009 at 9:59 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 16, 2009,

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Darin Fisher
On Thu, Sep 17, 2009 at 12:52 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:14 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:35 AM, Darin Fisher wrote: For a ping to be used as I suggested,

Re: [webkit-dev] js-only-tests migration from resources to script-tests

2009-09-17 Thread Eric Seidel
Looks fine. Thank you for giving warning so that people are aware of this large change. -eric On Wed, Sep 16, 2009 at 6:17 PM, Shinichiro Hamaji ham...@chromium.org wrote: Hi WebKit folks, With great helps from Eric and Darin, I'm working on moving js only layout tests from resources to

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread John Abd-El-Malek
On Thu, Sep 17, 2009 at 2:09 PM, Darin Fisher da...@chromium.org wrote: On Thu, Sep 17, 2009 at 12:52 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:14 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 17,

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread John Abd-El-Malek
On Thu, Sep 17, 2009 at 12:14 PM, Darin Fisher da...@chromium.org wrote: On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:35 AM, Darin Fisher wrote: For a ping to be used as I suggested, you would need to set the href to a javascript URL

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Ojan Vafai
On Thu, Sep 17, 2009 at 2:11 PM, John Abd-El-Malek j...@google.com wrote: On Thu, Sep 17, 2009 at 2:09 PM, Darin Fisher da...@chromium.org wrote: On Thu, Sep 17, 2009 at 12:52 PM, Maciej Stachowiak m...@apple.comwrote: Based on your comments below, I think the expedient thing to do is to let

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Brady Eidson
On Sep 17, 2009, at 2:17 PM, Ojan Vafai wrote: On Thu, Sep 17, 2009 at 2:11 PM, John Abd-El-Malek j...@google.com wrote: On Thu, Sep 17, 2009 at 2:09 PM, Darin Fisher da...@chromium.org wrote: On Thu, Sep 17, 2009 at 12:52 PM, Maciej Stachowiak m...@apple.com wrote: Based on your comments

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 2:09 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 12:52 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:14 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:35 AM,

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 2:16 PM, John Abd-El-Malek wrote: I think the image trick is more attractive than a ping because it's easier for web developers to use. But I'm not convinced it's the cleanest method we can come up with. If we are expecting web developers to change, then I'd

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Ojan Vafai
On Thu, Sep 17, 2009 at 3:35 PM, Brady Eidson beid...@apple.com wrote: On Sep 17, 2009, at 2:17 PM, Ojan Vafai wrote: There a plenty of sites that only have a beforeunload handler and have no reason to register an unload handler. If you're not prompting the user to stay on the page, the two

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 3:35 PM, Brady Eidson wrote: On Sep 17, 2009, at 2:17 PM, Ojan Vafai wrote: On Thu, Sep 17, 2009 at 2:11 PM, John Abd-El-Malek j...@google.com wrote: On Thu, Sep 17, 2009 at 2:09 PM, Darin Fisher da...@chromium.org wrote: On Thu, Sep 17, 2009 at 12:52 PM, Maciej

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread John Abd-El-Malek
On Thu, Sep 17, 2009 at 4:08 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 2:16 PM, John Abd-El-Malek wrote: I think the image trick is more attractive than a ping because it's easier for web developers to use. But I'm not convinced it's the cleanest method we can come

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Darin Fisher
On Thu, Sep 17, 2009 at 4:05 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 2:09 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 12:52 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:14 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 2:28 AM,