If you're tired of my complaining about the tree being red, you can
skip this message.
Today Alexey checked in http://trac.webkit.org/changeset/62576,
which broke two tests on every port. 12 hours later, these failures
remained in the tree until I cleaned them up. This mess could have
been
Thank you for fixing the problem.
Did you try talking to Alexey directly about this? Or to someone else who may
be familiar with the situation? It's usually better to try steps like that
before calling someone out on the mailing list. And if you do need to bring
something to wider attention,
Sausset François has been looking at using the newly released STIX
fonts [1] for the MathML implementation. If we start requiring STIX
font support for MathML, how do we guarantee:
* these fonts exist in the build process so the tests will succeed,
* these fonts exist on the target
Hi,
I'm planning to add support for 'Reftest' to WebKit.
Reftest is currently used in Mozilla and makes it possible to write HTML
tests where the reference rendering is also in HTML.
You can easily write tests that work no matter what fonts are present, or
what the platform the form controls
Hi,
The latest WebKit2 Windows port creates a single process for any
number of tabs that are opened.
Will this be changed to something like a one-process-per-tab mode?
Regards,
ARaj.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
In the later sample output, note that it did not reach body , whose
boundary obvious intersects any possible given Z rect. That would
happen if the div in case encloses the rect Z completely, and it
would be the stop point for the hit test.
In Mozilla's implementation, nodesFromRect does not
Hi folks!
While I worked on the Qt port of WebKit2, I faced with some build
issues. To solve these problems it seems like common parts of WebKit2
should change, that is why I thought that discussing them in the list
would be useful.
There are two main problem I see:
* Usage of precompiled
I know this sounds a bit silly, but it's a simplified version of what i'm doing.
Let's say I decided to replace every webpage with hello world. I
decided to do this from finishedParsing() within dom/Document.cpp:
void Document::finishedParsing()
{
ExceptionCode ec = 0;
HTMLBodyElement*
Hi Alex.
On QtWebKit, it is requered a set of fonts to be available on the
local system, and WEBKIT_TESTFONT environment variable to be exported
pointing to the font location path. See [1].
[1]
http://trac.webkit.org/wiki/QtWebKitContrib#InstallingthelayouttestfontsUsingrun-webkit-tests
In
07.07.2010, в 00:47, Adam Barth написал(а):
If you're tired of my complaining about the tree being red, you can
skip this message.
I understand that you're frustrated, but I think that you're misinterpreting
what happened.
1) He could have run-webkit-tests before committing his change.
I
Sorry for singling you out Alexey. I was just frustrated last night.
On Wed, Jul 7, 2010 at 8:58 AM, Alexey Proskuryakov a...@webkit.org wrote:
07.07.2010, в 00:47, Adam Barth написал(а):
If you're tired of my complaining about the tree being red, you can
skip this message.
I understand
On Jul 7, 2010, at 3:48 AM, Alex Milowski wrote:
Is there any precedence for this or default policy for tests requiring
fonts?
Yes. Some tests require the Ahem font, so the font is checked into the
repository and—at least on Mac OS X and Windows—DumpRenderTree activates the
font while
07.07.2010, в 9:18, Adam Barth написал(а):
This problem is now fixed thanks to William Siegrist. Patches written
by committers show up correctly in SVN blame and trac even if they're
landed by the commit-queue.
That's good to know, I'll try that next time.
I think we can improve this by
I agree with Maciej's response, but at the same time I can understand why
Adam was so frustrated. He (and others) have pointed out stuff like this on
and off list over and over again with little apparent change...
But that's not what I'm most worried about; why this was broken in the tree
for 12
On Wed, Jul 7, 2010 at 5:31 PM, Dan Bernstein m...@apple.com wrote:
On Jul 7, 2010, at 3:48 AM, Alex Milowski wrote:
Is there any precedence for this or default policy for tests requiring
fonts?
Yes. Some tests require the Ahem font, so the font is checked into the
repository and—at least
Hi.
On Wed, Jul 7, 2010 at 7:02 AM, Balazs Kelemen k...@inf.u-szeged.hu wrote:
Hi folks!
While I worked on the Qt port of WebKit2, I faced with some build
issues. To solve these problems it seems like common parts of WebKit2
should change, that is why I thought that discussing them in the
On Wed, Jul 7, 2010 at 8:30 AM, Matt 'Murph' Finnicum mattf...@gmail.comwrote:
I know this sounds a bit silly, but it's a simplified version of what i'm
doing.
Let's say I decided to replace every webpage with hello world. I
decided to do this from finishedParsing() within dom/Document.cpp:
On Jul 7, 2010, at 9:57 AM, Alex Milowski wrote:
The STIX fonts are relatively small (2.6MB for the full download) and
we probably don't need all of them. Would it be acceptable to check these in
like the Ahem font?
Subject to WebKit’s licensing requirements, yes.
07.07.2010, в 9:49, Jeremy Orlow написал(а):
Why did not one of those people roll the patch out when it was clear
that there were failures and Alexey wasn't in the process of fixing
them?
Just to avoid any misunderstanding, the best thing to do would have
been to tell me about the
If we want to return all the nodes, it is actually a simple change as
we just remove the code to check the enclosure. But this may affect
the hit test performance.
thanks,
Grace
On Wed, Jul 7, 2010 at 5:59 AM, Antonio Gomes (:tonikitoo)
toniki...@gmail.com wrote:
In the later sample output,
If every is OK with licenses, how DumpRenderTree needs to be modified to use
custom fonts?
And where the fonts have to be stored?
François Sausset
Le 7 juil. 2010 à 20:51, Dan Bernstein a écrit :
On Jul 7, 2010, at 9:57 AM, Alex Milowski wrote:
The STIX fonts are relatively small (2.6MB
On Jul 7, 2010, at 11:17 AM, Sausset François wrote:
If every is OK with licenses, how DumpRenderTree needs to be modified to use
custom fonts?
This is where the Mac version activates test fonts:
http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm#L218
and
Currently it seems that at least icecc does not. Also, qmake which is
the build system for the Qt port does not support prefix headers
directly and we thus have to emulate it using the precompiled header
support.
Kenneth
On Wed, Jul 7, 2010 at 2:27 PM, Sam Weinig sam.wei...@gmail.com wrote:
It
On Jul 7, 2010, at 9:45 AM, Alexey Proskuryakov wrote:
I think we can improve this by having sheriff-bot say which tests
broke. I bet if you saw these tests listed, you'd have realized what
was going one.
That would be very useful indeed! It currently takes some effort to find out
That was it.
Thanks a million!
On Wed, Jul 7, 2010 at 12:34 PM, Sam Weinig sam.wei...@gmail.com wrote:
On Wed, Jul 7, 2010 at 8:30 AM, Matt 'Murph' Finnicum mattf...@gmail.com
wrote:
I know this sounds a bit silly, but it's a simplified version of what i'm
doing.
Let's say I decided to
On Jul 7, 2010, at 4:41 AM, ARaj wrote:
Hi,
The latest WebKit2 Windows port creates a single process for any
number of tabs that are opened.
Will this be changed to something like a one-process-per-tab mode?
Our short-term plans are to make the threaded and single-web-process modes of
Who has the knowledge and access needed to fix problems like this?
svn: Working copy
'/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebKit/chromium/sdch/open-vcdiff'
locked
svn: run 'svn cleanup' to remove locks (type 'svn help cleanup' for details)
svn:
I think Yaar might be a good contact person.
Adam
On Wed, Jul 7, 2010 at 12:40 PM, Darin Adler da...@apple.com wrote:
Who has the knowledge and access needed to fix problems like this?
svn: Working copy
Hi Sam,
Can you please look at https://bugs.webkit.org/show_bug.cgi?id=41617
where I'm making memory stats reporting controlled by a preference,
and turning it off by default. You are in the CC list but for some
reason Bugzilla excluded you from the notification list when I
uploaded updated
I'll fix. Sorry about that.
:DG
On Wed, Jul 7, 2010 at 12:40 PM, Darin Adler da...@apple.com wrote:
Who has the knowledge and access needed to fix problems like this?
svn: Working copy
Mr. Glazkov is on it.
On Wed, Jul 7, 2010 at 12:41 PM, Adam Barth aba...@webkit.org wrote:
I think Yaar might be a good contact person.
Adam
On Wed, Jul 7, 2010 at 12:40 PM, Darin Adler da...@apple.com wrote:
Who has the knowledge and access needed to fix problems like this?
svn:
On Wed, Jun 16, 2010 at 3:27 PM, Maciej Stachowiak m...@apple.com wrote:
On Jun 16, 2010, at 2:04 PM, Eric Seidel wrote:
We could add a separate option to DumpRenderTree to disable
ReportCrash (sign up for all the crashing signals and simply exit(2)
or similar). That would be useful in
On Wed, Jul 7, 2010 at 5:00 PM, Dmitry Titov dim...@chromium.org wrote:
I'd lean to the removal, unless there is a port that has work ongoing or
planned soon for those implementations.
Does anybody vote for #ifdefs?
I vote against removal if only because Chromium has really wanted these
On Thu, Jul 8, 2010 at 2:03 AM, Alexey Proskuryakov a...@webkit.org wrote:
07.07.2010, в 9:49, Jeremy Orlow написал(а):
Why did not one of those people roll the patch out when it was clear that
there were failures and Alexey wasn't in the process of fixing them?
Just to avoid any
Maybe I should complain this in a different threads, but recently the commit
bot waiting time is way too long. Several times a patch of mine got the r+
and cq+ and it landed two days later. This is really frustrating.
I am very tempted to use svn directly to commit patches, but that means the
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a different threads, but recently the
commit bot waiting time is way too long. Several times a patch of mine got
the r+ and cq+ and it landed two days later. This is really frustrating.
I
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a different threads, but recently the commit
bot waiting time is way too long. Several times a patch of mine got the r+
and cq+ and
On Wed, Jul 7, 2010 at 7:19 PM, Oliver Hunt oli...@apple.com wrote:
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a different threads, but recently the
commit bot waiting time is way
On Wed, Jul 7, 2010 at 7:22 PM, James Robinson jam...@google.com wrote:
On Wed, Jul 7, 2010 at 7:19 PM, Oliver Hunt oli...@apple.com wrote:
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain
On Thu, Jul 8, 2010 at 10:19 AM, Oliver Hunt oli...@apple.com wrote:
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a different threads, but recently the
commit bot waiting time is
On Jul 7, 2010, at 7:22 PM, James Robinson wrote:
On Wed, Jul 7, 2010 at 7:19 PM, Oliver Hunt oli...@apple.com wrote:
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a
On Jul 7, 2010, at 7:26 PM, Jeremy Orlow wrote:
On Thu, Jul 8, 2010 at 10:19 AM, Oliver Hunt oli...@apple.com wrote:
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a different
On Jul 7, 2010, at 7:32 PM, Oliver Hunt wrote:
webkit-patch land-safely does the job of running the tests automatically,
that said if you have commit privileges you should be running the tests
yourself otherwise you're wasting the reviewers time.
Pushing a patch through the normal
On Wed, Jul 7, 2010 at 5:24 PM, Peter Kasting pkast...@google.com wrote:
On Wed, Jul 7, 2010 at 5:00 PM, Dmitry Titov dim...@chromium.org wrote:
I'd lean to the removal, unless there is a port that has work ongoing or
planned soon for those implementations.
Does anybody vote for #ifdefs?
That would be the standard thing to do.
The sooner someone gets started on the feature, the easier it'll be to
revert the patch that removes the code. :-)
J
On Thu, Jul 8, 2010 at 10:55 AM, David Levin le...@chromium.org wrote:
On Wed, Jul 7, 2010 at 5:24 PM, Peter Kasting
On Jul 7, 2010, at 7:42 PM, Maciej Stachowiak wrote:
On Jul 7, 2010, at 7:32 PM, Oliver Hunt wrote:
My opinion is that if people want to use the commit-queue to land patches
they should be happy to drop their commit privileges thus mooting this
entire issue.
That would probably make
On Wed, Jul 7, 2010 at 9:46 PM, William Siegrist wsiegr...@apple.comwrote:
On Jul 7, 2010, at 7:42 PM, Maciej Stachowiak wrote:
On Jul 7, 2010, at 7:32 PM, Oliver Hunt wrote:
My opinion is that if people want to use the commit-queue to land
patches they should be happy to drop their
47 matches
Mail list logo
