Re: [webkit-dev] Why is ResourceHandle.cpp in WebKit/chromium/src

2010-09-11 Thread Maciej Stachowiak
On Sep 11, 2010, at 9:42 PM, Darin Fisher wrote: > On Sat, Sep 11, 2010 at 2:49 AM, Adam Barth wrote: > > If we like pattern (3), maybe we should replace > PlatformBridge with (3)? > > Yes, perhaps we should do that. In concert with that, it would be good to > create a subdirectory in WebKi

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Maciej Stachowiak
I like Adam's thinking on this. ResourceHandle depending on Frame, even indirectly, is something of a layering violation. It makes more sense to factor out the bits that it does need, a la NetworkContext. Using client methods to make an association externally seems ok too, but poses more risk t

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Darin Fisher
On Sat, Sep 11, 2010 at 11:07 PM, Adam Barth wrote: > On Sat, Sep 11, 2010 at 10:52 PM, Darin Fisher wrote: > > On Sat, Sep 11, 2010 at 10:42 PM, Adam Barth wrote: > >> On Sat, Sep 11, 2010 at 10:02 PM, Darin Fisher > wrote: > >> > I don't understand. WebWorkers use ThreadableLoader, which ro

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Adam Barth
On Sat, Sep 11, 2010 at 10:52 PM, Darin Fisher wrote: > On Sat, Sep 11, 2010 at 10:42 PM, Adam Barth wrote: >> On Sat, Sep 11, 2010 at 10:02 PM, Darin Fisher wrote: >> > I don't understand.  WebWorkers use ThreadableLoader, which routes the >> > network request back to the main thread where ther

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Darin Fisher
On Sat, Sep 11, 2010 at 10:42 PM, Adam Barth wrote: > On Sat, Sep 11, 2010 at 10:02 PM, Darin Fisher wrote: > > On Sat, Sep 11, 2010 at 9:17 AM, Adam Barth wrote: > >> On Sat, Sep 11, 2010 at 8:15 AM, Holger Freyther > >> wrote: > >> > On 09/11/2010 05:57 PM, Adam Barth wrote: > >> >> Do we st

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Adam Barth
On Sat, Sep 11, 2010 at 10:02 PM, Darin Fisher wrote: > On Sat, Sep 11, 2010 at 9:17 AM, Adam Barth wrote: >> On Sat, Sep 11, 2010 at 8:15 AM, Holger Freyther >> wrote: >> > On 09/11/2010 05:57 PM, Adam Barth wrote: >> >> Do we still believe this FIXME is accurate?  If so, I have some time >> >>

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Darin Fisher
On Sat, Sep 11, 2010 at 9:17 AM, Adam Barth wrote: > On Sat, Sep 11, 2010 at 8:15 AM, Holger Freyther > wrote: > > On 09/11/2010 05:57 PM, Adam Barth wrote: > >> Do we still believe this FIXME is accurate? If so, I have some time > >> next week to look at removing the dependency. There's a pat

Re: [webkit-dev] Why is ResourceHandle.cpp in WebKit/chromium/src

2010-09-11 Thread Darin Fisher
On Sat, Sep 11, 2010 at 2:49 AM, Adam Barth wrote: > That makes a certain amount of sense. It seems like we have three > ways for WebCore to talk to Webkit/foo: > > 1) Client interfaces > 2) PlatformBridge > 3) Header-in-WebCore, implementation-in-WebKit/foo > > Is there some systematic way of d

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Maciej Stachowiak
On Sep 11, 2010, at 4:21 PM, Sam Weinig wrote: > It seems the dependency on Frame is now gone (as of last night I guess?) with > the advent of the NetworkingContext. Neat. I was going to suggest using factory objects to create ResourceHandles (then they can stuff in whatever info they need, or

Re: [webkit-dev] Why is ResourceHandle.cpp in WebKit/chromium/src

2010-09-11 Thread Maciej Stachowiak
On Sep 11, 2010, at 2:49 AM, Adam Barth wrote: > That makes a certain amount of sense. It seems like we have three > ways for WebCore to talk to Webkit/foo: > > 1) Client interfaces > 2) PlatformBridge > 3) Header-in-WebCore, implementation-in-WebKit/foo > > Is there some systematic way of det

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Adam Barth
Excellent. :) Adam On Sat, Sep 11, 2010 at 4:21 PM, Sam Weinig wrote: > It seems the dependency on Frame is now gone (as of last night I guess?) > with the advent of the NetworkingContext. > -Sam > > On Sat, Sep 11, 2010 at 3:42 PM, Maciej Stachowiak wrote: >> >> On Sep 11, 2010, at 2:57 AM,

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Sam Weinig
It seems the dependency on Frame is now gone (as of last night I guess?) with the advent of the NetworkingContext. -Sam On Sat, Sep 11, 2010 at 3:42 PM, Maciej Stachowiak wrote: > > On Sep 11, 2010, at 2:57 AM, Adam Barth wrote: > > > I don't mean to spam this list with design questions, but I'

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Maciej Stachowiak
On Sep 11, 2010, at 2:57 AM, Adam Barth wrote: > I don't mean to spam this list with design questions, but I'm trying > to wrap my mind around how the loader is put together today and how > we'd like it to be put together in the future. > > There's a FIXME in ResourceHandle that says that Resour

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Adam Barth
On Sat, Sep 11, 2010 at 8:15 AM, Holger Freyther wrote: > On 09/11/2010 05:57 PM, Adam Barth wrote: >> Do we still believe this FIXME is accurate?  If so, I have some time >> next week to look at removing the dependency.  There's a patch that >> either recently landed or is about to land that furt

Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Holger Freyther
On 09/11/2010 05:57 PM, Adam Barth wrote: > Do we still believe this FIXME is accurate? If so, I have some time > next week to look at removing the dependency. There's a patch that > either recently landed or is about to land that furthers the use of > Frame by ResourceHandle, so I wanted to ch

[webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Adam Barth
I don't mean to spam this list with design questions, but I'm trying to wrap my mind around how the loader is put together today and how we'd like it to be put together in the future. There's a FIXME in ResourceHandle that says that ResourceHandle shouldn't depend on Frame. (For those who aren't

Re: [webkit-dev] Why is ResourceHandle.cpp in WebKit/chromium/src

2010-09-11 Thread Adam Barth
That makes a certain amount of sense. It seems like we have three ways for WebCore to talk to Webkit/foo: 1) Client interfaces 2) PlatformBridge 3) Header-in-WebCore, implementation-in-WebKit/foo Is there some systematic way of determining which way we should use in a given circumstance? If we