Re: [webkit-dev] Testing XHR

2010-09-20 Thread Alexey Proskuryakov
I don't think that the suite is testing much besides what we already have regression tests for. For the most part, it just has different expectations. There doesn't seem to be any harm in importing it as a whole now, but looking over the failing tests, categorizing them and sending feedback to

Re: [webkit-dev] Testing XHR

2010-09-20 Thread Ojan Vafai
Filed https://bugs.webkit.org/show_bug.cgi?id=46164 for the script to pull the tests into our repo. On Tue, Sep 21, 2010 at 3:27 PM, Maciej Stachowiak wrote: > > On Sep 20, 2010, at 10:19 PM, Ojan Vafai wrote: > > > > > How about we create http/tests/xmlhttprequest/w3c-experimental or > somethin

Re: [webkit-dev] Testing XHR

2010-09-20 Thread Maciej Stachowiak
On Sep 20, 2010, at 10:19 PM, Ojan Vafai wrote: > > How about we create http/tests/xmlhttprequest/w3c-experimental or something > like that? That can tide us over until the official version comes out, at > which point, we can delete the w3c-experimental directory and just add a w3c > director

Re: [webkit-dev] Testing XHR

2010-09-20 Thread Ojan Vafai
On Tue, Sep 21, 2010 at 2:55 PM, Maciej Stachowiak wrote: > On Sep 20, 2010, at 9:34 PM, Luke Macpherson wrote: > > > WebKit (or at least Chrome) is currently failing a bunch opera's tests > > located at: http://tc.labs.opera.com/apis/XMLHttpRequest/ > > > > It seems that it would be a good idea

Re: [webkit-dev] Testing XHR

2010-09-20 Thread Maciej Stachowiak
On Sep 20, 2010, at 9:34 PM, Luke Macpherson wrote: > WebKit (or at least Chrome) is currently failing a bunch opera's tests > located at: http://tc.labs.opera.com/apis/XMLHttpRequest/ > > It seems that it would be a good idea for us to make use of these > tests in WebKit, so I was thinking of i

[webkit-dev] Testing XHR

2010-09-20 Thread Luke Macpherson
WebKit (or at least Chrome) is currently failing a bunch opera's tests located at: http://tc.labs.opera.com/apis/XMLHttpRequest/ It seems that it would be a good idea for us to make use of these tests in WebKit, so I was thinking of importing them into the codebase. This raises the question: Shoul

[webkit-dev] please add me

2010-09-20 Thread asadulla ansari
-- Regards " Navigate Today For Better Tomorrow!!!" mEeT mE LivE wItH tEcH cAkE @ http://hitechi.19.forumer.com/ http://go4expert.com/ http://www.liveperson.com/asadullah-ansari/ http://go4hitech.wordpress.com/ ___ webkit-dev mailing list webkit-dev@lis

Re: [webkit-dev] Review tool changes

2010-09-20 Thread Chris Marrin
On Sep 20, 2010, at 11:36 AM, Maciej Stachowiak wrote: > > On Sep 20, 2010, at 11:32 AM, Darin Adler wrote: > >> On Sep 20, 2010, at 10:22 AM, Darin Fisher wrote: >> >>> How about this? >>> >>> If any annotations were made to the patch, then "the button" gets named >>> Preview. Else, the bu

Re: [webkit-dev] Review tool changes

2010-09-20 Thread Chris Marrin
On Sep 20, 2010, at 11:36 AM, Adam Roben wrote: > On Sep 20, 2010, at 2:34 PM, Oliver Hunt wrote: > >> I really would like to be able to select some text and add a comment that >> uses the selection as context, a single line of context is frequently >> insufficient, this is about the only thin

Re: [webkit-dev] Review tool changes

2010-09-20 Thread Maciej Stachowiak
On Sep 20, 2010, at 11:32 AM, Darin Adler wrote: > On Sep 20, 2010, at 10:22 AM, Darin Fisher wrote: > >> How about this? >> >> If any annotations were made to the patch, then "the button" gets named >> Preview. Else, the button is named "Publish" and when clicked performs its >> work in one

Re: [webkit-dev] Review tool changes

2010-09-20 Thread Adam Roben
On Sep 20, 2010, at 2:34 PM, Oliver Hunt wrote: > I really would like to be able to select some text and add a comment that > uses the selection as context, a single line of context is frequently > insufficient, this is about the only thing that still makes the new review > tool less effective

Re: [webkit-dev] Review tool changes

2010-09-20 Thread Oliver Hunt
I really would like to be able to select some text and add a comment that uses the selection as context, a single line of context is frequently insufficient, this is about the only thing that still makes the new review tool less effective than the old review mechanism (for me at least). --Olive

Re: [webkit-dev] Ruby Text Enhancements

2010-09-20 Thread Ryosuke Niwa
On Mon, Sep 20, 2010 at 11:12 AM, David Hyatt wrote: > > > This is going to be tricky. You basically want to walk the line box tree > rather than the renderobject tree and then look at surrounding text. > > > About turning off the underline if the ruby is in a link: I've looked at > the styles and

Re: [webkit-dev] Review tool changes

2010-09-20 Thread Maciej Stachowiak
On Sep 20, 2010, at 10:22 AM, Darin Fisher wrote: > On Mon, Sep 20, 2010 at 10:10 AM, Adam Barth wrote: > On Mon, Sep 20, 2010 at 8:37 AM, Alexey Proskuryakov wrote: > > 16.09.2010, в 18:39, Darin Fisher написал(а): > >> Push the publish button to review your comments :-) > > > > Alas, not any

Re: [webkit-dev] Review tool changes

2010-09-20 Thread Darin Adler
On Sep 20, 2010, at 10:22 AM, Darin Fisher wrote: > How about this? > > If any annotations were made to the patch, then "the button" gets named > Preview. Else, the button is named "Publish" and when clicked performs its > work in one shot. > > Was there a strong outcry for removing the previ

Re: [webkit-dev] Ruby Text Enhancements

2010-09-20 Thread David Hyatt
On Sep 17, 2010, at 8:07 PM, Eric Mader wrote: > Hi, > > I'm working on making the following enhancements to Ruby Text: > > 1) Implement the behavior of ruby-overhang:auto > > 2) implement the behavior of ruby-line-stacking:exclude-ruby > > 3) Add some Mac OS specific character properties to t

Re: [webkit-dev] Review tool changes

2010-09-20 Thread Darin Fisher
On Mon, Sep 20, 2010 at 10:10 AM, Adam Barth wrote: > On Mon, Sep 20, 2010 at 8:37 AM, Alexey Proskuryakov > wrote: > > 16.09.2010, в 18:39, Darin Fisher написал(а): > >> Push the publish button to review your comments :-) > > > > Alas, not any more! > > > > https://bugs.webkit.org/show_bug.cgi?

Re: [webkit-dev] Review tool changes

2010-09-20 Thread Adam Barth
On Mon, Sep 20, 2010 at 8:37 AM, Alexey Proskuryakov wrote: > 16.09.2010, в 18:39, Darin Fisher написал(а): >> Push the publish button to review your comments :-) > > Alas, not any more! > > https://bugs.webkit.org/show_bug.cgi?id=46074 Yeah. The machinery is still there for the preview, I'm jus

Re: [webkit-dev] Review tool changes

2010-09-20 Thread Alexey Proskuryakov
16.09.2010, в 18:39, Darin Fisher написал(а): > Push the publish button to review your comments :-) > Alas, not any more! https://bugs.webkit.org/show_bug.cgi?id=46074 - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.o