[webkit-dev] question on Structure.

2012-01-05 Thread PandaCanFly
Hi, all. I am reading the implementation of JavascriptCore. I think Class Structure, Class JSCell, Class JSObject are the point to understand other codes. The member functions of Structure whose name is addPropertyTransition, addPropertyTransitionToExistingStructure, really confuse me. I

Re: [webkit-dev] Selection model is broken

2012-01-05 Thread Ojan Vafai
Sorry, that was too terse, https://bugs.webkit.org/show_bug.cgi?id=62664 is related in that we also should consider making tabindex order depend on visual ordering. On Thu, Jan 5, 2012 at 7:05 PM, Ojan Vafai wrote: > Another related bug https://bugs.webkit.org/show_bug.cgi?id=62664. > > > On Thu

Re: [webkit-dev] Selection model is broken

2012-01-05 Thread Ojan Vafai
Another related bug https://bugs.webkit.org/show_bug.cgi?id=62664. On Thu, Jan 5, 2012 at 4:30 PM, Ojan Vafai wrote: > On Thu, Jan 5, 2012 at 3:44 PM, Benjamin Poulain wrote: > >> On Thu, Jan 5, 2012 at 3:31 PM, Ojan Vafai wrote: >> > Is this too crazy? Are there other solutions? >> >> I also d

Re: [webkit-dev] Understanding WebKit layering and layering violations

2012-01-05 Thread Adam Barth
On Thu, Jan 5, 2012 at 4:18 PM, Fady Samuel wrote: > I've been working on WebKit off and on for a while now but I must admit > that, up to this point, I still don't have a firm grasp of all the layering > in WebKit. What depends on what, and what cannot depend on what? What is the > motivation of

Re: [webkit-dev] Selection model is broken

2012-01-05 Thread Ojan Vafai
On Thu, Jan 5, 2012 at 3:44 PM, Benjamin Poulain wrote: > On Thu, Jan 5, 2012 at 3:31 PM, Ojan Vafai wrote: > > Is this too crazy? Are there other solutions? > > I also do not like the selection model but I am unsure about your > suggestion. > > If we use the visual model for selection, finding t

Re: [webkit-dev] Selection model is broken

2012-01-05 Thread Ryosuke Niwa
On Thu, Jan 5, 2012 at 4:03 PM, Ojan Vafai wrote: > On Thu, Jan 5, 2012 at 3:47 PM, Ryosuke Niwa wrote: > >> On Thu, Jan 5, 2012 at 3:31 PM, Ojan Vafai wrote: >> >>> Selections on the web are document ordered (i.e. all the DOM between two >>> points). So, any CSS that puts elements out of docum

[webkit-dev] Understanding WebKit layering and layering violations

2012-01-05 Thread Fady Samuel
Hi all, I've been working on WebKit off and on for a while now but I must admit that, up to this point, I still don't have a firm grasp of all the layering in WebKit. What depends on what, and what cannot depend on what? What is the motivation of each of these individual layers? I understand the n

Re: [webkit-dev] Selection model is broken

2012-01-05 Thread Ojan Vafai
On Thu, Jan 5, 2012 at 3:47 PM, Ryosuke Niwa wrote: > On Thu, Jan 5, 2012 at 3:31 PM, Ojan Vafai wrote: > >> Selections on the web are document ordered (i.e. all the DOM between two >> points). So, any CSS that puts elements out of document order gives a >> crappy selection to the user. >> >> fo

Re: [webkit-dev] Selection model is broken

2012-01-05 Thread Ryosuke Niwa
On Thu, Jan 5, 2012 at 3:31 PM, Ojan Vafai wrote: > Selections on the web are document ordered (i.e. all the DOM between two > points). So, any CSS that puts elements out of document order gives a > crappy selection to the user. > > foo style="position:absolute;left:-100px">barbaz. > > If you sel

Re: [webkit-dev] Selection model is broken

2012-01-05 Thread Benjamin Poulain
On Thu, Jan 5, 2012 at 3:31 PM, Ojan Vafai wrote: > Is this too crazy? Are there other solutions? I also do not like the selection model but I am unsure about your suggestion. If we use the visual model for selection, finding the order of the content would get tricky (because the selected conten

[webkit-dev] Selection model is broken

2012-01-05 Thread Ojan Vafai
Selections on the web are document ordered (i.e. all the DOM between two points). So, any CSS that puts elements out of document order gives a crappy selection to the user. foobarbaz. If you select "foobaz", clearly no user would expect "bar" to get selected. The same problem arises with floats,

Re: [webkit-dev] layout tests: how are some compared against image, and others only text?

2012-01-05 Thread Stephen White
On Wed, Jan 4, 2012 at 6:39 PM, Elliot Poger wrote: > What is it that causes some tests to require baseline images (and not text > files) for comparison, while others require text and not image baselines? > > (I know that I can specifically SKIP comparison against IMAGE and/or TEXT > using test_e

Re: [webkit-dev] Asking for review by pinging bugs---another approach

2012-01-05 Thread Adam Barth
Sure. Feel free to add that feature. Obviously we don't want to force people to use it, but it might become popular. Adam On Jan 5, 2012 3:12 AM, "Hajime Morrita" wrote: > Does it make sense for webkit-patch post/upload to support "--ping" to > acknowledge a set of reviewers using a specific

Re: [webkit-dev] Asking for review by pinging bugs---another approach

2012-01-05 Thread Hajime Morrita
Does it make sense for webkit-patch post/upload to support "--ping" to acknowledge a set of reviewers using a specific form of comment? As a reviewer, some kind of specific pattern would be helpful to filter such ping mails which contain, for example, "ping:morrita@". Maybe this can be taken as a

Re: [webkit-dev] Tools/Scripts/build-webkit --gtk --debug --makeargs="-j1" taking up to 80% of memory

2012-01-05 Thread Soo-Hyun Choi
Sachin, On Thu, Jan 5, 2012 at 15:18, sachin nikam wrote: > i am running ubuntu 11.10 64 bit. I was able to eventually build with > --makeargs="-j1". > I will try increase the swap space and see if it helps. WebKit Debug build over Ubuntu 64bit machines should've been fine without any alteration

Re: [webkit-dev] Asking for review by pinging bugs---another approach

2012-01-05 Thread Andreas Kling
On Thu, Jan 5, 2012 at 7:49 AM, Adam Barth wrote: > Not to pick on anyone in particular, but when reading bugmail I > occasionally see messages like "pinging for review." I review a lot > of patches, but I don't find these messages particularly helpful > because I don't know whether I'm supposed