Also keep in mind that currently different build systems hack the include
path up to have the same #include point to different headers depending on
the build configuration, so the path expansion for a given #include will
not be the same for all ports. It's basically a very non-obvious way to do
The patch in question landed nearly a year ago and was added in order to
test functionality that was (at the time) implemented in WebCore.
window.testRunner may have been a better choice, I don't remember what the
state of it at the time was. Nowadays the functionality under test is no
longer in
On Thu, Mar 14, 2013 at 1:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
\On Thu, Mar 14, 2013 at 1:43 PM, James Robinson jam...@google.comwrote:
The patch in question landed nearly a year ago and was added in order to
test functionality that was (at the time) implemented in WebCore
On Tue, Mar 5, 2013 at 9:11 AM, Chris Fleizach cfleiz...@apple.com wrote:
Hello,
I'm planning on implementing the IndieUI Events 1.0 W3C spec
https://dvcs.w3.org/hg/IndieUI/raw-file/default/src/indie-ui-events.html
This feature's primary goal is to allow assistive technologies (like a
On Mon, Mar 4, 2013 at 4:52 PM, Jer Noble jer.no...@apple.com wrote:
On Mar 4, 2013, at 4:46 PM, Ryosuke Niwa rn...@webkit.org wrote:
Could you add either build or runtime flag?
I most definitely could. But are there any ports who would disable the
flag? (Honestly asking, here.) If
On Thu, Feb 14, 2013 at 9:55 AM, Dirk Schulze dschu...@adobe.com wrote:
Hi WebKit folks,
I worked on the Path interface defined by the Canvas spec of W3C and
WHATWG [1][2] for the last couple of weeks.
Summary:
Canvas supports a new DOM interface called Path. The Path interface takes
a
On Fri, Feb 1, 2013 at 5:12 PM, Balazs Kelemen kbal...@webkit.org wrote:
On 02/01/2013 02:28 AM, Darin Fisher wrote:
It would be nice if, in the shared library build of chromium, webcore and
perhaps the modules and platform were separate DLLs.
The shared library build is kind of a
On Tue, Jan 29, 2013 at 6:29 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Jan 29, 2013 at 5:46 PM, Adam Barth aba...@webkit.org wrote:
I understand that the new rules of the road for WebKit2 are that
contributors are allowed to break non-Apple ports. However, those new
norms do not
On Thu, Nov 29, 2012 at 6:08 PM, James Craig jcr...@apple.com wrote:
Snipping somewhat for brevity…
This is an interesting standards debate but as many people have noted it
does not belong on the webkit-dev list, which is for coordinating the
development of WebKit. Please take this over to
On Fri, Aug 17, 2012 at 1:54 AM, Dong Seong Hwang
luxte...@company100.netwrote:
2012/8/14 Dong Seong Hwang luxte...@company100.net
Trigger image decoding early in layout and scroll will certainly
relieve flashing though it can’t completely remove the problem. We
will apply this
On Thu, Aug 9, 2012 at 5:10 PM, Alpha Lam hc...@chromium.org wrote:
Hi everyone!
A few weeks ago some folks from company100.net have started a thread of
multithreaded (parallel) image decoding in WebKit. We have worked together
since then to get a better idea how to complete this feature. I
There are plenty of non-text tests in fast/, even entire directories of
them (fast/repaint). My understanding of the meaning of fast/ is that it is
where new tests that are not imported should go. This meaning is not
universally applied.
- James
On Jun 11, 2012 7:33 PM, Mike Lawther
(top-posting to fit in)
Doesn't the same argument apply to *deviceScaleFactor? That doesn't make
sense as a Setting either.
Pushing one or both out of settings doesn't answer the question of whether
they are redundant. My gut feeling is that they are and we should fold
them together.
On Fri, May 25, 2012 at 1:42 PM, Žan Doberšek zandober...@gmail.com wrote:
On Fri, May 25, 2012 at 9:57 AM, Dominik Röttsches
dominik.rottsc...@intel.com wrote:
Andrei,
On 05/25/2012 02:43 AM, Andrei Bucur wrote:
Ojan,
As Simon states, some repaint tests will likely not be
On Wed, May 16, 2012 at 12:04 PM, Anders Carlsson ander...@apple.comwrote:
On May 16, 2012, at 9:31 AM, Darin Adler da...@apple.com wrote:
On May 16, 2012, at 9:20 AM, Allan Sandfeld Jensen wrote:
there is another conflict which is entirely our own fault. It is
between WTF::bind and the
On Tue, Apr 24, 2012 at 7:15 AM, Tor Arne Vestbø
tor.arne.ves...@nokia.comwrote:
On 24.04.12 16:04, ext Shezan Baig wrote:
On Tue, Apr 24, 2012 at 9:55 AM, Adam Robenaro...@webkit.org wrote:
In what situation does this cause issues?
Probably the biggest issue is for people who've been
On Wed, Mar 14, 2012 at 2:08 PM, William Siegrist wsiegr...@apple.comwrote:
On Mar 14, 2012, at 1:47 PM, Robert Hogan li...@roberthogan.net wrote:
On Wednesday 14 March 2012 08:44:46 Ashod Nakashian wrote:
From: Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de
To: WebKit Development
On Wed, Mar 7, 2012 at 3:21 PM, Dan Bernstein m...@apple.com wrote:
Please set the svn:mime-type property on binary files that you add to the
tree, such as *-expected.png, before committing. Otherwise the resulting
webkit-changes message will include those files as text, which is
On Mon, Jan 30, 2012 at 3:56 AM, Nikolas Zimmermann
zimmerm...@physik.rwth-aachen.de wrote:
Good evening WebKit folks,
while working on some SVG Filter dynamic update issues I found out that
long-standing assumptions about the paint time don't hold anymore:
svg
rect id=rect width=1
On Mon, Jan 30, 2012 at 12:19 PM, Nikolas Zimmermann
zimmerm...@physik.rwth-aachen.de wrote:
Am 30.01.2012 um 19:38 schrieb James Robinson:
The document was laid out and painted once before the timeout fired. Most
SVG repainting tests work this way: setup document initially, then use
On Mon, Jan 16, 2012 at 12:02 AM, Gyuyoung Kim gyuyo...@gmail.com wrote:
Hello WebKit folks.
It looks that the result of layout test for EFL port needs rebaseline
because of 101343. The revision modified line spacing of font in
SimpleFontDataFreeType.cpp, and it seems that the existing
On Wed, Jan 4, 2012 at 3:39 PM, Elliot Poger epo...@chromium.org wrote:
What is it that causes some tests to require baseline images (and not text
files) for comparison, while others require text and not image baselines?
(I know that I can specifically SKIP comparison against IMAGE and/or
On Thu, Oct 6, 2011 at 11:07 AM, Alexey Proskuryakov a...@webkit.org wrote:
I share Simon's concern that that providing low level access to every
possible controller creates fragmentation, with purportedly HTML content
that only works on a few devices. There is no clear cut border here - it's
On Thu, Oct 6, 2011 at 2:07 PM, Alexey Proskuryakov a...@webkit.org wrote:
06.10.2011, в 13:49, Scott Graham написал(а):
The first revision of the spec (from the Scope section) is intended to
handle:
... support for devices common to current gaming systems including
gamepads, directional
On Wed, Oct 5, 2011 at 5:43 PM, Simon Fraser simon.fra...@apple.com wrote:
On Oct 5, 2011, at 5:37 PM, Darin Adler wrote:
Hi folks.
It really helps frequent reviewers like me if you use platform prefixes
on bugs. A platform prefix indicates that the bug only affects code on a
particular
On Tue, Oct 4, 2011 at 2:06 PM, Ryosuke Niwa rn...@webkit.org wrote:
Hi,
It came to my attention that some people are using raw pointers to pass
out-arguments (e.g. bug 69366). In my understanding, we use pass by
reference for out arguments when they have to be modified in callees.
If
On Tue, Sep 27, 2011 at 10:34 AM, Chris Marrin cmar...@apple.com wrote:
On Sep 26, 2011, at 9:48 PM, James Robinson wrote:
What happened at frame 9? Instead of advancing by 15 milliseconds worth,
the bird jumped forward by twice the normal amount. Why? We ran the rAF
callback twice
On Sun, Sep 25, 2011 at 6:52 PM, Darin Adler da...@apple.com wrote:
On Sep 25, 2011, at 12:20 AM, James Robinson wrote:
The TIMER based support for RAF is very new (only a few weeks old) and
still has several major bugs. I'd suggest letting it bake for a bit before
considering turning
On Sat, Sep 24, 2011 at 11:29 PM, Adam Barth aba...@webkit.org wrote:
On Sat, Sep 24, 2011 at 11:21 PM, Adam Barth aba...@webkit.org wrote:
On Thu, Sep 15, 2011 at 11:06 AM, Adam Barth aba...@webkit.org wrote:
On Wed, Sep 14, 2011 at 11:06 PM, Darin Fisher da...@chromium.org
wrote:
What
On Thu, Sep 22, 2011 at 2:32 PM, Charles Pritchard ch...@jumis.com wrote:
On 9/22/2011 2:13 PM, Ian Hickson wrote:
On Fri, 23 Sep 2011, Dean Jackson wrote:
However, isn't prefixing designed to avoid incompatibilities in spec
changes, not incompatibilities between implementations? Ensuring
On Thu, Sep 22, 2011 at 7:31 PM, Young Han Lee joybro...@gmail.com wrote:
Hi all,
I have a patch to add webkitLineDash and webkitLineDashOffset APIs on
CanvasRenderingContext2D on https://bugs.webkit.org/show_bug.cgi?id=63933
The purpose of these APIs is to support for strokes with dash in
== Always Enable ==
ENABLE(DETAILS) ???
ENABLE(DOM_STORAGE)
ENABLE(EVENTSOURCE)
ENABLE(INSPECTOR) ???
ENABLE(METER_TAG)
ENABLE(OFFLINE_WEB_APPLICATIONS)
ENABLE(PROGRESS_TAG)
ENABLE(SVG_ANIMATION) = Gated on ENABLE(SVG)
ENABLE(SVG_AS_IMAGE) = Gated on ENABLE(SVG)
On Thu, Sep 8, 2011 at 11:49 AM, Alexey Proskuryakov a...@webkit.org wrote:
08.09.2011, в 11:32, Eric Seidel написал(а):
FYI: As many of you already know, the build.webkit.org bots run
run-bindings-tests on (almost) all platforms.
They've been running (mostly w/o incident) on the bots
On Thu, Aug 18, 2011 at 2:05 PM, Sailesh Agrawal s...@chromium.org wrote:
Hi all, I'm trying to commit a patch through commit queue and I'm getting a
strange error:
http://queues.webkit.org/results/9419886
From that output, I'd guess that there was a merge conflict trying to apply
the patch.
On Jul 10, 2011 10:53 AM, Adam Barth aba...@webkit.org wrote:
Hi webkit-dev,
In trying to understand how our LayoutTest results system works, I've
created a digram of the fallback graph among the various
platform-specific directories:
On Wed, Jun 22, 2011 at 4:21 PM, Chris Fleizach cfleiz...@apple.com wrote:
On Jun 22, 2011, at 3:34 PM, Dominic Mazzoni wrote:
I just had another thought: how would this work in a multi-process
browser?
As you may know, Chrome runs an instance of webkit in a separate
renderer process
On Wed, Jun 8, 2011 at 4:20 PM, Darin Fisher da...@chromium.org wrote:
It seems like it doesn't scale very well to have to stand-up new buildbots
for each
new feature. At least in the Chromium port, it is possible for the
Chromium repo
to override ENABLE_ flags so that only DRT gets built
the ENABLE_'d code interacts with
the rest of the codebase.
- James
-Darin
On Wed, Jun 8, 2011 at 4:29 PM, James Robinson jam...@google.com wrote:
On Wed, Jun 8, 2011 at 4:20 PM, Darin Fisher da...@chromium.org wrote:
It seems like it doesn't scale very well to have to stand-up new
On Tue, May 31, 2011 at 12:08 PM, Geoffrey Garen gga...@apple.com wrote:
I agree that const should be used for logical constness. The rule should
not be merely doesn't alter any data members of this object but rather
does not alter observable state of this object or vend any type of pointer
I find these cherry-pick bug comments annoying and hope that you will stop
generating them. There are many ports that make releases based off of
WebKit trunk, and all of them have some notion of release branches that
contain cherry-picked revisions, reverts, etc. As a developer it's nearly
I have a related question - what sort of test coverage is there for WML
currently on the core bots? Do any of the core bots compile with WML
enabled? I've made and reviewed a few changes to WML code made parallel to
changes to the HTML forms code in the past and have made the WML edits
Which WebKit browser is using XHTMLMP?
- James
On Tue, Mar 8, 2011 at 4:43 PM, Ra Kyounga kyounga...@gmail.com wrote:
Currently, XHTMLMP is used in webkit browser for mobile business.
So, I think it's good to leave it for a while :)
2011. 3. 8., 오전 5:09, Eric Seidel 작성:
Are any ports
http://build.webkit.org/console fails to load in Chromium (and Google
Chrome) today. It seems that the bug is in the server's Accept-Encoding:
handling. If the Accept-Encoding line includes 'sdch' then the server
closes the socket without sending any response bytes. Requests for other
pages
On Tue, Jan 18, 2011 at 4:30 PM, Darin Adler da...@apple.com wrote:
It seems that a lot of people are making script tests with non-standard
wrappers. And not adding exceptions to the make-script-test-wrappers
script. I ran the script and it created 4 files, and modified 33 others.
Any ideas
Are you posting here because there is something specific to WebKit in
your query or because you dislike the outcome of the WHATWG thread?
Most of us follow the WHATWG closely and generally prefer to discuss
standardization issues such as this in that forum to get a broader
feedback base.
- James
On Fri, Nov 5, 2010 at 6:32 PM, James Craig jcr...@apple.com wrote:
Ojan Vafai wrote:
How is [ DOMAttributeChangeRequestEvent ] any different than
DOMAttrModified? The spec claims it doesn't have the problems that
DOMAttrModified has, but I don't see how that's the case.
DOMAttrModified
On Tue, Oct 12, 2010 at 9:47 AM, Chris Marrin cmar...@apple.com wrote:
On Oct 11, 2010, at 5:15 PM, Maciej Stachowiak wrote:
On Oct 11, 2010, at 4:03 PM, Chris Marrin wrote:
On Oct 11, 2010, at 3:35 PM, James Robinson wrote:
On Mon, Oct 11, 2010 at 3:15 PM, Chris Marrin cmar
To add a concrete data point, http://trac.webkit.org/changeset/69517 caused
a number of SVG tests to fail. It required 14 text rebaselines for Mac and
a further two more for Leopard (done by Adam Barth). In order to pass the
pixel tests in Chromium, it required 1506 new pixel baselines (checked
On Tue, Oct 12, 2010 at 3:46 PM, Maciej Stachowiak m...@apple.com wrote:
On Oct 12, 2010, at 2:37 PM, Darin Fisher wrote:
On Tue, Oct 12, 2010 at 1:20 PM, Maciej Stachowiak m...@apple.com wrote:
Hmm, I've found weak pointer abstractions to be very useful. The issue
with reference counting
On Mon, Oct 11, 2010 at 3:15 PM, Chris Marrin cmar...@apple.com wrote:
For accelerated 2D rendering we created a class called DrawingBuffer. This
encapsulates the accelerated drawing surface (usually in the GPU) and the
compositing layer used to display that surface on the page. The drawing
On Mon, Oct 11, 2010 at 4:03 PM, Chris Marrin cmar...@apple.com wrote:
On Oct 11, 2010, at 3:35 PM, James Robinson wrote:
On Mon, Oct 11, 2010 at 3:15 PM, Chris Marrin cmar...@apple.com wrote:
For accelerated 2D rendering we created a class called DrawingBuffer.
This encapsulates
On Mon, Sep 27, 2010 at 2:40 PM, Anne van Kesteren
annevankeste...@gmail.com wrote:
(I'm subscribed to webkit-dev with a different address.)
On Mon, Sep 27, 2010 at 8:31 PM, Michael Nordman micha...@google.com
wrote:
Yes, if we go with telling xhr up front for the array buffer case, I
On Mon, Sep 27, 2010 at 6:37 PM, Maciej Stachowiak m...@apple.com wrote:
On Sep 27, 2010, at 3:19 PM, Michael Nordman wrote:
Webkit's XHR currently does not keep two copies of the data that I can see.
I think we should avoid that.
We could keep the raw data around, which hopefully is
On Wed, Sep 1, 2010 at 4:20 PM, Chris Marrin cmar...@apple.com wrote:
Ken's PODRedBlackTree patch has made me go back and take a closer look at
WebKit's Arena class. Turns out it's not a class at all, just some structs
and macros. That seems very un-WebKit-like to me. Ken's patch also has a
The style guide currently covers this
http://webkit.org/coding/coding-style.html:
4. Control clauses without a body should use empty braces:Right:
for ( ; current; current = current-next) { }
Wrong:
for ( ; current; current = current-next);
- James
On Thu, Aug 26, 2010 at 12:22 PM, Chris
On Wed, Aug 25, 2010 at 2:34 PM, Adam Barth aba...@webkit.org wrote:
On Wed, Aug 25, 2010 at 2:31 PM, Stephan Assmus supersti...@gmx.de
wrote:
Am 25.08.2010 18:35, schrieb Adam Barth:
On Wed, Aug 25, 2010 at 7:09 AM, Stephan Assmussupersti...@gmx.de
wrote:
Am 24.08.2010 19:46, schrieb
Indeed! Dimitri or I will fix the python by Monday.
- James
On Aug 14, 2010 11:31 AM, Adam Barth aba...@webkit.org wrote:
The Chromium bots were supposed to have their Python upgraded ages
ago. If we ever want to run the LayoutTests on them, they'll need
their Python upgraded anyway. I think
On Mon, Aug 9, 2010 at 4:39 PM, Ojan Vafai o...@chromium.org wrote:
On Thu, Aug 5, 2010 at 2:22 AM, Adam Barth aba...@webkit.org wrote:
On Thu, Aug 5, 2010 at 1:59 AM, Maciej Stachowiak m...@apple.com wrote:
If mutation events tend to break editing, one simple solution is to turn
then off
I've had patches sit in the review queue for 4 weeks then receive a
positive review and land without much incident. Some patches are difficult
to review or have a limited number of potential reviewers. I would have
really appreciated a reminder email about that patch in particular (I
honestly
On Wed, Jul 7, 2010 at 7:19 PM, Oliver Hunt oli...@apple.com wrote:
On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote:
On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao zhen...@gmail.com wrote:
Maybe I should complain this in a different threads, but recently the
commit bot waiting time is way
How? Visited state information is not stored in the javascript heap (which
is what this object contains information about).
- James
On Fri, Jun 4, 2010 at 12:06 PM, David Hyatt hy...@apple.com wrote:
I'm fairly certain I could construct an attack on :visited history privacy
using this
...@apple.comwrote:
On May 17, 2010, at 3:44 PM, James Robinson wrote:
After this is done it should be possible to run the full layout test suite
with --tolerance=0 on Snow Leopard and have no failures. Assuming this
happens, I would like to switch the default value of --tolerance from 0.1
Leopard and Snow Leopard have subtle differences in the way they render
antialiased text. This does not affect the text metrics but does cause
slight pixel differences. The majority of our existing pixel test baselines
appear to have been generated on Leopard, but there is a growing minority of
As a concrete example, I found this test setup helpful for this patch:
http://trac.webkit.org/changeset/58345. A nice side effect was that it
revealed a bug in CodeGeneratorGObject.pm and let me fix it without having
to set up build setup for whatever it is that uses the GObject bindings.
I
I saw a very similar bug recently regarding modal dialogs and focus/blur
events: https://bugs.webkit.org/show_bug.cgi?id=33962. I think you will see
the crash from that stacktrace with or without r55593 in place. For
example, currently some mouse event handlers can fire underneath a
window.alert
On Tue, Nov 17, 2009 at 2:19 PM, Alexander Limi l...@mozilla.com wrote:
Good people of Webkit!
We'd all like for the web to be faster, and therefore I'd love your feedback
on my proposal — it would be great to see support for this in additional
browsers, not just Firefox:
On Tue, Nov 17, 2009 at 3:02 PM, Peter Kasting pkast...@google.com wrote:
On Tue, Nov 17, 2009 at 3:00 PM, James Robinson jam...@google.com wrote:
It seems like a browser will have to essentially stop rendering until
it has finished downloading the entire .zip and examined it.
I think
,
easier, faster solution.
On Tue, Nov 17, 2009 at 3:00 PM, James Robinson jam...@google.com
wrote:
It seems like a browser will have to essentially stop rendering until
it has finished downloading the entire .zip and examined it.
No. That's why the manifest is there, since it can be read early
On Sun, Oct 4, 2009 at 8:19 AM, Buakaw San buakaw@gmail.com wrote:
There is a document called How Chromium Displays Web Pages (http://
dev.chromium.org/developers/design-documents/displaying-a-web-page-in-
chrome), however I haven't found an equivalent page for Webkit. E.g.
How Webkit
On Fri, Oct 2, 2009 at 12:10 PM, Peter Kasting pkast...@google.com wrote:
On Fri, Oct 2, 2009 at 11:13 AM, Geoffrey Garen gga...@apple.com wrote:
Live items cannot be removed from the cache.
Yeah, I think that is what I'm seeing.
Assume the page is not being painted (e.g. the window is
It's difficult to understand the performance of a large web app nowadays -
think GMail scale and beyond, in part because a lot of things happen in the
UI thread outside of javascript. For example layout, selector matching and
painting can all happen in a deferred way, take a lot of time and yet
71 matches
Mail list logo
