On Fri, Dec 3, 2010 at 1:28 PM, Eric Seidel e...@webkit.org wrote:
It seems to me, that using bool types for function arguments is strictly
worse than using an enum. An enum is always clearer and can be easily
casted to a bool if needed.
doSomething(something, false);
Is much less
On Fri, Dec 3, 2010 at 2:42 PM, David Hyatt hy...@apple.com wrote:
An example of nice boolean usage is:
paintTextWithShadows(context, font, textRun, 0, length, length,
textOrigin, boxRect, textShadow, textStrokeWidth 0, isHorizontal());
GOOD!
The last parameter is a boolean indicating
webkit-dev is not a help me with my website list. It's for discussion of
development on WebKit itself.
PK
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Mon, Nov 1, 2010 at 9:40 AM, Brady Eidson beid...@apple.com wrote:
I think this pattern increases readability of forward declarations in
headers and we should change the style guidelines to specify its continued
use.
Thoughts?
I don't find either one significantly better than the other,
On Fri, Oct 22, 2010 at 11:02 AM, Kenneth Russell k...@google.com wrote:
WebKit coding practice is to not set svn:eol-style
on checked in text files
Darin Adler told me a while back that this is untrue, and that originally
all files had eol-style set and it was sloppiness/laziness/ignorance
On Mon, Oct 4, 2010 at 4:23 AM, Leandro Graciá Gil
leandrogra...@chromium.org wrote:
In summary, looking at code like this
B b = c-foo();
...
b.m();
If c-foo() returns a temporary (return B();), then it is safe.
Maybe I'm wrong, but are you completely sure about this one? I would
On Sun, Oct 3, 2010 at 10:31 AM, Darin Adler da...@apple.com wrote:
What you say here about object lifetime is not correct. I thought the same
thing a year or so back. But the C++ language keeps these objects alive
until the end of the block.
Correct. One helpful section from the standard
On Wed, Jul 21, 2010 at 2:40 PM, Ojan Vafai o...@chromium.org wrote:
Here are my initial thoughts on what a review bot would do.
*After a patch turns a week old, send the following email:*
Patch 12345 of bug 6789 is a week old. It may just be because no reviewer
has found time to review it.
On Wed, Jul 7, 2010 at 5:00 PM, Dmitry Titov dim...@chromium.org wrote:
I'd lean to the removal, unless there is a port that has work ongoing or
planned soon for those implementations.
Does anybody vote for #ifdefs?
I vote against removal if only because Chromium has really wanted these
On Thu, Jun 10, 2010 at 8:34 AM, Antonio Gomes (:tonikitoo)
toniki...@gmail.com wrote:
Ideally, patches in feedback? status should also be easier to
review/validate, and the author would be sure it is taking the right
path. EWS bots would not necessarily have to build it or even do style
On Thu, Jun 10, 2010 at 11:20 AM, Adam Barth aba...@webkit.org wrote:
On Thu, Jun 10, 2010 at 10:46 AM, Peter Kasting pkast...@google.com
wrote:
I'd quite like a flag that means this isn't ready for review, but the
test
bots should try it out and see if there are bugs in it. I don't know
On Thu, Jun 10, 2010 at 12:26 PM, David Hyatt hy...@apple.com wrote:
There are Web sites that depend on never scrolling less than 1 wheel delta
line though. So what can we do to get the best of both worlds?
Can we keep a count of the total delta not yet sent to the page, and each
time it
On Thu, Jun 10, 2010 at 12:26 PM, David Hyatt hy...@apple.com wrote:
Having investigated the original bug and its fix that caused this
regression, Safari 4's behavior was correct. The new behavior is broken.
A tiny continuous event in Safari 4 correctly reported values that are
smaller
On Tue, Jun 8, 2010 at 3:17 PM, Eric Seidel e...@webkit.org wrote:
Has anyone spent any time trying to reduce the number of includes in
WebCore? I know we have:
https://trac.webkit.org/browser/trunk/WebKitTools/Scripts/find-extra-includes
But I feel like we still have way too many
On Tue, Jun 8, 2010 at 8:34 PM, Nathan Vander Wilt nate-li...@calftrail.com
wrote:
What Safari 5's WebKit does is turn one line into 4800 (!) units instead
of 40. For Safari 5 the code above needs to read as follows to work the
same. You can see it isn't really more compatible at all:
var
On Fri, Jun 4, 2010 at 10:14 AM, Chris Fleizach cfleiz...@apple.com wrote:
Is there any way chromium can automate this so if it sees it is different,
it can re-generate to match the enums again
Is it really that enormous of a problem? It doesn't seem like you're going
to be making hundreds
On Fri, Jun 4, 2010 at 10:54 AM, Chris Fleizach cfleiz...@apple.com wrote:
For one, I would like to alphabetize that list. That will require hundreds
of changes, requiring me to make hundreds of blind changes in chromium code.
When ARIA2 comes out, mayhaps there will be a dozen or two new
On Fri, Jun 4, 2010 at 11:11 AM, Darin Adler da...@apple.com wrote:
If the two enum types are identical except for their names, then this
doesn’t firewall the types at all.
It doesn't firewall the concepts (but then, it's hard for an embedding layer
to not transmit any concepts, as that's
On Wed, Jun 2, 2010 at 1:52 PM, Antonio Gomes (:tonikitoo)
toniki...@gmail.com wrote:
If a port do not want to
take advantage of the new support, the current functionality should
and would be kept, i.e. Rect(x,y,1,1,) would do the trick.
Be careful to check whether you really want 1, 1 or
On Wed, Jun 2, 2010 at 3:28 PM, Gavin Peters (蓋文彼德斯) gav...@chromium.orgwrote:
I'm starting hacking at adding support for the Link: http header. This is
described in RFC 2068, although not RFC 2616. As well, there's a current
internet draft describing it:
On Wed, May 19, 2010 at 11:15 AM, Adam Barth aba...@webkit.org wrote:
We could add an unapply-from-attachment command, but that would
involve fetching the patch from bugs.webkit.org again... Another
option is that the upload command could store a copy of the patch
locally that you could then
On Tue, May 11, 2010 at 2:20 PM, Geoffrey Garen gga...@apple.com wrote:
Yes, this way of doing things has more overhead for you personally but
saves overhead for everyone else in the project.
I don't think it's fair to frame my perspective as me personally and your
perspective as everyone
On Mon, May 10, 2010 at 1:23 PM, Geoffrey Garen gga...@apple.com wrote:
I thought it was generally good practice to have bug.webkit.org bugs
with changes?
I wasn't aware of that.
What value would a bug report add in a situation like
http://trac.webkit.org/changeset/59086?
Personally,
On Mon, May 10, 2010 at 1:27 PM, Tony Gentilcore to...@chromium.org wrote:
On Mon, May 10, 2010 at 1:07 PM, Eric Seidel e...@webkit.org wrote:
Is this caused by the base load address of both perl and svn
conflicting/overlapping? (I don't really know how CYGWIN works.)
I'm by no means a
On Mon, May 10, 2010 at 2:05 PM, Adam Barth aba...@webkit.org wrote:
On Mon, May 10, 2010 at 1:30 PM, Peter Kasting pkast...@google.com
wrote:
I agree that a 1:1 association between patches and bugs (which has been
suggested to me in the past, thus mentioning it here) seems like a
mistake
On Mon, May 10, 2010 at 2:26 PM, Adam Barth aba...@webkit.org wrote:
in addition to bot integration, there are also
people integration benefits to using the bug tracker.
Can you say more?
PK
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
On Mon, May 10, 2010 at 2:28 PM, Peter Kasting pkast...@google.com wrote:
On Mon, May 10, 2010 at 2:26 PM, Adam Barth aba...@webkit.org wrote:
in addition to bot integration, there are also
people integration benefits to using the bug tracker.
Can you say more?
Never mind, clearly you're
On Tue, Apr 27, 2010 at 2:33 PM, SCU Rock scur...@gmail.com wrote:
In WebCore/platform/image-
decoders/jpeg/JPEGImageDecoder.cpp (
https://trac.webkit.org/browser/trunk/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp)
and png/PNGImageDecoder.cpp, setjmp and longjmp are called.
On Tue, Apr 20, 2010 at 1:26 AM, Patrick Roland Gansterer par...@paroga.com
wrote:
Bradley Nelson:
1. Ability to incrementally transition on Windows. It took us about 6
months to switch fully to gyp. Previous attempts to move to scons had
taken a long time and failed, due to the
On Tue, Apr 20, 2010 at 10:48 AM, Stephan Assmus supersti...@gmx.de wrote:
In the Haiku port, I've temporarily made some useful BitmapImage methods
public, to iterate over all images contained in the object and find the one
with the size I want (in the browser code later on). Is there a better
On Thu, Apr 15, 2010 at 3:41 PM, Aaron Boodman a...@chromium.org wrote:
I'm not sure what the path is for fetching favicons today. Does
WebCore just implicitly do it, or does it expose the information to
the host, who later may or may not make the request?
Answering this is complicated by
On Mon, Apr 19, 2010 at 10:38 PM, Bradley Nelson bradnel...@google.comwrote:
Here's the innards of an email with a laundry list of stuff I came up with
a while back on the gyp-developers list in response to Mike Craddick
regarding what motivated gyp's development, since we were aware of cmake
On Fri, Apr 16, 2010 at 8:42 AM, Kevin Ollivier kev...@theolliviers.comwrote:
Perhaps, but in any case, I think the first step there is for the Gyp
developers to try implementing support and see how it goes. However, from
that perspective, until Gyp has support for those formats, isn't a
On Fri, Apr 16, 2010 at 3:35 PM, Maciej Stachowiak m...@apple.com wrote:
I'm curious if the Chromium folks who created Gyp had any specific reason
that they ruled out CMake as an option. (I have heard that it was considered
and rejected.)
CCing a couple people involved if they wish to
On Thu, Apr 15, 2010 at 9:15 PM, Kevin Ollivier kev...@theolliviers.comwrote:
Anyway, my $0.02 is that, in terms of immediate bang for the buck, we're
probably better off trying to synchronize the build systems automatically in
some way. My perception is that Qt developers will want to use
On Wed, Apr 14, 2010 at 3:40 AM, Maciej Stachowiak m...@apple.com wrote:
On Apr 13, 2010, at 11:55 PM, Eric Seidel wrote:
Dammit. I'm not smart enough to use mailing lists.
My suggestion was WTFURL. ;)
WTFURLBBQ
MyNameIsURL
PK
___
On Wed, Mar 31, 2010 at 4:54 PM, Adam Barth aba...@webkit.org wrote:
The /cygdrive/c/Program Files/Microsoft Visual Studio 8/Common7/IDE
directory exists, but there's no devenv.com there (presumably because
I'm using Visual Studio Express). What do I need to do to get this
working?
Indeed,
On Thu, Mar 18, 2010 at 10:38 AM, Maciej Stachowiak m...@apple.com wrote:
The documentation on Google doctype has quite a few errors and doesn't seem
to have been updated for a while. For example, this test claims that Safari
3 does not apply style for the a element which is clearly wrong:
Rather than guess at answers to your comments, I CCed Mark Pilgrim, the
doctype owner, who will know what to do with this info.
PK
On Thu, Mar 18, 2010 at 11:18 AM, Maciej Stachowiak m...@apple.com wrote:
On Mar 18, 2010, at 11:07 AM, Peter Kasting wrote:
On Thu, Mar 18, 2010 at 10:38 AM
On Wed, Mar 17, 2010 at 8:55 AM, henry.haveri...@nokia.com wrote:
We don't currently have any documentation for web developers We'd like to
start with best practice articles and tutorials for some
HTML5 and CSS3 features but later extend to the basics and general
reference guides too.
This
On Tue, Mar 16, 2010 at 3:49 PM, Brent Fulgham bfulg...@gmail.com wrote:
Has anyone else run into these kinds of issues, and might have some
suggestions for how to better approach this problem?
On the Chromium side, Brett Wilson is our master of font code.
PK
On Tue, Mar 9, 2010 at 11:45 PM, Zoltan Herczeg zherc...@inf.u-szeged.huwrote:
It's also a big help when peers (which aren't necessarily WebKit
reviewers)
look over it and give review-style feedback as well. Especially when
said
peers know more about that code than any of the official
On Tue, Jan 5, 2010 at 4:50 PM, Chris Marrin cmar...@apple.com wrote:
I don't think the discussion here should be whether or not mutation events
a A Good Thing or not. They are being put to good use in Firefox already and
they are part of DOM Level 2 already. The question should be whether
On Tue, Jan 5, 2010 at 7:56 PM, Maciej Stachowiak m...@apple.com wrote:
If at all possible, I would prefer to help develop and promote a superior
alternative to DOM events rather than extending our DOM event support.
That being said, this is not a strong line in the sand. If enough
On Thu, Oct 1, 2009 at 10:41 AM, Drew Wilson atwil...@google.com wrote:
In this case, there was a failure in one of the layout tests on the windows
platform, so following the advice below, aroben correctly checked in an
update to the test expectations instead of skipping the tests.
On Mon, Dec 21, 2009 at 6:14 PM, Dirk Pranke dpra...@chromium.org wrote:
The Chromium framework doesn't look at the Skipped files, but does
look at the Safari Win baselines (we'll use those if we don't find a
better match).
Given all that, Darin, what were you suggesting when you said Let's
On Wed, Dec 16, 2009 at 9:12 PM, Alexey Proskuryakov a...@webkit.org wrote:
As current style rules say that tests for zero/non-zero should all be done
without equality comparisons. However, this rule can cause significant
readability problems if blindly applied to strcmp: if (!strcmp(string,
On Sat, Dec 12, 2009 at 8:40 PM, Mike Emmel mike.em...@gmail.com wrote:
I don't know the right answer just that its probably
time to overhaul the build system a bit and I can help.
You are certainly welcome to look at the GYP system that the Chromium
project uses to create builds for multiple
On Thu, Dec 10, 2009 at 7:57 AM, Joe Mason jma...@rim.com wrote:
Off the top of my head as a reviewer I'd accept:
if (color.red() == 255 color.green() == 0 color.blue() ==
255) // pink!
over
if (color.red() == 255 !color.green() color.blue() == 255)
// pink!
On Thu, Dec 10, 2009 at 11:28 AM, Adam Treat tr...@kde.org wrote:
both are confusing and in my mind call for exercising reviewer
discretion over the style guide.
And I *do not* think the
style guide is wrong for the *guide* to prefer !foo over foo == 0!
OK. Then I have no idea what your
On Wed, Dec 9, 2009 at 4:47 PM, Adam Treat tr...@kde.org wrote:
On Wednesday 09 December 2009 07:03:51 pm Peter Kasting wrote:
And I don't. Who is right? More importantly, how will you prevent us
from
starting this debate on a bug?
I won't? If you as a reviewer consider the indentation
On Fri, Dec 4, 2009 at 12:13 AM, Chris Jerdonek chris.jerdo...@gmail.comwrote:
An alternative policy is as follows:
(1) If-else control structures must have either braces around all
clauses or braces around no clauses.
(2) A clause with more than one line must be surrounded by braces.
On Thu, Dec 3, 2009 at 5:48 PM, Michael Nordman micha...@google.com wrote:
what peter pitched and what mjs pitched are one and the same i think
No, they are not. Both of us would transform a conditional with three arms.
Only I would transform one with two arms.
PK
On Wed, Dec 2, 2009 at 2:51 PM, Julie Parent
jparent+web...@gmail.comjparent%2bweb...@gmail.com
wrote:
As Eric just said to me in person, another option is to just re-run *any*
failing test twice, and only turn tree red if it fails twice. (Chromium
just recently started doing this, and it
On Wed, Dec 2, 2009 at 8:05 PM, Maciej Stachowiak m...@apple.com wrote:
I believe one rule that could work is something like this:
- Indent case labels inside a switch two spaces.
- Indent actual statements inside a switch four spaces.
- In the case where a case label is followed by a block,
This is a followup to my thread yesterday regarding consistent enforcement
of the style guide. Like Yong Li, I find the current rule about braces on
conditional arms to be suboptimal. The current rule is that one-line arms
must not have braces. This leads to strange constructions like:
if
On Wed, Dec 2, 2009 at 9:19 PM, Mark Rowe mr...@apple.com wrote:
On 2009-12-02, at 21:00, Peter Kasting wrote:
I find this tricky to read and error-prone. I propose that the rule be
modified to be:
* When all arms of a conditional or loop are one physical line, do not
use braces
I'd like formal clarification about how we enforce our style guide.
On https://bugs.webkit.org/show_bug.cgi?id=31806#c5 , Yong Li was notified
that one of his patches violates a WebKit style rule (no {} on one-line
conditional bodies). He objected to the rule, and George Staikos commented
that
On Mon, Nov 30, 2009 at 1:33 PM, Maciej Stachowiak m...@apple.com wrote:
My impression from WHATWG and from TPAC is that the web standards community
and other browser implementors don't really buy into the value of this
feature, so I think there's good odds we would end up in the orphan
On Mon, Nov 30, 2009 at 5:05 PM, Oliver Hunt oli...@apple.com wrote:
It is wrong to design an API based on architectural decisions of your
existing browser -- you should be making decisions based on what the
developers actually need. Being hard for the browser to implement is a
secondary
On Wed, Nov 25, 2009 at 9:41 PM, Dmitry Titov dim...@chromium.org wrote:
BTW, could you tell what's the 'course' that would be reverted?
Meaning, before we decide that SharedWorkers and inter-window communication
are insufficient, and a further proposal should be entertained by the
standards
On Tue, Nov 17, 2009 at 9:58 PM, Steve Souders st...@souders.org wrote:
I like the option of putting the manifest in the HTML. That was the main
suggestion I was going to make. You don't *have* to do it, but if you really
care about performance you could choose to do it.
James mentions: The
On Wed, Nov 18, 2009 at 3:54 PM, Dirk Pranke dpra...@chromium.org wrote:
Another caching-related issue involves versioning of the archives. If
version 2 of a zip contains only a few files modified since version 1,
and I have version 1 cached, is there some way to take advantage of
that?
On Tue, Nov 17, 2009 at 2:19 PM, Alexander Limi l...@mozilla.com wrote:
We'd all like for the web to be faster, and therefore I'd love your
feedback on my proposal
I have read the whole document, but I read it quickly, so please do point
out places where I've overlooked an obvious response.
On Tue, Nov 17, 2009 at 3:00 PM, James Robinson jam...@google.com wrote:
It seems like a browser will have to essentially stop rendering until
it has finished downloading the entire .zip and examined it.
I think mitigating this is why there are optional manifests. I agree that
if there's no
On Tue, Nov 17, 2009 at 3:14 PM, James Robinson jam...@google.com wrote:
On Tue, Nov 17, 2009 at 3:02 PM, Peter Kasting pkast...@google.com
wrote:
On Tue, Nov 17, 2009 at 3:00 PM, James Robinson jam...@google.com
wrote:
It seems like a browser will have to essentially stop rendering until
On Tue, Nov 17, 2009 at 5:36 PM, Alexander Limi l...@mozilla.com wrote:
On Tue, Nov 17, 2009 at 2:44 PM, Peter Kasting pkast...@google.com
wrote:
Reduced parallelism is a big concern of mine. Lots of sites make heavy
use of resource sharding across many hostnames to take advantage
On Thu, Oct 22, 2009 at 2:37 PM, Evan Martin ev...@google.com wrote:
This likely isn't what PK was talking about, but it's a good example
in its irony. Try selecting a paragraph on the front page of
webkit.org; you'll see weird gap painting over the navbar on the left.
Ben has suggested to
On Mon, Oct 19, 2009 at 1:10 PM, David Hyatt hy...@apple.com wrote:
I can get how editing in text fields you might feel a desire to match the
platform (where ragged selection may be the convention), but once you get
into rich text selection (images, floats, tables, columns, etc.), there
On Mon, Oct 19, 2009 at 1:21 PM, David Hyatt hy...@apple.com wrote:
On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote:
I'm not quite sure what you mean. Do you just mean it looks visually
confusing, but when you copy/paste you get the right text? Or are you
saying that it's actually
On Mon, Oct 19, 2009 at 1:31 PM, David Hyatt hy...@apple.com wrote:
You aren't only selecting text on a page though. For example, copying can
be of all the HTML content. This includes tables, images, plugins, etc.
If you don't highlight that content, then you're lying about what gets
On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher da...@chromium.org wrote:
I think there is a good use case for copying a selection of HTML from any
web page and pasting that into the rich text editor of a web mail program.
I agree, but that case does not degrade badly when you only copy the
On Mon, Oct 19, 2009 at 1:45 PM, David Hyatt hy...@apple.com wrote:
On Oct 19, 2009, at 3:37 PM, Peter Kasting wrote:
The only time non-text should be copied is when it is part of a rich text
area. In that case copying rich content makes sense.
Ok, well we fundamentally disagree
On Mon, Oct 19, 2009 at 1:55 PM, Pam Greene p...@chromium.org wrote:
On Mon, Oct 19, 2009 at 1:43 PM, Peter Kasting pkast...@google.comwrote:
On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher da...@chromium.org wrote:
I think there is a good use case for copying a selection of HTML from any
web
On Mon, Oct 19, 2009 at 1:58 PM, Joe Mason j...@notcharles.ca wrote:
Perhaps the browser should have Copy text and Copy all objects
options (in which case either WebKit needs to support both modes, or
the browser would need to filter the copied data).
Yes, that could help. Filed
On Mon, Oct 19, 2009 at 6:03 PM, Oliver Hunt oli...@apple.com wrote:
The real issue is whether application shortcuts get precedence over DOM
event handlers, currently on mac the DOM event handlers get precedence (and
thus the ability to override/prevent application shortcuts) and on windows
On Wed, Oct 14, 2009 at 10:25 AM, David Hyatt hy...@apple.com wrote:
On Oct 14, 2009, at 1:22 AM, Sam Weinig wrote:
(most patches probably won't break a build, unless you are named Dave
Hyatt).
Unnecessary. Wow.
T-shirts never lie
http://www.cafepress.com/tinderbox.1417340
On Thu, Oct 1, 2009 at 11:26 PM, Zoltan Herczeg zherc...@inf.u-szeged.huwrote:
see QWebSettings::clearMemoryCaches() (WebKit/qt/Api/qwebsettings.cpp) to
clear memory caches
Thanks, this is super-helpful.
PK
___
webkit-dev mailing list
On Fri, Oct 2, 2009 at 11:13 AM, Geoffrey Garen gga...@apple.com wrote:
Live items cannot be removed from the cache.
Yeah, I think that is what I'm seeing.
Assume the page is not being painted (e.g. the window is minimized). Is
there a way to turn the live items into dead ones so they can be
On Fri, Oct 2, 2009 at 2:42 PM, James Robinson jam...@google.com wrote:
On Fri, Oct 2, 2009 at 12:10 PM, Peter Kasting pkast...@google.comwrote:
On Fri, Oct 2, 2009 at 11:13 AM, Geoffrey Garen gga...@apple.com wrote:
Live items cannot be removed from the cache.
Yeah, I think that is what
In Chromium, we have various events that we'd like to respond to by freeing
as much memory as possible. (One example is system sleep, where we'd like
to dump memory before sleeping to avoid having to page it back in after
waking.)
I'm trying to find what areas in WebCore are good candidates for
On Wed, Sep 23, 2009 at 6:03 PM, Maciej Stachowiak m...@apple.com wrote:
My thinking on the topic is basically this:
A) For experimental features, it makes sense to make them disappear
completely when turned off, since turning them on is an unusual and
experimental state.
B) For end-user
On Thu, Sep 17, 2009 at 12:14 PM, Darin Fisher da...@chromium.org wrote:
At any rate, I think I'm persuaded by your arguments. Adam made a similar
argument the other day too. It seems reasonable to make Image behave this
way when created in certain contexts. We should probably include
On Tue, Sep 15, 2009 at 11:35 PM, Brady Eidson beid...@apple.com wrote:
I perceive the worse case outcome of the experiment to be that we change
the behavior back, but we will have educated web developers about pagehide
and evangelized at least a few of them into switching over.
When you
On Wed, Sep 16, 2009 at 1:52 PM, Brady Eidson beid...@apple.com wrote:
At some point when I wasn't paying close attention, this thread started to
talk about two different things that both happened to be related to unload
handlers.
I think:
1 - We all agree that the Page Cache is good
2 -
On Wed, Sep 16, 2009 at 1:53 PM, Maciej Stachowiak m...@apple.com wrote:
I think a good way to deal with poorly written unload handlers is to
temporarily set the slow script timeout to a much lower value during
execution of unload. This would not require any JS-engine-specific changes
to
On Wed, Sep 16, 2009 at 2:21 PM, Maciej Stachowiak m...@apple.com wrote:
I think that setting an upper bound on the amount of time that can be spent
in all unload handlers is a better solution than hacking the behavior of the
Date API. Because (a) It's less likely to have unexpected side
On Wed, Sep 16, 2009 at 2:54 PM, Adam Barth aba...@webkit.org wrote:
By the way, I fully expect to be overruled (outvoted?) here.
Unfortunately, that bug is degenerating into as complicated a
discussion as the downstream bug that started this discussion. Many
folks seem to have thought
On Wed, Sep 2, 2009 at 8:40 AM, David Levin le...@chromium.org wrote:
*Comments
* There should be a *single* space after punctation and before the next
sentence.
There should only be a single space before end of line comments.
I don't think either of these are unwritten rules. Both
On Wed, Sep 2, 2009 at 9:44 AM, Adam Barth aba...@webkit.org wrote:
On Wed, Sep 2, 2009 at 11:31 AM, Alexey Proskuryakova...@webkit.org wrote:
As an aside, is there any practical difference between static const and
const in C++? The only difference I'm aware of is that the former is
On Mon, Aug 31, 2009 at 6:44 PM, Dimitri Glazkov dglaz...@google.comwrote:
Having said that, I do think the global script object idea is a bad idea.
I am not convinced it's awesome either. But thought the same (and
still do) about HTML5 database, and yet here it is in the standard :)
On Fri, Aug 28, 2009 at 12:14 PM, George Staikos stai...@kde.org wrote:
The development of Iris Browser for Windows CE has been suspended, but we
still plan to contribute to WebKit as a project and this does not preclude
working on code specific to a given port. I think there is clearly
On Wed, Aug 26, 2009 at 3:04 PM, Michelangelo De Simone
micde...@gmail.comwrote:
speaking about type=email a UI element which fetches
email addresses from user's address book seems a happy choice to me.
Consider that if the user uses a web mail app (e.g. Gmail) the UA will have
no way of
On Wed, Aug 26, 2009 at 3:49 PM, Anthony Ricaud rik...@gmail.com wrote:
For other types (email, tel, url), sure, authors can't implement anything
similar. But they can style them differently, offer indications on how to
fill them, etc. One of the reason to use new input types in HTML5 is that
On Wed, Aug 26, 2009 at 5:44 PM, Maciej Stachowiak m...@apple.com wrote:
Another possibility is to have a review site (bugzilla?) be the canonical
place for log entries until they get committed. At commit time, a tool would
pull from this location.
This is probably the closest analog to how
On Thu, Aug 20, 2009 at 10:52 PM, Ryosuke Niwa rn...@google.com wrote:
I realized that all patches I submitted in the past 17 hours were lost as
well.
Yes; patches that landed in the tree are still landed (although their bugs
may have risen zombie-like from the grave) since the SVN repo was
On Thu, Aug 13, 2009 at 12:09 PM, Drew Wilson atwil...@google.com wrote:
WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const)
JSC::evaluate(JSC::ExecState*, JSC::ScopeChain, JSC::SourceCode const,
JSC::JSValue)
WTF::PassRefPtrJSC::ProgramNode
On Wed, Aug 12, 2009 at 10:21 PM, Adam Barth aba...@webkit.org wrote:
On Wed, Aug 12, 2009 at 10:10 PM, Joe Masonjoe.ma...@torchmobile.com
wrote:
Shouldn't buildbots always be doing a from-scratch build to ensure a
clean
environment anyway?
My experience is that most buildbots do
On Mon, Aug 10, 2009 at 10:28 AM, Peter Kasting pkast...@google.com wrote:
On Mon, Aug 10, 2009 at 10:27 AM, Darin Adler da...@apple.com wrote:
$ resolve-ChangeLogs WebCore/ChangeLog
svn: warning:
'../../../../Volumes/Home/darin/Safari/OpenSource/WebCore/ChangeLog' is not
a working copy
On Mon, Aug 10, 2009 at 10:55 AM, Darin Adler da...@apple.com wrote:
On Aug 10, 2009, at 10:53 AM, Peter Kasting wrote:
Try changing the last line of canonicalRelativePath() from:
return File::Spec-abs2rel($absolutePath);
to
return File::Spec-abs2rel($absolutePath, Cwd::getcwd
101 - 200 of 266 matches
Mail list logo
