Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-08 Thread Bruno Abinader
Hi again, Just to inform I've carefully followed the guidelines from Ryosuke as well as other reviewers, and also people from www-style (regarding "blink" value). The following patches are now pending review: -webkit-text-decoration-line: https://bugs.webkit.org/show_bug.cgi?id=90959 -webkit-tex

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-02 Thread Ryosuke Niwa
On Thu, Aug 2, 2012 at 9:43 PM, Bruno Abinader wrote: > > On Thu, Aug 2, 2012 at 6:10 PM, Ryosuke Niwa wrote: > > Does the spec require to return new values in the computed style of > > text-decoration property without authors specifying new text-decoration > > properties and values? > > > > If n

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-02 Thread Bruno Abinader
Hi again, On Thu, Aug 2, 2012 at 6:10 PM, Ryosuke Niwa wrote: > Does the spec require to return new values in the computed style of > text-decoration property without authors specifying new text-decoration > properties and values? > > If not, then using text-decoration property is probably better

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-02 Thread Bruno Abinader
Hi again, I too think so, but I thought it was a general rule to not make non-prefixed properties follow candidate recommendation strictly. If it is a general consensus that it is ok to accept prefixed keywords, then I'll happily change the implementation to do so :) On Wed, Aug 1, 2012 at 9:53 P

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-01 Thread Maciej Stachowiak
On Aug 1, 2012, at 4:36 PM, Elliott Sprehn wrote: > > On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader > wrote: > Hi all :) > > As suggested by Ojan, I am writing a mail to you about my intention to > implement all updated and missing text-decoration* properties from > CSS3 spec (currently in

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-01 Thread Bruno Abinader
Hi Elliott, On Wed, Aug 1, 2012 at 7:36 PM, Elliott Sprehn wrote: > It seems weird to have a prefixed version of text-decoration instead of just > making text-decoration allow the new prefixed keywords. > > What's the reason for having a whole new prefixed property? The rationale is that the CSS

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-01 Thread Elliott Sprehn
On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader wrote: > Hi all :) > > As suggested by Ojan, I am writing a mail to you about my intention to > implement all updated and missing text-decoration* properties from > CSS3 spec (currently in development), named below: > > -webkit-text-decoration ( http

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-01 Thread Ryosuke Niwa
Sure, that's fine. But please make sure not to ship these CSS properties until editing code is properly fixed. On Wed, Aug 1, 2012 at 4:47 AM, Bruno Abinader wrote: > Hi Ryosuke, > > Indeed. On the proposed implementation I've assured that the original > "text-decoration" from CSS 2.1 spec remai

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-01 Thread Bruno Abinader
Hi Ryosuke, Indeed. On the proposed implementation I've assured that the original "text-decoration" from CSS 2.1 spec remains with exactly same behavior as before (though I've managed to get some shared code to avoid duplication). Layout tests results from my local run points no new failing tests

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-07-31 Thread Ryosuke Niwa
Please make sure the new text decoration values don't break editing (rich text editing & execCommand). In particular, we probably need to update ApplyStyleCommand/EditingStyle to handle -webkit-text-decoration*. On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader wrote: > Hi all :) > > As suggested b

[webkit-dev] Add support for CSS3 text-decoration* properties

2012-07-31 Thread Bruno Abinader
Hi all :) As suggested by Ojan, I am writing a mail to you about my intention to implement all updated and missing text-decoration* properties from CSS3 spec (currently in development), named below: -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 ) CSS3 dev spec: http://de