Re: [webkit-dev] Build system update

2011-04-25 Thread Nico Weber
On Fri, Mar 25, 2011 at 10:59 AM, Maciej Stachowiak m...@apple.com wrote: In addition to your comments, I also find the gyp syntax somewhat unpleasant. In particular, in .gypi lists of files to compile, ever entry is double-quoted, comma-separated, line-separated, and then grouped in

Re: [webkit-dev] Build system update

2011-03-25 Thread Dirk Pranke
Hi Brent, I definitely agree that gyp is rather undocumented and kind of hard to use. It's nowhere near the level of documentation of CMake, let alone Xcode or GNU makefiles. Hopefully we can fix this in the near future. That said, I'd be kind of surprised if cmake was already installed on your

Re: [webkit-dev] Build system update

2011-03-25 Thread Maciej Stachowiak
In addition to your comments, I also find the gyp syntax somewhat unpleasant. In particular, in .gypi lists of files to compile, ever entry is double-quoted, comma-separated, line-separated, and then grouped in multiple levels of braces. This is noisier than any of our current formats except

Re: [webkit-dev] Build system update

2011-03-24 Thread Adam Barth
On Wed, Mar 23, 2011 at 8:46 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 23, 2011, at 3:33 AM, Adam Barth wrote: From my perspective, approach (2) is more desirable than checking in generated project files because approach (2) encapsulates Apple-internal build process to Apple folks,

Re: [webkit-dev] Build system update

2011-03-24 Thread Maciej Stachowiak
On Mar 24, 2011, at 12:28 AM, Adam Barth wrote: On Wed, Mar 23, 2011 at 8:46 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 23, 2011, at 3:33 AM, Adam Barth wrote: From my perspective, approach (2) is more desirable than checking in generated project files because approach (2)

Re: [webkit-dev] Build system update

2011-03-24 Thread Dimitri Glazkov
First, let me warm the tone of this thread a bit with an earnest salute to Adam for trying to solve the problem by actually doing _something_, rather than talking about it, as we've done for years now. My own contributions to the matter are small and insignificant in comparison. To recall, we do

Re: [webkit-dev] Build system update

2011-03-24 Thread Brent Fulgham
Hi Dimitri, LONG screed follows... On Mar 24, 2011, at 9:24 AM, Dimitri Glazkov wrote: \With the gyp conversion at this stage, we now have a possible solution to this problem. Given that there aren't any other viable alternatives in the present, please consider the most productive way of

Re: [webkit-dev] Build system update

2011-03-23 Thread Mark Rowe
On 2011-03-23, at 03:33, Adam Barth wrote: On Wed, Mar 23, 2011 at 12:22 AM, Mark Rowe mr...@apple.com wrote: On 2011-03-22, at 23:50, Adam Barth wrote: On Tue, Mar 22, 2011 at 8:14 PM, Mark Rowe mr...@apple.com wrote: Product names for targets are redundantly declared in the Xcode project

Re: [webkit-dev] Build system update

2011-03-23 Thread David Levin
On Wed, Mar 23, 2011 at 3:33 AM, Adam Barth aba...@webkit.org wrote: On Wed, Mar 23, 2011 at 12:22 AM, Mark Rowe mr...@apple.com wrote: In any case, I'm glad we've found a technically feasible solution. We've had at least one technically feasible solution from day zip: check in the

Re: [webkit-dev] Build system update

2011-03-23 Thread Adam Barth
On Wed, Mar 23, 2011 at 1:33 PM, David Levin le...@google.com wrote: On Wed, Mar 23, 2011 at 12:17 PM, Adam Barth aba...@webkit.org wrote: $ time git svn rebase [... update my working copy from changes during lunch (four revisions) ...] real    1m10.316s user    0m8.194s sys     0m16.400s

Re: [webkit-dev] Build system update

2011-03-23 Thread Mark Rowe
On 2011-03-23, at 13:49, Adam Barth wrote: On Wed, Mar 23, 2011 at 1:33 PM, David Levin le...@google.com wrote: On Wed, Mar 23, 2011 at 12:17 PM, Adam Barth aba...@webkit.org wrote: $ time git svn rebase [... update my working copy from changes during lunch (four revisions) ...] real

Re: [webkit-dev] Build system update

2011-03-23 Thread Adam Barth
On Wed, Mar 23, 2011 at 1:58 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-23, at 13:49, Adam Barth wrote: On Wed, Mar 23, 2011 at 1:33 PM, David Levin le...@google.com wrote: On Wed, Mar 23, 2011 at 12:17 PM, Adam Barth aba...@webkit.org wrote: $ time git svn rebase [... update my working

Re: [webkit-dev] Build system update

2011-03-23 Thread Peter Kasting
On Wed, Mar 23, 2011 at 2:08 PM, Adam Barth aba...@webkit.org wrote: Indeed. I suspect (2) and (3) are worth doing regardless. AFAIK, gyp currently always regenerates everything and then compares the new versions to the old to see if it actually needs to touch the files on disk. This seems

Re: [webkit-dev] Build system update

2011-03-23 Thread Adam Barth
On Wed, Mar 23, 2011 at 2:13 PM, Peter Kasting pkast...@chromium.org wrote: On Wed, Mar 23, 2011 at 2:08 PM, Adam Barth aba...@webkit.org wrote: Indeed.  I suspect (2) and (3) are worth doing regardless. AFAIK, gyp currently always regenerates everything and then compares the new versions to

Re: [webkit-dev] Build system update

2011-03-23 Thread Dirk Pranke
On Wed, Mar 23, 2011 at 1:33 PM, David Levin le...@google.com wrote: On Wed, Mar 23, 2011 at 12:17 PM, Adam Barth aba...@webkit.org wrote: $ time git svn rebase [... update my working copy from changes during lunch (four revisions) ...] real    1m10.316s user    0m8.194s sys    

Re: [webkit-dev] Build system update

2011-03-23 Thread Maciej Stachowiak
On Mar 23, 2011, at 3:33 AM, Adam Barth wrote: While this is certainly technically feasible, it would add a huge amount of overhead to the process of performing a submission. How often do you submit WebKit to the Apple internal build system? If that's sensitive information, I'm just

Re: [webkit-dev] Build system update

2011-03-22 Thread Mark Rowe
On 2011-03-22, at 19:16, Adam Barth wrote: WebKit-folk, With a bunch of help from Dimitri and Eric, we now have a functioning GYP-based build for the Apple Mac port. There are still a couple bugs we need to fix before this build system is ready for production (they're filed as blocking

Re: [webkit-dev] Build system update

2011-03-22 Thread Eric Seidel
On Tue, Mar 22, 2011 at 8:14 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-22, at 19:16, Adam Barth wrote: WebKit-folk, With a bunch of help from Dimitri and Eric, we now have a functioning GYP-based build for the Apple Mac port.  There are still a couple bugs we need to fix before this

Re: [webkit-dev] Build system update

2011-03-22 Thread Mark Rowe
On 2011-03-22, at 21:28, Eric Seidel wrote: On Tue, Mar 22, 2011 at 8:14 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-22, at 19:16, Adam Barth wrote: WebKit-folk, With a bunch of help from Dimitri and Eric, we now have a functioning GYP-based build for the Apple Mac port. There