Ryosuke Niwa írta:
Well, providing details in the bug would essentially email the author &
the reviewer since they're auto cc'ed. I agree commenting on the
Bugzilla is better so that others could follow.
No, reviewers aren't auto cc'ed to bugs if they only used "review patch"
and they wasn't
> My strong preference is immediate reaction. It doesn't always have to be a
> rollout, sometimes an issue can be fixed, or some tests can even be
> temporarily skipped - just make the tree green and stable for everyone else,
> as quickly as possible. But if the author is not available, and the
(re-sent from correct address)
11 июля 2014 г., в 3:59, Maciej Stachowiak написал(а):
> So it seems like the extra request for people using “webkitbot rollout” is to
> add diagnostic information to the rollout bug, and wait a reasonable period
> before cq+ing it. Is that something everyone cou
> On Jul 9, 2014, at 7:46 PM, Ryosuke Niwa wrote:
>
> On Wed, Jul 9, 2014 at 7:25 PM, Maciej Stachowiak wrote:
>
> What things need to be done in addition to using 'webkitbot rollout’ to meet
> a sufficient standard of notification? I assume based on your comments that
> it should:
>
> (1)
On Wed, Jul 9, 2014 at 7:25 PM, Maciej Stachowiak wrote:
>
> On Jul 9, 2014, at 4:45 PM, Ryosuke Niwa wrote:
>
> On Wednesday, July 9, 2014, Brady Eidson wrote:
>
>>
>> On Jul 9, 2014, at 4:15 PM, Ryosuke Niwa wrote:
>>
>> Again, im not requesting anything new here. The consensus on webkit-de
On Wed, Jul 9, 2014 at 5:05 PM, Brady Eidson wrote:
> On Jul 9, 2014, at 4:45 PM, Ryosuke Niwa wrote:
>
> Since webkitbot doesn't automatically post the details as to what failures
> the patch caused, and one line description is almost never adequate (e.g.
> needs a hyperlink to buildbot page, t
> On Jul 9, 2014, at 4:45 PM, Ryosuke Niwa wrote:
>
> On Wednesday, July 9, 2014, Brady Eidson wrote:
>
>> On Jul 9, 2014, at 4:15 PM, Ryosuke Niwa wrote:
>>
>> Again, im not requesting anything new here. The consensus on webkit-dev has
>> been to ping the author/reviewer on IRC or via ema
> On Jul 9, 2014, at 4:45 PM, Ryosuke Niwa wrote:
>
> On Wednesday, July 9, 2014, Brady Eidson wrote:
>
>> On Jul 9, 2014, at 4:15 PM, Ryosuke Niwa wrote:
>>
>> Again, im not requesting anything new here. The consensus on webkit-dev has
>> been to ping the author/reviewer on IRC or via ema
On Wednesday, July 9, 2014, Brady Eidson wrote:
>
> On Jul 9, 2014, at 4:15 PM, Ryosuke Niwa > wrote:
>
> Again, im not requesting anything new here. The consensus on webkit-dev
> has been to ping the author/reviewer on IRC or via email and comment in the
> original bug PRIOR to using webkitbot
> On Jul 9, 2014, at 4:15 PM, Ryosuke Niwa wrote:
>
> Again, im not requesting anything new here. The consensus on webkit-dev has
> been to ping the author/reviewer on IRC or via email and comment in the
> original bug PRIOR to using webkitbot to start reverting the patch.
I went through the
On Wednesday, July 9, 2014, Ryosuke Niwa wrote:
>
> On Wednesday, July 9, 2014, Brady Eidson > wrote:
>
>>
>> On Jul 9, 2014, at 1:43 PM, Ryosuke Niwa wrote:
>>
>>
>> When the bug for a rollout is created, the original bug is automatically
>>> reopened.
>>>
>>>
>>> Which makes sense when a patc
On Wednesday, July 9, 2014, Brady Eidson wrote:
>
> On Jul 9, 2014, at 1:43 PM, Ryosuke Niwa > wrote:
>
>
> When the bug for a rollout is created, the original bug is automatically
>> reopened.
>>
>>
>> Which makes sense when a patch breaks something, whether the resolution
>> is the author foll
> On Jul 9, 2014, at 1:43 PM, Ryosuke Niwa wrote:
>> When the bug for a rollout is created, the original bug is automatically
>> reopened.
>
> Which makes sense when a patch breaks something, whether the resolution is
> the author following up with a fix *or* the rollout committing.’
>
> Thi
> On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa wrote:
>
> When the bug for a rollout is created, the original bug is automatically
> reopened.
This is a long-standing bug in the bot. The original bug should not be reopened
until the change that fixed it is reverted.
__
On Wed, Jul 9, 2014 at 1:44 PM, Simon Fraser wrote:
>
> On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa wrote:
>
> On Wed, Jul 9, 2014 at 1:08 PM, Brady Eidson wrote:
>
>>
>> On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa wrote:
>>
>> On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton
>> wrote:
>>
>>>
>>> On Ju
On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa wrote:
> On Wed, Jul 9, 2014 at 1:08 PM, Brady Eidson wrote:
>
>> On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa wrote:
>>
>> On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton wrote:
>>
>>> On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak wrote:
>>>
>>>
>>> C
On Wed, Jul 9, 2014 at 1:35 PM, Brady Eidson wrote:
>
> On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa wrote:
>
> On Wed, Jul 9, 2014 at 1:08 PM, Brady Eidson wrote:
>
>>
>> On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa wrote:
>>
>> On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton
>> wrote:
>>
>>>
>>> On Ju
> On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa wrote:
>
> On Wed, Jul 9, 2014 at 1:08 PM, Brady Eidson wrote:
>
>> On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa wrote:
>>
>> On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton wrote:
>>
>>> On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak wrote:
>>>
>>>
>
On Wed, Jul 9, 2014 at 1:08 PM, Brady Eidson wrote:
>
> On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa wrote:
>
> On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton
> wrote:
>
>>
>> On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak wrote:
>>
>>
>> Could we teach webkitbot to do an appropriate notification wi
> On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa wrote:
>
> On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton wrote:
>
>> On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak wrote:
>>
>>
>> Could we teach webkitbot to do an appropriate notification with a waiting
>> period? Either as part of rollout or ad
On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton
wrote:
>
> On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak wrote:
>
>
> Could we teach webkitbot to do an appropriate notification with a waiting
> period? Either as part of rollout or add a new command to do it.
>
>
> It already does. The "waiting peri
> On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak wrote:
>
>
> Could we teach webkitbot to do an appropriate notification with a waiting
> period? Either as part of rollout or add a new command to do it.
It already does. The “waiting period” is defined by when the person who asked
for the rol
Could we teach webkitbot to do an appropriate notification with a waiting
period? Either as part of rollout or add a new command to do it.
- Maciej
> On Jul 9, 2014, at 11:40 AM, Ryosuke Niwa wrote:
>
> Yes. The point is to do these things before telling webkitbot to rollout a
> patch.
>
With any waiting period before actually rolling out?
Simon
On Jul 9, 2014, at 11:40 AM, Ryosuke Niwa wrote:
> Yes. The point is to do these things before telling webkitbot to rollout a
> patch.
>
> - R. Niwa
>
>
> On Wed, Jul 9, 2014 at 11:07 AM, Simon Fraser wrote:
> On Jul 9, 2014, at 7
Yes. The point is to do these things before telling webkitbot to rollout a
patch.
- R. Niwa
On Wed, Jul 9, 2014 at 11:07 AM, Simon Fraser
wrote:
> On Jul 9, 2014, at 7:43 AM, Ryosuke Niwa wrote:
>
> Hi all,
>
> This is a friendly remainder that you should
>
>- comment on the associated b
On Jul 9, 2014, at 7:43 AM, Ryosuke Niwa wrote:
> Hi all,
>
> This is a friendly remainder that you should
> comment on the associated bug
> email the patch author and the reviewer who reviewed the patch
> before rolling out / reverting a patch.
If you use webkitbot to roll out, is this necessa
Hi all,
This is a friendly remainder that you should
- comment on the associated bug
- email the patch author and the reviewer who reviewed the patch
before rolling out / reverting a patch.
- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.
27 matches
Mail list logo
