Re: [webkit-dev] Formatting style for inline comments in Python code

2017-11-03 Thread Aakash Jain
> On Nov 3, 2017, at 9:20 AM, Maciej Stachowiak wrote: > > > >> On Nov 3, 2017, at 8:59 AM, Aakash Jain > > wrote: >> >> >> >>> On Nov 2, 2017, at 8:45 PM, Maciej Stachowiak >>

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-11-03 Thread Maciej Stachowiak
> On Nov 3, 2017, at 8:59 AM, Aakash Jain wrote: > > > >> On Nov 2, 2017, at 8:45 PM, Maciej Stachowiak > > wrote: >> >> >> >>> On Nov 2, 2017, at 5:41 PM, Aakash Jain >>

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-11-03 Thread Aakash Jain
> On Nov 2, 2017, at 8:45 PM, Maciej Stachowiak wrote: > > > >> On Nov 2, 2017, at 5:41 PM, Aakash Jain > > wrote: >> >> >> >>> On Oct 26, 2017, at 10:21 AM, Maciej Stachowiak >>

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-11-02 Thread Maciej Stachowiak
> On Nov 2, 2017, at 5:41 PM, Aakash Jain wrote: > > > >> On Oct 26, 2017, at 10:21 AM, Maciej Stachowiak > > wrote: >> >> >> >>> On Oct 26, 2017, at 10:20 AM, Eric Carlson >>

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-11-02 Thread Aakash Jain
> On Oct 26, 2017, at 10:21 AM, Maciej Stachowiak wrote: > > > >> On Oct 26, 2017, at 10:20 AM, Eric Carlson > > wrote: >> >> >> >>> On Oct 26, 2017, at 9:50 AM, Brian Burg >>

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-26 Thread Ryosuke Niwa
On Thu, Oct 26, 2017 at 11:05 AM, Alexey Proskuryakov wrote: > > > 26 окт. 2017 г., в 9:50, Brian Burg написал(а): > > why differ from the vast majority of all other Python code in existence, > just to be different? What's the point? > > > My point is that

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-26 Thread Alexey Proskuryakov
> 26 окт. 2017 г., в 9:50, Brian Burg написал(а): > > why differ from the vast majority of all other Python code in existence, just > to be different? What's the point? My point is that people familiar with all other Python code in existence will not be hacking on

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-26 Thread Maciej Stachowiak
> On Oct 26, 2017, at 10:20 AM, Eric Carlson wrote: > > > >> On Oct 26, 2017, at 9:50 AM, Brian Burg > > wrote: >> >> >> >>> 2017/10/26 午前9:21、Alexey Proskuryakov >> >のメール: >>>

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-26 Thread Eric Carlson
> On Oct 26, 2017, at 9:50 AM, Brian Burg wrote: > > > >> 2017/10/26 午前9:21、Alexey Proskuryakov > >のメール: >> >> >> >>> 25 окт. 2017 г., в 18:21, Michael Catanzaro >> >

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-26 Thread Brian Burg
> 2017/10/26 午前9:21、Alexey Proskuryakov のメール: > > > >> 25 окт. 2017 г., в 18:21, Michael Catanzaro > > написал(а): >> >> On Wed, Oct 25, 2017 at 4:58 PM, Aakash Jain >

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-26 Thread Alexey Proskuryakov
> 25 окт. 2017 г., в 18:21, Michael Catanzaro > написал(а): > > On Wed, Oct 25, 2017 at 4:58 PM, Aakash Jain wrote: >> Does anyone else has any opinion/preference for this? > > The number of spaces before a comment really does not matter, but my

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-25 Thread Michael Catanzaro
On Wed, Oct 25, 2017 at 4:58 PM, Aakash Jain wrote: Does anyone else has any opinion/preference for this? The number of spaces before a comment really does not matter, but my $0.02: PEP8 is an extremely common style for Python programs that all Python developers are

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-25 Thread Aakash Jain
As Ryosuke said, we can modify check-webkit-style and in-fact I will update that if we decide to use Webkit style for this case. Does anyone else has any opinion/preference for this? Thanks Aakash > On Oct 25, 2017, at 12:22 PM, Brian Burg wrote: > > In this case, I always

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-25 Thread Ryosuke Niwa
On Wed, Oct 25, 2017 at 12:22 PM, Brian Burg wrote: > In this case, I always prefer the PEP8 rules, because check-webkit-style > will complain if you don't do so. > > Brian > It's not like we can't fix the style checker. We also follow the usual WebKit style guidelines in other

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-25 Thread Ryosuke Niwa
We should probably use one space to be consistent across the project. - R. Niwa On Wed, Oct 25, 2017 at 12:13 PM, Aakash Jain wrote: > Hi All, > > There is one case in which Webkit style guidelines and Python style > guidelines do not match. This is about spacing before

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-25 Thread Brian Burg
In this case, I always prefer the PEP8 rules, because check-webkit-style will complain if you don't do so. Brian > 2017/10/25 午後0:13、Aakash Jain のメール: > > Hi All, > > There is one case in which Webkit style guidelines and Python style > guidelines do not match. This is

[webkit-dev] Formatting style for inline comments in Python code

2017-10-25 Thread Aakash Jain
Hi All, There is one case in which Webkit style guidelines and Python style guidelines do not match. This is about spacing before inline comments. WebKit style guidelines (https://webkit.org/code-style-guidelines/#comments-eol ) says: