Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-31 Thread Maciej Stachowiak
On Dec 29, 2010, at 9:35 PM, Adam Barth wrote: On Mon, Dec 27, 2010 at 1:28 PM, Adam Barth aba...@webkit.org wrote: On Mon, Dec 27, 2010 at 1:25 PM, Darin Adler da...@apple.com wrote: On Dec 27, 2010, at 11:14 AM, Adam Barth wrote: On Mon, Dec 27, 2010 at 10:37 AM, Mark Rowe mr...@apple.com

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-29 Thread Adam Barth
On Mon, Dec 27, 2010 at 1:28 PM, Adam Barth aba...@webkit.org wrote: On Mon, Dec 27, 2010 at 1:25 PM, Darin Adler da...@apple.com wrote: On Dec 27, 2010, at 11:14 AM, Adam Barth wrote: On Mon, Dec 27, 2010 at 10:37 AM, Mark Rowe mr...@apple.com wrote: Can someone also elaborate on why Sources

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-28 Thread Antonio Gomes
I filed a meta bug for tracking the layering violation. https://bugs.webkit.org/show_bug.cgi?id=51662 It would be great if anyone added dependent bugs for this. There is a bug about it ( https://bugs.webkit.org/show_bug.cgi?id=21354 ) and it already has a better-filed dependency list. --

[webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Adam Barth
Here's a snapshot of my current thinking on where the files and folders currently in the top-level directory might go. There are a bunch of build-system related files that are currently in the root. I'm not sure whether we should leave them in there or move them into Sources somewhere. I'm

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Kenneth Rohde Christiansen
So we have PerformanceTests, RegressionTests and manual. Why not ManualTests? Is it really a good idea to move platform out of WebCore? Lots of stuff there seems quite WebCore related. Cheers Kenneth On Mon, Dec 27, 2010 at 9:04 AM, Adam Barth aba...@webkit.org wrote: Here's a snapshot of my

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Hajime Morita
Hi, thank you for leading the reorg. Sources/  automake/  cmake/  JavaScriptCore/  JavaScriptGlue/  Platform/ (was WebCore/platform) I'd like to keep platform directory under WebCore if there is no strong reason. Classes under WebCore/platform have WebCore namespace, and the boundary

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Patrick Gansterer
Hi, also thank you for leading the reorg. Adam Barth: Here's a snapshot of my current thinking on where the files and folders currently in the top-level directory might go. There are a bunch of build-system related files that are currently in the root. I'm not sure whether we should

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Zoltan Herczeg
Like it. I only have a few questions: * Where would the build (WebKitBuild) directory would go? Perhaps a Build/ would fit in the root directory. * Some manual-tests belong to the regression tests, and some are belong to the performance test. Would be good to separate them. * I think the build

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Mark Rowe
On 2010-12-27, at 10:19, Mark Rowe wrote: On 2010-12-27, at 00:04, Adam Barth wrote: Here's a snapshot of my current thinking on where the files and folders currently in the top-level directory might go. There are a bunch of build-system related files that are currently in the root.

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Adam Barth
Thanks fora ll your feedback. Responses inline. On Mon, Dec 27, 2010 at 2:06 AM, Kenneth Rohde Christiansen kenneth.christian...@gmail.com wrote: So we have PerformanceTests, RegressionTests and manual. Why not ManualTests? My thought process was that these are manual regression tests, just

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Kenneth Rohde Christiansen
Got it. I didn't notice that manual was a sub directory. Kenneth On Mon, Dec 27, 2010 at 8:14 PM, Adam Barth aba...@webkit.org wrote: Thanks fora ll your feedback. Responses inline. On Mon, Dec 27, 2010 at 2:06 AM, Kenneth Rohde Christiansen kenneth.christian...@gmail.com wrote: So we

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Sam Weinig
On Mon, Dec 27, 2010 at 11:14 AM, Adam Barth aba...@webkit.org wrote: Is it really a good idea to move platform out of WebCore? Lots of stuff there seems quite WebCore related. There seem to be a couple people who aren't sold on moving platform out of WebCore. It sounds like we should

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Darin Adler
On Dec 27, 2010, at 11:14 AM, Adam Barth wrote: On Mon, Dec 27, 2010 at 10:37 AM, Mark Rowe mr...@apple.com wrote: Can someone also elaborate on why Sources was chosen as the top-level directory name rather than Source? Source code is a mass noun so it's unclear why the abbreviated form of

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Adam Barth
On Mon, Dec 27, 2010 at 1:25 PM, Darin Adler da...@apple.com wrote: On Dec 27, 2010, at 11:14 AM, Adam Barth wrote: On Mon, Dec 27, 2010 at 10:37 AM, Mark Rowe mr...@apple.com wrote: Can someone also elaborate on why Sources was chosen as the top-level directory name rather than Source?

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Hajime Morita
I think moving Platform out from WebCore is great long term goal, but right now, there is simply too many layering violations for it to be feasible. For those curious, the intent is for nothing in Platform to be dependent on anything else in WebCore (eg. dom, html, rendering, loader), so

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Maciej Stachowiak
On Dec 27, 2010, at 12:04 AM, Adam Barth wrote: Here's a snapshot of my current thinking on where the files and folders currently in the top-level directory might go. There are a bunch of build-system related files that are currently in the root. I'm not sure whether we should leave them

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread Maciej Stachowiak
On Dec 27, 2010, at 1:11 PM, Sam Weinig wrote: On Mon, Dec 27, 2010 at 11:14 AM, Adam Barth aba...@webkit.org wrote: Is it really a good idea to move platform out of WebCore? Lots of stuff there seems quite WebCore related. There seem to be a couple people who aren't sold on moving

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-27 Thread David Levin
On Mon, Dec 27, 2010 at 7:17 PM, Maciej Stachowiak m...@apple.com wrote: On Dec 27, 2010, at 1:11 PM, Sam Weinig wrote: On Mon, Dec 27, 2010 at 11:14 AM, Adam Barth aba...@webkit.org wrote: Is it really a good idea to move platform out of WebCore? Lots of stuff there seems quite