Going ahead with the land now.
Will be around for several hours fixing builds. I'm sorry for any breaks.
-eric
On Wed, Mar 21, 2012 at 7:08 PM, Eric Seidel e...@webkit.org wrote:
I've posted my first-draft patch to:
https://bugs.webkit.org/show_bug.cgi?id=81844
If port maintainers would
The move appears to be a success.
Mac, CrMac, CrWin, CrLinux, Gtk and Qt are all back building again.
Win, CrAndroid and EFL are in progress.
HUGE thank you to Mark Rowe, Tony Chang, Jessie Berlin, Martin
Robinson, Csaba Osztrogonac, Carlos Garcia Campos, Michael Saboff, and
Filip Pizlo for all
I've posted my first-draft patch to:
https://bugs.webkit.org/show_bug.cgi?id=81844
If port maintainers would like to apply it locally and upload improved
versions (or upload diffs on top of that version) that would be most
welcome.
svn-apply seems to be having trouble with the adds for the WTF
We're ready to complete the move.
https://bugs.webkit.org/show_bug.cgi?id=80911 should land later this
evening, moving JavaScriptCore/wtf/Platform.h to Source/WTF/Platform.h
Tomorrow (Weds) I will move a .cpp file in the same way.
Thursday, I will move all the rest of the WTF files. I will
Hi,
I uploaded the necessary buildfix for Qt to the bugzilla:
https://bugs.webkit.org/show_bug.cgi?id=79783 .
Please be careful with moving JavaScriptCore/wtf to WTF, because we
need zillion trivial fixes for case sensitive file systems. (~4000 files!!!)
I made it locally to be able prepare
I'm going to push off the move, probably until next week.
Thank you for the Qt patch!
I'll post a patch for Mark and we can discuss further from there.
-eric
On Tue, Feb 28, 2012 at 7:38 AM, Osztrogonac Csaba o...@inf.u-szeged.hu wrote:
Hi,
I uploaded the necessary buildfix for Qt to the
On 2012-02-28, at 07:38, Osztrogonac Csaba o...@inf.u-szeged.hu wrote:
Hi,
I uploaded the necessary buildfix for Qt to the bugzilla:
https://bugs.webkit.org/show_bug.cgi?id=79783 .
Please be careful with moving JavaScriptCore/wtf to WTF, because we
need zillion trivial fixes for case
My current plan is to have a WTF/wtf directory to avoid this exact issue. :)
And to avoid the annoyance of 131 files in the root WTF directory.
I'm open to other suggestions if folks have them.
-eric
On Tue, Feb 28, 2012 at 3:59 PM, Mark Rowe mr...@apple.com wrote:
On 2012-02-28, at 07:38,
My current plan is to have a WTF/wtf directory to avoid this exact issue. :)
WTF/wtf makes the think, WTF? -- which is a fun mental onomatopoeia, but
probably not a great design.
Just plain Source/wtf looks better to me.
And to avoid the annoyance of 131 files in the root WTF directory.
I'd
I'm fine with Source/wtf. Very easy to implement.
On Tue, Feb 28, 2012 at 4:59 PM, Geoffrey Garen gga...@apple.com wrote:
My current plan is to have a WTF/wtf directory to avoid this exact issue. :)
WTF/wtf makes the think, WTF? -- which is a fun mental onomatopoeia, but
probably not a
On 2012-02-28, at 17:11, Eric Seidel e...@webkit.org wrote:
I'm fine with Source/wtf. Very easy to implement.
I think this has the potential to cause problems. It would lead to adding the
Source directory to the header search path for some build systems, which would
cause all sorts of
Thank you, particularly to the Qt/Gtk folks who further readied their
ports for this move over the last month.
We're ready to go forward with this.
We will be moving Source/JavaScriptCore/wtf to Source/WTF (and
associated build files) this Wednesday, Feb 27th, 5PM PST.
The move will likely
This will require some coordination to ensure that it doesn't break Apple's
internal builds. It would be great if you could post a patch ahead of time so
that we have some time to test and prepare for the changes on our side.
Thanks,
- Mark
On 2012-02-27, at 15:27, Eric Seidel e...@webkit.org
The patch will be large (and thus likely un-reviewable/readable). But
sure. I'll make sure to have a Mac-only patch for you by EOD
tomorrow.
I'll email this list with a link to the patch.
On Mon, Feb 27, 2012 at 3:43 PM, Mark Rowe mr...@apple.com wrote:
This will require some coordination to
On 2012-02-27, at 15:46, Eric Seidel e...@webkit.org wrote:
The patch will be large (and thus likely un-reviewable/readable). But
sure. I'll make sure to have a Mac-only patch for you by EOD
tomorrow.
Mac-only in what sense? We'd like to ensure it doesn't break our Windows
builds too!
On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel e...@webkit.org wrote:
We've been talking about moving WTF out of JavaScriptCore for a long
time. We believe we're nearly there.
https://bugs.webkit.org/show_bug.cgi?id=75673
This will mean that WTF will be built as a separate static library on all
On Tue, Jan 10, 2012 at 7:07 AM, Alexis Menard
alexis.men...@openbossa.org wrote:
On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel e...@webkit.org wrote:
We've been talking about moving WTF out of JavaScriptCore for a long
time. We believe we're nearly there.
On Tue, Jan 10, 2012 at 5:41 AM, Alexis Menard
alexis.men...@openbossa.orgwrote:
On Tue, Jan 10, 2012 at 7:07 AM, Alexis Menard
alexis.men...@openbossa.org wrote:
On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel e...@webkit.org wrote:
We've been talking about moving WTF out of JavaScriptCore for
If a Qt person wants to make this move even less error-prone for Qt,
adding a newwtf.a library which just builds WTF/Stub.cpp and links it
into JavaScriptCore (similar to what Mac, Gtk, and Chromium do today),
then there won't need to be any guess work on my part when moving
wtf.a I'll have
We've been talking about moving WTF out of JavaScriptCore for a long
time. We believe we're nearly there.
https://bugs.webkit.org/show_bug.cgi?id=75673
This will mean that WTF will be built as a separate static library on all ports.
The plan is to do this move all in one piece, after work hours
Hi Darin,
On Nov 2, 2011, at 4:42 PM, Darin Adler wrote:
On Nov 2, 2011, at 4:09 PM, Mark Rowe wrote:
There are a few related goals here that I'm aware of:
a) Separate WTF out of JavaScriptCore since it doesn't logically belong
there, but was simply a convenient home for it.
b) Separate
On Nov 4, 2011, at 8:48 AM, Kevin Ollivier wrote:
Step (2) here involves coming up with a good solution for export control in
both the WTF and platform cases. Today we use an explicit .exp file for
JavaScriptCore and WebCore on Mac and I believe a .def file in the Apple
Windows WebKit
On 2011-11-04, at 10:57, Kevin Ollivier wrote:
Hi Steve,
On Nov 4, 2011, at 9:12 AM, Steve Falkenburg wrote:
On Nov 4, 2011, at 8:48 AM, Kevin Ollivier wrote:
Step (2) here involves coming up with a good solution for export control
in both the WTF and platform cases. Today we use
Hi Mark,
On Nov 4, 2011, at 10:59 AM, Mark Rowe wrote:
On 2011-11-04, at 10:57, Kevin Ollivier wrote:
Hi Steve,
On Nov 4, 2011, at 9:12 AM, Steve Falkenburg wrote:
On Nov 4, 2011, at 8:48 AM, Kevin Ollivier wrote:
Step (2) here involves coming up with a good solution for export
On Fri, Nov 4, 2011 at 11:12 AM, Kevin Ollivier kev...@theolliviers.com wrote:
So I'm assuming that dynamic library would be JSCore, then? Is the idea
basically just to have a clean separation between WTF and JSCore build
projects?
Yes. Conceptually, WTF is a separate layer from
Mark,
I've created a stub WTF library at
http://trac.webkit.org/browser/trunk/Source/WTF
Would you be willing to create an appropriate xcodeproj file that
builds Stub.h and Stub.cpp (and integrates with whatever magic is
needed internally at Apple)? I'm also happy to attempt webkit.org
side of
On 2011-11-04, at 11:56, Adam Barth wrote:
Mark,
I've created a stub WTF library at
http://trac.webkit.org/browser/trunk/Source/WTF
Would you be willing to create an appropriate xcodeproj file that
builds Stub.h and Stub.cpp (and integrates with whatever magic is
needed internally at
On Fri, Nov 4, 2011 at 12:04 PM, Mark Rowe mr...@apple.com wrote:
On 2011-11-04, at 11:56, Adam Barth wrote:
I've created a stub WTF library at
http://trac.webkit.org/browser/trunk/Source/WTF
Would you be willing to create an appropriate xcodeproj file that
builds Stub.h and Stub.cpp (and
As discussed previously, I think it would benefit the project to move
WTF out of JavaScriptCore:
https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
https://lists.webkit.org/pipermail/webkit-dev/2011-February/015940.html
Previously, we've been unable to do this because of
On Wed, Nov 2, 2011 at 4:23 PM, Adam Barth aba...@webkit.org wrote:
As discussed previously, I think it would benefit the project to move
WTF out of JavaScriptCore:
https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
On 2011-11-02, at 13:23, Adam Barth wrote:
As discussed previously, I think it would benefit the project to move
WTF out of JavaScriptCore:
https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
https://lists.webkit.org/pipermail/webkit-dev/2011-February/015940.html
On Wed, Nov 2, 2011 at 4:09 PM, Mark Rowe mr...@apple.com wrote:
On 2011-11-02, at 13:23, Adam Barth wrote:
As discussed previously, I think it would benefit the project to move
WTF out of JavaScriptCore:
https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
On 2011-11-02, at 16:32, Adam Barth wrote:
On Wed, Nov 2, 2011 at 4:09 PM, Mark Rowe mr...@apple.com wrote:
On 2011-11-02, at 13:23, Adam Barth wrote:
As discussed previously, I think it would benefit the project to move
WTF out of JavaScriptCore:
On Nov 2, 2011, at 4:09 PM, Mark Rowe wrote:
There are a few related goals here that I'm aware of:
a) Separate WTF out of JavaScriptCore since it doesn't logically belong
there, but was simply a convenient home for it.
b) Separate WebCore/platform out of WebCore to help avoid layering
On Nov 2, 2011, at 4:42 PM, Darin Adler wrote:
Step (2) here involves coming up with a good solution for export control in
both the WTF and platform cases. Today we use an explicit .exp file for
JavaScriptCore and WebCore on Mac and I believe a .def file in the Apple
Windows WebKit port.
On 2011-11-02, at 16:42, Darin Adler wrote:
On Nov 2, 2011, at 4:09 PM, Mark Rowe wrote:
There are a few related goals here that I'm aware of:
a) Separate WTF out of JavaScriptCore since it doesn't logically belong
there, but was simply a convenient home for it.
b) Separate
On Wed, Nov 2, 2011 at 4:35 PM, Mark Rowe mr...@apple.com wrote:
On 2011-11-02, at 16:32, Adam Barth wrote:
On Wed, Nov 2, 2011 at 4:09 PM, Mark Rowe mr...@apple.com wrote:
On 2011-11-02, at 13:23, Adam Barth wrote:
As discussed previously, I think it would benefit the project to move
WTF out
On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak m...@apple.com wrote:
On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe mr...@apple.com wrote:
On 2010-12-22, at 10:34, Adam Barth wrote:
As an aside, would creating the Sources directory make it
On 2011-02-09, at 13:06, Adam Barth wrote:
On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak m...@apple.com wrote:
On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe mr...@apple.com wrote:
On 2010-12-22, at 10:34, Adam Barth wrote:
As an aside,
On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe mr...@apple.com wrote:
On 2011-02-09, at 13:06, Adam Barth wrote:
On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak m...@apple.com wrote:
On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe mr...@apple.com
On 2011-02-09, at 14:05, Adam Barth wrote:
On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe mr...@apple.com wrote:
On 2011-02-09, at 13:06, Adam Barth wrote:
On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak m...@apple.com wrote:
On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
On Wed, Dec 22,
On Feb 9, 2011, at 2:08 PM, Mark Rowe wrote:
On 2011-02-09, at 14:05, Adam Barth wrote:
On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe mr...@apple.com wrote:
On 2011-02-09, at 13:06, Adam Barth wrote:
On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak m...@apple.com wrote:
On Dec 22, 2010, at
On 2011-02-09, at 14:51, Kevin Ollivier wrote:
On Feb 9, 2011, at 2:08 PM, Mark Rowe wrote:
On 2011-02-09, at 14:05, Adam Barth wrote:
On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe mr...@apple.com wrote:
On 2011-02-09, at 13:06, Adam Barth wrote:
On Thu, Dec 23, 2010 at 1:32 PM, Maciej
On Feb 9, 2011, at 3:11 PM, Mark Rowe wrote:
On 2011-02-09, at 14:51, Kevin Ollivier wrote:
On Feb 9, 2011, at 2:08 PM, Mark Rowe wrote:
On 2011-02-09, at 14:05, Adam Barth wrote:
On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe mr...@apple.com wrote:
On 2011-02-09, at 13:06, Adam Barth
On 2011-02-09, at 16:21, Kevin Ollivier wrote:
On Feb 9, 2011, at 3:11 PM, Mark Rowe wrote:
On 2011-02-09, at 14:51, Kevin Ollivier wrote:
On Feb 9, 2011, at 2:08 PM, Mark Rowe wrote:
On 2011-02-09, at 14:05, Adam Barth wrote:
On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe
On Feb 9, 2011, at 4:28 PM, Mark Rowe wrote:
On 2011-02-09, at 16:21, Kevin Ollivier wrote:
On Feb 9, 2011, at 3:11 PM, Mark Rowe wrote:
On 2011-02-09, at 14:51, Kevin Ollivier wrote:
On Feb 9, 2011, at 2:08 PM, Mark Rowe wrote:
On 2011-02-09, at 14:05, Adam Barth wrote:
On Thu, Dec 23, 2010 at 3:32 PM, Maciej Stachowiak m...@apple.com wrote:
On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
[Forking the thread]
On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe mr...@apple.com wrote:
On 2010-12-22, at 10:34, Adam Barth wrote:
As an aside, would creating the
On Dec 24, 2010, at 12:37 AM, Eric Seidel wrote:
There may end up being some fancy foot-work in your submission script to
include parts of Tools.
No, we don’t submit anything in Tools as part of Apple build procedures. What
did you have in mind?
-- Darin
Generation code was what first came to mind. I know WebKit2 has its
own set of python code which can't reside in webkitpy due to
submission restrictions. I believe WebCore has its own set of
bindings, make_names, and other CSS generator scripts as well. I
guess all of those could move into
On Dec 24, 2010, at 9:51 AM, Eric Seidel wrote:
I guess all of those could move into Sources/Scripts if Sources becomes the
single directory which is submitted to Apple's build team.
I see what you mean. Good point.
I don’t think we really need to outlaw tools required for the building
On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
[Forking the thread]
On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe mr...@apple.com wrote:
On 2010-12-22, at 10:34, Adam Barth wrote:
As an aside, would creating the Sources directory make it easier to
move WTF out of JavaScriptCore?
I don't
[Forking the thread]
On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe mr...@apple.com wrote:
On 2010-12-22, at 10:34, Adam Barth wrote:
As an aside, would creating the Sources directory make it easier to
move WTF out of JavaScriptCore?
I don't think that the location of the source on disk is a
52 matches
Mail list logo
