2012/11/15 Ryosuke Niwa rn...@webkit.org:
On Thu, Nov 15, 2012 at 4:28 PM, Mike Lawther mikelawt...@google.com
wrote:
On 16 November 2012 09:59, Ryosuke Niwa rn...@webkit.org wrote:
While I don’t want to further agitate the issue or go off on a tangent,
and agree that we must address the
From: ext Ryosuke Niwa rn...@webkit.orgmailto:rn...@webkit.org
r+ and r- flags are supposed to be set only by reviewers. If you wanted to
withdraw your patch from the review queue, then you should be clearing r?
flag, instead of setting r-. If you’re uploading a WIP patch, then it should
Seconded. I also think only the one who submitted the patch can clear
the r? flag. Others should NOT do that, please, even you are a
reviewer. You can r- the patch if you believe it is bad.
I disagree with that. You seem to think that patches falls into either
good or bad. However the reality
On Fri, Nov 16, 2012 at 7:42 AM, Julien Chaffraix
julien.chaffr...@gmail.com wrote:
Seconded. I also think only the one who submitted the patch can clear
the r? flag. Others should NOT do that, please, even you are a
reviewer. You can r- the patch if you believe it is bad.
I disagree with
On Fri, Nov 16, 2012 at 7:16 AM, noam.rosent...@nokia.com wrote:
From: ext Ryosuke Niwa rn...@webkit.org
r+ and r- flags are supposed to be set only by reviewers. If you wanted
to withdraw your patch from the review queue, then you should be clearing
r? flag, instead of setting r-. If
2012/11/16 Julien Chaffraix julien.chaffr...@gmail.com:
Seconded. I also think only the one who submitted the patch can clear
the r? flag. Others should NOT do that, please, even you are a
reviewer. You can r- the patch if you believe it is bad.
I disagree with that. You seem to think that
On 16 November 2012 09:59, Ryosuke Niwa rn...@webkit.org wrote:
While I don’t want to further agitate the issue or go off on a tangent,
and agree that we must address the security aspect before getting rid of
RenderArena, only WebKit reviewers can r- patches written by other
contributors.
On Thu, Nov 15, 2012 at 4:28 PM, Mike Lawther mikelawt...@google.com wrote:
On 16 November 2012 09:59, Ryosuke Niwa rn...@webkit.org wrote:
While I don’t want to further agitate the issue or go off on a tangent,
and agree that we must address the security aspect before getting rid of
On Thu, Nov 15, 2012 at 4:28 PM, Mike Lawther mikelawt...@google.comwrote:
On 16 November 2012 09:59, Ryosuke Niwa rn...@webkit.org wrote:
While I don’t want to further agitate the issue or go off on a tangent,
and agree that we must address the security aspect before getting rid of
On Nov 15, 2012, at 4:56 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Nov 15, 2012 at 4:28 PM, Mike Lawther mikelawt...@google.com wrote:
On 16 November 2012 09:59, Ryosuke Niwa rn...@webkit.org wrote:
While I don’t want to further agitate the issue or go off on a tangent, and
agree
10 matches
Mail list logo
