[webkit-dev] Review states

2009-06-17 Thread Eric Seidel
(Maciej and I chatted about this briefly over IRC a while back.)

I think we need a new r+ state.  Or at least we need more than just r=?, r-, r+.

Why?  Currently r+ means at least 3 things:
1.  Ready to commit if you make some mods and re-post [non-committers]
2.  Ready to commit if you make some mods when you land [committers]
3.  Ready to commit as-is.

I have written a script to handle case 3:
https://bugs.webkit.org/show_bug.cgi?id=26283
But currently I can't just point it at the commit queue and hit go
because there are are r+'d patches which are cases 1 or 2.


I propose altering our bugzilla setup to have the following review
states (effectively adding a 4th state):

review:
REQUESTED
DENIED
APPROVED WITH MODIFICATIONS
APPROVED

I also think making our states have real english names will help new
people to the project.

I could easily make my script download, build, test and commit
everything which was APPROVED.  I could even teach it that similar
patches following an APPROVED WITH MODIFICATIONS patch could be
committed.  I'm hoping to automate more of our process.

I'm very interested in others thoughts on this matter.

-eric
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] ARM JIT and related issues

2009-06-17 Thread Zoltan Herczeg
Hi,

 1) The armv7 port is separate from the armv6 work, and uses the thumb2
 instruction set. Both ports are (I hope!) useful.

We hope it as well.

 2) We would have liked to let the community know about the arm v7 port
 sooner. Unfortunately, we were not at liberty to disclose it until the
 iPhone 3G S announcement. We try to let the community know what we're
 up to and drop code into the public tree as soon as we can, but
 sometimes we are limited by confidentiality constraints.

Corporate secrets are corporate secrects, that is understandable.

 3) We'd definitely like to have a port for pre-v7 ARM in the main
 WebKit tree. I think everyone made this clear.

That is great!

 4) I think it would be good to see if more code and ideas can be
 shared between the two ARM ports. They were made independently, and
 originally in different ways, so let's see what exchange can happen.

Right now the macro-assembler based ARM port is an x86 emulator. It
translates x86 instructions into ARM instruction sequences (usually 1-5
instructions are enough). As ARMv7 port mostly does it, but thumb2 is much
closer to x86 than a RISC architecture (Thumb2 looks like a CISC operation
mode).

 5) Gavin has been a strong proponent of using MacroAssembler as the
 primary CPU abstraction layer, and that approach has worked reasonably
 well so far. However, it seems at least to me that CPUs with very
 different instruction sets may want to do things differently at a
 higher level. x86 is a 2-operand instruction set with optional memory
 operands, and it seems to me a 3-operand load-store architecture might
 want to do things in a different way to get good performance. Making
 them go through a common assembler interface may not work. Ultimately,
 however, the proof is in the performance results. If doing things a
 different way delivers better performance, that is more important than
 maximizing code sharing or architectural purity. That has always been
 the WebKit way.

In case of the ARM-port we have a native implementation and a
MacroAssembler based implementation, and we have already posted
comparisons between them to the bugzilla. Furthermore, we performed some
tests on our XScale simulator, and the native jit'ed code executes 5-40%
less instructions. However, the gain is smaller on the total runtime,
since the jit'ed code takes only a fragment of the total runtime.

Although native jit is faster, we are happy with MacroAssembler as well.

 6) It seems like the intent with the Szeged arm port and the plan for
 getting it in the tree wasn't clear to all parties involved. For me
 personally, it wasn't clear that there was an intent to contribute it,
 or perhaps even an expectation that we'd just pick it up from the
 external repository where it was developed. Things would have been
 more clear if patches were submitted for review earlier.

We know that such big patches requries several refactoring phases before
they go to mainline, that is why we thought it is a good idea to create a
branch on Staikos where you can take a look at them before we flooded the
WebKit bugzilla with patches.

 7) It seems like people said some intemperate things during the
 earlier discussion. It also seems like these remarks were based partly
 on misunderstanding. I hope everyone has gotten past that, and that we
 are all ready to work together productively.

True. I feel the communication between us improved a lot. However, I am
still thinking how can we involve others as well. I am pretty sure not
only us are interested in the design decisions we discuss in bugzilla.
Perhaps squirellfish-dev would be a good place for such discussions.

 8) A number patches from the folks working at University of Szeged
 have been landed. But it seems to me like there has also been a fair
 amount of abandoned work and working at cross purposes. I feel like
 the people working on JavaScript at U of Szeged are not entirely in
 sync with the main JavaScriptCore hackers. You guys have done a lot of
 great work, and I'd like to explore what we can do to get more in sync
 on design direction. Does anyone have suggestions on this front?

Again, this is true. We have no idea what is the general direction of
JavaScriptCore. We can only see landed patches, and predict the ongoing
and future works based on them. However, landed patches are completed
works, and it is usually too late for any contributions when they are
landed. It would be good to discuss things before a work started,
especially design changes, which affects all-ports.

We feel the design dicussions - such it was about ifdefs - would greatly
improve the cooperation between all parties since everybody can feel as a
part of the community.

Thanks,
Zoltan


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread Nevo
From your log : missing pthread.h and uchar.h
 unicode/uchar.h and pthread.h are all located in WebKitSupportLibrary
,which would be extracted to WebKitLibraries under your source root .Check
the build script (I think it's readable enough) .I only built Webkit Win32
port once, saw the similar problem before ,just cannot remember how I fixed
that before . But I do believe  it should not be a serious issue to put you
mad :)



2009/6/17 张雷 zhang@kortide.com.cn


 3正在编译...
 3Assertions.cpp
 3ByteArray.cpp
 3CollatorDefault.cpp
 3d:\WebKit-r41121\JavaScriptCore\wtf/unicode/icu/UnicodeIcu.h(27) : fatal
 error C1083: 无法打开包括文件:“unicode/uchar.h”: No such file or directory
 3CollatorICU.cpp
 3d:\WebKit-r41121\JavaScriptCore\wtf/unicode/icu/UnicodeIcu.h(27) : fatal
 error C1083: 无法打开包括文件:“unicode/uchar.h”: No such file or directory
 3CurrentTime.cpp
 3dtoa.cpp
 3FastMalloc.cpp
 3..\..\wtf\FastMalloc.cpp(82) : fatal error C1083: 无法打开包括文件:“pthread.h”:
 No such file or directory
 3HashTable.cpp
 3项目 : warning PRJ0018 : 未找到下列环境变量:
 3$(PRODUCTION)
 3生成日志保存在“file://D:\WebKit-r41121\Output\obj\WTF\Debug\BuildLog.htm”
 3WTF - 3 个错误,0 个警告

 Building Webkit is a DAYMARE to me, and I'm afraid I cann't survive! Any
 help is appreciated! I've been nearly driven mad!!





 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] WebCore architecture for persistent cache

2009-06-17 Thread Jeremy Serdin
Hi all
I'm trying to implement a persistent cache for WebCore with libcurl.
I'm looking for some documents about webcore architecture in order to
implement it in a right way.
Can somebody help me?

Thx,

jser...@gmail.com
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Review states

2009-06-17 Thread Mark Rowe


On 2009-06-17, at 00:41, Eric Seidel wrote:


I propose altering our bugzilla setup to have the following review
states (effectively adding a 4th state):

review:
REQUESTED
DENIED
APPROVED WITH MODIFICATIONS
APPROVED


I think DENIED could also do with having a hard and soft state.  One  
to indicate that the approach is completely wrong, and another to  
indicate that the approach is sound but it just needs another round of  
improvements and review.


Also, does Bugzilla support custom states for flags?  ISTR that it  
only allows the three states and provides no means of changing their  
names.


- Mark



smime.p7s
Description: S/MIME cryptographic signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Crash on the Mac (RapidWeaver plugin and Safari 4)

2009-06-17 Thread Gilberto De Faveri

I've just reported the bug #26476.

Unfortunately, I was not able to reproduce it outside RapidWeaver  
plugin SDK.


On 12/giu/09, at 16:38, David Kilzer wrote:


Hi Gilberto,

Please file a bug on either https://bugreport.apple.com/ or https://bugs.webkit.org 
 with explicit steps on how to reproduce the crash, then report the  
bug number here.


Thanks!

Dave


--
gilberto de faveri
omnidea srl

edificio pegaso
parco scientifico tecnologico vega
via delle industrie, 15
30175 venezia marghera

tel +39 041 509 3441
fax +39 041 509 3641

www.omnidea.it

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread Ryosuke Niwa
Instead of trying to build from Visual Studio, try
WebKitTools/Scripts/build-webkit --debug on cygwin.
Ryosuke

On Tue, Jun 16, 2009 at 8:55 PM, 张雷 zhang@kortide.com.cn wrote:

  I tried several times, but failed always! God damn!
 I read all the instructions detailedly. These are my steps:

 Note: I already have VS2005 Professional Edition with sp1(Microsoft Visual
 Studio 2005 Team Suite Service Pack 
 1http://www.microsoft.com/downloads/details.aspx?familyid=BB4A75AB-E2D4-4C96-B39D-37BAF6B5B1DCdisplaylang=en)
 patched(But I don't have the other four suggested hotfixes intalled, for
 some reason).

 1)Install Cygwin with Cygwin downloader(All as instructed to do. Use Unix
 style line ending for my Cygwin.).
 2)Installthe QuickTime SDK.
 3)Get source code from Nightly Builds(I tried r41121 and the latest r44697
 but failed building either).
 4)Place WebKit Support 
 Librarieshttp://developer.apple.com/opensource/internet/webkit_sptlib_agree.htmlin
  the root of WebKit soruce tree.
 5)Set WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR
 6)Open WebKit.sln in VS2005 IDE and choose Debug and build solution. Then
 I get error message complainint that cannot open include file
 'unicode/uchar.h'. Detailed log message is as follows(errors are marked
 with red color):

 1-- 已启动生成: 项目: JavaScriptCoreGenerated, 配置: Release Win32 --
 2-- 已启动生成: 项目: record-memory-win, 配置: Release Win32 --
 1正在执行生成文件项目操作
 2正在编译...
 1 xcopy /y/d/e/i ..\..\..\WebKitLibraries\win\tools
 D:\WebKit-r41121\WebKitLibraries\win\tools
 1不能执行周期性复制
 1复制了 0 个文件
 1 touch D:\WebKit-r41121\Output\buildfailed
 1 bash build-generated-files.sh D:\WebKit-r41121\Output
 D:\WebKit-r41121\WebKitLibraries\win
 2main.cpp
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp -i 
 ArrayPrototype.lut.h
 1/cygdrive/d/WEBKIT~1/JAVASC~1/pcre/dftables chartables.c
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp -i 
 DatePrototype.lut.h
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp
 1bison -d -p jscyy /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Grammar.y -o
 Grammar.cpp  bison_out.txt 21
 2正在链接...
 2正在生成代码
 1perl -p -e 'END { if ($conflict) { unlink Grammar.cpp; die; } }
 $conflict ||= /conflict/'  bison_out.txt
 2已完成代码的生成
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table  Lexer.lut.h
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table
 2正在嵌入清单...
 1touch Grammar.cpp.h
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp -i  MathObject.lut.h
 2生成日志保存在“file://D:\WebKit-r41121\Output\obj\record-memory-win\Release\BuildLog.htm”
 2record-memory-win - 0 个错误,0 个警告
 1touch Grammar.hpp
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp
 1cat Grammar.cpp.h Grammar.hpp  Grammar.h
 1rm -f Grammar.cpp.h Grammar.hpp bison_out.txt
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/NumberConstructor.cpp -i 
 NumberConstructor.lut.h
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpConstructor.cpp -i 
 RegExpConstructor.lut.h
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/NumberConstructor.cpp
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpConstructor.cpp
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpObject.cpp -i 
 RegExpObject.lut.h
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpObject.cpp
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/StringPrototype.cpp -i 
 StringPrototype.lut.h
 1perl /cygdrive/d/WEBKIT~1/JAVASC~1/docs/make-bytecode-docs.pl
 /cygdrive/d/WEBKIT~1/JAVASC~1/interpreter/Interpreter.cpp docs/bytecode.html
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/StringPrototype.cpp
 1UNDOCUMENTED: get_by_id_self_list
 1UNDOCUMENTED: get_by_id_proto_list
 1 mkdir 2NUL
 D:\WebKit-r41121\Output\include\JavaScriptCore\JavaScriptCore
 1 xcopy /y /d ..\..\API\APICast.h
 D:\WebKit-r41121\Output\include\JavaScriptCore\JavaScriptCore
 1..\..\API\APICast.h
 1复制了 1 个文件
 1 xcopy /y /d ..\..\API\JavaScript.h
 D:\WebKit-r41121\Output\include\JavaScriptCore\JavaScriptCore
 1..\..\API\JavaScript.h
 1复制了 1 个文件
 1 xcopy /y /d ..\..\API\JSBase.h
 D:\WebKit-r41121\Output\include\JavaScriptCore\JavaScriptCore
 1..\..\API\JSBase.h
 1复制了 1 个文件
 1 xcopy /y /d ..\..\API\JSContextRef.h
 D:\WebKit-r41121\Output\include\JavaScriptCore\JavaScriptCore
 1..\..\API\JSContextRef.h
 1复制了 1 个文件
 1 xcopy /y /d ..\..\API\JSObjectRef.h
 D:\WebKit-r41121\Output\include\JavaScriptCore\JavaScriptCore
 1..\..\API\JSObjectRef.h
 1复制了 1 个文件
 1 xcopy /y /d ..\..\API\JSStringRef.h
 

Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread Takeshi Yoshino
Or just run WebKitTools/Scripts/update-webkit and then
WebKitTools/Scripts/update-webkit-support-libs to fetch and extract both
WebKitAuxiliaryLibrary.zip and WebKitSupportLibrary.zip .
And then you'll be able to build using WebKit/win/WebKit.vcproj/WebKit.sln .

Thanks,

Takeshi


2009/6/17 Ryosuke Niwa rn...@google.com

 You should still be able to use VS.net debugger with it.

 2009/6/17 Ryosuke Niwa rn...@google.com

 Instead of trying to build from Visual Studio, try
 WebKitTools/Scripts/build-webkit --debug on cygwin.
 Ryosuke

 On Tue, Jun 16, 2009 at 8:55 PM, 张雷 zhang@kortide.com.cn wrote:

  I tried several times, but failed always! God damn!
 I read all the instructions detailedly. These are my steps:

 Note: I already have VS2005 Professional Edition with sp1(Microsoft
 Visual Studio 2005 Team Suite Service Pack 
 1http://www.microsoft.com/downloads/details.aspx?familyid=BB4A75AB-E2D4-4C96-B39D-37BAF6B5B1DCdisplaylang=en)
 patched(But I don't have the other four suggested hotfixes intalled, for
 some reason).

 1)Install Cygwin with Cygwin downloader(All as instructed to do. Use Unix
 style line ending for my Cygwin.).
 2)Installthe QuickTime SDK.
 3)Get source code from Nightly Builds(I tried r41121 and the latest
 r44697 but failed building either).
 4)Place WebKit Support 
 Librarieshttp://developer.apple.com/opensource/internet/webkit_sptlib_agree.htmlin
  the root of WebKit soruce tree.
 5)Set WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR
 6)Open WebKit.sln in VS2005 IDE and choose Debug and build solution.
 Then I get error message complainint that cannot open include file
 'unicode/uchar.h'. Detailed log message is as follows(errors are marked
 with red color):

 1-- 已启动生成: 项目: JavaScriptCoreGenerated, 配置: Release Win32 --
 2-- 已启动生成: 项目: record-memory-win, 配置: Release Win32 --
 1正在执行生成文件项目操作
 2正在编译...
 1 xcopy /y/d/e/i ..\..\..\WebKitLibraries\win\tools
 D:\WebKit-r41121\WebKitLibraries\win\tools
 1不能执行周期性复制
 1复制了 0 个文件
 1 touch D:\WebKit-r41121\Output\buildfailed
 1 bash build-generated-files.sh D:\WebKit-r41121\Output
 D:\WebKit-r41121\WebKitLibraries\win
 2main.cpp
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp -i 
 ArrayPrototype.lut.h
 1/cygdrive/d/WEBKIT~1/JAVASC~1/pcre/dftables chartables.c
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp -i 
 DatePrototype.lut.h
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp
 1bison -d -p jscyy /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Grammar.y -o
 Grammar.cpp  bison_out.txt 21
 2正在链接...
 2正在生成代码
 1perl -p -e 'END { if ($conflict) { unlink Grammar.cpp; die; } }
 $conflict ||= /conflict/'  bison_out.txt
 2已完成代码的生成
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table  Lexer.lut.h
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table
 2正在嵌入清单...
 1touch Grammar.cpp.h
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp -i  MathObject.lut.h
 2生成日志保存在“file://D:\WebKit-r41121\Output\obj\record-memory-win\Release\BuildLog.htm”
 2record-memory-win - 0 个错误,0 个警告
 1touch Grammar.hpp
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp
 1cat Grammar.cpp.h Grammar.hpp  Grammar.h
 1rm -f Grammar.cpp.h Grammar.hpp bison_out.txt
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/NumberConstructor.cpp -i 
 NumberConstructor.lut.h
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpConstructor.cpp -i 
 RegExpConstructor.lut.h
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/NumberConstructor.cpp
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpConstructor.cpp
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpObject.cpp -i 
 RegExpObject.lut.h
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpObject.cpp
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/StringPrototype.cpp -i 
 StringPrototype.lut.h
 1perl /cygdrive/d/WEBKIT~1/JAVASC~1/docs/make-bytecode-docs.pl
 /cygdrive/d/WEBKIT~1/JAVASC~1/interpreter/Interpreter.cpp docs/bytecode.html
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/StringPrototype.cpp
 1UNDOCUMENTED: get_by_id_self_list
 1UNDOCUMENTED: get_by_id_proto_list
 1 mkdir 2NUL
 D:\WebKit-r41121\Output\include\JavaScriptCore\JavaScriptCore
 1 xcopy /y /d ..\..\API\APICast.h
 D:\WebKit-r41121\Output\include\JavaScriptCore\JavaScriptCore
 1..\..\API\APICast.h
 1复制了 1 个文件
 1 xcopy /y /d ..\..\API\JavaScript.h
 D:\WebKit-r41121\Output\include\JavaScriptCore\JavaScriptCore
 1..\..\API\JavaScript.h
 1复制了 1 个文件
 1 xcopy /y /d 

Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread 张雷




I tried building from the Cygwin command line with
WebKitTools/Scripts/build-webkit --debug. Buf failed with the same
error message. :(

 原始信息 
主题: Re: [webkit-dev] Help! I can't survive building WebKit in Visual
Studio 2005 IDE!
发件人: Ryosuke Niwa rn...@google.com
收件人: WebKit Development webkit-dev@lists.webkit.org
日期: 2009-6-17 17:26
Instead of trying to build from Visual Studio, try
WebKitTools/Scripts/build-webkit --debug on cygwin.
  
  
  Ryosuke
  
  On Tue, Jun 16, 2009 at 8:55 PM, 张雷 zhang@kortide.com.cn
wrote:
  
I tried several times, but
failed always! God damn!
I read all the instructions detailedly. These are my steps: 

Note: I already have VS2005 Professional Edition with sp1(Microsoft
Visual Studio 2005 Team Suite Service Pack 1) patched(But I don't
have the other four suggested hotfixes intalled, for some reason).

1)Install Cygwin with Cygwin downloader(All as instructed to do. Use
Unix style line ending for my Cygwin.). 
2)Installthe QuickTime SDK.
3)Get source code from Nightly Builds(I tried r41121 and the latest
r44697 but failed building either).
4)Place WebKit
Support Libraries in the root of WebKit soruce tree.
5)Set WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR
6)Open WebKit.sln in VS2005 IDE and choose "Debug" and build solution.
Then I get error message complainint that "cannot open include file
'unicode/uchar.h'". Detailed log message is as follows(errors are
marked with red color):

1-- 已启动生成: 项目: _javascript_CoreGenerated, 配置: Release Win32 --
2-- 已启动生成: 项目: record-memory-win, 配置: Release Win32 --
1正在执行生成文件项目操作
2正在编译...
1 xcopy /y/d/e/i "..\..\..\WebKitLibraries\win\tools"
"D:\WebKit-r41121\WebKitLibraries\win\tools"
1不能执行周期性复制
1复制了 0 个文件
1 touch "D:\WebKit-r41121\Output\buildfailed"
1 bash build-generated-files.sh "D:\WebKit-r41121\Output"
"D:\WebKit-r41121\WebKitLibraries\win"
2main.cpp
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp -i 
ArrayPrototype.lut.h
1/cygdrive/d/WEBKIT~1/JAVASC~1/pcre/dftables chartables.c
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp -i 
DatePrototype.lut.h
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp
1bison -d -p jscyy /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Grammar.y
-o Grammar.cpp  bison_out.txt 21
2正在链接...
2正在生成代码
1perl -p -e 'END { if ($conflict) { unlink "Grammar.cpp"; die; } }
$conflict ||= /conflict/'  bison_out.txt
2已完成代码的生成
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table  Lexer.lut.h
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table
2正在嵌入清单...
1touch Grammar.cpp.h
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp -i 
MathObject.lut.h
2生成日志保存在“file://D:\WebKit-r41121\Output\obj\record-memory-win\
Release\BuildLog.htm”
2record-memory-win - 0 个错误,0 个警告
1touch Grammar.hpp
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp
1cat Grammar.cpp.h Grammar.hpp  Grammar.h
1rm -f Grammar.cpp.h Grammar.hpp bison_out.txt
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/NumberConstructor.cpp -i 
NumberConstructor.lut.h
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpConstructor.cpp -i 
RegExpConstructor.lut.h
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/NumberConstructor.cpp
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpConstructor.cpp
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpObject.cpp -i 
RegExpObject.lut.h
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpObject.cpp
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/StringPrototype.cpp -i 
StringPrototype.lut.h
1perl /cygdrive/d/WEBKIT~1/JAVASC~1/docs/make-bytecode-docs.pl
/cygdrive/d/WEBKIT~1/JAVASC~1/interpreter/Interpreter.cpp
docs/bytecode.html
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/StringPrototype.cpp
1UNDOCUMENTED: get_by_id_self_list
1UNDOCUMENTED: get_by_id_proto_list
1 mkdir 2NUL
"D:\WebKit-r41121\Output\include\_javascript_Core\_javascript_Core"
1 xcopy /y /d "..\..\API\APICast.h"
"D:\WebKit-r41121\Output\include\_javascript_Core\_javascript_Core"
1..\..\API\APICast.h
1复制了 1 个文件
1 xcopy /y /d "..\..\API\_javascript_.h"
"D:\WebKit-r41121\Output\include\_javascript_Core\_javascript_Core"
1..\..\API\_javascript_.h
1复制了 1 个文件
1 xcopy /y /d "..\..\API\JSBase.h"
"D:\WebKit-r41121\Output\include\_javascript_Core\_javascript_Core"
1..\..\API\JSBase.h
1复制了 1 个文件
1 xcopy /y /d "..\..\API\JSContextRef.h"
"D:\WebKit-r41121\Output\include\_javascript_Core\_javascript_Core"
1..\..\API\JSContextRef.h
1复制了 1 个文件
1 xcopy /y /d 

[webkit-dev] 答复: Help! I can't survive b uilding WebKit in Visual Studio 2005 ID E!

2009-06-17 Thread canquan.shencq
Please run update-webkit at first.

 

Btw: please join in qq group:8763622 

 

  _  

发件人: webkit-dev-boun...@lists.webkit.org
[mailto:webkit-dev-boun...@lists.webkit.org] 代表 张雷
发送时间: 2009年6月17日 18:05
收件人: Ryosuke Niwa
抄送: WebKit Development
主题: Re: [webkit-dev] Help! I can't survive building WebKit in Visual
Studio 2005 IDE!

 

I tried building from the Cygwin command line with
WebKitTools/Scripts/build-webkit --debug. Buf failed with the same error
message. :(

 原始信息 
主题: Re: [webkit-dev] Help! I can't survive building WebKit in Visual
Studio 2005 IDE!
发件人: Ryosuke Niwa  mailto:rn...@google.com rn...@google.com
收件人: WebKit Development  mailto:webkit-dev@lists.webkit.org
webkit-dev@lists.webkit.org
日期: 2009-6-17 17:26



Instead of trying to build from Visual Studio, try
WebKitTools/Scripts/build-webkit --debug on cygwin. 

 

Ryosuke

On Tue, Jun 16, 2009 at 8:55 PM, 张雷 zhang@kortide.com.cn wrote:

I tried several times, but failed always! God damn!
I read all the instructions detailedly. These are my steps: 

Note: I already have VS2005 Professional Edition with sp1(Microsoft Visual
Studio 2005 Team Suite
http://www.microsoft.com/downloads/details.aspx?familyid=BB4A75AB-E2D4-4C96
-B39D-37BAF6B5B1DCdisplaylang=en  Service Pack 1) patched(But I don't have
the other four suggested hotfixes intalled, for some reason).

1)Install Cygwin with Cygwin downloader(All as instructed to do. Use Unix
style line ending for my Cygwin.). 
2)Installthe QuickTime SDK.
3)Get source code from Nightly Builds(I tried r41121 and the latest r44697
but failed building either).
4)Place WebKit Support Libraries
http://developer.apple.com/opensource/internet/webkit_sptlib_agree.html
in the root of WebKit soruce tree.
5)Set WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR
6)Open WebKit.sln in VS2005 IDE and choose Debug and build solution. Then
I get error message complainint that cannot open include file
'unicode/uchar.h'. Detailed log message is as follows(errors are marked
with red color):

1-- 已启动生成: 项目: JavaScriptCoreGenerated, 配置: Release Win32
--
2-- 已启动生成: 项目: record-memory-win, 配置: Release Win32 --
1正在执行生成文件项目操作
2正在编译...
1 xcopy /y/d/e/i ..\..\..\WebKitLibraries\win\tools
D:\WebKit-r41121\WebKitLibraries\win\tools
1不能执行周期性复制
1复制了 0 个文件
1 touch D:\WebKit-r41121\Output\buildfailed
1 bash build-generated-files.sh D:\WebKit-r41121\Output
D:\WebKit-r41121\WebKitLibraries\win
2main.cpp
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp -i 
ArrayPrototype.lut.h
1/cygdrive/d/WEBKIT~1/JAVASC~1/pcre/dftables chartables.c
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp -i 
DatePrototype.lut.h
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp
1bison -d -p jscyy /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Grammar.y -o
Grammar.cpp  bison_out.txt 21
2正在链接...
2正在生成代码
1perl -p -e 'END { if ($conflict) { unlink Grammar.cpp; die; } }
$conflict ||= /conflict/'  bison_out.txt
2已完成代码的生成
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table  Lexer.lut.h
1Creating hashtable for /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table
2正在嵌入清单...
1touch Grammar.cpp.h
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp -i  MathObject.lut.h
2生成日志保存在“file://D:\WebKit-r41121\Output\obj\record-memory-win\
Release\BuildLog.htm”
2record-memory-win - 0 个错误,0 个警告
1touch Grammar.hpp
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp
1cat Grammar.cpp.h Grammar.hpp  Grammar.h
1rm -f Grammar.cpp.h Grammar.hpp bison_out.txt
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/NumberConstructor.cpp -i 
NumberConstructor.lut.h
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpConstructor.cpp -i 
RegExpConstructor.lut.h
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/NumberConstructor.cpp
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpConstructor.cpp
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpObject.cpp -i 
RegExpObject.lut.h
1Creating hashtable for /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpObject.
cpp
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/StringPrototype.cpp -i 
StringPrototype.lut.h
1perl /cygdrive/d/WEBKIT~1/JAVASC~1/docs/make-bytecode-docs.pl
/cygdrive/d/WEBKIT~1/JAVASC~1/interpreter/Interpreter.cpp docs/bytecode.html
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/StringPrototype.cpp
1UNDOCUMENTED: get_by_id_self_list
1UNDOCUMENTED: get_by_id_proto_list
1 mkdir 2NUL
D:\WebKit-r41121\Output\include\JavaScriptCore\JavaScriptCore
1 xcopy /y /d ..\..\API\APICast.h

Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread 张雷




What's WebKitAuxiliaryLibrary.zip? I searched it in my WebKit source
folder but found none.

 原始信息 
主题: Re: [webkit-dev] Help! I can't survive building WebKit in Visual
Studio 2005 IDE!
发件人: Takeshi Yoshino tyosh...@google.com
收件人: Ryosuke Niwa rn...@google.com
抄送: WebKit Development webkit-dev@lists.webkit.org
日期: 2009-6-17 17:31
Or just runWebKitTools/Scripts/update-webkit and then
WebKitTools/Scripts/update-webkit-support-libs to fetch and extract
both WebKitAuxiliaryLibrary.zip and WebKitSupportLibrary.zip .
  And then you'll be able to build using
WebKit/win/WebKit.vcproj/WebKit.sln .
  
  
  Thanks,
  
  
  Takeshi
  
  
  2009/6/17 Ryosuke Niwa rn...@google.com
  You
should still be able to use VS.net debugger with it.

2009/6/17 Ryosuke Niwa rn...@google.com



Instead
of trying to build from Visual Studio, try
WebKitTools/Scripts/build-webkit --debug on cygwin.
  
  
  Ryosuke
  
  
  
  
  On Tue, Jun 16, 2009 at 8:55 PM, 张雷 zhang@kortide.com.cn wrote:
  
  
  


I tried several times,
but failed always! God damn!
I read all the instructions detailedly. These are my steps: 

Note: I already have VS2005 Professional Edition with sp1(Microsoft
Visual Studio 2005 Team Suite Service Pack 1) patched(But I don't
have the other four suggested hotfixes intalled, for some reason).

1)Install Cygwin with Cygwin downloader(All as instructed to do. Use
Unix style line ending for my Cygwin.). 
2)Installthe QuickTime SDK.
3)Get source code from Nightly Builds(I tried r41121 and the latest
r44697 but failed building either).
4)Place WebKit
Support Libraries in the root of WebKit soruce tree.
5)Set WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR
6)Open WebKit.sln in VS2005 IDE and choose "Debug" and build solution.
Then I get error message complainint that "cannot open include file
'unicode/uchar.h'". Detailed log message is as follows(errors are
marked with red color):

1-- 已启动生成: 项目: _javascript_CoreGenerated, 配置: Release Win32 --
2-- 已启动生成: 项目: record-memory-win, 配置: Release Win32 --
1正在执行生成文件项目操作
2正在编译...
1 xcopy /y/d/e/i "..\..\..\WebKitLibraries\win\tools"
"D:\WebKit-r41121\WebKitLibraries\win\tools"
1不能执行周期性复制
1复制了 0 个文件
1 touch "D:\WebKit-r41121\Output\buildfailed"
1 bash build-generated-files.sh "D:\WebKit-r41121\Output"
"D:\WebKit-r41121\WebKitLibraries\win"
2main.cpp
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp -i 
ArrayPrototype.lut.h
1/cygdrive/d/WEBKIT~1/JAVASC~1/pcre/dftables chartables.c
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp -i 
DatePrototype.lut.h
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp
1bison -d -p jscyy /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Grammar.y
-o Grammar.cpp  bison_out.txt 21
2正在链接...
2正在生成代码
1perl -p -e 'END { if ($conflict) { unlink "Grammar.cpp"; die; } }
$conflict ||= /conflict/'  bison_out.txt
2已完成代码的生成
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table  Lexer.lut.h
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table
2正在嵌入清单...
1touch Grammar.cpp.h
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp -i 
MathObject.lut.h
2生成日志保存在“file://D:\WebKit-r41121\Output\obj\record-memory-win\
Release\BuildLog.htm”
2record-memory-win - 0 个错误,0 个警告
1touch Grammar.hpp
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp
1cat Grammar.cpp.h Grammar.hpp  Grammar.h
1rm -f Grammar.cpp.h Grammar.hpp bison_out.txt
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/NumberConstructor.cpp -i 
NumberConstructor.lut.h
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpConstructor.cpp -i 
RegExpConstructor.lut.h
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/NumberConstructor.cpp
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpConstructor.cpp
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpObject.cpp -i 
RegExpObject.lut.h
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpObject.cpp
1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/StringPrototype.cpp -i 
StringPrototype.lut.h
1perl /cygdrive/d/WEBKIT~1/JAVASC~1/docs/make-bytecode-docs.pl
/cygdrive/d/WEBKIT~1/JAVASC~1/interpreter/Interpreter.cpp
docs/bytecode.html
1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/StringPrototype.cpp
1UNDOCUMENTED: get_by_id_self_list
1UNDOCUMENTED: get_by_id_proto_list
1 mkdir 2NUL
"D:\WebKit-r41121\Output\include\_javascript_Core\_javascript_Core"
1 xcopy /y /d 

Re: [webkit-dev] Help! I can't survive building WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread Nevo
But someone better to document the detail building setup in the official
webkit building page (or at least provide a link to related wiki pages ).
Firefox has a well documented building guide (Im not complaining :))

2009/6/17 Nevo sakur.dea...@gmail.com

 I think Takeshi already show you the way :)

 just run WebKitTools/Scripts/update-webkit and then
 WebKitTools/Scripts/update-webkit-support-libs to fetch and extract both
 WebKitAuxiliaryLibrary.zip and WebKitSupportLibrary.zip .


 2009/6/17 张雷 zhang@kortide.com.cn

  What's WebKitAuxiliaryLibrary.zip? I searched it in my WebKit source
 folder but found none.

  原始信息 
 主题: Re: [webkit-dev] Help! I can't survive building WebKit in Visual
  Studio 2005 IDE!
 发件人: Takeshi Yoshino tyosh...@google.com tyosh...@google.com
 收件人: Ryosuke Niwa rn...@google.com rn...@google.com
 抄送: WebKit Development 
 webkit-dev@lists.webkit.orgwebkit-dev@lists.webkit.org
 日期: 2009-6-17 17:31

 Or just run WebKitTools/Scripts/update-webkit and then
 WebKitTools/Scripts/update-webkit-support-libs to fetch and extract both
 WebKitAuxiliaryLibrary.zip and WebKitSupportLibrary.zip .
 And then you'll be able to build using WebKit/win/WebKit.vcproj/WebKit.sln
 .

  Thanks,

  Takeshi


 2009/6/17 Ryosuke Niwa rn...@google.com

 You should still be able to use VS.net debugger with it.

 2009/6/17 Ryosuke Niwa rn...@google.com

 Instead of trying to build from Visual Studio, try
 WebKitTools/Scripts/build-webkit --debug on cygwin.
  Ryosuke

   On Tue, Jun 16, 2009 at 8:55 PM, 张雷 zhang@kortide.com.cn wrote:

  I tried several times, but failed always! God damn!
 I read all the instructions detailedly. These are my steps:

 Note: I already have VS2005 Professional Edition with sp1(Microsoft
 Visual Studio 2005 Team Suite Service Pack 
 1http://www.microsoft.com/downloads/details.aspx?familyid=BB4A75AB-E2D4-4C96-B39D-37BAF6B5B1DCdisplaylang=en)
 patched(But I don't have the other four suggested hotfixes intalled, for
 some reason).

 1)Install Cygwin with Cygwin downloader(All as instructed to do. Use
 Unix style line ending for my Cygwin.).
 2)Installthe QuickTime SDK.
 3)Get source code from Nightly Builds(I tried r41121 and the latest
 r44697 but failed building either).
 4)Place WebKit Support 
 Librarieshttp://developer.apple.com/opensource/internet/webkit_sptlib_agree.htmlin
  the root of WebKit soruce tree.
 5)Set WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR
 6)Open WebKit.sln in VS2005 IDE and choose Debug and build solution.
 Then I get error message complainint that cannot open include file
 'unicode/uchar.h'. Detailed log message is as follows(errors are marked
 with red color):

 1-- 已启动生成: 项目: JavaScriptCoreGenerated, 配置: Release Win32 --
 2-- 已启动生成: 项目: record-memory-win, 配置: Release Win32 --
 1正在执行生成文件项目操作
 2正在编译...
 1 xcopy /y/d/e/i ..\..\..\WebKitLibraries\win\tools
 D:\WebKit-r41121\WebKitLibraries\win\tools
 1不能执行周期性复制
 1复制了 0 个文件
 1 touch D:\WebKit-r41121\Output\buildfailed
 1 bash build-generated-files.sh D:\WebKit-r41121\Output
 D:\WebKit-r41121\WebKitLibraries\win
 2main.cpp
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp -i 
 ArrayPrototype.lut.h
 1/cygdrive/d/WEBKIT~1/JAVASC~1/pcre/dftables chartables.c
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp -i 
 DatePrototype.lut.h
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp
 1bison -d -p jscyy /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Grammar.y -o
 Grammar.cpp  bison_out.txt 21
 2正在链接...
 2正在生成代码
 1perl -p -e 'END { if ($conflict) { unlink Grammar.cpp; die; } }
 $conflict ||= /conflict/'  bison_out.txt
 2已完成代码的生成
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table  Lexer.lut.h
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table
 2正在嵌入清单...
 1touch Grammar.cpp.h
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp -i  MathObject.lut.h
 2生成日志保存在“file://D:\WebKit-r41121\Output\obj\record-memory-win\Release\BuildLog.htm”
 2record-memory-win - 0 个错误,0 个警告
 1touch Grammar.hpp
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp
 1cat Grammar.cpp.h Grammar.hpp  Grammar.h
 1rm -f Grammar.cpp.h Grammar.hpp bison_out.txt
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/NumberConstructor.cpp -i 
 NumberConstructor.lut.h
 1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpConstructor.cpp -i 
 RegExpConstructor.lut.h
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/NumberConstructor.cpp
 1Creating hashtable for
 /cygdrive/d/WEBKIT~1/JAVASC~1/runtime/RegExpConstructor.cpp
 

[webkit-dev] Webkit in AIR - Getting text's coordniates for highlighting

2009-06-17 Thread Rehan Abdulaziz
Hey,
I wish to highlight a certain term (e.g. a search query) in HTMLLoader or
HTML (AIR) wherever it appears. The only way to do it in my mind is to
traverse through each component and find the occurrence of the term in its
body. So far, I have written the following code, and do not know where to go
from here:

   private function traverse(win:Object):void {
if (!win) return;
if (!win.document) return;
 trace(doc:  + win.doc);
if (!win.document.body) return;
trace(doc.body:  + win.document.body);
 var idx:int;
if (win.frames) {
for(idx = 0; idx  win.frames.length; idx++) {
 traverse(win.frames[idx]);
}
}
 }

In Firefox, it could be done by using the Find function of an instance
of Components.interfaces.nsIFind. How can I achieve it in AIR?

Thank you
Rehan
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] 答复: Help! I can't survive b uilding WebKit in Visual Studio 2005 IDE!

2009-06-17 Thread 张雷




OK! I ran WebKit/WebKitTools/Scripts/update-webkit and recompiled and
then I passed! It seems that I lacked WebKitAuxiliaryLibrary.zip
before, but the
instructions(http://webkit.org/building/checkout.html) for checking out
source from Nightly Builds does not say(or at least does not emphasize)
that it's required to run WebKit/WebKitTools/Scripts/update-webkit
first. The followings are my update message:


$ WebKit/WebKitTools/Scripts/update-webkit
Updating OpenSource
Skipped '.'
Subroutine main::tmpnam redefined at
/home/robert/WebKit/WebKitTools/Scripts/web
kitdirs.pm line 33
Subroutine main::tmpfile redefined at
/home/robert/WebKit/WebKitTools/Scripts/we
bkitdirs.pm line 33
Checking Last-Modified date of
WebKitAuxiliaryLibrary.zip...
Downloading WebKitAuxiliaryLibrary.zip...

 % Total % Received % Xferd Average Speed Time Time Time
Current
 Dload Upload Total Spent Left
Speed
100 1077k 100 1077k 0 0 53158 0 0:00:20 0:00:20
--:--:-- 36899

Installing WebKitAuxiliaryLibrary...
The WebKitAuxiliaryLibrary has been sucessfully installed in
/home/robert/WebKit/WebKitLibraries/win


Many thanks to you kindly people for your kind suggestions again. :) I
love you!

 原始信息 
主题: 答复: [webkit-dev] Help! I can't survive building WebKit in Visual
Studio 2005 IDE!
发件人: canquan.shencq canquan.she...@alibaba-inc.com
收件人: '张雷' zhang@kortide.com.cn, 'Ryosuke Niwa'
rn...@google.com
抄送: "'WebKit Development'" webkit-dev@lists.webkit.org
日期: 2009-6-17 18:08

  
  


  
  
  
  Please
run update-webkit
at first.
  
  Btw:
please join in qq
group:8763622 
  
  
  
  
  发件人:
webkit-dev-boun...@lists.webkit.org
[mailto:webkit-dev-boun...@lists.webkit.org] 代表
  张雷
  发送时间: 2009年6月17日 18:05
  收件人: Ryosuke Niwa
  抄送: WebKit Development
  主题: Re: [webkit-dev] Help! I can't survive building WebKit
in Visual
Studio 2005 IDE!
  
  
  I tried building from the Cygwin
command line with
WebKitTools/Scripts/build-webkit --debug. Buf failed with the same
error
message. :(
  
 原始信息 
  主题: Re: [webkit-dev] Help! I can't survive
building
WebKit in Visual Studio 2005 IDE!
  发件人: Ryosuke Niwa rn...@google.com
  收件人: WebKit Development webkit-dev@lists.webkit.org
  日期: 2009-6-17 17:26
  
  
  Instead of trying to build from
Visual Studio, try WebKitTools/Scripts/build-webkit
--debug on cygwin. 
  
  
  
  
  Ryosuke
  
  On Tue, Jun 16, 2009 at 8:55 PM,
  张雷 zhang@kortide.com.cn
wrote:
  
  I tried
several times, but
failed always! God damn!
I read all the instructions detailedly. These are my steps: 
  
Note: I already have VS2005 Professional Edition with sp1(Microsoft Visual Studio 2005
Team Suite
Service Pack 1) patched(But I don't have the other four suggested
hotfixes
intalled, for some reason).
  
1)Install Cygwin with Cygwin downloader(All as instructed to do. Use
Unix style
line ending for my Cygwin.). 
2)Installthe QuickTime SDK.
3)Get source code from Nightly Builds(I tried r41121 and the latest
r44697 but
failed building either).
4)Place WebKit Support Libraries in
the root of
WebKit soruce tree.
5)Set WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR
  6)Open WebKit.sln in VS2005 IDE and choose
"Debug"
and build solution. Then I get error message complainint that "cannot
open
include file 'unicode/uchar.h'". Detailed log message is as
follows(errors
are marked with red color):
  
  1-- 已启动生成: 项目:
_javascript_CoreGenerated, 配置: Release Win32
--
  2-- 已启动生成: 项目:
record-memory-win, 配置: Release Win32 --
  1正在执行生成
文件项目操作
  2正在编译...
  1 xcopy /y/d/e/i
"..\..\..\WebKitLibraries\win\tools"
"D:\WebKit-r41121\WebKitLibraries\win\tools"
  1不能执行周期
性复制
  1复制了 0 个文件
  1 touch "D:\WebKit-r41121\Output\buildfailed"
  1 bash build-generated-files.sh
"D:\WebKit-r41121\Output"
"D:\WebKit-r41121\WebKitLibraries\win"
  2main.cpp
  1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp -i 
ArrayPrototype.lut.h
  1/cygdrive/d/WEBKIT~1/JAVASC~1/pcre/dftables
chartables.c
  1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/ArrayPrototype.cpp
  1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp -i 
DatePrototype.lut.h
  1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/DatePrototype.cpp
  1bison -d -p jscyy
/cygdrive/d/WEBKIT~1/JAVASC~1/parser/Grammar.y
-o Grammar.cpp  bison_out.txt 21
  2正在链接...
  2正在生成代码
  1perl -p -e 'END { if ($conflict) { unlink
"Grammar.cpp"; die; } } $conflict ||= /conflict/'  bison_out.txt
  2已完成代码的
生成
  1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table  Lexer.lut.h
  1Creating hashtable for
/cygdrive/d/WEBKIT~1/JAVASC~1/parser/Keywords.table
  2正在嵌入清单...
  1touch Grammar.cpp.h
  1/cygdrive/d/WEBKIT~1/JAVASC~1/create_hash_table
/cygdrive/d/WEBKIT~1/JAVASC~1/runtime/MathObject.cpp -i 
MathObject.lut.h
  2生成日志保存
在“file://D:\WebKit-r41121\Output\obj\record-memory-win\
Release\BuildLog.htm”
  2record-memory-win - 0 

Re: [webkit-dev] Using WebKit renderer to produce PDF output

2009-06-17 Thread Dominik Roettsches
Hi Ben,

  I need to produce a tool that can generate PDFs from HTML. The best
  solution I can think of is to use WebKit's layout engine, and plug my own
  PDF generator in as a renderer backend.

On both, Windows or Linux, you could try using Cairo's PDF backend for your 
purpose [1], i.e. create a modified cairo-based GraphicsContext that outputs to 
PDF.

Regards,

Dominik

[1] http://cairographics.org/manual/cairo-pdf-surface.html


 -Original Message-
 From: webkit-dev-boun...@lists.webkit.org
 [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Ben Harper
 Sent: Wednesday, May 13, 2009 11:42 PM
 To: Darin Adler
 Cc: webkit-dev@lists.webkit.org
 Subject: Re: [webkit-dev] Using WebKit renderer to produce PDF output

 Unfortunately the platform is Windows. Regarding the method that
 you're describing - I assume the PDF generation is handled by
 CoreGraphics?

 Ben

 On Wed, May 13, 2009 at 11:17 PM, Darin Adler da...@apple.com wrote:
  On May 13, 2009, at 2:11 PM, Ben Harper wrote:
 
  I need to produce a tool that can generate PDFs from HTML. The best
  solution I can think of is to use WebKit's layout engine,
 and plug my own
  PDF generator in as a renderer backend. I don't want to
 reinvent the wheel
  though - so I'm asking here has this been done already, or
 are there other
  obvious solution out there that I'm missing?
 
  It depends what platform you're talking about. The Mac OS X
 version of
  WebKit already offers this capability, since printing on
 Mac OS X is based
  on PDF. The PDFOperationWithView method of NSPrintOperation
 can work for
  this purpose.
 
 -- Darin
 
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev




Access Systems Germany GmbH
Essener Strasse 5  |  D-46047 Oberhausen
HRB 13548 Amtsgericht Duisburg
Geschaeftsfuehrer: Michel Piquemal, Tomonori Watanabe, Yusuke Kanda

www.access-company.com

CONFIDENTIALITY NOTICE
This e-mail and any attachments hereto may contain information that is 
privileged or confidential, and is intended for use only by the
individual or entity to which it is addressed. Any disclosure, copying or 
distribution of the information by anyone else is strictly prohibited.
If you have received this document in error, please notify us promptly by 
responding to this e-mail. Thank you.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Building WebKit on ARM

2009-06-17 Thread jagadeesh k
Hi,

    I want to built WebKit on OMAP 3530(ARM cortex A8)with Open embedded Linux 
distribution.
1.Want to know the build instructions for building WebKit on OMAP 3530?

2.Does the WebKit source need to be changed(makefile) so that it builds for 
OMAP 3530?

Thanks 
jagadeesh 


  ___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Building WebKit on ARM

2009-06-17 Thread Zoltan Herczeg
Hi,

 1.Want to know the build instructions for building WebKit on OMAP 3530?

WebKit is written in c++, so you don't need to do anything special for
your CPU. Just run WebKitTools/Scripts/build-webkit

 2.Does the WebKit source need to be changed(makefile) so that it builds
 for OMAP 3530?

If you plan to use a cross-compiler, the answer is yes. However, you can
use a scratchbox environment to avoid these modifications:
http://freedesktop.org/wiki/Software/sbox2

Zoltan


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Review states

2009-06-17 Thread Adam Barth
On Wed, Jun 17, 2009 at 1:39 AM, Mark Rowemr...@apple.com wrote:

 On 2009-06-17, at 00:41, Eric Seidel wrote:

 I propose altering our bugzilla setup to have the following review
 states (effectively adding a 4th state):

 review:
 REQUESTED
 DENIED
 APPROVED WITH MODIFICATIONS
 APPROVED

 I think DENIED could also do with having a hard and soft state.  One to
 indicate that the approach is completely wrong, and another to indicate that
 the approach is sound but it just needs another round of improvements and
 review.

In the academic world, we'd call that REVISE AND RESUBMIT.  :)

Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Building WebKit on ARM

2009-06-17 Thread Holger Freyther
On Wednesday 17 June 2009 15:50:32 jagadeesh k wrote:
 Hi,

 I want to built WebKit on OMAP 3530(ARM cortex A8)with Open embedded
 Linux distribution. 1.Want to know the build instructions for building
 WebKit on OMAP 3530?

 2.Does the WebKit source need to be changed(makefile) so that it builds for
 OMAP 3530?

No,

koen from Angstrom/OpenEmbedded is maintaining the build recipe. All you need 
would be something like bitbake webkitgtk and you will get a webkit with the 
Armv7 JIT enabled for your OMAP3.

I think it would be best if you ask further questions in an OpenEmbedded 
channel.

regards
holger
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Should we put the webkit.org mailing lists on Gmane?

2009-06-17 Thread Adam Roben
Given the single vote in favor and no one opposed, I'm going to work  
on this today.


-Adam

On Jun 15, 2009, at 4:52 PM, Gustavo Noronha wrote:


On Sat, 2009-06-13 at 09:00 -0400, Adam Roben wrote:


Gmane (http://gmane.org) provides a few features that could be
useful for thewebkit.org mailing lists, including:

* a nicer web interface than Mailman's
* indexed search (maybe better than Mailman's, certainly at least as
good, and with a better interface)


+1, mainly for the indexed search, I'm not much into news =)


Getting the lists posted and imported just requires filling out a web
form (for posting the lists) and sending an email (to request the
import). I'm happy to take responsibility for doing this if people  
are

in favor of it.


Thanks for taking the initiative!

See you,

--
Gustavo Noronha g...@gnome.org
GNOME contributor

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Quesition about DumpRenderTree output

2009-06-17 Thread David Hyatt

On Jun 16, 2009, at 12:26 AM, Lucius Fox wrote:


Hi,

Can you please tell me what is the meaning of relative positioned
and the meaning of positioned in DumpRenderTree?


Those are CSS terms.  Relative positioned means you have  
position:relative specified in CSS.  Positioned with no qualifier  
means you are either fixed or absolutely positioned, i.e.,  
position:fixed or position:absolute in CSS.


dave

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Javascript window.open()

2009-06-17 Thread Zongheng Zhou
Hi,
I am using the QT port of webkit. Instead of doing anything else for the
Javascript 's window.open(), I only want to log the URL being requested.

Can anybody tell me how I can change the behavior of the window.open?

Thanks,
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Review states

2009-06-17 Thread Maciej Stachowiak


On Jun 17, 2009, at 1:39 AM, Mark Rowe wrote:



On 2009-06-17, at 00:41, Eric Seidel wrote:


I propose altering our bugzilla setup to have the following review
states (effectively adding a 4th state):

review:
REQUESTED
DENIED
APPROVED WITH MODIFICATIONS
APPROVED


I think DENIED could also do with having a hard and soft state.   
One to indicate that the approach is completely wrong, and another  
to indicate that the approach is sound but it just needs another  
round of improvements and review.


Also, does Bugzilla support custom states for flags?  ISTR that it  
only allows the three states and provides no means of changing their  
names.


If I were to name the states, then instead of review? / review- /  
review+, I would have something like:


Review
Rejected (for the rare case where the concept of a patch tries to do  
is completely wrong; often in this case the bug will also be INVALID)

Revise and Resubmit
Commit with Changes (probably this should only be used when the patch  
submitter is a commiter)

Commit

If flags won't cut it, we could try to teach bugzilla to use something  
else as the basis for review, such as keywords or the status whiteboard.


I would also like to change the names of the bug states and  
resolutions; I don't know how much we are constrained by bugzilla here.


Regards,
Maciej

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Review states

2009-06-17 Thread Jeremy Orlow
Rietveld doesn't really support any flags, right?
It seems like they could be added in without too much effort though.
 Mondrian (its closed source parent) does.

J

On Wed, Jun 17, 2009 at 11:13 AM, Eric Seidel e...@webkit.org wrote:

 It would appear bugzilla is too lame to support changing flag values
 +/-/? are all we get. :(
 https://bugs.webkit.org/editflagtypes.cgi
 (only accessible to bugzilla users with edit privilages).

 Maybe the solution is a different review tool instead of adding flags
 to attachments on the bug. :(


 I don't think Rietveld supports any sort of flags either though.  I've
 not looked at review board.

 -eric

 On Wed, Jun 17, 2009 at 8:14 AM, Maciej Stachowiakm...@apple.com wrote:
 
  On Jun 17, 2009, at 1:39 AM, Mark Rowe wrote:
 
 
  On 2009-06-17, at 00:41, Eric Seidel wrote:
 
  I propose altering our bugzilla setup to have the following review
  states (effectively adding a 4th state):
 
  review:
  REQUESTED
  DENIED
  APPROVED WITH MODIFICATIONS
  APPROVED
 
  I think DENIED could also do with having a hard and soft state.  One
 to
  indicate that the approach is completely wrong, and another to indicate
 that
  the approach is sound but it just needs another round of improvements
 and
  review.
 
  Also, does Bugzilla support custom states for flags?  ISTR that it only
  allows the three states and provides no means of changing their names.
 
  If I were to name the states, then instead of review? / review- /
 review+, I
  would have something like:
 
  Review
  Rejected (for the rare case where the concept of a patch tries to do is
  completely wrong; often in this case the bug will also be INVALID)
  Revise and Resubmit
  Commit with Changes (probably this should only be used when the patch
  submitter is a commiter)
  Commit
 
  If flags won't cut it, we could try to teach bugzilla to use something
 else
  as the basis for review, such as keywords or the status whiteboard.
 
  I would also like to change the names of the bug states and resolutions;
 I
  don't know how much we are constrained by bugzilla here.
 
  Regards,
  Maciej
 
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Review states

2009-06-17 Thread Joe Mason

Eric Seidel wrote:

It would appear bugzilla is too lame to support changing flag values
+/-/? are all we get. :(
https://bugs.webkit.org/editflagtypes.cgi
(only accessible to bugzilla users with edit privilages).

Maybe the solution is a different review tool instead of adding flags
to attachments on the bug. :(


If bugzilla's technical limitations are holding us back, maybe we should 
look at another bug tracker.


Joe
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Review states

2009-06-17 Thread Mark Rowe


On 2009-06-17, at 11:20, Joe Mason wrote:


Eric Seidel wrote:

It would appear bugzilla is too lame to support changing flag values
+/-/? are all we get. :(
https://bugs.webkit.org/editflagtypes.cgi
(only accessible to bugzilla users with edit privilages).
Maybe the solution is a different review tool instead of adding flags
to attachments on the bug. :(


If bugzilla's technical limitations are holding us back, maybe we  
should look at another bug tracker.


It doesn't have built-in support for this single feature so we'll toss  
the entire thing out?  We do have the ability to edit the Bugzilla  
source.


- Mark



smime.p7s
Description: S/MIME cryptographic signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Review states

2009-06-17 Thread David Hyatt

On Jun 17, 2009, at 1:20 PM, Joe Mason wrote:


Eric Seidel wrote:

It would appear bugzilla is too lame to support changing flag values
+/-/? are all we get. :(
https://bugs.webkit.org/editflagtypes.cgi
(only accessible to bugzilla users with edit privilages).
Maybe the solution is a different review tool instead of adding flags
to attachments on the bug. :(


If bugzilla's technical limitations are holding us back, maybe we  
should look at another bug tracker.



I am strongly against abandoning Bugzilla.

dave
(hy...@apple.com)

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] script to assist converting pixel tests to dumpastext tests

2009-06-17 Thread Darin Adler

On Jun 16, 2009, at 6:16 PM, Ryosuke Niwa wrote:


I've been converting a bunch of pixel tests to dumpAsText tests.


Thanks for telling us about your script.

These are layout tests, not pixel tests. While it's true that the  
tests dump the render tree as text and when run in the --pixel mode  
even dump the pixels, in most cases the render tree results are the  
primary test and the ability to check the pixel results is a sort of  
lesser secondary side benefit.


In general, it's only OK to convert a layout test to a dumpAsText test  
if it can test the same thing. In most cases, a mechanically created  
dumpAsText equivalent of an existing test would test a lot less than  
the layout test, and perhaps not test the original bug at all.


So the process of retiring layout tests and replacing them with  
equivalent dumpAsText tests is primarily one of understanding what  
each original test is intended to test, and figuring out if there's  
another way to do it that doesn't rely on render tree dump.


-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Review states

2009-06-17 Thread Maciej Stachowiak


On Jun 17, 2009, at 11:45 AM, Ojan Vafai wrote:


This is surely bike-shedding, but...

On Wed, Jun 17, 2009 at 8:14 AM, Maciej Stachowiak m...@apple.com  
wrote:

Review
Rejected (for the rare case where the concept of a patch tries to do  
is completely wrong; often in this case the bug will also be INVALID)

Revise and Resubmit

How about Needs work? I find resubmit a confusing word as commit  
and submit are often used interchangeably.


Just Revise would be ok with me, but I wanted to draw more of a  
distinction from Commit with Changes. Revise and Repost maybe,  
since we usually speak of posting a patch, rather than submitting  
it? Or just Post a New Patch.




Commit with Changes (probably this should only be used when the  
patch submitter is a commiter)

Commit




Anyway, to make any changes like this, we'll have to work around some  
of the technical limitations of bugzilla. A number of us have  
experience hacking bugzilla, so this is totally feasible. If there  
were an open source bug tracker that met our needs much better, to the  
point that transition costs would be lower than hacking bugzilla, then  
we could consider it. But that depends on having a concrete  
alternative that is actually better.


Cheers,
Maciej

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Review states

2009-06-17 Thread Maciej Stachowiak


On Jun 17, 2009, at 12:52 PM, Maciej Stachowiak wrote:



On Jun 17, 2009, at 11:45 AM, Ojan Vafai wrote:


This is surely bike-shedding, but...

On Wed, Jun 17, 2009 at 8:14 AM, Maciej Stachowiak m...@apple.com  
wrote:

Review
Rejected (for the rare case where the concept of a patch tries to  
do is completely wrong; often in this case the bug will also be  
INVALID)

Revise and Resubmit

How about Needs work? I find resubmit a confusing word as  
commit and submit are often used interchangeably.


Just Revise would be ok with me, but I wanted to draw more of a  
distinction from Commit with Changes. Revise and Repost maybe,  
since we usually speak of posting a patch, rather than  
submitting it? Or just Post a New Patch.




Commit with Changes (probably this should only be used when the  
patch submitter is a commiter)

Commit




Anyway, to make any changes like this, we'll have to work around  
some of the technical limitations of bugzilla. A number of us have  
experience hacking bugzilla, so this is totally feasible. If there  
were an open source bug tracker that met our needs much better, to  
the point that transition costs would be lower than hacking  
bugzilla, then we could consider it. But that depends on having a  
concrete alternative that is actually better.


I forgot to mention - there should probably be a final Checked In  
state. I think that would help smooth out the workflow when people  
attach multiple patches to a single bug. It seems more clear than  
unflagging.


Cheers,
Maciej

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Geoffrey Garen
If someone could be kind enough to explain how it works on other  
platforms, it would be very helpful.


I'm not really interested in helping with the dubiously legal task of  
taking JavaScriptCore, which is an OpenSource library, and turning it  
into a closed, proprietary library.


Geoff___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Review states

2009-06-17 Thread Ojan Vafai
On Wed, Jun 17, 2009 at 12:54 PM, Maciej Stachowiak m...@apple.com wrote:

 I forgot to mention - there should probably be a final Checked In state.
 I think that would help smooth out the workflow when people attach multiple
 patches to a single bug. It seems more clear than unflagging.


Would be great if this also took a revision number (like how mark as
duplicate takes a bug number) so it could add a link to the trac URL.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Toshiyasu Morita
--- On Wed, 6/17/09, Geoffrey Garen gga...@apple.com wrote:

 I'm not really interested in helping with the dubiously legal task
of taking
 JavaScriptCore, which is an OpenSource library, and turning
it into a closed, 
 proprietary library.
I'm not sure where this weird idea of developing a closed proprietary library 
came from. I have never mentioned anything about developing a closed 
proprietary library.

My client is a hardware company. It produces consumer devices. They have been 
using GNU software for a long time. Their current website has a support 
download page where you can download the GNU source code used in all their 
released products.

Toshi




  ___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Jeremy Orlow
IANAL (and correct me if I'm wrong), but
1) Parts of WebKit are licensed under the LGPL
2) Even if you're not modifying (or copying code from) files licensed under
the LGPL, any files linked to those LGPL files are governed by the LGPL
3) Presumably you're going to distribute binaries that include your modified
version of WebKit
4) And thus aren't you compelled to release the source code for anything
linked to any LGPL whenever 3 happens?

If so, why not just develop in the open?

J

On Wed, Jun 17, 2009 at 1:56 PM, Toshiyasu Morita tm_web...@yahoo.comwrote:

 --- On *Wed, 6/17/09, Geoffrey Garen gga...@apple.com* wrote:

  I'm not really interested in helping with the dubiously legal task of
 taking
  JavaScriptCore, which is an OpenSource library, and turning it into a
 closed,
  proprietary library.

 I'm not sure where this weird idea of developing a closed proprietary
 library came from. I have never mentioned anything about developing a closed
 proprietary library.

 My client is a hardware company. It produces consumer devices. They have
 been using GNU software for a long time. Their current website has a support
 download page where you can download the GNU source code used in all their
 released products.

 Toshi



 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Toshiyasu Morita
--- On Wed, 6/17/09, Geoffrey Garen gga...@apple.com wrote:





 I'm not really interested in helping with the dubiously legal task of
taking 


 JavaScriptCore, which is an OpenSource library, and turning it
into a closed, 


 proprietary library.



I've talked to my client, and he's told me it's their intent to
contribute the port back to the community once the port is finished.



IMHO main problem with trying to contribute the code now is they have 
milestones, and there aren't enough resources to coordinate the merging of all 
the MIPS architecture-specific code back to mainline.



Toshi


  ___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Kenneth Christiansen
That doesn't mean that you cannot develop it in the open. We can
integrate the code once you are ready to do so.

Kenneth

 I've talked to my client, and he's told me it's their intent to contribute
 the port back to the community once the port is finished.

 IMHO main problem with trying to contribute the code now is they have
 milestones, and there aren't enough resources to coordinate the merging of
 all the MIPS architecture-specific code back to mainline.

 Toshi

 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Toshiyasu Morita
--- On Wed, 6/17/09, Jeremy Orlow jor...@chromium.org wrote:

 IANAL (and correct me if I'm wrong), but 
 1) Parts of WebKit are licensed under the LGPL 2)
Even if you're not modifying (or copying code from) files licensed
under the 
 LGPL, any files linked to those LGPL files are governed by
the LGPL
 3) Presumably you're going to distribute binaries that include your modified 
 version
 of WebKit 4) And thus aren't you compelled to release the source code for 
 anything linked to
 any LGPL whenever 3 happens?

 If so, why not just develop in the open?

i've been told they want a head start on producing a MIPS-based device that 
uses WebKit.

Toshi



  ___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Toshiyasu Morita
kenneth.christian...@openbossa.org wrote:



 That doesn't mean that you cannot develop it in the open. We can

 integrate the code once you are ready to do so.

 

 Kenneth


You're preaching to the choir. It's not my decision to make.



Toshi


  ___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Attaching property to external (Obj-c) synthetic event

2009-06-17 Thread Ross Lillie
Greetings,

I need to generate a synthetic event (DOM Level 2) from external (native)
code and inject into the current DOM structure.  Furthermore, this event
needs to have a custom property attached, to pass external data into the
current Javascript context.

Generating and dispatching the event from external code is straightforward.
From the delegate method (didFinishLoadForFrame) of the WebFrame, I can
access the DOMDocument as well as the JSGlobalContextRef.  Using the
DOMDocument reference I create a new Event instance via the createEvent()
method and initialize to the desired type.  This event can then be
dispatched to a specified target in the DOM without any problems.

However, at this point (before dispatch) I would like to attach a JavaScript
property to the corresponding JSObject of the DOMEvent.  I assumed that this
could be accomplished by retrieving the JSObject reference from the
DOMEvent, but this appears not to work, as calling the [(DOMEvent)ev
JSObject] method returns NULL. Has the corresponding Javascript Object been
created yet, or is it created when dispatched to the desired target?

What am I missing?  It appears that my understanding of the
WindowScriptObject interface is not what it should be.  Any insight would be
appreciated.

Thanks in advance, and regards
Ross

--
Example (abbreviated) code snippet:

From the window didFinishLoadForFrame method:

JSGlobalContextRef ctx = [frame globalContext];
DOMDocument *doc = [frame DOMDocument];

DOMEvent *ev = [doc createEvent:@Events];
[ev initEvent:@eventType canBubbleArg:YES cancelableArg:NO];

// At this point I can select the event target via the DOMDocument
// getElementByID method and dispatch my custom event without problems.
// However, I'm trying to attach a custom property to the event as
// follows:

JSObjectRef evObj = [ev JSObject];  // THIS RETURNS NULL!!

// Intent was to use the JavaScriptCore APIs to add a custom property to the
// DOMEvent object created above

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Kenneth Christiansen
When then I guess that you can only expect to get help after you have
contributed the code back to the community. ;-)

Good luck with your port anyway.

Kenneth

On Wed, Jun 17, 2009 at 6:29 PM, Toshiyasu Moritatm_web...@yahoo.com wrote:
 kenneth.christian...@openbossa.org wrote:

 That doesn't mean that you cannot develop it in the open. We can
 integrate the code once you are ready to do so.

 Kenneth

 You're preaching to the choir. It's not my decision to make.

 Toshi

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Adam Treat
On Wednesday 17 June 2009 05:12:41 pm Jeremy Orlow wrote:
 If so, why not just develop in the open?

I'm just guessing here... but probably for the same rough combination of 
reasons that Google didn't develop Chromium in the open before it was publicly 
announced... or for the same rough combination of reasons that Apple didn't 
develop the new ARM JIT support in the open before it was publicly announced. 

Same goes for lots of initial features or ports that the various companies 
involved in WebKit have eventually contributed.

It would be nice if every change that is envisioned will eventually be merged 
back into the official repository to be developed in the open, but that is just 
not realistic given the commercial world we live in.

That said, if a company is determined to initially develop such things behind 
a closed door, then they should have no expectation that the greater community 
will help with any obfuscated technical questions given that we aren't privy 
to what's going on behind that closed door.  At least that's how I see it.

Cheers,
Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] [Bulk] Re: MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Adam Treat
On Wednesday 17 June 2009 06:24:32 pm Adam Treat wrote:
 It would be nice if every change that is envisioned will eventually be
 merged back into the official repository to be developed in the open, but
 that is just not realistic given the commercial world we live in.

I would also add that in my personal opinion and experience the business 
reasons often cited for hiding behind a closed door during the initial 
development of a new feature are dubious at best and real hindrances (even 
crippling hindrances) at worst.

Too often I think companies involved with Open Source choose to develop some 
new feature behind a closed door almost as an a priori default position.  In 
my experience this often leads to a lot of headaches when interacting with the 
community much as we are starting to see here.  Moveover, the actual business 
value of such initial closed development is often just assumed.  

I think it would behoove companies that are involved with WebKit to rethink 
these initial assumptions and actually make sure that whatever PR value they 
get from announcing there brand new swanky feature that has been developed 
behind a closed door, is actually greater than the negative repercussions that 
come from doing so.

Cheers,
Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] SharedWorkers alternate design

2009-06-17 Thread Drew Wilson
Following up again on this - now that my cross-thread MessagePort patch is
getting close to landing, I am moving forward on the SharedWorker design
described earlier in this thread.
I think there is still little clarity around the appcache behavior (dimich:
are you bring over your shadow frame concept to webkit?).

It doesn't seem like it should block the rest of SharedWorker development
while we work out the details - I will not expose the appcache APIs for
SharedWorkers until we have consensus about how they should work.

Let me know if you have any concerns with my approach. I'll add an
ENABLE_SHARED_WORKERS flag to control access to these APIs while development
proceeds.

-atw


On Tue, Jun 2, 2009 at 11:43 AM, Michael Nordman micha...@google.comwrote:

  As for our implementation - I don't know how appcache is integrated with
 the
  loader code.

 We're still working out the details sans workers. But if it's a
 requirement to be able to a have an distinct appache host per shared
 worker, then so be it.

  If not, we either need to add this support, or delay exposing appcache
 APIs to SharedWorkers
  until we add the ability to load data from worker context without going
 through a document
  object (probably required for persistent workers).

 I'm for deferring appcache + worker integration until we have appcach
 - worker integration in place (including in place for chrome).

 Exposing the scriptable APIs to workers don't necessarily have to go
 in lock step with and appcache selection and resource loading on
 behalf of workers.

 There may be some overlap with work being done to support resource
 loading for dedicated workers in chrome. In chrome resource loads
 don't go thru the renderer process at all (so no Document/Frame
 instances). I think Dmitry was talking about introducing a FakeFrame
 (maybe not the best name) for this purpose.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Attaching property to external (Obj-c) synthetic event

2009-06-17 Thread Ross Lillie
Greetings again,

Never mind.  If I understand things correctly, calling into the DOMDocument
from native code, to create a new Event instance, does not create the
corresponding JSObject in the window's global context.  Dispatching the
event to a target appears to be when the corresponding JSObject is created.

Any insight (such as the way scope chains are set up, etc, just guessing
here...) on why it works like this would be appreciated.

Again thanks in advance and regards,
Ross


On 6/17/09 4:29 PM, Ross Lillie ross.lil...@motorola.com wrote:

 Greetings,
 
 I need to generate a synthetic event (DOM Level 2) from external (native)
 code and inject into the current DOM structure.  Furthermore, this event
 needs to have a custom property attached, to pass external data into the
 current Javascript context.
 
 Generating and dispatching the event from external code is straightforward.
 From the delegate method (didFinishLoadForFrame) of the WebFrame, I can
 access the DOMDocument as well as the JSGlobalContextRef.  Using the
 DOMDocument reference I create a new Event instance via the createEvent()
 method and initialize to the desired type.  This event can then be
 dispatched to a specified target in the DOM without any problems.
 
 However, at this point (before dispatch) I would like to attach a JavaScript
 property to the corresponding JSObject of the DOMEvent.  I assumed that this
 could be accomplished by retrieving the JSObject reference from the
 DOMEvent, but this appears not to work, as calling the [(DOMEvent)ev
 JSObject] method returns NULL. Has the corresponding Javascript Object been
 created yet, or is it created when dispatched to the desired target?
 
 What am I missing?  It appears that my understanding of the
 WindowScriptObject interface is not what it should be.  Any insight would be
 appreciated.
 
 Thanks in advance, and regards
 Ross
 
 --
 Example (abbreviated) code snippet:
 
 From the window didFinishLoadForFrame method:
 
 JSGlobalContextRef ctx = [frame globalContext];
 DOMDocument *doc = [frame DOMDocument];
 
 DOMEvent *ev = [doc createEvent:@Events];
 [ev initEvent:@eventType canBubbleArg:YES cancelableArg:NO];
 
 // At this point I can select the event target via the DOMDocument
 // getElementByID method and dispatch my custom event without problems.
 // However, I'm trying to attach a custom property to the event as
 // follows:
 
 JSObjectRef evObj = [ev JSObject];  // THIS RETURNS NULL!!
 
 // Intent was to use the JavaScriptCore APIs to add a custom property to the
 // DOMEvent object created above
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to find a WebKit Nightly corresponding roughly to particular Safari version

2009-06-17 Thread Thomas Jaggi

Am 15.06.2009 um 18:31 schrieb Darin Adler:

On Jun 15, 2009, at 9:03 AM, Thomas Jaggi wrote:

Thanks for your help. If I got that right, 38725 would correspond  
to Safari 3.2.1 (http://trac.webkit.org/changeset/38725). Using the  
'official' detection script with 38707 (the last version before the  
non-existing 38725) I'm told Your WebKit version number is 528.5.  
But according to Wikipedia this would be Safari 4. Am I doing  
something wrong?


Unfortunately, due to branching, changeset numbers are not  
sufficient by themselves. Releases are done on branches. The  
changeset of the branch doesn't tell you what changeset on the main  
trunk is closest to that version. Typically it just indicates the  
latest main trunk changeset at the moment the release was tagged,  
which could be long after the release was done.


Hm, that's bad news.
Is there another possibility? Extracting the WebKit from Safari 3 or  
something?


Thomas
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Maciej Stachowiak


On Jun 17, 2009, at 2:18 PM, Toshiyasu Morita wrote:


--- On Wed, 6/17/09, Geoffrey Garen gga...@apple.com wrote:

 I'm not really interested in helping with the dubiously legal task  
of taking 
 JavaScriptCore, which is an OpenSource library, and turning it  
into a closed,

 proprietary library.

I've talked to my client, and he's told me it's their intent to  
contribute the port back to the community once the port is finished.


IMHO main problem with trying to contribute the code now is they  
have milestones, and there aren't enough resources to coordinate the  
merging of all the MIPS architecture-specific code back to mainline.


Glad to hear they are planning to contribute the code in the future.  
It will be much easier to provide meaningful help once the code is  
available. Until then, it's hard for us to help you figure out what is  
going wrong in the temporarily private port, and somewhat off-topic to  
ask for help on the list.


I'm not trying to give you a hard time. It's just that this list is  
meant for development discussion of WebKit, as in the public  
svn.webkit.org tree. We get a lot of questions from people who are  
clearly working on various private ports, and it is a distraction from  
the on-topic content. Asking for help in using the API is not entirely  
on-topic either.


If people would like a forum for such discussions, we can consider  
making a webkit-help list where it would be on-topic to ask for WebKit- 
related help, without distracting us from actual development discussion.


Regards,
Maciej

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] SharedWorkers alternate design

2009-06-17 Thread Michael Nordman
On Wed, Jun 17, 2009 at 3:43 PM, Drew Wilson atwil...@google.com wrote:

 Following up again on this - now that my cross-thread MessagePort patch is
 getting close to landing, I am moving forward on the SharedWorker design
 described earlier in this thread.
 I think there is still little clarity around the appcache behavior (dimich:
 are you bring over your shadow frame concept to webkit?).


I think we're making decent progress, but integration with workers is a ways
off yet. First things first for me, get things working w/o workers.

I'm wondering about bringing the 'shadow frame' technique to webcore too?



 It doesn't seem like it should block the rest of SharedWorker development
 while we work out the details - I will not expose the appcache APIs for
 SharedWorkers until we have consensus about how they should work.


Sounds good. You should plow ahead without concern for appcache integration.
I'll back fill later. We'll have similar backfilling to do with the Database
too.




 Let me know if you have any concerns with my approach. I'll add an
 ENABLE_SHARED_WORKERS flag to control access to these APIs while development
 proceeds.

 -atw


 On Tue, Jun 2, 2009 at 11:43 AM, Michael Nordman micha...@google.comwrote:

  As for our implementation - I don't know how appcache is integrated with
 the
  loader code.

 We're still working out the details sans workers. But if it's a
 requirement to be able to a have an distinct appache host per shared
 worker, then so be it.

  If not, we either need to add this support, or delay exposing appcache
 APIs to SharedWorkers
  until we add the ability to load data from worker context without going
 through a document
  object (probably required for persistent workers).

 I'm for deferring appcache + worker integration until we have appcach
 - worker integration in place (including in place for chrome).

 Exposing the scriptable APIs to workers don't necessarily have to go
 in lock step with and appcache selection and resource loading on
 behalf of workers.

 There may be some overlap with work being done to support resource
 loading for dedicated workers in chrome. In chrome resource loads
 don't go thru the renderer process at all (so no Document/Frame
 instances). I think Dmitry was talking about introducing a FakeFrame
 (maybe not the best name) for this purpose.



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] SharedWorkers alternate design

2009-06-17 Thread Dmitry Titov

 I think there is still little clarity around the appcache behavior (dimich:
 are you bring over your shadow frame concept to webkit?).


 I'm wondering about bringing the 'shadow frame' technique to webcore too?


If needs be :-)

Just to explain what is meant by 'shadow frame' (I'm not sure it was
discussed in webkit-dev beore): to provide access to FrameLoader in Chrome's
Worker process (which loads WebKit but doesn't load any html, just creates a
worker out of JS string), we create a WebView and load it from a (url,
encoding, mimtype, data) source with empty data and the worker's url. This
creates a frame with a an empty document but with a right origin and
encoding. This makes it possible to create a ThreadableLoader (and
underlying DocumentThreadableLoader) w/o aceess to the original worker's
parent. This loader is used to implement XHR and importScripts in Chrome
workers. Oriinally a Darin Fisher's idea, it was implemented as alternative
to rollign out a new frame-less loader.

Shared workers can use the same approach since they can not forever hold the
ref to the 'creating' document.

Dmitry
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Tab key Navigation

2009-06-17 Thread n179911
Hi,
Is 'Tab key Navigation a browser functionality or Webkit functionally?
For example, I load google.com, I put my mouse on the search input box click
once. The search input box should have focus.
And then i press 'Tab', the focus should moved.

But what I find out is the way Safari moves focus is different from Chromium
(both uses Webkit but may be using different versions). So I would like to
know if the Tab key navigation a Webkit functionality or a Browser
functionality?

Thank you.,
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] rdar://5735912 for DumpRenderTree?

2009-06-17 Thread Ryosuke Niwa
So I tracked down here the message is sent.
\WebCore\platform\network\cf\ResourceHandleCFNet.cpp
line 365 in ResourceHandle::start(Frame* frame)

But when I deleted the call
to CFURLConnectionScheduleWithCurrentMessageQueue,
DumpRenderTree crashed.  So I don't think simply removing the call solves
the problem.

Is there anyone familiar with this message?

Ryosuke

On Wed, Jun 17, 2009 at 1:02 AM, Alexey Proskuryakov a...@webkit.org wrote:


 17.06.2009, в 7:06, Ryosuke Niwa написал(а):

 CFURLConnectionScheduleWithCurrentMessageQueue: NO LONGER NEEDED TO BE
 CALLED -
 done by CFURLConnectionScheduleWithCurrentMessageQueue: NO LONGER NEEDED
 TO BE CALLED -
 done by CFURLConnectionScheduleWithRunLoop (4) (see
 rdar://5735912)CFURLConnecti
 onScheduleWithCurrentMessageQueue: NO LONGER NEEDED TO BE CALLED - done by
 CFURL
 ConnectionScheduleWithRunLoop (3) (see rdar://5735912)

 But since I don't have radar access, I don't really understand what it is.
 Is this something we should worry about?  Or is it something that we should
 just ignore?


 It appears that we should just do what the message suggests, and remove the
 call to CFURLConnectionScheduleWithCurrentMessageQueue in
 ResourceHandleWin.cpp.

 - WBR, Alexey Proskuryakov


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev