Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Carlos Garcia Campos 
El mié, 21-08-2013 a las 23:01 -0700, Ryosuke Niwa escribió:
> On Wed, Aug 21, 2013 at 10:54 PM, Ryosuke Niwa 
> wrote:
> On Wed, Aug 21, 2013 at 10:50 PM, Carlos Garcia Campos
>  wrote:
> 
> El mié, 21-08-2013 a las 14:04 -0700, Ryosuke Niwa
> escribió:
> > Hi,
> 
> [...]
> >
> > Separately, I'd like to know whether people liked
> the new format and
> > it's worth my time making webkitpy adopt the new
> format.
> 
> 
> I prefer the old format.
> 
> >
> > I personally didn't like the old format because it
> made the first line
> > of each change log too long.  I'm also not a big fun
> of wrapping URLs
> > in angle brackets.  It's also unclear to me what
> should happen when
> > there are multiple Bugzilla URLs to list.
> >
> >
> > But I hear the new format made git log --oneline
> much more readable so
> > I can be convinced although I don't intend to use
> git for WebKit
> > development in the foreseeable future myself.
> 
> 
> Well, git log is not actually affected by the
> ChangeLog format, but by
> the commit message. I mean, we generate the commit
> message from the
> ChangeLog, so we can keep the old format in the
> ChangeLog and update the
> script to generate the commit message to make it
> better for oneline git
> log format. webkitpy parses the ChangeLog not the
> commit message, so
> everything should work.
> 
> 
> If I'm not mistaken, I think a bunch of tools DO analyze git
> logs to do the work; commit-queue, webkitbot, etc...
> 
> 
> e.g. MarkBugFixed._determine_bug_id_and_svn_revision
> uses tool.scm().svn_commit_log to figure out the bug number.  In fact,
> the code assumes that the commit log uses the same format as the
> change log and uses changelog.py's parse_bug_id_from_changelog
> 
> 
> In fact, making change log & commit log use a different format is much
> more challenging than changing the format of change log & commit log.
>  It requires A LOT of refactoring and bug fixes in webkitpy.  I don't
> even know much work is required for webkitperl and other tools.

I see, I thought ChangeLog parser was used everywhere. So, I guess the
solution would be to find a format most people like and adapt all
scripts to it. I personally think it's not worth it, though. The oneline
git log format is ok with the old commit message format IMO. If the only
problem is that the bug number is not in the first line we can probably
add it without adding the URL in angle brackets, something like:

Bug 119872 - REGRESSION: Crash under JITCompiler::link while loading Gmail
https://bugs.webkit.org/show_bug.cgi?id=119872

> 
> - R. Niwa
> 
> 

-- 
Carlos Garcia Campos
http://pgp.rediris.es:11371/pks/lookup?op=get&search=0xF3D322D0EC4582C3

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Ryosuke Niwa 
On Wed, Aug 21, 2013 at 10:54 PM, Ryosuke Niwa  wrote:

> On Wed, Aug 21, 2013 at 10:50 PM, Carlos Garcia Campos <
> carlo...@webkit.org> wrote:
>
>> El mié, 21-08-2013 a las 14:04 -0700, Ryosuke Niwa escribió:
>> > Hi,
>>
>> [...]
>> >
>> > Separately, I'd like to know whether people liked the new format and
>> > it's worth my time making webkitpy adopt the new format.
>>
>> I prefer the old format.
>>
>> >
>> > I personally didn't like the old format because it made the first line
>> > of each change log too long.  I'm also not a big fun of wrapping URLs
>> > in angle brackets.  It's also unclear to me what should happen when
>> > there are multiple Bugzilla URLs to list.
>> >
>> >
>> > But I hear the new format made git log --oneline much more readable so
>> > I can be convinced although I don't intend to use git for WebKit
>> > development in the foreseeable future myself.
>>
>> Well, git log is not actually affected by the ChangeLog format, but by
>> the commit message. I mean, we generate the commit message from the
>> ChangeLog, so we can keep the old format in the ChangeLog and update the
>> script to generate the commit message to make it better for oneline git
>> log format. webkitpy parses the ChangeLog not the commit message, so
>> everything should work.
>>
>
> If I'm not mistaken, I think a bunch of tools DO analyze git logs to do
> the work; commit-queue, webkitbot, etc...
>

e.g. MarkBugFixed._determine_bug_id_and_svn_revision
uses tool.scm().svn_commit_log to figure out the bug number.  In fact, the
code assumes that the commit log uses the same format as the change log and
uses changelog.py's parse_bug_id_from_changelog

In fact, making change log & commit log use a different format is much more
challenging than changing the format of change log & commit log.  It
requires A LOT of refactoring and bug fixes in webkitpy.  I don't even know
much work is required for webkitperl and other tools.

- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Ryosuke Niwa 
On Wed, Aug 21, 2013 at 10:50 PM, Carlos Garcia Campos
wrote:

> El mié, 21-08-2013 a las 14:04 -0700, Ryosuke Niwa escribió:
> > Hi,
>
> [...]
> >
> > Separately, I'd like to know whether people liked the new format and
> > it's worth my time making webkitpy adopt the new format.
>
> I prefer the old format.
>
> >
> > I personally didn't like the old format because it made the first line
> > of each change log too long.  I'm also not a big fun of wrapping URLs
> > in angle brackets.  It's also unclear to me what should happen when
> > there are multiple Bugzilla URLs to list.
> >
> >
> > But I hear the new format made git log --oneline much more readable so
> > I can be convinced although I don't intend to use git for WebKit
> > development in the foreseeable future myself.
>
> Well, git log is not actually affected by the ChangeLog format, but by
> the commit message. I mean, we generate the commit message from the
> ChangeLog, so we can keep the old format in the ChangeLog and update the
> script to generate the commit message to make it better for oneline git
> log format. webkitpy parses the ChangeLog not the commit message, so
> everything should work.
>

If I'm not mistaken, I think a bunch of tools DO analyze git logs to do the
work; commit-queue, webkitbot, etc...

- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Carlos Garcia Campos 
El mié, 21-08-2013 a las 14:04 -0700, Ryosuke Niwa escribió:
> Hi,

[...]
> 
> Separately, I'd like to know whether people liked the new format and
> it's worth my time making webkitpy adopt the new format.

I prefer the old format.

> 
> I personally didn't like the old format because it made the first line
> of each change log too long.  I'm also not a big fun of wrapping URLs
> in angle brackets.  It's also unclear to me what should happen when
> there are multiple Bugzilla URLs to list.
> 
> 
> But I hear the new format made git log --oneline much more readable so
> I can be convinced although I don't intend to use git for WebKit
> development in the foreseeable future myself.

Well, git log is not actually affected by the ChangeLog format, but by
the commit message. I mean, we generate the commit message from the
ChangeLog, so we can keep the old format in the ChangeLog and update the
script to generate the commit message to make it better for oneline git
log format. webkitpy parses the ChangeLog not the commit message, so
everything should work.

> 
> - R. Niwa
> 
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

-- 
Carlos Garcia Campos
http://pgp.rediris.es:11371/pks/lookup?op=get&search=0xF3D322D0EC4582C3

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Gavin Barraclough 
I’m a bit of a luddite and edit my change log entries by hand.
The old format is more amenable to this, the new format is a regression.

cheers,
G.

On Aug 21, 2013, at 2:25 PM, Ryosuke Niwa  wrote:

> On Wed, Aug 21, 2013 at 2:04 PM, Ryosuke Niwa  wrote:
> Hi,
> 
> I have noticed that the change log format has recently been changed.  
> Unfortunately, this didn't work well with all webkitpy tools we have, and has 
> been rolled out in http://trac.webkit.org/changeset/154406.
> 
> I kindly ask you to manually edit your patch to use the old format before 
> landing your patch for now.
> 
> To clarify, the old multi-line format looks like:
> 
> 2013-08-13  Ryosuke Niwa  
> 
> REGRESSION(r150187): Safari fails to render allrecipe.com comment 
> popups
> https://bugs.webkit.org/show_bug.cgi?id=119780
> 
> Reviewed by Benjamin Poulain.
> 
> while new single-line format looked like:
> 
> 2013-08-18  Ryosuke Niwa  
> 
>  Pasting multiple lines into a textarea 
> can introduce extra new lines
> 
> Reviewed by Darin Adler.
> 
> Separately, I'd like to know whether people liked the new format and it's 
> worth my time making webkitpy adopt the new format.
> 
> I personally didn't like the new single-line format because it made the first 
> line of each change log too long.  I'm also not a big fun of wrapping URLs in 
> angle brackets.  It's also unclear to me what should happen when there are 
> multiple Bugzilla URLs to list.
> 
> But I hear the new format made git log --oneline much more readable so I can 
> be convinced although I don't intend to use git for WebKit development in the 
> foreseeable future myself.
> 
> - R. Niwa
> 
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Does Qt ARM support NRWT?

2013-08-21 Thread Osztrogonác Csaba 

Hi,

Thanks for the heads-up. I'm not working on Qt port nowadays, but
some of my colleagues (azbest_hu, kadam and abrhm). I cc-ed them to
this thread.

I can confirm that Qt ARM didn't support NRWT long long time ago,
but the Qt ARM bot on http://build.webkit.sed.hu was switched to
use NRWT directly instead of this RWT wrapper script at least half
a year before. So it's safe to remove this useNewRunWebKitTests()
function. It won't break anything.

As far as I remember that Qt ARM has only an easily fixable NRWT
issue: http://wkb.ug/6 . But it is unrelated to this bug.

I'm sure that the guys will fix these bugs quickly. ;)

Ossy

Ryosuke Niwa írta:

Hi,

It seems like the only port that uses ORWT by default is Qt ARM (and 
iOS) at this point.


Is it true that Qt ARM still doesn't support NRWT as this comment indicates?

sub useNewRunWebKitTests()
{
# NRWT does not support qt-arm: 
https://bugs.webkit.org/show_bug.cgi?id=64086

return 0 if isQt() and isARM();
# All other platforms should use NRWT by default.
return 1;
}

If so, what are remaining 
issues? https://bugs.webkit.org/show_bug.cgi?id=64086 has already been 
fixed so we need a new bug to track it if we still have some issue on Qt 
ARM.


- R. Niwa

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Does Qt ARM support NRWT?

2013-08-21 Thread Ryosuke Niwa 
Hi,

It seems like the only port that uses ORWT by default is Qt ARM (and iOS)
at this point.

Is it true that Qt ARM still doesn't support NRWT as this comment indicates?

sub useNewRunWebKitTests()
{
# NRWT does not support qt-arm:
https://bugs.webkit.org/show_bug.cgi?id=64086
return 0 if isQt() and isARM();
# All other platforms should use NRWT by default.
return 1;
}

If so, what are remaining issues?
https://bugs.webkit.org/show_bug.cgi?id=64086 has already been fixed so we
need a new bug to track it if we still have some issue on Qt ARM.

- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Brady Eidson 

On Aug 21, 2013, at 2:04 PM, Ryosuke Niwa  wrote:

> Separately, I'd like to know whether people liked the new format and it's 
> worth my time making webkitpy adopt the new format.
> 
> I personally didn't like the old format because it made the first line of 
> each change log too long.  I'm also not a big fun of wrapping URLs in angle 
> brackets.  It's also unclear to me what should happen when there are multiple 
> Bugzilla URLs to list.

I think you mean you personally don’t like the *new* format? :)

I don’t like it either.  The line was too long, and I frequently list multiple 
bug urls (a bugzilla and a radar).

I’ve had prepare-ChangeLog give me the new format and I simply ignored it and 
used the old format instead.  I didn’t feel remotely bad about this as there 
has never been 100% standardization on the format, anyways.

> But I hear the new format made git log --oneline much more readable so I can 
> be convinced although I don't intend to use git for WebKit development in the 
> foreseeable future myself.

I use git, and the old format doesn’t bother me.

I almost always care about the entire commit message, or at least the “TLDR;” 
included after the bug descriptions and urls.

~Brady

> 
> - R. Niwa
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Ryosuke Niwa 
On Wed, Aug 21, 2013 at 2:04 PM, Ryosuke Niwa  wrote:

> Hi,
>
> I have noticed that the change log format has recently been changed.
>  Unfortunately, this didn't work well with all webkitpy tools we have, and
> has been rolled out in http://trac.webkit.org/changeset/154406.
>
> *I kindly ask you to manually edit your patch to use the old format
> before landing your patch for now.*
>

To clarify, the old multi-line format looks like:

2013-08-13  Ryosuke Niwa  

REGRESSION(r150187): Safari fails to render allrecipe.com comment
popups
https://bugs.webkit.org/show_bug.cgi?id=119780

Reviewed by Benjamin Poulain.

while new single-line format looked like:

2013-08-18  Ryosuke Niwa  

 Pasting multiple lines into a
textarea can introduce extra new lines

Reviewed by Darin Adler.

Separately, I'd like to know whether people liked the new format and it's
> worth my time making webkitpy adopt the new format.
>
> I personally didn't like the *new single-line* format because it made the
> first line of each change log too long.  I'm also not a big fun of wrapping
> URLs in angle brackets.  It's also unclear to me what should happen when
> there are multiple Bugzilla URLs to list.
>
> But I hear the new format made git log --oneline much more readable so I
> can be convinced although I don't intend to use git for WebKit development
> in the foreseeable future myself.
>
> - R. Niwa
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] ChangeLog format

2013-08-21 Thread Ryosuke Niwa 
Hi,

I have noticed that the change log format has recently been changed.
 Unfortunately, this didn't work well with all webkitpy tools we have, and
has been rolled out in http://trac.webkit.org/changeset/154406.

*I kindly ask you to manually edit your patch to use the old format before
landing your patch for now.*

Otherwise webkit-patch and other tools will get confused and all kinds of
problem ensues.



Separately, I'd like to know whether people liked the new format and it's
worth my time making webkitpy adopt the new format.

I personally didn't like the old format because it made the first line of
each change log too long.  I'm also not a big fun of wrapping URLs in angle
brackets.  It's also unclear to me what should happen when there are
multiple Bugzilla URLs to list.

But I hear the new format made git log --oneline much more readable so I
can be convinced although I don't intend to use git for WebKit development
in the foreseeable future myself.

- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev