Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs
On Wed, Jan 15, 2014 at 10:54 PM, Alexey Proskuryakov wrote: > (re-sent from a correct address) > > I think that it's good to try not dumping build failures into comments > right away, and to see what happens. > > As for not showing style bot failures, it seems almost certain that this > will make them substantially more annoying to work with. Can you describe > the workflow for patch author and reviewer to deal with style bot warnings > when they are not inline? Manually finding relevant lines by number can't > work. > > I agree with Tim that dumping all tested paths along with style warnings > is silly. How hard would it be it to get rid of that? > The workflow is to click on the bubble to see the style errors. e.g. https://webkit-queues.appspot.com/results/6544662978363392 - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs
(re-sent from a correct address) I think that it's good to try not dumping build failures into comments right away, and to see what happens. As for not showing style bot failures, it seems almost certain that this will make them substantially more annoying to work with. Can you describe the workflow for patch author and reviewer to deal with style bot warnings when they are not inline? Manually finding relevant lines by number can't work. I agree with Tim that dumping all tested paths along with style warnings is silly. How hard would it be it to get rid of that? - WBR, Alexey Proskuryakov 15 янв. 2014 г., в 20:34, Ryosuke Niwa написал(а): > FWIW, I've posted a patch to implement the compromise Sam proposed: > https://bugs.webkit.org/show_bug.cgi?id=127079 > > It would be nice to update the code-view.js so that it could show style > errors inline next to code but that could be done in a separate patch. > > - R. Niwa > > > On Wed, Jan 15, 2014 at 8:29 PM, Gyuyoung Kim wrote: > +1, I would prefer to see EWS log only when I want to see it. > > Gyuyoung. > > > On Thu, Jan 16, 2014 at 1:24 PM, Joseph Pecoraro wrote: > I would also like to see a reduction in EWS "spam". > > It is not just the comment clutter, but also quite a bit of emails. > > - Joe > > On Jan 15, 2014, at 8:17 PM, Ryosuke Niwa wrote: > >> We could do that, or add some JS hack to Bugzilla so that it hides EWS >> comments by default but makes them expandable. >> >> - R. Niwa >> >> >> On Wed, Jan 15, 2014 at 8:09 PM, Sam Weinig wrote: >> Could we compromise for now, and remove all the non-test failing EWS >> comments (e.g. build failure, style failure)? >> >> - Sam >> >> On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa wrote: >> >>> I find Mac EWS's listing the failing tests to be very useful especially >>> because it uploads the results to Bugzilla. >>> >>> I do agree that comments about build failures are much less useful. >>> >>> - R. Niwa >>> >>> >>> On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wrote: >>> Hi Everyone, >>> >>> I am becoming increasingly annoyed by the comments made in bugs.webkit.org >>> bugs by our non-human helpers, the EWS bots. I don’t find the addition of >>> a comment indicating that a patch has failed on a bot, over the existing >>> indication in the bubble, to be worth the noise it creates. >>> >>> I propose that we stop allowing the bots to comment, and leave that space >>> for the developers. >>> >>> - Sam >>> >>> ___ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> https://lists.webkit.org/mailman/listinfo/webkit-dev >>> >> >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs
FWIW, I've posted a patch to implement the compromise Sam proposed: https://bugs.webkit.org/show_bug.cgi?id=127079 It would be nice to update the code-view.js so that it could show style errors inline next to code but that could be done in a separate patch. - R. Niwa On Wed, Jan 15, 2014 at 8:29 PM, Gyuyoung Kim wrote: > +1, I would prefer to see EWS log only when I want to see it. > > Gyuyoung. > > > On Thu, Jan 16, 2014 at 1:24 PM, Joseph Pecoraro wrote: > >> I would also like to see a reduction in EWS "spam". >> >> It is not just the comment clutter, but also quite a bit of emails. >> >> - Joe >> >> On Jan 15, 2014, at 8:17 PM, Ryosuke Niwa wrote: >> >> We could do that, or add some JS hack to Bugzilla so that it hides EWS >> comments by default but makes them expandable. >> >> - R. Niwa >> >> >> On Wed, Jan 15, 2014 at 8:09 PM, Sam Weinig wrote: >> >>> Could we compromise for now, and remove all the non-test failing EWS >>> comments (e.g. build failure, style failure)? >>> >>> - Sam >>> >>> On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa wrote: >>> >>> I find Mac EWS's listing the failing tests to be very useful especially >>> because it uploads the results to Bugzilla. >>> >>> I do agree that comments about build failures are much less useful. >>> >>> - R. Niwa >>> >>> >>> On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wrote: >>> Hi Everyone, I am becoming increasingly annoyed by the comments made in bugs.webkit.org bugs by our non-human helpers, the EWS bots. I don’t find the addition of a comment indicating that a patch has failed on a bot, over the existing indication in the bubble, to be worth the noise it creates. I propose that we stop allowing the bots to comment, and leave that space for the developers. - Sam ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev >>> >>> >>> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev >> >> >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev >> >> > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs
It isn't just about seeing the comment on the page, it also gets emailed. I agree, no bot comments would be better. The stye bot spew is particularly bad, mainly because it dumps all the file paths it tested not just what fails. — Timothy Hatcher On Jan 15, 2014, at 8:17 PM, Ryosuke Niwa wrote: > We could do that, or add some JS hack to Bugzilla so that it hides EWS > comments by default but makes them expandable. > > - R. Niwa > > > On Wed, Jan 15, 2014 at 8:09 PM, Sam Weinig wrote: > Could we compromise for now, and remove all the non-test failing EWS comments > (e.g. build failure, style failure)? > > - Sam > > On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa wrote: > >> I find Mac EWS's listing the failing tests to be very useful especially >> because it uploads the results to Bugzilla. >> >> I do agree that comments about build failures are much less useful. >> >> - R. Niwa >> >> >> On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wrote: >> Hi Everyone, >> >> I am becoming increasingly annoyed by the comments made in bugs.webkit.org >> bugs by our non-human helpers, the EWS bots. I don’t find the addition of a >> comment indicating that a patch has failed on a bot, over the existing >> indication in the bubble, to be worth the noise it creates. >> >> I propose that we stop allowing the bots to comment, and leave that space >> for the developers. >> >> - Sam >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev >> > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs
+1, I would prefer to see EWS log only when I want to see it. Gyuyoung. On Thu, Jan 16, 2014 at 1:24 PM, Joseph Pecoraro wrote: > I would also like to see a reduction in EWS "spam". > > It is not just the comment clutter, but also quite a bit of emails. > > - Joe > > On Jan 15, 2014, at 8:17 PM, Ryosuke Niwa wrote: > > We could do that, or add some JS hack to Bugzilla so that it hides EWS > comments by default but makes them expandable. > > - R. Niwa > > > On Wed, Jan 15, 2014 at 8:09 PM, Sam Weinig wrote: > >> Could we compromise for now, and remove all the non-test failing EWS >> comments (e.g. build failure, style failure)? >> >> - Sam >> >> On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa wrote: >> >> I find Mac EWS's listing the failing tests to be very useful especially >> because it uploads the results to Bugzilla. >> >> I do agree that comments about build failures are much less useful. >> >> - R. Niwa >> >> >> On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wrote: >> >>> Hi Everyone, >>> >>> I am becoming increasingly annoyed by the comments made in >>> bugs.webkit.org bugs by our non-human helpers, the EWS bots. I don’t >>> find the addition of a comment indicating that a patch has failed on a bot, >>> over the existing indication in the bubble, to be worth the noise it >>> creates. >>> >>> I propose that we stop allowing the bots to comment, and leave that >>> space for the developers. >>> >>> - Sam >>> >>> ___ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> https://lists.webkit.org/mailman/listinfo/webkit-dev >>> >> >> >> > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs
I would also like to see a reduction in EWS "spam". It is not just the comment clutter, but also quite a bit of emails. - Joe On Jan 15, 2014, at 8:17 PM, Ryosuke Niwa wrote: > We could do that, or add some JS hack to Bugzilla so that it hides EWS > comments by default but makes them expandable. > > - R. Niwa > > > On Wed, Jan 15, 2014 at 8:09 PM, Sam Weinig wrote: > Could we compromise for now, and remove all the non-test failing EWS comments > (e.g. build failure, style failure)? > > - Sam > > On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa wrote: > >> I find Mac EWS's listing the failing tests to be very useful especially >> because it uploads the results to Bugzilla. >> >> I do agree that comments about build failures are much less useful. >> >> - R. Niwa >> >> >> On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wrote: >> Hi Everyone, >> >> I am becoming increasingly annoyed by the comments made in bugs.webkit.org >> bugs by our non-human helpers, the EWS bots. I don’t find the addition of a >> comment indicating that a patch has failed on a bot, over the existing >> indication in the bubble, to be worth the noise it creates. >> >> I propose that we stop allowing the bots to comment, and leave that space >> for the developers. >> >> - Sam >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev >> > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs
We could do that, or add some JS hack to Bugzilla so that it hides EWS comments by default but makes them expandable. - R. Niwa On Wed, Jan 15, 2014 at 8:09 PM, Sam Weinig wrote: > Could we compromise for now, and remove all the non-test failing EWS > comments (e.g. build failure, style failure)? > > - Sam > > On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa wrote: > > I find Mac EWS's listing the failing tests to be very useful especially > because it uploads the results to Bugzilla. > > I do agree that comments about build failures are much less useful. > > - R. Niwa > > > On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wrote: > >> Hi Everyone, >> >> I am becoming increasingly annoyed by the comments made in >> bugs.webkit.org bugs by our non-human helpers, the EWS bots. I don’t >> find the addition of a comment indicating that a patch has failed on a bot, >> over the existing indication in the bubble, to be worth the noise it >> creates. >> >> I propose that we stop allowing the bots to comment, and leave that space >> for the developers. >> >> - Sam >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev >> > > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs
Could we compromise for now, and remove all the non-test failing EWS comments (e.g. build failure, style failure)? - Sam On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa wrote: > I find Mac EWS's listing the failing tests to be very useful especially > because it uploads the results to Bugzilla. > > I do agree that comments about build failures are much less useful. > > - R. Niwa > > > On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wrote: > Hi Everyone, > > I am becoming increasingly annoyed by the comments made in bugs.webkit.org > bugs by our non-human helpers, the EWS bots. I don’t find the addition of a > comment indicating that a patch has failed on a bot, over the existing > indication in the bubble, to be worth the noise it creates. > > I propose that we stop allowing the bots to comment, and leave that space for > the developers. > > - Sam > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs
I find Mac EWS's listing the failing tests to be very useful especially because it uploads the results to Bugzilla. I do agree that comments about build failures are much less useful. - R. Niwa On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wrote: > Hi Everyone, > > I am becoming increasingly annoyed by the comments made in > bugs.webkit.orgbugs by our non-human helpers, the EWS bots. I don’t find the > addition of > a comment indicating that a patch has failed on a bot, over the existing > indication in the bubble, to be worth the noise it creates. > > I propose that we stop allowing the bots to comment, and leave that space > for the developers. > > - Sam > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs
+1 This is blocked on improving Bugzilla EWS bubbles, making it humanly possible to find out without a comment which tests regressed. - WBR, Alexey Proskuryakov 15 янв. 2014 г., в 19:54, Sam Weinig написал(а): > Hi Everyone, > > I am becoming increasingly annoyed by the comments made in bugs.webkit.org > bugs by our non-human helpers, the EWS bots. I don’t find the addition of a > comment indicating that a patch has failed on a bot, over the existing > indication in the bubble, to be worth the noise it creates. > > I propose that we stop allowing the bots to comment, and leave that space for > the developers. > > - Sam > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Proposal: Stop EWS bot commenting in bugs
Hi Everyone, I am becoming increasingly annoyed by the comments made in bugs.webkit.org bugs by our non-human helpers, the EWS bots. I don’t find the addition of a comment indicating that a patch has failed on a bot, over the existing indication in the bubble, to be worth the noise it creates. I propose that we stop allowing the bots to comment, and leave that space for the developers. - Sam ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Fwd: Broken Windows EWS
This is being worked on. Initially there were issues involving the network, but now we have run into mysterious build issues. We’ll keep you posted on progress as it is made. Jon Begin forwarded message: > From: Osztrogonác Csaba > Subject: [webkit-dev] Broken Windows EWS > Date: January 13, 2014 at 9:17:04 AM PST > To: WebKit Development > > Hi, > > it seems the Windows EWS bots are still broken: > http://webkit-queues.appspot.com/queue-status/win-ews > > " > /cygdrive/c/Program Files (x86)/Microsoft Visual Studio > 12.0/Common7/IDE/WDExpress.exe WebKit.vcxproj\WebKit.sln /build Release|Win32 > Could not open build log file at > /home/buildbot/WebKit/WebKitBuild/Release/BuildOutput.htm at > Tools/Scripts/build-webkit line 359. > " > > They didn't process any patch in the last month and folks broke the > build many times because the Windows EWS is still out of order. > > Is there any plan for fixing them in the near future? > > br, > Ossy > > Brent Fulgham írta: >> Hi Ossy, >> I'm not sure what's going on. Those bots do have VS2013 on them. It looks >> like a process may be locking the build log, preventing anything from >> happening. >> I'll look into it ASAP. >> Thanks, >> -Brent > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
