[webkit-dev] Commits in branches triggering build in the bots now

[Carlos Garcia Campos]

I don't know what have changed, but now, commits in other branches are
triggering builds in the bots. I have just realized after merging a
couple of commits in GTK+ stable branch. This didn't happen before,
those commits didn't show in the bots at all. 

Any idea why is this happening now? I don't see any relevant change in
the buildbot config. For now I'll stop merging commits because I don't
want the bots to waste the time building and running tests when nothing
has actually changed.

Thanks, 
Carlos Garcia Campos
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Clang tidy

[Konstantin Tokarev]

04.05.2017, 04:31, "Olmstead, Don" :
> I took some time today to see how clang-tidy can be run on WebKit code and 
> opened https://bugs.webkit.org/show_bug.cgi?id=171632 with some examples on 
> how to run things. I also attached some output from the modernizer fixes that 
> can be applied.

I think you should not mix different kinds of modernizations in the single 
patch. This way it would be easier to review the changes, also changes that are 
already used by community will get in fast as no-brainers, while others may 
need discussion.

My 2c.

>
> I was thinking of running any code we move from WebCore/platform through 
> clang-tidy during the process of moving it to PAL. Documentation for the 
> checks can be found at 
> http://clang.llvm.org/extra/clang-tidy/checks/list.html if anyone wants to 
> take a look at what should potentially be run.
> ,
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


-- 
Regards,
Konstantin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Commits in branches triggering build in the bots now

[Lucas Forschler]

Hi Carlos!

I recently updated the svn post commit hook to use the newest version of 
svn_buildbot.py from 
https://github.com/buildbot/buildbot-contrib/blob/master/master/contrib/svn_buildbot.py
 


I am going to look through the diff now to see if there are any obvious changes 
which would cause this.
Thanks for bringing it to our attention!

Lucas


> On May 4, 2017, at 9:51 AM, Alexey Proskuryakov  wrote:
> 
> Hi Carlos,
> 
> Could you please file a bug, and include the relevant links to investigate 
> the issue?
> 
> - Alexey
> 
> 
>> 4 мая 2017 г., в 0:46, Carlos Garcia Campos > > написал(а):
>> 
>> I don't know what have changed, but now, commits in other branches are
>> triggering builds in the bots. I have just realized after merging a
>> couple of commits in GTK+ stable branch. This didn't happen before,
>> those commits didn't show in the bots at all. 
>> 
>> Any idea why is this happening now? I don't see any relevant change in
>> the buildbot config. For now I'll stop merging commits because I don't
>> want the bots to waste the time building and running tests when nothing
>> has actually changed.
>> 
>> Thanks, 
>> Carlos Garcia Campos
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org 
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Commits in branches triggering build in the bots now

[Alexey Proskuryakov]

Hi Carlos,

Could you please file a bug, and include the relevant links to investigate the 
issue?

- Alexey


> 4 мая 2017 г., в 0:46, Carlos Garcia Campos  написал(а):
> 
> I don't know what have changed, but now, commits in other branches are
> triggering builds in the bots. I have just realized after merging a
> couple of commits in GTK+ stable branch. This didn't happen before,
> those commits didn't show in the bots at all. 
> 
> Any idea why is this happening now? I don't see any relevant change in
> the buildbot config. For now I'll stop merging commits because I don't
> want the bots to waste the time building and running tests when nothing
> has actually changed.
> 
> Thanks, 
> Carlos Garcia Campos
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Commits in branches triggering build in the bots now

[Carlos Alberto Lopez Perez]

On 05/05/17 00:24, Lucas Forschler wrote:
> Hi Carlos!
> 
> I recently updated the svn post commit hook to use the newest version of 
> svn_buildbot.py from 
> https://github.com/buildbot/buildbot-contrib/blob/master/master/contrib/svn_buildbot.py
>  
> 
> 
> I am going to look through the diff now to see if there are any obvious 
> changes which would cause this.
> Thanks for bringing it to our attention!
> 
> Lucas

Its ok that the svn_buildbot script sends changes about any branches.

But the buildbot config should only trigger branches for changes on
trunk due to the change_filter": "trunk_filter" below:

https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg?rev=216213#L954

https://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json?rev=216213#L353

Maybe the issue is that the new svn_buildbot scripts fails to identify the 
branch name
(for WebKitGTK+ we use a non-standard branch name: "releases") and sends the 
changes with
branch "None"?

Maybe the patch below fixes the issue?

--- a/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
@@ -951,7 +951,7 @@ class PlatformSpecificScheduler(AnyBranchScheduler):
 def filter(self, change):
 return wkbuild.should_build(self.platform, change.files)
 
-trunk_filter = ChangeFilter(branch=["trunk", None])
+trunk_filter = ChangeFilter(branch="trunk")
 
 def loadBuilderConfig(c):
 # FIXME: These file handles are leaked.




signature.asc
Description: OpenPGP digital signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Commits in branches triggering build in the bots now

[Carlos Alberto Lopez Perez]

On 05/05/17 00:55, Carlos Alberto Lopez Perez wrote:
> But the buildbot config should only trigger branches for changes on
> trunk due to the change_filter": "trunk_filter" below:

I mean: "But the buildbot config should only trigger _builds_ for 



signature.asc
Description: OpenPGP digital signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Commits in branches triggering build in the bots now

[Lucas Forschler]

Hi Carlos!

It looks like there are a mix of issues here… 

First… the old svn commit hook never sent along changes to buildbot for 
anything that wasn’t in “trunk” or “branches”. 
So, the fact you were not getting triggers for anything outside of these 
branches was an error in the previous version of the script. I’m a bit shocked 
this is just now being discovered… we must never have had a builder working 
against anything other than “trunk" or “branches”.

Moving forward:

The new svn_buildbot.py does properly send along changes to any branch. 
However, it looks like it has a few problems, which I plan to fix up. 

I’m about to fix the hook, and thus should get appropriate branch name passed 
along to buildbot from the commit hook. (Right now, trunk and branch commits 
also get ‘None’)

I think your code change below should also be landed. But not until the 
post-commit hook is fixed, otherwise I believe no changes will be triggered.
Lucas


> On May 4, 2017, at 3:55 PM, Carlos Alberto Lopez Perez  
> wrote:
> 
> On 05/05/17 00:24, Lucas Forschler wrote:
>> Hi Carlos!
>> 
>> I recently updated the svn post commit hook to use the newest version of 
>> svn_buildbot.py from 
>> https://github.com/buildbot/buildbot-contrib/blob/master/master/contrib/svn_buildbot.py
>>  
>> 
>> 
>> I am going to look through the diff now to see if there are any obvious 
>> changes which would cause this.
>> Thanks for bringing it to our attention!
>> 
>> Lucas
> 
> Its ok that the svn_buildbot script sends changes about any branches.
> 
> But the buildbot config should only trigger branches for changes on
> trunk due to the change_filter": "trunk_filter" below:
> 
> https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg?rev=216213#L954
> 
> https://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json?rev=216213#L353
> 
> Maybe the issue is that the new svn_buildbot scripts fails to identify the 
> branch name
> (for WebKitGTK+ we use a non-standard branch name: "releases") and sends the 
> changes with
> branch "None"?
> 
> Maybe the patch below fixes the issue?
> 
> --- a/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
> +++ b/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
> @@ -951,7 +951,7 @@ class PlatformSpecificScheduler(AnyBranchScheduler):
> def filter(self, change):
> return wkbuild.should_build(self.platform, change.files)
> 
> -trunk_filter = ChangeFilter(branch=["trunk", None])
> +trunk_filter = ChangeFilter(branch="trunk")
> 
> def loadBuilderConfig(c):
> # FIXME: These file handles are leaked.
> 
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev