How about only a single comment when the first failure occurs? (Or else when
all bots pass, if there is never a failure.)
This should help the author, the reviewer, and anyone else cc’d, without being
too spammy.
> On Nov 1, 2019, at 5:20 PM, Aakash Jain wrote:
>
> Hi Ryosuke,
>
> Many
> On Nov 1, 2019, at 11:53, Michael Catanzaro wrote:
>
> On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote:
>> Namely, some people write a lambda as:
>> auto x = [] () { }
>> with a space between [] and () while others would write it as:
>> auto x = []() { }
>
> : I omit the () when there
On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro
wrote:
> On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote:
> > Namely, some people write a lambda as:
> > auto x = [] () { }
> >
> > with a space between [] and () while others would write it as:
> >
> > auto x = []() { }
>
> : I omit the ()
I've been using the short form in the layout code for a while now and never
mistaken it for code block start & end.
That being said I don't have strong preference on this.
Alan.
On Fri, Nov 1, 2019 at 4:37 PM Ryosuke Niwa wrote:
> On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro
> wrote:
>
On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote:
Namely, some people write a lambda as:
auto x = [] () { }
with a space between [] and () while others would write it as:
auto x = []() { }
: I omit the () when there are no parameters, as in these examples.
No preference on spacing.
Sounds good. I prefer the single comment when the first failure occur. That way
notification would be sent as soon as the first failure happens.
I'll implement that (assuming it's acceptable to everyone).
Thanks
Aakash
> On Nov 1, 2019, at 8:35 PM, Maciej Stachowiak wrote:
>
>
> How about
Hi Ryosuke,
Many people didn't like the noise by the EWS comments, and we removed the
comments as per previous discussion in:
https://lists.webkit.org/pipermail/webkit-dev/2019-June/030683.html.
I agree with your point that having some kind of notification might be useful.
I proposed some
Hi all,
There seems to be inconsistency in our coding style with regards to spacing
in lambdas.
Namely, some people write a lambda as:
auto x = [] () { }
with a space between [] and () while others would write it as:
auto x = []() { }
without a space between the two. I'd like to require
I mildly prefer without the space :)
--
Chris Dumez
> On Nov 1, 2019, at 11:19 AM, Ryosuke Niwa wrote:
>
> Hi all,
>
> There seems to be inconsistency in our coding style with regards to spacing
> in lambdas.
>
> Namely, some people write a lambda as:
> auto x = [] () { }
>
> with a
> On Nov 1, 2019, at 11:19 AM, Ryosuke Niwa wrote:
>
> Hi all,
>
> There seems to be inconsistency in our coding style with regards to spacing
> in lambdas.
I've noticed this too and the lack of consistency slightly annoys me.
>
> Namely, some people write a lambda as:
> auto x = [] () {
On Fri, Nov 1, 2019 at 11:19 AM Ryosuke Niwa wrote:
> Hi all,
>
> There seems to be inconsistency in our coding style with regards to
> spacing in lambdas.
>
> Namely, some people write a lambda as:
> auto x = [] () { }
>
> with a space between [] and () while others would write it as:
>
> auto
11 matches
Mail list logo
