Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Geoffrey Garen
I also don't buy your conclusion -- that if regular expressions account for 1% of JavaScript time on the Internet overall, they need not be optimized. I never said that. You said the regular expression test was "most likely... the least relevant test" in SunSpider. You said implementors

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Maciej Stachowiak
On Jul 7, 2009, at 7:02 PM, Mike Belshe wrote: On Tue, Jul 7, 2009 at 5:08 PM, Maciej Stachowiak wrote: - property access, involving at least some polymorphic access patterns - method calls - object-oriented programming patterns - GC load - programming in a style that makes significant use

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Mike Belshe
On Tue, Jul 7, 2009 at 7:01 PM, Maciej Stachowiak wrote: > > On Jul 7, 2009, at 6:43 PM, Mike Belshe wrote: > > >> (There are other benchmarks that use summation, for example iBench, though >> I am not sure these are examples of excellent benchmarks. Any benchmark that >> consists of a single tes

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Mike Belshe
On Tue, Jul 7, 2009 at 5:08 PM, Maciej Stachowiak wrote: > > On Jul 7, 2009, at 4:19 PM, Peter Kasting wrote: > > For example, the framework could compute both sums _and_ geomeans, if >> people thought both were valuable. >> > > That's a plausible thing to do, but I think there's a downside: if

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Maciej Stachowiak
On Jul 7, 2009, at 6:43 PM, Mike Belshe wrote: (There are other benchmarks that use summation, for example iBench, though I am not sure these are examples of excellent benchmarks. Any benchmark that consists of a single test also implicitly uses summation. I'm not sure what other benchma

Re: [webkit-dev] Question about Constructors in WebKit JS Bindings

2009-07-07 Thread Adam Barth
On Tue, Jul 7, 2009 at 6:29 PM, Drew Wilson wrote: > Interesting - I ran some tests on both current WebKit and Firefox. > Firefox has a couple of interesting properties. For example this code: > Worker.prototype.foo = 3; > log("Worker.prototype.foo = " + Worker.prototype.foo); > var worker = new Wo

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Mike Belshe
On Tue, Jul 7, 2009 at 4:45 PM, Maciej Stachowiak wrote: > > On Jul 7, 2009, at 4:28 PM, Mike Belshe wrote: > > >> When SunSpider was first created, regexps were a small proportion of the >> total execution in what were the fastest publicly available at the time. >> Eventually, everything else go

Re: [webkit-dev] Question about Constructors in WebKit JS Bindings

2009-07-07 Thread Drew Wilson
Interesting - I ran some tests on both current WebKit and Firefox. Firefox has a couple of interesting properties. For example this code: Worker.prototype.foo = 3; log("Worker.prototype.foo = " + Worker.prototype.foo); var worker = new Worker("foobar.js"); log("worker.foo = " + worker.foo); yield

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Peter Kasting
On Tue, Jul 7, 2009 at 5:08 PM, Maciej Stachowiak wrote: > On Jul 7, 2009, at 4:19 PM, Peter Kasting wrote: > >> For example, the framework could compute both sums _and_ geomeans, if >> people thought both were valuable. >> > > That's a plausible thing to do, but I think there's a downside: if yo

Re: [webkit-dev] Question about Constructors in WebKit JS Bindings

2009-07-07 Thread Drew Wilson
On Tue, Jul 7, 2009 at 5:25 PM, Adam Barth wrote: > > I'd have to look at the code a bit more to know whether this is > correct. Where does |globalObject| come from? It comes from the JSDOMWindow object where that constructor is exposed. Case in point: #if ENABLE(CHANNEL_MESSAGING) JSValue JS

Re: [webkit-dev] Question about Constructors in WebKit JS Bindings

2009-07-07 Thread Adam Barth
I think it's quite likely that all the constructors are wrong. If you're in doubt, you can test Firefox and IE to see how they behave. On Tue, Jul 7, 2009 at 4:45 PM, Drew Wilson wrote: > So it seems like we should never reference lexicalGlobalObject in our > constructor/prototype creation code a

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Maciej Stachowiak
On Jul 7, 2009, at 4:19 PM, Peter Kasting wrote: For example, the framework could compute both sums _and_ geomeans, if people thought both were valuable. That's a plausible thing to do, but I think there's a downside: if you make a change that moves the two scores in opposite directions, t

Re: [webkit-dev] Question about Constructors in WebKit JS Bindings

2009-07-07 Thread Drew Wilson
OK, coming back around to this - I'm looking at the automatically generated constructors. As an example, let's look at something simple like EventException. JSEventExceptionConstructor(ExecState* exec) : DOMObject(JSEventExceptionConstructor::createStructure(exec->lexicalGlobalObject()-

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Maciej Stachowiak
On Jul 7, 2009, at 4:28 PM, Mike Belshe wrote: When SunSpider was first created, regexps were a small proportion of the total execution in what were the fastest publicly available at the time. Eventually, everything else got much faster. So at some point, SunSpider said "it might be a go

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Mike Belshe
On Tue, Jul 7, 2009 at 4:20 PM, Maciej Stachowiak wrote: > > On Jul 7, 2009, at 4:01 PM, Mike Belshe wrote: > > >> I'd like benchmarks to: >>a) have meaning even as browsers change over time >>b) evolve. as new areas of JS (or whatever) become important, the >> benchmark should have faci

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Mike Belshe
On Tue, Jul 7, 2009 at 3:58 PM, Geoffrey Garen wrote: > Are you saying that you did see Regex as being such a high percentage of >> javascript code? If so, we're using very different mixes of content for our >> tests. >> > > I'm saying that I don't buy your claim that regular expression performa

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Oliver Hunt
What you seem to think is better would be to repeatedly update sunspider everytime that something gets faster, ignoring entirely that the value in sunspider is precisely that it has not changed. Not quite what I'm saying :-) I'd like benchmarks to: a) have meaning even as browsers change

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Maciej Stachowiak
On Jul 7, 2009, at 4:01 PM, Mike Belshe wrote: I'd like benchmarks to: a) have meaning even as browsers change over time b) evolve. as new areas of JS (or whatever) become important, the benchmark should have facilities to include that. Fair? Good? Bad? I think we can't rule ou

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Peter Kasting
I'm more verbose than Mike, but it seems like people are talking past each other. On Tue, Jul 7, 2009 at 3:25 PM, Oliver Hunt wrote: > If we see one section of the test taking dramatically longer than another > then we can assume that we have not been paying enough attention to > performance in

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Mike Belshe
On Tue, Jul 7, 2009 at 3:25 PM, Oliver Hunt wrote: > > On Jul 7, 2009, at 3:01 PM, Mike Belshe wrote: > > On Mon, Jul 6, 2009 at 10:11 AM, Geoffrey Garen wrote: > >> So, what you end up with is after a couple of years, the slowest test in >>> the suite is the most significant part of the score.

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Geoffrey Garen
Are you saying that you did see Regex as being such a high percentage of javascript code? If so, we're using very different mixes of content for our tests. I'm saying that I don't buy your claim that regular expression performance should only count as 1% of a JavaScript benchmark. I don'

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Oliver Hunt
On Jul 7, 2009, at 3:01 PM, Mike Belshe wrote: On Mon, Jul 6, 2009 at 10:11 AM, Geoffrey Garen wrote: So, what you end up with is after a couple of years, the slowest test in the suite is the most significant part of the score. Further, I'll predict that the slowest test will most likely

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Mike Belshe
On Sat, Jul 4, 2009 at 3:27 PM, Maciej Stachowiak wrote: > > On Jul 4, 2009, at 11:47 AM, Mike Belshe wrote: > > I'd like to understand what's going to happen with SunSpider in the future. > Here is a set of questions and criticisms. I'm interested in how these can > be addressed. > > There are

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Mike Belshe
As I said, we can argue the mix of tests forever, but it is not useful. Yes, I would test using top-100 sites. In the future, if a benchmark claims to have a representative mix, it should document why. Right? Are you saying that you did see Regex as being such a high percentage of javascript cod

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Geoffrey Garen
So, I determined this through profiling. If you profile your browser while browsing websites, you won't find that it spends 20-30% of its javascript execution time running regex (even with the old pcre). What websites did you browse, and how did you choose them? Do you think your browsing

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Mike Belshe
On Mon, Jul 6, 2009 at 10:11 AM, Geoffrey Garen wrote: > So, what you end up with is after a couple of years, the slowest test in >> the suite is the most significant part of the score. Further, I'll predict >> that the slowest test will most likely be the least relevant test, because >> the tr

Re: [webkit-dev] Chrome build bot

2009-07-07 Thread Darin Fisher
We are working on it. It is taking more time than we'd like :-( For now, we only have an integration builder that tests tip-of-tree WebKit in a Chromium build environment: http://tinyurl.com/l9mops That's a big help to Chromium developers, but it isn't something well suited for the WebKit communi

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-07 Thread Eric Seidel
Oh, I did really like the idea of a prepare-ChangeLog "wizard" which someone suggested. Where it might ask you some of the relevant questions instead of filling in boilerplate. I continue to find it frustrating that I have to r- patches with bad ChangeLogs. :) I don't think that's so much contri

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-07 Thread Eric Seidel
I had intended to summarize this long thread which I started. But I've since realized that we're mostly bikeshedding here, so there isn't much actionable takeaway. :( Thank you to all of you for your thoughtful responses! I'm not at all attached to the current YELLING CHANGELOG TEMPLATE. :) But

Re: [webkit-dev] Isolated world tests

2009-07-07 Thread Adam Barth
On Mon, Jul 6, 2009 at 6:02 PM, Maciej Stachowiak wrote: > I was going to reply to Adam's last comment, and point out that (a) > his reasons for implementing for V8 only sound reasonable, but (b) I think > JSC-based ports may want the functionality in the near if not immediate > future, and would t

[webkit-dev] Chrome build bot

2009-07-07 Thread Eric Carlson
Chrome hackers - When do you plan to have a build bot on build.webkit.org? I broke your build yesterday with http://trac.webkit.org/changeset/45572 , but didn't realize it so Albert had to clean up after me (again, thanks Albert). I *try* not to break other builds but the media elemen

Re: [webkit-dev] About Word wrap in DumpRendertree

2009-07-07 Thread Dan Bernstein
On Jul 7, 2009, at 12:05 AM, bircov wrote: I have this question about the output of Dumprendertree:- If a simple html with a div with fixed width (300px or something) is given as input to dumprendertree, the word wrap shown by the output of dumprendertree differs from the word wrap observe

[webkit-dev] About Word wrap in DumpRendertree

2009-07-07 Thread bircov
I have this question about the output of Dumprendertree:- If a simple html with a div with fixed width (300px or something) is given as input to dumprendertree, the word wrap shown by the output of dumprendertree differs from the word wrap observed when html is viewed in the browser. I have att