Re: [webkit-dev] Whitespace changes

2009-08-27 Thread Roland Steiner
On Fri, Aug 28, 2009 at 6:22 AM, Dirk Pranke wrote: > > As to the trailing whitespace issue, I'm actually with you on this > one; I've never seen that mentioned or considered as a coding style > guideline before this project, and am continually getting tripped up > by it on Chromium's presubmit h

Re: [webkit-dev] Qtish API for JavaScriptCore

2009-08-27 Thread Geoffrey Garen
Hi Simon. What about functionality where the C API would slow down the C++ API but the internal JSC API is stable enough/good enough? If there are such areas, and they turn out to be substantial, we should look at speeding them up, for the benefit of all clients of the C API. I can th

Re: [webkit-dev] Qtish API for JavaScriptCore

2009-08-27 Thread Oliver Hunt
On Aug 27, 2009, at 2:30 PM, Simon Hausmann wrote: Hi Oliver, On Wednesday 26 August 2009 11:04:29 pm ext Oliver Hunt wrote: Hi Simon, It would really be preferred if the Qt API were just built on top of the standard JSC C-API, and was kept external from the repository. We would like to

Re: [webkit-dev] Qtish API for JavaScriptCore

2009-08-27 Thread Simon Hausmann
On Thursday 27 August 2009 10:09:38 am ext Kalle Vahlman wrote: > 2009/8/26 Simon Hausmann : > > Hi fellow WebKit contributors! > > > > Currently the Qt port of WebKit merely provides an API to deal with > > rendering web content, and as such our interface to the underlying > > JavaScriptCore engin

Re: [webkit-dev] Qtish API for JavaScriptCore

2009-08-27 Thread Simon Hausmann
Hi Oliver, On Wednesday 26 August 2009 11:04:29 pm ext Oliver Hunt wrote: > Hi Simon, > It would really be preferred if the Qt API were just built on top > of the standard JSC C-API, and was kept external from the repository. We would like to utilize a Qt JSC API in the Qt API of WebKit, too

Re: [webkit-dev] Whitespace changes

2009-08-27 Thread Dirk Pranke
On Thu, Aug 27, 2009 at 1:37 PM, Mark Rowe wrote: >> +1 >> >> I see little point in having coding standards if you don't encourage >> people to use them. There is enough churn in the tree that there are >> already a large number of changes to skip over, so skipping over >> reformatting (even whites

Re: [webkit-dev] Whitespace changes

2009-08-27 Thread Jeremy Orlow
On Thu, Aug 27, 2009 at 1:37 PM, Mark Rowe wrote: > > On 2009-08-27, at 12:57, Dirk Pranke wrote: > > On Thu, Aug 27, 2009 at 11:55 AM, Peter Kasting >> wrote: >> >>> On Wed, Aug 26, 2009 at 10:43 PM, David Levin >>> wrote: >>> fwiw, I know that the check-webkit-style checks for trail

Re: [webkit-dev] Whitespace changes

2009-08-27 Thread Mark Rowe
On 2009-08-27, at 12:57, Dirk Pranke wrote: On Thu, Aug 27, 2009 at 11:55 AM, Peter Kasting wrote: On Wed, Aug 26, 2009 at 10:43 PM, David Levin wrote: fwiw, I know that the check-webkit-style checks for trailing whitespace (and I approved that change - sorry), but I think it should p

Re: [webkit-dev] Whitespace changes

2009-08-27 Thread Jeremy Orlow
On Thu, Aug 27, 2009 at 1:29 PM, Mark Rowe wrote: > > On 2009-08-27, at 11:55, Peter Kasting wrote: > > On Wed, Aug 26, 2009 at 10:43 PM, David Levin wrote: > >> fwiw, I know that the check-webkit-style checks for trailing whitespace >> (and I approved that change - sorry), but I think it should

Re: [webkit-dev] Problem with StringImpl methods (characters() and length())

2009-08-27 Thread Darin Adler
On Aug 27, 2009, at 11:56 AM, Seweryn Pływaczyk wrote: I suppose that I built something in wrong way (under WinCE) but I have really no idea where I should start an investigation. This typically means that you have built different source files with different settings. I’m betting some code

Re: [webkit-dev] Whitespace changes

2009-08-27 Thread Mark Rowe
On 2009-08-27, at 11:55, Peter Kasting wrote: On Wed, Aug 26, 2009 at 10:43 PM, David Levin wrote: fwiw, I know that the check-webkit-style checks for trailing whitespace (and I approved that change - sorry), but I think it should probably be removed. Maintaining a cultural attitude tha

Re: [webkit-dev] Fwd: Whitespace changes

2009-08-27 Thread Darin Fisher
On Thu, Aug 27, 2009 at 1:18 PM, Eric Seidel wrote: > On Thu, Aug 27, 2009 at 11:55 AM, Peter Kasting wrote: > >> Maintaining a cultural attitude that is widely positive towards cleanup >> makes people feel less reticent about cleaning up, and taking ownership of, >> code; frowning on certain ty

[webkit-dev] Fwd: Whitespace changes

2009-08-27 Thread Eric Seidel
On Thu, Aug 27, 2009 at 11:55 AM, Peter Kasting wrote: > Maintaining a cultural attitude that is widely positive towards cleanup > makes people feel less reticent about cleaning up, and taking ownership of, > code; frowning on certain types of cleanup makes people less likely to do > _any_ clean

Re: [webkit-dev] Whitespace changes

2009-08-27 Thread Dirk Pranke
On Thu, Aug 27, 2009 at 11:55 AM, Peter Kasting wrote: > On Wed, Aug 26, 2009 at 10:43 PM, David Levin wrote: >> >> fwiw, I know that the check-webkit-style checks for trailing whitespace >> (and I approved that change - sorry), but I think it should probably be >> removed. > > Since opinions were

Re: [webkit-dev] Standing of the WINCE port

2009-08-27 Thread Peter Kasting
On Wed, Aug 26, 2009 at 10:00 PM, Adam Barth wrote: > Is the WINCE port in a bad standing of some sort, or can reviews of > WINCE patches proceed as normal? > On a related note, I have heard rumors that the acquisition of Torch Mobile means that their development of a WinCE-based browser will ce

[webkit-dev] Problem with StringImpl methods (characters() and length())

2009-08-27 Thread Seweryn Pływaczyk
Hi I have a strange problem with the mentioned methods and I'd like to ask if someone of you had a similar one. During initialization of AtomicString CStringTranslator::equal(StringImpl* r, const char* s) is called. There are the following lines inside of this method : int length = r->length();

Re: [webkit-dev] Whitespace changes

2009-08-27 Thread Peter Kasting
On Wed, Aug 26, 2009 at 10:43 PM, David Levin wrote: > fwiw, I know that the check-webkit-style checks for trailing whitespace > (and I approved that change - sorry), but I think it should probably be > removed. > Since opinions were requested, I'm in favor of both the check-webkit-style change

Re: [webkit-dev] Implementation thoughts on HTML5 elements

2009-08-27 Thread Peter Kasting
On Wed, Aug 26, 2009 at 6:20 PM, Anthony Ricaud wrote: > So what about number implementation ? I have no idea what state number is currently in so I have avoided commenting on it. I know the intent was to provide a spinbox, and that there have been people actively working on it recently, but t

Re: [webkit-dev] Inline vs Inline Block and relative positioning for MathML

2009-08-27 Thread David Hyatt
You really don't want to use relative positioning to move objects around like this. The objects should just be placed into the correct positions by the layout() method without having to resort to relative positioning. You also can't mutate a DOM-backed renderer's style like that as it co

Re: [webkit-dev] Standing of the WINCE port

2009-08-27 Thread KwangYul Seo
Hi, 2 WINCE ports are not competing. We are waiting for Torch Mobile to finish the WINCE port not to cause conflicts as you can see in: https://bugs.webkit.org/show_bug.cgi?id=27076 I submitted the Geolocation WINCE patch because the Torch Mobile WINCE port does not have one: https://bugs.webk

[webkit-dev] Inline vs Inline Block and relative positioning for MathML

2009-08-27 Thread Alex Milowski
I'm struggling with something I don't quite understand. I get a different behavior when the superscript is an instance of RenderInline versus and inline-block instance of RenderBlock for the superscript. Specifically, it works just fine in the case of the RenderInline but not when the superscript

Re: [webkit-dev] Qtish API for JavaScriptCore

2009-08-27 Thread Kalle Vahlman
2009/8/26 Simon Hausmann : > Hi fellow WebKit contributors! > > Currently the Qt port of WebKit merely provides an API to deal with rendering > web content, and as such our interface to the underlying JavaScriptCore engine > is minimal. > > We, the team of Qt developers at Nokia and INdT, would lik