Re: [webkit-dev] WebKit Icon license?

On Mar 23, 2010, at 9:00 PM, Shinichiro Hamaji wrote: A related P1 issue :) http://webkit.org/b/19371 Want. Where can I obtain that shirt? - Maciej On Wed, Mar 24, 2010 at 9:28 AM, Maciej Stachowiak wrote: On Mar 23, 2010, at 3:25 AM, Jeremy Orlow wrote: It seems as though we shoul

Re: [webkit-dev] WebKit Icon license?

A related P1 issue :) http://webkit.org/b/19371 On Wed, Mar 24, 2010 at 9:28 AM, Maciej Stachowiak wrote: > > On Mar 23, 2010, at 3:25 AM, Jeremy Orlow wrote: > > It seems as though we should at very least change the main icon on > webkit.org to match what is apparently the official webkit logo.

[webkit-dev] Question about WML support

Is that anyone working with WML in webkit? I use webkit to open the wml page, meet a fata error. In file:"WebCore\rendering\RenderTextControlSingleLine.cpp",the "inputElement()" return NULL value,that cause "inputElement()->isSearchField()" access memory error. I trace into "InputElement.cpp",

Re: [webkit-dev] Advise on spellchecker bug

On Tue, Mar 23, 2010 at 12:35 PM, Tony Gentilcore wrote: > 2. Where is the best place to add a test for my fix? It doesn't seem to be > possible to test this through a LayoutTest. If the answer to #1 is that this > is port-specific behavior, then I can add a chromium/tests. If this is not > port-s

Re: [webkit-dev] Question regarding build flags for the features

On Mar 23, 2010, at 1:22 PM, Dmitry Titov wrote: If we had a single flag for all those (ENABLE_FILE_API ?) then a port would have to implement all features at once to be able to enable it. It might be inconvenient. If the code is not shared and those flags can be enabled in any combination

Re: [webkit-dev] WebKit Icon license?

On Mar 23, 2010, at 3:25 AM, Jeremy Orlow wrote: It seems as though we should at very least change the main icon on webkit.org to match what is apparently the official webkit logo. The icons for the Mac and Windows nightlies probably needn't change since they're run within Safari anyway,

Re: [webkit-dev] AbsoluteClippedOverflowRect return empty IntRect

Hi Simon. That was my thought. Thank you for confirming. On Tue, Mar 23, 2010 at 2:54 PM, Simon Fraser wrote: > On Mar 23, 2010, at 11:38 AM, tonikitoo (Antonio Gomes) wrote: > >> Hey all. >> >> I am facing a strange issue while trying to the get repaintable rect >> of a given Node* object. In m

Re: [webkit-dev] Question regarding build flags for the features

If we had a single flag for all those (ENABLE_FILE_API ?) then a port would have to implement all features at once to be able to enable it. It might be inconvenient. If the code is not shared and those flags can be enabled in any combination, why not keep them separate? On a related note, it'd be

[webkit-dev] Advise on spellchecker bug

I'm new to WebKit, so apologies in advance for my ignorance. There is a chromium bug that we don't update the spelling markers when spell checking is toggled or the language is changed (http://crbug.com/21225). I have a fix ready for this which simply re-checks the field upon toggle. But this ste

Re: [webkit-dev] AbsoluteClippedOverflowRect return empty IntRect

On Mar 23, 2010, at 11:38 AM, tonikitoo (Antonio Gomes) wrote: > Hey all. > > I am facing a strange issue while trying to the get repaintable rect > of a given Node* object. In my code I am doing something like: > > (...) > ASSERT(node); > node->renderer()->absoluteClippedOverflowRect(); > (...)

Re: [webkit-dev] Members m_dragSrcMayBeUA and m_dragSrcIsDHTML of EventHandlerDragState don't seem to ever be set...

Sorry, m_dragSrcMayBeUA is set only for Mac builds. But http://www.google.com/codesearch?q=m_dragSrcIsDHTML&hl=en&btnG=Search+Code does not seem to be. On Tue, Mar 23, 2010 at 3:05 PM, Buakaw San wrote: > See EvenHandler

[webkit-dev] Members m_dragSrcMayBeUA and m_dragSrcIsDHTML of EventHandlerDragState don't seem to ever be set...

See EvenHandlerDragState in EventHandler.cpp http://www.google.com/codesearch/p?hl=en#N6Qhr5kJSgQ/WebCore/page/EventHandler.h&q=class:EventHandlerDragState&sa=N&cd=1&ct=rc A quick codesearch or grep for m_dragSrcMayBeUA or m_dragSrcIsDHTML shows that these members are accessed but never set in th

[webkit-dev] AbsoluteClippedOverflowRect return empty IntRect

Hey all. I am facing a strange issue while trying to the get repaintable rect of a given Node* object. In my code I am doing something like: (...) ASSERT(node); node->renderer()->absoluteClippedOverflowRect(); (...) , where "node" is a valid reference to an in the following simple html sample i

[webkit-dev] Question regarding build flags for the features

Hi, I've introduced a build flag ENABLE(BLOB_SLICE) for the Blob.slice feature. To continue implementing other File API features, we probably need a couple more build flags, like ENABLE(FILE_URN) and ENABLE(FILE_READER). When the embedder implements the necessary support, these flags can be turned

Re: [webkit-dev] WebKit Icon license?

On Tue, Mar 23, 2010 at 3:31 AM, Jeremy Orlow wrote: > And does anyone know where the original artwork is and/or came from? Here is a clue: http://trac.webkit.org/browser/trunk/PlanetWebKit/wwwroot/images/planet-webkit.png?rev=28380 The "Tim" mentioned here (who potentially put the logo togethe

Re: [webkit-dev] WebKit Icon license?

And does anyone know where the original artwork is and/or came from? On Tue, Mar 23, 2010 at 10:25 AM, Jeremy Orlow wrote: > It seems as though we should at very least change the main icon on > webkit.org to match what is apparently the official webkit logo. The > icons for the Mac and Windows

Re: [webkit-dev] WebKit Icon license?

It seems as though we should at very least change the main icon on webkit.org to match what is apparently the official webkit logo. The icons for the Mac and Windows nightlies probably needn't change since they're run within Safari anyway, but probably the nightly source icon should change. Anyon

Re: [webkit-dev] Leading new-line in dataTransfer.setData

Hm, I guess I've been successfully convinced otherwise (i.e., "patch upcoming!")... ^_^; - Roland On Tue, Mar 23, 2010 at 5:53 PM, Maciej Stachowiak wrote: > > On Mar 23, 2010, at 1:40 AM, Roland Steiner wrote: > > Hm, but the first line could also be a comment (starting with '#') which > Mozil

Re: [webkit-dev] Leading new-line in dataTransfer.setData

On Mar 23, 2010, at 1:40 AM, Roland Steiner wrote: Hm, but the first line could also be a comment (starting with '#') which Mozilla also skips. IOW, I read the spec as "return the first line that is a (valid) URL". But of course I could be convinced otherwise... It doesn't start with "#"

Re: [webkit-dev] Leading new-line in dataTransfer.setData

On Tue, 23 Mar 2010, Roland Steiner wrote: > > Hm, but the first line could also be a comment (starting with '#') which > Mozilla also skips. IOW, I read the spec as "return the first line that > is a (valid) URL". But of course I could be convinced otherwise... The empty string is a valid URL.

Re: [webkit-dev] Leading new-line in dataTransfer.setData

Hm, but the first line could also be a comment (starting with '#') which Mozilla also skips. IOW, I read the spec as "return the first line that is a (valid) URL". But of course I could be convinced otherwise... Cheers, - Roland On Tue, Mar 23, 2010 at 5:37 PM, Maciej Stachowiak wrote: > > On

Re: [webkit-dev] Leading new-line in dataTransfer.setData

On Mar 23, 2010, at 1:01 AM, Roland Steiner wrote: Hi all, On the topic of dataTransfer.setData, there seems to be a small inconsistency between browsers when it comes to leading new-lines. e.g., dataTransfer.setData("text/uri-list", "\nhttp://foo";) followed by dataTransfer.getData("URL

[webkit-dev] Leading new-line in dataTransfer.setData

Hi all, On the topic of dataTransfer.setData, there seems to be a small inconsistency between browsers when it comes to leading new-lines. e.g., dataTransfer.setData("text/uri-list", "\nhttp://foo";) followed by dataTransfer.getData("URL"). Mozilla returns an empty string (see http://mxr.mozilla.