Re: [webkit-dev] On returning mutable pointers from const methods

2012-10-29 Thread Maciej Stachowiak
On Oct 28, 2012, at 10:09 PM, Peter Kasting pkast...@chromium.org wrote: On Sun, Oct 28, 2012 at 6:12 AM, Maciej Stachowiak m...@apple.com wrote: I am not sure a blanket rule is correct. If the Foo* is logically related to the object with the foo() method and effectively would give access to

Re: [webkit-dev] On returning mutable pointers from const methods

2012-10-29 Thread Peter Kasting
On Sun, Oct 28, 2012 at 11:16 PM, Maciej Stachowiak m...@apple.com wrote: On Oct 28, 2012, at 10:09 PM, Peter Kasting pkast...@chromium.org wrote: On Sun, Oct 28, 2012 at 6:12 AM, Maciej Stachowiak m...@apple.com wrote: I am not sure a blanket rule is correct. If the Foo* is logically

[webkit-dev] question about jsc

2012-10-29 Thread yuqing cai
hi, all, I try to port the webkit to a new platform(the platform is linux based run with glibc glib, but not gtk), now I have build the jsc project successfully, but when I run the jsc program, something happend show as below:

Re: [webkit-dev] DRT/WTR should clear the cache at the beginning of each test?

2012-10-29 Thread Maciej Stachowiak
On Oct 28, 2012, at 3:30 PM, Antti Koivisto koivi...@iki.fi wrote: We could clear the cache between tests but run each test twice in a row. Second run will then happen with deterministically pre-populated cache. That would both make things more predictable and improve our test coverage for

[webkit-dev] How to modify JsHTMLMediaElement.cpp to add STOP fucntionality

2012-10-29 Thread ankit srivastav
Hi All, I'm trying to add stop functionality in my application which is using webkit on WIN port. currently Play and Pause functions are available but no STOP function is present , so in JsHTMLMediaElement.cpp I have added a new function: jsHTMLMediaElementPrototypeFunctionStop(ExecState*

Re: [webkit-dev] On returning mutable pointers from const methods

2012-10-29 Thread Antti Koivisto
I don't think the original proposal was meant to apply to the basic container types. Would this be a sensible rule to adopt for WebCore only for example? Like all our blanket rules, this one should be ignored when it doesn't make sense. If that kind of cases are expected to be very rare then

Re: [webkit-dev] On returning mutable pointers from const methods

2012-10-29 Thread Maciej Stachowiak
On Oct 29, 2012, at 3:47 PM, Antti Koivisto koivi...@iki.fi wrote: I don't think the original proposal was meant to apply to the basic container types. Would this be a sensible rule to adopt for WebCore only for example? Like all our blanket rules, this one should be ignored when it

Re: [webkit-dev] question about jsc

2012-10-29 Thread Michael Saboff
The output of undefined is normal. It is the result of the expression you entered. jsc is basically returning the result of the expressions you enter. Both var and print themselves evaluate to undefined. If you try x = 1; you'll get 1 as that expression returns 1. Concerning testing, If

Re: [webkit-dev] question about jsc

2012-10-29 Thread yuqing cai
Michael, Thanks for your reply, now I understand it. :~) 于 2012年10月29日 23:16, Michael Saboff 写道: The output of undefined is normal. It is the result of the expression you entered. jsc is basically returning the result of the expressions you enter. Both var and print themselves evaluate to

Re: [webkit-dev] DRT/WTR should clear the cache at the beginning of each test?

2012-10-29 Thread Dirk Pranke
On Mon, Oct 29, 2012 at 5:48 AM, Maciej Stachowiak m...@apple.com wrote: On Oct 28, 2012, at 10:09 PM, Dirk Pranke dpra...@chromium.org wrote: On Sun, Oct 28, 2012 at 6:32 AM, Maciej Stachowiak m...@apple.com wrote: I think the nature of loader and cache code is that it's very hard to make

Re: [webkit-dev] Performance Tests

2012-10-29 Thread Ryosuke Niwa
Thanks a lot for your work :) This is a huge improvement to our perf. test infrastructure. On Mon, Oct 29, 2012 at 3:01 PM, Zoltan Horvath zol...@webkit.org wrote: Hi there, In the past few weeks I made some refactoring work on the PageLoad tests of the PerformanceTests, so now for your

Re: [webkit-dev] Some stderr output missing when using run-webkit-tests

2012-10-29 Thread Dana Jansens
On Mon, Oct 29, 2012 at 6:59 PM, Dirk Pranke dpra...@chromium.org wrote: If that's the case, it's a bug, and new to me. The output was present on the results page, but it would only include the first, maybe, 60 lines or so. - Dana -- Dirk On Mon, Oct 29, 2012 at 3:42 PM, Terry Anderson