Re: [webkit-dev] ReadMe.md on Github

2017-02-21 Thread Konstantin Tokarev
  22.02.2017, 10:18, "Brian Burg" : On Feb 21, 2017, at 10:53 PM, Ryosuke Niwa wrote: Hi, I recently added ReadMe.md file to WebKit's top-level directory for the convenience of Github users: https://github.com/WebKit/webkit I've added a very abridged instruction

Re: [webkit-dev] ReadMe.md on Github

2017-02-21 Thread Brian Burg
> On Feb 21, 2017, at 10:53 PM, Ryosuke Niwa wrote: > > Hi, > > I recently added ReadMe.md file to WebKit's top-level directory for the > convenience of Github users: https://github.com/WebKit/webkit > > > I've added a very abridged

[webkit-dev] ReadMe.md on Github

2017-02-21 Thread Ryosuke Niwa
Hi, I recently added ReadMe.md file to WebKit's top-level directory for the convenience of Github users: https://github.com/WebKit/webkit I've added a very abridged instruction on how to checkout & build WebKit for Mac/iOS ports for simplicity. It would be great if we can trim down the amount of

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

2017-02-21 Thread Mark Lam
Oh yeah, I forgot about that. I think the register state is more important for crash analysis, especially if we can make sure that the compiler does not aggregate the int3s. I’ll explore alternatives. > On Feb 21, 2017, at 5:54 PM, Saam barati wrote: > > I thought the

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

2017-02-21 Thread Saam barati
I thought the main point of moving to SIGTRAP was to preserve register state? That said, there are probably places where we care more about the message than the registers. - Saam > On Feb 21, 2017, at 5:43 PM, Mark Lam wrote: > > Is there a reason why RELEASE_ASSERT (and

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

2017-02-21 Thread Filip Pizlo
+1 -Filip > On Feb 21, 2017, at 17:43, Mark Lam wrote: > > Is there a reason why RELEASE_ASSERT (and friends) does not call > WTFReportAssertionFailure() to report where the assertion occur? Is this > purely to save memory? svn blame tells me that it has been this way

[webkit-dev] Why does RELEASE_ASSERT not have an error message?

2017-02-21 Thread Mark Lam
Is there a reason why RELEASE_ASSERT (and friends) does not call WTFReportAssertionFailure() to report where the assertion occur? Is this purely to save memory? svn blame tells me that it has been this way since the introduction of RELEASE_ASSERT in r140577 many years ago. Would anyone

Re: [webkit-dev] CSS Parse error in element.

2017-02-21 Thread Atul Sowani
I compared the code of TP5 with the code of default qtwebkit in PhantomJS and did not find any difference. So I think PhantomJS is making use of the latest version of QtWebKit. On Fri, Feb 17, 2017 at 4:04 PM, Konstantin Tokarev wrote: > > > 17.02.2017, 12:19, "Atul Sowani"