Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-10 Thread Andy Estes
> On May 10, 2017, at 3:17 PM, Michael Catanzaro wrote: > > On Tue, May 9, 2017 at 2:57 PM, Ryosuke Niwa wrote: >> One annoying thing is that I've seen clang complaining about that >> return statement being an unreachable statement while gcc doesn't :(. >> So we probably shouldn't have return

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-10 Thread Michael Catanzaro
On Tue, May 9, 2017 at 2:57 PM, Ryosuke Niwa wrote: One annoying thing is that I've seen clang complaining about that return statement being an unreachable statement while gcc doesn't :(. So we probably shouldn't have return statement, not to mention that 0 may not be a valid enum value. In th

Re: [webkit-dev] Performance Difference between Webkit and Wekit2 API's

2017-05-10 Thread Ryosuke Niwa
On Wed, May 10, 2017 at 6:19 AM, Rodney Dowdall wrote: > We currently have a port of WebKit that uses the WebKit API. It works > well, but the performance isn't quite at the level of some other WebKit > ports. > > I was wondering if there would be an expected performance gain by using > the Webk

Re: [webkit-dev] Also in the tradition of massive renames

2017-05-10 Thread Ryosuke Niwa
I support both the directory & Xcode project renames. It's long overdue! - R. Niwa On Wed, May 10, 2017 at 12:42 PM, Dan Bernstein wrote: > I suggest that when this takes place, the Xcode projects within these > directories get renamed as well, to maintain the invariant that the > .xcodeproj i

Re: [webkit-dev] Also in the tradition of massive renames

2017-05-10 Thread Dan Bernstein
I suggest that when this takes place, the Xcode projects within these directories get renamed as well, to maintain the invariant that the .xcodeproj is named after the enclosing directory. > On May 10, 2017, at 11:18 AM, Maciej Stachowiak wrote: > > > I'd like to propose the following directo

Re: [webkit-dev] User agent woes

2017-05-10 Thread Michael Catanzaro
I noticed a UI change on Google Maps today: Earth Mode (which previously indicated we were getting full-featured 3D functionality) has been replaced with Satellite Mode (which was previously the low-functionality 2D version). At first I was worried that we would need to find a new quirk to make

[webkit-dev] Also in the tradition of massive renames

2017-05-10 Thread Maciej Stachowiak
I'd like to propose the following directory renames for consideration: Source/WebKit --> Source/WebKitLegacy (or alternately, LegacyWebKit for autocomplete happiness, but maybe not if we keep the LayoutTests name) Source/WebKit2 --> Source/WebKit Reasons: - Matches the current names of the buil

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Maciej Stachowiak
> On May 10, 2017, at 2:51 AM, Konstantin Tokarev wrote: > > > > 10.05.2017, 12:42, "Ryosuke Niwa" >: > On Wed, May > 10, 2017 at 2:14 AM, Ryosuke Niwa < > rn...@webkit.org > > wrote: >>> On Wed, May 10, 2017 at 12:02 AM, Maciej Stachow

Re: [webkit-dev] Performance Difference between Webkit and Wekit2 API's

2017-05-10 Thread Geoffrey Garen
Though I don’t have specific numbers to share, WebKit2’s design generally provides much better performance under these conditions: (1) Faster: Long-running JavaScript programs on iOS; (2) Faster and smoother: Scrolling; (3) Faster and smoother: More than one webpage open at once; (4) Less memo

Re: [webkit-dev] Unsubscribe

2017-05-10 Thread Lucas Forschler
I’m will look into this, thanks for letting us know. Lucas > On May 9, 2017, at 10:50 PM, Peter Frane wrote: > > I've been trying to to retrieve my password but the "remind" button here does > not work: https://lists.webkit.org/mailman/options/webkit-dev >

Re: [webkit-dev] Performance Difference between Webkit and Wekit2 API's

2017-05-10 Thread Konstantin Tokarev
10.05.2017, 16:20, "Rodney Dowdall" : > Hello > > We currently have a port of WebKit that uses the WebKit API.  It works well, > but the performance isn't quite at the level of some other WebKit ports. > > I was wondering if there would be an expected performance gain by using the > Webkit2 API

[webkit-dev] Performance Difference between Webkit and Wekit2 API's

2017-05-10 Thread Rodney Dowdall
Hello We currently have a port of WebKit that uses the WebKit API. It works well, but the performance isn't quite at the level of some other WebKit ports. I was wondering if there would be an expected performance gain by using the Webkit2 API. My line of thinking is that the streamlining that t

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Konstantin Tokarev
10.05.2017, 12:42, "Ryosuke Niwa" : > On Wed, May 10, 2017 at 2:14 AM, Ryosuke Niwa wrote: >>  On Wed, May 10, 2017 at 12:02 AM, Maciej Stachowiak wrote: >>>  IntegrationTests doesn't distinguish them from performance tests, or API >>>  tests. And most test integration only incidentally. Functi

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Ryosuke Niwa
On Wed, May 10, 2017 at 2:14 AM, Ryosuke Niwa wrote: > On Wed, May 10, 2017 at 12:02 AM, Maciej Stachowiak wrote: >> >> IntegrationTests doesn't distinguish them from performance tests, or API >> tests. And most test integration only incidentally. FunctionalTests doesn't >> distinguish them from

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Ryosuke Niwa
On Wed, May 10, 2017 at 12:02 AM, Maciej Stachowiak wrote: > > IntegrationTests doesn't distinguish them from performance tests, or API > tests. And most test integration only incidentally. FunctionalTests doesn't > distinguish them from any of the other kinds of tests besides performance > tests.

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Maciej Stachowiak
A few more coats of paint for the bike shed: > On May 9, 2017, at 10:45 PM, Ryosuke Niwa wrote: > > On Tue, May 9, 2017 at 10:23 PM, Maciej Stachowiak > wrote: > > On May 9, 2017, at 9:07 PM, Michael Catanzaro > < mcatanz...@igalia.com >