Re: [webkit-dev] adding script type to webcore

2009-10-17 Thread Dan Bernstein
On Oct 17, 2009, at 1:47 PM, Alexander Cohen wrote: Hello, Forgive me if this is a very vague question, but where should i start in webkit to view how it implements the script tag and how it starts evaluating JS. I'm looking into adding a new script type and having it evaluated and run.

Re: [webkit-dev] How does Zooming Work?

2009-10-06 Thread Dan Bernstein
On Oct 6, 2009, at 8:49 PM, Alex Milowski wrote: What exactly happens during a zoom (command +/-) ? Depends on the flavor of zoom (“full-page” zoom vs. text-only zoom), but in both cases, a full style recalculation for the document is forced. I have code that works well but layout does

Re: [webkit-dev] Purging as much memory as possible

2009-10-01 Thread Dan Bernstein
On Oct 1, 2009, at 6:24 PM, Peter Kasting wrote: * Does anyone already know the likely footprint of the Glyph cache, or how to clear it? FontCache::purgeInactiveFontData(). If you’re using Safari then you can see Font and Glyph Caches statistics in its Caches window, which also includes a

Re: [webkit-dev] map tag and zoom donot work ..?

2009-09-18 Thread Dan Bernstein
On Sep 18, 2009, at 8:09 AM, Simon Fraser wrote: On Sep 17, 2009, at 11:08 PM, Purushottam Sholapur wrote: Hi All, Web pages with < map > tag do not behave as expected when page is zoomed. Typically, map tag with coords property do not scale properly when page is zoomed. E.g: http://24

Re: [webkit-dev] Whitespace changes

2009-08-26 Thread Dan Bernstein
On Aug 26, 2009, at 10:35 PM, Oliver Hunt wrote: Adam just landed a fairly substantial patch that did nothing but remove whitespace from the ends of lines. While we had a thread about style changes earlier, it was in the context of changes that actually bring code into line with style gui

Re: [webkit-dev] LayoutTest results choose from which folder?

2009-08-25 Thread Dan Bernstein
On Aug 25, 2009, at 4:38 PM, Dirk Pranke wrote: On Sun, Aug 23, 2009 at 12:23 PM, Dan Bernstein wrote: On Aug 23, 2009, at 11:28 AM, Dirk Pranke wrote: Hi Chris, In layout test results, we make the latest Mac OS X version the rule, and earlier versions the exception. Tiger will look for

Re: [webkit-dev] LayoutTest results choose from which folder?

2009-08-23 Thread Dan Bernstein
On Aug 23, 2009, at 11:28 AM, Dirk Pranke wrote: Hi Chris, In layout test results, we make the latest Mac OS X version the rule, and earlier versions the exception. Tiger will look for results in mac- tiger first, then in mac-leopard, then in mac-snowleopard, then in mac, then finally in

Re: [webkit-dev] LayoutTest results choose from which folder?

2009-08-22 Thread Dan Bernstein
On Aug 22, 2009, at 10:33 AM, Chris Fleizach wrote: I just committed http://trac.webkit.org/changeset/47675 which affects LayoutTest/accessibility/aria-roles.html The result is different on SnowLeopard than it is on Tiger/Leopard To account for this difference, I have an -expected file in p

[webkit-dev] WinCE Font work

2009-08-05 Thread Dan Bernstein
Hi, Today while looking at the patch at I noticed that the WinCE version of FontCustomPlatformData includes CachedFont.h and uses CachedFont. It is incorrect for classes in the platform layer to have any knowledge of higher WebCore layers (e

Re: [webkit-dev] Patch process - let's make it better

2009-07-10 Thread Dan Bernstein
On Jul 10, 2009, at 4:17 PM, Chris Marrin wrote: The annoying part is the fact that I ALWAYS get conflicts in at least one Changelog file when I try to check in. I have to fix these by hand, do svn resolved, and try to check in again. No you don’t. You can just use WebKitTools/Scripts/reso

Re: [webkit-dev] About Word wrap in DumpRendertree

2009-07-07 Thread Dan Bernstein
On Jul 7, 2009, at 12:05 AM, bircov wrote: I have this question about the output of Dumprendertree:- If a simple html with a div with fixed width (300px or something) is given as input to dumprendertree, the word wrap shown by the output of dumprendertree differs from the word wrap observe

[webkit-dev] Text control rules in themeWin.css

2009-07-06 Thread Dan Bernstein
Hi folks, I was looking at themeWin.css and noticed a few rules relating to text controls. Can anyone shed a light on their purpose and why they are in themeWin.css rather than in html4.css or in a port-specific theme? Specifically, these rules: input:not([type]), input[type="text"], input

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-01 Thread Dan Bernstein
On Jul 1, 2009, at 10:44 PM, Eric Seidel wrote: prepare-ChangeLog should have a --bug= argument and use it for url autofill https://bugs.webkit.org/show_bug.cgi?id=26383 I would much prefer if the bug URL came first. I believe that this is the prevailing style. Thanks, —Dan

Re: [webkit-dev] what's important in layouttests?

2009-06-25 Thread Dan Bernstein
On Jun 25, 2009, at 7:54 PM, David Jones wrote: I am confused about webkit's layouttests. 1.What's the layouttess used for? The layout tests are used to detect unintended changes in engine behavior, which are typically regressions. Are they provided only for developers who want to create

Re: [webkit-dev] Need help in understanding Webkit text wrapping

2009-03-09 Thread Dan Bernstein
On Mar 9, 2009, at 6:48 PM, Meryl Silverburgh > wrote: Hi, Can you please tell me where is the Webkit code which does text wrapping? For example, I have a paragraph of text. How does Webkit decide where to break into multiple lines? RenderBlock::findNextLineBreak() in bidi.cpp.

Re: [webkit-dev] currently failing regression tests on Mac OS X Leopard

2009-03-06 Thread Dan Bernstein
On Mar 6, 2009, at 7:47 AM, Darin Adler wrote: After fixing the test I could easily deal with myself, the following tests are failing for me: fast/block/float/t0905-c414-flt-fit-01-d-g.html fast/block/float/t0905-c5525-fltblck-00-d-ag.html fast/block/float/t0905-c5526-flthw-00-c-g

Re: [webkit-dev] Build error when source tree on alternate volume

2009-01-07 Thread Dan Bernstein
Unfortunately, WebKit cannot be built when there are spaces in the path to the source tree. See . On Jan 7, 2009, at 1:14 PM, Ross Lillie wrote: I'm getting build errors when building WebKit on OS X (10.5.6, Xcode 3.1.1) when the source tree i

Re: [webkit-dev] Getting more buildbots green

2009-01-03 Thread Dan Bernstein
On Jan 3, 2009, at 11:41 AM, Darin Adler wrote: editing/selection/move-left-right.html — The failure here is curious. The actual test output seems to be unchanged, but all the WARNING lines mentioning moving in the wrong direction seem to be missing. Mitz, can you help? I never under

Re: [webkit-dev] FontCache refactoring proposal

2008-12-11 Thread Dan Bernstein
Hi Julien, On Dec 11, 2008, at 2:14 AM, Julien Chaffraix wrote: Hi everyone, while working on memory leaks inside WebCore, the Pleyo team has found that the FontCache was responsible for a few of them. It would be good to have a bug filed about each leak. In order to solve those leaks and

Re: [webkit-dev] Need help in understanding web kit

2008-12-09 Thread Dan Bernstein
On Dec 9, 2008, at 10:19 PM, ying lcs wrote: Hi, Can you please point me to the part of Webkit rendering code where it does text wrapping? for example , how does it determine when to break a paragraph into multiple lines of text? Thank you. Line layout is implemented in WebCore/rendering/bi

Re: [webkit-dev] calcPrefWidths, SimpleFontData, and text fields (oh my!)

2008-11-19 Thread Dan Bernstein
On Nov 19, 2008, at 1:17 PM, Mike Pinkerton wrote: In tracking down something for Mac Chromium, I came across something in WebCore that I can't explain, and hopefully someone on this list can vend me a clue. RenderTextControl::calcPrefWidths() checks the average character width of the primary

Re: [webkit-dev] Font cache cleaning

2008-10-11 Thread Dan Bernstein
On Oct 10, 2008, at 6:29 AM, Frederic Marmond wrote: Hi people, I just wonder how to clear the font cache, arbitrary. For example, when leaving a site, clear all cached font data, to start loading the new page in a 'clean' environment. I know it may slow down things :) old memory vs speed d

Re: [webkit-dev] 答复: 答复: About the layout test result.

2008-10-07 Thread Dan Bernstein
* fonts) that are in the WebKit source tree. The Times family alone would probably suffice for the majority of the tests. I do not know how or even whether any or all of the required fonts are available for installation on Windows. -- Dan Thanks! -- Bely 发件人: Dan Bernstein [mailto:[EMAIL

Re: [webkit-dev] 答复: About the layout test r esult.

2008-10-06 Thread Dan Bernstein
On Oct 6, 2008, at 7:55 PM, Bely wrote: Hi Mark, Thanks for your reply! I am running the tests on windows, with cygwin installed. After build it in VC8 using “debug” configuration, I execute the tests by invoking run-webkit-tests in cygwin console like: ./run-webkit-tests

Re: [webkit-dev] JavaScriptCore cleanup

2008-09-07 Thread Dan Bernstein
JSCore++ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Faster run-webkit-tests?

2008-07-10 Thread Dan Bernstein
On Jul 10, 2008, at 5:11 PM, Refstrup, Jacob Grundtvig wrote: > Hi, > > Has anyone looked into making run-webkit-tests run faster by taking > advantage of multiple CPUs? E.g. my workstation is 8gb, with 2 x > dual core and I think it'd do just fine in running 4-8 tests > simultaneously. > >

Re: [webkit-dev] New focus outline enhancement 7138 - outline broken

2008-05-07 Thread Dan Bernstein
On May 7, 2008, at 7:43 AM, Johan Lund wrote: Is there any way to make it render on top of everything or perhaps offset it so it renders inside, like in IE? :focus { outline-offset: -4px; } (or you can add the rule to your user style sheet). You can also change the outline color, sty

<    1   2