On Aug 26, 2009, at 10:35 PM, Oliver Hunt wrote:

Adam just landed a fairly substantial patch that did nothing but remove whitespace from the ends of lines. While we had a thread about style changes earlier, it was in the context of changes that actually bring code into line with style guidelines in a way that actually effects the visible layout of code.

I do not believe that patches such as r47808 should be considered valuable as the changes have no visible effect on code layout, but do impact our ability to effectively use tools like svn or git blame, however the situation is slightly ambiguous on this matter so i thought i should bring it up on the mailing list.

Does anyone else have thoughts on this?

While I do see value in cleaning up code, I think the cost of whitespace-only changes is higher than their benefit.
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Reply via email to