[webkit-dev] Is JSRetainPtr part of public WebKit API on some platforms?

Julien Chaffraix asked me about API breakage in Remove all releaseRef implementations except for RetainPtr. I realize now that JSRetainPtr.h is in the API directory. Is it part of the public API on some platforms? I know it’s not on Mac. -- Darin

Re: [webkit-dev] Supporting w3c ref tests and changing our convention

On Nov 11, 2011, at 4:24 AM, Tor Arne Vestbø wrote: > On 07.11.11 15:44, Alan Stearns wrote: >> What if we defer some of the W3C metadata work until tests were actually >> submitted to the W3C? >> >> 1. Tests we pull from W3C can run from manifests, since they are provided. >> >> 2. Tests we de

Re: [webkit-dev] Cleaning up directories in WebCore

On Nov 18, 2011, at 1:51 AM, Adam Barth wrote: > Features/ <-- New folder for (roughly) self-contained features I like the concept, but not the name. I’ll try to think on this and suggest a name I like better than “features”. > notifications/ > storage/ > fileapi/ > webaudio/ > mediastrea

Re: [webkit-dev] Simplifying "hub" classes (was Cleaning up directories in WebCore)

On Nov 20, 2011, at 8:55 PM, Adam Barth wrote: > On Sun, Nov 20, 2011 at 8:36 PM, Hajime Morrita wrote: >> One traditional pattern is to split a big class into a set small classes >> plus a "hub" class like how Adam has done for original Frame. > > ^^^ The work to split up Frame was largely do

Re: [webkit-dev] Using C++ constant local variables in WebKit

On Nov 28, 2011, at 1:38 PM, David Kilzer wrote: > In a discussion on Bug 71921, Antti, Darin Adler and I started a discussion > about using C++ constant pointers in WebKit. Does the WebKit community have > a consensus opinion on the matter? I thought we were discussing local var

Re: [webkit-dev] const_iterator

On Nov 30, 2011, at 1:35 PM, David Levin wrote: > All of this seems to apply equally to const_iterator as well. I don’t think it does. > Are you mildly opposed to it as well? Or is something different about it? It seems to me that const_iterator is analogous to pointer-to-const and const membe

Re: [webkit-dev] query on eventsender

On Nov 22, 2011, at 2:35 AM, Antaryami Pandia wrote: > Can eventsender be used to send click events on options of a drop down combo > box? No. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cg

[webkit-dev] Commit queue rejecting all patches

We are getting this: > Attachment XXX did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/10728791 > > New failing tests: > svg/custom/linking-uri-01-b.svg Can someone fix it? -- Darin ___ webkit-dev mailing list webk

[webkit-dev] Making empty vectors smaller; eliminate String::adopt(Vector)?

For vectors with no inline capacity, we can store the capacity inside the Vector’s buffer. That way, the Vector itself will be one size_t smaller when empty. In fact, with a bit of performance risk, we can do the same thing with the vector’s size, making an empty Vector just a single pointer. Bu

Re: [webkit-dev] Incremental steps towards moving WebCore/platform out of WebCore

The namespace name Platform is OK. I’m concerned that this is over-use of namespace and will make WebCore code overall harder to read. One of the notable features of the classes in the platform directory is that they fit in smoothly and are easy to use in WebCore. Being in the same namespace as

[webkit-dev] Is Harmony a new WebKit project?

I see some work in JavaScriptCore on something named Harmony. Is adding this a WebKit project? If so, then I’d like to see the customary webkit-dev message announcing the new project so we can discuss it. -- Darin ___ webkit-dev mailing list webkit-dev

[webkit-dev] How to use ASSERT_NO_EXCEPTION

Here’s my first draft of a note about ASSERT_NO_EXCEPTION. We might want to add this to the WebCore website; not sure. Many core DOM functions in classes in WebCore serve a dual purpose. They are used to implement DOM API that can be called from JavaScript. This often means that they will handl

[webkit-dev] Moving code from Element to NamedNodeMap -- I think that is the wrong direction

Hi folks. One of the main things the Element class does is implement an attribute store for elements. Currently, this attribute store is in a separate reference-counted object. That object is exposed to the DOM as NamedNodeMap. But I believe this is not a good pattern for the long run. The reas

Re: [webkit-dev] Moving code from Element to NamedNodeMap -- I think that is the wrong direction

On Dec 21, 2011, at 11:26 PM, Ryosuke Niwa wrote: > the immediate problem we have today is that code that updates and notifies > attributes are scattered all over the place, and making refactoring harder Understood. I want to make sure that as we do improvements, we move in the right direction.

Re: [webkit-dev] Moving code from Element to NamedNodeMap -- I think that is the wrong direction

On Dec 21, 2011, at 11:32 PM, Darin Adler wrote: > On Dec 21, 2011, at 11:26 PM, Ryosuke Niwa wrote: > >> Could you file bugs for these goals so that Adam and I can tackle those >> after the break? > > Sure. Not tonight, but as soon as I get a chance. I filed a fe

[webkit-dev] generate-bindings.pl now running every time I type make even if nothing has changed

Hi folks. After recent changes for [Supplemental] it seems that generate-bindings.pl is running every time I type make, even if nothing has changed since the last time I built. For DOMWindowWebAudio.idl and for DOMWindowWebSocket.idl. How is this supposed to work? -- Darin

Re: [webkit-dev] WebKit IDL cleanup

Great idea to make some improvements. I think there are many opportunities for the code generators to share code instead of being copy/pasted/modified versions of one another. When changing the scripts we should look for opportunities to do that. I love the part of this where you will remove su

[webkit-dev] Double posting of review comments when using Preview button at bugs.webkit.org

This bug report https://bugs.webkit.org/show_bug.cgi?id=77750 describes a problem I’ve been seeing that is causing me to double post large comments in many bugs. Really annoying! -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://l

Re: [webkit-dev] What is the license policy of a reviewing patch on Bugzilla (not yet landed to main trunk)?

On Feb 6, 2012, at 6:17 PM, Ryosuke Niwa wrote: > But I've seen cases where people didn't realize some files they uploaded on > Bugzilla weren't compatible with LGPL or BSD until the review process Sure, people make mistakes, but our request is that they determine this before uploading a patch

Re: [webkit-dev] WebKit IDL cleanup

I’m really enjoying how the cleanup is going so far. The IDL attribute names are noticeably clearer and more consistent. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Should we move methods from layoutTestController/etc... to internals?

On Feb 21, 2012, at 12:15 PM, Ryosuke Niwa wrote: > It appears to me window.internals is a superior solution to expose > cross-platform features to our test harness compared to other interfaces > implemented in DumpRenderTree and WebKitTestRunner such as > layoutTestController and friends. As

Re: [webkit-dev] 48459: Glyphs in vertical text tests are rotated 90 degrees clockwise on Windows

Key to any patch that adds a new parser is testing of all the branches in the parser code, including fuzz testing to make sure the parser doesn’t introduce security vulnerabilities. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http:

Re: [webkit-dev] About BrowsingContext and WindowProxy spec

On Mar 7, 2012, at 9:34 AM, Adam Barth wrote: > The WindowProxy is implemented in WebKit using the WindowShell class. Idle thought: We might want to consider renaming our WindowShell class WindowProxy, just to match the HTML specification concept, as I think we’ve done in a few other cases. --

Re: [webkit-dev] Ambiguity in the style guide

Yes, the general principle is to match the case sensitive sorting done by old school Unix command-line sort tool with no option. Not because there is any specific benefit to that particular order, just that there is a benefit to an unambiguous order. -- Darin ___

Re: [webkit-dev] Issue regarding Same Origin check with Blobs and XMLHttpRequest

On May 10, 2012, at 1:32 AM, Vishal Shah wrote: > If this is not the correct list to be contacted, please suggest me the > correct one. This is not the correct WebKit list. http://www.webkit.org/contact.html “webkit-dev is for discussion of the WebKit project's development […] you should dire

Re: [webkit-dev] Using namespace std

On May 15, 2012, at 5:48 AM, Allan Sandfeld Jensen wrote: > To me it seems like an odd practice, so I would like to ask what original > rationale behind that style guideline is Adding a list of using declarations like "using std::min" to the top of each source file would give us another ongoing

Re: [webkit-dev] Access to WebElements through WebKit2 Touch API

On May 15, 2012, at 8:24 AM, Webkit Research wrote: > How can we get access in Webkit2 to all WebElements x/y coordinates for a > given loaded HTML page. Our problem is that the information we want is in the > DOM but the DOM does not seem accessible through the WebKit2 Touch API. This is the w

Re: [webkit-dev] Using namespace std

On May 16, 2012, at 9:20 AM, Allan Sandfeld Jensen wrote: > there is another conflict which is entirely our own fault. It is between > WTF::bind and the new std::bind from C++11 We should find a good solution for this. I’d suggest talking with Anders Carlsson about it. -- Darin ___

Re: [webkit-dev] Using namespace std

On May 16, 2012, at 12:47 PM, James Robinson wrote: > On Wed, May 16, 2012 at 12:04 PM, Anders Carlsson wrote: > >> FWIW, I don't think we really need using directives for the std namespace - >> the fully qualified name is short enough and I like the additional clarity >> that we're calling so

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

On May 17, 2012, at 4:30 AM, Ojan Vafai wrote: > I have a proposal that hopefully addresses everyone's concerns, is minimally > different from the current format *and* unifies the format with Skipped lists > (i.e. Skipped lists as they exist today are valid test_expectations.txt > format). The

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

Seriously, syntax is a significant barrier. Having to know which special characters to use. I don’t see this “clear delineation” you speak of. Just special punctuation I have to use to satisfy the computer. -- Darin ___ webkit-dev mailing list webkit-d

[webkit-dev] We should rename layoutTestController to testController

I am thinking we should rename layoutTestController to testController. Or if you don’t like that name, maybe testHarness or some even better name. The old name is too long and the word “layout” is so strange. We could expose the object under the new name and the old one, and then over time conv

Re: [webkit-dev] webkit2 with v8

On Jun 1, 2012, at 9:55 AM, Jake wrote: > I believe it's a disservice to the community as a whole to not provide proper > javascript engine abstractions in webkit. I don’t agree. We should have abstractions for things that need to be abstract. Too many abstractions make the code much harder t

Re: [webkit-dev] webkit2 with v8

Are you a WebKit developer? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

Our past experience with this sort of thing at Apple is that it led to bugs we didn’t find until after we shipped “final” software because they did not show up during earlier testing. Since then, we’ve gone out of our way to avoid differences, since one of the main things we want to do with non-

Re: [webkit-dev] DOM tree traversal on detached nodes

On Jun 6, 2012, at 6:14 PM, Kentaro Hara wrote: > IMHO, (a) would be the best semantics. I agree, and I think that the specification actually does require this. The real issue here is how to fix this bug efficiently. I believe that Geoff Garen has been contemplating this and also has a proposa

Re: [webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

On Jun 11, 2012, at 7:33 PM, Mike Lawther wrote: > Does having the 'fast' directory still serve a useful purpose? Not sure it does. The original intent was to put more extensive complete tests that were slow but had greater coverage outside the “fast” directory, so that you could run the major

Re: [webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

On Jun 12, 2012, at 10:17 AM, Ryosuke Niwa wrote: > The last time we had this discussion, the consensus appeared to be renaming > it to RegressionTests. I still like that name. > Are you suggesting that we have LayoutTests/W3C? Yes. Something like RegressionTests/ImportedTests/W3C. > we have

Re: [webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

On Jun 12, 2012, at 1:02 PM, Ryosuke Niwa wrote: > Because then we'll be placing tests for one component in multiple directories. Makes sense, but fleshing this out for all the tests could be tricky. Only a certain percentage of our tests will fall cleanly into a component such as CSS or DOM.

Re: [webkit-dev] malloc(0)

On Jun 12, 2012, at 3:03 PM, Myles C. Maxfield wrote: > I noticed that this caused a problem in one particular place > (WTF::StringImpl::getData16SlowCase()) where the code allocates (constant * > length) bytes for an (empty) string, and provides an accessor that exposes > this pointer. This p

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

On Jun 12, 2012, at 5:17 PM, Ojan Vafai wrote: > It's great to use a fuzzer in order to find cases where we're broken and then > make reduced layout tests from those. Generally we do require a test each time we fix a bug. So it’s a strategy for the project to always make reduced tests when we

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

On Jun 13, 2012, at 12:12 PM, Dirk Pranke wrote: > On Wed, Jun 13, 2012 at 12:05 PM, Darin Adler wrote: >> On Jun 12, 2012, at 5:17 PM, Ojan Vafai wrote: >> >>> It's great to use a fuzzer in order to find cases where we're broken and >>>

Re: [webkit-dev] malloc(0)

On Jun 13, 2012, at 2:24 PM, Myles C. Maxfield wrote: > There is still the question of if I can upstream this to ICU, which I'm > checking on. I was not proposing changing ICU. > In the meantime, Ryosuke Niwa has a good argument for option 3) above. Yes, that’s what I was suggesting; I am gla

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

On Jun 13, 2012, at 3:53 PM, Dirk Pranke wrote: > * we use "\" (backslash) as a delimiter instead of ":" and "=" Seems worse to me. When I see a backslash I assume it’s a line continuation character or a C escape sequence. On the other hand, neither the ":" nor the "=" meant anything to me eit

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

On Jun 13, 2012, at 4:26 PM, Ryosuke Niwa wrote: > So something like > > webkit.org/12345 [Win Mac Debug] animations/stop-animation-on-suspend.html > [Crash Text Pass] > > ? I like that! Yes, looks good to me too. -- Darin ___ webkit-dev mailing li

Re: [webkit-dev] editbugs permission

On Jun 13, 2012, at 9:25 PM, Mike Lawther wrote: > I'd like to ask for EditBugs permission for dstockw...@chromium.org, who has > already landed a couple of patches and is helping us triage bugs. Someone must have seen this and granted permission, because I went to do so and he already had it.

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

On Jun 15, 2012, at 12:12 AM, Roland Steiner wrote: > I made the original name change, because I honestly was entirely confused > about the meaning of "selfOnlyRef" (it's done by Node on Document, so what is > "self"? Why is it needed?) A good rule of thumb, the one that I use, is that a name l

Re: [webkit-dev] Making Webkit compliant with HTML5 new features

On Jun 15, 2012, at 7:23 AM, Ryosuke Niwa wrote: > Filing bugs on bugs.webkit.org for things that make WebKit not compliant with > the HTML5 specifications is a good starting point. Another useful task is to learn to write good regression tests, and write tests that demonstrate the problems you

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

On Jun 15, 2012, at 9:47 AM, Ryosuke Niwa wrote: > // Nodes belonging to this document hold guard references - > // these are enough to keep the document from being destroyed, but > // not enough to keep it from removing its children. This allows a > // node that outlives its document to still hav

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

On Jun 15, 2012, at 10:15 AM, Maciej Stachowiak wrote: > But it's hard to explain fully in a function name w/o excess verbosity. I think my favorite excess verbosity version is refDocumentButNotOtherNodes. -- Darin ___ webkit-dev mailing list webkit-d

Re: [webkit-dev] Hardware Acceleration

On Jun 21, 2012, at 2:49 AM, ketan goyal wrote: > I am working on some 3D stuff and need hardware acceleration for performance. > > So, I am wondering if Hardware Acceleration is supported for GTK port in > webkit ? I think you may misunderstand the purpose of this mailing list. This is the ma

Re: [webkit-dev] [PATCH] Errors from "build-webkit --debug --minimal"

This is the wrong mailing list to discuss this kind of issue. On this list we discuss contributions to the WebKit project and collaborate on WebKit development. If you want to build WebKit and do not intend to contribute patches, you can ask questions on the webkit-help mailing list as described

[webkit-dev] Lots of email to this list is showing up too small for me to read

Some of the email to the WebKit lists is now showing up in 10 point size rather than the default size for my mail reader. I’m having a hard time reading the small text and I have to do various tricks to make these mails readable. It seems to mostly be from people at Google. Did you guys change s

Re: [webkit-dev] Lots of email to this list is showing up too small for me to read

On Jun 26, 2012, at 10:12 PM, Ryosuke Niwa wrote: > Could you send me a copy (markup and possibly a screenshot) of emails you see > this problem and ones you don't see this problem? Yes. I did that. -- Darin ___ webkit-dev mailing list webkit-dev@list

Re: [webkit-dev] Question related to license in WK2 EFL port

There’s some specific policy about this that’s displayed in bugs.webkit.org when you attach a patch for review: > Hello and thank you for contributing a patch. Here is our licensing policy > and terms for contributing code to the WebKit project. > > • If you are sending in a patch to exis

Re: [webkit-dev] New runtime setting: css3TextDecoration

On Aug 14, 2012, at 5:41 PM, Elliott Sprehn wrote: > The point of the vendor prefix is to assert the instability of the feature. The WebKit project uses vendor prefixes to avoid compatibility conflict between a feature and a later incompatible standardized feature that would use the same name.

Re: [webkit-dev] Proposal to remove list-item special counter

On Aug 15, 2012, at 2:29 PM, Elliott Sprehn wrote: > WebKit is the only browser that implements the magic counter named > "list-item" and we have no tests for it. Seems like we really ought to add some tests for it. > It's not useful since we don't support the ::marker pseudo element Maybe it

Re: [webkit-dev] Proposal for coding guidelines: Do not use fall-through switch cases inside #ifdef's

On Aug 21, 2012, at 1:22 PM, Mark Rowe wrote: > It'd be preferable to fix whatever problem exists with the dependencies so > that these files are automatically regenerated when needed. Otherwise anyone > building on these platforms, including buildbots, will just run in to the > issue after yo

Re: [webkit-dev] unsigned vs unsigned int

On Sep 16, 2012, at 2:30 AM, Allan Sandfeld Jensen wrote: > On Thursday 13 September 2012, Dan Bernstein wrote: >> On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen >> wrote: >> >>> I was telling people to use "unsigned" instead of "unsigned int", as I >>> have been told that was the pre

Re: [webkit-dev] unsigned vs unsigned int

On Sep 17, 2012, at 1:22 AM, Allan Sandfeld Jensen wrote: > On Sunday 16 September 2012, Darin Adler wrote: >> I think we should use the shortest name for each type. >> >> That is why I like “unsigned” better than “unsigned int”. > > Does this mean you also prefer &#

Re: [webkit-dev] Enable encoding detector on layout(regression) test

On Sep 18, 2012, at 6:25 PM, Kangil Han wrote: > However, enabling encoding detector by javaScript manipulation seems not > feasible since encoding detector works on reading input stream level. You could probably make an encoding detection test using an iframe with a data URL in it. Have you t

Re: [webkit-dev] Enable encoding detector on layout(regression) test

On Sep 19, 2012, at 9:22 AM, Darin Adler wrote: > On Sep 18, 2012, at 6:25 PM, Kangil Han wrote: > >> However, enabling encoding detector by javaScript manipulation seems not >> feasible since encoding detector works on reading input stream level. > > You could p

Re: [webkit-dev] New Feature: Canvas Path object

On Sep 22, 2012, at 9:21 PM, Elliott Sprehn wrote: > On Fri, Sep 21, 2012 at 6:34 AM, Dirk Schulze wrote: > >> I would like to ask if there are objections to implement the canvas Path >> object. > > Do we have metrics on how often people already have things named Path? All > other canvas obj

Re: [webkit-dev] Is there a rule to use UNUSED_PARAM ?

I prefer we use UNUSED_PARAM as little as possible. The main reason is that we can utter UNUSED_PARAM and then use the parameter without getting a compiler error. This makes it easy to use the macro in a way that is misleading. It doesn’t actually enforce that a parameter is unused, and is more

Re: [webkit-dev] Improving DOM Exception console messages.

On Oct 1, 2012, at 2:57 AM, Mike West wrote: > Concretely, this might involve adding two properties to ExceptionBase: > 'context' and 'totallySektitContext' I think the naming here is critical. The word “context” is an extremely bland and vague one that does not make it clear what this inform

Re: [webkit-dev] Is there a rule to use UNUSED_PARAM ?

On Oct 1, 2012, at 5:21 PM, Mike Lawther wrote: > my first reading of that name had me thinking it meant 'ASSERT that this > variable is unused' in the vein of macros I've seen in other places like > ASSERT_TRUE, ASSERT_NOT_NULL etc. Yes, even though I named the macro I have had the same thou

Re: [webkit-dev] Is there a rule to use UNUSED_PARAM ?

On Oct 1, 2012, at 5:23 PM, Darin Adler wrote: > Yes, even though I named the macro Hmm, not sure I did. Maybe someone else did. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Tips on why run-webkit-tests is not working for me?

I’m trying to test some changes on my Mountain Lion Mac, using the Mac port. When I call run-webkit-tests it fails with file not found. Using port 'mac-mountainlion' Test configuration: Placing test results in /Users/darin/Build/Debug/layout-test-results Baseline search path: mac -> generic Usin

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

On Oct 3, 2012, at 9:10 AM, Ryosuke Niwa wrote: > Could you tell us what your directory structure look like and where you're > executing that command? Looks like a path confusion. My WebKit source tree is in ~/Safari/OpenSource and my build products are in ~/Builds. I am running the script ins

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

On Oct 3, 2012, at 4:18 PM, Dirk Pranke wrote: > it's trying to run "/usr/bin/make", "-C" > "/Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/LayoutTests/java"] > (approximately). > > It's probably bad that it's hardcoded to look in /usr/bin; is that your > problem? I’ll check.

Re: [webkit-dev] Transformations precision: double -> float

On Oct 10, 2012, at 9:00 AM, Gabor Rapcsanyi wrote: > That was a long time ago and there were no objections >> Unless there's something in the spec requiring double precision it makes >> sense to move away from double precision throughout WebKit. I’m a little concerned about this. The program

Re: [webkit-dev] Mac build issue (appearing only locally)

Seems like this must be a difference between clang versions; I suggest updating to a newer version of Xcode. If we need to support the older clang, then the fix of reordering the methods seems OK. There are other fixes we could consider too. -- Darin

Re: [webkit-dev] Slide deck: How WebKit Works

I like those slides. Thanks for putting them where we can all see and use them. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] …Inlines.h vs …InlineMethods.h

On Nov 3, 2012, at 10:09 AM, Mark Lam wrote: > 1. to keep class definitions more compact >- so you can see more of the entire class (not that this is always > possible anyway). >- being able to see the entire class (when possible) can yield useful > information about the shape of the cl

Re: [webkit-dev] …Inlines.h vs …InlineMethods.h

On Nov 5, 2012, at 8:47 AM, Geoffrey Garen wrote: > (2) Adopt the convention that any class using "*Inlines.h" defines all inline > functions defined out-of-line in "*Inlines.h" This is a proposal I don’t agree with. Making a firm rule here here means that every larger inline function in one o

Re: [webkit-dev] compile failure when I try to introduce GLContextEGL to MediaPlayerPrivateGStreamer

On Nov 9, 2012, at 12:27 AM, Simon Hausmann wrote: > It's the X11 headers that are broken and the usual workaround is to do things > like > >#undef None > > after including them. That should probably happen in GLContextEGL.h or even > nearer to the inclusion. I agree. You can see one ex

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

On Nov 9, 2012, at 9:59 AM, Rafael Brandao wrote: > I'd go with the overloads in a single file Why? Seems the overloads should be in the files of the classes they are for. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.w

[webkit-dev] Problems with the new NATIVE_TYPE_ERR

Four months back we added NATIVE_TYPE_ERR for IndexedDB, as a way for the DOM code to raise JavaScript type error exceptions rather than DOM exceptions . Yesterday we started using NATIVE_TYPE_ERR elsewhere in the DOM

Re: [webkit-dev] Problems with the new NATIVE_TYPE_ERR

On Nov 13, 2012, at 10:44 AM, Joshua Bell wrote: > The switch from DOMException of type TYPE_MISMATCH_ERR to TypeError does not > appear to be controversial, but as arv@ mentioned in one of the bugs: > > "WebIDL only defines bindings for ECMAScript. We really need someone from > Apple to take

Re: [webkit-dev] generic test expectations?

If we do add base test expectations shared by all platforms, please don’t put the file into LayoutTests/platform/generic; just put it at the top level of LayoutTests. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.

Re: [webkit-dev] generic test expectations?

On Nov 13, 2012, at 12:02 PM, Tony Chang wrote: > I don't think we should support port specific ref test results. That kind of > misses the point of using a ref test in the first place. I mean, you may as > well check in port specific pixel results which are easier to review for > correctness.

Re: [webkit-dev] do you want "WK1" and "WK2" keywords in the TestExpectations files?

I’d prefer an directory-based overlay/inheritance approach to sharing WebKit1- vs. WebKit2-specific expectations over in-file keywords. I’d like to share more than just a central expectations file, so we could share expected results or even WebKit1 or WebKit2-specific tests. -- Darin __

Re: [webkit-dev] generic test expectations?

On Nov 13, 2012, at 12:16 PM, Tony Chang wrote: > Here is a ref test result from ietestcenter: > http://trac.webkit.org/browser/trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm > > Looking at that HTML file, it's not immediately obvious that the result is > correct. If

Re: [webkit-dev] do you want "WK1" and "WK2" keywords in the TestExpectations files?

On Nov 13, 2012, at 12:29 PM, Dirk Pranke wrote: > We pretty much have this today (with platform/wk2 and platform/mac-wk2). > You're saying you'd prefer to add platform/wk1, platform/mac-wk1, > platform/mac-lion-wk1, and platform/mac-lion-wk2 if/where necessary (and no > keywords), right? I w

Re: [webkit-dev] sharing more test references

On Nov 13, 2012, at 4:01 PM, Dirk Pranke wrote: > It turns out that we have a reasonably large number of tests that produce the > exact same pixel results. On chromium-mac on 10.8, for example, there are > 2048 tests that share a result with some other test. 50 of them, for example, > draw a g

Re: [webkit-dev] sharing more test references

On Nov 13, 2012, at 4:56 PM, Dirk Pranke wrote: > Wouldn't the fact that there are a large set of tests with the same result be > an argument *for* doing the iframe thing? The simple hand-coded green square in upper left corner should be simple, perhaps even simpler than the iframe thing. > W

[webkit-dev] Prefix naming scheme for DOM-exposed functions

Hi folks. Many of the APIs designed for use in the DOM are not efficient for use inside WebKit, or have designs that are better for JavaScript than for C++. Antti Koivisto and I have been discussing how to best communicate this to WebKit contributors so they don’t end up using inefficient idiom

Re: [webkit-dev] Prefix naming scheme for DOM-exposed functions

On Dec 7, 2012, at 12:28 PM, Elliott Sprehn wrote: > This seems like it would introduce bugs and make maintaining the DOM harder > since we'd need to duplicate logic. We should not needlessly duplicate logic. If the change causes us to copy and paste code, we’re doing it wrong. > Right now we

Re: [webkit-dev] request of "canconfirm-bit"

On Jan 16, 2013, at 9:19 AM, Adam Barth wrote: > We more or less ignore the "is confirmed" bit in bugs.webkit.org. I believe it’s possible to rename UNCONFIRMED to NEW and delete NEW so we can get rid of this distinction that we don’t make use of. Might be worth doing at some point to reduce c

Re: [webkit-dev] Proposal to remove list-item special counter

On Jan 16, 2013, at 5:46 PM, Elliott Sprehn wrote: > I've scoured the web and can't find any reference to anyone using it, mention > of it's usage on any pages and no other browser supports it. How much more common is use of the rest of the counters specification? I understand that counters is

Re: [webkit-dev] request of "canconfirm-bit"

On Jan 16, 2013, at 2:54 PM, 徐征 wrote: > So, how can I get assign for this issue(and make the status to ASSIGNED)? You don’t need to. You can add comments and post a patch without having the bug formally assigned to you. In fact, we don’t normally pay all that much attention to the Assigned To

[webkit-dev] Clipboard class plans

Hi folks. I have some work planned on the DOM clipboard classes. I’m not in a big hurry to get this done fast. It’s my side project. But I thought some people might be interested in what I am thinking about doing. I have a good 20% of the project already sitting in my local git repository and I

Re: [webkit-dev] Clipboard class plans

On Feb 6, 2013, at 12:06 PM, Daniel Cheng wrote: > ​I think ​Clipboard.types currently returns an Array. Clipboard::types currently returns ListHashSet, and custom bindings translate that into a JavaScript array. > There's a patch in progress to change this to Vector to remove the > need for

Re: [webkit-dev] SerializedScriptValue: signed vs unsigned char

On Feb 7, 2013, at 8:31 AM, Glenn Adams wrote: > Given Maciej and Adam's comments, you had best stay with unsigned char/uint_8 > and convert any non-conforming usage to this pattern when needed. Yes, I think that’s the right direction for WebKit. -- Darin __

Re: [webkit-dev] Should LChar really being unsigned char? (was Re: SerializedScriptValue: signed vs unsigned char)

Short answer, yes. On Feb 10, 2013, at 9:14 AM, Glenn Adams wrote: > Because LChar is often (always?) UTF-8 encoded, the individual encoding units > of which are 0x00 through 0xFF. Close. LChar is always Latin-1 encoded. That’s what the "L" is for. That’s the same thing as the first 256 code

Re: [webkit-dev] sln files with wrong line endings

Typically in Subversion the fix for a problem like this is to set the eol-style explicitly; presumably to CRLF for Windows project and solution files and to LF or native for plain old source files. Once that property is set, people changing file later on can’t cause problems with inconsistent li

[webkit-dev] AncestorChainWalker substance and style thoughts

I am trying to learn about code related to shadow DOM that needs to be understood by anyone working on an part of the DOM. I have some questions and concerns about AncestorChainWalker. If there is a document I should be reading that covers these, please point me to it. The parentNode and parent

Re: [webkit-dev] AncestorChainWalker substance and style thoughts

On Feb 18, 2013, at 6:17 PM, Ryosuke Niwa wrote: > See https://bugs.webkit.org/show_bug.cgi?id=110146 where we're going to > rename the class, member functions and variables. Thanks. Good discussion there. What about my other question? Why is this a class instead of a function? -- Darin _

Re: [webkit-dev] AncestorChainWalker substance and style thoughts

On Feb 18, 2013, at 6:18 PM, Hajime Morrita wrote: > Non-trivial tree traversal API in general should, IMO, be modeled after > recently introduced NodeTraversal. Having separate namespaces allows us to > keep Node API minimal. Also it is stateless and simple. I made > NodeRenderingTraversal in

Re: [webkit-dev] AncestorChainWalker substance and style thoughts

On Feb 18, 2013, at 6:28 PM, Ryosuke Niwa wrote: > I had the same question when I found this class today but when I tried to > turn it into a function, I realized that each caller of this function now > needs to maintain two variables instead of one. Since those two variables > (node and distr

<    1   2   3   4   5   6   7   8   9   10   >