Re: [webkit-dev] Replacing Cairo in WebKit with Skia

2024-02-08 Thread Kirsling, Ross via webkit-dev
Seems like a great opportunity to turn WinCairo into simply "Win". Ross On 2/7/24, 3:31 PM, "Yusuke Suzuki via webkit-dev" mailto:webkit-dev@lists.webkit.org>> wrote: Nice, this sounds really good. Cairo performance was one of the limiting factors in WebKitGTK, and adopting some libraries

Re: [webkit-dev] Anne Van Kesteren is now a WebKit reviewer

2024-01-12 Thread Kirsling, Ross via webkit-dev
Indeed, congratulations!! From: Mathias Bynens via webkit-dev Sent: Friday, January 12, 2024 10:02:13 PM To: Tim Nguyen Cc: WebKit Development Subject: Re: [webkit-dev] Anne Van Kesteren is now a WebKit reviewer Congrats Anne! On Thu, Jan 11, 2024 at 8:32 PM

Re: [webkit-dev] ENABLE macro placement between includes

2023-08-15 Thread Kirsling, Ross via webkit-dev
I would support specifying the common pattern in our styleguide. Ross From: Alex Christensen via webkit-dev Reply-To: Alex Christensen Date: Thursday, August 3, 2023 at 2:52 PM To: Webkit Development List Subject: [webkit-dev] ENABLE macro placement between includes Our coding style says to

Re: [webkit-dev] Proposal on retiring JIT on Windows

2023-03-26 Thread Kirsling, Ross via webkit-dev
26, 2023 3:18:36 PM To: Kirsling, Ross Cc: Fujii Hironori ; Brent Fulgham ; Mark Lam ; WebKit Development Subject: Re: [webkit-dev] Proposal on retiring JIT on Windows The reason is that the patch is reverted because it broke Windows DFG. This is not acceptable to us since we have no EWS bots

Re: [webkit-dev] Proposal on retiring JIT on Windows

2023-03-25 Thread Kirsling, Ross via webkit-dev
This seems unfortunate and unexpected to me—I thought having a singular Windows port was supposed to mean reduced maintenance burden, since we don't have to divide the number of Windows maintainers into two. Although reconciling FTL with Windows' calling convention is a challenge that no one's

Re: [webkit-dev] WebKit Documentation

2023-03-09 Thread Kirsling, Ross via webkit-dev
I’d vote for (1) since it’s easy to type! Thanks, Ross From: Ryosuke Niwa via webkit-dev Reply-To: Ryosuke Niwa Date: Friday, March 10, 2023 at 6:41 AM To: Brandon Stewart Cc: Ling Ho via webkit-dev Subject: Re: [webkit-dev] WebKit Documentation On Mar 9, 2023, at 10:48 AM, Brandon

Re: [webkit-dev] Remove the version labels in GitHub

2022-11-20 Thread Kirsling, Ross via webkit-dev
Right, I thought that was the point of the above discussion so I was surprised to see that the prompt hasn't been removed. From: Yusuke Suzuki via webkit-dev Sent: Monday, November 21, 2022 12:51:42 PM To: WebKit Development Cc: Darin Adler Subject: Re:

Re: [webkit-dev] Remove the version labels in GitHub

2022-10-22 Thread Kirsling, Ross via webkit-dev
Indeed, I'd love it those didn't exist. (I always imagined them to be exclusively intended for bug reports originating from non-contributors, but I'm not even certain how much they've been used in that scenario.) From: Michael Catanzaro via webkit-dev Sent:

Re: [webkit-dev] Style guide: enforce `while (true)` over `for (; ; )`

2022-10-05 Thread Kirsling, Ross via webkit-dev
I've always kind of liked that `for (;;)` doesn't involve an explicit constant, but I too like consistency even more. :) From: Ryosuke Niwa via webkit-dev Sent: Thursday, October 6, 2022 1:01:01 PM To: Yusuke Suzuki ; Tim Nguyen ; WebKit Development Subject:

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-09-07 Thread Kirsling, Ross via webkit-dev
This conversation has had some diverging threads (which is what makes mailing list-based communication so difficult), but I'm disappointed that this should mean that the crux of the conversation was lost. There is no such thing as "not maintaining the non-unified build"; there never has been.

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-06-03 Thread Kirsling, Ross via webkit-dev
"Supported configurations" may indeed be too tricky of a concept to pin down, but I believe Diego explained quite thoroughly how the central issue here would be every bit as relevant in a world where we only care about standard Mac builds. If FooBar.cpp and FooBaz.cpp need the same 10

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-06-01 Thread Kirsling, Ross via webkit-dev
orking Mac Cmake build). This bot means that people can know their patches are free of include errors without having to worry about how to verify that locally. Ross From: Ryosuke Niwa Date: Wednesday, June 1, 2022 at 4:39 PM To: "Kirsling, Ross" Cc: Alexey Proskuryakov , "webkit

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-06-01 Thread Kirsling, Ross via webkit-dev
includes correct. This has not been possible in the past, but Igalia's generosity in providing an EWS builder means that it now could be. They deserve our gratitude. Ross From: Alexey Proskuryakov Sent: Wednesday, June 1, 2022 3:26:50 PM To: Kirsling, Ross Cc: dpino

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-05-21 Thread Kirsling, Ross via webkit-dev
This is wonderful news—thanks Diego! Ross From: dpino via webkit-dev Sent: Friday, May 20, 2022 9:17:56 PM To: webkit-dev@lists.webkit.org Subject: [webkit-dev] Deployment of new EWS Non-Unified builder Hi, Last year we started a thread to discuss the

[webkit-dev] Basuke Suzuki is now a WebKit reviewer!

2022-03-07 Thread Kirsling, Ross via webkit-dev
Hi everybody, I’m happy to announce that Basuke Suzuki is WebKit’s newest reviewer! Basuke has done significant work on the PlayStation and WinCairo ports, Curl, the socket-based remote web inspector, and bmalloc, so keep him in mind next time you need a review. Please join me in

Re: [webkit-dev] Request for position: relative indexing method on JS indexables

2020-11-30 Thread Kirsling, Ross via webkit-dev
Hey Shu, This is already implemented behind the JSC runtime option `useAtMethod`. (Latest relevant revision is r270005.) Looking forward to seeing whether the new name is in fact web-compatible. 爛 Ross From: Shu-yu Guo via

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-16 Thread Kirsling, Ross
Non-unified build fixes are done to support *all* platforms, because sudden unification shifts can happen anywhere. We can't currently perform a full non-unified build on Mac since the CMake build only works up through JSC, so Sony and Igalia have been performing this maintenance by hand on

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Kirsling, Ross
No need for apology—I hugely appreciate the support on this, given the shrouded process of getting those ZIP files updated! :D Ross From: on behalf of Brent Fulgham Date: Thursday, April 9, 2020 at 3:16 PM To: Ryosuke Niwa Cc: "Kirsling, Ross" , "webkit-dev@lists.webkit.org

[webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-03 Thread Kirsling, Ross
Hi everybody, Just sending out an email blast for visibility regarding https://bugs.webkit.org/show_bug.cgi?id=209694. This patch: * Upgrades the Mac ICU headers under Source/WTF/icu from ICU 55 to ICU 62, matching Mojave * Introduces a minimum ICU version of 60.2 throughout the

Re: [webkit-dev] Terminology: Could we change 'roll out' to 'roll back'?

2020-03-06 Thread Kirsling, Ross
automated 'rollouts' turned into automated 'reverts' instead. Ross On 3/6/20, 6:31 PM, "Ryosuke Niwa" wrote: On Fri, Mar 6, 2020 at 6:15 PM Kirsling, Ross wrote: > > Late on Friday seems like a good time for a terminological debate (), so I’d like to propos

[webkit-dev] Terminology: Could we change 'roll out' to 'roll back'?

2020-03-06 Thread Kirsling, Ross
Greetings WebKittens, Late on Friday seems like a good time for a terminological debate (), so I’d like to propose we revisit one of the strangest items of WebKit-specific terminology: the phrase ‘roll out’. In our industry, the typical meaning of the phrase ‘roll out’ is, of course,

[webkit-dev] Question regarding per-file BSD license text

2017-08-22 Thread Kirsling, Ross
Hi all, I have a simple question about the license text included in each source file. My understanding is that if a non-Apple contributor adds a new file, their affiliation should only be reflected in the copyright line and NOT in the BSD license text itself (which reads "APPLE INC."), because