Re: [webkit-dev] Frustrated at inconsiderate behavior

What I noticed wrt the commit queue is that when a "core" build is broken continuously for days (like what happened with the Chromium Linux bot earlier this week for example), it causes big problems for the commit queue. Perhaps a 12 hour rule would be sufficient -- the cq doesn't submit if a buil

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Thu, Jul 8, 2010 at 15:38, Xan Lopez wrote: > Aren't you essentially saying that you like the change because it > allows you to join the fun of adding code to already broken trees? > Again, I don't see how this helps us to move towards > as-greener-as-possible trees. > > If core-builders are r

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Fri, Jul 9, 2010 at 12:30 AM, Daniel Cheng wrote: > As someone who doesn't have committer access, I like the change to the CQ. > Before, I might have to wait 3 days for a patch to land since the CQ would > wait for all the core builders to be green. Meanwhile, committers see that > the CQ is be

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Thu, Jul 8, 2010 at 14:55, Xan Lopez wrote: > On Thu, Jul 8, 2010 at 11:38 PM, Jeremy Orlow wrote: > > I think the point that's been made in this thread is that whatever policy > > the commit queue uses should be in line with whatever policies all > > committers should be using. Otherwise yo

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Thu, Jul 8, 2010 at 11:38 PM, Jeremy Orlow wrote: > I think the point that's been made in this thread is that whatever policy > the commit queue uses should be in line with whatever policies all > committers should be using.  Otherwise you run into the problems Maciej > noted. I don't see this

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Fri, Jul 9, 2010 at 2:14 AM, Xan Lopez wrote: > On Thu, Jul 8, 2010 at 8:09 PM, Adam Barth wrote: > > Originally, we had the commit-queue to land only if all the core > > builders were green. One recent change we made to make the > > commit-queue more agressive is to land when the commit-que

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Thu, Jul 8, 2010 at 8:09 PM, Adam Barth wrote: > Originally, we had the commit-queue to land only if all the core > builders were green.  One recent change we made to make the > commit-queue more agressive is to land when the commit-queue itself > sees 100% passing tests on itself.  When we wer

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Thu, Jul 8, 2010 at 10:58 AM, Xan Lopez wrote: > On Thu, Jul 8, 2010 at 7:54 PM, Adam Barth wrote: >> >> 2) Currently the commit-queue only lands if it gets a 100% passing run >> of all the tests.  We could instead change it to land if there are no >> new test failures as a result of applying

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Thu, Jul 8, 2010 at 7:54 PM, Adam Barth wrote: > > 2) Currently the commit-queue only lands if it gets a 100% passing run > of all the tests.  We could instead change it to land if there are no > new test failures as a result of applying the patch.  This check is to > avoid introducing new fail

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Wed, Jul 7, 2010 at 7:29 PM, Maciej Stachowiak wrote: > One negative externality is that it > sometimes makes people excessively upset about tree redness, and sometimes > makes them want to fix redness in a way that papers over problems (e.g. by > adding to the skipped list). If that's the mai

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Wed, Jul 7, 2010 at 9:46 PM, William Siegrist wrote: > On Jul 7, 2010, at 7:42 PM, Maciej Stachowiak wrote: > > > > > On Jul 7, 2010, at 7:32 PM, Oliver Hunt wrote: > > > >> My opinion is that if people want to use the commit-queue to land > patches they should be happy to drop their commit pri

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Jul 7, 2010, at 7:42 PM, Maciej Stachowiak wrote: > > On Jul 7, 2010, at 7:32 PM, Oliver Hunt wrote: > >> My opinion is that if people want to use the commit-queue to land patches >> they should be happy to drop their commit privileges thus mooting this >> entire issue. > > That would prob

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Jul 7, 2010, at 7:32 PM, Oliver Hunt wrote: > > webkit-patch land-safely does the job of running the tests automatically, > that said if you have commit privileges you should be running the tests > yourself otherwise you're wasting the reviewers time. > > Pushing a patch through the normal

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Jul 7, 2010, at 7:26 PM, Jeremy Orlow wrote: > On Thu, Jul 8, 2010 at 10:19 AM, Oliver Hunt wrote: > > On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote: > >> >> >> On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao wrote: >> Maybe I should complain this in a different threads, but recently the

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Jul 7, 2010, at 7:22 PM, James Robinson wrote: > > > On Wed, Jul 7, 2010 at 7:19 PM, Oliver Hunt wrote: > > On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote: > >> >> >> On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao wrote: >> Maybe I should complain this in a different threads, but recen

[webkit-dev] Frustrated at inconsiderate behavior

On Thu, Jul 8, 2010 at 10:19 AM, Oliver Hunt wrote: > > On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote: > > > > On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao wrote: > >> Maybe I should complain this in a different threads, but recently the >> commit bot waiting time is way too long. Several ti

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Wed, Jul 7, 2010 at 7:22 PM, James Robinson wrote: > > > On Wed, Jul 7, 2010 at 7:19 PM, Oliver Hunt wrote: > >> >> On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote: >> >> >> >> On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao wrote: >> >>> Maybe I should complain this in a different threads, bu

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Wed, Jul 7, 2010 at 7:19 PM, Oliver Hunt wrote: > > On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote: > > > > On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao wrote: > >> Maybe I should complain this in a different threads, but recently the >> commit bot waiting time is way too long. Several tim

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Jul 7, 2010, at 7:16 PM, Tony Gentilcore wrote: > > > On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao wrote: > Maybe I should complain this in a different threads, but recently the commit > bot waiting time is way too long. Several times a patch of mine got the r+ > and cq+ and it landed two

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Wed, Jul 7, 2010 at 6:50 PM, Mo, Zhenyao wrote: > Maybe I should complain this in a different threads, but recently the > commit bot waiting time is way too long. Several times a patch of mine got > the r+ and cq+ and it landed two days later. This is really frustrating. > > I am very tempte

Re: [webkit-dev] Frustrated at inconsiderate behavior

Maybe I should complain this in a different threads, but recently the commit bot waiting time is way too long. Several times a patch of mine got the r+ and cq+ and it landed two days later. This is really frustrating. I am very tempted to use svn directly to commit patches, but that means the pa

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Thu, Jul 8, 2010 at 2:03 AM, Alexey Proskuryakov wrote: > > 07.07.2010, в 9:49, Jeremy Orlow написал(а): > > Why did not one of those people roll the patch out when it was clear that > there were failures and Alexey wasn't in the process of fixing them? > > > Just to avoid any misunderstanding

Re: [webkit-dev] Frustrated at inconsiderate behavior

On Jul 7, 2010, at 9:45 AM, Alexey Proskuryakov wrote: > >> I think we can improve this by having sheriff-bot say which tests >> broke. I bet if you saw these tests listed, you'd have realized what >> was going one. > > > That would be very useful indeed! It currently takes some effort to fin

Re: [webkit-dev] Frustrated at inconsiderate behavior

07.07.2010, в 9:49, Jeremy Orlow написал(а): Why did not one of those people roll the patch out when it was clear that there were failures and Alexey wasn't in the process of fixing them? Just to avoid any misunderstanding, the best thing to do would have been to tell me about the probl

Re: [webkit-dev] Frustrated at inconsiderate behavior

I agree with Maciej's response, but at the same time I can understand why Adam was so frustrated. He (and others) have pointed out stuff like this on and off list over and over again with little apparent change... But that's not what I'm most worried about; why this was broken in the tree for 12

Re: [webkit-dev] Frustrated at inconsiderate behavior

07.07.2010, в 9:18, Adam Barth написал(а): This problem is now fixed thanks to William Siegrist. Patches written by committers show up correctly in SVN blame and trac even if they're landed by the commit-queue. That's good to know, I'll try that next time. I think we can improve this by ha

Re: [webkit-dev] Frustrated at inconsiderate behavior

Sorry for singling you out Alexey. I was just frustrated last night. On Wed, Jul 7, 2010 at 8:58 AM, Alexey Proskuryakov wrote: > 07.07.2010, в 00:47, Adam Barth написал(а): >> If you're tired of my complaining about the tree being red, you can >> skip this message. > > I understand that you're

Re: [webkit-dev] Frustrated at inconsiderate behavior

07.07.2010, в 00:47, Adam Barth написал(а): > If you're tired of my complaining about the tree being red, you can > skip this message. I understand that you're frustrated, but I think that you're misinterpreting what happened. > 1) He could have run-webkit-tests before committing his change.

Re: [webkit-dev] Frustrated at inconsiderate behavior

Thank you for fixing the problem. Did you try talking to Alexey directly about this? Or to someone else who may be familiar with the situation? It's usually better to try steps like that before calling someone out on the mailing list. And if you do need to bring something to wider attention, p

[webkit-dev] Frustrated at inconsiderate behavior

If you're tired of my complaining about the tree being red, you can skip this message. Today Alexey checked in , which broke two tests on every port. 12 hours later, these failures remained in the tree until I cleaned them up. This mess could have been avo