Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
Hi, > [.] > > The feature does not seem very invasive so if some people really > > invest time in maturing this, it could be worth experimenting > > with this and provide feedback to the W3C working group. > > I think everything should be behind a feature flag, and have the > > -webkit- prefix. As usual with experimental features, you will > > have to remove it if it turns out the experiment is not successful. > > > > I wouldn't characterize the nav-* properties as experimental, > > given their fairly widespread implementation among Television > > oriented profiles of HTML/CSS, going back at least to 1999 [1]. > > See also specifications from 2001 and 2003 [2][3]. > > > > As such, it seems somewhat questionable to use a -webkit- prefix. > > If we're not prefixing it, then it's very important for the initial > implementation to pass all compatibility tests W3C and/or it matches > other vendors' implementations. Agreed. Working on making W3C pass in the initial implementation was already the idea, as I mentioned in my original mail when I pointed out the tests that Opera has recently submitted [1]. Anyway, it seems to me that there are no major issues blocking this try to get this feature integrated in WebKit, besides those doubts and concerns related to how specifically execute the task. In that regard, it's my understanding a good way to proceed now might be: * Polish the patch and update it to match the current codebase properly. * Put these changes behind a feature flag. To be enabled in WebKitGTK+. * Ensure the patch passes W3C tests[1]. Include the tests with the patch. * Submit the patch for review. About the prefix, I'd personally prefer to move on without it for now and leave that decision for a further step, once this work has been fleshed out a bit more. Is anyone against this plan? Thanks, Mario [1] http://lists.w3.org/Archives/Public/public-css-testsuite/2013Jul/0004.html ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
El vie, 26-07-2013 a las 20:07 -0700, Benjamin Poulain escribió: > On Fri, Jul 26, 2013 at 1:57 AM, Mario Sanchez Prada < > mario.pr...@samsung.com> wrote: > > > > Ah, When I made a new patch, had doubts about the file name "Deprecated". > > > So, I have to wait the "StyleBuilder" Class to have a clear form. > > > > On this regard, some input from Dirk Schulze could probably be very useful > > as guidance here, as he was the original author of the commit where this > > class got deprecated[1]. > > > > It is a work in progress to clean the StyleBuilder. > > > > > Also, I'm waiting for the community to conclude this discussion. > > > > Me too. > > > > Honestly, I am concerned that no one in favor of this feature is a regular > contributor. Mario has volunteered to maintain this feature, or do you really mean Mario is not a regular contributor? > The feature does not seem very invasive so if some people really invest > time in maturing this, it could be worth experimenting with this and > provide feedback to the W3C working group. > I think everything should be behind a feature flag, and have the -webkit- > prefix. As usual with experimental features, you will have to remove it if > it turns out the experiment is not successful. > > Benjamin > On Fri, Jul 26, 2013 at 1:57 AM, Mario Sanchez Prada > wrote: > > Ah, When I made a new patch, had doubts about the file name > "Deprecated". > > So, I have to wait the "StyleBuilder" Class to have a clear > form. > > > On this regard, some input from Dirk Schulze could probably be > very useful > as guidance here, as he was the original author of the commit > where this > class got deprecated[1]. > > > It is a work in progress to clean the StyleBuilder. > > > Also, I'm waiting for the community to conclude this > discussion. > > > Me too. > > > Honestly, I am concerned that no one in favor of this feature is a > regular contributor. > > > The feature does not seem very invasive so if some people really > invest time in maturing this, it could be worth experimenting with > this and provide feedback to the W3C working group. > I think everything should be behind a feature flag, and have the > -webkit- prefix. As usual with experimental features, you will have to > remove it if it turns out the experiment is not successful. > > > Benjamin > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
On Sun, Jul 28, 2013 at 12:27 AM, Glenn Adams wrote: > > On Fri, Jul 26, 2013 at 9:07 PM, Benjamin Poulain wrote: > >> On Fri, Jul 26, 2013 at 1:57 AM, Mario Sanchez Prada < >> mario.pr...@samsung.com> wrote: >> >>> > Ah, When I made a new patch, had doubts about the file name >>> "Deprecated". >>> > So, I have to wait the "StyleBuilder" Class to have a clear form. >>> >>> On this regard, some input from Dirk Schulze could probably be very >>> useful >>> as guidance here, as he was the original author of the commit where this >>> class got deprecated[1]. >>> >> >> It is a work in progress to clean the StyleBuilder. >> >> >>> > Also, I'm waiting for the community to conclude this discussion. >>> >>> Me too. >>> >> >> Honestly, I am concerned that no one in favor of this feature is a >> regular contributor. >> >> The feature does not seem very invasive so if some people really invest >> time in maturing this, it could be worth experimenting with this and >> provide feedback to the W3C working group. >> I think everything should be behind a feature flag, and have the -webkit- >> prefix. As usual with experimental features, you will have to remove it if >> it turns out the experiment is not successful. >> > > I wouldn't characterize the nav-* properties as experimental, given their > fairly widespread implementation among Television oriented profiles of > HTML/CSS, going back at least to 1999 [1]. See also specifications from > 2001 and 2003 [2][3]. > > As such, it seems somewhat questionable to use a -webkit- prefix. > If we're not prefixing it, then it's very important for the initial implementation to pass all compatibility tests W3C and/or it matches other vendors' implementations. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
On Fri, Jul 26, 2013 at 9:07 PM, Benjamin Poulain wrote: > On Fri, Jul 26, 2013 at 1:57 AM, Mario Sanchez Prada < > mario.pr...@samsung.com> wrote: > >> > Ah, When I made a new patch, had doubts about the file name >> "Deprecated". >> > So, I have to wait the "StyleBuilder" Class to have a clear form. >> >> On this regard, some input from Dirk Schulze could probably be very useful >> as guidance here, as he was the original author of the commit where this >> class got deprecated[1]. >> > > It is a work in progress to clean the StyleBuilder. > > >> > Also, I'm waiting for the community to conclude this discussion. >> >> Me too. >> > > Honestly, I am concerned that no one in favor of this feature is a regular > contributor. > > The feature does not seem very invasive so if some people really invest > time in maturing this, it could be worth experimenting with this and > provide feedback to the W3C working group. > I think everything should be behind a feature flag, and have the -webkit- > prefix. As usual with experimental features, you will have to remove it if > it turns out the experiment is not successful. > I wouldn't characterize the nav-* properties as experimental, given their fairly widespread implementation among Television oriented profiles of HTML/CSS, going back at least to 1999 [1]. See also specifications from 2001 and 2003 [2][3]. As such, it seems somewhat questionable to use a -webkit- prefix. [1] http://www.arib.or.jp/english/html/overview/archives/br/ARIB_STD-B24-2_2of2_v5.1_E1.pdf [2] http://www.atsc.org/cms/standards/a100/a_100_2.pdf [3] http://my.safaribooksonline.com/book/digital-media/9780240806662/15-building-applications-with-html/s235_xhtml ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
On Fri, Jul 26, 2013 at 1:57 AM, Mario Sanchez Prada < mario.pr...@samsung.com> wrote: > > Ah, When I made a new patch, had doubts about the file name "Deprecated". > > So, I have to wait the "StyleBuilder" Class to have a clear form. > > On this regard, some input from Dirk Schulze could probably be very useful > as guidance here, as he was the original author of the commit where this > class got deprecated[1]. > It is a work in progress to clean the StyleBuilder. > > Also, I'm waiting for the community to conclude this discussion. > > Me too. > Honestly, I am concerned that no one in favor of this feature is a regular contributor. The feature does not seem very invasive so if some people really invest time in maturing this, it could be worth experimenting with this and provide feedback to the W3C working group. I think everything should be behind a feature flag, and have the -webkit- prefix. As usual with experimental features, you will have to remove it if it turns out the experiment is not successful. Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
Hy Kyounga, > From: Kyounga Ra [mailto:kyounga...@gmail.com] > [...] > Hi Mario, > > Thanks for your kind comments in detail. You're welcome. Thanks to you for your patch and doing this work in the first place! > I would be very thankful for you to do that work (using/maintaining this feature) for WebKitGTK+ port. > Of course, it helps to enhance first patch's quality. That's the idea, as well as helping normalize the situation about something that has been widely used for a while already in downstream ports. > (Please keep my comment. "Copyright (C) 2013 Alticast Corporation. All rights reserved." with your comment.) Of course, you are the original author of the patch. The only reason why you don't see those lines in my experiment in github is because I based that work on your previous patch, which did not contain those lines at all. > Ah, When I made a new patch, had doubts about the file name "Deprecated". > So, I have to wait the "StyleBuilder" Class to have a clear form. On this regard, some input from Dirk Schulze could probably be very useful as guidance here, as he was the original author of the commit where this class got deprecated[1]. > Also, I'm waiting for the community to conclude this discussion. Me too. Thanks, Mario [1] http://trac.webkit.org/changeset/148363 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
Hi Antonio, > -Original Message- > From: toniki...@gmail.com [mailto:toniki...@gmail.com] On Behalf Of > Antonio Gomes > [...] > Ah, thanks for clarifying. That changes the scenario then. Question is > back to open: is there any port that would be willing to have this > feature's build flag ON by default? As Martin said, no upstream port is currently shipping this feature at the moment, but that's precisely why we were proposing ourselves to help with it and also to maintain it in WebKitGTK+ once the patch is accepted and integrated. And that includes doing all the required work to have that build flag set to ON by default in that port. Regarding to that, I also think it would be valuable for the discussion if someone else from the WebKitGTK+ team could explicitly mention here whether they would be in favour or not to have such a feature enabled, all things considered. Thanks, Mario ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
I'm working with WebKit on Linux and will use and maintain on my WebKit. It could be meaningful as one of the WebKit ports? -Kyounga 2013/7/26 Antonio Gomes > Ah, thanks for clarifying. That changes the scenario then. Question is > back to open: is there any port that would be willing to have this > feature's build flag ON by default? > > Cheers, > > On Thu, Jul 25, 2013 at 3:38 PM, Martin Robinson > wrote: > > On Thu, Jul 25, 2013 at 7:01 AM, Antonio Gomes > wrote: > >> Given that we have a port shipping it (GTK), and usage and interest > >> from on the TV industry and that Opera is working hard to get it > >> included to CSS3 UI spec, it looks good to me for implementing this > >> feature. If there is no objections, please proceed and guard it behind > >> a build flag. > > > > For the sake of clarity: as far as I know, WebKitGTK+ does not have > > nor is shipping this feature. It may be shipping on some downstream > > and proprietary version of the GTK+ port, though. > > > > --Martin > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
Hi Mario, Thanks for your kind comments in detail. I would be very thankful for you to do that work (using/maintaining this feature) for WebKitGTK+ port. Of course, it helps to enhance first patch's quality. (Please keep my comment. "Copyright (C) 2013 Alticast Corporation. All rights reserved." with your comment.) Ah, When I made a new patch, had doubts about the file name "Deprecated". So, I have to wait the "StyleBuilder" Class to have a clear form. Also, I'm waiting for the community to conclude this discussion. -Kyounga 2013/7/25 Mario Sanchez Prada > Hi Kyounga, > > > [...] > > First, I filed up my new patch based on the latest webkit without new > feature-name even though this discussion wasn't concluded. > > I did not find any patch in bugzilla for bug 66027 newer than the one from > Jan 2012 when I started doing the experiments, so that's why I came up with > my own rebased version. Now I see you posted a newer version already, > thanks > for doing that. > > > If you think this feature should be behind ENABLE_CSS_DIRECTIONAL_FOCUS, > I'll make a new patch. > > That's probably a good idea but first we need to clarify whether this might > fit or not integrated in webkit.org. And in order to do that, as Benjamin > mentioned, we need to have at least one port using and maintaining that > feature, so that's why I proposed that we could help doing that work for > the > WebKitGTK+ port, besides helping with the development of your patch, if you > wish. > > > If this feature is widely used in TV industry and is included in next > CSS4, > > it is not bad implementing this feature in Webkit. Isn't it? > > I agree with you, but for the feature to make it to upstream WebKit some > more things are needed, as it was explained previously in this thread. > > > And then, should I mark the 66027 bug as "Reopended" to review it? > > I would say so, but before asking for review over it, and besides the > ongoing discussion here, I believe the patch needs still some changes in > addition to being rebased, such as adding tests to it and probably > re-writting the part based on the now called DeprecatedStyleBuilder which, > according to r148363, should not be used to add new properties since a > while > ago. > > Thanks for your reply, > Mario > > [1] http://trac.webkit.org/changeset/148363 > > > -Kyounga > > > > > 2013/7/25 Mario Sanchez Prada > > > Hi, > > > > > > For the sake of completeness, I'd like to mention that this feature is > also > > > used in the Hbbtv browser shipped with Samsung TVs, as Giuseppe Pascale > from > > > Opera already pointed out in a recent discussion[1]. > > > > > > That, together with what it was mentioned about the SmartTV Alliance > using > > > it, means that pretty much the whole TV world is relying quite a bit on > this > > > thing nowadays, so it would be great if we could have it integrated and > > > supported upstream. > > > > > > That being said, we at the Samsung would be happy to support this > feature > > > actively in WebKit, both by helping with the patch that's already in > > > Bugzilla [2] *and* maintaining it in at least one port. Should that be > the > > > case, the obvious choice for us would be the WebKitGTK port, since > that's > > > what we currently have on our TVs. > > > > > > Problem is that the patch in [2] is quite old already (Jan 2012), so it > > > would be awesome if Kyounga Ra attached a newer version of it, since > that > > > one depends on some parts that are now deprecated or simply refactored > in > > > some way, as I could check today while experimenting with it on top of > > > latest WebKit [3]. > > > > > > Last, regarding to tests, just to mention that Opera has recently > submitted > > > tests for this feature (see [4]). This would be IMHO another good point > to > > > keep in mind here, since we could import them in WebKit too. > > > > > > What do you think? > > > Mario > > > > > > [1] http://lists.w3.org/Archives/Public/www-style/2013Jun/0332.html > > > [2] https://bugs.webkit.org/show_bug.cgi?id=66027 > > > [3] > > https://github.com/mariospr/webkit/commit/5bda577699599aa4f99192380b46ad73e5 > ea1672 > > > [4] > http://lists.w3.org/Archives/Public/public-css-testsuite/2013Jul/0004.html > > > > > -Original Message- > > > From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- > > > boun
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
Ah, thanks for clarifying. That changes the scenario then. Question is back to open: is there any port that would be willing to have this feature's build flag ON by default? Cheers, On Thu, Jul 25, 2013 at 3:38 PM, Martin Robinson wrote: > On Thu, Jul 25, 2013 at 7:01 AM, Antonio Gomes wrote: >> Given that we have a port shipping it (GTK), and usage and interest >> from on the TV industry and that Opera is working hard to get it >> included to CSS3 UI spec, it looks good to me for implementing this >> feature. If there is no objections, please proceed and guard it behind >> a build flag. > > For the sake of clarity: as far as I know, WebKitGTK+ does not have > nor is shipping this feature. It may be shipping on some downstream > and proprietary version of the GTK+ port, though. > > --Martin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
On Thu, Jul 25, 2013 at 7:01 AM, Antonio Gomes wrote: > Given that we have a port shipping it (GTK), and usage and interest > from on the TV industry and that Opera is working hard to get it > included to CSS3 UI spec, it looks good to me for implementing this > feature. If there is no objections, please proceed and guard it behind > a build flag. For the sake of clarity: as far as I know, WebKitGTK+ does not have nor is shipping this feature. It may be shipping on some downstream and proprietary version of the GTK+ port, though. --Martin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
On Tue, Jul 23, 2013 at 12:17 AM, Kyounga Ra wrote: > Hi webkit-dev! > > I'd like to add new feature for CSS nav-[dir] properties. > https://bugs.webkit.org/show_bug.cgi?id=66027 > > This feature is for > http://dev.w3.org/csswg/css3-ui/#nav-dir > On recent discussion, these nav-* properties was dropped from level 3. > http://lists.w3.org/Archives/Public/www-style/2013Apr/0428.html > > But, I need this feature. (I'm in the TV industry.) > Honestly, already implemented and have used it. > You can see my previous patch. > > At that time, I thought that this is W3C standard and we didn't need to > develop it behind a defined feature name. > Now, this property was dropped from CSS. > Actually, it hasn't been dropped. It was decided to move from CSS3 Basic UI to a new level 4 version; however, that earlier decision was recently vacated after Opera and others supported its retention in level 3 (where it will continue to be marked as "at risk" pending the results of a CR phase). [1] http://dev.w3.org/csswg/css-ui/#nav-index0 [2] http://lists.w3.org/Archives/Public/www-style/2013Jul/0090.html > So, is it okay implementing this feature behind > ENABLE_CSS_DIRECTIONAL_FOCUS? > > I re-ported this feature whenever I rebase my webkit. > It's troublesome job. > > how about you > Adding "ENABLE_CSS_DIRECTIONAL_FOCUS" is not bad? > > Any comments are welcome. > > - Kyounga > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
Given that we have a port shipping it (GTK), and usage and interest from on the TV industry and that Opera is working hard to get it included to CSS3 UI spec, it looks good to me for implementing this feature. If there is no objections, please proceed and guard it behind a build flag. Cheers, On Thu, Jul 25, 2013 at 7:04 AM, Mario Sanchez Prada wrote: > Hi Kyounga, > >> [...] >> First, I filed up my new patch based on the latest webkit without new > feature-name even though this discussion wasn't concluded. > > I did not find any patch in bugzilla for bug 66027 newer than the one from > Jan 2012 when I started doing the experiments, so that's why I came up with > my own rebased version. Now I see you posted a newer version already, thanks > for doing that. > >> If you think this feature should be behind ENABLE_CSS_DIRECTIONAL_FOCUS, > I'll make a new patch. > > That's probably a good idea but first we need to clarify whether this might > fit or not integrated in webkit.org. And in order to do that, as Benjamin > mentioned, we need to have at least one port using and maintaining that > feature, so that's why I proposed that we could help doing that work for the > WebKitGTK+ port, besides helping with the development of your patch, if you > wish. > >> If this feature is widely used in TV industry and is included in next > CSS4, >> it is not bad implementing this feature in Webkit. Isn't it? > > I agree with you, but for the feature to make it to upstream WebKit some > more things are needed, as it was explained previously in this thread. > >> And then, should I mark the 66027 bug as "Reopended" to review it? > > I would say so, but before asking for review over it, and besides the > ongoing discussion here, I believe the patch needs still some changes in > addition to being rebased, such as adding tests to it and probably > re-writting the part based on the now called DeprecatedStyleBuilder which, > according to r148363, should not be used to add new properties since a while > ago. > > Thanks for your reply, > Mario > > [1] http://trac.webkit.org/changeset/148363 > >> -Kyounga >> >> > 2013/7/25 Mario Sanchez Prada >> > Hi, >> > >> > For the sake of completeness, I'd like to mention that this feature is > also >> > used in the Hbbtv browser shipped with Samsung TVs, as Giuseppe Pascale > from >> > Opera already pointed out in a recent discussion[1]. >> > >> > That, together with what it was mentioned about the SmartTV Alliance > using >> > it, means that pretty much the whole TV world is relying quite a bit on > this >> > thing nowadays, so it would be great if we could have it integrated and >> > supported upstream. >> > >> > That being said, we at the Samsung would be happy to support this > feature >> > actively in WebKit, both by helping with the patch that's already in >> > Bugzilla [2] *and* maintaining it in at least one port. Should that be > the >> > case, the obvious choice for us would be the WebKitGTK port, since > that's >> > what we currently have on our TVs. >> > >> > Problem is that the patch in [2] is quite old already (Jan 2012), so it >> > would be awesome if Kyounga Ra attached a newer version of it, since > that >> > one depends on some parts that are now deprecated or simply refactored > in >> > some way, as I could check today while experimenting with it on top of >> > latest WebKit [3]. >> > >> > Last, regarding to tests, just to mention that Opera has recently > submitted >> > tests for this feature (see [4]). This would be IMHO another good point > to >> > keep in mind here, since we could import them in WebKit too. >> > >> > What do you think? >> > Mario >> > >> > [1] http://lists.w3.org/Archives/Public/www-style/2013Jun/0332.html >> > [2] https://bugs.webkit.org/show_bug.cgi?id=66027 >> > [3] > https://github.com/mariospr/webkit/commit/5bda577699599aa4f99192380b46ad73e5 > ea1672 >> > [4] > http://lists.w3.org/Archives/Public/public-css-testsuite/2013Jul/0004.html >> >> > -Original Message- >> > From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- >> > boun...@lists.webkit.org] On Behalf Of Danilo Cesar Lemes de Paula >> > Sent: 24 July 2013 14:52 >> > To: webkit-dev@lists.webkit.org >> > Subject: Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to >> > WebCore. >> > >> > On 07/23/2013 09:26 P
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
Hi Kyounga, > [...] > First, I filed up my new patch based on the latest webkit without new feature-name even though this discussion wasn't concluded. I did not find any patch in bugzilla for bug 66027 newer than the one from Jan 2012 when I started doing the experiments, so that's why I came up with my own rebased version. Now I see you posted a newer version already, thanks for doing that. > If you think this feature should be behind ENABLE_CSS_DIRECTIONAL_FOCUS, I'll make a new patch. That's probably a good idea but first we need to clarify whether this might fit or not integrated in webkit.org. And in order to do that, as Benjamin mentioned, we need to have at least one port using and maintaining that feature, so that's why I proposed that we could help doing that work for the WebKitGTK+ port, besides helping with the development of your patch, if you wish. > If this feature is widely used in TV industry and is included in next CSS4, > it is not bad implementing this feature in Webkit. Isn't it? I agree with you, but for the feature to make it to upstream WebKit some more things are needed, as it was explained previously in this thread. > And then, should I mark the 66027 bug as "Reopended" to review it? I would say so, but before asking for review over it, and besides the ongoing discussion here, I believe the patch needs still some changes in addition to being rebased, such as adding tests to it and probably re-writting the part based on the now called DeprecatedStyleBuilder which, according to r148363, should not be used to add new properties since a while ago. Thanks for your reply, Mario [1] http://trac.webkit.org/changeset/148363 > -Kyounga > > > 2013/7/25 Mario Sanchez Prada > > Hi, > > > > For the sake of completeness, I'd like to mention that this feature is also > > used in the Hbbtv browser shipped with Samsung TVs, as Giuseppe Pascale from > > Opera already pointed out in a recent discussion[1]. > > > > That, together with what it was mentioned about the SmartTV Alliance using > > it, means that pretty much the whole TV world is relying quite a bit on this > > thing nowadays, so it would be great if we could have it integrated and > > supported upstream. > > > > That being said, we at the Samsung would be happy to support this feature > > actively in WebKit, both by helping with the patch that's already in > > Bugzilla [2] *and* maintaining it in at least one port. Should that be the > > case, the obvious choice for us would be the WebKitGTK port, since that's > > what we currently have on our TVs. > > > > Problem is that the patch in [2] is quite old already (Jan 2012), so it > > would be awesome if Kyounga Ra attached a newer version of it, since that > > one depends on some parts that are now deprecated or simply refactored in > > some way, as I could check today while experimenting with it on top of > > latest WebKit [3]. > > > > Last, regarding to tests, just to mention that Opera has recently submitted > > tests for this feature (see [4]). This would be IMHO another good point to > > keep in mind here, since we could import them in WebKit too. > > > > What do you think? > > Mario > > > > [1] http://lists.w3.org/Archives/Public/www-style/2013Jun/0332.html > > [2] https://bugs.webkit.org/show_bug.cgi?id=66027 > > [3] https://github.com/mariospr/webkit/commit/5bda577699599aa4f99192380b46ad73e5 ea1672 > > [4] http://lists.w3.org/Archives/Public/public-css-testsuite/2013Jul/0004.html > > > -Original Message- > > From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- > > boun...@lists.webkit.org] On Behalf Of Danilo Cesar Lemes de Paula > > Sent: 24 July 2013 14:52 > > To: webkit-dev@lists.webkit.org > > Subject: Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to > > WebCore. > > > > On 07/23/2013 09:26 PM, Kyounga Ra wrote: > > > -Which browsers are shipping the feature? > > > -Which browsers are planning to ship the feature? > > > A) other major browsers? opera presto > > > also Webkit-based TV browsers support it. > > > > > > -Is it a mature standard (or an amazing feature) that one of the > > > WebKit ports wants to maintain? > > > A) not matured yet. but these properties are widely used by the TV > > > industry. > > > TV industry people like me want to maintain. > > > > > > > nav-[dir] is a required part of the SmartTV Alliance spec, so it's > > probably being used by Phillips, LG and Toshiba TVs. > > > > Danilo Cesar > > > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
Hi, First, I filed up my new patch based on the latest webkit without new feature-name even though this discussion wasn't concluded. If you think this feature should be behind ENABLE_CSS_DIRECTIONAL_FOCUS, I'll make a new patch. If this feature is widely used in TV industry and is included in next CSS4, it is not bad implementing this feature in Webkit. Isn't it? And then, should I mark the 66027 bug as "Reopended" to review it? -Kyounga 2013/7/25 Mario Sanchez Prada > Hi, > > For the sake of completeness, I'd like to mention that this feature is also > used in the Hbbtv browser shipped with Samsung TVs, as Giuseppe Pascale > from > Opera already pointed out in a recent discussion[1]. > > That, together with what it was mentioned about the SmartTV Alliance using > it, means that pretty much the whole TV world is relying quite a bit on > this > thing nowadays, so it would be great if we could have it integrated and > supported upstream. > > That being said, we at the Samsung would be happy to support this feature > actively in WebKit, both by helping with the patch that's already in > Bugzilla [2] *and* maintaining it in at least one port. Should that be the > case, the obvious choice for us would be the WebKitGTK port, since that's > what we currently have on our TVs. > > Problem is that the patch in [2] is quite old already (Jan 2012), so it > would be awesome if Kyounga Ra attached a newer version of it, since that > one depends on some parts that are now deprecated or simply refactored in > some way, as I could check today while experimenting with it on top of > latest WebKit [3]. > > Last, regarding to tests, just to mention that Opera has recently submitted > tests for this feature (see [4]). This would be IMHO another good point to > keep in mind here, since we could import them in WebKit too. > > What do you think? > Mario > > [1] http://lists.w3.org/Archives/Public/www-style/2013Jun/0332.html > [2] https://bugs.webkit.org/show_bug.cgi?id=66027 > [3] > > https://github.com/mariospr/webkit/commit/5bda577699599aa4f99192380b46ad73e5 > ea1672 > [4] > http://lists.w3.org/Archives/Public/public-css-testsuite/2013Jul/0004.html > > > -Original Message- > > From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- > > boun...@lists.webkit.org] On Behalf Of Danilo Cesar Lemes de Paula > > Sent: 24 July 2013 14:52 > > To: webkit-dev@lists.webkit.org > > Subject: Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to > > WebCore. > > > > On 07/23/2013 09:26 PM, Kyounga Ra wrote: > > > -Which browsers are shipping the feature? > > > -Which browsers are planning to ship the feature? > > > A) other major browsers? opera presto > > > also Webkit-based TV browsers support it. > > > > > > -Is it a mature standard (or an amazing feature) that one of the > > > WebKit ports wants to maintain? > > > A) not matured yet. but these properties are widely used by the TV > > > industry. > > > TV industry people like me want to maintain. > > > > > > > nav-[dir] is a required part of the SmartTV Alliance spec, so it's > > probably being used by Phillips, LG and Toshiba TVs. > > > > Danilo Cesar > > > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > https://lists.webkit.org/mailman/listinfo/webkit-dev > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
Hi, For the sake of completeness, I'd like to mention that this feature is also used in the Hbbtv browser shipped with Samsung TVs, as Giuseppe Pascale from Opera already pointed out in a recent discussion[1]. That, together with what it was mentioned about the SmartTV Alliance using it, means that pretty much the whole TV world is relying quite a bit on this thing nowadays, so it would be great if we could have it integrated and supported upstream. That being said, we at the Samsung would be happy to support this feature actively in WebKit, both by helping with the patch that's already in Bugzilla [2] *and* maintaining it in at least one port. Should that be the case, the obvious choice for us would be the WebKitGTK port, since that's what we currently have on our TVs. Problem is that the patch in [2] is quite old already (Jan 2012), so it would be awesome if Kyounga Ra attached a newer version of it, since that one depends on some parts that are now deprecated or simply refactored in some way, as I could check today while experimenting with it on top of latest WebKit [3]. Last, regarding to tests, just to mention that Opera has recently submitted tests for this feature (see [4]). This would be IMHO another good point to keep in mind here, since we could import them in WebKit too. What do you think? Mario [1] http://lists.w3.org/Archives/Public/www-style/2013Jun/0332.html [2] https://bugs.webkit.org/show_bug.cgi?id=66027 [3] https://github.com/mariospr/webkit/commit/5bda577699599aa4f99192380b46ad73e5 ea1672 [4] http://lists.w3.org/Archives/Public/public-css-testsuite/2013Jul/0004.html > -Original Message- > From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- > boun...@lists.webkit.org] On Behalf Of Danilo Cesar Lemes de Paula > Sent: 24 July 2013 14:52 > To: webkit-dev@lists.webkit.org > Subject: Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to > WebCore. > > On 07/23/2013 09:26 PM, Kyounga Ra wrote: > > -Which browsers are shipping the feature? > > -Which browsers are planning to ship the feature? > > A) other major browsers? opera presto > > also Webkit-based TV browsers support it. > > > > -Is it a mature standard (or an amazing feature) that one of the > > WebKit ports wants to maintain? > > A) not matured yet. but these properties are widely used by the TV > > industry. > > TV industry people like me want to maintain. > > > > nav-[dir] is a required part of the SmartTV Alliance spec, so it's > probably being used by Phillips, LG and Toshiba TVs. > > Danilo Cesar > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
On 07/23/2013 09:26 PM, Kyounga Ra wrote: > -Which browsers are shipping the feature? > -Which browsers are planning to ship the feature? > A) other major browsers? opera presto > also Webkit-based TV browsers support it. > > -Is it a mature standard (or an amazing feature) that one of the WebKit > ports wants to maintain? > A) not matured yet. but these properties are widely used by the TV > industry. > TV industry people like me want to maintain. > nav-[dir] is a required part of the SmartTV Alliance spec, so it's probably being used by Phillips, LG and Toshiba TVs. Danilo Cesar ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/23/2013 09:26 PM, Kyounga Ra wrote: > -Which browsers are shipping the feature? -Which browsers are > planning to ship the feature? A) other major browsers? opera > presto also Webkit-based TV browsers support it. > nav-[dir] is a required part of the SmartTV Alliance spec, so it's probably being used by Phillips, LG and Toshiba TVs. Danilo Cesar -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iQIcBAEBAgAGBQJR79rsAAoJEIvTIZEF7lnMmcYQAJbn2ImfdCxphdZBJHCoA/yz 7nmgH9l/plC5uVU/tYPnNw+eQbyHISz4LAHFJEzQqn1jDJOark/zxrgmMv1LoVUB /Ch0hRDPYbLlFSOqKjKCp/bWrWuD5KStRO75gKi+dwnF3zTHzhGp8oV7l1mWcyBd q9xrKo/8AXmTwUrsPLabKuaAHm47rTIA192VzKuTtRUcAtSAA+loJKFEiQOSfS+6 c5QIjjcZbhFj3TPy5JkwbQarj9/h0T1IhEeYYa6/FW+kU2XP9WH30xFt/mx9fsks XIWGjXABHhyf1iKPXd00LJSDhJ6KURAzAilNdkVGIUqesl22O8RCwg/wMfrZE84m hAusxSOp3oZNelSwY1oAhxkBgR+qioMqIoDpVUIH3a72EDCdof4dcRkMTGT2v0iv 4FM1nUgKVtIPrEtHEkSbxGOL1mVuglnYLuqpzOnv7fUUEGZVdU/TGlaiKN6lOrmU lLKPTIQGogXPoVIK8G66k2uDnfriejPIZL0NARx3e3Acil4tMMLh0WwhmfR4pNGB WtZVT0Vmabt9UDJwbMczmkOUkAUJx5Y+c6ouioahR+DsL6Lp6hKb9MuEZz3pbIso rBVPZRAB8OgcTCrPvoQbuEEWypSYrfnZomWMCI27wdjx8qfAA/IqxmdKWKiGTCDc ec9WA5SBptZe7anQ/iO6 =er4X -END PGP SIGNATURE- ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
-Which browsers are shipping the feature? -Which browsers are planning to ship the feature? A) other major browsers? opera presto also Webkit-based TV browsers support it. -Is it a mature standard (or an amazing feature) that one of the WebKit ports wants to maintain? A) not matured yet. but these properties are widely used by the TV industry. TV industry people like me want to maintain. 2013/7/24 Benjamin Poulain > Hi, > > > On Mon, Jul 22, 2013 at 11:17 PM, Kyounga Ra wrote: > >> I'd like to add new feature for CSS nav-[dir] properties. >> https://bugs.webkit.org/show_bug.cgi?id=66027 >> >> This feature is for >> http://dev.w3.org/csswg/css3-ui/#nav-dir >> On recent discussion, these nav-* properties was dropped from level 3. >> http://lists.w3.org/Archives/Public/www-style/2013Apr/0428.html >> >> But, I need this feature. (I'm in the TV industry.) >> Honestly, already implemented and have used it. >> You can see my previous patch. >> >> At that time, I thought that this is W3C standard and we didn't need to >> develop it behind a defined feature name. >> Now, this property was dropped from CSS. >> So, is it okay implementing this feature behind >> ENABLE_CSS_DIRECTIONAL_FOCUS? >> >> I re-ported this feature whenever I rebase my webkit. >> It's troublesome job. >> >> how about you >> Adding "ENABLE_CSS_DIRECTIONAL_FOCUS" is not bad? >> > > Adding new features has a big cost on the project, that is not the kind of > thing we do lightly. > > Feature flags are there to allow ports to disable a feature before > shipping a product. For example, if Apple decide adds a feature and GTK > decides it is not ready for shipping, the feature can be disabled for > releasing of WebKitGTK. Feature flags are not not a free pass to add code > that is not shipped by any port. > > The important questions to add CSS-nav are: > -Which browsers are shipping the feature? > -Which browsers are planning to ship the feature? > -Is it a mature standard (or an amazing feature) that one of the WebKit > ports wants to maintain? > > Benjamin > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
Hi, On Mon, Jul 22, 2013 at 11:17 PM, Kyounga Ra wrote: > I'd like to add new feature for CSS nav-[dir] properties. > https://bugs.webkit.org/show_bug.cgi?id=66027 > > This feature is for > http://dev.w3.org/csswg/css3-ui/#nav-dir > On recent discussion, these nav-* properties was dropped from level 3. > http://lists.w3.org/Archives/Public/www-style/2013Apr/0428.html > > But, I need this feature. (I'm in the TV industry.) > Honestly, already implemented and have used it. > You can see my previous patch. > > At that time, I thought that this is W3C standard and we didn't need to > develop it behind a defined feature name. > Now, this property was dropped from CSS. > So, is it okay implementing this feature behind > ENABLE_CSS_DIRECTIONAL_FOCUS? > > I re-ported this feature whenever I rebase my webkit. > It's troublesome job. > > how about you > Adding "ENABLE_CSS_DIRECTIONAL_FOCUS" is not bad? > Adding new features has a big cost on the project, that is not the kind of thing we do lightly. Feature flags are there to allow ports to disable a feature before shipping a product. For example, if Apple decide adds a feature and GTK decides it is not ready for shipping, the feature can be disabled for releasing of WebKitGTK. Feature flags are not not a free pass to add code that is not shipped by any port. The important questions to add CSS-nav are: -Which browsers are shipping the feature? -Which browsers are planning to ship the feature? -Is it a mature standard (or an amazing feature) that one of the WebKit ports wants to maintain? Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
On 07/23/2013 08:17 AM, Kyounga Ra wrote: Hi webkit-dev! I'd like to add new feature for CSS nav-[dir] properties. https://bugs.webkit.org/show_bug.cgi?id=66027 This feature is for http://dev.w3.org/csswg/css3-ui/#nav-dir On recent discussion, these nav-* properties was dropped from level 3. http://lists.w3.org/Archives/Public/www-style/2013Apr/0428.html Note that since then, Opera has been working to get the nav-up/down/left/right properties added back to css3: http://lists.w3.org/Archives/Public/www-style/2013Jul/0090.html http://www.w3.org/Style/CSS/Tracker/actions/565?changelog -Mostyn. But, I need this feature. (I'm in the TV industry.) Honestly, already implemented and have used it. You can see my previous patch. At that time, I thought that this is W3C standard and we didn't need to develop it behind a defined feature name. Now, this property was dropped from CSS. So, is it okay implementing this feature behind ENABLE_CSS_DIRECTIONAL_FOCUS? I re-ported this feature whenever I rebase my webkit. It's troublesome job. how about you Adding "ENABLE_CSS_DIRECTIONAL_FOCUS" is not bad? Any comments are welcome. - Kyounga ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- Mostyn Bramley-Moore most...@opera.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
Hi webkit-dev! I'd like to add new feature for CSS nav-[dir] properties. https://bugs.webkit.org/show_bug.cgi?id=66027 This feature is for http://dev.w3.org/csswg/css3-ui/#nav-dir On recent discussion, these nav-* properties was dropped from level 3. http://lists.w3.org/Archives/Public/www-style/2013Apr/0428.html But, I need this feature. (I'm in the TV industry.) Honestly, already implemented and have used it. You can see my previous patch. At that time, I thought that this is W3C standard and we didn't need to develop it behind a defined feature name. Now, this property was dropped from CSS. So, is it okay implementing this feature behind ENABLE_CSS_DIRECTIONAL_FOCUS? I re-ported this feature whenever I rebase my webkit. It's troublesome job. how about you Adding "ENABLE_CSS_DIRECTIONAL_FOCUS" is not bad? Any comments are welcome. - Kyounga ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
