Re: [webkit-dev] Crashes during testing

2010-02-26 Thread Jeremy Orlow
Personally, I've found those kind of changes are responsible for a disproportionate percentage of build errors and bugs. :-) On Fri, Feb 26, 2010 at 5:16 PM, Darin Adler wrote: > On Feb 26, 2010, at 1:42 AM, Jeremy Orlow wrote: > > > Did you run the layout tests at all? > > Oliver already said

Re: [webkit-dev] Crashes during testing

2010-02-26 Thread Darin Adler
On Feb 26, 2010, at 1:42 AM, Jeremy Orlow wrote: > Did you run the layout tests at all? Oliver already said that he did, but before he made the small last minute change that caused the crash. -- Darin ___ webkit-dev mailing list webkit-dev@lists.

Re: [webkit-dev] Crashes during testing

2010-02-26 Thread Jeremy Orlow
On Fri, Feb 26, 2010 at 12:03 AM, Oliver Hunt wrote: > But any regressions would have been blamed on eric. > His name would show up in the SVN log, sure, but I don't think that'd fool your average WebKit developer for long. webkit-patch land does the correct thing, but i disable the testing pri

Re: [webkit-dev] Crashes during testing

2010-02-25 Thread Adam Barth
On Thu, Feb 25, 2010 at 3:03 PM, Oliver Hunt wrote: > But any regressions would have been blamed on eric. > > webkit-patch land does the correct thing, but i disable the testing prior to > commit because a 25 minute delay prior to committing is more or less > guaranteed to cause it to fail to comm

Re: [webkit-dev] Crashes during testing

2010-02-25 Thread Oliver Hunt
But any regressions would have been blamed on eric. webkit-patch land does the correct thing, but i disable the testing prior to commit because a 25 minute delay prior to committing is more or less guaranteed to cause it to fail to commit due to someone else landing. --Oliver On Feb 25,

Re: [webkit-dev] Crashes during testing

2010-02-25 Thread Kenneth Russell
OK, thanks, that appears to have fixed it. How about that commit queue? Would have caught the crashes before they were checked in. -Ken On Thu, Feb 25, 2010 at 2:53 PM, Oliver Hunt wrote: > Update to r55258 or later :D > > --Oliver > > On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote: > >> A

Re: [webkit-dev] Crashes during testing

2010-02-25 Thread Oliver Hunt
Update to r55258 or later :D --Oliver On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote: A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If you have made changes in this area recently, can

Re: [webkit-dev] Crashes during testing

2010-02-25 Thread Oliver Hunt
My bad, fixing now. --Oliver On Feb 25, 2010, at 2:47 PM, Maciej Stachowiak wrote: On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote: A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If y

Re: [webkit-dev] Crashes during testing

2010-02-25 Thread Maciej Stachowiak
On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote: A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If you have made changes in this area recently, can you please look into this? Thanks,

[webkit-dev] Crashes during testing

2010-02-25 Thread Kenneth Russell
A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If you have made changes in this area recently, can you please look into this? Thanks, -Ken Thread 0 Crashed: Dispatch queue: com.apple.main-thr