Re: [webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-24 Thread Steve Block
> I'd rather the mock controller setup be ugly than the typical use of the > controller. Having the > controller and client on Page was quite annoying. I'd much prefer it lived on > Document. I'm fine with moving the controller and client from the Page to the Document. The important thing, as I u

Re: [webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-23 Thread Dean Jackson
On 23/08/2010, at 9:14 PM, Steve Block wrote: >> - it would allow the client to live in WebCore. >> FWIW, Geolocation seems to take both approaches. One implementation is down >> in Navigator/Document/DOMWindow, >> but the mock controller is on Page. I've found the low-level approach much >> ea

Re: [webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-23 Thread Steve Block
> - it would allow the client to live in WebCore. > FWIW, Geolocation seems to take both approaches. One implementation is down > in Navigator/Document/DOMWindow, > but the mock controller is on Page. I've found the low-level approach much > easier to implement. My understanding was that clients

Re: [webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-17 Thread Maciej Stachowiak
On Aug 17, 2010, at 6:50 AM, Dean Jackson wrote: > > On 17/08/2010, at 12:22 AM, Maciej Stachowiak wrote: > >> >> On Aug 16, 2010, at 10:52 PM, Eric Seidel wrote: >> >>> Where-ever it goes, please don't put it on Document directly. :) >>> (Feel free to tie it to Document's lifetime, just don'

Re: [webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-17 Thread Dean Jackson
On 17/08/2010, at 7:21 AM, Eric Seidel wrote: > My apologies for derailing your earlier discussion. I just was in > Document.cpp again yesterday and my mind was blown by the madness that > is that god-class. Then you posted about adding to Document (which > sounds like the right corse of action

Re: [webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-17 Thread Eric Seidel
My apologies for derailing your earlier discussion. I just was in Document.cpp again yesterday and my mind was blown by the madness that is that god-class. Then you posted about adding to Document (which sounds like the right corse of action here!) and I took advantage of your post for my stop-po

Re: [webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-17 Thread Dean Jackson
On 17/08/2010, at 12:22 AM, Maciej Stachowiak wrote: > > On Aug 16, 2010, at 10:52 PM, Eric Seidel wrote: > >> Where-ever it goes, please don't put it on Document directly. :) >> (Feel free to tie it to Document's lifetime, just don't add to >> Document's 300+ methods.) >> >> The madness must

Re: [webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-17 Thread Maciej Stachowiak
On Aug 16, 2010, at 10:52 PM, Eric Seidel wrote: > Where-ever it goes, please don't put it on Document directly. :) > (Feel free to tie it to Document's lifetime, just don't add to > Document's 300+ methods.) > > The madness must stop... Document is long overdue for some weightloss... I assume

Re: [webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-16 Thread Eric Seidel
Where-ever it goes, please don't put it on Document directly. :) (Feel free to tie it to Document's lifetime, just don't add to Document's 300+ methods.) The madness must stop... Document is long overdue for some weightloss... -eric On Mon, Aug 16, 2010 at 11:43 PM, Dean Jackson wrote: > Hi, >

[webkit-dev] DeviceOrientation/Motion on Document rather than Page

2010-08-16 Thread Dean Jackson
Hi, I've been looking into implementing the clients for DeviceOrientation/Motion Events. Currently, the controllers for these events are members of Page. I think they are better suited on Document. Here are a few reasons: - Page isn't tied to any actual web page or document. Would we want to s