[webkit-dev] FYI: sub-pixel layout landing soon

2012-04-23 Thread Levi Weintraub
WebKittens and Unlucky Sheriffs We intend to flip the switch on sub-pixel layout tomorrow morning PST. We apologize in advance for any breakages. See https://trac.webkit.org/wiki/LayoutUnit and http://webkit.org/b/60318 for reference, and feel free to contact Emil (eae) or me (leviw) with any

Re: [webkit-dev] FYI: sub-pixel layout landing soon

2012-04-23 Thread Levi Weintraub
Supporting this would be very logistically intensive and error prone. Beyond huge test expectation differences, hacking on the rendering engine could easily result in bugs in one path or the other. -Levi On Mon, Apr 23, 2012 at 2:31 PM, Adele Peterson ad...@apple.com wrote: Is there an if-def

Re: [webkit-dev] FYI: sub-pixel layout landing soon

2012-04-23 Thread Adele Peterson
We're not prepared to take on this big change in our ports at this time. Without an if-def, I'm not sure how we're going to coordinate flipping the switch at a time that works for everyone. - Adele On Apr 23, 2012, at 2:48 PM, Levi Weintraub wrote: Supporting this would be very logistically

Re: [webkit-dev] FYI: sub-pixel layout landing soon

2012-04-23 Thread Maciej Stachowiak
If it's a global switch that ports can't opt out of, then we have to do this at a time when it wouldn't disrupt anyone's release cycle. Let's say hypothetically a vendor was going to branch from trunk and ship in two weeks (not actually the case for us, but just to make it an extreme example).

Re: [webkit-dev] FYI: sub-pixel layout landing soon

2012-04-23 Thread Levi Weintraub
Given the concerns brought up, we'll be adding an ENABLE_SUBPIXEL_LAYOUT flag that will default to on. Turning this off will continue to use FractionalLayoutUnits, but the fraction will switch to 1/1 from the default of 1/60. This should be ready in the near future, and we'll provide another