Re: [webkit-dev] Fwd: Review queue needs love

2009-06-19 Thread Drew Wilson 
Great, thanks for the responses, all - I feel much better knowing that we're
one big WebKit family :)
I agree that it's a good practice to tag platform-specific bugs, but I
wasn't aware how to do this - I'll make sure I add the appropriate
annotations on any future chrome-specific bugs I submit.

Cheers,

-atw

On Fri, Jun 19, 2009 at 11:54 AM, Maciej Stachowiak  wrote:

>
> On Jun 19, 2009, at 11:46 AM, Maciej Stachowiak wrote:
>
>
> On Jun 19, 2009, at 11:05 AM, Drew Wilson wrote:
>
> I absolutely understand that there are ways to proactively find reviewers,
> and I'm *not* complaining about the time being taken (I understand the
> constraints that most of the webkit reviewers have been under the last few
> weeks with WWDC, etc). As you say, we can always ping people on IRC to find
> reviewers for bugfixes.
> I was more specifically wondering if there was something about this patch
> that made it not show up on the list Eric provided below. My concern is
> because the bugfix came from a google.com address, it might have been
> getting lumped in with the "oh, must be Yet Another Chromium Patch so I
> won't worry about it" list, which if true has troubling implications given
> that there are an increasing number of Googlers that are making
> contributions to WebKit that have nothing to do with Chromium.
>
>
> I try to tag Chromium-specific bugs with [Chromium] in the bug title when I
> go through the review queue, and I know others do as well, so from the fact
> that this bug is not so tagged you can assume we are aware it is a
> cross-platform fix.
>
>
> I should also note, in case this helps assuage your concerns, that many
> cross-platform patches submitted by Google contributors have been reviewed
> by non-Google reviewers, probably the majority of such patches. We
> definitely don't want every company to become an island of review, in fact
> I'd love it if more patches from Apple contributors were reviewed by
> non-Apple reviewers.
>
> Regards,
> Maciej
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Fwd: Review queue needs love

2009-06-19 Thread Maciej Stachowiak 


On Jun 19, 2009, at 11:46 AM, Maciej Stachowiak wrote:



On Jun 19, 2009, at 11:05 AM, Drew Wilson wrote:

I absolutely understand that there are ways to proactively find  
reviewers, and I'm *not* complaining about the time being taken (I  
understand the constraints that most of the webkit reviewers have  
been under the last few weeks with WWDC, etc). As you say, we can  
always ping people on IRC to find reviewers for bugfixes.


I was more specifically wondering if there was something about this  
patch that made it not show up on the list Eric provided below. My  
concern is because the bugfix came from a google.com address, it  
might have been getting lumped in with the "oh, must be Yet Another  
Chromium Patch so I won't worry about it" list, which if true has  
troubling implications given that there are an increasing number of  
Googlers that are making contributions to WebKit that have nothing  
to do with Chromium.


I try to tag Chromium-specific bugs with [Chromium] in the bug title  
when I go through the review queue, and I know others do as well, so  
from the fact that this bug is not so tagged you can assume we are  
aware it is a cross-platform fix.


I should also note, in case this helps assuage your concerns, that  
many cross-platform patches submitted by Google contributors have been  
reviewed by non-Google reviewers, probably the majority of such  
patches. We definitely don't want every company to become an island of  
review, in fact I'd love it if more patches from Apple contributors  
were reviewed by non-Apple reviewers.


Regards,
Maciej

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Fwd: Review queue needs love

2009-06-19 Thread Dimitri Glazkov 
I think this is a great way to distinguish bugs. I just posted on
chromium-dev recommending this.

:DG<

On Fri, Jun 19, 2009 at 11:46 AM, Maciej Stachowiak wrote:
>
> On Jun 19, 2009, at 11:05 AM, Drew Wilson wrote:
>
> I absolutely understand that there are ways to proactively find reviewers,
> and I'm *not* complaining about the time being taken (I understand the
> constraints that most of the webkit reviewers have been under the last few
> weeks with WWDC, etc). As you say, we can always ping people on IRC to find
> reviewers for bugfixes.
> I was more specifically wondering if there was something about this patch
> that made it not show up on the list Eric provided below. My concern is
> because the bugfix came from a google.com address, it might have been
> getting lumped in with the "oh, must be Yet Another Chromium Patch so I
> won't worry about it" list, which if true has troubling implications given
> that there are an increasing number of Googlers that are making
> contributions to WebKit that have nothing to do with Chromium.
>
> I try to tag Chromium-specific bugs with [Chromium] in the bug title when I
> go through the review queue, and I know others do as well, so from the fact
> that this bug is not so tagged you can assume we are aware it is a
> cross-platform fix.
>  - Maciej
>
> -atw
>
> On Fri, Jun 19, 2009 at 10:51 AM, David Levin  wrote:
>>
>> Drew, if you go to http://nightly.webkit.org/start/, then click "Patches
>> awaiting Review".
>> That is the list folks work off of, but it doesn't hurt to figure out the
>> appropriate person to review the patch (find out who has changed the file a
>> lot) and ping them in irc to see if they can get to it.
>> Dave
>>
>> On Fri, Jun 19, 2009 at 10:21 AM, Drew Wilson  wrote:
>>>
>>> I note that this bug fix:
>>> https://bugs.webkit.org/show_bug.cgi?id=23721
>>> ...was not on the list below, and has been waiting for some reviewer love
>>> for a couple of weeks now. Is it falling through the cracks somehow?
>>> -atw
>>>
>>> On Fri, Jun 19, 2009 at 4:18 AM, Andrei Popescu 
>>> wrote:

 Hi,

 On Fri, Jun 19, 2009 at 3:03 AM, Eric Seidel wrote:
 >
 > The other 24 remaining patches consist of 6 Gtk patches, 3 Chromium
 > patches, and a bunch of huge new feature patches.
 >

 No quite. The following two are rather small patches to common code
 (appcache and database):

 https://bugs.webkit.org/show_bug.cgi?id=22700
 https://bugs.webkit.org/show_bug.cgi?id=25711

 I think Alexey promised to look at them.

 Thanks,
 Andrei
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>>
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Fwd: Review queue needs love

2009-06-19 Thread Maciej Stachowiak 


On Jun 19, 2009, at 11:05 AM, Drew Wilson wrote:

I absolutely understand that there are ways to proactively find  
reviewers, and I'm *not* complaining about the time being taken (I  
understand the constraints that most of the webkit reviewers have  
been under the last few weeks with WWDC, etc). As you say, we can  
always ping people on IRC to find reviewers for bugfixes.


I was more specifically wondering if there was something about this  
patch that made it not show up on the list Eric provided below. My  
concern is because the bugfix came from a google.com address, it  
might have been getting lumped in with the "oh, must be Yet Another  
Chromium Patch so I won't worry about it" list, which if true has  
troubling implications given that there are an increasing number of  
Googlers that are making contributions to WebKit that have nothing  
to do with Chromium.


I try to tag Chromium-specific bugs with [Chromium] in the bug title  
when I go through the review queue, and I know others do as well, so  
from the fact that this bug is not so tagged you can assume we are  
aware it is a cross-platform fix.


 - Maciej



-atw

On Fri, Jun 19, 2009 at 10:51 AM, David Levin   
wrote:
Drew, if you go to http://nightly.webkit.org/start/, then click  
"Patches awaiting Review".


That is the list folks work off of, but it doesn't hurt to figure  
out the appropriate person to review the patch (find out who has  
changed the file a lot) and ping them in irc to see if they can get  
to it.


Dave


On Fri, Jun 19, 2009 at 10:21 AM, Drew Wilson   
wrote:

I note that this bug fix:

https://bugs.webkit.org/show_bug.cgi?id=23721

...was not on the list below, and has been waiting for some reviewer  
love for a couple of weeks now. Is it falling through the cracks  
somehow?


-atw


On Fri, Jun 19, 2009 at 4:18 AM, Andrei Popescu   
wrote:

Hi,

On Fri, Jun 19, 2009 at 3:03 AM, Eric Seidel wrote:
>
> The other 24 remaining patches consist of 6 Gtk patches, 3 Chromium
> patches, and a bunch of huge new feature patches.
>

No quite. The following two are rather small patches to common code
(appcache and database):

https://bugs.webkit.org/show_bug.cgi?id=22700
https://bugs.webkit.org/show_bug.cgi?id=25711

I think Alexey promised to look at them.

Thanks,
Andrei
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Fwd: Review queue needs love

2009-06-19 Thread Oliver Hunt 


On Jun 19, 2009, at 11:05 AM, Drew Wilson wrote:

I absolutely understand that there are ways to proactively find  
reviewers, and I'm *not* complaining about the time being taken (I  
understand the constraints that most of the webkit reviewers have  
been under the last few weeks with WWDC, etc). As you say, we can  
always ping people on IRC to find reviewers for bugfixes.


I was more specifically wondering if there was something about this  
patch that made it not show up on the list Eric provided below. My  
concern is because the bugfix came from a google.com address, it  
might have been getting lumped in with the "oh, must be Yet Another  
Chromium Patch so I won't worry about it" list, which if true has  
troubling implications given that there are an increasing number of  
Googlers that are making contributions to WebKit that have nothing  
to do with Chromium.


The source of a patch does not effect whether it gets reviewed, but if  
a patch is for a specific port you need someone from that port to  
review it.  If the bug/patch contains "Chromium" i assume it's  
platform specific, just as i would for Gtk or Qt.  If you're putting  
that tag on non-platform specific patches that will unnecessarily  
delay the review process.


--Oliver

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Fwd: Review queue needs love

2009-06-19 Thread Adam Treat 
On Friday 19 June 2009 02:05:23 pm Drew Wilson wrote:
> I was more specifically wondering if there was something about this patch
> that made it not show up on the list Eric provided below. My concern is
> because the bugfix came from a google.com address, it might have been
> getting lumped in with the "oh, must be Yet Another Chromium Patch so I
> won't worry about it" list, which if true has troubling implications given
> that there are an increasing number of Googlers that are making
> contributions to WebKit that have nothing to do with Chromium.

Your concern seems rather odd given that Eric is a Google employee.  Moreover, 
the link that started this thread was given by Maciej and your bug is indeed 
found in that list:

https://bugs.webkit.org/buglist.cgi?field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=review%3F

Cheers,
Adam

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Fwd: Review queue needs love

2009-06-19 Thread Drew Wilson 
I absolutely understand that there are ways to proactively find reviewers,
and I'm *not* complaining about the time being taken (I understand the
constraints that most of the webkit reviewers have been under the last few
weeks with WWDC, etc). As you say, we can always ping people on IRC to find
reviewers for bugfixes.
I was more specifically wondering if there was something about this patch
that made it not show up on the list Eric provided below. My concern is
because the bugfix came from a google.com address, it might have been
getting lumped in with the "oh, must be Yet Another Chromium Patch so I
won't worry about it" list, which if true has troubling implications given
that there are an increasing number of Googlers that are making
contributions to WebKit that have nothing to do with Chromium.

-atw

On Fri, Jun 19, 2009 at 10:51 AM, David Levin  wrote:

> Drew, if you go to http://nightly.webkit.org/start/, then click "*Patches
> awaiting Review ".*
> *
> That is the list folks work off of, but it doesn't hurt to figure out the
> appropriate person to review the patch (find out who has changed the file a
> lot) and ping them in irc to see if they can get to it.
>
> Dave
>
>
> *
> On Fri, Jun 19, 2009 at 10:21 AM, Drew Wilson  wrote:
>
>> I note that this bug fix:
>> https://bugs.webkit.org/show_bug.cgi?id=23721
>>
>> ...was not on the list below, and has been waiting for some reviewer love
>> for a couple of weeks now. Is it falling through the cracks somehow?
>>
>> -atw
>>
>>
>> On Fri, Jun 19, 2009 at 4:18 AM, Andrei Popescu wrote:
>>
>>> Hi,
>>>
>>> On Fri, Jun 19, 2009 at 3:03 AM, Eric Seidel wrote:
>>> >
>>> > The other 24 remaining patches consist of 6 Gtk patches, 3 Chromium
>>> > patches, and a bunch of huge new feature patches.
>>> >
>>>
>>> No quite. The following two are rather small patches to common code
>>> (appcache and database):
>>>
>>> https://bugs.webkit.org/show_bug.cgi?id=22700
>>> https://bugs.webkit.org/show_bug.cgi?id=25711
>>>
>>> I think Alexey promised to look at them.
>>>
>>> Thanks,
>>> Andrei
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>
>>
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Fwd: Review queue needs love

2009-06-19 Thread David Levin 
Drew, if you go to http://nightly.webkit.org/start/, then click "*Patches
awaiting Review ".*
*
That is the list folks work off of, but it doesn't hurt to figure out the
appropriate person to review the patch (find out who has changed the file a
lot) and ping them in irc to see if they can get to it.

Dave


*On Fri, Jun 19, 2009 at 10:21 AM, Drew Wilson  wrote:

> I note that this bug fix:
> https://bugs.webkit.org/show_bug.cgi?id=23721
>
> ...was not on the list below, and has been waiting for some reviewer love
> for a couple of weeks now. Is it falling through the cracks somehow?
>
> -atw
>
>
> On Fri, Jun 19, 2009 at 4:18 AM, Andrei Popescu wrote:
>
>> Hi,
>>
>> On Fri, Jun 19, 2009 at 3:03 AM, Eric Seidel wrote:
>> >
>> > The other 24 remaining patches consist of 6 Gtk patches, 3 Chromium
>> > patches, and a bunch of huge new feature patches.
>> >
>>
>> No quite. The following two are rather small patches to common code
>> (appcache and database):
>>
>> https://bugs.webkit.org/show_bug.cgi?id=22700
>> https://bugs.webkit.org/show_bug.cgi?id=25711
>>
>> I think Alexey promised to look at them.
>>
>> Thanks,
>> Andrei
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Fwd: Review queue needs love

2009-06-19 Thread Drew Wilson 
I note that this bug fix:
https://bugs.webkit.org/show_bug.cgi?id=23721

...was not on the list below, and has been waiting for some reviewer love
for a couple of weeks now. Is it falling through the cracks somehow?

-atw

On Fri, Jun 19, 2009 at 4:18 AM, Andrei Popescu  wrote:

> Hi,
>
> On Fri, Jun 19, 2009 at 3:03 AM, Eric Seidel wrote:
> >
> > The other 24 remaining patches consist of 6 Gtk patches, 3 Chromium
> > patches, and a bunch of huge new feature patches.
> >
>
> No quite. The following two are rather small patches to common code
> (appcache and database):
>
> https://bugs.webkit.org/show_bug.cgi?id=22700
> https://bugs.webkit.org/show_bug.cgi?id=25711
>
> I think Alexey promised to look at them.
>
> Thanks,
> Andrei
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Fwd: Review queue needs love

2009-06-19 Thread Andrei Popescu 
Hi,

On Fri, Jun 19, 2009 at 3:03 AM, Eric Seidel wrote:
>
> The other 24 remaining patches consist of 6 Gtk patches, 3 Chromium
> patches, and a bunch of huge new feature patches.
>

No quite. The following two are rather small patches to common code
(appcache and database):

https://bugs.webkit.org/show_bug.cgi?id=22700
https://bugs.webkit.org/show_bug.cgi?id=25711

I think Alexey promised to look at them.

Thanks,
Andrei
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Fwd: Review queue needs love

2009-06-18 Thread Eric Seidel 
Oh how I wish that my @webkit.org address and gmail would get along...

-eric

-- Forwarded message --
From: Eric Seidel 
Date: Thu, Jun 18, 2009 at 7:02 PM
Subject: Re: [webkit-dev] Review queue needs love
To: Adam Treat 
Cc: webkit-dev@lists.webkit.org


I've gone through the queue again now.  4 of them nee Hyatt's attention:
https://bugs.webkit.org/show_bug.cgi?id=26156
https://bugs.webkit.org/show_bug.cgi?id=26120
https://bugs.webkit.org/show_bug.cgi?id=25072
https://bugs.webkit.org/show_bug.cgi?id=21462

4 of the remaining bugs are from me! :)
https://bugs.webkit.org/show_bug.cgi?id=25494
https://bugs.webkit.org/show_bug.cgi?id=25922
https://bugs.webkit.org/show_bug.cgi?id=25916
https://bugs.webkit.org/show_bug.cgi?id=26283

The other 24 remaining patches consist of 6 Gtk patches, 3 Chromium
patches, and a bunch of huge new feature patches.

-eric

On Thu, Jun 18, 2009 at 4:21 PM, Adam Treat wrote:
> On Thursday 18 June 2009 05:39:04 pm Oliver Hunt wrote:
>> I reviewed quite a few last night as well.  At the moment there appear
>> to be a large number of chromium, gtk, and qt specific patches up for
>> review -- it would be great if reviewers for those ports went through
>> them all :D
>
> I went through all the Qt ones today after Maciej made his request.  I think
> there is only one outstanding Qt related one at the moment...
>
> Adam
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev