Re: [webkit-dev] Is it OK to remove Frame::setIsDisconnected() and isDisconnected() ?

2012-04-09 Thread Adam Barth
On Mon, Apr 9, 2012 at 3:24 PM, Maciej Stachowiak wrote: > On Apr 9, 2012, at 12:27 PM, Adam Barth wrote: >> On Wed, Apr 15, 2009 at 2:21 PM, Maciej Stachowiak wrote: >>> On Apr 15, 2009, at 1:29 PM, Sverrir Á. Berg wrote: Hi Adam, Thanks for the links.  These are simply exposing the fu

Re: [webkit-dev] Is it OK to remove Frame::setIsDisconnected() and isDisconnected() ?

2012-04-09 Thread Maciej Stachowiak
On Apr 9, 2012, at 12:27 PM, Adam Barth wrote: > On Wed, Apr 15, 2009 at 2:21 PM, Maciej Stachowiak wrote: >> On Apr 15, 2009, at 1:29 PM, Sverrir Á. Berg wrote: >>> Hi Adam, >>> Thanks for the links. These are simply exposing the functions as a formal a >>> API's. I understand that you typica

Re: [webkit-dev] Is it OK to remove Frame::setIsDisconnected() and isDisconnected() ?

2012-04-09 Thread Adam Barth
On Wed, Apr 15, 2009 at 2:21 PM, Maciej Stachowiak wrote: >On Apr 15, 2009, at 1:29 PM, Sverrir Á. Berg wrote: >> Hi Adam, >> Thanks for the links.  These are simply exposing the functions as a formal a >> API's.  I understand that you typically don't want to change externally >> exposed API's but

Re: [webkit-dev] Is it OK to remove Frame::setIsDisconnected() and isDisconnected() ?

2009-04-15 Thread Maciej Stachowiak
On Apr 15, 2009, at 1:29 PM, Sverrir Á. Berg wrote: Hi Adam, Thanks for the links. These are simply exposing the functions as a formal a API's. I understand that you typically don't want to change externally exposed API's but these can easily be stubbed out (or removed). I should have p

Re: [webkit-dev] Is it OK to remove Frame::setIsDisconnected() and isDisconnected() ?

2009-04-15 Thread Sverrir Á . Berg
Hi Adam,Thanks for the links. These are simply exposing the functions as a formal a API's. I understand that you typically don't want to change externally exposed API's but these can easily be stubbed out (or removed). I should have pointed out in my original email that I have tried to remove the

Re: [webkit-dev] Is it OK to remove Frame::setIsDisconnected() and isDisconnected() ?

2009-04-15 Thread Adam Roben
On Apr 15, 2009, at 3:48 PM, Sverrir Á. Berg wrote: Working on a change in FrameTree and noticed that the checks in top() and parent() for 'checkForDisconnectedFrame' rely on a flag in Frame that as far as I can tell is never set. So my naive question is: Can I remove the corresponding code f

[webkit-dev] Is it OK to remove Frame::setIsDisconnected() and isDisconnected() ?

2009-04-15 Thread Sverrir Á . Berg
Working on a change in FrameTree and noticed that the checks in top() and parent() for 'checkForDisconnectedFrame' rely on a flag in Frame that as far as I can tell is never set.So my naive question is: Can I remove the corresponding code from Frame and FrameTree? If not I would like if somebody c