Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Roland Steiner
Sorry for the late reply, this thread flew under my radar. I made the original name change, because I honestly was entirely confused about the meaning of selfOnlyRef (it's done by Node on Document, so what is self? Why is it needed?) - so I guess we'll have to agree to disagree which one is

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Darin Adler
On Jun 15, 2012, at 12:12 AM, Roland Steiner wrote: I made the original name change, because I honestly was entirely confused about the meaning of selfOnlyRef (it's done by Node on Document, so what is self? Why is it needed?) A good rule of thumb, the one that I use, is that a name like

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Ryosuke Niwa
On Fri, Jun 15, 2012 at 9:30 AM, Darin Adler da...@apple.com wrote: On Jun 15, 2012, at 12:12 AM, Roland Steiner wrote: I made the original name change, because I honestly was entirely confused about the meaning of selfOnlyRef (it's done by Node on Document, so what is self? Why is it

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Darin Adler
On Jun 15, 2012, at 9:47 AM, Ryosuke Niwa wrote: // Nodes belonging to this document hold guard references - // these are enough to keep the document from being destroyed, but // not enough to keep it from removing its children. This allows a // node that outlives its document to still have a

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Maciej Stachowiak
On Jun 15, 2012, at 12:12 AM, Roland Steiner rolandstei...@google.com wrote: Sorry for the late reply, this thread flew under my radar. I made the original name change, because I honestly was entirely confused about the meaning of selfOnlyRef (it's done by Node on Document, so what is

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Ryosuke Niwa
On Fri, Jun 15, 2012 at 9:49 AM, Darin Adler da...@apple.com wrote: On Jun 15, 2012, at 9:47 AM, Ryosuke Niwa wrote: // Nodes belonging to this document hold guard references - // these are enough to keep the document from being destroyed, but // not enough to keep it from removing its

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Darin Adler
On Jun 15, 2012, at 10:15 AM, Maciej Stachowiak m...@apple.com wrote: But it's hard to explain fully in a function name w/o excess verbosity. I think my favorite excess verbosity version is refDocumentButNotOtherNodes. -- Darin ___ webkit-dev mailing

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Maciej Stachowiak
On Jun 15, 2012, at 10:31 AM, Darin Adler da...@apple.com wrote: On Jun 15, 2012, at 10:15 AM, Maciej Stachowiak m...@apple.com wrote: But it's hard to explain fully in a function name w/o excess verbosity. I think my favorite excess verbosity version is refDocumentButNotOtherNodes.

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Ryosuke Niwa
On Fri, Jun 15, 2012 at 12:14 PM, Maciej Stachowiak m...@apple.com wrote: I am not sure how to get the key points across without being accurate or misleading. A version that I think explains the complete design without saying anything false or misleading:

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Maciej Stachowiak
On Jun 15, 2012, at 12:22 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Jun 15, 2012 at 12:14 PM, Maciej Stachowiak m...@apple.com wrote: I am not sure how to get the key points across without being accurate or misleading. A version that I think explains the complete design without

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-15 Thread Ryosuke Niwa
On Fri, Jun 15, 2012 at 12:40 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 15, 2012, at 12:22 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Jun 15, 2012 at 12:14 PM, Maciej Stachowiak m...@apple.com wrote: I am not sure how to get the key points across without being accurate or

[webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

2012-06-11 Thread Maciej Stachowiak
On Jun 11, 2012, at 6:06 PM, Maciej Stachowiak m...@apple.com wrote: not a self-only reference (at some point renamed to guardRef). BTW I was able to find where it was renamed but not a good explanation of why. I think selfOnlyRef() was a much clearer name. The history seems to be that it