Thanks a lot for the review! The patch has landed and should be a much
cleaner foundation for generated content (which may also have to be
overlapped).
Speaking of general ruby text enhancements: there is a new bug
https://bugs.webkit.org/show_bug.cgi?id=47596 regarding the ruby display
types. The
Seeing that this is progressing ad a quick pace, could I entice some kind
reviewer to r+ my patch for bug
https://bugs.webkit.org/show_bug.cgi?id=41040 before I get (another...)
mid-air collision?
^_^; Roland
On Wed, Oct 6, 2010 at 5:34 PM, Eric Mader wrote:
>
> On Oct 5, 2010, at 6:25 PM, Dav
On Oct 5, 2010, at 6:25 PM, David Hyatt wrote:
> On Oct 5, 2010, at 7:33 PM, Eric Mader wrote:
>
>>
>> On Sep 24, 2010, at 8:02 PM, David Hyatt wrote:
>>
>>> This is a tough problem. It seems like you have to get involved in the
>>> line layout code e.g., findNextLineBreak in order to really
On Oct 5, 2010, at 7:33 PM, Eric Mader wrote:
>
> On Sep 24, 2010, at 8:02 PM, David Hyatt wrote:
>
>> This is a tough problem. It seems like you have to get involved in the line
>> layout code e.g., findNextLineBreak in order to really do the right thing.
>> findNextLineBreak uses an iterat
On Sep 24, 2010, at 8:02 PM, David Hyatt wrote:
> This is a tough problem. It seems like you have to get involved in the line
> layout code e.g., findNextLineBreak in order to really do the right thing.
> findNextLineBreak uses an iterator that walks the objects, so it's easier to
> tell wha
Thanks. Looks like hooking findNextLineBreak is something we should try.
- kida
On 2010/09/28, at 12:56, David Hyatt wrote:
> On Sep 28, 2010, at 12:20 PM, Yasuo Kida wrote:
>
>>
>> On 2010/09/28, at 10:11, David Hyatt wrote:
>>> On Sep 27, 2010, at 3:40 PM, Eric Mader wrote:
Are you sayi
On Sep 28, 2010, at 12:20 PM, Yasuo Kida wrote:
>
> On 2010/09/28, at 10:11, David Hyatt wrote:
>> On Sep 27, 2010, at 3:40 PM, Eric Mader wrote:
>>> Are you saying that subclassing computeLogicalWidth() would still mean that
>>> I'm computing the margins at the initial calculation time?
>>
>>
On Sep 28, 2010, at 7:11 AM, David Hyatt wrote:
>>> "The ruby element allows one or more spans of phrasing content to be marked
>>> with ruby annotations."
>>>
> * That the text for the ruby text and ruby base are always the direct
> child of the RenderRubyText and RenderRubyBase objec
On 2010/09/28, at 10:11, David Hyatt wrote:
> On Sep 27, 2010, at 3:40 PM, Eric Mader wrote:
>> Are you saying that subclassing computeLogicalWidth() would still mean that
>> I'm computing the margins at the initial calculation time?
>
> You'd be computing them whenever the ruby run's layout cha
On Sep 27, 2010, at 3:40 PM, Eric Mader wrote:
>
> Are you saying that subclassing computeLogicalWidth() would still mean that
> I'm computing the margins at the initial calculation time?
>
You'd be computing them whenever the ruby run's layout changed. The problem
with that is if you're set
A generic question: is there any in-depth documentation I can ready about block
layout and how the various methods are supposed to be used? I've looked at the
technical articles at http://webkit.org/coding/technical-articles.html but they
seem to only have fairly high-level information and left
On Sep 21, 2010, at 7:16 PM, Roland Steiner wrote:
> Hi Eric,
>
> comments inline:
>
> On Wed, Sep 22, 2010 at 6:57 AM, Eric Mader wrote:
>
> On Sep 20, 2010, at 9:52 PM, Roland Steiner wrote:
>> Oh vey, that's ambituous! :) There's so many corner cases I foresee on this
>> one that I was
Hi Eric,
comments inline:
On Wed, Sep 22, 2010 at 6:57 AM, Eric Mader wrote:
>
> On Sep 20, 2010, at 9:52 PM, Roland Steiner wrote:
>
> Oh vey, that's ambituous! :) There's so many corner cases I foresee on
> this one that I was just too happy to postpone it when we originally
> discussed to l
On Sep 20, 2010, at 9:52 PM, Roland Steiner wrote:
> Great to see someone else interested in doing ruby implementation! :)
>
> I did the original ruby implementation, so I'm very happy to help with any
> questions/problems/issues (bugs? there are not bugs!). BTW, please note that
> there is a
On Sep 21, 2010, at 2:52 AM, Roland Steiner wrote:
>
>
>
> We'd probably need to add a new value to that property if Ruby is supposed to
> be skipped.
>
> Ergh Looking at it, I'm not sure that's a good proposal at all - at least
> it has still lots to address (it doesn't address list bu
Great to see someone else interested in doing ruby implementation! :)
I did the original ruby implementation, so I'm very happy to help with any
questions/problems/issues (bugs? there are not bugs!). BTW, please note that
there is another ruby patch in the review pipeline:
https://bugs.webkit.org/
On Mon, Sep 20, 2010 at 11:12 AM, David Hyatt wrote:
>
>
> This is going to be tricky. You basically want to walk the line box tree
> rather than the renderobject tree and then look at surrounding text.
>
> > About turning off the underline if the ruby is in a link: I've looked at
> the styles and
On Sep 17, 2010, at 8:07 PM, Eric Mader wrote:
> Hi,
>
> I'm working on making the following enhancements to Ruby Text:
>
> 1) Implement the behavior of ruby-overhang:auto
>
> 2) implement the behavior of ruby-line-stacking:exclude-ruby
>
> 3) Add some Mac OS specific character properties to t
Hi,
I'm working on making the following enhancements to Ruby Text:
1) Implement the behavior of ruby-overhang:auto
2) implement the behavior of ruby-line-stacking:exclude-ruby
3) Add some Mac OS specific character properties to the ruby text
4) Turn off the underline when the ruby text is in a
19 matches
Mail list logo
