Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-26 Thread David Hyatt
On Oct 22, 2009, at 4:38 PM, Evan Martin wrote: On Mon, Oct 19, 2009 at 1:22 PM, David Hyatt wrote: I've actually been super frustrated with WebKit's selection behavior for a long time, precisely because it tries to let you select everything. In Concrete examples of where something weird

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-22 Thread Evan Martin
On Thu, Oct 22, 2009 at 4:22 PM, Maciej Stachowiak wrote: > Seems like a bug to me. Selection draws over content that won't get copied. > You also get some double-drawn selection if you Select All on the webkit.org > front page. Please file. https://bugs.webkit.org/show_bug.cgi?id=30694 _

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-22 Thread Maciej Stachowiak
On Oct 22, 2009, at 2:38 PM, Evan Martin wrote: On Mon, Oct 19, 2009 at 1:22 PM, David Hyatt wrote: I've actually been super frustrated with WebKit's selection behavior for a long time, precisely because it tries to let you select everything. In Concrete examples of where something weir

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-22 Thread Ben Goodger
On Thu, Oct 22, 2009 at 2:48 PM, Peter Kasting wrote: > On Thu, Oct 22, 2009 at 2:37 PM, Evan Martin wrote: > >> This likely isn't what PK was talking about, but it's a good example >> in its irony. Try selecting a paragraph on the front page of >> webkit.org; you'll see weird gap painting over

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-22 Thread Peter Kasting
On Thu, Oct 22, 2009 at 2:37 PM, Evan Martin wrote: > This likely isn't what PK was talking about, but it's a good example > in its irony. Try selecting a paragraph on the front page of > webkit.org; you'll see weird gap painting over the navbar on the left. > Ben has suggested to me that this

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-22 Thread Evan Martin
On Mon, Oct 19, 2009 at 1:22 PM, David Hyatt wrote: > > I've actually been super frustrated with WebKit's selection behavior for a > > long time, precisely because it tries to let you select everything. In > > Concrete examples of where something weird happens would be helpful. The > gap code is

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-20 Thread Maciej Stachowiak
On Oct 19, 2009, at 2:03 PM, Peter Kasting wrote: On Mon, Oct 19, 2009 at 1:58 PM, Joe Mason wrote: Perhaps the browser should have "Copy text" and "Copy all objects" options (in which case either WebKit needs to support both modes, or the browser would need to filter the copied data). Yes, t

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:58 PM, Joe Mason wrote: > Perhaps the browser should have "Copy text" and "Copy all objects" > options (in which case either WebKit needs to support both modes, or > the browser would need to filter the copied data). Yes, that could help. Filed crbug.com/25239. PK __

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:55 PM, Pam Greene wrote: > On Mon, Oct 19, 2009 at 1:43 PM, Peter Kasting wrote: > >> On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher wrote: >> >>> I think there is a good use case for copying a selection of HTML from any >>> web page and pasting that into the rich text e

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Pam Greene
On Mon, Oct 19, 2009 at 1:43 PM, Peter Kasting wrote: > On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher wrote: > >> I think there is a good use case for copying a selection of HTML from any >> web page and pasting that into the rich text editor of a web mail program. >> > > I agree, but that case

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Timothy Hatcher
On Oct 19, 2009, at 1:43 PM, Peter Kasting wrote: Note that within Chrome we put in ctrl-shift-v to "paste as plain text" precisely because of issues like this. Most other programs don't have that option though (and even in Chrome it's hard to discover). I guess it isn't exactly what you

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Timothy Hatcher
On Oct 19, 2009, at 1:43 PM, Peter Kasting wrote: Note that within Chrome we put in ctrl-shift-v to "paste as plain text" precisely because of issues like this. Most other programs don't have that option though (and even in Chrome it's hard to discover). On Mac we call this "Paste and Ma

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:45 PM, David Hyatt wrote: > On Oct 19, 2009, at 3:37 PM, Peter Kasting wrote: > > The only time non-text should be copied is when it is part of a rich text > area. In that case copying rich content makes sense. > > > Ok, well we fundamentally disagree on this point, so

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Darin Fisher
On Mon, Oct 19, 2009 at 1:43 PM, Peter Kasting wrote: > On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher wrote: > >> I think there is a good use case for copying a selection of HTML from any >> web page and pasting that into the rich text editor of a web mail program. >> > > I agree, but that case

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread David Hyatt
On Oct 19, 2009, at 3:37 PM, Peter Kasting wrote: On Mon, Oct 19, 2009 at 1:31 PM, David Hyatt wrote: You aren't only selecting text on a page though. For example, copying can be of all the HTML content. This includes tables, images, plugins, etc. If you don't highlight that content, th

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher wrote: > I think there is a good use case for copying a selection of HTML from any > web page and pasting that into the rich text editor of a web mail program. > I agree, but that case does not degrade badly when you only copy the text, whereas if th

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Darin Fisher
On Mon, Oct 19, 2009 at 1:37 PM, Peter Kasting wrote: > On Mon, Oct 19, 2009 at 1:31 PM, David Hyatt wrote: > >> You aren't only selecting text on a page though. For example, copying can >> be of all the HTML content. This includes tables, images, plugins, etc. >> If you don't highlight that c

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:31 PM, David Hyatt wrote: > You aren't only selecting text on a page though. For example, copying can > be of all the HTML content. This includes tables, images, plugins, etc. > If you don't highlight that content, then you're lying about what gets > copied. > No, you

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread David Hyatt
On Oct 19, 2009, at 3:27 PM, Peter Kasting wrote: On Mon, Oct 19, 2009 at 1:21 PM, David Hyatt wrote: On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote: I'm not quite sure what you mean. Do you just mean it looks visually confusing, but when you copy/paste you get the right text? Or are yo

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:21 PM, David Hyatt wrote: > On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote: > I'm not quite sure what you mean. Do you just mean it looks visually > confusing, but when you copy/paste you get the right text? Or are you > saying that it's actually selecting the wrong

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread David Hyatt
On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote: On Mon, Oct 19, 2009 at 1:10 PM, David Hyatt wrote: I can get how editing in text fields you might feel a desire to match the platform (where ragged selection may be the convention), but once you get into rich text selection (images, floats,

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread David Hyatt
On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote: On Mon, Oct 19, 2009 at 1:10 PM, David Hyatt wrote: I can get how editing in text fields you might feel a desire to match the platform (where ragged selection may be the convention), but once you get into rich text selection (images, floats,

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Evan Martin
On Mon, Oct 19, 2009 at 1:13 PM, Ben Goodger wrote: > To me, it looks ugly to have a ragged edge if you can avoid it. Dave > did a great job making it look nice in WebKit. I don't have a strong > feeling on Linux so if people feel strongly there whatever. But on > Windows Chrome I want to retain t

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Peter Kasting
On Mon, Oct 19, 2009 at 1:10 PM, David Hyatt wrote: > I can get how editing in text fields you might feel a desire to match the > platform (where ragged selection may be the convention), but once you get > into rich text selection (images, floats, tables, columns, etc.), there > really is no plat

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Ben Goodger
To me, it looks ugly to have a ragged edge if you can avoid it. Dave did a great job making it look nice in WebKit. I don't have a strong feeling on Linux so if people feel strongly there whatever. But on Windows Chrome I want to retain the solid edge. Maybe there are ways the solid edge can be imp

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread David Hyatt
On Oct 19, 2009, at 3:03 PM, Ben Goodger wrote: I agree. I would like to retain this mode of selection in Windows Chrome at least. I think it's only ragged in most apps because people don't take the time to make it look nice. -Ben Yeah, when it comes to complex Web page selection, I don't thi

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Jeremy Orlow
FYI, this was filed some time ago: http://code.google.com/p/chromium/issues/detail?id=3527 https://bugs.webkit.org/show_bug.cgi?id=21960 On Mon, Oct 19, 2009 at 1:03 PM, Ben Goodger wrote: > I agree. I would like to retain this mode of selection in Windows > Chrome at least. I think it's only ra

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread Ben Goodger
I agree. I would like to retain this mode of selection in Windows Chrome at least. I think it's only ragged in most apps because people don't take the time to make it look nice. -Ben On Mon, Oct 19, 2009 at 12:57 PM, David Hyatt wrote: > On Oct 16, 2009, at 7:07 PM, Evan Martin wrote: > >> When

Re: [webkit-dev] Selection highlight painting ("gaps"?)

2009-10-19 Thread David Hyatt
On Oct 16, 2009, at 7:07 PM, Evan Martin wrote: When you select multiple lines of text in WebKit, the highlight paints over whitespace on the right margin. This is correct behavior for Mac, but not for Windows or Linux. I would suggest making it be controlled by a Setting rather than #ifdef

[webkit-dev] Selection highlight painting ("gaps"?)

2009-10-16 Thread Evan Martin
When you select multiple lines of text in WebKit, the highlight paints over whitespace on the right margin. This is correct behavior for Mac, but not for Windows or Linux. Epiphany (using WebKitGtk) does it Linux style, but my best efforts to trace through the code have found no ifdefs related to