Re: [webkit-dev] Why is gtest in the Source directory?

2011-05-12 Thread David Levin
On Thu, May 12, 2011 at 11:33 AM, David Levin wrote: > > > On Thu, May 12, 2011 at 10:36 AM, Adam Barth wrote: > >> Here's a straw-man proposal: >> >> Tests/ > > -- All testing code. Do test harnesses go here too? > > Layout/ # Would be nice to have a better name since these test much >> mor

Re: [webkit-dev] Why is gtest in the Source directory?

2011-05-12 Thread Kevin Ollivier
On May 12, 2011, at 11:48 AM, Darin Adler wrote: > On May 12, 2011, at 11:33 AM, David Levin wrote: > >> Layout/ # Would be nice to have a better name since these test much >> more than Layout >> >> DumpRenderTreeTests? >> Integration? >> AutomatedHtmlTests? > > Here are some characteristics

Re: [webkit-dev] Why is gtest in the Source directory?

2011-05-12 Thread Ilya Tikhonovsky
Functional? Regards, Tim. On Thu, May 12, 2011 at 10:48 PM, Darin Adler wrote: > On May 12, 2011, at 11:33 AM, David Levin wrote: > > Layout/ # Would be nice to have a better name since these test much >> more than Layout >> > > DumpRenderTreeTests? > Integration? > AutomatedHtmlTests? > > >

Re: [webkit-dev] Why is gtest in the Source directory?

2011-05-12 Thread Darin Adler
On May 12, 2011, at 11:33 AM, David Levin wrote: > Layout/ # Would be nice to have a better name since these test much > more than Layout > > DumpRenderTreeTests? > Integration? > AutomatedHtmlTests? Here are some characteristics of these tests that may help us name the directory: 1) Thi

Re: [webkit-dev] Why is gtest in the Source directory?

2011-05-12 Thread David Levin
On Thu, May 12, 2011 at 10:36 AM, Adam Barth wrote: > Here's a straw-man proposal: > > Tests/ -- All testing code. Do test harnesses go here too? Layout/ # Would be nice to have a better name since these test much > more than Layout > DumpRenderTreeTests? Integration? AutomatedHtmlTests?

Re: [webkit-dev] Why is gtest in the Source directory?

2011-05-12 Thread Adam Barth
Here's a straw-man proposal: Tests/ Layout/ # Would be nice to have a better name since these test much more than Layout Performance/ Unit/ Manual/ Source/ JavaScriptCore/ WebCore/ WebKit/ ThirdParty/ ANGLE/ Tools/ WebKitTestRunner/ MiniBrowser/ Scripts/ In this organiz

Re: [webkit-dev] Why is gtest in the Source directory?

2011-05-12 Thread Dmitry Lomov
I think more important issue to consider is should WebKit unit-tests (TestWebKitAPI) live under Tools. Unit-tests evolve with the product and an organic part of it - it doesn't feel that they constitute a "tool". Three possible locations come to mind: - ./Tests - separate top-level directory, sibl

Re: [webkit-dev] Why is gtest in the Source directory?

2011-05-12 Thread David Levin
It sounds like you have a helpful mental mapping for what belongs in each directory that we haven't written anywhere. Perhaps you could write it down and send it to webkit-dev so that we can make it a common model. It feels like a related topic is why are the unit tests under Tools as opposed to

[webkit-dev] Why is gtest in the Source directory?

2011-05-12 Thread Dan Bernstein
Is gtest required to build any of the WebKit ports? If not, can it be moved out of Source and into Tools? Thanks, —Dan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev